Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 6, 2002:

3:17 PM Changeset in webkit [2262] by darin

• 4 edits in trunk/JavaScriptCore

I noticed some broken lists at mapblast.com and tracked it down to this.

• kjs/array_object.cpp: (ArrayInstanceImp::put): Don't truncate the list; only extend the length if it's not already long enough. (ArrayProtoFuncImp::call): Fix some ifdef'd code so it compiles if you turn the ifdefs on.

12:23 PM Changeset in webkit [2261] by darin

• 4 edits in trunk/WebCore

• fixed 3046737 -- infinite loop in font name matching code on some pages

• kwq/KWQString.mm: (QString::replace): Removed the incorrect early exit if the passed in string was the empty string.

Oct 5, 2002:

8:27 AM Changeset in webkit [2260] by darin

• 3 edits in trunk/WebKit

• fixed 3068323 -- nil object inserted in dictionary exception on mouse move

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Add some assertions in the hope of finding if my assumptions about this are wrong, and use the version of the dictionary setter that does nothing if it's passed nil when putting in the frame found by name.

Oct 4, 2002:

10:58 PM Changeset in webkit [2259] by darin

• 4 edits in trunk/WebCore

Tests:

• harness.c: (main): Stop using debug versions of frameworks. This was causing us problems we'd see only in the test programs, and we didn't see the text of the asserts. We can turn this back on again if we make it so we can see what's wrong.

• WebFoundation-Misc/ifnsurlextensions-test.chk: Update for new expected results that handle "../" properly.

• kde/kurl-test.chk: Update for canonicalization, which was added a while back without updating this test.

WebFoundation:

• fixed 3064420 -- NSURLExtras function does not resolve "../" URLs at top level the way the web expects

• Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithString:relativeToURL:]): Added code to detect URL results that have paths that start with /../ and remove the extra levels. Tested with the Tests directory.

• English.lproj/StringsNotToBeLocalized.txt: Added the string used as a localization exception.

WebCore:

• kwq/KWQKURL.mm: (KURL::parse): Fix code that adds "" to file URLs. The code was including the extra slashes as part of the path, which they are not. Verified with the tests in the Tests directory.

9:34 PM Changeset in webkit [2258] by darin

• 3 edits in trunk/WebKit

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Add a couple more localization exceptions for newly added strings.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Add a localization exception for the WebKit bundle identifier.

9:28 PM Changeset in webkit [2257] by darin

• 3 edits
  1 add in trunk/WebKit

WebFoundation:

• Misc.subproj/WebLocalizableStrings.h: Implement the real version of the UI_STRING macro. It uses the FRAMEWORK_NAME preprocessor define to find the appropriate bundle global, and passes that along with the key into the WebLocalizedString function.
• Misc.subproj/WebLocalizableStrings.m: Add the definition for the WebFoundationLocalizableStrings bundle global. (WebLocalizedString): Added. Locates the bundle, then creates a string object, then calls localizedStringForKey to find the localized version of the string in the bundle's localizable strings.
• WebFoundation.exp: Export WebLocalizedString.

• WebFoundation.pbproj/project.pbxproj: Add -DFRAMEWORK_NAME=WebFoundation.

WebKit:

• Misc.subproj/WebKitLocalizableStrings.m: Added. Contains the definition of the WebKitLocalizableStringsBundle.
• WebKit.pbproj/project.pbxproj: Add -DFRAMEWORK_NAME=WebKit.

8:31 PM Changeset in webkit [2256] by darin

• 5 edits in trunk

• fixed 2992187 -- Should use curly quotes in status bar messages, window titles, and error dialogs

• BrowserWindowController.m: (-[BrowserWindowController performQuickSearch:]): (-[BrowserWindowController goToToolbarLocation:]): Change the last two straight apostrophes to curly ones.

7:00 PM Changeset in webkit [2255] by rjw

• 4 edits
  9 adds in trunk/WebKit

Stubs for DOM level 2 core API.

• DOM.subproj/WebDOMDocument.h: Added.
• DOM.subproj/WebDOMDocument.m: Added.
• DOM.subproj/WebDOMElement.h: Added.
• DOM.subproj/WebDOMElement.m: Added.
• DOM.subproj/WebDOMNamedNodeMap.h: Added.
• DOM.subproj/WebDOMNamedNodeMap.m: Added.
• DOM.subproj/WebDOMNode.h: Added.
• DOM.subproj/WebDOMNode.m: Added.
• WebKit.pbproj/project.pbxproj:

• WebView.subproj/WebHTMLViewPrivate.m: tweak.

Removed import of header that was removed earlier.

• BookmarksController.m:

6:40 PM Changeset in webkit [2254] by darin

• 3 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Add the last few exceptions. We now have a completely-clean run of extract-localizable-strings in WebKit!

4:46 PM Changeset in webkit [2253] by darin

• 4 edits in trunk/WebKit

• fixed 3060140 -- REGRESSION: frames of animated gif drawn in wrong position.

I got the "fromRect" and "toRect" parameters backwards when I made the changes
to fix bug 3050810.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer nextFrame:]): Reverse targetRect and imageRect.

• WebKit.pbproj/project.pbxproj: Mark some new files as UTF-8 because Project Builder asked me to.

3:43 PM Changeset in webkit [2252] by darin

• 2 edits
  2 deletes in trunk/WebKit

• Panels.subproj/WebPanelCookieAcceptHandler.h: Removed.
• Panels.subproj/WebPanelCookieAcceptHandler.m: Removed.

3:39 PM Changeset in webkit [2251] by rjw

• 3 edits in trunk/WebKit

Danger Will Robinson. We have to poseAsClass: as early as possible
so that any NSViews will be created with the appropriate poser.
This problem manifested itself with SimpleViewer failing
immediately. NSViews were created by loading a nib before
WebHTMLView class initialization occured. After posing the
already instantiated instances of NSView had a %NSView class,
causing many things to break.

• WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):

2:27 PM Changeset in webkit [2250] by darin

• 3 edits in trunk/JavaScriptCore

Fixed problems parsing numbers that are larger than a long with parseInt.

• kjs/config.h: Define HAVE_FUNC_STRTOLL.
• kjs/function.cpp: (GlobalFuncImp::call): Change parseInt to use strtoll if available.

2:07 PM Changeset in webkit [2249] by darin

• 5 edits in trunk/JavaScriptCore

• kjs/config.h: Define HAVE_FUNC_STRTOLL.
• kjs/function.cpp: (GlobalFuncImp::call): Change parseInt to use strtoll if available.

2:07 PM Changeset in webkit [2248] by rjw

• 6 edits in trunk/WebKit

Ensure that we return non-nil request from handle:willSendRequest:
even when WK's laod delegate is nil.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:willSendRequest:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]):

1:43 PM Changeset in webkit [2247] by darin

• 7 edits in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Add dprintf, NSLog, and NSException to the list of tokens that introduce non-localizable strings, and added handling for square brackets.

WebFoundation:

• CacheLoader.subproj/WebResourceLoad.m: (_loadSweeper):
• Database.subproj/WebFileDatabase.m: (-[WebFileReader initWithPath:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Changed logging code to take advantage of the fact that we once-again support %@.

• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addRequestMessageBody:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _addRequestMessageBody:]): Fixed logging code to eliminate a leak.

• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler debugStringForCacheAttributeValue:]): Changed this code to just call description instead of using string formatting.

• English.lproj/StringsNotToBeLocalized.txt: Add more exceptions. We now have a completely-clean run of extract-localizable-strings in WebFoundation!

• English.lproj/Localizable.strings: Re-generated.

WebKit:

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel loadNib]): Use ERROR instead of NSLog here. (-[WebAuthenticationPanel setUpForRequest:]): Mark some strings for localization.

• WebKit.pbproj/project.pbxproj: Change the encoding on a lot more files to UTF-8.

• English.lproj/StringsNotToBeLocalized.txt: Added some new exceptions.
• English.lproj/Localizable.strings: Re-generated.

WebBrowser:

More progress on localization.

• English.lproj/StringsNotToBeLocalized.txt: Added a few strings.

• GlobalHistory.m: (-[GlobalHistory outlineView:objectValueForTableColumn:byItem:]): Marked a string for localization.

• FrameProgressEntry.m: (-[FrameProgressEntry updateKeyFrom:to:dataSource:]): Added an assert in case we run into an issue like the one from earlier today.

• English.lproj/Localizable.strings: Re-generated.

1:32 PM Changeset in webkit [2246] by rjw

• 2 edits in trunk/WebKit/WebView.subproj

Actually checkin.

11:51 AM Changeset in webkit [2245] by rjw

• 4 edits
  2 deletes in trunk/WebKit

Changed WebDOMNode name to WebDebugDOMNode to make room for
real node.

• Debug/DOMTree.m: (-[DOMTreeDataSource initWithWebView:]): (-[DOMTree itemSelected:]):

Changed WebDOMNode name to WebDebugDOMNode to make room for
real node.

• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDOMNode.h: Removed.
• WebView.subproj/WebDOMNode.m: Removed.

Oct 3, 2002:

7:48 PM Changeset in webkit [2244] by rjw

• 10 edits in trunk/WebKit

Changed name of controller's resourceProgressDelegate methods to resourceLoadDelegate.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient initWithLoader:dataSource:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setResourceLoadDelegate:]): (-[WebController resourceLoadDelegate]): (-[WebController setDownloadDelegate:]): (-[WebController downloadDelegate]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient handle:didReceiveResponse:]):

Changed name of controller's resourceProgressDelegate methods to resourceLoadDelegate.

• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument close]):

7:35 PM Changeset in webkit [2243] by rjw

• 4 edits in trunk/WebKit

Create the activity entry in resourceRequest:didReceiveResponse:fromDataSource:
rather than resourceRequest:willSendRequest:fromDataSource:.

• BrowserWebController.m: (-[BrowserWebController resourceRequest:willSendRequest:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveResponse:fromDataSource:]):

Always call resourceRequest:willSendRequest: on resourceProgressDelegate.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]):

7:11 PM Changeset in webkit [2242] by rjw

• 4 edits in trunk/WebKit

Add calls to downloadProgressDelegate.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):

6:38 PM Changeset in webkit [2241] by rjw

• 5 edits in trunk/WebKit

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:]): Hack to prevent handle creation with nil delegate, still perform frame complete check.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): Removed unused code.

(-[WebMainResourceClient handle:willSendRequest:]):
Copy the request, ugh.

• BrowserWebController.m: (-[BrowserWebController resourceRequest:willSendRequest:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveContentLength:fromDataSource:]): (-[BrowserWebController resourceRequest:didFinishLoadingFromDataSource:]): Clean up activity value changes.

• FrameProgressEntry.m: (-[FrameProgressEntry trackSubresource:withIdentifier:forDataSource:]): (-[FrameProgressEntry updateKeyFrom:to:dataSource:]): (-[FrameProgressEntry updateSubresource:ofDataSource:withURLString:bytesLoaded:bytesExpected:error:]): Update key when request changes. May be removed if with go with opaque identifier.

• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor entryForKey:dataSource:]): Accessor method for ResourceProgressEntry.

Copy request if a different instance is returned.

• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientWillSendRequest]):

5:43 PM Changeset in webkit [2240] by darin

• 4 edits in trunk/WebCore

• fixed 3065730 -- Crash loading "My T-Mobile" page (in khtml::Decoder::decode)

• khtml/misc/decoder.cpp: (Decoder::decode): Fixed a mistake that would cause the loop to run off the end of the buffer, introduced back on 2002-08-30.

5:31 PM Changeset in webkit [2239] by darin

• 11 edits in trunk

WebCore:

Add API to execute JavaScript.

• kwq/WebCoreBridge.h: Add method.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge executeJavaScriptFromString:]): Call through to KHTML. But only if the document is not nil. We need to figure out what to do in the case where the document is nil.

WebKit:

Add API for executing JavaScript.

• WebView.subproj/WebController.h: Add method.
• WebView.subproj/WebController.m: (-[WebController executeJavaScriptFromString:]): Call through to WebCore to do the heavy lifting.

WebBrowser:

Fixed most of 2980477 -- javascript: URLs don't work when typed
into the page address field or in bookmarks

They work now, but only if the frontmost window is not empty.

• BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): Rename, change to take a policy parameter instead of a boolean, and add code for the javascript: case. (-[WebBookmark goTo]): Pass ReuseAvailableWindow. (-[WebBookmark goToInNewWindow]): Pass CreateWindow. (-[WebBookmark goToUsingNewWindowAccordingToEvent:]): Choose policy based on both the command key and the shift key.

• BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]): Add add code for the javascript: case.

3:53 PM Changeset in webkit [2238] by darin

• 7 edits
  1 delete in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Do all the remaining TODO items for this script.

WebFoundation:

• English.lproj/Localizable.strings: Added. Generated by script.
• English.lproj/StringsNotToBeLocalized.txt: Updated with many more entries.

• Misc.subproj/WebError.m: Switch from NSLocalizedStringFromTable to UI_STRING.
• Misc.subproj/WebNSStringExtras.m: Switch from dummy WebLocalizedStringWithKeyAndValue to UI_STRING.

• Misc.subproj/WebQueue.m: (+[WebQueue newNode]): Just use malloc.

• English.lproj/WebError.strings: Removed.
• Misc.subproj/WebMultipartForm.h: Removed.
• Misc.subproj/WebMultipartForm.m: Removed.

• WebFoundation.pbproj/project.pbxproj: Changed encoding of many files to UTF-8. Removed files. Added Localizable.strings and StringsNotToBeLocalized.txt.

WebKit:

• English.lproj/Localizable.strings: Generated by the script.
• English.lproj/StringsNotToBeLocalized.txt: Added many more strings to ignore.
• English.lproj/WebError.strings: Removed.

• WebView.subproj/WebDefaultContextMenuDelegate.m:
• WebView.subproj/WebView.m: Use UI_STRING instead of NSLocalizedString.

• WebKit.pbproj/project.pbxproj: Changed encodings of some files to UTF-8. Removed WebError.strings.

WebBrowser:

• BrowserWebController.m: (-[BrowserWebController mouseoverTextForElement:modifierFlags:]): Added. Also put in strings for when the control key is down. (-[BrowserWebController mouseDidMoveOverElement:modifierFlags:]): Factor out the actual string change here. More work on this is required.

• ABHomePagesController.m:
• BookmarkToolbarItem.m:
• BookmarksController.m:
• BookmarksViewController.m:
• BookmarksWindowController.m:
• BrowserWebBookmarkExtras.m:
• BrowserWebController.m:
• BrowserWebErrorExtras.m:
• BrowserWindowController.m:
• ContextMenuHandler.m:
• DownloadMonitor.m:
• DownloadProgressEntry.m:
• FavoriteButton.m:
• FindPanelController.m:
• FrameProgressEntry.m:
• GlobalHistory.m:
• HTMLSourceDocument.m:
• LoadProgressMonitor.m:
• LocationChangeError.m:
• RendezvousController.m:
• Preferences.subproj/AppearancePreferences.m: Switch from NSLocalizedString to UI_STRING

• DateCell.m: Replace the dummy NSLocalizedStringWithKeyAndValue with UI_STRING.
• ResourceProgressEntry.m: (-[ResourceProgressEntry _committedStatus]): Got rid of FIXME: Localize, and put in use of UI_STRING.

• English.lproj/StringsNotToBeLocalized.txt: Add some more exceptions.
• English.lproj/Localizable.strings: Check in script-generated file for now.

• BrowserStrings.h: Removed.

• WebBrowser.pbproj/project.pbxproj: Changed encodings for many files to UTF-8. Also added StringsNotToBeLocalized.txt, although not in any target.

3:06 PM Changeset in webkit [2237] by rjw

• 13 edits
  1 delete in trunk/WebKit

Renamed WebResourceProgressDelegate.h to WebResourceLoadDelegate.h

• BrowserWebController.m:

Renamed WebResourceProgressDelegate.h to WebResourceLoadDelegate.h

• Misc.subproj/WebKit.h:
• WebCoreSupport.subproj/WebSubresourceClient.m:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.m:
• WebView.subproj/WebControllerPrivate.m:
• WebView.subproj/WebMainResourceClient.m:
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebResourceProgressDelegate.h: Removed.

2:53 PM Changeset in webkit [2236] by rjw

• 26 edits
  2 deletes in trunk/WebKit

Changed to reflect new WebResourceLoadDelegate API.

• BrowserWebController.h:
• BrowserWebController.m: (-[BrowserWebController resourceRequest:willSendRequest:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveContentLength:fromDataSource:]): (-[BrowserWebController resourceRequest:didReceiveResponse:fromDataSource:]): (-[BrowserWebController resourceRequest:didFinishLoadingFromDataSource:]):
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withBytesLoaded:bytesExpected:error:dataSource:complete:]): (-[DownloadMonitor resourceRequest:willSendRequest:fromDataSource:]): (-[DownloadMonitor resourceRequest:didReceiveContentLength:fromDataSource:]): (-[DownloadMonitor resourceRequest:didReceiveResponse:fromDataSource:]): (-[DownloadMonitor resourceRequest:didFinishLoadingFromDataSource:]): (-[DownloadMonitor resourceRequest:didFailLoadingWithError:fromDataSource:]):
• FrameProgressEntry.m: (-[FrameProgressEntry updateSubresource:ofDataSource:withURLString:bytesLoaded:bytesExpected:error:]):
• LoadProgressMonitor.m:

Changed to reflect new WebResourceLoadDelegate API.

• Misc.subproj/WebIconLoader.m:
• Misc.subproj/WebKit.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream cancel]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:size:]): (-[WebBridge reportBadURL:]):
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient initWithLoader:dataSource:]): (-[WebSubresourceClient dealloc]): (-[WebSubresourceClient receivedProgressWithComplete:]): (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient handle:willSendRequest:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]): (-[WebSubresourceClient cancel]):
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController setResourceProgressDelegate:]): (-[WebController resourceProgressDelegate]): (-[WebController setDownloadProgressDelegate:]): (-[WebController downloadProgressDelegate]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedProgressForResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgressForResourceHandle:bytesSoFar:fromDataSource:complete:]): (-[WebController _receivedError:forResourceHandle:fromDataSource:]): (-[WebController _mainReceivedError:forResourceHandle:fromDataSource:]):
• WebView.subproj/WebLoadProgress.h: Removed.
• WebView.subproj/WebLoadProgress.m: Removed.
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebResourceProgressDelegate.h:

Always send a handle:willSendRequest: before sending a request,
including first time. This will allow WebKit clients to intervene
on every load should they so choose.

• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadWithDelegate:]):

12:27 PM Changeset in webkit [2235]

• 3 copies in tags/Alexander-26

This commit was manufactured by cvs2svn to create tag 'Alexander-26'.

12:27 PM Changeset in webkit [2234] by sheridan

• 8 edits in trunk

Alex-26 version

Oct 2, 2002:

5:37 PM Changeset in webkit [2233] by mjs

• 8 edits in trunk/WebKit

• Added "remember my password" checkbox (underlying feature not yet implemented).

• Fixed a bug that caused a crash when cancelling the auth sheet.

• Panels.subproj/English.lproj/WebAuthenticationPanel.nib: Added "remember this password" checkbox.
• Panels.subproj/WebAuthenticationPanel.h:
• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel cancel:]): Make sure the panel gets retained a bit longer, so the cleanup that happens after this message is sent can use the panel object. (-[WebAuthenticationPanel logIn:]): Make sure the panel gets retained a bit longer, so the cleanup that happens after this message is sent can use the panel object. (-[WebAuthenticationPanel runAsModalDialogWithRequest:]): Pass proper remembered value with credential. (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]): Pass proper remembered value with credential.
• WebKit.pbproj/project.pbxproj: Project Builder had its way with this file.

4:52 PM Changeset in webkit [2232] by darin

• 23 edits in trunk

WebCore:

Moved "overURL" handling out of WebCore into WebKit and Alex.
Also separated the two levels of the "element dictionary" so they
don't rely on having the same keys.

• khtml/khtml_part.h: Revert the APPLE_CHANGES to overURL.
• khtml/khtml_part.cpp: (KHTMLPart::overURL): Removed the APPLE_CHANGES and just ifdef'd out the whole thing for our version. (KHTMLPart::khtmlMouseMoveEvent): Get rid of the APPLE_CHANGES and don't do any of the status bar setup.

• kwq/KWQKHTMLPartImpl.h: Remove overURL.
• kwq/KWQKHTMLPartImpl.mm: Ditto.

• kwq/WebCoreBridge.h: Change keys so they don't match the WebKit ones so we don't accidentally rely on that. Add WebCoreElementLinkTarget.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Add code to set up WebCoreElementLinkTarget.

WebKit:

Machinery so we can handle mouseover feedback at the browser level.

• WebView.subproj/WebWindowOperationsDelegate.h: Added mouseDidMoveOverElement:modifierFlags:.

• WebKit.exp: Export WebElementLinkTargetFrameKey.
• WebView.subproj/WebController.h: Add WebElementLinkTargetFrameKey.
• WebView.subproj/WebController.m: Ditto.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView removeMouseMovedObserver]): Send a callback when we stop tracking the mouse altogether. (-[WebHTMLView viewDidMoveToWindow]): Only set up the mouse moved observer if we are the top-level HTML view. (-[WebHTMLView windowDidBecomeMain:]): Ditto. (-[WebHTMLView mouseMovedNotification:]): Handle mouse over if we are over any subview of the HTML view. Also send the callback.

• WebView.subproj/WebHTMLViewPrivate.h: Added lastMouseOverElementWasNotNil, _mouseOverElement:modifierFlags: and _insideAnotherHTMLView.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Copy over each element separately so we don't rely on keys matching. Find the target frame given the target string, and include it in the dictionary. (-[WebHTMLView _mouseOverElement:modifierFlags]): Added. Calls the window operations delegate method, but doesn't call it over and over again if the information is still "nil". (-[WebHTMLView _insideAnotherHTMLView]): Added. (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Added. Helper for the _elementAtPoint method which could be moved to WebNSDictionaryExtras some day.

WebBrowser:

• fixed 2935687 -- cmd-shift-click should open new window behind
• fixed 3050456 -- Click modifier actions are decided by WebBrowser, but status messages come from WebCore

• BrowserWebController.m: (-[BrowserWebController mouseDidMoveOverElement:modifierFlags:]): Added. Contains the same logic that used to be in WebCore for mouseover messages, but translated into WebKit-ese as opposed to WebCore-ese.

• WebBrowser.pbproj/project.pbxproj: Change encoding of BrowserWebController.m to UTF-8. Be careful if you open this file without having the project open in Project Builder.

4:14 PM Changeset in webkit [2231] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

Implemented HTTP-specific subclass for WebResourceResponse.

• CacheLoader.subproj/IFURLHandleC.h:
• CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode): (IFURLHandleGetResultCode):
• CacheLoader.subproj/WebCacheLoaderConstants.h:
• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle cancel]):
• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]):
• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse init]): (-[WebResourceResponse initWithCoder:]): (-[WebResourceResponse encodeWithCoder:]): (-[WebResourceResponse _takePersistentValuesFrom:]): (-[WebResourceResponse dealloc]):
• CacheLoader.subproj/WebResourceResponsePrivate.h:
• Misc.subproj/WebError.h:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler performHTTPHeaderRead:andCall:]):
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler responseClass]): (-[WebHTTPProtocolHandler setResponseMetadata:]): (-[WebHTTPProtocolHandler shouldCacheResponse:]): (-[WebHTTPProtocolHandler cacheableAttributesWithDefaults:]):
• ProtocolHandlers.subproj/WebHTTPResourceResponse.h:
• ProtocolHandlers.subproj/WebHTTPResourceResponse.m:
• ProtocolHandlers.subproj/WebHTTPResourceResponsePrivate.h: Added.
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _examineHeaders]):
• WebFoundation.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Implemented HTTP-specific subclass for WebResourceResponse.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:]): Add import for WebHTTPResourceResponse.

1:53 PM Changeset in webkit [2230] by darin

• 8 edits in trunk/WebKit

WebFoundation:

Add return value to willSendRequest callback.

• CacheLoader.subproj/WebResourceHandleDelegate.h: Add return value.

• CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle loadWithDelegate:]): Call _notifyClientWillSendRequest to do the work of sending the willSendRequest message in the canonical URL case, to avoid duplicate code.

• CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandle _notifyClientWillSendRequest]): Keep the returned request.

• CacheLoader.subproj/WebResourceCallbackClient.m: (-[WebResourceCallbackClient handle:willSendRequest:]):
• CacheLoader.subproj/WebResourceSynchronousDelegate.m: (-[WebResourceHandleSynchronousDelegate handle:willSendRequest:]): Update to return the request.

WebKit:

Add return value to willSendRequest callback.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader handle:willSendRequest:]):
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream handle:willSendRequest:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:willSendRequest:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Update to return the request.

12:47 PM Changeset in webkit [2229] by darin

• 11 edits in trunk/WebKit

Use the text encoding name from the response and got rid of
[WebDataSource encoding]. Also remove the "first chunk" logic since we
now get a separate callback for the response.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Get the encoding name from the response, or fall back on the default.

• WebView.subproj/WebDataSource.h: Removed encoding.
• WebView.subproj/WebDataSource.m: Ditto.

• WebView.subproj/WebDataSourcePrivate.h: Removed _setEncoding.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): No need to release encoding any more.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): No isFirstChunk to initialize. (-[WebMainResourceClient handle:didReceiveResponse:]): Moved the response handling in here, including the policy logic. (-[WebMainResourceClient handle:didReceiveData:]): This has only what's left.

12:12 PM Changeset in webkit [2228] by cblu

• 14 edits in trunk/WebKit

WebKit:

Replaced contentType on WebDataSource to response.

• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:]): (-[WebNetscapePluginStream setResponse:]): (-[WebNetscapePluginStream setDataSource:]): (-[WebNetscapePluginStream receivedData:withDataSource:]): (-[WebNetscapePluginStream handle:didReceiveResponse:]): (-[WebNetscapePluginStream handle:didReceiveData:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource response]): (-[WebDataSource fileType]):
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _representationClass]): (-[WebDataSource _setResponse:]): (-[WebDataSource _setContentPolicy:]):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]):
• WebView.subproj/WebTextView.m: (-[WebTextView dataSourceUpdated:]):
• WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):

WebBrowser:

Replaced contentType on WebDataSource to response.

• BrowserWebController.m: (-[BrowserWebController receivedProgress:forResourceHandle:fromDataSource:complete:]):

11:59 AM Changeset in webkit [2227] by darin

• 11 edits in trunk/WebKit

WebKit:

More work on "open window behind".

• WebView.subproj/WebControllerPolicyDelegate.h: Add new OpenNewWindowBehind constants to the enums.

• WebView.subproj/WebWindowOperationsDelegate.h: Add a behind: parameter to the openNewWindowWithURL method.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): In the new WebClickPolicyOpenNewWindowBehind case, pass YES for behind.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:referrer:]):
• WebView.subproj/WebFrame.m: (-[WebFrame frameNamed:]): Pass NO for behind.

WebBrowser:

More work on "open window behind".

• BrowserWebController.m: (-[BrowserWebController openNewWindowWithURL:referrer:behind:]): Add new behind parameter to match change to window operations delegate in WebKit. (-[BrowserWebController clickPolicyForElement:button:modifierFlags:]): Use the WebClickPolicyOpenNewWindowBehind policy if the shift key and command key are down.

10:39 AM Changeset in webkit [2226] by darin

• 7 edits in trunk/WebKit

Cut down on unnecessary use of WebFoundation private stuff.

• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream startLoad]): Remove unnecessary use of [WebResourceHandle _request].
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]): Remove assert about status code, since status codes are going away.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]): Use currentURL for logging. (-[WebMainResourceClient handleDidFinishLoading:]): Ditto. (-[WebMainResourceClient handle:didReceiveData:]): Ditto.

10:03 AM Changeset in webkit [2225] by darin

• 6 edits in trunk/WebKit

WebKit:

• WebView.subproj/WebControllerPolicyDelegate.h: Change modifierMask to modifierFlags to match NSEvent.
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForElement:button:modifierFlags:]): Ditto.
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Ditto.

WebBrowser:

Start of the "open window behind" feature.

• BrowserDocument.m: (-[BrowserDocument close]): Move a cancel here from the BrowserWebController resetDocument method that really didn't belong there. (-[BrowserDocument _goToURL:referrer:withFallbackURLs:]): Rearrange this function so that the part that is just "go to a particular WebResourceRequest" is clearly separated, in preparation for using a method in WebController some day.

• BrowserDocumentController.h: Add URLWindowPolicy enum, and use it as the parameter for goToURL and tryMultipleURLs.
• BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:behind:): Remove display: parameter, and add behind: parameter. (-[BrowserDocumentController _goToEachURL:referrer:windowPolicy:]): Update to take a windowPolicy parameter instead of separate booleans. (-[BrowserDocumentController goToEachURL:]): Use windowPolicy. (-[BrowserDocumentController openDocument:]): Use windowPolicy. (-[BrowserDocumentController goToURL:]): Use windowPolicy. (-[BrowserDocumentController goToURL:referrer:windowPolicy:]): Use windowPolicy. (-[BrowserDocumentController tryMultipleURLs:windowPolicy:]): Use windowPolicy.

• BrowserWebController.m: (-[BrowserWebController resetDocument]): Move cancel to BrowserDocument close. (-[BrowserWebController openNewWindowWithURL:referrer:]): Use windowPolicy. (-[BrowserWebController pluginNotFoundSheetEnded:returnCode:contextInfo:]): Use windowPolicy. (-[BrowserWebController clickPolicyForElement:button:modifierFlags:]): Update name to match change in WebKit.

• ActivityViewer.m: (-[ActivityViewer _goToClickedItem:]):
• AppController.m: (-[AppController application:openFile:]): (-[AppController handleGURLEvent:withReplyEvent:]):
• BrowserWebBookmarkExtras.m: (-[WebBookmark _goToForceNewWindow:]):
• Test/PageLoadTestRunner.m: (-[PageLoadTestRunner goToPage]): Update to use windowPolicy.

9:46 AM Changeset in webkit [2224] by darin

• 5 edits in trunk/WebKit

Get rid of uses of canonicalURL.

• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Start with normal URL. The change to the canonical URL will come in as a redirect. (-[WebSubresourceClient handle:didReceiveData:]): Remove assert. (-[WebSubresourceClient handleDidFinishLoading:]): Ditto.
• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]):Start with normal URL. The change to the canonical URL will come in as a redirect.

9:23 AM Changeset in webkit [2223] by kocienda

• 3 edits in trunk/WebKit

Added import of WebHTTPResourceRequest.h to get access to methods
which have moved to the HTTP-sepcific request category.

• WebView.subproj/WebDataSourcePrivate.m