Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 8, 2002:

10:22 PM Changeset in webkit [2288] by darin

• 7 edits in trunk/WebKit

• fixed 3069764 -- REGRESSION: Plug-ins sometimes don't respond to update events, causes disappearing

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView drawRect:]): Set the visible region of the port to the port bounds to work around the fact that NSWindow tries to help us by doing a BeginUpdate call. This ensures we can draw where we think we are dirty, not just where Carbon thinks we are dirty.

• Plugins.subproj/WebNetscapePluginDocumentView.m: Tweak includes.
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: Tweak includes.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]): Tweak.

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

10:16 PM Changeset in webkit [2287] by darin

• 7 edits in trunk/WebCore

• WebCore.pbproj/project.pbxproj: Project Builder wanted to set encodings for new files. Maybe Richard is not using the new Project Builder on all his machines?

• kwq/KWQString.mm: (_allocateNode): Fix typo in comment.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Tweak.

8:04 PM Changeset in webkit [2286] by darin

• 17 edits in trunk/WebKit

WebKit:

Make WebFrame do the entire frame hierarchy, instead of having the
parent and child pointers in the data source.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): Get children from the frame, not the data source. (-[WebBridge setFrame:]): Do the setParent: call on the bridge here, instead of in dataSourceChanged, since the parent relationship is now established even without having the data source. (-[WebBridge dataSourceChanged]): Remove the setParent: call. (-[WebBridge loadRequest:]): Remove the parent parameter. It's already set up at this point so we don't need to set it. (-[WebBridge loadURL:referrer:]): Don't pass a parent. (-[WebBridge postWithURL:referrer:data:contentType:]): Don't pass a parent. (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Don't pass a parent. (-[WebBridge addBackForwardItemWithURL:anchor:]): Get the parent frame by just calling the parent method instead of the more roundabout way that it was doing it before.

• WebView.subproj/WebController.m: (-[WebController _frameForDataSource:fromFrame:]): Get the children list from the frame, no need to ask the data source. And no need to deal with the provisional data source, since those can't have children any more. (-[WebController _frameForView:fromFrame:]): Ditto.

• WebView.subproj/WebControllerPrivate.h: Change parent parameter when creating a new frame to be a frame, not a data source.
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate _clearControllerReferences:]): Get the children list from the frame. (-[WebControllerPrivate dealloc]): Rename the _reset method _controllerWillBeDeallocated to be more concrete. More simplification can happen here later. (-[WebController createFrameNamed:for:inParent:allowsScrolling:]): Call _addChild on the parent frame rather than calling addFrame on the parent data source.

• WebView.subproj/WebDataSource.h: Remove the parent, children, frameNamed, frameNames, and frameExists methods.
• WebView.subproj/WebDataSource.m: (-[WebDataSource controller]): Remove the assertion here about parents, since we don't have a parent pointer any more. (-[WebDataSource isLoading]): Get the list of children from the frame.

• WebView.subproj/WebDataSourcePrivate.h: Remove the parent pointer and the frames dictionary, also remove the _setParent: and addFrame: methods.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Don't release the frames list. (-[WebDataSource _recursiveStopLoading]): Get the frames list from the frame. (-[WebDataSource _layoutChildren]): Ditto. (-[WebDataSource _defersCallbacksChanged]): Ditto.

• WebView.subproj/WebFrame.h: Add parent and children methods.
• WebView.subproj/WebFrame.m: (-[WebFrame dealloc]): Call _detachFromParent. (-[WebFrame setProvisionalDataSource:]): Set the encoding of the data source to match the encoding of the parent's data source. This used to be done in [WebDataSource _setParent:]. Further simplification can probably be done here. (-[WebFrame reload]): Remove the call to [WebDataSource _setParent:]. (+[WebFrame _frameNamed:fromFrame:]): Get the children from the frame. (-[WebFrame frameNamed:]): Get the parent from the frame. (-[WebFrame parent]): Added. (-[WebFrame children]): Added.

• WebView.subproj/WebFramePrivate.h: Added parent and children fields, changed reset to _controllerWillBeDeallocated, changed _parentDataSourceWillBeDeallocated to _detachFromParent, added _addChild method. Further simplification can probably be done here.
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Release the children array. (-[WebFrame _controllerWillBeDeallocated]): Renamed from reset. Now just calls _detachFromParent. (-[WebFrame _detachFromParent]): Does all the work that reset and _parentDataSourceWillBeDeallocated used to do. (-[WebFrame _setDataSource:]): Call _detachFromParent on all the children and release them before setting up the new data source. (-[WebFrame _transitionToCommitted]): Get the parent from self instead of the data source. (-[WebFrame _isLoadComplete]): Ditto. (+[WebFrame _recursiveCheckCompleteFromFrame:]): Get the children from self instead of the data source. (-[WebFrame _textSizeMultiplierChanged]): Ditto. (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): Remove the call to [WebDataSource _setParent:]. (-[WebFrame _addChild:]): Added. Puts the child in a children list, and also sets the override encoding of the child based on our data source's override encoding.

WebBrowser:

Update for the WebKit change that moved the children list to the frame
instead of the data source.

• BrowserWebFrameExtras.h: Remove the parentFrame method, since the parent method on WebFrame now does the same thing.
• BrowserWebFrameExtras.m: (-[WebFrame _topFrame]): Use parent.
• BrowserWebViewExtras.m: (-[WebView largestScrollableWebView]): Call the children method on the frame now, not the data source.
• LoadProgressMonitor.m: (-[LoadProgressMonitor _monitorProvisionalDataSourceForFrame:]): Get the parent directly from the frame now, no need to go through the data source. (-[LoadProgressMonitor titleChangedForFrame:]): Use the parent method, not parentFrame.

7:41 PM Changeset in webkit [2285] by sullivan

• 3 edits in trunk/WebKit

WebKit:

--2002-10-08 John Sullivan <​sullivan@apple.com>

• WebKit.pbproj/project.pbxproj: Project Builder says I changed it only by setting "hasScannedForEncodings" to 1 -- version wars again?

WebBrowser:

• fixed 3070645 -- Editable items in "Library" column should be drop targets
• made "Library" column unstriped -- I stripified it earlier without realizing that it wasn't supposed to be stripulated.

You can now drop bookmarks from one top-level group into another, and they move
(unless you hold the option key down).

• BookmarksViewController.m: (-[BookmarksViewController awakeFromNib]): register drag types for table view (-[BookmarksViewController menuFolderTitle]): new convenience method (-[BookmarksViewController complainAboutTryingToMoveFavorites]): tweaked wording (-[BookmarksViewController complainAboutTryingToMoveBookmarksMenu]): new method (-[BookmarksViewController tableView:validateDrop:proposedRow:proposedDropOperation:]): new method, decide what can be dropped and where (-[BookmarksViewController tableView:acceptDrop:row:dropOperation:]): new method, handle the drop; both of these methods are currently overly complicated (-[BookmarksViewController outlineView:acceptDrop:item:childIndex:]): handle trying to move menu root as well as favorites root

• English.lproj/Localizable.strings: update localizations

4:54 PM Changeset in webkit [2284] by hyatt

• 4 edits in trunk/WebCore

This was an unintentional checkin. backing out.

• khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::removeNamedItem):

4:42 PM Changeset in webkit [2283] by rjw

• 3 edits in trunk/WebKit

Removed unnecessary (and incorrect) include.
The *.m files in DOM.subproj might be removed,
they are empty now.

• DOM.subproj/WebDOMDocument.m:

4:27 PM Changeset in webkit [2282] by rjw

• 9 edits in trunk

i Added bridge method set the selection.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectionFrom:startOffset:to:endOffset:]):

Added selection API.

• WebView.subproj/WebHTMLRepresentation.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation setSelectionFrom:startOffset:to:endOffset:]):

4:07 PM Changeset in webkit [2281] by rjw

• 11 edits in trunk

Add accessor for DOM document.

• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebHTMLRepresentation.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]):

Added bridge method to get the DOM document.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge DOMDocument]):
• kwq/WebCoreDOM.h:

3:47 PM Changeset in webkit [2280] by rjw

• 11 edits in trunk/WebCore

More DOM implementation.

• khtml/dom/dom_text.h:
• khtml/dom/dom_xml.h:
• khtml/xml/dom_textimpl.h:
• khtml/xml/dom_xmlimpl.h:
• kwq/WebCoreDOM.h:
• kwq/WebCoreDOMNode.mm: (DOM::CharacterDataImpl::createInstance): (DOM::TextImpl::createInstance): (DOM::ProcessingInstructionImpl::createInstance): (-[WebCoreDOMCharacterData data]): (-[WebCoreDOMCharacterData setData:]): (-[WebCoreDOMCharacterData length]): (-[WebCoreDOMCharacterData substringData::]): (-[WebCoreDOMCharacterData appendData:]): (-[WebCoreDOMCharacterData insertData::]): (-[WebCoreDOMCharacterData deleteData::]): (-[WebCoreDOMText splitText:]): (+[WebCoreDOMCDATASection CDATASectionWithImpl:DOM::]): (-[WebCoreDOMProcessingInstruction data]): (-[WebCoreDOMProcessingInstruction setData:]):
• kwq/WebCoreDOMPrivate.h:
• kwq/WebDOMElement.h:

3:07 PM Changeset in webkit [2279] by rjw

• 15 edits in trunk

Made getAttributeNodeNamed match spec, changed
to getAttributeNode.

• DOM.subproj/WebDOMElement.h:

Implemented WebCoreDOMElement.
Fixed extra deref of impl in subclasses
of WebCoreDOMNode.

• khtml/dom/dom_element.h:
• khtml/dom/dom_node.h:
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nodeimpl.h:
• kwq/WebCoreDOMDocument.mm: (-[WebCoreDOMDocument initWithImpl:DOM::]):
• kwq/WebCoreDOMNode.mm: (DOM::NodeListImpl::createInstance): (DOM::NamedNodeMapImpl::createInstance): (DOM::AttrImpl::createInstance): (DOM::ElementImpl::createInstance): (-[WebCoreDOMNodeList length]): (-[WebCoreDOMNodeList item:]): (-[WebCoreDOMAttr initWithImpl:DOM::]): (+[WebCoreDOMDocumentFragment documentFragmentWithImpl:DOM::]): (-[WebCoreDOMElement tagName]): (-[WebCoreDOMElement setAttribute::]): (-[WebCoreDOMElement removeAttribute:]): (-[WebCoreDOMElement getAttributeNode:]): (-[WebCoreDOMElement removeAttributeNode:]): (-[WebCoreDOMElement getElementsByTagName:]): (-[WebCoreDOMElement getAttributeNS::]): (-[WebCoreDOMElement setAttributeNS:::]):
• kwq/WebDOMDocument.h:
• kwq/WebDOMElement.h:

2:40 PM Changeset in webkit [2278] by sullivan

• 9 edits
  2 deletes in trunk/WebKit

WebKit:

• WebKit part of fix for 3069150 -- eliminate "separator" feature from Bookmarks

• Bookmarks.subproj/WebBookmarkSeparator.h: Removed.
• Bookmarks.subproj/WebBookmarkSeparator.m: Removed. Removed class

• Bookmarks.subproj/WebBookmark.h:
• Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkOfType:]): (+[WebBookmark bookmarkFromDictionaryRepresentation:withGroup:]):
• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:URLString:type:]):
• Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]):
• Bookmarks.subproj/WebBookmarkPrivate.h:
• English.lproj/StringsNotToBeLocalized.txt: Removed all references to class.

• WebKit.pbproj/project.pbxproj: Updated for removed files.

WebBrowser:

• WebBrowser part of fix for 3069150 -- eliminate "separator" feature from Bookmarks
• fixed 3070014 -- Library view needs "New Folder" button
• fixed 3050660 -- the 5 editing items in the Bookmarks menu before the bookmarks should be moved or made a submenu
• fixed 3069152 -- eliminate the ability to create new empty bookmarks

• OutlineViewPlus.h:
• OutlineViewPlus.m: (-[OutlineViewPlus keyDown:]): Add delegate handling of keyDown events like that in TableViewPlus so I could remove the ugly hack of out-of-sight buttons handling Delete and Return as keyboard shortcuts.

• BookmarksController.m: (-[BookmarksController imageForBookmark:]): Remove bookmark separator handling. (-[BookmarksController addMenuItemForBookmark:toMenu:]): Remove bookmark separator handling.

• BookmarksViewController.h:
• BookmarksViewController.m: (-[BookmarksViewController removeSelectedBookmarks]): removed sender parameter; no longer used as IBAction. (-[BookmarksViewController handleKeyDown:inSourceColumn:]): new bottleneck method for handling Return and Delete (and forward delete) keys pressed in either table view or outline view. (-[BookmarksViewController tableView:keyDown:]): now calls handleKeyDown:inSourceColumn: (-[BookmarksViewController outlineView:objectValueForTableColumn:byItem:]): Remove bookmark separator handling. (-[BookmarksViewController outlineView:shouldEditTableColumn:item:]): Remove bookmark separator handling. (-[BookmarksViewController outlineView:keyDown:]): new delegate method, calls handleKeyDown:inSourceColumn: (-[BookmarksViewController delete:]): No sender parameter for removeSelectedBookmarks anymore (-[BookmarksViewController validateUserInterfaceItem:]): Removed case for removeSelectedBookmarks since it's never auto-validated now

• BrowserWebBookmarkExtras.m: (+[WebBookmark writeBookmarks:toPasteboard:withOwner:]): Remove bookmark separator handling.

• English.lproj/Browser.nib: added New Folder button; removed ugly hack of out-of-sight buttons handling Delete and Return; put table view and outline view in boxes to handle New Folder button and future changes.

• English.lproj/Localizable.strings: update localizations

• English.lproj/MainMenu.nib: removed editing items from Bookmarks menu

• FavoriteButton.m: (-[FavoriteButton setBookmark:]): Remove bookmark separator handling. (-[FavoriteButton menu]): Remove bookmark separator handling.

• FavoritesBar.m: (-[FavoritesBar performDragOperation:]): Remove bookmark separator handling.

2:16 PM Changeset in webkit [2277] by rjw

• 17 edits
  7 adds
  2 deletes in trunk

Fixes to the DOM API.

• DOM.subproj/WebDOMDocument.h:
• DOM.subproj/WebDOMDocument.m:
• DOM.subproj/WebDOMNode.h:
• DOM.subproj/WebDOMNode.m:
• DOM.subproj/WebDOMNamedNodeMap.h: Removed.
• DOM.subproj/WebDOMNamedNodeMap.m: Removed.
• WebKit.pbproj/project.pbxproj:

First cut at ObjC stubs for DOM API. Finished the
main classes. Need to finish
WebDOMElement, WebDOMElement, WebDOMElement,
WebDOMCDATASection, WebDOMText, WebDOMComment,
WebDOMCharacterData and

• WebCore.pbproj/project.pbxproj:
• khtml/dom/dom_doc.h:
• khtml/dom/dom_element.h:
• khtml/dom/dom_node.h:
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nodeimpl.h:
• kwq/WebCoreDOM.h: Added.
• kwq/WebCoreDOMDocument.mm: Added. (DOM::DOMImplementationImpl::createInstance): (DOM::DocumentTypeImpl::createInstance): (DOM::DocumentImpl::createInstance): (domStringToNSString): (NSStringToDOMString): (+[WebCoreDOMDocumentType documentTypeWithImpl:DOM::]): (-[WebCoreDOMDocumentType initWithImpl:DOM::]): (-[WebCoreDOMDocumentType dealloc]): (-[WebCoreDOMDocumentType DOM::]): (-[WebCoreDOMDocumentType name]): (-[WebCoreDOMDocumentType entities]): (-[WebCoreDOMDocumentType notations]): (-[WebCoreDOMDocumentType publicId]): (-[WebCoreDOMDocumentType systemId]): (-[WebCoreDOMDocumentType internalSubset]): (+[WebCoreDOMImplementation implementionatWithImpl:DOM::]): (-[WebCoreDOMImplementation initWithImpl:DOM::]): (-[WebCoreDOMImplementation dealloc]): (-[WebCoreDOMImplementation DOM::]): (-[WebCoreDOMImplementation hasFeature::]): (-[WebCoreDOMImplementation createDocument:::]): (+[WebCoreDOMDocument documentWithImpl:DOM::]): (-[WebCoreDOMDocument initWithImpl:DOM::]): (-[WebCoreDOMDocument dealloc]): (-[WebCoreDOMDocument DOM::]): (-[WebCoreDOMDocument doctype]): (-[WebCoreDOMDocument implementation]): (-[WebCoreDOMDocument documentElement]): (-[WebCoreDOMDocument createElement:]): (-[WebCoreDOMDocument createElementNS::]): (-[WebCoreDOMDocument createDocumentFragment]): (-[WebCoreDOMDocument createTextNode:]): (-[WebCoreDOMDocument createComment:]): (-[WebCoreDOMDocument createCDATASection:]): (-[WebCoreDOMDocument createProcessingInstruction::]): (-[WebCoreDOMDocument createAttribute:]): (-[WebCoreDOMDocument createAttributeNS::]): (-[WebCoreDOMDocument createEntityReference:]): (-[WebCoreDOMDocument getElementById:]): (-[WebCoreDOMDocument getElementsByTagName:]): (-[WebCoreDOMDocument getElementsByTagNameNS::]): (-[WebCoreDOMDocument importNode::]):
• kwq/WebCoreDOMNode.mm: Added. (DOM::NamedNodeMapImpl::createInstance): (DOM::AttrImpl::createInstance): (+[WebCoreDOMNode nodeWithImpl:DOM::]): (-[WebCoreDOMNode initWithImpl:DOM::]): (-[WebCoreDOMNode DOM::]): (-[WebCoreDOMNode dealloc]): (-[WebCoreDOMNode nodeName]): (-[WebCoreDOMNode nodeValue]): (-[WebCoreDOMNode setNodeValue:]): (-[WebCoreDOMNode nodeType]): (-[WebCoreDOMNode parentNode]): (-[WebCoreDOMNode firstChild]): (-[WebCoreDOMNode lastChild]): (-[WebCoreDOMNode previousSibling]): (-[WebCoreDOMNode nextSibling]): (-[WebCoreDOMNode ownerDocument]): (-[WebCoreDOMNode insert:before:]): (-[WebCoreDOMNode replace:child:]): (-[WebCoreDOMNode removeChild:]): (-[WebCoreDOMNode hasChildNodes]): (-[WebCoreDOMNode cloneNode:]): (-[WebCoreDOMNode normalize]): (-[WebCoreDOMNode isSupported::]): (-[WebCoreDOMNode namespaceURI]): (-[WebCoreDOMNode prefix]): (-[WebCoreDOMNode setPrefix:]): (-[WebCoreDOMNode localName]): (+[WebCoreDOMNodeList nodeListWithImpl:DOM::]): (-[WebCoreDOMNodeList initWithImpl:DOM::]): (-[WebCoreDOMNodeList DOM::]): (-[WebCoreDOMNodeList dealloc]): (+[WebCoreDOMNamedNodeMap namedNodeMapWithImpl:DOM::]): (-[WebCoreDOMNamedNodeMap initWithImpl:DOM::]): (-[WebCoreDOMNamedNodeMap DOM::]): (-[WebCoreDOMNamedNodeMap dealloc]): (-[WebCoreDOMNamedNodeMap length]): (-[WebCoreDOMNamedNodeMap getNamedItem:]): (-[WebCoreDOMNamedNodeMap setNamedItem:]): (+[WebCoreDOMAttr attrWithImpl:DOM::]): (-[WebCoreDOMAttr initWithImpl:DOM::]): (-[WebCoreDOMAttr DOM::]): (-[WebCoreDOMAttr dealloc]): (-[WebCoreDOMAttr name]): (-[WebCoreDOMAttr specified]): (-[WebCoreDOMAttr value]): (-[WebCoreDOMAttr ownerElement]): (+[WebCoreDOMCDATASection CDATASectionWithImpl:DOM::]): (-[WebCoreDOMCDATASection initWithImpl:DOM::]): (-[WebCoreDOMCDATASection DOM::]): (-[WebCoreDOMCDATASection dealloc]):
• kwq/WebCoreDOMPrivate.h: Added.
• kwq/WebDOMDocument.h: Added.
• kwq/WebDOMElement.h: Added.
• kwq/WebDOMNode.h: Added.

2:12 PM Changeset in webkit [2276] by kocienda

• 3 edits in trunk/WebKit

WebFoundation:

Some changes to make some progress on this bug:

Radar 3015613 (Search results disappear when backtracking)

This set of changes does not fix this bug, but it does provide much of the WebFoundation
support we'll need for a complete fix. In order to finish the fix, we need to make
some API changes in WebKit.

• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad _cacheKey]): Add HTTP request method to cache key.
• CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]): Explicitly set defaults for requestCachePolicy and responseCachePolicy.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler shouldCacheResponse:]): Do not unconditionally determine that HEAD, POST, PUT, and DELETE methods are uncacheable. This change is made so we can show cached results when a user uses back/forward or history to do navigation.

WebKit:

Use WebFrameLoadType variable to set the request cache policy for the WebResourceRequest.
This will help us to provide cached results for POST requests when the user navigates
using the back/forward list or history for navigation, while making sure we do not
use cached results when the user pokes the submit button for a form they have
submitted previously.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:])

1:54 PM Changeset in webkit [2275] by cblu

• 4 edits in trunk/WebKit

WebFoundation:

• Sniff file resources for HTML if we can't determine a MIME type.
• Assume resources without content types or extensions are HTML.

• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse contentType]): Cleaned up, make HTML assumption
• Misc.subproj/WebNSStringExtras.h:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_isExtensionDefinite]): added, returns YES for common extensions that should be correct.
• ProtocolHandlers.subproj/WebFileProtocolHandler.m: (-[WebFileProtocolHandler didLoadData:]): sniff if !_web_isExtensionDefinite

WebKit:

Moved assumption that a resource without a content type or extension is HTML to WebFoundation.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

12:52 PM Changeset in webkit [2274] by hyatt

• 7 edits in trunk/WebCore

Fix a bug in my event handling code for layers. This makes
the links on ESPN.com work again (bug 3051636). Yay!

• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
• khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::removeNamedItem):
• kwq/qt/qrect.h:

10:51 AM Changeset in webkit [2273] by cblu

• 4 edits in trunk/WebKit

Minor plug-in code clean-up.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream receivedData:]):

8:08 AM Changeset in webkit [2272] by cblu

• 4 edits in trunk/WebKit

Partial fix for 2967073 - should open all TEXT type files, at least

• WebView.subproj/WebControllerPrivate.m: (+[WebController _MIMETypeForFile:]): Sniff for HTML in the fail case.

Oct 7, 2002:

5:00 PM Changeset in webkit [2271] by darin

• 5 edits in trunk/WebCore

• fixed 3037353 -- align="middle" elements not horizontally centered

• khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute):
• khtml/html/html_tableimpl.cpp: (HTMLTablePartElementImpl::parseAttribute): Handle "middle" same as center in these two places.

3:20 PM Changeset in webkit [2270] by darin

• 9 edits in trunk

WebFoundation:

WebFoundation part of implementation of multipart forms posting.

• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _addRequestMessageBody:]):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addRequestMessageBody:]): Remove obsolete support for non-NSData form data. Use the contentType in the request, if present.

• ProtocolHandlers.subproj/WebHTTPResourceRequest.h: Add contentType and setContentType methods; convenience for setting the Content-Type header.
• ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest _headerForKey:]): Added. (-[WebResourceRequest userAgent]): Use _headerForKey. (-[WebResourceRequest referrer]): Ditto. (-[WebResourceRequest contentType]): Added. Use _headerForKey. (-[WebResourceRequest setContentType:]): Added.

• ProtocolHandlers.subproj/WebHTTPProtocolHandler.h: Remove requestData.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: Ditto.

WebCore:

WebCore part of implementation of multipart forms posting.

• kwq/WebCoreBridge.h: Add a contentType parameter to the bridge's [postWithURL:referrer:data:] method.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::submitForm): Extract the content type from the args, and pass it along to the bridge.

WebKit:

WebKit part of implementation of multipart forms posting.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge postWithURL:referrer:data:contentType:]): Add a contentType parameter to match change in WebCore API. Put the contentType value into the request.

3:01 PM Changeset in webkit [2269] by cblu

• 3 edits in trunk/WebKit

• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase init]): Don't override document view and rep types for types that have already been registered.

2:06 PM Changeset in webkit [2268] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Add a port to the background thread's run loop so it will not exit
the run method constantly.

• Database.subproj/WebFileDatabase.m: (+[WebFileDatabase _syncLoop:])

2:06 PM Changeset in webkit [2267] by darin

• 4 edits in trunk/JavaScriptCore

Fixed absurdly high memory usage when looking at pages that use a lot of JavaScript.

• kjs/collector.cpp: (Collector::allocate): Implement a new policy of doing a garbage collect every 1000 allocations. The old policy was both complicated and misguided. (Collector::collect): Zero out the "number of allocations since last collect".

1:29 PM Changeset in webkit [2266] by darin

• 13 edits in trunk

WebCore:

• fixed 3011025 -- Page up/down is not working when text area has focus

• kwq/KWQTextArea.mm: (-[KWQTextArea needsPanelToBecomeKey]): Return YES so we are considered a valid key view even when in normal tabbing mode. This fixes a problem with tabbing backwards into a text area. (-[KWQTextAreaTextView scrollPageUp:]): Added. Passes a scrollPageUp: selector along the responder chain if we are already scrolled to the top. (-[KWQTextAreaTextView scrollPageDown:]): Ditto.

• kwq/KWQNSTextField.mm: Remove unnecessary overrides of textDidEndEditing. Turns out the real fix was to override display to do nothing as a workaround for bug 2753974.

WebKit:

WebKit part of the page up/down fix.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView scrollPoint:]): If we are called from the handling of a page up or page down keyboard event, then ignore the specific scrolling requested, and do our idea of page up and page down. This guarantees that we will get the smarter idea of how to page from WebView instead of the one that's hardcoded into NSTextView.

• WebView.subproj/WebView.m: (-[WebView keyDown:]): Use scrollPageUp:, scrollPageDown:, scrollLineUp:, and scrollLineDown: instead of _pageUp, _pageDown, _lineUp, and _lineDown. This lets other classes see and use these selectors, which is useful when passing calls up the responder chain.
• WebView.subproj/WebViewPrivate.h: Remove the private methods that are being changed to match the NSResponder keyboard methods.
• WebView.subproj/WebViewPrivate.m: (-[WebView scrollPageUp:]): Rename from _pageUp, and also pass a scrollPageUp: selector along the responder chain if we are already scrolled to the top. (-[WebView scrollPageDown:]): Ditto. (-[WebView scrollLineUp:]): Rename from _lineUp. (-[WebView scrollLineDown:]): Rename from _lineDown.

1:02 PM Changeset in webkit [2265] by rjw

• 1 edit in trunk/WebCore/force-clean-timestamp

Force build, sorry. PB doesn't seem to be behaving.

12:38 PM Changeset in webkit [2264] by rjw

• 16 edits in trunk

'Re'play the delegate messages when an item is loaded from
the WebCore cache.

Note that the client will NOT receive a willSendRequest: message. The client
presumably already did any request substitution before the object was loaded
into the cache. Allowing the delegate to override the request and replace
the object in the WebCore cache would introduce significant complexity.

Fixes 3069138.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveResponse:]):

Added response to WebCore's CachedObject. This allows us to correctly
emulated the WebResourceLoadDelegate API when 're'loading an item
from the WebCore cache.

• khtml/misc/loader.cpp: (CachedObject::~CachedObject): (CachedObject::setResponse): (Loader::receivedResponse):
• khtml/misc/loader.h:
• kwq/KWQLoaderImpl.h:
• kwq/KWQLoaderImpl.mm: (-[WebCoreResourceLoader receivedResponse:]): (KWQCheckCacheObjectStatus): (KWQRetainResponse): (KWQReleaseResponse):
• kwq/WebCoreBridge.h:
• kwq/WebCoreResourceLoader.h:

11:35 AM Changeset in webkit [2263] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Fixed problem in the disk cache where disk writes, once they start, were not being
preempted by future activity through the cache (as it should). The issue here is
that the disk cache was simply "borrowing" the thread that was used to call into
the disk cache to schedule a timer. This turned out to be bad, since that thread
was raised to maximum priority some time ago.

I fixed this by giving the disk cache its own (minimum priority) thread to
write files. This will insulate it from unrelated threading changes in other code.

• Database.subproj/WebFileDatabase.m: (+[WebFileDatabase _syncLoop:]) (databaseInit) (-[WebFileDatabase setTimer]) (-[WebFileDatabase setObject:forKey:])

Oct 6, 2002:

3:17 PM Changeset in webkit [2262] by darin

• 4 edits in trunk/JavaScriptCore

I noticed some broken lists at mapblast.com and tracked it down to this.

• kjs/array_object.cpp: (ArrayInstanceImp::put): Don't truncate the list; only extend the length if it's not already long enough. (ArrayProtoFuncImp::call): Fix some ifdef'd code so it compiles if you turn the ifdefs on.

12:23 PM Changeset in webkit [2261] by darin

• 4 edits in trunk/WebCore

• fixed 3046737 -- infinite loop in font name matching code on some pages

• kwq/KWQString.mm: (QString::replace): Removed the incorrect early exit if the passed in string was the empty string.

Oct 5, 2002:

8:27 AM Changeset in webkit [2260] by darin

• 3 edits in trunk/WebKit

• fixed 3068323 -- nil object inserted in dictionary exception on mouse move

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Add some assertions in the hope of finding if my assumptions about this are wrong, and use the version of the dictionary setter that does nothing if it's passed nil when putting in the frame found by name.

Oct 4, 2002:

10:58 PM Changeset in webkit [2259] by darin

• 4 edits in trunk/WebCore

Tests:

• harness.c: (main): Stop using debug versions of frameworks. This was causing us problems we'd see only in the test programs, and we didn't see the text of the asserts. We can turn this back on again if we make it so we can see what's wrong.

• WebFoundation-Misc/ifnsurlextensions-test.chk: Update for new expected results that handle "../" properly.

• kde/kurl-test.chk: Update for canonicalization, which was added a while back without updating this test.

WebFoundation:

• fixed 3064420 -- NSURLExtras function does not resolve "../" URLs at top level the way the web expects

• Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithString:relativeToURL:]): Added code to detect URL results that have paths that start with /../ and remove the extra levels. Tested with the Tests directory.

• English.lproj/StringsNotToBeLocalized.txt: Added the string used as a localization exception.

WebCore:

• kwq/KWQKURL.mm: (KURL::parse): Fix code that adds "" to file URLs. The code was including the extra slashes as part of the path, which they are not. Verified with the tests in the Tests directory.

9:34 PM Changeset in webkit [2258] by darin

• 3 edits in trunk/WebKit

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Add a couple more localization exceptions for newly added strings.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Add a localization exception for the WebKit bundle identifier.

9:28 PM Changeset in webkit [2257] by darin

• 3 edits
  1 add in trunk/WebKit

WebFoundation:

• Misc.subproj/WebLocalizableStrings.h: Implement the real version of the UI_STRING macro. It uses the FRAMEWORK_NAME preprocessor define to find the appropriate bundle global, and passes that along with the key into the WebLocalizedString function.
• Misc.subproj/WebLocalizableStrings.m: Add the definition for the WebFoundationLocalizableStrings bundle global. (WebLocalizedString): Added. Locates the bundle, then creates a string object, then calls localizedStringForKey to find the localized version of the string in the bundle's localizable strings.
• WebFoundation.exp: Export WebLocalizedString.

• WebFoundation.pbproj/project.pbxproj: Add -DFRAMEWORK_NAME=WebFoundation.

WebKit:

• Misc.subproj/WebKitLocalizableStrings.m: Added. Contains the definition of the WebKitLocalizableStringsBundle.
• WebKit.pbproj/project.pbxproj: Add -DFRAMEWORK_NAME=WebKit.

8:31 PM Changeset in webkit [2256] by darin

• 5 edits in trunk

• fixed 2992187 -- Should use curly quotes in status bar messages, window titles, and error dialogs

• BrowserWindowController.m: (-[BrowserWindowController performQuickSearch:]): (-[BrowserWindowController goToToolbarLocation:]): Change the last two straight apostrophes to curly ones.

7:00 PM Changeset in webkit [2255] by rjw

• 4 edits
  9 adds in trunk/WebKit

Stubs for DOM level 2 core API.

• DOM.subproj/WebDOMDocument.h: Added.
• DOM.subproj/WebDOMDocument.m: Added.
• DOM.subproj/WebDOMElement.h: Added.
• DOM.subproj/WebDOMElement.m: Added.
• DOM.subproj/WebDOMNamedNodeMap.h: Added.
• DOM.subproj/WebDOMNamedNodeMap.m: Added.
• DOM.subproj/WebDOMNode.h: Added.
• DOM.subproj/WebDOMNode.m: Added.
• WebKit.pbproj/project.pbxproj:

• WebView.subproj/WebHTMLViewPrivate.m: tweak.

Removed import of header that was removed earlier.

• BookmarksController.m:

6:40 PM Changeset in webkit [2254] by darin

• 3 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Add the last few exceptions. We now have a completely-clean run of extract-localizable-strings in WebKit!

4:46 PM Changeset in webkit [2253] by darin

• 4 edits in trunk/WebKit

• fixed 3060140 -- REGRESSION: frames of animated gif drawn in wrong position.

I got the "fromRect" and "toRect" parameters backwards when I made the changes
to fix bug 3050810.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer nextFrame:]): Reverse targetRect and imageRect.

• WebKit.pbproj/project.pbxproj: Mark some new files as UTF-8 because Project Builder asked me to.

3:43 PM Changeset in webkit [2252] by darin

• 2 edits
  2 deletes in trunk/WebKit

• Panels.subproj/WebPanelCookieAcceptHandler.h: Removed.
• Panels.subproj/WebPanelCookieAcceptHandler.m: Removed.

3:39 PM Changeset in webkit [2251] by rjw

• 3 edits in trunk/WebKit

Danger Will Robinson. We have to poseAsClass: as early as possible
so that any NSViews will be created with the appropriate poser.
This problem manifested itself with SimpleViewer failing
immediately. NSViews were created by loading a nib before
WebHTMLView class initialization occured. After posing the
already instantiated instances of NSView had a %NSView class,
causing many things to break.

• WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):

2:27 PM Changeset in webkit [2250] by darin

• 3 edits in trunk/JavaScriptCore

Fixed problems parsing numbers that are larger than a long with parseInt.

• kjs/config.h: Define HAVE_FUNC_STRTOLL.
• kjs/function.cpp: (GlobalFuncImp::call): Change parseInt to use strtoll if available.

2:07 PM Changeset in webkit [2249] by darin

• 5 edits in trunk/JavaScriptCore

• kjs/config.h: Define HAVE_FUNC_STRTOLL.
• kjs/function.cpp: (GlobalFuncImp::call): Change parseInt to use strtoll if available.

2:07 PM Changeset in webkit [2248] by rjw

• 6 edits in trunk/WebKit

Ensure that we return non-nil request from handle:willSendRequest:
even when WK's laod delegate is nil.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:willSendRequest:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]):

1:43 PM Changeset in webkit [2247] by darin

• 7 edits in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Add dprintf, NSLog, and NSException to the list of tokens that introduce non-localizable strings, and added handling for square brackets.

WebFoundation:

• CacheLoader.subproj/WebResourceLoad.m: (_loadSweeper):
• Database.subproj/WebFileDatabase.m: (-[WebFileReader initWithPath:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Changed logging code to take advantage of the fact that we once-again support %@.

• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addRequestMessageBody:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _addRequestMessageBody:]): Fixed logging code to eliminate a leak.

• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler debugStringForCacheAttributeValue:]): Changed this code to just call description instead of using string formatting.

• English.lproj/StringsNotToBeLocalized.txt: Add more exceptions. We now have a completely-clean run of extract-localizable-strings in WebFoundation!

• English.lproj/Localizable.strings: Re-generated.

WebKit:

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel loadNib]): Use ERROR instead of NSLog here. (-[WebAuthenticationPanel setUpForRequest:]): Mark some strings for localization.

• WebKit.pbproj/project.pbxproj: Change the encoding on a lot more files to UTF-8.

• English.lproj/StringsNotToBeLocalized.txt: Added some new exceptions.
• English.lproj/Localizable.strings: Re-generated.

WebBrowser:

More progress on localization.

• English.lproj/StringsNotToBeLocalized.txt: Added a few strings.

• GlobalHistory.m: (-[GlobalHistory outlineView:objectValueForTableColumn:byItem:]): Marked a string for localization.

• FrameProgressEntry.m: (-[FrameProgressEntry updateKeyFrom:to:dataSource:]): Added an assert in case we run into an issue like the one from earlier today.

• English.lproj/Localizable.strings: Re-generated.

1:32 PM Changeset in webkit [2246] by rjw

• 2 edits in trunk/WebKit/WebView.subproj

Actually checkin.

11:51 AM Changeset in webkit [2245] by rjw

• 4 edits
  2 deletes in trunk/WebKit

Changed WebDOMNode name to WebDebugDOMNode to make room for
real node.

• Debug/DOMTree.m: (-[DOMTreeDataSource initWithWebView:]): (-[DOMTree itemSelected:]):

Changed WebDOMNode name to WebDebugDOMNode to make room for
real node.

• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDOMNode.h: Removed.
• WebView.subproj/WebDOMNode.m: Removed.