Context Navigation

← Previous Period
Next Period →

Timeline

Oct 14, 2002:

11:20 PM Changeset in webkit [2323] by hyatt

5 edits in trunk/WebCore

More collapsing margin surgery. Working on setting up blocks
to properly compute their collapsed margins (without actually changing
the obsolete collapsing behavior yet).

khtml/rendering/render_flow.cpp: (RenderFlow::RenderFlow): (RenderFlow::layout): (RenderFlow::layoutBlockChildren):
khtml/rendering/render_flow.h:

10:34 PM Changeset in webkit [2322] by cblu

14 edits in trunk/WebKit

WebFoundation:

Renamed filenameByCorrectingExtensionOfFilename:withMIMEType: to filenameWithURL:andMIMEType:
It comes up with the best filename for a URL and MIME type.

Misc.subproj/WebFileTypeMappings.h:
Misc.subproj/WebFileTypeMappings.m:

WebKit:

Made all downloads no matter how prompted, pass through the content policy API so the client can properly choose the file name and correct the extension if necessary. We now ask for the content policy even if one has been predetermined.

WebView.subproj/WebControllerPolicyDelegate.h:
WebView.subproj/WebControllerPrivate.h:
WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:withContentPolicy:]): Renamed, set the predetermined content policy.
WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate downloadURL:]): call [WebController _downloadURL:withContentPolicy:]
WebView.subproj/WebDefaultPolicyDelegate.m:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call [WebController _downloadURL:withContentPolicy:]
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): call [WebController _downloadURL:withContentPolicy:]
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): ask for content policy even if one is predetermined

WebBrowser:

Support for content policy API change. Properly handle the predetermined content policy.
Minor clean-up in DownloadProgressEntry.

BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andURL:inFrame:withContentPolicy:]): Properly handle the predetermined content policy.
DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): Use bytesLoaded and bytesExpected var names (-[DownloadProgressEntry setCompleted]): set bytesExpected to bytesLoaded (-[DownloadProgressEntry updateProgressUI]): slight rearrange.

7:04 PM Changeset in webkit [2321] by hyatt

4 edits in trunk/WebCore

Adding helper functions for handling of collapsing margins.
Not used yet.

khtml/rendering/render_object.h:

4:27 PM Changeset in webkit [2320] by darin

4 edits in trunk/WebCore

Fixed problems with named colors.

kwq/KWQColor.mm: (QColor::setNamedColor): Check named colors before hex codes for colors because our hex code parsing is now lenient enough that many names qualify.

4:27 PM Changeset in webkit [2319] by cblu

6 edits in trunk/WebKit

WebFoundation:

Added new method that corrects a filename's extension based on its MIME type.

Misc.subproj/WebFileTypeMappings.h:
Misc.subproj/WebFileTypeMappings.m: (-[WebFileTypeMappings filenameByCorrectingExtensionOfFilename:withMIMEType:]): if the extension does not correspond with the MIME type, correct it using the preferred MIME type.

WebKit:

Cleaned up download handler and download progress delegate interactions.
Got rid of error suppression junk.
Only send 1 final message to the download progress delegate

WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:forHandle:]): no error suppression (-[WebMainResourceClient didCancelWithHandle:]): ignore cancel errors because 1 download error is enough (-[WebMainResourceClient handleDidFinishLoading:]): don't send the special and odd final message to the download progress delegate (-[WebMainResourceClient handle:didReceiveData:]): no error suppression (-[WebMainResourceClient handle:didFailLoadingWithError:]): ignore cancel errors because 1 download error is enough

WebBrowser:

Correct extensions of filenames of downloaded files based on MIME type. This fixes issues with files that have random extensions and thus not claimed by any application.
Cleaned up DownloadMonitor. Got rid of bottle-neck progress method that caused much confusion and bugs.

BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:URL:inFrame:]): call [WebFileTypeMappings filenameByCorrectingExtensionOfFilename:withMIMEType:]
DownloadMonitor.m: (-[DownloadMonitor _entryForDataSource:]): renamed (-[DownloadMonitor _entryForView:]): renamed (-[DownloadMonitor resourceRequest:didReceiveResponse:fromDataSource:]): create new download entry (-[DownloadMonitor resourceRequest:didReceiveContentLength:fromDataSource:]): increment progress of download entry (-[DownloadMonitor resourceRequest:didFinishLoadingFromDataSource:]): setCompleted on the download entry (-[DownloadMonitor resourceRequest:didFailLoadingWithError:fromDataSource:]): set error and setCompleted on the download entry
DownloadProgressEntry.h:
DownloadProgressEntry.m: (-[DownloadProgressEntry awakeFromNib]): progress bar should be determinate by default (-[DownloadProgressEntry setCompleted]): replaces _cleanUpIfComplete, have the DownloadMonitor tell us when we're done.

4:23 PM Changeset in webkit [2318] by hyatt

4 edits in trunk/WebCore

Really fixing zeldman.com this time. This disabling stuff
is complicated! :)

khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseAttribute): (HTMLLinkElementImpl::setStyleSheet): (HTMLLinkElementImpl::sheetLoaded):

1:33 PM Changeset in webkit [2317] by darin

12 edits in trunk/WebKit

Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkFromDictionaryRepresentation:withGroup:]):
Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]):
Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]):
Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]): Add checking since we don't "trust" the dictionary passed in.

History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]): Add FIXME about adding the checking.

Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup initWithFile:]): Use copy, not retain.

WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Fix storage leak by releasing the default context menu delegate.

WebView.subproj/WebControllerPrivate.h: Tweak.

12:46 PM Changeset in webkit [2316] by hyatt

4 edits in trunk/WebCore

Stop the insanity. Make sure that a sheet that is disabled
while it is still loading is removed from the doc's list
of pending sheets (for FOUC checks).

Fixes zeldman.com.

khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseAttribute):

10:20 AM Changeset in webkit [2315] by cblu

4 edits in trunk/WebKit

Made WebNetscapePluginStream retain a WebNetscapePluginEmbeddedView not a WebBaseNetscapePluginView.

Plugins.subproj/WebNetscapePluginStream.h:
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):

12:19 AM Changeset in webkit [2314] by hyatt

6 edits in trunk/WebCore

Implementing the ability to individually enable/disable
both preferred and alternate stylesheets. Enabling/disabling
sheets via the disabled property of the <link> element overrides
whether or not a sheet happens to be alternate or preferred.

This new implementation of sheet disabling/enabling was a missing
piece of our HTML4 compliance, and was used by the Wired
site to implement its text sizing mechanism.

khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLLinkElementImpl::parseAttribute): (HTMLLinkElementImpl::process):
khtml/html/html_headimpl.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector):

Oct 13, 2002:

11:44 PM Changeset in webkit [2313] by darin

3 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Added strings from WebBookmarkProxy.m.

11:16 PM Changeset in webkit [2312] by cblu

7 edits
6 adds
2 deletes in trunk/WebKit

Eliminated the dual-role behavior of WebPluginStream. Renamed WebPluginStream to WebBaseNetscapePluginStream.

WebNetscapePluginRepresentation, a subclass of WebNetscapePluginRepresentation, is the document representation for standalone plug-ins. WebNetscapePluginStream, also a subclass of WebNetscapePluginRepresentation, is the general plug-in stream loader for embedded plug-ins or plug-in requested streams.

23 plug-in source files with more likely to come!

Plugins.subproj/WebBaseNetscapePluginStream.h: Added.
Plugins.subproj/WebBaseNetscapePluginStream.m: Added. (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream setPluginPointer:]): (-[WebBaseNetscapePluginStream setResponse:]): (-[WebBaseNetscapePluginStream receivedData:]): (-[WebBaseNetscapePluginStream receivedError:]): (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setWindow]): (-[WebBaseNetscapePluginView pluginPointer]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
Plugins.subproj/WebNetscapePluginDocumentView.m:
Plugins.subproj/WebNetscapePluginRepresentation.h: Added.
Plugins.subproj/WebNetscapePluginRepresentation.m: Added. (-[WebNetscapePluginRepresentation setDataSource:]): (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]):
Plugins.subproj/WebNetscapePluginStream.h: Added.
Plugins.subproj/WebNetscapePluginStream.m: Added. (-[WebNetscapePluginStream setCurrentURL:]): (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream stop]): (-[WebNetscapePluginStream loadEnded]): (-[WebNetscapePluginStream handle:willSendRequest:]): (-[WebNetscapePluginStream handle:didReceiveResponse:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase init]):
Plugins.subproj/WebPluginStream.h: Removed.
Plugins.subproj/WebPluginStream.m: Removed.
WebKit.pbproj/project.pbxproj:

Oct 11, 2002:

11:10 PM Changeset in webkit [2311] by rjw

5 edits in trunk/WebCore

Avoid one-click crasher.

Debug/SnippetController.m: (-[SnippetController load]):

Remove debugging.

kwq/WebCoreDOMDocument.mm: (+[WebCoreDOMDocument documentWithImpl:DOM::]):
kwq/WebCoreDOMNode.mm: (-[WebCoreDOMNode lastChild]):

10:49 PM Changeset in webkit [2310] by rjw

18 edits in trunk

More implementation of snippet viewer to show converted
attributed string.

Debug/Snippet.nib:
Debug/SnippetController.h:
Debug/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController awakeFromNib]): (-[SnippetController load]): (lastNode): (-[SnippetController loadComplete]): (-[SnippetController convert:]): (-[SnippetController show:]): (-[SnippetController mainDataSource]): (-[SnippetLocationChangeDelegate initWithController:]): (-[SnippetLocationChangeDelegate locationChangeDone:forDataSource:]): (-[AttributedStringView dealloc]): (-[AttributedStringView setAttributedString:]): (-[AttributedStringView drawRect:]):

More DOM/attributed string work.

WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
WebView.subproj/WebHTMLRepresentationPrivate.h:

More DOM/attributed string work. Still need to fix more
inappropriate casting problems.

khtml/dom/dom_node.cpp: (Node::lastChild):
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::lastChild): (NodeBaseImpl::lastChild):
khtml/xml/dom_nodeimpl.h:
kwq/KWQKHTMLPartImpl.cpp: (KWQKHTMLPartImpl::selectionStartOffset): (KWQKHTMLPartImpl::selectionEndOffset): (KWQKHTMLPartImpl::selectionStart): (KWQKHTMLPartImpl::selectionEnd):
kwq/KWQKHTMLPartImpl.h:
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge DOMDocument]): (-[WebCoreBridge setSelectionFrom:startOffset:to:endOffset:]): (attributedString): (-[WebCoreBridge selectedAttributedString]): (-[WebCoreBridge attributedStringFrom:startOffset:to:endOffset:]):
kwq/WebCoreDOMDocument.mm: (-[WebCoreDOMDocumentType DOM::]): (-[WebCoreDOMDocumentType name]): (-[WebCoreDOMDocumentType entities]): (-[WebCoreDOMDocumentType notations]): (-[WebCoreDOMDocumentType publicId]): (-[WebCoreDOMDocumentType systemId]): (-[WebCoreDOMDocumentType internalSubset]): (-[WebCoreDOMImplementation DOM::]): (-[WebCoreDOMImplementation hasFeature::]): (-[WebCoreDOMImplementation createDocument:::]): (+[WebCoreDOMDocument documentWithImpl:DOM::]): (-[WebCoreDOMDocument DOM::]): (-[WebCoreDOMDocument doctype]): (-[WebCoreDOMDocument implementation]): (-[WebCoreDOMDocument documentElement]): (-[WebCoreDOMDocument createElement:]): (-[WebCoreDOMDocument createElementNS::]): (-[WebCoreDOMDocument createDocumentFragment]): (-[WebCoreDOMDocument createTextNode:]): (-[WebCoreDOMDocument createComment:]): (-[WebCoreDOMDocument createCDATASection:]): (-[WebCoreDOMDocument createProcessingInstruction::]): (-[WebCoreDOMDocument createAttribute:]): (-[WebCoreDOMDocument createAttributeNS::]): (-[WebCoreDOMDocument createEntityReference:]): (-[WebCoreDOMDocument getElementById:]): (-[WebCoreDOMDocument getElementsByTagName:]): (-[WebCoreDOMDocument getElementsByTagNameNS::]): (-[WebCoreDOMDocument importNode::]):
kwq/WebCoreDOMNode.mm: (-[WebCoreDOMNode initWithImpl:DOM::]): (-[WebCoreDOMNode firstChild]): (-[WebCoreDOMNode lastChild]):
kwq/WebCoreDOMPrivate.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectionFrom:startOffset:to:endOffset:]): (recursive_toHTML): (attributedString):

4:22 PM Changeset in webkit [2309] by kocienda

3 edits in trunk/WebKit

Fixed uninitialized variable build breaker I got when
doing a Deployment build.

Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:URLString:type:]):

2:56 PM Changeset in webkit [2308] by sullivan

8 edits
2 adds in trunk/WebKit

WebKit:

Added the concept of bookmark proxies; items that can be
stored and displayed with other bookmarks but represent
a source of bookmark-like items (e.g. Rendezvous, History)

Bookmarks.subproj/WebBookmarkProxy.h: Added.
Bookmarks.subproj/WebBookmarkProxy.m: Added. (-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]): (-[WebBookmarkProxy dictionaryRepresentation]): (-[WebBookmarkProxy bookmarkType]): (-[WebBookmarkProxy copyWithZone:]): (-[WebBookmarkProxy title]): (-[WebBookmarkProxy setTitle:]): (-[WebBookmarkProxy icon]): New class, has a title and that's about it

Bookmarks.subproj/WebBookmark.h:
Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkFromDictionaryRepresentation:withGroup:]): Handle proxy case

Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:URLString:type:]): Handle proxy case

Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]), (-[WebBookmarkList dictionaryRepresentation]): Handle proxy case

Bookmarks.subproj/WebBookmarkPrivate.h: Add #define for proxy

WebKit.pbproj/project.pbxproj: updated for new files

WebBrowser:

started work on moving Address Book, Rendezvous, and History out of their own windows and into the Library view.

The titles Rendezvous/Address Book/History now appear in the
Library view, but they don't do anything. They have no content,
you can't drag them, and if you try to drop something on one
you get a mysterious console message but nothing else happens.

BookmarksController.m: (+[BookmarksController _favoritesTitle]), (+[BookmarksController _menuRootTitle]): just moved in file (+[BookmarksController historyProxyTitle]), (+[BookmarksController addressBookProxyTitle]), (+[BookmarksController rendezvousProxyTitle]): new methods to retrieve localizable titles for these bookmark proxies. (-[BookmarksController imageForBookmark:]): supply the right images for the proxies we know about (-[BookmarksController addMenuItemForBookmark:toMenu:]): handle proxy case (but there isn't yet a way to get one in a menu) (-[BookmarksController _blessOrCreateSpecialFolders]): make sure the right set of proxies are in there where they belong.

BookmarksViewController.m: (-[BookmarksViewController bookmarkForSourceRow:]): (-[BookmarksViewController sourceRowForBookmark:]): (-[BookmarksViewController numberOfRowsInTableView:]): (-[BookmarksViewController canRemoveBookmarkSource:]): (-[BookmarksViewController tableView:shouldEditTableColumn:row:]):
English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt:

2:02 PM Changeset in webkit [2307] by cblu

3 edits in trunk/WebKit

Thought I has checking for nil enough, but not enough as I raised an exception on Avie's machine.

Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin getPluginInfo]): check for the nil extension case

1:33 PM Changeset in webkit [2306] by darin

3 edits in trunk/WebKit

Apply a simplified technique I learned while working on the Favorites button
class in the browser code.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): Use the NSViewFocusDidChangeNotification to track the plugin rectangles instead of the NSViewFrameDidChangeNotification and NSViewBoundsDidChangeNotification on all the superviews.

9:34 AM Changeset in webkit [2305] by sullivan

3 edits in trunk/WebKit

WebKit:

Resources/url_icon.tiff: new generic URL icon -- no more @!

WebBrowser:

some new and improved images from Steve Lemay (more to come)

Resources/Images/FavoritesBar.tif: new little heart
Resources/Images/folder16.tiff: new little folder
Resources/Images/rendezvous.tiff: new rendezvous symbol
Resources/Images/tiny_menu.tiff: new little menu

Oct 10, 2002:

9:07 PM Changeset in webkit [2304] by darin

4 edits in trunk/JavaScriptCore

fixed 3072643 -- infinite loop in JavaScript code at walgreens.com

The problem is that "xxx".indexOf("", 1) needs to return 1, but we
were returning 0.

kjs/ustring.cpp: (UString::find): Return pos, not 0, when the search string is empty. (UString::rfind): Make sure that pos is not past the end of the string, taking into account the search string; fixes a potential read off the end of the buffer. Also return pos, not 0, when the search string is empty.

3:29 PM Changeset in webkit [2303] by darin

4 edits in trunk/WebKit

fixed 3069366 -- REGRESSION: no pop-up window at inkfinder.com

The window now pops up, but it doesn't seem to work right. But I
think the window working right is a separate issue.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Make sure we use the copy of the request that we're keeping around when we call _setRequest on the data source, rather than the copy we're returning which can be modified by WebFoundation. Also rearrange things so we're more likely to get things right when the delegate changes the URL on the request.

3:07 PM Changeset in webkit [2302] by hyatt

4 edits in trunk/WebCore

Fix for 3058829, assertion caused by table cell with
incorrect display type. Implemented a quirk that forces
<td>s of display: block to construct table cells as
rendering objects.