Timeline



Oct 18, 2002:

5:27 PM Changeset in webkit [2374] by rjw
  • 15 edits in trunk

Fixed khtml to ignore <title> tags after the first tag.

Fixed setting document.title from JavaScript.

  • khtml/dom/html_document.cpp: (HTMLDocument::setTitle):
  • khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::childrenChanged):

Changed name to setUsesBackForwardList: from
setUseBackForwardList. ditto for useBackForwardList

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setUsesBackForwardList:]): (-[WebController usesBackForwardList]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]):

Fixed history items that have "untitled" title after
redirect. (3078577).

  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):

Made title of snippet window change to match document title, if
present.

  • Debug/SnippetController.h:
  • Debug/SnippetController.m: (-[SnippetController setTitle:]): (-[SnippetLocationChangeDelegate locationChangeDone:forDataSource:]):
3:08 PM Changeset in webkit [2373] by darin
  • 4 edits in trunk/WebCore
  • fixed 3078293 -- Implement evaluateJavaScript on WebController
  • kwq/KWQVariant.mm: (QVariant::asString): Made this return reasonable values for types other than string. Still may be loose ends left, but this takes care of most of it.
3:00 PM Changeset in webkit [2372] by darin
  • 11 edits in trunk

WebCore:

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:]): Changed to return a string and changed name.

WebKit:

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController stringByEvaluatingJavaScriptFromString:]): Changed to return a string and changed name.

WebBrowser:

  • BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]):
  • BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]): Update to call stringByEvaluatingJavaScriptFromString.
1:49 PM Changeset in webkit [2371] by darin
  • 3 edits in trunk/WebKit

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
  • English.lproj/Localizable.strings: Regenerate after recent changes.

WebKit:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

  • LoadProgressMonitor.m: (-[LoadProgressMonitor _busyStatus]): Say "Contacting <host>" instead of "Looking for <host>" to help reduce confusion about whether this shows up just during DNS or not.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
  • English.lproj/Localizable.strings: Regnerate.
1:26 PM Changeset in webkit [2370] by kocienda
  • 3 edits in trunk/WebKit

Removed unneeded import of WebFoundation/WebResourceLoadManager.h

  • Misc.subproj/WebIconLoader.m
1:20 PM Changeset in webkit [2369] by hyatt
  • 7 edits in trunk/WebCore

The collapsing margin rewrite. Also fixes a bug where
we stay in quirks mode for strict HTML4 dtds when we
shouldn't.

  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::determineParseMode):
  • khtml/rendering/render_flow.cpp: (RenderFlow::layout): (RenderFlow::layoutBlockChildren):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_object.h:
11:10 AM Changeset in webkit [2368] by darin
  • 7 edits in trunk

WebCore:

  • Makefile.am: Move dependency so clean happens before build.

WebKit:

  • Makefile.am: Move dependency so clean happens before build.
11:01 AM Changeset in webkit [2367] by darin
  • 3 edits in trunk/WebKit
  • force-clean-timestamp: Dependencies don't work well enough, so we need a clean build here after the WebFoundation domain change.
10:13 AM Changeset in webkit [2366] by darin
  • 7 edits
    1 delete in trunk/WebKit

WebFoundation:

WebError cleanup. Change domains to be strings, remove unused codes.

  • AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
  • AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _checkForAuthenticationFailureInHTTPResponse:withURL:]): Don't return an error code. The error code was always vague, and never looked at by our one client or exposed outside WebFoundation. If we later want to report a precise error, we can easily re-add it.
  • CacheLoader.subproj/WebResourceLoad.h: Change domain parameter to an NSString *.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]): Ditto.
  • Misc.subproj/WebError.h: Moved WebErrorDomainWebKit to WebKit. Removed WebErrorDomainFTP. Removed WebErrorCodeNoError, WebErrorCodeHTTPUnknownAuthenticationSchemeError, and WebErrorCodeHTTPBadAuthenticationHeaderError, which were never used. Changed methods to take NSString * for the error domain. Added errorIsInDomain method.
  • Misc.subproj/WebError.m: (-[WebErrorPrivate dealloc]): Release the error domain string. (classInitialize): Remove descriptions for now-unused error codes. (-[WebError initWithErrorCode:inDomain:failingURL:]): Take a domain string. (-[WebError errorDomain]): Return the domain string. (-[WebError errorIsInDomain:]): Added. (-[WebError errorDescription]): Update to look up by string. (+[WebError addErrorsWithCodesAndDescriptions:inDomain:]): Use domain string as key.
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler performHTTPHeaderRead:andCall:]): Get rid of the code that stored the authenticationFailureResult, which was never passed to the user.
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.h: Remove authenticationFailureResult.
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler determineErrorAndFail]): Rearrange the code so we don't use WebErrorCodeNoError. Also change the domain so that we don't report the WebErrorCodeCannotConnectToHostError error in the SSL domain any more.
  • WebFoundation.exp: Export the new domain string globals.

WebKit:

Update for WebFoundation error domain changes.

  • Misc.subproj/WebKitErrors.h: Put WebErrorDomainWebKit in here. Also remove WebErrorNoError and the WebErrorCode name for the enum.
  • WebKit.exp: Export the WebErrorDomainWebKit constant.
  • WebView.subproj/WebView.m: Define the WebErrorDomainWebKit.
  • WebKit.pbproj/project.pbxproj: Always use WebKit.exp.
  • Makefile.am: Don't generate WebKit-combined.exp any more.
  • WebKit-tests.exp: Removed.

WebBrowser:

Update for WebFoundation error domain changes.

  • LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): Use the new errorIsInDomain method instead of doing a switch statement, since that works with NSString. (-[LocationChangeHandler specializedMessageForError:]): Ditto.

Oct 17, 2002:

11:41 PM Changeset in webkit [2365] by darin
  • 2 edits in trunk/WebKit
  • fixed 3078644 -- Odd clipping in frame
  • WebView.subproj/WebClipView.h: Add hasAdditionalClip and additionalClip methods.
  • WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Add an assertion. (-[WebClipView setAdditionalClip:]): Ditto. (-[WebClipView hasAdditionalClip]): Added. (-[WebClipView additionalClip]): Added.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView visibleRect]): Turn off the additional clip while computing our visibleRect. This way, the additional clip only affects people who ask for the clip view's visibleRect directly, which basically means just the focus rectangle drawing code we are trying to influence.
11:40 PM Changeset in webkit [2364] by darin
  • 5 edits in trunk/WebKit

A small change that eliminates a variety of strange clipping problems, including ones that
make large swathes of the page disappear.

  • WebView.subproj/WebClipView.h: Add hasAdditionalClip and additionalClip methods.
  • WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Add an assertion. (-[WebClipView setAdditionalClip:]): Ditto. (-[WebClipView hasAdditionalClip]): Added. (-[WebClipView additionalClip]): Added.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView visibleRect]): Turn off the additional clip while computing our visibleRect. This way, the additional clip only affects people who ask for the clip view's visibleRect directly, which basically means just the focus rectangle drawing code we are trying to influence.
5:30 PM Changeset in webkit [2363] by rjw
  • 11 edits in trunk

Support for drawing frame borders and frame resizing. (fixes 2982466).

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge frameBorderStyle]):
  • kwq/qt/qframe.h:

Support for drawing frame borders (fixes 2982466).

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _drawBorder:]): (-[WebHTMLView drawRect:]):
5:18 PM Changeset in webkit [2362] by darin
  • 8 edits in trunk/WebCore
  • fixed 2807340 -- Alex is case sensitive for anchors, but should not be in quirks mode (other browsers aren't)
  • khtml/dom/html_misc.cpp: Touched this file to prevent us from requiring a full build. Damned header dependencies still don't work right.
  • khtml/html/html_miscimpl.h: Add caseSensitive parameters.
  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::getNamedItem): Add caseSensitive parameter, and compare by converting both to lower case if it's false and pass it on when recursing. (HTMLCollectionImpl::namedItem): Pass along a caseSensitive parameter. (HTMLFormCollectionImpl::getNamedItem): Pass along a caseSensitive parameter. (HTMLFormCollectionImpl::getNamedFormItem): Pass along, and handle, it. (HTMLFormCollectionImpl::getNamedImgItem): Ditto. (HTMLFormCollectionImpl::nextNamedItemInternal): Pass true for caseSensitive.
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): Pass false for the new caseSensitive parameter to namedItem when the document mode is not strict.
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines): Removed a stray NSLog that I left in by accident.
4:04 PM Changeset in webkit [2361] by darin
  • 6 edits in trunk/WebCore
  • fixed 3052547 -- <select> doesn't size properly (size > 1)
  • khtml/rendering/render_form.cpp: (RenderLineEdit::slotReturnPressed): #if !APPLE_CHANGES around some unused code in here. (RenderSelect::updateFromElement): Fix bug where it was using Multi here, but Extended elsewhere for the selection mode. (RenderSelect::layout): Change code so that QListBox handles the sizing.
  • kwq/KWQListBox.h: Removed a lot of unused stuff, made other things use inlines.
  • kwq/KWQListBox.mm: Rewrote most of the file contents. Made a new QListBox::sizeForNumberOfLines method. We will have to port this to NSTableView rather than NSBrowser.
2:05 PM Changeset in webkit [2360] by darin
  • 4 edits in trunk/WebCore
  • fixed 3078245 -- REGRESSION: lightgrey displays as black, used to display as white, should display light gray
  • kwq/KWQColor.mm: (getNamedColors): For every color with the name "gray" in it, also include the version spelled "grey" as other browsers seem to.
1:14 PM Changeset in webkit [2359] by sullivan
  • 8 edits in trunk/WebKit

WebKit:

  • added support for bookmark identifiers, to be used for marking bookmark proxies uniquely (independent of localized title). This is not the old unique-identifier scheme; now identifiers are optional, and initially nil, but the client can use them for its own purposes.
  • Bookmarks.subproj/WebBookmark.h:
  • Bookmarks.subproj/WebBookmark.m: (-[WebBookmark dealloc]): release identifier (-[WebBookmark identifier]): return identifier (-[WebBookmark setIdentifier:]): set identifier
  • Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkLeaf dictionaryRepresentation]): save identifier (-[WebBookmarkLeaf copyWithZone:]): copy identifier
  • Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkList dictionaryRepresentation]): save identifier (-[WebBookmarkList copyWithZone:]): copy identifier
  • Bookmarks.subproj/WebBookmarkPrivate.h:
  • Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkProxy dictionaryRepresentation]): save identifier (-[WebBookmarkProxy copyWithZone:]): copy identifier

WebBrowser:

  • a bunch of work in the direction of getting the special "bookmark sources" to work in the bookmarks view. The Address Book contents now appear in the Bookmarks view, but Rendezvous and History don't yet.
  • BookmarkSource.h: Added. Defines protocol to be used by special bookmark sources.
  • BookmarksController.h: define identifier constants used for special bookmark sources.
  • BookmarksController.m: (-[BookmarksController _blessOrCreateSpecialFolders]): set identifiers on bookmark proxies representing special bookmark sources
  • BookmarksViewController.m: (-[BookmarksViewController undoRemoveBookmarks:]): (-[BookmarksViewController selectedContentItems]): (-[BookmarksViewController deleteContentItems:]): (-[BookmarksViewController deleteSelectedContentItems]): (-[BookmarksViewController doubleClick:]): (-[BookmarksViewController newBookmarkFolder:]): (-[BookmarksViewController bookmarkSourceForProxyIdentifier:]): (-[BookmarksViewController refreshContents]): (-[BookmarksViewController bookmarksFromContentItems:]): (-[BookmarksViewController bookmarkFromContentItem:]): (-[BookmarksViewController canAddToBookmarkSource:]): (-[BookmarksViewController canAddToSelectedBookmarkSource]): (-[BookmarksViewController canDeleteFromSelectedBookmarkSource]): (-[BookmarksViewController child:ofContentItem:]): (-[BookmarksViewController isContentItemExpandable:]): (-[BookmarksViewController numberOfChildrenOfContentItem:]): (-[BookmarksViewController titleStringForContentItem:]): (-[BookmarksViewController addressStringForContentItem:]): (-[BookmarksViewController imageForContentItem:]): (-[BookmarksViewController shouldEditTableColumn:forContentItem:]): (-[BookmarksViewController tableView:draggingSourceOperationMaskForLocal:]): (-[BookmarksViewController cleanUpAfterDraggingBookmarksWithOperation:]): (-[BookmarksViewController prepareForDraggingBookmarks:fromSourceColumn:]): (-[BookmarksViewController tableView:validateDrop:proposedRow:proposedDropOperation:]): (-[BookmarksViewController handleKeyDown:inSourceColumn:]): (-[BookmarksViewController tableViewSelectionDidChange:]): (-[BookmarksViewController outlineView:child:ofItem:]): (-[BookmarksViewController outlineView:isItemExpandable:]): (-[BookmarksViewController outlineView:numberOfChildrenOfItem:]): (-[BookmarksViewController outlineView:objectValueForTableColumn:byItem:]): (-[BookmarksViewController outlineView:draggingSourceOperationMaskForLocal:]): (-[BookmarksViewController outlineView:writeItems:toPasteboard:]): (-[BookmarksViewController outlineView:willDisplayCell:forTableColumn:item:]): (-[BookmarksViewController outlineView:shouldEditTableColumn:item:]): (-[BookmarksViewController copy:]): (-[BookmarksViewController delete:]): My brain gets sore thinking about writing individual comments here. Basically I generalized methods that were dealing explicitly with bookmarks to deal with opaque "content items" instead, then delegate to the appropriate BookmarkSource in the bottleneck methods. Only Address Book is hooked up so far. This also fixed lots of trouble you could get into if you played with the "not implemented yet" items too much.
  • ABHomePagesController.h:
  • ABHomePagesController.m: (-[ABHomePagesController refreshContents]): (-[ABHomePagesController canDeleteContents]): (-[ABHomePagesController deleteContentItems:]): (-[ABHomePagesController isContentItemExpandable:]): (-[ABHomePagesController child:ofContentItem:]): (-[ABHomePagesController numberOfChildrenOfContentItem:]): (-[ABHomePagesController bookmarkFromContentItem:]): (-[ABHomePagesController bookmarksFromContentItems:]): (-[ABHomePagesController addressStringForContentItem:]): (-[ABHomePagesController titleStringForContentItem:]): (-[ABHomePagesController imageForContentItem:]): Implement BookmarkSource protocol; I haven't deleted all the similar code that drives the Address Book window yet.
  • English.lproj/MainMenu.nib: changed "Last Search Results" to "SnapBack to Search" under protest.
  • WebBrowser.pbproj/project.pbxproj: updated for new file
12:06 PM Changeset in webkit [2358] by hyatt
  • 4 edits in trunk/WebCore

Make navigator.product dynamic based off user agent (i.e.,
make it participate in spoofing too).

  • khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty):
11:10 AM Changeset in webkit [2357]
  • 3 copies in tags/Alexander-28

This commit was manufactured by cvs2svn to create tag 'Alexander-28'.

11:10 AM Changeset in webkit [2356] by sheridan
  • 8 edits in trunk

Alex-28

10:12 AM Changeset in webkit [2355] by darin
  • 5 edits in trunk/WebCore
  • fixed 3077856 -- REGRESSION: scroll to fragment doesn't work (except when Alex started from command line)
  • kwq/kparts/browserextension.h: Initialize reload to false. It was uninitialized, and when true was preventing anchor navigation from working.
9:48 AM Changeset in webkit [2354] by darin
  • 4 edits in trunk/WebKit
  • fixed 3062613 -- too many redirects at nytimes.com and apple

Our cookie policy was rejecting the cookies from nytimes.com -- the policy base
URL was still the news.com URL from before the redirect.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Update the cookie policy URL when a redirect changes the data source's URL.
9:17 AM Changeset in webkit [2353] by darin
  • 3 edits in trunk/WebKit
  • fixed 3077910 -- REGRESSION: download window open at startup time -> no scrollbars
  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Check for WebDocumentView protocol before making the layout method call. Prevents exception when WebDynamicScrollBarsView is used with a document that is not a WebDocumentView.
1:05 AM Changeset in webkit [2352] by darin
  • 4 edits in trunk/WebCore
  • khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): Don't recurse on the same child twice. (RenderFlow::rightmostPosition): Ditto.
1:03 AM Changeset in webkit [2351] by hyatt
  • 4 edits in trunk/WebCore

Fix bayarea.com. My implementation of offsetParent was
flawed. And to think I was blaming Gecko... ;)

  • khtml/rendering/render_object.cpp: (RenderObject::offsetParent):

Oct 16, 2002:

10:43 PM Changeset in webkit [2350] by darin
  • 5 edits in trunk/WebCore
  • fixed 3061103 -- Line-breaks lost when submitting after pasting text from MSIE into Alexander textarea
  • kwq/KWQLineEdit.mm: (QLineEdit::text):
  • kwq/KWQTextEdit.mm: (QTextEdit::text): Turn \r\n sequences and standalone \r characters into \n characters on the way out of AppKit land and into KHTML land. I didn't try to make this efficient for the common case because these are not time-critical functions.
6:08 PM Changeset in webkit [2349] by rjw
  • 13 edits in trunk

i Fixed a few regressions in drawing of frame resize handle

in preparation for drawing frame borders and completing
2982466.

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize):
  • kwq/KWQPainter.mm: (QPainter::drawRect):
  • kwq/qt/qscrollview.h:
  • kwq/KWQScrollView.mm: (QScrollView::updateContents):
  • kwq/KWQWidget.mm: (QWidget::enableFlushDrawing):

Use static_cast everywhere DOM::NodeImpl is cast to
subclass.

  • kwq/WebCoreDOMNode.mm: (-[WebCoreDOMNode DOM::]): (-[WebCoreDOMNodeList DOM::]): (-[WebCoreDOMNamedNodeMap DOM::]): (-[WebCoreDOMAttr DOM::]):

Added some drawing debug code (ifdef excluded).

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
5:37 PM Changeset in webkit [2348] by hyatt
  • 7 edits in trunk/WebCore

Fix crash on pages with bulleted lists. Making sure the list
item marker doesn't get a layer (which means it has to be
painted by hand now by the list item object).

  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
  • khtml/rendering/render_list.cpp: (RenderListItem::printObject):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.h:
5:01 PM Changeset in webkit [2347] by darin
  • 4 edits in trunk/WebCore
  • fixed 3072542 -- double "&" in submit button
  • khtml/rendering/render_form.cpp: (RenderSubmitButton::rawText): Don't double the "&" character, not needed for KWQ.
4:49 PM Changeset in webkit [2346] by darin
  • 3 edits in trunk/WebKit

Fixed anomalies with plugin positioning caused by my switch to
NSViewFocusDidChangeNotification. Turns out that is not sent during
live resize, but we need things to work during live resize.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): Register for changes in the bounds and frame of all superviews again, instead of using NSViewFocusDidChangeNotification.
4:28 PM Changeset in webkit [2345] by hyatt
  • 5 edits in trunk/WebCore

When render objects were being dynamically wrapped in anonymous
blocks, the layer parenting connection was being broken without
being reconnected when the wrapping finished. This patch
shifts the layer connection into the functions that are also
called in the dynamic case.

With this fix, all objects on mrskin finally show up. Yeehah.
brainjar.com's brain is back too.

This patch also stops treating images as inline if they are
using abs/fixed positioning, since according to the CSS spec,
abs/fixed positioned elements should be treated as block-level
content.

  • khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/rendering/render_image.cpp: (RenderImage::setStyle):
4:24 PM Changeset in webkit [2344] by darin
  • 9 edits in trunk/WebCore
  • fixed 3045570 -- can't select a printer at inkfinder.com
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Call the new openURL for the case where we are reusing a part. We do this backwards from how KHTML does, so it's twisted.
  • kwq/KWQKHTMLPartImpl.h: Add openURL.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Tell the bridge to load the URL.
  • kwq/mac-encodings.txt: Tweak Korean encoding names.
3:41 PM Changeset in webkit [2343] by rjw
  • 3 edits in trunk/WebKit

Fixed 2969367. Ensure layout happens before doing check
to determine if scrollbars are needed. Ahhh, dynamic
scrollbars work so much better now.

  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
3:01 PM Changeset in webkit [2342] by darin
  • 3 edits in trunk/WebKit

Fixed the problem where we would leave white bits when making the window larger.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): During live resize, use the visible rectangle after doing layout, not before.
2:55 PM Changeset in webkit [2341] by hyatt
  • 9 edits in trunk/WebCore

A very substantial change. Absolute/fixed positioned elements that
are NOT renderflows were not getting layers constructed for them.
They do now.

Also, floats now have layers constructed for them. This allows
printSpecialObjects to be completely eliminated, enables smarter
damge rect intersection testing for faster painting, and fixes
regressions on sites like www.demian5.com.

  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
  • khtml/rendering/render_flow.cpp: (RenderFlow::printObject): (RenderFlow::addOverHangingFloats): (RenderFlow::printTree):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
  • khtml/rendering/render_root.cpp: (RenderRoot::printObject):
  • khtml/rendering/render_table.cpp: (RenderTable::print):
1:40 PM Changeset in webkit [2340] by rjw
  • 10 edits in trunk

Fixed 3059237, which was fixed, but regressed.

Fixed regression in visited links due to change is semantics of
[dataSource request], added [dataSource _originalRequest]. Items
always need to be added to history with the original request.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _originalRequest]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):

Removed bogus code.

  • kwq/KWQKHistoryProvider.mm:
10:03 AM Changeset in webkit [2339] by darin
  • 11 edits in trunk/WebKit

WebKit:

  • fixed 3017152 -- intra-page anchors not updating page address field
  • WebView.subproj/WebLocationChangeDelegate.h: Rearrange methods so they are in the order they are delivered. Add locationChangedWithinPageForDataSource method. Renamed the redirect methods to match the verb tenses used in the others. Removed the URL parameter from the server redirect method.
  • WebView.subproj/WebLocationChangeDelegate.m: Update the class to match the changes to the protocol.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Update for change to clientWillRedirectTo method name. (-[WebBridge loadURL:]): Call locationChangedWithinPageForDataSource:.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Update for change to serverRedirectedForDataSource method name.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseMovedNotification:]): Remove overzealous assert that was firing for me.
  • WebCoreSupport.subproj/WebSubresourceClient.m: Update comment.
  • WebView.subproj/WebDataSource.h: Fix comment.

WebBrowser:

WebBrowser changes to handle location changes within a page (clicks on anchors).

  • BrowserWindowController.h: Added mainFrameLocationChangedWithinPage.
  • BrowserWindowController.m: (-[BrowserWindowController mainFrameLocationChangedWithinPage]): Calls setLocationFieldTextToCurrentURL.
  • LocationChangeHandler.m: (-[LocationChangeHandler serverRedirectedForDataSource:]): Updated name to track change in WebKit. Also removed unnecessary calls to titleChangedForFrame and to _currentURLHasChanged, since both are only needed if the data source is committed, and server redirects always come before it is committed. (-[LocationChangeHandler locationChangedWithinPageForDataSource:]): Added. Has much of what used to be in serverRedirectedForDataSource, and also calls the new mainFrameLocationChangedWithinPage. (-[LocationChangeHandler clientWillRedirectTo:delay:fireDate:forFrame:]): Updated name to track change in WebKit.

Oct 15, 2002:

6:42 PM Changeset in webkit [2338] by rjw
  • 6 edits in trunk/WebCore
  • kwq/WebCoreBridge.mm: (attributedString): Don't convert element unless it has a renderer.
  • kwq/WebCoreDOMNode.mm: (-[WebCoreDOMAttr DOM::]): (-[WebCoreDOMAttr name]): (-[WebCoreDOMAttr specified]): (-[WebCoreDOMAttr value]): (-[WebCoreDOMAttr ownerElement]): (-[WebCoreDOMElement tagName]): (-[WebCoreDOMElement setAttribute::]): (-[WebCoreDOMElement removeAttribute:]): (-[WebCoreDOMElement getAttributeNode:]): (-[WebCoreDOMElement removeAttributeNode:]): (-[WebCoreDOMElement getElementsByTagName:]): (-[WebCoreDOMElement getAttributeNS::]): (-[WebCoreDOMElement setAttributeNS:::]): (-[WebCoreDOMCharacterData data]): (-[WebCoreDOMCharacterData setData:]): (-[WebCoreDOMCharacterData length]): (-[WebCoreDOMCharacterData substringData::]): (-[WebCoreDOMCharacterData appendData:]): (-[WebCoreDOMCharacterData insertData::]): (-[WebCoreDOMCharacterData deleteData::]): (-[WebCoreDOMText splitText:]): (-[WebCoreDOMProcessingInstruction data]): (-[WebCoreDOMProcessingInstruction setData:]):
  • kwq/WebCoreDOMPrivate.h: API cleanup.
5:39 PM Changeset in webkit [2337] by hyatt
  • 4 edits in trunk/WebCore

More work on making blocks correctly compute their maximal
positive and negative margins. Adding code to ensure
that floats and absolute/fixed positioned elements know
not to collapse with children or with themselves. Also adding
code to teach empty blocks that they can collapse their own
margins together.

  • khtml/rendering/render_flow.cpp: (RenderFlow::layout): (RenderFlow::layoutBlockChildren):
5:15 PM Changeset in webkit [2336] by darin
  • 18 edits in trunk

WebCore:

WebCore support for using referrer even in loads that are not initiated
by WebCore itself.

  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Don't pass a referrer. We get the referrer from the part.
  • kwq/KWQKHTMLPartImpl.h: Add a new referrer method that works on the part, and remove the old one that got it from the URL arguments.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Don't pass a referrer when creating a new window. (KWQKHTMLPartImpl::openURLRequest): Don't pass a referrer when doing a load. (KWQKHTMLPartImpl::urlSelected): Don't pass a referrer when doing a load. (KWQKHTMLPartImpl::createPart): Don't pass a referrer when creating a child frame for this window. (KWQKHTMLPartImpl::submitForm): Don't pass a referrer when doing a load. (KWQKHTMLPartImpl::referrer): Added.
  • kwq/KWQLoaderImpl.mm: (KWQServeRequest): Don't pass a referrer when starting a load.
  • kwq/WebCoreBridge.h: Add referrer method. Remove referrer parameter from many other methods.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge referrer]): Added.

WebKit:

  • fixed 3062393 -- need to send proper referrer for "open in new window" menu items and keyboard shortcuts
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): Don't take a referrer parameter any more. Get the referrer by calling to the other side of the bridge, instead. (-[WebBridge startLoadingResource:withURL:]): Ditto. (-[WebBridge loadURL:]): Ditto. (-[WebBridge postWithURL:data:contentType:]): Ditto. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto.
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]): Don't take a referrer parameter, which was always nil anyway. Instead, get the referrer from the bridge. (-[WebDefaultContextMenuDelegate openLinkInNewWindow:]): Don't pass nil for referrer. (-[WebDefaultContextMenuDelegate openImageInNewWindow:]): Ditto. (-[WebDefaultContextMenuDelegate openFrameInNewWindow:]): Ditto.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Pass a referrer from the bridge, rather than nil, for both WebClickPolicyOpenNewWindow and WebClickPolicyOpenNewWindowBehind.
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Add a FIXME.
4:48 PM Changeset in webkit [2335] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/WebDataSourcePrivate.h: Remove unused stuff.
  • WebView.subproj/WebDataSourcePrivate.m: Ditto.
4:35 PM Changeset in webkit [2334] by darin
  • 4 edits in trunk/WebCore
  • fixed 3021713 -- text selection background obliterates descenders (in www.theregister.co.uk articles)
  • fixed 3038207 -- Selected link text doesn't draw its link underline
  • khtml/rendering/render_text.cpp: (TextSlave::printSelection): Don't draw text at all, just draw a selection background. (RenderText::printObject): Draw in two passes. Draw the selection background in the first pass, and the text in the second pass. That way pieces of the background won't cover any other text or adornments, like underlines.
3:44 PM Changeset in webkit [2333] by darin
  • 16 edits in trunk

WebCore:

  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Move the special case of a different anchor within the same page into WebKit from here.
  • kwq/kdecore/kurl.h: Mark urlcmp as a friend.
  • kwq/KWQKURL.mm: (urlcmp): Implement the ignoreRef feature, which is needed to make the KHTMLPart::openURL function work right.
  • kwq/WebCoreBridge.h: Removed addBackForwardItemWithURL:anchor: and added URL method.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge URL]): Added.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:]): Add a special case for when the URL is the same as the previous URL for the same frame. This relies on some logic in KHTML's openURL method that handles this case too.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Don't bother keeping an inputURL. (-[WebDataSource URL]): Just return [[self request] URL]. Maybe we can remove this altogether.
  • WebView.subproj/WebDataSourcePrivate.h: Remove inputURL, finalURL.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): No need to release inputURL, finalURL. (-[WebDataSource _setURL:]): Used only by the new code above. Makes a copy of the request, changes the URL, and then drops the old request. (-[WebDataSource _setRequest:]): Changed to no longer call _setURL. Now does much of the work that _setURL used to do.
1:49 PM Changeset in webkit [2332] by darin
  • 13 edits in trunk

WebCore:

The key was to make the name attribute work properly.

  • khtml/ecma/kjs_window.cpp: (Window::get): Enable the "name" attribute. (Window::put): Enable the "name" attribute, but don't do the conversion to an 8-bit string -- leave it as a QString.
  • kwq/WebCoreBridge.h: Add setName/name methods.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setName:]): Added. Calls part->setName(). (-[WebCoreBridge name]): Added. Calls part->name().
  • kwq/kparts/part.h: Added setName/name to ReadOnlyPart.
  • kwq/KWQKHTMLPartImpl.mm: Remove old bogusish comment.

WebKit:

WebKit part of improved frame name support.

  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Call setName on the newly created part.
1:01 PM Changeset in webkit [2331] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3075777 -- hysteresis for dragging links on web pages is still too large
  • WebView.subproj/WebHTMLView.m: changed hysteresis constants; added comment.
12:52 PM Changeset in webkit [2330] by darin
  • 3 edits in trunk/WebKit

Fix problem where timer was lasting after window was closed.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Add a call to [_private->bridge closeURL].
12:51 PM Changeset in webkit [2329] by rjw
  • 4 edits in trunk/WebCore

Added text color to attributed string conversion.

  • kwq/WebCoreBridge.mm: (attributedString):
12:47 PM Changeset in webkit [2328] by rjw
  • 8 edits in trunk

Added attributed string to pasteboard. Fixes 3006760.
We may want to scale back the content that is included in the
attributed string. Currently all text nodes in the selection
are converted. This include text nodes for non-visible content,
i.e. scripts.
[Note we may also want to put HTML snippet on the pboard. The appkit
does support reading text using htmldisplay today. Of course this should
eventually migrate to use WebView.]

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView copy:]):

Added API to get attributed string from bridge.
Added API to get selection in terms of the DOM API
from the bridge.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (attributedString): (-[WebCoreBridge selectionStart]): (-[WebCoreBridge selectionStartOffset]): (-[WebCoreBridge selectionEnd]): (-[WebCoreBridge selectionEndOffset]):
11:20 AM Changeset in webkit [2327] by darin
  • 5 edits in trunk/WebCore
  • fixed 3054791 -- crash in WebCoreSettings _updateAllViews changing font
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Pass in the "this" pointer so that the right instance is removed from the instances list. Before, we would always remove the first instance from the list, leaving the list broken.
11:19 AM Changeset in webkit [2326] by darin
  • 3 edits in trunk/WebKit

Fixed bug where URLs dragged to the content area were not made canonical
the way URLs dragged to the page address field are.

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]): Make URLs canonical before returning them.
10:34 AM Changeset in webkit [2325] by cblu
  • 6 edits in trunk/WebKit

If a file is renamed during download because a file of the same name already exists, show this in the UI.

  • Misc.subproj/WebDownloadHandler.h:
  • Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedResponse:]): added, create file here (-[WebDownloadHandler receivedData:]): don't create file here
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): call [dataSource _setPrimaryLoadComplete:YES] for downloads (-[WebMainResourceClient handle:didReceiveResponse:]): call [WebDownloadHandler receivedResponse:] (-[WebMainResourceClient handle:didReceiveData:]): no download error to handle
7:28 AM Changeset in webkit [2324] by kocienda
  • 4 edits in trunk/WebCore

Fixed an "unused variable" build breaker. Note that I just
commented out the code and put a FIXME, as I know this is code
that David has been banging on a lot. This should be either
used for real or removed eventually, but I'll leave that for
Hyatt.

  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

Oct 14, 2002:

11:20 PM Changeset in webkit [2323] by hyatt
  • 5 edits in trunk/WebCore

More collapsing margin surgery. Working on setting up blocks
to properly compute their collapsed margins (without actually changing
the obsolete collapsing behavior yet).

  • khtml/rendering/render_flow.cpp: (RenderFlow::RenderFlow): (RenderFlow::layout): (RenderFlow::layoutBlockChildren):
  • khtml/rendering/render_flow.h:
10:34 PM Changeset in webkit [2322] by cblu
  • 14 edits in trunk/WebKit

WebFoundation:

Renamed filenameByCorrectingExtensionOfFilename:withMIMEType: to filenameWithURL:andMIMEType:
It comes up with the best filename for a URL and MIME type.

  • Misc.subproj/WebFileTypeMappings.h:
  • Misc.subproj/WebFileTypeMappings.m:

WebKit:

  • Made all downloads no matter how prompted, pass through the content policy API so the client can properly choose the file name and correct the extension if necessary. We now ask for the content policy even if one has been predetermined.
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:withContentPolicy:]): Renamed, set the predetermined content policy.
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate downloadURL:]): call [WebController _downloadURL:withContentPolicy:]
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call [WebController _downloadURL:withContentPolicy:]
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): call [WebController _downloadURL:withContentPolicy:]
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): ask for content policy even if one is predetermined

WebBrowser:

  • Support for content policy API change. Properly handle the predetermined content policy.
  • Minor clean-up in DownloadProgressEntry.
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andURL:inFrame:withContentPolicy:]): Properly handle the predetermined content policy.
  • DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): Use bytesLoaded and bytesExpected var names (-[DownloadProgressEntry setCompleted]): set bytesExpected to bytesLoaded (-[DownloadProgressEntry updateProgressUI]): slight rearrange.
7:04 PM Changeset in webkit [2321] by hyatt
  • 4 edits in trunk/WebCore

Adding helper functions for handling of collapsing margins.
Not used yet.

  • khtml/rendering/render_object.h:
4:27 PM Changeset in webkit [2320] by darin
  • 4 edits in trunk/WebCore

Fixed problems with named colors.

  • kwq/KWQColor.mm: (QColor::setNamedColor): Check named colors before hex codes for colors because our hex code parsing is now lenient enough that many names qualify.
4:27 PM Changeset in webkit [2319] by cblu
  • 6 edits in trunk/WebKit

WebFoundation:

  • Added new method that corrects a filename's extension based on its MIME type.
  • Misc.subproj/WebFileTypeMappings.h:
  • Misc.subproj/WebFileTypeMappings.m: (-[WebFileTypeMappings filenameByCorrectingExtensionOfFilename:withMIMEType:]): if the extension does not correspond with the MIME type, correct it using the preferred MIME type.

WebKit:

  • Cleaned up download handler and download progress delegate interactions.
  • Got rid of error suppression junk.
  • Only send 1 final message to the download progress delegate
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:forHandle:]): no error suppression (-[WebMainResourceClient didCancelWithHandle:]): ignore cancel errors because 1 download error is enough (-[WebMainResourceClient handleDidFinishLoading:]): don't send the special and odd final message to the download progress delegate (-[WebMainResourceClient handle:didReceiveData:]): no error suppression (-[WebMainResourceClient handle:didFailLoadingWithError:]): ignore cancel errors because 1 download error is enough

WebBrowser:

  • Correct extensions of filenames of downloaded files based on MIME type. This fixes issues with files that have random extensions and thus not claimed by any application.
  • Cleaned up DownloadMonitor. Got rid of bottle-neck progress method that caused much confusion and bugs.
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:URL:inFrame:]): call [WebFileTypeMappings filenameByCorrectingExtensionOfFilename:withMIMEType:]
  • DownloadMonitor.m: (-[DownloadMonitor _entryForDataSource:]): renamed (-[DownloadMonitor _entryForView:]): renamed (-[DownloadMonitor resourceRequest:didReceiveResponse:fromDataSource:]): create new download entry (-[DownloadMonitor resourceRequest:didReceiveContentLength:fromDataSource:]): increment progress of download entry (-[DownloadMonitor resourceRequest:didFinishLoadingFromDataSource:]): setCompleted on the download entry (-[DownloadMonitor resourceRequest:didFailLoadingWithError:fromDataSource:]): set error and setCompleted on the download entry
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry awakeFromNib]): progress bar should be determinate by default (-[DownloadProgressEntry setCompleted]): replaces _cleanUpIfComplete, have the DownloadMonitor tell us when we're done.
4:23 PM Changeset in webkit [2318] by hyatt
  • 4 edits in trunk/WebCore

Really fixing zeldman.com this time. This disabling stuff
is complicated! :)

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseAttribute): (HTMLLinkElementImpl::setStyleSheet): (HTMLLinkElementImpl::sheetLoaded):
1:33 PM Changeset in webkit [2317] by darin
  • 12 edits in trunk/WebKit
  • Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkFromDictionaryRepresentation:withGroup:]):
  • Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]):
  • Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]):
  • Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]): Add checking since we don't "trust" the dictionary passed in.
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]): Add FIXME about adding the checking.
  • Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup initWithFile:]): Use copy, not retain.
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Fix storage leak by releasing the default context menu delegate.
  • WebView.subproj/WebControllerPrivate.h: Tweak.
12:46 PM Changeset in webkit [2316] by hyatt
  • 4 edits in trunk/WebCore

Stop the insanity. Make sure that a sheet that is disabled
while it is still loading is removed from the doc's list
of pending sheets (for FOUC checks).

Fixes zeldman.com.

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseAttribute):
10:20 AM Changeset in webkit [2315] by cblu
  • 4 edits in trunk/WebKit

Made WebNetscapePluginStream retain a WebNetscapePluginEmbeddedView not a WebBaseNetscapePluginView.

  • Plugins.subproj/WebNetscapePluginStream.h:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
12:19 AM Changeset in webkit [2314] by hyatt
  • 6 edits in trunk/WebCore

Implementing the ability to individually enable/disable
both preferred and alternate stylesheets. Enabling/disabling
sheets via the disabled property of the <link> element overrides
whether or not a sheet happens to be alternate or preferred.

This new implementation of sheet disabling/enabling was a missing
piece of our HTML4 compliance, and was used by the Wired
site to implement its text sizing mechanism.

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::HTMLLinkElementImpl): (HTMLLinkElementImpl::parseAttribute): (HTMLLinkElementImpl::process):
  • khtml/html/html_headimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector):
Note: See TracTimeline for information about the timeline view.