Timeline



Oct 21, 2002:

5:45 PM Changeset in webkit [2405] by darin
  • 13 edits
    1 delete in trunk

WebCore:

  • kwq/KWQInputDialog.mm: (QInputDialog::getText): Call the view factory to do the heavy lifting.
  • kwq/WebCoreViewFactory.h: Add runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:. Use a protocol for the subclass responsibility.
  • kwq/WebCoreViewFactory.m: Remove stub methods not needed because of the subclass responsibility technique we are using.
  • kwq/qt/qstylesheet.h: Made this inline, since it does nothing.
  • kwq/KWQStyleSheet.mm: Removed.
  • WebCore.pbproj/project.pbxproj: Removed KWQStyleSheet.mm.

WebKit:

  • WebCoreSupport.subproj/WebViewFactory.h: Changed to use new protocol scheme so we get an error if we forget to implement something.
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): Stub.
5:28 PM Changeset in webkit [2404] by rjw
  • 10 edits in trunk/WebKit

Real checkin this time!

5:00 PM Changeset in webkit [2403] by trey
  • 4 edits in trunk/WebKit

WebFoundation:

Fixed typos and other doc comment errors found during API review.

  • CacheLoader.subproj/WebCacheManager.m:
  • CacheLoader.subproj/WebProtocolHandler.h:
  • Misc.subproj/WebError.h:

WebKit:

Fixed typos and other doc comment errors found during API review.

  • WebView.subproj/WebController.h:
4:09 PM Changeset in webkit [2402] by rjw
  • 14 edits in trunk/WebKit

Modernized the activity window a little bit. Fixed
a slew of activity related bugs.

  • BrowserWebController.m: (-[BrowserWebController identifierForInitialRequest:fromDataSource:]): (-[BrowserWebController resource:willSendRequest:fromDataSource:]): (-[BrowserWebController resource:didReceiveResponse:fromDataSource:]): (-[BrowserWebController resource:didReceiveContentLength:fromDataSource:]): (-[BrowserWebController resource:didFinishLoadingFromDataSource:]):
  • FrameProgressEntry.h:
  • FrameProgressEntry.m: (-[FrameProgressEntry _initWithFrame:]): (-[FrameProgressEntry provisionalDataSourceWasCommitted]): (-[FrameProgressEntry activeSubresourcesForDataSource:]): (-[FrameProgressEntry trackSubresource:forDataSource:]): (-[FrameProgressEntry completedEntry:fromDataSource:]): (-[FrameProgressEntry trackSubframe:fromDataSource:]): (-[FrameProgressEntry resetProvisionalLoad]):
  • LoadProgressMonitor.h:
  • LoadProgressMonitor.m: (-[LoadProgressMonitor _monitorProvisionalDataSourceForFrame:]): (-[LoadProgressMonitor _incrementProgressBarWithOldBytes:newBytes:oldTotal:newTotal:isMainResource:]): (-[LoadProgressMonitor createProgressEntryWithRequest:dataSource:]): (-[LoadProgressMonitor completedEntry:fromDataSource:]): (-[LoadProgressMonitor receivedError:forEntry:fromDataSource:]): (-[LoadProgressMonitor receivedUpdateForEntry:URLString:bytesLoaded:bytesExpected:error:dataSource:]):
  • ResourceProgressEntry.h:
  • ResourceProgressEntry.m:

Changed WebResourceLoadDelegate methods to include an identifier
as first parameter. This will help clients track callbacks relating
to a particular resource. Added identifierForInitialRequest:fromDataSource:
so clients can create their own identifier.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
  • WebCoreSupport.subproj/WebSubresourceClient.h:
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:willSendRequest:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]):
  • WebView.subproj/WebController.m: (-[WebResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[WebResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[WebResourceLoadDelegate resource:didReceiveResponse:fromDataSource:]): (-[WebResourceLoadDelegate resource:didReceiveContentLength:fromDataSource:]): (-[WebResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[WebResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]):
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):
  • WebView.subproj/WebResourceLoadDelegate.h:
3:41 PM Changeset in webkit [2401] by hyatt
  • 10 edits in trunk/WebCore

Implement support for a new @-rule called @konq-quirks. This
will allow us to put style rules into html4.css that only
apply for pages in quirks mode.

  • khtml/css/css_ruleimpl.cpp: (CSSQuirksRuleImpl::CSSQuirksRuleImpl): (CSSQuirksRuleImpl::~CSSQuirksRuleImpl): (CSSQuirksRuleImpl::cssRules): (CSSQuirksRuleImpl::appendRule): (CSSQuirksRuleImpl::insertRule): (CSSQuirksRuleImpl::deleteRule):
  • khtml/css/css_ruleimpl.h:
  • khtml/css/cssparser.cpp: (StyleBaseImpl::parseAtRule):
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/dom/css_rule.h:
2:19 PM Changeset in webkit [2400] by cblu
  • 7 edits in trunk/WebKit

WebFoundation:

Partial fix for 2968124 - file misnamed on download

  • added the "filename" method to response so that the logic for getting the correct filename for a resource is in one easy place.
  • obey the "Content-Disposition" header. Not totally fixed because the parsing doesn't totally work.
  • CacheLoader.subproj/WebResourceResponse.h:
  • CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse filename]): new, filename by using "Content-Disposition" and MIME type. (-[WebResourceResponse _setContentType:]): no changes, but I added _setFilename
  • CacheLoader.subproj/WebResourceResponsePrivate.h:
  • Misc.subproj/WebFileTypeMappings.h: remove unused method
  • Misc.subproj/WebFileTypeMappings.m: remove unused method
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler setResponseMetadata:]): call _setFilename for the "Content-Disposition"

WebKit:

Changed content policy API to pass a response instead of MIME type so client can get the mime type and filename from one class.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

Changed content policy API to pass a response instead of MIME type so client can get the mime type and filename from one class.

  • BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andURL:inFrame:withContentPolicy:]):
12:45 PM Changeset in webkit [2399] by darin
  • 4 edits in trunk/WebKit
  • fixed 3080512 -- REGRESSION: moving from old page to new one, we get blank white before the new one is ready

Roll out a bunch of my changes, because they weren't complete. Added FIXMEs for the
problems I was unsuccessfully trying to fix.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]):
  • WebView.subproj/WebView.m: (-[WebView initWithFrame:]), (-[WebView isOpaque]), (-[WebView drawRect:]): Roll back.
12:09 PM Changeset in webkit [2398] by darin
  • 5 edits in trunk/WebCore

Remove closeEntireTree now that deferred close takes care of that case.

  • khtml/html/htmlparser.cpp: (KHTMLParser::startBody):
  • khtml/rendering/render_object.h:
11:23 AM Changeset in webkit [2397] by darin
  • 4 edits in trunk/WebCore
  • fixed 3075041 -- text larger/smaller increment too large when font-size specified as %
  • khtml/css/cssstyleselector.cpp: Don't apply the zoom factor to a font size that already has the zoom factor applied.
11:12 AM Changeset in webkit [2396] by darin
  • 5 edits in trunk/WebKit
  • fixed 3080246 -- REGRESSION: Animated GIFs sometimes disappear after drag or scroll

Once more, with feeling.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setNeedsLayoutIfSizeChanged:]): Added setNeedsDisplay:YES here. The lack of this is what caused the bug. But also don't do any work when the size doesn't change. This prevents this from being called at all in the scrolling case, which is what we want. (-[WebHTMLView viewWillMoveToSuperview:]): Just the name change. (-[WebHTMLView layout]): Store the layout size for the above methods.
  • WebView.subproj/WebHTMLViewPrivate.h: Add a place to store the size.
  • WebView.subproj/WebImageView.m: (-[WebImageView layout]): Roll this change back in.
11:04 AM Changeset in webkit [2395] by darin
  • 4 edits in trunk/WebCore
  • khtml/khtmlview.cpp: (KHTMLView::clear): Default to fast scrolling. I'm pretty sure this was just backwards here.
8:53 AM Changeset in webkit [2394] by darin
  • 3 edits in trunk/WebKit
  • fixed 3080246 -- REGRESSION: Animated GIFs sometimes disappear after drag or scroll
  • WebView.subproj/WebImageView.m: (-[WebImageView layout]): My change to this caused the regression. Not sure why, but I'll just back out because the change wasn't important.
3:06 AM Changeset in webkit [2393] by hyatt
  • 4 edits in trunk/WebCore

DLs are supposed to have margins.

  • khtml/css/html4.css:
1:16 AM Changeset in webkit [2392] by hyatt
  • 4 edits in trunk/WebCore

Fix for margin problems on aintitcool.com. There was a subtlety
to WinIE's quirk. For <h1>-<h6> only, they don't collapse the
bottom margin for table cells (they still collapse the top
margin). I just love emulating the odd behavior of WinIE.
Wheee.

  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

Oct 20, 2002:

11:11 PM Changeset in webkit [2391] by cblu
  • 3 edits in trunk/WebKit

Fixed: 3025847 - Can't use any menu command keys after clicking on a plugin

Don't give plug-ins command-modified keys anymore because the ability wasn't worth the annoyance. If only plug-ins truthfully responded t events! Anyway, filed 3080103 so that I can look into a way to make this work for everybody.

  • Plugins.subproj/WebBaseNetscapePluginView.m:
11:03 PM Changeset in webkit [2390] by darin
  • 4 edits in trunk/WebCore

Redid my fix. It was just an ordering thing. The image had to already be
installed as the current image before calling ref(), because in the cached
case, you get the loading complete callback right then.

  • khtml/rendering/render_image.cpp: (RenderImage::updateFromElement): Call deref on the old image later. Basically, instead of moving the ref of the new image up, I moved the deref of the old image down.
10:39 PM Changeset in webkit [2389] by darin
  • 4 edits in trunk/WebCore

Roll out my render_image.cpp change. It was causing a big problem
getting images from the cache. I need to study further to figure out why.

  • khtml/rendering/render_image.cpp: (RenderImage::updateFromElement): Roll back the change.
10:03 PM Changeset in webkit [2388] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3025868 - Plugin context menu disappears then reappears if you click off of it

Also fixed some rare dragging weirdness in WebHTMLView. If you attempted to drag a plug-in after dragging an image, the image would drag again.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView mouseDragged:]): subclass and do nothing to prevent calling mouseDragged in WebHTMLView (-[WebBaseNetscapePluginView performKeyEquivalent:]): no changes to this method, removed menuForEvent, wasn't needed after all
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream stop]): minor clean-up
9:02 PM Changeset in webkit [2387] by hyatt
  • 4 edits in trunk/WebCore

Rewrite the clearing code for floats. Rewrote the
collapsing margin code to really work with floating and
clearing. This fixes the right hand side of wired.com.

  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::checkClear): (RenderFlow::addChild):
5:41 PM Changeset in webkit [2386] by darin
  • 4 edits in trunk/WebCore
  • fixed 3007961 -- Crash in DOM::HTMLImageElementImpl::parseAttribute
  • khtml/rendering/render_image.cpp: (RenderImage::updateFromElement): Be sure to call ref on the new image before calling deref on the old image. That's because deref on the old image causes a cache flush, which might cause the image to go away in certain cases.
5:08 PM Changeset in webkit [2385] by cblu
  • 4 edits in trunk/WebCore

Fixed possible build failure.

  • kwq/KWQDOMNode.cpp: (isImage): remove unused variable.
4:54 PM Changeset in webkit [2384] by darin
  • 3 edits in trunk/WebKit
  • fixed a minor problem with autorelease I just ran into
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]): Create an autorelease pool for the benefit of the class initialize functions that will be called.
4:18 PM Changeset in webkit [2383] by cblu
  • 4 edits in trunk/WebCore

Partial fix for:
3023814 - contexual menus and dragging doesn't work for some images

The image map case is still broken because I need to find a way to get the RenderImage for an AREA node. Anyone know how?

  • kwq/KWQDOMNode.cpp: (isImage): Also return true if the node is an INPUT tag with TYPE set to "image"
3:10 PM Changeset in webkit [2382] by cblu
  • 13 edits in trunk/WebKit

Fixed 3050010: Should show contextual menu for WebImageView
Also made drags from WebImageView work.

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: added _web_setPromisedImageDragImage which does the hackery to extend the promised file drag for images
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _menuForElement:]): added, gets menu items from delegate and creates menu
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): simplified, gets element and calls -[WebController _menuForElement:] (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): call _web_setPromisedImageDragImage: when dragging image
  • WebView.subproj/WebImageRepresentation.h:
  • WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation dealloc]): release the URL (-[WebImageRepresentation URL]): added so WebImageView can get the URL (-[WebImageRepresentation setDataSource:]): retain the URL
  • WebView.subproj/WebImageView.h: use new drag bools
  • WebView.subproj/WebImageView.m: (-[WebImageView initWithFrame:]): ditto (-[WebImageView setAcceptsDrags:]): ditto (-[WebImageView acceptsDrags]): ditto (-[WebImageView setAcceptsDrops:]): ditto (-[WebImageView acceptsDrops]): ditto (-[WebImageView controller]): new (-[WebImageView menuForEvent:]): new, creates element and calls -[WebController _menuForElement:] (-[WebImageView mouseDragged:]): drag promised file (-[WebImageView dragImage:at:offset:event:pasteboard:source:slideBack:]): call _web_setPromisedImageDragImage: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): new
12:59 PM Changeset in webkit [2381] by darin
  • 7 edits in trunk/WebKit
  • fixed a problem where you would get garbage bits when resizing while loading a standalone image

Cleaned up some of the complexity of how we were handling resizing.

  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Do the update twice to properly handle the case where a disappearing scroller makes a second scroller appear or vice versa.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Remove the code that was trying to set the setDrawsBackground flag on the scroll view. It was doing it wrong, causing bugs with drawing non-HTML views while loading. Also, it wasn't working as an optimization, since the window was still drawing the metallic background behind. We can revisit adding an optimization at the WebHTMLView level if it creates a measurable speed increase, but we must be careful to test loading with non-HTML views along with the HTML cases.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setNeedsLayoutToYes:]): Added. Calls setNeedsLayout:YES. (-[WebHTMLView viewWillMoveToSuperview:]): Added. Registers so we get _setNeedsLayoutToYes: calls when the superview's size changes. This allows us to do a layout at all the right times. (-[WebHTMLView layout]): Call setNeedsDisplay:YES, because if we do a layout without a complete display the screen will look bad. Also do a reapplyStyles, because if there are pending style changes we want to apply them before doing a layout since they could affect the layout. (-[WebHTMLView drawRect:]): Remove the special case that says to always relayout during live resize, because it works without a special case now. For the other live resize case, turn it from a special case into a general one. Any time layout is done, make sure to draw the entire view, not just the passed-in rectangle, and call setNeedsDisplay:NO so we don't do it all over again.
  • WebView.subproj/WebImageView.m: (-[WebImageView layout]): Explicitly set frame size to 0,0 when there is no image.
  • WebView.subproj/WebView.m: Remove now-unnecessary viewWillStartLiveResize, setFrame:, viewDidEndLiveResize, isOpaque, and drawRect overrides. (-[WebView initWithFrame:]): Don't call setDrawsBackground:NO for the reasons above. Don't set scroll bar visibility because the dynamic scroll bars view handles that already.
9:09 AM Changeset in webkit [2380] by darin
  • 4 edits in trunk/WebCore
  • fixed 3076390 -- crash in DOM::DocumentImpl::setParsing loading thread detail page at groups.apple.com
  • khtml/khtml_part.cpp: (KHTMLPart::openURL): Don't do any redirect special case if the document is nil. Just do a normal load in that case.
8:40 AM Changeset in webkit [2379] by darin
  • 5 edits in trunk/WebCore
  • fixed 3079864 -- REGRESSION: assertion failure on any page with a form element
  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Roll back the parent call to use NodeBaseImpl::attach. Not sure why I changed that at the last minute before my last checkin, but it was *bad*.
  • fixed a crash I observed when clicking on an about:blank page
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Check for nil renderer.

Oct 19, 2002:

10:10 PM Changeset in webkit [2378] by darin
  • 3 edits in trunk/WebKit
  • fixed 3073693 -- flash drawn to screen even when window minimized
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): Set up additional notifications. Don't start the null event sender if the window is miniaturized. (-[WebBaseNetscapePluginView windowDidMiniaturize:]): Stop the null event sender. (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): Start the null event sender.
4:41 PM Changeset in webkit [2377] by darin
  • 8 edits in trunk/WebCore
  • fixed 3075032 -- textarea contents sometimes aren't shown

The root of the problem is that we weren't delivering close calls to
the render objects in the case where we created them late due to our FOUC
fix. I taught the DOM implementation to remember that a close call is
due, and deliver it when the render object is created. We can probably
replace the closeEntireTree hack with this too. I'll talk to Dave about
that on Monday.

  • khtml/xml/dom_nodeimpl.h: Add m_rendererNeedsClose and closeRenderer.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): Initialize m_rendererNeedsClose to false. (NodeImpl::closeRenderer): Call close on the renderer if it's created, otherwise set m_rendererNeedsClose. (NodeImpl::attach): If the renderer is created and m_rendererNeedsClose is true call close on the renderer and set it to false.
  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Rearrange this so that the base class attach is called before updateFromElement is called. This allows the base attach to do a close for us before we update.
  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Call closeRenderer on the DOM node rather than calling close on the render node. (KHTMLParser::popOneBlock): Ditto.
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::endElement): Ditto. (XMLTokenizer::finish): Ditto.
10:19 AM Changeset in webkit [2376] by darin
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Removed stray printf.
1:11 AM Changeset in webkit [2375] by hyatt
  • 5 edits in trunk/WebCore

A couple of whitespace fixes. What's really odd about these
fixes is that they *work* but only if you load the page by
hitting "Back". I suspect that I've now fixed the bugs on
KHTML's end, and we have some sort of whitepsace dropping
problem on our end.

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::write):

Oct 18, 2002:

5:27 PM Changeset in webkit [2374] by rjw
  • 15 edits in trunk

Fixed khtml to ignore <title> tags after the first tag.

Fixed setting document.title from JavaScript.

  • khtml/dom/html_document.cpp: (HTMLDocument::setTitle):
  • khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::childrenChanged):

Changed name to setUsesBackForwardList: from
setUseBackForwardList. ditto for useBackForwardList

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setUsesBackForwardList:]): (-[WebController usesBackForwardList]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]):

Fixed history items that have "untitled" title after
redirect. (3078577).

  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):

Made title of snippet window change to match document title, if
present.

  • Debug/SnippetController.h:
  • Debug/SnippetController.m: (-[SnippetController setTitle:]): (-[SnippetLocationChangeDelegate locationChangeDone:forDataSource:]):
3:08 PM Changeset in webkit [2373] by darin
  • 4 edits in trunk/WebCore
  • fixed 3078293 -- Implement evaluateJavaScript on WebController
  • kwq/KWQVariant.mm: (QVariant::asString): Made this return reasonable values for types other than string. Still may be loose ends left, but this takes care of most of it.
3:00 PM Changeset in webkit [2372] by darin
  • 11 edits in trunk

WebCore:

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:]): Changed to return a string and changed name.

WebKit:

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController stringByEvaluatingJavaScriptFromString:]): Changed to return a string and changed name.

WebBrowser:

  • BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]):
  • BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]): Update to call stringByEvaluatingJavaScriptFromString.
1:49 PM Changeset in webkit [2371] by darin
  • 3 edits in trunk/WebKit

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
  • English.lproj/Localizable.strings: Regenerate after recent changes.

WebKit:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

  • LoadProgressMonitor.m: (-[LoadProgressMonitor _busyStatus]): Say "Contacting <host>" instead of "Looking for <host>" to help reduce confusion about whether this shows up just during DNS or not.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
  • English.lproj/Localizable.strings: Regnerate.
1:26 PM Changeset in webkit [2370] by kocienda
  • 3 edits in trunk/WebKit

Removed unneeded import of WebFoundation/WebResourceLoadManager.h

  • Misc.subproj/WebIconLoader.m
1:20 PM Changeset in webkit [2369] by hyatt
  • 7 edits in trunk/WebCore

The collapsing margin rewrite. Also fixes a bug where
we stay in quirks mode for strict HTML4 dtds when we
shouldn't.

  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::determineParseMode):
  • khtml/rendering/render_flow.cpp: (RenderFlow::layout): (RenderFlow::layoutBlockChildren):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_object.h:
11:10 AM Changeset in webkit [2368] by darin
  • 7 edits in trunk

WebCore:

  • Makefile.am: Move dependency so clean happens before build.

WebKit:

  • Makefile.am: Move dependency so clean happens before build.
11:01 AM Changeset in webkit [2367] by darin
  • 3 edits in trunk/WebKit
  • force-clean-timestamp: Dependencies don't work well enough, so we need a clean build here after the WebFoundation domain change.
10:13 AM Changeset in webkit [2366] by darin
  • 7 edits
    1 delete in trunk/WebKit

WebFoundation:

WebError cleanup. Change domains to be strings, remove unused codes.

  • AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
  • AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _checkForAuthenticationFailureInHTTPResponse:withURL:]): Don't return an error code. The error code was always vague, and never looked at by our one client or exposed outside WebFoundation. If we later want to report a precise error, we can easily re-add it.
  • CacheLoader.subproj/WebResourceLoad.h: Change domain parameter to an NSString *.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]): Ditto.
  • Misc.subproj/WebError.h: Moved WebErrorDomainWebKit to WebKit. Removed WebErrorDomainFTP. Removed WebErrorCodeNoError, WebErrorCodeHTTPUnknownAuthenticationSchemeError, and WebErrorCodeHTTPBadAuthenticationHeaderError, which were never used. Changed methods to take NSString * for the error domain. Added errorIsInDomain method.
  • Misc.subproj/WebError.m: (-[WebErrorPrivate dealloc]): Release the error domain string. (classInitialize): Remove descriptions for now-unused error codes. (-[WebError initWithErrorCode:inDomain:failingURL:]): Take a domain string. (-[WebError errorDomain]): Return the domain string. (-[WebError errorIsInDomain:]): Added. (-[WebError errorDescription]): Update to look up by string. (+[WebError addErrorsWithCodesAndDescriptions:inDomain:]): Use domain string as key.
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler performHTTPHeaderRead:andCall:]): Get rid of the code that stored the authenticationFailureResult, which was never passed to the user.
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.h: Remove authenticationFailureResult.
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler determineErrorAndFail]): Rearrange the code so we don't use WebErrorCodeNoError. Also change the domain so that we don't report the WebErrorCodeCannotConnectToHostError error in the SSL domain any more.
  • WebFoundation.exp: Export the new domain string globals.

WebKit:

Update for WebFoundation error domain changes.

  • Misc.subproj/WebKitErrors.h: Put WebErrorDomainWebKit in here. Also remove WebErrorNoError and the WebErrorCode name for the enum.
  • WebKit.exp: Export the WebErrorDomainWebKit constant.
  • WebView.subproj/WebView.m: Define the WebErrorDomainWebKit.
  • WebKit.pbproj/project.pbxproj: Always use WebKit.exp.
  • Makefile.am: Don't generate WebKit-combined.exp any more.
  • WebKit-tests.exp: Removed.

WebBrowser:

Update for WebFoundation error domain changes.

  • LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): Use the new errorIsInDomain method instead of doing a switch statement, since that works with NSString. (-[LocationChangeHandler specializedMessageForError:]): Ditto.

Oct 17, 2002:

11:41 PM Changeset in webkit [2365] by darin
  • 2 edits in trunk/WebKit
  • fixed 3078644 -- Odd clipping in frame
  • WebView.subproj/WebClipView.h: Add hasAdditionalClip and additionalClip methods.
  • WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Add an assertion. (-[WebClipView setAdditionalClip:]): Ditto. (-[WebClipView hasAdditionalClip]): Added. (-[WebClipView additionalClip]): Added.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView visibleRect]): Turn off the additional clip while computing our visibleRect. This way, the additional clip only affects people who ask for the clip view's visibleRect directly, which basically means just the focus rectangle drawing code we are trying to influence.
11:40 PM Changeset in webkit [2364] by darin
  • 5 edits in trunk/WebKit

A small change that eliminates a variety of strange clipping problems, including ones that
make large swathes of the page disappear.

  • WebView.subproj/WebClipView.h: Add hasAdditionalClip and additionalClip methods.
  • WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Add an assertion. (-[WebClipView setAdditionalClip:]): Ditto. (-[WebClipView hasAdditionalClip]): Added. (-[WebClipView additionalClip]): Added.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView visibleRect]): Turn off the additional clip while computing our visibleRect. This way, the additional clip only affects people who ask for the clip view's visibleRect directly, which basically means just the focus rectangle drawing code we are trying to influence.
5:30 PM Changeset in webkit [2363] by rjw
  • 11 edits in trunk

Support for drawing frame borders and frame resizing. (fixes 2982466).

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge frameBorderStyle]):
  • kwq/qt/qframe.h:

Support for drawing frame borders (fixes 2982466).

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _drawBorder:]): (-[WebHTMLView drawRect:]):
5:18 PM Changeset in webkit [2362] by darin
  • 8 edits in trunk/WebCore
  • fixed 2807340 -- Alex is case sensitive for anchors, but should not be in quirks mode (other browsers aren't)
  • khtml/dom/html_misc.cpp: Touched this file to prevent us from requiring a full build. Damned header dependencies still don't work right.
  • khtml/html/html_miscimpl.h: Add caseSensitive parameters.
  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::getNamedItem): Add caseSensitive parameter, and compare by converting both to lower case if it's false and pass it on when recursing. (HTMLCollectionImpl::namedItem): Pass along a caseSensitive parameter. (HTMLFormCollectionImpl::getNamedItem): Pass along a caseSensitive parameter. (HTMLFormCollectionImpl::getNamedFormItem): Pass along, and handle, it. (HTMLFormCollectionImpl::getNamedImgItem): Ditto. (HTMLFormCollectionImpl::nextNamedItemInternal): Pass true for caseSensitive.
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): Pass false for the new caseSensitive parameter to namedItem when the document mode is not strict.
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines): Removed a stray NSLog that I left in by accident.
4:04 PM Changeset in webkit [2361] by darin
  • 6 edits in trunk/WebCore
  • fixed 3052547 -- <select> doesn't size properly (size > 1)
  • khtml/rendering/render_form.cpp: (RenderLineEdit::slotReturnPressed): #if !APPLE_CHANGES around some unused code in here. (RenderSelect::updateFromElement): Fix bug where it was using Multi here, but Extended elsewhere for the selection mode. (RenderSelect::layout): Change code so that QListBox handles the sizing.
  • kwq/KWQListBox.h: Removed a lot of unused stuff, made other things use inlines.
  • kwq/KWQListBox.mm: Rewrote most of the file contents. Made a new QListBox::sizeForNumberOfLines method. We will have to port this to NSTableView rather than NSBrowser.
2:05 PM Changeset in webkit [2360] by darin
  • 4 edits in trunk/WebCore
  • fixed 3078245 -- REGRESSION: lightgrey displays as black, used to display as white, should display light gray
  • kwq/KWQColor.mm: (getNamedColors): For every color with the name "gray" in it, also include the version spelled "grey" as other browsers seem to.
1:14 PM Changeset in webkit [2359] by sullivan
  • 8 edits in trunk/WebKit

WebKit:

  • added support for bookmark identifiers, to be used for marking bookmark proxies uniquely (independent of localized title). This is not the old unique-identifier scheme; now identifiers are optional, and initially nil, but the client can use them for its own purposes.
  • Bookmarks.subproj/WebBookmark.h:
  • Bookmarks.subproj/WebBookmark.m: (-[WebBookmark dealloc]): release identifier (-[WebBookmark identifier]): return identifier (-[WebBookmark setIdentifier:]): set identifier
  • Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkLeaf dictionaryRepresentation]): save identifier (-[WebBookmarkLeaf copyWithZone:]): copy identifier
  • Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkList dictionaryRepresentation]): save identifier (-[WebBookmarkList copyWithZone:]): copy identifier
  • Bookmarks.subproj/WebBookmarkPrivate.h:
  • Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkProxy dictionaryRepresentation]): save identifier (-[WebBookmarkProxy copyWithZone:]): copy identifier

WebBrowser:

  • a bunch of work in the direction of getting the special "bookmark sources" to work in the bookmarks view. The Address Book contents now appear in the Bookmarks view, but Rendezvous and History don't yet.
  • BookmarkSource.h: Added. Defines protocol to be used by special bookmark sources.
  • BookmarksController.h: define identifier constants used for special bookmark sources.
  • BookmarksController.m: (-[BookmarksController _blessOrCreateSpecialFolders]): set identifiers on bookmark proxies representing special bookmark sources
  • BookmarksViewController.m: (-[BookmarksViewController undoRemoveBookmarks:]): (-[BookmarksViewController selectedContentItems]): (-[BookmarksViewController deleteContentItems:]): (-[BookmarksViewController deleteSelectedContentItems]): (-[BookmarksViewController doubleClick:]): (-[BookmarksViewController newBookmarkFolder:]): (-[BookmarksViewController bookmarkSourceForProxyIdentifier:]): (-[BookmarksViewController refreshContents]): (-[BookmarksViewController bookmarksFromContentItems:]): (-[BookmarksViewController bookmarkFromContentItem:]): (-[BookmarksViewController canAddToBookmarkSource:]): (-[BookmarksViewController canAddToSelectedBookmarkSource]): (-[BookmarksViewController canDeleteFromSelectedBookmarkSource]): (-[BookmarksViewController child:ofContentItem:]): (-[BookmarksViewController isContentItemExpandable:]): (-[BookmarksViewController numberOfChildrenOfContentItem:]): (-[BookmarksViewController titleStringForContentItem:]): (-[BookmarksViewController addressStringForContentItem:]): (-[BookmarksViewController imageForContentItem:]): (-[BookmarksViewController shouldEditTableColumn:forContentItem:]): (-[BookmarksViewController tableView:draggingSourceOperationMaskForLocal:]): (-[BookmarksViewController cleanUpAfterDraggingBookmarksWithOperation:]): (-[BookmarksViewController prepareForDraggingBookmarks:fromSourceColumn:]): (-[BookmarksViewController tableView:validateDrop:proposedRow:proposedDropOperation:]): (-[BookmarksViewController handleKeyDown:inSourceColumn:]): (-[BookmarksViewController tableViewSelectionDidChange:]): (-[BookmarksViewController outlineView:child:ofItem:]): (-[BookmarksViewController outlineView:isItemExpandable:]): (-[BookmarksViewController outlineView:numberOfChildrenOfItem:]): (-[BookmarksViewController outlineView:objectValueForTableColumn:byItem:]): (-[BookmarksViewController outlineView:draggingSourceOperationMaskForLocal:]): (-[BookmarksViewController outlineView:writeItems:toPasteboard:]): (-[BookmarksViewController outlineView:willDisplayCell:forTableColumn:item:]): (-[BookmarksViewController outlineView:shouldEditTableColumn:item:]): (-[BookmarksViewController copy:]): (-[BookmarksViewController delete:]): My brain gets sore thinking about writing individual comments here. Basically I generalized methods that were dealing explicitly with bookmarks to deal with opaque "content items" instead, then delegate to the appropriate BookmarkSource in the bottleneck methods. Only Address Book is hooked up so far. This also fixed lots of trouble you could get into if you played with the "not implemented yet" items too much.
  • ABHomePagesController.h:
  • ABHomePagesController.m: (-[ABHomePagesController refreshContents]): (-[ABHomePagesController canDeleteContents]): (-[ABHomePagesController deleteContentItems:]): (-[ABHomePagesController isContentItemExpandable:]): (-[ABHomePagesController child:ofContentItem:]): (-[ABHomePagesController numberOfChildrenOfContentItem:]): (-[ABHomePagesController bookmarkFromContentItem:]): (-[ABHomePagesController bookmarksFromContentItems:]): (-[ABHomePagesController addressStringForContentItem:]): (-[ABHomePagesController titleStringForContentItem:]): (-[ABHomePagesController imageForContentItem:]): Implement BookmarkSource protocol; I haven't deleted all the similar code that drives the Address Book window yet.
  • English.lproj/MainMenu.nib: changed "Last Search Results" to "SnapBack to Search" under protest.
  • WebBrowser.pbproj/project.pbxproj: updated for new file
12:06 PM Changeset in webkit [2358] by hyatt
  • 4 edits in trunk/WebCore

Make navigator.product dynamic based off user agent (i.e.,
make it participate in spoofing too).

  • khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty):
11:10 AM Changeset in webkit [2357]
  • 3 copies in tags/Alexander-28

This commit was manufactured by cvs2svn to create tag 'Alexander-28'.

11:10 AM Changeset in webkit [2356] by sheridan
  • 8 edits in trunk

Alex-28

10:12 AM Changeset in webkit [2355] by darin
  • 5 edits in trunk/WebCore
  • fixed 3077856 -- REGRESSION: scroll to fragment doesn't work (except when Alex started from command line)
  • kwq/kparts/browserextension.h: Initialize reload to false. It was uninitialized, and when true was preventing anchor navigation from working.
9:48 AM Changeset in webkit [2354] by darin
  • 4 edits in trunk/WebKit
  • fixed 3062613 -- too many redirects at nytimes.com and apple

Our cookie policy was rejecting the cookies from nytimes.com -- the policy base
URL was still the news.com URL from before the redirect.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Update the cookie policy URL when a redirect changes the data source's URL.
9:17 AM Changeset in webkit [2353] by darin
  • 3 edits in trunk/WebKit
  • fixed 3077910 -- REGRESSION: download window open at startup time -> no scrollbars
  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Check for WebDocumentView protocol before making the layout method call. Prevents exception when WebDynamicScrollBarsView is used with a document that is not a WebDocumentView.
1:05 AM Changeset in webkit [2352] by darin
  • 4 edits in trunk/WebCore
  • khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): Don't recurse on the same child twice. (RenderFlow::rightmostPosition): Ditto.
1:03 AM Changeset in webkit [2351] by hyatt
  • 4 edits in trunk/WebCore

Fix bayarea.com. My implementation of offsetParent was
flawed. And to think I was blaming Gecko... ;)

  • khtml/rendering/render_object.cpp: (RenderObject::offsetParent):
Note: See TracTimeline for information about the timeline view.