Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 23, 2002:

11:50 PM Changeset in webkit [2444] by darin

• 4 edits in trunk/WebKit

• fixed 3083013 -- REGRESSION: Cookie refused at ​http://directory/ even on reload

Restore a bit of the cruft.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): We need to change the request on the data source when a redirect happens, because the data source goes on to ultimately communicate this to WebCore. Restored the code that did that, with some changes to fit into the new regime.

10:16 PM Changeset in webkit [2443] by rjw

• 30 edits in trunk/WebKit

Cleaned up months of accumulated cruft.
Added base class to the three WebResourceHandleDelegate implementors.
Removed superfluous handle references to controller callbacks.
More can still be done.
All in the name of fixing 3076050.

• Misc.subproj/WebKitErrors.h:
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]):
• Plugins.subproj/WebNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream stop]): (-[WebNetscapePluginStream handle:willSendRequest:]): (-[WebNetscapePluginStream handle:didReceiveResponse:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]):
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient initWithLoader:dataSource:]): (-[WebSubresourceClient dealloc]): (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient handle:willSendRequest:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]): (-[WebSubresourceClient cancel]):
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate init]): (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate dealloc]): (-[WebBaseResourceHandleDelegate setDataSource:]): (-[WebBaseResourceHandleDelegate dataSource]): (-[WebBaseResourceHandleDelegate resourceLoadDelegate]): (-[WebBaseResourceHandleDelegate downloadDelegate]): (-[WebBaseResourceHandleDelegate setIsDownload:]): (-[WebBaseResourceHandleDelegate isDownload]): (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): (-[WebBaseResourceHandleDelegate handle:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate handle:didReceiveData:]): (-[WebBaseResourceHandleDelegate handleDidFinishLoading:]): (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancel]): (-[WebBaseResourceHandleDelegate handle]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedBytesSoFar:fromDataSource:complete:]): (-[WebController _receivedError:fromDataSource:]): (-[WebController _mainReceivedError:fromDataSource:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _startLoading]): (-[WebDataSource _stopLoading]): (-[WebDataSource _clearErrors]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient cancel]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient _notifyDelegatesOfInterruptionByPolicyChange]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebResourceLoadDelegate.h:

6:30 PM Changeset in webkit [2442] by cblu

• 13 edits in trunk

WebCore:

WebKit now gets called when render_frame subviews are added.

• khtml/rendering/render_frames.cpp: (RenderPart::setWidget): call didAddWidget on the part
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::didAddWidget): added, calls didAddSubview on the bridge

WebKit:

Support for new plug-in API. This is about as much as I can do without the new java plug-in and java root.

• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): observe window close changes (-[WebPluginController dealloc]): remove observer, assert if we're still tracking plug-ins (-[WebPluginController didAddSubview:]): start the plug-in (-[WebPluginController stopAllPlugins]): stop and destroy all plug-ins. (-[WebPluginController windowWillClose:]): call stopAllPlugins if the window in question is closing
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): call stopAllPlugins on WebPluginController

5:44 PM Changeset in webkit [2441] by cblu

• 19 edits in trunk

WebCore:

Change for plug-in package API changes.

• kwq/KWQKConfigBase.mm: (KConfig::readEntry):
• kwq/WebCoreBridge.h: added didAddSubview, called when a render_frame's view is added as a subview of the main view.
• kwq/WebCoreViewFactory.h: added didAddSubview

WebKit:

Changed the plug-in package API to return key enumerators instead dictionaries.

• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage unload]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage extensionEnumerator]): (-[WebBasePluginPackage MIMETypeEnumerator]): (-[WebBasePluginPackage descriptionForMIMEType:]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage extensionsForMIMEType:]): (-[WebBasePluginPackage setName:]): (-[WebBasePluginPackage setPath:]): (-[WebBasePluginPackage setFilename:]): (-[WebBasePluginPackage setPluginDescription:]): (-[WebBasePluginPackage setMIMEToDescriptionDictionary:]): (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
• Plugins.subproj/WebNetscapePluginPackage.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage getPluginInfo]): (-[WebNetscapePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage executableType]):
• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController didAddSubview:]):
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase MIMETypes]): (-[WebPluginDatabase init]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:serviceType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): (-[WebBridge didAddSubview:]): new
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _didAddSubview:]): new

4:17 PM Changeset in webkit [2440] by darin

• 16 edits in trunk

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt:

WebCore:

• finished up the job of moving the file button to WebKit

I did this mainly for localization reasons.

• kwq/KWQFileButton.h: Remove filename(), add filenameChanged(), make KWQFileButton be a QWidget subclass, not a QPushButton one. Remove clicked() and paint() virtual functions, _filename, _icon, and _label data members.
• kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Just make a WebCoreFileButton. (KWQFileButton::~KWQFileButton): Less to do here now. (KWQFileButton::setFilename): Call the button to do the work. (KWQFileButton::sizeHint): Ditto. (KWQFileButton::frameGeometry): Ditto. (KWQFileButton::setFrameGeometry): Ditto. (KWQFileButton::baselinePosition): Ditto. (KWQFileButton::filenameChanged): Added. Sends message. (-[KWQFileButtonAdapter initWithKWQFileButton:]): Observe the "filename changed notification". (-[KWQFileButtonAdapter dealloc]): Stop observing. (-[KWQFileButtonAdapter filenameChanged:]): Send a signal when the notification comes in, so KHTML finds out.

• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Remove handling for RenderFileButton slotReturnPressed. (KWQSlot::call): Ditto.

• kwq/WebCoreViewFactory.h: Remove bestSize. Add setVisualFrame, visualFrame, and bestVisualFrameSize.

• kwq/KWQInputDialog.mm: Tweaked includes. Long-term we want to use "", not <>.
• kwq/KWQKConfigBase.mm: Ditto.
• kwq/KWQKHTMLPartImpl.mm: Ditto.

WebKit:

• finished up the job of moving the file button here from WebCore.

I did this mainly for localization reasons.

• WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton initWithFrame:]): Set up button control size, font, bezel style, target, and action. Also add it as a subview. (-[WebFileButton drawRect:]): Center icon in the "visual frame" part of the view, not the entire bounds. (-[WebFileButton setFilename:]): Don't show any icon when the filename is empty. (-[WebFileButton bestVisualFrameSize]): Implemented this. (-[WebFileButton visualFrame]): Ditto. (-[WebFileButton setVisualFrame:]): Ditto. (-[WebFileButton baseline]): Ditto. (-[WebFileButton beginSheet]): Added. Shared between button presses and other clicks. (-[WebFileButton chooseButtonPressed:]): Call beginSheet. (-[WebFileButton mouseDown:]): Ditto. (-[WebFileButton openPanelDidEnd:returnCode:contextInfo:]): Send the notification, WebCoreFileButtonFilenameChanged, when the filename is changed.

• WebView.subproj/WebController.m: (-[WebController policyDelegate]): Add a FIXME about the leak I found here.

1:49 PM Changeset in webkit [2439] by cblu

• 20 edits in trunk

WebCore:

Call the arguments for plug-ins "attributes" everywhere.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart):
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
• kwq/WebCoreBridge.h:

WebKit:

Call the arguments for plug-ins "attributes" everywhere.

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setAttributes:]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:attributes:]):
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView initWithFrame:mimeType:attributes:]): (-[WebNullPluginView drawRect:]):
• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): (-[WebPluginController dealloc]): (-[WebPluginController addPluginView:]):
• Plugins.subproj/WebPluginPackage.h:
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage viewFactory]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): (-[WebBridge viewForPluginWithURL:attributes:baseURL:serviceType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):

11:52 AM Changeset in webkit [2438] by cblu

• 17 edits in trunk

WebCore:

For the new plug-in API, we need to pass a WebPluginContainer to the plug-in view upon creation. The is owned by the WebFrame. To make this all work, I had to move the WebCore plug-in and java view constructors to WebBridge from WebViewFactory since WebBridge has the frame.

• khtml/khtml_part.cpp: (KHTMLPart::createJavaContext): New APPLE_CHANGES around the java context constructor so we pass the part.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart): call the bridge to create the view
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): save the context (KJavaAppletWidget::showApplet): call the bridge to create the view
• kwq/WebCoreBridge.h:
• kwq/WebCoreViewFactory.h:
• kwq/khtml/java/kjavaappletcontext.h: made constructor take the part
• kwq/khtml/java/kjavaappletwidget.h: ivar for the context

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURL]): (-[WebBridge viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebBridge viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory fileButton]): (-[WebViewFactory pluginsInfo]):

10:49 AM Changeset in webkit [2437] by darin

• 6 edits in trunk/WebKit

• fix bug where plugins crashed closing a stream that was never opened

• Plugins.subproj/WebBaseNetscapePluginStream.h: Change type for parameter of receivedError: to NPReason. It's not NPError.
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): Assert that stream is destroyed by checking stream.ndata. (-[WebBaseNetscapePluginStream setResponse:]): Set stream.ndata to nil if the stream is not successfully created by NPP_NewStream. (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): Added. Destroys the stream, but only if it's present. Also set stream.ndata to nil. This was the bug fix. (-[WebBaseNetscapePluginStream receivedError:]): Call destroyStreamWithReason:. (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Call destroyStreamWithReason:.

• English.lproj/Localizable.strings: Update.
• English.lproj/StringsNotToBeLocalized.txt: Update.

10:38 AM Changeset in webkit [2436] by cblu

• 3 edits in trunk/WebKit

Forgot to add WebPluginController back to the project after I had a project conflict.

• WebKit.pbproj/project.pbxproj:

10:27 AM Changeset in webkit [2435] by cblu

• 4 edits
  2 adds in trunk/WebKit

Added WebPluginController which controls and reacts to plug-in requests. Its owned by the WebFrame.

• Plugins.subproj/WebPluginController.h: Added.
• Plugins.subproj/WebPluginController.m: Added. (-[WebPluginController initWithWebFrame:]): (-[WebPluginController showURL:inFrame:]): (-[WebPluginController showStatus:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): (-[WebFrame pluginController]):

9:57 AM Changeset in webkit [2434] by darin

• 19 edits
  2 adds in trunk

WebCore:

• fixed 3080478 -- reproducible incomplete load on apple.com

• kwq/KWQLoaderImpl.mm: (-[WebCoreResourceLoader receivedResponse:]): Add an assert. (-[WebCoreResourceLoader cancel]): Don't finish here, just disconnect the handle from the job, and disconnect the job from the WebCoreResourceLoader, and let the KHTML code finish the cleanup later. This is the bug fix. (KWQCheckCacheObjectStatus): Add an assertion.

• kwq/KWQKjobclasses.mm: (TransferJob::~TransferJob): Don't call kill(); do the work here instead. (TransferJob::kill): Self-destruct. Need this to avoid a storage leak.

• khtml/misc/loader.cpp: (CachedObject::~CachedObject): Put some Apple-specific code inside APPLE_CHANGES. (CachedObject::setResponse): Streamlined this function. (Loader::receivedResponse): Added assertions.

• kwq/qt/qxml.h: Add more stubs.
• kwq/KWQxml.mm: Ditto.

• kwq/WebCoreViewFactory.h: Add [WebCoreViewFactory fileButton], the WebCoreFileButton protocol, and WebCoreFileButtonFilenameChanged.
• kwq/WebCoreViewFactory.m: Add WebCoreFileButtonFilenameChanged.
• WebCore.exp: Export _WebCoreFileButtonFilenameChanged.

WebKit:

Add WebFileButton, to be used by WebCore soon. It's about 1/2
done right now. Compiles but not used yet.

• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory fileButton]): Added.

• WebCoreSupport.subproj/WebFileButton.h: Added.
• WebCoreSupport.subproj/WebFileButton.m: Added.
• WebKit.pbproj/project.pbxproj: Added WebFileButton files.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveResponse:]): Add an assertion.

5:40 AM Changeset in webkit [2433] by mjs

• 5 edits in trunk/WebKit

• fixed 2876448 - The authentication panel should give a note when the user tried to log in and failed

Also, made the message different (and more helpful) when the
authentication is for a proxy server.

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Use different messages depending on proxy and previous failure count.

Updated localized strings:

• English.lproj/Localizable.strings:
• English.lproj/StringsNotToBeLocalized.txt:

2:29 AM Changeset in webkit [2432] by mjs

• 7 edits in trunk/WebKit

• fixed 2876446 - The label in the authentication panel needs to adjust its height depending on content

Also improved [NSControl sizeToFitAndAdjustWindowHeight] method.

• Panels.subproj/English.lproj/WebAuthenticationPanel.nib: Adjusted springs.
• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Use sizeToFitAndAdjustWindowHeight on main label.

• Misc.subproj/WebNSControlExtras.m: (-[NSControl sizeToFitAndAdjustWindowHeight]): Improved the logic so the best height is picked while leaving the width alone. Before, the label would always come out to be a very wide single line.

Oct 22, 2002:

11:31 PM Changeset in webkit [2431] by mjs

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Made WebControllerSets.h private. Also alphabetized headers in target pane and subproject folders.

11:25 PM Changeset in webkit [2430] by mjs

• 6 edits in trunk/WebCore

Forgot to check this in earlier:

• fixed 3077084 - debugging output when suppressing or allowing pop-ups

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
• kwq/KWQLogging.h:
• kwq/KWQLogging.m:

10:48 PM Changeset in webkit [2429] by cblu

• 5 edits in trunk/WebKit

load and unload is only a WebNetscapePluginPackage thing since you can't unload an NSBundle.

• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m:
• Plugins.subproj/WebNetscapePluginPackage.h:

10:35 PM Changeset in webkit [2428] by cblu

• 9 edits
  4 adds in trunk/WebKit

More moving stuff around for the new plug-in API. Added WebBasePluginPackage and added subclass WebPluginPackage. Also made WebNetscapePluginPackage a subclass of WebBasePluginPackage.

• Plugins.subproj/WebBasePluginPackage.h: Added.
• Plugins.subproj/WebBasePluginPackage.m: Added. (+[WebBasePluginPackage pluginWithPath:]): creates a WebPluginPackage or WebNetscapePluginPackage (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage extensionToMIMEDictionary]): (-[WebBasePluginPackage MIMEToExtensionsDictionary]): (-[WebBasePluginPackage MIMEToDescriptionDictionary]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage unload]): (-[WebBasePluginPackage isLoaded]): (-[WebBasePluginPackage description]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNetscapePluginPackage.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]):
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase pluginForFilename:]): (-[WebPluginDatabase MIMETypes]): (-[WebPluginDatabase init]):
• Plugins.subproj/WebPluginPackage.h: Added.
• Plugins.subproj/WebPluginPackage.m: Added. (-[WebPluginPackage initWithPath:]):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): check the class of the plug-in when deciding which view to create. (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]): same here.
• WebKit.pbproj/project.pbxproj:

5:41 PM Changeset in webkit [2427] by hyatt

• 3 edits in trunk/WebKit

Getting XML docs at least made for XML files...

• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation setDataSource:]):

5:40 PM Changeset in webkit [2426] by hyatt

• 7 edits in trunk/WebCore

Get XML files closer. An XML doc is at least made. No
parsing works yet though.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::setPolicyBaseURL):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge setContentType:]):

5:24 PM Changeset in webkit [2425] by cblu

• 11 edits in trunk

WebCore:

Fixed: 3023814 - contexual menus and dragging doesn't work for some images

Added a innerNonSharedNode to NodeInfo that points to the node which is not shared by another node. In this case, the innerNonSharedNode is the image node not the area node.

• khtml/rendering/render_frames.cpp: (RenderFrameSet::nodeAtPoint): call setInnerNonSharedNode
• khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint): call setInnerNonSharedNode
• khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint): call setInnerNonSharedNode
• khtml/rendering/render_object.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): use the innerNonSharedNode

WebKit:

Made new plug-in API headers private.

• WebKit.pbproj/project.pbxproj:

4:25 PM Changeset in webkit [2424] by hyatt

• 5 edits in trunk/WebCore

Fix slashdot. Make sure the KONQBLOCK hack just throws away
margins at the tops and bottoms of kids.

• khtml/css/html4.css:
• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

3:44 PM Changeset in webkit [2423] by darin

• 5 edits in trunk/WebKit

WebKit:

• Misc.subproj/WebKitErrors.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): Rename WebErrorLocationChangeInterruptedByURLPolicyChange to WebErrorLocationChangeInterruptedByPolicyChange.

WebBrowser:

• LocationChangeHandler.m: (-[LocationChangeHandler locationChangeDone:forDataSource:]): Rename WebErrorLocationChangeInterruptedByURLPolicyChange to WebErrorLocationChangeInterruptedByPolicyChange.

3:37 PM Changeset in webkit [2422] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): Send the new error whenever a policy change happens. The old code was sending a successful completion in the download and ignore cases.

3:27 PM Changeset in webkit [2421] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• fixed 3080873 -- Error in console when no bookmark file found -[WebBookmarkGroup _loadBookmarkGroupGuts]

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _loadBookmarkGroupGuts]): removed ERROR that was useful only long ago.

WebBrowser:

• fixed buggy case with my previous checkin

• ActivityViewer.h: new ivar _pendingExpansionItems
• ActivityViewer.m: (-[ActivityViewer init]): create empty _pendingExpansionItems (-[ActivityViewer dealloc]): release _pendingExpansionItems (-[ActivityViewer expandPendingItems]): expand _pendingExpansionItems and empty the set (-[ActivityViewer showActivity:]): call expandPendingItems when window becomes visible (-[ActivityViewer addTopLevelActivity:]): if window is not visible, save item in _pendingExpansionItems to expand later.

3:18 PM Changeset in webkit [2420] by rjw

• 9 edits
  4 adds in trunk/WebKit

Added stubs from common WebResourceHandleDelegate base
class.

• Plugins.subproj/WebBaseNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.h:
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebBaseResourceHandleDelegate.h: Added.
• WebView.subproj/WebBaseResourceHandleDelegate.m: Added.
• WebView.subproj/WebMainResourceClient.h:

3:13 PM Changeset in webkit [2419] by darin

• 5 edits
  4 adds in trunk/WebKit

Make the panel position itself above the main window.
Too bad we can't use a sheet, but this is better than a random position.

• WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m: (-[WebJavaScriptTextInputPanel initWithPrompt:text:]): Use the new [NSWindow sizeToFitAndAdjustWindowHeight] and [NSControl sizeToFitAndAdjustWindowHeight].

• Misc.subproj/WebNSControlExtras.h: Added.
• Misc.subproj/WebNSControlExtras.m: Added.
• Misc.subproj/WebNSWindowExtras.h: Added.
• Misc.subproj/WebNSWindowExtras.m: Added.
• WebKit.pbproj/project.pbxproj: Added above files.

• English.lproj/StringsNotToBeLocalized.txt: Update.

3:11 PM Changeset in webkit [2418] by hyatt

• 4 edits in trunk/WebCore

Fix for left-hand-side of wired.com. A disturbingly basic
bug. I was applying a parent's margins to its children
when collapsing, even if the parent had a border/padding set
that should have separated it from its kids.

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

3:01 PM Changeset in webkit [2417] by kocienda

• 5 edits in trunk/WebKit

WebKit:

• Misc.subproj/WebKitErrors.h: Add new error code to signify that a location change has been interrupted by a change in the URLPolicy governing the load.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Add code to check the URLPolicy for the URL in the request that is submitted to us in this delegate method. Send a locationChangeDone:forDataSource: message with an error using the newly-defined code in cases where the location change should be cancelled.

WebBrowser:

Update LocationChangeHandler to handle the case where the
URLPolicy changes during a page load. This happens in the
case where we attempt to load an FTP URL that looks like
a URL to a file, but turns out to be a URL to a directory.

• LocationChangeHandler.m: (-[LocationChangeHandler locationChangeDone:forDataSource:])

2:56 PM Changeset in webkit [2416] by cblu

• 3 edits
  3 adds in trunk/WebKit

Added protocol headers for new plug-in API.

• Plugins.subproj/WebPlugin.h: Added.
• Plugins.subproj/WebPluginContainer.h: Added.
• Plugins.subproj/WebPluginViewFactory.h: Added.
• WebKit.pbproj/project.pbxproj:

2:45 PM Changeset in webkit [2415] by hyatt

• 4 edits in trunk/WebCore

Optimize my inline margin discarding to be smart about the
case when the inline has a block and its beginning or
end. Fixes aintitcool.com.

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

2:40 PM Changeset in webkit [2414] by cblu

• 14 edits
  4 adds
  4 deletes in trunk/WebKit

• Moved things around to make room for new plug-in API.
• Renamed WebNetscapePlugin to WebNetscapePluginPackage.
• Renamed WebNetscapePluginDatabase to WebPluginDatabase.

• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setPluginPointer:]):
• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView plugin]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:arguments:]):
• Plugins.subproj/WebNetscapePluginNullEventSender.h: Added.
• Plugins.subproj/WebNetscapePluginNullEventSender.m: Added. (-[WebNetscapePluginNullEventSender initWithPluginView:]): (-[WebNetscapePluginNullEventSender dealloc]): (-[WebNetscapePluginNullEventSender sendNullEvents]): (-[WebNetscapePluginNullEventSender stop]):
• Plugins.subproj/WebNetscapePluginPackage.h: Added.
• Plugins.subproj/WebNetscapePluginPackage.m: Added. (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): (-[WebNetscapePluginPackage getPluginInfo]): (-[WebNetscapePluginPackage stringByResolvingSymlinksAndAliasesInPath:]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage unload]): (-[WebNetscapePluginPackage NPP_SetWindow]): (-[WebNetscapePluginPackage NPP_New]): (-[WebNetscapePluginPackage NPP_Destroy]): (-[WebNetscapePluginPackage NPP_NewStream]): (-[WebNetscapePluginPackage NPP_StreamAsFile]): (-[WebNetscapePluginPackage NPP_DestroyStream]): (-[WebNetscapePluginPackage NPP_WriteReady]): (-[WebNetscapePluginPackage NPP_Write]): (-[WebNetscapePluginPackage NPP_HandleEvent]): (-[WebNetscapePluginPackage NPP_URLNotify]): (-[WebNetscapePluginPackage NPP_GetValue]): (-[WebNetscapePluginPackage NPP_SetValue]): (-[WebNetscapePluginPackage NPP_Print]): (-[WebNetscapePluginPackage MIMEToExtensionsDictionary]): (-[WebNetscapePluginPackage extensionToMIMEDictionary]): (-[WebNetscapePluginPackage MIMEToDescriptionDictionary]): (-[WebNetscapePluginPackage name]): (-[WebNetscapePluginPackage filename]): (-[WebNetscapePluginPackage path]): (-[WebNetscapePluginPackage isLoaded]): (-[WebNetscapePluginPackage pluginDescription]): (-[WebNetscapePluginPackage description]): (functionPointerForTVector): (tVectorForFunctionPointer):
• Plugins.subproj/WebPlugin.h: Removed.
• Plugins.subproj/WebPlugin.m: Removed.
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (+[WebPluginDatabase installedPlugins]): (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase pluginForFilename:]): (-[WebPluginDatabase MIMETypes]): (-[WebPluginDatabase init]):
• Plugins.subproj/WebPluginNullEventSender.h: Removed.
• Plugins.subproj/WebPluginNullEventSender.m: Removed.
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory pluginsInfo]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.m: (+[WebController canShowMIMEType:]):

2:36 PM Changeset in webkit [2413] by darin

• 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m

* empty log message *

2:36 PM Changeset in webkit [2412] by darin

• 3 edits in trunk/WebKit

• WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m: Added missing import.

1:57 PM Changeset in webkit [2411] by darin

• 4 edits
  6 adds in trunk/WebKit

• fixed 3077305 -- js dialog not yet implemented - crash (fatal error)

• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): Create a WebJavaScriptTextInputPanel and run it.

• English.lproj/WebJavaScriptTextInputPanel.nib: Added.
• WebCoreSupport.subproj/WebJavaScriptTextInputPanel.h: Added.
• WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m: Added.
• WebKit.pbproj/project.pbxproj: Added

1:52 PM Changeset in webkit [2410] by cblu

• 5 edits in trunk/WebKit

Use the mouseDown point instead of the mouseDragged point to determine the mouseOffset when dragging images. When you drag an image now, the point where you clicked is the point where the cursor is in relation to the drag image.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): retain the mouse down event (-[WebHTMLView mouseDragged:]): use the mouse down event
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): release the mouse down event

1:06 PM Changeset in webkit [2409] by hyatt

• 5 edits in trunk/WebCore

Removing konq's flow-around-floats hack for <blockquote> and
<dl>. These objects are allowed to flow under floats. Fixes
www.webreference.com's front page.

Also fixing a bug in my <td> margin collapsing quirk that
prevented lists (ol,ul,dl,menu,dir) from collapsing their
top margins into the td.

• khtml/css/html4.css:
• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::addChild):

1:20 AM Changeset in webkit [2408] by hyatt

• 3 edits in trunk/WebCore

Fix a typo in my change to the h1 rule.

• khtml/css/html4.css:

1:20 AM Changeset in webkit [2407] by hyatt

• 1 edit in trunk/WebCore/khtml/css/html4.css

* empty log message *

12:51 AM Changeset in webkit [2406] by hyatt

• 12 edits in trunk/WebCore

Ok, this patch does a lot of stuff. It contains a complete
rewrite of the WinIE quirk for handling collapsing margins
at the tops and bottoms of table cells. We match WinIE's
behavior for all HTML4 block-level elements.

This patch also applies a bottom margin to <form> elements,
which is what was causing the missing space on livepage.apple.com
underneath the textfield on the right. WinIE and Gecko both
put a bottom margin on all forms.

This patch also updates the collapsing margin code to detect
inlines that have been morphed into blocks by KHTML (this is
so wrong, don't even get me started, you can't treat an inline
as a block, this code is lame, etc. etc.) and to properly ignore
their margins completely. Fixing the code to not morph inlines
is another architectural problem that will have to be dealt
with (sigh).

• khtml/css/css_valueimpl.h:
• khtml/css/cssparser.cpp: (StyleBaseImpl::parseValue): (StyleBaseImpl::parseUnit):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp:
• khtml/css/html4.css:
• khtml/misc/khtmllayout.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::RenderFlow): (RenderFlow::layout): (RenderFlow::layoutBlockChildren): (RenderFlow::addChild):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_object.h:

Oct 21, 2002:

5:45 PM Changeset in webkit [2405] by darin

• 13 edits
  1 delete in trunk

WebCore:

• kwq/KWQInputDialog.mm: (QInputDialog::getText): Call the view factory to do the heavy lifting.

• kwq/WebCoreViewFactory.h: Add runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:. Use a protocol for the subclass responsibility.
• kwq/WebCoreViewFactory.m: Remove stub methods not needed because of the subclass responsibility technique we are using.

• kwq/qt/qstylesheet.h: Made this inline, since it does nothing.
• kwq/KWQStyleSheet.mm: Removed.
• WebCore.pbproj/project.pbxproj: Removed KWQStyleSheet.mm.

WebKit:

• WebCoreSupport.subproj/WebViewFactory.h: Changed to use new protocol scheme so we get an error if we forget to implement something.
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): Stub.

5:28 PM Changeset in webkit [2404] by rjw

• 10 edits in trunk/WebKit

Real checkin this time!

5:00 PM Changeset in webkit [2403] by trey

• 4 edits in trunk/WebKit

WebFoundation:

Fixed typos and other doc comment errors found during API review.

• CacheLoader.subproj/WebCacheManager.m:
• CacheLoader.subproj/WebProtocolHandler.h:
• Misc.subproj/WebError.h:

WebKit:

Fixed typos and other doc comment errors found during API review.

• WebView.subproj/WebController.h:

4:09 PM Changeset in webkit [2402] by rjw

• 14 edits in trunk/WebKit

Modernized the activity window a little bit. Fixed
a slew of activity related bugs.

• BrowserWebController.m: (-[BrowserWebController identifierForInitialRequest:fromDataSource:]): (-[BrowserWebController resource:willSendRequest:fromDataSource:]): (-[BrowserWebController resource:didReceiveResponse:fromDataSource:]): (-[BrowserWebController resource:didReceiveContentLength:fromDataSource:]): (-[BrowserWebController resource:didFinishLoadingFromDataSource:]):
• FrameProgressEntry.h:
• FrameProgressEntry.m: (-[FrameProgressEntry _initWithFrame:]): (-[FrameProgressEntry provisionalDataSourceWasCommitted]): (-[FrameProgressEntry activeSubresourcesForDataSource:]): (-[FrameProgressEntry trackSubresource:forDataSource:]): (-[FrameProgressEntry completedEntry:fromDataSource:]): (-[FrameProgressEntry trackSubframe:fromDataSource:]): (-[FrameProgressEntry resetProvisionalLoad]):
• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor _monitorProvisionalDataSourceForFrame:]): (-[LoadProgressMonitor _incrementProgressBarWithOldBytes:newBytes:oldTotal:newTotal:isMainResource:]): (-[LoadProgressMonitor createProgressEntryWithRequest:dataSource:]): (-[LoadProgressMonitor completedEntry:fromDataSource:]): (-[LoadProgressMonitor receivedError:forEntry:fromDataSource:]): (-[LoadProgressMonitor receivedUpdateForEntry:URLString:bytesLoaded:bytesExpected:error:dataSource:]):
• ResourceProgressEntry.h:
• ResourceProgressEntry.m:

Changed WebResourceLoadDelegate methods to include an identifier
as first parameter. This will help clients track callbacks relating
to a particular resource. Added identifierForInitialRequest:fromDataSource:
so clients can create their own identifier.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:willSendRequest:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebController.m: (-[WebResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[WebResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[WebResourceLoadDelegate resource:didReceiveResponse:fromDataSource:]): (-[WebResourceLoadDelegate resource:didReceiveContentLength:fromDataSource:]): (-[WebResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[WebResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebResourceLoadDelegate.h:

3:41 PM Changeset in webkit [2401] by hyatt

• 10 edits in trunk/WebCore

Implement support for a new @-rule called @konq-quirks. This
will allow us to put style rules into html4.css that only
apply for pages in quirks mode.

• khtml/css/css_ruleimpl.cpp: (CSSQuirksRuleImpl::CSSQuirksRuleImpl): (CSSQuirksRuleImpl::~CSSQuirksRuleImpl): (CSSQuirksRuleImpl::cssRules): (CSSQuirksRuleImpl::appendRule): (CSSQuirksRuleImpl::insertRule): (CSSQuirksRuleImpl::deleteRule):
• khtml/css/css_ruleimpl.h:
• khtml/css/cssparser.cpp: (StyleBaseImpl::parseAtRule):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp:
• khtml/css/cssstyleselector.h:
• khtml/dom/css_rule.h:

2:19 PM Changeset in webkit [2400] by cblu

• 7 edits in trunk/WebKit

WebFoundation:

Partial fix for 2968124 - file misnamed on download

• added the "filename" method to response so that the logic for getting the correct filename for a resource is in one easy place.
• obey the "Content-Disposition" header. Not totally fixed because the parsing doesn't totally work.

• CacheLoader.subproj/WebResourceResponse.h:
• CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse filename]): new, filename by using "Content-Disposition" and MIME type. (-[WebResourceResponse _setContentType:]): no changes, but I added _setFilename
• CacheLoader.subproj/WebResourceResponsePrivate.h:
• Misc.subproj/WebFileTypeMappings.h: remove unused method
• Misc.subproj/WebFileTypeMappings.m: remove unused method
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler setResponseMetadata:]): call _setFilename for the "Content-Disposition"

WebKit:

Changed content policy API to pass a response instead of MIME type so client can get the mime type and filename from one class.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

Changed content policy API to pass a response instead of MIME type so client can get the mime type and filename from one class.

• BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andURL:inFrame:withContentPolicy:]):

12:45 PM Changeset in webkit [2399] by darin

• 4 edits in trunk/WebKit

• fixed 3080512 -- REGRESSION: moving from old page to new one, we get blank white before the new one is ready

Roll out a bunch of my changes, because they weren't complete. Added FIXMEs for the
problems I was unsuccessfully trying to fix.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]):
• WebView.subproj/WebView.m: (-[WebView initWithFrame:]), (-[WebView isOpaque]), (-[WebView drawRect:]): Roll back.

12:09 PM Changeset in webkit [2398] by darin

• 5 edits in trunk/WebCore

Remove closeEntireTree now that deferred close takes care of that case.

• khtml/html/htmlparser.cpp: (KHTMLParser::startBody):
• khtml/rendering/render_object.h:

11:23 AM Changeset in webkit [2397] by darin

• 4 edits in trunk/WebCore

• fixed 3075041 -- text larger/smaller increment too large when font-size specified as %

• khtml/css/cssstyleselector.cpp: Don't apply the zoom factor to a font size that already has the zoom factor applied.

11:12 AM Changeset in webkit [2396] by darin

• 5 edits in trunk/WebKit

• fixed 3080246 -- REGRESSION: Animated GIFs sometimes disappear after drag or scroll

Once more, with feeling.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setNeedsLayoutIfSizeChanged:]): Added setNeedsDisplay:YES here. The lack of this is what caused the bug. But also don't do any work when the size doesn't change. This prevents this from being called at all in the scrolling case, which is what we want. (-[WebHTMLView viewWillMoveToSuperview:]): Just the name change. (-[WebHTMLView layout]): Store the layout size for the above methods.
• WebView.subproj/WebHTMLViewPrivate.h: Add a place to store the size.

• WebView.subproj/WebImageView.m: (-[WebImageView layout]): Roll this change back in.

11:04 AM Changeset in webkit [2395] by darin

• 4 edits in trunk/WebCore

• khtml/khtmlview.cpp: (KHTMLView::clear): Default to fast scrolling. I'm pretty sure this was just backwards here.

8:53 AM Changeset in webkit [2394] by darin

• 3 edits in trunk/WebKit

• fixed 3080246 -- REGRESSION: Animated GIFs sometimes disappear after drag or scroll

• WebView.subproj/WebImageView.m: (-[WebImageView layout]): My change to this caused the regression. Not sure why, but I'll just back out because the change wasn't important.

3:06 AM Changeset in webkit [2393] by hyatt

• 4 edits in trunk/WebCore

DLs are supposed to have margins.

• khtml/css/html4.css:

1:16 AM Changeset in webkit [2392] by hyatt

• 4 edits in trunk/WebCore

Fix for margin problems on aintitcool.com. There was a subtlety
to WinIE's quirk. For <h1>-<h6> only, they don't collapse the
bottom margin for table cells (they still collapse the top
margin). I just love emulating the odd behavior of WinIE.
Wheee.

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

Oct 20, 2002:

11:11 PM Changeset in webkit [2391] by cblu

• 3 edits in trunk/WebKit

Fixed: 3025847 - Can't use any menu command keys after clicking on a plugin

Don't give plug-ins command-modified keys anymore because the ability wasn't worth the annoyance. If only plug-ins truthfully responded t events! Anyway, filed 3080103 so that I can look into a way to make this work for everybody.

• Plugins.subproj/WebBaseNetscapePluginView.m:

11:03 PM Changeset in webkit [2390] by darin

• 4 edits in trunk/WebCore

Redid my fix. It was just an ordering thing. The image had to already be
installed as the current image before calling ref(), because in the cached
case, you get the loading complete callback right then.

• khtml/rendering/render_image.cpp: (RenderImage::updateFromElement): Call deref on the old image later. Basically, instead of moving the ref of the new image up, I moved the deref of the old image down.

10:39 PM Changeset in webkit [2389] by darin

• 4 edits in trunk/WebCore

Roll out my render_image.cpp change. It was causing a big problem
getting images from the cache. I need to study further to figure out why.

• khtml/rendering/render_image.cpp: (RenderImage::updateFromElement): Roll back the change.

10:03 PM Changeset in webkit [2388] by cblu

• 4 edits in trunk/WebKit

Fixed: 3025868 - Plugin context menu disappears then reappears if you click off of it

Also fixed some rare dragging weirdness in WebHTMLView. If you attempted to drag a plug-in after dragging an image, the image would drag again.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView mouseDragged:]): subclass and do nothing to prevent calling mouseDragged in WebHTMLView (-[WebBaseNetscapePluginView performKeyEquivalent:]): no changes to this method, removed menuForEvent, wasn't needed after all
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream stop]): minor clean-up

9:02 PM Changeset in webkit [2387] by hyatt

• 4 edits in trunk/WebCore

Rewrite the clearing code for floats. Rewrote the
collapsing margin code to really work with floating and
clearing. This fixes the right hand side of wired.com.

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::checkClear): (RenderFlow::addChild):

5:41 PM Changeset in webkit [2386] by darin

• 4 edits in trunk/WebCore

• fixed 3007961 -- Crash in DOM::HTMLImageElementImpl::parseAttribute

• khtml/rendering/render_image.cpp: (RenderImage::updateFromElement): Be sure to call ref on the new image before calling deref on the old image. That's because deref on the old image causes a cache flush, which might cause the image to go away in certain cases.

5:08 PM Changeset in webkit [2385] by cblu

• 4 edits in trunk/WebCore

Fixed possible build failure.

• kwq/KWQDOMNode.cpp: (isImage): remove unused variable.

4:54 PM Changeset in webkit [2384] by darin

• 3 edits in trunk/WebKit

• fixed a minor problem with autorelease I just ran into

• WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]): Create an autorelease pool for the benefit of the class initialize functions that will be called.

4:18 PM Changeset in webkit [2383] by cblu

• 4 edits in trunk/WebCore

Partial fix for:
3023814 - contexual menus and dragging doesn't work for some images

The image map case is still broken because I need to find a way to get the RenderImage for an AREA node. Anyone know how?

• kwq/KWQDOMNode.cpp: (isImage): Also return true if the node is an INPUT tag with TYPE set to "image"

3:10 PM Changeset in webkit [2382] by cblu

• 13 edits in trunk/WebKit

Fixed 3050010: Should show contextual menu for WebImageView
Also made drags from WebImageView work.

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: added _web_setPromisedImageDragImage which does the hackery to extend the promised file drag for images
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _menuForElement:]): added, gets menu items from delegate and creates menu
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): simplified, gets element and calls -[WebController _menuForElement:] (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): call _web_setPromisedImageDragImage: when dragging image
• WebView.subproj/WebImageRepresentation.h:
• WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation dealloc]): release the URL (-[WebImageRepresentation URL]): added so WebImageView can get the URL (-[WebImageRepresentation setDataSource:]): retain the URL
• WebView.subproj/WebImageView.h: use new drag bools
• WebView.subproj/WebImageView.m: (-[WebImageView initWithFrame:]): ditto (-[WebImageView setAcceptsDrags:]): ditto (-[WebImageView acceptsDrags]): ditto (-[WebImageView setAcceptsDrops:]): ditto (-[WebImageView acceptsDrops]): ditto (-[WebImageView controller]): new (-[WebImageView menuForEvent:]): new, creates element and calls -[WebController _menuForElement:] (-[WebImageView mouseDragged:]): drag promised file (-[WebImageView dragImage:at:offset:event:pasteboard:source:slideBack:]): call _web_setPromisedImageDragImage: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): new

12:59 PM Changeset in webkit [2381] by darin

• 7 edits in trunk/WebKit

• fixed a problem where you would get garbage bits when resizing while loading a standalone image

Cleaned up some of the complexity of how we were handling resizing.

• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Do the update twice to properly handle the case where a disappearing scroller makes a second scroller appear or vice versa.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Remove the code that was trying to set the setDrawsBackground flag on the scroll view. It was doing it wrong, causing bugs with drawing non-HTML views while loading. Also, it wasn't working as an optimization, since the window was still drawing the metallic background behind. We can revisit adding an optimization at the WebHTMLView level if it creates a measurable speed increase, but we must be careful to test loading with non-HTML views along with the HTML cases.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setNeedsLayoutToYes:]): Added. Calls setNeedsLayout:YES. (-[WebHTMLView viewWillMoveToSuperview:]): Added. Registers so we get _setNeedsLayoutToYes: calls when the superview's size changes. This allows us to do a layout at all the right times. (-[WebHTMLView layout]): Call setNeedsDisplay:YES, because if we do a layout without a complete display the screen will look bad. Also do a reapplyStyles, because if there are pending style changes we want to apply them before doing a layout since they could affect the layout. (-[WebHTMLView drawRect:]): Remove the special case that says to always relayout during live resize, because it works without a special case now. For the other live resize case, turn it from a special case into a general one. Any time layout is done, make sure to draw the entire view, not just the passed-in rectangle, and call setNeedsDisplay:NO so we don't do it all over again.

• WebView.subproj/WebImageView.m: (-[WebImageView layout]): Explicitly set frame size to 0,0 when there is no image.

• WebView.subproj/WebView.m: Remove now-unnecessary viewWillStartLiveResize, setFrame:, viewDidEndLiveResize, isOpaque, and drawRect overrides. (-[WebView initWithFrame:]): Don't call setDrawsBackground:NO for the reasons above. Don't set scroll bar visibility because the dynamic scroll bars view handles that already.

9:09 AM Changeset in webkit [2380] by darin

• 4 edits in trunk/WebCore

• fixed 3076390 -- crash in DOM::DocumentImpl::setParsing loading thread detail page at groups.apple.com

• khtml/khtml_part.cpp: (KHTMLPart::openURL): Don't do any redirect special case if the document is nil. Just do a normal load in that case.

8:40 AM Changeset in webkit [2379] by darin

• 5 edits in trunk/WebCore

• fixed 3079864 -- REGRESSION: assertion failure on any page with a form element

• khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Roll back the parent call to use NodeBaseImpl::attach. Not sure why I changed that at the last minute before my last checkin, but it was *bad*.

• fixed a crash I observed when clicking on an about:blank page

• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Check for nil renderer.

Oct 19, 2002:

10:10 PM Changeset in webkit [2378] by darin

• 3 edits in trunk/WebKit

• fixed 3073693 -- flash drawn to screen even when window minimized

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): Set up additional notifications. Don't start the null event sender if the window is miniaturized. (-[WebBaseNetscapePluginView windowDidMiniaturize:]): Stop the null event sender. (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): Start the null event sender.

4:41 PM Changeset in webkit [2377] by darin

• 8 edits in trunk/WebCore

• fixed 3075032 -- textarea contents sometimes aren't shown

The root of the problem is that we weren't delivering close calls to
the render objects in the case where we created them late due to our FOUC
fix. I taught the DOM implementation to remember that a close call is
due, and deliver it when the render object is created. We can probably
replace the closeEntireTree hack with this too. I'll talk to Dave about
that on Monday.

• khtml/xml/dom_nodeimpl.h: Add m_rendererNeedsClose and closeRenderer.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): Initialize m_rendererNeedsClose to false. (NodeImpl::closeRenderer): Call close on the renderer if it's created, otherwise set m_rendererNeedsClose. (NodeImpl::attach): If the renderer is created and m_rendererNeedsClose is true call close on the renderer and set it to false.

• khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Rearrange this so that the base class attach is called before updateFromElement is called. This allows the base attach to do a close for us before we update.

• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Call closeRenderer on the DOM node rather than calling close on the render node. (KHTMLParser::popOneBlock): Ditto.
• khtml/xml/xml_tokenizer.cpp: (XMLHandler::endElement): Ditto. (XMLTokenizer::finish): Ditto.

10:19 AM Changeset in webkit [2376] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Removed stray printf.

1:11 AM Changeset in webkit [2375] by hyatt

• 5 edits in trunk/WebCore

A couple of whitespace fixes. What's really odd about these
fixes is that they *work* but only if you load the page by
hitting "Back". I suspect that I've now fixed the bugs on
KHTML's end, and we have some sort of whitepsace dropping
problem on our end.

• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::write):