Context Navigation

← Previous Period
Next Period →

Timeline

Oct 27, 2002:

11:54 PM Changeset in webkit [2488] by darin

11 edits in trunk

WebCore:

fixed 3058845 -- <input type=file> uses hard-coded width of 200 pixels for filename

khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): Use a default of 20 "x-widths" wide, to match Mozilla, rather than the 17 that is in KHTML by default. (RenderFileButton::calcMinMaxWidth): Pass in a character width here, using the same 20-character rule as above.
kwq/KWQFileButton.h: Replace sizeHint() with sizeForCharacterWidth(int).
kwq/KWQFileButton.mm: (KWQFileButton::sizeForCharacterWidth): Pass character count to the WebCoreFileButton. (KWQFileButton::baselinePosition): Fix baseline computation. It was computing some huge negative number before and was obviously broken.
kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Add an assertion.
kwq/WebCoreViewFactory.h: Replace bestVisualFrameSize with bestVisualFrameSizeForCharacterCount:.

WebKit:

WebKit part of filename width fix

WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton drawRect:]): Compute left position by starting at the right side of the button frame rather than by starting at the right side of the overall bounds. Removes dependency on fixed-width filename area. (-[WebFileButton updateLabel]): Added. Computes ellipsized filename. (-[WebFileButton setFilename:]): Use updateLabel instead of code in line here. (-[WebFileButton setFrameSize:]): Call updateLabel. (-[WebFileButton bestVisualFrameSizeForCharacterCount:]): Compute a width based on the count passed in rather than a hardcoded 200-pixel constant.

10:52 PM Changeset in webkit [2487] by darin

5 edits in trunk/WebKit

fixed 3037369 -- Status text not cleared after start of drag from page

WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Find the highest-level enclosing WebHTMLView, and call _updateMouseoverWithEvent: with the mouseUp event after the drag is done. (-[WebHTMLView mouseMovedNotification:]): Just call _updateMouseoverWithEvent:, the code from here was moved into there.

WebView.subproj/WebHTMLViewPrivate.h: Declare _updateMouseoverWithEvent.
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _updateMouseoverWithEvent:]): Moved all the code from mouseMovedNotification: in here so it could be used twice.

6:27 PM Changeset in webkit [2486] by gramps

8 edits in trunk

WebCore:

khtml/ecma/kjs_navigator.cpp:

(Navigator::getValueProperty):

Tweaked AppName, Product, and Vendor logic.

WebKit:

WebView.subproj/WebController.m:

(-[WebController userAgentForURL:]):

Changed default user agent to Mozilla 1.1.

WebBrowser:

Debug/DebugUtilities.m:

(-[DebugUtilities userAgentSubmenuItem]):

Updated all user agents and added new experimental items.

9:08 AM Changeset in webkit [2485] by darin

9 edits in trunk

WebCore:

kwq/KWQLoader.mm: (KWQServeRequest): Add a missing "delete job" for one particular failure case.

WebKit:

Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy dealloc]): Added, so we don't leak the title.

Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup removeBookmark:]):
Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList removeChild:]): Added retain/release pairs so we don't use an object after it's deallocated. In practice this doesn't happen the way these are used by Alex since they are in an array, but they have windows of vulnerability depending on exactly how they are used.

WebBrowser:

BookmarksController.m: (-[BookmarksController _blessOrCreateSpecialFolders]): Fix indenting.

Oct 26, 2002:

11:45 PM Changeset in webkit [2484] by darin

8 edits in trunk/WebCore

fixed a bug in the WebCore cache that caused it to not cache very much after a while, and also caused a crash I saw twice on my machine

Adjust total size of items in the LRU list, when the size of one of the
items that's in the list is changed.

khtml/misc/loader.h: Added a size parameter (default 0) to the CachedObject constructor. Added a protected CachedObject::setSize() and made m_size private. Added Cache::adjustSize() and Cache::checkLRUAndUncacheableListIntegrity().
khtml/misc/loader.cpp: (CachedObject::setSize): Added. This is now the only legal way to change the size of a cached object, and it calls Cache::adjustSize. (CachedCSSStyleSheet::CachedCSSStyleSheet): Pass the length into the base class's constructor instead of setting m_size. (CachedCSSStyleSheet::data): Call setSize() instead of setting m_size. Also get the size back with size() rather than m_size. (CachedScript::CachedScript): Pass the length into the base class's constructor instead of setting m_size. (CachedScript::data): Call setSize() instead of setting m_size. Also get the size back with size() rather than m_size. (CachedImage::CachedImage): Don't set m_size to 0, since the base class's constructor does that already. (CachedImage::clear): Use setSize() to set the size to 0 instead of setting m_size directly. (CachedImage::data): Use setSize() instead of setting m_size directly. (Cache::checkLRUAndUncacheableListIntegrity): Useful debugging function. Left in but ifdef'd out. (Cache::adjustSize): Added. Changes the "total LRU list size" by the passed-in delta, but only if the passed-in object is in the LRU list.

kwq/KWQLineEdit.mm:
kwq/KWQTextField.h:
kwq/KWQTextField.mm: Renamed the Objective C class KWQNSTextField to KWQTextField.

4:55 PM Changeset in webkit [2483] by darin

8 edits in trunk/JavaScriptCore

changed to use #if APPLE_CHANGES and #if !APPLE_CHANGES consistently

We no longer do #ifdef APPLE_CHANGES or #ifndef APPLE_CHANGES.

kjs/collector.cpp:
kjs/collector.h:
kjs/grammar.cpp:
kjs/internal.cpp:
kjs/ustring.h:

4:49 PM Changeset in webkit [2482] by darin

3 edits
22 deletes in trunk/WebCore

Tools:

Scripts/check-forwarding-headers: Added. Finds unused forwarding headers in WebCore.

WebCore:

removed forwarding headers that are not actually needed

ForwardingHeaders/kcmdlineargs.h: Removed.
ForwardingHeaders/kinstance.h: Removed.
ForwardingHeaders/kio/kprinter.h: Removed.
ForwardingHeaders/kio/ktrader.h: Removed.
ForwardingHeaders/kio/scheduler.h: Removed.
ForwardingHeaders/kparts/factory.h: Removed.
ForwardingHeaders/kparts/historyprovider.h: Removed.
ForwardingHeaders/kstddirs.h: Removed.
ForwardingHeaders/qarray.h: Removed.
ForwardingHeaders/qbrush.h: Removed.
ForwardingHeaders/qbutton.h: Removed.
ForwardingHeaders/qcollection.h: Removed.
ForwardingHeaders/qcombobox.h: Removed.
ForwardingHeaders/qframe.h: Removed.
ForwardingHeaders/qglobal.h: Removed.
ForwardingHeaders/qiodevice.h: Removed.
ForwardingHeaders/qlineedit.h: Removed.
ForwardingHeaders/qnamespace.h: Removed.
ForwardingHeaders/qpen.h: Removed.
ForwardingHeaders/qprinter.h: Removed.
ForwardingHeaders/qsize.h: Removed.
ForwardingHeaders/qstack.h: Removed.

4:41 PM Changeset in webkit [2481] by darin

7 edits in trunk/WebCore

fixed a couple of files accidentally checked in with KWQQ names

ForwardingHeaders/qasyncio.h: Change names.
ForwardingHeaders/qstylesheet.h: Ditto.
WebCore.pbproj/project.pbxproj: Ditto.
kwq/KWQMovie.h: Ditto.

4:21 PM Changeset in webkit [2480]

1 copy
89 deletes in branches/unlabeled-1.6.56

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.6.56'.

4:21 PM Changeset in webkit [2479] by darin

49 edits in trunk/WebCore

changed to use #if APPLE_CHANGES and #if !APPLE_CHANGES consistently

We no longer do #ifdef APPLE_CHANGES or #ifndef APPLE_CHANGES.

lots of files

4:08 PM Changeset in webkit [2478] by darin

246 edits
107 adds
19 deletes in trunk/WebCore

changed naming scheme in KWQ for files like qstring.h Now use names like KWQString.h and make a forwarding header called qstring.h.

tons of files

12:27 AM Changeset in webkit [2477] by darin

24 edits
1 add
2 deletes in trunk

WebCore:

fixed 3068404 -- eliminate all user-visible messages from WebCore

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Use runJavaScriptPrompt function instead of the more generic QInputDialog.

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::altText): Get submit alt text for input element from the view factory, rather than using i18n, since we don't support that.
khtml/html/htmlparser.cpp: (KHTMLParser::handleIsindex): Ditto, for the intro that says "This is a searchable index".
khtml/rendering/render_form.cpp: (RenderSubmitButton::defaultLabel): Ditto, for "Submit". (RenderResetButton::defaultLabel): Ditto, for "Reset". (RenderFileButton::slotClicked): Ifdef'd out this unused code that had i18n text in it.

khtml/xml/xml_tokenizer.cpp: (XMLHandler::errorString): Put in an ifdef and a FIXME to avoid i18n. (XMLHandler::fatalError): Ditto. (XMLTokenizer::finish): Ditto.

khtml/misc/decoder.cpp: (Decoder::decode): Ifdef'd the check for the first language being "ja", since that's not how we're going to trigger Japanese auto-detect.

khtml/rendering/render_applet.cpp: (RenderEmptyApplet::RenderEmptyApplet): Turned off the code that does the empty applet label. I don't think it worked, and it used i18n. We'll have to tackle this eventually.

kwq/KWQKHTMLPartImpl.h: Added runJavaScriptPrompt.
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::runJavaScriptPrompt): Moved the code here that used to be in KWQInputDialog.

kwq/kdecore/klocale.h: Remove i18n() and KLocale::languageList(), added the functions that are listed below.
kwq/KWQKLocale.mm: (inputElementAltText): Added specific function for getting one of the very few translated strings that we need in WebCore. (resetButtonDefaultLabel): Ditto. (searchableIndexIntroduction): Ditto. (submitButtonDefaultLabel): Ditto. (KLocale::language): Use the view factory to ask for the language code, since there's no public API to get it that WebCore can use.

kwq/WebCoreViewFactory.h: Add new API for above.

ForwardingHeaders/qinputdialog.h: Added empty file.

kwq/qt/qinputdialog.h: Removed.
kwq/KWQInputDialog.mm: Removed.
WebCore.pbproj/project.pbxproj: Removed QInputDialog files.

WebKit:

WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory inputElementAltText]): Added. (-[WebViewFactory resetButtonDefaultLabel]): Added. (-[WebViewFactory searchableIndexIntroduction]): Added. (-[WebViewFactory submitButtonDefaultLabel]): Added. (-[WebViewFactory defaultLanguageCode]): Added.

English.lproj/Localizable.strings: Update.
English.lproj/StringsNotToBeLocalized.txt: Update.

Oct 25, 2002:

11:43 PM Changeset in webkit [2476] by darin

18 edits
1 add
2 deletes in trunk

WebCore:

Remove some user-visible strings. We can't have any strings that need
localization in WebCore, given our translation strategy.

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::encoding): Put APPLE_CHANGES around some i18n dialog code.
khtml/khtml_part.cpp: (KHTMLPart::submitForm): Ditto.
khtml/rendering/render_frames.cpp: (RenderPartObject::slotPartLoadingErrorNotify): Ditto.
khtml/ecma/kjs_window.cpp: (Window::get): Ditto. (Window::scheduleClose): Ditto. (WindowFunc::tryCall): Put APPLE_CHANGES in to use JavaScript-specific methods in the part of calling the generic ones from KMessageBox.

ForwardingHeaders/kmessagebox.h: Added (empty file).

kwq/KWQKHTMLPartImpl.h: Added new runJavaScript functions.
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::runJavaScriptAlert): Added. (KWQKHTMLPartImpl::runJavaScriptConfirm): Added.

kwq/WebCoreViewFactory.h: Added runJavaScriptAlertPanelWithMessage and runJavaScriptConfirmPanelWithMessage.

kwq/kdeui/kmessagebox.h: Removed.
kwq/KWQKMessageBox.mm: Removed.
WebCore.pbproj/project.pbxproj: Removed the KMessageBox files.

WebKit:

WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory runJavaScriptAlertPanelWithMessage:]): Added. (-[WebViewFactory runJavaScriptConfirmPanelWithMessage:]): Added.

English.lproj/Localizable.strings: Update.
English.lproj/StringsNotToBeLocalized.txt: Update.

10:49 PM Changeset in webkit [2475] by darin

4 edits in trunk/JavaScriptCore

fixed 3038011 -- drop-down menu hierarchy broken at yahoo new acct page

kjs/array_object.cpp: (ArrayProtoFuncImp::call): Fix bug calling concat on an empty array. The old code tried to optimize in a way that would prevent appending any arrays until at least one element was in the destination array. So if you were concatenating a non-empty array into an empty array, you got an empty array.

7:14 PM Changeset in webkit [2474] by rjw

4 edits in trunk/WebCore

Removed debug logging.

khtml/rendering/font.cpp: (Font::drawText):

7:11 PM Changeset in webkit [2473] by rjw

12 edits in trunk

Implemented support for bidi text layout.

WebCoreSupport.subproj/WebTextRenderer.m: (_drawGlyphs): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]):

Implemented support for bidi text layout. WebCore
temporarily depends on SPI to get unicode character
attribute from CF. This will change shortly.

khtml/rendering/font.cpp: (Font::drawText):
kwq/KWQChar.mm: (QChar::direction):
kwq/KWQPainter.mm: (QPainter::drawText):
kwq/WebCoreTextRenderer.h:
kwq/qt/qpainter.h:

Updated to reflect change in WebKit SPI.

EtchedStringView.m: (-[EtchedStringView drawRect:]):

5:55 PM Changeset in webkit [2472] by cblu

11 edits in trunk/WebKit

Made frameNamed private in WebController and renamed it to _findFrameNamed. Got rid of _frameInThisWindowNamed in WebController because it isn't needed anymore.

WebView.subproj/WebController.h:
WebView.subproj/WebController.m: (-[WebController _goToItem:withFrameLoadType:]): call _findFrameNamed
WebView.subproj/WebControllerPrivate.h:
WebView.subproj/WebControllerPrivate.m: (-[WebController _findFrameNamed:]): renamed, made private, got rid of call to _frameInThisWindowNamed as it is not needed
WebView.subproj/WebFrame.m: (-[WebFrame findFrameNamed:]): call [WebController _findFrameNamed:]

5:27 PM Changeset in webkit [2471] by cblu

8 edits in trunk/WebKit

Fix case where we would name a new window _blank
If a data source can't be created for a plug-in request, don't create the frame or open a window.
cleaned up plug-in stream notifications

Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView initWithFrame:]): create streamNotifications dict (-[WebBaseNetscapePluginView dealloc]): release streamNotifications dict (-[WebBaseNetscapePluginView frameStateChanged:]): cleaned up (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): create data source before frame
Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): create data source before frame
WebView.subproj/WebControllerPrivate.m: (-[WebController _setTopLevelFrameName:]): don't allow _blank frames
WebView.subproj/WebFrame.m: (-[WebFrame findOrCreateFramedNamed:]): no need to check for _blank

5:06 PM Changeset in webkit [2470] by darin

3 edits in trunk/WebKit

WebKit:

Tighten up the code that observes mouse moved events.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Don't set up observers here. (-[WebHTMLView addMouseMovedObserver]): Added some assertions. (-[WebHTMLView viewWillMoveToWindow:]): Stop observing the "become main" and "resign main" notifications here. (-[WebHTMLView viewDidMoveToWindow]): Start observing them here. (-[WebHTMLView windowDidBecomeMain:]): Assert that the notification is for this window, instead of checking with if. (-[WebHTMLView windowDidResignMain:]): Assert that the notification is for this window.

WebBrowser:

fixed 3078924 -- Rollovers fail on wired.com after selecting a menu

BrowserApplication.m: (-[BrowserApplication sendEvent:]): Put in a workaround that sets the mouse focus to the key window.

BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Remove unneeded pageTitleChanged. (-[BrowserWindowController frameLoadWithinPage:]): Call updateBackAndForwardButtons instead of doing the "two calls to setActivity:" dance.

4:41 PM Changeset in webkit [2469] by cblu

20 edits in trunk

WebCore:

Cleaned up the frame searching shenanigans. Things are much cleaner and clearer now.

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): call findFrameNamed
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): call findOrCreateFramedNamed
kwq/WebCoreBridge.h:

WebKit:

Cleaned up the frame searching shenanigans. Things are much cleaner and clearer now.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): call findOrCreateFramedNamed
Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): call findOrCreateFramedNamed
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): moved (-[WebBridge mainFrame]): moved (-[WebBridge findOrCreateFramedNamed:]): call findOrCreateFramedNamed on the frame (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): call _pluginController
WebView.subproj/WebControllerPrivate.m: (-[WebController _frameInThisWindowNamed:]): call _descendantFrameNamed
WebView.subproj/WebFrame.h:
WebView.subproj/WebFrame.m: (-[WebFrame findFrameNamed:]): was frameNamed. First checks special-case frame names, descendant frames, then the whole controller, then other controllers. (-[WebFrame findOrCreateFramedNamed:]): calls findFrameNamed, opens new window if necessary
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _descendantFrameNamed:]): searches children, children's children etc. (-[WebFrame _pluginController]): this method needed an "_"
WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]): call _pluginController
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): no need to special case for "_blank" since findFrameNamed will return nil for that name

3:51 PM Changeset in webkit [2468] by trey

14 edits
2 deletes in trunk/WebKit

WebKit:

2919039 - Implement limit on back/forward history list
2998200 - access to most-recent in submenu of back & forward buttons
3022566 - need WebKit API for accessing and visiting back/forward list items
3084051 - forward button incorrectly enabled after going forward all the way

Remaining issues at this point are getting the title of the pages
into the menu items (instead of the URL), and saving document
state properly when you jump around in the list. Solutions are
known and coming soon.

History.subproj/WebBackForwardList.h: Added doc comments to API. Made ivars private. Replaced index- based API with item-based API. Added a sizelimit to the overall list. Tweaked API to get back and forward lists.
History.subproj/WebBackForwardList.m: Straightforward impl of the above, with the note that I dumped WebHistoryList from the API and impl in favor of an NSArray, which is efficient for this sort of use (queue, stack). (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToEntry:]): (-[WebBackForwardList backEntry]): (-[WebBackForwardList forwardEntry]): (-[WebBackForwardList maximumSize]): (-[WebBackForwardList setMaximumSize:]): (-[WebBackForwardList description]):
History.subproj/WebHistoryList.h: Removed. Nuked from API, per above.
History.subproj/WebHistoryList.m: Removed.
Misc.subproj/WebKit.h: WebHistoryList gone from API.
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:]): Use if/else instead of buried "return;", so next person doesn;t make the same mis-read I did. (-[WebBridge saveDocumentState:]): Site of future work.
WebKit.pbproj/project.pbxproj: Nuked WebHistoryList.
WebView.subproj/WebController.h:
WebView.subproj/WebController.m: (-[WebController goBackOrForwardToItem:]): New method to support random access nav in backforward list.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]): Site of future work (fixing title in items)
WebView.subproj/WebFramePrivate.h: WebFrameLoadTypeIndexedBack/WebFrameLoadTypeIndexedForward are collapsed into WebFrameLoadTypeIndexedBackForward. Vestigial WebFrameLoadTypeIntermediateBack is nuked.
WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate setBackForwardItem:]): (-[WebFrame _setBackForwardItem:]): (-[WebFrame _backForwardItem]): Must remember the BF item we're going to so we can update the BF list on commit. (-[WebFrame _transitionToCommitted]): Update the BF list on commit. (-[WebFrame _isLoadComplete]): (-[WebFrame _goToItem:withFrameLoadType:]): Update BF list on within-page nav. Remember BF item we are going to for later update on commit.

WebBrowser:

2919039 - Implement limit on back/forward history list
2998200 - access to most-recent in submenu of back & forward buttons
3084051 - forward button incorrectly enabled after going forward all the way

Remaining issues at this point are getting the title of the pages
into the menu items (instead of the URL), and saving document
state properly when you jump around in the list. Solutions are
known and coming soon.

BrowserDocument.h: Add BrowserDocumentClientNavigatedWithinPageNotification.
BrowserDocument.m: (-[BrowserDocument init]): Set up BackForwardListSizeLimit preference. (-[BrowserDocument canGoBack]): (-[BrowserDocument canGoForward]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]): Nits adopting new API. (-[BrowserDocument goToItem:]): (-[BrowserDocument _addItem:toMenu:]): (-[BrowserDocument backListMenuForButton:]): (-[BrowserDocument forwardListMenuForButton:]): Code to build BF menus, and respond to clicks.
BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): (-[BrowserWindowController frameLoadWithinPage:]): Register for and handle BrowserDocumentClientNavigatedWithinPageNotification. Must update title bar widgets at this point.
Defaults.plist: New defaults: BackForwardListSizeLimit, BackForwardMenuSizeLimit
LocationChangeHandler.m: (-[LocationChangeHandler locationChangedWithinPageForDataSource:]): Post BrowserDocumentClientNavigatedWithinPageNotification.
PreferenceKeys.h: New default keys.

12:51 PM Changeset in webkit [2467] by cblu

3 edits in trunk/WebKit

Minor non-mentionable clean-up.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]):

10:11 AM Changeset in webkit [2466] by cblu

5 edits in trunk/WebKit

Cleaned up the plug-in API headers so they can be sent to other groups.

Plugins.subproj/WebPlugin.h:
Plugins.subproj/WebPluginContainer.h:
Plugins.subproj/WebPluginViewFactory.h:

3:09 AM Changeset in webkit [2465] by mjs

4 edits in trunk/WebCore

fixed 3065638 - "undefined" output to screen on empty document.write()

khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): Don;t assume there is at least one argument.

2:31 AM Changeset in webkit [2464] by rjw

2 edits in trunk/WebKit

* empty log message *

2:15 AM Changeset in webkit [2463] by mjs

4 edits in trunk/WebCore

fixed 3048031 - innerHTML is incorrectly null

kwq/KWQString.mm: (QString::isNull): Check for NULL by comparing to shared_null_handle instead of checking for 0 length, so garden-variety empty strings don't show as NULL. (QString::QString): Make sure that string created with a NULL char
uses the shared null handle, so it's properly NULL.

Oct 24, 2002:

9:54 PM Changeset in webkit [2462] by rjw

9 edits in trunk

Fixed many font substitution related bugs, at least including:
3006966, 3026675, 3071106, and more... (each of these bugs
has a list of related bugs).

Needs little more cleanup to correctly deal with non base characters.

WebCoreSupport.subproj/WebTextRenderer.h:
WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

Against Darin's better judgement prevent extra layout when not in live resize. If
this introduces any regressions I owe darin a good bottle of wine.

WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):

Updated to reflect new calling parameter semantic of floatCharacterWidths(),
which now returns the entire array of widths up the last character requested.

khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint):

4:35 PM Changeset in webkit [2461] by cblu

4 edits in trunk/WebKit

New Java plug-in works! Much faster to load and no spinny cursor! Unfortunately, it very unstable.

Plugins.subproj/WebPluginController.m: cleaned-up the logging messages. (-[WebPluginController addPluginView:]): (-[WebPluginController didAddPluginView:]): (-[WebPluginController startAllPlugins]): (-[WebPluginController stopAllPlugins]): (-[WebPluginController destroyAllPlugins]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): make height and width an attribute.

4:12 PM Changeset in webkit [2460] by hyatt

4 edits in trunk/WebCore

<pre>, <xmp> and <plaintext> should all have a top margin of 1em.
Fixes a bunch of sites that use <pre>.

khtml/css/html4.css:

3:34 PM Changeset in webkit [2459] by cblu

18 edits in trunk

WebCore:

Removed didAddSubview calls because that can easily be done in WebKit. Duh!

khtml/rendering/render_frames.cpp: (RenderPart::setWidget):
kwq/KWQKHTMLPartImpl.h:
kwq/KWQKHTMLPartImpl.mm:
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
kwq/WebCoreBridge.h:

WebKit:

Some clean-up and bug fixes for new plug-in support.

Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): need a colon after windowWillClose (-[WebPluginController addPluginView:]): added logging (-[WebPluginController didAddPluginView:]): added logging (-[WebPluginController startAllPlugins]): added logging (-[WebPluginController stopAllPlugins]): added logging (-[WebPluginController destroyAllPlugins]): added logging
Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage getMIMEInformation]): use correct dict key for getting MIME descriptions
WebCoreSupport.subproj/WebBridge.m: no more didAddSubview
WebView.subproj/WebFramePrivate.h: no more didAddSubview
WebView.subproj/WebFramePrivate.m: no more didAddSubview
WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]): call didAddPluginView on WebPluginController

3:08 PM Changeset in webkit [2458] by sullivan

3 edits in trunk/WebKit

WebKit:

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]): added ASSERT(response != nil), leftover from debugging session on Tuesday, seems worth leaving in.

WebBrowser:

fixed 3083271 -- Change Show/Hide menu items in View menu to use check marks

English.lproj/MainMenu.nib: changed menu items to not include "Show" or "Hide" and to be indented by two spaces so they look like they belong to the dimmed "Show" item at the top of the menu. This is a yucky UI hack but is (A) probably better than the old huge list of items starting with "Show" or "Hide", and (B) what SJ wants.

BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): validate by updating check mark rather than changing title

1:28 PM Changeset in webkit [2457] by darin

5 edits
29 adds
26 deletes in trunk/WebCore

A step in the direction of making KWQ headers much nicer.
Move all empty headers out of kwq, and into ForwardingHeaders.

ForwardingHeaders/kcmdlineargs.h: Added.
ForwardingHeaders/kdatastream.h: Added.
ForwardingHeaders/khtml_iface.h: Added.
ForwardingHeaders/khtml_printsettings.h: Added.
ForwardingHeaders/khtml_run.h: Added.
ForwardingHeaders/kio/kprinter.h: Added.
ForwardingHeaders/kio/kprotocolmanager.h:
ForwardingHeaders/kio/ktrader.h: Added.
ForwardingHeaders/kio/scheduler.h: Added.
ForwardingHeaders/kmultipledrag.h: Added.
ForwardingHeaders/kprinter.h: Added.
ForwardingHeaders/kprotocolmanager.h: Added.
ForwardingHeaders/ksslcertchain.h: Added.
ForwardingHeaders/ksslinfodlg.h: Added.
ForwardingHeaders/kstdaction.h: Added.
ForwardingHeaders/ktempfile.h: Added.
ForwardingHeaders/ktrader.h: Added.
ForwardingHeaders/kurldrag.h: Added.
ForwardingHeaders/kxmlguifactory.h: Added.
ForwardingHeaders/qasyncimageio.h: Added.
ForwardingHeaders/qbitmap.h: Added.
ForwardingHeaders/qclipboard.h: Added.
ForwardingHeaders/qfontdatabase.h: Added.
ForwardingHeaders/qglobal.h: Added.
ForwardingHeaders/qhbox.h: Added.
ForwardingHeaders/qintcache.h: Added.
ForwardingHeaders/qintdict.h: Added.
ForwardingHeaders/qmetaobject.h: Added.
ForwardingHeaders/qobjectlist.h: Added.
ForwardingHeaders/scheduler.h: Added.

kwq/dcop/kdatastream.h: Removed.
kwq/kdecore/kcmdlineargs.h: Removed.
kwq/kdecore/kmultipledrag.h: Removed.
kwq/kdecore/ktempfile.h: Removed.
kwq/kdecore/kurldrag.h: Removed.
kwq/kdeui/kstdaction.h: Removed.
kwq/kdeui/kxmlguifactory.h: Removed.
kwq/khtml/khtml_iface.h: Removed.
kwq/khtml/khtml_printsettings.h: Removed.
kwq/khtml/khtml_run.h: Removed.
kwq/kio/kprinter.h: Removed.
kwq/kio/kprotocolmanager.h: Removed.
kwq/kio/kssl/ksslcertchain.h: Removed.
kwq/kio/kssl/ksslinfodlg.h: Removed.
kwq/kio/ktrader.h: Removed.
kwq/kio/scheduler.h: Removed.
kwq/qt/qasyncimageio.h: Removed.
kwq/qt/qbitmap.h: Removed.
kwq/qt/qclipboard.h: Removed.
kwq/qt/qfontdatabase.h: Removed.
kwq/qt/qglobal.h: Removed.
kwq/qt/qhbox.h: Removed.
kwq/qt/qintcache.h: Removed.
kwq/qt/qintdict.h: Removed.
kwq/qt/qmetaobject.h: Removed.
kwq/qt/qobjectlist.h: Removed.

WebCore.pbproj/project.pbxproj: Removed all the above headers from the project.

12:47 PM Changeset in webkit [2456] by darin

3 edits in trunk/WebKit

WebFoundation:

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebKit:

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

WebBrowser.pbproj/project.pbxproj: Move the new pltsuite into the Test group.

12:23 PM Changeset in webkit [2455] by darin

4 edits
1 delete in trunk/WebCore

ForwardingHeaders/private/qucomextra_p.h: Emptied this out.
kwq/qt/private/qucomextra_p.h: Removed.

12:15 PM Changeset in webkit [2454] by hyatt

4 edits in trunk/WebCore

Make sure that KHTML's initial layout happens after KHTML
fires the onload. This means that in the case where we
beat the timer, we will now fire the onload before both
the initial layout and the initial paint.

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):

11:35 AM Changeset in webkit [2453] by cblu

5 edits in trunk/WebKit

WebKit:

Changed some method names in WebPluginController.

Plugins.subproj/WebPluginController.h:
Plugins.subproj/WebPluginController.m: (-[WebPluginController didAddPluginView:]): (-[WebPluginController startAllPlugins]): (-[WebPluginController stopAllPlugins]): (-[WebPluginController destroyAllPlugins]): (-[WebPluginController windowWillClose:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _didAddSubview:]):

WebBrowser:

Fixed: 2961256 - vend an open URL service

AppController.m: (-[AppController applicationDidFinishLaunching:]): register the services
ServicesProvider.h: Added.
ServicesProvider.m: Added. (-[ServicesProvider openURL:userData:error:]): the service
WebBrowser.pbproj/project.pbxproj:

10:04 AM Changeset in webkit [2452]

3 copies in tags/Alexander-29

This commit was manufactured by cvs2svn to create tag 'Alexander-29'.

10:04 AM Changeset in webkit [2451] by sheridan

8 edits in trunk

Alex-29 version stamp

9:28 AM Changeset in webkit [2450] by rjw

4 edits in trunk/WebKit

Don't leak request.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):

9:18 AM Changeset in webkit [2449] by rjw

5 edits in trunk/WebKit

Always copy request, we can't count on it being immutable.
This was the cause of the ASSERT from last night's checkin.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):

Only send serverRedirectedForDataSource: if URL changed.

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]):

8:38 AM Changeset in webkit [2448] by cblu

17 edits in trunk

WebCore:

Use "MIMEType" instead of "serviceType".

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart):
kwq/WebCoreBridge.h:

WebKit:

Use "MIMEType" instead of "serviceType".

Plugins.subproj/WebBasePluginPackage.h:
Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage setPath:]):
Plugins.subproj/WebNetscapePluginEmbeddedView.h:
Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributes:]):
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage getMIMEInformation]): changed name. (-[WebNetscapePluginPackage initWithPath:]):
Plugins.subproj/WebNullPluginView.h:
Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView initWithFrame:MIMEType:attributes:]): (-[WebNullPluginView dealloc]): (-[WebNullPluginView viewDidMoveToWindow]): send missing plug-ins notification here
Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage getMIMEInformation]): new, gets MIME info from plist (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage dealloc]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]): (-[WebPluginPackage unload]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):

2:02 AM Changeset in webkit [2447] by rjw

3 edits in trunk/WebKit

Flag error instead of ASSERTing as a result of fix to 3083013.
Not clear why this condition occurs, but better than ASSERTing
for Alex 29.

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]):

12:35 AM Changeset in webkit [2446] by darin

5 edits in trunk/WebCore

kwq/KWQKLocale.mm: (i18n): Make it obvious when non-localized strings from WebCore show up in the UI, but putting the string "not localized: " in front.

kwq/KWQKMessageBox.mm: (KMessageBox::error): Fix use of NSRunAlertPanel so that we won't accidentally try to interpret % sequences in the messages we are displaying. (KMessageBox::warningYesNo): Ditto. (KMessageBox::questionYesNo): Ditto. (KMessageBox::sorry): Ditto. (KMessageBox::information): Ditto.

12:20 AM Changeset in webkit [2445] by darin

7 edits in trunk/WebKit

fixed a crash I ran into in the new delegate code

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _releaseResources]): Retain self across this deallocation to avoid reentering and being deallocated midstream. This happens because the handle holds the only reference to us, and we may be releasing the last reference to it. (-[WebBaseResourceHandleDelegate dealloc]): Add call to [super dealloc].

Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Add call to [super dealloc].

WebView.subproj/WebMainResourceClient.m: Tweak.

Oct 23, 2002:

11:50 PM Changeset in webkit [2444] by darin

4 edits in trunk/WebKit

fixed 3083013 -- REGRESSION: Cookie refused at http://directory/ even on reload

Restore a bit of the cruft.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): We need to change the request on the data source when a redirect happens, because the data source goes on to ultimately communicate this to WebCore. Restored the code that did that, with some changes to fit into the new regime.

10:16 PM Changeset in webkit [2443] by rjw

30 edits in trunk/WebKit

Cleaned up months of accumulated cruft.
Added base class to the three WebResourceHandleDelegate implementors.
Removed superfluous handle references to controller callbacks.
More can still be done.
All in the name of fixing 3076050.

Misc.subproj/WebKitErrors.h:
Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]):
Plugins.subproj/WebNetscapePluginStream.h:
Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream stop]): (-[WebNetscapePluginStream handle:willSendRequest:]): (-[WebNetscapePluginStream handle:didReceiveResponse:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]):
WebCoreSupport.subproj/WebSubresourceClient.h:
WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient initWithLoader:dataSource:]): (-[WebSubresourceClient dealloc]): (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient handle:willSendRequest:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]): (-[WebSubresourceClient cancel]):
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate init]): (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate dealloc]): (-[WebBaseResourceHandleDelegate setDataSource:]): (-[WebBaseResourceHandleDelegate dataSource]): (-[WebBaseResourceHandleDelegate resourceLoadDelegate]): (-[WebBaseResourceHandleDelegate downloadDelegate]): (-[WebBaseResourceHandleDelegate setIsDownload:]): (-[WebBaseResourceHandleDelegate isDownload]): (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): (-[WebBaseResourceHandleDelegate handle:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate handle:didReceiveData:]): (-[WebBaseResourceHandleDelegate handleDidFinishLoading:]): (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancel]): (-[WebBaseResourceHandleDelegate handle]):
WebView.subproj/WebControllerPrivate.h:
WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedBytesSoFar:fromDataSource:complete:]): (-[WebController _receivedError:fromDataSource:]): (-[WebController _mainReceivedError:fromDataSource:]):
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSource.m:
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _startLoading]): (-[WebDataSource _stopLoading]): (-[WebDataSource _clearErrors]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]):
WebView.subproj/WebMainResourceClient.h:
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient cancel]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient _notifyDelegatesOfInterruptionByPolicyChange]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):
WebView.subproj/WebResourceLoadDelegate.h:

6:30 PM Changeset in webkit [2442] by cblu

13 edits in trunk

WebCore:

WebKit now gets called when render_frame subviews are added.

khtml/rendering/render_frames.cpp: (RenderPart::setWidget): call didAddWidget on the part
kwq/KWQKHTMLPartImpl.h:
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::didAddWidget): added, calls didAddSubview on the bridge

WebKit:

Support for new plug-in API. This is about as much as I can do without the new java plug-in and java root.

Plugins.subproj/WebPluginController.h:
Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): observe window close changes (-[WebPluginController dealloc]): remove observer, assert if we're still tracking plug-ins (-[WebPluginController didAddSubview:]): start the plug-in (-[WebPluginController stopAllPlugins]): stop and destroy all plug-ins. (-[WebPluginController windowWillClose:]): call stopAllPlugins if the window in question is closing
WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): call stopAllPlugins on WebPluginController

5:44 PM Changeset in webkit [2441] by cblu

19 edits in trunk

WebCore:

Change for plug-in package API changes.

kwq/KWQKConfigBase.mm: (KConfig::readEntry):
kwq/WebCoreBridge.h: added didAddSubview, called when a render_frame's view is added as a subview of the main view.
kwq/WebCoreViewFactory.h: added didAddSubview

WebKit:

Changed the plug-in package API to return key enumerators instead dictionaries.

Plugins.subproj/WebBasePluginPackage.h:
Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage unload]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage extensionEnumerator]): (-[WebBasePluginPackage MIMETypeEnumerator]): (-[WebBasePluginPackage descriptionForMIMEType:]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage extensionsForMIMEType:]): (-[WebBasePluginPackage setName:]): (-[WebBasePluginPackage setPath:]): (-[WebBasePluginPackage setFilename:]): (-[WebBasePluginPackage setPluginDescription:]): (-[WebBasePluginPackage setMIMEToDescriptionDictionary:]): (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
Plugins.subproj/WebNetscapePluginPackage.h:
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage getPluginInfo]): (-[WebNetscapePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage executableType]):
Plugins.subproj/WebPluginController.h:
Plugins.subproj/WebPluginController.m: (-[WebPluginController didAddSubview:]):
Plugins.subproj/WebPluginDatabase.h:
Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase MIMETypes]): (-[WebPluginDatabase init]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:serviceType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): (-[WebBridge didAddSubview:]): new
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _didAddSubview:]): new

4:17 PM Changeset in webkit [2440] by darin

16 edits in trunk

WebFoundation:

English.lproj/StringsNotToBeLocalized.txt:

WebCore:

finished up the job of moving the file button to WebKit

I did this mainly for localization reasons.

kwq/KWQFileButton.h: Remove filename(), add filenameChanged(), make KWQFileButton be a QWidget subclass, not a QPushButton one. Remove clicked() and paint() virtual functions, _filename, _icon, and _label data members.
kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Just make a WebCoreFileButton. (KWQFileButton::~KWQFileButton): Less to do here now. (KWQFileButton::setFilename): Call the button to do the work. (KWQFileButton::sizeHint): Ditto. (KWQFileButton::frameGeometry): Ditto. (KWQFileButton::setFrameGeometry): Ditto. (KWQFileButton::baselinePosition): Ditto. (KWQFileButton::filenameChanged): Added. Sends message. (-[KWQFileButtonAdapter initWithKWQFileButton:]): Observe the "filename changed notification". (-[KWQFileButtonAdapter dealloc]): Stop observing. (-[KWQFileButtonAdapter filenameChanged:]): Send a signal when the notification comes in, so KHTML finds out.

kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Remove handling for RenderFileButton slotReturnPressed. (KWQSlot::call): Ditto.

kwq/WebCoreViewFactory.h: Remove bestSize. Add setVisualFrame, visualFrame, and bestVisualFrameSize.

kwq/KWQInputDialog.mm: Tweaked includes. Long-term we want to use "", not <>.
kwq/KWQKConfigBase.mm: Ditto.
kwq/KWQKHTMLPartImpl.mm: Ditto.

WebKit:

finished up the job of moving the file button here from WebCore.

I did this mainly for localization reasons.

WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton initWithFrame:]): Set up button control size, font, bezel style, target, and action. Also add it as a subview. (-[WebFileButton drawRect:]): Center icon in the "visual frame" part of the view, not the entire bounds. (-[WebFileButton setFilename:]): Don't show any icon when the filename is empty. (-[WebFileButton bestVisualFrameSize]): Implemented this. (-[WebFileButton visualFrame]): Ditto. (-[WebFileButton setVisualFrame:]): Ditto. (-[WebFileButton baseline]): Ditto. (-[WebFileButton beginSheet]): Added. Shared between button presses and other clicks. (-[WebFileButton chooseButtonPressed:]): Call beginSheet. (-[WebFileButton mouseDown:]): Ditto. (-[WebFileButton openPanelDidEnd:returnCode:contextInfo:]): Send the notification, WebCoreFileButtonFilenameChanged, when the filename is changed.

WebView.subproj/WebController.m: (-[WebController policyDelegate]): Add a FIXME about the leak I found here.

1:49 PM Changeset in webkit [2439] by cblu

20 edits in trunk

WebCore:

Call the arguments for plug-ins "attributes" everywhere.

kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart):
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
kwq/WebCoreBridge.h:

WebKit:

Call the arguments for plug-ins "attributes" everywhere.

Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setAttributes:]):
Plugins.subproj/WebNetscapePluginEmbeddedView.h:
Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:attributes:]):
Plugins.subproj/WebNullPluginView.h:
Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView initWithFrame:mimeType:attributes:]): (-[WebNullPluginView drawRect:]):
Plugins.subproj/WebPluginController.h:
Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): (-[WebPluginController dealloc]): (-[WebPluginController addPluginView:]):
Plugins.subproj/WebPluginPackage.h:
Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage viewFactory]):
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): (-[WebBridge viewForPluginWithURL:attributes:baseURL:serviceType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):

11:52 AM Changeset in webkit [2438] by cblu

17 edits in trunk

WebCore:

For the new plug-in API, we need to pass a WebPluginContainer to the plug-in view upon creation. The is owned by the WebFrame. To make this all work, I had to move the WebCore plug-in and java view constructors to WebBridge from WebViewFactory since WebBridge has the frame.

khtml/khtml_part.cpp: (KHTMLPart::createJavaContext): New APPLE_CHANGES around the java context constructor so we pass the part.
kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart): call the bridge to create the view
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): save the context (KJavaAppletWidget::showApplet): call the bridge to create the view
kwq/WebCoreBridge.h:
kwq/WebCoreViewFactory.h:
kwq/khtml/java/kjavaappletcontext.h: made constructor take the part
kwq/khtml/java/kjavaappletwidget.h: ivar for the context

WebKit:

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURL]): (-[WebBridge viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebBridge viewForJavaAppletWithFrame:baseURL:parameters:]):
WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory fileButton]): (-[WebViewFactory pluginsInfo]):

10:49 AM Changeset in webkit [2437] by darin

6 edits in trunk/WebKit

fix bug where plugins crashed closing a stream that was never opened

Plugins.subproj/WebBaseNetscapePluginStream.h: Change type for parameter of receivedError: to NPReason. It's not NPError.
Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): Assert that stream is destroyed by checking stream.ndata. (-[WebBaseNetscapePluginStream setResponse:]): Set stream.ndata to nil if the stream is not successfully created by NPP_NewStream. (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): Added. Destroys the stream, but only if it's present. Also set stream.ndata to nil. This was the bug fix. (-[WebBaseNetscapePluginStream receivedError:]): Call destroyStreamWithReason:. (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Call destroyStreamWithReason:.

English.lproj/Localizable.strings: Update.
English.lproj/StringsNotToBeLocalized.txt: Update.

10:38 AM Changeset in webkit [2436] by cblu

3 edits in trunk/WebKit

Forgot to add WebPluginController back to the project after I had a project conflict.

WebKit.pbproj/project.pbxproj:

10:27 AM Changeset in webkit [2435] by cblu

4 edits
2 adds in trunk/WebKit

Added WebPluginController which controls and reacts to plug-in requests. Its owned by the WebFrame.

Plugins.subproj/WebPluginController.h: Added.
Plugins.subproj/WebPluginController.m: Added. (-[WebPluginController initWithWebFrame:]): (-[WebPluginController showURL:inFrame:]): (-[WebPluginController showStatus:]):
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): (-[WebFrame pluginController]):

9:57 AM Changeset in webkit [2434] by darin

19 edits
2 adds in trunk

WebCore:

fixed 3080478 -- reproducible incomplete load on apple.com

kwq/KWQLoaderImpl.mm: (-[WebCoreResourceLoader receivedResponse:]): Add an assert. (-[WebCoreResourceLoader cancel]): Don't finish here, just disconnect the handle from the job, and disconnect the job from the WebCoreResourceLoader, and let the KHTML code finish the cleanup later. This is the bug fix. (KWQCheckCacheObjectStatus): Add an assertion.

kwq/KWQKjobclasses.mm: (TransferJob::~TransferJob): Don't call kill(); do the work here instead. (TransferJob::kill): Self-destruct. Need this to avoid a storage leak.

khtml/misc/loader.cpp: (CachedObject::~CachedObject): Put some Apple-specific code inside APPLE_CHANGES. (CachedObject::setResponse): Streamlined this function. (Loader::receivedResponse): Added assertions.

kwq/qt/qxml.h: Add more stubs.
kwq/KWQxml.mm: Ditto.

kwq/WebCoreViewFactory.h: Add [WebCoreViewFactory fileButton], the WebCoreFileButton protocol, and WebCoreFileButtonFilenameChanged.
kwq/WebCoreViewFactory.m: Add WebCoreFileButtonFilenameChanged.
WebCore.exp: Export _WebCoreFileButtonFilenameChanged.

WebKit:

Add WebFileButton, to be used by WebCore soon. It's about 1/2
done right now. Compiles but not used yet.

WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory fileButton]): Added.

WebCoreSupport.subproj/WebFileButton.h: Added.
WebCoreSupport.subproj/WebFileButton.m: Added.
WebKit.pbproj/project.pbxproj: Added WebFileButton files.

WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveResponse:]): Add an assertion.

5:40 AM Changeset in webkit [2433] by mjs

5 edits in trunk/WebKit

fixed 2876448 - The authentication panel should give a note when the user tried to log in and failed

Also, made the message different (and more helpful) when the
authentication is for a proxy server.

Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Use different messages depending on proxy and previous failure count.

Updated localized strings:

English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt:

2:29 AM Changeset in webkit [2432] by mjs

7 edits in trunk/WebKit

fixed 2876446 - The label in the authentication panel needs to adjust its height depending on content

Also improved [NSControl sizeToFitAndAdjustWindowHeight] method.

Panels.subproj/English.lproj/WebAuthenticationPanel.nib: Adjusted springs.
Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Use sizeToFitAndAdjustWindowHeight on main label.

Misc.subproj/WebNSControlExtras.m: (-[NSControl sizeToFitAndAdjustWindowHeight]): Improved the logic so the best height is picked while leaving the width alone. Before, the label would always come out to be a very wide single line.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed