Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 5, 2002:

8:00 PM Changeset in webkit [2573] by mjs

• 10 edits in trunk/WebKit

WebKit:

Reworked clickPolicy arguments to be closer to proposed version.

• WebKit.exp:
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebControllerPolicyDelegate.m:
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:]): (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

WebBrowser:

Adjusted for WebKit API changes.

• BrowserWebController.m: (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):

5:59 PM Changeset in webkit [2572] by darin

• 3 edits in trunk/WebKit

• WebCoreSupport.subproj/WebTextRenderer.m: Made a slightly simpler and faster version of the new "lose precision" CEIL_TO_INT macro.

5:56 PM Changeset in webkit [2571] by darin

• 4 edits in trunk/WebCore

• fixed 3092722 -- assertion failed

• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader reportError]): Removed the assertion. It wasn't needed.

5:47 PM Changeset in webkit [2570] by rjw

• 3 edits in trunk/WebKit

Fixed a couple of issues that Dave highlighted w/ his whitespace
fixes. CG sometimes introduces very small 'error' in metrics, specifically
we saw character widths of 20.0000019 that should have been 20. As a
work-around we loose precision beyond the 1000th place. Also, always
ceil spaces.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

5:25 PM Changeset in webkit [2569] by darin

• 3 edits in trunk/WebKit

• fixed 3084704 -- crash in HTMLTokenizer on page with JavaScript HTMLDocument::Close inside a <script>

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): We need to stop loading here. Otherwise we might do loading after closeURL, which could lead to a problem like the one above.

5:21 PM Changeset in webkit [2568] by darin

• 4 edits in trunk/WebKit

• changed our MacBinary decoding to not pay any attention to the comment

Before we would "fail to decode" if the comment was truncated, now we just
don't worry about it.

• Downloads.subproj/WebMacBinaryDecoder.h: Remove _commentLength and _commentEnd.
• Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Remove code to get _commentLength and code to compute _commentEnd. (-[WebMacBinaryDecoder finishDecoding]): Check offset against the resource fork end rather than the comment end to see if we got enough data.

5:19 PM Changeset in webkit [2567] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• Resources/url_icon.tiff: reverted generic URL icon back to the one that looks like a document until we get something from HI that SJ likes

WebBrowser:

• Resources/Images/FavoritesBar.tif:
• Resources/Images/tiny_menu.tiff: reverted Bookmarks menu and Bookmarks toolbar icons back to the previous versions until we get something from HI that SJ likes

4:27 PM Changeset in webkit [2566] by cblu

• 12 edits in trunk/WebKit

WebKit:

Fixed: 3074108 - Decode macbinary files during download

• Downloads.subproj/WebDownloadDecoder.h:
• Downloads.subproj/WebDownloadHandler.h:
• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]): (-[WebDownloadHandler dealloc]): (-[WebDownloadHandler decodeHeaderData:dataForkData:resourceForkData:]): (-[WebDownloadHandler decodeData:dataForkData:resourceForkData:]): (-[WebDownloadHandler closeFile]): (-[WebDownloadHandler cleanUpAfterFailure]): (-[WebDownloadHandler createFileIfNecessary]): (-[WebDownloadHandler writeData:toFork:]): (-[WebDownloadHandler writeDataForkData:resourceForkData:]): (-[WebDownloadHandler dataIfDoneBufferingData:]): (-[WebDownloadHandler receivedData:]): (-[WebDownloadHandler finishDecoding]): (-[WebDownloadHandler finishedLoading]): (-[WebDownloadHandler cancel]):
• Downloads.subproj/WebMacBinaryDecoder.h:
• Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[WebMacBinaryDecoder fileAttributes]): (-[WebMacBinaryDecoder filename]):
• Misc.subproj/WebKitErrors.h: added new errors
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): don't send response to download handler (-[WebMainResourceClient handle:didReceiveData:]): watch for decoding errors

WebBrowser:

Fixed: 3074108 - Decode macbinary files during download

• DownloadMonitor.m: (-[DownloadMonitor identifierForInitialRequest:fromDataSource:]): (-[DownloadMonitor resource:willSendRequest:fromDataSource:]): (-[DownloadMonitor resource:didReceiveResponse:fromDataSource:]):
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): new, convenience (+[DownloadProgressEntry entryWithDataSource:]): (-[DownloadProgressEntry filename]): (-[DownloadProgressEntry path]): (-[DownloadProgressEntry setCompleted]):
• DownloadRow.m: (-[DownloadRow _updateStatusFields]):

11:35 AM Changeset in webkit [2565] by kocienda

• 3 edits in trunk/WebKit

Fix for this bug:

Radar 3092747 (javascript cookieEnabled property returns incorrect value)

Now, we return "true" for navigator.cookieEnabled when
"Only accept cookies from the same domain as the current page" option
is selected is user preferences.

• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled])

10:51 AM Changeset in webkit [2564] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• fixed 3091271 -- missing plug-in icon is on white background, not transparent.

• Resources/nullplugin.tiff: Photoshopped the white away. It's still ugly, but that's a separate bug (3091274)

WebBrowser:

Removed the text from the lock icon. Also cleaned up the
code that positions the lock icon in the window.

• BrowserWindow.m: (-[BrowserWindow adjustRightSideImageViewFrame]): new method, sets the image view's frame based on the image size and specified margins (-[BrowserWindow setUpRightSideImageView]): now calls adjustRightSideImageViewFrame (-[BrowserWindow setTitleBarRightSideImage:]): now calls adjustRightSideImageViewFrame if image has changed

• Resources/Images/Lock.tif: textless version

9:27 AM Changeset in webkit [2563] by darin

• 9 edits in trunk/WebCore

• re-fixed 3070484 -- icon rollovers are very slow on Mac OS X website

Had to roll back some of the files I changed yesterday. I had missed the
one line of useful code among much stuff we don't need.

• khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::slotLoaderRequestStarted): (KHTMLPart::slotLoaderRequestDone):
• kwq/KWQSignal.h:
• kwq/KWQSignal.mm: (KWQSignal::call):
• kwq/KWQSignalStubs.mm: (Loader::requestDone): (Loader::requestFailed): (Loader::requestStarted):
• kwq/KWQSlot.h:
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call): Just roll back all the changes from my 3091714 check-in below, except for the bug fix itself in loader.cpp and KWQResourceLoader.mm.

9:08 AM Changeset in webkit [2562] by kocienda

• 3 edits in trunk/WebKit/Misc.subproj

The -(NSEnumeration *)keys method has never been implemented, and is unneeded.
Removing from API. This has no external impact as this class
is entirely private to WebFoundation.

• Database.subproj/WebDatabase.h:
• Database.subproj/WebDatabase.m:
• Database.subproj/WebFileDatabase.m:

3:20 AM Changeset in webkit [2561] by mjs

• 3 edits in trunk/WebKit

• fixed 3083732 - SJ: window comes out blank on samsung site

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Don't start loading if the URL is exactly the same as the parent URL. We may need a more stringent check, but this seems to match the tolerance of other browsers OK.

2:26 AM Changeset in webkit [2560] by mjs

• 6 edits in trunk/WebCore

• fixed 3027404 - pop-up ads not always suppressed

• khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::isWindowOpenAllowed): Don't allow opening if we are in a timer callback - for reasons unexplained this will always show up as an inline script.
• khtml/ecma/kjs_binding.h:
• khtml/ecma/kjs_window.cpp: (ScheduledAction::execute): Note that we're in a timer callback.

1:31 AM Changeset in webkit [2559] by mjs

• 7 edits in trunk/WebKit

WebKit:

Added request and frame to click policy callback.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForElement:button:modifierFlags:request:inFrame:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):

WebBrowser:

• fixed 3044620 - incorrect URL sent to the click policy handler, other problems, because it's processed early

• BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierFlags:request:inFrame:]): Look at request URL, not element URL.

Nov 4, 2002:

6:00 PM Changeset in webkit [2558] by rjw

• 12 edits in trunk

i Changes to support cursive letter forms. It works, but I've

disabled it for now. It's buggy and needs cleanup.
Arabic now renders correctly except for ligature substitution.

• Misc.subproj/WebUnicode.h:
• Misc.subproj/WebUnicode.m: (_unicodeIsMark): (getShape): (prevChar): (nextChar): (prevLogicalCharJoins): (nextLogicalCharJoins): (glyphVariantLogical): (shapedString):
• Misc.subproj/WebUnicodeTables.m:
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):
• WebKitPrefix.h:

Changes to support cursive letter forms.

• kwq/KWQChar.mm:
• kwq/WebCoreUnicode.h:

Updated to lastest API.

• SimpleViewer/DocumentController.m: (-[ResourceLoadDelegate initWithDocumentController:]): (-[ResourceLoadDelegate updateStatus]): (-[ResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]):

5:25 PM Changeset in webkit [2557] by darin

• 11 edits in trunk/WebCore

• fixed 3091714 -- reproducible assert cachedObject->response in KWQCheckCacheObjectStatus

• khtml/misc/loader.cpp: (Loader::slotFinished): For APPLE_CHANGES, don't finish the load if it's an error.

• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle]): Shared code for the three following methods. (-[KWQResourceLoader cancel]): Use setError(1) again instead of just keeping the load around forever. (-[KWQResourceLoader reportError]): Ditto. (-[KWQResourceLoader finish]): Use finishJobAndHandle to share code with the two above.

• khtml/khtml_part.cpp: (KHTMLPart::init): Put the slotLoaderRequestStarted and slotLoaderRequestDone connect lines inside ifdefs. (KHTMLPart::~KHTMLPart): Same for disconnect.

• kwq/KWQSignal.h: Remove code for the DocLoader signals.
• kwq/KWQSignal.mm: (KWQSignal::call): Ditto.
• kwq/KWQSignalStubs.mm: (Loader::requestDone): Ditto. (Loader::requestFailed): Ditto. (Loader::requestStarted): Ditto.
• kwq/KWQSlot.h: Ditto.
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Ditto. (KWQSlot::call): Ditto.

5:10 PM Changeset in webkit [2556] by mjs

• 7 edits in trunk/WebCore

Changes to send NSEvents all the way through WebCore and then pass
them back out to WebKit, so that click policy can have a
WebResourceRequest added.

• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::openURL): (KWQKHTMLPart::openURLRequest): (KWQKHTMLPart::urlSelected): (KWQKHTMLPart::submitForm): (KWQKHTMLPart::createDummyDocument): (KWQKHTMLPart::setCurrentEvent):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]):

5:02 PM Changeset in webkit [2555] by mjs

• 8 edits in trunk/WebKit

Changes to send NSEvents all the way through WebCore and then pass
them back out to WebKit, so that click policy can have a
WebResourceRequest added.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:triggeringEvent:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseUp:]):
• WebView.subproj/WebHTMLViewPrivate.h:
• WebView.subproj/WebHTMLViewPrivate.m:

4:04 PM Changeset in webkit [2554] by cblu

• 3 edits in trunk/WebKit

Fixed - 3091658: REGRESSION: cmd-left for back doesn't work in plain-text viewer

We now pass text field key events to the next responder which would be WebView in this case.

• WebView.subproj/WebTextView.m: (-[WebTextView keyDown:]): (-[WebTextView keyUp:]):

3:08 PM Changeset in webkit [2553] by darin

• 15 edits in trunk/WebKit

• fixed 3090257 -- "leak the world" using the Wallace and Gromit "console"

• Plugins.subproj/WebNetscapePluginStream.m: Update for changes to the base delegate. (-[WebNetscapePluginStream start]): Use loadWithRequest:. (-[WebNetscapePluginStream stop]): Call cancel instead of just canceling the handle directly. This fixes the world leak. (-[WebNetscapePluginStream cancel]): Do some of the work that was formerly in "stop".

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Call the "stop loading URL" whenever we cancel I/O, so we don't leak the world. (-[WebMainResourceClient handle:didReceiveResponse:]): Ditto.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handleDidFinishLoading:]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _finishedLoadingResourceFromDataSource:]): Fix a typo in the word "finished".

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): Tweak. (-[WebBaseResourceHandleDelegate cancel]): Tweak.

• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels didStartLoadingURL:inWindow:]): Add assertions. (-[WebStandardPanels didStopLoadingURL:inWindow:]): Ditto. (-[WebStandardPanels _didStartLoadingURL:inController:]): Ditto. (-[WebStandardPanels _didStopLoadingURL:inController:]): Ditto.

2:52 PM Changeset in webkit [2552] by mhay

• 1 edit in trunk/WebKit/Plugins.subproj/WebPluginDatabase.m

Modified pluginForKey:withEnumeratorSelector: such that we now
enumerate all plugins that match the given key before we return
a plugin. This fixes a bug in which we would sometimes return
the wrong plugin (according to our preferences) because we did
not examine all of the available plugins before making our choice.

With this change, Alexander now behaves correctly when we have
multiple Java plugins in the plugins folder (as we will on user
systems in the field).

10:58 AM Changeset in webkit [2551] by darin

• 6 edits in trunk/WebKit

• Downloads.subproj/WebMacBinaryDecoder.h: Removed many unneeded fields.
• Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added comments. Changed maximum filename length to 63 as the format supports, rather than the 31 that's based on historical HFS limitations. Fix endian dependency in CRC check. (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Simplified this, and removed the state machine and the accumulator. Also added some asserts. Fixed endian dependency in the code to extract the header. (-[WebMacBinaryDecoder finishDecoding]): New simpler check now that we don't have a _streamComplete boolean. (-[WebMacBinaryDecoder fileAttributes]): Rewrote to take advantage of the above changes, and also to use kCFAbsoluteTimeIntervalSince1904 rather than parsing a date string.

• Downloads.subproj/crc16.h: Tweaks.
• Downloads.subproj/crc16.m: Tweaks.

10:27 AM Changeset in webkit [2550] by darin

• 3 edits in trunk/WebKit

WebKit:

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer dealloc]): Replaced a useless call to stopAnimation with a couple of asserts.

WebBrowser:

• DownloadRow.m: (-[DownloadRow dealloc]): Replaced a useless timer invalidate with an assert.

8:30 AM Changeset in webkit [2549] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• Resources/url_icon.tiff: new "generic URL" icon from HI -- this one looks like a red ribbon (!)

WebBrowser:

new images from Steve Lemay

• Resources/Images/MultipleBookmarks.tif: Added. This one will be used when dragging multiple bookmarks, but isn't yet.

• Resources/Images/AddLink.tif:
• Resources/Images/AddLinkDisabled.tif:
• Resources/Images/AddLinkPressed.tif:
• Resources/Images/Back.tif:
• Resources/Images/BackDisabled.tif:
• Resources/Images/BackPressed.tif:
• Resources/Images/FavoritesBar.tif:
• Resources/Images/FavoritesFolderArrow.tif:
• Resources/Images/FontBigger.tif:
• Resources/Images/FontBiggerDisabled.tif:
• Resources/Images/FontBiggerPressed.tif:
• Resources/Images/FontSmaller.tif:
• Resources/Images/FontSmallerDisabled.tif:
• Resources/Images/FontSmallerPressed.tif:
• Resources/Images/Forward.tif:
• Resources/Images/ForwardDisabled.tif:
• Resources/Images/ForwardPressed.tif:
• Resources/Images/NewFolder.tif:
• Resources/Images/NewFolder_Pressed.tif:
• Resources/Images/Reload.tif:
• Resources/Images/ReloadDisabled.tif:
• Resources/Images/ReloadPressed.tif:
• Resources/Images/Stop.tif:
• Resources/Images/StopDisabled.tif:
• Resources/Images/StopPressed.tif:
• Resources/Images/tiny_menu.tiff: new versions of these existing images

• English.lproj/Browser.nib: resized New Folder buttons

• WebBrowser.pbproj/project.pbxproj: updated for new file

8:24 AM Changeset in webkit [2548] by mhay

• 1 edit in trunk/WebKit/Plugins.subproj/WebPluginController.m

(1) Modified destroyAllPlugins to remove the plugin's view from the browser's view hierarchy prior to calling the plugins' pluginDestroy methods.
(2) Modified showURL:inFrame: such that arg 'target' may be 'nil'.

Nov 3, 2002:

11:49 PM Changeset in webkit [2547] by darin

• 4 edits in trunk/WebKit

WebKit:

• Plugins.subproj/WebPluginError.h:
• Plugins.subproj/WebPluginError.m: Not MyCompanyName, but rather Apple Computer.

WebBrowser:

• DownloadProgressEntry.m:
• DownloadRow.h:
• DownloadRow.m:
• DownloadViewController.h:
• DownloadViewController.m:
• DownloadWindowController.h:
• DownloadWindowController.m:
• ServicesProvider.h:
• ServicesProvider.m: Not MyCompanyName, but rather Apple Computer.

11:05 PM Changeset in webkit [2546] by darin

• 5 edits in trunk/WebKit

WebFoundation:

• AuthenticationManager.subproj/WebKeychainCredential.m: (-[WebKeychainCredentialPrivate dealloc]): Check for NULL before calling CFRelease, since our dealloc function can be called even before our init function runs if a base class decides to do the "[self release]; return nil;" thing in its init function.

• CookieManager.subproj/WebCookieStorageServer.m: (-[WebCookieStorageServerPrivate dealloc]): Remove call to invalidate, since, as Trey reminded us, it's pointless to invalidate a timer that retains us in our dealloc function.

WebKit:

• Plugins.subproj/WebPlugin.h: Fix comment.

• Plugins.subproj/WebPluginError.m: (-[WebPluginErrorPrivate dealloc]): Fix leak by calling [super dealloc].

• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Remove the timer invalidate since, as Trey pointed out, it's pointless to invalidate a timer in dealloc if it's retaining this object while valid.

WebBrowser:

• DiskCopyPuppetStrings.h: Remove bogus Log section. Fix header guard that was broken.

• DownloadRow.m: (-[DownloadRow dealloc]): Fix leak by calling [super dealloc].
• DownloadViewController.m: (-[DownloadViewController dealloc]): Ditto.

1:18 PM Changeset in webkit [2545] by cblu

• 4 edits
  4 adds in trunk/WebKit

WebKit:

• Added MacBinary decoding code. Not yet used.

• Downloads.subproj/WebMacBinaryDecoder.h: Added.
• Downloads.subproj/WebMacBinaryDecoder.m: Added. (+[WebMacBinaryDecoder canDecodeHeaderData:]): (-[WebMacBinaryDecoder init]): (-[WebMacBinaryDecoder dealloc]): (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[WebMacBinaryDecoder finishDecoding]): (-[WebMacBinaryDecoder fileAttributes]):
• Downloads.subproj/crc16.h: Added.
• Downloads.subproj/crc16.m: Added. (CRC16):
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage isLoaded]):
• WebKit.pbproj/project.pbxproj:

WebBrowser:

• Added DiskCopy interaction code. Not yet used.
• Added Chuck's table view hacks to get NSViews in a TableView. Not yet used.

• DiskCopyPuppetStrings.h: Added.
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor init]): (-[DownloadMonitor removeEntry:]): (-[DownloadMonitor _removeExpiredEntries]): (-[DownloadMonitor resource:didFinishLoadingFromDataSource:]): (-[DownloadMonitor resource:didFailLoadingWithError:fromDataSource:]):
• ViewCell.h: Added.
• ViewCell.m: Added. (RectCenteredInRect): (+[ViewCell needsToRemainInViewHierarchy]): (-[ViewCell init]): (-[ViewCell copyWithZone:]): (-[ViewCell dealloc]): (-[ViewCell instantiateView]): (-[ViewCell setObjectValue:]): (-[ViewCell objectValue]): (-[ViewCell removeViewFromSuperview]): (-[ViewCell setView:]): (-[ViewCell view]): (-[ViewCell setViewFrame:inCellFrame:inView:]): (-[ViewCell drawWithFrame:inView:]): (-[ViewCell trackMouse:inRect:ofView:]): (-[ViewCell editWithFrame:inView:editor:delegate:event:]):
• ViewCellTableView.h: Added.
• ViewCellTableView.m: Added. (+[ViewCellTableColumn newViewCell]): (-[ViewCellTableColumn initWithIdentifier:]): (-[ViewCellTableColumn initWithCoder:]): (-[ViewCellTableColumn dealloc]): (-[ViewCellTableColumn cells]): (-[ViewCellTableColumn dataCellForRow:]): (-[ViewCellTableColumn removeRows:]): (-[ViewCellTableColumn appendRows:]): (-[ViewCellTableColumn noteNumberOfTableRowsChanged:]): (-[ViewCellTableColumn willRemoveFromTableView:]): (-[NSTableColumn noteNumberOfTableRowsChanged:]): (-[NSTableColumn willRemoveFromTableView:]): (-[ViewCellTableView replaceHeaderView]): (-[ViewCellTableView workaroundReorderResizeProblem]): (-[ViewCellTableView didReorderOrResizeNotification:]): (-[ViewCellTableView initWithFrame:]): (-[ViewCellTableView initWithCoder:]): (-[ViewCellTableView dealloc]): (-[ViewCellTableView noteNumberOfRowsChanged]): (-[ViewCellTableView reloadData]): (-[ViewCellTableView removeTableColumn:]): (-[ViewCellTableView acceptsFirstResponder]): (-[ViewCellTableView needsPanelToBecomeKey]):
• WebBrowser.pbproj/project.pbxproj:

12:50 PM Changeset in webkit [2544] by darin

• 3 edits in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Add printf to the list of functions to ignore when finding localizable strings.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes both to the code here and to the extract script.

WebBrowser:

• English.lproj/StringsNotToBeLocalized.txt: Remove some now-unneeded exceptions for strings that don't appear in our code any more.

• English.lproj/Localizable.strings: Re-generated. It appears that John removed two more localizable strings after he generated it. (I had to check because last time I did this I clobbered John's change, and I didn't want to do that again.)

12:41 PM Changeset in webkit [2543] by darin

• 9 edits in trunk

WebCore:

• fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

Turns out all updating would be slow if any resources on the page failed to load.

• kwq/WebCoreResourceLoader.h: Add reportError, distinct from cancel and finish.
• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader reportError]): Set the error boolean on the job and then call through to [finish].

WebKit:

• fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

Turns out all updating would be slow if any resources on the page failed to load.

• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Call the new reportError instead of cancel. (-[WebSubresourceClient handle:didFailLoadingWithError:]): Ditto.

12:20 PM Changeset in webkit [2542] by darin

• 4 edits in trunk/WebCore

• fixed 3091275 -- can't type into Answer field in RealOne Player order form

• khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): Treat 0 as max (1024) as other browsers do. (RenderFileButton::updateFromElement): Ditto, although this is in !APPLE_CHANGES code that we don't use in WebCore.

Nov 2, 2002:

2:00 PM Changeset in webkit [2541] by darin

• 3 edits in trunk/WebKit

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Do the previous fix one better by using _web_hostWithPort.

1:55 PM Changeset in webkit [2540] by darin

• 3 edits in trunk/WebKit

• fixed bug where the address of an NSNumber object would be used for the port number

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Call intValue on the object returned from [NSURL port].

Nov 1, 2002:

10:46 PM Changeset in webkit [2539] by darin

• 3 edits in trunk/WebKit

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Fixed uninitialized variable problem.

6:16 PM Changeset in webkit [2538] by darin

• 5 edits in trunk/WebCore

• applied the same "subclass responsibility" pattern here as in some of the other WebCore classes

• kwq/WebCoreImageRendererFactory.h: Move the subclass responsibility into a protocol.
• kwq/WebCoreImageRendererFactory.m: Remove now-unneeded stubs.

6:12 PM Changeset in webkit [2537] by darin

• 9 edits in trunk/WebKit

• fixed 3090239 -- crash on window close

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Nil out the bridge and release it so we don't close the URL twice.

• fixed 3058598 -- animated gif animates repeatedly in Alex, but only once in other browsers

• WebCoreSupport.subproj/WebImageRenderer.h: Added fields used by bug workaround.
• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer blockHasGIFExtensionSignature:length:]): Helper method for bug workaround. (-[WebImageRenderer checkDataForGIFExtensionSignature:]): Checks incoming data for the GIF extension signatures. (-[WebImageRenderer initWithData:]): Override to call checkDataForGIFExtensionSignature. (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Call checkDataForGIFExtensionSignature. (-[WebImageRenderer repetitionCount]): Return 1 if we were going to return 0, but we didn't see a GIF extension signature. This workaround can be removed once we require a system new enough to have the bug fix for bug 3090341. (-[WebImageRenderer nextFrame:]): Stop on last frame, don't wrap around to first.

• WebCoreSupport.subproj/WebImageRendererFactory.h: Update for changes to WebCore.
• WebCoreSupport.subproj/WebImageRendererFactory.m: Tweaks.

• WebView.subproj/WebImageRepresentation.m: Update imports.
• WebView.subproj/WebImageView.m: Update imports.

5:16 PM Changeset in webkit [2536] by rjw

• 10 edits in trunk

i Implemented rendering of diacriticals.

• Misc.subproj/WebUnicode.h:
• Misc.subproj/WebUnicode.m: (_unicodeDigitValue): (_unicodeCategory): (_unicodeDirection): (_unicodeJoining): (_unicodeDecompositionTag): (_unicodeMirrored): (_unicodeCombiningClass): (_unicodeLower): (_unicodeUpper):
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]): (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):

Removed old implementation.

• kwq/KWQChar.mm: (QChar::direction):

Renamed JoiningCenter -> JoiningCausing.

• kwq/WebCoreUnicode.h:

5:10 PM Changeset in webkit [2535] by darin

• 7 edits in trunk

JavaScriptCore:

• kjs/object.cpp: Make the same change Maciej just did, but to the other constructor right next to the one he changed.

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

4:28 PM Changeset in webkit [2534] by darin

• 8 edits in trunk/WebCore

• fixed 3062598 -- meta refresh of 0.1s fails

KHTML was using an integer for the delay.

• khtml/khtml_part.h: Make scheduleRedirection take a double.
• khtml/khtmlpart_p.h: Make m_delayRedirect be a double.
• khtml/khtml_part.cpp: (KHTMLPart::slotData): Use a double when parsing meta refresh. (KHTMLPart::checkCompleted): Cast to int when passing to timer start. (KHTMLPart::scheduleRedirection): Cast to int when passing to timer start; also check for absurd values and do nothing. (KHTMLPart::slotParentCompleted): Cast to int when passing to timer start.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Use a double when parsing meta refresh.

• kwq/KWQKDebug.h: Add overloads for unsigned int and double to keep us compiling now that we use a double in one place.

4:13 PM Changeset in webkit [2533] by cblu

• 9 edits in trunk/WebKit

WebKit:

Check that the plug-in is loaded before calling it.

• Plugins.subproj/WebBaseNetscapePluginStream.h:
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream setPluginPointer:]): (-[WebBaseNetscapePluginStream setResponse:]): (-[WebBaseNetscapePluginStream receivedData:]): (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isLoaded]):
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage isLoaded]):
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):

WebBrowser:

Use the display name of the dataSource not the document when reporting plug-in errors.

• LoadProgressMonitor.m: (-[LoadProgressMonitor pluginFailedWithError:dataSource:]):

3:17 PM Changeset in webkit [2532] by cblu

• 16 edits
  2 adds in trunk/WebKit

WebFoundation:

• Misc.subproj/WebError.m:

WebKit:

• Moved plug-in error handling to WebResourceLoadDelegate
• Report plug-in load failure, java load failure, and plug-in not found errors.
• Added WebPluginError, subclass of WebError.
• Attempted fix: 3090675 - Standalone WMP (Window Media Player) content crashes Alexander

• English.lproj/Localizable.strings:
• Misc.subproj/WebKitErrors.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): don't send event to null function
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): report plug-in load failure
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m: take a WebPluginError (-[WebNullPluginView dealloc]): (-[WebNullPluginView viewDidMoveToWindow]):
• Plugins.subproj/WebPluginError.h: Added.
• Plugins.subproj/WebPluginError.m: Added. (-[WebPluginErrorPrivate dealloc]): (-[WebPluginError dealloc]): (-[WebPluginError pluginPageURL]): (-[WebPluginError pluginName]): (-[WebPluginError MIMEType]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): report plug-in load failure (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): report plug-in load failure
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebController.m: (-[WebResourceLoadDelegate pluginFailedWithError:dataSource:]): added, does nothing
• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebView.m: (+[WebView initialize]): added new error strings

WebBrowser:

• Moved plug-in error handling to WebResourceLoadDelegate

• BrowserWebController.m:
• English.lproj/Localizable.strings:
• LoadProgressMonitor.m: (-[LoadProgressMonitor pluginNotFoundSheetEnded:returnCode:contextInfo:]): (-[LoadProgressMonitor pluginFailedWithError:dataSource:]): display special sheets for new errors.

3:00 PM Changeset in webkit [2531] by darin

• 4 edits in trunk/WebCore

• fixed 3090249 -- random crash on page load
• fixed 3090286 -- assert _job in KWQResourceLoader cancel

• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader cancel]): This function needs to handle the case where the load is already cancelled. I think this also caused Avie's crash.

2:09 PM Changeset in webkit [2530] by sullivan

• 5 edits in trunk/WebKit

WebKit:

• some weaning of WebBookmark API from WebBookmarkGroup

• Bookmarks.subproj/WebBookmark.m: (-[WebBookmark dealloc]): set group to nil instead of asserting that it's non-nil

• Bookmarks.subproj/WebBookmarkGroup.h: removed obsolete ivar _bookmarksByID
• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup initWithFile:]): removed obsolete ivar _bookmarksByID (-[WebBookmarkGroup dealloc]): removed obsolete ivar _bookmarksByID (-[WebBookmarkGroup removeBookmark:]): removed this unnecessary method; callers need to use [[bookmark parent] removeChild:bookmark] instead

WebBrowser:

• fixed bug Darin found in my recent checkin that caused rearranging bookmarks in toolbar to fail an assertion in [WebBookmarkGroup removeBookmark:]
• fixed a leak I found in the process (bookmark rearranged in toolbar would leak)

• BookmarksController.m: (-[BookmarksController updateBookmarkSources]): use [[bookmark parent] removeChild:bookmark] instead of now-obsolete [[bookmark group] removeBookmark:bookmark]

• BookmarksViewController.m: (-[BookmarksViewController removeBookmarks:]), (-[BookmarksViewController redoRemoveBookmarks:]), (-[BookmarksViewController undoNewBookmark:]), (-[BookmarksViewController moveBookmarks:toNewFolder:]): use [[bookmark parent] removeChild:bookmark] instead of now-obsolete [[bookmark group] removeBookmark:bookmark]

• BrowserWebBookmarkExtras.m: (-[WebBookmark deleteWithUndo]): use [[bookmark parent] removeChild:bookmark] instead of now-obsolete [[bookmark group] removeBookmark:bookmark]

• FavoriteButton.m: (-[FavoriteButton draggedImage:endedAt:operation:]): don't use undoable delete in the drag-to-rearrange case; added FIXME explaining why

• FavoritesBar.m: (-[FavoritesBar deleteFavoritesWithURLsMatchingBookmarks:]), (-[FavoritesBar titleChangeSheetDidEnd:returnCode:contextInfo:]): use [[bookmark parent] removeChild:bookmark] instead of now-obsolete [[bookmark group] removeBookmark:bookmark] (-[FavoritesBar performDragOperation:]): autorelease the copy of the bookmark in the dragged FavoriteButton

12:45 PM Changeset in webkit [2529] by trey

• 7 edits in trunk/WebKit

Moved involved code for loading URLs from WebBridge up to WebFrame, with a little
consolidation along the way. I need to get all this stuff in one place in prep
for doing back-forward properly with frames. There should be no change in
functionality as a result of these changes.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:]): (-[WebBridge postWithURL:data:contentType:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Much of the guts of these is moved to WebFramePrivate.
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setIsClientRedirect:]): (-[WebDataSource _isClientRedirect]): Keep state of whether we're processing a redirect in DataSource. I had previously to do this with a loadType, but that failed because cliRedir is orthogonal.
• WebView.subproj/WebFramePrivate.h: WebFrameLoadTypeClientRedirect is gone.
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate init]): Initialize loadType explicitly. (-[WebFrame _transitionToCommitted]): Test [dataSource _isClientRedirect] instead of looking at loadType. (-[WebFrame _isLoadComplete]): Nuke WebFrameLoadTypeClientRedirect (-[WebFrame _goToItem:withFrameLoadType:]): Nuke WebFrameLoadTypeClientRedirect. (-[WebFrame _loadRequest:]): Helper method moved from WebBridge. (-[WebFrame _loadURL:loadType:clientRedirect:]): Core impl moved up from WebBridge. (-[WebFrame _postWithURL:data:contentType:]): Core impl moved up from WebBridge.

11:51 AM Changeset in webkit [2528] by darin

• 4 edits in trunk/WebKit

• implemented loop counts

• WebCoreSupport.subproj/WebImageRenderer.h: Added repetitionsComplete field.
• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer repetitionCount]): Get NSImageLoopCount. (-[WebImageRenderer nextFrame:]): Check repetitionCount and stop once we hit it.