⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 9, 2002:

3:45 PM Changeset in webkit [2615] by darin
  • 11 edits in trunk/WebKit
  • fixed 3095156 -- reproducible leak of WebDataSource due to bad URL in stylesheet
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Check for errors by looking at the return value from loadWithRequest: rather than making a separate call to canInitWithRequest.
  • WebView.subproj/WebBaseResourceHandleDelegate.h: Add boolean success/failure result loadWithRequest:.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): Return NO if we fail to make a handle.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Check result of loadWithRequest: and complain if it's NO.
  • WebView.subproj/WebMainResourceClient.m: Tweak whitespace.
12:59 PM Changeset in webkit [2614] by cblu
  • 6 edits in trunk/WebKit

WebKit:

Fixed: 2991610 - Alexander should support services, including Speech

  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView initialize]): register for service types (-[WebHTMLView dealloc]): moved to top of file (-[WebHTMLView copy:]): call _writeSelectionToPasteboard (-[WebHTMLView writeSelectionToPasteboard:types:]): call _writeSelectionToPasteboard (-[WebHTMLView validRequestorForSendType:returnType:]): return self for our pboard types
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView _pasteboardTypes]): new, returns the array of supported pboard types (-[WebHTMLView _writeSelectionToPasteboard:]): new, adds data to pboard
  • WebView.subproj/WebImageView.m: (-[WebImageView initialize]): register for service types (-[WebImageView validateUserInterfaceItem:]): respond to copy (-[WebImageView validRequestorForSendType:returnType:]): return self for images (-[WebImageView writeImageToPasteboard:]): writes image data to pboard (-[WebImageView copy:]): calls writeImageToPasteboard (-[WebImageView writeSelectionToPasteboard:types:]): calls writeImageToPasteboard

WebBrowser:

Open the URL in a new window as we do for other externally opened URLs.

  • ServicesProvider.m: (-[ServicesProvider openURL:userData:error:]):

Nov 8, 2002:

11:46 PM Changeset in webkit [2613] by darin
  • 3 edits in trunk/WebKit
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem setTitle:]): Use display title if it matches, so we don't end up with two identical strings, as when reading from the property list. (-[WebHistoryItem setDisplayTitle:]): The same thing, the other way round.
11:46 PM Changeset in webkit [2612] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/date_object.cpp: (ctimeUsingCF): Added. (timeUsingCF): Added.
11:09 PM Changeset in webkit [2611] by darin
  • 3 edits in trunk/WebKit
  • fixed 3095078 -- image loop counts still not handled right
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer blockHasGIFExtensionSignature:length:]): Look for the tag "NETSCAPE2.0", not "NETSCAPE1.0". (-[WebImageRenderer nextFrame:]): Remove special handling for last frames with a duration of 0. That was just a misunderstanding.
8:12 PM Changeset in webkit [2610] by mjs
  • 4 edits in trunk/WebCore
  • fixed 3096451 - REGRESSION: clicking on link to open window only works when pop-up suppression is off
  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::ScriptInterpreter): Initialize m_timerCallback to false.
5:42 PM Changeset in webkit [2609] by darin
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Slightly better fix. Essentially just take out the assert.
5:39 PM Changeset in webkit [2608] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQComboBox.mm: Bump fudge factor up one pixel. You could see it was wrong with strings like "0".
5:37 PM Changeset in webkit [2607] by darin
  • 3 edits in trunk/WebKit
  • fixed an assert I am seeing a lot
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Oops.
5:33 PM Changeset in webkit [2606] by darin
  • 5 edits in trunk/WebCore
  • fixed 3090452 -- REGRESSION: orbitz Box extends way over margins
  • kwq/KWQComboBox.h: Added _width and _widthGood.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Set _widthGood to false. (QComboBox::insertItem): Set _widthGood to false. (QComboBox::sizeHint): Compute the width by measuring the text ourselves. Turns out the cell isn't helpful for that. (QComboBox::clear): Set _widthGood to false.
4:23 PM Changeset in webkit [2605] by rjw
  • 3 edits in trunk/WebKit

Solved missing glyph problem, but it's very slow, so
it's disabled for now. I'll turn back on after extending
the character to glyph map in each renderer to include
substituted font.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer substituteFontForString:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

Coalesce items, and add a count to title when appropriate. Useful for
condensing multiple item, like spacer.gif.

  • LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]):
  • ResourceProgressEntry.h:
  • ResourceProgressEntry.m: (-[ResourceProgressEntry count]): (-[ResourceProgressEntry setCount:]): (-[ResourceProgressEntry title]):
2:35 PM Changeset in webkit [2604] by darin
  • 15 edits in trunk/WebKit
  • separate WebBaseNetscapePluginStream more cleanly from its subclasses by making most fields private
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
  • Plugins.subproj/WebNetscapePluginStream.h:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]): (-[WebSubresourceClient cancel]):
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate _cancelWithError:]): (-[WebBaseResourceHandleDelegate cancel]): (-[WebBaseResourceHandleDelegate cancelQuietly]): (-[WebBaseResourceHandleDelegate cancelledError]): (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]):
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancel]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient notifyDelegatesOfInterruptionByPolicyChange]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handleDidFinishLoading:]):
1:06 PM Changeset in webkit [2603] by darin
  • 4 edits in trunk/WebKit

Tools:

  • Scripts/blame-malloc-history: Added.
  • Scripts/count-malloc-history: Added.
  • Scripts/diff-malloc-history: Added.

WebFoundation:

  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle description]): Used a description in a more-standard format.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad _cleanup]): Changed so it no longer uses autorelease. (-[WebResourceLoad description]): Use a description in a more-standard format.
  • CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest description]): Used a description that includes the URL.
  • Misc.subproj/WebError.m: (-[WebError description]): Used a description in a more-standard format.
  • Misc.subproj/WebKeyValuePair.m: (-[WebKeyValuePair description]): Used a description in a more-standard format.
  • Misc.subproj/WebMonitor.m: Removed a description method that did the same as what NSObject already does.
  • English.lproj/Localizable.strings: Regenerated.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for above changes.

WebKit:

  • changed persistent dictionaries to use NSString instead of NSURL because of impact on memory footprint

Also changed WebIconDatabase code to verify what it reads from disk,
and ignore it if it can't verify the format.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase iconForSiteURL:withSize:cache:]): (-[WebIconDatabase retainIconForSiteURL:]): (-[WebIconDatabase releaseIconForSiteURL:]): (-[WebIconDatabase _iconDictionariesAreGood]): (-[WebIconDatabase _loadIconDictionaries]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _hasIconForSiteURL:]): (-[WebIconDatabase _iconsForIconURLString:]): (-[WebIconDatabase _setIcon:forIconURL:]): (-[WebIconDatabase _setIconURL:forSiteURL:]): (-[WebIconDatabase _setBuiltInIconAtPath:forHost:]): (-[WebIconDatabase _retainIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]): (-[WebIconDatabase _retainFutureIconForSiteURL:]): (-[WebIconDatabase _releaseFutureIconForSiteURL:]): (-[WebIconDatabase _retainOriginalIconsOnDisk]): (-[WebIconDatabase _releaseOriginalIconsOnDisk]): (-[NSEnumerator _web_isAllStrings]):
  • Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels didStartLoadingURL:inWindow:]): (-[WebStandardPanels didStopLoadingURL:inWindow:]): (-[WebStandardPanels _didStartLoadingURL:inController:]): (-[WebStandardPanels _didStopLoadingURL:inController:]): (-[WebStandardPanels frontmostWindowLoadingURL:]):
11:08 AM Changeset in webkit [2602] by rjw
  • 4 edits in trunk/WebCore

Cleanup of fix to 3083281. Never call stopAnimating from
QPixmap's destructor. With the fix it wouldn't have been
called anyway.

  • kwq/KWQPixmap.mm: (QPixmap::~QPixmap):
9:58 AM Changeset in webkit [2601] by darin
  • 4 edits in trunk/WebCore
  • kwq/WebCoreBridge.mm: (attributedString): Remove some dead code.
9:57 AM Changeset in webkit [2600] by darin
  • 7 edits in trunk/WebKit
  • fixed crash on boot that Don was seeing
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem URL]): Make this work when _URLString is nil. (-[WebHistoryItem initFromDictionaryRepresentation:]): Make this work for nil URL.
  • my own private war on the cString method
  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]): Use %@ in LOG to avoid cString. (-[WebDownloadHandler finishedLoading]): Ditto.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Ditto.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]): Ditto. (-[WebFrame _setState:]): More of the same. (-[WebFrame _isLoadComplete]): Ditto.
6:56 AM Changeset in webkit [2599] by kocienda
  • 4 edits in trunk/WebKit

Fix deployment build breaker: a variable was used only in a
LOG statement, causing the variable to become usused when
building with the Deployment build style.

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler finishedLoading])

Nov 7, 2002:

11:53 PM Changeset in webkit [2598] by darin
  • 4 edits in trunk/WebKit
  • History.subproj/WebHistoryItem.h: Replace _URL with _URLString.
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem _retainIconInDatabase:]): Get the URL with [self URL]. (-[WebHistoryItem initWithURL:target:parent:title:]): Set up _URLString. (-[WebHistoryItem dealloc]): Release _URLString. (-[WebHistoryItem URL]): Make a URL from _URLString. (-[WebHistoryItem icon]): Use [self URL] instead of _URL. (-[WebHistoryItem setURL:]): Store a URL string. (-[WebHistoryItem hash]): Use the URL string's hash. (-[WebHistoryItem isEqual:]): Compare the URL strings. (-[WebHistoryItem description]): Use _URLString. (-[WebHistoryItem dictionaryRepresentation]): Use _URLString. (-[WebHistoryItem initFromDictionaryRepresentation:]): Call through to the other init functions so we have only one designated initializer. Leave the date as nil if there's no date in the dictionary instead of setting the date to 0.
11:47 PM Changeset in webkit [2597] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::slotData): Add an assert in the hopes of catching bug 3084704 a little earlier.
11:43 PM Changeset in webkit [2596] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/date_object.cpp: (mktimeUsingCF): Fix storage leak.
9:29 PM Changeset in webkit [2595] by mjs
  • 9 edits in trunk/WebKit

WebKit:

Removed SaveAndOpenExternally policy.

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler finishedLoading]):
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handleDidFinishLoading:]):

WebBrowser:

Removed all uses of SaveAndOpenExternally policy.

  • BrowserDocument.m: (-[BrowserDocument _stopNonDownloadingDataSource:]):
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]):
9:15 PM Changeset in webkit [2594] by cblu
  • 3 edits in trunk/WebKit

WebKit:

  • WebKit.pbproj/project.pbxproj:

WebBrowser:

Made Alexander responsible for opening downloads.

  • BrowserWebController.m: (-[BrowserWebController fileURLPolicyForMIMEType:andRequest:inFrame:]): call +[WBPreferences shouldOpenFileWithMIMEType:] (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]): no open policy
  • Defaults.plist:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry isDiskCopyFile]): (-[DownloadProgressEntry startDiskCopyInteraction]): (-[DownloadProgressEntry openFile]): (-[DownloadProgressEntry setCompleted]):
  • Preferences.subproj/WBPreferences.h:
  • Preferences.subproj/WBPreferences.m: (+[WBPreferences shouldOpenFileWithMIMEType:]): moved this method here from BrowserWebController as this is now called in 2 different places
7:10 PM Changeset in webkit [2593] by mjs
  • 4 edits in trunk/JavaScriptCore
  • partial fix to 3073230 - JavaScript time calls do I/O by lastat()ing /etc/localtime
  • kjs/date_object.cpp: (mktimeUsingCF): Implementation of mktime using CF.
6:49 PM Changeset in webkit [2592] by rjw
  • 2 edits in trunk/WebKit

Commit changelog.

5:29 PM Changeset in webkit [2591] by mjs
  • 3 edits in trunk/WebKit
  • fixed 3095628 - REGRESSION: exception when clicking on link to load content into iframe
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:]): Get the element info from the HTML view where the click originally happened, not the current document view. Add some asserts to make sure this is working.
5:14 PM Changeset in webkit [2590] by rjw
  • 4 edits in trunk/WebCore

Don't stop animating unless we're the last referee. (3083281)

  • kwq/KWQPixmap.mm: (QPixmap::~QPixmap):
3:50 PM Changeset in webkit [2589] by rjw
  • 3 edits in trunk/WebKit

Fixed updating of status bar and activity window when
loading plugin content as main document. (3084311)

  • LoadProgressMonitor.m: (-[LoadProgressMonitor resource:didReceiveContentLength:fromDataSource:]):
11:29 AM Changeset in webkit [2588]
  • 3 copies in tags/Alexander-31

This commit was manufactured by cvs2svn to create tag 'Alexander-31'.

11:29 AM Changeset in webkit [2587] by sheridan
  • 8 edits in trunk

Alex-31 stamp

7:47 AM Changeset in webkit [2586] by mjs
  • 3 edits in trunk/WebKit
  • fixed 3094778 - REGRESSION: Assert on logout from schwab.com

(probably fixed it anyway - I'm flying blind on this one)

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): Use a nil request if the URL was nil, instead of making a request that contains a nil URL.
6:33 AM Changeset in webkit [2585] by mjs
  • 14 edits in trunk/WebKit

WebKit:

Changed things so that creating a window takes a request rather
than a URL and referrer.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]):
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:behind:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setTriggeringEvent:]): (-[WebDataSource _triggeringEvent]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame findOrCreateFramedNamed:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Changed things so that creating a window takes a request rather
than a URL and referrer.

  • BrowserWebController.m: (-[BrowserWebController createWindowWithRequest:]):

Nov 6, 2002:

10:43 PM Changeset in webkit [2584] by darin
  • 4 edits in trunk/WebKit
  • fixed problem where files small enough to fit entirely in the buffer (8K or less) would not be decoded
  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler decodeData:]): Added. Moved most of the code from receivedData into here. (-[WebDownloadHandler receivedData:]): Changed to call decodeData. (-[WebDownloadHandler finishedLoading]): Call decodeData on any remaining bytes rather than writing them straight out to the data fork.
5:21 PM Changeset in webkit [2583] by rjw
  • 8 edits in trunk

More work on rendering scripts. Now most complex scripts render correctly.
Working new features include:
bidi, diacriticals, cursive forms, and arabic ligatures.
Selection of text rendered in these scripts, is however, not working.
Also, line height is incorrect when renderering combined below glyphs.
ajami is, sadly, horrendously broken.

  • Misc.subproj/WebUnicode.m: (glyphVariantLogical): (shapedString):
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

Use our notion of unicode whitespace from lookup tables
and isspace for latin1. This is more correct than CF.
Fixed issues Dave ran into with whitespace calculations.

  • kwq/KWQChar.mm: (QChar::isSpace):
5:10 PM Changeset in webkit [2582] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

  • Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkOfType:]): made this handle WebBookmarkTypeProxy

WebBrowser:

  • fixed 3092708 -- allow option for Bookmarks Toolbar as submenu of Bookmarks menu

The wording and possibly layout in Preferences will change soon, but the
behavior is now implemented as SJ specified.

  • Defaults.plist:
  • PreferenceKeys.h: New preference keys for the new options
  • Preferences.subproj/English.lproj/BookmarkPreferences.nib: rejigger everything in the bookmarks preferences panel
  • Preferences.subproj/BookmarkPreferences.h:
  • Preferences.subproj/BookmarkPreferences.m: (-[BookmarkPreferences updateBookmarksViews]): (-[BookmarkPreferences toggleBookmarksToolbarIncludesAddressBook:]): (-[BookmarkPreferences toggleBookmarksToolbarIncludesRendezvous:]): (-[BookmarkPreferences toggleBookmarksMenuAndToolbarAreSame:]): (-[BookmarkPreferences toggleBookmarksMenuIncludesBookmarksToolbar:]): (-[BookmarkPreferences toggleBookmarksMenuIncludesRendezvous:]): (-[BookmarkPreferences initializeFromDefaults]): reworked all the code to handle the new options, including the way some options change when others are checked
  • BookmarksController.h: made addressBookProxyTitle and rendezvousProxyTitle public
  • BookmarksController.m: (-[BookmarksController addChildrenOfBookmark:toMenu:]): new method, generalized from code elsewhere (handles keyboard equivalents for toolbar items) (-[BookmarksController addMenuItemForBookmark:toMenu:]): now calls addChildrenOfBookmark:toMenu: (-[BookmarksController addFavoritesSubmenu]): new method, calls addChildrenOfBookmark:toMenu: (-[BookmarksController addSpecialBookmarkSourcesToMenu]): now handles toolbar as submenu, plus fancier logic to match new preferences (-[BookmarksController _addBookmarksToMenu]): now calls addChildrenOfBookmark:toMenu: (-[BookmarksController receivedBrowserPreferenceValueChangedNotification:]): now checks for new preferences also
  • FavoriteButton.m: (-[FavoriteButton setBookmark:]): now handles WebBookmarkTypeProxy -- like folder in appearance, but not a drag target (-[FavoriteButton menu]): now handles WebBookmarkTypeProxy (by returning nil for the context menu) (-[FavoriteButton hasContentsMenu]): new method, just checks bookmark type (-[FavoriteButton _contentsMenu]): now handles WebBookmarkTypeProxy by using BookmarkSource protocol to extract contents (-[FavoriteButton mouseDown:]): check hasContentMenu instead of assuming which types have menus
  • FavoritesBar.m: (-[FavoritesBar addButtonForBookmark:withLeftEdge:]): new method, extracted from _refreshButtons (-[FavoritesBar includeRendezvous]), (-[FavoritesBar includeAddressBook]): new methods, check with NSUserDefaults (-[FavoritesBar _refreshButtons]): take includeRendezvous and includeAddressBook into account; now calls addButtonForBookmark:withLeftEdge: (-[FavoritesBar refreshButtonsSoon]): new method, extracted from _favoritesChanged (-[FavoritesBar preferenceValueChanged:]): new method, call refreshButtons if the right prefs have changed (-[FavoritesBar _favoritesChanged:]): now calls refreshButtonsSoon (-[FavoritesBar initWithView:]): register for preferences value changed notifications (-[FavoritesBar dropIndexFromDraggingInfo:]): take includeRendezvous and includeAddressBook into account (-[FavoritesBar performDragOperation:]): take includeRendezvous and includeAddressBook into account
4:16 PM Changeset in webkit [2581] by darin
  • 5 edits in trunk/WebKit
  • fixed bug that affected BinHex-encoded files with no resource fork
  • Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeData:dataForkData:resourceForkData:]): Don't decode the resource fork unless done with the data fork.
  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]): Set the forks to nil before calling through.
3:47 PM Changeset in webkit [2580] by darin
  • 4 edits in trunk/WebKit
  • Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Fix == 129 check that was supposed to be <= 129.
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
3:44 PM Changeset in webkit [2579] by cblu
  • 2 edits in trunk/WebKit/Downloads.subproj

WebFoundation:

Added _web_infoDictionaryForBundleAtPath. Gets info dictionary without using NSBundle.

  • Misc.subproj/WebNSDictionaryExtras.h:
  • Misc.subproj/WebNSDictionaryExtras.m: (+[NSDictionary _web_infoDictionaryForBundleAtPath:]):

WebBrowser:

Preliminary work for disk copy interaction.

  • AppController.m: (-[AppController awakeFromNib]): tweak to GURL event call, no actual change
  • Defaults.plist: don't have WebKit open disk images for us anymore, since Alex will do this.
  • DiskCopyPuppetStrings.h:
  • DownloadMonitor.m: (-[DownloadMonitor init]): set handlers for disk copy events (-[DownloadMonitor handleDiskCopyEvent:withReplyEvent:]): added, does nothing right now
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry diskCopyStage]): new (-[DownloadProgressEntry setDiskCopyStage:]): new (-[DownloadProgressEntry startDiskCopyInteraction]): new, check version of disk copy, open disk image (-[DownloadProgressEntry setCompleted]): call startDiskCopyInteraction
3:31 PM Changeset in webkit [2578] by darin
  • 4 edits in trunk/WebKit
  • Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeIntoBuffer:size:]): Fix an off-by-one error handling repeat counts.
  • WebKit.pbproj/project.pbxproj: Fix group name I accidentally mangled.
3:11 PM Changeset in webkit [2577] by darin
  • 8 edits
    2 adds in trunk/WebKit
  • added a BinHex decoder and did a little work on the MacBinary decoder

I'm not supposed to be working on this, but I didn't feel like doing "real" work.

  • Downloads.subproj/WebBinHexDecoder.h: Added.
  • Downloads.subproj/WebBinHexDecoder.m: Added.
  • WebKit.pbproj/project.pbxproj: Added WebBinHexDecoder.
  • Downloads.subproj/WebDownloadDecoder.h: Added WEB_DOWNLOAD_DECODER_MINIMUM_HEADER_LENGTH.
  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler closeFile]): Check to be sure we don't close the same file twice.
  • Downloads.subproj/WebMacBinaryDecoder.h: Added _scriptCode.
  • Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added check of MacBinary version field. (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Added MacBinary III part that gets the script code. (-[WebMacBinaryDecoder filename]): Use the script code.
2:37 PM Changeset in webkit [2576] by mjs
  • 8 edits in trunk/WebKit

WebKit:

Took URL field out of click policy - open in new window policy
will always open the request URL.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyPrivate dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

WebBrowser:

Updated for WebKit changes.

  • BrowserWebController.m: (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):
11:26 AM Changeset in webkit [2575] by cblu
  • 3 edits in trunk/WebKit

Support MacBinary I by checking that bytes 99-127 are 0. Also check byte 82 for all formats.

  • Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]):
9:25 AM Changeset in webkit [2574] by kocienda
  • 3 edits in trunk/WebKit

WebFoundation:

Fix for this bug:

Radar 3004422 (Loader should cache misses)

I added a code to support caching HTTP 404 responses. These objects
will now get cached just like other responses, and they are subject
to the same revalidation rules as other cache objects.

To support caching the 404 for a specified period of time, I have
added an extra method to WebHTTPResourceRequest.

  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler willCacheObject:]): (-[WebHTTPProtocolHandler shouldCacheResponse:]):
  • ProtocolHandlers.subproj/WebHTTPResourceRequest.h:
  • ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest pageNotFoundCacheLifetime]): (-[WebResourceRequest setPageNotFoundCacheLifetime:]): (-[WebHTTPResourceRequestParameters copyWithZone:]): (-[WebHTTPResourceRequestParameters isEqual:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _examineHeaders]):

WebKit:

Call new WebHTTPResourceRequest method to set the amount of time
to cache a 404 response when trying to fetch a favicon.

This change helps to fix this bug:

Radar 3004422 (Loader should cache misses)

  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])

Nov 5, 2002:

8:00 PM Changeset in webkit [2573] by mjs
  • 10 edits in trunk/WebKit

WebKit:

Reworked clickPolicy arguments to be closer to proposed version.

  • WebKit.exp:
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPolicyDelegate.m:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:]): (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

WebBrowser:

Adjusted for WebKit API changes.

  • BrowserWebController.m: (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):
5:59 PM Changeset in webkit [2572] by darin
  • 3 edits in trunk/WebKit
  • WebCoreSupport.subproj/WebTextRenderer.m: Made a slightly simpler and faster version of the new "lose precision" CEIL_TO_INT macro.
5:56 PM Changeset in webkit [2571] by darin
  • 4 edits in trunk/WebCore
  • fixed 3092722 -- assertion failed
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader reportError]): Removed the assertion. It wasn't needed.
5:47 PM Changeset in webkit [2570] by rjw
  • 3 edits in trunk/WebKit

Fixed a couple of issues that Dave highlighted w/ his whitespace
fixes. CG sometimes introduces very small 'error' in metrics, specifically
we saw character widths of 20.0000019 that should have been 20. As a
work-around we loose precision beyond the 1000th place. Also, always
ceil spaces.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):
5:25 PM Changeset in webkit [2569] by darin
  • 3 edits in trunk/WebKit
  • fixed 3084704 -- crash in HTMLTokenizer on page with JavaScript HTMLDocument::Close inside a <script>
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): We need to stop loading here. Otherwise we might do loading after closeURL, which could lead to a problem like the one above.
5:21 PM Changeset in webkit [2568] by darin
  • 4 edits in trunk/WebKit
  • changed our MacBinary decoding to not pay any attention to the comment

Before we would "fail to decode" if the comment was truncated, now we just
don't worry about it.

  • Downloads.subproj/WebMacBinaryDecoder.h: Remove _commentLength and _commentEnd.
  • Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Remove code to get _commentLength and code to compute _commentEnd. (-[WebMacBinaryDecoder finishDecoding]): Check offset against the resource fork end rather than the comment end to see if we got enough data.
5:19 PM Changeset in webkit [2567] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

  • Resources/url_icon.tiff: reverted generic URL icon back to the one that looks like a document until we get something from HI that SJ likes

WebBrowser:

  • Resources/Images/FavoritesBar.tif:
  • Resources/Images/tiny_menu.tiff: reverted Bookmarks menu and Bookmarks toolbar icons back to the previous versions until we get something from HI that SJ likes
4:27 PM Changeset in webkit [2566] by cblu
  • 12 edits in trunk/WebKit

WebKit:

Fixed: 3074108 - Decode macbinary files during download

  • Downloads.subproj/WebDownloadDecoder.h:
  • Downloads.subproj/WebDownloadHandler.h:
  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]): (-[WebDownloadHandler dealloc]): (-[WebDownloadHandler decodeHeaderData:dataForkData:resourceForkData:]): (-[WebDownloadHandler decodeData:dataForkData:resourceForkData:]): (-[WebDownloadHandler closeFile]): (-[WebDownloadHandler cleanUpAfterFailure]): (-[WebDownloadHandler createFileIfNecessary]): (-[WebDownloadHandler writeData:toFork:]): (-[WebDownloadHandler writeDataForkData:resourceForkData:]): (-[WebDownloadHandler dataIfDoneBufferingData:]): (-[WebDownloadHandler receivedData:]): (-[WebDownloadHandler finishDecoding]): (-[WebDownloadHandler finishedLoading]): (-[WebDownloadHandler cancel]):
  • Downloads.subproj/WebMacBinaryDecoder.h:
  • Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[WebMacBinaryDecoder fileAttributes]): (-[WebMacBinaryDecoder filename]):
  • Misc.subproj/WebKitErrors.h: added new errors
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): don't send response to download handler (-[WebMainResourceClient handle:didReceiveData:]): watch for decoding errors

WebBrowser:

Fixed: 3074108 - Decode macbinary files during download

  • DownloadMonitor.m: (-[DownloadMonitor identifierForInitialRequest:fromDataSource:]): (-[DownloadMonitor resource:willSendRequest:fromDataSource:]): (-[DownloadMonitor resource:didReceiveResponse:fromDataSource:]):
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDictionary:]): new, convenience (+[DownloadProgressEntry entryWithDataSource:]): (-[DownloadProgressEntry filename]): (-[DownloadProgressEntry path]): (-[DownloadProgressEntry setCompleted]):
  • DownloadRow.m: (-[DownloadRow _updateStatusFields]):
11:35 AM Changeset in webkit [2565] by kocienda
  • 3 edits in trunk/WebKit

Fix for this bug:

Radar 3092747 (javascript cookieEnabled property returns incorrect value)

Now, we return "true" for navigator.cookieEnabled when
"Only accept cookies from the same domain as the current page" option
is selected is user preferences.

  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled])
10:51 AM Changeset in webkit [2564] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

  • fixed 3091271 -- missing plug-in icon is on white background, not transparent.
  • Resources/nullplugin.tiff: Photoshopped the white away. It's still ugly, but that's a separate bug (3091274)

WebBrowser:

Removed the text from the lock icon. Also cleaned up the
code that positions the lock icon in the window.

  • BrowserWindow.m: (-[BrowserWindow adjustRightSideImageViewFrame]): new method, sets the image view's frame based on the image size and specified margins (-[BrowserWindow setUpRightSideImageView]): now calls adjustRightSideImageViewFrame (-[BrowserWindow setTitleBarRightSideImage:]): now calls adjustRightSideImageViewFrame if image has changed
  • Resources/Images/Lock.tif: textless version
9:27 AM Changeset in webkit [2563] by darin
  • 9 edits in trunk/WebCore
  • re-fixed 3070484 -- icon rollovers are very slow on Mac OS X website

Had to roll back some of the files I changed yesterday. I had missed the
one line of useful code among much stuff we don't need.

  • khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::slotLoaderRequestStarted): (KHTMLPart::slotLoaderRequestDone):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::call):
  • kwq/KWQSignalStubs.mm: (Loader::requestDone): (Loader::requestFailed): (Loader::requestStarted):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call): Just roll back all the changes from my 3091714 check-in below, except for the bug fix itself in loader.cpp and KWQResourceLoader.mm.
9:08 AM Changeset in webkit [2562] by kocienda
  • 3 edits in trunk/WebKit/Misc.subproj

The -(NSEnumeration *)keys method has never been implemented, and is unneeded.
Removing from API. This has no external impact as this class
is entirely private to WebFoundation.

  • Database.subproj/WebDatabase.h:
  • Database.subproj/WebDatabase.m:
  • Database.subproj/WebFileDatabase.m:
3:20 AM Changeset in webkit [2561] by mjs
  • 3 edits in trunk/WebKit
  • fixed 3083732 - SJ: window comes out blank on samsung site
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Don't start loading if the URL is exactly the same as the parent URL. We may need a more stringent check, but this seems to match the tolerance of other browsers OK.
2:26 AM Changeset in webkit [2560] by mjs
  • 6 edits in trunk/WebCore
  • fixed 3027404 - pop-up ads not always suppressed
  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::isWindowOpenAllowed): Don't allow opening if we are in a timer callback - for reasons unexplained this will always show up as an inline script.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_window.cpp: (ScheduledAction::execute): Note that we're in a timer callback.
1:31 AM Changeset in webkit [2559] by mjs
  • 7 edits in trunk/WebKit

WebKit:

Added request and frame to click policy callback.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForElement:button:modifierFlags:request:inFrame:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):

WebBrowser:

  • fixed 3044620 - incorrect URL sent to the click policy handler, other problems, because it's processed early
  • BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierFlags:request:inFrame:]): Look at request URL, not element URL.
Note: See TracTimeline for information about the timeline view.