⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 3, 2002:

11:19 PM Changeset in webkit [2926] by mjs
  • 2 edits
    36 adds in trunk/JavaScriptCore

Reviewed by: Darin Adler

  • imported PCRE 3.9 into the tree; this isn't actually compiled or used yet.
  • pcre/*: Added.
11:07 PM Changeset in webkit [2925] by darin
  • 2 edits in trunk/WebKit
  • fixed 3117193 -- REGRESSION: Hang on Hixie's weblog

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer substituteFontForString:families:]): Do the operation on the whole string at once instead of a character at a time. I decided to do this rather than correct the bug in the character-at-a-time version.
9:50 PM Changeset in webkit [2924] by mjs
  • 5 edits in trunk

Rolled over all the ChangeLogs to ChangeLog-2002-12-03's in the hopes
of speeding up checkouts and checkins.

9:18 PM Changeset in webkit [2923] by trey
  • 4 edits in trunk/WebKit

Re-fix of 3113393 - Clients side redirects shouldn't always add item to back/forward list
Fix 3116980 - REGRESSION: Back button goes back twice
Fix 3099631 - assertion failure at ​http://www.calendarlive.com/ when pop-up blocking is off

The earlier fix for the first bug was to consider any redirect happening within one
second as a continuation of the previous load. To fix the regressions I re-cast that
fix using a similar, pre-existing mechanism.

Reviewed by: Richwill

  • WebView.subproj/WebFramePrivate.h: Nuke shortRedirectComing, rename instantRedirectComing to quickRedirectComing.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _createOrUpdateItem]): Remove code related to shortRedirectComing, the fix that brought the regressions. (-[WebFrame _setState:]): Don't cache the page we're leaving if we're doing a redirect (since we don't want the redirecting page in the cache). (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Above rename. (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Above rename. (-[WebFrame _loadURL:intoChild:]): Comment fix. (-[WebFrame _clientRedirectedTo:delay:fireDate:]): Use 1 second instead of 0 seconds as the metric of a client redirect. Do not consider whether the frame state is completed as part of the decision. (-[WebFrame _clientRedirectCancelled]): Above rename.
8:52 PM Changeset in webkit [2922] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by: Darin

  • REALLY changed the default state for block pop-ups to be off.
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): change default for letting JavaScript open windows automatically to YES

WebBrowser:

Reviewed by: Darin

  • Deleted old unused preference keys, one of which was tricking me into thinking that block pop-ups was correctly set when it wasn't (the real setting is in WebKit)
  • Defaults.plist:
  • PreferenceKeys.h: deleted things that aren't used anywhere
8:39 PM Changeset in webkit [2921] by darin
  • 5 edits in trunk/WebKit
  • fixed 3117135 -- world leak: drag any image, get a leak of 1 WebFrame

Reviewed by John.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Retain the URL of the dragged image, not the entire element dictionary. The element dictionary creates a reference cycle since it includes a reference to the WebFrame. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use the URL rather than extracting it from the dictionary with a WebElementImageURLKey.
  • WebView.subproj/WebHTMLViewPrivate.h: URL, not element dictionary.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): Release the URL, not the element dictionary.
7:25 PM Changeset in webkit [2920] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3078227, hanging in table code. Make sure <form>s
don't get wrapped in anonymous rows and cells.

Reviewed by: rjw

  • khtml/rendering/render_table.cpp: (RenderTable::addChild): (RenderTableSection::addChild): (RenderTableRow::addChild):
7:10 PM Changeset in webkit [2919] by rjw
  • 5 edits in trunk/WebKit

Added a preference to change the page cache size, i.e.:
Alexander.app/Contents/MacOS/Alexander -WebKitPageCacheSizePreferenceKey 4

Reviewed by: hyatt

  • History.subproj/WebBackForwardList.m: (+[WebBackForwardList setPageCacheSize:]): (+[WebBackForwardList pageCacheSize]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): (-[WebPreferences _initialTimedLayoutSize]): (-[WebPreferences _pageCacheSize]):
  • WebView.subproj/WebPreferencesPrivate.h:
6:43 PM Changeset in webkit [2918] by hyatt
  • 4 edits in trunk/WebCore

Backing out a file that I did not intend to check in.

  • khtml/misc/loader.cpp:
6:14 PM Changeset in webkit [2917] by rjw
  • 4 edits in trunk/WebCore

D'oh. Fixed last minute change that broke the build.

  • kwq/KWQFont.mm: (QFont::getNSFont):
6:05 PM Changeset in webkit [2916] by hyatt
  • 8 edits in trunk/WebCore

Remove the moveWidgetsAside function. This fixes all the
form controls on livepage.apple.com that were getting hosed
by the scrolling marquee.

Reviewed by: darin

  • khtml/html/html_tableimpl.cpp: (HTMLTableRowElementImpl::addChild):
  • khtml/misc/loader.cpp:
  • khtml/rendering/render_root.cpp: (RenderRoot::layout):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::paint):
5:56 PM Changeset in webkit [2915] by rjw
  • 19 edits in trunk

Fixed 3019986. Use an array of font families instead of a single
font family to support CSS family lists.
r=hyatt

  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthForString:font:]):
  • Misc.subproj/WebStringTruncator.m: (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer substituteFontForString:families:]): (-[WebTextRenderer substituteFontForCharacters:length:families:]): (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:fontFamilies:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:fontFamilies:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:fontFamilies:]):
  • WebCoreSupport.subproj/WebTextRendererFactory.h:
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamilies:traits:size:]): (-[WebTextRendererFactory fontWithFamily:traits:size:]): (+[WebTextRendererFactory fallbackFontWithTraits:size:]): (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]): (-[WebTextRendererFactory cachedFontFromFamilies:traits:size:]): (-[WebTextRendererFactory rendererWithFamilies:traits:size:]):

Fixed 3019986. Use an array of font families instead of a single
font family to support CSS family lists.
r=hyatt

  • kwq/KWQFont.h:
  • kwq/KWQFont.mm: (QFont::getNSFont):
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
  • kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawUnderlineForText):
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebCoreTextRendererFactory.h:
  • kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory rendererWithFamilies:traits:size:]): (-[WebCoreTextRendererFactory fontWithFamilies:traits:size:]):
4:21 PM Changeset in webkit [2914] by cblu
  • 3 edits in trunk/WebKit

Fixed: 3115073 - REGRESSION: plants.com is crashing in WebIconDB with bad retain count

The plants.com favicon was marked to be removed from disk and thus it had no retain count. The problem was that it was still on disk and _hasIconForIconURL would return YES. If hasIconForIconURL returns YES, its is ok to call _setIconURL:forSiteURL:. Since there was no retain count, the assert in _setIconURL:forSiteURL: would be hit.

We now consider icons without retain counts to not exist even if they're on disk.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _setIconURL:forSiteURL:]):
3:20 PM Changeset in webkit [2913] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by: Darin Adler

  • fixed Deployment build.
  • kjs/dtoa.cpp: Work around warnings.
2:51 PM Changeset in webkit [2912] by mjs
  • 5 edits
    2 adds in trunk/JavaScriptCore
  • fixed 3114790 - Gamespot reviews pages badly mis-rendering because floating point numbers format wide

Reviewed by: David Hyatt

  • kjs/dtoa.cpp: Imported float <--> string conversion routines from David M. Gay. I changed this to fix warnings and avoid colliding with names of standard library functions.
  • kjs/dtoa.h: Added a header I made up for dtoa.cpp
  • kjs/ustring.cpp: (UString::from): Use new double to string routine (kjs_strtod). (UString::toDouble): Use new string to double routine (kjs_dtoa).
  • JavaScriptCore.pbproj/project.pbxproj: Added new files
2:46 PM Changeset in webkit [2911] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3112599, aol.com shopping page doesn't work. Apply
the same form demotion trick to <tr> that I did already for
<tbody> and <table>.

r=gramps

  • khtml/html/dtd.cpp: (DOM::checkChild):
  • khtml/html/html_tableimpl.cpp: (HTMLTableRowElementImpl::addChild):
  • khtml/html/html_tableimpl.h:
1:57 PM Changeset in webkit [2910] by cblu
  • 11 edits in trunk/WebKit

Fixed:
3112477 - REGRESSION: dropping image within window loads image in current window
Fix: Unregister the parent webview for dragging when the drag starts, reregister after the drag ends.

3116423 - Dragged images sometimes have the wrong promised-file file type
Fix: Make the - [NSView_web_dragPromisedImage...] method take a file type rather than deriving the file type from the URL

3115768 - REGRESSION: contextual menu item "copy url to clipboard" doesn't work
Fix: In [NSPastboard _web_writeURL:andTitle:withOwner:] adding pboard types doesn't work for the general pasteboard, have to redeclare.

3116594 - Image on the drag pasteboard shouldn't have applied transparency and scaling
Fix: In - [NSView_web_dragPromisedImage...] put the original image on the pboard

Reviewed by John.

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): don't use addTypes as it doesn't work as I expected
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:origin:URL:fileType:title:event:]): put the original image on the pboard, not the drag image
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): (-[WebHTMLView mouseDragged:]): call _web_dragPromisedImage (-[WebHTMLView draggedImage:endedAt:operation:]): call -[WebView _reregisterDraggedTypes]
  • WebView.subproj/WebImageView.m: (-[WebImageView mouseDragged:]): call _web_dragPromisedImage (-[WebImageView draggedImage:endedAt:operation:]): call -[WebView _reregisterDraggedTypes]
  • WebView.subproj/WebView.m: (-[WebView initWithFrame:]): call _reregisterDraggedTypes (-[WebView draggingEntered:]): simplified, don't need to check drag source
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _reregisterDraggedTypes]):
1:50 PM Changeset in webkit [2909] by hyatt
  • 4 edits in trunk/WebCore

Fix link feedback regression on aintitcool.com. Observe
the wacky feedback we give now (yes, it matches MacIE and
Gecko). Gotta love this malformed page.

<a><h4>...</h4></a>

r=mjs

  • khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
1:36 PM Changeset in webkit [2908] by darin
  • 3 edits in trunk/WebKit
  • fixed 3114796 -- WORLD LEAKS: 1 WebFrame leaked on trivial source file with <html> tag only (probably fixed a ton of other bugs too, since this always leaks)

Reviewed by Chris.

  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Added a missing autorelease.
1:18 PM Changeset in webkit [2907] by darin
  • 5 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej.

  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit:

Reviewed by Maciej.

  • WebView.subproj/WebView.m: Fixed a pair of strings that conflict.
  • English.lproj/Localizable.strings: Regenerated.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
1:11 PM Changeset in webkit [2906] by hyatt
  • 12 edits in trunk/WebCore

Eliminate the KONQBLOCK hack. Fixes ipodhacks.com (a mislayout
caused by malformed html... <table><br>...)

r=mjs

  • khtml/css/html4.css:
  • khtml/html/dtd.cpp: (DOM::checkChild):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isInline):
  • khtml/html/htmlparser.cpp: (KHTMLParser::reset): (KHTMLParser::insertNode):
  • khtml/html/htmlparser.h:
  • khtml/misc/htmltags.c: (hash_tag): (findTag):
  • khtml/misc/htmltags.h:
  • khtml/misc/htmltags.in:
  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

Dec 2, 2002:

3:17 PM Changeset in webkit [2905] by hyatt
  • 8 edits in trunk/WebCore

Fix for 3032557, wsj.com DHTML elements in the wrong position.
This patch adds support for img.x and img.y (a Mozilla extension
from NS4 days), which is used by the site to position the menus.

r=kocienda on the patch.

  • khtml/dom/html_image.cpp: (HTMLImageElement::x): (HTMLImageElement::y):
  • khtml/dom/html_image.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_html.lut.h:
2:00 PM Changeset in webkit [2904] by hyatt
  • 4 edits in trunk/WebCore

Undo my changes to margin collapsing for blocks inside inlines.
Although they may be correct in a strict mode, they don't
work with the real-world Web. For now, I'm just backing out
the code. The CSS WG hasn't decided how this should work yet
anyway, so I'll just let the quirk behavior be our behavior
in both modes.

This fixes aintitcool.com.

  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):
9:59 AM Changeset in webkit [2903] by trey
  • 10 edits in trunk/WebKit

WebKit:

Refined bookmark notifications to be more detailed. We now have added, removed,
willChange and didChange.

  • Bookmarks.subproj/WebBookmarkGroup.h: New API.
  • Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _sendNotification:forBookmark:children:]): (-[WebBookmarkGroup _setTopBookmark:]): (-[WebBookmarkGroup _bookmarkWillChange:]): (-[WebBookmarkGroup _bookmarkDidChange:]): (-[WebBookmarkGroup _bookmarkChildren:wereAddedToParent:]): (-[WebBookmarkGroup _bookmarkChildren:wereRemovedToParent:]): All just small pieces of flow control for posting the notes.
  • Bookmarks.subproj/WebBookmarkGroupPrivate.h: Internal methods for posting the notes.
  • Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf setTitle:]): Post da note (-[WebBookmarkLeaf setURLString:]): Post da note (-[WebBookmarkLeaf description]): Added for debugging.
  • Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList setTitle:]): Post da note (-[WebBookmarkList removeChild:]): Post da note (-[WebBookmarkList insertChild:atIndex:]): Post da note
  • Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy setTitle:]): Post da note
  • English.lproj/StringsNotToBeLocalized.txt: New strings.
  • WebKit.exp: New strings.

WebBrowser:

The auto-complete DB properly tracks HistoryItems and Bookmarks coming and going.
We have only one DB entry for a given URL, with a ref count. HistoryItems replace
Bookmarks in the DB, so we have a well-defined place to keep stats like visitCount
or recent times accessed.

  • BookmarksController.m: (-[BookmarksController awakeFromNib]): Adopt new API for bookmark notifications.
  • BookmarksViewController.m: Adopt new API for bookmark notifications.
  • CompletionController.m: (+[CompletionController _tree_create]): Set refCount of root node. (_keyStringFromItem): Nuke redundant code. (_keyStringFromNode): Deleted nodes must retain their key string to function properly in the DB. (_findPotentialNode): Test for deleted nodes using new bit. (+[CompletionController _tree_addItem:]): New rules for handing a collision on add. Bump ref count, replace Bookmarks with HistoryItems. (+[CompletionController _tree_deleteItem:]): Obey refcounting. (+[CompletionController _tree_nextItemUsingCursor:]): Test for deleted nodes using new bit. (DumpAutoCompleteTree): Debugging nit. (+[CompletionController _removeBookmarkTree:]): New utility routine. (+[CompletionController _loadDB]): Debugging nits. (-[CompletionController _executeQuery]): Bandaid fix for user typing "www.". (+[CompletionController _registerForNotifications]): Register for bookmark notes. (+[CompletionController _bookmarksAdded:]): Receive bookmark note. (+[CompletionController _bookmarksRemoved:]): Receive bookmark note. (+[CompletionController _bookmarkWillChange:]): Receive bookmark note. (+[CompletionController _bookmarkDidChange:]): Receive bookmark note. (-[CompletionController _positionWindow]): Small code rearranging.
5:40 AM Changeset in webkit [2902] by mjs
  • 12 edits in trunk/WebKit

WebKit:

  • added original URL field to action dictionary so that policy delegates can avoid prompting over and over on redirects.
  • WebKit.exp:
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPolicyDelegate.m:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]): (-[WebFrame _addExtraFieldsToRequest:]): (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):

WebBrowser:

  • fixed 3109894 - Insecure form warning prompts twice
  • BrowserWebController.m: (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):

Dec 1, 2002:

5:32 PM Changeset in webkit [2901] by hyatt
  • 5 edits in trunk/WebCore

Convert the WebCore cache from LRU to size-adjusted and
popularity-aware LRU (LRU-SP). With the improved cache,
the size restriction on images can be relaxed back to 40K
(from 16K) while retaining the same score on cvs-base.
This should result in better real-world performance.

  • khtml/misc/loader.cpp: (CachedObject::ref): (CachedObject::setSize): (m_tail): (LRUList::~LRUList): (Cache::flush): (FastLog2): (Cache::getLRUListFor): (Cache::removeFromLRUList): (Cache::insertInLRUList): (Cache::adjustSize):
  • khtml/misc/loader.h:

Nov 29, 2002:

8:20 PM Changeset in webkit [2900] by gramps
  • 4 edits in trunk/WebCore
  • khtml/css/html4.css:

Finally tweak headline font sizes and margins to match Gecko and CSS
standard:

  • increase H1 font-size from 1.7em to 2em
  • increase H2 font-size from 1.4em to 1.5em
  • make H2 top and bottom margin match (bottom was strangely .87em)
  • increase H4 margin from 1.0em to 1.33em
Note: See TracTimeline for information about the timeline view.