Context Navigation

← Previous Period
Next Period →

Timeline

Dec 7, 2002:

6:06 PM Changeset in webkit [2967] by hyatt

5 edits in trunk/WebCore

This change fixes three bugs in list items.

(1) Stop implementing markers as floats. This is simply
wrong. The bullet doesn't affect the height of the line
box if it's a float, and it can also affect other
list items that follow the bullet's enclosing list item
(leading to odd staggered layout of lists).

(2) Relax the DTD. It was trying to obey strict HTML, which
is hopeless in the case of lists. Match the behavior of
both Gecko and the IEs (mac and win32) and allow non-list
content to be inserted between list items without being
wrapped in its own list item. Lists were making empty
items for whitespace in between items, and this stops that
and makes our lists behave much more like Gecko and the IEs.

(3) The bullet's min and max width weren't getting set, which
could lead to confused line width calculations when image
bullets were used.

Reviewed by: gramps

ChangeLog:
khtml/html/dtd.cpp: (DOM::checkChild):
khtml/rendering/bidi.cpp: (RenderFlow::findNextLineBreak):
khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListMarker::calcMinMaxWidth):

5:03 PM Changeset in webkit [2966] by kocienda

3 edits in trunk/WebCore

Tests:

Reviewed by: Maciej

Fix for this bug:

Radar 3073988 (URLs with /../ are not resolved before being sent to the host)

TestURLs.h: Added some new test URLs. Added a new TestAbsoluteURLsWithRelativePortions array.
WebFoundation-Misc/ifnsurlextensions-test.chk: Updated for changed behavior.
kde/Makefile.am: Added new kurl-relative-test.
kde/kurl-relative-test.chk: Added.
kde/kurl-relative-test.cpp: Added.
kde/kurl-test.chk: Updated for changed behavior.

WebFoundation:

Reviewed by: Maciej

Fix for this bug:

Radar 3073988 (URLs with /../ are not resolved before being sent to the host)

Misc.subproj/WebNSURLExtras.m: (pathRemovingDots): New code that was adapted from KURL relative URL resolution code. (-[NSURL _web_URLComponents]): Call new pathRemovingDots function where needed.

WebCore:

Reviewed by: Maciej

Fix for this bug:

Radar 3073988 (URLs with /../ are not resolved before being sent to the host)

kwq/KWQKURL.mm: (KURL::KURL): (copyPathRemovingDots): New function containing code that was pulled out of the existing relative URL resolution code. (KURL::parse): Call new copyPathRemovingDots function instead of doing same work inline.

Dec 6, 2002:

6:21 PM Changeset in webkit [2965] by hyatt

8 edits in trunk/WebCore

Sigh. I forgot to commit the first layer fix (that has already
been reviewed), so now this is also including that.

The first layer fix was to deal with the yale.edu crasher.
It involved making sure that append/remove of render object
trees drill down into those trees to remove/append corresponding
layers (instead of just checking the root of the trees).

The second fix involves making sure that cliprects are right
for painting backgrounds and borders of clipped objects.
Fixes benoit's bug.

Reviewed by: mjs and darin (fix 1), mjs and gramps (fix 2)

khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
khtml/rendering/render_container.h:
khtml/rendering/render_layer.cpp: (RenderLayer::paint): (RenderLayer::constructZTree):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.cpp: (RenderObject::appendLayers): (RenderObject::removeLayers): (RenderObject::enclosingLayer):
khtml/rendering/render_object.h:

5:50 PM Changeset in webkit [2964] by trey

2 edits in trunk/WebKit

WebKit:

Clean up some printfs. Use WebKitLogPageCache for page cache info.

Reviewed by: rjw

WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _purgePageCache]): (-[WebFrame _setState:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):

WebBrowser:

Clean up some printfs. Use WebKitLogPageCache for page cache info.

Reviewed by: rjw, co-conspirator

Debug/DebugUtilities.m: (-[BrowserDocument toggleBackForwardEnabled:]):

5:18 PM Changeset in webkit [2963] by trey

6 edits in trunk/WebKit

WebKit:

3118584 - implement desired behavior for load - reload - b/f
3119241 - page cache needs to be refreshed after reload
3118096 - isTargetItem:NO saved to disk with every bookmark

The most noticeable changes are the addition of the "Same" loadType, and that reload
does not restore form state. 3119241 was noticed in passing, and is related.
3118096 is a nit with a possible small perf benefit.

Reviewed by: rjw

History.subproj/WebHistoryItem.h:
History.subproj/WebHistoryItem.m: (-[WebHistoryItem dealloc]): New originalURL field. (-[WebHistoryItem originalURL]): New getter. (-[WebHistoryItem setOriginalURL:]): New setter. (-[WebHistoryItem dictionaryRepresentation]): Dont save isTarget. (-[WebHistoryItem initFromDictionaryRepresentation:]): Dont save isTarget.
WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): Test for going to same URL, invoke loadTypeSame case.
WebView.subproj/WebFramePrivate.h: Add loadTypeSame
WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): Remove a line of dead code. (-[WebFrame _createItem]): Set originalURL when item is created. (-[WebFrame _transitionToCommitted:]): For loadTypeSame, clear page cache (-[WebFrame _purgePageCache]): Added logging. (-[WebFrame _setState:]): Don't add to page cache if doing a reload. (-[WebFrame _isLoadComplete]): LoadTypeSame is a NOP. (-[WebFrame _loadItem:fromItem:withLoadType:]): LoadTypeSame is an ASSERT. (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): In the LoadTypeSame case load from origin and never do anchor nav. If asked to load the same URL, invoke LoadTypeSame case. (-[WebFrame _loadURL:intoChild:]): Latent bug: WebFrameLoadTypeReloadAllowingStaleData should restore child frame content like reload does. (-[WebFrame _itemForRestoringDocState]): Prevent form state restore on reload and loadSame. (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): New utility function.

WebBrowser:

3118584 - implement desired behavior for load - reload - b/f
3119029 - assert if you control click on back button when it's enabled only to leave bookmarks view

The app no longer has a test in it to turn a standard nav into a reload. WK does it.

The bug was a result of the special case of the back button as a way to get out
of bookmarks view to the web view. The back menu basically has to play the same game.

Reviewed by: rjw, john sullivan (respectively)

BrowserDocument.m: (-[BrowserDocument goToRequest:]): Remove test, let WK sort out when to reload. (-[BrowserDocument goToItem:]): Special case if in bookmarks view. Go back to web view mode. (-[BrowserDocument backListMenuForButton:]): Special case if in bookmarks view. Add current item to menu.
BrowserWindowController.h: Export a couple existing methods.

4:27 PM Changeset in webkit [2962] by mjs

10 edits in trunk/WebCore

Reviewed by: Darin

fixed 3077227 - netflix "top 100" page JavaScript runs so slowly, it seems like a hang

I fixed this by adding hash tables of image and form elements by
name and id. This allows scans of the whole document to be avoided
in many cases.

This also results in a small speedup (~1%) on cvs-js-ibench.

khtml/dom/html_document.cpp:
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasProperty): (KJS::HTMLDocument::tryGet):
khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::addNamedImageOrForm): (HTMLDocumentImpl::removeNamedImageOrForm): (HTMLDocumentImpl::haveNamedImageOrForm):
khtml/html/html_documentimpl.h:
khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::attach): (HTMLFormElementImpl::detach): (HTMLFormElementImpl::parseAttribute):
khtml/html/html_formimpl.h:
khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseAttribute): (HTMLImageElementImpl::attach): (HTMLImageElementImpl::detach):
khtml/html/html_imageimpl.h:

3:05 PM Changeset in webkit [2961] by hyatt

4 edits in trunk/WebCore

Hack to make i-bench paint every fourth page. We can tune
this # as needed.

Reviewed by: darin

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):
khtml/rendering/render_flow.h:

12:07 PM Changeset in webkit [2960] by darin

4 edits in trunk/WebCore

Reviewed by Trey.

Update to latest character-sets document.

kwq/character-sets.txt: Got the newest one and merged in our change.
kwq/KWQCharsetData.c: Regenerated this. Added just one character set name.

10:05 AM Changeset in webkit [2959] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

khtml/ecma/kjs_events.h: Add listenerObjImp() method so we don't have to ref/unref for speed-critical uses.

khtml/ecma/kjs_window.cpp: (Window::getJSEventListener): Change this to work with ObjectImp so we don't ref/unref each listener. This should give us some extra speed.

8:35 AM Changeset in webkit [2958] by mjs

8 edits in trunk

JavaScriptCore:

Reviewed by: Darin Adler

made framework embedding work correctly with buildit

JavaScriptCore.pbproj/project.pbxproj: Give framework a relative install path, don't install it the normal way, and copy it manually to /AppleInternal/Library/Frameworks if installing.

WebFoundation:

Reviewed by: Darin Adler

made framework embedding work correctly with buildit

WebFoundation.pbproj/project.pbxproj: Give framework a relative install path, don't install it the normal way, and copy it manually to /AppleInternal/Library/Frameworks if installing.

WebCore:

Reviewed by: Darin Adler

made framework embedding work correctly with buildit

WebCore.pbproj/project.pbxproj: Give framework a relative install path, don't install it the normal way, and copy it manually to /AppleInternal/Library/Frameworks if installing. Also look for other frameworks in ${DSTROOT}/AppleInternal/Library/Frameworks.

WebKit:

Reviewed by: Darin Adler

made framework embedding work correctly with buildit

WebKit.pbproj/project.pbxproj: Give framework a relative install path, don't install it the normal way, and copy it manually to /AppleInternal/Library/Frameworks if installing. Also look for other frameworks in ${DSTROOT}/AppleInternal/Library/Frameworks.

WebBrowser:

Reviewed by: Darin Adler

made framework embedding work correctly with buildit

copy-frameworks-to-dstroot.sh: Copy frameworks from /AppleInternal/Library/Frameworks
embed-frameworks.sh: Fixed typo.

12:20 AM Changeset in webkit [2957] by darin

5 edits in trunk

WebCore:

Reviewed by Trey.

fixed 3111903 -- crash in DOM::HTMLDocumentImpl::close

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Check for the case where view() is 0 so we don't do a null-dereference. Also, remove some of the unneeded redundant isNull/isEmpty checking here.

WebKit:

Reviewed by Trey.

fixed 3103691 -- assertion in WebHTMLView addMouseMovedObserver at versiontracker

WebView.subproj/WebHTMLView.m: (-[WebHTMLView addMouseMovedObserver]): Instead of asserting, do the checks here to determine if the observer should be installed. (-[WebHTMLView viewDidMoveToWindow]): Remove checks, since addMouseMovedObserver now checks. (-[WebHTMLView windowDidBecomeMain:]): Remove checks, since addMouseMovedObserver now checks.

Dec 5, 2002:

11:03 PM Changeset in webkit [2956] by darin

5 edits in trunk/WebCore

Reviewed by Don.

fixed 3116149 -- REGRESSION: assert on invalid encoding trying to show accuweather.com source

The regression was caused when we updated the View Source window to try to get the encoding right.

kwq/WebCoreBridge.mm: (+[WebCoreBridge stringWithData:textEncoding:]): Make this function decode the string as Windows Latin-1 if the passed-in encoding is invalid or ISO Latin-1, since that's what we always want.

kwq/mac-encodings.txt: Add "8859_1" since we have now seen it "in the wild".
kwq/KWQCharsetData.c: Check in new version of generated file.

8:00 PM Changeset in webkit [2955] by rjw

3 edits in trunk/WebKit

Don't ceil spaces if not a fixed pitch font. This make sites
that have hard coded block widths have less wrapping beyond what the
designer expected. Fixes 3117225.

Reviewed by: mjs

WebCoreSupport.subproj/WebTextRenderer.h:
WebCoreSupport.subproj/WebTextRenderer.m: (widthForGlyph): (-[WebTextRenderer _computeWidthForSpace]): (-[WebTextRenderer initWithFont:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:fontFamilies:]):

6:51 PM Changeset in webkit [2954] by hyatt

3 edits in trunk/WebCore

Fix for javadoc page. It specified an invalid unit, and our
unit match was on a substring, so it allowed "pts" when it
shouldn't. This patch adds some code to help handle this
error case.

Bug # is 3119830.

Reviewed by: rjw

khtml/css/cssparser.cpp: (StyleBaseImpl::parseUnit):

6:35 PM Changeset in webkit [2953] by cblu

13 edits in trunk

WebCore:

Reviewed by: rjw

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedString]): renamed to reflect WebDocument API change (-[WebCoreBridge deselectAll]): added (-[WebCoreBridge elementAtPoint:]): call selectedString

WebKit:

Added WebDocumentText protocol. Made WebHTMLView and WebTextView implement it.

Reviewed by: rjw

WebView.subproj/WebController.m: (-[WebController supportsTextEncoding]): check if protocol is WebDocumentText
WebView.subproj/WebDocument.h:
WebView.subproj/WebHTMLView.h:
WebView.subproj/WebHTMLView.m: (-[WebHTMLView hasSelection]): call selectedString (-[WebHTMLView takeFindStringFromSelection:]): call selectedString (-[WebHTMLView selectAll:]): call selectAll (-[WebHTMLView string]): part of WebDocumentText protocol (-[WebHTMLView attributedString]): part of WebDocumentText protocol (-[WebHTMLView selectedString]): part of WebDocumentText protocol (-[WebHTMLView selectedAttributedString]): part of WebDocumentText protocol (-[WebHTMLView selectAll]): part of WebDocumentText protocol (-[WebHTMLView deselectAll]): part of WebDocumentText protocol
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _writeSelectionToPasteboard:]): call selectedAttributedString
WebView.subproj/WebTextView.h:
WebView.subproj/WebTextView.m: (-[WebTextView string]): part of WebDocumentText protocol (-[WebTextView attributedString]): part of WebDocumentText protocol (-[WebTextView selectedString]): part of WebDocumentText protocol (-[WebTextView selectedAttributedString]): part of WebDocumentText protocol (-[WebTextView selectAll]): part of WebDocumentText protocol (-[WebTextView deselectAll]): part of WebDocumentText protocol

WebBrowser:

Fixed: 3119117 - AppleScript text attribute not implemented

Reviewed by: rjw

BrowserDocument.m: (-[BrowserDocument text]): Create and return a text storage of the document
Scripting.subproj/English.lproj/Alexander.scriptTerminology: fixed typo

5:44 PM Changeset in webkit [2952] by darin

3 edits in trunk/WebKit

Reviewed by Richard.

fixed 3107240 -- world leak: reproducible, trying to open TIFF file

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient notifyDelegatesOfInterruptionByPolicyChange]): Send error to the delegate using receivedError: rather than directly. This results in the frame properly stopping the load and fixes the leak.

4:37 PM Changeset in webkit [2951] by hyatt

3 edits in trunk/WebCore

Fix relative positioned elements to add in the right offset
when repainting themselves.

Reviewed by: darin

khtml/rendering/render_box.cpp: (RenderBox::repaintRectangle):

4:31 PM Changeset in webkit [2950] by darin

6 edits in trunk/WebKit

WebFoundation:

Reviewed by Chris.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit:

Reviewed by Chris.

Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler initWithDataSource:]): Add WebGZipDecoder to the list.

Downloads.subproj/WebGZipDecoder.h: Finished this.
Downloads.subproj/WebGZipDecoder.m: Finished this.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebBrowser:

Reviewed by Chris.

BugReportController.m: Removed obsolete FIXME.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
English.lproj/Localizable.strings: Regenerated this, some string somewhere changed.

4:18 PM Changeset in webkit [2949] by rjw

6 edits in trunk/WebCore

Fixed two issues relating to font sizes. Fixes any page
that specifies font size in device independent units, i.e.
www.abcnews.com.

Change dpi to 72. Mac OS X does appear to assume 72, not 96!
Don't appply DPI adjustments to font selections, instead normalize values to points. OS X takes care of device scaling.

Reviewed by: gramps

khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLengthFloat): (CSSPrimitiveValueImpl::computePointFloat):
khtml/css/css_valueimpl.h:
khtml/css/cssstyleselector.cpp:
kwq/KWQPaintDeviceMetrics.mm: (QPaintDeviceMetrics::logicalDpiY):

3:28 PM Changeset in webkit [2948] by mjs

2 edits in trunk/WebKit

Reviewed by: Darin

English.lproj/InfoPlist.strings: removed letters from CFBundleShortVersionString to make buildit happy.

1:23 PM Changeset in webkit [2947] by hyatt

3 edits in trunk/WebCore

Make sure that blocks with block children compute their
minwidth and maxwidth correctly. This fixes 4-5 bugs on my
list, including the becblog.blogspot.com misrender and
the wrapping list item on webstandards.org.

The fix ensures that the margins of a child have been
computed before they are asked for by the parent in
calcBlockMinMaxWidth.

Also fix a bug in collapsing margins that caused the height
of positioned elements that contained only zero-height children
to not compute their heights correctly. We now pass tests 2
and 3 on the collapsing margin tests with this fix.

Reviewed by: trey

khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::calcBlockMinMaxWidth):

12:41 PM Changeset in webkit [2946]

3 copies in tags/Alexander-35

This commit was manufactured by cvs2svn to create tag 'Alexander-35'.

12:41 PM Changeset in webkit [2945] by sheridan

5 edits in trunk

Alex-35 stamp

9:17 AM Changeset in webkit [2944] by darin

2 edits in trunk/WebKit

Reviewed by Ken.

fixed 3118647 -- REGRESSION: click policy no longer works

WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Allow mouse up events too. Those are usually the ones that trigger navigation.

12:31 AM Changeset in webkit [2943] by hyatt

5 edits in trunk/WebCore

Fix for wsj.com orange underline regression. In quirks mode
only, don't let anchors without hrefs go into :hover. This
matches MacIE's behavior.

The bug is 3118643.

Reviewed by: mjs

khtml/rendering/render_object.cpp: (RenderObject::setHoverAndActive): (RenderObject::nodeAtPoint):
khtml/rendering/render_object.h:
khtml/rendering/render_text.h:

12:23 AM Changeset in webkit [2942] by mjs

4 edits
1 add in trunk/WebCore

Reviewed by: David Hyatt

fixed 3118083 - WebCore includes config.h from Labyrinth top level

Makefile.am: Regenerate config.h from top-level version, but make sure not to alter date if it has not changed.
config.h: Added (autogenerated but checked in for benefit of B&I).
ForwardingHeaders/config.h: Include WebCore copy rather than Labyrinth copy.

Dec 4, 2002:

10:29 PM Changeset in webkit [2941] by darin

2 edits in trunk/WebKit

Reviewed by Maciej.

fixed assert when you choose an item from a menu, for example, and that navigates

WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): If the event is over some other element, just don't include the element info.

7:29 PM Changeset in webkit [2940] by mjs

11 edits in trunk/WebCore

Reviewed by: David Hyatt

fixed 3049601 - support the equivalent of createcontextualfragment(NS6) or insertAdjacentHTML (IE)

fixed 3108065 - DHTML at expedia.com doesn't work-- lack of support for createContextualFragment

fixed 3114627 - DHTML menus used in Yahoo mail don't work-- lack of support for createContextualFragment

improvement towards 3052113 - "site menu" part of .mac home page editing doesn't work

khtml/ecma/kjs_range.h:
khtml/ecma/kjs_range.cpp: (DOMRangeProtoFunc::tryCall): Added suppor for createContextualFragment method.
khtml/ecma/kjs_range.lut.h: Regenerated.
khtml/dom/dom2_range.h:
khtml/dom/dom2_range.cpp: (Range::createContextualFragment): Implemented (calls impl).
khtml/html/html_elementimpl.h:
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Factored out of setInnerHTML. (HTMLElementImpl::setInnerHTML): Call createContextualFragment to make the fragment.
khtml/xml/dom2_rangeimpl.h:
khtml/xml/dom2_rangeimpl.cpp: (RangeImpl::createContextualFragment): Implemented (calls start container element).

6:30 PM Changeset in webkit [2939] by hyatt

4 edits in trunk/WebCore

Fix assert on compuserve page. <form> under <table> should not
get a layout() call.

Reviewed by: gramps

khtml/rendering/render_flow.cpp: (RenderFlow::layout):
khtml/rendering/render_table.cpp: (RenderTable::layout):

5:49 PM Changeset in webkit [2938] by cblu

3 edits in trunk/WebKit

WebKit:

Fixed: 3116294 - Need "Reload" feature in Downloads window

Reviewed by: rjw

WebKit.pbproj/project.pbxproj: made WebFramePrivate.h private so that WebBrowser can call _downloadRequest:toPath:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadDataSource:withLoadType:]): commented out assert that complains about lack of WebView. Long-term solution is to catch this earlier and have a lone datasource download mechanism 3118355.

WebBrowser:

Fixed: 3116294 - Need "Reload" feature in Downloads window

Added new download button art.

Reviewed by: sullivan & darin

DownloadMonitor.h:
DownloadMonitor.m: (-[DownloadMonitor init]): create new dictionary _reloadingDataSourceToEntry that store pointers of dataSources to entries so the download monitor knows which entry started the reload. (-[DownloadMonitor resource:didReceiveResponse:fromDataSource:]): check if this is a reload by checking _reloadingDataSourceToEntry (-[DownloadMonitor setEntry:forReloadingDataSource:]): new, called by the entry to set itself as a reloading downlaod
DownloadProgressEntry.h:
DownloadProgressEntry.m: (-[DownloadProgressEntry _setController:]): new, for when a controller is created for reload (-[DownloadProgressEntry _setDataSource:]): tweak (-[DownloadProgressEntry _setRequest:]): new, need to retain the request so it can be used for reload (-[DownloadProgressEntry _setStartDate:]): new, allows to set the date more then just once (-[DownloadProgressEntry dealloc]): release the request and controller (-[DownloadProgressEntry reload]): make a controller, set it up, start download, reset the entry (-[DownloadProgressEntry setDone:]): release the controller because it won't be needed
DownloadRow.h:
DownloadRow.m: (-[DownloadRow _repositionSubviews]): new, moves widgets around (-[DownloadRow _setButtonAttributes]): new, sets attributes of the button (-[DownloadRow _startProgressAnimation]): simplified, just deal with progress bar (-[DownloadRow _startDiskCopyAnimation]): simplified, just deal with progress bar (-[DownloadRow _stopProgressAnimation]): simplified, just deal with progress bar (-[DownloadRow _updateStage]): call _repositionSubviews and _setButtonAttributes (-[DownloadRow awakeFromNib]): save the origins of the widgets (-[DownloadRow reload:]): call [entry reload]
English.lproj/Localizable.strings:
ResourceProgressEntry.m: (-[ResourceProgressEntry setBytesLoaded:]): remove error, added comment
Resources/Images/Download_Reload.tif: Added.
Resources/Images/Download_ReloadPressed.tif: Added.
Resources/Images/Download_Reveal.tif:
Resources/Images/Download_RevealPressed.tif:
Resources/Images/Download_Stop.tif:
Resources/Images/Download_StopPressed.tif:
WebBrowser.pbproj/project.pbxproj:

5:20 PM Changeset in webkit [2937] by hyatt

19 edits in trunk/WebCore

Fix shroudedisles.com table misalignment by removing more\
bogus rules from html4.css.

Fix forums on macosx.com by implementing support for the align
attribute on the <P> tag.

Implement min-width and max-width for block level floating
and normal flow elements.

Fix event handling so that :hover notifications get through to
objects inside floats.

Reviewed by: rjw

khtml/css/html4.css:
khtml/html/html_blockimpl.cpp: (HTMLParagraphElementImpl::parseAttribute):
khtml/html/html_blockimpl.h:
khtml/rendering/render_box.cpp: (RenderBox::calcWidth): (RenderBox::calcWidthUsing): (RenderBox::calcHeight):
khtml/rendering/render_box.h:
khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::nodeAtPoint):
khtml/rendering/render_flow.h:
khtml/rendering/render_frames.cpp: (RenderFrameSet::nodeAtPoint):
khtml/rendering/render_frames.h:
khtml/rendering/render_image.cpp: (RenderImage::nodeAtPoint):
khtml/rendering/render_image.h:
khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
khtml/rendering/render_object.h:
khtml/rendering/render_root.cpp: (RenderRoot::calcHeight):
khtml/rendering/render_style.cpp: (StyleBoxData::StyleBoxData):
khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):
khtml/rendering/render_text.h:

4:19 PM Changeset in webkit [2936] by trey

2 edits in trunk/WebKit

3097585 - Crash in -[WebFrame(WebPrivate) _isLoadComplete] at result of google image search

The root of this problem was that we would detach child frames by calling detach
on them all, then clearing the whole array. This would fail because detaching a
frame might have to stop a load, which calls checkLoadComplete, which visits the
entire frame tree. But if a previously detached child is still sitting in that
tree, we end up with an assertion failure. The solution is to remove the kids as
they are detached.

Reviewed by: Darin Adler

WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem]): Method rename (a nit I missed from an earlier change) (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Method rename (-[WebFrame _detachChildren]): new method to do detaching right (-[WebFrame _detachFromParent]): call new method (-[WebFrame _setDataSource:]): call new method (-[WebFrame _transitionToCommitted:]): Method rename

4:12 PM Changeset in webkit [2935] by mjs

6 edits in trunk/JavaScriptCore

Reviewed by: Richard Williamson

Added explicit lock/unlock methods so Sherlock can grab the
interpreter lock as needed.

partially addressed 3084320 - JavaScriptCore crash

kjs/internal.cpp: (InterpreterImp::InterpreterImp): (InterpreterImp::lock): (InterpreterImp::unlock):
kjs/internal.h:
kjs/interpreter.cpp: (Interpreter::lock): (Interpreter::unlock):
kjs/interpreter.h:

2:04 PM Changeset in webkit [2934] by mjs

2 edits in trunk/JavaScriptCore

Added missing reviewer.

1:57 PM Changeset in webkit [2933] by mjs

10 edits
5 adds
18 deletes in trunk/JavaScriptCore

Reviewed by: NOBODY (OOPS!)

Set things up so JavaScriptCore builds in PCRE and uses it for
regular expressions. This fixes many form validation bugs:

fixed 3103197 - javascript at fidelity.com rejects valid input
fixed 2942552 - form validation at weather.com fails
fixed 3079752 - js always reports textarea is empty
fixed 3079719 - covad.com "check availalbility" fails

Makefile.am: Add pcre subdir.
kjs/config.h: define HAVE_PCREPOSIX to true.
kjs/regexp.h: Don't include pcreposix.h since nothing from there is used.
pcre/.cvsignore: Added.
pcre/ChangeLog: Removed.
pcre/INSTALL: Removed.
pcre/Makefile.am: Added.
pcre/Makefile.in: Removed.
pcre/NEWS: Removed.
pcre/NON-UNIX-USE: Removed.
pcre/README: Removed.
pcre/chartables.c: Added.
pcre/config.guess: Removed.
pcre/config.in: Removed.
pcre/config.sub: Removed.
pcre/configure: Removed.
pcre/configure.in: Removed.
pcre/dll.mk: Removed.
pcre/doc/Tech.Notes: Removed.
pcre/doc/pcre.3: Removed.
pcre/doc/pcre.html: Removed.
pcre/doc/pcre.txt: Removed.
pcre/doc/pcregrep.1: Removed.
pcre/doc/pcregrep.html: Removed.
pcre/doc/pcregrep.txt: Removed.
pcre/doc/pcreposix.3: Removed.
pcre/doc/pcreposix.html: Removed.
pcre/doc/pcreposix.txt: Removed.
pcre/doc/pcretest.1: Removed.
pcre/doc/pcretest.html: Removed.
pcre/doc/pcretest.txt: Removed.
pcre/doc/perltest.txt: Removed.
pcre/install-sh: Removed.
pcre/ltmain.sh: Removed.
pcre/pcre-config.h: Added.
pcre/pcre-config.in: Removed.
pcre/internal.h: Include pcre-config.h instead of config.h
pcre/pcre.c: (ord2utf8): Fix warnings. (pcre_compile): Fix warnings.
pcre/pcre.def: Removed.
pcre/pcre.h: Added.
pcre/pcre.in: Removed.
JavaScriptCore.pbproj/project.pbxproj: Added pcre files to build.
JavaScriptCorePrefix.h: Guard c++ headers with #ifdef cplusplus.

1:47 PM Changeset in webkit [2932] by darin

14 edits
2 adds in trunk

WebCore:

Reviewed by Trey and Maciej.

fixed 3117558 -- Assertion failure in KWQKHTMLPart::slotData after typing "amazon.com" twice
got rid of the per-part NSEvent in preparation for NSView mouse event handling going through WebCore

khtml/khtml_part.h: Added declaration for didOpenURL.
khtml/khtml_part.cpp: (KHTMLPart::openURL): Changed name to didOpenURL in the APPLE_CHANGES version because calls to openURL from within KHTML need to make the round trip to WebKit. Also disabled the "scroll to anchor" part.

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::isFrameSet): Fix to return false when document is 0.

kwq/KWQKHTMLPart.h: Add scrollToAnchor, remove setCurrentEvent and _currentEvent
kwq/KWQKHTMLPart.mm: (KHTMLPart::openURL): Pass the openURL call to the KWQKHTMLPart. (KWQKHTMLPart::KWQKHTMLPart): Don't initialize _currentEvent. (KWQKHTMLPart::~KWQKHTMLPart): Don't release _currentEvent. (KWQKHTMLPart::submitForm): Pass [NSApp currentEvent] instead of _currentEvent. (KWQKHTMLPart::urlSelected): Pass [NSApp currentEvent] instead of _currentEvent. (KWQKHTMLPart::scrollToAnchor): Added. Contains the code from the anchor case inside KHTMLPart::openURL.

kwq/WebCoreBridge.h: Added scrollToAnchorWithURL:.
kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:headers:lastModified:pageCache:]): Change around so that we don't do a bunch of irrelevant stuff in the page cache case. I think we might just want to make a separate method for the page cache case. (-[WebCoreBridge scrollToAnchorWithURL:]): Added. (-[WebCoreBridge mouseUp:]): Simplify check for nil view. Remove calls to setCurrentEvent. (-[WebCoreBridge mouseDown:]): Simplify check for nil view. Fix event type constants for right mouse button and other mouse button. (-[WebCoreBridge mouseMoved:]): Simplify check for nil view. (-[WebCoreBridge mouseDragged:]): Simplify check for nil view.

WebKit:

Reviewed by Trey and Maciej.

fixed 3117558 -- Assertion failure in KWQKHTMLPart::slotData after typing "amazon.com" twice
update NSEvent handling in preparation for NSView mouse event handling going through WebCore

WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:fromItem:withLoadType:]): Added FIXME comments about matching the _loadURL case more closely. (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Only use the event if it's a mouse down event. This prevents trouble when we have other kinds of events coming through. (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Call the new scrollToAnchorWithURL: instead of openURL:. This fixes the assertion failure in the bug above. (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Update checks here to more closely match the ones in KHTMLPart::openURL that we are replacing. Add more comments.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): Function to intercept all clicks at the WebHTMLView level, disabled for now because we are not yet ready.

started a gzip download decoder, not yet hooked up

Downloads.subproj/WebGZipDecoder.h: Added.
Downloads.subproj/WebGZipDecoder.m: Added.
WebKit.pbproj/project.pbxproj: Add WebGZipDecoder and zlib.

other changes

Panels.subproj/WebAuthenticationPanel.m: Fixed screwed-up indentation.

11:01 AM Changeset in webkit [2931] by rjw

12 edits in trunk

WebCore

Cache the NSFont in QFont after doing family based lookup.
Use that cached font to find a text renderer.

Reviewed by: Darin

kwq/KWQFont.h:
kwq/KWQFont.mm: (QFont::QFont): (QFont::~QFont): (QFont::setFamily): (QFont::setFirstFamily): (QFont::setPixelSize): (QFont::setWeight): (QFont::setItalic): (QFont::getNSFont):
kwq/KWQFontMetrics.mm:
kwq/KWQPainter.mm: (QPainter::_updateRenderer):
kwq/WebCoreTextRendererFactory.h:
kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory rendererWithFont:]):

WebKit

Cache the fallback font in the same way we cache other
fonts.

Reviewed by: Darin

WebCoreSupport.subproj/WebTextRendererFactory.h:
WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fallbackFontWithTraits:size:]): (-[WebTextRendererFactory fontWithFamilies:traits:size:]): (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]):

2:34 AM Changeset in webkit [2930] by rjw

7 edits in trunk

WebCore

Cache the last used text renderer to avoid expensive lookup
when font hasn't changed.

Reviewed by: maciej

khtml/rendering/render_flow.cpp: (RenderFlow::layout):
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::_updateRenderer): (QPainter::drawText): (QPainter::drawUnderlineForText):

WebKit

Fixed massive performance regression.
We were leaking WebFontCacheKey.
Added a cache of missing fonts to avoid
expensive appkit lookup.

Reviewed by: Maciej

WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]): (-[WebTextRendererFactory cachedFontFromFamilies:traits:size:]):

1:22 AM Changeset in webkit [2929]

1 copy
15 deletes in tags/PCRE_3_9

This commit was manufactured by cvs2svn to create tag 'PCRE_3_9'.

1:22 AM Changeset in webkit [2928]

1 copy
42 deletes in tags/PCRE-6-1-anchor

This commit was manufactured by cvs2svn to create tag
'PCRE-6-1-anchor'.

1:22 AM Changeset in webkit [2927] by mjs

2 edits
28 adds in trunk/JavaScriptCore

top level:

Reviewed by: Richard Williamson

pcre/doc/*: Added.
pcre/testdata/*: Added.

pcre:

(i) Added long-form option names like gnu grep.
(ii) Added --help to list all options with an explanatory phrase.
(iii) Added -r, --recursive to recurse into sub-directories.
(iv) Added -f, --file to read patterns from a file.

Dec 3, 2002:

11:19 PM Changeset in webkit [2926] by mjs

2 edits
36 adds in trunk/JavaScriptCore

Reviewed by: Darin Adler

imported PCRE 3.9 into the tree; this isn't actually compiled or used yet.

pcre/*: Added.

11:07 PM Changeset in webkit [2925] by darin

2 edits in trunk/WebKit

fixed 3117193 -- REGRESSION: Hang on Hixie's weblog

Reviewed by Maciej.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer substituteFontForString:families:]): Do the operation on the whole string at once instead of a character at a time. I decided to do this rather than correct the bug in the character-at-a-time version.

9:50 PM Changeset in webkit [2924] by mjs

5 edits in trunk

Rolled over all the ChangeLogs to ChangeLog-2002-12-03's in the hopes
of speeding up checkouts and checkins.

9:18 PM Changeset in webkit [2923] by trey

4 edits in trunk/WebKit

Re-fix of 3113393 - Clients side redirects shouldn't always add item to back/forward list
Fix 3116980 - REGRESSION: Back button goes back twice
Fix 3099631 - assertion failure at http://www.calendarlive.com/ when pop-up blocking is off

The earlier fix for the first bug was to consider any redirect happening within one
second as a continuation of the previous load. To fix the regressions I re-cast that
fix using a similar, pre-existing mechanism.

Reviewed by: Richwill

WebView.subproj/WebFramePrivate.h: Nuke shortRedirectComing, rename instantRedirectComing to quickRedirectComing.
WebView.subproj/WebFramePrivate.m: (-[WebFrame _createOrUpdateItem]): Remove code related to shortRedirectComing, the fix that brought the regressions. (-[WebFrame _setState:]): Don't cache the page we're leaving if we're doing a redirect (since we don't want the redirecting page in the cache). (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Above rename. (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Above rename. (-[WebFrame _loadURL:intoChild:]): Comment fix. (-[WebFrame _clientRedirectedTo:delay:fireDate:]): Use 1 second instead of 0 seconds as the metric of a client redirect. Do not consider whether the frame state is completed as part of the decision. (-[WebFrame _clientRedirectCancelled]): Above rename.

8:52 PM Changeset in webkit [2922] by sullivan

3 edits in trunk/WebKit

WebKit:

Reviewed by: Darin

REALLY changed the default state for block pop-ups to be off.

WebView.subproj/WebPreferences.m: (+[WebPreferences load]): change default for letting JavaScript open windows automatically to YES

WebBrowser:

Reviewed by: Darin

Deleted old unused preference keys, one of which was tricking me into thinking that block pop-ups was correctly set when it wasn't (the real setting is in WebKit)

Defaults.plist:
PreferenceKeys.h: deleted things that aren't used anywhere

8:39 PM Changeset in webkit [2921] by darin

5 edits in trunk/WebKit

fixed 3117135 -- world leak: drag any image, get a leak of 1 WebFrame

Reviewed by John.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Retain the URL of the dragged image, not the entire element dictionary. The element dictionary creates a reference cycle since it includes a reference to the WebFrame. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use the URL rather than extracting it from the dictionary with a WebElementImageURLKey.

WebView.subproj/WebHTMLViewPrivate.h: URL, not element dictionary.
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): Release the URL, not the element dictionary.

7:25 PM Changeset in webkit [2920] by hyatt

4 edits in trunk/WebCore

Fix for 3078227, hanging in table code. Make sure <form>s
don't get wrapped in anonymous rows and cells.

Reviewed by: rjw

khtml/rendering/render_table.cpp: (RenderTable::addChild): (RenderTableSection::addChild): (RenderTableRow::addChild):

7:10 PM Changeset in webkit [2919] by rjw

5 edits in trunk/WebKit

Added a preference to change the page cache size, i.e.:
Alexander.app/Contents/MacOS/Alexander -WebKitPageCacheSizePreferenceKey 4

Reviewed by: hyatt

History.subproj/WebBackForwardList.m: (+[WebBackForwardList setPageCacheSize:]): (+[WebBackForwardList pageCacheSize]):
WebView.subproj/WebPreferences.m: (+[WebPreferences load]): (-[WebPreferences _initialTimedLayoutSize]): (-[WebPreferences _pageCacheSize]):
WebView.subproj/WebPreferencesPrivate.h:

6:43 PM Changeset in webkit [2918] by hyatt

4 edits in trunk/WebCore

Backing out a file that I did not intend to check in.

khtml/misc/loader.cpp:

6:14 PM Changeset in webkit [2917] by rjw

4 edits in trunk/WebCore

D'oh. Fixed last minute change that broke the build.

kwq/KWQFont.mm: (QFont::getNSFont):

6:05 PM Changeset in webkit [2916] by hyatt

8 edits in trunk/WebCore

Remove the moveWidgetsAside function. This fixes all the
form controls on livepage.apple.com that were getting hosed
by the scrolling marquee.

Reviewed by: darin

khtml/html/html_tableimpl.cpp: (HTMLTableRowElementImpl::addChild):
khtml/misc/loader.cpp:
khtml/rendering/render_root.cpp: (RenderRoot::layout):
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::paint):

5:56 PM Changeset in webkit [2915] by rjw

19 edits in trunk

Fixed 3019986. Use an array of font families instead of a single
font family to support CSS family lists.
r=hyatt

Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthForString:font:]):
Misc.subproj/WebStringTruncator.m: (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
WebCoreSupport.subproj/WebTextRenderer.h:
WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer substituteFontForString:families:]): (-[WebTextRenderer substituteFontForCharacters:length:families:]): (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:fontFamilies:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:fontFamilies:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:fontFamilies:]):
WebCoreSupport.subproj/WebTextRendererFactory.h:
WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamilies:traits:size:]): (-[WebTextRendererFactory fontWithFamily:traits:size:]): (+[WebTextRendererFactory fallbackFontWithTraits:size:]): (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]): (-[WebTextRendererFactory cachedFontFromFamilies:traits:size:]): (-[WebTextRendererFactory rendererWithFamilies:traits:size:]):

Fixed 3019986. Use an array of font families instead of a single
font family to support CSS family lists.
r=hyatt

kwq/KWQFont.h:
kwq/KWQFont.mm: (QFont::getNSFont):
kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawUnderlineForText):
kwq/WebCoreTextRenderer.h:
kwq/WebCoreTextRendererFactory.h:
kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory rendererWithFamilies:traits:size:]): (-[WebCoreTextRendererFactory fontWithFamilies:traits:size:]):

4:21 PM Changeset in webkit [2914] by cblu

3 edits in trunk/WebKit

Fixed: 3115073 - REGRESSION: plants.com is crashing in WebIconDB with bad retain count

The plants.com favicon was marked to be removed from disk and thus it had no retain count. The problem was that it was still on disk and _hasIconForIconURL would return YES. If hasIconForIconURL returns YES, its is ok to call _setIconURL:forSiteURL:. Since there was no retain count, the assert in _setIconURL:forSiteURL: would be hit.

We now consider icons without retain counts to not exist even if they're on disk.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _setIconURL:forSiteURL:]):

3:20 PM Changeset in webkit [2913] by mjs

4 edits in trunk/JavaScriptCore

Reviewed by: Darin Adler

fixed Deployment build.

kjs/dtoa.cpp: Work around warnings.

2:51 PM Changeset in webkit [2912] by mjs

5 edits
2 adds in trunk/JavaScriptCore

fixed 3114790 - Gamespot reviews pages badly mis-rendering because floating point numbers format wide

Reviewed by: David Hyatt

kjs/dtoa.cpp: Imported float <--> string conversion routines from David M. Gay. I changed this to fix warnings and avoid colliding with names of standard library functions.
kjs/dtoa.h: Added a header I made up for dtoa.cpp
kjs/ustring.cpp: (UString::from): Use new double to string routine (kjs_strtod). (UString::toDouble): Use new string to double routine (kjs_dtoa).
JavaScriptCore.pbproj/project.pbxproj: Added new files

2:46 PM Changeset in webkit [2911] by hyatt

6 edits in trunk/WebCore

Fix for 3112599, aol.com shopping page doesn't work. Apply
the same form demotion trick to <tr> that I did already for
<tbody> and <table>.

r=gramps

khtml/html/dtd.cpp: (DOM::checkChild):
khtml/html/html_tableimpl.cpp: (HTMLTableRowElementImpl::addChild):
khtml/html/html_tableimpl.h:

1:57 PM Changeset in webkit [2910] by cblu

11 edits in trunk/WebKit

Fixed:
3112477 - REGRESSION: dropping image within window loads image in current window
Fix: Unregister the parent webview for dragging when the drag starts, reregister after the drag ends.

3116423 - Dragged images sometimes have the wrong promised-file file type
Fix: Make the - [NSView_web_dragPromisedImage...] method take a file type rather than deriving the file type from the URL

3115768 - REGRESSION: contextual menu item "copy url to clipboard" doesn't work
Fix: In [NSPastboard _web_writeURL:andTitle:withOwner:] adding pboard types doesn't work for the general pasteboard, have to redeclare.

3116594 - Image on the drag pasteboard shouldn't have applied transparency and scaling
Fix: In - [NSView_web_dragPromisedImage...] put the original image on the pboard

Reviewed by John.

Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): don't use addTypes as it doesn't work as I expected
Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:origin:URL:fileType:title:event:]): put the original image on the pboard, not the drag image
WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): (-[WebHTMLView mouseDragged:]): call _web_dragPromisedImage (-[WebHTMLView draggedImage:endedAt:operation:]): call -[WebView _reregisterDraggedTypes]
WebView.subproj/WebImageView.m: (-[WebImageView mouseDragged:]): call _web_dragPromisedImage (-[WebImageView draggedImage:endedAt:operation:]): call -[WebView _reregisterDraggedTypes]
WebView.subproj/WebView.m: (-[WebView initWithFrame:]): call _reregisterDraggedTypes (-[WebView draggingEntered:]): simplified, don't need to check drag source
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _reregisterDraggedTypes]):

1:50 PM Changeset in webkit [2909] by hyatt

4 edits in trunk/WebCore

Fix link feedback regression on aintitcool.com. Observe
the wacky feedback we give now (yes, it matches MacIE and
Gecko). Gotta love this malformed page.

<a><h4>...</h4></a>

r=mjs

khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):

1:36 PM Changeset in webkit [2908] by darin

3 edits in trunk/WebKit

fixed 3114796 -- WORLD LEAKS: 1 WebFrame leaked on trivial source file with <html> tag only (probably fixed a ton of other bugs too, since this always leaks)

Reviewed by Chris.

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Added a missing autorelease.

1:18 PM Changeset in webkit [2907] by darin

5 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit:

Reviewed by Maciej.

WebView.subproj/WebView.m: Fixed a pair of strings that conflict.
English.lproj/Localizable.strings: Regenerated.
English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

1:11 PM Changeset in webkit [2906] by hyatt

12 edits in trunk/WebCore

Eliminate the KONQBLOCK hack. Fixes ipodhacks.com (a mislayout
caused by malformed html... <table><br>...)

r=mjs

khtml/css/html4.css:
khtml/html/dtd.cpp: (DOM::checkChild):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isInline):
khtml/html/htmlparser.cpp: (KHTMLParser::reset): (KHTMLParser::insertNode):
khtml/html/htmlparser.h:
khtml/misc/htmltags.c: (hash_tag): (findTag):
khtml/misc/htmltags.h:
khtml/misc/htmltags.in:
khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed