Timeline



Dec 10, 2002:

10:18 PM Changeset in webkit [2996] by darin
  • 12 edits in trunk
  • fixed fix for 3124081 -- REGRESSION: partial progress is left in address field after download

Reviewed by Chris.

Need to move it down one line so the data source is clear before callback.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): Do the _clearProvisionalDataSource before the locationChangeDone: callback.
10:06 PM Changeset in webkit [2995] by sullivan
  • 8 edits in trunk

Tools:

Fixed more "Alexander"s that were lurking in places
I forgot to look before.

  • Scripts/embed-into-alex: EMBED_HOST="${SYMROOTS}/Safari.app"
  • Scripts/run-plt: many occurrences
  • Scripts/set-alex-version: occurred in comment only
  • Scripts/time-alex-startup:
my $alex = $ENV{"SAFARI"}
"$symroots/Safari.app";

if ($alex =~ /Safari\.app$/) {

$alex .= "/Contents/MacOS/Safari";

JavaScriptCore:

Fixed more "Alexander"s that were lurking in places I forgot
to look before.

Reviewed by Darin

  • Makefile.am: "rm -rf $(SYMROOTS)/Safari.app/Frameworks/JavaScriptCore.framework"

WebFoundation:

Fixed more "Alexander"s that were lurking in places I forgot
to look before.

Reviewed by Darin

  • Makefile.am: "rm -rf $(SYMROOTS)/Safari.app/Frameworks/WebFoundation.framework"

WebCore:

Fixed more "Alexander"s that were lurking in places I forgot
to look before.

Reviewed by Darin

  • Makefile.am: "rm -rf $(SYMROOTS)/Safari.app/Frameworks/WebCore.framework"

WebKit:

Fixed more "Alexander"s that were lurking in places I forgot
to look before.

Reviewed by Darin

  • Makefile.am: "rm -rf $(SYMROOTS)/Safari.app/Frameworks/WebKit.framework"

WebBrowser:

Fixed more "Alexander"s that were lurking in places
I forgot to look before.

Reviewed by Darin

  • Makefile.am: "rm -rf $(SYMROOTS)/Safari.app" in make clean
  • Preferences.subproj/English.lproj/GeneralPreferences.nib: "When Safari Quits"
  • Scripting.subproj/Safari.scriptSuite: value for Name key
  • copy-frameworks-to-dstroot.sh: app_name
  • embed-frameworks.sh: app_name
9:26 PM Changeset in webkit [2994] by darin
  • 3 edits in trunk/WebKit
  • fixed 3124081 -- REGRESSION: partial progress is left in address field after download

Reviewed by Chris.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): Put in code to call the locationChangeDone: method on the location change delegate if keepLoading is YES. Since the data source is not finished loading WebFrame won't do it.
9:03 PM Changeset in webkit [2993] by cblu
  • 3 edits in trunk/WebKit

Fixed: 3124079 - REGRESSION: Downloads never complete

Reviewed by darin.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): release and set to nil the download handler after calling [super handleDidFinishLoading:h]
6:22 PM Changeset in webkit [2992] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Don.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Call Cache::init before KHTMLPart::init so we have a loader to connect the signals to.
4:51 PM Changeset in webkit [2991] by rjw
  • 4 edits in trunk/WebKit

Fixed 3115427. Page now draws instantly instead of 20 seconds.
I added the substitution font we get from the appkit to the character to glyph
cache.

Fixed early return optimization from letter forming function. It was too
eager to return!

Reviewed by mjs.

  • Misc.subproj/WebUnicode.m: (shapedString):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (glyphForCharacter): (glyphForUnicodeCharacter): (widthForGlyph): (widthForCharacter): (_fontContainsString): (-[WebTextRenderer substituteFontForString:families:]): (-[WebTextRenderer _computeWidthForSpace]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:fontFamilies:]): (-[WebTextRenderer extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer updateGlyphEntryForCharacter:glyphID:font:]): (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]): (-[WebTextRenderer extendGlyphToWidthMapToInclude:]):
3:33 PM Changeset in webkit [2990] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Trey.

  • khtml/khtml_part.cpp: (KHTMLPart::KHTMLPart): Don't call KHTMLPart::init at all...
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Call it here instead so that signal connections happen properly.
3:02 PM Changeset in webkit [2989] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

  • tweaked the API of WebBookmarkImporter while implementing real "Import IE Favorites" UI

Reviewed by Ken

  • Bookmarks.subproj/WebBookmarkImporter.h: fixed a typo in a constant
  • Bookmarks.subproj/WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]): Don't pass a group here. This method now creates the topBookmark (as it was doing before) but does not attempt to insert it anywhere. It's up to the client to fetch the topBookmark and do something with it. Also, don't name the new folder here; leave that to the caller also.
  • English.lproj/Localizable.strings: kept this file up to date

WebBrowser:

  • fixed 3123342 -- Import IE bookmarks at first startup
  • fixed 3122497 -- Descenders cut off in bookmarks view
  • removed "Google Search" from View menu since it's not working yet and we're hoping to get by without it using a direct manipulation approach instead

Reviewed by Ken

  • BookmarksController.m: (-[BookmarksController importInternetExplorerFavorites]): new method, moved here from DebugUtilities and tweaked to match changes in WebBookmarkImporter's API (-[BookmarksController importInternetExplorerFavoritesIfNecessary]): new method, checks NSUserDefaults value to bail out if importing has already occurred, and sets NSUserDefaults value after importing. (-[BookmarksController awakeFromNib]): call importInternetExplorerFavoritesIfNecessary
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): remove IE importing stuff from here
  • English.lproj/Localizable.strings: kept this file up to date
  • English.lproj/MainMenu.nib: removed "Google Search" menu item from View menu
  • PreferenceKeys.h: added preference key to remember whether we've imported IE favorites
  • TextCell.m: (-[TextCell drawInteriorWithFrame:inView:]): Rather than insetting frame to make text appear vertically centered, just move down the top edge. This fixes 3122497.
2:00 PM Changeset in webkit [2988] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3116996. My hack to make selects ignore fixed CSS
widths that are smaller than their intrinsic width was not
good. Remove the hack.

Reviewed by darin

  • khtml/rendering/render_box.cpp: (RenderBox::calcReplacedWidth):
10:19 AM Changeset in webkit [2987] by darin
  • 7 edits in trunk

WebCore:

Reviewed by John.

  • fixed 3108912 -- onclick handlers not supported on form elements

We now pass the events back to the NSView here in WebCore; they pass through all the
machinery in the DOM before getting sent on.

  • kwq/KWQKHTMLPart.h: Add widgetWillReleaseView and handleMouseDownEventForWidget functions, overrides for khtmlMousePressEvent, khtmlMouseDoubleClickEvent, khtmlMouseReleaseEvent, and a new _mouseDownView field.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Initialize _mouseDownView to nil. (KWQKHTMLPart::khtmlMousePressEvent): Call handleMouseDownEventForWidget, but if it returns false call through to the base class function. (KWQKHTMLPart::khtmlMouseDoubleClickEvent): Ditto. (KWQKHTMLPart::handleMouseDownEventForWidget): Do a hit test to find out which view to send the mouse down event to, and then send it. (KWQKHTMLPart::khtmlMouseReleaseEvent): Send the mouse up event to the view we sent a mouse down event to, or call through to the base class otherwise. (KWQKHTMLPart::widgetWillReleaseView): Clear out the _mouseDownView field if the view is being released by the QWidget that owns it.
  • kwq/KWQWidget.mm: (QWidget::~QWidget): Call KWQKHTMLPart::widgetWillReleaseView. (QWidget::setView): Call KWQKHTMLPart::widgetWillReleaseView on the old view.

WebKit:

Reviewed by John.

  • fixed 3108912 -- onclick handlers not supported on form elements
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): Take over hit testing so that all clicks on subviews are handled by the WebHTMLView. WebCore now handles getting the mouse events to the subviews after passing the events through the DOM.

Dec 9, 2002:

9:45 PM Changeset in webkit [2986] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Trey.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Treat a click on a link to the same URL with an anchor as a scroll to anchor, not a same URL load. (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Avoid adding the same anchor URL to the back/forward list many times.
9:00 PM Changeset in webkit [2985] by darin
  • 16 edits in trunk

Tools:

Reviewed by Maciej.

  • Scripts/set-alex-version: Make it bump the source version and marketing version of all our subprojects, because that's what we need up until Alex 1.0.

JavaScriptCore:

Reviewed by Maciej.

  • JavaScriptCore.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
  • English.lproj/InfoPlist.strings: In here too.

WebFoundation:

Reviewed by Maciej.

  • fixed problems I noticed in my review of Chris's change (which came in too late)
CacheLoader.subproj/WebResourceLoad.m: (_guessMIMEType): Fix && vs.
confusion that

will make CR, LF, and tab not qualify as text characters. Also take end of loop check
out of the loop.

  • added a method for use in user-agent computations
  • Misc.subproj/WebNSUserDefaultsExtras.h: Added _web_preferredLanguageCode.
  • Misc.subproj/WebNSUserDefaultsExtras.m: (+[NSUserDefaults _web_preferredLanguageCode]): Use _web_HTTPStyleLanguageCode on the first element of the AppleLanguages array.
  • WebFoundation.pbproj/project.pbxproj: Bump versions to 0.8 and 35u. Make WebNSUserDefaultsExtras.h SPI so we can use it in WebKit. Re-sort things a bit.
  • English.lproj/InfoPlist.strings: Bump versions in here too.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes.

WebCore:

Reviewed by Maciej.

  • WebCore.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.

WebKit:

Reviewed by Maciej.

  • fixed 3028664 -- change user agent string to include application name and version
  • WebView.subproj/WebController.m: (-[WebController setApplicationNameForUserAgent:]): Remove locking, unneeded since we changed how WebFoundation handles user agent. (-[WebController setCustomUserAgent:]): Ditto. (-[WebController resetUserAgent]): Ditto. (-[WebController userAgentForURL:]): Remove locking. Also add new algorithm for computing the user agent which takes the preferred language into account, and incorporates the WebKit version and the application name.
  • WebView.subproj/WebControllerPrivate.h: No need for a lock.
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): Don't create a lock. (-[WebControllerPrivate dealloc]): Don't release a lock.
  • WebKit.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
  • English.lproj/InfoPlist.strings: In here too.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes.

WebBrowser:

Reviewed by Maciej.

  • pass properly-formatted application name string to WebKit so it can make a good user-agent
  • BrowserWebController.m: (-[BrowserWebController initWithBrowserDocument:]): Instead of passing "Mr. Poopypants", pass Sherlock, augmented with version strings, to setApplicationNameForUserAgent:. Later we will pass Safari instead.
  • WebBrowser.pbproj/project.pbxproj: Bump version to 35u (we won't use " unofficial" any more).
  • English.lproj/StringsNotToBeLocalized.txt: Updated for these changes.
8:16 PM Changeset in webkit [2984] by mjs
  • 8 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3117734 - fail at document.releaseEvents in js at rollingstone.com
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): Added no-op implementations of captureEvents and releaseEvents. (KJS::HTMLDocument::tryGet):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp: (Window::get, WindowFunc::tryCall): Added no-op implementation of releaseEvents.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_html.lut.h: Regenerated.
  • khtml/ecma/kjs_window.lut.h: Regenerated.
7:27 PM Changeset in webkit [2983] by hyatt
  • 3 edits in trunk/WebCore

Fix for the CSS test suite link. Need to make sure inlines
that are obscured by blocks are properly considered to be
above the block background.

Reviewed by LUCKY WINNER

  • khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
5:24 PM Changeset in webkit [2982] by darin
  • 17 edits in trunk/WebCore

Reviewed by Trey.

  • made KWQKHTMLPart a subclass of KHTMLPart so we can override virtual functions
  • khtml/khtml_part.h: Get rid of kwq pointer.
  • khtml/khtml_part.cpp: (KHTMLPart::init): No need to make a KWQKHTMLPart any more. (KHTMLPart::~KHTMLPart): No need to delete a KWQKHTMLPart any more. (KHTMLPart::closeURL): KWQKHTMLPart does saveDocumentState in an override now. (KHTMLPart::begin): KWQ() instead of ->kwq. (KHTMLPart::checkCompleted): KWQ() instead of ->kwq, and ifdef out some unneeded code. (KHTMLPart::urlSelected): KWQ() instead of ->kwq. (KHTMLPart::requestFrameName): KWQ() instead of ->kwq. (KHTMLPart::processObjectRequest): Just call openURL, since we are now KWQKHTMLPart. (KHTMLPart::submitForm): KWQ() instead of ->kwq. (KHTMLPart::popupMenu): Did a bit more ifdef'int out here.
  • kwq/KWQKHTMLPart.h: Include "khtml_part.h" and remove includes we don't need any more. Inherit from KHTMLPart instead of QObject. Remove KHTMLPart parameter from constructor. Override openURL and closeURL. Remove part and d pointers. Add KWQ() inline to avoid casting.
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::completed): KWQ() instead of ->kwq. (KHTMLPart::openURL): Never reached now, since we override. (KHTMLPart::setStatusBarText): KWQ() instead of ->kwq. (KHTMLPart::started): KWQ() instead of ->kwq. (KWQKHTMLPart::KWQKHTMLPart): No need to deal with separate part. (KWQKHTMLPart::bridgeForFrameName): KWQ() instead of ->kwq. (KWQKHTMLPart::openURL): Add bool return value so we can override the existing openURL. (KWQKHTMLPart::slotData): Remove unneeded part->. (KWQKHTMLPart::setView): Remove unneeded part->. (KWQKHTMLPart::document): Remove unneeded part->. (KWQKHTMLPart::renderer): Remove unneeded part->. (KWQKHTMLPart::userAgent): Remove unneeded part->. (KWQKHTMLPart::nextKeyViewInFrame): KWQ() instead of ->kwq. (KWQKHTMLPart::nextKeyViewInFrameHierarchy): KWQ() instead of ->kwq. (KWQKHTMLPart::canCachePage): Remove unneeded part->. (KWQKHTMLPart::saveWindowProperties): Use this instead of part. (KWQKHTMLPart::saveLocationProperties): Use this instead of part. (KWQKHTMLPart::restoreWindowProperties): Use this instead of part. (KWQKHTMLPart::restoreLocationProperties): Use this instead of part. (KWQKHTMLPart::openURLFromPageCache): Remove unneeded part->. (KWQKHTMLPart::partForNode): KWQ() instead of ->kwq. (KWQKHTMLPart::updatePolicyBaseURL): Remove unneeded part->. (KWQKHTMLPart::setPolicyBaseURL): Remove unneeded part->. (KWQKHTMLPart::createDummyDocument): Use this instead of part. (KWQKHTMLPart::scrollToAnchor): Remove unneeded part->. (KWQKHTMLPart::closeURL): Added. Calls saveDocumentState().
  • kwq/WebCoreBridge.h: Use KWQKHTMLPart instead of KHTMLPart.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge init]): Make a KWQKHTMLPart. Use _part instead of _part->kwq in the rest of the file.
  • kwq/KWQSignal.mm: (KWQSignal::disconnect): Add the names of a few signals that are disconnected after the KWQKHTMLPart part of the KHTMLPart is destroyed, to avoid noise.
  • khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): KWQ() instead of ->kwq.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::initScript): KWQ() instead of ->kwq.
  • khtml/ecma/kjs_window.cpp: (Window::scheduleClose): KWQ() instead of ->kwq. (WindowFunc::tryCall): KWQ() instead of ->kwq.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setTitle): KWQ() instead of ->kwq.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::openURLRequest): KWQ() instead of ->kwq. (KHTMLPartBrowserExtension::createNewWindow): KWQ() instead of ->kwq. (KHTMLPartBrowserExtension::setIconURL): KWQ() instead of ->kwq. (KHTMLPartBrowserExtension::setTypedIconURL): KWQ() instead of ->kwq.
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet): KWQ() instead of ->kwq.
  • kwq/KWQLoader.mm: (KWQServeRequest): Cast to KWQKHTMLPart instead of casting to KHTMLPart and doing ->kwq. (KWQCheckIfReloading): Ditto. (KWQCheckCacheObjectStatus): Ditto.
  • WebCore.pbproj/project.pbxproj: Let Electron punish the wicked.
3:24 PM Changeset in webkit [2981] by rjw
  • 20 edits in trunk

Many changes for b/f list.

  1. Always attempt to cache snap back items.
  2. Lazily release resources from page cache. This garners gains on the PLT (and presumably iBench) tests, both for uncached.
  3. Set the page cache size to 4 (+ snap back items). After releasing resources we hover around 28MB footprint. Closing windows releases all resources.
  4. Turn on the back/forward cache by default. The menu item still allows you to toggle b/f on and off. Useful when conducting speed comparison in the PLT.
  5. Addition of lazy update to PLT memory statistics to show footprint after lazy release of page cache resources.
  6. Delayed to leak detector to account for lazy release of resources.
  7. A change when saving a page to back/forward cache to clear and restore the documents root renderer. Without this fix pages would appear to 'flicker' more when content arrived.
  8. A change to ensure a layout when restoring a page from the b/f cache. Without this fix scrollbars wouldn't appear correctly.
  9. A change to ensure that khtmlview layout and paint timers are unscheduled when a page is placed in the b/f cache.
  10. A fix to decouple of khtmlview from it's part when placed in the b/f cache. This fixed a crash caused by inappropriate deference of the part when a page cache item was released.
  11. A comment in KHTMLPageCache.h explaining the that our page cache is not the same as the khtml page cache. (Their cache just cached the html source.)
  12. Reapply styles when loading page from cache. This ensures that visited link get the appropriate style.

Reviewed by kocienda.

  • History.subproj/WebBackForwardList.m: (+[WebBackForwardList pageCacheSize]): (+[WebBackForwardList setUsesPageCache:]): (+[WebBackForwardList usesPageCache]):
  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (-[WebHistoryItem alwaysAttemptToUsePageCache]): (+[WebHistoryItem _invalidateReleaseTimer]): (-[WebHistoryItem _scheduleRelease]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebHistoryItem _releasePageCache:]): (-[WebHistoryItem setHasPageCache:]): (-[WebWindowWatcher windowWillClose:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _commitIfReady:]): (-[WebDataSource _loadingFromPageCache]):
  • WebView.subproj/WebDynamicScrollBarsView.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _purgePageCache]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _setState:]): (-[WebFrame _opened]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]):

WebCore

Reviewed by kocienda.

  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::clearTimers):
  • khtml/html/html_documentimpl.h:
  • khtml/khtmlview.cpp: (KHTMLView::clearPart): (KHTMLView::timerEvent):
  • khtml/khtmlview.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::restoreRenderer): (DocumentImpl::detach):
  • khtml/xml/dom_docimpl.h:
  • kwq/KWQKHTMLPageCache.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:headers:lastModified:pageCache:]): (-[WebCoreBridge saveDocumentToPageCache]): (-[KWQPageState initWithDocument:DOM::URL:windowProperties:KJS::locationProperties:KJS::]): (-[KWQPageState dealloc]): (-[KWQPageState KJS::]): (-[KWQPageState khtml::]):

WebBrowser

Make the memory check fire again after a delay.
This will show the high water mark first, and then
the footprint after the lazy release of resource has completed.

Reviewed by kocienda.

  • BrowserDocument.m: (-[BrowserDocument setSearchResultsForSnapBack:]): (-[BrowserDocument setPageForSnapBack:]):
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]):
  • Test/PageLoadTestController.m: (-[PageLoadTestController testFinishedNotification:]):
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner checkForWorldLeaks]): (-[PageLoadTestRunner checkForWorldLeaksNow]):
3:16 PM Changeset in webkit [2980] by darin
  • 1 edit in trunk/WebKit/WebView.subproj/WebHTMLView.m

Oops.

3:16 PM Changeset in webkit [2979] by darin
  • 2 edits in trunk/WebKit

Reviewed by Chris.

  • fixed 3122608 -- REGRESSION: Downloads can't be cancelled

When I fixed the leak for other categories of policy interruption, I messed
things up for downloads. Added new parameters to handle this right.

  • WebView.subproj/WebBaseResourceHandleDelegate.h: Remove isDownload flag.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate isDownload]): Return NO, override in subclass. (-[WebBaseResourceHandleDelegate handle:didReceiveResponse:]): Call isDownload method instead of looking at flag directly.
  • WebView.subproj/WebControllerPrivate.h: Add complete: parameter to _mainReceivedError:.
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:fromDataSource:complete:]): If complete is NO, then don't mark the primary load as complete.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient isDownload]): Added. Returns YES if downloadHandler is non-nil. (-[WebMainResourceClient receivedError:complete:]): Added complete parameter. Call the _setPrimaryLoadComplete: method in the download case (fixes a possible leak), and pass the complete parameter through to the controller. (-[WebMainResourceClient cancel]): Pass complete:YES. (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): Added the keepLoading flag, and pass complete:!keepLoading. (-[WebMainResourceClient stopLoadingForPolicyChange]): Pass keepLoading:NO. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Pass keepLoading:YES, and remove the call to the now-obsolete setIsDownload:. (-[WebMainResourceClient handle:didFailLoadingWithError:]): Pass complete:YES.
3:14 PM Changeset in webkit [2978] by darin
  • 11 edits in trunk/WebKit

Reviewed by Chris.

  • fixed 3122608 -- Downloads can't be cancelled

When I fixed the leak for other categories of policy interruption, I messed
things up for downloads. Added new parameters to handle this right.

  • WebView.subproj/WebBaseResourceHandleDelegate.h: Remove isDownload flag.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate isDownload]): Return NO, override in subclass. (-[WebBaseResourceHandleDelegate handle:didReceiveResponse:]): Call isDownload method instead of looking at flag directly.
  • WebView.subproj/WebControllerPrivate.h: Add complete: parameter to _mainReceivedError:.
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:fromDataSource:complete:]): If complete is NO, then don't mark the primary load as complete.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient isDownload]): Added. Returns YES if downloadHandler is non-nil. (-[WebMainResourceClient receivedError:complete:]): Added complete parameter. Call the _setPrimaryLoadComplete: method in the download case (fixes a possible leak), and pass the complete parameter through to the controller. (-[WebMainResourceClient cancel]): Pass complete:YES. (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): Added the keepLoading flag, and pass complete:!keepLoading. (-[WebMainResourceClient stopLoadingForPolicyChange]): Pass keepLoading:NO. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Pass keepLoading:YES, and remove the call to the now-obsolete setIsDownload:. (-[WebMainResourceClient handle:didFailLoadingWithError:]): Pass complete:YES.
11:00 AM Changeset in webkit [2977] by trey
  • 10 edits in trunk/WebCore

Fixed 3115903 - exchangehomes.com sometimes has form state poorly restored

KHTML is much smarter about restoring form state now, taking into account element names and
types instead of blindly blasting data by simple element ordering. We encode the name
and type at the front of the "state" strings that previously just held the value of the
element.

QString::endsWith() was just plain wrong. Looks like it had some copied code, but was
never really implemented.

Reviewed by: Darin Adler

  • WebCore.pbproj/project.pbxproj: PB is hellbent on adding "shouldUseHeadermap = 0;"
  • khtml/html/html_formimpl.cpp: (encodedElementName): Utility func to encode an element name, escaping amp and lt (HTMLGenericFormElementImpl::state): Build the prefix of an element's state string, e.g. ELEMENT_NAME&ELEMENT_TYPE& (HTMLGenericFormElementImpl::findMatchingState): Find a matching piece of state out of the list of state strings that were previously saved. (HTMLFieldSetElementImpl::type): Return our element type. (HTMLInputElementImpl::state): Call super as part of building state string. (HTMLInputElementImpl::restoreState): Use findMatchingState. (HTMLLegendElementImpl::type): Return our element type. (HTMLSelectElementImpl::state): Call super as part of building state string. (HTMLSelectElementImpl::restoreState): Use findMatchingState. (HTMLKeygenElementImpl::type): Return our element type. (HTMLOptGroupElementImpl::type): Return our element type. (HTMLOptionElementImpl::type): Return our element type. (HTMLTextAreaElementImpl::state): Call super as part of building state string. (HTMLTextAreaElementImpl::restoreState): Use findMatchingState.
  • khtml/html/html_formimpl.h: type() is moved up to HTMLGenericFormElementImpl
  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Pass list of states to restoreState. (KHTMLParser::popOneBlock): Pass list of states to restoreState.
  • khtml/xml/dom_docimpl.h: Add method to return the whole list of form states.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::restoreState): Nodes receive the whole list of form states to restore from, not just a single state that has already been chosen.
  • khtml/xml/dom_nodeimpl.h:
  • kwq/KWQString.mm: (QString::endsWith): Walk the search string correctly.
8:49 AM Changeset in webkit [2976] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3103954 - preferences not displayed properly at excite.com
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::value): If a radio or checkbox input has a value, return that rather than something based on the checked state. Only fall back on the checked state if there is no value.
8:36 AM Changeset in webkit [2975] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3103036 - REGRESSION: scripts dropped from DOM tree; javascript text rendered to screen

The problem here is that we don't allow SCRIPT inside MAP, so the
script tag gets thrown away in the DOM and the text is added
directly to the MAP. I can't see a good reason not to allow SCRIPT
here, so I think the best thing to do is relax the DTD.

  • khtml/html/dtd.cpp: (DOM::checkChild): Relax the DTD to allow SCRIPT inside MAP.
8:21 AM Changeset in webkit [2974] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

  • fixed 3059637 - all articles missing at excite.com sports page
  • fixed 3065903 - most of content missing at excite.com news page

These bugs both came up because a JavaScript function has a var
declaration that collides with a function parameter name.

  • kjs/nodes.cpp: (VarDeclNode::processVarDecls): Don't set the property to undefined if a property with that name is already set on the global object. Otherwise we may clobber function parameters with undefined even before hitting a possible var initializer.

Dec 8, 2002:

11:12 PM Changeset in webkit [2973] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3007276, styles do not cascade properly through
tables. The font was being reset to the default font
(konq_default) when it needed to be reset to the body's font.
I added a new font family value called konq_body and the
style system resolves that value to be the body's font family list.

Reviewed by: gramps and mjs

  • khtml/css/cssstyleselector.cpp:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::attach):
9:48 PM Changeset in webkit [2972] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3121814. Forms inside table elements (tbody and table
etc.) can be inline. Just remove the assert and replace it
with a bailout.

Fix for 3036479. Tables with specified heights but cells
with no height (or no cells at all) were not honoring
the specified height.

Reviewed by: gramps

  • khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::startRow): (RenderTable::layoutRows): (RenderTable::paint): (RenderTable::recalcCells):
9:41 PM Changeset in webkit [2971] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 2981252 - JavaScript inside <!-- --> comments inside <select> is not executed

This problem is caused by the hack to turn all whitespace into
spaces inside <select>, so that it's collapsed in the DOM. But
this is especially bad for scripts inside select tags, so I
changed the select special case to not apply inside scripts.

  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::addPending): (HTMLTokenizer::write):
7:39 PM Changeset in webkit [2970] by darin
  • 18 edits in trunk

WebFoundation:

Reviewed by Don and Dave.

  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
  • WebFoundation.pbproj/project.pbxproj: Let Electron be Electron.

WebCore:

Reviewed by Don and Dave.

  • fixed 3115845 -- bad-pointer crash destroying DOM tree reproducible at a particular site

All hail libgmalloc, without which this would just be another bug I can't reproduce!

This memory trasher bug was caused bug calling setChildrenLoaded after casting a node to
HTMLObjectElementImpl, when the node wasn't always an object element. It turns out that this
fix was made obsolete a while back when I changed close on renderers to be delivered even for
cases where the renderer is not created yet at close time.

  • khtml/html/htmlparser.cpp: (KHTMLParser::processCloseTag): Remove the special case for </object>. Now that this is fixed another way we don't need this at all.
  • khtml/html/html_objectimpl.h: Remove setChildrenLoaded and m_childrenLoaded.
  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): Remove code that sets m_childrenLoaded to false. (HTMLObjectElementImpl::attach): Remove code that looks at m_childrenLoaded, since we don't need it any more (and in fact there's no way to set it any more).
  • fixed 3120578 -- REGRESSION: going to about:blank creates null view

If no tokens are ever sent to the parser, then we end up without a render tree.

  • khtml/html/htmlparser.h: Add finished() function.
  • khtml/html/htmlparser.cpp: (KHTMLParser::finished): Make an HTML element if the document is still empty at this point. This is identical to what KHTMLParser::insertNode does when you insert any kind of element other than an HTML element.
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::end): Call finished() to let the parser know.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Turn on the "paint red" feature in development builds. Null view problems are particularly hard to debug without something like this, and we don't care if development builds are ever-so-slightly slower. No change in deployment.
  • fixed 3121527 -- crash in WebCoreBridge frameBorderStyle
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge frameBorderStyle]): Handle case where this is called and we don't have a KHTMLView yet.
  • other changes
  • WebCore.pbproj/project.pbxproj: Electron is doing his thing.

WebKit:

Reviewed by Don and Dave.

  • fixed 3120578 -- REGRESSION: going to about:blank creates null view

This part of the fix makes sure that a renderer is created, even when there are no bytes
of data passed through. This makes the empty document about:blank case work just like the
"document with just whitespace in it case". There's another part of the fix in WebCore that
takes care of the remaining problem.

  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Call receivedData:withDataSource: on the bridge with nil for the data. It would be even more elegant to add a new call for the case where we finish, but it's not necessary, since the existing receivedData: call does all the right things if passed nil.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _finishedLoading]): Call finishedLoadingWithDataSource: here, to make sure it's done after committing. This parallels what we already do for the didReceiveData call.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): Remove the call to finishedLoadingWithDataSource: because it's handled by _finishedLoading now. This parallels what we already do for the didReceiveData call.
  • fixed long standing problem where resizing could make you see a "null view"
  • WebView.subproj/WebView.m: (-[WebView drawRect:]): Add a "paint cyan" feature in development builds. Null view problems are particularly hard to debug without something like this, and we don't care if development builds are slightly slower. No change in deployment. (-[WebView setFrameSize:]): Tell the scroll view to draw the background if we are resized. We can't do our "let the old bits show through" thing any more if we have to redraw because of resizing.
  • other changes
  • WebKit.pbproj/project.pbxproj: Remove the old -DAPPLE_CHANGES and -DHAVE_CONFIG_H that we once needed when WebKit used to compile C++ headers from the KHTML part of WebCore. We haven't needed those for ages. Also sort things a bit, using the new Electron feature for sorting lists of files alphabetically, and some by hand.
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

Reviewed by Don and Dave.

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
6:42 PM Changeset in webkit [2969] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Fixed: 3121627 - REGRESSION: partial progress is left in address field after download

Reviewed by: darin

In WebMainResourceClient, make sure to always call receivedError before _clearProvisionalDataSource so that
receivedError works. This is done in multiple places, so I factored this out into one method interuptForPolicyChange.

  • WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:fromDataSource:]): added asserts for nil error, dataSource and frame
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChange]): renamed from notifyDelegatesOfInterruptionByPolicyChange because it now also sets the provisionalDataSource on the frame to nil. (-[WebMainResourceClient stopLoadingForPolicyChange]): call interruptForPolicyChange, stop load (-[WebMainResourceClient continueAfterContentPolicy:response:]): call interruptForPolicyChange

WebBrowser:

Fixed: 3121284 - REGRESSION: Downloaded item's URL is left in address field

Reviewed by: darin

  • BrowserWindowController.m: (-[BrowserWindowController updateLocationFieldText]): If the provisional data source has ended in error, don't use its URL.
1:08 PM Changeset in webkit [2968] by hyatt
  • 3 edits in trunk/WebCore

Fix for image bullets. They were neglecting to offset
themselves by their own width, and were just relying on
sheer luck (the default margin) to accommodate their
size. The bug is 3007040 (borkware.com).

Reviewed by: gramps

  • khtml/rendering/render_list.cpp: (RenderListMarker::paintObject):

Dec 7, 2002:

6:06 PM Changeset in webkit [2967] by hyatt
  • 5 edits in trunk/WebCore

This change fixes three bugs in list items.

(1) Stop implementing markers as floats. This is simply
wrong. The bullet doesn't affect the height of the line
box if it's a float, and it can also affect other
list items that follow the bullet's enclosing list item
(leading to odd staggered layout of lists).

(2) Relax the DTD. It was trying to obey strict HTML, which
is hopeless in the case of lists. Match the behavior of
both Gecko and the IEs (mac and win32) and allow non-list
content to be inserted between list items without being
wrapped in its own list item. Lists were making empty
items for whitespace in between items, and this stops that
and makes our lists behave much more like Gecko and the IEs.

(3) The bullet's min and max width weren't getting set, which
could lead to confused line width calculations when image
bullets were used.

Reviewed by: gramps

  • ChangeLog:
  • khtml/html/dtd.cpp: (DOM::checkChild):
  • khtml/rendering/bidi.cpp: (RenderFlow::findNextLineBreak):
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListMarker::calcMinMaxWidth):
5:03 PM Changeset in webkit [2966] by kocienda
  • 3 edits in trunk/WebCore

Tests:

Reviewed by: Maciej

Fix for this bug:

Radar 3073988 (URLs with /../ are not resolved before being sent to the host)

  • TestURLs.h: Added some new test URLs. Added a new TestAbsoluteURLsWithRelativePortions array.
  • WebFoundation-Misc/ifnsurlextensions-test.chk: Updated for changed behavior.
  • kde/Makefile.am: Added new kurl-relative-test.
  • kde/kurl-relative-test.chk: Added.
  • kde/kurl-relative-test.cpp: Added.
  • kde/kurl-test.chk: Updated for changed behavior.

WebFoundation:

Reviewed by: Maciej

Fix for this bug:

Radar 3073988 (URLs with /../ are not resolved before being sent to the host)

  • Misc.subproj/WebNSURLExtras.m: (pathRemovingDots): New code that was adapted from KURL relative URL resolution code. (-[NSURL _web_URLComponents]): Call new pathRemovingDots function where needed.

WebCore:

Reviewed by: Maciej

Fix for this bug:

Radar 3073988 (URLs with /../ are not resolved before being sent to the host)

  • kwq/KWQKURL.mm: (KURL::KURL): (copyPathRemovingDots): New function containing code that was pulled out of the existing relative URL resolution code. (KURL::parse): Call new copyPathRemovingDots function instead of doing same work inline.

Dec 6, 2002:

6:21 PM Changeset in webkit [2965] by hyatt
  • 8 edits in trunk/WebCore

Sigh. I forgot to commit the first layer fix (that has already
been reviewed), so now this is also including that.

The first layer fix was to deal with the yale.edu crasher.
It involved making sure that append/remove of render object
trees drill down into those trees to remove/append corresponding
layers (instead of just checking the root of the trees).

The second fix involves making sure that cliprects are right
for painting backgrounds and borders of clipped objects.
Fixes benoit's bug.

Reviewed by: mjs and darin (fix 1), mjs and gramps (fix 2)

  • khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::paint): (RenderLayer::constructZTree):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.cpp: (RenderObject::appendLayers): (RenderObject::removeLayers): (RenderObject::enclosingLayer):
  • khtml/rendering/render_object.h:
5:50 PM Changeset in webkit [2964] by trey
  • 2 edits in trunk/WebKit

WebKit:

Clean up some printfs. Use WebKitLogPageCache for page cache info.

Reviewed by: rjw

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _purgePageCache]): (-[WebFrame _setState:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):

WebBrowser:

Clean up some printfs. Use WebKitLogPageCache for page cache info.

Reviewed by: rjw, co-conspirator

  • Debug/DebugUtilities.m: (-[BrowserDocument toggleBackForwardEnabled:]):
5:18 PM Changeset in webkit [2963] by trey
  • 6 edits in trunk/WebKit

WebKit:

3118584 - implement desired behavior for load - reload - b/f
3119241 - page cache needs to be refreshed after reload
3118096 - isTargetItem:NO saved to disk with every bookmark

The most noticeable changes are the addition of the "Same" loadType, and that reload
does not restore form state. 3119241 was noticed in passing, and is related.
3118096 is a nit with a possible small perf benefit.

Reviewed by: rjw

  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem dealloc]): New originalURL field. (-[WebHistoryItem originalURL]): New getter. (-[WebHistoryItem setOriginalURL:]): New setter. (-[WebHistoryItem dictionaryRepresentation]): Dont save isTarget. (-[WebHistoryItem initFromDictionaryRepresentation:]): Dont save isTarget.
  • WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): Test for going to same URL, invoke loadTypeSame case.
  • WebView.subproj/WebFramePrivate.h: Add loadTypeSame
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): Remove a line of dead code. (-[WebFrame _createItem]): Set originalURL when item is created. (-[WebFrame _transitionToCommitted:]): For loadTypeSame, clear page cache (-[WebFrame _purgePageCache]): Added logging. (-[WebFrame _setState:]): Don't add to page cache if doing a reload. (-[WebFrame _isLoadComplete]): LoadTypeSame is a NOP. (-[WebFrame _loadItem:fromItem:withLoadType:]): LoadTypeSame is an ASSERT. (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): In the LoadTypeSame case load from origin and never do anchor nav. If asked to load the same URL, invoke LoadTypeSame case. (-[WebFrame _loadURL:intoChild:]): Latent bug: WebFrameLoadTypeReloadAllowingStaleData should restore child frame content like reload does. (-[WebFrame _itemForRestoringDocState]): Prevent form state restore on reload and loadSame. (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): New utility function.

WebBrowser:

3118584 - implement desired behavior for load - reload - b/f
3119029 - assert if you control click on back button when it's enabled only to leave bookmarks view

The app no longer has a test in it to turn a standard nav into a reload. WK does it.

The bug was a result of the special case of the back button as a way to get out
of bookmarks view to the web view. The back menu basically has to play the same game.

Reviewed by: rjw, john sullivan (respectively)

  • BrowserDocument.m: (-[BrowserDocument goToRequest:]): Remove test, let WK sort out when to reload. (-[BrowserDocument goToItem:]): Special case if in bookmarks view. Go back to web view mode. (-[BrowserDocument backListMenuForButton:]): Special case if in bookmarks view. Add current item to menu.
  • BrowserWindowController.h: Export a couple existing methods.
4:27 PM Changeset in webkit [2962] by mjs
  • 10 edits in trunk/WebCore

Reviewed by: Darin

  • fixed 3077227 - netflix "top 100" page JavaScript runs so slowly, it seems like a hang

I fixed this by adding hash tables of image and form elements by
name and id. This allows scans of the whole document to be avoided
in many cases.

This also results in a small speedup (~1%) on cvs-js-ibench.

  • khtml/dom/html_document.cpp:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasProperty): (KJS::HTMLDocument::tryGet):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::addNamedImageOrForm): (HTMLDocumentImpl::removeNamedImageOrForm): (HTMLDocumentImpl::haveNamedImageOrForm):
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::attach): (HTMLFormElementImpl::detach): (HTMLFormElementImpl::parseAttribute):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseAttribute): (HTMLImageElementImpl::attach): (HTMLImageElementImpl::detach):
  • khtml/html/html_imageimpl.h:
3:05 PM Changeset in webkit [2961] by hyatt
  • 4 edits in trunk/WebCore

Hack to make i-bench paint every fourth page. We can tune
this # as needed.

Reviewed by: darin

  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):
  • khtml/rendering/render_flow.h:
12:07 PM Changeset in webkit [2960] by darin
  • 4 edits in trunk/WebCore

Reviewed by Trey.

Update to latest character-sets document.

  • kwq/character-sets.txt: Got the newest one and merged in our change.
  • kwq/KWQCharsetData.c: Regenerated this. Added just one character set name.
10:05 AM Changeset in webkit [2959] by darin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/ecma/kjs_events.h: Add listenerObjImp() method so we don't have to ref/unref for speed-critical uses.
  • khtml/ecma/kjs_window.cpp: (Window::getJSEventListener): Change this to work with ObjectImp so we don't ref/unref each listener. This should give us some extra speed.
8:35 AM Changeset in webkit [2958] by mjs
  • 8 edits in trunk

JavaScriptCore:

Reviewed by: Darin Adler

  • made framework embedding work correctly with buildit
  • JavaScriptCore.pbproj/project.pbxproj: Give framework a relative install path, don't install it the normal way, and copy it manually to /AppleInternal/Library/Frameworks if installing.

WebFoundation:

Reviewed by: Darin Adler

  • made framework embedding work correctly with buildit
  • WebFoundation.pbproj/project.pbxproj: Give framework a relative install path, don't install it the normal way, and copy it manually to /AppleInternal/Library/Frameworks if installing.

WebCore:

Reviewed by: Darin Adler

  • made framework embedding work correctly with buildit
  • WebCore.pbproj/project.pbxproj: Give framework a relative install path, don't install it the normal way, and copy it manually to /AppleInternal/Library/Frameworks if installing. Also look for other frameworks in ${DSTROOT}/AppleInternal/Library/Frameworks.

WebKit:

Reviewed by: Darin Adler

  • made framework embedding work correctly with buildit
  • WebKit.pbproj/project.pbxproj: Give framework a relative install path, don't install it the normal way, and copy it manually to /AppleInternal/Library/Frameworks if installing. Also look for other frameworks in ${DSTROOT}/AppleInternal/Library/Frameworks.

WebBrowser:

Reviewed by: Darin Adler

  • made framework embedding work correctly with buildit
  • copy-frameworks-to-dstroot.sh: Copy frameworks from /AppleInternal/Library/Frameworks
  • embed-frameworks.sh: Fixed typo.
12:20 AM Changeset in webkit [2957] by darin
  • 5 edits in trunk

WebCore:

Reviewed by Trey.

  • fixed 3111903 -- crash in DOM::HTMLDocumentImpl::close
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Check for the case where view() is 0 so we don't do a null-dereference. Also, remove some of the unneeded redundant isNull/isEmpty checking here.

WebKit:

Reviewed by Trey.

  • fixed 3103691 -- assertion in WebHTMLView addMouseMovedObserver at versiontracker
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView addMouseMovedObserver]): Instead of asserting, do the checks here to determine if the observer should be installed. (-[WebHTMLView viewDidMoveToWindow]): Remove checks, since addMouseMovedObserver now checks. (-[WebHTMLView windowDidBecomeMain:]): Remove checks, since addMouseMovedObserver now checks.
Note: See TracTimeline for information about the timeline view.