Context Navigation

WebCore.pbproj/project.pbxproj: Remove signature.
kwq/KWQColor.mm: Turn off inlining so we can build even on the compiler that warns about static data in inline functions.

WebKit:

Reviewed by Trey.

WebKit.pbproj/project.pbxproj: Remove signature.
WebView.subproj/WebController.m: Turn off inlining so we can build even on the compiler that warns about static data in inline functions.

WebBrowser:

Reviewed by Trey.

Scripting.subproj/Safari.scriptSuite: Change signature to sfri.
WebBrowser.pbproj/project.pbxproj: Change signature to sfri.

8:17 PM Changeset in webkit [3114] by sullivan

2 edits in trunk/WebKit

WebKit:

fixed 2895826 -- ICON: Need a "no plug-in" icon

Resources/nullplugin.tiff: new plug-in icon. Blue 3-D lego with question marks.

WebBrowser:

fixed 312965 -- SJ: Need Home button art with thinner lines
also added an all-purpose document icon with a compass instead of a spider, and a tweaked version of the app icon

Resources/Images/Home.tif:
Resources/Images/HomeDisabled.tif:
Resources/Images/HomePressed.tif:
Resources/compass.icns: new versions

document.icns: Removed. this was the spider, he's gone now but his name remains.

Resources/document.icns: Added. put it in here with the app icon.

WebBrowser.pbproj/project.pbxproj: updated for new/removed files

7:41 PM Changeset in webkit [3113] by rjw

2 edits in trunk/WebKit

Added support for Aki's 20% boost to line height. This is
done with a horrible hack and should be removed when 3129490
is fixed.

Reviewed by hyatt.

WebCoreSupport.subproj/WebTextRenderer.m:

7:24 PM Changeset in webkit [3112] by mjs

3 edits in trunk/WebCore

Reviewed by John.

fixed 3120729 - HOMEPAGE: Can't set a DIV innerHTML property with html content starting with <html><head><head/><body>

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Pop <html> and <body>, and remove <head> to allow a full HTML document to be made and inserted as a contextual fragment.

7:20 PM Changeset in webkit [3111]

3 copies in tags/Alexander-39

This commit was manufactured by cvs2svn to create tag 'Alexander-39'.

7:20 PM Changeset in webkit [3110] by sheridan

9 edits in trunk

Alexander-39, submitting to B&I

4:53 PM Changeset in webkit [3109] by hyatt

3 edits in trunk/WebCore

Make sure that anonymous block construction works properly
when you try to insert a block in between two inlines that
have already been wrapped in an anonymous block.

Reviewed by mjs

khtml/rendering/render_flow.cpp: (RenderFlow::addChildToFlow): (RenderFlow::makeChildrenNonInline):

4:34 PM Changeset in webkit [3108]

3 copies in tags/Alexander-38

This commit was manufactured by cvs2svn to create tag 'Alexander-38'.

4:34 PM Changeset in webkit [3107] by sheridan

9 edits in trunk

Alex-38

3:41 PM Changeset in webkit [3106] by rjw

2 edits in trunk/WebKit

Fixed 3127932. Added WebFrameLoadTypeReloadAllowingStaleData to cases that do not
get cached in the b/f cache.

Reviewed by trey.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]):

2:53 PM Changeset in webkit [3105] by rjw

2 edits in trunk/WebKit

Fixed 3128794. Use CG directy to get font metrics rather than the appkit. The appkit
has a bug that sometimes causes line height to be 20% too large.

2:12 PM Changeset in webkit [3104] by trey

9 edits in trunk/WebKit

WebKit:

Reworking the code to update the page icon led me to roll the WebIconDB API
for URL to NSString. In addition, the vestigial "Site" was removed.

Everything below is renaming, except where noted.

Reviewed by Darin

English.lproj/StringsNotToBeLocalized.txt:
History.subproj/WebHistoryItem.m: (-[WebHistoryItem _retainIconInDatabase:]): (-[WebHistoryItem icon]):
Misc.subproj/WebIconDatabase.h:
Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): Use _web_isFileURL. (-[WebIconDatabase iconForURL:withSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase _iconDictionariesAreGood]): (-[WebIconDatabase _loadIconDictionaries]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _iconForFileURL:withSize:]): Cons up a NSURL to get the path. Test explicitly for .htm and .html suffixes. (-[WebIconDatabase _setIcon:forIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _releaseIconForIconURLString:]): (-[WebIconDatabase _retainFutureIconForURL:]): (-[WebIconDatabase _releaseFutureIconForURL:]): (-[WebIconDatabase _sendNotificationForURL:]):
Misc.subproj/WebIconDatabasePrivate.h:
Misc.subproj/WebIconLoader.m: (-[WebIconLoader handleDidFinishLoading:]):
WebKit.exp:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _loadIcon]):

WebBrowser:

3127109 - REGRESSION: generic favicon shown while page from same domain is loading

We now avoid jumping to the generic icon when we're loading and are moving
to a URL within the same domain as the current one.

In addition, some name changes for the URL->NSString changes in the WebIconDB API.

Reviewed by John

BookmarkSource.m: (-[BookmarkSource imageForContentItem:]): Adopt API change.
BrowserWindowController.h: New ivar, _acceptsGenericIcon.
BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Init new ivar. (-[BrowserWindowController acceptsGenericIcon]): New getter. (-[BrowserWindowController setAcceptsGenericIcon:]): New setter. (-[BrowserWindowController updateLocationFieldIcon]): Obey new ivar as to we will accept a generic icon when updating.
LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]): If the new URL is in the same site as the old one, avoid accepting a generic icon. (-[LocationChangeHandler locationChangeDone:forDataSource:]): Reset _acceptsGenericIcon
NewBookmarksController.m: (-[NewBookmarksController awakeFromNib]): Adopt API change.
TitleBarButton.m: (-[TitleBarButton drawPathRepresentingPopUpMenuForEvent:URL:]): Adopt API change.

1:58 PM Changeset in webkit [3103] by cblu

3 edits in trunk/WebKit

WebFoundation:

Fixed: 3113073 - link on http://studio.adobe.com/explore/ redirects to not found page in Alex

Reviewed by darin.

Misc.subproj/WebNSStringExtras.m: (-[NSString _web_looksLikeAbsoluteURL]): trim whitespace because _web_URLWithString allows whitespace
Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithString:]): trim whitespace because we shouldn't replace spaces with escape characters (+[NSURL _web_URLWithString:relativeToURL:]): trim whitespace because we shouldn't replace spaces with escape characters

WebKit:

Fixed: 3113073 - link on http://studio.adobe.com/explore/ redirects to not found page in Alex

Reviewed by darin.

Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]): don't trim whitespace because _web_URLWithString does this for us
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginURLFromCString:]): tweak

11:15 AM Changeset in webkit [3102] by darin

2 edits in trunk/WebKit/Misc.subproj

Reviewed by Darin.

fixed build; WebFileDatabase was importing a file that is internal

Database.subproj/WebFileDatabase.h: Don't import WebLRUFileList.h.
Database.subproj/WebFileDatabase.m: Do import WebLRUFileList.h.

11:05 AM Changeset in webkit [3101] by sullivan

4 edits in trunk/WebKit

WebKit:

to help with performance of various bookmark operations, added a call that returns the internal array of children, to complement the safer call that returns a copy.

Reviewed by Darin

Bookmarks.subproj/WebBookmark.h: commented -children and new -rawChildren
Bookmarks.subproj/WebBookmark.m: (-[WebBookmark rawChildren]): new method, returns nil at this level. (-[WebBookmark contentMatches:]): use -rawChildren instead of -children

Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList rawChildren]): new method, returns internal array without copying

WebBrowser:

fixed 3129823 -- displaying many bookmarks in outline view is very slow

Deployed new rawChildren call everywhere appropriate in WebBrowser. This
prevents a lot of array-creation. On my machine, the time it takes to
display a folder containing 1000 items went from 0.96 sec to 0.0084 sec.

Reviewed by Darin

BookmarksController.m: (-[BookmarksController addChildrenOfBookmark:toMenu:]): (-[BookmarksController goToNthFavoriteLeaf:]): (-[BookmarksController _addBookmarksToMenu]): (-[BookmarksController mergeBookmarksFrom:to:]): (-[BookmarksController mergeBuiltInBookmarksIfNecessary]): (-[BookmarksController importInternetExplorerFavorites]): (-[BookmarksController updateBookmarkSources]): (-[BookmarksController favoriteBookmarks]): (-[BookmarksController addFavoriteBookmark:atIndex:]): (-[BookmarksController recursivelyAddChildFoldersOf:toMenu:withIndentationLevel:]): use -rawChildren instead of -children

BookmarksViewController.m: (-[BookmarksViewController newContentItemWithTitle:URLString:type:positionIgnoresSelection:]): use -rawChildren instead of -children (-[BookmarksViewController bookmarkSources]): use -rawChildren instead of -children (-[BookmarksViewController refreshContents]): log timing (-[BookmarksViewController canRemoveBookmarkSource:]): use -rawChildren instead of -children (-[BookmarksViewController deleteSelectedContentItems]): log timing (-[BookmarksViewController child:ofContentItem:usingSource:]): use -rawChildren instead of -children (-[BookmarksViewController outlineView:validateDrop:proposedItem:proposedChildIndex:]): use -rawChildren instead of -children (-[BookmarksViewController paste:]): log timing; use -rawChildren instead of -children (-[BookmarksViewController initWithBookmark:bookmark:]): use -rawChildren instead of -children

(+[CompletionController _addBookmarkTree:]):
use -rawChildren instead of -children
(+[CompletionController _removeBookmarkTree:]):
use -rawChildren instead of -children

FavoriteButton.m: (-[FavoriteButton _contentsMenu]): use -rawChildren instead of -children

WebBrowser.pbproj/project.pbxproj: version wars

9:20 AM Changeset in webkit [3100] by kocienda

2 edits in trunk/WebKit/Misc.subproj

Reviewed by Darin

Fix for this bug:

Radar 3128631 (WebFileDatabase walks its whole directory tree to expire files)

Complete reworking of the way in which the disk cache database keeps track
of the files on disk. This should result in fewer I/O operations, and
should fix the extremely bad behavior that involved walking the entire
disk cache tree evey time a single file needed to be deleted.

Database.subproj/WebFileDatabase.h: Use new WebLRUFileList code.
Database.subproj/WebFileDatabase.m: Ditto.
Database.subproj/WebLRUFileList.h: Added.
Database.subproj/WebLRUFileList.m: Ditto.
Misc.subproj/WebFoundationLogging.h: Added WebFoundationLogWebFileDatabaseActivity channel
Misc.subproj/WebFoundationLogging.m: Ditto
WebFoundation.pbproj/project.pbxproj: Added WebLRUFileList.

12:54 AM Changeset in webkit [3099] by darin

1 edit in trunk/WebCore/config.h

top level:

Reviewed by Maciej.

remove leftover bits of NO_LICENSE

acconfig.h: Remove NO_LICENSE.
configure.in: Remove all the NO_LICENSE-related bits.

WebBrowser:

Reviewed by Maciej.

remove leftover bits of NO_LICENSE

WebBrowser.pbproj/project.pbxproj: Remove build styles setting HAVE_CONFIG_H and also INCLUDE_TEST_SUITE too, because that hasn't been used anywhere for like forever.

12:09 AM Changeset in webkit [3098] by darin

183 edits
1 delete in trunk

top level:

Reviewed by Don and Maciej.

force-clean-timestamp: Trigger a full build since we are setting MACOSX_DEPLOYMENT_TARGET to 10.2, which requires remaking all PFEs.

Tools:

Scripts/check-copyright: Added.

JavaScriptCore:

Reviewed by Don and Maciej.

fixed 3129115 -- need Apple copyright added to open source documents

tons of files: Added our copyright to files we modified, and updated all to standard format.

other changes

JavaScriptCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2. Also removed completion.cpp.
kjs/completion.cpp: Removed.
kjs/completion.h: Made the Completion constructor inline.

kjs/grammar.y: Removed an obsolete "pretend ifdef". No need to put these in APPLE_CHANGES now.

WebFoundation:

Reviewed by Don and Maciej.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
WebFoundation.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.

WebCore:

Reviewed by Don and Maciej.

fixed 3129115 -- need Apple copyright added to open source documents

tons of files: Added copyright message to files we modified and standardized format of copyrights too.

fixed 3129235 -- assert in LRUList visiting apple.com if "Display images" preference is off

khtml/misc/loader.cpp: (Cache::getLRUListFor): Use the first list for 0-sized objects. (Cache::removeFromLRUList): Allow 0-sized objects.

other changes

khtml/rendering/render_style.h: Remove bogus unused private constructor.

kwq/KWQFont.h: Added copy constructor and assignment operator.
kwq/KWQFont.mm: (QFont::QFont): Copy constructor now retains the NSFont. The old version didn't which could cause retain/release problems. (QFont::operator=): Retain the new NSFont and release the old one.

WebCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.

WebKit:

Reviewed by Don and Maciej.

WebView.subproj/WebUserAgentSpoofTable.gperf: Added a couple of new domains to the list we spoof as Mac IE, and added comments.
WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.

WebKit.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2

WebBrowser:

Reviewed by Don and Maciej.

fixed 3106686 -- Remove "world leak" debugging window before beta

Test/PageLoadTestController.m: (-[PageLoadTestController windowDidLoad]): (Not part of the bug fix.) Changed the combo box so it automatically sizes to the number of pltsuite files so we don't have to edit the nib all the time. (-[PageLoadTestController anyWindowWillClose:]): Don't do any world leak test when the window closes. The one in the page load test window is still there.

Debug/DebugUtilities.m: (-[NSApplication validate_toggleAlwaysCheckForWorldLeaks:]): Don't enable or check the debug menu item at all. Put an ifdef in so we can turn it on later.

fixed 3124310 -- remove "app refuses to launch" code before shipping

main.m: (main): Remove all the licensing code.

other changes

BrowserNSNetServiceExtras.m: Made all locally-defined-and used functions static so we would know if any were unused and for cleanliness. (-[NSNetService hostName:andPort:]): Remove some silly assertions. (decode_name): Change printf for errors to ERROR. (decode_srv): Ditto. (decode_txt): Removed because it's unused. (skip_question): Ditto. (MyDictionaryKeyHashCallBack): Removed silly assertion. (MyCreateCFDictionaryFromTXT): Ditto.

WebBrowser.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2

Dec 16, 2002:

11:00 PM Changeset in webkit [3097] by mjs

7 edits in trunk/WebCore

Reviewed by Darin.

fixed 3125283 - HOMEPAGE: in onload of an IMG, the width and height are equal to zero

There were two problems here. First, the calls to get image width
and height didn't force a layout in all the cases where it was
required. Second, layout wouldn't lay out images at all until
parsing was done, due to a hack to block inline layout until that
point. I'm not sure if this will have other bad consquences, but
nearly every page I tried, including Hebrew and Japanese pages as
well as every page on the base PLT laid out properly.

khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): Force a layout if not laid out. (HTMLImageElementImpl::height): Likewise.
khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Remove setBlockBidi hack - this was preventing images from getting laid out until the document was totally done parsing.
khtml/rendering/render_flow.cpp: (RenderFlow::RenderFlow): More setBLockBidi removal. (RenderFlow::layout): Likewise. (RenderFlow::close): Likewise. (RenderFlow::addChildToFlow): Likewise. (RenderFlow::printTree): Likewise.
khtml/rendering/render_flow.h:
khtml/rendering/render_object.h:

6:30 PM Changeset in webkit [3096] by sheridan

3 edits in trunk

forgot to check in new sourceversion earlier - 38

5:51 PM Changeset in webkit [3095] by hyatt

4 edits in trunk/WebCore

When a clear occurs (thus causing a block to move underneath
a float), make sure the block gets a fresh layout, so that it
can readjust its contents now that they don't have to flow
around the float.

Reviewed by darin

khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

5:38 PM Changeset in webkit [3094] by cblu

2 edits in trunk/WebKit

Fixed: 3129503 - Crash cancelling download after closing browser window that started download

Reviewed by rjw.

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setLoading:]): Added comment about our tragic dependence on a non-retained reference to the controller. (-[WebDataSource _recursiveStopLoading]): Call webFrame before calling _stopLoading because we release the controller in _stopLoading and we depend on it in webFrame.

5:32 PM Changeset in webkit [3093] by rjw

3 edits in trunk/WebCore

Fixed 3128477. Check KJS::Window before saving js objects.

Reviewed by darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveWindowProperties): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreWindowProperties): (KWQKHTMLPart::restoreLocationProperties):

4:50 PM Changeset in webkit [3092]

3 copies in tags/Alexander-37

This commit was manufactured by cvs2svn to create tag 'Alexander-37'.

4:50 PM Changeset in webkit [3091] by sheridan

8 edits in trunk

submitting to B&I. Alexander-37

2:33 PM Changeset in webkit [3090] by mjs

5 edits in trunk/WebCore

Reviewed by Darin.

fixed 3125412 - HOMEPAGE: 2nd load of html in the same div fails.
fixed 3052113 - HOMEPAGE: "site menu" part of .mac home page editing doesn't work
fixed 3075392 - HOMEPAGE: "pages" section of mac.com homepage editing is missing

khtml/html/html_baseimpl.h:
khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Function that loads new URL, to be called if src attribute is set explicitly and the element is already attached. (HTMLFrameElementImpl::parseAttribute): Call updateForNewURL when src attrinute is set. (HTMLFrameElementImpl::contentDocument): Don't involve render widget in getting the content document.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Allow contextual fragments to be created (and therefore innerHTML to be set on) TR and HTML elements.

2:32 PM Changeset in webkit [3089] by hyatt

3 edits in trunk/WebCore

Use the layer's bounds as the damage rect not the object's.
The layer knows about the overflow out of the object. The
object does not. Duh.

Fixes disney.com bustage.

Reviewed by sullivan

khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):

2:01 PM Changeset in webkit [3088] by hyatt

4 edits in trunk/WebCore

Code needs to go in calcMinMaxWidth instead, so parents computing
their own minmax widths will get the correct value during the ifrst
pass. With this change weather.com is actually fixed.

Reviewed by mjs

khtml/rendering/render_box.cpp: (RenderBox::calcWidth):
khtml/rendering/render_flow.cpp: (RenderFlow::calcMinMaxWidth):

1:42 PM Changeset in webkit [3087] by hyatt

3 edits in trunk/WebCore

Fix for 3128843, horked layout on weather.com. Ensure that
overflow: hidden elements bounds-check their minwidth and maxwidth
values to ensure that you don't grow the clipped element.

Reviewed by mjs

khtml/rendering/render_box.cpp: (RenderBox::calcWidth):

11:46 AM Changeset in webkit [3086] by trey

3 edits in trunk/WebCore

3129175 - we're doing needless GETs when using b/f cache

Turns out that an empty UserStyle was causing WebCore to reload the base URL
of the page, since it tried to load the style "".

Reviewed by Darin

khtml/khtml_part.cpp: (KHTMLPart::reparseConfiguration): Of the UserStyle is empty, set it to an empty string instead of an empty URL.

11:07 AM Changeset in webkit [3085] by mjs

4 edits in trunk/WebCore

Reviewed by Darin.

fixed 3129008 - REGRESSION: Successive hot/cached runs of cvs-base PLT are slightly slower

This was due to me reintroducing a leak of the document. Now fixed.

khtml/ecma/kjs_dom.cpp: (DOMDocument::~DOMDocument): forget self from cached DOM object table. (KJS::getDOMDocumentNode): Instead of storing the document in the marked per-document table, store it in the unmarked table, and as a property on the Window object. (KJS::getDOMNode): use getDocumentNode when appropriate.
khtml/ecma/kjs_dom.h:

9:27 AM Changeset in webkit [3084] by kocienda

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Reviewed by Darin

Fix for these bugs:

Radar 3128622 (files that can't be mmap'd are opened twice)
Radar 3128624 (names of "not mappable" files kept in ever-growing set)

It turns out that simply reading in the bytes using the NSData
initWithContentsOfFile: method is faster than attempting to mmap
disk cache files to read them.

Since the mmap code is now removed, the issues raised by the bugs
simply go away.

Database.subproj/WebFileDatabase.m: (-[WebFileDatabase objectForKey:])

2:39 AM Changeset in webkit [3083] by hyatt

2 edits in trunk/WebCore

Fix for 3128728. Ensure that list markers get placed into an
existing line box if possible. This patch also fixes RTL bullets
and line height calculations involving image bullets that are the
biggest thing on the line. List markers also correctly move
to avoid floats.

Reviewed by mjs

khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (getLineBoxParent): (RenderListItem::layout): (RenderListMarker::calcMinMaxWidth):

2:38 AM Changeset in webkit [3082] by hyatt

4 edits in trunk/WebCore

Fix for 3128728. Ensure that list markers get placed into an
existing line box if possible. This patch also fixes RTL bullets
and line height calculations involving image bullets that are the
biggest thing on the line. List markers also correctly move
to avoid floats.

Reviewed by mjs

khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (getLineBoxParent): (RenderListItem::layout): (RenderListMarker::calcMinMaxWidth):

12:53 AM Changeset in webkit [3081]

1 copy
6 deletes in tags/Alexander-37u3

This commit was manufactured by cvs2svn to create tag
'Alexander-37u3'.

12:53 AM Changeset in webkit [3080] by mjs

2 edits in trunk/WebKit

Reviewed by no one but it's just a version bump.

WebKit.pbproj/project.pbxproj: Bump version to 37u3

12:36 AM Changeset in webkit [3079] by darin

6 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3128858 -- Supply Finder bits for decoded BinHex files

Downloads.subproj/WebBinHexDecoder.h: Add a _finderFlags field.
Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeHeader]): Decode Finder flags. (-[WebBinHexDecoder fileAttributes]): Put Finder flags in dictionary.

Downloads.subproj/WebMacBinaryDecoder.m: Tweaked things for no good reason. (It is good to always import your own header first as a check that it's self-sufficient).

WebKit.pbproj/project.pbxproj: Let Electron wipe the slate clean of pre-Electron iniquity.

12:16 AM Changeset in webkit [3078] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3128766 -- macconnection.com tries to add properties to the navigator DOM object, which fails

khtml/ecma/kjs_window.cpp: (Window::get): Set up properties named navigator and clientInformation the first time either is queried. These will hold a persistent shared object rather than making one every time it's asked for.

WebCore.pbproj/project.pbxproj: Let Electron undo Maciej's evil.

12:11 AM Changeset in webkit [3077] by cblu

5 edits in trunk/WebKit

WebFoundation:

Fixed: 3094928 - Apply Finder bits to decoded downloads

Reviewed by darin.

Misc.subproj/WebNSFileManagerExtras.h:
Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_createFileAtPath:contents:attributes:]): new, creates file and sets Finder bits.

WebKit:

Fixed: 3094928 - Apply Finder bits to decoded downloads

Reviewed by darin.

Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_createFileAtPath:contents:attributes: so we set Finder bits
Downloads.subproj/WebMacBinaryDecoder.h:
Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): save Finder bits (-[WebMacBinaryDecoder fileAttributes]): return Finder bits

WebBrowser:

Fixed: 3094928 - Apply Finder bits to decoded downloads

Reviewed by darin.

DownloadRow.m: (-[DownloadRow _updateIconAndFilename]): no changes, moved up (-[DownloadRow _stopProgressAnimation]): call _updateIconAndFilename so we pick up icon changes. The Finder will update the icon after we close the file if it has the custom icon bit.

Dec 15, 2002:

11:37 PM Changeset in webkit [3076]

4 copies
56 deletes in tags/Alexander-37u2

This commit was manufactured by cvs2svn to create tag
'Alexander-37u2'.

11:37 PM Changeset in webkit [3075] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

JavaScriptCore.pbproj/project.pbxproj: Bump version to 37u2.

11:37 PM Changeset in webkit [3074] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

fixed likely B&I build problem.

WebKit.pbproj/project.pbxproj: Get at other frameworks in B&I build. Bump version to 37u2.

9:50 PM Changeset in webkit [3073] by darin

10 edits
2 adds in trunk/WebKit

Reviewed by Dave.

implemented user-agent spoofing as described in bug 3044569

WebView.subproj/WebController.m: (-[WebController userAgentForURL:]): Find the suffix of the host name that contains exactly one dot, lower-case it, and look it up in the user-agent spoof table. For now, anything in the table pretends to be MacIE. Don't fret that this table is simple. We will complicate it as needed. The technique is flexible, even though it may not look it now.

WebView.subproj/WebControllerPrivate.h: Add userAgentWhenPretendingToBeMacIE field.
WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Release userAgentWhenPretendingToBeMacIE. (-[WebController _defaultsDidChange]): Release and nil userAgentWhenPretendingToBeMacIE.

Makefile.am: Added rules to build WebUserAgentSpoofTable.c using gperf.
WebView.subproj/WebUserAgentSpoofTable.c: Added. Generated file.
WebView.subproj/WebUserAgentSpoofTable.gperf: Added. Table

English.lproj/StringsNotToBeLocalized.txt: Update for above changes.

fixed a crash I saw in a simplistic way

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Don't assert if the webFrame is nil, just return a partial dictionary.

9:00 PM Changeset in webkit [3072] by mjs

3 edits in trunk/WebCore

Tools:

Reviewed by Darin.

Scripts/set-module-version: Accept `u' in source version.

WebCore:

Reviewed by Darin.

WebCore.pbproj/project.pbxproj: Updated source version to 37u2.

8:14 PM Changeset in webkit [3071] by darin

3 edits in trunk/WebCore

Reviewed by Trey.

fixed regression where clicked-on buttons were getting keyboard focus

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMousePressEvent): Check clickCount here the way NSWindow does. See below for rationale. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): I didn't read the code in [NSWindow sendEvent:] that I was stealing carefully enough. The old needsPanelToBecomeKey flag is used to decide whether something should really get first responder, and I need to do check that too. And while I was in here, did the same clickCount check that NSWindow does for good measure.

7:05 PM Changeset in webkit [3070] by mjs

7 edits in trunk/WebCore

Reviewed by Darin.

fixed 3128383 - DOM nodes should always use the same JS object

khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::ScriptInterpreter): Set auto-delete to true on document dictionary. (ScriptInterpreter::getDOMObjectForDocument): New function - gets DOM object from per-document dictionary. (ScriptInterpreter::putDOMObjectForDocument): New function - put DOM object into per-document dictionary. (ScriptInterpreter::deleteDOMObjectsForDocument): Clear all objects from specific per-document dictionary. (ScriptInterpreter::mark): Mark per-document objects. (ScriptInterpreter::forgetDOMObjectsForDocument): Clear objects for this document from all interpreters.
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_dom.cpp: (KJS::getDOMNode): Use per-document rather than general DOM object dictionary.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): Call forgetDOMObjectsForDocument.

6:42 PM Changeset in webkit [3069] by hyatt

3 edits in trunk/WebCore

Fix for 3057974 and 3128713. I needed to make frames check to
see if their parentNode had a renderer to complete the FOUC
fix. Completing the FOUC fix finally solves 3057974.

Reviewed by darin

khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach):

5:51 PM Changeset in webkit [3068] by hyatt

4 edits in trunk/WebCore

Fix for 3109226, epinions page is mostly blank. Add a hack
to disallow > but only inside attribute values for which there
is no corresponding attribute name.

Also fix attribute values with no name so that the value is
used as the name so that e.g., <option "selected"> works.

Reviewed by darin

khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer):
khtml/html/htmltokenizer.h:

5:03 PM Changeset in webkit [3067] by darin

2 edits in trunk/WebKit

Reviewed by Trey.

fixed 3128260 -- REGRESSION: context menus in frames are always the generic page menu

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView hitTest:]): Check the control key in the mouse down event. If it's down, then do no magic.

4:42 PM Changeset in webkit [3066] by darin

5 edits in trunk/WebCore

Reviewed by Dave.

fixed 3127900 -- REGRESSION: text fields select all their text when clicked on with the mouse

kwq/KWQKHTMLPart.h: Add _firstResponderAtMouseDownTime.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMousePressEvent): Don't call makeFirstResponder: if it's already set. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Using _firstResponderAtMouseDownTime, catch the case where an NSTextField's editor was just created and became first responder. In those cases, pass the mouseDown: to the text field, not the newly created editor. Even though it shouldn't make a difference it does. Also don't makeFirstResponder: if it's already set. (KWQKHTMLPart::mouseDown): Set _firstResponderAtMouseDownTime.

kwq/KWQWidget.mm: (QWidget::setFocus): Don't call makeFirstResponder: if it's already set.

4:42 PM Changeset in webkit [3065] by darin

2 edits in trunk/WebKit

Reviewed by Dave.

fixed 3128651 -- REGRESSION: Mouse wheeling is busted on frames pages

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView hitTest:]): Only do the hitTest magic for left mouse downs; the rest of the clicks end up going to the correct view anyway, without our help. This makes this stop making trouble for the scroll wheel events.

3:42 PM Changeset in webkit [3064] by hyatt

7 edits in trunk/WebCore

Make sure framesets don't get built twice when FOUC delays
their loading.

Reviewed by gramps

khtml/css/cssstyleselector.cpp:
khtml/css/cssstyleselector.h:
khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::attach):
khtml/rendering/render_style.cpp: (RenderStyle::operator==): (RenderStyle::isStyleAvailable):
khtml/rendering/render_style.h:

3:02 PM Changeset in webkit [3063] by darin

5 edits in trunk/WebCore

Reviewed by Dave.

fixed ==/= typo in QFontMetrics that caused a part of my recent speedup to not take effect
fixed 3128582 -- REGRESSION: Crash on planetquake.com

kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::setFont): Fix a horrifying "== instead of =" mistake. (QFontMetrics::ascent): Give an ERROR message, don't crash, when this is called on a font metrics object that hasn't been updated to work for a particular font. (QFontMetrics::descent): Ditto. (QFontMetrics::lineSpacing): Ditto. (QFontMetrics::xHeight): Ditto. (QFontMetrics::width): Ditto. (QFontMetrics::floatWidth): Ditto. (QFontMetrics::floatCharacterWidths): Ditto.

khtml/html/html_inlineimpl.cpp: (HTMLBRElementImpl::attach): Eliminated what was causing us to hit the above. BR elements need to respect display() == NONE.

fixed the fix for operator==; needs to work even if the pseudo type was extracted already for one of the two, and not the other

khtml/css/cssparser.cpp: (CSSSelector::extractPseudoType): Only do work when the selector is Pseudo. (CSSSelector::operator==): Call pseudoType() instead of going right at _pseudoType.

2:34 PM Changeset in webkit [3062] by hyatt

3 edits in trunk/WebCore

Fix for 3128402, missing content on voodooextreme. Don't allow
object/embed inside the head.

Reviewed by cblu

khtml/html/dtd.cpp:

12:18 PM Changeset in webkit [3061] by darin

6 edits in trunk/WebCore

Reviewed by Ken.

fixed 3127898 -- Crash going to altavista.com after visiting sony.com

khtml/ecma/kjs_window.cpp: (Window::get): Change lots of properties to return "undefined" rather than crashing when the view is NULL. I'm not sure that undefined is the perfect thing to return in this case, but it's better than crashing the program. We can refine later as needed.

fixed 3127157 -- REGRESSION: applet does not become first responder when clicked-on
fixed 3127934 -- Crash in KWQKHTMLPart::widgetWillReleaseView scrolling around

kwq/KWQKHTMLPart.h: Get rid of widgetWillReleaseView(). Add mouseDownViewIfStillGood().
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Call makeFirstResponder: in the same way that the NSWindow does before delivering a mouseDown: message. This oversight caused the applet problem. (findViewInSubviews): Added. (KWQKHTMLPart::mouseDownViewIfStillGood): Added. Gets _mouseDownView, but then checks that it's still a subview before returning it. A little inefficient, but the only way to do it given that there's no general way to find out that an NSView is being removed from your view hierarchy or deallocated. This fixes the crash in widgetWillReleaseView. (KWQKHTMLPart::khtmlMouseMoveEvent): Use mouseDownViewIfStillGood() instead of _mouseDownView directly. (KWQKHTMLPart::khtmlMouseReleaseEvent): Ditto. (KWQKHTMLPart::passSubframeEventToSubframe): Ditto.
kwq/KWQWidget.mm: (QWidget::~QWidget): Remove call to widgetWillReleaseView(). (QWidget::setView): Ditto.

3:23 AM Changeset in webkit [3060] by hyatt

3 edits in trunk/WebCore

operator== on CSSSelectors needed to be updated to compare
_pseudoTypes. A nice subtle bug from the mega-patch.

Reviewed by mjs

khtml/css/cssparser.cpp: (CSSSelector::operator == ):

2:46 AM Changeset in webkit [3059] by hyatt

3 edits in trunk/WebCore

Fix for 3128429, sans-serif font got broken. Just a typo
from darin's mega-patch.

Reviewed by mjs

khtml/css/cssstyleselector.cpp:

1:15 AM Changeset in webkit [3058] by darin

34 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

JavaScriptCore.pbproj/project.pbxproj: Make dtoa.h visible as an SPI so I can use it inside QString.

WebFoundation:

Reviewed by Maciej.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebCore:

Reviewed by Maciej and Dave.

optimizations that improve speed; total is 13.8% on cached cvs-base on my machine

khtml/css/css_valueimpl.h: Add isKonqBody() and genericFamilyType() to find out if a font is a standard one. This is much faster than doing string comparisons all the time.
khtml/css/css_valueimpl.cpp: (FontFamilyValueImpl::FontFamilyValueImpl): Check the font names against the standard ones on time when the FontFamilyValueImpl object is constructed rather than every time the stuff is matched.
khtml/css/cssparser.h: Add pseudoType() and extractPseudoType() to CSSSelector so we don't have to do string compares all the time.
khtml/css/cssparser.cpp: (StyleBaseImpl::parseValue): Use QConstString in a way that's effective (with an object that has a long enough lifetime), or don't use it at all. (StyleBaseImpl::parseContent): Ditto. (StyleBaseImpl::preprocess): Preprocess into a buffer, usually on the stack, rather than using QString += QChar over and over again. (CSSSelector::extractPseudoType): Convert the value string into a type, and get rid of it. Saves memory because the string goes away. And doing it once is much faster than string comparing each time.
khtml/css/cssstyleselector.cpp: (cleanPath): Restructure to save one find() in the common case. (checkPseudoState): Restructure to avoid some DOMString creation/destruction in the case where the tag is not an <A>. Also use QConstString correctly. (CSSStyleSelector::checkOneSelector): Use the new pseudoType() instead of string compares. (CSSStyleSelector::applyRule): Use isKonqBody() and genericFamilyType() instead of string comparisons.

khtml/dom/dom_string.h: Make the destructor non-virtual. This was a big win, and a mistake the way it was before. Also make the DOMString constructor with no parameters inline.
khtml/dom/dom_string.cpp: (DOMString::string): Don't use QConstString here, since it does no good. (DOM::operator==): Rewrite to do things faster and avoid calling strlen.

khtml/html/html_objectimpl.h: Don't use QConstString in places where it does harm and no good.
khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::parseAttribute): Use QConstString properly.

khtml/html/htmltokenizer.cpp: (tagMatch): Added. (HTMLTokenizer::parseSpecial): Change tokenizing so it doesn't construct temporary strings (with QConstString) just to compare small substrings.

khtml/khtml_part.cpp: (KHTMLPart::write): Don't use a decoder object when source is all ASCII.

kwq/KWQColor.mm: (hex2int): Don't bother with uppercase hex since we always lowercase anyway. (QColor::setNamedColor): Use a new gperf-based table instead of an NSDictionary to look up colors.
kwq/KWQColorData.c: Added this autogenerated file.
kwq/KWQColorData.gperf: Added. Source file with list of colors and color values.
kwq/Makefile.am: Build KWQColorData.c from KWQColorData.gperf.
WebCore.pbproj/project.pbxproj: Added KWQColorData.gperf.

khtml/misc/helper.cpp: (khtml::setNamedColor): Don't call setNamedColor again with the lowercased color name, since our QColor::setNamedColor already has to lowercase the name (because it has to check all names before checking any hex values).

khtml/rendering/font.h: Don't initialize the QFontMetrics since in every case we end up changing the font later anyway. Also remove unused field.
khtml/rendering/font.cpp: (Font::update): Use the new QFontMetrics::setFont for speed.

khtml/rendering/render_object.cpp: (RenderObject::enclosingLayer): Change it so it doesn't get the layer twice. This function showed up on the sample so we know it's hot.

khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::containsOnlyWhitespace): Did a faster implementation that doesn't call QChar::direction() except for non-ASCII characters.

kwq/KWQFontMetrics.h: Add empty constructor for use in font.cpp. Add accessor and setter for the font too. Made baselineOffset() inline since it's trivial.
kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): Don't make the renderer until we use it. (QFontMetricsPrivate::getRenderer): Make it here. (QFontMetricsPrivate::font): Added. (QFontMetricsPrivate::setFont): Added. Dumps the renderer if the font is different. (QFontMetrics::QFontMetrics): Added empty constructor. (QFontMetrics::setFont): Added.

kwq/KWQKURL.mm: (KURL::parse): Avoid function call overhead calling strncasecmp and strncmp. Also made the check for localhost case insensitive.

kwq/KWQString.h: Remove _isUnicodeInternal and _isAsciiInternal, since they are trivially computed, and it saves time to not have that extra field to manipulate. Removed private data() function since it's the same as *dataHandle and not really more clear. Made ascii() and unicode() simpler and inline. Also made latin1() and getCFString() inline. Renamed QStringData to KWQStringData.
kwq/KWQString.mm: (QStringData::QStringData): Remove initializers for the xxxInternal. (QStringData::initialize): Removed some unnecessary if statements, and made a slight improvement in the case of a 0-length string that comes with a pointer for Unicode (can't do it in the char * case because it's a feature that's used). (QString::makeSharedNull): No need to set _isUnicodeInternal. (QStringData::~QStringData): Use the new functions instead of the old bits. (QStringData::increaseAsciiSize): Grow faster when we get to larger sizes where the "good size" call doesn't have as much of an effect. Simplified by removing unneeded code. (QStringData::increaseUnicodeSize): Ditto. (QStringData::makeAscii): Update for removal of _isAsciiInternal. (QStringData::makeUnicode): Update for removal of _isUnicodeInternal. (QString::detachIfInternal): Add this new inline to speed things up for the common case where there's no detaching needed. (QString::at): Simplify, there were excess if branches here. (QString::toDouble): Use kjs_strtod and don't copy the string using QCString for additional speed. (QString::lower): Don't detach if the string is already all lowercase. Added a FIXME about the code that assumes all "ASCII" bytes are truly ASCII. This code blurs the distinction between Latin-1 and ASCII in a way that will not work right for Latin-1 characters in an 8-byte character QString. (QString::detachInternal): Update for removal of _isUnicodeInternal. (QString::detach): Removed a special case for shared_null that was dead code since shared_null has the _isUnicodeValid flag set. (operator==): Rewrote the comparison with char * to avoid the costly call to strlen.

Makefile.am: Updated the rules here so the force clean timestamp works right.
force-clean-timestamp: Touched this since the header dependencies don't seem right for the DOMString constructor change, at least.
WebCore-tests.exp: Exported a symbol now needed by tests since QString does more inlining.
WebCore-combined.exp: Re-generated.

WebBrowser:

Reviewed by Maciej.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

1:04 AM Changeset in webkit [3057] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

slightly improved situation with 3124933 (abcnews.com leads to empty window with sheet complaining about javascript: URL); the popup window still comes up empty but it doesn't put up a sheet.

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::openURLRequest): Handled "javascript:" URLs here.

12:24 AM Changeset in webkit [3056] by gramps

4 edits in trunk/WebKit

Reviewed by darin

Debug/DebugUtilities.m:

(-[DebugUtilities userAgentSubmenuItem]):

Changed "PPC" in one user agent string to "PPC Mac OS X" used for
debugging.

Fixed 3127173 -- REGRESSION: fboweb.com renders incorrectly

Reviewed by darin

English.lproj/StringsNotToBeLocalized.txt:
WebView.subproj/WebController.m:

(-[WebController userAgentForURL:]):

Changed "PPC" in our user agent string to "PPC Mac OS X" in order to
match Mozilla and make the silly server-side user agent string checking
work at fboweb.com. Actually, just "PPC " would work fine at
fboweb.com. Go figure.

Dec 14, 2002:

11:39 PM Changeset in webkit [3055] by hyatt

3 edits in trunk/WebCore

Fix insidemacgames.com. Reinstate rules I removed
and fix other rules to be !important so that the
td[align=right] rules won't affect child tables
with align=center.

Reviewed by gramps

khtml/css/html4.css:

8:43 PM Changeset in webkit [3054] by hyatt

12 edits in trunk/WebCore

Fix for 3016385, menus on webreference.com don't show up.

Fixes to make webreference.com menus show up. This involved
fixing layers to not clip positioned objects when overflow:hidden
is set, fixing the stupid clip/sync layout hack for livepage
so that it doesn't break webreference, and implementing
navigator.productSub (right now the date is set to
Christmas 2002).

Reviewed by gramps/maciej.

khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty):
khtml/ecma/kjs_navigator.h:
khtml/ecma/kjs_navigator.lut.h:
khtml/rendering/render_box.cpp: (RenderBox::getOverflowClipRect):
khtml/rendering/render_box.h:
khtml/rendering/render_flow.cpp: (RenderFlow::layout):
khtml/rendering/render_layer.cpp: (RenderLayer::paint): (RenderLayer::nodeAtPoint): (RenderLayer::constructZTree):
khtml/rendering/render_layer.h:
khtml/rendering/render_object.cpp: (RenderObject::setLayouted):
khtml/rendering/render_object.h:

7:33 PM Changeset in webkit [3053] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Ken.

further corrections to number printing.

kjs/ustring.cpp: (UString::from): Make number printing match the ECMA standard algorithm.

5:48 PM Changeset in webkit [3052] by kocienda

7 edits in trunk/WebCore

Reviewed by Maciej

Fix for this bug:

Radar 3128159 (Netscape non-standard DOM event attribute "which" unsupported)

khtml/dom/dom2_events.cpp: (UIEvent::which): Added which() definition.
khtml/dom/dom2_events.h: Added declarations for which() functions in UIEvent.
khtml/ecma/kjs_events.cpp: (DOMUIEvent::getValueProperty): Added which property.
khtml/ecma/kjs_events.h: Ditto.
khtml/ecma/kjs_events.lut.h: File regenerated.

4:37 PM Changeset in webkit [3051] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Dave.

fix toString() conversion for numbers less than 1. Negative exponents are still wrong though (things like 1E-34).

kjs/ustring.cpp: (UString::from): Don't print empty string for numbers less than 1, and remember to add extra 0s after the decimal for negative decimal positions.

Dec 13, 2002:

7:49 PM Changeset in webkit [3050] by rjw

8 edits in trunk/WebCore

Fixed 3127310 and 3127920.

Implemented findWordBoundary. We now correctly detect word boundaries.
This function makes use of carbon unicode utilities.

With help from hyatt, made selection correctly account for render
continuations. This fixes many of the 'unable to select' issues.

Reviewed by trey and hyatt.

khtml/khtml_events.cpp: (khtml::MouseEvent::offset):
khtml/khtml_part.cpp: (findWordBoundary): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent):
khtml/rendering/render_object.cpp: (RenderObject::checkSelectionPoint):
khtml/rendering/render_object.h:
khtml/rendering/render_text.cpp: (RenderText::checkSelectionPoint):
khtml/rendering/render_text.h:

7:06 PM Changeset in webkit [3049] by mjs

2 edits
1 add in trunk/WebCore

Reviewed by Don.

fixed build.

ForwardingHeaders/rendering/render_layer.h: Added.

6:42 PM Changeset in webkit [3048] by mjs

9 edits in trunk/WebCore

Reviewed by Don.

khtml/dom/dom2_events.cpp: (UIEvent::layerX): Added to support nonstandard Mozilla event.layerX property. (UIEvent::layerY): Added to support nonstandard Mozilla event.layerY property.
khtml/dom/dom2_events.h:
khtml/ecma/kjs_events.cpp: (DOMUIEvent::getValueProperty): Implemented layerX and layerY
khtml/ecma/kjs_events.h:
khtml/ecma/kjs_events.lut.h:
khtml/xml/dom2_eventsimpl.cpp: (MouseEventImpl::MouseEventImpl): Added call to computeLayerPos. (MouseEventImpl::computeLayerPos): Compute layer position. (MouseEventImpl::layerX): Added. (MouseEventImpl::layerY): Added. (MouseEventImpl::initMouseEvent): Added call to computeLayerPos.
khtml/xml/dom2_eventsimpl.h:

6:14 PM Changeset in webkit [3047] by hyatt

3 edits in trunk/WebCore

Fix for 314799, image at wired.com doesn't show up. Block
level replaced floating elements were being treated as though
they didn't float.

Reviewed by gramps

khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

5:28 PM Changeset in webkit [3046] by darin

5 edits in trunk/WebKit

Reviewed by Don.

WebView.subproj/WebController.m: (-[WebController userAgentForURL:]): Add "(like Gecko)" string and change "WebKit" to "AppleWebKit".

English.lproj/StringsNotToBeLocalized.txt: Update for these changes.
Misc.subproj/WebUnicode.h: No need for & 0xFF since we cast to unsigned char.

5:02 PM Changeset in webkit [3045] by hyatt

5 edits in trunk/WebCore

Fix for 3098045.

Do not treat XHTML-style tags e.g., <br/> or <table/> as
self-closing. This is absolutely wrong, and it does not
match the behavior of other browsers. According to the HTML4
spec for parsing, / is an erroneous character and should simply
be dropped, so <table/> should be treated like <table>.

Fixes for crashes on glazman's blog and on tantek's blog. Both
still mis-render, but at least they don't crash.

Reviewed by gramps (and darin too)

khtml/html/htmltokenizer.cpp:
khtml/rendering/render_container.cpp:
khtml/rendering/render_style.cpp:

4:29 PM Changeset in webkit [3044] by sullivan

3 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3028061 -- visiting a bookmarked site that now has a site icon will not update bookmark's icon

No longer store the icon in the WebHistoryItem, since there's no
mechanism for keeping it fresh and telling interested clients
when it changes. Instead, the latest icon is always returned from
the icon database, and it's up to clients to get a fresh one when
they notice that the icon for a URL has been updated.

Reviewed by Darin

History.subproj/WebHistoryItem.h: remove _icon and _loadedIcon ivars

History.subproj/WebHistoryItem.m: (-[WebHistoryItem dealloc]): don't release _icon (-[WebHistoryItem icon]): just return fresh icon from database, don't store (-[WebHistoryItem setURL:]): don't set _loadedIcon to NO

WebBrowser:

WebBrowser part of fix for 3028061 -- visiting a bookmarked site that now has a site icon will not update bookmark's icon

This first cut, which fixes the bug completely, just tosses out
the cached bookmark & history menus & tells the outline view to
redisplay everything. We might improve this later, but in practice
the only difference in behavior that this will cause is to make
the Bookmarks menu rebuild itself from scratch when clicked on
more often. (We can address that multiple ways, probably the best
one being to make rebuilding much faster by using IconRefs instead
of NSImages, see 3120678.)

Reviewed by Darin

BookmarksController.m: (-[BookmarksController awakeFromNib]): register for icon-changed notifications (-[BookmarksController _receivedIconChangedNotification:]): mark menu dirty when any icon has changed

BookmarksViewController.m: (-[BookmarksViewController awakeFromNib]): register for icon-changed notifications (-[BookmarksViewController iconChanged:]): reload outlineview data when any icon has changed. Note that this has no effect when the outlineview is not showing.

GlobalHistory.m: (-[GlobalHistory _registerForHistoryNotifications]): register for icon-changed notifications (-[GlobalHistory receivedIconChangedNotification:]): mark menu dirty when any icon has changed (-[GlobalHistory receivedEntriesChangedNotification:]): removed wayward space character

2:59 PM Changeset in webkit [3043]

3 copies in tags/Alexander-37u1

This commit was manufactured by cvs2svn to create tag
'Alexander-37u1'.

2:59 PM Changeset in webkit [3042] by sheridan

5 edits in trunk

changelog markers for B&I submission (I hope)

2:09 PM Changeset in webkit [3041] by darin

2 edits in trunk/WebKit

WebKit:

Reviewed by Maciej.

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

Reviewed by Maciej.

fix some relatively new messages to use curly apostrophes

AppController.m: (-[AppController confirmEmptyCache:]): One in here.
LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]): Two in here.
English.lproj/Localizable.strings: Generated this.

2:08 PM Changeset in webkit [3040] by trey

2 edits in trunk/WebKit

3108976 - assert _private provisionalItem in -[WebFrame(WebPrivate) _transitionToCommitted
3108865 - frames not maintained going back at directory.apple.com

Both bugs are fixed by the same small change. We no longer try to inherit loadType
across redirects. Instead we just make sure the right thing happens in _transitionToCommitted:
for redirects in the loadType=Standard case.

3122721 - History stores both original and redirected sites

Easy fix while in the neighborhood. We just don't add to History when doing a redirect.

Reviewed by rjw

WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): On redirect, update the URL of the frame's current item, not the current item in the b/f list. Also do not add to history on redirect. (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Cut out funny business that tried to guess when to inherit loadtype across redirects.

1:24 PM Changeset in webkit [3039] by hyatt

7 edits in trunk/WebCore

Two fixes. Bugs are 3121024, which had to do with handling
escaped characters in the CSS content property, and
bug 3127375 (44854 in bugs.kde.org), which had to do with
making sure table cells relayout properly when images load
async.

Reviewed by darin and john

khtml/css/cssparser.cpp: (StyleBaseImpl::parseContent): (StyleBaseImpl::isHexadecimal):
khtml/css/cssparser.h:
khtml/rendering/bidi.cpp: (RenderFlow::layoutInlineChildren):
khtml/rendering/render_flow.cpp: (RenderFlow::layout):
khtml/rendering/render_flow.h:

1:13 PM Changeset in webkit [3038] by darin

6 edits
4 adds in trunk/WebCore

Reviewed by Trey.

moved KWQFontFamily and KWQPageState to new homes

kwq/KWQFontFamily.h: Added.
kwq/KWQFontFamily.mm: Added.
kwq/KWQPageState.h: Added.
kwq/KWQPageState.mm: Added.
WebCore.pbproj/project.pbxproj: Added new source files.

kwq/KWQFont.h: Removed KWQFontFamily.
kwq/KWQFont.mm: Removed KWQFontFamily.
kwq/WebCoreBridge.mm: Removed KWQPageState.

11:24 AM Changeset in webkit [3037] by mjs

7 edits in trunk/WebCore

Reviewed by Ken.

fixed 3083814 - dhtml at www.bayarea.com doesn't hide on some mouse movements

khtml/ecma/kjs_events.h:
khtml/ecma/kjs_events.cpp: (DOMUIEvent::getValueProperty): Implemented pageX and pageY properties.
khtml/ecma/kjs_events.lut.h: Regenerated.
khtml/dom/dom2_events.h:
khtml/dom/dom2_events.cpp: (UIEvent::pageX): Get x coordinate if a mouse event. (UIEvent::pageY): Get y coordinate if a mouse event.

10:49 AM Changeset in webkit [3036] by rjw

12 edits in trunk

WebFoundation:

Fixed 3127225. Provide new SPI to get available system memory.
(Also currently unused SPI to get number of processors.)

Reviewed by gramps.

Misc.subproj/WebSystemBits.h:
Misc.subproj/WebSystemBits.m: (initCapabilities): (WebSystemMainMemory): (WebSystemProcessors):
WebFoundation.exp:
WebFoundation.pbproj/project.pbxproj:

WebCore:

Fixed 3127225. Set WebCore object cache size when first bridge is created.

Reviewed by gramps.

kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge init]):

WebKit:

Fixed 3127225. Scale page cache based on available memory.
Also added support for setting WebCore object cache size via
a preference.
Fixed 3126267. Increase CG glyph cache size if font smoothing
is turned on.

Reviewed by gramps.

History.subproj/WebBackForwardList.m: (+[WebBackForwardList pageCacheSize]):
Misc.subproj/WebKitLogging.h:
Misc.subproj/WebKitLogging.m:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge getObjectCacheSize]):
WebCoreSupport.subproj/WebTextRendererFactory.m: (getAppDefaultValue): (getUserDefaultValue): (getLCDScaleParameters):
WebView.subproj/WebPreferences.m: (+[WebPreferences load]): (-[WebPreferences _pageCacheSize]): (-[WebPreferences _objectCacheSize]):
WebView.subproj/WebPreferencesPrivate.h:

10:27 AM Changeset in webkit [3035] by cblu

2 edits in trunk/WebKit

Fixed: 3105486 - c|net news.com site seems to have lost its favicon again

Reviewed by darin.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _updateFileDatabase]): Only save icons with a size of 16 x 16 since that's the only size we use.

10:04 AM Changeset in webkit [3034] by cblu

2 edits in trunk/WebKit

Catch NULL status strings passed to NPN_Status.

Reviewed by darin.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView status:]): check the incoming string before calling [NSString stringWithCString]

10:03 AM Changeset in webkit [3033] by darin

18 edits in trunk/WebCore

Reviewed by John.

Overall speedup on cvs-base is about 5%.

reduce QString use in the tokenizer and tighten up QString implementation for a speedup
fix up the QFontFamily implementation, using new QString features too, for a speedup

khtml/html/htmltokenizer.h: Take const QString & instead of QString to avoid an extra copy.
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::begin): Use QString::null instead of "" for QString objects; faster. (HTMLTokenizer::scriptHandler): In APPLE_CHANGES, use new prepend that avoids the need to create a temporary QString. Use QString::null instead of QString() for a null string, and also made other small fixes to avoid temporary QStrings. (HTMLTokenizer::setSrc): Take const QString & instead of QString to avoid an extra copy.

kwq/KWQFont.h: Rename QFontFamily to KWQFontFamily. Make family() inline, add inline familyIsEmpty(). Change KWQFontFamily to store both the QString for the family and the NSString instead of only the NSString to avoid constant conversions back and forth. Remove type cases in CREATE_FAMILY_ARRAY that could result in copying the font object.
kwq/KWQFont.mm: (KWQFontFamily::KWQFontFamily): Fix bug where a copied family object would have a random ref count instead of a ref count of 0. Also update for NSString change. (KWQFontFamily::operator=): Use the ref before deref algorithm instead of the check for self-assignment. (KWQFontFamily::getNSFamily): Compute the NSString for the family name here. To avoid making an NSString every time, use a CFDictionary with QString as a key and NSString as a value instead of using an NSSet. (KWQFontFamily::setFamily): Invalidate the NSString family when the QString family is changed. Moved the code to make things unique to getNSFamily. (KWQFontFamily::operator==): Call getNSFamily rather than

kwq/KWQString.h: Added a prepend and insert overload that take a QChar pointer and length, for use in the tokenizer, and a hash function, for use in CFDictionary. Also added a global set of CFDictionaryKeyCallBacks.
kwq/KWQString.mm: (QString::prepend): New overload calls new insert overload. (QString::insert): Old insert slightly tightened by calling detach() only after the early exit and removing an extra detach from a function that already does forceUnicode. Added the new insert that takes a QChar * and a length. (operator==): Rewrite this so that it is efficient and doesn't involve creating a QString temporary or doing a function call. (QString::hash): Wrote this. Used the same hash algorithm I did in my recent KJS work. (retainQString): Added. For use in CFDictionaryKey callback. (releaseQString): Added. For use in CFDictionaryKey callback. (describeQString): Added. For use in CFDictionaryKey callback. (equalQString): Added. For use in CFDictionaryKey callback. (hashQString): Added. For use in CFDictionaryKey callback.

khtml/rendering/font.h: Change name to KWQFontFamily.
khtml/rendering/font.cpp: (Font::update): Call familyIsEmpty() instead of family().isEmpty() to avoid making and destroying a QString every time. Also put this batch of KWQFontFamily-specific changes inside #if APPLE_CHANGES. Much to my dismay, we have others elsewhere that aren't ifdef'd.

khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule): Change name to KWQFontFamily. Clearly this code needs some #if APPLE_CHANGES, and changing the class name helps make that clear.

change KHTMLSettings so using it doesn't require copying QStrings for a speedup

kwq/KWQKHTMLSettings.h: Made all the functions static members to avoid the unnecessary overhead of passing a this pointer. Added lots of setXXX functions for use by the WebCoreSettings code that gets called by WebKit when settings are changed. Return objects by reference because we can and it avoids copying QString objects.
kwq/KWQKHTMLSettings.mm: Changed all the functions in here to return the same global object each time, and made the set functions update those globals.
kwq/WebCoreSettings.mm: All the setters now call through to KHTMLSettings set functions.

fixed 3126513 -- crash in KWQKHTMLPart::clearTimers() deallocating KWQPageState
did some cleanup in the bridge and the part; part of the process of moving real work out of the bridge

kwq/KWQKHTMLPart.h: Rearrange things to be a little more logical. Mark isFrameSet() const. added an attributedString function here so it's not inside WebCoreBridge. Added an overload of clearTimers that takes a view parameter.
kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::isFrameSet): Mark this const.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clearTimers): Add the overload that takes the view parameter. (KWQKHTMLPart::attributedString): Moved this code in here from the bridge.

kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedAttributedString]): Call the attributedString function in its new home in KWQKHTMLPart. (-[WebCoreBridge attributedStringFrom:startOffset:to:endOffset:]): Ditto. (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:]): Take a const KURL & instead of a KURL to avoid unnecessary copying. (-[KWQPageState dealloc]): Call the new clearTimers that takes a view parameter. This should fix the crash in autorelease pool deallocation mentioned above.

1:44 AM Changeset in webkit [3032] by hyatt

9 edits in trunk/WebCore

Fix for 3121865, content missing at disney.com. Make
sure blocks track width overflow as well as height
overflow and ensure that a layer's dimensions expand
to encompass both width and height overflow.

Also fixes a bug with line breaking that allowed unbreakable
words to actually be broken up when they were the only word
on a line. This is wrong and differs from all other
browsers, so the patch in bidi.cpp fixes us to match
other browsers. (This was required to fix the above bug.)

Reviewed by mjs.

khtml/rendering/bidi.cpp: (RenderFlow::findNextLineBreak):
khtml/rendering/render_flow.cpp: (RenderFlow::RenderFlow): (RenderFlow::layout): (RenderFlow::layoutBlockChildren):
khtml/rendering/render_flow.h:
khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
khtml/rendering/render_object.h:
khtml/rendering/render_table.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed