Context Navigation

← Previous Period
Next Period →

Timeline

Dec 19, 2002:

8:59 PM Changeset in webkit [3146]

3 copies in tags/Alexander-42

This commit was manufactured by cvs2svn to create tag 'Alexander-42'.

8:59 PM Changeset in webkit [3145] by sheridan

8 edits in trunk

alexander-42
it's the meaning of life

8:48 PM Changeset in webkit [3144] by sullivan

4 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3124949 -- Alexander recreates the default set of bookmarks every time a separate app copy is launched

Reviewed by Darin

Bookmarks.subproj/WebBookmarkGroup.h: new _tag ivar and -tag method.

Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup dealloc]): release _tag (-[WebBookmarkGroup tag]): return _tag (-[WebBookmarkGroup _loadBookmarkGroupGuts]): read _tag from the dictionary in the file (or leave it at nil if there's no value in the file).

English.lproj/StringsNotToBeLocalized.txt: kept this file up to date

WebBrowser:

WebBrowser part of fix for 3124949 -- Alexander recreates the default set of bookmarks every time a separate app copy is launched

Reviewed by Darin

BookmarksController.m: (-[BookmarksController mergeBuiltInBookmarksIfNecessary]): if the mod date has changed since the last time this was checked, check the tag in the bookmarks group (loaded from the file) to see if it has changed. If the tag hasn't changed, then don't merge the built-in bookmarks.

PreferenceKeys.h: new #define BuiltInBookmarksTagPreferenceKey

English.lproj/BuiltInBookmarks.plist: Added tag (happens to be string that looks like a date) to this file. We'll update this whenever we update the contents.

5:50 PM Changeset in webkit [3143] by hyatt

10 edits in trunk/WebCore

Fix for 3129393, crasher on sundancecatalog.com. There
are two elements to this fix. The basic problem was that
sundancecatalog was saying:

<table style="display: inline">

In WinIE, this turns into an inline-table and not an inline.
In Gecko this does not happen. Like Gecko, we treated this
as an inline, so we triggered a problem in my inline splitting
code.

The first fix was to bulletproof my inline splitting code to
ensure all new render objects are fully connected before children
are added, so that you can get to renderArenas at all times.

The second fix implements the WinIE quirk and turns the table
into an inline-table so that you avoid a complete garbage
render tree.

Reviewed by trey

khtml/css/html4.css:
khtml/rendering/render_flow.cpp: (RenderFlow::layout): (RenderFlow::splitFlow): (RenderFlow::addChildToFlow):
khtml/rendering/render_flow.h:
khtml/rendering/render_list.cpp: (RenderListMarker::lineHeight):
khtml/rendering/render_list.h:
khtml/rendering/render_object.cpp: (RenderObject::createObject):
khtml/rendering/render_table.cpp: (RenderTable::lineHeight): (RenderTable::baselinePosition): (RenderTable::setStyle):
khtml/rendering/render_table.h:

2:17 PM Changeset in webkit [3142] by darin

3 edits in trunk/WebCore

Reviewed by John.

A number of non-reproducible bugs look like they may be due to bad
event objects. I was assuming that callers retained the events until
the functions handling them returned, but that assumption may be wrong.
So I'm retaining/releasing the current event. This is correct in any case.
I'm also adding a new assertion, but since assertions are in Development
builds only that is very low risk.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::keyEvent): Add retain/release and a new assertion. (KWQKHTMLPart::mouseDown): Ditto. (KWQKHTMLPart::mouseDragged): Ditto. (KWQKHTMLPart::mouseUp): Ditto. (KWQKHTMLPart::mouseMoved): Ditto.

12:33 PM Changeset in webkit [3141] by darin

1 edit in trunk/WebKit/ChangeLog

Added missing bug # to log.

12:19 PM Changeset in webkit [3140] by darin

3 edits in trunk/WebKit

WebKit:

Reviewed by John.

corrected the name of a method that was leading to trouble elsewhere

WebView.subproj/WebDataSource.h: Change fileType to fileExtension for clarity.
WebView.subproj/WebDataSource.m: (-[WebDataSource fileExtension]): Ditto.

WebBrowser:

Reviewed by John.

fixed 3132671 -- REGRESSION: Saving an HTML file with Safari doesn't append .html (its used to)

BrowserDocument.m: (-[BrowserDocument fileType]): Call [NSDocumentController typeFromFileExtension:] instead of using the extension as the file type, which only works if you happen to have a file type that's named exactly the same as the extension.
HTMLSourceDocument.m: (-[HTMLSourceDocument fileType]): Ditto.

WebBrowser.pbproj/project.pbxproj: Added capitalized file types, fixed .jp2 to be separate from .jpg, These came from looking over NSImage's file type list.
English.lproj/InfoPlist.strings: Added JPEG 2000.

12:17 PM Changeset in webkit [3139] by sheridan

3 edits in trunk

version 42u

12:07 PM Changeset in webkit [3138]

3 copies in tags/Alexander-41

This commit was manufactured by cvs2svn to create tag 'Alexander-41'.

12:07 PM Changeset in webkit [3137] by sheridan

8 edits in trunk

Alexander-41 going to B&I

10:14 AM Changeset in webkit [3136] by darin

2 edits in trunk/WebKit

Reviewed by John.

probably fixed 3129395 -- Reproducible crash when running a javascript at www.scenespot.org

WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): Close the window. Before we relied on it being released which was bad. But it's not clear this actually was the cause of the bug.

10:08 AM Changeset in webkit [3135] by darin

2 edits in trunk/WebKit

Reviewed by Chris.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Added an assert. (-[WebBaseNetscapePluginView setWindow]): Added an assert. (-[WebBaseNetscapePluginView stop]): Cancel perform requests, now that we are using them for URL navigation. (-[WebBaseNetscapePluginView frameStateChanged:]): Only notify if the plugin is still running. (-[WebBaseNetscapePluginView loadPluginRequest:]): Added. Does the actual load at idle time. Also fixed to only notify if plugin is loaded. Added a number of FIXMEs for other problems here. Also send JavaScript to the appropriate frame, not always the top level. (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Use loadPluginRequest: to do the request after a delay. Also remove the special cases for special frame names; they were trying to avoid calling a plugin that has gone away, but we do that a better way now. (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): Added logging. (-[WebBaseNetscapePluginView status:]): Use Windows Latin-1 rather than MacRoman for messages. I guess we should test later to find out which is used by MacIE and conform to that, but for now this seems like a better default. (-[WebPluginRequest initWithRequest:frame:notifyData:]): Added. (-[WebPluginRequest dealloc]): Added. (-[WebPluginRequest request]): Added. (-[WebPluginRequest webFrame]): Added. (-[WebPluginRequest notifyData]): Added.

Dec 18, 2002:

10:34 PM Changeset in webkit [3134] by rjw

3 edits in trunk/WebCore

Added an ASSERT to ensure that 3127329 isn't still happening.
This bug should have been fixed be earlier changes.

Reviewed by darin.

kwq/KWQPageState.mm: (-[KWQPageState dealloc]):

10:18 PM Changeset in webkit [3133] by cblu

3 edits in trunk/WebCore

Fixed: 3131267 - REGRESSION: Java 1.4.1 Applets Restarted When Window is Resized
Fixed: 3131244 - REGRESSION: Java 1.4.1 Multiple Copies of Applet Started When Window is Resized

Dave recently patched khtml with a fix for media content inside of table cells. The patch causes the java widget to get the layout call more than once. Calling layout more than once is perfectly allowed, but the java widget wasn't prepared for that and would create a new java view for each layout. We now only create a java view when the java view hasn't already been created.

Reviewed by darin.

kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet): If the view of the widget is still a KWQView, we haven't replaced it with the Java view. This stops multiple view from being created.

10:17 PM Changeset in webkit [3132] by darin

2 edits in trunk/WebKit

Reviewed by Chris.

fixed fix for 3132056 -- Supply Finder bits for decoded BinHex files

Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeHeader]): Mask off fewer Finder flag bits. Use the same mask as for MacBinary, in fact.

9:49 PM Changeset in webkit [3131] by darin

3 edits in trunk/WebKit

Reviewed by Richard.

fixed 3127490 -- pages w/frames sometimes show up blank

WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Updated the optimization where we draw the entire view if we did a layout so that it works properly for the case where the clip is narrower because of the parent WebHTMLView.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

8:17 PM Changeset in webkit [3130]

3 copies in tags/Alexander-40

This commit was manufactured by cvs2svn to create tag 'Alexander-40'.

8:17 PM Changeset in webkit [3129] by sheridan

8 edits in trunk

Alexander-40 stamp

7:44 PM Changeset in webkit [3128] by trey

8 edits in trunk

WebCore:

3098388 - Pressing the back button goes back two levels at allmusic.com

In support of the fix for this bug, WebCore passes khtml's lockHistory setting
up through the bridge.

Reviewed by Darin

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Pass it along.
kwq/WebCoreBridge.h:

WebKit:

3098388 - Pressing the back button goes back two levels at allmusic.com

I rewrote the logic we use to decide whether a given redirect should be
treated as part of the previous navigation. We make use of WebCore's
lockHistory setting, the delay time and the frame state.

Reviewed by Darin.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectToURL:delay:fireDate:lockHistory:]): Pass lockHistory up to the frame.
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:]): New logic. No quick summary, best to read the code.

7:21 PM Changeset in webkit [3127] by cblu

4 edits in trunk/WebKit

WebKit:

Reject the RealPlayer plug-in because we know it doesn't work.

Reviewed by sullivan.

English.lproj/StringsNotToBeLocalized.txt:
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]): reject the RealPlayer plug-in

WebBrowser:

Fixed: 3103603 - Safari becomes unresponsive while launching DiskCopy
Special case RealPlayer and WMP plug-ins. Provide the option to open the content in the apps.

Reviewed by sullivan.

BrowserNSWorkspaceExtras.m: (-[NSWorkspace launchApplicationAtPath:processSerialNumber:makeFrontmost:event:]): enable async launching of DiskCopy
English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt:
LoadProgressMonitor.m: (-[LoadProgressMonitor pluginFailedWithError:dataSource:]): special case RealPlayer and WMP plug-ins. Provide the option to open the content in the apps.

5:58 PM Changeset in webkit [3126] by mjs

11 edits in trunk

Tools:

Reviewed by John.

fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

Scripts/set-alex-version: New the script takes 3 different versions, source version, marketing version and internal version.

JavaScriptCore:

Reviewed by John.

fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

English.lproj/InfoPlist.strings:
JavaScriptCore.pbproj/project.pbxproj:

WebFoundation:

Reviewed by John.

fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

English.lproj/InfoPlist.strings:
WebFoundation.pbproj/project.pbxproj:

WebCore:

Reviewed by John.

fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

English.lproj/InfoPlist.strings:

WebKit:

Reviewed by John.

fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

English.lproj/InfoPlist.strings:

WebBrowser:

Reviewed by John.

fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

English.lproj/InfoPlist.strings:
WebBrowser.pbproj/project.pbxproj:

5:13 PM Changeset in webkit [3125] by rjw

2 edits in trunk/WebKit

Fixed 3129951. Don't allow pages that are stopping to enter the page cache.
(Fixed yesterday, forgot to checkin.)

Reviewed by trey.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]):

4:54 PM Changeset in webkit [3124] by mjs

21 edits in trunk

WebFoundation:

Reviewed by Trey and Darin.

Minor fixes required to fix these bugs:

3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
3091248 - picture does not show up in window from epinions

CacheLoader.subproj/WebResourceResponse.h: Don't include uninstalled headers in this private but installed header.
ProtocolHandlers.subproj/WebAboutProtocolHandler.m: (-[WebAboutProtocolHandler setResponseMetadata:]): "about:blank" should be a blank html document, not a blank plain text document.
Misc.subproj/WebNSURLExtras.h:
Misc.subproj/WebNSURLExtras.m: (-[NSString _web_shouldLoadAsEmptyDocument]): New method.
English.lproj/StringsNotToBeLocalized.txt: Updated.

WebCore:

Reviewed by Trey and Darin.

fixed 3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
fixed 3091248 - picture does not show up in window from epinions

khtml/ecma/kjs_window.cpp: (Window::get): Put back document-creating code that was in #if !APPLE_CHANGES. (Window::isSafeScript): Extend access to a window that was opened to no URL or to about:blank by the active window. (shouldLoadAsEmptyDocument): Helper for the above. (WindowFunc::tryCall): Update APPLE_CHANGES comments - now it's clear we don't need to create a document in a fresh window (accessing document will take care of that), and that it will be counter-productive, possibly adding a useless entry to the back/forward list.
khtml/khtml_part.cpp: (KHTMLPart::begin): If we're not loading a URL, make a dummy document (the call will check if we have a dummy document already).
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createEmptyDocument): Isntead of setting up a half-assed document, ask bridge to synchronously load a fully assed (but empty) document. Renamed from createDummyDocument.
kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::openURLRequest): Decode script. Also, check if return value is a string - if so, write it into the document. Maybe we want this to be more general.
kwq/KWQKURL.mm: (KURL::KURL): Changed to successfully resolve absolute URLs against an empty base URL.
kwq/WebCoreBridge.h: prototyped new loadEmptyDocumentSynchronously method.

WebKit:

Reviewed by Darin and Trey.

fixed 3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
fixed 3091248 - picture does not show up in window from epinions
made "about:blank" load synchronously, which I'm told is required by some sites.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): If the URL is nil or empty, pass a nil request - otherwise WebBrowser will try to load it, resulting in an extra back/forward list entry. (-[WebBridge loadEmptyDocumentSynchronously]): Tell the frame to load a request with an empty URL - this will cause a synchronous load of an empty html document
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): Split off startLoading: part of method to allow behavior to be subclassed. (-[WebBaseResourceHandleDelegate startLoading:]):
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]): Lie and claim the URL is "about:blank" if it's really empty to avoid confusing WebCore.
WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): Don't put the empty URL in global history. (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]): Don't check policy if URL is empty - this is likely to confuse the client and we know what the right behavior here is.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient startLoading:]): Try to load "about:blank" and the empty URL synchronously, bypassing WebFoundation. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto. (-[WebMainResourceClient setDefersCallbacks:]): Ditto.
English.lproj/StringsNotToBeLocalized.txt: Updated.

4:07 PM Changeset in webkit [3123] by cblu

9 edits in trunk

WebCore:

Fixed: 3052731 - qt file complains about lack of active-x handler
Fixed: 3025872 - Black square where lion should be on mgm.com

3052731: The page has a syntax error. Notice the missing ">"? He treat this as an OBJECT without an EMBED. khtml actually has a fallback for this. They check the classid and map a mime type to it. They currently map for realaudio and flash, but not quicktime. I added a quicktime mapping as well as a mapping for shockwave.

3025872: khtml was unable to parse the EMBED tag within the OBJECT tag (similar to 3052731). When this happens, it looks at the classid and maps it to a mime type. This part was successful because it has a classid->mime type mapping for flash. The strange thing was that it was setting the main URL of the plug-in to "dummy". The code has this comment:

url = "dummy"; Not needed, but KHTMLPart aborts the request if empty

It does this even if the url is valid. It even handles the invalid url case before even calling the part. The fix is to disable this line of code.

Reviewed by trey.

khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):

WebKit:

Fixed: 2862385 - need to pass browser's user agent and version to plug-ins
Added some more error checking to the plug-in code

Reviewed by trey.

Plugins.subproj/WebBaseNetscapePluginView.h:
Plugins.subproj/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView setCurrentPluginView:]): new, sets a global variable for the current plug-in (+[WebBaseNetscapePluginView currentPluginView]): new, returns the current plug-in (-[WebBaseNetscapePluginView start]): check if NPP_New fails, return NO if it does, set the current plug-in view. Currently, this is the only place we need to do this. (-[WebBaseNetscapePluginView userAgent]): made instance-specific because it depends on the plug-in view's WebController
Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]): don't start the stream is start fails
Plugins.subproj/npapi.m: (NPN_MemAlloc): tweak (NPN_RequestRead): tweak (pluginViewForInstance): returns the instance's plug-in view if it has one, if not, return the current plug-in view (NPN_GetURLNotify): get the instance from pluginViewForInstance (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_UserAgent): (NPN_Status): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw): (NPN_GetValue): (NPN_SetValue): (NPN_GetJavaEnv): (NPN_GetJavaPeer):

2:40 PM Changeset in webkit [3122] by rjw

5 edits in trunk/WebKit

Fixed 3109590. We now set the cookie policy URL to a frame's URL if the
contents of the frame changes as a result of user action. The site mentioned
is this bug branded a service by wrapping it in their own frameset. That frameset
had a different domain than the service, so our cookie policy prevented cookies
from being set.

Reviewed by trey.

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]):
WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]):
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):

12:46 PM Changeset in webkit [3121] by cblu

4 edits
2 adds in trunk/WebKit

Fixed: 3131714 - System becomes unresponsive while downloading

While downloading a file, Safari and the Finder take up 30%-40% of the CPU each. This is happening because for every chunk of data we write to disk, we call -[NSWorkspace noteFileSystemChanged:]. noteFileSystemChanged is inefficient. It sends 2 AppleEvents each with 60 timeouts. The event also causes the Finder to do a lot of work.

We should:

Send 1 AppleEvent ourselves with no timeout since we don't care about the reply
Call the notification/event less often. The only benefit of sending the event for every chunk written is that the file size updates in the Finder. Not worth the performance impact.

Reviewed by kocienda.

Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): call _web_noteFileChangedAtPath (-[WebDownloadHandler createFileIfNecessary]): call _web_noteFileChangedAtPath (-[WebDownloadHandler writeDataForkData:resourceForkData:]): don't call noteFileSystemChanged (-[WebDownloadHandler finishedLoading]): call _web_noteFileChangedAtPath
Misc.subproj/WebNSWorkspaceExtras.h: Added.
Misc.subproj/WebNSWorkspaceExtras.m: Added. (-[NSWorkspace _web_noteFileChangedAtPath:]): Notifies the Finder (or any other app that cares) that we added, removed or changed the attributes of a file. This method is better than calling noteFileSystemChanged: because noteFileSystemChanged: sends 2 apple events both with a 60 second timeout. This method returns immediately.
WebKit.pbproj/project.pbxproj:

3:47 AM Changeset in webkit [3120] by darin

2 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3098293 -- Shockwave plug-in doesn't work

The problem is that the Shockwave plug-in depends on being able to do LMGetCurApRefNum
and then do a PBGetFCBInfoSync on the result, and if it gets an error it will refuse
to initialize.

Plugins.subproj/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage initialize]): Supply a bogus CurApRefNum. Do it only if CurApRefNum is -1, so we don't screw things up if we are used in a Carbon application.

12:15 AM Changeset in webkit [3119] by trey

4 edits in trunk/WebCore

3105755 - can't log in to amex

The problem was on c/r khtml would not pick a submit button to add to the
form state that is sent. We now "activate" the first submit button that meets the
criteria for being a "successful" form element, if no button was already
activated by being clicked on.

Reviewed by Darin.

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submit): Pick a submit button to use, if none was already chosen by virtue of being clicked. (HTMLButtonElementImpl::isSuccessfulSubmitButton): New getter to support submit button selection. (HTMLButtonElementImpl::isActivatedSubmit): New getter on existing prop. (HTMLButtonElementImpl::setActivatedSubmit): New setter on existing prop. (HTMLInputElementImpl::isSuccessfulSubmitButton): New getter to support submit button selection. (HTMLInputElementImpl::isActivatedSubmit): New getter on existing prop. (HTMLInputElementImpl::setActivatedSubmit): New setter on existing prop.
khtml/html/html_formimpl.h: Add new methods to common superclass.

Dec 17, 2002:

11:49 PM Changeset in webkit [3118] by gramps

8 edits in trunk/WebCore

Reviewed by Joyce Chow.

khtml/misc/arena.cpp:
khtml/misc/arena.h:
khtml/rendering/render_arena.cpp:
khtml/rendering/render_arena.h:
khtml/rendering/render_layer.cpp:
khtml/rendering/render_layer.h:

Changed copyright and licensing.

11:33 PM Changeset in webkit [3117] by hyatt

3 edits in trunk/WebCore

NOWRAP was completely broken. This fixes the problem
and makes porsche.com look ok again.

Bug #3131287.

Reviewed by gramps

khtml/rendering/bidi.cpp: (RenderFlow::findNextLineBreak):

10:26 PM Changeset in webkit [3116]

5 copies in tags/Alexander-38-fat

This commit was manufactured by cvs2svn to create tag
'Alexander-38-fat'.

10:26 PM Changeset in webkit [3115] by darin

11 edits in trunk

JavaScriptCore:

Reviewed by Trey.

JavaScriptCore.pbproj/project.pbxproj: Removed signature.

WebFoundation:

Reviewed by Trey.

WebFoundation.pbproj/project.pbxproj: Remove signature.

WebCore:

Reviewed by Trey.

WebCore.pbproj/project.pbxproj: Remove signature.
kwq/KWQColor.mm: Turn off inlining so we can build even on the compiler that warns about static data in inline functions.

WebKit:

Reviewed by Trey.

WebKit.pbproj/project.pbxproj: Remove signature.
WebView.subproj/WebController.m: Turn off inlining so we can build even on the compiler that warns about static data in inline functions.

WebBrowser:

Reviewed by Trey.

Scripting.subproj/Safari.scriptSuite: Change signature to sfri.
WebBrowser.pbproj/project.pbxproj: Change signature to sfri.

8:17 PM Changeset in webkit [3114] by sullivan

2 edits in trunk/WebKit

WebKit:

fixed 2895826 -- ICON: Need a "no plug-in" icon

Resources/nullplugin.tiff: new plug-in icon. Blue 3-D lego with question marks.

WebBrowser:

fixed 312965 -- SJ: Need Home button art with thinner lines
also added an all-purpose document icon with a compass instead of a spider, and a tweaked version of the app icon

Resources/Images/Home.tif:
Resources/Images/HomeDisabled.tif:
Resources/Images/HomePressed.tif:
Resources/compass.icns: new versions

document.icns: Removed. this was the spider, he's gone now but his name remains.

Resources/document.icns: Added. put it in here with the app icon.

WebBrowser.pbproj/project.pbxproj: updated for new/removed files

7:41 PM Changeset in webkit [3113] by rjw

2 edits in trunk/WebKit

Added support for Aki's 20% boost to line height. This is
done with a horrible hack and should be removed when 3129490
is fixed.

Reviewed by hyatt.

WebCoreSupport.subproj/WebTextRenderer.m:

7:24 PM Changeset in webkit [3112] by mjs

3 edits in trunk/WebCore

Reviewed by John.

fixed 3120729 - HOMEPAGE: Can't set a DIV innerHTML property with html content starting with <html><head><head/><body>

khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Pop <html> and <body>, and remove <head> to allow a full HTML document to be made and inserted as a contextual fragment.

7:20 PM Changeset in webkit [3111]

3 copies in tags/Alexander-39

This commit was manufactured by cvs2svn to create tag 'Alexander-39'.

7:20 PM Changeset in webkit [3110] by sheridan

9 edits in trunk

Alexander-39, submitting to B&I

4:53 PM Changeset in webkit [3109] by hyatt

3 edits in trunk/WebCore

Make sure that anonymous block construction works properly
when you try to insert a block in between two inlines that
have already been wrapped in an anonymous block.

Reviewed by mjs

khtml/rendering/render_flow.cpp: (RenderFlow::addChildToFlow): (RenderFlow::makeChildrenNonInline):

4:34 PM Changeset in webkit [3108]

3 copies in tags/Alexander-38

This commit was manufactured by cvs2svn to create tag 'Alexander-38'.

4:34 PM Changeset in webkit [3107] by sheridan

9 edits in trunk

Alex-38

3:41 PM Changeset in webkit [3106] by rjw

2 edits in trunk/WebKit

Fixed 3127932. Added WebFrameLoadTypeReloadAllowingStaleData to cases that do not
get cached in the b/f cache.

Reviewed by trey.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]):

2:53 PM Changeset in webkit [3105] by rjw

2 edits in trunk/WebKit

Fixed 3128794. Use CG directy to get font metrics rather than the appkit. The appkit
has a bug that sometimes causes line height to be 20% too large.

2:12 PM Changeset in webkit [3104] by trey

9 edits in trunk/WebKit

WebKit:

Reworking the code to update the page icon led me to roll the WebIconDB API
for URL to NSString. In addition, the vestigial "Site" was removed.

Everything below is renaming, except where noted.

Reviewed by Darin

English.lproj/StringsNotToBeLocalized.txt:
History.subproj/WebHistoryItem.m: (-[WebHistoryItem _retainIconInDatabase:]): (-[WebHistoryItem icon]):
Misc.subproj/WebIconDatabase.h:
Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): Use _web_isFileURL. (-[WebIconDatabase iconForURL:withSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase _iconDictionariesAreGood]): (-[WebIconDatabase _loadIconDictionaries]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _iconForFileURL:withSize:]): Cons up a NSURL to get the path. Test explicitly for .htm and .html suffixes. (-[WebIconDatabase _setIcon:forIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _releaseIconForIconURLString:]): (-[WebIconDatabase _retainFutureIconForURL:]): (-[WebIconDatabase _releaseFutureIconForURL:]): (-[WebIconDatabase _sendNotificationForURL:]):
Misc.subproj/WebIconDatabasePrivate.h:
Misc.subproj/WebIconLoader.m: (-[WebIconLoader handleDidFinishLoading:]):
WebKit.exp:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _loadIcon]):

WebBrowser:

3127109 - REGRESSION: generic favicon shown while page from same domain is loading

We now avoid jumping to the generic icon when we're loading and are moving
to a URL within the same domain as the current one.

In addition, some name changes for the URL->NSString changes in the WebIconDB API.

Reviewed by John

BookmarkSource.m: (-[BookmarkSource imageForContentItem:]): Adopt API change.
BrowserWindowController.h: New ivar, _acceptsGenericIcon.
BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Init new ivar. (-[BrowserWindowController acceptsGenericIcon]): New getter. (-[BrowserWindowController setAcceptsGenericIcon:]): New setter. (-[BrowserWindowController updateLocationFieldIcon]): Obey new ivar as to we will accept a generic icon when updating.
LocationChangeHandler.m: (-[LocationChangeHandler locationChangeStartedForDataSource:]): If the new URL is in the same site as the old one, avoid accepting a generic icon. (-[LocationChangeHandler locationChangeDone:forDataSource:]): Reset _acceptsGenericIcon
NewBookmarksController.m: (-[NewBookmarksController awakeFromNib]): Adopt API change.
TitleBarButton.m: (-[TitleBarButton drawPathRepresentingPopUpMenuForEvent:URL:]): Adopt API change.

1:58 PM Changeset in webkit [3103] by cblu

3 edits in trunk/WebKit

WebFoundation:

Fixed: 3113073 - link on http://studio.adobe.com/explore/ redirects to not found page in Alex

Reviewed by darin.

Misc.subproj/WebNSStringExtras.m: (-[NSString _web_looksLikeAbsoluteURL]): trim whitespace because _web_URLWithString allows whitespace
Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithString:]): trim whitespace because we shouldn't replace spaces with escape characters (+[NSURL _web_URLWithString:relativeToURL:]): trim whitespace because we shouldn't replace spaces with escape characters

WebKit:

Fixed: 3113073 - link on http://studio.adobe.com/explore/ redirects to not found page in Alex

Reviewed by darin.

Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]): don't trim whitespace because _web_URLWithString does this for us
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView pluginURLFromCString:]): tweak

11:15 AM Changeset in webkit [3102] by darin

2 edits in trunk/WebKit/Misc.subproj

Reviewed by Darin.

fixed build; WebFileDatabase was importing a file that is internal

Database.subproj/WebFileDatabase.h: Don't import WebLRUFileList.h.
Database.subproj/WebFileDatabase.m: Do import WebLRUFileList.h.

11:05 AM Changeset in webkit [3101] by sullivan

4 edits in trunk/WebKit

WebKit:

to help with performance of various bookmark operations, added a call that returns the internal array of children, to complement the safer call that returns a copy.

Reviewed by Darin

Bookmarks.subproj/WebBookmark.h: commented -children and new -rawChildren
Bookmarks.subproj/WebBookmark.m: (-[WebBookmark rawChildren]): new method, returns nil at this level. (-[WebBookmark contentMatches:]): use -rawChildren instead of -children

Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList rawChildren]): new method, returns internal array without copying

WebBrowser:

fixed 3129823 -- displaying many bookmarks in outline view is very slow

Deployed new rawChildren call everywhere appropriate in WebBrowser. This
prevents a lot of array-creation. On my machine, the time it takes to
display a folder containing 1000 items went from 0.96 sec to 0.0084 sec.

Reviewed by Darin

BookmarksController.m: (-[BookmarksController addChildrenOfBookmark:toMenu:]): (-[BookmarksController goToNthFavoriteLeaf:]): (-[BookmarksController _addBookmarksToMenu]): (-[BookmarksController mergeBookmarksFrom:to:]): (-[BookmarksController mergeBuiltInBookmarksIfNecessary]): (-[BookmarksController importInternetExplorerFavorites]): (-[BookmarksController updateBookmarkSources]): (-[BookmarksController favoriteBookmarks]): (-[BookmarksController addFavoriteBookmark:atIndex:]): (-[BookmarksController recursivelyAddChildFoldersOf:toMenu:withIndentationLevel:]): use -rawChildren instead of -children

BookmarksViewController.m: (-[BookmarksViewController newContentItemWithTitle:URLString:type:positionIgnoresSelection:]): use -rawChildren instead of -children (-[BookmarksViewController bookmarkSources]): use -rawChildren instead of -children (-[BookmarksViewController refreshContents]): log timing (-[BookmarksViewController canRemoveBookmarkSource:]): use -rawChildren instead of -children (-[BookmarksViewController deleteSelectedContentItems]): log timing (-[BookmarksViewController child:ofContentItem:usingSource:]): use -rawChildren instead of -children (-[BookmarksViewController outlineView:validateDrop:proposedItem:proposedChildIndex:]): use -rawChildren instead of -children (-[BookmarksViewController paste:]): log timing; use -rawChildren instead of -children (-[BookmarksViewController initWithBookmark:bookmark:]): use -rawChildren instead of -children

(+[CompletionController _addBookmarkTree:]):
use -rawChildren instead of -children
(+[CompletionController _removeBookmarkTree:]):
use -rawChildren instead of -children

FavoriteButton.m: (-[FavoriteButton _contentsMenu]): use -rawChildren instead of -children

WebBrowser.pbproj/project.pbxproj: version wars

9:20 AM Changeset in webkit [3100] by kocienda

2 edits in trunk/WebKit/Misc.subproj

Reviewed by Darin

Fix for this bug:

Radar 3128631 (WebFileDatabase walks its whole directory tree to expire files)

Complete reworking of the way in which the disk cache database keeps track
of the files on disk. This should result in fewer I/O operations, and
should fix the extremely bad behavior that involved walking the entire
disk cache tree evey time a single file needed to be deleted.

Database.subproj/WebFileDatabase.h: Use new WebLRUFileList code.
Database.subproj/WebFileDatabase.m: Ditto.
Database.subproj/WebLRUFileList.h: Added.
Database.subproj/WebLRUFileList.m: Ditto.
Misc.subproj/WebFoundationLogging.h: Added WebFoundationLogWebFileDatabaseActivity channel
Misc.subproj/WebFoundationLogging.m: Ditto
WebFoundation.pbproj/project.pbxproj: Added WebLRUFileList.

12:54 AM Changeset in webkit [3099] by darin

1 edit in trunk/WebCore/config.h

top level:

Reviewed by Maciej.

remove leftover bits of NO_LICENSE

acconfig.h: Remove NO_LICENSE.
configure.in: Remove all the NO_LICENSE-related bits.

WebBrowser:

Reviewed by Maciej.

remove leftover bits of NO_LICENSE

WebBrowser.pbproj/project.pbxproj: Remove build styles setting HAVE_CONFIG_H and also INCLUDE_TEST_SUITE too, because that hasn't been used anywhere for like forever.

12:09 AM Changeset in webkit [3098] by darin

183 edits
1 delete in trunk

top level:

Reviewed by Don and Maciej.

force-clean-timestamp: Trigger a full build since we are setting MACOSX_DEPLOYMENT_TARGET to 10.2, which requires remaking all PFEs.

Tools:

Scripts/check-copyright: Added.

JavaScriptCore:

Reviewed by Don and Maciej.

fixed 3129115 -- need Apple copyright added to open source documents

tons of files: Added our copyright to files we modified, and updated all to standard format.

other changes

JavaScriptCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2. Also removed completion.cpp.
kjs/completion.cpp: Removed.
kjs/completion.h: Made the Completion constructor inline.

kjs/grammar.y: Removed an obsolete "pretend ifdef". No need to put these in APPLE_CHANGES now.

WebFoundation:

Reviewed by Don and Maciej.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
WebFoundation.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.

WebCore:

Reviewed by Don and Maciej.

fixed 3129115 -- need Apple copyright added to open source documents

tons of files: Added copyright message to files we modified and standardized format of copyrights too.

fixed 3129235 -- assert in LRUList visiting apple.com if "Display images" preference is off

khtml/misc/loader.cpp: (Cache::getLRUListFor): Use the first list for 0-sized objects. (Cache::removeFromLRUList): Allow 0-sized objects.

other changes

khtml/rendering/render_style.h: Remove bogus unused private constructor.

kwq/KWQFont.h: Added copy constructor and assignment operator.
kwq/KWQFont.mm: (QFont::QFont): Copy constructor now retains the NSFont. The old version didn't which could cause retain/release problems. (QFont::operator=): Retain the new NSFont and release the old one.

WebCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.

WebKit:

Reviewed by Don and Maciej.

WebView.subproj/WebUserAgentSpoofTable.gperf: Added a couple of new domains to the list we spoof as Mac IE, and added comments.
WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.

WebKit.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2

WebBrowser:

Reviewed by Don and Maciej.

fixed 3106686 -- Remove "world leak" debugging window before beta

Test/PageLoadTestController.m: (-[PageLoadTestController windowDidLoad]): (Not part of the bug fix.) Changed the combo box so it automatically sizes to the number of pltsuite files so we don't have to edit the nib all the time. (-[PageLoadTestController anyWindowWillClose:]): Don't do any world leak test when the window closes. The one in the page load test window is still there.

Debug/DebugUtilities.m: (-[NSApplication validate_toggleAlwaysCheckForWorldLeaks:]): Don't enable or check the debug menu item at all. Put an ifdef in so we can turn it on later.

fixed 3124310 -- remove "app refuses to launch" code before shipping

main.m: (main): Remove all the licensing code.

other changes

BrowserNSNetServiceExtras.m: Made all locally-defined-and used functions static so we would know if any were unused and for cleanliness. (-[NSNetService hostName:andPort:]): Remove some silly assertions. (decode_name): Change printf for errors to ERROR. (decode_srv): Ditto. (decode_txt): Removed because it's unused. (skip_question): Ditto. (MyDictionaryKeyHashCallBack): Removed silly assertion. (MyCreateCFDictionaryFromTXT): Ditto.

WebBrowser.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2

Dec 16, 2002:

11:00 PM Changeset in webkit [3097] by mjs

7 edits in trunk/WebCore

Reviewed by Darin.

fixed 3125283 - HOMEPAGE: in onload of an IMG, the width and height are equal to zero

There were two problems here. First, the calls to get image width
and height didn't force a layout in all the cases where it was
required. Second, layout wouldn't lay out images at all until
parsing was done, due to a hack to block inline layout until that
point. I'm not sure if this will have other bad consquences, but
nearly every page I tried, including Hebrew and Japanese pages as
well as every page on the base PLT laid out properly.

khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): Force a layout if not laid out. (HTMLImageElementImpl::height): Likewise.
khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Remove setBlockBidi hack - this was preventing images from getting laid out until the document was totally done parsing.
khtml/rendering/render_flow.cpp: (RenderFlow::RenderFlow): More setBLockBidi removal. (RenderFlow::layout): Likewise. (RenderFlow::close): Likewise. (RenderFlow::addChildToFlow): Likewise. (RenderFlow::printTree): Likewise.
khtml/rendering/render_flow.h:
khtml/rendering/render_object.h:

6:30 PM Changeset in webkit [3096] by sheridan

3 edits in trunk

forgot to check in new sourceversion earlier - 38

5:51 PM Changeset in webkit [3095] by hyatt

4 edits in trunk/WebCore

When a clear occurs (thus causing a block to move underneath
a float), make sure the block gets a fresh layout, so that it
can readjust its contents now that they don't have to flow
around the float.

Reviewed by darin

khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):

5:38 PM Changeset in webkit [3094] by cblu

2 edits in trunk/WebKit

Fixed: 3129503 - Crash cancelling download after closing browser window that started download

Reviewed by rjw.

WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setLoading:]): Added comment about our tragic dependence on a non-retained reference to the controller. (-[WebDataSource _recursiveStopLoading]): Call webFrame before calling _stopLoading because we release the controller in _stopLoading and we depend on it in webFrame.

5:32 PM Changeset in webkit [3093] by rjw

3 edits in trunk/WebCore

Fixed 3128477. Check KJS::Window before saving js objects.

Reviewed by darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveWindowProperties): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreWindowProperties): (KWQKHTMLPart::restoreLocationProperties):

4:50 PM Changeset in webkit [3092]

3 copies in tags/Alexander-37

This commit was manufactured by cvs2svn to create tag 'Alexander-37'.

4:50 PM Changeset in webkit [3091] by sheridan

8 edits in trunk

submitting to B&I. Alexander-37

2:33 PM Changeset in webkit [3090] by mjs

5 edits in trunk/WebCore

Reviewed by Darin.

fixed 3125412 - HOMEPAGE: 2nd load of html in the same div fails.
fixed 3052113 - HOMEPAGE: "site menu" part of .mac home page editing doesn't work
fixed 3075392 - HOMEPAGE: "pages" section of mac.com homepage editing is missing

khtml/html/html_baseimpl.h:
khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Function that loads new URL, to be called if src attribute is set explicitly and the element is already attached. (HTMLFrameElementImpl::parseAttribute): Call updateForNewURL when src attrinute is set. (HTMLFrameElementImpl::contentDocument): Don't involve render widget in getting the content document.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Allow contextual fragments to be created (and therefore innerHTML to be set on) TR and HTML elements.

2:32 PM Changeset in webkit [3089] by hyatt

3 edits in trunk/WebCore

Use the layer's bounds as the damage rect not the object's.
The layer knows about the overflow out of the object. The
object does not. Duh.

Fixes disney.com bustage.

Reviewed by sullivan

khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):

2:01 PM Changeset in webkit [3088] by hyatt

4 edits in trunk/WebCore

Code needs to go in calcMinMaxWidth instead, so parents computing
their own minmax widths will get the correct value during the ifrst
pass. With this change weather.com is actually fixed.

Reviewed by mjs

khtml/rendering/render_box.cpp: (RenderBox::calcWidth):
khtml/rendering/render_flow.cpp: (RenderFlow::calcMinMaxWidth):

1:42 PM Changeset in webkit [3087] by hyatt

3 edits in trunk/WebCore

Fix for 3128843, horked layout on weather.com. Ensure that
overflow: hidden elements bounds-check their minwidth and maxwidth
values to ensure that you don't grow the clipped element.

Reviewed by mjs

khtml/rendering/render_box.cpp: (RenderBox::calcWidth):

11:46 AM Changeset in webkit [3086] by trey

3 edits in trunk/WebCore

3129175 - we're doing needless GETs when using b/f cache

Turns out that an empty UserStyle was causing WebCore to reload the base URL
of the page, since it tried to load the style "".

Reviewed by Darin

khtml/khtml_part.cpp: (KHTMLPart::reparseConfiguration): Of the UserStyle is empty, set it to an empty string instead of an empty URL.

11:07 AM Changeset in webkit [3085] by mjs

4 edits in trunk/WebCore

Reviewed by Darin.

fixed 3129008 - REGRESSION: Successive hot/cached runs of cvs-base PLT are slightly slower

This was due to me reintroducing a leak of the document. Now fixed.

khtml/ecma/kjs_dom.cpp: (DOMDocument::~DOMDocument): forget self from cached DOM object table. (KJS::getDOMDocumentNode): Instead of storing the document in the marked per-document table, store it in the unmarked table, and as a property on the Window object. (KJS::getDOMNode): use getDocumentNode when appropriate.
khtml/ecma/kjs_dom.h:

9:27 AM Changeset in webkit [3084] by kocienda

1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Reviewed by Darin

Fix for these bugs:

Radar 3128622 (files that can't be mmap'd are opened twice)
Radar 3128624 (names of "not mappable" files kept in ever-growing set)

It turns out that simply reading in the bytes using the NSData
initWithContentsOfFile: method is faster than attempting to mmap
disk cache files to read them.

Since the mmap code is now removed, the issues raised by the bugs
simply go away.

Database.subproj/WebFileDatabase.m: (-[WebFileDatabase objectForKey:])

2:39 AM Changeset in webkit [3083] by hyatt

2 edits in trunk/WebCore

Fix for 3128728. Ensure that list markers get placed into an
existing line box if possible. This patch also fixes RTL bullets
and line height calculations involving image bullets that are the
biggest thing on the line. List markers also correctly move
to avoid floats.

Reviewed by mjs

khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (getLineBoxParent): (RenderListItem::layout): (RenderListMarker::calcMinMaxWidth):

2:38 AM Changeset in webkit [3082] by hyatt

4 edits in trunk/WebCore

Fix for 3128728. Ensure that list markers get placed into an
existing line box if possible. This patch also fixes RTL bullets
and line height calculations involving image bullets that are the
biggest thing on the line. List markers also correctly move
to avoid floats.

Reviewed by mjs

khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (getLineBoxParent): (RenderListItem::layout): (RenderListMarker::calcMinMaxWidth):

12:53 AM Changeset in webkit [3081]

1 copy
6 deletes in tags/Alexander-37u3

This commit was manufactured by cvs2svn to create tag
'Alexander-37u3'.

12:53 AM Changeset in webkit [3080] by mjs

2 edits in trunk/WebKit

Reviewed by no one but it's just a version bump.

WebKit.pbproj/project.pbxproj: Bump version to 37u3

12:36 AM Changeset in webkit [3079] by darin

6 edits in trunk/WebKit

Reviewed by Maciej.

fixed 3128858 -- Supply Finder bits for decoded BinHex files

Downloads.subproj/WebBinHexDecoder.h: Add a _finderFlags field.
Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeHeader]): Decode Finder flags. (-[WebBinHexDecoder fileAttributes]): Put Finder flags in dictionary.

Downloads.subproj/WebMacBinaryDecoder.m: Tweaked things for no good reason. (It is good to always import your own header first as a check that it's self-sufficient).

WebKit.pbproj/project.pbxproj: Let Electron wipe the slate clean of pre-Electron iniquity.

12:16 AM Changeset in webkit [3078] by darin

4 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3128766 -- macconnection.com tries to add properties to the navigator DOM object, which fails

khtml/ecma/kjs_window.cpp: (Window::get): Set up properties named navigator and clientInformation the first time either is queried. These will hold a persistent shared object rather than making one every time it's asked for.

WebCore.pbproj/project.pbxproj: Let Electron undo Maciej's evil.

12:11 AM Changeset in webkit [3077] by cblu

5 edits in trunk/WebKit

WebFoundation:

Fixed: 3094928 - Apply Finder bits to decoded downloads

Reviewed by darin.

Misc.subproj/WebNSFileManagerExtras.h:
Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_createFileAtPath:contents:attributes:]): new, creates file and sets Finder bits.

WebKit:

Fixed: 3094928 - Apply Finder bits to decoded downloads

Reviewed by darin.

Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_createFileAtPath:contents:attributes: so we set Finder bits
Downloads.subproj/WebMacBinaryDecoder.h:
Downloads.subproj/WebMacBinaryDecoder.m: (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): save Finder bits (-[WebMacBinaryDecoder fileAttributes]): return Finder bits

WebBrowser:

Fixed: 3094928 - Apply Finder bits to decoded downloads

Reviewed by darin.

DownloadRow.m: (-[DownloadRow _updateIconAndFilename]): no changes, moved up (-[DownloadRow _stopProgressAnimation]): call _updateIconAndFilename so we pick up icon changes. The Finder will update the icon after we close the file if it has the custom icon bit.

Dec 15, 2002:

11:37 PM Changeset in webkit [3076]

4 copies
56 deletes in tags/Alexander-37u2

This commit was manufactured by cvs2svn to create tag
'Alexander-37u2'.

11:37 PM Changeset in webkit [3075] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

JavaScriptCore.pbproj/project.pbxproj: Bump version to 37u2.

11:37 PM Changeset in webkit [3074] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

fixed likely B&I build problem.

WebKit.pbproj/project.pbxproj: Get at other frameworks in B&I build. Bump version to 37u2.

9:50 PM Changeset in webkit [3073] by darin

10 edits
2 adds in trunk/WebKit

Reviewed by Dave.

implemented user-agent spoofing as described in bug 3044569

WebView.subproj/WebController.m: (-[WebController userAgentForURL:]): Find the suffix of the host name that contains exactly one dot, lower-case it, and look it up in the user-agent spoof table. For now, anything in the table pretends to be MacIE. Don't fret that this table is simple. We will complicate it as needed. The technique is flexible, even though it may not look it now.

WebView.subproj/WebControllerPrivate.h: Add userAgentWhenPretendingToBeMacIE field.
WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Release userAgentWhenPretendingToBeMacIE. (-[WebController _defaultsDidChange]): Release and nil userAgentWhenPretendingToBeMacIE.

Makefile.am: Added rules to build WebUserAgentSpoofTable.c using gperf.
WebView.subproj/WebUserAgentSpoofTable.c: Added. Generated file.
WebView.subproj/WebUserAgentSpoofTable.gperf: Added. Table

English.lproj/StringsNotToBeLocalized.txt: Update for above changes.

fixed a crash I saw in a simplistic way

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Don't assert if the webFrame is nil, just return a partial dictionary.

9:00 PM Changeset in webkit [3072] by mjs

3 edits in trunk/WebCore

Tools:

Reviewed by Darin.

Scripts/set-module-version: Accept `u' in source version.

WebCore:

Reviewed by Darin.

WebCore.pbproj/project.pbxproj: Updated source version to 37u2.

8:14 PM Changeset in webkit [3071] by darin

3 edits in trunk/WebCore

Reviewed by Trey.

fixed regression where clicked-on buttons were getting keyboard focus

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMousePressEvent): Check clickCount here the way NSWindow does. See below for rationale. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): I didn't read the code in [NSWindow sendEvent:] that I was stealing carefully enough. The old needsPanelToBecomeKey flag is used to decide whether something should really get first responder, and I need to do check that too. And while I was in here, did the same clickCount check that NSWindow does for good measure.

7:05 PM Changeset in webkit [3070] by mjs

7 edits in trunk/WebCore

Reviewed by Darin.

fixed 3128383 - DOM nodes should always use the same JS object

khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::ScriptInterpreter): Set auto-delete to true on document dictionary. (ScriptInterpreter::getDOMObjectForDocument): New function - gets DOM object from per-document dictionary. (ScriptInterpreter::putDOMObjectForDocument): New function - put DOM object into per-document dictionary. (ScriptInterpreter::deleteDOMObjectsForDocument): Clear all objects from specific per-document dictionary. (ScriptInterpreter::mark): Mark per-document objects. (ScriptInterpreter::forgetDOMObjectsForDocument): Clear objects for this document from all interpreters.
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_dom.cpp: (KJS::getDOMNode): Use per-document rather than general DOM object dictionary.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): Call forgetDOMObjectsForDocument.

6:42 PM Changeset in webkit [3069] by hyatt

3 edits in trunk/WebCore

Fix for 3057974 and 3128713. I needed to make frames check to
see if their parentNode had a renderer to complete the FOUC
fix. Completing the FOUC fix finally solves 3057974.

Reviewed by darin

khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach):

5:51 PM Changeset in webkit [3068] by hyatt

4 edits in trunk/WebCore

Fix for 3109226, epinions page is mostly blank. Add a hack
to disallow > but only inside attribute values for which there
is no corresponding attribute name.

Also fix attribute values with no name so that the value is
used as the name so that e.g., <option "selected"> works.

Reviewed by darin

khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer):
khtml/html/htmltokenizer.h:

5:03 PM Changeset in webkit [3067] by darin

2 edits in trunk/WebKit

Reviewed by Trey.

fixed 3128260 -- REGRESSION: context menus in frames are always the generic page menu

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView hitTest:]): Check the control key in the mouse down event. If it's down, then do no magic.

4:42 PM Changeset in webkit [3066] by darin

5 edits in trunk/WebCore

Reviewed by Dave.

fixed 3127900 -- REGRESSION: text fields select all their text when clicked on with the mouse

kwq/KWQKHTMLPart.h: Add _firstResponderAtMouseDownTime.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMousePressEvent): Don't call makeFirstResponder: if it's already set. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Using _firstResponderAtMouseDownTime, catch the case where an NSTextField's editor was just created and became first responder. In those cases, pass the mouseDown: to the text field, not the newly created editor. Even though it shouldn't make a difference it does. Also don't makeFirstResponder: if it's already set. (KWQKHTMLPart::mouseDown): Set _firstResponderAtMouseDownTime.

kwq/KWQWidget.mm: (QWidget::setFocus): Don't call makeFirstResponder: if it's already set.

4:42 PM Changeset in webkit [3065] by darin

2 edits in trunk/WebKit

Reviewed by Dave.

fixed 3128651 -- REGRESSION: Mouse wheeling is busted on frames pages

WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView hitTest:]): Only do the hitTest magic for left mouse downs; the rest of the clicks end up going to the correct view anyway, without our help. This makes this stop making trouble for the scroll wheel events.

3:42 PM Changeset in webkit [3064] by hyatt

7 edits in trunk/WebCore

Make sure framesets don't get built twice when FOUC delays
their loading.

Reviewed by gramps

khtml/css/cssstyleselector.cpp:
khtml/css/cssstyleselector.h:
khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::attach):
khtml/rendering/render_style.cpp: (RenderStyle::operator==): (RenderStyle::isStyleAvailable):
khtml/rendering/render_style.h:

3:02 PM Changeset in webkit [3063] by darin

5 edits in trunk/WebCore

Reviewed by Dave.

fixed ==/= typo in QFontMetrics that caused a part of my recent speedup to not take effect
fixed 3128582 -- REGRESSION: Crash on planetquake.com

kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::setFont): Fix a horrifying "== instead of =" mistake. (QFontMetrics::ascent): Give an ERROR message, don't crash, when this is called on a font metrics object that hasn't been updated to work for a particular font. (QFontMetrics::descent): Ditto. (QFontMetrics::lineSpacing): Ditto. (QFontMetrics::xHeight): Ditto. (QFontMetrics::width): Ditto. (QFontMetrics::floatWidth): Ditto. (QFontMetrics::floatCharacterWidths): Ditto.

khtml/html/html_inlineimpl.cpp: (HTMLBRElementImpl::attach): Eliminated what was causing us to hit the above. BR elements need to respect display() == NONE.

fixed the fix for operator==; needs to work even if the pseudo type was extracted already for one of the two, and not the other

khtml/css/cssparser.cpp: (CSSSelector::extractPseudoType): Only do work when the selector is Pseudo. (CSSSelector::operator==): Call pseudoType() instead of going right at _pseudoType.

2:34 PM Changeset in webkit [3062] by hyatt

3 edits in trunk/WebCore

Fix for 3128402, missing content on voodooextreme. Don't allow
object/embed inside the head.

Reviewed by cblu

khtml/html/dtd.cpp:

12:18 PM Changeset in webkit [3061] by darin

6 edits in trunk/WebCore

Reviewed by Ken.

fixed 3127898 -- Crash going to altavista.com after visiting sony.com

khtml/ecma/kjs_window.cpp: (Window::get): Change lots of properties to return "undefined" rather than crashing when the view is NULL. I'm not sure that undefined is the perfect thing to return in this case, but it's better than crashing the program. We can refine later as needed.

fixed 3127157 -- REGRESSION: applet does not become first responder when clicked-on
fixed 3127934 -- Crash in KWQKHTMLPart::widgetWillReleaseView scrolling around

kwq/KWQKHTMLPart.h: Get rid of widgetWillReleaseView(). Add mouseDownViewIfStillGood().
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Call makeFirstResponder: in the same way that the NSWindow does before delivering a mouseDown: message. This oversight caused the applet problem. (findViewInSubviews): Added. (KWQKHTMLPart::mouseDownViewIfStillGood): Added. Gets _mouseDownView, but then checks that it's still a subview before returning it. A little inefficient, but the only way to do it given that there's no general way to find out that an NSView is being removed from your view hierarchy or deallocated. This fixes the crash in widgetWillReleaseView. (KWQKHTMLPart::khtmlMouseMoveEvent): Use mouseDownViewIfStillGood() instead of _mouseDownView directly. (KWQKHTMLPart::khtmlMouseReleaseEvent): Ditto. (KWQKHTMLPart::passSubframeEventToSubframe): Ditto.
kwq/KWQWidget.mm: (QWidget::~QWidget): Remove call to widgetWillReleaseView(). (QWidget::setView): Ditto.

3:23 AM Changeset in webkit [3060] by hyatt

3 edits in trunk/WebCore

operator== on CSSSelectors needed to be updated to compare
_pseudoTypes. A nice subtle bug from the mega-patch.

Reviewed by mjs

khtml/css/cssparser.cpp: (CSSSelector::operator == ):

2:46 AM Changeset in webkit [3059] by hyatt

3 edits in trunk/WebCore

Fix for 3128429, sans-serif font got broken. Just a typo
from darin's mega-patch.

Reviewed by mjs

khtml/css/cssstyleselector.cpp:

1:15 AM Changeset in webkit [3058] by darin

34 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

JavaScriptCore.pbproj/project.pbxproj: Make dtoa.h visible as an SPI so I can use it inside QString.

WebFoundation:

Reviewed by Maciej.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebCore:

Reviewed by Maciej and Dave.

optimizations that improve speed; total is 13.8% on cached cvs-base on my machine

khtml/css/css_valueimpl.h: Add isKonqBody() and genericFamilyType() to find out if a font is a standard one. This is much faster than doing string comparisons all the time.
khtml/css/css_valueimpl.cpp: (FontFamilyValueImpl::FontFamilyValueImpl): Check the font names against the standard ones on time when the FontFamilyValueImpl object is constructed rather than every time the stuff is matched.
khtml/css/cssparser.h: Add pseudoType() and extractPseudoType() to CSSSelector so we don't have to do string compares all the time.
khtml/css/cssparser.cpp: (StyleBaseImpl::parseValue): Use QConstString in a way that's effective (with an object that has a long enough lifetime), or don't use it at all. (StyleBaseImpl::parseContent): Ditto. (StyleBaseImpl::preprocess): Preprocess into a buffer, usually on the stack, rather than using QString += QChar over and over again. (CSSSelector::extractPseudoType): Convert the value string into a type, and get rid of it. Saves memory because the string goes away. And doing it once is much faster than string comparing each time.
khtml/css/cssstyleselector.cpp: (cleanPath): Restructure to save one find() in the common case. (checkPseudoState): Restructure to avoid some DOMString creation/destruction in the case where the tag is not an <A>. Also use QConstString correctly. (CSSStyleSelector::checkOneSelector): Use the new pseudoType() instead of string compares. (CSSStyleSelector::applyRule): Use isKonqBody() and genericFamilyType() instead of string comparisons.

khtml/dom/dom_string.h: Make the destructor non-virtual. This was a big win, and a mistake the way it was before. Also make the DOMString constructor with no parameters inline.
khtml/dom/dom_string.cpp: (DOMString::string): Don't use QConstString here, since it does no good. (DOM::operator==): Rewrite to do things faster and avoid calling strlen.

khtml/html/html_objectimpl.h: Don't use QConstString in places where it does harm and no good.
khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::parseAttribute): Use QConstString properly.

khtml/html/htmltokenizer.cpp: (tagMatch): Added. (HTMLTokenizer::parseSpecial): Change tokenizing so it doesn't construct temporary strings (with QConstString) just to compare small substrings.

khtml/khtml_part.cpp: (KHTMLPart::write): Don't use a decoder object when source is all ASCII.

kwq/KWQColor.mm: (hex2int): Don't bother with uppercase hex since we always lowercase anyway. (QColor::setNamedColor): Use a new gperf-based table instead of an NSDictionary to look up colors.
kwq/KWQColorData.c: Added this autogenerated file.
kwq/KWQColorData.gperf: Added. Source file with list of colors and color values.
kwq/Makefile.am: Build KWQColorData.c from KWQColorData.gperf.
WebCore.pbproj/project.pbxproj: Added KWQColorData.gperf.

khtml/misc/helper.cpp: (khtml::setNamedColor): Don't call setNamedColor again with the lowercased color name, since our QColor::setNamedColor already has to lowercase the name (because it has to check all names before checking any hex values).

khtml/rendering/font.h: Don't initialize the QFontMetrics since in every case we end up changing the font later anyway. Also remove unused field.
khtml/rendering/font.cpp: (Font::update): Use the new QFontMetrics::setFont for speed.

khtml/rendering/render_object.cpp: (RenderObject::enclosingLayer): Change it so it doesn't get the layer twice. This function showed up on the sample so we know it's hot.

khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::containsOnlyWhitespace): Did a faster implementation that doesn't call QChar::direction() except for non-ASCII characters.

kwq/KWQFontMetrics.h: Add empty constructor for use in font.cpp. Add accessor and setter for the font too. Made baselineOffset() inline since it's trivial.
kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): Don't make the renderer until we use it. (QFontMetricsPrivate::getRenderer): Make it here. (QFontMetricsPrivate::font): Added. (QFontMetricsPrivate::setFont): Added. Dumps the renderer if the font is different. (QFontMetrics::QFontMetrics): Added empty constructor. (QFontMetrics::setFont): Added.

kwq/KWQKURL.mm: (KURL::parse): Avoid function call overhead calling strncasecmp and strncmp. Also made the check for localhost case insensitive.

kwq/KWQString.h: Remove _isUnicodeInternal and _isAsciiInternal, since they are trivially computed, and it saves time to not have that extra field to manipulate. Removed private data() function since it's the same as *dataHandle and not really more clear. Made ascii() and unicode() simpler and inline. Also made latin1() and getCFString() inline. Renamed QStringData to KWQStringData.
kwq/KWQString.mm: (QStringData::QStringData): Remove initializers for the xxxInternal. (QStringData::initialize): Removed some unnecessary if statements, and made a slight improvement in the case of a 0-length string that comes with a pointer for Unicode (can't do it in the char * case because it's a feature that's used). (QString::makeSharedNull): No need to set _isUnicodeInternal. (QStringData::~QStringData): Use the new functions instead of the old bits. (QStringData::increaseAsciiSize): Grow faster when we get to larger sizes where the "good size" call doesn't have as much of an effect. Simplified by removing unneeded code. (QStringData::increaseUnicodeSize): Ditto. (QStringData::makeAscii): Update for removal of _isAsciiInternal. (QStringData::makeUnicode): Update for removal of _isUnicodeInternal. (QString::detachIfInternal): Add this new inline to speed things up for the common case where there's no detaching needed. (QString::at): Simplify, there were excess if branches here. (QString::toDouble): Use kjs_strtod and don't copy the string using QCString for additional speed. (QString::lower): Don't detach if the string is already all lowercase. Added a FIXME about the code that assumes all "ASCII" bytes are truly ASCII. This code blurs the distinction between Latin-1 and ASCII in a way that will not work right for Latin-1 characters in an 8-byte character QString. (QString::detachInternal): Update for removal of _isUnicodeInternal. (QString::detach): Removed a special case for shared_null that was dead code since shared_null has the _isUnicodeValid flag set. (operator==): Rewrote the comparison with char * to avoid the costly call to strlen.

Makefile.am: Updated the rules here so the force clean timestamp works right.
force-clean-timestamp: Touched this since the header dependencies don't seem right for the DOMString constructor change, at least.
WebCore-tests.exp: Exported a symbol now needed by tests since QString does more inlining.
WebCore-combined.exp: Re-generated.

WebBrowser:

Reviewed by Maciej.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

1:04 AM Changeset in webkit [3057] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

slightly improved situation with 3124933 (abcnews.com leads to empty window with sheet complaining about javascript: URL); the popup window still comes up empty but it doesn't put up a sheet.

kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::openURLRequest): Handled "javascript:" URLs here.

12:24 AM Changeset in webkit [3056] by gramps

4 edits in trunk/WebKit

Reviewed by darin

Debug/DebugUtilities.m:

(-[DebugUtilities userAgentSubmenuItem]):

Changed "PPC" in one user agent string to "PPC Mac OS X" used for
debugging.

Fixed 3127173 -- REGRESSION: fboweb.com renders incorrectly

Reviewed by darin

English.lproj/StringsNotToBeLocalized.txt:
WebView.subproj/WebController.m:

(-[WebController userAgentForURL:]):

Changed "PPC" in our user agent string to "PPC Mac OS X" in order to
match Mozilla and make the silly server-side user agent string checking
work at fboweb.com. Actually, just "PPC " would work fine at
fboweb.com. Go figure.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed