⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 3, 2003:

6:53 PM Changeset in webkit [3252] by rjw
  • 3 edits in trunk/WebKit

Fixed 3139129. Added application/xhtml+xml to list of supported type.

Reviewed by gramps.

  • WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]):
  • WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]):
5:52 PM Changeset in webkit [3251] by rjw
  • 4 edits in trunk/WebCore

Fix for 3138425. Don't open a new window when document.open() is called
with < 2 parameters.

Reviewed by darin.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall):
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
4:57 PM Changeset in webkit [3250] by rjw
  • 14 edits in trunk

WebCore:

Fixed 3138743, 3138678, and 3138854. Removed the RenderText
widths cache, replaced it with a much simply monospace character
cache. Should be much faster for covered cases too! Also fixed
buffer overrun problem causing the crash in 3138854.

Reviewed by darin.

  • khtml/rendering/font.cpp: (Font::isFixedPitch):
  • khtml/rendering/font.h:
  • khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint): (RenderText::RenderText): (RenderText::setStyle): (RenderText::~RenderText): (RenderText::shouldUseMonospaceCache): (RenderText::cacheWidths): (RenderText::widthFromCache): (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::setText): (RenderText::width):
  • khtml/rendering/render_text.h:
  • kwq/KWQFont.h:
  • kwq/KWQFont.mm: (QFont::isFixedPitch):
  • kwq/WebCoreTextRendererFactory.h:
  • kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory isFontFixedPitch:]):

WebKit:

Support for fixes to 3138743, 3138678. Added
isFontFixedPitch used to determine if font is fixed
pitch. Makes use of appkit private _isFakeFixedPitch
(detects courier and monoca). Updated our fakey test
to use the appkit's version.

Reviewed by darin.

  • WebCoreSupport.subproj/WebTextRenderer.m:
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory isFontFixedPitch:]):
4:50 PM Changeset in webkit [3249] by darin
  • 2 edits in trunk/WebKit

Reviewed by Chris.

  • fixed leak of WebIconLoader observed using leaks tool
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Tell the icon loader to stop loading. Add a FIXME asking why we had to do this to fix the leak. (-[WebDataSource _loadIcon]): Add an assertion.
2:05 PM Changeset in webkit [3248] by sullivan
  • 3 edits in trunk/WebCore
  • fixed 3138673 -- reproducible crash in JavaScript

Reviewed by Darin, OK'ed by Don.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setTitle): Check for nil view or nil part before dereferencing.
12:05 PM Changeset in webkit [3247] by hyatt
  • 3 edits in trunk/WebCore

Fix for percentage table heights. A check was missing to
look for a fixed height on the containing block.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTable::layoutRows):
11:21 AM Changeset in webkit [3246] by rjw
  • 4 edits in trunk/WebKit

Fix to 3131226. Don't force a layout when the document view is set
on the page's scrollview. A layout would occur indirectly as a result
of reflectScrolledClipView: being called when the document view
was set. The khtmlpart/khtmlview/WebHTMLView would be out of sync
at this point and a layout would have unintended and incorrect
side effects.

Reviewed by Darin (and tested by John).

  • WebView.subproj/WebDynamicScrollBarsView.h:
  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
  • WebView.subproj/WebViewPrivate.m: (-[WebView _setDocumentView:]):
10:28 AM Changeset in webkit [3245] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fixed 3138213 -- browser hangs trying to open Apple travel site
  • kjs/date_object.cpp: (timetUsingCF): Check for very-negative year numbers too.

Jan 2, 2003:

6:19 PM Changeset in webkit [3244] by kocienda
  • 3 edits in trunk

Setting version to 49u

5:23 PM Changeset in webkit [3243]
  • 3 copies in branches/Alexander-48-branch

This commit was manufactured by cvs2svn to create branch
'Alexander-48-branch'.

5:23 PM Changeset in webkit [3242]
  • 3 copies in tags/Alexander-48

This commit was manufactured by cvs2svn to create tag 'Alexander-48'.

5:23 PM Changeset in webkit [3241]
  • 3 copies in branches/ALEXANDER_48_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create branch
'ALEXANDER_48_BRANCH_ANCHOR'.

5:23 PM Changeset in webkit [3240] by kocienda
  • 8 edits in trunk

Building Safari-48

3:34 PM Changeset in webkit [3239] by rjw
  • 2 edits in trunk/WebKit

Increase the minimum font size to 9pt. This bounds the lower
size of the sizes array used for named sizes. Net effect is
to increase xx-small from 8pt to 9pt. xx-small is used by
www.microsoft.com.

Reviewed by hyatt.

  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]):
3:24 PM Changeset in webkit [3238] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3136473. <object>s with no specified size should be
0x0. They should not be 300x200. Fixes thinker.org.

Reviewed by john and darin.

  • khtml/rendering/render_frames.cpp: (RenderPart::intrinsicWidth): (RenderPart::intrinsicHeight):
3:22 PM Changeset in webkit [3237] by darin
  • 5 edits in trunk/WebCore

Reviewed by Maciej and Trey.

  • fixed 3138063 -- REGRESSION: JavaScript-submitted form activates input type=image (webmail.mac.com)

JavaScript-submitted forms must not get a submit button activated as return-key-submitted ones do.

  • khtml/html/html_formimpl.h: Add boolean activateSubmitButton parameter to submit.
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::prepareSubmit): Pass true for activateSubmitButton. (HTMLFormElementImpl::submit): Only activate a button if activateSubmitButton is true.
  • khtml/dom/html_form.cpp: (HTMLFormElement::submit): Pass false for activateSubmitButton.
3:05 PM Changeset in webkit [3236] by hyatt
  • 4 edits in trunk/WebCore

Fix for the 3137790. This patch passes the mouse event x and y as
distinct arguments to constructZTree, so that the damageRect can
really reflect your clip rect.
This allows me to prune out layers that are clipped so
that if x,y aren't inside the clip rect, the layer doesn't get added to
the list.

This patch also makes the "clip" property apply to the element that specifies the clip instead of to the element's kids. This is ambiguous in the spec, but it turns out other browsers do it this way, so there really is an interpretation that must be followed. :)

Reviewed by darin

  • khtml/rendering/render_layer.cpp: (RenderLayer::nodeAtPoint): (RenderLayer::constructZTree):
  • khtml/rendering/render_layer.h:
12:25 PM Changeset in webkit [3235] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug #3137935. When a float causes a line to get
moved down past the float, the line would incorrectly break
rather than expanding to use the newly-available width.

Reviewed by darin.

  • khtml/rendering/bidi.cpp: (RenderFlow::findNextLineBreak):
11:34 AM Changeset in webkit [3234] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3131190 -- <textarea wrap="hard"> eats text on blur
  • kwq/KWQTextArea.mm: (-[KWQTextArea paragraphs]): Add missing parentheses so we don't always return 0 or 1 for the number of paragraphs.
11:17 AM Changeset in webkit [3233] by darin
  • 2 edits in trunk/WebKit

Reviewed by Don.

  • at Scott and Don's request, roll out small text anti-aliasing cutoff

Turns out this makes small text look worse, not better. We're not going to respect
this setting, and in Panther AppKit will almost certainly be changed not to either.

  • WebCoreSupport.subproj/WebTextRenderer.m: Rolled out yesterday's change using CVS.
10:58 AM Changeset in webkit [3232] by darin
  • 3 edits in trunk/WebKit

Reviewed by John and Don.

  • fixed 3137661 -- REGRESSION: autoscroll selection is broken

The new logic in WebCore is slightly pickier, and can't abide a mouse-moved event
coming in during a drag. Unfortunately, we were sending a fake mouse-moved event
during a drag, so lets not do that.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): Cancel any scheduled fake mouse-moved event. (-[WebHTMLView mouseUp:]): Send a fake mouse-moved event because we didn't update during the drag.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged]): Don't schedule a fake mouse-moved event if the mouse is down, because that means we are in the middle of a drag.
10:24 AM Changeset in webkit [3231] by darin
  • 3 edits in trunk/WebKit

Reviewed by John and Ken.

  • fixed 3135548 -- exception in Internet Explorer bookmark import code at first startup
  • Bookmarks.subproj/WebBookmarkImporter.m: (_breakStringIntoLines): Break lines before a <DT> or </DL>. (_HREFTextFromSpec): Rewrite to simplify, search in a case-insensitive manner. (-[WebBookmarkImporter initWithPath:]): Change prefix checks to be case-insensitive. Don't discard folders altogether if the name can't be parsed as that would mess up nesting w.r.t the next </DL>. Make the </DL> handling robust so we misparse, but don't crash the whole application by raising an exception.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for this change and recent changes.

Jan 1, 2003:

10:03 PM Changeset in webkit [3230] by rjw
  • 2 edits in trunk/WebKit

Obey the font smoothing size preference (3137618).

Reviewed by Don and Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m:
9:37 PM Changeset in webkit [3229] by mjs
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

  • fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
  • fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Initialize new mouseDownMayStartDrag and mouseDownMayStartSelect methods. (KWQKHTMLPart::khtmlMousePressEvent): Make sure a mouse down won't be used to start a drag or selection if the default action is prevented on the mouse down event. (KWQKHTMLPart::mouseDown): Since the default action wasn't prevented, decide if this might be the start of a drag or selection. (KWQKHTMLPart::khtmlMouseMoveEvent): On a drag or selection, call back to the bridge to handle selection or autoscrolling appropriately.
  • kwq/WebCoreBridge.h: Prototype new methods.

WebKit:

Reviewed by Darin.

  • fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
  • fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge handleMouseDragged:]): New method; call through the WebHTMLView. (-[WebBridge mayStartDragWithMouseDown:]): Likewise. (-[WebBridge handleAutoscrollForMouseDragged:]): Likewise.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]): Instead of doing drag handling here, just pass the event to WebCore. (-[WebHTMLView draggedImage:endedAt:operation:]): Send a fake mousemove event instead of sending the current event (likely a mouse up as if it were a mouse move).
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): Release drag element if any. (-[WebHTMLView _dragImageForElement:]): New method. Split out the code to make the special drag image for links. (-[WebHTMLView _handleMouseDragged:]): Move all the drag handling here. This method will get called only if WebCore hasn't blocked default drag handling. (-[WebHTMLView _handleAutoscrollForMouseDragged:]): Do autoscroll. Autoscroll is still lame, we need a timer. (-[WebHTMLView _mayStartDragWithMouseDown:]): Determine if the element is a link or image and so may be dragged; remember the drag element.
8:26 PM Changeset in webkit [3228] by darin
  • 3 edits in trunk/WebCore

Reviewed by Don.

  • fixed 3137566 -- non-reproducible nil-dereference in KHTMLView::clearPart deallocating KWQPageState
  • kwq/KWQPageState.mm: (-[KWQPageState dealloc]): Add nil check.
5:14 PM Changeset in webkit [3227] by rjw
  • 3 edits in trunk/WebKit

Correct fix for 3137430 that doesn't always effectively disable
the cache.

Reviewed by kocienda.

  • History.subproj/WebHistoryItem.m:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):
2:59 PM Changeset in webkit [3226] by hyatt
  • 4 edits in trunk/WebCore

Fix tables so that malformations inside them are properly pulled
out of the table without being flattened.

Fixes 3131480.

Reviewed by gramps

  • khtml/html/dtd.cpp: (DOM::checkChild):
  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
2:35 PM Changeset in webkit [3225] by rjw
  • 2 edits in trunk/WebKit

Don't reset the cookie policy URL if it has already been set. Fixes to 3109590.

Reviewed by Maciej.

12:45 PM Changeset in webkit [3224] by rjw
  • 2 edits in trunk/WebKit

Don't attempt to restore page from page cache if the cache
doesn't contain valid page state. This may happen after a
redirect. Fixes 3137430.

Reviewed by kocienda.

  • History.subproj/WebHistoryItem.m:
11:31 AM Changeset in webkit [3223] by darin
  • 12 edits in trunk/WebKit

WebKit:

Reviewed by Trey.

  • fixed 3137287 -- REGRESSION: Java applets don't work when you go back to them (Java 1.4.1 plug-in)

By attaching the plug-in controller to the frame, we run into trouble.
It really needs to be attached to the data source, which has the right lifetime
and is kept around in the page cache.

  • Plugins.subproj/WebPluginController.h: Keep a reference to a data source, not a frame. Add a new _started variable. Rename addPluginView: to addPlugin:, get rid of didAddPluginView:, replace destroyAllPlugins with dataSourceWillBeDeallocated, add startAllPlugins and stopAllPlugins.
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithDataSource:]): Store a data source reference, not a frame reference. Don't bother registering for the window will close notification, WebHTMLView handles that fine. (-[WebPluginController startAllPlugins]): Do nothing if they are already started, call pluginStart on each otherwise. (-[WebPluginController stopAllPlugins]): Do nothing if they are not started, call pluginStop on each otherwise. (-[WebPluginController addPlugin:]): Initialize the plugin if it's not already in our list. Also start it if we are in "started" mode. (-[WebPluginController dataSourceWillBeDeallocated]): Stop all the plugins, then destroy them. Also nil out the fields of the object. This is always called before the controller is released so we don't need to override dealloc. (-[WebPluginController showURL:inFrame:]): Added error checking and changed now that we start with a data source. (-[WebPluginController showStatus:]): Ditto.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): Use the data source, not the view. Don't add the plugin here, wait until we are ready to start.
  • WebView.subproj/WebDataSourcePrivate.h: Store a pointer to the plug-in controller here.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Tell the plug-in controller to go away. (-[WebDataSource _makeHandleDelegates:deferCallbacks:]): Remove unused empty method. (-[WebDataSource _pluginController]): Create a plug-in controller if needed.
  • WebView.subproj/WebFramePrivate.h: Remove plug-in controller code.
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Remove plug-in controller code. (-[WebFrame _detachFromParent]): Remove plug-in controller code. (-[WebFrame _transitionToCommitted:]): Remove plug-in controller code.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewWillMoveToWindow:]): Stop plug-ins when view moves out of a window. This includes the case when the window is being destroyed. (-[WebHTMLView viewDidMoveToWindow]): Start plug-ins when view moves into a window. (-[WebHTMLView addSubview:]): Add plug-ins to the controller as they are added to us.
  • WebView.subproj/WebController.m: Added now-needed include due to header change.
  • WebView.subproj/WebDefaultContextMenuDelegate.m: Ditto.

WebBrowser:

Reviewed by Don and Ken.

  • worked around 3137387 -- Using Java 1.4.1 plug-in causes world leak (NSDocument close never called)
  • BrowserWindow.m: (-[BrowserWindow setDelegate:]): If someone tries to set the delegate to something other than the BrowserWindowController, don't let them. (-[BrowserWindow setWindowController:]): Same thing for the controller.
  • fixed 3137494 -- loading bad URL with PLT window in "world leak check mode" indicates leak, prevents quit

Filed bug 3137567 about the AppKit part of this.

  • Test/PageLoadTestRunner.m: (-[NSWindow closeIfBrowserWindow]): Close the sheet, if any, before closing the window.

Dec 31, 2002:

2:12 PM Changeset in webkit [3222] by kocienda
  • 3 edits in trunk

Moving version to 48u.

2:07 PM Changeset in webkit [3221]
  • 3 copies in tags/Alexander-47

This commit was manufactured by cvs2svn to create tag 'Alexander-47'.

2:07 PM Changeset in webkit [3220] by kocienda
  • 8 edits in trunk

Building Safari-47

Dec 30, 2002:

11:18 PM Changeset in webkit [3219] by darin
  • 2 edits in trunk/WebKit

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit:

  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
11:12 PM Changeset in webkit [3218] by darin
  • 4 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3132141 -- enter key does not work with input type=image

Made the logic handle image and submit type inputs in the same way.

  • khtml/html/html_formimpl.h: Remove unused m_clicked flags.
  • khtml/html/html_formimpl.cpp: (HTMLButtonElementImpl::HTMLButtonElementImpl): Remove code to set the m_clicked flag. The only place this flag was looked at is better handled by the m_activeSubmit flag. (HTMLButtonElementImpl::defaultEventHandler): Remove more m_clicked flag code. (HTMLInputElementImpl::HTMLInputElementImpl): Remove more m_clicked flag code. (HTMLInputElementImpl::isSuccessfulSubmitButton): An image is also a successful submit button, and unlike a submit element, it doesn't require a name because it will just submit x and y with no name in that case. I suppose we could rename this function, but I think it's still a pretty clear name even if not 100% accurate. (HTMLInputElementImpl::encoding): Remove use of m_clicked and use m_activeSubmit instead. This was the only place using m_clicked at all. Also remove bogus check for a -1 coordinate. The coordinate defaults to 0, not -1, and it was never happening. (HTMLInputElementImpl::defaultEventHandler): Remove more m_clicked flag code.
9:42 PM Changeset in webkit [3217] by trey
  • 2 edits in trunk/WebKit

3137110 - REGRESSION: calls from 2nd and subsequent instances of Java 1.4.1 plug-in seem to be ignored

We had previously made changes to "numb" a plugin controller after its frame
was tossed or changed content. We now finish the job by making sure a new
controller is created when we go to a new page with plugins. To so this we
release the old controller whenever we flush the plugins from a page.

Reviewed by Maciej.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Call newly factored code. (-[WebFrame _transitionToCommitted:]): Call newly factored code. (-[WebFrame _destroyPluginController]): New method to tear down plugins.
5:25 PM Changeset in webkit [3216] by trey
  • 2 edits in trunk/WebKit

3135025 - Assertion failure in _transitionToCommitted on espn nba scoreboard

For blank pages we decided that there would be no b/f entry. This means that
subframes within such pages (created via doc.write()), should not try to make
WebHistoryItems, since they have no parent items to attach them to.

Reviewed by Darin.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): Don't make a history item for a subframe it the parent frame has no item.
3:17 PM Changeset in webkit [3215] by darin
  • 9 edits in trunk/JavaScriptCore

Reviewed by Don and Maciej.

  • follow-on to my fix for 3134693 that fixes one more case of recursion and simplifies further
  • kjs/grammar.y: Remove SourceElementNode and just use a StatementNode instead. Reverse SourceElements rule so the recursive rule comes first as in the original KJS code (avoids actual parser recursion).
  • kjs/grammar.cpp: Regenerated.
  • kjs/grammar.cpp.h: Regenerated.
  • kjs/grammar.h: Regenerated.
  • kjs/nodes.h: Make processFuncDecl a virtual function in StatementNode so that we can use a StatementNode instead of a SourceElementNode. Add a call to reverseList in BlockNode to correct the order of the linked list in SourceElementsNode, to replace the technique where we reversed it in the parser. Remove SourceElementNode class, and make the element in SourceElementsNode be a StatementNode instead.
  • kjs/nodes.cpp: Remove SourceElementNode code. (StatementNode::processFuncDecl): Added empty function. (BlockNode::reverseList): Added. Used to make the SourceElements list ordered correctly.
  • kjs/nodes2string.cpp: Remove SourceElementNode code.
2:10 PM Changeset in webkit [3214] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3129016, make sure that zero-height tables and lists
will be skipped in a search for floats that occur before
them. Makes usatoday work.

Reviewed by gramps

  • khtml/rendering/render_flow.cpp: (RenderFlow::clearFloats):
2:06 PM Changeset in webkit [3213] by darin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3135642 -- ad frames are missing at channels.netscape.com
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Updated to use the same rule as Mozilla: Empty URL for an iframe means "about:blank".
  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Loosen things so that it's safe for a frame to manipulate an empty child frame, as well as an empty opened window. Also remove the useless check for an empty document -- it never happens in practice.
11:47 AM Changeset in webkit [3212] by trey
  • 2 edits in trunk/WebKit

3135779 - REGRESSION: reproducible assertion failure, going back from ~orubin to the main spies.com page
3136218 - REGRESSION: Assertion failure in _restoreScrollPosition running browser buster

Both were caused by subtle interactions between new code for short-circuiting loading of
blank pages, and the WebHistoryItem manipulations we do for b/f and reload of child frames.

Reviewed by Maciej

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:intoChild:]): Setup provisional or current item before jumping into the real work of loading the URL. (-[WebFrame _restoreScrollPosition]): Tweaked to make the assertion message clearer.
11:22 AM Changeset in webkit [3211] by kocienda
  • 3 edits in trunk/WebCore

Tests:

Reviewed by Darin and Gramps

Added some more test cases as part of the work to fix this bug:

Radar 3136795 (type URL with ../ in it, get assertion)

I also notice an unrelated change in ifnsurlextensions-test.chk where
leading whitespace in a URL is now getting removed correctly. Bonus.

  • TestURLs.h
  • WebFoundation-Misc/ifnsurlextensions-test.chk
  • WebFoundation-Misc/ifnsurlextensions-test.m: (main)

WebFoundation:

Reviewed by Darin and Gramps

Radar 3136795 (type URL with ../ in it, get assertion)

The code to remove relative portions from URLs was eating leading slashes on
URL paths. This caused absolute paths with relative portions to get mangled,
resulting in a URL that the engine could not use. Now, leading slashes are no
longer removed from URL paths, resulting in usuable URLs.

  • Misc.subproj/WebNSURLExtras.m: (pathRemovingDots) (-[NSURL _web_URLComponents])

WebCore:

Reviewed by Darin and Gramps

Fix for this bug:

Radar 3136795 (type URL with ../ in it, get assertion)

The code to remove relative portions from URLs was eating leading slashes on
URL paths. This caused absolute paths with relative portions to get mangled,
resulting in a URL that the engine could not use. Now, leading slashes are no
longer removed from URL paths, resulting in usuable URLs.

  • kwq/KWQKURL.mm: (copyPathRemovingDots)
11:19 AM Changeset in webkit [3210] by darin
  • 3 edits in trunk/WebKit

Reviewed by Don and Ken.

  • fixed 3136797 -- crash when Adobe SVG Viewer plug-in puts up modal dialog
  • Plugins.subproj/WebBaseNetscapePluginView.h: Add inSetWindow boolean.
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Don't send any events to a plug-in while it's inside NPP_SetWindow. We don't want to implement more general reentrancy protection, because it could cause trouble for plugins that can handle it correctly, but it's unlikely that any legitimate use would require reentrant calls while inside NPP_SetWindow, and that's the case that crashes for the SVG viewer plug-in when it presents its registration dialog. (-[WebBaseNetscapePluginView setWindow]): Set boolean.
Note: See TracTimeline for information about the timeline view.