⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 20, 2003:

6:35 PM Changeset in webkit [3362] by hyatt
  • 4 edits in trunk/WebCore

Fix :hover performance regression on wsj.com. Moving my
<a name="foo"> quirk down into the :hover rule matching code,
so that we'll know never to apply :hover to anchorless <a>s.

Reviewed by gramps

  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/render_object.cpp: (RenderObject::setHoverAndActive):
6:33 PM Changeset in webkit [3361] by mjs
  • 13 edits
    1 add in trunk

WebCore:

Reviewed by Trey.

  • fixed 3132120 - onchange handler not firing on mac.com webmail
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::handleFocusOut): Moved empty virtual method here from render_form. (RenderWidget::eventFilter): Uncomment call to handleFocusOut - we need it to send onChange properly.
  • khtml/rendering/render_replaced.h:
  • kwq/KWQObject.h: Add empty eventFilter virtual method.
  • kwq/KWQComboBox.h: Remove no longer needed empty eventFilter.
  • kwq/KWQEvent.h: Implement a bit more of QFocusEvent.
  • kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Tell the text view its widget. (-[KWQTextAreaTextView setWidget:]): New method to set widget. (-[KWQTextAreaTextView becomeFirstResponder]): In addition to the usual stuff, call the widget's event filter with a focus in event. (-[KWQTextAreaTextView resignFirstResponder]): In addition to the usual stuff, call the widget's event filter with a focus out event.
  • kwq/KWQTextField.mm: (-[KWQTextField becomeFirstResponder]): Cleaned up a bit. (-[KWQTextField fieldWillBecomeFirstResponder]): Call the widget's event filter with a focus in event. (-[KWQTextField fieldWillResignFirstResponder]): Call the widget's event filter with a focus out event.
  • kwq/KWQView.mm:

WebKit:

Reviewed by Trey.

  • fixed 3132120 - onchange handler not firing on mac.com webmail
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView resignFirstResponder]): If we really resign first responder, and our delegate responds to filedWillBecomeFirstResponder, then call that method. (-[WebNSTextView becomeFirstResponder]): If we really become first responder, and our delegate responds to filedWillBecomeFirstResponder, then call that method.
5:35 PM Changeset in webkit [3360] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3147213. <nobr> is treated like other inlines now,
so it can contain blocks. <wbr> is also fixed. This fixes
tvguide.com.

Reviewed by john

  • khtml/html/dtd.cpp: (DOM::checkChild):
4:29 PM Changeset in webkit [3359] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Reviewed by Hyatt

Moved up to HTTP/1.1 in the simple loader, including chunked transer encoding and
persistent connections. While I was in the neighborhood, I cleaned up a lot of
code and improved some names.

  • Database.subproj/WebFileDatabase.m: Changed sync idle timeout from 3 seconds to 10 seconds. In the "real world" I think that this is a better choice since with even DSL speeds, pages often take longer than 3 seconds to load.
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_timeoutFromKeepAliveHeader]): Added this helper.
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.h: Added WebHTTPTransferEncoding enum and transferEncodingFlags ivar to the class.
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler populateResponseWithProtocolMetadata:]): Do a "sanity" check on the value of transferEncodingFlags. If the encoding is not "identity" discard content length header value. (-[WebHTTPProtocolHandler determineTransferEncoding]): Added.
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.h: Quite a bit of rearranging and additions in order to handle new functionality. Moved the whole method interface into the .m file. None of that was public in any way.
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebHTTPPersistentConnection initWithFD:expiry:]): Added. (-[WebHTTPPersistentConnection isExpired]): Added. (WebSimpleHTTPProtocolHandlerInit): Some name changes and additions in order to handle new functionality. (_persistentConnectionSweeper): Added. (_signalledHandlersCallback): Name change. (_socketWriteCallback): Name change. (_socketReadCallback): Name change. (-[WebSimpleHTTPProtocolHandler initWithResourceLoad:]): Create the HTTP request string here. (-[WebSimpleHTTPProtocolHandler beginLoadInBackgroundWithConditions:]): Now checks to see if a persistent connection is available for the destination host/port. (-[WebSimpleHTTPProtocolHandler endLoad]): Name change to call _finishedWithFileDescriptor. (-[WebSimpleHTTPProtocolHandler cleanUpForRetry]): Rearranged in order to be more legible. Some additions to handle new functionality. (-[WebSimpleHTTPProtocolHandler dealloc]): Adjusted for name changes. (-[WebSimpleHTTPProtocolHandler _createHTTPRequest]): Now uses HTTP/1.1 and Connection: keep-alive. This is what the change is all about. :-) (-[WebSimpleHTTPProtocolHandler _extractResponseStatusLineFromBytes:length:]): (-[WebSimpleHTTPProtocolHandler _processHTTPResultCode]): Name change. (-[WebSimpleHTTPProtocolHandler _performSocketRead]): Name change. (-[WebSimpleHTTPProtocolHandler _finishedWithFileDescriptor]): Name change. Now handles keeping connections alive if they are eligible. (isToken): Added to deal with chunked transfer encoding. (skipLWS): Ditto. (skipToken): Ditto. (skipQuotedString): Ditto. (parseChunkedHeader): Ditto. (-[WebSimpleHTTPProtocolHandler _processResponseData]): Now handles chunked transfer encoding. (-[WebSimpleHTTPProtocolHandler _handleLoadCallback]): Now does more checks to see if a load has finished. Additional logic needed here since we do not get a "hard close" when a load is done since we are trying to keep the socket open.
4:09 PM Changeset in webkit [3358] by trey
  • 3 edits in trunk/WebKit

Nit fix to remove a dead "cursor" ivar found while grepping.

Reviewed by Richard.

  • WebView.subproj/WebDynamicScrollBarsView.h:
  • WebView.subproj/WebDynamicScrollBarsView.m:
4:00 PM Changeset in webkit [3357] by hyatt
  • 4 edits in trunk/WebCore

Gah. Fix positioned objects and floating objects so that they
don't append themselves to the list of runs in normal flow.
An astoundingly basic bug. :(

Reviewed by john

  • khtml/rendering/bidi.cpp: (appendRunsForObject):
  • khtml/rendering/render_flow.cpp: (RenderFlow::addChildToFlow):
1:59 PM Changeset in webkit [3356] by hyatt
  • 23 edits in trunk/WebCore

Fixes for 3150561 (blog articles vanish on stylesheet switch) and
and 3150560 (crash changing fixed positioned element to normal
positioning dynamically).

This change makes layers able to deal with dynamic changes in
position that cause you to have to either remove a layer from
the hierarchy while preserving the children or to insert a
layer into the hierarchy in between a parent and its descendants.

This patch also rewrites :hover/:active so that they can actually
be used in selectors other than the rightmost selector (e.g., so you
can write a rule like "li:hover > a").

Also, layers will now properly clear out their hover/active state
when the mouse is no longer inside them.

With these fixes, Eric Meyer's "Pure CSS Menus" work (perfectly)
and the repainting problems on sites like brainjar.com and
diveintomark.org and wired.com are fixed.

Reviewed by mjs and john.

  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/cssparser.cpp: (StyleBaseImpl::parseSelector):
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/dom/html_head.cpp: (HTMLLinkElement::setDisabled):
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/rendering/render_flow.cpp: (RenderFlow::setStyle):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::addChild): (RenderLayer::removeOnlyThisLayer): (RenderLayer::insertOnlyThisLayer): (RenderLayer::clearOtherLayersHoverActiveState): (RenderLayer::clearHoverAndActiveState): (RenderLayer::nodeAtPoint): (RenderLayer::constructZTree):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.cpp: (RenderObject::addLayers): (RenderObject::moveLayers): (RenderObject::findNextLayer): (RenderObject::setStyle): (RenderObject::setHoverAndActive):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.cpp: (RenderStyle::diff):
  • khtml/rendering/render_style.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
  • khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::setActive):

Jan 18, 2003:

7:08 PM Changeset in webkit [3355] by mjs
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3149511 - Blogger.com window closes after update is posted
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): For now, don't allow closing the window at all if it wasn't opened by JavaScript, since we don't support the history object and so can't tell if the window has only one history item.
3:11 PM Changeset in webkit [3354] by mjs
  • 3 edits in trunk/WebKit

Reviewed by John.

  • fixed 3123041 - VIP: Spewage at bottom of oregonlive.com and other similar pages
  • WebView.subproj/WebUserAgentSpoofTable.gperf: Added nj.com to spoof list below oregonlive.com (which was already in there). Added comment explaining the need to spoof a bit more.
  • WebView.subproj/WebUserAgentSpoofTable.c: (hash): (_web_findSpoofTableEntry): Regenerated.

Jan 17, 2003:

3:08 PM Changeset in webkit [3353] by darin
  • 7 edits in trunk/WebCore

Reviewed by Dave.

  • fixed the crashing so the layout tests work
  • khtml/rendering/render_layer.h: Add a node pointer result.
  • khtml/rendering/render_layer.cpp: (RenderLayer::elementList): Return the node pointer so we can destroy it when done with it.
  • khtml/rendering/render_object.h: Make renderArena() const.
  • khtml/rendering/render_object.cpp: (RenderObject::renderArena): Make it const.
  • kwq/KWQRenderTreeDebug.cpp: (writeLayers): Free the Z layer list when done. Without this things just crashed.
2:46 PM Changeset in webkit [3352] by rjw
  • 3 edits in trunk/WebCore

Fixed 3126141. Allow pages with plugins to be cached. This is safe
because plugins are cleanly started/stopped when their containing views are
added/removed from the view hierarchy.

Reviewed by trey.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage):
2:42 PM Changeset in webkit [3351] by hyatt
  • 35 edits
    3 adds in trunk/WebCore

The new table code from Lars. Also includes bug fixes for
percentage height children in table cells, for positioning
of tables, and for width distribution of percentage width
cells.

Reviewed by darin

  • ForwardingHeaders/rendering/table_layout.h: Added.
  • WebCore.pbproj/project.pbxproj:
  • khtml/css/cssparser.cpp: (StyleBaseImpl::parseValue):
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssvalues.c: (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/dom/html_table.cpp: (HTMLTableElement::insertRow): (HTMLTableElement::deleteRow): (HTMLTableRowElement::insertCell): (HTMLTableRowElement::deleteCell): (HTMLTableSectionElement::insertRow): (HTMLTableSectionElement::deleteRow):
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): (HTMLTableElementImpl::setTFoot): (HTMLTableElementImpl::setTBody): (HTMLTableElementImpl::createTHead): (HTMLTableElementImpl::createTFoot): (HTMLTableElementImpl::insertRow): (HTMLTableElementImpl::deleteRow): (HTMLTableElementImpl::addChild): (HTMLTableElementImpl::parseAttribute): (HTMLTableElementImpl::attach): (HTMLTablePartElementImpl::parseAttribute): (HTMLTableSectionElementImpl::HTMLTableSectionElementImpl): (HTMLTableSectionElementImpl::~HTMLTableSectionElementImpl): (HTMLTableSectionElementImpl::insertRow): (HTMLTableSectionElementImpl::deleteRow): (HTMLTableSectionElementImpl::numRows): (HTMLTableRowElementImpl::rowIndex): (HTMLTableRowElementImpl::insertCell): (HTMLTableRowElementImpl::deleteCell): (HTMLTableCellElementImpl::HTMLTableCellElementImpl): (HTMLTableCellElementImpl::parseAttribute): (HTMLTableCellElementImpl::attach): (HTMLTableColElementImpl::HTMLTableColElementImpl): (HTMLTableColElementImpl::parseAttribute):
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): (KHTMLParser::getElement):
  • khtml/rendering/bidi.cpp: (RenderFlow::layoutInlineChildren):
  • khtml/rendering/render_body.cpp: (RenderBody::availableHeight):
  • khtml/rendering/render_body.h:
  • khtml/rendering/render_box.cpp: (RenderBox::contentWidth): (RenderBox::contentHeight): (RenderBox::calcReplacedWidth): (RenderBox::calcReplacedHeight): (RenderBox::availableHeight): (RenderBox::calcAbsoluteVertical):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::leftOffset): (RenderFlow::rightOffset): (RenderFlow::addOverHangingFloats): (RenderFlow::calcBlockMinMaxWidth): (RenderFlow::calcMinMaxWidth):
  • khtml/rendering/render_form.cpp:
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_object.cpp: (RenderObject::createObject): (RenderObject::paddingTop): (RenderObject::paddingBottom): (RenderObject::paddingLeft): (RenderObject::paddingRight):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
  • khtml/rendering/render_root.cpp: (RenderRoot::RenderRoot): (RenderRoot::layout): (RenderRoot::paintObject):
  • khtml/rendering/render_root.h:
  • khtml/rendering/render_style.cpp: (StyleSurroundData::StyleSurroundData):
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::~RenderTable): (RenderTable::setStyle): (RenderTable::position): (RenderTable::addChild): (RenderTable::calcWidth): (RenderTable::layout): (RenderTable::setCellWidths): (RenderTable::paint): (RenderTable::calcMinMaxWidth): (RenderTable::splitColumn): (RenderTable::appendColumn): (RenderTable::colElement): (RenderTable::recalcSections): (RenderTable::removeChildNode): (RenderTable::dump): (RenderTableSection::RenderTableSection): (RenderTableSection::~RenderTableSection): (RenderTableSection::detach): (RenderTableSection::setStyle): (RenderTableSection::addChild): (RenderTableSection::ensureRows): (RenderTableSection::addCell): (RenderTableSection::setCellWidths): (RenderTableSection::calcRowHeight): (RenderTableSection::layoutRows): (RenderTableSection::paint): (RenderTableSection::recalcCells): (RenderTableSection::clearGrid): (RenderTableSection::removeChildNode): (RenderTableSection::dump): (RenderTableRow::RenderTableRow): (RenderTableRow::detach): (RenderTableRow::setStyle): (RenderTableRow::addChild): (RenderTableRow::removeChildNode): (RenderTableRow::dump): (RenderTableRow::layout): (RenderTableCell::RenderTableCell): (RenderTableCell::detach): (RenderTableCell::updateFromElement): (RenderTableCell::getCellPercentageHeight): (RenderTableCell::setCellPercentageHeight): (RenderTableCell::calcMinMaxWidth): (RenderTableCell::baselinePosition): (RenderTableCell::setStyle): (RenderTableCell::paint): (RenderTableCell::paintBoxDecorations): (RenderTableCell::dump): (RenderTableCol::RenderTableCol): (RenderTableCol::updateFromElement): (RenderTableCol::addChild): (RenderTableCol::dump):
  • khtml/rendering/render_table.h:
  • khtml/rendering/table_layout.cpp: Added. (FixedTableLayout::FixedTableLayout): (FixedTableLayout::~FixedTableLayout): (FixedTableLayout::calcWidthArray): (FixedTableLayout::calcMinMaxWidth): (FixedTableLayout::layout): (AutoTableLayout::AutoTableLayout): (AutoTableLayout::~AutoTableLayout): (AutoTableLayout::recalcColumn): (AutoTableLayout::fullRecalc): (AutoTableLayout::calcMinMaxWidth): (AutoTableLayout::calcEffectiveWidth): (AutoTableLayout::insertSpanCell): (AutoTableLayout::layout): (AutoTableLayout::calcPercentages):
  • khtml/rendering/table_layout.h: Added.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): (NodeImpl::dump):
  • khtml/xml/dom_nodeimpl.h:
2:38 PM Changeset in webkit [3350] by darin
  • 6 edits in trunk/WebCore

Reviewed by Dave.

  • clean room rewrite of QCString::operator<<.
  • kwq/KWQCString.mm: (operator<<): Rewrote it.
  • update format of render tree dumping for real use
  • khtml/rendering/render_layer.h: Added elementList().
  • khtml/rendering/render_layer.cpp: (RenderLayer::elementList): Added.
  • kwq/KWQRenderTreeDebug.cpp: (operator<<): Added an overload for writing out QRect. (writeIndent): Added. (write): Use the overload for QRect, also reorganize to dump layers. (writeLayers): Use this to dump the layers. (externalRepresentation): Call writeLayers instead of write.
11:24 AM Changeset in webkit [3349] by cblu
  • 3 edits in trunk/WebKit

WebFoundation:

Fixed: 3143656 - crash in MIMETypeForFile when a large QT movie is dragged over window

Removed all unnecessary content sniffing as that work is already done in WebResourceLoad.

Reviewed by darin.

  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad _sendResponseMetadataCallbackCheckingPreconditions:]): only sniff here, call _web_guessedMIMEType
  • Misc.subproj/WebMultipartForm.m: include WebNSDataExtras
  • Misc.subproj/WebNSDataExtras.h: Added.
  • Misc.subproj/WebNSDataExtras.m: Added. (-[NSMutableData _web_appendFormat:]): (-[NSMutableData _web_appendEncodedString:format:arguments:]): (-[NSMutableData _web_appendEncodedString:format:]): (-[NSData _web_guessedMIMEType]): was _guessMIMEType in WebResourceLoad
  • Misc.subproj/WebNSMutableDataExtras.h: Removed.
  • Misc.subproj/WebNSMutableDataExtras.m: Removed.
  • Misc.subproj/WebNSStringExtras.h: removed 2 unneeded methods
  • Misc.subproj/WebNSStringExtras.m:
  • ProtocolHandlers.subproj/WebFileProtocolHandler.m: (-[WebFileProtocolHandler didLoadData:]): get the MIME type from the extension, don't sniff
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _extractResponseStatusLineFromBytes:length:]): don't sniff
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Fixed: 3143656 - crash in MIMETypeForFile when a large QT movie is dragged over window

Reviewed by darin.

  • WebView.subproj/WebControllerPrivate.m: (+[WebController _MIMETypeForFile:]): rewrote, now calls _web_guessedMIMEType
9:04 AM Changeset in webkit [3348] by darin
  • 4 edits
    2 deletes in trunk/WebCore

Reviewed by Ken.

  • removed unused KWQDrawUtil code
  • ForwardingHeaders/qdrawutil.h: Emptied this file out.
  • kwq/KWQDrawUtil.h: Removed.
  • kwq/KWQDrawUtil.mm: Removed.
  • WebCore.pbproj/project.pbxproj: Removed KWQDrawUtil.
8:53 AM Changeset in webkit [3347] by darin
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by John.

  • updated copyright to include expat copyrights
  • WebCore.pbproj/project.pbxproj: Added expat copyrights on the end. Got text of copyrights from Acknowledgments.rtf in WebBrowser.

WebBrowser:

Reviewed by John.

  • updated acknowledgments to latest text from legal that mentions expat
  • Help/English.lproj/Acknowledgments.rtf: New drop from legal.
8:07 AM Changeset in webkit [3346] by darin
  • 3 edits in trunk/WebKit

WebKit:

  • compressed all our non-compressed TIFF files
  • Resources/nullplugin.tiff:
  • Resources/url_icon.tiff:

WebBrowser:

  • compressed all our non-compressed TIFF files
  • Preferences.subproj/AppearancePreferences.tiff:
  • Preferences.subproj/BookmarkPreferences.tiff:
  • Preferences.subproj/GeneralPreferences.tiff:
  • Preferences.subproj/SecurityPreferences.tiff:
  • Resources/Images/Activity_Stop.tif:
  • Resources/Images/AddLink.tif:
  • Resources/Images/AddLinkDisabled.tif:
  • Resources/Images/AddLinkPressed.tif:
  • Resources/Images/AddressBook.tiff:
  • Resources/Images/Back.tif:
  • Resources/Images/BackDisabled.tif:
  • Resources/Images/BackPressed.tif:
  • Resources/Images/BookmarksButton.tif:
  • Resources/Images/BookmarksButton_Pressed.tif:
  • Resources/Images/BookmarksButton_Rollover.tif:
  • Resources/Images/BookmarksButton_Selected.tif:
  • Resources/Images/BookmarksButton_Selected_Pressed.tif:
  • Resources/Images/BookmarksDragBadge1-2.tif:
  • Resources/Images/BookmarksDragBadge3.tif:
  • Resources/Images/BookmarksDragBadge4.tif:
  • Resources/Images/BookmarksDragBadge5.tif:
  • Resources/Images/BookmarksDragImage.tif:
  • Resources/Images/Bug_Report.tif:
  • Resources/Images/Bug_Report_Pressed.tif:
  • Resources/Images/DarkMetalSwatch.tif:
  • Resources/Images/Download_Clear.tif:
  • Resources/Images/Download_ClearDisabled.tif:
  • Resources/Images/Download_ClearPressed.tif:
  • Resources/Images/Download_Reload.tif:
  • Resources/Images/Download_ReloadPressed.tif:
  • Resources/Images/Download_Reveal.tif:
  • Resources/Images/Download_RevealPressed.tif:
  • Resources/Images/Download_Stop.tif:
  • Resources/Images/Download_StopPressed.tif:
  • Resources/Images/FavoriteDrag_Caps.tif:
  • Resources/Images/FavoriteDrag_Middle.tif:
  • Resources/Images/FavoritePressed_Caps.tif:
  • Resources/Images/FavoritePressed_Middle.tif:
  • Resources/Images/FavoriteRollover_Caps.tif:
  • Resources/Images/FavoriteRollover_Middle.tif:
  • Resources/Images/FavoritesBar.tif:
  • Resources/Images/FavoritesBarClipIndicator.tiff:
  • Resources/Images/FavoritesBarClipIndicatorPressed.tiff:
  • Resources/Images/FavoritesFolderArrow.tif:
  • Resources/Images/FavoritesFolderArrowWhite.tif:
  • Resources/Images/FontBigger.tif:
  • Resources/Images/FontBiggerDisabled.tif:
  • Resources/Images/FontBiggerPressed.tif:
  • Resources/Images/FontSmaller.tif:
  • Resources/Images/FontSmallerDisabled.tif:
  • Resources/Images/FontSmallerPressed.tif:
  • Resources/Images/Forward.tif:
  • Resources/Images/ForwardDisabled.tif:
  • Resources/Images/ForwardPressed.tif:
  • Resources/Images/History.tif:
  • Resources/Images/Home.tif:
  • Resources/Images/HomeDisabled.tif:
  • Resources/Images/HomePressed.tif:
  • Resources/Images/LibrarySelection.tif:
  • Resources/Images/LibrarySelectionGray.tif:
  • Resources/Images/Location_Left.tif:
  • Resources/Images/Location_Left_Progress.tif:
  • Resources/Images/Location_Middle.tif:
  • Resources/Images/Location_Middle_Progress.tif:
  • Resources/Images/Location_Right_Progress.tif:
  • Resources/Images/Lock.tif:
  • Resources/Images/NewFolder.tif:
  • Resources/Images/NewFolder_Disabled.tif:
  • Resources/Images/NewFolder_Pressed.tif:
  • Resources/Images/Reload.tif:
  • Resources/Images/ReloadDisabled.tif:
  • Resources/Images/ReloadPressed.tif:
  • Resources/Images/Search_Left.tif:
  • Resources/Images/Search_Left_Progress.tif:
  • Resources/Images/Search_Middle.tif:
  • Resources/Images/Search_Middle_Progress.tif:
  • Resources/Images/Search_Right.tif:
  • Resources/Images/Search_Right_Progress.tif:
  • Resources/Images/Search_SnapBack.tif:
  • Resources/Images/Search_SnapBackPressed.tif:
  • Resources/Images/Stop.tif:
  • Resources/Images/StopDisabled.tif:
  • Resources/Images/StopPressed.tif:
  • Resources/Images/folder16.tiff:
  • Resources/Images/rendezvous.tiff:
  • Resources/Images/tiny_menu.tiff:
12:47 AM Changeset in webkit [3345] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3148141 - crash in KJS::WindowFunc::tryCall leaving certain site
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setView): If setting the view to nil and we have a document, detach the document. This means that we are removing a frame from the tree, so we want to run it's onUnload handler now, rather than later when things are no longer fully hooked up.

Jan 16, 2003:

6:25 PM Changeset in webkit [3344] by rjw
  • 4 edits in trunk/WebCore

Fixed 3148932. Account for zero width characters
in <pre> fixed-width optimization.

Reviewed by hyatt.

  • khtml/rendering/render_text.cpp: (RenderText::widthFromCache):

Reviewed by Richard (written by Mike S.) 'Clean' implementations of these
functions that were too similar to the Qt implementations.

  • kwq/KWQString.mm: (QString::left): (QString::right): (QString::mid):
5:43 PM Changeset in webkit [3343] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3144771 - Crash in KJS::WindowFunc::tryCall leaving www.smogcheck.org

I fixed this by making sure we couldn't send the unload event twice, which was
happening before in certain circumstances.

  • khtml/khtml_part.cpp: (KHTMLPart::closeURL): When emitting load event, note that unload event has not yet been sent. (KHTMLPart::checkEmitLoadEvent): Note when unload event has been sent to avoid sending it twice.
  • khtml/khtmlpart_p.h:
5:18 PM Changeset in webkit [3342] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • made minor tweaks to work better with Mozilla's JavaScript tests.
  • kjs/testkjs.cpp: (VersionFunctionImp::call): Implemented (main): Ignore files named -f (hack to match -f <filename syntax that moz JavaScript tests expect). Also use return code 3 instead of 1 for uncaught exception.
5:17 PM Changeset in webkit [3341] by mjs
  • 3 edits in branches/Alexander-48-branch/JavaScriptCore

Reviewed by no one - just backing out an accidental commit to the wrong branch.

  • kjs/testkjs.cpp: (main):
5:02 PM Changeset in webkit [3340] by mjs
  • 4 edits in branches/Alexander-48-branch/WebCore

Reviewed by no one, I'm just rolling out an accidentally committed change.

  • removed the change below which I accidentally committed on the branch.
  • khtml/khtml_part.cpp: (KHTMLPart::closeURL): (KHTMLPart::checkEmitLoadEvent):
  • khtml/khtmlpart_p.h:
4:24 PM Changeset in webkit [3339] by darin
  • 3 edits in trunk/JavaScriptCore
  • kjs/number_object.cpp: (NumberObjectImp::construct): Fix build, remove stray space.
4:17 PM Changeset in webkit [3338] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • rolled in a change from the KJS folks
  • kjs/number_object.h: Use ObjectImp *, not Object, for the proto.
  • kjs/number_object.cpp: (NumberInstanceImp::NumberInstanceImp): Use ObjectImp *, not Object, for the proto. (NumberPrototypeImp::NumberPrototypeImp): Pass ObjectImp. (NumberObjectImp::construct): Use ObjectImp.
3:36 PM Changeset in webkit [3337] by darin
  • 5 edits in trunk

Removed the Safari-49 markers to reduce confusion since
49 was never used and includes changes that were not in 51.

3:08 PM Changeset in webkit [3336] by darin
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebController.h: Fixed a comment that was out of date.
1:11 PM Changeset in webkit [3335] by cblu
  • 2 edits in trunk/WebKit

Fixed comment.

Reviewed by NOBODY (OOPS!).

  • Plugins.subproj/WebBaseNetscapePluginView.m:
1:10 PM Changeset in webkit [3334] by cblu
  • 2 edits in trunk/WebKit

Fixed: 3125743 - right-click doesn't count as ctrl-click in Flash

AppKit doesn't call mouseDown or mouseUp on right-click. Simulate control-click mouseDown and mouseUp so plug-ins get the right-click event as they do in Carbon

Reviewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView rightMouseDown:]): (-[WebBaseNetscapePluginView rightMouseUp:]):
12:45 PM Changeset in webkit [3333] by darin
  • 15 edits
    2 adds
    4 deletes in trunk

WebCore:

Reviewed by John.

  • added an API for dumping the external representation of the render tree for testing
  • kwq/KWQRenderTreeDebug.h: Added.
  • kwq/KWQRenderTreeDebug.cpp: Added.
  • kwq/KWQTextStream.h: Added more overloads for operator<<.
  • kwq/KWQTextStream.mm: (QTextStream::operator<<): Implemented them.
  • kwq/WebCoreBridge.h: Added renderTreeAsExternalRepresentation.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge renderTreeAsExternalRepresentation]): Added.
  • removed remnants of an earlier more-naive cut at this same sort of thing
  • removed ForwardingHeaders from the project since that doesn't really help Project Builder
  • kwq/WebCoreTestController.h: Removed.
  • kwq/WebCoreTestController.m: Removed.
  • WebCore.exp: Removed WebCoreTestController.
  • WebCore-combined.exp: Re-generated.
  • WebCore.pbproj/project.pbxproj: Removed WebCoreTestController and ForwardingHeaders.

WebKit:

Reviewed by John.

  • added an API for dumping the external representation of the render tree for testing
  • Misc.subproj/WebCoreStatistics.h: Added renderTreeAsExternalRepresentation.
  • Misc.subproj/WebCoreStatistics.m: (-[WebFrame renderTreeAsExternalRepresentation]): Added.
  • removed remnants of an earlier more-naive cut at this same sort of thing
  • Misc.subproj/WebTestController.h: Removed.
  • Misc.subproj/WebTestController.m: Removed.
  • WebKit.exp: Removed WebTestController.
  • WebKit.pbproj/project.pbxproj: Removed WebTestController.
  • other changes
  • WebCoreSupport.subproj/WebBridge.m: Had added new copyright date to touch a file. That's not needed any more, but the date should be updated anyway.
10:51 AM Changeset in webkit [3332] by sheridan
  • 3 edits in trunk

Safari-53u; tree is open

10:47 AM Changeset in webkit [3331]
  • 3 copies in tags/Safari-52

This commit was manufactured by cvs2svn to create tag 'Safari-52'.

10:47 AM Changeset in webkit [3330] by sheridan
  • 8 edits in trunk

Safari-52 stamp

Note: See TracTimeline for information about the timeline view.