Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jan 21, 2003:

9:29 PM Changeset in webkit [3395] by trey

• 4 edits in trunk/WebCore

3032718 - I-beam cursor behavior different between web view and text view

Now that the innerNode is the real text element instead of an enclosing
tag element, it's a piece of cake to test for a text node and set the ibeam cursor.

Reviewed by Chris

• khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Set iBeam if over text.
• kwq/KWQKCursor.mm: (KCursor::ibeamCursor): Make this cursor have the Cocoa ibeam instead of arrow.

9:04 PM Changeset in webkit [3394] by hyatt

• 4 edits in trunk/WebCore

Fix selection so that it will go up to the parent node
if the innerNode is text, preserving the old behavior for
now until we can rewrite selection to not require this.

Reviewed by cblu.

• khtml/khtml_events.cpp: (khtml::MouseEvent::offset):
• khtml/khtml_part.cpp: (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent):

9:02 PM Changeset in webkit [3393] by trey

• 3 edits in trunk/WebCore

3121681 - "localhost" part of link is lost with relative links

Was broken for abs links with localhost too. Solution is to tighten up the test
for "localhost" removal to only apply to file urls.
canonical result.

Reviewed by Maciej.

• kwq/KWQKURL.mm: (KURL::parse): Allow the authority processing even for links with localhost. Only cut out the addition of host for locahost file links.

7:06 PM Changeset in webkit [3392] by hyatt

• 2 edits in trunk/WebCore

Fix nodeAtPoint to return text nodes if the mouse is over them.
Make :active fully hierarchical so that e.g., <a><b>Foo</b></a>
gets an outline when clicked.

Reviewed by trey

• khtml/rendering/render_object.cpp: (RenderObject::setHoverAndActive):
• khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):

6:51 PM Changeset in webkit [3391] by hyatt

• 4 edits in trunk/WebCore

Fix nodeAtPoint to return text nodes if the mouse is over them.
Make :active fully hierarchical so that e.g., <a><b>Foo</b></a>
gets an outline when clicked.

Reviewed by ???

• khtml/rendering/render_object.cpp: (RenderObject::setHoverAndActive):
• khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):

5:45 PM Changeset in webkit [3390] by hyatt

• 4 edits in trunk/WebCore

Fix for regressions on layout-tests caused by new table code.
Make sure cell's padding is used and not just the table's cellpadding.

Also make sure cell padding can be changed dynamically.

Reviewed by darin.

• khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn):

5:33 PM Changeset in webkit [3389] by hyatt

• 2 edits in trunk/WebCore

Fix for regressions on layout-tests caused by new table code.
Make sure cell's padding is used and not just the table's cellpadding.

Reviewed by darin.

• khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn):

5:09 PM Changeset in webkit [3388] by darin

• 5 edits in trunk

Bump versions to 0.8.2/54u. Fix some copyrights to say 2003, not 2001-2003.

4:54 PM Changeset in webkit [3387]

• 5 copies
  2 deletes in tags/WebCore-53

This commit was manufactured by cvs2svn to create tag 'WebCore-53'.

4:54 PM Changeset in webkit [3386]

• 3 copies
  2 deletes in tags/JavaScriptCore-53

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-53'.

4:54 PM Changeset in webkit [3385] by darin

• 3 edits in branches

More README and project fixes.

4:51 PM Changeset in webkit [3384] by darin

• 2 edits in branches/JavaScriptCore-53-branch/JavaScriptCore

Updated project and README to prepare for tarballs.

4:49 PM Changeset in webkit [3383] by darin

• 1 edit in trunk/JavaScriptCore/README

New README for tarballs.

4:48 PM Changeset in webkit [3382] by darin

• 1 edit in trunk/WebCore/README

New README.

4:12 PM Changeset in webkit [3381]

• 1 copy
  317 deletes in branches/unlabeled-1.3.50

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.3.50'.

4:12 PM Changeset in webkit [3380]

• 1 copy
  317 deletes in branches/unlabeled-1.2.50

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.2.50'.

4:12 PM Changeset in webkit [3379]

• 1 copy
  317 deletes in branches/unlabeled-1.16.50

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.16.50'.

4:12 PM Changeset in webkit [3378]

• 3 copies
  2 deletes in branches/WebCore-53-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-53-branch'.

4:12 PM Changeset in webkit [3377]

• 3 copies
  2 deletes in tags/WEBCORE_53_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create tag
'WEBCORE_53_BRANCH_ANCHOR'.

4:12 PM Changeset in webkit [3376] by darin

• 390 edits in trunk/WebCore

• correct our copyrights to 2003; copyright is based on year of publication, not year worked on

4:11 PM Changeset in webkit [3375]

• 1 copy
  2 deletes in branches/JavaScriptCore-53-branch

This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-53-branch'.

4:11 PM Changeset in webkit [3374]

• 1 copy
  2 deletes in tags/JAVASCRIPTCORE_53_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create tag
'JAVASCRIPTCORE_53_BRANCH_ANCHOR'.

4:11 PM Changeset in webkit [3373] by darin

• 44 edits in trunk/JavaScriptCore

More copyright fixes.

3:54 PM Changeset in webkit [3372] by hyatt

• 6 edits in trunk/WebCore

Fix for the 2.5% perf regression from the descendant rules
changes. This patch does 3 things:
(1) Fix the descendant rule check in the CSS parser. It
was incorrect.
(2) Fix DOM insertion/removal from setting the parent as needing
a style re-resolve.
(3) Fix whitespace inside <html> so that it doesn't make a premature
<body>.

Reviewed by mjs

• khtml/css/cssparser.cpp: (StyleBaseImpl::parseSelector):
• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
• khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::insertBefore): (NodeBaseImpl::replaceChild): (NodeBaseImpl::removeChild): (NodeBaseImpl::appendChild):

3:46 PM Changeset in webkit [3371] by darin

• 3 edits in trunk/WebCore

Reviewed by Richard.

• clean room rewrite of QCString

• kwq/KWQCString.mm: Replaced functions that needed rewrite.

2:35 PM Changeset in webkit [3370] by rjw

• 11 edits in trunk/WebCore

Added support to pause and resume javascript timers. This allows pages
that have javascript timers to be added to the page cache.

Fixes 3126138.

Reviewed by trey and maciej.

• khtml/ecma/kjs_window.cpp: (Window::pauseTimeouts): (Window::resumeTimeouts): (WindowQObject::pauseTimeouts): (WindowQObject::resumeTimeouts): (WindowQObject::timerEvent):
• khtml/ecma/kjs_window.h:
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::pauseActions): (KWQKHTMLPart::resumeActions): (KWQKHTMLPart::canCachePage): (KWQKHTMLPart::openURLFromPageCache):
• kwq/KWQObject.h:
• kwq/KWQObject.mm: (QObject::pauseTimer): (QObject::_addTimer): (QObject::clearPausedTimers): (QObject::resumeTimers): (QObject::startTimer):
• kwq/KWQPageState.h:
• kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:]): (-[KWQPageState setPausedActions:int::]): (-[KWQPageState int::]): (-[KWQPageState _cleanupPausedActions]): (-[KWQPageState invalidate]): (-[KWQPageState dealloc]):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): (-[WebCoreBridge saveDocumentToPageCache]):

12:32 PM Changeset in webkit [3369] by darin

• 3 edits in trunk/WebCore

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::createRenderer): Add return statements to fix compile on deployment build.

12:19 PM Changeset in webkit [3368] by darin

• 3 edits in trunk/WebCore

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::rendererIsNeeded): (HTMLInputElementImpl::attach): Add return statements to fix compile on deployment build.

12:18 PM Changeset in webkit [3367] by darin

• 45 edits in trunk/JavaScriptCore

• correct our copyrights to 2003; copyright is based on year of publication, not year worked on

11:54 AM Changeset in webkit [3366] by mjs

• 5 edits in trunk/WebCore

Reviewed by Nobody, fixing an accidental commit.

• khtml/khtml_part.cpp:
• khtml/html/html_documentimpl.cpp:
• khtml/xml/dom_docimpl.h:

11:43 AM Changeset in webkit [3365] by darin

• 31 edits in trunk/WebCore

Everything else reviewed by Maciej, dtd.cpp and htmlparser.cpp changes reviewed by Dave.

• fixed 3151098 -- REGRESSION: Frequent assert about renderer in DOM code

• khtml/html/dtd.cpp: (DOM::checkChild): Disallow text inside colgroup so it can be handled as a special case inside the parser.
• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Discard text inside colgroup and don't pop the colgroup.

• fixed 3149792 -- memory trasher at robinlionheart.com
• fixed 3150664 -- failed assertion in HTMLFrameSetElementImpl::attach on page with frameset inside frameset

The key to fixing the 3149792 memory trasher was to avoid constructing trees where there
is a render object nested inside an object that is not a suitable container. In particular,
the code assumed that RenderFlow objects would only be inside other RenderFlow objects, and
this does not happen if you have an <object> that is an image, with objects inside it that
are intended to be used if the image fails to load.

The key to fixing the 3150664 assertion was to handle the case where a frame set's parent
didn't have a renderer, rather than just asserting about it.

• khtml/rendering/render_flow.cpp: (RenderFlow::layout): Added an assertion and a FIXME from Dave's and my review of this code. (RenderFlow::splitInlines): Add assertions that we have actual RenderFlow objects. Casting non-RenderFlow objects was the cause of the memory trashing. The other parts of this change assure we never hit these assertions by not creating any render objects for DOM objects that are inside non-RenderFlow. (RenderFlow::addChildWithContinuation): Add a similar assertion here.

• khtml/rendering/render_object.h: Declare new member function.
• khtml/rendering/render_object.cpp: (RenderObject::canHaveChildren): Return false.
• khtml/rendering/render_container.h: Declare new member function.
• khtml/rendering/render_container.cpp: (RenderContainer::canHaveChildren): Return true.
• khtml/rendering/render_replaced.h: Declare new member function.
• khtml/rendering/render_replaced.cpp: (RenderReplaced::canHaveChildren): Return false.

• khtml/xml/dom_nodeimpl.h: Declare new member functions.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::createRendererIfNeeded): Added. Checks to see if a renderer should be created, and creates it if so. The bug fix is checking canHaveChildren() here. This also reduces the amount of repeated code in various attach() methods. (NodeImpl::styleForRenderer): Added. Default is parent style. (NodeImpl::rendererIsNeeded): Added. Default is to create only if display is not none. (NodeImpl::createRenderer): Added. Must never reach this function, but I didn't make it a pure virtual because of subclasses like AttrImpl that don't ever call createRendererIfNeeded. Could rethink this and improve it even more.

• khtml/xml/dom_elementimpl.h: Declare new member functions.
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::styleForRenderer): Override to get the style from the style selector rather than from the parent renderer. (ElementImpl::createRenderer): Call RenderObject::createObject to create the right type of renderer. (ElementImpl::attach): Call createRendererIfNeeded to do most of the work.

• khtml/html/html_baseimpl.h: Declare new member functions.
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::createRenderer): Create a RenderBody. (HTMLBodyElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLFrameElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLFrameElementImpl::createRenderer): Create a RenderFrame. (HTMLFrameElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLFrameSetElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLFrameSetElementImpl::createRenderer): Create a RenderFrameSet. (HTMLFrameSetElementImpl::attach): Call createRendererIfNeeded to do most of the work. This fixes a bug where the parent doesn't have a renderer; we were asserting in that case rather than just not creating a renderer ourselves, which was wrong. (HTMLHtmlElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLHtmlElementImpl::createRenderer): Create a RenderHtml. (HTMLHtmlElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLIFrameElementImpl::createRenderer): Create a RenderPartObject. (HTMLIFrameElementImpl::attach): Call createRendererIfNeeded to do most of the work.

• khtml/html/html_formimpl.h: Declare new member functions.
• khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::attach): Remove now-unneeded code that is handled by createRendererIfNeeded now. (HTMLInputElementImpl::rendererIsNeeded): Return false for HIDDEN, otherwise call base. (HTMLInputElementImpl::createRenderer): Create the appropriate type of RenderObject. (HTMLInputElementImpl::attach): Call createRendererIfNeeded to do most of the work. Determined that we don't need the special case for image buttons any more. (HTMLSelectElementImpl::createRenderer): Create a RenderSelect. (HTMLSelectElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLTextAreaElementImpl::createRenderer): Create a RenderTextArea. (HTMLTextAreaElementImpl::attach): Call createRendererIfNeeded to do most of the work.

• khtml/html/html_imageimpl.h: Declare new member function.
• khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::createRenderer): Create a RenderImage. (HTMLImageElementImpl::attach): Call createRendererIfNeeded to do most of the work.

• khtml/html/html_inlineimpl.h: Declare new member function.
• khtml/html/html_inlineimpl.cpp: (HTMLBRElementImpl::createRenderer): Create a RenderBR. (HTMLBRElementImpl::attach): Call createRendererIfNeeded to do most of the work.

• khtml/html/html_objectimpl.h: Declare new member functions.
• khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLAppletElementImpl::createRenderer): Create either a RenderApplet or RenderEmptyApplet. (HTMLAppletElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLEmbedElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLEmbedElementImpl::createRenderer): Create a RenderPartObject. (HTMLEmbedElementImpl::attach): Call createRendererIfNeeded to do most of the work. (HTMLObjectElementImpl::rendererIsNeeded): Override to implement the different policy this element uses to decide whether to make a renderer (same as old code). (HTMLObjectElementImpl::createRenderer): Create either a RenderImage or a RenderPartObject. (HTMLObjectElementImpl::attach): Call createRendererIfNeeded to do most of the work.

• khtml/xml/dom_textimpl.h: Declare new member functions.
• khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded): Moved logic about not making renderers for only-whitespace elements here. Left out the special case for textarea, since the fact that RenderReplaced returns false from the canHaveChildren function now takes care of that of that case. (TextImpl::createRenderer): Create a RenderText. (TextImpl::attach): Call createRendererIfNeeded to do most of the work.

• fixed a buffer overrun that libgmalloc detected

• khtml/misc/decoder.cpp: (KanjiCode::judge): Pass in a size parameter instead of using strlen. (Decoder::decode): Pass in a size parameter.

• a little housekeeping

• WebCore.pbproj/project.pbxproj: Remove a bunch of the .moc files from the project. I'm not sure why I put them in originally, but they do no good in there.
• khtml/khtmlview.moc: Empty out this file.

11:18 AM Changeset in webkit [3364] by mjs

• 3 edits in trunk/WebCore

Reviewed by Trey.

• fixed 3145317 - Unable to add or remove menu items on Site Menu page using Safari Beta

This turned out to be a problem with event.layerX / event.layerY.

• khtml/xml/dom2_eventsimpl.cpp: (MouseEventImpl::computeLayerPos): Since layer position is relative to parent layer, go up the layer tree adjusting for layer offset to compute true layer position.

10:28 AM Changeset in webkit [3363] by mjs

• 6 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3151982 - missing content at debka.com after iframe is written using document.write
• fixed 3000234 - javascript problem writing iframe at cycleworld.com

• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler): If we come out of the script with the parser in skip mode, don't throw away the whole rest of the document - instead, parse it as usual. The parser's skip mode will take care of skipping stuff as needed and will detect close tags for special tags like <iframe>.

Jan 20, 2003:

6:35 PM Changeset in webkit [3362] by hyatt

• 4 edits in trunk/WebCore

Fix :hover performance regression on wsj.com. Moving my
<a name="foo"> quirk down into the :hover rule matching code,
so that we'll know never to apply :hover to anchorless <a>s.

Reviewed by gramps

• khtml/css/cssstyleselector.cpp:
• khtml/rendering/render_object.cpp: (RenderObject::setHoverAndActive):

6:33 PM Changeset in webkit [3361] by mjs

• 13 edits
  1 add in trunk

WebCore:

Reviewed by Trey.

• fixed 3132120 - onchange handler not firing on mac.com webmail

• khtml/rendering/render_form.h:
• khtml/rendering/render_replaced.cpp: (RenderWidget::handleFocusOut): Moved empty virtual method here from render_form. (RenderWidget::eventFilter): Uncomment call to handleFocusOut - we need it to send onChange properly.
• khtml/rendering/render_replaced.h:
• kwq/KWQObject.h: Add empty eventFilter virtual method.
• kwq/KWQComboBox.h: Remove no longer needed empty eventFilter.
• kwq/KWQEvent.h: Implement a bit more of QFocusEvent.
• kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Tell the text view its widget. (-[KWQTextAreaTextView setWidget:]): New method to set widget. (-[KWQTextAreaTextView becomeFirstResponder]): In addition to the usual stuff, call the widget's event filter with a focus in event. (-[KWQTextAreaTextView resignFirstResponder]): In addition to the usual stuff, call the widget's event filter with a focus out event.
• kwq/KWQTextField.mm: (-[KWQTextField becomeFirstResponder]): Cleaned up a bit. (-[KWQTextField fieldWillBecomeFirstResponder]): Call the widget's event filter with a focus in event. (-[KWQTextField fieldWillResignFirstResponder]): Call the widget's event filter with a focus out event.
• kwq/KWQView.mm:

WebKit:

Reviewed by Trey.

• fixed 3132120 - onchange handler not firing on mac.com webmail

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView resignFirstResponder]): If we really resign first responder, and our delegate responds to filedWillBecomeFirstResponder, then call that method. (-[WebNSTextView becomeFirstResponder]): If we really become first responder, and our delegate responds to filedWillBecomeFirstResponder, then call that method.

5:35 PM Changeset in webkit [3360] by hyatt

• 3 edits in trunk/WebCore

Fix for 3147213. <nobr> is treated like other inlines now,
so it can contain blocks. <wbr> is also fixed. This fixes
tvguide.com.

Reviewed by john

• khtml/html/dtd.cpp: (DOM::checkChild):

4:29 PM Changeset in webkit [3359] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Reviewed by Hyatt

Moved up to HTTP/1.1 in the simple loader, including chunked transer encoding and
persistent connections. While I was in the neighborhood, I cleaned up a lot of
code and improved some names.

• Database.subproj/WebFileDatabase.m: Changed sync idle timeout from 3 seconds to 10 seconds. In the "real world" I think that this is a better choice since with even DSL speeds, pages often take longer than 3 seconds to load.
• Misc.subproj/WebNSStringExtras.h:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_timeoutFromKeepAliveHeader]): Added this helper.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.h: Added WebHTTPTransferEncoding enum and transferEncodingFlags ivar to the class.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler populateResponseWithProtocolMetadata:]): Do a "sanity" check on the value of transferEncodingFlags. If the encoding is not "identity" discard content length header value. (-[WebHTTPProtocolHandler determineTransferEncoding]): Added.
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.h: Quite a bit of rearranging and additions in order to handle new functionality. Moved the whole method interface into the .m file. None of that was public in any way.
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebHTTPPersistentConnection initWithFD:expiry:]): Added. (-[WebHTTPPersistentConnection isExpired]): Added. (WebSimpleHTTPProtocolHandlerInit): Some name changes and additions in order to handle new functionality. (_persistentConnectionSweeper): Added. (_signalledHandlersCallback): Name change. (_socketWriteCallback): Name change. (_socketReadCallback): Name change. (-[WebSimpleHTTPProtocolHandler initWithResourceLoad:]): Create the HTTP request string here. (-[WebSimpleHTTPProtocolHandler beginLoadInBackgroundWithConditions:]): Now checks to see if a persistent connection is available for the destination host/port. (-[WebSimpleHTTPProtocolHandler endLoad]): Name change to call _finishedWithFileDescriptor. (-[WebSimpleHTTPProtocolHandler cleanUpForRetry]): Rearranged in order to be more legible. Some additions to handle new functionality. (-[WebSimpleHTTPProtocolHandler dealloc]): Adjusted for name changes. (-[WebSimpleHTTPProtocolHandler _createHTTPRequest]): Now uses HTTP/1.1 and Connection: keep-alive. This is what the change is all about. :-) (-[WebSimpleHTTPProtocolHandler _extractResponseStatusLineFromBytes:length:]): (-[WebSimpleHTTPProtocolHandler _processHTTPResultCode]): Name change. (-[WebSimpleHTTPProtocolHandler _performSocketRead]): Name change. (-[WebSimpleHTTPProtocolHandler _finishedWithFileDescriptor]): Name change. Now handles keeping connections alive if they are eligible. (isToken): Added to deal with chunked transfer encoding. (skipLWS): Ditto. (skipToken): Ditto. (skipQuotedString): Ditto. (parseChunkedHeader): Ditto. (-[WebSimpleHTTPProtocolHandler _processResponseData]): Now handles chunked transfer encoding. (-[WebSimpleHTTPProtocolHandler _handleLoadCallback]): Now does more checks to see if a load has finished. Additional logic needed here since we do not get a "hard close" when a load is done since we are trying to keep the socket open.

4:09 PM Changeset in webkit [3358] by trey

• 3 edits in trunk/WebKit

Nit fix to remove a dead "cursor" ivar found while grepping.

Reviewed by Richard.

• WebView.subproj/WebDynamicScrollBarsView.h:
• WebView.subproj/WebDynamicScrollBarsView.m:

4:00 PM Changeset in webkit [3357] by hyatt

• 4 edits in trunk/WebCore

Gah. Fix positioned objects and floating objects so that they
don't append themselves to the list of runs in normal flow.
An astoundingly basic bug. :(

Reviewed by john

• khtml/rendering/bidi.cpp: (appendRunsForObject):
• khtml/rendering/render_flow.cpp: (RenderFlow::addChildToFlow):

1:59 PM Changeset in webkit [3356] by hyatt

• 23 edits in trunk/WebCore

Fixes for 3150561 (blog articles vanish on stylesheet switch) and
and 3150560 (crash changing fixed positioned element to normal
positioning dynamically).

This change makes layers able to deal with dynamic changes in
position that cause you to have to either remove a layer from
the hierarchy while preserving the children or to insert a
layer into the hierarchy in between a parent and its descendants.

This patch also rewrites :hover/:active so that they can actually
be used in selectors other than the rightmost selector (e.g., so you
can write a rule like "li:hover > a").

Also, layers will now properly clear out their hover/active state
when the mouse is no longer inside them.

With these fixes, Eric Meyer's "Pure CSS Menus" work (perfectly)
and the repainting problems on sites like brainjar.com and
diveintomark.org and wired.com are fixed.

Reviewed by mjs and john.

• khtml/css/css_stylesheetimpl.h:
• khtml/css/cssparser.cpp: (StyleBaseImpl::parseSelector):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp:
• khtml/css/cssstyleselector.h:
• khtml/dom/html_head.cpp: (HTMLLinkElement::setDisabled):
• khtml/rendering/render_box.cpp: (RenderBox::setStyle):
• khtml/rendering/render_box.h:
• khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
• khtml/rendering/render_flow.cpp: (RenderFlow::setStyle):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_layer.cpp: (RenderLayer::addChild): (RenderLayer::removeOnlyThisLayer): (RenderLayer::insertOnlyThisLayer): (RenderLayer::clearOtherLayersHoverActiveState): (RenderLayer::clearHoverAndActiveState): (RenderLayer::nodeAtPoint): (RenderLayer::constructZTree):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_object.cpp: (RenderObject::addLayers): (RenderObject::moveLayers): (RenderObject::findNextLayer): (RenderObject::setStyle): (RenderObject::setHoverAndActive):
• khtml/rendering/render_object.h:
• khtml/rendering/render_style.cpp: (RenderStyle::diff):
• khtml/rendering/render_style.h:
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
• khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::setActive):

Jan 18, 2003:

7:08 PM Changeset in webkit [3355] by mjs

• 3 edits in trunk/WebCore

Reviewed by John.

• fixed 3149511 - Blogger.com window closes after update is posted

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): For now, don't allow closing the window at all if it wasn't opened by JavaScript, since we don't support the history object and so can't tell if the window has only one history item.

3:11 PM Changeset in webkit [3354] by mjs

• 3 edits in trunk/WebKit

Reviewed by John.

• fixed 3123041 - VIP: Spewage at bottom of oregonlive.com and other similar pages

• WebView.subproj/WebUserAgentSpoofTable.gperf: Added nj.com to spoof list below oregonlive.com (which was already in there). Added comment explaining the need to spoof a bit more.
• WebView.subproj/WebUserAgentSpoofTable.c: (hash): (_web_findSpoofTableEntry): Regenerated.

Jan 17, 2003:

3:08 PM Changeset in webkit [3353] by darin

• 7 edits in trunk/WebCore

Reviewed by Dave.

• fixed the crashing so the layout tests work

• khtml/rendering/render_layer.h: Add a node pointer result.
• khtml/rendering/render_layer.cpp: (RenderLayer::elementList): Return the node pointer so we can destroy it when done with it.

• khtml/rendering/render_object.h: Make renderArena() const.
• khtml/rendering/render_object.cpp: (RenderObject::renderArena): Make it const.

• kwq/KWQRenderTreeDebug.cpp: (writeLayers): Free the Z layer list when done. Without this things just crashed.

2:46 PM Changeset in webkit [3352] by rjw

• 3 edits in trunk/WebCore

Fixed 3126141. Allow pages with plugins to be cached. This is safe
because plugins are cleanly started/stopped when their containing views are
added/removed from the view hierarchy.

Reviewed by trey.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage):

2:42 PM Changeset in webkit [3351] by hyatt

• 35 edits
  3 adds in trunk/WebCore

The new table code from Lars. Also includes bug fixes for
percentage height children in table cells, for positioning
of tables, and for width distribution of percentage width
cells.

Reviewed by darin

• ForwardingHeaders/rendering/table_layout.h: Added.
• WebCore.pbproj/project.pbxproj:
• khtml/css/cssparser.cpp: (StyleBaseImpl::parseValue):
• khtml/css/cssstyleselector.cpp:
• khtml/css/cssvalues.c: (findValue):
• khtml/css/cssvalues.h:
• khtml/css/cssvalues.in:
• khtml/css/html4.css:
• khtml/dom/html_table.cpp: (HTMLTableElement::insertRow): (HTMLTableElement::deleteRow): (HTMLTableRowElement::insertCell): (HTMLTableRowElement::deleteCell): (HTMLTableSectionElement::insertRow): (HTMLTableSectionElement::deleteRow):
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): (HTMLTableElementImpl::setTFoot): (HTMLTableElementImpl::setTBody): (HTMLTableElementImpl::createTHead): (HTMLTableElementImpl::createTFoot): (HTMLTableElementImpl::insertRow): (HTMLTableElementImpl::deleteRow): (HTMLTableElementImpl::addChild): (HTMLTableElementImpl::parseAttribute): (HTMLTableElementImpl::attach): (HTMLTablePartElementImpl::parseAttribute): (HTMLTableSectionElementImpl::HTMLTableSectionElementImpl): (HTMLTableSectionElementImpl::~HTMLTableSectionElementImpl): (HTMLTableSectionElementImpl::insertRow): (HTMLTableSectionElementImpl::deleteRow): (HTMLTableSectionElementImpl::numRows): (HTMLTableRowElementImpl::rowIndex): (HTMLTableRowElementImpl::insertCell): (HTMLTableRowElementImpl::deleteCell): (HTMLTableCellElementImpl::HTMLTableCellElementImpl): (HTMLTableCellElementImpl::parseAttribute): (HTMLTableCellElementImpl::attach): (HTMLTableColElementImpl::HTMLTableColElementImpl): (HTMLTableColElementImpl::parseAttribute):
• khtml/html/html_tableimpl.h:
• khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): (KHTMLParser::getElement):
• khtml/rendering/bidi.cpp: (RenderFlow::layoutInlineChildren):
• khtml/rendering/render_body.cpp: (RenderBody::availableHeight):
• khtml/rendering/render_body.h:
• khtml/rendering/render_box.cpp: (RenderBox::contentWidth): (RenderBox::contentHeight): (RenderBox::calcReplacedWidth): (RenderBox::calcReplacedHeight): (RenderBox::availableHeight): (RenderBox::calcAbsoluteVertical):
• khtml/rendering/render_box.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::leftOffset): (RenderFlow::rightOffset): (RenderFlow::addOverHangingFloats): (RenderFlow::calcBlockMinMaxWidth): (RenderFlow::calcMinMaxWidth):
• khtml/rendering/render_form.cpp:
• khtml/rendering/render_form.h:
• khtml/rendering/render_frames.cpp:
• khtml/rendering/render_frames.h:
• khtml/rendering/render_object.cpp: (RenderObject::createObject): (RenderObject::paddingTop): (RenderObject::paddingBottom): (RenderObject::paddingLeft): (RenderObject::paddingRight):
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
• khtml/rendering/render_root.cpp: (RenderRoot::RenderRoot): (RenderRoot::layout): (RenderRoot::paintObject):
• khtml/rendering/render_root.h:
• khtml/rendering/render_style.cpp: (StyleSurroundData::StyleSurroundData):
• khtml/rendering/render_style.h:
• khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::~RenderTable): (RenderTable::setStyle): (RenderTable::position): (RenderTable::addChild): (RenderTable::calcWidth): (RenderTable::layout): (RenderTable::setCellWidths): (RenderTable::paint): (RenderTable::calcMinMaxWidth): (RenderTable::splitColumn): (RenderTable::appendColumn): (RenderTable::colElement): (RenderTable::recalcSections): (RenderTable::removeChildNode): (RenderTable::dump): (RenderTableSection::RenderTableSection): (RenderTableSection::~RenderTableSection): (RenderTableSection::detach): (RenderTableSection::setStyle): (RenderTableSection::addChild): (RenderTableSection::ensureRows): (RenderTableSection::addCell): (RenderTableSection::setCellWidths): (RenderTableSection::calcRowHeight): (RenderTableSection::layoutRows): (RenderTableSection::paint): (RenderTableSection::recalcCells): (RenderTableSection::clearGrid): (RenderTableSection::removeChildNode): (RenderTableSection::dump): (RenderTableRow::RenderTableRow): (RenderTableRow::detach): (RenderTableRow::setStyle): (RenderTableRow::addChild): (RenderTableRow::removeChildNode): (RenderTableRow::dump): (RenderTableRow::layout): (RenderTableCell::RenderTableCell): (RenderTableCell::detach): (RenderTableCell::updateFromElement): (RenderTableCell::getCellPercentageHeight): (RenderTableCell::setCellPercentageHeight): (RenderTableCell::calcMinMaxWidth): (RenderTableCell::baselinePosition): (RenderTableCell::setStyle): (RenderTableCell::paint): (RenderTableCell::paintBoxDecorations): (RenderTableCell::dump): (RenderTableCol::RenderTableCol): (RenderTableCol::updateFromElement): (RenderTableCol::addChild): (RenderTableCol::dump):
• khtml/rendering/render_table.h:
• khtml/rendering/table_layout.cpp: Added. (FixedTableLayout::FixedTableLayout): (FixedTableLayout::~FixedTableLayout): (FixedTableLayout::calcWidthArray): (FixedTableLayout::calcMinMaxWidth): (FixedTableLayout::layout): (AutoTableLayout::AutoTableLayout): (AutoTableLayout::~AutoTableLayout): (AutoTableLayout::recalcColumn): (AutoTableLayout::fullRecalc): (AutoTableLayout::calcMinMaxWidth): (AutoTableLayout::calcEffectiveWidth): (AutoTableLayout::insertSpanCell): (AutoTableLayout::layout): (AutoTableLayout::calcPercentages):
• khtml/rendering/table_layout.h: Added.
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLElement):
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl): (NodeImpl::dump):
• khtml/xml/dom_nodeimpl.h:

2:38 PM Changeset in webkit [3350] by darin

• 6 edits in trunk/WebCore

Reviewed by Dave.

• clean room rewrite of QCString::operator<<.

• kwq/KWQCString.mm: (operator<<): Rewrote it.

• update format of render tree dumping for real use

• khtml/rendering/render_layer.h: Added elementList().
• khtml/rendering/render_layer.cpp: (RenderLayer::elementList): Added.

• kwq/KWQRenderTreeDebug.cpp: (operator<<): Added an overload for writing out QRect. (writeIndent): Added. (write): Use the overload for QRect, also reorganize to dump layers. (writeLayers): Use this to dump the layers. (externalRepresentation): Call writeLayers instead of write.

11:24 AM Changeset in webkit [3349] by cblu

• 3 edits in trunk/WebKit

WebFoundation:

Fixed: 3143656 - crash in MIMETypeForFile when a large QT movie is dragged over window

Removed all unnecessary content sniffing as that work is already done in WebResourceLoad.

Reviewed by darin.

• CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad _sendResponseMetadataCallbackCheckingPreconditions:]): only sniff here, call _web_guessedMIMEType
• Misc.subproj/WebMultipartForm.m: include WebNSDataExtras
• Misc.subproj/WebNSDataExtras.h: Added.
• Misc.subproj/WebNSDataExtras.m: Added. (-[NSMutableData _web_appendFormat:]): (-[NSMutableData _web_appendEncodedString:format:arguments:]): (-[NSMutableData _web_appendEncodedString:format:]): (-[NSData _web_guessedMIMEType]): was _guessMIMEType in WebResourceLoad
• Misc.subproj/WebNSMutableDataExtras.h: Removed.
• Misc.subproj/WebNSMutableDataExtras.m: Removed.
• Misc.subproj/WebNSStringExtras.h: removed 2 unneeded methods
• Misc.subproj/WebNSStringExtras.m:
• ProtocolHandlers.subproj/WebFileProtocolHandler.m: (-[WebFileProtocolHandler didLoadData:]): get the MIME type from the extension, don't sniff
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _extractResponseStatusLineFromBytes:length:]): don't sniff
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Fixed: 3143656 - crash in MIMETypeForFile when a large QT movie is dragged over window

Reviewed by darin.

• WebView.subproj/WebControllerPrivate.m: (+[WebController _MIMETypeForFile:]): rewrote, now calls _web_guessedMIMEType

9:04 AM Changeset in webkit [3348] by darin

• 4 edits
  2 deletes in trunk/WebCore

Reviewed by Ken.

• removed unused KWQDrawUtil code

• ForwardingHeaders/qdrawutil.h: Emptied this file out.

• kwq/KWQDrawUtil.h: Removed.
• kwq/KWQDrawUtil.mm: Removed.
• WebCore.pbproj/project.pbxproj: Removed KWQDrawUtil.

8:53 AM Changeset in webkit [3347] by darin

• 3 edits in trunk/WebCore

WebCore:

Reviewed by John.

• updated copyright to include expat copyrights

• WebCore.pbproj/project.pbxproj: Added expat copyrights on the end. Got text of copyrights from Acknowledgments.rtf in WebBrowser.

WebBrowser:

Reviewed by John.

• updated acknowledgments to latest text from legal that mentions expat

• Help/English.lproj/Acknowledgments.rtf: New drop from legal.

8:07 AM Changeset in webkit [3346] by darin

• 3 edits in trunk/WebKit

WebKit:

• compressed all our non-compressed TIFF files

• Resources/nullplugin.tiff:
• Resources/url_icon.tiff:

WebBrowser:

• compressed all our non-compressed TIFF files

• Preferences.subproj/AppearancePreferences.tiff:
• Preferences.subproj/BookmarkPreferences.tiff:
• Preferences.subproj/GeneralPreferences.tiff:
• Preferences.subproj/SecurityPreferences.tiff:
• Resources/Images/Activity_Stop.tif:
• Resources/Images/AddLink.tif:
• Resources/Images/AddLinkDisabled.tif:
• Resources/Images/AddLinkPressed.tif:
• Resources/Images/AddressBook.tiff:
• Resources/Images/Back.tif:
• Resources/Images/BackDisabled.tif:
• Resources/Images/BackPressed.tif:
• Resources/Images/BookmarksButton.tif:
• Resources/Images/BookmarksButton_Pressed.tif:
• Resources/Images/BookmarksButton_Rollover.tif:
• Resources/Images/BookmarksButton_Selected.tif:
• Resources/Images/BookmarksButton_Selected_Pressed.tif:
• Resources/Images/BookmarksDragBadge1-2.tif:
• Resources/Images/BookmarksDragBadge3.tif:
• Resources/Images/BookmarksDragBadge4.tif:
• Resources/Images/BookmarksDragBadge5.tif:
• Resources/Images/BookmarksDragImage.tif:
• Resources/Images/Bug_Report.tif:
• Resources/Images/Bug_Report_Pressed.tif:
• Resources/Images/DarkMetalSwatch.tif:
• Resources/Images/Download_Clear.tif:
• Resources/Images/Download_ClearDisabled.tif:
• Resources/Images/Download_ClearPressed.tif:
• Resources/Images/Download_Reload.tif:
• Resources/Images/Download_ReloadPressed.tif:
• Resources/Images/Download_Reveal.tif:
• Resources/Images/Download_RevealPressed.tif:
• Resources/Images/Download_Stop.tif:
• Resources/Images/Download_StopPressed.tif:
• Resources/Images/FavoriteDrag_Caps.tif:
• Resources/Images/FavoriteDrag_Middle.tif:
• Resources/Images/FavoritePressed_Caps.tif:
• Resources/Images/FavoritePressed_Middle.tif:
• Resources/Images/FavoriteRollover_Caps.tif:
• Resources/Images/FavoriteRollover_Middle.tif:
• Resources/Images/FavoritesBar.tif:
• Resources/Images/FavoritesBarClipIndicator.tiff:
• Resources/Images/FavoritesBarClipIndicatorPressed.tiff:
• Resources/Images/FavoritesFolderArrow.tif:
• Resources/Images/FavoritesFolderArrowWhite.tif:
• Resources/Images/FontBigger.tif:
• Resources/Images/FontBiggerDisabled.tif:
• Resources/Images/FontBiggerPressed.tif:
• Resources/Images/FontSmaller.tif:
• Resources/Images/FontSmallerDisabled.tif:
• Resources/Images/FontSmallerPressed.tif:
• Resources/Images/Forward.tif:
• Resources/Images/ForwardDisabled.tif:
• Resources/Images/ForwardPressed.tif:
• Resources/Images/History.tif:
• Resources/Images/Home.tif:
• Resources/Images/HomeDisabled.tif:
• Resources/Images/HomePressed.tif:
• Resources/Images/LibrarySelection.tif:
• Resources/Images/LibrarySelectionGray.tif:
• Resources/Images/Location_Left.tif:
• Resources/Images/Location_Left_Progress.tif:
• Resources/Images/Location_Middle.tif:
• Resources/Images/Location_Middle_Progress.tif:
• Resources/Images/Location_Right_Progress.tif:
• Resources/Images/Lock.tif:
• Resources/Images/NewFolder.tif:
• Resources/Images/NewFolder_Disabled.tif:
• Resources/Images/NewFolder_Pressed.tif:
• Resources/Images/Reload.tif:
• Resources/Images/ReloadDisabled.tif:
• Resources/Images/ReloadPressed.tif:
• Resources/Images/Search_Left.tif:
• Resources/Images/Search_Left_Progress.tif:
• Resources/Images/Search_Middle.tif:
• Resources/Images/Search_Middle_Progress.tif:
• Resources/Images/Search_Right.tif:
• Resources/Images/Search_Right_Progress.tif:
• Resources/Images/Search_SnapBack.tif:
• Resources/Images/Search_SnapBackPressed.tif:
• Resources/Images/Stop.tif:
• Resources/Images/StopDisabled.tif:
• Resources/Images/StopPressed.tif:
• Resources/Images/folder16.tiff:
• Resources/Images/rendezvous.tiff:
• Resources/Images/tiny_menu.tiff:

12:47 AM Changeset in webkit [3345] by mjs

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3148141 - crash in KJS::WindowFunc::tryCall leaving certain site

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setView): If setting the view to nil and we have a document, detach the document. This means that we are removing a frame from the tree, so we want to run it's onUnload handler now, rather than later when things are no longer fully hooked up.