Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Feb 1, 2003:

5:29 PM Changeset in webkit [3540] by darin

• 3 edits in trunk/WebCore

• fix mistake that broke build

• khtml/rendering/render_block.h: Add include of <qsortedlist.h>.

5:02 PM Changeset in webkit [3539] by mjs

• 3 edits in trunk/WebKit

Reviewed by Darin and Ken.

• fixed 3162581 - 56 debug: Assertion failure displaying pop-up menu while downloading

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): No need to assert that the controller is not deferred if this is a handle being used for a download. (-[WebMainResourceClient handle:didReceiveData:]): Likewise. (-[WebMainResourceClient handleDidFinishLoading:]): Likewise. (-[WebMainResourceClient handle:didFailLoadingWithError:]): Likewise.

4:51 PM Changeset in webkit [3538] by darin

• 12 edits in trunk/WebCore

Reviewed by Dave.

• reduced the amount of RenderFlow in the world by about 1/2

• khtml/rendering/bidi.h: Take RenderBlock * instead of RenderFlow *.
• khtml/rendering/bidi.cpp: (BidiIterator::BidiIterator): Take RenderBlock * instead of RenderFlow *. (RenderBlock::layoutInlineChildren): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::findNextLineBreak): Fix debug message to say RenderBlock instead of RenderFlow.

• khtml/rendering/render_block.cpp: (RenderBlock::addChildToFlow): Make RenderBlock * instead of RenderFlow *. (RenderBlock::layout): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::layoutBlockChildren): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::clearFloats): Fix debug message to say RenderBlock instead of RenderFlow.

• khtml/rendering/render_flow.h: Return a RenderFlow * instead of a RenderObject * from createFlow.
• khtml/rendering/render_flow.cpp: (RenderFlow::createFlow): Use an if statement instead of ? : to get rid of typecasting.

• khtml/rendering/render_html.cpp: (RenderHtml::containingBlockWidth): Fix parent call to call RenderBlock. Calling RenderFlow was a mistake, but one that didn't matter since the actual method isn't implemented until up in RenderBox anyway.

• khtml/rendering/render_inline.h: Change some parameters to RenderBlock *.
• khtml/rendering/render_inline.cpp: (cloneInline): Make this return a RenderInline * instead of a RenderFlow *. (RenderInline::splitInlines): Change some parameters to RenderBlock * and locals to RenderInline *. (RenderInline::splitFlow): Change some parameters and locals to RenderBlock *.

• khtml/rendering/render_layer.h: Remove forward declaration of class RenderFlow.
• khtml/rendering/render_object.h: Remove forward declaration and friend declaration of class RenderFlow.

1:39 PM Changeset in webkit [3537] by trey

• 12 edits
  2 adds in trunk

WebCore:

New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.

New SPI is exposed over the bridge and KWQTextField passes the text delegate msgs to it.

Reviewed by Richard

• kwq/KWQTextField.mm: Pass text delegate msgs through new SPI. (-[KWQTextField controlTextDidBeginEditing:]): (-[KWQTextField controlTextDidEndEditing:]): (-[KWQTextField controlTextDidChange:]): (-[KWQTextField control:textShouldBeginEditing:]): (-[KWQTextField control:textShouldEndEditing:]): (-[KWQTextField control:didFailToFormatString:errorDescription:]): (-[KWQTextField control:didFailToValidatePartialString:errorDescription:]): (-[KWQTextField control:isValidObject:]): (-[KWQTextField control:textView:doCommandBySelector:]):
• kwq/WebCoreBridge.h: New SPI for passing text delegate msgs.

WebKit:

New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.

New private API is exposed for the app to set a WebFormDelegate.

Reviewed by Richard

• WebCoreSupport.subproj/WebBridge.m: Pass msgs from WC on to the controller's FormDelegate. (formDelegate): Little utility function. (-[WebBridge controlTextDidBeginEditing:]): (-[WebBridge controlTextDidEndEditing:]): (-[WebBridge controlTextDidChange:]): (-[WebBridge control:textShouldBeginEditing:]): (-[WebBridge control:textShouldEndEditing:]): (-[WebBridge control:didFailToFormatString:errorDescription:]): (-[WebBridge control:didFailToValidatePartialString:errorDescription:]): (-[WebBridge control:isValidObject:]): (-[WebBridge control:textView:doCommandBySelector:]):
• WebKit.exp: New class exported.
• WebKit.pbproj/project.pbxproj: New WebFormDelegate files.
• WebView.subproj/WebControllerPrivate.h: API to set/get FormDelegate.
• WebView.subproj/WebControllerPrivate.m: (-[WebController _setFormDelegate:]): simple setter (-[WebController _formDelegate]): simple getter
• WebView.subproj/WebFormDelegate.h: Added.
• WebView.subproj/WebFormDelegate.m: Added. NOP impls for all these delegate methods. (-[WebFormDelegate controlTextDidBeginEditing:inFrame:]): (-[WebFormDelegate controlTextDidEndEditing:inFrame:]): (-[WebFormDelegate controlTextDidChange:inFrame:]): (-[WebFormDelegate control:textShouldBeginEditing:inFrame:]): (-[WebFormDelegate control:textShouldEndEditing:inFrame:]): (-[WebFormDelegate control:didFailToFormatString:errorDescription:inFrame:]): (-[WebFormDelegate control:didFailToValidatePartialString:errorDescription:inFrame:]): (-[WebFormDelegate control:isValidObject:inFrame:]): (-[WebFormDelegate control:textView:doCommandBySelector:inFrame:]):

WebBrowser:

New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.

This is mostly using new API, with a couple autocomplete fixes for newly exposed issues.

Reviewed by Richard

• BrowserWindowController.h: New formDelegate ivar.
• BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Create FormDelegate, an internal helper object to field WebFormDelegate messages. (-[BrowserWindowController dealloc]): Release FormDelegate. (-[BrowserWindowController controlTextDidEndEditing:]): Pass msg on to completion controller. (-[FormDelegate initWithController:]): Create CompletionController to do autocomplete (commented out for now). (-[FormDelegate controlTextDidBeginEditing:inFrame:]): Pass msg on to completion controller. (-[FormDelegate controlTextDidEndEditing:inFrame:]): Pass msg on to completion controller. (-[FormDelegate controlTextDidChange:inFrame:]): Pass msg on to completion controller. (-[FormDelegate control:textView:doCommandBySelector:inFrame:]): Pass msg on to completion controller.
• CompletionController.h: Added controlTextDidBeginEditing: Should have been receiving this all along.
• CompletionController.m: (-[CompletionController _buildUI]): Set TableView font to match the textfield. (-[CompletionController _positionWindow]): Position window relative to TextField, not enclosing ScrollView (bogus code that's a NOP for the locationField). (-[CompletionController controlTextDidEndEditing:]): Hide the completion window when we leave the field.

Jan 31, 2003:

6:30 PM Changeset in webkit [3536] by hyatt

• 3 edits in trunk/WebCore

Fix regression that broke John's site. RenderInline needs
to implement childrenInline() so that it can return true.
I pulled this method out of RenderFlow and into RenderBlock,
which caused RenderInline to use RenderObject's method (and
that one returns false).

Reviewed by rjw

• khtml/rendering/render_inline.h:

5:44 PM Changeset in webkit [3535] by hyatt

• 3 edits in trunk/WebCore

Fix for crash on espn.com. Revert my change to make
containingBlock() return 0 for the root. Put it back to the
old behavior, where the root returns itself when you ask for
the root's containing block.

Reviewed by rjw

• khtml/rendering/render_object.cpp: (RenderObject::containingBlock): (RenderObject::setOverhangingContents):

5:13 PM Changeset in webkit [3534] by hyatt

• 3 edits in trunk/WebCore

Two whitespace handling fixes that improve <pre> handling,
especially of inline pres.

Reviewed by rjw.

• khtml/rendering/bidi.cpp: (RenderBlock::findNextLineBreak):

4:31 PM Changeset in webkit [3533]

• 15 copies
  1 delete in tags/Safari-56

This commit was manufactured by cvs2svn to create tag 'Safari-56'.

4:31 PM Changeset in webkit [3532] by sheridan

• 8 edits in branches/Safari-0-8-2-branch

Safari-56 version stamp

3:14 PM Changeset in webkit [3531] by darin

• 3 edits in branches/Safari-0-8-2-branch/WebCore

Rolled over changes from the main trunk.

2003-01-31 Darin Adler <Darin Adler>

Reviewed by Richard.

• khtml/misc/decoder.cpp: (Decoder::decode): Turn off Japanese auto-detect. It was causing us to use Japanese encoding on pages that were UTF-8.

3:13 PM Changeset in webkit [3530] by darin

• 3 edits in trunk/WebCore

Reviewed by Richard.

• khtml/misc/decoder.cpp: (Decoder::decode): Turn off Japanese auto-detect. It was causing us to use Japanese encoding on pages that were UTF-8.

2:06 PM Changeset in webkit [3529] by darin

• 4 edits
  1 delete in branches/Safari-0-8-2-branch/WebCore

Rolled over changes from the main trunk.

2003-01-31 Darin Adler <Darin Adler>

• Resources/Info.plist: Removed unused file.

2003-01-31 Darin Adler <Darin Adler>

Reviewed by me, Dave wrote the code.

• fixed 3162013 -- Safari collapses margins through bottom borders (affects top of zeldman.com)

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): Don't collapse if we have any bottom border or padding.

2003-01-31 Darin Adler <Darin Adler>

Reviewed by Dave.

• fixed 3160442 -- no top image map at ebay, caused by referrer returning null instead of empty string

• khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): Return an empty string, not null, when there is no referrer.

1:47 PM Changeset in webkit [3528] by darin

• 2 edits
  1 delete in trunk/WebCore

• Resources/Info.plist: Removed unused file.

1:44 PM Changeset in webkit [3527] by hyatt

• 26 edits
  4 adds in trunk/WebCore

Split RenderFlow into subclasses: RenderInline and RenderBlock.
This change should make inlines a lot smaller (since nearly all
of the member variables in RenderFlow moved into RenderBlock).

It also simplifies methods like containingBlock(), which can
now return a RenderBlock.

Reviewed by darin

• WebCore.pbproj/project.pbxproj:
• khtml/css/cssstyleselector.cpp:
• khtml/rendering/bidi.cpp: (RenderBlock::bidiReorderLine): (RenderBlock::layoutInlineChildren): (RenderBlock::findNextLineBreak):
• khtml/rendering/render_block.cpp: Added. (:RenderFlow): (RenderBlock::~RenderBlock): (RenderBlock::setStyle): (RenderBlock::addChildToFlow): (getInlineRun): (RenderBlock::makeChildrenNonInline): (RenderBlock::removeChild): (RenderBlock::layout): (RenderBlock::layoutBlockChildren): (RenderBlock::layoutSpecialObjects): (RenderBlock::paint): (RenderBlock::paintObject): (RenderBlock::paintFloats): (RenderBlock::insertSpecialObject): (RenderBlock::removeSpecialObject): (RenderBlock::positionNewFloats): (RenderBlock::newLine): (RenderBlock::leftOffset): (RenderBlock::leftRelOffset): (RenderBlock::rightOffset): (RenderBlock::rightRelOffset): (RenderBlock::lineWidth): (RenderBlock::nearestFloatBottom): (RenderBlock::floatBottom): (RenderBlock::lowestPosition): (RenderBlock::rightmostPosition): (RenderBlock::leftBottom): (RenderBlock::rightBottom): (RenderBlock::clearFloats): (RenderBlock::addOverHangingFloats): (RenderBlock::checkClear): (RenderBlock::nodeAtPoint): (RenderBlock::calcMinMaxWidth): (next): (RenderBlock::calcInlineMinMaxWidth): (RenderBlock::calcBlockMinMaxWidth): (RenderBlock::close): (RenderBlock::printTree): (RenderBlock::dump):
• khtml/rendering/render_block.h: Added.
• khtml/rendering/render_body.cpp: (RenderBody::RenderBody): (RenderBody::setStyle): (RenderBody::layout): (RenderBody::availableHeight):
• khtml/rendering/render_body.h:
• khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth): (RenderBox::calcWidth): (RenderBox::calcHeight):
• khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild): (RenderContainer::removeLeftoverAnonymousBoxes):
• khtml/rendering/render_flow.cpp: (RenderFlow::createFlow): (RenderFlow::addChildWithContinuation):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_form.h:
• khtml/rendering/render_html.cpp: (RenderHtml::RenderHtml): (RenderHtml::setStyle): (RenderHtml::layout):
• khtml/rendering/render_html.h:
• khtml/rendering/render_image.h:
• khtml/rendering/render_inline.cpp: Added. (:RenderFlow): (RenderInline::~RenderInline): (RenderInline::setStyle): (RenderInline::addChildToFlow): (cloneInline): (RenderInline::splitInlines): (RenderInline::splitFlow): (RenderInline::paint): (RenderInline::paintObject): (RenderInline::calcMinMaxWidth): (RenderInline::offsetWidth): (RenderInline::offsetHeight): (RenderInline::offsetLeft): (RenderInline::offsetTop):
• khtml/rendering/render_inline.h: Added.
• khtml/rendering/render_list.cpp: (RenderListItem::RenderListItem): (RenderListItem::setStyle): (getParentOfFirstLineBox): (RenderListItem::calcMinMaxWidth): (RenderListItem::layout): (RenderListItem::paint): (RenderListItem::paintObject):
• khtml/rendering/render_list.h:
• khtml/rendering/render_object.cpp: (RenderObject::createObject): (RenderObject::containingBlock): (RenderObject::setOverhangingContents): (RenderObject::removeFromSpecialObjects):
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.h:
• khtml/rendering/render_root.cpp: (RenderRoot::RenderRoot): (RenderRoot::calcMinMaxWidth): (RenderRoot::layout): (RenderRoot::paintObject):
• khtml/rendering/render_root.h:
• khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::setStyle): (RenderTable::lineHeight): (RenderTable::baselinePosition): (RenderTable::addChild): (RenderTable::calcWidth): (RenderTable::recalcSections): (RenderTable::dump): (RenderTableCell::RenderTableCell): (RenderTableCell::detach): (RenderTableCell::calcMinMaxWidth): (RenderTableCell::close): (RenderTableCell::repaintRectangle): (RenderTableCell::absolutePosition): (RenderTableCell::setStyle): (RenderTableCell::dump):
• khtml/rendering/render_table.h:
• khtml/rendering/render_text.h:
• khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):

1:13 PM Changeset in webkit [3526] by darin

• 3 edits in trunk/WebCore

Reviewed by me, Dave wrote the code.

• fixed 3162013 -- Safari collapses margins through bottom borders (affects top of zeldman.com)

• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): Don't collapse if we have any bottom border or padding.

1:09 PM Changeset in webkit [3525] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3160442 -- no top image map at ebay, caused by referrer returning null instead of empty string

• khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): Return an empty string, not null, when there is no referrer.

12:55 PM Changeset in webkit [3524] by cblu

• 7 edits in trunk

WebCore:

• kwq/WebCoreBridge.mm: fixed key value

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
• WebView.subproj/WebController.m: fixed key value

WebBrowser:

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

9:38 AM Changeset in webkit [3523] by cblu

• 14 edits in trunk

WebCore:

Fixed : 3155148 - image shown when dragging gets size from image file, not size as used on page

Reviewed by darin.

• kwq/WebCoreBridge.h: added WebCoreElementImageRectKey
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): get the rect of the image

WebKit:

Fixed : 3155148 - image shown when dragging gets size from image file, not size as used on page

Reviewed by darin.

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:rect:URL:fileType:title:event:]): take a rect so we know the original size and origin
• WebKit.exp: added WebElementImageRectKey
• WebView.subproj/WebController.h: WebElementImageRectKey
• WebView.subproj/WebController.m: WebElementImageRectKey
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _handleMouseDragged:]): call _web_dragPromisedImage with WebElementImageRect
• WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]): provide the WebElementImageRect since we do this for other image elements (-[WebImageView mouseDragged:]): call _web_dragPromisedImage with [self bounds]

8:54 AM Changeset in webkit [3522] by trey

• 4 edits in trunk/WebCore

3161088 - disabled select elements are not disabled when scrolling list used

We use a tableview delegate method to prevent the user from changing the
selection when disabled. Too bad tableviews don't know how to disable themselves.
We also condition the cell used for drawing to match our enabled state.

Reviewed by Maciej.

• kwq/KWQListBox.h: Keep track of whether we are enabled.
• kwq/KWQListBox.mm: (QListBox::QListBox): Init new flag. (QListBox::setEnabled): Set new flag. (QListBox::isEnabled): Getter for new flag. (-[KWQListBoxTableViewDelegate selectionShouldChangeInTableView:]): Disallow selection changes if disabled. (-[KWQListBoxTableViewDelegate tableView:willDisplayCell:forTableColumn:row:]): Enable cell based on our enabled state to get visual feedback of being disabled.

Jan 30, 2003:

8:59 PM Changeset in webkit [3521] by trey

• 3 edits in trunk/WebCore

3161486 - REGRESSION: double click on a widget causes crash

Slight enhancement to the earlier fix of this bug. When handling a doubleclick we
don't want to try to pass the current event down the Cocoa widgets, because Cocoa
has no double-click event, and we just end up resending one we already sent.

The upshot is that we do not pass an extra mouseup event to the widgets at the
end of a double click sequence.

Reviewed by Darin.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Do not pass event down to the widget for doubleclick events.

8:09 PM Changeset in webkit [3520]

• 6 copies in tags/Safari-55

This commit was manufactured by cvs2svn to create tag 'Safari-55'.

8:09 PM Changeset in webkit [3519]

• 6 copies in branches/Safari-0-8-2-branch

This commit was manufactured by cvs2svn to create branch
'Safari-0-8-2-branch'.

8:09 PM Changeset in webkit [3518]

• 6 copies in tags/SAFARI_0_8_2_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create tag
'SAFARI_0_8_2_BRANCH_ANCHOR'.

8:09 PM Changeset in webkit [3517] by darin

• 6 edits in trunk/WebCore

Reviewed by Ken, Maciej, and Trey.

• fixed 3161486 -- REGRESSION: double click on a widget causes crash

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Only pass the mouseUp event if it's not the same as the current event. Through a strange set of circumstances, sometimes the "mouse down" event is a mouse up event (due to KHTML vs. AppKit differences for double-click handling).

• fixed build with newer compiler

• khtml/html/Makefile.am: Use ANSI-C style, not C++ style, gperf.
• khtml/html/doctypes.cpp: Regenerated.
• khtml/html/html_documentimpl.cpp: Do inline workaround to make newer compiler happy. (HTMLDocumentImpl::determineParseMode): Change to use ANSI-C style.

4:42 PM Changeset in webkit [3516] by sheridan

• 4 edits in trunk

tree is open, 56u is build version, now on the path to beta 2 officially

4:34 PM Changeset in webkit [3515] by sheridan

• 8 edits in trunk

Safari-55 version stamp

4:13 PM Changeset in webkit [3514] by cblu

• 3 edits in trunk/WebKit

Backed out my fix for 3161102. Richard and I found problems the fix. 3161102 turns out to not be an issue.

Reviewed by rjw.

• History.subproj/WebHistoryItem.m: (+[WebHistoryItem _releaseAllPendingPageCaches]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView windowWillClose:]):

2:17 PM Changeset in webkit [3513] by rjw

• 3 edits in trunk/WebCore

Fix for 3156831 (and dupe 3160816). Don't access userInfo on an invalid NSTimer.

Reviewed by trey.

• kwq/KWQObject.mm: (QObject::pauseTimer): (QObject::resumeTimers):

2:11 PM Changeset in webkit [3512] by cblu

• 3 edits in trunk/WebKit

Fixed: 3161102 - Avoid retain cycles by destroying plug-ins in the page cache before dealloc

Reviewed by rjw.

• History.subproj/WebHistoryItem.m: (+[WebHistoryItem _releaseAllPendingPageCaches]): iterate over all of the plug-ins and call destroy
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView windowWillClose:]): clear page cache

1:41 PM Changeset in webkit [3511] by trey

• 3 edits in trunk/WebCore

3160565 - REGRESSION: Can't log in to etrade

Fix regression caused by fixed to 3058229. We auto-select an item of a select element
if it is size=1 or size is unset (m_size==0 in the code).

This gives us conformance with WinIE. The test at dbaron.org fails us for the
case of a disabled list with no size and no initial selection.

Reviewed by Darin.

• khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::recalcListItems): Auto-select an item if size==1 or is unset.

1:22 PM Changeset in webkit [3510] by hyatt

• 3 edits in trunk/WebCore

Make quirk bits part of the bitfield to shrink RenderFlows.

Reviewed by trey

• khtml/rendering/render_flow.h:

12:24 PM Changeset in webkit [3509] by hyatt

• 5 edits in trunk/WebCore

Fix for 3155954. Make sure no layers get made for :before,
:after or :first-letter. The only debatable case is whether
overflow can apply to generated content. Included a FIXME
to think about that case.

Reviewed by darin

• khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
• khtml/rendering/render_flow.cpp: (RenderFlow::addChildToFlow):
• khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):

12:03 PM Changeset in webkit [3508] by cblu

• 3 edits in trunk/WebKit

Fixed: 3160464 - Slideback sometimes happens twice

Because we start drags in mouseDragged (which AppKit says we shouldn't), we get mouseDragged events after a drag (image, link, text etc) has ended. We also get mouseDragged events after we've sent the fake mouseUp to WebCore. That is probably bad for unknown reasons.

Reviewed by darin.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): set ignoringMouseDraggedEvents to NO (-[WebHTMLView mouseDragged:]): check ignoringMouseDraggedEvents (-[WebHTMLView draggedImage:endedAt:operation:]): set ignoringMouseDraggedEvents to NO
• WebView.subproj/WebHTMLViewPrivate.h: added ignoringMouseDraggedEvents

11:25 AM Changeset in webkit [3507] by darin

• 3 edits in trunk/WebCore

• khtml/html/html_documentimpl.cpp: Updated license.

9:12 AM Changeset in webkit [3506] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed 3160710 -- REGRESSION: bizrate.com front page ad in wrong position

The new code to compute port coordinates was screwing up somehow.
I had to roll it out and we'll have to try again to fix the problem Ed was fixing.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Roll back changes between 1.45 and 1.47.

8:08 AM Changeset in webkit [3505] by darin

• 3 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3158958 -- nil-dereference in KJS::DOMNode::getValueProperty at www.babyage.com

• khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): Move the code that gets the render object down after the point where the render tree is updated, so we don't end up using a stale pointer.

Jan 29, 2003:

10:32 PM Changeset in webkit [3504] by darin

• 3 edits in trunk/WebCore

• add new assertion that Dave can use to debug bug 3155954 tomorrow

• khtml/rendering/render_arena.cpp: (RenderArena::allocate): Assert that the arena is not 0. (RenderArena::free): Change signature so we will detect double-frees even more simply.

8:48 PM Changeset in webkit [3503] by hyatt

• 5 edits in trunk/WebCore

Margins were being lost on documents inside iframes
and objects. This turned out to be 3 different bugs, one
of which involved the bad cast of an object element to an
iframe element.

Reviewed by darin

• khtml/html/html_baseimpl.cpp: (HTMLIFrameElementImpl::HTMLIFrameElementImpl):
• khtml/rendering/render_frames.cpp: (RenderPartObject::slotViewCleared):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):

5:11 PM Changeset in webkit [3502] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed 3158624 -- crash reentering WebBaseNetscapePluginView removeTrackingRect closing window

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView removeTrackingRect]): Set tracking tag to 0 before releasing the window to prevent reentering.

4:29 PM Changeset in webkit [3501] by hyatt

• 2 edits in trunk/WebCore

Fix for auto width tables. Prevent overflow when assigning from
the computed integer max width back into a short value.

Fixes cnn.com and spies.com. Bug # is 3158469.

Reviewed by darin

• khtml/rendering/table_layout.cpp: (AutoTableLayout::calcMinMaxWidth):

4:28 PM Changeset in webkit [3500] by hyatt

• 3 edits in trunk/WebCore

Fix for auto width tables. Prevent overflow when assigning from
the computed integer max width back into a short value.

Fixes cnn.com and spies.com. Bug # is 3158469.

Reviewed by darin

• khtml/rendering/table_layout.cpp: (AutoTableLayout::calcMinMaxWidth):

4:28 PM Changeset in webkit [3499] by sullivan

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Reviewed by Ken

• Database.subproj/WebFileDatabase.m: (-[WebFileDatabase _truncateToSizeLimit:]): fixed an NSString leak found with the leaks tool.

4:23 PM Changeset in webkit [3498] by darin

• 5 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3150439 -- navigating to a .xml, then away, then back causes display problems

• khtml/rendering/render_root.h: Add paintBoxDecorations
• khtml/rendering/render_root.cpp: (RenderRoot::paintObject): Call paintBoxDecorations all the time. Don't consult shouldPaintBackgroundOrBorder(), and don't waste cycles on !isInline(). (RenderRoot::paintBoxDecorations): If we don't have a RenderHtml as our first child, then fill with the background color.

• khtml/html/htmlparser.cpp: (KHTMLParser::finished): Remove code that makes an HTML element for an empty document. We don't need it any more.

3:40 PM Changeset in webkit [3497] by kocienda

• 9 edits in trunk/WebKit

Reviewed by Darin.

Fix for this bug:

Radar 3142818 (Downloading many items quickly can cause future page loads to fail)

The issue was with a mismatch between different object's idea about
whether callbacks were being deferred. I have simplified the code in this
area somewhat, and I have added some asserts to make sure that callbacks
are not sent when deferalls are on.

More work will need to be done in callback deferral-land, however. This change
fixes the bug, but it may not be a good long-term fix. I will file a bug on
the need for this additonal work.

• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate defersCallbacks]): Added method.
• WebView.subproj/WebMainResourceClient.h: Removed unneeded defersBeforeCheckingPolicy flag.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterNavigationPolicy:request:]): Unconditionally set callback deferrals to NO. (-[WebMainResourceClient handle:willSendRequest:]): Remove all callback deferral code here. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Unconditionally set callback deferrals to NO. (-[WebMainResourceClient handle:didReceiveResponse:]): Assert that the handle argument to this method, the client (self), and the data source's controller all are not deferring callbacks. Unconditionally set callback deferrals to YES. (-[WebMainResourceClient handle:didReceiveData:]): Ditto (-[WebMainResourceClient handleDidFinishLoading:]): Ditto (-[WebMainResourceClient handle:didFailLoadingWithError:]): Ditto

3:33 PM Changeset in webkit [3496] by sullivan

• 2 edits in trunk/WebKit

• fixed 3160116 -- REGRESSION:leak in WebBookmarkLeaf at startup

Reviewed by Darin

• Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): don't leak the _entry that was created in initWithURLString:title:group:

3:21 PM Changeset in webkit [3495] by hyatt

• 5 edits in trunk/WebCore

Fix for tables. They weren't initializing their max top/bottom
values for margin collapsing, so their margins were being
ignored!

Reviewed by darin

• khtml/rendering/render_flow.cpp: (RenderFlow::layout):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_table.cpp: (RenderTable::layout):

2:00 PM Changeset in webkit [3494] by hyatt

• 3 edits in trunk/WebCore

Back out my removal of the layer optimization. The rest of
the code is not prepared to deal with child elements overriding
visibility, or with invisible layers sitting on top of
visible ones.

• khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):

1:53 PM Changeset in webkit [3493] by trey

• 5 edits in trunk/WebKit

3159750 - REGRESSION: cursor is I-beam when over a standalone image

We now reset the cursor to arrow before switching doc views.

Also, made various replacements of "id <WebDocumentView>" with "NSView < WebDocumentView> *"
to get better compile time checking.

Reviewed by Darin.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _makeDocumentView]): Use NSView* (-[WebFrame _transitionToCommitted:]): Use NSView*
• WebView.subproj/WebViewPrivate.h: Use NSView*
• WebView.subproj/WebViewPrivate.m: (-[WebView _setDocumentView:]): Use NSView*. Reset cursor. (-[WebView _makeDocumentViewForDataSource:]): Use NSView*

12:55 PM Changeset in webkit [3492] by cblu

• 3 edits in trunk/WebKit

3159529 - REGRESSION: URLs with no path are saved as "-.html"

Reviewed by darin, trey, kocienda.

• Misc.subproj/WebResourceResponseExtras.m: (-[NSURL _web_suggestedFilenameForSavingWithMIMEType:]): Don't use the lastPathComponent if it is "/".

12:46 PM Changeset in webkit [3491] by hyatt

• 4 edits in trunk/WebCore

Fix yet another bug with makeChildrenNonInline that caused the
assertion on 3158194. Rather than trying to work with the
function as it was written by the KHTML guys, I've just thrown
everything out and re-written it using a helper function to make
it more clear what's going on (and less error-prone).

Reviewed by darin

• khtml/rendering/render_flow.cpp: (getInlineRun): (RenderFlow::makeChildrenNonInline):

10:45 AM Changeset in webkit [3490] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by John.

• kjs/scope_chain.cpp: Rolled out the fix to bug 3137084. It caused a massive storage leak, and probably didn't even fix the bug.

10:01 AM Changeset in webkit [3489] by darin

• 3 edits in trunk/WebCore

• khtml/rendering/break_lines.cpp: (isBreakable): Fix error that prevented this from compiling. I had failed to build, and then tested the version without my change! I retested with the change.

8:38 AM Changeset in webkit [3488] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• 3158477 -- text break locator leak leads to giant (2.04 GB) VSIZE idling at livepage

• khtml/rendering/break_lines.cpp: (isBreakable): Dispose the text locator.

Jan 28, 2003:

7:19 PM Changeset in webkit [3487] by trey

• 3 edits in trunk/WebKit

Removing ERROR() that isn't an error, left over from the Safari-48 download firedrill.

Reviewed by Chris.

• Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): Don't ERROR if we are asked to cleanup a file and there is nothing to cleanup. This can happen in the rare case of the download being canceled before the first byte arrives, and we deal properly, no ERROR.

7:13 PM Changeset in webkit [3486] by hyatt

• 1 edit in trunk/WebCore/khtml/html/html_documentimpl.cpp

* empty log message *

5:28 PM Changeset in webkit [3485] by hyatt

• 3 edits in trunk/WebCore

Fix quirks/strict regression caused by improper use of findRev (should
be find), and latin1() (can't be invoked on temporaries).

Reviewed by darin

• khtml/html/html_documentimpl.cpp: (parseDocTypePart): (HTMLDocumentImpl::determineParseMode):

4:26 PM Changeset in webkit [3484] by hyatt

• 4 edits in trunk/WebCore

Fix for 3155209, dashed-line schmutz left behind when dragging
links.

Also porting a fix from the old table code to the new table code
that I missed.

Reviewed by darin

• khtml/rendering/render_object.cpp: (RenderObject::setStyle):
• khtml/rendering/render_table.cpp: (RenderTable::layout):

3:08 PM Changeset in webkit [3483] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

• fixed 3157318 -- hang at time zone page after clicking on map at www.time.gov

• kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Allow a comma after the day. Given how this code is structured, it allows commas in unwanted contexts too, but that's almost certainly harmless.

2:34 PM Changeset in webkit [3482] by cblu

• 5 edits in trunk/WebKit

Fixed: 3150856 - crash with full-size plugins in frame or iframe

Reviewed by darin.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): added assert
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): added assert
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _makeDocumentView]): Don't call setDataSource here because the view is not in the view hierarchy at this point.
• WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): Call setDataSource on the document view after it has been placed in the view hierarchy. This what we for the top-level view, so should do this for views in subframes as well.

2:20 PM Changeset in webkit [3481] by hyatt

• 16 edits
  2 adds in trunk/WebCore

New implementation of determineParseMode that is much better
about getting the quirks vs. strict decision right (as compared
to Mozilla and WinIE).

Also made a new inQuirksMode function and converted callers of
parseMode to use it, so that AlmostStrict and Strict modes will
both be treated as non-quirks mode by those who check for this
sort of thing.

Reviewed by darin, mjs

• khtml/html/html_documentimpl.cpp: (parsePS): (containsString): (parseDocTypeDeclaration): (HTMLDocumentImpl::determineParseMode):
• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::setStyleSheet): (HTMLStyleElementImpl::childrenChanged):
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::attach):
• khtml/html/htmlparser.cpp: (KHTMLParser::parseToken):
• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):
• khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
• khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):
• khtml/rendering/render_list.cpp: (getParentOfFirstLineBox):
• khtml/rendering/render_object.cpp: (RenderObject::createObject):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::determineParseMode):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::createDecl):
• kwq/KWQString.mm: (QString::compare):

2:08 PM Changeset in webkit [3480] by cblu

• 13 edits in trunk/WebKit

Fixed: 3156172 - No filename correction when downloading images via drag & drop

Reviewed by mjs, john, trey.

• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:]): call _downloadURL:toDirectory: (-[WebController _downloadURL:toDirectory:]): call -[WebFrame _downloadRequest:toDirectory:]
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): release the download directory (-[WebDataSource _setDownloadDirectory:]): new (-[WebDataSource _downloadDirectory]): new
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _downloadRequest:toDirectory:]): renamed
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): call -[WebController _downloadURL:toDirectory:]
• WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): call -[WebController _downloadURL:toDirectory:]
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the data source has a download directory, use it plus the filename from the response as download path

1:55 PM Changeset in webkit [3479] by darin

• 4 edits in trunk/WebCore

Reviewed by Ken and Maciej.

• fixed remaining bit of 3142646 -- JavaScript Error reported at www.hotmail.com after first time

The problem was that forms that were attached, but had no render object yet, were
not in the form names dictionary. This causes trouble for JavaScript that runs before
style sheets load, since the FOUC code makes us not create render objects at that stage.

• khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::attach): Don't check m_render before adding to dictionary. (HTMLFormElementImpl::parseAttribute): Use attached(), not m_render, to tell whether to track the name of the form in the dictionary.

• khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseAttribute): Use attached(), not m_render, to tell whether to track the name of the image in the dictionary. (HTMLImageElementImpl::attach): Don't check m_render before adding to dictionary.

12:50 PM Changeset in webkit [3478] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• fixed 3144918 -- Can't drill down multiple levels of categories when selling on ebay if first item in list is chosen

The bug was caused by having array values in the property map past the storageLength cutoff
in an array object; those values would not be seen when you do a get.

• kjs/array_object.cpp: (ArrayInstanceImp::put): Implement a new rule for resizing the storage that is independent of the length. The old rule would sometimes make the storage very big if you added two elements in a row that both had large, but consecutive indexes. This eliminates any cases where we make sparse entries in the property map below the sparse array cutoff. (ArrayInstanceImp::resizeStorage): Don't ever make storage size bigger than the cutoff unless the caller specifically requests it. (ArrayInstanceImp::setLength): Change this so it only makes the storage smaller, never larger. We will actually enlarge the storage when putting elements in.

12:32 PM Changeset in webkit [3477] by mjs

• 4 edits in trunk/WebCore

Reviewed by John.

• fixed 3157014 - Crash on disabling JavaScript and reloading livepage.apple.com

• khtml/khtml_part.cpp: (KHTMLPart::openURL): Move check of JavaScript setting and possible disabling from here... (KHTMLPart::begin): ... to here, to make sure it happens after clearing the interpreter.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::resumeActions): Don't bother to restore timers if JavaScript is off.

12:11 PM Changeset in webkit [3476] by trey

• 3 edits in trunk/WebCore

3158465 - REGRESSION: cursor turns into I-beam after clicking on most KWQ widgets

When we return from handing a mousedown to an AK widget, we check to see if currentEvent
is now a MouseUp, in which case we hand it to khtml. This allows khtml to keep in
synch as to the state of the mouse. This covers the case of AK widgets that
run their own event loop and consume events until a mouseup (but not ones that use
Carbon, such as PopUpList, since Carbon does not update currentEvent).

Reviewed by Darin.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Pass mouseup to khtml.

10:39 AM Changeset in webkit [3475] by trey

• 7 edits in trunk

WebCore:

2940179 - Arrow cursor should change to link cursor after click of link in non-frontmost window

3158238 - cursor shape does not track after double-click to activate a window

Reviewed by Darin.

• khtml/khtmlview.cpp: (KHTMLView::viewportMouseDoubleClickEvent): We get this when the mouse goes up the second time, so clear d->mousePressed.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::mouseMoved): Pitch any mousemoved that comes through while we think the mouse is down. Those screw up our tracking, like 3137661. This is part of the 2940179 fix.

WebKit:

2940179 - Arrow cursor should change to link cursor after click of link in non-frontmost window
3158240 - cursor does not track when switching from panels to safari windows

Two changes here: First, we post fake mousemoved events to get the cursor fixed up
without checking if the mouse is down (WC deals with that now). That fixes 2940179,
because the button is down when we get notified of becoming key.

Second, we observe key window instead of main window notifications everywhere, so we
update the cursor when clicking between a panel and our doc windows.

Reviewed by Darin.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView addMouseMovedObserver]): s/main/key/g (-[WebHTMLView addWindowObservers]): s/main/key/g (-[WebHTMLView removeWindowObservers]): s/main/key/g (-[WebHTMLView windowDidBecomeKey:]): s/main/key/g (-[WebHTMLView windowDidResignKey:]): s/main/key/g
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged]): Always post mousemoved event.

9:26 AM Changeset in webkit [3474] by sullivan

• 4 edits in trunk/WebKit

• fixed 3158304 -- Assertion failure cancelling "Add Bookmark" or deleting newly-created bookmarks

Reviewed by Darin

• Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _bookmark:changedUUIDFrom:to:]): new method that notifies group when a bookmark that's already in a group changes its UUID -- the UUID to bookmark dictionary updates for this change.

• Bookmarks.subproj/WebBookmarkGroupPrivate.h: private declaration for this method

• Bookmarks.subproj/WebBookmark.m: (-[WebBookmark _setUUID:]): notify group when UUID changes (-[WebBookmark UUID]): ditto

8:23 AM Changeset in webkit [3473] by darin

• 2 edits in trunk/WebKit

Reviewed by Ken.

• fixed 3156197 -- leak in -[WebBookmarkList initFromDictionaryRepresentation:withGroup:]

• Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]): Fixed storage leak by not allocating the list here, because [self init] will be called and that will allocate the list.