Context Navigation

khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Check getJSEventListener result for nil.
khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Check getJSEventListener result for nil.

3:10 PM Changeset in webkit [3632] by darin

2 edits in trunk/WebKit

Reviewed by Ed.

applied a fixed version of Ed Voas's change to make plug-ins position correctly inside Carbon metal windows; should have no effect on Safari

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Don't assume that the Cocoa concept of the content view matches up with the Carbon concept of where the port is positioned. Instead, convert coordinates to border view coordinates, then back to Carbon content coordinates by using the delta between the port bounds and the port's pixmap bounds. Bug 3160710 was caused by an older version of this patch implicitly assuming the port bounds always had (0,0) for top left.

11:24 AM Changeset in webkit [3631]

17 copies
2 deletes in tags/Safari-58~3

This commit was manufactured by cvs2svn to create tag 'Safari-58~3'.

11:24 AM Changeset in webkit [3630] by mjs

2 edits in branches/Safari-58-1-branch/WebKit

Reviewed by Trey.

WebKit.pbproj/project.pbxproj: Add /System/Library/PrivateFrameworks

11:23 AM Changeset in webkit [3629] by mjs

3 edits in branches/Safari-58-1-branch/WebCore

Reviewed by Trey.

WebCore.pbproj/project.pbxproj: Include /System/Library/PrivateFrameworks.

10:53 AM Changeset in webkit [3628] by trey

8 edits in trunk

JavaScriptCore:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

JavaScriptCore.pbproj/project.pbxproj:

WebFoundation:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

WebFoundation.pbproj/project.pbxproj:

WebCore:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

WebCore.pbproj/project.pbxproj:

WebKit:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

WebKit.pbproj/project.pbxproj:

Feb 10, 2003:

5:59 PM Changeset in webkit [3627] by hyatt

23 edits
2 adds in trunk/WebCore

Inline box model landing, stage 1. Doesn't really change
much of anything visually yet. Just builds a bunch of boxes
and positions them, but those boxes aren't used yet.

Also fixing repaint() to understand not to dirty outside
overflow:hidden clipped ancestors.

Fixed two table bugs in table painting as well.

Reviewed by kocienda

WebCore.pbproj/project.pbxproj:
khtml/rendering/bidi.cpp:
khtml/rendering/bidi.h:
khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:
khtml/rendering/render_box.cpp: (RenderBox::position): (RenderBox::repaintRectangle):
khtml/rendering/render_box.h:
khtml/rendering/render_flow.cpp: (RenderFlow::addChild): (RenderFlow::deleteLineBoxes): (RenderFlow::detach): (RenderFlow::createInlineBox):
khtml/rendering/render_flow.h:
khtml/rendering/render_image.cpp: (RenderImage::paintObject):
khtml/rendering/render_inline.cpp:
khtml/rendering/render_inline.h:
khtml/rendering/render_line.cpp: Added. (InlineBox::detach): (throw): (InlineBox::operator delete): (InlineFlowBox::marginLeft): (InlineFlowBox::marginRight): (InlineFlowBox::marginBorderPaddingLeft): (InlineFlowBox::marginBorderPaddingRight): (InlineFlowBox::getFlowSpacingWidth): (InlineFlowBox::nextOnLineExists): (InlineFlowBox::prevOnLineExists): (InlineFlowBox::onEndChain): (InlineFlowBox::determineSpacingForFlowBoxes): (InlineFlowBox::placeBoxesHorizontally): (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::adjustMaxAscentAndDescent): (InlineFlowBox::computeLogicalBoxHeights): (InlineFlowBox::placeBoxesVertically):
khtml/rendering/render_line.h: Added.
khtml/rendering/render_object.cpp: (RenderObject::createInlineBox):
khtml/rendering/render_object.h:
khtml/rendering/render_replaced.cpp:
khtml/rendering/render_replaced.h:
khtml/rendering/render_table.cpp: (RenderTableSection::paint): (RenderTableCell::repaintRectangle): (RenderTableCell::paint):
khtml/rendering/render_table.h:
khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint): (RenderText::paintObject): (RenderText::height): (RenderText::createInlineBox): (RenderText::position): (RenderText::width): (RenderText::metrics):
khtml/rendering/render_text.h:
khtml/xml/dom_docimpl.h:

5:21 PM Changeset in webkit [3626]

21 copies
1 delete in tags/Safari-58~2

This commit was manufactured by cvs2svn to create tag 'Safari-58~2'.

5:21 PM Changeset in webkit [3625] by mjs

2 edits in branches/Safari-58-1-branch/WebKit

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

WebKit.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

5:17 PM Changeset in webkit [3624] by mjs

6 edits in branches/Safari-58-1-branch

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.

4:09 PM Changeset in webkit [3623] by cblu

3 edits in trunk/WebKit

Added HeaderDoc comments for WebDownload and WebPluginError.

Reviewed by rjw.

Downloads.subproj/WebDownload.h:
Plugins.subproj/WebPluginError.h:

3:03 PM Changeset in webkit [3622] by trey

7 edits
1 add in trunk/WebKit

Following the recent fix for ensuring that we always have a FormDelegate,
when we need a default policy delegate we use a shared one instead of allocing
a new one each time, which then would leak.

This included getting rid of the initWithWebController: method in the
WebDefaultPolicyDelegate API. The arg was not used.

Reviewed by Richard

WebKit.pbproj/project.pbxproj: new private header
WebView.subproj/WebController.m: (-[WebController policyDelegate]): use shared delegate if none set
WebView.subproj/WebDefaultPolicyDelegate.h:
WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate _sharedWebPolicyDelegate]): return shared instance
WebView.subproj/WebDefaultPolicyDelegatePrivate.h: Added.
WebView.subproj/WebFormDelegate.m: (+[WebFormDelegate _sharedWebFormDelegate]): Trivial renaming of static.

2:26 PM Changeset in webkit [3621] by darin

13 edits in trunk/WebCore

Reviewed by Richard.

fixed 3124596 -- failures handling URLs with non-ASCII characters in them

khtml/xml/dom_docimpl.h: Add an m_decoder field.
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_decoder to 0. (DocumentImpl::completeURL): Pass the QTextCodec from m_decoder to KURL if present.

khtml/khtml_part.cpp: (KHTMLPart::begin): Set the decoder on the document when we make the document if we have a decoder. (KHTMLPart::write): Set the decoder on the document when we make the decoder if we have a document. (KHTMLPart::completeURL): Remove APPLE_CHANGES; we handle the encoding in the document.

kwq/KWQKURL.h: Removed "encoding hint" parameters. Add a QTextCodec parameter to the relative URL constructor, which is the one used when we deal with links on a page.
kwq/KWQKURL.mm: (KURL::KURL): Decode the relative string based on the QTextCodec parameter.

kwq/KWQString.h: Added isAllASCII, good for detecting when it's safe to use latin1() or ascii() without worrying about character sets.
kwq/KWQString.mm: (QString::isAllASCII): Added.

WebCore-tests.exp: Updated for changes in KURL API.
WebCore-combined.exp: Regenerated.

other changes

khtml/rendering/render_table.cpp: (RenderTableCell::setWidth): Add an assertion that will help us notice future overflow issues.

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Rolled out the APPLE_CHANGES here that were intended to cope with the lack of window.history, which we now have. While KHTML's rule may not be the correct rule, this will now work as well in Safari as in Konqueror.

1:47 PM Changeset in webkit [3620] by rjw

2 edits in trunk/WebKit

Update API issues document.

Reviewed by me.

API-Issues.rtf:

1:13 PM Changeset in webkit [3619]

21 copies
1 delete in tags/Safari-58~1

This commit was manufactured by cvs2svn to create tag 'Safari-58~1'.

1:13 PM Changeset in webkit [3618] by mjs

11 edits in branches/Safari-58-1-branch

top level:

Reviewed by Maciej.

remove leftover bits of NO_LICENSE

acconfig.h: Remove NO_LICENSE.
configure.in: Remove all the NO_LICENSE-related bits.

Tools:

Ahem.ttf: Added.
Makefile.am: Install Ahem.ttf into the user's home directory if it's not already in there.

JavaScriptCore:

Reviewed by John.

kjs/scope_chain.cpp: Rolled out the fix to bug 3137084. It caused a massive storage leak, and probably didn't even fix the bug.

Tests:

Another example application. Illustrates how to get document source,
and how to convert HTML to an NSAttributedString, among other things.
Need to add comments and cleanly format code.

NOTE: The two example apps won't compile until I checkin some post 0.8.2 WebKit API tweaks
tomorrow.

Reviewed by me.

ChangeLog:
SnippetEditor/ApplicationController.h: Added.
SnippetEditor/ApplicationController.m: Added. (-[ApplicationController mainWebView]): (-[ApplicationController validateUserInterfaceItem:]): (-[ApplicationController new:]):
SnippetEditor/English.lproj/MainMenu.nib: Added.
SnippetEditor/English.lproj/Snippet.nib: Added.
SnippetEditor/SnippetController.h: Added.
SnippetEditor/SnippetController.m: Added. (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController windowNibName]): (-[SnippetController awakeFromNib]): (-[SnippetController loadURL:]): (-[SnippetController load]): (-[SnippetController loadComplete]): (-[SnippetController setTitle:]): (-[SnippetController updateFromText:]): (-[SnippetController updateFromURL:]): (-[SnippetController mainDataSource]): (-[SnippetLocationChangeDelegate initWithController:]): (-[SnippetLocationChangeDelegate locationChangeDone:forDataSource:]): (-[AttributedStringView dealloc]): (-[AttributedStringView setAttributedString:]): (-[AttributedStringView drawRect:]):
SnippetEditor/SnippetEditor.pbproj/project.pbxproj: Added.
SnippetEditor/SnippetEditor_Prefix.h: Added.
SnippetEditor/main.m: Added. (main):

Tweaked to reflect updated API.

SimpleViewer/DocumentController.h:
SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[ResourceLoadDelegate dealloc]): (-[ResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]):

WebFoundation:

Merged changes from trunk.

2003-02-09 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

fixed 3167156 - WebFoundation-58.1: Partial downloads do not work
fixed 3048004 - "simple" loader should send headers passed in as part of request (CFNetwork one already does)

ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (WebSimpleHTTPProtocolHandlerInit): Add the rest of the headers that are specially handled. (-[WebSimpleHTTPProtocolHandler _createHTTPRequest]): Add custom headers that do not conflict with standard ones (and add FIXME to note that they should actually win).

WebCore:

Rolled over changes from the main trunk.

2003-02-03 David Hyatt <hyatt@apple.com>

Fix for 3163603, livepage.apple.com repaints entire page.

Reviewed by darin.

khtml/rendering/render_object.cpp: (RenderObject::setStyle):

WebKit:

Rolled over changes from the trunk.

2003-02-03 Chris Blumenberg <cblu@apple.com>

Fixed: 3163073 - SECURITY: Need to check if filename in encoded download is safe

Reviewed by kocienda, darin, mjs.

Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_filenameByFixingIllegalCharacters on the enco

WebBrowser:

Rolled over changes from the main trunk.

2003-01-31 Chris Blumenberg <cblu@apple.com>

Beta expiration warnings should not say "Beta 1"

Reviewed by john.

English.lproj/Localizable.strings:
main.m: (main): (shouldShowFinalBetaExpirationWarning): fixed variable name

12:40 PM Changeset in webkit [3617] by cblu

2 edits in trunk/WebKit

Fixed: 3168888 - REGRESSION: many downloads fail (due to -36 error from write)

Reviewed by darin.

Downloads.subproj/WebDownload.m: (-[WebDownload writeForkData:isDataFork:]):

10:02 AM Changeset in webkit [3616] by trey

6 edits
1 add in trunk/WebKit

Make sure we have a FormsDelegate installed with NOP behavior if our client
does not set one. Editing forms was broken for Ed by the introduction
of the new FormDelegate.

Reviewed by Darin.

WebKit.pbproj/project.pbxproj: Added new header file.
WebView.subproj/WebControllerPrivate.m: (-[WebController _formDelegate]): Use shared delegate if none set yet.
WebView.subproj/WebFormDelegatePrivate.h: New header.
WebView.subproj/WebFormDelegate.h: Nit cleanup.
WebView.subproj/WebFormDelegate.m: (+[WebFormDelegate _sharedWebFormDelegate]): New method to return a shared NOP implementation.

Feb 9, 2003:

10:01 AM Changeset in webkit [3615]

4 copies
2 deletes in tags/JavaScriptCore-60

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-60'.

10:01 AM Changeset in webkit [3614] by darin

1 edit in branches/JavaScriptCore-60-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Update project for tarball.

9:56 AM Changeset in webkit [3613]

23 copies
3 deletes in tags/WebCore-60

This commit was manufactured by cvs2svn to create tag 'WebCore-60'.

9:56 AM Changeset in webkit [3612] by darin

1 edit in branches/WebCore-60-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

Tweak project for tarball.

Feb 7, 2003:

11:14 PM Changeset in webkit [3611] by darin

5 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3145899 -- tf1.fr page marked UTF-8 is being decoded as Latin-1 (due to <noscript> before <meta>)

khtml/misc/decoder.cpp: (Decoder::decode): Add NOSCRIPT to the list of tags that are allowed before META tags that specify character sets.

fixed 3144214 -- treat Big5 as Windows CP 950 the same way TEC does

kwq/mac-encodings.txt: Move Big5 names to kCFStringEncodingDOSChineseTrad instead of kCFStringEncodingBig5.
kwq/KWQCharsetData.c: Regenerated.

2:08 PM Changeset in webkit [3610] by rjw

26 edits in trunk

WebKit:

Changes to support per WebController preferences.

Reviewed by Maciej and Ken.

WebView.subproj/WebController.m: (-[WebController setPreferences:]):
WebView.subproj/WebControllerPrivate.h:
WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): (-[WebControllerPrivate dealloc]): (-[WebController _setFormDelegate:]): (-[WebController _formDelegate]): (-[WebController _settings]): (-[WebController _updateWebCoreSettingsFromPreferences:]): (-[WebController _releaseUserAgentStrings]): (-[WebController _preferencesChangedNotification:]):
WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:controller:]):
WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: (-[WebPreferences _postPreferencesChangesNotification]): (+[WebPreferences load]): (-[WebPreferences _stringValueForKey:]): (-[WebPreferences _setStringValue:forKey:]): (-[WebPreferences _integerValueForKey:]): (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _boolValueForKey:]): (-[WebPreferences _setBoolValue:forKey:]): (-[WebPreferences standardFontFamily]): (-[WebPreferences setStandardFontFamily:]): (-[WebPreferences fixedFontFamily]): (-[WebPreferences setFixedFontFamily:]): (-[WebPreferences serifFontFamily]): (-[WebPreferences setSerifFontFamily:]): (-[WebPreferences sansSerifFontFamily]): (-[WebPreferences setSansSerifFontFamily:]): (-[WebPreferences cursiveFontFamily]): (-[WebPreferences setCursiveFontFamily:]): (-[WebPreferences fantasyFontFamily]): (-[WebPreferences setFantasyFontFamily:]): (-[WebPreferences defaultFontSize]): (-[WebPreferences setDefaultFontSize:]): (-[WebPreferences defaultFixedFontSize]): (-[WebPreferences setDefaultFixedFontSize:]): (-[WebPreferences minimumFontSize]): (-[WebPreferences setMinimumFontSize:]): (-[WebPreferences defaultTextEncodingName]): (-[WebPreferences setDefaultTextEncodingName:]): (-[WebPreferences userStyleSheetEnabled]): (-[WebPreferences setUserStyleSheetEnabled:]): (-[WebPreferences userStyleSheetLocation]): (-[WebPreferences setUserStyleSheetLocation:]): (-[WebPreferences JavaEnabled]): (-[WebPreferences setJavaEnabled:]): (-[WebPreferences JavaScriptEnabled]): (-[WebPreferences setJavaScriptEnabled:]): (-[WebPreferences JavaScriptCanOpenWindowsAutomatically]): (-[WebPreferences setJavaScriptCanOpenWindowsAutomatically:]): (-[WebPreferences pluginsEnabled]): (-[WebPreferences setPluginsEnabled:]): (-[WebPreferences allowAnimatedImages]): (-[WebPreferences allowAnimatedImageLooping]): (-[WebPreferences setAllowAnimatedImageLooping:]): (-[WebPreferences setWillLoadImagesAutomatically:]): (-[WebPreferences willLoadImagesAutomatically]): (-[WebPreferences _initialTimedLayoutDelay]): (-[WebPreferences _initialTimedLayoutSize]): (-[WebPreferences _pageCacheSize]): (-[WebPreferences _objectCacheSize]): (-[WebPreferences _initialTimedLayoutEnabled]): (-[WebPreferences _resourceTimedLayoutDelay]): (-[WebPreferences _resourceTimedLayoutEnabled]):
WebView.subproj/WebPreferencesPrivate.h:

WebCore:

Changes to support per WebController preferences.
KHTMLPart now always accesses preferences from it's m_setting.
Changes made to WebPreferences pass to WebCoreSetting to KTMLSettings.
Added JavaScriptCanOpenWindowsAutomatically to KHTMLSettings.

Reviewed by Maciej and Ken.

khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::restoreURL): (KHTMLPart::openURL): (KHTMLPart::begin): (KHTMLPart::reparseConfiguration):
khtml/khtmlpart_p.h:
kwq/KWQKConfigBase.h:
kwq/KWQKConfigBase.mm: (KConfig::readUnsignedNumEntry):
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setSettings):
kwq/KWQKHTMLSettings.h:
kwq/KWQKHTMLSettings.mm: (KHTMLSettings::stdFontName): (KHTMLSettings::fixedFontName): (KHTMLSettings::serifFontName): (KHTMLSettings::sansSerifFontName): (KHTMLSettings::cursiveFontName): (KHTMLSettings::fantasyFontName): (KHTMLSettings::minFontSize): (KHTMLSettings::mediumFontSize): (KHTMLSettings::mediumFixedFontSize): (KHTMLSettings::isJavaEnabled): (KHTMLSettings::autoLoadImages): (KHTMLSettings::isPluginsEnabled): (KHTMLSettings::isJavaScriptEnabled): (KHTMLSettings::JavaScriptCanOpenWindowsAutomatically): (KHTMLSettings::userStyleSheet): (KHTMLSettings::setStdFontName): (KHTMLSettings::setFixedFontName): (KHTMLSettings::setSerifFontName): (KHTMLSettings::setSansSerifFontName): (KHTMLSettings::setCursiveFontName): (KHTMLSettings::setFantasyFontName): (KHTMLSettings::setMinFontSize): (KHTMLSettings::setMediumFontSize): (KHTMLSettings::setMediumFixedFontSize): (KHTMLSettings::setAutoLoadImages): (KHTMLSettings::setIsJavaScriptEnabled): (KHTMLSettings::setIsJavaEnabled): (KHTMLSettings::setArePluginsEnabled): (KHTMLSettings::setJavaScriptCanOpenWindowsAutomatically): (KHTMLSettings::setUserStyleSheet):
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge init]): (-[WebCoreBridge initializeSettings:]):
kwq/WebCoreSettings.h:
kwq/WebCoreSettings.mm: (-[WebCoreSettings dealloc]): (-[WebCoreSettings init]): (-[WebCoreSettings setStandardFontFamily:]): (-[WebCoreSettings setFixedFontFamily:]): (-[WebCoreSettings setSerifFontFamily:]): (-[WebCoreSettings setSansSerifFontFamily:]): (-[WebCoreSettings setCursiveFontFamily:]): (-[WebCoreSettings setFantasyFontFamily:]): (-[WebCoreSettings setMinimumFontSize:]): (-[WebCoreSettings setDefaultFontSize:]): (-[WebCoreSettings setDefaultFixedFontSize:]): (-[WebCoreSettings setJavaEnabled:]): (-[WebCoreSettings setPluginsEnabled:]): (-[WebCoreSettings setJavaScriptEnabled:]): (-[WebCoreSettings setJavaScriptCanOpenWindowsAutomatically:]): (-[WebCoreSettings setWillLoadImagesAutomatically:]): (-[WebCoreSettings setUserStyleSheetLocation:]): (-[WebCoreSettings userStyleSheetLocation]): (-[WebCoreSettings settings]):

12:49 PM Changeset in webkit [3609]

23 copies
3 deletes in branches/WebCore-60-tarball-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-60-tarball-branch'.

12:49 PM Changeset in webkit [3608]

23 copies
3 deletes in tags/WEBCORE_60_TARBALL_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create tag
'WEBCORE_60_TARBALL_BRANCH_ANCHOR'.

12:49 PM Changeset in webkit [3607]

31 copies
1 delete in tags/Safari-60

This commit was manufactured by cvs2svn to create tag 'Safari-60'.

12:49 PM Changeset in webkit [3606]

4 copies
2 deletes in branches/JavaScriptCore-60-branch

This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-60-branch'.

12:49 PM Changeset in webkit [3605]

4 copies
2 deletes in tags/JAVASCRIPTCORE_60_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create tag
'JAVASCRIPTCORE_60_BRANCH_ANCHOR'.

12:49 PM Changeset in webkit [3604] by sheridan

8 edits in branches/Safari-0-8-2-branch

Safari-60

10:59 AM Changeset in webkit [3603] by darin

3 edits in branches/Safari-0-8-2-branch/WebCore

Rolled change from trunk to branch.

2003-02-07 Darin Adler <Darin Adler>

Reviewed by Dave.

fixed 3165171 -- REGRESSION: images overlap text

khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Change to distribute space to the fixed columns first so the code to distribute to non-fixed columns does not assume it can distribute more to the fixed columns than it really can.

10:53 AM Changeset in webkit [3602] by kocienda

3 edits in branches/Safari-0-8-2-branch/WebCore

Rolled changes from trunk onto branch to fix this bug:

Radar 3165860 (REGRESSION: most of the page disappears when you mouse over DHTML at rollingstone.com)

Original comment for checkin:

2003-02-06 David Hyatt <hyatt@apple.com>

Fix rollingstone regression.

Reviewed by mjs

khtml/rendering/render_object.cpp: (RenderObject::setLayouted):

10:49 AM Changeset in webkit [3601] by kocienda

4 edits in branches/Safari-0-8-2-branch/WebCore

Moved Darin's copyright changes onto this branch.

khtml/rendering/render_table.cpp:
khtml/rendering/render_table.h:

10:46 AM Changeset in webkit [3600] by kocienda

4 edits in branches/Safari-0-8-2-branch/WebCore

Rolled changes from trunk onto branch to fix this bug:

Radar 3167025 (REGRESSION: http://www.buypcdirect.com doesn't wrap correctly b/c of huge cell width value)

Original comment for checkin:

003-02-07 Darin Adler <Darin Adler>

Reviewed by Ken.

fixed 3167025 -- REGRESSION: http://www.buypcdirect.com doesn't wrap correctly b/c of huge cell width value

khtml/rendering/table_layout.h: Make the fields in the Layout structure used in table width computations use int instead of short.
khtml/rendering/table_layout.cpp: (FixedTableLayout::calcMinMaxWidth): Make sure we don't overflow m_minWidth or m_maxWidth in case the specified fixed width value is huge. (FixedTableLayout::layout): Use ints for the calcWidth array instead of shorts. (AutoTableLayout::calcMinMaxWidth): Clamp both maxWidth and minWidth to 0x7fff to match the other code in this file, rather than using 10000.

10:42 AM Changeset in webkit [3599] by kocienda

5 edits in branches/Safari-0-8-2-branch/WebCore

Rolled changes from trunk onto branch to fix this bug:

Radar 3166693 (REGRESSION: infinite recursion in makeFirstResponder while tabbing as page loaded)

Original comment for checkin:

2003-02-06 Darin Adler <Darin Adler>

Reviewed by Ken.

fixed 3166693 -- REGRESSION: infinite recursion in makeFirstResponder while tabbing as page loaded

Because we now deliver blur events, we are triggering a handler on this page that changes focus.
It triggered an infinite loop because setFocus kept setting the focus back to a text field, which
then changed the focus to its editor. The fix was to make QWidget::setFocus smarter about editors.

kwq/KWQTextField.mm: (-[KWQTextField becomeFirstResponder]): Don't do any changes in responder until after calling KWQKHTMLPart::setDocumentFocus, since that can change focus away. If it does, return NO.

kwq/KWQWidget.h: Add hasFocus, remove virtual from setFocus and clearFocus.
kwq/KWQWidget.mm: (QWidget::hasFocus): Added. Moved code to check if a particular view is first responder here. Here's the bug fix too, check if the first responder is this widget's view's editor, and if so return true. (QWidget::setFocus): Do nothing if this widget already has focus. (QWidget::clearFocus): Do nothing if this widget does not have focus.

10:36 AM Changeset in webkit [3598] by kocienda

7 edits in branches/Safari-0-8-2-branch/WebCore

Rolled changes from trunk onto branch to fix this bug:

Radar 3165295 (Hang while triple clicking on page)

Original comment for checkin:

2003-02-06 Darin Adler <Darin Adler>

Reviewed by Dave.

fixed 3165295 -- Hang while triple clicking on page

Flaws in the continuation logic we added to checkSelectionPoint made it take
exponential time on pages with a lot of continuations.

khtml/rendering/render_object.h: Make checkSelectionPoint non-virtual, and added virtual checkSelectionPointIgnoringContinuations.
khtml/rendering/render_object.cpp: (RenderObject::checkSelectionPoint): Added. Does the inline continuation part of the render object walking process, which we only want to do at the top level, since otherwise we will see the same nodes multiple times. Also optimizes by only looking at the inline continuations of inlines, not any continuations of a block. (RenderObject::checkSelectionPointIgnoringContinuations): This is now the virtual function that is overriden by RenderText. It is identical to the old version of checkSelectionPoint, minus the continuation logic.

khtml/rendering/render_text.h: Changed the name of checkSelectionPoint to checkSelectionPointIgnoringContinuations.
khtml/rendering/render_text.cpp: (RenderText::checkSelectionPointIgnoringContinuations): Changed the name, and nothing else.

fixed my build which was crashing on load

WebCore.pbproj/project.pbxproj: Change seg1addr from 2200000 to 9000000.

10:28 AM Changeset in webkit [3597] by kocienda

4 edits in branches/Safari-0-8-2-branch/WebCore

Rolled changes from trunk onto branch to fix this bug:

Radar 3161953 (crash due to trashed memory on XML page)

Original comment for checkin:

Reviewed by Dave.

fixed 3161953 -- crash in KWQListImpl, DOM::CSSStyleSheetImpl::isLoading on XML page

The problem is that this page has some non-HTML elements, but the code was checking
only the element ID, not whether it is HTML or not. Also fixed the page's layout.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector): Check that the node is an HTML element before checking the ID in two places. Without this, we cast the pointer to the wrong type and trash memory.

khtml/rendering/render_root.cpp: (RenderRoot::layout): Set all the children false here, not just firstChild. (RenderRoot::docHeight): Take all the children's heights into account, not just firstChild. (RenderRoot::docWidth): Take all the children's widths into account, not just firstChild.

10:16 AM Changeset in webkit [3596] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_object.cpp

* empty log message *

10:07 AM Changeset in webkit [3595] by darin

4 edits in trunk/WebCore

khtml/rendering/render_table.h: Added copyright date.
khtml/rendering/render_table.cpp: Added copyright date.

9:53 AM Changeset in webkit [3594] by darin

3 edits in trunk/WebCore

Reviewed by Dave.

fixed 3165171 -- REGRESSION: images overlap text

khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Change to distribute space to the fixed columns first so the code to distribute to non-fixed columns does not assume it can distribute more to the fixed columns than it really can.

8:58 AM Changeset in webkit [3593] by darin

4 edits in trunk/WebCore

Reviewed by Ken.

fixed 3167025 -- REGRESSION: http://www.buypcdirect.com doesn't wrap correctly b/c of huge cell width value

khtml/rendering/table_layout.h: Make the fields in the Layout structure used in table width computations use int instead of short.
khtml/rendering/table_layout.cpp: (FixedTableLayout::calcMinMaxWidth): Make sure we don't overflow m_minWidth or m_maxWidth in case the specified fixed width value is huge. (FixedTableLayout::layout): Use ints for the calcWidth array instead of shorts. (AutoTableLayout::calcMinMaxWidth): Clamp both maxWidth and minWidth to 0x7fff to match the other code in this file, rather than using 10000.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed