⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 13, 2003:

5:15 PM Changeset in webkit [3647] by trey
  • 19 edits in trunk

WebBrowser:

First checkin for working forms autocomplete.

The feature is disabled by default, but can be turned on (persistently) via
the debug menu. Note that your data is not encrypted on disk yet.

Aside from the plain old implementation work, there is some refactoring done
with CompletionController to allow URLCompletionController and FormCompletionController
to share more code.

There is also the addition of the libCdsaCrypt, which is not yet used, but will be
soon for encyption. It's a thin layer over some Security API's to make them usable
for simple applications, from developer.apple.com.

Reviewed by Chris

  • CompletionController.h: Added _ignoreTextDidChange. Added new methods to be implemented by subclasses to facilitate factoring.
  • CompletionController.m: (-[CompletionController _sendMessageIgnoringTextChanges:]): New wrapper to send a message with _ignoreTextDidChange temporarily set. This prevents recursion into our completion code. (-[CompletionController reflectSelectedRow]): Impl factored up from URLCompCtrl, calls new methods to get into from subclasses. (-[CompletionController reflectFinalSelectedRow]): Ditto. (-[CompletionController executeQuery]): Comment fix. (-[CompletionController completeString:]): Use _sendMessageIgnoringTextChanges (-[CompletionController queryString]): New method to be overridden. (-[CompletionController intermediateMatchingStringAtIndex:]): Ditto. (-[CompletionController finalMatchingStringAtIndex:]): Ditto. (-[CompletionController controlTextDidChange:]): Obey _ignoreTextDidChange flag. (-[CompletionController control:textView:doCommandBySelector:]): Use _sendMessageIgnoringTextChanges. (-[CompletionController goToItemAtRow:]): Ditto (-[CompletionController tableViewSelectionDidChange:]): Ditto (-[CompletionController tableView:objectValueForTableColumn:row:]): use new overridable method.
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Add item for disabling feature. (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument toggleFormsAutoComplete:]):
  • Defaults.plist: New key.
  • FormCompletionController.h:
  • FormCompletionController.m: All new code. (completionDBPath): Get db path. (domainFromFrame): Utility routine. (+[FormCompletionController formCompletionEnabled]): Return pref value. (+[FormCompletionController setFormCompletionEnabled:]): Set pref value. (-[FormCompletionController initWithSourceField:frame:]): Setup state for doing completion. (-[FormCompletionController dealloc]): (+[FormCompletionController _loadCompletionDB]): Load db. (+[FormCompletionController _saveCompletionDB:]): Save db. (+[FormCompletionController _saveCompletionDBSoon]): Queue up a db save. (+[FormCompletionController _appWillTerminate:]): Save db. (+[FormCompletionController clearFormAutoCompleteDatabase]): Nuke db. (+[FormCompletionController frame:willSubmitFormWithValues:]): Save new form values in db. (-[FormCompletionController executeQuery]): Match string to db.
  • PreferenceKeys.h: New key.
  • URLCompletionController.m: (-[URLCompletionController executeQuery]): Comment. (-[URLCompletionController intermediateMatchingStringAtIndex:]): Factored code from old impl mostly moved to super class. (-[URLCompletionController finalMatchingStringAtIndex:]): Factored code from old impl mostly moved to super class.
  • WebBrowser.pbproj/project.pbxproj: Add new security sample code.
  • libCdsaCrypt.h: Added.
  • libCdsaCrypt.m: Added.

WebKit:

First checkin for working forms autocomplete.

This level mostly just has glue to go from app to WC through the bridge.
WebHTMLReo exports some new SPI to get the element of a view, and then to get
some HTML-level properties of that element.

Reviewed by Chris

  • Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _saveBookmarkGroupGuts]): Don't dump entire bookmark dict in the log.
  • WebKit.exp: New class used by app, objc_class_name_WebHTMLRepresentation.
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation elementForView:]): New SPI. (-[WebHTMLRepresentation elementDoesAutoComplete:]): New SPI. (-[WebHTMLRepresentation elementIsInLoginForm:]): New SPI.

WebCore:

First checkin for working forms autocomplete.

This level has some new support routines.

Reviewed by Chris

  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::isLoginForm): New, returns if a form is for login.
  • khtml/html/html_formimpl.h:
  • kwq/KWQDOMNode.cpp: (idFromNode): New, helper routine to allow us to use the id() function from ObjC.
  • kwq/KWQDOMNode.h:
  • kwq/KWQTextArea.h: Adopt KWQWidgetHolder protocol.
  • kwq/KWQTextArea.mm: (-[KWQTextArea widget]): Adopt KWQWidgetHolder protocol. (-[KWQTextAreaTextView widget]): Adopt KWQWidgetHolder protocol.
  • kwq/KWQTextField.h: Adopt KWQWidgetHolder protocol.
  • kwq/KWQTextField.mm: (-[KWQTextField widget]): Adopt KWQWidgetHolder protocol. (-[KWQSecureTextField widget]): Adopt KWQWidgetHolder protocol.
  • kwq/KWQView.h: Define KWQWidgetHolder protocol
  • kwq/KWQView.mm: (-[KWQView widget]): Adopt KWQWidgetHolder protocol.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): New method. (inputElementFromDOMElement): Common code for next two methods. (-[WebCoreBridge elementIsInLoginForm:]): New method. (-[WebCoreBridge elementDoesAutoComplete:]): New method.
2:40 PM Changeset in webkit [3646] by darin
  • 8 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3162806 -- REGRESSION: handle == h assertion when clicking headphone link at cnn.com
  • khtml/ecma/kjs_window.cpp: (HistoryFunc::tryCall): Instead of trying to actually do the history navigation here, call the new KHTMLPart::scheduleHistoryNavigation.
  • khtml/khtml_part.cpp: (KHTMLPart::init): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields. (KHTMLPart::openURL): Ditto. (KHTMLPart::createJavaContext): Ditto. (KHTMLPart::clear): Also initialize m_scheduledRedirection to noRedirectionScheduled. (KHTMLPart::checkCompleted): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress. (KHTMLPart::scheduleRedirection): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress, and set m_scheduledRedirection to redirectionScheduled. (KHTMLPart::scheduleHistoryNavigation): Added. Does the same thing as scheduleRedirection, but always uses a delay of 0, sets m_scheduledRedirection to historyNavigationScheduled, and sets m_scheduledHistoryNavigationSteps. (KHTMLPart::slotRedirect): Add an if statement that does the history navigation. The code is moved here from HistoryFunc::tryCall. Also set m_scheduledRedirection to noRedirectionScheduled. (KHTMLPart::urlSelected): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields. (KHTMLPart::requestObject): Ditto. (KHTMLPart::submitForm): Ditto. (KHTMLPart::slotParentCompleted): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress. (KHTMLPart::setZoomFactor): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields.
  • khtml/khtml_part.h: Added scheduleHistoryNavigation.
  • khtml/khtmlpart_p.h: Added RedirectionScheduled enum. Added more #if !APPLE_CHANGES to leave out a bunch more fields we don't use. Added m_scheduledRedirection and m_scheduledHistoryNavigationSteps.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Check and don't do anything if the timer was being used for history redirection.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Check m_scheduledRedirection instead of m_redirectURL to figure out if there is a redirection in progress. Not strictly necessary since we really don't care about the history case here, but consistent with the rest.
12:02 PM Changeset in webkit [3645] by sheridan
  • 3 edits in trunk

updating versions to 61u ... trunk had gotten out of sync because of the branch

10:54 AM Changeset in webkit [3644] by cblu
  • 18 edits in trunk

WebCore:

Fixed WebKit typos found by Peter Wilson.

Reviewed by darin.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bridgeForFrameName): call findOrCreateFrameNamed
  • kwq/WebCoreBridge.h: fixed method name for findOrCreateFrameNamed

WebKit:

Fixed WebKit typos found by Peter Wilson.

Reviewed by darin.

  • Misc.subproj/WebKitErrors.h:
  • Misc.subproj/WebKitErrors.m: (categoryInitialize): Error should be WebErrorDescriptionCannotFindApplicationForURL not WebErrorDescriptionCannotNotFindApplicationForURL
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): call findOrCreateFrameNamed
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): call findOrCreateFrameNamed
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge findOrCreateFrameNamed:]): call findOrCreateFrameNamed
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame findOrCreateFrameNamed:]): fixed name
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): use WebErrorDescriptionCannotFindApplicationForURL
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): use WebErrorDescriptionCannotFindApplicationForURL
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView setAllowsScrolling:]): cast to WebDynamicScrollBarsView (-[WebView allowsScrolling]): cast to WebDynamicScrollBarsView (-[WebView frameScrollView]): return NSScrollView
  • WebView.subproj/WebViewPrivate.m: (-[WebView _setDocumentView:]): cast to WebDynamicScrollBarsView

Feb 12, 2003:

5:29 PM Changeset in webkit [3643] by cblu
  • 6 edits
    1 add in trunk/WebKit
  • Moved the WebKit error registration out of WebView because apps that use WebKit but not WebView might need to use WebKit errors (like my test app for WebDownload).
  • Added file close and file move errors (needed for WebDownload).

Reviewed by kocienda.

  • English.lproj/Localizable.strings: Localize file close and file move errors.
  • Misc.subproj/WebKitErrors.h: Added file close and file move errors.
  • Misc.subproj/WebKitErrors.m: Added. (+[WebError initialize]): register the errors here
  • WebKit.exp: Export the WebDownload class (forgot to do this earlier).
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebView.m: don't register the errors here
3:44 PM Changeset in webkit [3642] by darin
  • 11 edits in trunk

WebCore:

Reviewed by Ken.

  • fixed 3158484 -- after submission failure, submitting a second time doesn't work
  • kwq/KWQKHTMLPart.h: Added didNotOpenURL method. Changed _formSubmittedFlag bool into _submittedFormURL string.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): No need to initialize string. (KWQKHTMLPart::didNotOpenURL): If the form we submitted failed, then forget about it. (KWQKHTMLPart::submitForm): Only do the protection against multiple submissions if the URL is the same. (KWQKHTMLPart::setView): Nuke the submitted URL here where we used to nuke the flag.
  • kwq/WebCoreBridge.h: Added didNotOpenURL: method to be called by WebKit.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge didNotOpenURL:]): Forward the call to the part.

WebKit:

Reviewed by Ken.

  • fixed 3158484 -- after submission failure, submitting a second time doesn't work
  • WebView.subproj/WebDataSourcePrivate.h: Added _receivedError:complete: method.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedError:complete:]): Added, parallel to _receivedData and _finishedLoading. Calls the new bridge method didNotOpenURL: for cases where we fail before committing (which calls openURL). Note that we can't use our own _bridge method because it asserts that we have committed to prevent accidental misuse. Also make the call on the controller that used to be done directly by the client.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:complete:]): Call the new -[WebDataSource _receivedError:complete:] rather than calling the controller directly.
2:18 PM Changeset in webkit [3641] by darin
  • 3 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3162786 -- hang with large amounts of text in textarea
  • kwq/KWQTextArea.mm: (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): Rewrite to not use RangeOfParagraph to avoid n2 algorithm. Also made small changes to similar functions so they look similar, and got rid of an int/unsigned mismatch in a case where the value is guaranteed to be positive.
12:11 PM Changeset in webkit [3640] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Dave.

  • fixed 3145442 -- toString(16) is not working, causing non-ASCII characters in mac.com homepage to be munged
  • kjs/number_object.cpp: (NumberProtoFuncImp::call): Add handling for toString with a radix other than 10 passed as an argument.

Feb 11, 2003:

7:08 PM Changeset in webkit [3639]
  • 8 copies
    6 deletes in tags/WebKit-58~5

This commit was manufactured by cvs2svn to create tag 'WebKit-58~5'.

7:08 PM Changeset in webkit [3638] by rjw
  • 2 edits in branches/Safari-58-1-branch/WebKit

* empty log message *

7:01 PM Changeset in webkit [3637] by rjw
  • 2 edits in branches/Safari-58-1-branch/WebKit

Add import of CGFontCache.h, which is no longer
included by CoreGraphicsPrivate.h.

Reviewed by Vicki.

  • WebCoreSupport.subproj/WebTextRendererFactory.m:
5:13 PM Changeset in webkit [3636]
  • 7 copies
    6 deletes in tags/Safari-58~4

This commit was manufactured by cvs2svn to create tag 'Safari-58~4'.

5:13 PM Changeset in webkit [3635] by mjs
  • 3 edits in branches/Safari-58-1-branch/WebKit

Reviewed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: Change (void ) cast to (void *) for compatibility with the latest Panther.
5:07 PM Changeset in webkit [3634] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
4:55 PM Changeset in webkit [3633] by darin
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3170403 -- nil-dereference in addEventListener
  • khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Check getJSEventListener result for nil.
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Check getJSEventListener result for nil.
3:10 PM Changeset in webkit [3632] by darin
  • 2 edits in trunk/WebKit

Reviewed by Ed.

  • applied a fixed version of Ed Voas's change to make plug-ins position correctly inside Carbon metal windows; should have no effect on Safari
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Don't assume that the Cocoa concept of the content view matches up with the Carbon concept of where the port is positioned. Instead, convert coordinates to border view coordinates, then back to Carbon content coordinates by using the delta between the port bounds and the port's pixmap bounds. Bug 3160710 was caused by an older version of this patch implicitly assuming the port bounds always had (0,0) for top left.
11:24 AM Changeset in webkit [3631]
  • 17 copies
    2 deletes in tags/Safari-58~3

This commit was manufactured by cvs2svn to create tag 'Safari-58~3'.

11:24 AM Changeset in webkit [3630] by mjs
  • 2 edits in branches/Safari-58-1-branch/WebKit

Reviewed by Trey.

  • WebKit.pbproj/project.pbxproj: Add /System/Library/PrivateFrameworks
11:23 AM Changeset in webkit [3629] by mjs
  • 3 edits in branches/Safari-58-1-branch/WebCore

Reviewed by Trey.

  • WebCore.pbproj/project.pbxproj: Include /System/Library/PrivateFrameworks.
10:53 AM Changeset in webkit [3628] by trey
  • 8 edits in trunk

JavaScriptCore:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

WebFoundation:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

  • WebFoundation.pbproj/project.pbxproj:

WebCore:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

  • WebCore.pbproj/project.pbxproj:

WebKit:

Set -seg1addr in our build styles, but not for the B&I build.
This makes our SYMROOTS from B&I usable to determine symbols from crash
logs from the field.
Also nuked DeploymentFat build style.

Reviewed by Ken.

  • WebKit.pbproj/project.pbxproj:

Feb 10, 2003:

5:59 PM Changeset in webkit [3627] by hyatt
  • 23 edits
    2 adds in trunk/WebCore

Inline box model landing, stage 1. Doesn't really change
much of anything visually yet. Just builds a bunch of boxes
and positions them, but those boxes aren't used yet.

Also fixing repaint() to understand not to dirty outside
overflow:hidden clipped ancestors.

Fixed two table bugs in table painting as well.

Reviewed by kocienda

  • WebCore.pbproj/project.pbxproj:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/bidi.h:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::position): (RenderBox::repaintRectangle):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::addChild): (RenderFlow::deleteLineBoxes): (RenderFlow::detach): (RenderFlow::createInlineBox):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_image.cpp: (RenderImage::paintObject):
  • khtml/rendering/render_inline.cpp:
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_line.cpp: Added. (InlineBox::detach): (throw): (InlineBox::operator delete): (InlineFlowBox::marginLeft): (InlineFlowBox::marginRight): (InlineFlowBox::marginBorderPaddingLeft): (InlineFlowBox::marginBorderPaddingRight): (InlineFlowBox::getFlowSpacingWidth): (InlineFlowBox::nextOnLineExists): (InlineFlowBox::prevOnLineExists): (InlineFlowBox::onEndChain): (InlineFlowBox::determineSpacingForFlowBoxes): (InlineFlowBox::placeBoxesHorizontally): (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::adjustMaxAscentAndDescent): (InlineFlowBox::computeLogicalBoxHeights): (InlineFlowBox::placeBoxesVertically):
  • khtml/rendering/render_line.h: Added.
  • khtml/rendering/render_object.cpp: (RenderObject::createInlineBox):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp:
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_table.cpp: (RenderTableSection::paint): (RenderTableCell::repaintRectangle): (RenderTableCell::paint):
  • khtml/rendering/render_table.h:
  • khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint): (RenderText::paintObject): (RenderText::height): (RenderText::createInlineBox): (RenderText::position): (RenderText::width): (RenderText::metrics):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_docimpl.h:
5:21 PM Changeset in webkit [3626]
  • 21 copies
    1 delete in tags/Safari-58~2

This commit was manufactured by cvs2svn to create tag 'Safari-58~2'.

5:21 PM Changeset in webkit [3625] by mjs
  • 2 edits in branches/Safari-58-1-branch/WebKit

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • WebKit.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.
5:17 PM Changeset in webkit [3624] by mjs
  • 6 edits in branches/Safari-58-1-branch

Merged changes from the trunk:

2003-02-04 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • WebFoundation.pbproj/project.pbxproj: Updated to build the framework standalone instead of embedded when doing a B&I build for Panther.
4:09 PM Changeset in webkit [3623] by cblu
  • 3 edits in trunk/WebKit

Added HeaderDoc comments for WebDownload and WebPluginError.

Reviewed by rjw.

  • Downloads.subproj/WebDownload.h:
  • Plugins.subproj/WebPluginError.h:
3:03 PM Changeset in webkit [3622] by trey
  • 7 edits
    1 add in trunk/WebKit

Following the recent fix for ensuring that we always have a FormDelegate,
when we need a default policy delegate we use a shared one instead of allocing
a new one each time, which then would leak.

This included getting rid of the initWithWebController: method in the
WebDefaultPolicyDelegate API. The arg was not used.

Reviewed by Richard

  • WebKit.pbproj/project.pbxproj: new private header
  • WebView.subproj/WebController.m: (-[WebController policyDelegate]): use shared delegate if none set
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate _sharedWebPolicyDelegate]): return shared instance
  • WebView.subproj/WebDefaultPolicyDelegatePrivate.h: Added.
  • WebView.subproj/WebFormDelegate.m: (+[WebFormDelegate _sharedWebFormDelegate]): Trivial renaming of static.
2:26 PM Changeset in webkit [3621] by darin
  • 13 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3124596 -- failures handling URLs with non-ASCII characters in them
  • khtml/xml/dom_docimpl.h: Add an m_decoder field.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_decoder to 0. (DocumentImpl::completeURL): Pass the QTextCodec from m_decoder to KURL if present.
  • khtml/khtml_part.cpp: (KHTMLPart::begin): Set the decoder on the document when we make the document if we have a decoder. (KHTMLPart::write): Set the decoder on the document when we make the decoder if we have a document. (KHTMLPart::completeURL): Remove APPLE_CHANGES; we handle the encoding in the document.
  • kwq/KWQKURL.h: Removed "encoding hint" parameters. Add a QTextCodec parameter to the relative URL constructor, which is the one used when we deal with links on a page.
  • kwq/KWQKURL.mm: (KURL::KURL): Decode the relative string based on the QTextCodec parameter.
  • kwq/KWQString.h: Added isAllASCII, good for detecting when it's safe to use latin1() or ascii() without worrying about character sets.
  • kwq/KWQString.mm: (QString::isAllASCII): Added.
  • WebCore-tests.exp: Updated for changes in KURL API.
  • WebCore-combined.exp: Regenerated.
  • other changes
  • khtml/rendering/render_table.cpp: (RenderTableCell::setWidth): Add an assertion that will help us notice future overflow issues.
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Rolled out the APPLE_CHANGES here that were intended to cope with the lack of window.history, which we now have. While KHTML's rule may not be the correct rule, this will now work as well in Safari as in Konqueror.
1:47 PM Changeset in webkit [3620] by rjw
  • 2 edits in trunk/WebKit

Update API issues document.

Reviewed by me.

  • API-Issues.rtf:
1:13 PM Changeset in webkit [3619]
  • 21 copies
    1 delete in tags/Safari-58~1

This commit was manufactured by cvs2svn to create tag 'Safari-58~1'.

1:13 PM Changeset in webkit [3618] by mjs
  • 11 edits in branches/Safari-58-1-branch

top level:

Reviewed by Maciej.

  • remove leftover bits of NO_LICENSE
  • acconfig.h: Remove NO_LICENSE.
  • configure.in: Remove all the NO_LICENSE-related bits.

Tools:

  • Ahem.ttf: Added.
  • Makefile.am: Install Ahem.ttf into the user's home directory if it's not already in there.

JavaScriptCore:

Reviewed by John.

  • kjs/scope_chain.cpp: Rolled out the fix to bug 3137084. It caused a massive storage leak, and probably didn't even fix the bug.

Tests:

Another example application. Illustrates how to get document source,
and how to convert HTML to an NSAttributedString, among other things.
Need to add comments and cleanly format code.

NOTE: The two example apps won't compile until I checkin some post 0.8.2 WebKit API tweaks
tomorrow.

Reviewed by me.

  • ChangeLog:
  • SnippetEditor/ApplicationController.h: Added.
  • SnippetEditor/ApplicationController.m: Added. (-[ApplicationController mainWebView]): (-[ApplicationController validateUserInterfaceItem:]): (-[ApplicationController new:]):
  • SnippetEditor/English.lproj/MainMenu.nib: Added.
  • SnippetEditor/English.lproj/Snippet.nib: Added.
  • SnippetEditor/SnippetController.h: Added.
  • SnippetEditor/SnippetController.m: Added. (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController windowNibName]): (-[SnippetController awakeFromNib]): (-[SnippetController loadURL:]): (-[SnippetController load]): (-[SnippetController loadComplete]): (-[SnippetController setTitle:]): (-[SnippetController updateFromText:]): (-[SnippetController updateFromURL:]): (-[SnippetController mainDataSource]): (-[SnippetLocationChangeDelegate initWithController:]): (-[SnippetLocationChangeDelegate locationChangeDone:forDataSource:]): (-[AttributedStringView dealloc]): (-[AttributedStringView setAttributedString:]): (-[AttributedStringView drawRect:]):
  • SnippetEditor/SnippetEditor.pbproj/project.pbxproj: Added.
  • SnippetEditor/SnippetEditor_Prefix.h: Added.
  • SnippetEditor/main.m: Added. (main):

Tweaked to reflect updated API.

  • SimpleViewer/DocumentController.h:
  • SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[ResourceLoadDelegate dealloc]): (-[ResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[ResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]):

WebFoundation:

Merged changes from trunk.

2003-02-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • fixed 3167156 - WebFoundation-58.1: Partial downloads do not work
  • fixed 3048004 - "simple" loader should send headers passed in as part of request (CFNetwork one already does)
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (WebSimpleHTTPProtocolHandlerInit): Add the rest of the headers that are specially handled. (-[WebSimpleHTTPProtocolHandler _createHTTPRequest]): Add custom headers that do not conflict with standard ones (and add FIXME to note that they should actually win).

WebCore:

Rolled over changes from the main trunk.

2003-02-03 David Hyatt <​hyatt@apple.com>

Fix for 3163603, livepage.apple.com repaints entire page.

Reviewed by darin.

  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):

WebKit:

Rolled over changes from the trunk.

2003-02-03 Chris Blumenberg <​cblu@apple.com>

Fixed: 3163073 - SECURITY: Need to check if filename in encoded download is safe

Reviewed by kocienda, darin, mjs.

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_filenameByFixingIllegalCharacters on the enco

WebBrowser:

Rolled over changes from the main trunk.

2003-01-31 Chris Blumenberg <​cblu@apple.com>

Beta expiration warnings should not say "Beta 1"

Reviewed by john.

  • English.lproj/Localizable.strings:
  • main.m: (main): (shouldShowFinalBetaExpirationWarning): fixed variable name
12:40 PM Changeset in webkit [3617] by cblu
  • 2 edits in trunk/WebKit

Fixed: 3168888 - REGRESSION: many downloads fail (due to -36 error from write)

Reviewed by darin.

  • Downloads.subproj/WebDownload.m: (-[WebDownload writeForkData:isDataFork:]):
10:02 AM Changeset in webkit [3616] by trey
  • 6 edits
    1 add in trunk/WebKit

Make sure we have a FormsDelegate installed with NOP behavior if our client
does not set one. Editing forms was broken for Ed by the introduction
of the new FormDelegate.

Reviewed by Darin.

  • WebKit.pbproj/project.pbxproj: Added new header file.
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _formDelegate]): Use shared delegate if none set yet.
  • WebView.subproj/WebFormDelegatePrivate.h: New header.
  • WebView.subproj/WebFormDelegate.h: Nit cleanup.
  • WebView.subproj/WebFormDelegate.m: (+[WebFormDelegate _sharedWebFormDelegate]): New method to return a shared NOP implementation.

Feb 9, 2003:

10:01 AM Changeset in webkit [3615]
  • 4 copies
    2 deletes in tags/JavaScriptCore-60

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-60'.

10:01 AM Changeset in webkit [3614] by darin
  • 1 edit in branches/JavaScriptCore-60-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Update project for tarball.

9:56 AM Changeset in webkit [3613]
  • 23 copies
    3 deletes in tags/WebCore-60

This commit was manufactured by cvs2svn to create tag 'WebCore-60'.

9:56 AM Changeset in webkit [3612] by darin
  • 1 edit in branches/WebCore-60-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

Tweak project for tarball.

Note: See TracTimeline for information about the timeline view.