Context Navigation

khtml/css/cssstyleselector.cpp:
khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
khtml/rendering/bidi.cpp:
khtml/rendering/font.cpp:
khtml/rendering/font.h:
khtml/rendering/render_block.cpp:
khtml/rendering/render_block.h:
khtml/rendering/render_box.cpp: (RenderBox::paintBackground): (RenderBox::paintBackgroundExtended): (RenderBox::getClipRect): (RenderBox::position):
khtml/rendering/render_box.h:
khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox): (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations): (RenderFlow::repaint):
khtml/rendering/render_flow.h:
khtml/rendering/render_inline.cpp: (RenderInline::paintObject): (RenderInline::width): (RenderInline::height): (RenderInline::offsetLeft): (RenderInline::offsetTop): (RenderInline::nodeAtPoint):
khtml/rendering/render_inline.h:
khtml/rendering/render_line.cpp: (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::computeLogicalBoxHeights): (InlineFlowBox::placeBoxesVertically): (InlineFlowBox::shrinkBoxesWithNoTextChildren): (InlineFlowBox::paintBackgroundAndBorder): (shouldDrawDecoration): (InlineFlowBox::paintDecorations):
khtml/rendering/render_line.h:
khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::lineHeight): (RenderObject::getTextDecorationColors):
khtml/rendering/render_object.h:
khtml/rendering/render_root.cpp: (enclosingPositionedRect):
khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==): (RenderStyle::diff):
khtml/rendering/render_style.h:
khtml/rendering/render_table.cpp: (RenderTableCell::repaintRectangle):
khtml/rendering/render_text.cpp: (TextRun::paintDecoration): (TextRun::checkSelectionPoint): (RenderText::nodeAtPoint): (RenderText::cursorPos): (RenderText::absolutePosition): (RenderText::paintObject): (RenderText::paint): (RenderText::position):
khtml/rendering/render_text.h:
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::drawLineForText):
kwq/WebCoreTextRenderer.h:

Feb 13, 2003:

5:15 PM Changeset in webkit [3647] by trey

19 edits in trunk

WebBrowser:

First checkin for working forms autocomplete.

The feature is disabled by default, but can be turned on (persistently) via
the debug menu. Note that your data is not encrypted on disk yet.

Aside from the plain old implementation work, there is some refactoring done
with CompletionController to allow URLCompletionController and FormCompletionController
to share more code.

There is also the addition of the libCdsaCrypt, which is not yet used, but will be
soon for encyption. It's a thin layer over some Security API's to make them usable
for simple applications, from developer.apple.com.

Reviewed by Chris

CompletionController.h: Added _ignoreTextDidChange. Added new methods to be implemented by subclasses to facilitate factoring.
CompletionController.m: (-[CompletionController _sendMessageIgnoringTextChanges:]): New wrapper to send a message with _ignoreTextDidChange temporarily set. This prevents recursion into our completion code. (-[CompletionController reflectSelectedRow]): Impl factored up from URLCompCtrl, calls new methods to get into from subclasses. (-[CompletionController reflectFinalSelectedRow]): Ditto. (-[CompletionController executeQuery]): Comment fix. (-[CompletionController completeString:]): Use _sendMessageIgnoringTextChanges (-[CompletionController queryString]): New method to be overridden. (-[CompletionController intermediateMatchingStringAtIndex:]): Ditto. (-[CompletionController finalMatchingStringAtIndex:]): Ditto. (-[CompletionController controlTextDidChange:]): Obey _ignoreTextDidChange flag. (-[CompletionController control:textView:doCommandBySelector:]): Use _sendMessageIgnoringTextChanges. (-[CompletionController goToItemAtRow:]): Ditto (-[CompletionController tableViewSelectionDidChange:]): Ditto (-[CompletionController tableView:objectValueForTableColumn:row:]): use new overridable method.
Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Add item for disabling feature. (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument toggleFormsAutoComplete:]):
Defaults.plist: New key.
FormCompletionController.h:
FormCompletionController.m: All new code. (completionDBPath): Get db path. (domainFromFrame): Utility routine. (+[FormCompletionController formCompletionEnabled]): Return pref value. (+[FormCompletionController setFormCompletionEnabled:]): Set pref value. (-[FormCompletionController initWithSourceField:frame:]): Setup state for doing completion. (-[FormCompletionController dealloc]): (+[FormCompletionController _loadCompletionDB]): Load db. (+[FormCompletionController _saveCompletionDB:]): Save db. (+[FormCompletionController _saveCompletionDBSoon]): Queue up a db save. (+[FormCompletionController _appWillTerminate:]): Save db. (+[FormCompletionController clearFormAutoCompleteDatabase]): Nuke db. (+[FormCompletionController frame:willSubmitFormWithValues:]): Save new form values in db. (-[FormCompletionController executeQuery]): Match string to db.
PreferenceKeys.h: New key.
URLCompletionController.m: (-[URLCompletionController executeQuery]): Comment. (-[URLCompletionController intermediateMatchingStringAtIndex:]): Factored code from old impl mostly moved to super class. (-[URLCompletionController finalMatchingStringAtIndex:]): Factored code from old impl mostly moved to super class.
WebBrowser.pbproj/project.pbxproj: Add new security sample code.
libCdsaCrypt.h: Added.
libCdsaCrypt.m: Added.

WebKit:

First checkin for working forms autocomplete.

This level mostly just has glue to go from app to WC through the bridge.
WebHTMLReo exports some new SPI to get the element of a view, and then to get
some HTML-level properties of that element.

Reviewed by Chris

Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _saveBookmarkGroupGuts]): Don't dump entire bookmark dict in the log.
WebKit.exp: New class used by app, objc_class_name_WebHTMLRepresentation.
WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation elementForView:]): New SPI. (-[WebHTMLRepresentation elementDoesAutoComplete:]): New SPI. (-[WebHTMLRepresentation elementIsInLoginForm:]): New SPI.

WebCore:

First checkin for working forms autocomplete.

This level has some new support routines.

Reviewed by Chris

khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::isLoginForm): New, returns if a form is for login.
khtml/html/html_formimpl.h:
kwq/KWQDOMNode.cpp: (idFromNode): New, helper routine to allow us to use the id() function from ObjC.
kwq/KWQDOMNode.h:
kwq/KWQTextArea.h: Adopt KWQWidgetHolder protocol.
kwq/KWQTextArea.mm: (-[KWQTextArea widget]): Adopt KWQWidgetHolder protocol. (-[KWQTextAreaTextView widget]): Adopt KWQWidgetHolder protocol.
kwq/KWQTextField.h: Adopt KWQWidgetHolder protocol.
kwq/KWQTextField.mm: (-[KWQTextField widget]): Adopt KWQWidgetHolder protocol. (-[KWQSecureTextField widget]): Adopt KWQWidgetHolder protocol.
kwq/KWQView.h: Define KWQWidgetHolder protocol
kwq/KWQView.mm: (-[KWQView widget]): Adopt KWQWidgetHolder protocol.
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): New method. (inputElementFromDOMElement): Common code for next two methods. (-[WebCoreBridge elementIsInLoginForm:]): New method. (-[WebCoreBridge elementDoesAutoComplete:]): New method.

2:40 PM Changeset in webkit [3646] by darin

8 edits in trunk/WebCore

Reviewed by Trey.

fixed 3162806 -- REGRESSION: handle == h assertion when clicking headphone link at cnn.com

khtml/ecma/kjs_window.cpp: (HistoryFunc::tryCall): Instead of trying to actually do the history navigation here, call the new KHTMLPart::scheduleHistoryNavigation.

khtml/khtml_part.cpp: (KHTMLPart::init): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields. (KHTMLPart::openURL): Ditto. (KHTMLPart::createJavaContext): Ditto. (KHTMLPart::clear): Also initialize m_scheduledRedirection to noRedirectionScheduled. (KHTMLPart::checkCompleted): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress. (KHTMLPart::scheduleRedirection): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress, and set m_scheduledRedirection to redirectionScheduled. (KHTMLPart::scheduleHistoryNavigation): Added. Does the same thing as scheduleRedirection, but always uses a delay of 0, sets m_scheduledRedirection to historyNavigationScheduled, and sets m_scheduledHistoryNavigationSteps. (KHTMLPart::slotRedirect): Add an if statement that does the history navigation. The code is moved here from HistoryFunc::tryCall. Also set m_scheduledRedirection to noRedirectionScheduled. (KHTMLPart::urlSelected): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields. (KHTMLPart::requestObject): Ditto. (KHTMLPart::submitForm): Ditto. (KHTMLPart::slotParentCompleted): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress. (KHTMLPart::setZoomFactor): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields.

khtml/khtml_part.h: Added scheduleHistoryNavigation.
khtml/khtmlpart_p.h: Added RedirectionScheduled enum. Added more #if !APPLE_CHANGES to leave out a bunch more fields we don't use. Added m_scheduledRedirection and m_scheduledHistoryNavigationSteps.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Check and don't do anything if the timer was being used for history redirection.

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Check m_scheduledRedirection instead of m_redirectURL to figure out if there is a redirection in progress. Not strictly necessary since we really don't care about the history case here, but consistent with the rest.

12:02 PM Changeset in webkit [3645] by sheridan

3 edits in trunk

updating versions to 61u ... trunk had gotten out of sync because of the branch

10:54 AM Changeset in webkit [3644] by cblu

18 edits in trunk

WebCore:

Fixed WebKit typos found by Peter Wilson.

Reviewed by darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bridgeForFrameName): call findOrCreateFrameNamed
kwq/WebCoreBridge.h: fixed method name for findOrCreateFrameNamed

WebKit:

Fixed WebKit typos found by Peter Wilson.

Reviewed by darin.

Misc.subproj/WebKitErrors.h:
Misc.subproj/WebKitErrors.m: (categoryInitialize): Error should be WebErrorDescriptionCannotFindApplicationForURL not WebErrorDescriptionCannotNotFindApplicationForURL
Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): call findOrCreateFrameNamed
Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): call findOrCreateFrameNamed
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge findOrCreateFrameNamed:]): call findOrCreateFrameNamed
WebView.subproj/WebFrame.h:
WebView.subproj/WebFrame.m: (-[WebFrame findOrCreateFrameNamed:]): fixed name
WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): use WebErrorDescriptionCannotFindApplicationForURL
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): use WebErrorDescriptionCannotFindApplicationForURL
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebView setAllowsScrolling:]): cast to WebDynamicScrollBarsView (-[WebView allowsScrolling]): cast to WebDynamicScrollBarsView (-[WebView frameScrollView]): return NSScrollView
WebView.subproj/WebViewPrivate.m: (-[WebView _setDocumentView:]): cast to WebDynamicScrollBarsView

Feb 12, 2003:

5:29 PM Changeset in webkit [3643] by cblu

6 edits
1 add in trunk/WebKit

Moved the WebKit error registration out of WebView because apps that use WebKit but not WebView might need to use WebKit errors (like my test app for WebDownload).
Added file close and file move errors (needed for WebDownload).

Reviewed by kocienda.

English.lproj/Localizable.strings: Localize file close and file move errors.
Misc.subproj/WebKitErrors.h: Added file close and file move errors.
Misc.subproj/WebKitErrors.m: Added. (+[WebError initialize]): register the errors here
WebKit.exp: Export the WebDownload class (forgot to do this earlier).
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebView.m: don't register the errors here

3:44 PM Changeset in webkit [3642] by darin

11 edits in trunk

WebCore:

Reviewed by Ken.

fixed 3158484 -- after submission failure, submitting a second time doesn't work

kwq/KWQKHTMLPart.h: Added didNotOpenURL method. Changed _formSubmittedFlag bool into _submittedFormURL string.
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): No need to initialize string. (KWQKHTMLPart::didNotOpenURL): If the form we submitted failed, then forget about it. (KWQKHTMLPart::submitForm): Only do the protection against multiple submissions if the URL is the same. (KWQKHTMLPart::setView): Nuke the submitted URL here where we used to nuke the flag.

kwq/WebCoreBridge.h: Added didNotOpenURL: method to be called by WebKit.
kwq/WebCoreBridge.mm: (-[WebCoreBridge didNotOpenURL:]): Forward the call to the part.

WebKit:

Reviewed by Ken.

fixed 3158484 -- after submission failure, submitting a second time doesn't work

WebView.subproj/WebDataSourcePrivate.h: Added _receivedError:complete: method.
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedError:complete:]): Added, parallel to _receivedData and _finishedLoading. Calls the new bridge method didNotOpenURL: for cases where we fail before committing (which calls openURL). Note that we can't use our own _bridge method because it asserts that we have committed to prevent accidental misuse. Also make the call on the controller that used to be done directly by the client.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:complete:]): Call the new -[WebDataSource _receivedError:complete:] rather than calling the controller directly.

2:18 PM Changeset in webkit [3641] by darin

3 edits in trunk/WebCore

Reviewed by Trey.

fixed 3162786 -- hang with large amounts of text in textarea

kwq/KWQTextArea.mm: (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): Rewrite to not use RangeOfParagraph to avoid n^{2 algorithm. Also made small
changes to similar functions so they look similar, and got rid of an int/unsigned
mismatch in a case where the value is guaranteed to be positive.}

12:11 PM Changeset in webkit [3640] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Dave.

fixed 3145442 -- toString(16) is not working, causing non-ASCII characters in mac.com homepage to be munged

kjs/number_object.cpp: (NumberProtoFuncImp::call): Add handling for toString with a radix other than 10 passed as an argument.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed