⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 17, 2003:

4:13 PM Changeset in webkit [3659] by darin
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3174332 -- REGRESSION: bad initial layout due to empty QFontMetrics
  • khtml/rendering/render_html.cpp: (RenderHtml::setStyle): Don't set the style's to display:BLOCK if it's display:NONE. This prevents us from modifying the special FOUC style among other things.
  • unrelated code cleanup
  • khtml/html/html_baseimpl.cpp: Moved code around that was grouped badly.
2:19 PM Changeset in webkit [3658] by hyatt
  • 3 edits in trunk/WebCore

Missed another "Almost Strict" spot.

Reviewed by kocienda

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle):
12:25 PM Changeset in webkit [3657] by hyatt
  • 7 edits in trunk/WebCore

Fix for 3% improvement on cached cvs-base. Make cells share the
declarations set up by the table (add these decls to the table
once instead of to every cell).

Reviewed by darin

  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): (HTMLTableElementImpl::~HTMLTableElementImpl): (HTMLTableElementImpl::createSharedCellDecls): (HTMLTableCellElementImpl::getAdditionalStyleDecls): (HTMLTableCellElementImpl::attach):
  • khtml/html/html_tableimpl.h:
  • khtml/xml/dom_elementimpl.h:
11:22 AM Changeset in webkit [3656] by trey
  • 1 edit in trunk/WebCore/khtml/khtmlview.cpp

Cleanup comment turd left in by mistake

11:00 AM Changeset in webkit [3655] by kocienda
  • 22 edits in trunk/WebKit

Reviewed by Trey

Rolled in documentation changes from Peter Kelly, our tech writer.

  • History.subproj/WebBackForwardList.h
  • History.subproj/WebHistory.h
  • Misc.subproj/WebKitErrors.h
  • Misc.subproj/WebResourceResponseExtras.h
  • Panels.subproj/WebStandardPanels.h
  • Plugins.subproj/WebPluginError.h
  • WebView.subproj/WebContextMenuDelegate.h
  • WebView.subproj/WebController.h
  • WebView.subproj/WebControllerPolicyDelegate.h
  • WebView.subproj/WebDataSource.h
  • WebView.subproj/WebDefaultPolicyDelegate.h
  • WebView.subproj/WebDocument.h
  • WebView.subproj/WebFrame.h
  • WebView.subproj/WebPreferences.h
  • WebView.subproj/WebResourceLoadDelegate.h
  • WebView.subproj/WebView.h
  • WebView.subproj/WebWindowOperationsDelegate.h
10:54 AM Changeset in webkit [3654] by trey
  • 2 edits in trunk/WebKit

2943514 hide the cursor when using the arrow keys to scroll

Reviewed by Darin

  • WebView.subproj/WebView.m: (-[WebView keyDown:]): Hide that cursor.
10:53 AM Changeset in webkit [3653] by trey
  • 4 edits in trunk/WebCore

2938062 Mouse cursor does not change to link cursor over non-button form submission controls

Reviewed by Darin

  • khtml/khtmlview.cpp: (isSubmitImage): Helper function to ID submit buttons with images. (KHTMLView::viewportMouseMoveEvent): Set cursor for submit buttons with images.
  • kwq/WebCoreBridge.mm: (inputElementFromDOMElement): Simplify previously written casting goop.
9:21 AM Changeset in webkit [3652] by cblu
  • 4 edits in trunk/WebKit

WebKit:

Added debug method that can be used inside of gdb to examine an image. Needed this many times.

Reviewed by darin.

  • Misc.subproj/WebNSImageExtras.h:
  • Misc.subproj/WebNSImageExtras.m: (-[NSImage _web_saveAndOpen]):

WebBrowser:

Implemented the tab bar with tabs and all.

Reviewed by darin.

  • BarBackground.m: moved private appkit declarations to BrowserNSViewExtras and BrowserNSWindowExtras so they can be used by other classes
  • BrowserNSStringExtras.m: (-[NSString drawDoubledInRect:withTopColor:bottomColor:font:centered:flipped:]): obey the x origin when centering text
  • BrowserNSViewExtras.h:
  • BrowserNSViewExtras.m: (-[NSView shouldDrawBackgroundTheSneakyPrivateNSWindowWay]): moved method from BarBackground so it can be used by other classes
  • BrowserNSWindowExtras.h: put private appkit declarations here
  • English.lproj/Browser.nib:
  • EtchedStringButtonCell.h: Added.
  • EtchedStringButtonCell.m: Added. Factored out from FavoriteButtonCell so TabButtonCell can use the same functionality (+[EtchedStringButtonCell font]): (+[EtchedStringButtonCell bottomColorForDarkText]): (+[EtchedStringButtonCell topColorForDarkText]): (+[EtchedStringButtonCell bottomColorForLightText]): (+[EtchedStringButtonCell topColorForLightText]): (-[EtchedStringButtonCell textRectForFrame:]): (-[EtchedStringButtonCell drawInteriorWithFrame:inView:]): (-[EtchedStringButtonCell setTextCenterTruncated:]): (-[EtchedStringButtonCell isTextCenterTruncated]): (-[EtchedStringButtonCell setTextCentered:]): (-[EtchedStringButtonCell isTextCentered]): (-[EtchedStringButtonCell setDrawsLightText:]): (-[EtchedStringButtonCell drawsLightText]):
  • FavoriteButton.m: (-[FavoriteButton setBookmark:]):
  • FavoriteButtonCell.h:
  • FavoriteButtonCell.m: made subclass of EtchedStringButtonCell (+[FavoriteButtonCell updateCellForButton:]): (-[FavoriteButtonCell textRectForFrame:]): (-[FavoriteButtonCell imageRectForFrame:]): (-[FavoriteButtonCell drawInteriorWithFrame:inView:]):
  • Resources/Images/TabBevel_Caps.tif: Added.
  • Resources/Images/TabBevel_Middle.tif: Added.
  • Resources/Images/TabClose_Back.tif: Added.
  • Resources/Images/TabClose_Back_Pressed.tif: Added.
  • Resources/Images/TabClose_Back_Rollover.tif: Added.
  • Resources/Images/TabClose_Front.tif: Added.
  • Resources/Images/TabClose_Front_Pressed.tif: Added.
  • Resources/Images/TabClose_Front_Rollover.tif: Added.
  • Resources/Images/TabMask_Caps.tif: Added.
  • Resources/Images/TabMask_Middle.tif: Added.
  • TabBarView.h:
  • TabBarView.m: (-[TabBarView scaledAndTexturedWindowBackgroundImage]): image of textured background used by tab buttons (-[TabBarView windowBackgroundImage]): ditto (-[TabBarView _addTabButtonWithTabViewItem:]): links tab button to tab item (-[TabBarView _removeTabButton:]): removes tab button (-[TabBarView _layOutButtons]): lays out tab buttons (-[TabBarView _bringSelectedTabToFront:]): brings tab button of tab item to front (-[TabBarView awakeFromNib]): set things up (-[TabBarView dealloc]): release things (-[TabBarView _drawSeparatorAtXOrigin:]): draws separator (-[TabBarView drawRect:]): draw separators (-[TabBarView setFrameSize:]): call _layOutButtons (-[TabBarView bringTabToFront:]): brings tab item of tab button to front (-[TabBarView closeTab:]): closes the clicked tab (-[TabBarView tabView:shouldSelectTabViewItem:]): forward to delegate, return YES otherwise (-[TabBarView tabView:willSelectTabViewItem:]): deselect current tab, forward to delegate (-[TabBarView tabView:didSelectTabViewItem:]): select current tab, forward to delegate (-[TabBarView tabViewDidChangeNumberOfTabViewItems:]): call _layOutButtons, forward to delegate
  • TabButton.h: Added.
  • TabButton.m: Added. (+[TabButton initialize]): set the cell (+[TabButton _loadImages]): load images (-[TabButton _setCloseButtonImages:]): set close images (-[TabButton initWithFrame:tabViewItem:]): set attributes (-[TabButton dealloc]): release things (-[TabButton drawRect:]): drag textured background obeying mask (-[TabButton mouseDownCanMoveWindow]): return NO (-[TabButton setState:]): set the close button images appropriately (-[TabButton setCloseAction:]): set the action of the close button (-[TabButton tabViewItem]): getter (-[TabButton height]): returns the height given the height of the mask image (-[TabButton closeTab:]): call the close action on the target of the button
  • TabButtonCell.h: Added.
  • TabButtonCell.m: Added. (+[TabButtonCell bottomColorForLightText]): override (+[TabButtonCell topColorForLightText]): override (-[TabButtonCell textRectForFrame:]): override (-[TabButtonCell setTextInsetX:]): sets the X inset
  • TabViewItemWithButton.h: Added.
  • TabViewItemWithButton.m: Added. (-[TabViewItemWithButton dealloc]): (-[TabViewItemWithButton setLabel:]): set the title on the button (-[TabViewItemWithButton setButton:]): set the button (-[TabViewItemWithButton button]): returns the button
  • WebBrowser.pbproj/project.pbxproj:

Feb 16, 2003:

11:39 PM Changeset in webkit [3651] by hyatt
  • 3 edits in trunk/WebCore

Fix "Almost Strict" mode to not match @konq-quirks.

Reviewed by kocienda

  • ChangeLog:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyleSelector):

Feb 15, 2003:

11:00 PM Changeset in webkit [3650] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/Localizable.strings: Regenerated.

Feb 14, 2003:

11:44 AM Changeset in webkit [3649] by hyatt
  • 2 edits in trunk/WebKit

Patch to the drawLine function for the inline box model landing.

Reviewed by kocienda

  • WebCoreSupport.subproj/WebTextRenderer.m:
11:43 AM Changeset in webkit [3648] by hyatt
  • 28 edits in trunk/WebCore

Make the inline box model live. Borders/backgrounds and text
decorations have been rewritten.

Also fixed a bug with clip rects. They didn't include borders.

Reviewed by kocienda

  • khtml/css/cssstyleselector.cpp:
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/font.cpp:
  • khtml/rendering/font.h:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::paintBackground): (RenderBox::paintBackgroundExtended): (RenderBox::getClipRect): (RenderBox::position):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox): (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations): (RenderFlow::repaint):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject): (RenderInline::width): (RenderInline::height): (RenderInline::offsetLeft): (RenderInline::offsetTop): (RenderInline::nodeAtPoint):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_line.cpp: (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::computeLogicalBoxHeights): (InlineFlowBox::placeBoxesVertically): (InlineFlowBox::shrinkBoxesWithNoTextChildren): (InlineFlowBox::paintBackgroundAndBorder): (shouldDrawDecoration): (InlineFlowBox::paintDecorations):
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::lineHeight): (RenderObject::getTextDecorationColors):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_root.cpp: (enclosingPositionedRect):
  • khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==): (RenderStyle::diff):
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_table.cpp: (RenderTableCell::repaintRectangle):
  • khtml/rendering/render_text.cpp: (TextRun::paintDecoration): (TextRun::checkSelectionPoint): (RenderText::nodeAtPoint): (RenderText::cursorPos): (RenderText::absolutePosition): (RenderText::paintObject): (RenderText::paint): (RenderText::position):
  • khtml/rendering/render_text.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawLineForText):
  • kwq/WebCoreTextRenderer.h:

Feb 13, 2003:

5:15 PM Changeset in webkit [3647] by trey
  • 19 edits in trunk

WebBrowser:

First checkin for working forms autocomplete.

The feature is disabled by default, but can be turned on (persistently) via
the debug menu. Note that your data is not encrypted on disk yet.

Aside from the plain old implementation work, there is some refactoring done
with CompletionController to allow URLCompletionController and FormCompletionController
to share more code.

There is also the addition of the libCdsaCrypt, which is not yet used, but will be
soon for encyption. It's a thin layer over some Security API's to make them usable
for simple applications, from developer.apple.com.

Reviewed by Chris

  • CompletionController.h: Added _ignoreTextDidChange. Added new methods to be implemented by subclasses to facilitate factoring.
  • CompletionController.m: (-[CompletionController _sendMessageIgnoringTextChanges:]): New wrapper to send a message with _ignoreTextDidChange temporarily set. This prevents recursion into our completion code. (-[CompletionController reflectSelectedRow]): Impl factored up from URLCompCtrl, calls new methods to get into from subclasses. (-[CompletionController reflectFinalSelectedRow]): Ditto. (-[CompletionController executeQuery]): Comment fix. (-[CompletionController completeString:]): Use _sendMessageIgnoringTextChanges (-[CompletionController queryString]): New method to be overridden. (-[CompletionController intermediateMatchingStringAtIndex:]): Ditto. (-[CompletionController finalMatchingStringAtIndex:]): Ditto. (-[CompletionController controlTextDidChange:]): Obey _ignoreTextDidChange flag. (-[CompletionController control:textView:doCommandBySelector:]): Use _sendMessageIgnoringTextChanges. (-[CompletionController goToItemAtRow:]): Ditto (-[CompletionController tableViewSelectionDidChange:]): Ditto (-[CompletionController tableView:objectValueForTableColumn:row:]): use new overridable method.
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Add item for disabling feature. (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument toggleFormsAutoComplete:]):
  • Defaults.plist: New key.
  • FormCompletionController.h:
  • FormCompletionController.m: All new code. (completionDBPath): Get db path. (domainFromFrame): Utility routine. (+[FormCompletionController formCompletionEnabled]): Return pref value. (+[FormCompletionController setFormCompletionEnabled:]): Set pref value. (-[FormCompletionController initWithSourceField:frame:]): Setup state for doing completion. (-[FormCompletionController dealloc]): (+[FormCompletionController _loadCompletionDB]): Load db. (+[FormCompletionController _saveCompletionDB:]): Save db. (+[FormCompletionController _saveCompletionDBSoon]): Queue up a db save. (+[FormCompletionController _appWillTerminate:]): Save db. (+[FormCompletionController clearFormAutoCompleteDatabase]): Nuke db. (+[FormCompletionController frame:willSubmitFormWithValues:]): Save new form values in db. (-[FormCompletionController executeQuery]): Match string to db.
  • PreferenceKeys.h: New key.
  • URLCompletionController.m: (-[URLCompletionController executeQuery]): Comment. (-[URLCompletionController intermediateMatchingStringAtIndex:]): Factored code from old impl mostly moved to super class. (-[URLCompletionController finalMatchingStringAtIndex:]): Factored code from old impl mostly moved to super class.
  • WebBrowser.pbproj/project.pbxproj: Add new security sample code.
  • libCdsaCrypt.h: Added.
  • libCdsaCrypt.m: Added.

WebKit:

First checkin for working forms autocomplete.

This level mostly just has glue to go from app to WC through the bridge.
WebHTMLReo exports some new SPI to get the element of a view, and then to get
some HTML-level properties of that element.

Reviewed by Chris

  • Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _saveBookmarkGroupGuts]): Don't dump entire bookmark dict in the log.
  • WebKit.exp: New class used by app, objc_class_name_WebHTMLRepresentation.
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation elementForView:]): New SPI. (-[WebHTMLRepresentation elementDoesAutoComplete:]): New SPI. (-[WebHTMLRepresentation elementIsInLoginForm:]): New SPI.

WebCore:

First checkin for working forms autocomplete.

This level has some new support routines.

Reviewed by Chris

  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::isLoginForm): New, returns if a form is for login.
  • khtml/html/html_formimpl.h:
  • kwq/KWQDOMNode.cpp: (idFromNode): New, helper routine to allow us to use the id() function from ObjC.
  • kwq/KWQDOMNode.h:
  • kwq/KWQTextArea.h: Adopt KWQWidgetHolder protocol.
  • kwq/KWQTextArea.mm: (-[KWQTextArea widget]): Adopt KWQWidgetHolder protocol. (-[KWQTextAreaTextView widget]): Adopt KWQWidgetHolder protocol.
  • kwq/KWQTextField.h: Adopt KWQWidgetHolder protocol.
  • kwq/KWQTextField.mm: (-[KWQTextField widget]): Adopt KWQWidgetHolder protocol. (-[KWQSecureTextField widget]): Adopt KWQWidgetHolder protocol.
  • kwq/KWQView.h: Define KWQWidgetHolder protocol
  • kwq/KWQView.mm: (-[KWQView widget]): Adopt KWQWidgetHolder protocol.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): New method. (inputElementFromDOMElement): Common code for next two methods. (-[WebCoreBridge elementIsInLoginForm:]): New method. (-[WebCoreBridge elementDoesAutoComplete:]): New method.
2:40 PM Changeset in webkit [3646] by darin
  • 8 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3162806 -- REGRESSION: handle == h assertion when clicking headphone link at cnn.com
  • khtml/ecma/kjs_window.cpp: (HistoryFunc::tryCall): Instead of trying to actually do the history navigation here, call the new KHTMLPart::scheduleHistoryNavigation.
  • khtml/khtml_part.cpp: (KHTMLPart::init): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields. (KHTMLPart::openURL): Ditto. (KHTMLPart::createJavaContext): Ditto. (KHTMLPart::clear): Also initialize m_scheduledRedirection to noRedirectionScheduled. (KHTMLPart::checkCompleted): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress. (KHTMLPart::scheduleRedirection): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress, and set m_scheduledRedirection to redirectionScheduled. (KHTMLPart::scheduleHistoryNavigation): Added. Does the same thing as scheduleRedirection, but always uses a delay of 0, sets m_scheduledRedirection to historyNavigationScheduled, and sets m_scheduledHistoryNavigationSteps. (KHTMLPart::slotRedirect): Add an if statement that does the history navigation. The code is moved here from HistoryFunc::tryCall. Also set m_scheduledRedirection to noRedirectionScheduled. (KHTMLPart::urlSelected): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields. (KHTMLPart::requestObject): Ditto. (KHTMLPart::submitForm): Ditto. (KHTMLPart::slotParentCompleted): Use m_scheduledRedirection rather than m_redirectURL to check whether a redirection is already in progress. (KHTMLPart::setZoomFactor): Add a few more #if !APPLE_CHANGES so we can leave out more unused fields.
  • khtml/khtml_part.h: Added scheduleHistoryNavigation.
  • khtml/khtmlpart_p.h: Added RedirectionScheduled enum. Added more #if !APPLE_CHANGES to leave out a bunch more fields we don't use. Added m_scheduledRedirection and m_scheduledHistoryNavigationSteps.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Check and don't do anything if the timer was being used for history redirection.
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close): Check m_scheduledRedirection instead of m_redirectURL to figure out if there is a redirection in progress. Not strictly necessary since we really don't care about the history case here, but consistent with the rest.
12:02 PM Changeset in webkit [3645] by sheridan
  • 3 edits in trunk

updating versions to 61u ... trunk had gotten out of sync because of the branch

10:54 AM Changeset in webkit [3644] by cblu
  • 18 edits in trunk

WebCore:

Fixed WebKit typos found by Peter Wilson.

Reviewed by darin.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bridgeForFrameName): call findOrCreateFrameNamed
  • kwq/WebCoreBridge.h: fixed method name for findOrCreateFrameNamed

WebKit:

Fixed WebKit typos found by Peter Wilson.

Reviewed by darin.

  • Misc.subproj/WebKitErrors.h:
  • Misc.subproj/WebKitErrors.m: (categoryInitialize): Error should be WebErrorDescriptionCannotFindApplicationForURL not WebErrorDescriptionCannotNotFindApplicationForURL
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): call findOrCreateFrameNamed
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): call findOrCreateFrameNamed
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge findOrCreateFrameNamed:]): call findOrCreateFrameNamed
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame findOrCreateFrameNamed:]): fixed name
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): use WebErrorDescriptionCannotFindApplicationForURL
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): use WebErrorDescriptionCannotFindApplicationForURL
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView setAllowsScrolling:]): cast to WebDynamicScrollBarsView (-[WebView allowsScrolling]): cast to WebDynamicScrollBarsView (-[WebView frameScrollView]): return NSScrollView
  • WebView.subproj/WebViewPrivate.m: (-[WebView _setDocumentView:]): cast to WebDynamicScrollBarsView
Note: See TracTimeline for information about the timeline view.