Timeline
Feb 18, 2003:
- 7:02 PM Changeset in webkit [3671] by
-
- 8 edits in trunk
WebCore:
Reviewed by Chris.
Merged changes from Safari-58-1-branch.
2003-02-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Trey.
- WebCore.pbproj/project.pbxproj: Include /System/Library/PrivateFrameworks.
WebKit:
Reviewed by Chris.
Merged changes from Safari-58-1-branch.
2003-02-11 Richard Williamson <rjw@apple.com>
Add import of CGFontCache.h, which is no longer
included by CoreGraphicsPrivate.h.
Reviewed by Vicki.
- WebCoreSupport.subproj/WebTextRendererFactory.m:
2003-02-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- WebCoreSupport.subproj/WebTextRenderer.m: Change (void ) cast to (void *) for compatibility with the latest Panther.
2003-02-11 Maciej Stachowiak <mjs@apple.com>
Reviewed by Trey.
- WebKit.pbproj/project.pbxproj: Add /System/Library/PrivateFrameworks
- 4:34 PM Changeset in webkit [3670] by
-
- 5 edits in trunk/WebCore
3171982 - REGRESSION: onClick handlers run twice when button pressed (DSLReports.com forums)
My earlier changes added the codepath by which we let khtmlview fully process
a mouse up after a widget has done it's tracking, which leads to the second
onClick call. Presumably that path does not exist in the native KDE case.
The change below reduces the impact of my hack, whereby instead of fully posting
a fake mouseup, we just note that the mouse has done up at the end of mousedown
handling, and clear the mousePressed state (state I also added).
Reviewed by Darin.
- khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): Look for a current mouseUp at the end of dispatching the mouse down.
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Don't post a phony mouse up from here. (KWQKHTMLPart::lastEventIsMouseUp): Utility routine to test for mouseUp.
- 3:25 PM Changeset in webkit [3669] by
-
- 3 edits in trunk
opening tree for Safari-63
- 3:23 PM Changeset in webkit [3668]
-
- 3 copies in tags/Safari-62
This commit was manufactured by cvs2svn to create tag 'Safari-62'.
- 3:23 PM Changeset in webkit [3667] by
-
- 3 edits in trunk
fixing typo
- 3:18 PM Changeset in webkit [3666] by
-
- 8 edits in trunk
Safari-62 for the trunk
- 2:18 PM Changeset in webkit [3665]
-
- 31 copies1 delete in tags/Safari-61
This commit was manufactured by cvs2svn to create tag 'Safari-61'.
- 2:18 PM Changeset in webkit [3664] by
-
- 9 edits in branches/Safari-0-8-2-branch
Safari-61 on the branch
- 2:06 PM Changeset in webkit [3663] by
-
- 2 edits in trunk/WebCore
Fix for 3176102, bad table cell regression. I was adding in
random properties for cells. Eep.
Also patched table element to add in the inherit property using
CSS_VAL_INHERIT instead of the string "inherit" (faster).
Reviewed by gramps
- khtml/css/cssstyleselector.cpp:
- khtml/html/html_tableimpl.cpp
- 2:03 PM Changeset in webkit [3662] by
-
- 4 edits in trunk/WebCore
Fix for 3176102, bad table cell regression. I was adding in
random properties for cells. Eep.
Reviewed by gramps
- khtml/css/cssstyleselector.cpp:
- 12:13 PM Changeset in webkit [3661] by
-
- 3 edits in trunk/WebCore
Fix for 3171795, dotted borders drawn incorrectly. Picked this
gem up from the KHTML trunk.
Reviewed by darin
- khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
- 11:18 AM Changeset in webkit [3660] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Trey and Ken.
- fixed 3142355 -- nil-deref in CFTimeZoneCopyAbbreviation
Although I can't reproduce this bug, it seems that it's caused by CFTimeZoneCopyDefault returning NULL.
I'm almost certain that the UTC time zone will be created successfully in this case, so I'll just use that.
- kjs/date_object.cpp: (UTCTimeZone): Added. Gets the UTC time zone (once in a global). (CopyLocalTimeZone): Added. Gets the local time zone, but falls back to UTC. (gmtimeUsingCF): Use UTCTimeZone. (localtimeUsingCF): Use CopyLocalTimeZone. (mktimeUsingCF): Use CopyLocalTimeZone. (timegmUsingCF): Use UTCTimeZone.
Feb 17, 2003:
- 4:13 PM Changeset in webkit [3659] by
-
- 4 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3174332 -- REGRESSION: bad initial layout due to empty QFontMetrics
- khtml/rendering/render_html.cpp: (RenderHtml::setStyle): Don't set the style's to display:BLOCK if it's display:NONE. This prevents us from modifying the special FOUC style among other things.
- unrelated code cleanup
- khtml/html/html_baseimpl.cpp: Moved code around that was grouped badly.
- 2:19 PM Changeset in webkit [3658] by
-
- 3 edits in trunk/WebCore
Missed another "Almost Strict" spot.
Reviewed by kocienda
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle):
- 12:25 PM Changeset in webkit [3657] by
-
- 7 edits in trunk/WebCore
Fix for 3% improvement on cached cvs-base. Make cells share the
declarations set up by the table (add these decls to the table
once instead of to every cell).
Reviewed by darin
- khtml/css/cssstyleselector.cpp:
- khtml/css/cssstyleselector.h:
- khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): (HTMLTableElementImpl::~HTMLTableElementImpl): (HTMLTableElementImpl::createSharedCellDecls): (HTMLTableCellElementImpl::getAdditionalStyleDecls): (HTMLTableCellElementImpl::attach):
- khtml/html/html_tableimpl.h:
- khtml/xml/dom_elementimpl.h:
- 11:22 AM Changeset in webkit [3656] by
-
- 1 edit in trunk/WebCore/khtml/khtmlview.cpp
Cleanup comment turd left in by mistake
- 11:00 AM Changeset in webkit [3655] by
-
- 22 edits in trunk/WebKit
Reviewed by Trey
Rolled in documentation changes from Peter Kelly, our tech writer.
- History.subproj/WebBackForwardList.h
- History.subproj/WebHistory.h
- Misc.subproj/WebKitErrors.h
- Misc.subproj/WebResourceResponseExtras.h
- Panels.subproj/WebStandardPanels.h
- Plugins.subproj/WebPluginError.h
- WebView.subproj/WebContextMenuDelegate.h
- WebView.subproj/WebController.h
- WebView.subproj/WebControllerPolicyDelegate.h
- WebView.subproj/WebDataSource.h
- WebView.subproj/WebDefaultPolicyDelegate.h
- WebView.subproj/WebDocument.h
- WebView.subproj/WebFrame.h
- WebView.subproj/WebPreferences.h
- WebView.subproj/WebResourceLoadDelegate.h
- WebView.subproj/WebView.h
- WebView.subproj/WebWindowOperationsDelegate.h
- 10:54 AM Changeset in webkit [3654] by
-
- 2 edits in trunk/WebKit
2943514 hide the cursor when using the arrow keys to scroll
Reviewed by Darin
- WebView.subproj/WebView.m: (-[WebView keyDown:]): Hide that cursor.
- 10:53 AM Changeset in webkit [3653] by
-
- 4 edits in trunk/WebCore
2938062 Mouse cursor does not change to link cursor over non-button form submission controls
Reviewed by Darin
- khtml/khtmlview.cpp: (isSubmitImage): Helper function to ID submit buttons with images. (KHTMLView::viewportMouseMoveEvent): Set cursor for submit buttons with images.
- kwq/WebCoreBridge.mm: (inputElementFromDOMElement): Simplify previously written casting goop.
- 9:21 AM Changeset in webkit [3652] by
-
- 4 edits in trunk/WebKit
WebKit:
Added debug method that can be used inside of gdb to examine an image. Needed this many times.
Reviewed by darin.
- Misc.subproj/WebNSImageExtras.h:
- Misc.subproj/WebNSImageExtras.m: (-[NSImage _web_saveAndOpen]):
WebBrowser:
Implemented the tab bar with tabs and all.
Reviewed by darin.
- BarBackground.m: moved private appkit declarations to BrowserNSViewExtras and BrowserNSWindowExtras so they can be used by other classes
- BrowserNSStringExtras.m: (-[NSString drawDoubledInRect:withTopColor:bottomColor:font:centered:flipped:]): obey the x origin when centering text
- BrowserNSViewExtras.h:
- BrowserNSViewExtras.m: (-[NSView shouldDrawBackgroundTheSneakyPrivateNSWindowWay]): moved method from BarBackground so it can be used by other classes
- BrowserNSWindowExtras.h: put private appkit declarations here
- English.lproj/Browser.nib:
- EtchedStringButtonCell.h: Added.
- EtchedStringButtonCell.m: Added. Factored out from FavoriteButtonCell so TabButtonCell can use the same functionality (+[EtchedStringButtonCell font]): (+[EtchedStringButtonCell bottomColorForDarkText]): (+[EtchedStringButtonCell topColorForDarkText]): (+[EtchedStringButtonCell bottomColorForLightText]): (+[EtchedStringButtonCell topColorForLightText]): (-[EtchedStringButtonCell textRectForFrame:]): (-[EtchedStringButtonCell drawInteriorWithFrame:inView:]): (-[EtchedStringButtonCell setTextCenterTruncated:]): (-[EtchedStringButtonCell isTextCenterTruncated]): (-[EtchedStringButtonCell setTextCentered:]): (-[EtchedStringButtonCell isTextCentered]): (-[EtchedStringButtonCell setDrawsLightText:]): (-[EtchedStringButtonCell drawsLightText]):
- FavoriteButton.m: (-[FavoriteButton setBookmark:]):
- FavoriteButtonCell.h:
- FavoriteButtonCell.m: made subclass of EtchedStringButtonCell (+[FavoriteButtonCell updateCellForButton:]): (-[FavoriteButtonCell textRectForFrame:]): (-[FavoriteButtonCell imageRectForFrame:]): (-[FavoriteButtonCell drawInteriorWithFrame:inView:]):
- Resources/Images/TabBevel_Caps.tif: Added.
- Resources/Images/TabBevel_Middle.tif: Added.
- Resources/Images/TabClose_Back.tif: Added.
- Resources/Images/TabClose_Back_Pressed.tif: Added.
- Resources/Images/TabClose_Back_Rollover.tif: Added.
- Resources/Images/TabClose_Front.tif: Added.
- Resources/Images/TabClose_Front_Pressed.tif: Added.
- Resources/Images/TabClose_Front_Rollover.tif: Added.
- Resources/Images/TabMask_Caps.tif: Added.
- Resources/Images/TabMask_Middle.tif: Added.
- TabBarView.h:
- TabBarView.m: (-[TabBarView scaledAndTexturedWindowBackgroundImage]): image of textured background used by tab buttons (-[TabBarView windowBackgroundImage]): ditto (-[TabBarView _addTabButtonWithTabViewItem:]): links tab button to tab item (-[TabBarView _removeTabButton:]): removes tab button (-[TabBarView _layOutButtons]): lays out tab buttons (-[TabBarView _bringSelectedTabToFront:]): brings tab button of tab item to front (-[TabBarView awakeFromNib]): set things up (-[TabBarView dealloc]): release things (-[TabBarView _drawSeparatorAtXOrigin:]): draws separator (-[TabBarView drawRect:]): draw separators (-[TabBarView setFrameSize:]): call _layOutButtons (-[TabBarView bringTabToFront:]): brings tab item of tab button to front (-[TabBarView closeTab:]): closes the clicked tab (-[TabBarView tabView:shouldSelectTabViewItem:]): forward to delegate, return YES otherwise (-[TabBarView tabView:willSelectTabViewItem:]): deselect current tab, forward to delegate (-[TabBarView tabView:didSelectTabViewItem:]): select current tab, forward to delegate (-[TabBarView tabViewDidChangeNumberOfTabViewItems:]): call _layOutButtons, forward to delegate
- TabButton.h: Added.
- TabButton.m: Added. (+[TabButton initialize]): set the cell (+[TabButton _loadImages]): load images (-[TabButton _setCloseButtonImages:]): set close images (-[TabButton initWithFrame:tabViewItem:]): set attributes (-[TabButton dealloc]): release things (-[TabButton drawRect:]): drag textured background obeying mask (-[TabButton mouseDownCanMoveWindow]): return NO (-[TabButton setState:]): set the close button images appropriately (-[TabButton setCloseAction:]): set the action of the close button (-[TabButton tabViewItem]): getter (-[TabButton height]): returns the height given the height of the mask image (-[TabButton closeTab:]): call the close action on the target of the button
- TabButtonCell.h: Added.
- TabButtonCell.m: Added. (+[TabButtonCell bottomColorForLightText]): override (+[TabButtonCell topColorForLightText]): override (-[TabButtonCell textRectForFrame:]): override (-[TabButtonCell setTextInsetX:]): sets the X inset
- TabViewItemWithButton.h: Added.
- TabViewItemWithButton.m: Added. (-[TabViewItemWithButton dealloc]): (-[TabViewItemWithButton setLabel:]): set the title on the button (-[TabViewItemWithButton setButton:]): set the button (-[TabViewItemWithButton button]): returns the button
- WebBrowser.pbproj/project.pbxproj:
Feb 16, 2003:
- 11:39 PM Changeset in webkit [3651] by
-
- 3 edits in trunk/WebCore
Fix "Almost Strict" mode to not match @konq-quirks.
Reviewed by kocienda
- ChangeLog:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyleSelector):
Feb 15, 2003:
- 11:00 PM Changeset in webkit [3650] by
-
- 2 edits in trunk/WebKit
- English.lproj/Localizable.strings: Regenerated.
Feb 14, 2003:
- 11:44 AM Changeset in webkit [3649] by
-
- 2 edits in trunk/WebKit
Patch to the drawLine function for the inline box model landing.
Reviewed by kocienda
- WebCoreSupport.subproj/WebTextRenderer.m:
- 11:43 AM Changeset in webkit [3648] by
-
- 28 edits in trunk/WebCore
Make the inline box model live. Borders/backgrounds and text
decorations have been rewritten.
Also fixed a bug with clip rects. They didn't include borders.
Reviewed by kocienda
- khtml/css/cssstyleselector.cpp:
- khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
- khtml/rendering/bidi.cpp:
- khtml/rendering/font.cpp:
- khtml/rendering/font.h:
- khtml/rendering/render_block.cpp:
- khtml/rendering/render_block.h:
- khtml/rendering/render_box.cpp: (RenderBox::paintBackground): (RenderBox::paintBackgroundExtended): (RenderBox::getClipRect): (RenderBox::position):
- khtml/rendering/render_box.h:
- khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox): (RenderFlow::paintLineBoxBackgroundBorder): (RenderFlow::paintLineBoxDecorations): (RenderFlow::repaint):
- khtml/rendering/render_flow.h:
- khtml/rendering/render_inline.cpp: (RenderInline::paintObject): (RenderInline::width): (RenderInline::height): (RenderInline::offsetLeft): (RenderInline::offsetTop): (RenderInline::nodeAtPoint):
- khtml/rendering/render_inline.h:
- khtml/rendering/render_line.cpp: (InlineFlowBox::verticallyAlignBoxes): (InlineFlowBox::computeLogicalBoxHeights): (InlineFlowBox::placeBoxesVertically): (InlineFlowBox::shrinkBoxesWithNoTextChildren): (InlineFlowBox::paintBackgroundAndBorder): (shouldDrawDecoration): (InlineFlowBox::paintDecorations):
- khtml/rendering/render_line.h:
- khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::lineHeight): (RenderObject::getTextDecorationColors):
- khtml/rendering/render_object.h:
- khtml/rendering/render_root.cpp: (enclosingPositionedRect):
- khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): (StyleInheritedData::StyleInheritedData): (StyleInheritedData::operator==): (RenderStyle::diff):
- khtml/rendering/render_style.h:
- khtml/rendering/render_table.cpp: (RenderTableCell::repaintRectangle):
- khtml/rendering/render_text.cpp: (TextRun::paintDecoration): (TextRun::checkSelectionPoint): (RenderText::nodeAtPoint): (RenderText::cursorPos): (RenderText::absolutePosition): (RenderText::paintObject): (RenderText::paint): (RenderText::position):
- khtml/rendering/render_text.h:
- kwq/KWQPainter.h:
- kwq/KWQPainter.mm: (QPainter::drawLineForText):
- kwq/WebCoreTextRenderer.h:
