Timeline



Feb 26, 2003:

5:15 PM Changeset in webkit [3709] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • fixed 3156705 - REGRESSION: javascript menus improperly placed at umich.edu store
  • kjs/nodes.cpp: (StatListNode::execute): If the first statement's completion is not normal, return immediately.
3:38 PM Changeset in webkit [3708] by hyatt
  • 4 edits in trunk/WebCore

Additional cleanup. Don't need the arg to be a reference param
any more.

Reviewed by mjs

  • khtml/rendering/render_object.cpp: (RenderObject::getTextDecorationColors):
  • khtml/rendering/render_object.h:
3:22 PM Changeset in webkit [3707] by mjs
  • 11 edits in trunk

WebCore:

Reviewed by Dave.

This was a set of mutually recursive frameset pages. This allows
the number of frames to grow huge, which kills both WebCore and
WebKit, so I added a hard limit of 200 total frames per page.

  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::detach): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_baseimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::incrementFrameCount): (KHTMLPart::decrementFrameCount): (KHTMLPart::topLevelFrameCount):
  • khtml/khtml_part.h:

WebKit:

Reviewed by Dave.

WebKit's processing time was O(N3) in the number of
frames. Improved it to O(N2) by storing frame pointer directly in
WebDataSource instead of linear scan. Could still be improved more.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource webFrame]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setWebFrame:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): (-[WebFrame _setDataSource:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]): (-[WebFrame _clearProvisionalDataSource]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formValues:]): (-[WebFrame _loadDataSource:withLoadType:formValues:]): (-[WebFrame _setProvisionalDataSource:]):
3:10 PM Changeset in webkit [3706] by hyatt
  • 6 edits in trunk/WebCore

Fix numerous regressions with text-decoration in quirks mode and
also fixed a bug where text-decoration:none is not being honored
on links.

Reviewed by mjs

  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/render_object.cpp: (RenderObject::getTextDecorationColors):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_text.cpp: (TextRun::paintDecoration):
1:39 PM Changeset in webkit [3705] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3179109. containingBlock() had a big old bug in it.
For ABSOLUTE positioned elements, it would return inline relative
positioned parents (when it should only be returning blocks).

Reviewed by john

  • khtml/rendering/render_object.cpp: (RenderObject::containingBlock):
12:59 PM Changeset in webkit [3704] by rjw
  • 8 edits in trunk/WebKit

Fixed 3102760. Removed WebDocumentDragSettings from API.

Reviewed by Chris.

  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m:
  • WebView.subproj/WebImageView.h:
  • WebView.subproj/WebImageView.m: (-[WebImageView initWithFrame:]): (-[WebImageView mouseDragged:]):
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (-[WebTextView initWithFrame:]): (-[WebTextView layout]):
12:25 AM Changeset in webkit [3703] by hyatt
  • 5 edits in trunk/WebCore

Fix for findNextLayer problems. There was nothing wrong with
findNextLayer per se... it was just getting called *way* more
often than it needed to be.

Fixes two bugs, 3159866 and 3168815.

Reviewed by darin

  • khtml/rendering/render_container.cpp: (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/rendering/render_object.cpp: (addLayers): (RenderObject::addLayers):
  • khtml/rendering/render_object.h:

Feb 25, 2003:

10:18 PM Changeset in webkit [3702] by darin
  • 4 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3177139 -- REGRESSION: tiny buttons with no text on dbaron test page

This is actually a shortcoming in XML support. The reason it seemed like a regression
is that this page was parsed as HTML before we had the XML support.

  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): As the HTML tokenizer/parser does, call init() on all DOM tree elements before calling attach(). The KHTML guys want to get rid of init(), but until they do, we need the same thing here as in the HTML version. (XMLHandler::startCDATA): Ditto. (XMLHandler::enterText): Ditto.
  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Fix an obvious editing error that would lead to a second attach.
7:52 PM Changeset in webkit [3701] by hyatt
  • 3 edits in trunk/WebCore

Revert one of my optimizations. It was bogus. You can't use
the parsed value of "inherit."

Fixes versiontracker. Bug #3178204

Reviewed by mjs

  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::createSharedCellDecls):
6:38 PM Changeset in webkit [3700] by hyatt
  • 3 edits in trunk/WebCore

reverseRuns was buggy and crashing. 3182658.

Reviewed by mjs

  • khtml/rendering/bidi.cpp:
5:46 PM Changeset in webkit [3699] by hyatt
  • 3 edits in trunk/WebCore

Regression caused by my inclusion of inline flows in the bidi
iteration. These flows are always empty and should be skipped
if found at the start of a line.

The bug # is 3175670.

Reviewed by NOBODY (OOPS!).

  • khtml/rendering/bidi.cpp:
4:56 PM Changeset in webkit [3698] by hyatt
  • 2 edits in trunk/WebKit

Fix for bug #3181249. Ensure the padding argument gets passed
through properly (instead of just passing 0).

Reviewed by darin

  • WebCoreSupport.subproj/WebTextRenderer.m:
4:34 PM Changeset in webkit [3697] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug 3166276. <tt> uses wrong font size inside a table.
Make sure logical font values like "medium" don't set the "size
specified" bit on the font, so that the generic family change
code will get activated.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp:
2:28 PM Changeset in webkit [3696] by darin
  • 7 edits in trunk/WebCore

Reviewed by me, changes by Dave.

  • fixed 3181790 -- REGRESSION: TextRun objects of length 0 or with just the character '\n' leak
  • khtml/rendering/render_text.cpp: (RenderText::position): Destroy the passed-in TextRun if it's the kind that's not needed, rather than just returning.
  • fixed 3181794 -- REGRESSION: objects created by RenderObject::createInlineBox leak
  • khtml/rendering/render_box.cpp: (RenderBox::position): Only do work for replaced elements, and for those elements, destroy the passed-in InlineBox. Dave says this is not the real solution, but it does plug the leak.
  • khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox): Call through to the inherited createInlineBox for all replaced elements. This code was making the wrong kind of InlineBox for replaced elements.
  • removed Id cvs magic string which causes big headaches in generated files
  • khtml/css/parser.cpp: Removed Id cvs magic string.
  • khtml/css/parser.y: Removed Id cvs magic string.
12:00 PM Changeset in webkit [3695] by hyatt
  • 43 edits
    9 adds in trunk/WebCore

The new CSS1 parser, implementation of attr(), improvement of
the content property, impl of the :target selector, and new
dotted/dashed line drawing code for borders.

Reviewed by darin/gramps

  • ForwardingHeaders/css/css_base.h: Added.
  • WebCore.pbproj/project.pbxproj:
  • khtml/css/Makefile.am:
  • khtml/css/css_base.cpp: Added. (StyleBaseImpl::checkLoaded): (StyleBaseImpl::stylesheet): (StyleBaseImpl::baseURL): (StyleBaseImpl::setParsedValue): (StyleListImpl::~StyleListImpl): (CSSSelector::print): (CSSSelector::specificity): (CSSSelector::extractPseudoType): (CSSSelector::operator == ): (CSSSelector::selectorText):
  • khtml/css/css_base.h: Added.
  • khtml/css/css_ruleimpl.cpp: (CSSRuleImpl::parentRule): (CSSImportRuleImpl::CSSImportRuleImpl): (CSSImportRuleImpl::~CSSImportRuleImpl): (CSSImportRuleImpl::setStyleSheet): (CSSImportRuleImpl::init): (CSSMediaRuleImpl::CSSMediaRuleImpl): (CSSMediaRuleImpl::append): (CSSMediaRuleImpl::insertRule): (CSSStyleRuleImpl::setDeclaration): (CSSStyleRuleImpl::setNonCSSHints):
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::CSSStyleSheetImpl): (CSSStyleSheetImpl::insertRule): (CSSStyleSheetImpl::cssRules): (CSSStyleSheetImpl::parseString): (MediaListImpl::deleteMedium):
  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::getPropertyValue): (CSSStyleDeclarationImpl::get4Values): (CSSStyleDeclarationImpl::getShortHandValue): (CSSStyleDeclarationImpl::getPropertyCSSValue): (CSSStyleDeclarationImpl::removeProperty): (CSSStyleDeclarationImpl::getPropertyPriority): (CSSStyleDeclarationImpl::setProperty): (CSSStyleDeclarationImpl::setLengthProperty): (CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (CSSPrimitiveValueImpl::cleanup): (CSSPrimitiveValueImpl::computeLength): (CSSPrimitiveValueImpl::computeLengthFloat): (CSSPrimitiveValueImpl::setFloatValue): (CSSPrimitiveValueImpl::cssText): (FontFamilyValueImpl::FontFamilyValueImpl): (FontValueImpl::FontValueImpl): (FontValueImpl::~FontValueImpl):
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp: (qFatal): (ValueList::ValueList): (ValueList::~ValueList): (ValueList::addValue): (CSSParser::CSSParser): (CSSParser::~CSSParser): (CSSParser::parseSheet): (CSSParser::parseRule): (CSSParser::parseValue): (CSSParser::parseDeclaration): (CSSParser::addProperty): (CSSParser::createStyleDeclaration): (CSSParser::clearProperties): (CSSParser::document): (validUnit): (CSSParser::parseShortHand): (CSSParser::parse4Values): (CSSParser::parseContent): (CSSParser::parseShape): (CSSParser::parseFont): (CSSParser::parseFontFamily): (parseColor): (CSSParser::parseColor): (yyerror): (DOM::CSSParser::lex): (toHex): (DOM::CSSParser::text):
  • khtml/css/cssparser.h:
  • khtml/css/cssproperties.c: (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/css/parser.cpp: Added. (DOM::getPropertyID): (getValueID): (cssyyerror): (cssyylex): (yy_memcpy):
  • khtml/css/parser.h: Added.
  • khtml/css/parser.y: Added.
  • khtml/css/quirks.css: Added.
  • khtml/css/tokenizer.cpp: Added.
  • khtml/css/tokenizer.flex: Added.
  • khtml/dom/css_value.h:
  • khtml/dom/html_element.cpp:
  • khtml/ecma/kjs_css.cpp:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):
  • khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute): (HTMLHRElementImpl::attach): (HTMLParagraphElementImpl::parseAttribute):
  • khtml/html/html_elementimpl.cpp: (isHexDigit): (toHex): (HTMLElementImpl::addHTMLColor):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_inlineimpl.cpp: (HTMLFontElementImpl::parseAttribute):
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): (HTMLTableElementImpl::attach): (HTMLTablePartElementImpl::parseAttribute): (HTMLTableCellElementImpl::parseAttribute):
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
  • khtml/misc/helper.h:
  • khtml/rendering/render_body.cpp: (RenderBody::setStyle):
  • khtml/rendering/render_list.cpp: (RenderListMarker::lineHeight): (RenderListMarker::baselinePosition):
  • khtml/rendering/render_style.cpp: (RenderStyle::setContent):
  • khtml/rendering/render_style.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::setFocusNode): (DocumentImpl::setCSSTarget): (DocumentImpl::getCSSTarget):
  • khtml/xml/dom_docimpl.h:
  • kwq/KWQChar.mm: (QChar::upper):
  • kwq/KWQColor.h:
  • kwq/KWQKStandardDirs.mm: (locate):
  • kwq/KWQPainter.mm: (QPainter::drawLine):
  • kwq/KWQString.h:
11:47 AM Changeset in webkit [3694] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3181290 -- need call to reload all bookmarks from disk,
for synching's sake.

I ended up not adding a new call, but making the existing loadBookmarkGroup
work better when called after the initial load. It wasn't doing anything wrong
before; it just wasn't passing along enough information to clients to enable
them to do the right thing.

Reviewed by Trey

  • Bookmarks.subproj/WebBookmarkGroup.h: new extern NSStrings WebBookmarksWillBeReloadedNotification and WebBookmarksWereReloadedNotification
  • Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup _sendNotification:forBookmark:children:]): soften assert so it doesn't fire on the new cases.

(-[WebBookmarkGroup _bookmarksWillBeReloaded]):
send WebBookmarksWillBeReloadedNotification
(-[WebBookmarkGroup _bookmarksWereReloaded]):
send WebBookmarksWereReloadedNotification

(-[WebBookmarkGroup _loadBookmarkGroupGuts]):
bracket the load with the new notification-sending calls

  • WebKit.exp: add the two new extern NSStrings

WebBrowser:

WebBrowser part of fix for 3181290 -- need call to reload all
bookmarks from disk, for synching's sake

Reviewed by Trey

  • BookmarksController.m: (-[BookmarksController _receivedBookmarksWereReloadedNotification:]): new method; parallel to _receivedBookmarksChangedNotification. Unlike that method, this one does not trigger a save-bookmars-to-disk. (Also this one updates the top-level data structures.) (-[BookmarksController awakeFromNib]): register for WebBookmarksWereReloadedNotifications from our group.
  • BookmarksViewController.m: (-[BookmarksViewController updateUIForChangeToBookmark:includingChildren:]): Changed title from ...andChildren:. Used to take array of children, now just takes a boolean. The array was being converted into a boolean immediately, and rather than add yet another caller that created an array for the sole purpose of passing it to this method, I changed the method to take the boolean and updated all callers. (-[BookmarksViewController bookmarksChanged:]): handle reload case by getting top changed bookmark from bookmark group that is the notification object (-[BookmarksViewController awakeFromNib]): register for WebBookmarksWereReloadedNotification from our bookmark group (-[BookmarksViewController newSourceFolder]): update for parameter change in updateUIForChangeToBookmark:includingChildren: (-[BookmarksViewController undoNewBookmark:]): ditto (-[BookmarksViewController redoNewBookmark:]): ditto (-[BookmarksViewController newContentItemWithTitle:URLString:type:positionIgnoresSelection:]): ditto (-[BookmarksViewController changeTitleForBookmark:to:]): ditto (-[BookmarksViewController changeAddressForBookmark:to:]): ditto
  • URLCompletionController.m: (+[URLCompletionController _loadDB]): removed false part of comment (+[URLCompletionController _registerForNotifications]): register for WebBookmarksWereReloadedNotification, call _reloadDB
10:18 AM Changeset in webkit [3693] by darin
  • 4 edits in trunk/WebKit

WebKit:

Reviewed by John.

  • fixed 3176962 -- add KHTML somewhere in the user agent string
  • English.lproj/StringsNotToBeLocalized.txt: Change "(like Gecko)" to "(KHTML, like Gecko)".
  • WebView.subproj/WebController.m: (-[WebController userAgentForURL:]): Ditto.

WebBrowser:

Reviewed by John.

  • fixed 3176962 -- add KHTML somewhere in the user agent string
  • Debug/DebugUtilities.m: (-[DebugUtilities userAgentSubmenuItem]): Change "(like Gecko)" to "(KHTML, like Gecko)".

Feb 24, 2003:

3:09 PM Changeset in webkit [3692] by mjs
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed 3167642 - crash in renderArena.
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::HTMLDocumentImpl): Added new processingLoadEvent bool. (HTMLDocumentImpl::close): Guard against re-entering the load event handler.
10:33 AM Changeset in webkit [3691] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3179059 -- CSS1: capitalized letters should remain capitalized when text-transform: capitalize is applied
  • khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::capitalize): Capitalize the first letters of words, but don't make any letters lowercase.

Feb 23, 2003:

3:24 PM Changeset in webkit [3690] by darin
  • 3 edits in trunk/WebCore

Tests:

Reviewed by Maciej.

  • added tests for URLs affected by bug 3179181, ones with a "?" or "#" character right after the host name, with no intervening "/"
  • turned off tests that aren't passing right now, so make check can be used pass/fail easy to turn tests back on by editing test.list
  • WebFoundation-Misc/ifnsstringextensions-test.chk: Updated results for _web_splitAtNonDateCommas, which now splits only at commas followed by spaces.
  • test.list: Disabled ifnsthreadextensions-test, ifnsurlextensions-test, and ifurlparsing-test, since they aren't passing right now. We can turn them back on when we get them back in shape.

WebCore:

Reviewed by Maciej.

  • fixed 3179181 -- KURL won't accept URLs with a query part and no / separating host name from path
  • kwq/KWQKURL.mm: (KURL::parse): Allow any path segment end character to end the host part of a URL, rather than allowing only a "/".
Note: See TracTimeline for information about the timeline view.