⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 5, 2003:

11:29 PM Changeset in webkit [3757] by trey
  • 4 edits in trunk/WebCore

Autofill tweak. In field names, replace all digits with spaces before matching
labels against them. This turns the digits to word boundaries, so field names like
"address2" are matched by "address".

As part of this, I abandoned an earlier attempt to map Qt regexp syntax to Darwin's.
Now clients just have to use Darwin's.

Reviewed by Maciej.

  • kwq/KWQKHTMLPart.mm: (regExpForLabels): (KWQKHTMLPart::matchLabelsAgainstElement): Replace digits with space.
  • kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::compile): Don't try to support Qt syntax.
7:26 PM Changeset in webkit [3756] by rjw
  • 30 edits in trunk/WebKit

WebKit:

API changes
WebView and WebDataSource give up -(WebController *)controller.
WebView gets -(WebFrame *)webFrame.

Reviewed by cblu.

  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView dataSource]):
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient resourceDidFinishLoading:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setDataSource:]):
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController backForwardList]): (-[WebController setUsesBackForwardList:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _controller]): (-[WebDataSource _receivedError:complete:]): (-[WebDataSource _loadIcon]):
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFramePrivate.m: (switch):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _controller]): (-[WebHTMLView _frame]): (-[WebHTMLView _elementAtPoint:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView controller]): (-[WebImageView menuForEvent:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): (-[WebMainResourceClient continueAfterNavigationPolicy:formState:]): (-[WebMainResourceClient resource:willSendRequest:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient resource:didReceiveData:]): (-[WebMainResourceClient resourceDidFinishLoading:]): (-[WebMainResourceClient resource:didFailLoadingWithError:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]):
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView webFrame]): (-[WebView concludeDragOperation:]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _controller]):

WebBrowser:

API changes
WebView and WebDataSource give up -(WebController *)controller.
WebView gets -(WebFrame *)webFrame.

Reviewed by cblu.

  • BrowserTabViewItem.m: (-[BrowserTabViewItem webController]):
  • BrowserWebViewExtras.m: (-[WebView largestScrollableWebView]):
  • BrowserWindowController.m: (-[BrowserWindowController updateLabelForTab:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController findTabForWebController:]): (-[BrowserWindowController tabBarView:menuForClippedTabViewItems:]): (-[BrowserWindowController reloadTab:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController canReloadTab:]): (-[BrowserWindowController canReloadAllTabs]):
  • DownloadProgressEntry.m:
  • LoadProgressMonitor.m: (-[LoadProgressMonitor resource:didReceiveResponse:fromDataSource:]): (-[LoadProgressMonitor resource:didReceiveContentLength:fromDataSource:]):
5:17 PM Changeset in webkit [3755] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • WebView.subproj/WebFramePrivate.m: (_recursiveGoToItem:fromItem:withLoadType:): Account for possibility of nil target.
3:19 PM Changeset in webkit [3754] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • fixed crash when going back due to frame name of nil since we don't force the name "_top" any more.
  • WebView.subproj/WebController.m: (-[WebController _goToItem:withLoadType:]): Handle nil target properly.
8:23 AM Changeset in webkit [3753] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed 3189441 -- REGRESSION: layout tests crash building generated frame name
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _addFramePathToString:]): Handle a frame name of nil here, since we don't force the name "_top" any more.
8:19 AM Changeset in webkit [3752] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3189442 -- REGRESSION: utf-16-little-endian.html crashes making decoder
  • kwq/KWQCharsets.mm: (encodingNameHash): Re-add tolower call to hash function to match the equality function.

Mar 4, 2003:

11:18 PM Changeset in webkit [3751] by trey
  • 11 edits in trunk

WebCore:

New support for autofill. We provide a routine that scans backwards in the text
before a given element, looking for a match with a set of labels. In addition,
we provide for a similar match against the element's name.

To implement a few more methods in QRegExp API were implemented.

Reviewed by Maciej.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (scanForForm): Remove redundant call to a helper function. (regExpForLabels): Return a regexp used to search for the set of labels. (KWQKHTMLPart::searchForLabelsBeforeElement): Walk the DOM to scan backwards in the text before the element, apply regexp to the text we find. (KWQKHTMLPart::matchLabelsAgainstElement): Get the element name, use regexp to check it for any of the labels.
  • kwq/KWQRegExp.h:
  • kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::KWQRegExpPrivate): Init two new ivars. (RegExpFromPattern): Massage a non-glob expression before handing to Darwin. (QRegExp::KWQRegExpPrivate::compile): Call RegExpFromPattern. (QRegExp::match): Set new ivars based on match result. (QRegExp::search): New API, just call match. (QRegExp::searchRev): New API, call match repeatedly to (weakly) simulate a reverse search. (QRegExp::pos): Return info from last result. (QRegExp::matchedLength): Return info from last result.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge searchForLabels:beforeElement:]): Call straight through to part. (-[WebCoreBridge matchLabels:againstElement:]): Call straight through to part.

WebKit:

Support for autofill. These are just two new glue routines
that call down through the bridge. They allow regexp driven
binding of AB data to form elements.

Reviewed by Maciej.

  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Call straight to bridge. (-[WebHTMLRepresentation matchLabels:againstElement:]): Call straight to bridge.
11:14 PM Changeset in webkit [3750] by mjs
  • 2 edits in trunk/WebKit

Reinstate missing part of last checking.

  • WebView.subproj/WebFramePrivate.m:
11:05 PM Changeset in webkit [3749] by mjs
  • 12 edits in trunk/WebKit

Tests:

Reviewed by Trey.

Updated for WebKit API change.

  • DumpBackForward/main.m: (main): (-[CheapWindowOpsDelegate createWindowWithRequest:]):
  • DumpRenderTree/main.m: (main):
  • PDFViewer/DocumentController.m: (-[DocumentController loadURL:]):
  • SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]):
  • SnippetEditor/SnippetController.m: (-[SnippetController _resetViews]):

WebKit:

Reviewed by Trey.

Added the ability to set the top-level frame name via the
WebController initializer. Also made [[controller mainFrame]
frameName] return the true top-level frame name instead of "_top",
since that is already special-cased anywhere it needs to be.

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController init]): Update for change to designated initializer. (-[WebController initWithView:]): New convenience initializer. (-[WebController initWithView:frameName:setName:]): Added ability to set top-level frame name.
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Remove topLevelFrameNAme field. (-[WebController _setTopLevelFrameName:]): Actually set it on the top level frame, no point to keeping it here. (-[WebController _findFrameInThisWindowNamed:]): No more need to special-case top-level frame name.
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:controller:]): call [self _setName:] instead of [_private setName:]
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setName:]): Don't let the name get set to _blank.

WebBrowser:

Reviewed by Trey.

Updated for WebKit API change.

  • BrowserWebController.m: (-[BrowserWebController initWithDocument:request:]):
  • BrowserWindowController.m: (-[BrowserWindowController setUpFavoritesBar]):
  • Debug/SnippetController.m: (-[SnippetController load]):
  • DownloadProgressEntry.m: (-[DownloadProgressEntry reload]):
5:11 PM Changeset in webkit [3748] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Darin

  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]): (-[NSString _web_drawAtPoint:font:textColor:): removed the unnecessary string parameter from these two NSString methods.

WebBrowser:

  • updated all callers to WebKitNSStringExtras methods that I renamed.

Reviewed by Darin

  • BrowserNSStringExtras.m: (-[NSString drawDoubledInRect:withTopColor:bottomColor:font:centered:flipped:]): replace _web_drawString:atPoint:... with _web_drawAtPoint:...
  • DownloadRow.m: (-[DownloadRow bestWidth]): replace _web_widthOfString:font:... with _web_widthWithFont:...
  • TabBarView.m: (-[TabBarView _leftTruncateWordsFrom:withFont:width:maxWordsToRemove:]): ditto
  • TabButton.m: (-[TabButton _updateCellAttributes]): ditto
4:56 PM Changeset in webkit [3747] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • got rid of some framework initialization (working on bug 3185161)
  • WebView.subproj/WebPreferences.m: (-[WebPreferences _postPreferencesChangesNotification]): Moved this function up. (+[WebPreferences standardPreferences]): Call _postPreferencesChangesNotification when this is made, for consistency with the old behavior. (+[WebPreferences initialize]): Changed to initialize from load, and got rid of stuff we don't want to do from inside an initialize function.
4:42 PM Changeset in webkit [3746] by darin
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

  • got rid of some framework initialization (working on bug 3188781)
  • khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor): Put some waitCursor use inside #if !APPLE_CHANGES. (KHTMLPart::reparseConfiguration): Put some waitCursor use inside #if !APPLE_CHANGES.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): Use KCursor cursors instead of Qt cursors.
  • kwq/KWQNamespace.h: Remove Qt cursors.
  • kwq/KWQCursor.mm: Remove Qt cursors.
  • kwq/KWQKCursor.h: Remove waitCursor.
  • kwq/KWQKCursor.mm: Remove waitCursor.
4:41 PM Changeset in webkit [3745] by darin
  • 9 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • got rid of some framework initialization (working on bug 2959353)
  • kjs/identifier.h: Turn Identifier:null into Identifier:null().
  • kjs/identifier.cpp: Removed Identifier:null and added Identifier:null().
  • kjs/internal.cpp: Made NaN_Bytes and Inf_Bytes const.
  • kjs/completion.h: Use Identifier:null() instead of Identifier:null.
  • kjs/function.h: Ditto.
  • kjs/function_object.cpp: (FunctionObjectImp::construct): Ditto.
  • kjs/nodes.cpp: (FuncExprNode::evaluate): Use Identifier:null() instead of Identifier:null.
4:37 PM Changeset in webkit [3744] by sheridan
  • 3 edits in trunk

forgot to update to version 65u after the build of Safari-64

3:45 PM Changeset in webkit [3743] by darin
  • 8 edits in trunk/WebCore

Reviewed by John.

  • fixed build rules for parser.cpp so we don't rebuild it every time
  • khtml/css/Makefile.am: Changed target to parser.cpp, not parser.
  • some QColor cleanup
  • kwq/KWQColor.h: Removed the qRgba function, the unused KWQColor constructor that takes a QString parameter, and made the KWQColor constructor that takes a const char * parameter explicit.
  • kwq/KWQColor.mm: (QColor::QColor): Use findColor directly so we don't create and then destroy a QString. (QColor::setNamedColor): Eliminated the unnecessary special case for empty string. Get rid of the call to lower(), which is now handled by the caller. Got rid of the "can't decipher this color" ERROR, which makes little sense now that non-named colors (like hex ones) are handled at the KHTML level. Don't use setRgb to set the color, since the RGB value in the gperf table is already in the correct format to just be stored in QColor::color.
  • khtml/misc/helper.h: Removed now-unused setNamedColor function. I'm sure this same change exists on the KHTML trunk (since the CSS parser rewrite).
  • khtml/misc/helper.cpp: More of the same.
  • khtml/misc/loader.cpp: #if !APPLE_CHANGES the places that use qRgba to set bgColor, which we don't use anyway.
12:38 PM Changeset in webkit [3742] by rjw
  • 3 edits in trunk/WebKit

Remove initWithURL: and frameName from WebDataSource public API.

Reviewed by trey.

  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource webFrame]):
9:40 AM Changeset in webkit [3741] by darin
  • 3 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
  • English.lproj/Localizable.strings: Regenerated.
12:40 AM Changeset in webkit [3740] by rjw
  • 41 edits
    10 adds
    2 deletes in trunk/WebKit

WebKit:

Switch all WebController's delegate to use informal protocols.

Reviewed by trey.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView status:]):
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge showWindow]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge setStatusText:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge setWebFrame:]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resourceLoadDelegate]): (-[WebBaseResourceHandleDelegate downloadDelegate]): (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]): (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]):
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setWindowOperationsDelegate:]): (-[WebController windowOperationsDelegate]): (-[WebController setResourceLoadDelegate:]): (-[WebController resourceLoadDelegate]): (-[WebController setDownloadDelegate:]): (-[WebController downloadDelegate]): (-[WebController setContextMenuDelegate:]): (-[WebController contextMenuDelegate]): (-[WebController setPolicyDelegate:]): (-[WebController policyDelegate]): (-[WebController setLocationChangeDelegate:]): (-[WebController locationChangeDelegate]): (-[WebController stringByEvaluatingJavaScriptFromString:]):
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:behind:]): (-[WebController _menuForElement:]): (-[WebController _mouseDidMoveOverElement:modifierFlags:]): (-[WebController _locationChangeDelegateForwarder]): (-[WebController _resourceLoadDelegateForwarder]): (-[WebController _policyDelegateForwarder]): (-[WebController _contextMenuDelegateForwarder]): (-[WebController _windowOperationsDelegateForwarder]): (-[_WebSafeForwarder initWithTarget:defaultTarget:templateClass:]): (-[_WebSafeForwarder forwardInvocation:]): (-[_WebSafeForwarder methodSignatureForSelector:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (+[WebDefaultContextMenuDelegate sharedContextMenuDelegate]):
  • WebView.subproj/WebDefaultLocationChangeDelegate.h: Added.
  • WebView.subproj/WebDefaultLocationChangeDelegate.m: Added. (+[WebDefaultLocationChangeDelegate sharedLocationChangeDelegate]): (-[WebDefaultLocationChangeDelegate locationChangeStartedForDataSource:]): (-[WebDefaultLocationChangeDelegate serverRedirectedForDataSource:]): (-[WebDefaultLocationChangeDelegate locationChangeCommittedForDataSource:]): (-[WebDefaultLocationChangeDelegate receivedPageTitle:forDataSource:]): (-[WebDefaultLocationChangeDelegate receivedPageIcon:forDataSource:]): (-[WebDefaultLocationChangeDelegate locationChangeDone:forDataSource:]): (-[WebDefaultLocationChangeDelegate willCloseLocationForDataSource:]): (-[WebDefaultLocationChangeDelegate locationChangedWithinPageForDataSource:]): (-[WebDefaultLocationChangeDelegate clientWillRedirectTo:delay:fireDate:forFrame:]): (-[WebDefaultLocationChangeDelegate clientRedirectCancelledForFrame:]):
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate sharedPolicyDelegate]):
  • WebView.subproj/WebDefaultPolicyDelegatePrivate.h: Removed.
  • WebView.subproj/WebDefaultResourceLoadDelegate.h: Added.
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: Added. (+[WebDefaultResourceLoadDelegate sharedResourceLoadDelegate]): (-[WebDefaultResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didReceiveResponse:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didReceiveContentLength:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]): (-[WebDefaultResourceLoadDelegate pluginFailedWithError:dataSource:]):
  • WebView.subproj/WebDefaultWindowOperationsDelegate.h: Added.
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m: Added. (+[WebDefaultWindowOperationsDelegate sharedWindowOperationsDelegate]): (-[WebDefaultWindowOperationsDelegate runJavaScriptConfirmPanelWithMessage:]): (-[WebDefaultWindowOperationsDelegate runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[WebDefaultWindowOperationsDelegate runOpenPanelForFileButtonWithResultListener:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:controller:]): (-[WebFrame findOrCreateFrameNamed:]):
  • WebView.subproj/WebFramePrivate.m: (if): (switch):
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebLocationChangeDelegate.m: Removed.
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]):
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Switch all WebController's delegate to use informal protocols.

Reviewed by trey.

  • BrowserWebController.h:
  • Debug/SnippetController.h:
  • Debug/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController load]): (-[SnippetController locationChangeDone:forDataSource:]):
  • LoadProgressMonitor.h:
  • LocationChangeHandler.h:

Tests:

Switch all WebController's delegate to use informal protocols.

Reviewed by trey.

  • DumpBackForward/main.m:
  • DumpRenderTree/main.m:
  • Makefile.am:
  • SimpleViewer/DocumentController.h:
  • SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController updateStatus]): (-[DocumentController locationChangeStartedForDataSource:]): (-[DocumentController receivedPageTitle:forDataSource:]): (-[DocumentController locationChangeDone:forDataSource:]): (-[DocumentController identifierForInitialRequest:fromDataSource:]): (-[DocumentController resource:willSendRequest:fromDataSource:]):
  • SnippetEditor/DataResourceRequest.m: (+[DataProtocolHandler canHandleURL:]): (-[DataProtocolHandler startLoadingWithCacheObject:]):
  • SnippetEditor/SnippetController.h:
  • SnippetEditor/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController _resetViews]): (-[SnippetController locationChangeDone:forDataSource:]):

Mar 3, 2003:

10:50 PM Changeset in webkit [3739] by darin
  • 5 edits in trunk/WebKit

WebKit:

Reviewed by Richard.

  • simplified the custom user agent and text encoding methods as per request from documentation group
  • WebView.subproj/WebController.h: Removed hasCustomUserAgent, resetUserAgent, hasCustomTextEncoding, and resetTextEncoding. Updated comments to indicate what nil means.
  • WebView.subproj/WebController.m: (-[WebController setCustomUserAgent:]): Remove assertion, allow nil. (-[WebController customUserAgent]): Remove nil check. (-[WebController setCustomTextEncodingName:]): Remove assertion, allow nil, and do an == check along with the isEqualToString: check to handle the nil case. (-[WebController customTextEncodingName]): Remove nil check.

WebBrowser:

Reviewed by Richard.

  • updated for WebKit API changes
  • BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Use customTextEncodingName of nil to detect lack of custom text encoding, rather than hasCustomTextEncoding. (-[BrowserWindowController changeTextEncoding:]): Use setCustomTextEncodingName:nil to reset custom text encoding rather than resetTextEncoding.
  • Debug/DebugUtilities.m: (-[BrowserDocument setUserAgent:]): Just use isEqualToString: with the user agent as the responder because it now returns nil when there is none. (-[BrowserDocument validate_setUserAgent:]): Ditto. (-[BrowserDocument resetUserAgent:]): Use customUserAgent instead of hasCustomUserAgent, and use setCustomUserAgent:nil instead of resetUserAgent. (-[BrowserDocument validate_resetUserAgent:]): More of the same.
6:09 PM Changeset in webkit [3738] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Richard.

  • upgrade to new hash function in one spot that I missed:
  • kwq/KWQString.mm: (QString::hash): Use spiffy new hash algorithm.
5:29 PM Changeset in webkit [3737] by mjs
  • 19 edits in trunk

WebCore:

Reviewed by Darin.

  • fixed 3163855 - Need control over certain potential dialogs/sheets
  • khtml/rendering/render_form.cpp: (RenderFileButton::RenderFileButton): Pass the part to KWQFileButton.
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Go through the bridge for the view, not the view factory.
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::runJavaScriptAlert): Go through the bridge for the panel, not the view factory. (KWQKHTMLPart::runJavaScriptConfirm): Likewise. (KWQKHTMLPart::runJavaScriptPrompt): Likewise.
  • kwq/WebCoreViewFactory.h: Move methods from here...
  • kwq/WebCoreBridge.h: ...to here.

WebKit:

Reviewed by Darin.

  • fixed 3163855 - Need control over certain potential dialogs/sheets
  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge runJavaScriptAlertPanelWithMessage:]): Moved here from view factory. Call the bridge instead of popping up the dialog. (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): Likewise. (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): Likewise. (-[WebBridge fileButton]): Moved here from view factory, so we can pass the bridge to the button. (-[WebBridge runOpenPanelForFileButtonWithResultListener:]): Call the delegate.
  • WebCoreSupport.subproj/WebFileButton.h:
  • WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton initWithBridge:]): New method so this object knows about the bridge. (-[WebFileButton beginSheet]): Instead of popping up the sheet directly, call the bridge (which will call the delegate). (-[WebFileButton chooseFilename:]): Update for the new filename. (-[WebFileButton cancel]): Do nothing.
  • WebCoreSupport.subproj/WebViewFactory.m: Removed some methods.
  • WebKit.exp: Export .objc_class_WebJavaScriptTextInputPanel (for now).
  • WebKit.pbproj/project.pbxproj: Export WebJavaScriptTextInputPanel.h (for now).
  • WebView.subproj/WebWindowOperationsDelegate.h: Added new methods.

WebBrowser:

Reviewed by Darin.

Implemented new window delegate methods. Moving the code here is
temporary until we make the window operations delegate an informal
protocol or else provide a default implementation to subclass.

  • BrowserWebController.m: (-[BrowserWebController setResizable:]): (-[BrowserWebController runJavaScriptAlertPanelWithMessage:]): (-[BrowserWebController runJavaScriptConfirmPanelWithMessage:]): (-[BrowserWebController runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[BrowserWebController runOpenPanelForFileButtonWithResultListener:]): (-[BrowserWebController openPanelDidEnd:returnCode:contextInfo:]):
5:13 PM Changeset in webkit [3736] by mjs
  • 7 edits in trunk

JavaScriptCore:

Reviewed by Trey.

  • fixed 3158833 - ebay prefs page is so slow, it seems like a hang.

92% speed improvement on ebay prefs page.
1% speed improvement on js-ibench and js-performance plt suites.

There were a couple of problems with the identifier hash table that
I fixed:

  • kjs/identifier.cpp: (void Identifier::remove): Adjust the shrink threshold to avoid constantly growing and shrinking.
  • kjs/ustring.cpp: (UString::Rep::computeHash): Use a better hash function that avoids collisions for obvious data sets.

WebFoundation:

Reviewed by Trey.

Updated string hash function to match the new, improved one in
JavaScriptCore.

  • Database.subproj/WebLRUFileList.m: (cStringHash):

WebCore:

Reviewed by Trey.

Updated string hash function to match the new, improved one in
JavaScriptCore.

  • kwq/KWQCharsets.mm: (encodingNameHash):
4:46 PM Changeset in webkit [3735] by darin
  • 6 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3187518 -- REGRESSION: w3c css sample page crashes in cssyyparse
  • khtml/css/parser.y: (selector): Added code to handle the case where simple_selector is 0.
  • khtml/css/parser.cpp: Regenerated.
  • fixed regression I introduced earlier today where ID anchors wouldn't work
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): Check by ID first explicitly before using DOC_ANCHORS.
  • WebCore.pbproj/project.pbxproj: Add parser.y to the project to make it easier to open it.
4:39 PM Changeset in webkit [3734] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3185852, crash when dynamically inserting rules because
of an unitialized parser variable.

Reviewed by darin

  • khtml/css/css_ruleimpl.cpp: (CSSMediaRuleImpl::insertRule):
  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::insertRule):
  • khtml/css/cssparser.cpp: (CSSParser::parseRule):
  • khtml/css/cssparser.h:
4:13 PM Changeset in webkit [3733] by hyatt
  • 3 edits in trunk/WebCore

Clean up dynamic ID/CLASS setting/removal. Make ID actually
work when set dynamically. Fixes bug 3173050.

Reviewed by john

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute):
4:09 PM Changeset in webkit [3732] by darin
  • 5 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3154394 -- non-repro nil-dereference in DOM::HTMLFormElementImpl::submit
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submit): Add checks for nil like the other methods in this file have.
  • fixed some types to remove a bit of unnecessary overhead
  • khtml/ecma/kjs_window.h: Change types.
  • khtml/ecma/kjs_window.cpp: (Window::installTimeout): Change parameter to UString, not Identifier. (WindowFunc::tryCall): Pass the UString, not Identifier. (ScheduledAction::ScheduledAction): Change parameter to use const QString & to avoid a bit of overhead. (WindowQObject::installTimeout): Change parameter to UString, not Identifier.
3:15 PM Changeset in webkit [3731] by hyatt
  • 3 edits in trunk/WebCore

I messed up when i merged Lars' quirks color patch for CSS with
my original patch. I'm now exactly matching Lars' patch, and this
now fixes bug 3181185.

Reviewed by darin

  • khtml/css/cssparser.cpp: (CSSParser::parseColor):
2:47 PM Changeset in webkit [3730] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3179084. Fix is to just dump our code so that the new
addHTMLColor code kicks in. This code is very close to WinIE
on more-colortests.html.

Reviewed by darin

  • ChangeLog:
  • kwq/KWQColor.mm: (QColor::setNamedColor):
12:24 PM Changeset in webkit [3729] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3178361, <th> don't draw borders. Boneheaded mistake
on my part. Just forgot to include it along with <td> in the
CSS hack for sharing cell rules.

Reviewed by rjw

  • khtml/css/cssstyleselector.cpp:
11:56 AM Changeset in webkit [3728] by rjw
  • 4 edits in trunk/WebKit

Reviewed by Chris & Darin.

Fixed frameRequiredForMIMEType: to correctly check for BOTH
netscape plugins and cocoa plugins.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:]):

Made WebPluginViewFactory.h private (SPI) to provide access to
plugin package keys.

  • WebKit.pbproj/project.pbxproj:
11:54 AM Changeset in webkit [3727] by rjw
  • 3 edits in trunk/WebCore

Fix build oops from last checkin to khtml/html/html_formimpl.cpp.

Reviewed by trey

  • khtml/html/html_formimpl.cpp: (encodeCString):
11:31 AM Changeset in webkit [3726] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3183445 -- hang in QCString::length reloading page with lots of text in textarea
  • khtml/html/html_formimpl.cpp: (encodeCString): Compute string length only once outside the loop to avoid being O(n2) in the size of the string.
10:28 AM Changeset in webkit [3725] by darin
  • 3 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3180364 -- infinite loop in JavaScript at www.vw.dk (due to document.anchors problem) leads to hang

The underlying problem was that our document.anchors had all the anchors in it.
But here's what the Gecko DOM reference documentation says about document.anchors:
"For reasons of backwards compatibility, the returned set of anchors only contains
those anchors created with the name attribute, not those created with the id attribute."

  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::calcLength): Include only A elements with NAME attributes in the DOC_ANCHORS case. (HTMLCollectionImpl::getItem): Ditto. (HTMLCollectionImpl::getNamedItem): Ditto.

Mar 2, 2003:

10:48 PM Changeset in webkit [3724] by trey
  • 3 edits in trunk/WebCore

Use a KWQPopUpButton in place of NSPopUpButton. The only addition is that
it implements the KWQWidgetHolder protocol. This is needed in order to
auto set PopUps during autofill.

Reviewed by Maciej.

  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Make a KWQPopUpButton instead of NSPopUpButton. (QComboBox::~QComboBox): trivial s/KWQPopUpButton/NSPopUpButton/ (QComboBox::insertItem): ditto (QComboBox::sizeHint): ditto (QComboBox::baselinePosition): ditto (QComboBox::clear): ditto (QComboBox::setCurrentItem): ditto (QComboBox::currentItem): ditto (-[KWQPopUpButtonCell widget]): Also implement KWQWidgetHolder (-[KWQPopUpButton widget]): Implement KWQWidgetHolder by calling our cell.
Note: See TracTimeline for information about the timeline view.