Timeline



Mar 8, 2003:

2:58 AM Changeset in webkit [3788] by hyatt
  • 1 edit in trunk/WebCore/khtml/css/cssstyleselector.cpp

* empty log message *

2:55 AM Changeset in webkit [3787] by hyatt
  • 3 edits in trunk/WebCore

Check in the patch I actually meant to land. Somehow what I landed
had removed a line that was supposed to be there.

  • khtml/css/cssstyleselector.cpp:

Mar 7, 2003:

8:02 PM Changeset in webkit [3786] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Trey.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Fix form submission (was completely broken).
6:19 PM Changeset in webkit [3785] by mjs
  • 24 edits in trunk

WebCore:

Reviewed by Richard.

  • fixed 3127705 - don't open new window on opt-click even if the link requests it
  • fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Don't use findOrCreateFrameNamed, instead pass target along. (KWQKHTMLPart::openURLRequest): Likewise. (KWQKHTMLPart::submitForm): Likewise. (KWQKHTMLPart::urlSelected): Likewise.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Likewise.
  • kwq/WebCoreBridge.h:

WebKit:

Reviewed by Richard.

  • fixed 3127705 - don't open new window on opt-click even if the link requests it
  • fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)
  • removed open new window and open new window behind policies
  • removed [WebFrame findOrCreateFrameNamed:] from API
  • remved showWindowBehind from window operations delegate
  • added decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener: delegate method
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebPluginRequest initWithRequest:frameName:notifyData:]): (-[WebPluginRequest dealloc]): (-[WebPluginRequest frameName]):
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:target:triggeringEvent:form:formValues:]): (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[NSObject performSelector:withObject:withObject:withObject:]):
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Reviewed by Richard.

  • fixed 3127705 - don't open new window on opt-click even if the link requests it
  • fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)
  • updated for various WebKit API changes.
  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument initWithContentsOfRequest:frameName:]): (-[BrowserDocument init]): (-[BrowserDocument initWithContentsOfURL:ofType:]): (-[BrowserDocument createWebController]):
  • BrowserDocumentController.h:
  • BrowserDocumentController.m: (-[BrowserDocumentController _openDocumentWithContentsOfRequest:behind:display:frameName:]): (-[BrowserDocumentController openDocumentWithContentsOfRequest:behind:display:]): (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]): (-[BrowserDocumentController openDocument:]): (-[BrowserDocumentController goToRequest:windowPolicy:frameName:]): (-[BrowserDocumentController goToRequest:windowPolicy:]):
  • BrowserWebController.h:
  • BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]): (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
6:16 PM Changeset in webkit [3784] by hyatt
  • 4 edits in trunk/WebCore

better fix for text-decoration issue on time.com.

Reviewed by mjs

  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/render_style.h:
6:02 PM Changeset in webkit [3783] by cblu
  • 2 edits in trunk/WebKit

Updated header doc comments.

  • Downloads.subproj/WebDownload.h:
4:04 PM Changeset in webkit [3782] by hyatt
  • 3 edits in trunk/WebCore

Fix for time.com regression. Don't allow text-decoration to
apply to anchor elements with no href.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp:
3:14 PM Changeset in webkit [3781] by hyatt
  • 3 edits in trunk/WebCore

Whoops. Fix regression causedb y previous checkin.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp:
3:10 PM Changeset in webkit [3780] by rjw
  • 11 edits in trunk/WebKit

WebKit:

Drop mainDocumentError from WebDataSource.
Combine registerView: and registerRepresentation: into one method on WebFrame.

Reviewed by trey.

  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _mainDocumentError]):
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (+[WebFrame registerViewClass:representationClass:forMIMEType:]):
  • WebView.subproj/WebFramePrivate.m: (switch):
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m:

Tests:

Drop mainDocumentError from WebDataSource.
Combine registerView: and registerRepresentation: into one method on WebFrame.

Reviewed by trey.

  • PDFViewer/ApplicationController.m: (-[ApplicationController awakeFromNib]):
2:58 PM Changeset in webkit [3779] by hyatt
  • 3 edits in trunk/WebCore

Make the :hover:active behavior much more sophisticated
(and make it match WinIE, since that buggy browser is what
necessitates this hack).

Reviewed by darin

  • khtml/css/cssstyleselector.cpp:
2:58 PM Changeset in webkit [3778] by sullivan
  • 6 edits in trunk/WebKit

WebKit:

WebKit part of fixes to these two synching-related bugs:

3190844 -- Bookmarks Bar and Menu collections need to be
marked specially in Bookmarks file

3192197 -- Safari should write out UUID-full Bookmarks
file after reading UUID-free one

Reviewed by Trey

  • Bookmarks.subproj/WebBookmark.h:
  • Bookmarks.subproj/WebBookmark.m: (-[WebBookmark setUUID:]): Removed the leading underscore, made this method public. Removed unnecessary constraint that new or old UUID had to be nil; now short-circuits the no-change case. (-[WebBookmark copyWithZone:]): updated for name change (-[WebBookmark initFromDictionaryRepresentation:withGroup:]): ditto
  • Bookmarks.subproj/WebBookmarkGroup.h:
  • Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup bookmarkForUUID:]): new public method to find a bookmark from a UUID. (-[WebBookmarkGroup _addBookmark:]): updated for name change
  • Bookmarks.subproj/WebBookmarkPrivate.h: removed declaration for old _setUUID

WebBrowser:

WebBrowser part of fixes to these two synching-related bugs:

3190844 -- Bookmarks Bar and Menu collections need to be
marked specially in Bookmarks file

3192197 -- Safari should write out UUID-full Bookmarks
file after reading UUID-free one

Reviewed by Trey

  • BookmarksController.m: (-[BookmarksController bookmark:isFolderTitled:]): new convenience method (-[BookmarksController findOrCreateBookmarkSourceTitled:withUUID:index:]): new method, replaces old code to bless the Bookmarks Bar and Bookmarks Menu folders. Now sets the new well-known UUID for these folders, and ensures that the bookmarks file will be saved if the UUIDs were not there previously. I also removed some of the old backward-compatibility-to-ancient- prelease-version hacks. (-[BookmarksController updateBookmarkSources]): reworked to call new methods
  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt: Kept these up to date
11:48 AM Changeset in webkit [3777] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed regression caused when we made the stopLoading method on WebDataSource private
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _recursiveStopLoading]): The children are frames, so we need to do stopLoading, not _stopLoading.
11:20 AM Changeset in webkit [3776] by cblu
  • 14 edits in trunk/WebKit

WebKit:

Fixed: 3191052 - Predetermined downloads should not be started from the browser window

  • Stripped the rest of WebKit of download related code.

Reviewed by trey.

  • Downloads.subproj/WebDownload.h: Changed the download delegate method from download:didStartFromDataSource: download:didStartFromRequest:. Passing the data source wasn't that helpful. It was also quirky that the data source would sometimes be nil.
  • Downloads.subproj/WebDownload.m: (-[WebDownloadPrivate dealloc]): release directory path (-[WebDownload _initWithLoadingResource:dataSource:]): call _loadStarted and _loadEnded (-[WebDownload loadWithDelegate:]): call _loadStarted (-[WebDownload _loadStarted]): set flag, retain self (-[WebDownload _loadEnded]): set flag, release self (-[WebDownload resource:willSendRequest:]): call _loadEnded if the returned request is nil (-[WebDownload resourceDidFinishLoading:]): call _loadEnded (-[WebDownload resource:didFailLoadingWithError:]): call _loadEnded (-[WebDownload _createFileIfNecessary]): handle a predetermined download directory, not path (-[WebDownload _cancelWithError:]): call _loadEnded (-[WebDownload _setDirectoryPath:]): new private method
  • Downloads.subproj/WebDownloadPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:fromDataSource:complete:]): don't call [dataSource isDownloading] (-[WebController _downloadURL:toDirectory:]): create and start a self retained WebDownload
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: removed download related methods
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: removed download related methods (-[WebDataSource _commitIfReady:]): don't call isDownloading
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): when handing off the load to the download, don't deal with the download path (-[WebMainResourceClient resource:didReceiveResponse:]): no more predetermined downloads come through here

WebBrowser:

Fixed: 3142376 - would be better if queued downloads showed up in downloads window

  • Handle WebKit started downloads that don't have associated data sources.
  • Don't use removed WebKit download API's.
  • Handle HTTP errors in responses instead of downloading html error files.
  • Don't update progress bar using a timer so it doesn't jerk.

Reviewed by john.

  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]): call downloadMayBeOpenedForRequest (-[BrowserWebController stopLoading]): removed stopNonDownloadingDataSource, don't call it
  • DownloadMonitor.h:
  • DownloadMonitor.m: (-[DownloadMonitor init]): create _openableDownloadRequests (-[DownloadMonitor download:didStartFromRequest:]): fixed leak, create entry with request (-[DownloadMonitor download:didReceiveResponse:]): handle HTTP errors (-[DownloadMonitor downloadMayBeOpenedForRequest:]): renamed
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry setBytesLoaded:]): call progress notification (-[DownloadProgressEntry setBytesExpected:]): call progress notification (-[DownloadProgressEntry bytesExpected]): overridden to avoid superclass quirks
  • DownloadRow.m: (-[DownloadRow initWithDownloadProgressEntry:]): observe DownloadEntryProgressDidChangeNotification (-[DownloadRow _updateProgressAnimation]): handle changes in bytesExpected (-[DownloadRow _startProgressAnimation]): call _updateProgressAnimation, have timer call _updateStatusField (-[DownloadRow _updateStatusField]): handle no bytes received case (-[DownloadRow entryStageDidChange]): tweak (-[DownloadRow entryPathDidChange]): tweak (-[DownloadRow entryProgressDidChange]): call _updateProgressAnimation
  • English.lproj/Localizable.strings: updated

Mar 6, 2003:

11:26 PM Changeset in webkit [3775] by mjs
  • 7 edits in trunk/WebKit

WebKit:

Reviewed by Trey.

Step towards policy API changes. Remove WebPolicyNone,
WebPolicyRevealInFinder, WebPolicyOpenURL and WebPolicyShow.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
  • WebView.subproj/WebFramePrivate.m: (switch):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):

WebBrowser:

Reviewed by Trey.

Updated for WebKit API changes. Handle removed convenience
policies internally.

  • BrowserWebController.m: (-[BrowserWebController unableToImplementPolicyWithError:inFrame:]): (-[BrowserWebController openFileExternallyWithRequest:inFrame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): (-[BrowserWebController revealInFinderWithRequest:inFrame:]): (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]): (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
7:45 PM Changeset in webkit [3774] by rjw
  • 3 edits in trunk/WebKit

Remove setWebView: from WebFrame.

Reviewed by chris.

  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:controller:]): (-[WebFrame name]):
7:30 PM Changeset in webkit [3773] by rjw
  • 14 edits in trunk/WebKit

WebKit:

API changes. WebCapabilities -> WebContentTypes.
Move fileExtension from WebDataSource to WebContentTypes

Reviewed by chris.

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
  • WebKit.exp:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (+[WebContentTypes suggestedFileExtensionForMIMEType:]): (-[WebController supportsTextEncoding]): (-[WebController setCustomTextEncodingName:]): (-[WebController _mainFrameOverrideEncoding]): (-[WebController customTextEncodingName]): (-[WebController stringByEvaluatingJavaScriptFromString:]): (-[WebController userAgentForURL:]):
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):

WebBrowser:

API changes. WebCapabilities -> WebContentTypes.
Move fileExtension from WebDataSource to WebContentTypes

Reviewed by chris.

  • BrowserDocument.m: (-[BrowserDocument fileType]):
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]):
6:37 PM Changeset in webkit [3772] by cblu
  • 21 edits in trunk/WebKit

WebFoundation:

Reviewed by trey.

Added _web_changeFileAttributes:atPath and factored _web_changeFinderAttributes out to its own method.

  • Misc.subproj/WebNSFileManagerExtras.h:
  • Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_changeFinderAttributes:forFileAtPath:]): was _web_createFileAtPath (-[NSFileManager _web_changeFileAttributes:atPath:]): call createFileAtPath, then _web_changeFinderAttributes (-[NSFileManager _web_createFileAtPath:contents:attributes:]): call changeFileAttributes, then _web_changeFinderAttributes

WebKit:

Implemented WebDownload API.

Fixed: 3118355 - Download mechanism that doesn't involve WebDataSource, WebFrame, WebController etc
Fixed: 3110173 - add per-request disabling of download decoding, use to turn off when "Open Safe Files" is off

Reviewed by trey, rjw, mjs.

  • Downloads.subproj/WebDownload.h: Tweaked comments, added new methods.
  • Downloads.subproj/WebDownload.m: (-[WebDownloadPrivate dealloc]): release new objects (-[WebDownload initWithRequest:]): was initWithRequest:delegate:, but found that starting the load from the init method made it tricky to do other set up work before the load started. (-[WebDownload _initWithLoadingResource:dataSource:]): private init method, "catches up" to load by sending delegate method immediately, doesn't retain the dataSource, uses it for info (-[WebDownload loadWithDelegate:]): new, starts load (-[WebDownload cancel]): cancel load with no error (-[WebDownload path]): simple getter (-[WebDownload setPath:]): implement this because WebDownload is the WebDownloadDecisionListener, call _setPath (-[WebDownload resource:willSendRequest:]): resource delegate method (-[WebDownload resource:didReceiveResponse:]): resource delegate method (-[WebDownload resource:didReceiveData:]): resource delegate method, decode and write data, cancel load if error (-[WebDownload resourceDidFinishLoading:]): resource delegate method, decode and write data if necessary, end in error if error (-[WebDownload resource:didFailLoadingWithError:]): resource delegate method, end in error (-[WebDownload _pathWithUniqueFilenameForPath:]): this work was done in _createFileIfNecessary, does what it says (-[WebDownload _createFSRefForPath:]): this work was done in _createFileIfNecessary as well, makes fileRefPtr point to a file (-[WebDownload _createFileIfNecessary]): creates file, creates temp file if path hasn't been set yet (-[WebDownload _decodeHeaderData:dataForkData:resourceForkData:]): call private method (-[WebDownload _decodeData:dataForkData:resourceForkData:]): made private, if the download is encoded, ask client if OK to decode (-[WebDownload _decodeData:]): hardly changed, don't cancel, just return error (-[WebDownload _dataIfDoneBufferingData:]): moved, not changed (-[WebDownload _finishDecoding]): hardly changed, don't cancel, just return error (-[WebDownload _writeForkData:isDataFork:]): moved, not changed (-[WebDownload _writeDataForkData:resourceForkData:]): moved, not changed (-[WebDownload _isFileClosed]): new (-[WebDownload _fileDidClose:]): new, called by the callback thread, delete file if deleteFile flag is set, report error or end successfully (-[WebDownload _closeForkAsync:]): new (-[WebDownload _closeForkSync:]): new (-[WebDownload _closeFileAsync]): new (-[WebDownload _closeFileSync]): new (-[WebDownload _deleteFileAsnyc]): new (-[WebDownload _closeAndDeleteFileAsync]): new (-[WebDownload _cancelWithError:]): kill load if there is one, report error if there is one, close and delete file is not already closed or deleted (-[WebDownload _cancelWithErrorCode:]): internal convenienve, calls _cancelWithError (-[WebDownload _setPath:]): set path, if we are already saving data to a temp path, move the file and continue downloading (-[WebDownload _currentPath]): new (-[WebDownload _errorWithCode:]): new (-[WebDownload _dataForkReferenceNumber]): added underscore (-[WebDownload _setDataForkReferenceNumber:]): added underscore (-[WebDownload _resourceForkReferenceNumber]): added underscore (-[WebDownload _setResourceForkReferenceNumber:]): added underscore (-[WebDownload _areWritesCancelled]): added underscore (-[WebDownload _setWritesCancelled:]): added underscore (-[WebDownload _encounteredCloseError]): new (-[WebDownload _setEncounteredCloseError:]): new (WriteCompletionCallback): call underscored methods (CloseCompletionCallback): call underscored methods, handle close error, don't delete file (DeleteCompletionCallback): call _currentPath
  • Downloads.subproj/WebDownloadPrivate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.h: renamed handle to resource
  • WebView.subproj/WebBaseResourceHandleDelegate.m: renamed handle to resource (-[WebBaseResourceHandleDelegate _releaseResources]): renamed handle to resource (-[WebBaseResourceHandleDelegate startLoading:]): renamed handle to resource (-[WebBaseResourceHandleDelegate loadWithRequest:]): renamed handle to resource (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): renamed handle to resource (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): renamed handle to resource (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): renamed handle to resource, don't handle downloads (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): renamed handle to resource, don't handle downloads (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): renamed handle to resource, don't handle downloads (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): renamed handle to resource, don't handle downloads (-[WebBaseResourceHandleDelegate cancelWithError:]): renamed handle to resource, don't handle downloads
  • WebView.subproj/WebController.h: updated comments
  • WebView.subproj/WebController.m: (-[WebController setDownloadDelegate:]): call the ivar downloadDelegate, not downloadProgressDelegate (-[WebController downloadDelegate]): call the ivar downloadDelegate, not downloadProgressDelegate
  • WebView.subproj/WebControllerPolicyDelegate.h: removed saveFilenameForResponse:andRequest:, handle by WebDownload
  • WebView.subproj/WebControllerPrivate.h: call the ivar downloadDelegate, not downloadProgressDelegate
  • WebView.subproj/WebDefaultPolicyDelegate.m: removed saveFilenameForResponse:andRequest:, handle by WebDownload
  • WebView.subproj/WebMainResourceClient.h: added WebResourceDelegateProxy icar
  • WebView.subproj/WebMainResourceClient.m: remove most download related stuff (-[WebMainResourceClient initWithDataSource:]): create a WebResourceDelegateProxy which allows us to change the resource delegate (-[WebMainResourceClient dealloc]): release the proxy (-[WebMainResourceClient receivedError:complete:]): don't handle downloads (-[WebMainResourceClient continueAfterContentPolicy:response:]): pass the load off to the download (-[WebMainResourceClient resource:didReceiveResponse:]): don't handle downloads (-[WebMainResourceClient resource:didReceiveData:]): don't handle downloads (-[WebMainResourceClient resourceDidFinishLoading:]): don't handle downloads (-[WebMainResourceClient resource:didFailLoadingWithError:]): don't handle downloads (-[WebMainResourceClient startLoading:]): make the proxy the delegate (-[WebResourceDelegateProxy setDelegate:]): switches the resource delegate (-[WebResourceDelegateProxy resource:willSendRequest:]): forwards message (-[WebResourceDelegateProxy resource:didReceiveResponse:]): forwards message (-[WebResourceDelegateProxy resource:didReceiveData:]): forwards message (-[WebResourceDelegateProxy resourceDidFinishLoading:]): forwards message (-[WebResourceDelegateProxy resource:didFailLoadingWithError:]): forwards message

WebBrowser:

Made WebBrowser use the WebDownload API. Most of the changes involved switching from a WebDataSource to a WebDownload to represent a download.

Fixed: 3118355 - Download mechanism that doesn't involve WebDataSource, WebFrame, WebController etc
Fixed: 3110173 - add per-request disabling of download decoding, use to turn off when "Open Safe Files" is off

Reviewed by trey.

  • BrowserWebController.m: Removed savePathForResponse:: because it is handled by the WebDownload API
  • BrowserWebErrorExtras.m: Define WebErrorDomainBrowser in here not in DownloadMonitor.
  • DownloadMonitor.h:
  • DownloadMonitor.m: (-[DownloadMonitor _loadDownloadHistory]): call DownloadProgressEntry init method, not class constructor (-[DownloadMonitor init]): (-[DownloadMonitor download:didStartFromDataSource:]): new WebDownload API, reuse a DownloadProgressEntry if reloading, else create a new one (-[DownloadMonitor download:willSendRequest:]): new WebDownload API (-[DownloadMonitor download:didReceiveResponse:]): new WebDownload API (-[DownloadMonitor download:decidePathWithListener:suggestedFilename:]): new WebDownload API, set path immediately (-[DownloadMonitor download:didReceiveDataOfLength:]): new WebDownload API (-[DownloadMonitor downloadShouldDecodeEncodedFile:]): new WebDownload API, return YES if "Open Safe Downloads" is enabled (-[DownloadMonitor download:didCreateFileAtPath:]): new WebDownload API (-[DownloadMonitor downloadDidFinishDownloading:]): new WebDownload API (-[DownloadMonitor download:didFailDownloadingWithError:]): new WebDownload API (-[DownloadMonitor downloadMayBeOpenedForDataSource:]): use renamed dictionary (-[DownloadMonitor setEntry:forReloadingDownload:]):
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry _setDownload:]): new, replaces setDataSource (-[DownloadProgressEntry dealloc]): release the response (-[DownloadProgressEntry setResponse:]): new (-[DownloadProgressEntry response]): new (-[DownloadProgressEntry filename]): handle the nil path case (a DownloadProgressEntry now will be created before the file exists) (-[DownloadProgressEntry setPath:]): added comments (-[DownloadProgressEntry fileExists]): handle the nil path (-[DownloadProgressEntry open]): assert for nil path (-[DownloadProgressEntry stop]): cancel the download (-[DownloadProgressEntry reload]): No need to involve all the WebKit machinery to do a download. Phew! (-[DownloadProgressEntry reveal]): handle the nil path (-[DownloadProgressEntry setDownloadStage:]): don't do anything if the set stage is the same as the current (-[DownloadProgressEntry _openDiskCopyFile]): assert for nil path (-[DownloadProgressEntry _openInstallerPackage]): assert for nil path (-[DownloadProgressEntry autoOpen]): assert for nil path (-[DownloadProgressEntry setDone:]): release and set download to nil (-[NSFileManager _pathForSingleItemAtPath:]): assert for nil path
5:14 PM Changeset in webkit [3771] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3156125, regression on hiptop.com. Caused by better
nowrap handling perversely enough. Need another quirk from
Moz/WinIE to make this site behave.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTableCell::calcMinMaxWidth): (RenderTableCell::setStyle):
4:25 PM Changeset in webkit [3770] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3191027 -- REGRESSION: KWQColor assert at aol.com front page
  • kwq/KWQColor.mm: (qRgb): Clamp to [0,0xFF] instead of asserting.
3:25 PM Changeset in webkit [3769] by rjw
  • 12 edits in trunk/WebKit

Move tweaks to WebKit API.

Removed [WebFrame setController:] from public API.
Removed [WebDataSource stringWithData:] from public API.

Reviewed by hyatt.

  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource mainDocumentError]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stringWithData:]):
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebHTMLRepresentation.m:
  • WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation setDataSource:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView dataSourceUpdated:]):
2:33 PM Changeset in webkit [3768] by rjw
  • 33 edits in trunk/WebKit

WebKit:

Tweaks to WebKit API.
Dropped URL on WebDataSource.
Dropped start/stop loading on WebDataSource.
Drop frameForView and frameForDataSource from WebController.
Moved canShowXX to WebCapabilities.

Reviewed by hyatt.

  • Downloads.subproj/WebDownload.m: (-[WebDownload errorWithCode:]):
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_printViewHierarchy:]):
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView dataSource]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
  • WebKit.exp:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (+[WebCapabilities canShowMIMEType:]): (+[WebCapabilities canShowFile:]): (-[WebController mainFrame]):
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _frameForDataSource:fromFrame:]): (-[WebController _frameForDataSource:]): (-[WebController _frameForView:fromFrame:]): (-[WebController _frameForView:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): (-[WebDataSource _stopLoading]): (-[WebDataSource _stopLoadingInternal]): (-[WebDataSource _recursiveStopLoading]): (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _loadIcon]): (-[WebDataSource _URL]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openFrameInNewWindow:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]):
  • WebView.subproj/WebFramePrivate.m: (if):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frame]): (-[WebHTMLView _elementAtPoint:]):
  • WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation setDataSource:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancel]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient resource:didReceiveData:]): (-[WebMainResourceClient resourceDidFinishLoading:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]):
  • WebView.subproj/WebView.m: (-[WebView webFrame]):
  • WebView.subproj/WebViewPrivate.m: (-[WebView _isMainFrame]):

WebBrowser:

Tweaks to WebKit API.
Dropped URL on WebDataSource.
Dropped start/stop loading on WebDataSource.
Drop frameForView and frameForDataSource from WebController.
Moved canShowXX to WebCapabilities.

Reviewed by hyatt.

  • BrowserDocument.m: (-[BrowserDocument provisionalURL]):
  • BrowserDocumentController.m: (-[BrowserDocumentController openHTMLSourceDocumentWithDataSource:]):
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]): (-[BrowserWebController currentURL]): (-[BrowserWebController stopNonDownloadingDataSource:]):
  • BrowserWebViewExtras.m: (-[WebView largestScrollableWebView]):
  • DownloadProgressEntry.m: (-[DownloadProgressEntry stop]):
  • FormCompletionController.m: (domainFromFrame): (+[AutoFillController autoFillInController:]):
  • FrameProgressEntry.m: (-[FrameProgressEntry URL]):
  • HTMLSourceDocument.m: (-[HTMLSourceDocument fileName]): (-[HTMLSourceDocument displayName]): (-[HTMLSourceDocument browserDocumentLoadingFinished:]):
  • LoadProgressMonitor.m: (-[LoadProgressMonitor _busyStatus]):
2:14 PM Changeset in webkit [3767] by voas
  • 2 edits in trunk/WebKit

2003-03-06 Ed Voas ​voas@apple.com

Reviewed by Richard.

Don't use _HIViewSetNeedsDisplayInRect for now. Fixes
Jaguar builds.

  • Carbon.subproj/HIViewAdapter.m: (-[HIViewAdapter setNeedsDisplay:]): (-[HIViewAdapter setNeedsDisplayInRect:]):
1:52 PM Changeset in webkit [3766] by trey
  • 3 edits in trunk/WebCore

Refinement of routine that scans the DOM for field labels.
We skip nodes that have no renderer, or are invisible.

Reviewed by hyatt.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsBeforeElement): Added check.
1:48 PM Changeset in webkit [3765] by mjs
  • 7 edits in trunk/WebKit

WebKit:

Reviewed by John.

Step towards policy API chantes - removed unneeded policy and URL
arguments from unableToImplementPolicy:

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):

WebBrowser:

Reviewed by John.

Updated for WebKit API change.

  • BrowserWebController.m: (-[BrowserWebController unableToImplementPolicyWithError:inFrame:]): Removed URL and policy arguments.
1:40 PM Changeset in webkit [3764] by voas
  • 3 edits
    14 adds in trunk/WebKit

2003-03-06 Ed Voas ​voas@apple.com

Reviewed by Richard.

First cut of Carbon view support. It will need tweaking as we go,
but I think I finally have all the assertions taken care of, and
I also believe that I have the drawing glitches all sorted out now.

  • Carbon.subproj/CarbonUtils.h: Added.
  • Carbon.subproj/CarbonUtils.m: Added. (InitWebKitForCarbon): (PoolCleaner): (ConvertNSImageToCGImageRef):
  • Carbon.subproj/CarbonWindowAdapter.h: Added.
  • Carbon.subproj/CarbonWindowAdapter.m: Added. (+[CarbonWindowAdapter frameViewClassForStyleMask:]): (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]): (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): (-[CarbonWindowAdapter setViewsNeedDisplay:]): (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]): (-[CarbonWindowAdapter dealloc]): (-[CarbonWindowAdapter windowRef]): (-[CarbonWindowAdapter _hasWindowRef]): (-[CarbonWindowAdapter _managesWindowRef]): (-[CarbonWindowAdapter _removeWindowRef]): (-[CarbonWindowAdapter _carbonWindowClass]): (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]): (-[CarbonWindowAdapter sendSuperEvent:]): (-[CarbonWindowAdapter _cancelKey:]): (-[CarbonWindowAdapter _commonAwake]): (-[CarbonWindowAdapter _destroyRealWindow:]): (-[CarbonWindowAdapter _oldPlaceWindow:]): (-[CarbonWindowAdapter _termWindowIfOwner]): (-[CarbonWindowAdapter _windowMovedToRect:]): (-[CarbonWindowAdapter constrainFrameRect:toScreen:]): (-[CarbonWindowAdapter selectKeyViewFollowingView:]): (-[CarbonWindowAdapter selectKeyViewPrecedingView:]): (-[CarbonWindowAdapter makeKeyWindow]): (-[CarbonWindowAdapter canBecomeKeyWindow]): (-[CarbonWindowAdapter canBecomeMainWindow]): (-[CarbonWindowAdapter encodeWithCoder:]): (-[CarbonWindowAdapter initWithCoder:]): (-[CarbonWindowAdapter setContentView:]): (-[CarbonWindowAdapter worksWhenModal]): (-[CarbonWindowAdapter _setModalWindowLevel]): (-[CarbonWindowAdapter _clearModalWindowLevel]): (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]): (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]): (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]): (-[CarbonWindowAdapter _handleRootBoundsChanged]): (-[CarbonWindowAdapter _handleContentBoundsChanged]): (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]): (NSCarbonWindowHandleEvent):
  • Carbon.subproj/CarbonWindowContentView.h: Added.
  • Carbon.subproj/CarbonWindowContentView.m: Added.
  • Carbon.subproj/CarbonWindowFrame.h: Added.
  • Carbon.subproj/CarbonWindowFrame.m: Added. (+[CarbonWindowFrame frameRectForContentRect:styleMask:]): (+[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (+[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): (-[CarbonWindowFrame frameRectForContentRect:styleMask:]): (-[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (-[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): (-[CarbonWindowFrame initWithFrame:styleMask:owner:]): (-[CarbonWindowFrame dealloc]): (-[CarbonWindowFrame _setFrameNeedsDisplay:]): (-[CarbonWindowFrame _setSheet:]): (-[CarbonWindowFrame _updateButtonState]): (-[CarbonWindowFrame _windowChangedKeyState]): (-[CarbonWindowFrame _showToolbarWithAnimation:]): (-[CarbonWindowFrame _hideToolbarWithAnimation:]): (-[CarbonWindowFrame closeButton]): (-[CarbonWindowFrame styleMask]): (-[CarbonWindowFrame dragRectForFrameRect:]): (-[CarbonWindowFrame isOpaque]): (-[CarbonWindowFrame minimizeButton]): (-[CarbonWindowFrame setTitle:]): (-[CarbonWindowFrame title]): (-[CarbonWindowFrame _sheetHeightAdjustment]): (-[CarbonWindowFrame _maxTitlebarTitleRect]): (-[CarbonWindowFrame _clearDragMargins]): (-[CarbonWindowFrame _resetDragMargins]):
  • Carbon.subproj/HIViewAdapter.h: Added.
  • Carbon.subproj/HIViewAdapter.m: Added. (+[HIViewAdapter bindHIViewToNSView:nsView:]): (+[HIViewAdapter getHIViewForNSView:]): (+[HIViewAdapter unbindNSView:]): (-[HIViewAdapter initWithFrame:view:]): (-[HIViewAdapter hiView]): (-[HIViewAdapter nextValidKeyView]): (-[HIViewAdapter setNeedsDisplay:]): (-[HIViewAdapter setNeedsDisplayInRect:]): (-[CarbonSheetInterceptor _orderFrontRelativeToWindow:]): (-[CarbonSheetInterceptor _orderOutRelativeToWindow:]):
  • Carbon.subproj/HIWebView.h: Added.
  • Carbon.subproj/HIWebView.m: Added. (if): (switch):
  • Carbon.subproj/HIWebViewPriv.h: Added.
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
1:22 PM Changeset in webkit [3763] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3190580, tables should reset line-height and white-space
in quirks mode.

Reviewed by trey and john

  • khtml/css/quirks.css:
11:26 AM Changeset in webkit [3762] by sheridan
  • 3 edits in trunk

starting Safari-66; tree is open

11:23 AM Changeset in webkit [3761]
  • 3 copies in tags/Safari-65

This commit was manufactured by cvs2svn to create tag 'Safari-65'.

11:23 AM Changeset in webkit [3760] by sheridan
  • 8 edits in trunk

Safari-65 stamp

8:46 AM Changeset in webkit [3759] by darin
  • 2 edits in trunk/WebCore

Reviewed by Don.

  • fixed 3177862 -- REGRESSION: can't upload widget at www.konfabulator.com
  • khtml/html/html_formimpl.cpp: (fixUpfromUnicode): Add a call to fixLineBreaks here (and move this down below that function). (HTMLFormElementImpl::formData): Remove the call to fixLineBreaks here, which was being used on non-text form data, like files being uploaded.
8:35 AM Changeset in webkit [3758] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3177862 -- REGRESSION: can't upload widget at www.konfabulator.com
  • khtml/html/html_formimpl.cpp: (fixUpfromUnicode): Add a call to fixLineBreaks here (and move this down below that function). (HTMLFormElementImpl::formData): Remove the call to fixLineBreaks here, which was being used on non-text form data, like files being uploaded.

Mar 5, 2003:

11:29 PM Changeset in webkit [3757] by trey
  • 4 edits in trunk/WebCore

Autofill tweak. In field names, replace all digits with spaces before matching
labels against them. This turns the digits to word boundaries, so field names like
"address2" are matched by "address".

As part of this, I abandoned an earlier attempt to map Qt regexp syntax to Darwin's.
Now clients just have to use Darwin's.

Reviewed by Maciej.

  • kwq/KWQKHTMLPart.mm: (regExpForLabels): (KWQKHTMLPart::matchLabelsAgainstElement): Replace digits with space.
  • kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::compile): Don't try to support Qt syntax.
7:26 PM Changeset in webkit [3756] by rjw
  • 30 edits in trunk/WebKit

WebKit:

API changes
WebView and WebDataSource give up -(WebController *)controller.
WebView gets -(WebFrame *)webFrame.

Reviewed by cblu.

  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView dataSource]):
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient resourceDidFinishLoading:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setDataSource:]):
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController backForwardList]): (-[WebController setUsesBackForwardList:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _controller]): (-[WebDataSource _receivedError:complete:]): (-[WebDataSource _loadIcon]):
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFramePrivate.m: (switch):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _controller]): (-[WebHTMLView _frame]): (-[WebHTMLView _elementAtPoint:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView controller]): (-[WebImageView menuForEvent:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): (-[WebMainResourceClient continueAfterNavigationPolicy:formState:]): (-[WebMainResourceClient resource:willSendRequest:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient resource:didReceiveData:]): (-[WebMainResourceClient resourceDidFinishLoading:]): (-[WebMainResourceClient resource:didFailLoadingWithError:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]):
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView webFrame]): (-[WebView concludeDragOperation:]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _controller]):

WebBrowser:

API changes
WebView and WebDataSource give up -(WebController *)controller.
WebView gets -(WebFrame *)webFrame.

Reviewed by cblu.

  • BrowserTabViewItem.m: (-[BrowserTabViewItem webController]):
  • BrowserWebViewExtras.m: (-[WebView largestScrollableWebView]):
  • BrowserWindowController.m: (-[BrowserWindowController updateLabelForTab:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController findTabForWebController:]): (-[BrowserWindowController tabBarView:menuForClippedTabViewItems:]): (-[BrowserWindowController reloadTab:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController canReloadTab:]): (-[BrowserWindowController canReloadAllTabs]):
  • DownloadProgressEntry.m:
  • LoadProgressMonitor.m: (-[LoadProgressMonitor resource:didReceiveResponse:fromDataSource:]): (-[LoadProgressMonitor resource:didReceiveContentLength:fromDataSource:]):
5:17 PM Changeset in webkit [3755] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • WebView.subproj/WebFramePrivate.m: (_recursiveGoToItem:fromItem:withLoadType:): Account for possibility of nil target.
3:19 PM Changeset in webkit [3754] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • fixed crash when going back due to frame name of nil since we don't force the name "_top" any more.
  • WebView.subproj/WebController.m: (-[WebController _goToItem:withLoadType:]): Handle nil target properly.
8:23 AM Changeset in webkit [3753] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed 3189441 -- REGRESSION: layout tests crash building generated frame name
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _addFramePathToString:]): Handle a frame name of nil here, since we don't force the name "_top" any more.
8:19 AM Changeset in webkit [3752] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3189442 -- REGRESSION: utf-16-little-endian.html crashes making decoder
  • kwq/KWQCharsets.mm: (encodingNameHash): Re-add tolower call to hash function to match the equality function.

Mar 4, 2003:

11:18 PM Changeset in webkit [3751] by trey
  • 11 edits in trunk

WebCore:

New support for autofill. We provide a routine that scans backwards in the text
before a given element, looking for a match with a set of labels. In addition,
we provide for a similar match against the element's name.

To implement a few more methods in QRegExp API were implemented.

Reviewed by Maciej.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (scanForForm): Remove redundant call to a helper function. (regExpForLabels): Return a regexp used to search for the set of labels. (KWQKHTMLPart::searchForLabelsBeforeElement): Walk the DOM to scan backwards in the text before the element, apply regexp to the text we find. (KWQKHTMLPart::matchLabelsAgainstElement): Get the element name, use regexp to check it for any of the labels.
  • kwq/KWQRegExp.h:
  • kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::KWQRegExpPrivate): Init two new ivars. (RegExpFromPattern): Massage a non-glob expression before handing to Darwin. (QRegExp::KWQRegExpPrivate::compile): Call RegExpFromPattern. (QRegExp::match): Set new ivars based on match result. (QRegExp::search): New API, just call match. (QRegExp::searchRev): New API, call match repeatedly to (weakly) simulate a reverse search. (QRegExp::pos): Return info from last result. (QRegExp::matchedLength): Return info from last result.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge searchForLabels:beforeElement:]): Call straight through to part. (-[WebCoreBridge matchLabels:againstElement:]): Call straight through to part.

WebKit:

Support for autofill. These are just two new glue routines
that call down through the bridge. They allow regexp driven
binding of AB data to form elements.

Reviewed by Maciej.

  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Call straight to bridge. (-[WebHTMLRepresentation matchLabels:againstElement:]): Call straight to bridge.
11:14 PM Changeset in webkit [3750] by mjs
  • 2 edits in trunk/WebKit

Reinstate missing part of last checking.

  • WebView.subproj/WebFramePrivate.m:
11:05 PM Changeset in webkit [3749] by mjs
  • 12 edits in trunk/WebKit

Tests:

Reviewed by Trey.

Updated for WebKit API change.

  • DumpBackForward/main.m: (main): (-[CheapWindowOpsDelegate createWindowWithRequest:]):
  • DumpRenderTree/main.m: (main):
  • PDFViewer/DocumentController.m: (-[DocumentController loadURL:]):
  • SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]):
  • SnippetEditor/SnippetController.m: (-[SnippetController _resetViews]):

WebKit:

Reviewed by Trey.

Added the ability to set the top-level frame name via the
WebController initializer. Also made [[controller mainFrame]
frameName] return the true top-level frame name instead of "_top",
since that is already special-cased anywhere it needs to be.

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController init]): Update for change to designated initializer. (-[WebController initWithView:]): New convenience initializer. (-[WebController initWithView:frameName:setName:]): Added ability to set top-level frame name.
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate dealloc]): Remove topLevelFrameNAme field. (-[WebController _setTopLevelFrameName:]): Actually set it on the top level frame, no point to keeping it here. (-[WebController _findFrameInThisWindowNamed:]): No more need to special-case top-level frame name.
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:controller:]): call [self _setName:] instead of [_private setName:]
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setName:]): Don't let the name get set to _blank.

WebBrowser:

Reviewed by Trey.

Updated for WebKit API change.

  • BrowserWebController.m: (-[BrowserWebController initWithDocument:request:]):
  • BrowserWindowController.m: (-[BrowserWindowController setUpFavoritesBar]):
  • Debug/SnippetController.m: (-[SnippetController load]):
  • DownloadProgressEntry.m: (-[DownloadProgressEntry reload]):
5:11 PM Changeset in webkit [3748] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Darin

  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]): (-[NSString _web_drawAtPoint:font:textColor:): removed the unnecessary string parameter from these two NSString methods.

WebBrowser:

  • updated all callers to WebKitNSStringExtras methods that I renamed.

Reviewed by Darin

  • BrowserNSStringExtras.m: (-[NSString drawDoubledInRect:withTopColor:bottomColor:font:centered:flipped:]): replace _web_drawString:atPoint:... with _web_drawAtPoint:...
  • DownloadRow.m: (-[DownloadRow bestWidth]): replace _web_widthOfString:font:... with _web_widthWithFont:...
  • TabBarView.m: (-[TabBarView _leftTruncateWordsFrom:withFont:width:maxWordsToRemove:]): ditto
  • TabButton.m: (-[TabButton _updateCellAttributes]): ditto
4:56 PM Changeset in webkit [3747] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • got rid of some framework initialization (working on bug 3185161)
  • WebView.subproj/WebPreferences.m: (-[WebPreferences _postPreferencesChangesNotification]): Moved this function up. (+[WebPreferences standardPreferences]): Call _postPreferencesChangesNotification when this is made, for consistency with the old behavior. (+[WebPreferences initialize]): Changed to initialize from load, and got rid of stuff we don't want to do from inside an initialize function.
4:42 PM Changeset in webkit [3746] by darin
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

  • got rid of some framework initialization (working on bug 3188781)
  • khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor): Put some waitCursor use inside #if !APPLE_CHANGES. (KHTMLPart::reparseConfiguration): Put some waitCursor use inside #if !APPLE_CHANGES.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): Use KCursor cursors instead of Qt cursors.
  • kwq/KWQNamespace.h: Remove Qt cursors.
  • kwq/KWQCursor.mm: Remove Qt cursors.
  • kwq/KWQKCursor.h: Remove waitCursor.
  • kwq/KWQKCursor.mm: Remove waitCursor.
4:41 PM Changeset in webkit [3745] by darin
  • 9 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • got rid of some framework initialization (working on bug 2959353)
  • kjs/identifier.h: Turn Identifier:null into Identifier:null().
  • kjs/identifier.cpp: Removed Identifier:null and added Identifier:null().
  • kjs/internal.cpp: Made NaN_Bytes and Inf_Bytes const.
  • kjs/completion.h: Use Identifier:null() instead of Identifier:null.
  • kjs/function.h: Ditto.
  • kjs/function_object.cpp: (FunctionObjectImp::construct): Ditto.
  • kjs/nodes.cpp: (FuncExprNode::evaluate): Use Identifier:null() instead of Identifier:null.
4:37 PM Changeset in webkit [3744] by sheridan
  • 3 edits in trunk

forgot to update to version 65u after the build of Safari-64

3:45 PM Changeset in webkit [3743] by darin
  • 8 edits in trunk/WebCore

Reviewed by John.

  • fixed build rules for parser.cpp so we don't rebuild it every time
  • khtml/css/Makefile.am: Changed target to parser.cpp, not parser.
  • some QColor cleanup
  • kwq/KWQColor.h: Removed the qRgba function, the unused KWQColor constructor that takes a QString parameter, and made the KWQColor constructor that takes a const char * parameter explicit.
  • kwq/KWQColor.mm: (QColor::QColor): Use findColor directly so we don't create and then destroy a QString. (QColor::setNamedColor): Eliminated the unnecessary special case for empty string. Get rid of the call to lower(), which is now handled by the caller. Got rid of the "can't decipher this color" ERROR, which makes little sense now that non-named colors (like hex ones) are handled at the KHTML level. Don't use setRgb to set the color, since the RGB value in the gperf table is already in the correct format to just be stored in QColor::color.
  • khtml/misc/helper.h: Removed now-unused setNamedColor function. I'm sure this same change exists on the KHTML trunk (since the CSS parser rewrite).
  • khtml/misc/helper.cpp: More of the same.
  • khtml/misc/loader.cpp: #if !APPLE_CHANGES the places that use qRgba to set bgColor, which we don't use anyway.
12:38 PM Changeset in webkit [3742] by rjw
  • 3 edits in trunk/WebKit

Remove initWithURL: and frameName from WebDataSource public API.

Reviewed by trey.

  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource webFrame]):
9:40 AM Changeset in webkit [3741] by darin
  • 3 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
  • English.lproj/Localizable.strings: Regenerated.
12:40 AM Changeset in webkit [3740] by rjw
  • 41 edits
    10 adds
    2 deletes in trunk/WebKit

WebKit:

Switch all WebController's delegate to use informal protocols.

Reviewed by trey.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView status:]):
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge showWindow]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge setStatusText:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge setWebFrame:]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resourceLoadDelegate]): (-[WebBaseResourceHandleDelegate downloadDelegate]): (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]): (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]):
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setWindowOperationsDelegate:]): (-[WebController windowOperationsDelegate]): (-[WebController setResourceLoadDelegate:]): (-[WebController resourceLoadDelegate]): (-[WebController setDownloadDelegate:]): (-[WebController downloadDelegate]): (-[WebController setContextMenuDelegate:]): (-[WebController contextMenuDelegate]): (-[WebController setPolicyDelegate:]): (-[WebController policyDelegate]): (-[WebController setLocationChangeDelegate:]): (-[WebController locationChangeDelegate]): (-[WebController stringByEvaluatingJavaScriptFromString:]):
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:behind:]): (-[WebController _menuForElement:]): (-[WebController _mouseDidMoveOverElement:modifierFlags:]): (-[WebController _locationChangeDelegateForwarder]): (-[WebController _resourceLoadDelegateForwarder]): (-[WebController _policyDelegateForwarder]): (-[WebController _contextMenuDelegateForwarder]): (-[WebController _windowOperationsDelegateForwarder]): (-[_WebSafeForwarder initWithTarget:defaultTarget:templateClass:]): (-[_WebSafeForwarder forwardInvocation:]): (-[_WebSafeForwarder methodSignatureForSelector:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.h:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (+[WebDefaultContextMenuDelegate sharedContextMenuDelegate]):
  • WebView.subproj/WebDefaultLocationChangeDelegate.h: Added.
  • WebView.subproj/WebDefaultLocationChangeDelegate.m: Added. (+[WebDefaultLocationChangeDelegate sharedLocationChangeDelegate]): (-[WebDefaultLocationChangeDelegate locationChangeStartedForDataSource:]): (-[WebDefaultLocationChangeDelegate serverRedirectedForDataSource:]): (-[WebDefaultLocationChangeDelegate locationChangeCommittedForDataSource:]): (-[WebDefaultLocationChangeDelegate receivedPageTitle:forDataSource:]): (-[WebDefaultLocationChangeDelegate receivedPageIcon:forDataSource:]): (-[WebDefaultLocationChangeDelegate locationChangeDone:forDataSource:]): (-[WebDefaultLocationChangeDelegate willCloseLocationForDataSource:]): (-[WebDefaultLocationChangeDelegate locationChangedWithinPageForDataSource:]): (-[WebDefaultLocationChangeDelegate clientWillRedirectTo:delay:fireDate:forFrame:]): (-[WebDefaultLocationChangeDelegate clientRedirectCancelledForFrame:]):
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate sharedPolicyDelegate]):
  • WebView.subproj/WebDefaultPolicyDelegatePrivate.h: Removed.
  • WebView.subproj/WebDefaultResourceLoadDelegate.h: Added.
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: Added. (+[WebDefaultResourceLoadDelegate sharedResourceLoadDelegate]): (-[WebDefaultResourceLoadDelegate identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:willSendRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didReceiveResponse:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didReceiveContentLength:fromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didFinishLoadingFromDataSource:]): (-[WebDefaultResourceLoadDelegate resource:didFailLoadingWithError:fromDataSource:]): (-[WebDefaultResourceLoadDelegate pluginFailedWithError:dataSource:]):
  • WebView.subproj/WebDefaultWindowOperationsDelegate.h: Added.
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m: Added. (+[WebDefaultWindowOperationsDelegate sharedWindowOperationsDelegate]): (-[WebDefaultWindowOperationsDelegate runJavaScriptConfirmPanelWithMessage:]): (-[WebDefaultWindowOperationsDelegate runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[WebDefaultWindowOperationsDelegate runOpenPanelForFileButtonWithResultListener:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:controller:]): (-[WebFrame findOrCreateFrameNamed:]):
  • WebView.subproj/WebFramePrivate.m: (if): (switch):
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebLocationChangeDelegate.m: Removed.
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeAndKeepLoading:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]):
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Switch all WebController's delegate to use informal protocols.

Reviewed by trey.

  • BrowserWebController.h:
  • Debug/SnippetController.h:
  • Debug/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController load]): (-[SnippetController locationChangeDone:forDataSource:]):
  • LoadProgressMonitor.h:
  • LocationChangeHandler.h:

Tests:

Switch all WebController's delegate to use informal protocols.

Reviewed by trey.

  • DumpBackForward/main.m:
  • DumpRenderTree/main.m:
  • Makefile.am:
  • SimpleViewer/DocumentController.h:
  • SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController updateStatus]): (-[DocumentController locationChangeStartedForDataSource:]): (-[DocumentController receivedPageTitle:forDataSource:]): (-[DocumentController locationChangeDone:forDataSource:]): (-[DocumentController identifierForInitialRequest:fromDataSource:]): (-[DocumentController resource:willSendRequest:fromDataSource:]):
  • SnippetEditor/DataResourceRequest.m: (+[DataProtocolHandler canHandleURL:]): (-[DataProtocolHandler startLoadingWithCacheObject:]):
  • SnippetEditor/SnippetController.h:
  • SnippetEditor/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController _resetViews]): (-[SnippetController locationChangeDone:forDataSource:]):
Note: See TracTimeline for information about the timeline view.