Timeline
Mar 11, 2003:
- 8:34 PM Changeset in webkit [3806] by
-
- 2 edits in trunk/WebKit
Fixed deployment build failure.
Reviewed by me.
- WebView.subproj/WebFramePrivate.m:
- 7:15 PM Changeset in webkit [3805] by
-
- 31 edits in trunk/WebKit
WebKit:
Added controller: parameter to all WebControllers delegates.
Reviewed by chris.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]):
- Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
- Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
- Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge showWindow]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge runJavaScriptAlertPanelWithMessage:]): (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebBridge setStatusText:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]):
- WebCoreSupport.subproj/WebSubresourceClient.m:
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
- WebView.subproj/WebContextMenuDelegate.h:
- WebView.subproj/WebControllerPolicyDelegate.h:
- WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:]): (-[WebController _menuForElement:]): (-[WebController _mouseDidMoveOverElement:modifierFlags:]):
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
- WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate controller:contextMenuItemsForElement:defaultMenuItems:]):
- WebView.subproj/WebDefaultLocationChangeDelegate.m: (-[WebDefaultLocationChangeDelegate controller:locationChangeStartedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:serverRedirectedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangeCommittedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:receivedPageTitle:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:receivedPageIcon:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangeDone:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:willCloseLocationForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangedWithinPageForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[WebDefaultLocationChangeDelegate controller:clientRedirectCancelledForFrame:]):
- WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate controller:unableToImplementPolicy:error:forURL:inFrame:]): (-[WebDefaultPolicyDelegate controller:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate controller:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
- WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate controller:identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:willSendRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didReceiveResponse:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didReceiveContentLength:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didFinishLoadingFromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didFailLoadingWithError:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:pluginFailedWithError:dataSource:]):
- WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate controller:runJavaScriptConfirmPanelWithMessage:]): (-[WebDefaultWindowOperationsDelegate controller:runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[WebDefaultWindowOperationsDelegate controller:runOpenPanelForFileButtonWithResultListener:]):
- WebView.subproj/WebFramePrivate.m: (if): (switch):
- WebView.subproj/WebLocationChangeDelegate.h:
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]):
- WebView.subproj/WebResourceLoadDelegate.h:
- WebView.subproj/WebWindowOperationsDelegate.h:
WebBrowser:
Added controller: parameter to all WebControllers delegates.
Reviewed by chris.
- LoadProgressMonitor.m: (-[LoadProgressMonitor controller:identifierForInitialRequest:fromDataSource:]): (-[LoadProgressMonitor controller:resource:willSendRequest:fromDataSource:]): (-[LoadProgressMonitor controller:resource:didReceiveResponse:fromDataSource:]): (-[LoadProgressMonitor controller:resource:didReceiveContentLength:fromDataSource:]): (-[LoadProgressMonitor controller:resource:didFinishLoadingFromDataSource:]): (-[LoadProgressMonitor controller:pluginFailedWithError:dataSource:]):
- LocationChangeHandler.m: (-[LocationChangeHandler controller:locationChangeStartedForDataSource:]): (-[LocationChangeHandler controller:locationChangeCommittedForDataSource:]): (-[LocationChangeHandler controller:locationChangeDone:forDataSource:]): (-[LocationChangeHandler controller:willCloseLocationForDataSource:]): (-[LocationChangeHandler controller:receivedPageTitle:forDataSource:]): (-[LocationChangeHandler controller:receivedPageIcon:forDataSource:]): (-[LocationChangeHandler controller:serverRedirectedForDataSource:]): (-[LocationChangeHandler controller:locationChangedWithinPageForDataSource:]): (-[LocationChangeHandler controller:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[LocationChangeHandler controller:clientRedirectCancelledForFrame:]):
Tests:
Added controller: parameter to all WebControllers delegates.
Reviewed by chris.
- SimpleViewer/DocumentController.m: (-[DocumentController controller:locationChangeStartedForDataSource:]): (-[DocumentController controller:receivedPageTitle:forDataSource:]): (-[DocumentController controller:locationChangeDone:forDataSource:]): (-[DocumentController controller:identifierForInitialRequest:fromDataSource:]): (-[DocumentController controller:resource:willSendRequest:fromDataSource:]): (-[DocumentController controller:resource:didFinishLoadingFromDataSource:]): (-[DocumentController controller:resource:didFailLoadingWithError:fromDataSource:]):
- 6:52 PM Changeset in webkit [3804] by
-
- 15 edits in trunk/WebKit
WebKit:
Reviewed by Richard.
Final policy API changes:
- changed WebPolicyDecisionListener to protocol in public API
- replaced policy enum with separate methods
- made content policy handling async
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebControllerPolicyDelegate.h:
- WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyDecisionListener _usePolicy:]): (-[WebPolicyDecisionListener use]): (-[WebPolicyDecisionListener ignore]): (-[WebPolicyDecisionListener download]):
- WebView.subproj/WebControllerPolicyDelegatePrivate.h:
- WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate unableToImplementPolicyWithError:inFrame:]): (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebFramePrivate.m: (switch):
- WebView.subproj/WebMainResourceClient.h:
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancelContentPolicy]): (-[WebMainResourceClient cancel]): (-[WebMainResourceClient cancelQuietly]): (-[WebMainResourceClient cancelWithError:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient continueAfterContentPolicy:]): (-[WebMainResourceClient checkContentPolicyForResponse:]): (-[WebMainResourceClient resource:didReceiveResponse:]):
WebBrowser:
Reviewed by Richard.
- adjusted for WebKit API changes.
- BrowserWebController.m: (-[BrowserWebController decideContentPolicyForMIMEType:andRequest:inFrame:decisionListener:]): (-[BrowserWebController tellListenerToUseContentPolicyAndRelease:]): (-[BrowserWebController confirmSendSheetDidEnd:returnCode:contextInfo:]): (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]): (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
- 4:52 PM Changeset in webkit [3803] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed mistake in that last check-in that made Safari assert on startup with Chris's bookmarks bar
- Misc.subproj/WebStringTruncator.m: (centerTruncateToBuffer): Fix logic here to not use an uninitialized variable.
- 3:49 PM Changeset in webkit [3802] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed 3193213 -- assert truncatedLength+1 < STRING_BUFFER_SIZE creating tab label for firstyearibs.com
- fixed 3194935 -- WebStringTruncator rightTruncateString: will break between composed characters
- fixed right truncator to use interpolation algorithm rather than linear search
- Misc.subproj/WebStringTruncator.m: (centerTruncateToBuffer): Changed from a class method to a plain function, and tweaked the code a bit. (rightTruncateToBuffer): Added. Like centerTruncateToBuffer, but does it on the right end instead. (stringWidth): Added. Helper function that calls the TextRenderer method with the right parameters. (truncateString): Moved all the code from centerTruncateString here, adding one new parameter, the truncate to buffer function. (+[WebStringTruncator centerTruncateString:toWidth:]): Call truncateString with the appropriate parameters. (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): Ditto. (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): Ditto.
- 3:39 PM Changeset in webkit [3801] by
-
- 4 edits in trunk/WebCore
Fix for tantek's slides, this is an issue on diveintomark's
list as well. <style> was not honoring any media attributes
set on it, so print stylesheets were being applied to the screen,
etc.!
Reviewed by rjw
- khtml/html/html_headimpl.cpp: (HTMLStyleElementImpl::childrenChanged):
- khtml/html/html_headimpl.h:
- 3:00 PM Changeset in webkit [3800]
-
- 3 copies in tags/Safari-66~1_ANCHOR
This commit was manufactured by cvs2svn to create tag
'Safari-66~1_ANCHOR'.
- 3:00 PM Changeset in webkit [3799]
-
- 3 copies in branches/Safari-66~1-branch
This commit was manufactured by cvs2svn to create branch
'Safari-66~1-branch'.
- 3:00 PM Changeset in webkit [3798]
-
- 3 copies in tags/Safari-66
This commit was manufactured by cvs2svn to create tag 'Safari-66'.
- 3:00 PM Changeset in webkit [3797] by
-
- 8 edits in trunk
Safari-66 (panther submission hopeful)
- 10:15 AM Changeset in webkit [3796] by
-
- 3 edits in trunk/WebCore
Reviewed by John.
- fixed 3166759 -- two fields both look like they have focus at webmail.iquest.net due to onblur
- kwq/KWQTextField.mm: (-[KWQTextField selectText:]): Don't call -[NSTextField selectText:] in the case where we already have an editor, because the NSTextField version will cause the field to relinquish first responder and then take it back, which will send both onblur and onfocus. (-[KWQSecureTextField selectText:]): Same fix for the secure text field.
- 1:19 AM Changeset in webkit [3795] by
-
- 3 edits in trunk/WebCore
Fix the 16000 pixel tall scrollbar on macromedia.com/software.
vertical-align position hints were being set to bad values.
Reviewed by mjs
- khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition):
- 1:18 AM Changeset in webkit [3794] by
-
- 2 edits in trunk/WebKit
Reviewed by Dave.
- fixed 3194221 - REGRESSION: search results loaded in wrong frame at directory.apple.com
- WebView.subproj/WebFramePrivate.m: (_postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:): Deliver targetted form posts correctly.
Mar 10, 2003:
- 6:58 PM Changeset in webkit [3793] by
-
- 3 edits in trunk/WebCore
Fix for <pre> regression, bug #3193590, directory listings
busted.
Reviewed by gramps
- khtml/rendering/bidi.cpp:
- 5:53 PM Changeset in webkit [3792] by
-
- 12 edits2 adds in trunk
WebCore:
Reviewed by Maciej.
- fixed 3010915 -- mouse wheel won't scroll the main document when you are over [i]frame
- kwq/WebCoreScrollView.h: Added.
- kwq/WebCoreScrollView.m: Added. Overrides scrollWheel to "do the right thing".
- WebCore.pbproj/project.pbxproj: Added WebCoreScrollView, and made it SPI so WebKit can use it.
- WebCore.exp: Exported WebCoreScrollView so WebKit can use it.
- WebCore-combined.exp: Regenerated.
- kwq/KWQListBox.mm: Made KWQListBoxScrollView a subclass of WebCoreScrollView instead of NSScrollView.
- kwq/KWQTextArea.h: Made KWQTextArea a subclass of WebCoreScrollView instead of NSScrollView.
- other changes
- kwq/KWQComboBox.mm: Make the workaround for the position of text in the pop-up compile only when we build on Jaguar. That way a Jaguar-built Safari looks perfect on Jaguar and a Panther built one looks perfect on Panther.
- kwq/KWQKHTMLPart.mm: Reformatted some method calls.
WebKit:
Reviewed by Maciej.
- fixed 3010915 -- mouse wheel won't scroll the main document when you are over [i]frame
- WebView.subproj/WebDynamicScrollBarsView.h: Made WebDynamicScrollBarsView a subclass of WebCoreScrollView instead of NSScrollView.
- other changes
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:): Fix problem where you would not get any information if the click was on a subview of the WebHTMLView, like a form control.
- 1:11 PM Changeset in webkit [3791] by
-
- 10 edits in trunk/WebCore
Fix compacts and run-ins to work a lot better than they did
before. I had some huge misunderstandings with how compact
worked that have now been clarified.
Reviewed by kocienda
- khtml/rendering/bidi.cpp:
- khtml/rendering/bidi.h:
- khtml/rendering/render_block.cpp:
- khtml/rendering/render_block.h:
- khtml/rendering/render_flow.cpp: (RenderFlow::repaint):
- khtml/rendering/render_line.cpp: (InlineFlowBox::placeBoxesHorizontally):
- khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
- khtml/rendering/render_object.h:
- 10:37 AM Changeset in webkit [3790] by
-
- 11 edits in trunk/WebKit
Fixed some download-related leaks. Primarily, we were leaking the data source that started the download. The data source is now immediately released when it becomes a download.
Reviewed by darin.
- Downloads.subproj/WebDownload.m: (-[WebDownloadPrivate dealloc]): release the WebResourceDelegateProxy (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): renamed, don't pass a datasource so WebDownload is completely disconnected from the that. Pass the proxy so it transfers ownership from WebMainResourceClient and it doesn't leak when we cancel a download. (-[WebDownload _setRequest:]): added (-[WebDownload _setResponse:]): added (-[WebDownload resource:willSendRequest:]): call _setRequest (-[WebDownload resource:didReceiveResponse:]): call _setResponse
- Downloads.subproj/WebDownloadPrivate.h:
- WebView.subproj/WebBaseResourceHandleDelegate.h:
- WebView.subproj/WebBaseResourceHandleDelegate.m: removed notifyDelegatesOfInterruptionByPolicyChange, no longer called
- WebView.subproj/WebMainResourceClient.h: made WebResourceDelegateProxy available to other classes
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): moved most error handling code here (-[WebMainResourceClient cancel]): stop load, call receivedError (-[WebMainResourceClient interruptForPolicyChange]): renamed, call receivedError with the policy interrupt error (-[WebMainResourceClient stopLoadingForPolicyChange]): call interruptForPolicyChange (-[WebMainResourceClient continueAfterContentPolicy:response:]): for WebPolicySave, create the download, call interruptForPolicyChange and return so the response isn't set on the superclass. (-[WebMainResourceClient resource:didFailLoadingWithError:]): call receivedError (-[WebResourceDelegateProxy setDelegate:]): don't retain the delegate (-[WebResourceDelegateProxy resourceDidFinishLoading:]): don't release the delegate (-[WebResourceDelegateProxy resource:didFailLoadingWithError:]): don't release the delegate
- 8:32 AM Changeset in webkit [3789] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Ken.
- fixed 3193099 -- date parsing can't handle the time zone format that date formatting produces
- kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Allow a "GMT" prefix before the time zone offset.
Mar 8, 2003:
- 2:58 AM Changeset in webkit [3788] by
-
- 1 edit in trunk/WebCore/khtml/css/cssstyleselector.cpp
* empty log message *
- 2:55 AM Changeset in webkit [3787] by
-
- 3 edits in trunk/WebCore
Check in the patch I actually meant to land. Somehow what I landed
had removed a line that was supposed to be there.
- khtml/css/cssstyleselector.cpp:
Mar 7, 2003:
- 8:02 PM Changeset in webkit [3786] by
-
- 3 edits in trunk/WebCore
Reviewed by Trey.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Fix form submission (was completely broken).
- 6:19 PM Changeset in webkit [3785] by
-
- 24 edits in trunk
WebCore:
Reviewed by Richard.
- fixed 3127705 - don't open new window on opt-click even if the link requests it
- fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Don't use findOrCreateFrameNamed, instead pass target along. (KWQKHTMLPart::openURLRequest): Likewise. (KWQKHTMLPart::submitForm): Likewise. (KWQKHTMLPart::urlSelected): Likewise.
- kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Likewise.
- kwq/WebCoreBridge.h:
WebKit:
Reviewed by Richard.
- fixed 3127705 - don't open new window on opt-click even if the link requests it
- fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)
- removed open new window and open new window behind policies
- removed [WebFrame findOrCreateFrameNamed:] from API
- remved showWindowBehind from window operations delegate
- added decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener: delegate method
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebPluginRequest initWithRequest:frameName:notifyData:]): (-[WebPluginRequest dealloc]): (-[WebPluginRequest frameName]):
- Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]):
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:target:triggeringEvent:form:formValues:]): (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
- WebView.subproj/WebControllerPolicyDelegate.h:
- WebView.subproj/WebControllerPrivate.h:
- WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:]):
- WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
- WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
- WebView.subproj/WebFrame.h:
- WebView.subproj/WebFrame.m:
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebFramePrivate.m: (-[NSObject performSelector:withObject:withObject:withObject:]):
- WebView.subproj/WebWindowOperationsDelegate.h:
WebBrowser:
Reviewed by Richard.
- fixed 3127705 - don't open new window on opt-click even if the link requests it
- fixed 3143971 - cmd-click should override the target="_blank" and target="_new" (important for tabs)
- updated for various WebKit API changes.
- BrowserDocument.h:
- BrowserDocument.m: (-[BrowserDocument initWithContentsOfRequest:frameName:]): (-[BrowserDocument init]): (-[BrowserDocument initWithContentsOfURL:ofType:]): (-[BrowserDocument createWebController]):
- BrowserDocumentController.h:
- BrowserDocumentController.m: (-[BrowserDocumentController _openDocumentWithContentsOfRequest:behind:display:frameName:]): (-[BrowserDocumentController openDocumentWithContentsOfRequest:behind:display:]): (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]): (-[BrowserDocumentController openDocument:]): (-[BrowserDocumentController goToRequest:windowPolicy:frameName:]): (-[BrowserDocumentController goToRequest:windowPolicy:]):
- BrowserWebController.h:
- BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]): (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
- 6:16 PM Changeset in webkit [3784] by
-
- 4 edits in trunk/WebCore
better fix for text-decoration issue on time.com.
Reviewed by mjs
- khtml/css/cssstyleselector.cpp:
- khtml/rendering/render_style.h:
- 6:02 PM Changeset in webkit [3783] by
-
- 2 edits in trunk/WebKit
Updated header doc comments.
- Downloads.subproj/WebDownload.h:
- 4:04 PM Changeset in webkit [3782] by
-
- 3 edits in trunk/WebCore
Fix for time.com regression. Don't allow text-decoration to
apply to anchor elements with no href.
Reviewed by darin
- khtml/css/cssstyleselector.cpp:
- 3:14 PM Changeset in webkit [3781] by
-
- 3 edits in trunk/WebCore
Whoops. Fix regression causedb y previous checkin.
Reviewed by darin
- khtml/css/cssstyleselector.cpp:
- 3:10 PM Changeset in webkit [3780] by
-
- 11 edits in trunk/WebKit
WebKit:
Drop mainDocumentError from WebDataSource.
Combine registerView: and registerRepresentation: into one method on WebFrame.
Reviewed by trey.
- Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
- WebView.subproj/WebDataSource.h:
- WebView.subproj/WebDataSource.m:
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _mainDocumentError]):
- WebView.subproj/WebFrame.h:
- WebView.subproj/WebFrame.m: (+[WebFrame registerViewClass:representationClass:forMIMEType:]):
- WebView.subproj/WebFramePrivate.m: (switch):
- WebView.subproj/WebView.h:
- WebView.subproj/WebView.m:
Tests:
Drop mainDocumentError from WebDataSource.
Combine registerView: and registerRepresentation: into one method on WebFrame.
Reviewed by trey.
- PDFViewer/ApplicationController.m: (-[ApplicationController awakeFromNib]):
- 2:58 PM Changeset in webkit [3779] by
-
- 3 edits in trunk/WebCore
Make the :hover:active behavior much more sophisticated
(and make it match WinIE, since that buggy browser is what
necessitates this hack).
Reviewed by darin
- khtml/css/cssstyleselector.cpp:
- 2:58 PM Changeset in webkit [3778] by
-
- 6 edits in trunk/WebKit
WebKit:
WebKit part of fixes to these two synching-related bugs:
3190844 -- Bookmarks Bar and Menu collections need to be
marked specially in Bookmarks file
3192197 -- Safari should write out UUID-full Bookmarks
file after reading UUID-free one
Reviewed by Trey
- Bookmarks.subproj/WebBookmark.h:
- Bookmarks.subproj/WebBookmark.m: (-[WebBookmark setUUID:]): Removed the leading underscore, made this method public. Removed unnecessary constraint that new or old UUID had to be nil; now short-circuits the no-change case. (-[WebBookmark copyWithZone:]): updated for name change (-[WebBookmark initFromDictionaryRepresentation:withGroup:]): ditto
- Bookmarks.subproj/WebBookmarkGroup.h:
- Bookmarks.subproj/WebBookmarkGroup.m: (-[WebBookmarkGroup bookmarkForUUID:]): new public method to find a bookmark from a UUID. (-[WebBookmarkGroup _addBookmark:]): updated for name change
- Bookmarks.subproj/WebBookmarkPrivate.h: removed declaration for old _setUUID
WebBrowser:
WebBrowser part of fixes to these two synching-related bugs:
3190844 -- Bookmarks Bar and Menu collections need to be
marked specially in Bookmarks file
3192197 -- Safari should write out UUID-full Bookmarks
file after reading UUID-free one
Reviewed by Trey
- BookmarksController.m: (-[BookmarksController bookmark:isFolderTitled:]): new convenience method (-[BookmarksController findOrCreateBookmarkSourceTitled:withUUID:index:]): new method, replaces old code to bless the Bookmarks Bar and Bookmarks Menu folders. Now sets the new well-known UUID for these folders, and ensures that the bookmarks file will be saved if the UUIDs were not there previously. I also removed some of the old backward-compatibility-to-ancient- prelease-version hacks. (-[BookmarksController updateBookmarkSources]): reworked to call new methods
- English.lproj/Localizable.strings:
- English.lproj/StringsNotToBeLocalized.txt: Kept these up to date
- 11:48 AM Changeset in webkit [3777] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed regression caused when we made the stopLoading method on WebDataSource private
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _recursiveStopLoading]): The children are frames, so we need to do stopLoading, not _stopLoading.
- 11:20 AM Changeset in webkit [3776] by
-
- 14 edits in trunk/WebKit
WebKit:
Fixed: 3191052 - Predetermined downloads should not be started from the browser window
- Stripped the rest of WebKit of download related code.
Reviewed by trey.
- Downloads.subproj/WebDownload.h: Changed the download delegate method from download:didStartFromDataSource: download:didStartFromRequest:. Passing the data source wasn't that helpful. It was also quirky that the data source would sometimes be nil.
- Downloads.subproj/WebDownload.m: (-[WebDownloadPrivate dealloc]): release directory path (-[WebDownload _initWithLoadingResource:dataSource:]): call _loadStarted and _loadEnded (-[WebDownload loadWithDelegate:]): call _loadStarted (-[WebDownload _loadStarted]): set flag, retain self (-[WebDownload _loadEnded]): set flag, release self (-[WebDownload resource:willSendRequest:]): call _loadEnded if the returned request is nil (-[WebDownload resourceDidFinishLoading:]): call _loadEnded (-[WebDownload resource:didFailLoadingWithError:]): call _loadEnded (-[WebDownload _createFileIfNecessary]): handle a predetermined download directory, not path (-[WebDownload _cancelWithError:]): call _loadEnded (-[WebDownload _setDirectoryPath:]): new private method
- Downloads.subproj/WebDownloadPrivate.h:
- WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedError:fromDataSource:complete:]): don't call [dataSource isDownloading] (-[WebController _downloadURL:toDirectory:]): create and start a self retained WebDownload
- WebView.subproj/WebDataSource.h:
- WebView.subproj/WebDataSource.m: removed download related methods
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebDataSourcePrivate.m: removed download related methods (-[WebDataSource _commitIfReady:]): don't call isDownloading
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebFramePrivate.m:
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): when handing off the load to the download, don't deal with the download path (-[WebMainResourceClient resource:didReceiveResponse:]): no more predetermined downloads come through here
WebBrowser:
Fixed: 3142376 - would be better if queued downloads showed up in downloads window
- Handle WebKit started downloads that don't have associated data sources.
- Don't use removed WebKit download API's.
- Handle HTTP errors in responses instead of downloading html error files.
- Don't update progress bar using a timer so it doesn't jerk.
Reviewed by john.
- BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]): call downloadMayBeOpenedForRequest (-[BrowserWebController stopLoading]): removed stopNonDownloadingDataSource, don't call it
- DownloadMonitor.h:
- DownloadMonitor.m: (-[DownloadMonitor init]): create _openableDownloadRequests (-[DownloadMonitor download:didStartFromRequest:]): fixed leak, create entry with request (-[DownloadMonitor download:didReceiveResponse:]): handle HTTP errors (-[DownloadMonitor downloadMayBeOpenedForRequest:]): renamed
- DownloadProgressEntry.h:
- DownloadProgressEntry.m: (-[DownloadProgressEntry setBytesLoaded:]): call progress notification (-[DownloadProgressEntry setBytesExpected:]): call progress notification (-[DownloadProgressEntry bytesExpected]): overridden to avoid superclass quirks
- DownloadRow.m: (-[DownloadRow initWithDownloadProgressEntry:]): observe DownloadEntryProgressDidChangeNotification (-[DownloadRow _updateProgressAnimation]): handle changes in bytesExpected (-[DownloadRow _startProgressAnimation]): call _updateProgressAnimation, have timer call _updateStatusField (-[DownloadRow _updateStatusField]): handle no bytes received case (-[DownloadRow entryStageDidChange]): tweak (-[DownloadRow entryPathDidChange]): tweak (-[DownloadRow entryProgressDidChange]): call _updateProgressAnimation
- English.lproj/Localizable.strings: updated
Note:
See TracTimeline
for information about the timeline view.
