⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 16, 2003:

8:49 PM Changeset in webkit [3843] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3196050 - Hang in www.janegoodall.org dynamic menus
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::handleLocalEvents): Copy handlers before processing them, so we don't go into an infinite loop if a handler adds or removes handlers.
12:48 AM Changeset in webkit [3842] by trey
  • 8 edits in trunk

JavaScriptCore:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

WebFoundation:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

  • WebFoundation.pbproj/project.pbxproj:

WebCore:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

  • WebCore.pbproj/project.pbxproj:

WebKit:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

  • WebKit.pbproj/project.pbxproj:

WebBrowser:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.

Reviewed by Maciej.

  • WebBrowser.pbproj/project.pbxproj:

Mar 14, 2003:

6:37 PM Changeset in webkit [3841] by cblu
  • 2 edits in trunk/WebKit

Backed out changes to WebBaseNetscapePluginView. Unintentional commit.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]):
6:29 PM Changeset in webkit [3840] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3198961 - REGRESSION: Stopping load of plug-in content is not reflected in UI

Reviewed by mjs.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancelWithError:]): call receivedError so [dataSource _receivedError:error complete:YES] is called
6:06 PM Changeset in webkit [3839] by rjw
  • 3 edits in trunk/WebCore

Fixed 3197162. The regression was introduced with the change
to preferences. The old settings API was used to 'reset' the jscript
other properties of the part. This effectively always disabled
javascript and prevented properties from being restored to the js
property maps.

Reviewed by trey.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveWindowProperties): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreWindowProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::openURLFromPageCache):
3:28 PM Changeset in webkit [3838]
  • 13 copies in tags/Safari-66~1

This commit was manufactured by cvs2svn to create tag 'Safari-66~1'.

3:28 PM Changeset in webkit [3837] by mjs
  • 10 edits in branches/Safari-66~1-branch

top level:

Reviewed by Maciej.

  • remove leftover bits of NO_LICENSE
  • acconfig.h: Remove NO_LICENSE.
  • configure.in: Remove all the NO_LICENSE-related bits.

Tools:

  • Scripts/byteswap: Fixed a bug in the tool that Trey spotted. It wouldn't swap newline characters correctly.

JavaScriptCore:

Reviewed by Ken.

  • fixed 3193099 -- date parsing can't handle the time zone format that date formatting produces
  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Allow a "GMT" prefix before the time zone offset.

Tests:

  • TestURLs.h: Added more test URLs.
  • kde/kurl-test.chk: Added test results for the new URLs.

WebFoundation:

Reviewed by trey.

Added _web_changeFileAttributes:atPath and factored _web_changeFinderAttributes out to its own method.

  • Misc.subproj/WebNSFileManagerExtras.h:
  • Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_changeFinderAttributes:forFileAtPath:]): was _web_createFileAtPath (-[NSFileManager _web_changeFileAttributes:atPath:]): call createFileAtPath, then _web_changeFinderAttributes (-[NSFileManager _web_createFileAtPath:contents:attributes:]): call changeFileAttributes, then _web_changeFinderAttributes

WebCore:

Reviewed by John.

  • fixed 3166759 -- two fields both look like they have focus at webmail.iquest.net due to onblur
  • kwq/KWQTextField.mm: (-[KWQTextField selectText:]): Don't call -[NSTextField selectText:] in the case where we already have an editor, because the NSTextField version will cause the field to relinquish first responder and then take it back, which will send both onblur and onfocus. (-[KWQSecureTextField selectText:]): Same fix for the secure text field.

WebKit:

Reviewed by Dave.

  • fixed 3194221 - REGRESSION: search results loaded in wrong frame at directory.apple.com
  • WebView.subproj/WebFramePrivate.m: (_postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:): Deliver targetted form posts correctly.

WebBrowser:

First step of preferences reorganization. I added new empty
panes for AutoFill and Tabs. I added an Advanced pane and
moved the existing Style Sheet and Proxies controls and code
there. I made no other code changes yet.

Reviewed by Maciej

  • BookmarksController.m: (-[BookmarksController findOrCreateBookmarkSourceTitled:withUUID:index:]): Unrelated change -- once you've found the Bookmarks Menu or Bookmarks Bar folder, stop iterating. This code will be changed soon anyway due to 3192834.
  • Preferences.subproj/AdvancedPreferences.tiff: Added.
  • Preferences.subproj/AutoFillPreferences.tiff: Added.
  • Preferences.subproj/TabsPreferences.tiff: Added. new images for new preference panes
  • Preferences.subproj/AdvancedPreferences.h: Added.
  • Preferences.subproj/AdvancedPreferences.m: Added. (-[AdvancedPreferences sendProxyTabEventToPSN:]): (-[AdvancedPreferences openProxyPreferences:]): (-[AdvancedPreferences setStyleSheetPathPreference:]): (-[AdvancedPreferences styleSheetPathPreference]): (-[AdvancedPreferences updateStyleSheetMenu]): (-[AdvancedPreferences takeStyleSheetFromMenuItem:]): (-[AdvancedPreferences disableUserStyleSheet:]): (-[AdvancedPreferences choseStyleSheetFromPanel:returnCode:contextInfo:]): (-[AdvancedPreferences chooseStyleSheetFromFileBrowser:]): (-[AdvancedPreferences initializeFromDefaults]): (-[AdvancedPreferences isResizable]): Just cut/pasted code to here from AppearancePreferences (style sheet) and GeneralPreferences (proxies)
  • Preferences.subproj/AppearancePreferences.h:
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences initializeFromDefaults]): Cut out the style sheet code.
  • Preferences.subproj/GeneralPreferences.h:
  • Preferences.subproj/GeneralPreferences.m: (-[GeneralPreferences toggleAutoOpenDownloads:]): Cut out the proxies code.
  • Preferences.subproj/AutoFillPreferences.h: Added.
  • Preferences.subproj/AutoFillPreferences.m: Added. New empty husk of a class.
  • Preferences.subproj/TabsPreferences.h: Added.
  • Preferences.subproj/TabsPreferences.m: Added. New empty husk of a class.
  • Preferences.subproj/English.lproj/AutoFillPreferences.nib: Added. New empty husk of a preference pane.
  • Preferences.subproj/English.lproj/TabsPreferences.nib: Added. New empty husk of a preference pane.
  • Preferences.subproj/English.lproj/AdvancedPreferences.nib: Added. New preference pane, contains style sheet and proxies controls that formerly lived elsewhere. (Also a silly dividing line.)
  • Preferences.subproj/English.lproj/AppearancePreferences.nib: Removed style sheet control, shrunk window.
  • Preferences.subproj/English.lproj/GeneralPreferences.nib: Removed proxies control, shrunk window.
  • Preferences.subproj/WBPreferences.m: (-[WBPreferences init]): Create the three new panes.
  • WebBrowser.pbproj/project.pbxproj: updated for new files.
  • English.lproj/Localizable.strings: updated for names of new panes.
3:27 PM Changeset in webkit [3836] by hyatt
  • 3 edits in trunk/WebCore

Make :target match the root element if no #fragment is specified in
the URL.

Reviewed by john

  • khtml/css/cssstyleselector.cpp:
3:08 PM Changeset in webkit [3835] by mjs
  • 4 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • fixed 3190846 - REGRESSION: can't use Fidelity NetBenefits account
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Treat javascript: URLs as about:blank for now. (HTMLFrameElementImpl::attach): Likewise.
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Make sure to send completed() signal after signals are connectd in synchronous load case.
1:53 PM Changeset in webkit [3834] by mjs
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Don.

  • revert premature controller --> webView renaming, it's causing problems with window opening and such.
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m:

WebBrowser:

Reviewed by Don.

  • add controller: argument to a method that now needs it.

(informal protocols suck!)

  • BrowserWebController.m: (-[BrowserWebController controller:runOpenPanelForFileButtonWithResultListener:]):
12:13 PM Changeset in webkit [3833] by hyatt
  • 4 edits in trunk/WebCore

Fix for ew.com, hrweb and arstechnica forums. A <br> should
not create a nonempty line in the case where the previous line
didn't break cleanly. The fix is to have a new boolean that
tracks how the previous line broke and to have <br> check that
to figure out if it should set the line to be non-empty.

Reviewed by gramps

  • khtml/rendering/bidi.cpp:
11:28 AM Changeset in webkit [3832] by cblu
  • 7 edits in trunk/WebKit

Fixed: 3197872 - Standalone plug-in content isn't restarted when switching tabs
Fixed: 3189675 - assertion in plug-in code fails (nil window) with .swf page displaying standalone in a tab

We start plug-ins when they are added to the window and stop them when they are removed. To restart a plug-in, the data stream must be redelivered. This works in the embedded plug-in case, but in the standalone plug-in case, the stream is delivered by the machinery in WebKit. The stream is only delivered once. This fix addresses that.

Reviewed by trey.

  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): reset the offset ivar (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): If we create a file for the plug-in, handle the case where the file is already created.
  • Plugins.subproj/WebBaseNetscapePluginView.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView isStarted]): added so the stream knows the state of the view
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView initWithFrame:]): tweak (-[WebNetscapePluginDocumentView viewDidMoveToWindow]): call redeliverStream if we are added back to the window (-[WebNetscapePluginDocumentView setDataSource:]): only start the plug-in if we are in a window, don't assert
  • Plugins.subproj/WebNetscapePluginRepresentation.h:
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation dealloc]): release the retained data source and error (-[WebNetscapePluginRepresentation setDataSource:]): retain the data source (-[WebNetscapePluginRepresentation isPluginViewStarted]): new (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): only do work if isPluginViewStarted (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): retain the error, only do work if isPluginViewStarted (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]): only do work if isPluginViewStarted
(-[WebNetscapePluginRepresentation redeliverStream]): call receivedData
with all the received data up to this point. Call receivedError:: or finishedLoadingWithDataSource: if the load is already complete.

Mar 13, 2003:

11:17 PM Changeset in webkit [3831]
  • 1 copy
    319 deletes in branches/unlabeled-1.10.38

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.10.38'.

11:17 PM Changeset in webkit [3830] by mjs
  • 26 edits in trunk

WebCore:

Reviewed by Trey.

  • fixed 3188209 - REGRESSION: onmouseup handlers not running for most form elements
  • khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): Connect to clicked signal. (RenderFileButton::RenderFileButton): Likewise. (RenderFileButton::slotClicked): Send clicked through DOM. (RenderTextArea::RenderTextArea): Connect to clicked signal.
  • khtml/rendering/render_replaced.cpp: (RenderWidget::sendConsumedMouseUp): New method to send a mouseUp event for this DOM element. Meant for up events consumed by AppKit mouseDown: methods that use modal event loops.
  • khtml/rendering/render_replaced.h:
  • kwq/KWQButton.h:
  • kwq/KWQButton.mm: (-[KWQButton initWithQButton:]): Moved here from former adaptor class. (-[KWQButton action:]): Make sure to send up before click. (-[KWQButton mouseDown:]): Record that we are processing a mouse event. If no click happened, send the missing up event. (QButton::QButton): Use NSButton subclass instead of separate adaptor. (QButton::~QButton): Likewise.
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Initialize clicked signal. (KWQFileButton::clicked): Emit clicked signal. (-[KWQFileButtonAdapter initWithKWQFileButton:]): Observe Clicked notification too. (-[KWQFileButtonAdapter clicked]): Send mouse up and click through DOM.
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): Initialize clicked signal. (QLineEdit::clicked): Emit clicked signal.
  • kwq/KWQListBox.mm: (QListBox::QListBox): No longer use separate object as delegate and data source. (QListBox::~QListBox): No more need to retrieve and release delegate. (-[KWQTableView initWithListBox:items:]): (-[KWQTableView mouseDown:]): Record that we are processing a mouse event; if no click happens while processing, send the mouse up event through the DOM. (-[KWQTableView tableViewSelectionDidChange:]): If sending clicked and processing a mouse event, send up first.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView mouseDown:]): Send up and click through DOM after calling super.
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): Initialize clicked signal. (QTextEdit::clicked): Emit clicked signal.
  • kwq/KWQTextField.mm: (-[KWQTextField setPasswordMode:]): initWithQLineEdit: instead of initWithQWidget: (-[KWQTextField fieldEditorDidMouseDown:]): Send up and click through DOM. (-[KWQSecureTextField initWithQLineEdit:]): Store QLineEdit*, not just QWidget*. (-[KWQSecureTextField fieldEditorDidMouseDown:]): Send up and click through DOM.
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: (QWidget::sendConsumedMouseUp): Common method for widgets to send a mouseUp that has been consumed by mouseDown processing through the DOM.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreFirstResponderChanges.h:
  • kwq/WebCoreViewFactory.m:
  • WebCore.exp: Export new string constant.
  • WebCore-combined.exp: Regenerated.

WebKit:

Reviewed by Trey.

  • fixed 3188209 - REGRESSION: onmouseup handlers not running for most form elements
  • WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton chooseButtonPressed:]): Send appropriate NSNotification.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSTextView mouseDown:]): Call fieldEditorDidMouseDown: on delegate, if implemented, after calling super.
7:09 PM Changeset in webkit [3829] by rjw
  • 67 edits in trunk

WebKit:

First stage of the WebController -> WebView, WebView -> WebFrameView.
This change does the WebView -> WebFrameView part of the change. Also
changes WebController's inheritance. It now inherits from NSView. Also
added some simple action methods to WebController (soon to be WebView)
to facilitate IB hookup.

Reviewed by Maciej.

  • Carbon.subproj/CarbonWindowAdapter.m:
  • Carbon.subproj/HIWebView.h:
  • Carbon.subproj/HIWebView.m: (if): (switch):
  • Carbon.subproj/HIWebViewPriv.h:
  • Misc.subproj/WebKitStatistics.m: (+[WebKitStatistics viewCount]):
  • Misc.subproj/WebKitStatisticsPrivate.h:
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_parentWebFrameView]):
  • Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels frontmostWindowLoadingURL:]):
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView layout]):
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView dataSource]):
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge areScrollbarsVisible]): (-[WebBridge setScrollbarsVisible:]): (-[WebBridge window]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge nextKeyViewOutsideWebFrameViews]): (-[WebBridge previousKeyViewOutsideWebFrameViews]): (-[WebBridge setNeedsReapplyStyles]): (-[WebBridge setNeedsLayout]): (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): (-[WebBridge frameRequiredForMIMEType:]): (-[WebBridge handleMouseDragged:]): (-[WebBridge mayStartDragWithMouseDragged:]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (+[WebContentTypes canShowMIMEType:]): (-[WebController _commonInitialization:frameName:groupName:]): (-[WebController init]): (-[WebController initWithFrame:]): (-[WebController initWithView:]): (-[WebController supportsTextEncoding]): (-[WebController takeStringURLFrom:]): (-[WebController goBack:]): (-[WebController goForward:]): (-[WebController stopLoading:]):
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate _clearControllerReferences:]): (-[WebController _createFrameNamed:inParent:allowsScrolling:]): (-[WebController _frameForView:fromFrame:]): (-[WebController _frameForView:]):
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _layoutChildren]): (-[WebDataSource _receivedData:]):
  • WebView.subproj/WebDebugDOMNode.h:
  • WebView.subproj/WebDebugDOMNode.m: (-[WebDebugDOMNode initWithWebFrameView:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate controller:contextMenuItemsForElement:defaultMenuItems:]):
  • WebView.subproj/WebDefaultLocationChangeDelegate.m: (-[WebDefaultLocationChangeDelegate controller:locationChangeStartedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:serverRedirectedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangeCommittedForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:receivedPageTitle:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:receivedPageIcon:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangeDone:forDataSource:]): (-[WebDefaultLocationChangeDelegate controller:willCloseLocationForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:locationChangedWithinPageForDataSource:]): (-[WebDefaultLocationChangeDelegate controller:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[WebDefaultLocationChangeDelegate controller:clientRedirectCancelledForFrame:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate controller:unableToImplementPolicyWithError:inFrame:]): (-[WebDefaultPolicyDelegate controller:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate controller:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate controller:identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:willSendRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didReceiveResponse:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didReceiveContentLength:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didFinishLoadingFromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:resource:didFailLoadingWithError:fromDataSource:]): (-[WebDefaultResourceLoadDelegate controller:pluginFailedWithError:dataSource:]):
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate controller:runJavaScriptConfirmPanelWithMessage:]): (-[WebDefaultWindowOperationsDelegate controller:runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[WebDefaultWindowOperationsDelegate controller:runOpenPanelForFileButtonWithResultListener:]):
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebDynamicScrollBarsView.m:
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame init]): (-[WebFrame initWithName:webFrameView:controller:]): (-[WebFrame view]): (+[WebFrame registerViewClass:representationClass:forMIMEType:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (if): (switch):
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): (-[WebHTMLView draggedImage:endedAt:operation:]): (-[WebHTMLView becomeFirstResponder]):
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _controller]): (-[WebHTMLView _frame]): (-[WebHTMLView _elementAtPoint:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView controller]): (-[WebImageView menuForEvent:]): (-[WebImageView mouseDragged:]): (-[WebImageView draggedImage:endedAt:operation:]):
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebRenderNode.h:
  • WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:position:rect:view:children:]): (-[WebRenderNode initWithWebFrameView:]):
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]):
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebFrameView initWithFrame:]): (-[WebFrameView dealloc]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m:
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebCore:

First stage of the WebController -> WebView, WebView -> WebFrameView.
This change does the WebView -> WebFrameView part of the change. Also
changes WebController's inheritance. It now inherits from NSView.

Reviewed by Maciej.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyView):
  • kwq/KWQScrollView.mm:
  • kwq/KWQWidget.mm: (QWidget::getOuterView):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreBridge previousKeyViewInsideWebFrameViews]):

WebBrowser:

First stage of the WebController -> WebView, WebView -> WebFrameView.
This change does the WebView -> WebFrameView part of the change. Also
changes WebController's inheritance. It now inherits from NSView.

Reviewed by Maciej.

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument mainWebFrameView]): (-[BrowserDocument bugReportSheetDidEnd:returnCode:contextInfo:]): (-[BrowserDocument printShowingPrintPanel:]): (-[BrowserDocument setURLString:]): (-[BrowserDocument text]):
  • BrowserWebController.h:
  • BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController mainWebFrameView]): (-[BrowserWebController goToRequest:allowJavaScript:waitInQueue:]): (-[BrowserWebController goToURL:withFallbackURLs:]): (-[BrowserWebController setShouldStartEmpty]):
  • BrowserWebViewExtras.h:
  • BrowserWebViewExtras.m: (-[WebFrameView largestScrollableWebView]):
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController mainWebFrameView]): (-[BrowserWindowController updateKeyboardLoop]): (-[BrowserWindowController setUpTabForController:]): (-[BrowserWindowController windowWillHandleKeyEvent:]): (-[BrowserWindowController bestWindowSizeForCurrentPageWithDefaultSize:]): (-[BrowserWindowController frameLoadStarted:]): (-[BrowserWindowController frameLoadCommitted:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController targetForSearch]): (-[BrowserWindowController canReloadTab:]): (-[BrowserWindowController canReloadAllTabs]):
  • ContextMenuHandler.m: (-[ContextMenuHandler controller:contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler search:]): (-[ContextMenuHandler goToAddress:]):
  • Debug/DOMTree.m: (-[DOMTreeDataSource initWithWebFrameView:]): (-[DOMTree createTreeFromController:]):
  • Debug/RenderTree.m: (-[RenderTreeDataSource initWithWebFrameView:]): (-[RenderTree createTreeFromController:]):
  • Debug/SnippetController.m: (-[SnippetController load]):
  • Debug/ViewTree.m: (-[ViewTreeDataSource initWithWebFrameView:]): (-[ViewTree createTreeFromController:]):
  • FormCompletionController.m: (+[AutoFillController autoFillInController:]):

Tests:

First stage of the WebController -> WebView, WebView -> WebFrameView.
This change does the WebView -> WebFrameView part of the change. Also
changes WebController's inheritance. It now inherits from NSView.

Reviewed by Maciej.

  • DumpBackForward/main.m: (main): (-[CheapWindowOpsDelegate controller:createWindowWithRequest:]):
  • DumpRenderTree/main.m: (main):
  • IBViewer/DocumentController.h:
  • IBViewer/DocumentController.m: (-[DocumentController controller:locationChangeStartedForDataSource:]): (-[DocumentController controller:locationChangeDone:forDataSource:]):
  • IBViewer/English.lproj/Document.nib:
  • PDFBundle/PDFView.m: (-[PDFView dataSource]): (-[PDFView layout]): (+[PDFPluginViewFactory pluginViewWithArguments:]):
  • PDFViewer/ApplicationController.m: (-[ApplicationController awakeFromNib]):
  • PDFViewer/DocumentController.m: (-[DocumentController loadURL:]):
  • PDFViewer/PDFRepresentation.m: (-[PDFView layout]):
  • SimpleViewer/ApplicationController.m:
  • SimpleViewer/DocumentController.h:
  • SimpleViewer/DocumentController.m: (-[DocumentController dealloc]): (-[DocumentController loadURL:]):
  • SnippetEditor/ApplicationController.m:
  • SnippetEditor/SnippetController.m: (-[SnippetController _resetViews]): (-[SnippetController loadComplete]):
5:41 PM Changeset in webkit [3828] by darin
  • 3 edits in trunk/WebCore
  • remove mistaken inlining to fix build with newer versions of gcc
  • khtml/rendering/render_object.cpp: (RenderObject::container): Don't mark this inline.
5:25 PM Changeset in webkit [3827] by hyatt
  • 3 edits in trunk/WebCore

This is a fix to stop creating textruns for the whitespace at the
end of a block. This is a major line layout bug that leads to the
height of the last line in a paragraph being wrong, especially when
<font> tags are used.

Example of the problem:

<div><nobr>foo</nobr> </div>

The whitespace between the </nobr> and the end of the </div> was
being counted when it should have been stripped. The problem was
an off-by-one error with the endpoint I set up. I used a position
of 0, which is inclusive, so I needed a new value that meant
"Stop on this object and don't include any of it." I'm using
UINT_MAX as this special value for the position.

Reviewed by john

  • khtml/rendering/bidi.cpp:
  • khtml/rendering/bidi.h:
4:57 PM Changeset in webkit [3826] by sullivan
  • 2 edits in trunk/WebKit

WebKit:

Reviewed by Trey.

  • English.lproj/StringsNotToBeLocalized.txt: Removed all the bookmarks-related strings that I forgot to remove in my previous checkin.

WebBrowser:

  • fixed 3192834 Bookmarks Bar and Menu titles should not be localized in bookmarks.plist, for synching

Reviewed by Trey.

  • WebBookmarkGroup.h: changed _loading to _notificationsSuppressed
  • WebBookmarkGroup.m: (-[WebBookmarkGroup suppressNotifications]): new method, sets _notificationsSuppressed (and asserts about reentrancy) (-[WebBookmarkGroup resumeNotifications]): new method, clears _notificationsSuppressed (and asserts about reentrancy) (-[WebBookmarkGroup _sendNotification:forBookmark:children:]): check _notificationsSuppressed instead of _loading (-[WebBookmarkGroup _loadBookmarkGroupGuts]): call suppress/resumeNotifications instead of using _loading
  • BookmarksController.m: (+[BookmarksController _favoritesTitle]): just tweaked localization comment (+[BookmarksController _menuRootTitle]): ditto (+[BookmarksController historyProxyTitle]): ditto (+[BookmarksController addressBookProxyTitle]): ditto (+[BookmarksController rendezvousProxyTitle]): ditto (-[BookmarksController savePendingChanges]): temporarily change titles of bookmarks for bar and menu so that the special well-known stored value is saved; guard with -[WebBookmarkGroup suppress/resumeNotifications]. (-[BookmarksController findOrCreateBookmarkSourceWithStoredTitle:displayedTitle:atIndex:]): modified to look first for well-known stored title and 2nd for displayed title; don't look for special UUIDs anymore. Death to special UUIDs. (-[BookmarksController updateBookmarkSources]): call findOrCreateBookmarkSourceWithStoredTitle:displayedTitle:atIndex: appropriately
  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt: updated for these changes and also for the big bookmark code-moving change earlier.
  • WebBrowser.pbproj/project.pbxproj: change encoding of AutoFillPreferences.m to Unicode so I can use a curly quote in an error message
  • Preferences.subproj/AutoFillPreferences.m: (-[AutoFillPreferences editMyCard:]): return of the curly quote now that I changed the file encoding properly
3:12 PM Changeset in webkit [3825]
  • 8 copies in tags/Safari-67~1

This commit was manufactured by cvs2svn to create tag 'Safari-67~1'.

3:12 PM Changeset in webkit [3824] by darin
  • 5 edits in branches/Safari-67~1-branch/WebCore
  • fixes for building with newer gcc
  • khtml/css/Makefile.am: Rolled in Makefile fix from main trunk.
  • khtml/css/parser.y: Rolled in inline build fix from main trunk.
  • khtml/css/parser.cpp: Regenerated.
3:03 PM Changeset in webkit [3823] by darin
  • 5 edits in trunk/WebCore

Reviewed by Dave.

  • khtml/rendering/bidi.cpp: (appendRun): Added an if statement to handle the case where obj is 0; the while loop already handled that case.
  • did the "no inlining workaround" needed for newer versions of gcc
  • khtml/css/parser.y: Added #define inline as we have elsewhere.
  • khtml/css/parser.cpp: Regenerated.
12:45 PM Changeset in webkit [3822] by hyatt
  • 3 edits in trunk/WebCore

Add color dumping and bgcolor dumping to the render dump tool.

Reviewed by darin

  • kwq/KWQRenderTreeDebug.cpp: (operator<<):
12:25 PM Changeset in webkit [3821] by hyatt
  • 10 edits in trunk/WebCore

Fix for 3193407, crash in CSS parser on www.hixie.ch. Improved the grammar to
understand the CSS3 :not selector so that it wouldn't think of that case as an
error. Also patched the error handling case that crashed on :not anyway. Then
I went ahead and implemented :not (since it was trivial to add once the parser
was reading it in).

Also fixed the regression that the * selector didn't work. The new KHTML trunk moved
away from a tag value of -1 in order to do @namespace support. Since we aren't really ready
to take that code yet, I patched our parser.y to treat * like -1 instead of 0xffff.

Implemented support for a couple of new CSS3 selectors, :root and ::selection. Also :last-child and :only-child.

Fixed a trivial bug (demonstrated in the CSS3 test suite) with the matching of the ~= selector.

Reviewed by darin

  • khtml/css/Makefile.am:
  • khtml/css/css_base.cpp: (CSSSelector::extractPseudoType):
  • khtml/css/css_base.h:
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_text.cpp: (TextRun::paintSelection): (RenderText::paintObject):
12:11 PM Changeset in webkit [3820] by sullivan
  • 3 edits
    1 delete in trunk/WebKit

WebKit:

Removed all the bookmarks code from WebKit; put it
in WebBrowser instead.

Reviewed by Darin

  • Bookmarks.subproj/WebBookmark.h: Removed.
  • Bookmarks.subproj/WebBookmark.m: Removed.
  • Bookmarks.subproj/WebBookmarkGroup.h: Removed.
  • Bookmarks.subproj/WebBookmarkGroup.m: Removed.
  • Bookmarks.subproj/WebBookmarkGroupPrivate.h: Removed.
  • Bookmarks.subproj/WebBookmarkImporter.h: Removed.
  • Bookmarks.subproj/WebBookmarkImporter.m: Removed.
  • Bookmarks.subproj/WebBookmarkLeaf.h: Removed.
  • Bookmarks.subproj/WebBookmarkLeaf.m: Removed.
  • Bookmarks.subproj/WebBookmarkList.h: Removed.
  • Bookmarks.subproj/WebBookmarkList.m: Removed.
  • Bookmarks.subproj/WebBookmarkPrivate.h: Removed.
  • Bookmarks.subproj/WebBookmarkProxy.h: Removed.
  • Bookmarks.subproj/WebBookmarkProxy.m: Removed.
  • WebKit.exp: removed all bookmark-related symbols
  • WebKit.pbproj/project.pbxproj: updated for removed files

WebBrowser:

Moved all the bookmarks code that was in WebKit
into WebBrowser. No code changes other than fixing
up #imports to make everything compile.

Reviewed by Darin

  • ABHomePagesController.m:
  • BookmarkSource.m:
  • BookmarksController.m:
  • BookmarksViewController.m:
  • BrowserDocument.m:
  • BrowserNSViewExtras.m:
  • BrowserWebBookmarkExtras.h:
  • BrowserWebBookmarkExtras.m:
  • BrowserWindowController.m:
  • ContextMenuHandler.m:
  • FavoritesBar.m:
  • FavoritesBarView.m:
  • GlobalHistory.m:
  • LocationTextField.m:
  • NewBookmarksController.m:
  • RendezvousController.m:
  • TitleBarButton.m:
  • URLCompletionController.m: Just fixed up #imports for moved bookmarks files.
  • WebBookmark.m:
  • WebBookmarkGroup.h:
  • WebBookmarkGroup.m:
  • WebBookmarkGroupPrivate.h:
  • WebBookmarkImporter.m:
  • WebBookmarkLeaf.h:
  • WebBookmarkLeaf.m:
  • WebBookmarkList.h:
  • WebBookmarkList.m:
  • WebBookmarkPrivate.h:
  • WebBookmarkProxy.h: These are the files that were moved (and had their #imports changed also). They don't say "New" because I moved the cvs history on the server first.
  • WebBrowser.pbproj/project.pbxproj: updated for files added to project
12:05 PM Changeset in webkit [3819] by sheridan
  • 3 edits in trunk

tree for Safari-68u is open

11:53 AM Changeset in webkit [3818]
  • 3 copies in branches/Safari-67~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-67~1-branch'.

11:53 AM Changeset in webkit [3817]
  • 3 copies in tags/Safari-67~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-67~1-anchor'.

11:53 AM Changeset in webkit [3816]
  • 3 copies in tags/Safari-67

This commit was manufactured by cvs2svn to create tag 'Safari-67'.

11:53 AM Changeset in webkit [3815] by sheridan
  • 8 edits in trunk

Safari-67 stamp

7:18 AM Changeset in webkit [3814] by darin
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3194451 -- Textarea COLS='40.0' displays with width of 0
  • khtml/xml/dom_stringimpl.h: Changed toInt to not be inline any more. It was already really too big for inline to be a good optimization.
  • khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::toInt): Rewrote this to find the valid characters at the start of the string, rather than strip invalid characters from the end. The old code would strip non-digits from the end, which doesn't help with a string like "40.0" or even "40 garbage3".
  • fixed a bit of int/long sloppiness
  • kwq/KWQString.mm: (QString::toLong): Use LONG_MAX, not INT_MAX. (QString::toULong): Use ULONG_MAX, not UINT_MAX.

Mar 12, 2003:

9:19 PM Changeset in webkit [3813] by mhay
  • 2 edits in trunk/WebKit/Bookmarks.subproj

First cut at importing Netscape and Mozilla bookmarks.

Reviewed by Darin Adler, John Sullivan

  • BookmarksController.h: Removed -(IBAction)importInternetExplorerFavorites:(id)sender; and replaced it with -(IBAction)importFavorites:(id)sender;
  • BookmarksController.m: (-[BookmarksController importFavoritesFrom:intoBookmarksFolder:settingPrefKey:]): (-[BookmarksController importIEFavorites]): (-[BookmarksController _computeNetscapeAndMozillaBookmarksPath]): (-[BookmarksController importNetscapeAndMozillaFavorites]): (-[BookmarksController importFavorites:]): (-[BookmarksController importFavoritesIfNecessary]): (-[BookmarksController awakeFromNib]): Rearranged/rewrote bookmark importing code to support multiple browser types.
  • PreferenceKeys.h: Added preference key to indicate that we had imported Netscape and Mozilla bookmarks.
  • Localizable.strings: Added localizable string used to name imported Netscape and Mozilla bookmarks folder.
  • DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Changed menu item "Import IE Favorites" to "Import Favorites". Changed action associated with that menu item from importInternetExplorerFavorites: to importFavorites:
  • WebBookmarkImporter.h: Defined constant strings used to import Netscape and Mozilla bookmarks.
  • WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]): Added return statement to avoid executing when we had no data.
4:14 PM Changeset in webkit [3812] by cblu
  • 4 edits in trunk/WebKit

3196673 - REGRESSION: Assertion failure when download fails to create file

  • Retain the download delegate because it will live longer than the WebController which it is an instance of.

Reviewed by rjw.

  • Downloads.subproj/WebDownload.m: (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): call _downloadStarted (-[WebDownload loadWithDelegate:]): call _downloadStarted (-[WebDownload _downloadStarted]): renamed from _loadStarted (-[WebDownload _downloadEnded]): release delegate (-[WebDownload resource:willSendRequest:]): reordered so if we are released in this method, we never call self (-[WebDownload resourceDidFinishLoading:]): don't call _loadEnded because _downloadEnded gets called in _didCloseFile and _cancelWithError (-[WebDownload resource:didFailLoadingWithError:]): don't call _loadEnded because _downloadEnded gets called in _didCloseFile and _cancelWithError (-[WebDownload _didCloseFile:]): call _downloadEnded (-[WebDownload _cancelWithError:]): call _downloadEnded
  • WebView.subproj/WebController.h: mention that the download delegate gets retained.
4:10 PM Changeset in webkit [3811] by rjw
  • 3 edits in trunk/WebCore

Fixed leak of RenderRoot.

Reviewed by darin.

  • kwq/KWQPageState.mm: (-[KWQPageState invalidate]): Added comment. (-[KWQPageState dealloc]): Ensure that the renderer is "re"set on the document so it will be correctly cleaned up in detach.
4:07 PM Changeset in webkit [3810] by hyatt
  • 4 edits in trunk/WebCore

Two fixes. The first is more help with macromedia. Floats could
get lost and not painted by the correct layer still. The new
code is more robust about checking if a layer crossing occurred
in the case where you want to addOverhangingFloats to a parent.

The second fix changes the priority of space allocation when
growing cells from their minwidths to their preferred widths.
The old code did fixed and then percent. The new code does
percent and then fixed.

Also when tables are overconstrained after growing cells to their
effective widths, instead of shrinking cells without regard for
their type, I implemented a shrink system that follows the same
priority (reversed) that was used when growing the cells originally.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::layout):
2:09 PM Changeset in webkit [3809] by trey
  • 3 edits in trunk/WebCore

WebCore:

3190784 REGRESSION: crash in KWQListIteratorImpl in form completion code at sonyericsson.com page

Don't crash on an input element with no enclosing form.

  • kwq/WebCoreBrid

(-[WebCoreBridge formForElement:]): Gracefully bail on !form.

WebBrowser:

3190784 REGRESSION: crash in KWQListIteratorImpl in form completion code at sonyericsson.com page

Don't crash on an input element with no enclosing form.

Reviewed by Chris.

  • FormCompletionController.m: (-[FormCompletionController initWithSourceField:frame:]): Bail out if form==nil.
11:40 AM Changeset in webkit [3808] by darin
  • 7 edits in trunk/WebKit

Reviewed by John.

  • fixed 3193552 -- REGRESSION: crash loading ftp directory URL
  • fixed minor problems with setDefersCallbacks handling and object lifetime
  • WebView.subproj/WebBaseResourceHandleDelegate.h: Removed now-unused cancelQuietly.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancel]): Changed cancel to tolerate being called when we have already cancelled. It's an error to call cancelWithError once we have cancelled.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]): Added. New function to create the WebError object for policy change. (-[WebMainResourceClient stopLoadingForPolicyChange]): Changed to just be a call to cancelWithError:. (-[WebMainResourceClient resource:willSendRequest:]): Call setDefersCallbacks:YES here; continueAfterNavigationPolicy already takes care of setDefersCallbacks:NO, but we lost this one somewhere along the way. (-[WebMainResourceClient continueAfterContentPolicy:response:]): Changed to call receivedError: on interruptForPolicyChangeError directly. It wasn't clearer to call a method named interruptForPolicyChange. (-[WebMainResourceClient resource:didReceiveResponse:]): Don't bother calling setDefersCallbacks:YES here any more; checkContentPolicyForResponse: takes care of that so there's no need to do it here. Initialize _contentLength before calling checkContentPolicyForResponse:, since that method can result in deallocating self.
9:50 AM Changeset in webkit [3807] by sullivan
  • 2 edits in trunk/WebKit

WebKit:

Reviewed by Trey

  • English.lproj/StringsNotToBeLocalized.txt: updated for recent changes

WebBrowser:

  • changed "Auto-fill" to "AutoFill" everywhere for consistency (Ron got to choose between "Auto Fill", "AutoFill", and "Auto-fill", and "AutoFill" won).

Reviewed by Trey

  • BrowserWindowController.m: (-[BrowserWindowController explainWhyAutoFillDidNothing]): Auto-fill -> AutoFill in sheet title & message
  • English.lproj/Browser.nib: Auto-fill -> "Automatically fill in" in tooltip for button
  • English.lproj/MainMenu.nib: Auto-fill -> AutoFill in menu
  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt: updated for these and earlier changes
Note: See TracTimeline for information about the timeline view.