Timeline



Mar 18, 2003:

11:23 PM Changeset in webkit [3863] by trey
  • 4 edits in trunk/WebKit

3077223 full keyboard UI navigation fails in authentication sheet

Hook up the views in this panel into a useful nextKeyView cycle.

Reviewed by Maciej.

  • Panels.subproj/English.lproj/WebAuthenticationPanel.nib:
11:05 PM Changeset in webkit [3862] by trey
  • 16 edits in trunk

WebCore:

Support for password saving in forms. Added elementIsPassword:,
nuked deadwood formIsLoginForm:.

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submit): Pass forms data for login forms and password fields to bridge. This case was skipped for security in khtml's autocomplete, but we need this data to save passwords, and we enforce policy at a higher level.
  • khtml/html/html_formimpl.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: Nuked formIsLoginForm:. (-[WebCoreBridge elementIsPassword:]): New utility.

WebKit:

Support for saving passwords on forms-based logins. Biggest change is that
the willSubmitForm: message is async to allow a sheet to be presented.

Also fixed @interface.*{ so prepare-change-log can swallow WebFramePrivate.m.

Reviewed by Maciej.

  • WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyDecisionListener continue]): The decision listener also implements WebFormSubmissionListener, to share some other impl.
  • WebView.subproj/WebControllerPolicyDelegatePrivate.h:
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:willSubmitForm:withValues:submissionListener:]): Take listener param for async API.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Latent bug. Don't call willSubmitForm if no values are being submitted. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Latent bug. Don't call willSubmitForm if no values are being submitted. (-[WebFrame _continueAfterWillSubmitForm:]): Continuation code for after FormDelegate is done with willSubmitForm. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Pass new listener arg to willSubmitForm.
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: Nuke deadwood formIsLoginForm. (-[WebHTMLRepresentation elementIsPassword:]): Just pass through glue over the bridge.

WebBrowser:

Password saving is implemented, with data saved in the keychain.
Lots of FIXMEs were either fixed or moved to Radar.

Reviewed by Chris.

  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Observe BrowserDocumentLoadingFinishedNotification. (-[BrowserWindowController frameLoadStarted:]): Cancel timer that would try to autofill the last page with a password. (-[BrowserWindowController frameLoadFinished:]): Start a timer that will try to autofill this page with a password. We use a short timer to avoid affecting the PLT. (-[BrowserWindowController tryToAutofillPasswords:]): Force keychain check of password protecting the ad-hoc data. Try to autocomplete any login form on the page. (-[FormDelegate frame:willSubmitForm:withValues:submissionListener:]): Pass new async listener param along to FormCompletionController.
  • CompletionController.m: (-[CompletionController _showMatchesWindow:]): Don't try to set an initial match if there wasn't one. (-[CompletionController completeString:]): Handle the case of a subclass specifying no initial match after a query.
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Nuke items for which we now have real prefs.
  • English.lproj/ABAutoCompleteMappings.plist: A tweak for better matching. No longer need to have both USA and U.S.A.
  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt:
  • FormCompletionController.h:
  • FormCompletionController.m: (urlFromFrame): New utility, just factored from other routines. (domainFromFrame): Call new utility. (authResourceFromFrame): New utility. (HTMLRepFromFrame): New utility, just factored from other routines. (dontSaveMarker): Return a magic username that indicates passwords are never saved for a particular AuthResource. (+[FormCompletionController setPasswordCompletionEnabled:]): Nuke NOP code. (viewContainsTextField): Utility to search view hierarchy for a text field. (+[FormCompletionController verifyKeychainAccessWithController:]): Read the AutoComplete encryption password, just to get the keychain nag out of the way. (+[FormCompletionController _cryptData:encode:]): Terminology - s/AutoComplete/AutoFill/ (+[FormCompletionController _reapABMarker:forFrame:fieldName:]): Deletes a stale AB marker that was detected. (+[FormCompletionController loginInfoForForm:inFrame:]): Return some info about the form if it is a login form. (+[FormCompletionController _frame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): Handle a login form being submitted. Runs a sheet for the user, or at least makes sure the one we are sending becomes the default item for the site. (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): After the sheet, possibly save the new item, or save a refusal marker so we never ask the user again for this site. Make sure to continue the submission. (+[FormCompletionController _frame:willSubmitRegularForm:withValues:]): Same code as what used to be in willSubmitForm, just factored here for the non-login case. (+[FormCompletionController frame:willSubmitForm:withValues:submissionListener:]): Branch to either the regular or login method. (+[FormCompletionController _addABMatchesToArray:forString:atABPointer:]): Subtle bug in how we inserted AB matches into the matches from completion data. We would sometimes errantly leave ABMarkers in this list, which became problematic now that we reap stale ones. Now we are willing to match an ABMatch against a literal string from the CompletionDB -AND- an ABMarker. (+[FormCompletionController _credentialMatchesForString:frame:]): Match the partialString against previous logins for this site. For these matches we insert WebCredentials into the matches array. (+[FormCompletionController _matchesForString:frame:fieldName:view:]): Call new utility routine. Reap any stale ABMarkers left over in the matches list. (stringFromMatch): Handle a Credential match. (matchComparator): Oops, should be case insensitive. (-[FormCompletionController queryResultsForString:startingMatch:]): Do a credential-based match if this is a login form. (+[FormCompletionController currentFrameAndForm:inController:]): Just factored code from autoFillInController. (+[FormCompletionController _autoFillPasswordInFrame:formInfo:]): Stick the default login and password into a form. (+[FormCompletionController autoFillInController:]): AutoFill a non-login form the same was as before (code was moved from elsewhere). AutoFill a login form too. (+[FormCompletionController autoFillPasswordInController:]): AutoFill, but only for login forms. (-[FormCompletionController initWithSourceField:frame:]): Use new utility to decide if this is a login form instead of WC routine. (-[FormCompletionController reflectSelectedRow]): If we are stuffing a username into a login form, stuff the password field too. (-[FormCompletionController finalMatchingStringForResult:]): FIXME -> Radar. (cookedPopupString): strip periods out of strings before we match popup values. (indexOfBestStringInArray): Use cookedPopupString for all matching. (-[AutoFillController _reflectAutoFillMatch:inView:fieldName:]): When stuffing a popup, be sure the action message is sent to get the right side-effects. (-[AutoFillController autoFill]): Use new utility routines. Return a more accurate result of whether we actually autofilled anything. (-[AutoFillController autoFillAddressStartingAtView:match:]): Use new utility routines. (+[FormToABBinder loadGlobalBinder]): FIXME -> Radar (-[FormToABBinder initWithPath:]): Cleanup SearchPass handling, so a non-specified SearchPass really behaves the same as a SearchPass==1.
10:18 PM Changeset in webkit [3861] by rjw
  • 38 edits
    4 deletes in trunk/WebKit

WebKit:

Another rename WebController*.[hm] to WebView*.[hm]

Reviewed by darin.

  • Carbon.subproj/HIWebView.h:
  • Misc.subproj/WebKit.h:
  • Misc.subproj/WebNSPasteboardExtras.m:
  • Panels.subproj/WebStandardPanelsPrivate.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginDocumentView.m:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
  • Plugins.subproj/WebNullPluginView.m:
  • Plugins.subproj/WebPluginController.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebController.h: Removed.
  • WebView.subproj/WebController.m: Removed.
  • WebView.subproj/WebControllerPrivate.h: Removed.
  • WebView.subproj/WebControllerPrivate.m: Removed.
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebDefaultResourceLoadDelegate.m:
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLView.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Another rename WebController*.[hm] to WebView*.[hm]

Reviewed by darin.

  • BrowserDocument.h:
  • BrowserDocument.m:
  • BrowserDocumentController.h:
  • BrowserWebController.h:
  • BrowserWebFrameExtras.m:
  • BrowserWebViewExtras.m:
  • BrowserWindowController.m:
  • ContextMenuHandler.m:
  • Debug/DebugUtilities.m:
  • Debug/SnippetController.m:
  • LoadProgressMonitor.m:
  • LocationChangeHandler.m:

Tests:

Another rename WebController*.[hm] to WebView*.[hm]

Reviewed by darin.

  • DumpBackForward/main.m:
  • DumpRenderTree/main.m:
  • IBViewer/DocumentController.m:
9:13 PM Changeset in webkit [3860] by rjw
  • 33 edits in trunk/WebKit

WebKit:

Renamed WebView*.[hm] to WebFrameView*.[hm]

Reviewed by me (I'm bad, it's just a file rename).

  • Misc.subproj/WebKit.h:
  • Misc.subproj/WebNSViewExtras.m:
  • Panels.subproj/WebStandardPanels.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginDocumentView.m:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNullPluginView.m:
  • Plugins.subproj/WebPluginController.m:
  • Plugins.subproj/WebPluginDatabase.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebControllerPrivate.m:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDebugDOMNode.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.h:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLView.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebRenderNode.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.h: Removed.
  • WebView.subproj/WebView.m: Removed.
  • WebView.subproj/WebViewPrivate.h: Removed.
  • WebView.subproj/WebViewPrivate.m: Removed.

WebBrowser:

Renamed WebView*.[hm] to WebFrameView*.[hm]

Reviewed by me (I'm bad, it's just a file rename).

  • BrowserDocument.m:
  • BrowserTabViewItem.m:
  • BrowserWebController.m:
  • BrowserWebViewExtras.h:
  • BrowserWindowController.m:
  • ContextMenuHandler.m:
  • Debug/ViewTree.m:
  • FormCompletionController.m:
  • LocationChangeHandler.m:

Tests:

Renamed WebView*.[hm] to WebFrameView*.[hm]

Reviewed by me (I'm bad, it's just a file rename).

  • DumpBackForward/main.m:
  • DumpRenderTree/main.m:
  • HeaderView/ApplicationController.m:
  • HeaderView/DocumentController.m:
  • IBViewer/ApplicationController.m:
  • PDFBundle/PDFView.m:
  • PDFViewer/ApplicationController.m:
  • PDFViewer/DocumentController.m:
  • PDFViewer/PDFRepresentation.m:
  • SimpleViewer/ApplicationController.m:
  • SimpleViewer/DocumentController.m:
  • SnippetEditor/ApplicationController.m:
  • SnippetEditor/SnippetController.m:
8:29 PM Changeset in webkit [3859] by rjw
  • 65 edits in trunk/WebKit

WebKit:

Stage 2 of WebController to WebView renaming.

Reviewed by hyatt.

  • API-Issues.rtf:
  • Carbon.subproj/HIWebView.h:
  • Carbon.subproj/HIWebView.m:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
  • Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels _didStartLoadingURL:inController:]): (-[WebStandardPanels _didStopLoadingURL:inController:]): (-[WebStandardPanels frontmostWindowLoadingURL:]):
  • Panels.subproj/WebStandardPanelsPrivate.h:
  • Plugins.subproj/WebBaseNetscapePluginView.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView controller]): (-[WebBaseNetscapePluginView loadPluginRequest:]):
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation isPluginViewStarted]): (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge mainFrame]): (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge showWindow]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge areScrollbarsVisible]): (-[WebBridge setScrollbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge runJavaScriptAlertPanelWithMessage:]): (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebBridge setStatusText:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge setWebFrame:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge userAgentForURL:]): (-[WebBridge nextKeyViewOutsideWebFrameViews]): (-[WebBridge previousKeyViewOutsideWebFrameViews]): (-[WebBridge defersLoading]): (-[WebBridge setDefersLoading:]): (-[WebBridge setNeedsReapplyStyles]): (-[WebBridge setNeedsLayout]): (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): (-[WebBridge handleMouseDragged:]): (-[WebBridge mayStartDragWithMouseDragged:]): (-[WebBridge historyLength]): (-[WebBridge goBackOrForward:]): (formDelegate):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
  • WebKit.exp:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebView _commonInitialization:frameName:groupName:]): (-[WebView initWithFrame:]): (-[WebView supportsTextEncoding]): (-[WebView userAgentForURL:]):
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebViewPrivate _clearControllerReferences:]): (+[WebView canShowFile:]): (+[WebView suggestedFileExtensionForMIMEType:]): (-[WebView _createFrameNamed:inParent:allowsScrolling:]): (-[WebView _findFrameNamed:]): (-[WebView _openNewWindowWithRequest:]): (-[WebView _menuForElement:]): (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView _frameForView:fromFrame:]):
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m: (+[WebControllerSets addController:toSetNamed:]): (+[WebControllerSets removeController:fromSetNamed:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _controller]): (-[WebDataSource _setController:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _layoutChildren]): (+[WebDataSource _repTypes]): (-[WebDataSource _receivedData:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]): (-[WebDefaultContextMenuDelegate downloadURL:]):
  • WebView.subproj/WebDefaultLocationChangeDelegate.m: (-[WebDefaultLocationChangeDelegate webView:locationChangeStartedForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:serverRedirectedForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:locationChangeCommittedForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:receivedPageTitle:forDataSource:]): (-[WebDefaultLocationChangeDelegate webView:receivedPageIcon:forDataSource:]): (-[WebDefaultLocationChangeDelegate webView:locationChangeDone:forDataSource:]): (-[WebDefaultLocationChangeDelegate webView:willCloseLocationForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:locationChangedWithinPageForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[WebDefaultLocationChangeDelegate webView:clientRedirectCancelledForFrame:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:inFrame:]): (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:willSendRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:pluginFailedWithError:dataSource:]):
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate webView:runJavaScriptConfirmPanelWithMessage:]): (-[WebDefaultWindowOperationsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[WebDefaultWindowOperationsDelegate webView:runOpenPanelForFileButtonWithResultListener:]):
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame init]): (-[WebFrame initWithName:webFrameView:webView:]): (-[WebFrame frameView]): (-[WebFrame webView]): (-[WebFrame findFrameNamed:]): (+[WebFrame registerViewClass:representationClass:forMIMEType:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (if): (switch):
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _controller]):
  • WebView.subproj/WebImageView.m: (-[WebImageView controller]): (-[WebImageView menuForEvent:]):
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:]):
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]):
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebFrameView setAllowsScrolling:]): (-[WebFrameView allowsScrolling]): (-[WebFrameView scrollView]): (-[WebFrameView documentView]): (-[WebFrameView drawRect:]): (-[WebFrameView setFrameSize:]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebFrameView _controller]): (-[WebFrameView _setDocumentView:]): (-[WebFrameView _setController:]): (-[WebFrameView _contentView]): (-[WebFrameView _verticalKeyboardScrollAmount]): (-[WebFrameView _horizontalKeyboardScrollAmount]): (-[WebFrameView _scrollToBottomLeft]): (+[WebFrameView _viewTypes]):
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Stage 2 of WebController to WebView renaming.

Reviewed by hyatt.

  • BrowserDocument.m: (-[BrowserDocument fileType]): (-[BrowserDocument mainWebFrameView]): (-[BrowserDocument text]):
  • BrowserTabViewItem.m: (-[BrowserTabViewItem webController]):
  • BrowserWebController.h:
  • BrowserWebController.m: (-[BrowserWebController webView:setStatusText:]): (-[BrowserWebController webViewStatusText:]): (-[BrowserWebController mouseoverTextForElement:modifierFlags:]): (-[BrowserWebController webView:mouseDidMoveOverElement:modifierFlags:]): (-[BrowserWebController webView:createWindowWithRequest:]): (-[BrowserWebController webViewCloseWindow:]): (-[BrowserWebController webViewShowWindow:]): (-[BrowserWebController webViewShowWindowBehindFrontmost:]): (-[BrowserWebController webViewFocusWindow:]): (-[BrowserWebController webViewUnfocusWindow:]): (-[BrowserWebController webViewFirstResponderInWindow:]): (-[BrowserWebController webView:makeFirstResponderInWindow:]): (-[BrowserWebController webViewIsResizable:]): (-[BrowserWebController webView:setResizable:]): (-[BrowserWebController webViewAreToolbarsVisible:]): (-[BrowserWebController webView:setToolbarsVisible:]): (-[BrowserWebController webViewIsStatusBarVisible:]): (-[BrowserWebController webView:setStatusBarVisible:]): (-[BrowserWebController mainWebFrameView]): (-[BrowserWebController webView:setFrame:]): (-[BrowserWebController webViewFrame:]): (-[BrowserWebController webView:runJavaScriptAlertPanelWithMessage:]): (-[BrowserWebController webView:runJavaScriptConfirmPanelWithMessage:]): (-[BrowserWebController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[BrowserWebController webView:runOpenPanelForFileButtonWithResultListener:]): (-[BrowserWebController webView:unableToImplementPolicyWithError:inFrame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): (-[BrowserWebController webView:decideContentPolicyForMIMEType:andRequest:inFrame:decisionListener:]): (-[BrowserWebController webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]): (-[BrowserWebController goToURL:withFallbackURLs:]):
  • BrowserWebFrameExtras.m: (-[WebFrame isMainFrame]):
  • BrowserWebViewExtras.m: (-[WebFrameView isScrollable]): (-[WebFrameView largestScrollableWebView]):
  • BrowserWindowController.m: (-[BrowserWindowController updateLabelForTab:]): (-[BrowserWindowController setUpTabForController:]): (-[BrowserWindowController bestWindowSizeForCurrentPageWithDefaultSize:]): (-[BrowserWindowController frameLoadStarted:]): (-[BrowserWindowController frameLoadCommitted:]): (-[BrowserWindowController closeTab:]): (-[BrowserWindowController closeOtherTabs:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController tabBarView:menuForClippedTabViewItems:]): (-[BrowserWindowController replaceTabSwitcher:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController orderedTabs]): (-[BrowserWindowController canReloadTab:]): (-[BrowserWindowController canReloadAllTabs]): (-[BrowserWindowController validateMenuItem:]):
  • ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler search:]): (-[ContextMenuHandler goToAddress:]):
  • Debug/DebugUtilities.m: (-[BrowserDocument setUserAgent:]): (-[BrowserDocument validate_setUserAgent:]):
  • Debug/Snippet.nib:
  • Debug/SnippetController.h:
  • Debug/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController load]): (-[SnippetController loadComplete]): (-[SnippetController mainDataSource]): (-[SnippetController webView:locationChangeDone:forDataSource:]):
  • FormCompletionController.h:
  • FormCompletionController.m: (+[FormCompletionController autoFillInController:]): (+[AutoFillController autoFillInController:]):
  • LoadProgressMonitor.m: (-[LoadProgressMonitor _monitorProvisionalDataSourceForFrame:]): (-[LoadProgressMonitor monitorFrame:]): (-[LoadProgressMonitor webView:identifierForInitialRequest:fromDataSource:]): (-[LoadProgressMonitor webView:resource:willSendRequest:fromDataSource:]): (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]): (-[LoadProgressMonitor webView:resource:didReceiveContentLength:fromDataSource:]): (-[LoadProgressMonitor webView:resource:didFinishLoadingFromDataSource:]): (-[LoadProgressMonitor webView:pluginFailedWithError:dataSource:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeStartedForDataSource:]): (-[LocationChangeHandler webView:locationChangeCommittedForDataSource:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): (-[LocationChangeHandler webView:willCloseLocationForDataSource:]): (-[LocationChangeHandler webView:receivedPageTitle:forDataSource:]): (-[LocationChangeHandler webView:receivedPageIcon:forDataSource:]): (-[LocationChangeHandler webView:serverRedirectedForDataSource:]): (-[LocationChangeHandler webView:locationChangedWithinPageForDataSource:]): (-[LocationChangeHandler webView:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[LocationChangeHandler webView:clientRedirectCancelledForFrame:]):

Tests:

Stage 2 of WebController to WebView renaming.

Reviewed by hyatt.

  • Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:identifierForInitialRequest:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didReceiveResponse:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didReceiveContentLength:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didFinishLoadingFromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didFailLoadingWithError:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:pluginFailedWithError:dataSource:]):
  • DumpBackForward/main.m: (main): (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): (-[CheapWindowOpsDelegate webView:createWindowWithRequest:]):
  • DumpRenderTree/main.m: (main): (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]):
  • HeaderView/ApplicationController.m:
  • HeaderView/DocumentController.h:
  • HeaderView/DocumentController.m: (-[DocumentController dealloc]): (-[DocumentController awakeFromNib]): (-[DocumentController loadURL:]): (-[DocumentController updateLayout]): (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
  • IBViewer/DocumentController.m: (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
  • PDFBundle/PDFView.m: (-[PDFView layout]):
  • PDFViewer/DocumentController.h:
  • PDFViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
  • PDFViewer/PDFRepresentation.m: (-[PDFView layout]):
  • SimpleViewer/DocumentController.h:
  • SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
  • SnippetEditor/SnippetController.h:
  • SnippetEditor/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController awakeFromNib]): (-[SnippetController _resetViews]): (-[SnippetController _updateTitleWithURL]): (-[SnippetController updateFromURL:]): (-[SnippetController updateFromText:]): (-[SnippetController loadComplete]): (-[SnippetController mainDataSource]): (-[SnippetController webView:locationChangeDone:forDataSource:]):
5:29 PM Changeset in webkit [3858] by mjs
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3119663 - document.lastModified returns the wrong date format
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): Instead of using NSDate's default date format, use the format that IE and Gecko use.
4:35 PM Changeset in webkit [3857] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Fix build, use size instead of length.
4:25 PM Changeset in webkit [3856] by darin
  • 2 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3187143 -- when a font-family has many variants, Safari chooses the wrong one
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]): Changed the algorithm here in two ways. 1) Pick the family member with matching traits that has a weight closest to 5, the standard weight; the old code picked the first family member with matching traits. 2) Match traits based on a mask of which traits are the important ones. The old code matched traits based on a rule of "if the trait bit is 1 it matters, otherwise don't care".
3:31 PM Changeset in webkit [3855] by mjs
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3080337 - default values seem to be "no" when third param of window.open is an empty string
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Treat empty string the same as missing for third argument - leave all chrome on. Also remove support for scrollbars= property
2:23 PM Changeset in webkit [3854] by darin
  • 2 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3194756 -- REGRESSION: Geneva bold yields Geneva plain, used to yield Helvetica bold (apple.com)
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]): Remove the first call to NSFontManager before we do our searching algorithm. We always need to do the searching, because NSFontManager uses a different set of rules.
2:13 PM Changeset in webkit [3853] by darin
  • 12 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3164522 -- text encoding conversion is done a chunk at a time with no state; won't work in some cases
  • fixed 3164557 -- pages served with encoding UTF-16LE but no BOM character won't be decoded correctly
  • fixed 3164569 -- pages without BOM that have a server-specified encoding of utf-16 will fail to decode
  • fixed 3165002 -- can't open link with tilde (~) in page with Japanese encoding
  • fixed 3181297 -- can't open link with backslash (\) in page with Japanese encoding (download at netscape.com)
  • fixed 3182977 -- "unicode" encoding handled as UTF-16 rather than UTF-8 at www.delcom-eng.com
  • khtml/misc/decoder.h: Add an optional "8-bit-only" parameter to the setEncoding method.
  • khtml/misc/decoder.cpp: (Decoder::setEncoding): Add an "8-bit-only" parameter. Use the new codeForNameEightBitOnly method when that parameter is true. Use the new usesVisualOrdering constant rather than all the hardcoded logic here to tell logical from visual Hebrew encodings. (Decoder::decode): Pass true for "8-bit-only" when the encoding came out of an HTML header, since we are already parsing the file by this point so it makes no sense to use a non-8-bit encoding. (Decoder::flush): Pass true for the "flush" parameter when calling the decoder.
  • kwq/KWQCharsets.h: Add a new KWQEncodingFlags enum, and return a parameter of that type (optionally) from KWQCFStringEncodingFromIANACharsetName.
  • kwq/KWQCharsets.mm: (buildDictionaries): Make the dictionaries lead to table entries so we can get both the flags and the encoding. (KWQCFStringEncodingFromIANACharsetName): Get the flags as well as the encoding. (KWQCFStringEncodingToIANACharsetName): Use the new dictionary format. (encodingNameHash): Removed special case for hash for 0. This was useful in JavaScriptCore where this hash function came from, but it's not relevant for a CF hash function.
  • kwq/KWQTextCodec.h: Added codecForNameEightBitOnly function to QTextCodec. Added optional KWQEncodingFlags parameter to QTextCodec constructor. Replaced isISOLatin1Hebrew with usesVisualOrdering. Added == and hash functions to QTextCodec. Added virtual destructor to QTextDecoder. Added optional "flush" boolean parameter to QTextDecoder's toUnicode function.
  • kwq/KWQTextCodec.mm: (codecForCFStringEncoding): Use both the encoding and the flags as a key for the dictionary that holds QTextCodec objects. (QTextCodec::codecForName): Pass flags through. (QTextCodec::codecForNameEightBitOnly): Added. Maps kCFStringEncodingUnicode to kCFStringEncodingUTF8. (QTextCodec::codecForLocale): Pass noEncodingFlags. (QTextCodec::makeDecoder): Pass flags to KWQTextDecoder constructor. (QTextCodec::toUnicode): Pass true for the "flush" boolean parameter to KWQTextDecoder. (operator==): Added. Compares both encoding and flags. (QTextCodec::hash): Added. Computes a hash of encoding and flags. (QTextCodecsEqual): Added. Calls operator==. (QTextCodecHash): Added. Calls hash member function. (QTextDecoder::~QTextDecoder): Added. Empty. (KWQTextDecoder::KWQTextDecoder): Made this no longer inline. (KWQTextDecoder::~KWQTextDecoder): Added. Cache the TEC object for use next time. (KWQTextDecoder::convertUTF16): Use the flags to decide on big vs. little endian when the page does not have a BOM marker that makes it unambiguous. (KWQTextDecoder::convertUsingTEC): Added flush parameter. Changed code to reuse the same converter for successive convert calls, and only flush when the flush parameter is passed. Added code to set the kUnicodeForceASCIIRangeMask. Do it directly since we can't use TECSetBasicOptions due to bug 3201405. (KWQTextDecoder::toUnicode): Pass flush parameter through.
  • kwq/mac-encodings.txt: Added new sections for "Unicode, bigEndian", "Unicode, littleEndian", and "ISOLatinHebrew, visualOrdering". Also moved UTF-16 to "Unicode" from "UTF8" since we now handle this with the "8-bit-only" mechanism.
  • kwq/make-charset-table.pl: Updated script to support flags (after a comma), and made it a bit more strict about what to do with ill-formed lines.
  • kwq/KWQCharsetData.c: Regenerated.
  • other changes
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsBeforeElement): Take advantage of "using" and remove unneeded namespace prefixes. (KWQKHTMLPart::matchLabelsAgainstElement): Ditto. (KWQKHTMLPart::pauseActions): Ditto. (KWQKHTMLPart::resumeActions): Add check for nil to match pauseActions. Also take advantage of "using" and remove unneeded namespace prefixes. (KWQKHTMLPart::saveWindowProperties): Use ERROR instead of ASSERT for the nil case. (KWQKHTMLPart::saveLocationProperties): Use ERROR instead of ASSERT for the nil case. (KWQKHTMLPart::restoreWindowProperties): Use ERROR instead of ASSERT for the nil case. (KWQKHTMLPart::restoreLocationProperties): Use ERROR instead of printf for the nil case. (KWQKHTMLPart::openURLFromPageCache): Take advantage of "using" and remove unneeded namespace prefixes. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Ditto. (KWQKHTMLPart::passSubframeEventToSubframe): Ditto.

Mar 17, 2003:

4:44 PM Changeset in webkit [3852] by cblu
  • 7 edits
    1 add in trunk/WebKit

WebKit:

Fixed: 3200647 - File I/O related download errors just says "error"

Reviewed by darin.

  • Downloads.subproj/WebDownload.m: (+[WebDownloadPrivate initialize]): call _registerWebKitErrors
  • English.lproj/Localizable.strings:
  • Misc.subproj/WebKitErrors.h: cleaned-up, removed unused errors
  • Misc.subproj/WebKitErrors.m: (+[WebError _registerWebKitErrors]): (registerErrors):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebView.m: (+[WebFrameView initialize]): call _registerWebKitErrors

WebBrowser:

Fixed: 3200647 - File I/O related download errors just says "error"

Reviewed by darin.

  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry dictionaryRepresentation]): store the error domain
3:28 PM Changeset in webkit [3851] by darin
  • 3 edits in trunk/WebKit

Reviewed by Chris and Richard.

  • fixed 3200611 -- Progress indicator in tabs not shown for subframe loads
  • WebView.subproj/WebDataSource.m: (-[WebDataSource isLoading]): Remove the early out for when we're in the WebFrameStateComplete state. The top frame being complete does not really tell us anything about whether subframes are complete, especially since they can have their locations changed without affecting the top level frame at all.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
11:33 AM Changeset in webkit [3850] by cblu
  • 2 edits in trunk/WebKit

Made data categories use the "_web_" prefix.

Reviewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): (-[NSData _web_startsWithBlankLine]): (-[NSData _web_locationAfterFirstBlankLine]):
11:18 AM Changeset in webkit [3849] by cblu
  • 2 edits in trunk/WebKit

WebFoundation:

Fixed: 3199105 - Accept carbon-style file URLs from plug-in POST requests
Fixed: 3148767 - POST (aka Flash Remoting) doesn't work from Flash

Reviewed by kocienda.

  • Misc.subproj/WebNSDataExtras.h:
  • Misc.subproj/WebNSDataExtras.m: (_findEOL): new (-[NSData _web_parseRFC822HeaderFields]): new
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_fixedCarbonPOSIXPath]): moved from WB (-[NSString _web_capitalizeRFC822HeaderFieldName]): new

WebKit:

Fixed: 3199105 - Accept carbon-style file URLs from plug-in POST requests
Fixed: 3148767 - POST (aka Flash Remoting) doesn't work from Flash

Reviewed by kocienda.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): parse headers, handle carbon POSIX paths (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): call _postURLNotify (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): call _postURLNotify (-[NSData startsWithBlankLine]): new (-[NSData locationAfterFirstBlankLine]): new

WebBrowser:

Renamed canonicalizedCarbonPOSIXPath to _web_fixedCarbonPOSIXPath and moved it down to WF.

Reviewed by ken.

  • AppController.m: (-[AppController handleURLEvent:withReplyEvent:]):
  • BrowserNSStringExtras.h:
  • BrowserNSStringExtras.m:
10:57 AM Changeset in webkit [3848] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fixed 3200259 - REGRESSION: Clicking on Flash links at homestarrunner.com creates blank windows
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): Don't always make the window, only do it if the frame doesn't already exist. Duh.
10:20 AM Changeset in webkit [3847] by darin
  • 3 edits in trunk/WebKit

Reviewed by Trey and Maciej.

  • fixed 3199154 -- REGRESSION: world leaks on any page load test
  • WebView.subproj/WebController.m: (-[WebController initWithView:frameName:groupName:]): Call through to initWithFrame, the designated initializer, not init. Calling [super init] results in calling our initWithFrame method, resulting in two calls to the _commonInitialization method.
9:53 AM Changeset in webkit [3846] by mjs
  • 2 edits in trunk/WebKit

WebFoundation:

Reviewed by Trey.

  • fixed 3199763 - Need to revise authentication API for form passwords
  • fixed a bunch of crashing and wrongful Keychain saving bugs found while testing
  • AuthenticationManager.subproj/WebAuthenticatingResource.h:
  • AuthenticationManager.subproj/WebAuthenticatingResource.m: (-[WebAuthenticatingResourcePrivate dealloc]): (-[WebAuthenticatingResource _internalInit]): (-[WebAuthenticatingResource initWithURL:realm:receivesCredentialSecurely:]): (-[WebAuthenticatingResource initWithProxyHost:port:type:realm:receivesCredentialSecurely:]): (-[WebAuthenticatingResource initWithHTMLFormURL:]): (-[WebAuthenticatingResource isProxy]): (-[WebAuthenticatingResource isHTMLForm]): (-[WebAuthenticatingResource host]): (-[WebAuthenticatingResource port]): (-[WebAuthenticatingResource type]): (-[WebAuthenticatingResource hash]): (-[WebAuthenticatingResource isEqual:]):
  • AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationHandlerDispatcher startAuthentication:]):
  • AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _usernameForRealm:URL:]): (-[WebAuthenticationManager _removePasswordForRealm:URL:]): (-[WebAuthenticationManager _removeProxyPasswordForURL:]): (-[WebAuthenticationManager _proxyResourceForURL:]): (-[WebAuthenticationManager _setDefaultUserInfoFromURL:]): (-[WebAuthenticationManager _invokeHandlersWithURL:realm:forRequest:failureCount:withCallback:context:]): (-[WebAuthenticationManager _invokeHandlersWithURL:proxy:forRequest:failureCount:withCallback:context:]): (-[WebAuthenticationManager WebAuthenticationRequest:useCredential:]):
  • AuthenticationManager.subproj/WebAuthenticationRequest.h:
  • AuthenticationManager.subproj/WebAuthenticationRequest.m: (-[WebAuthenticationRequestPrivate initWithResource:defaultUsername:previousFailureCount:delegate:]): (-[WebAuthenticationRequestPrivate dealloc]): (-[WebAuthenticationRequest _initWithResource:defaultUsername:previousFailureCount:delegate:]): (-[WebAuthenticationRequest resource]): (-[WebAuthenticationRequest defaultUsername]):
  • AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
  • AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _rootResourceForResource:]): (-[WebCredentialStorage _resourceWithKeychainItem:isDefault:]): (-[WebCredentialStorage _saveCredential:forResource:isDefault:]): (-[WebCredentialStorage removeCredential:forResource:]): (-[WebCredentialStorage setDefaultCredential:forResource:]):
  • Misc.subproj/WebNSURLExtras.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLByRemovingUserAndPath]):

WebKit:

Reviewed by Trey.

Adjusted for WebFoundation API changes.

  • Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]):
9:41 AM Changeset in webkit [3845] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
8:59 AM Changeset in webkit [3844] by cblu
  • 9 edits in trunk/WebKit

Fixed: 3199951 - Standalone plug-in content that is cancelled doesn't restart when switching tabs

Instead of creating and managing resourceData in WebMainResourceClient then passing the ownership to WebDataSource, just manage it in WebDataSource. We had the prior behavior because we didn't buffer downloads. Now, we always buffer. The fix for the bug is to retain the incomplete data even though the load ends in error.

Reviewed by darin.

  • WebView.subproj/WebDataSource.h: updated headerdoc for the data method
  • WebView.subproj/WebDataSource.m: (-[WebDataSource data]): just return resourceData
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): create resourceData if necessary, append data to it.
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): don't work with resourceData (-[WebMainResourceClient dealloc]): don't work with resourceData (-[WebMainResourceClient resource:didReceiveData:]): don't work with resourceData (-[WebMainResourceClient resourceDidFinishLoading:]): don't work with resourceData

Mar 16, 2003:

8:49 PM Changeset in webkit [3843] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3196050 - Hang in www.janegoodall.org dynamic menus
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::handleLocalEvents): Copy handlers before processing them, so we don't go into an infinite loop if a handler adds or removes handlers.
12:48 AM Changeset in webkit [3842] by trey
  • 8 edits in trunk

JavaScriptCore:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

WebFoundation:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

  • WebFoundation.pbproj/project.pbxproj:

WebCore:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

  • WebCore.pbproj/project.pbxproj:

WebKit:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

  • WebKit.pbproj/project.pbxproj:

WebBrowser:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.

Reviewed by Maciej.

  • WebBrowser.pbproj/project.pbxproj:

Mar 14, 2003:

6:37 PM Changeset in webkit [3841] by cblu
  • 2 edits in trunk/WebKit

Backed out changes to WebBaseNetscapePluginView. Unintentional commit.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]):
6:29 PM Changeset in webkit [3840] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3198961 - REGRESSION: Stopping load of plug-in content is not reflected in UI

Reviewed by mjs.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancelWithError:]): call receivedError so [dataSource _receivedError:error complete:YES] is called
6:06 PM Changeset in webkit [3839] by rjw
  • 3 edits in trunk/WebCore

Fixed 3197162. The regression was introduced with the change
to preferences. The old settings API was used to 'reset' the jscript
other properties of the part. This effectively always disabled
javascript and prevented properties from being restored to the js
property maps.

Reviewed by trey.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveWindowProperties): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreWindowProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::openURLFromPageCache):
3:28 PM Changeset in webkit [3838]
  • 13 copies in tags/Safari-66~1

This commit was manufactured by cvs2svn to create tag 'Safari-66~1'.

3:28 PM Changeset in webkit [3837] by mjs
  • 10 edits in branches/Safari-66~1-branch

top level:

Reviewed by Maciej.

  • remove leftover bits of NO_LICENSE
  • acconfig.h: Remove NO_LICENSE.
  • configure.in: Remove all the NO_LICENSE-related bits.

Tools:

  • Scripts/byteswap: Fixed a bug in the tool that Trey spotted. It wouldn't swap newline characters correctly.

JavaScriptCore:

Reviewed by Ken.

  • fixed 3193099 -- date parsing can't handle the time zone format that date formatting produces
  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Allow a "GMT" prefix before the time zone offset.

Tests:

  • TestURLs.h: Added more test URLs.
  • kde/kurl-test.chk: Added test results for the new URLs.

WebFoundation:

Reviewed by trey.

Added _web_changeFileAttributes:atPath and factored _web_changeFinderAttributes out to its own method.

  • Misc.subproj/WebNSFileManagerExtras.h:
  • Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_changeFinderAttributes:forFileAtPath:]): was _web_createFileAtPath (-[NSFileManager _web_changeFileAttributes:atPath:]): call createFileAtPath, then _web_changeFinderAttributes (-[NSFileManager _web_createFileAtPath:contents:attributes:]): call changeFileAttributes, then _web_changeFinderAttributes

WebCore:

Reviewed by John.

  • fixed 3166759 -- two fields both look like they have focus at webmail.iquest.net due to onblur
  • kwq/KWQTextField.mm: (-[KWQTextField selectText:]): Don't call -[NSTextField selectText:] in the case where we already have an editor, because the NSTextField version will cause the field to relinquish first responder and then take it back, which will send both onblur and onfocus. (-[KWQSecureTextField selectText:]): Same fix for the secure text field.

WebKit:

Reviewed by Dave.

  • fixed 3194221 - REGRESSION: search results loaded in wrong frame at directory.apple.com
  • WebView.subproj/WebFramePrivate.m: (_postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:): Deliver targetted form posts correctly.

WebBrowser:

First step of preferences reorganization. I added new empty
panes for AutoFill and Tabs. I added an Advanced pane and
moved the existing Style Sheet and Proxies controls and code
there. I made no other code changes yet.

Reviewed by Maciej

  • BookmarksController.m: (-[BookmarksController findOrCreateBookmarkSourceTitled:withUUID:index:]): Unrelated change -- once you've found the Bookmarks Menu or Bookmarks Bar folder, stop iterating. This code will be changed soon anyway due to 3192834.
  • Preferences.subproj/AdvancedPreferences.tiff: Added.
  • Preferences.subproj/AutoFillPreferences.tiff: Added.
  • Preferences.subproj/TabsPreferences.tiff: Added. new images for new preference panes
  • Preferences.subproj/AdvancedPreferences.h: Added.
  • Preferences.subproj/AdvancedPreferences.m: Added. (-[AdvancedPreferences sendProxyTabEventToPSN:]): (-[AdvancedPreferences openProxyPreferences:]): (-[AdvancedPreferences setStyleSheetPathPreference:]): (-[AdvancedPreferences styleSheetPathPreference]): (-[AdvancedPreferences updateStyleSheetMenu]): (-[AdvancedPreferences takeStyleSheetFromMenuItem:]): (-[AdvancedPreferences disableUserStyleSheet:]): (-[AdvancedPreferences choseStyleSheetFromPanel:returnCode:contextInfo:]): (-[AdvancedPreferences chooseStyleSheetFromFileBrowser:]): (-[AdvancedPreferences initializeFromDefaults]): (-[AdvancedPreferences isResizable]): Just cut/pasted code to here from AppearancePreferences (style sheet) and GeneralPreferences (proxies)
  • Preferences.subproj/AppearancePreferences.h:
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences initializeFromDefaults]): Cut out the style sheet code.
  • Preferences.subproj/GeneralPreferences.h:
  • Preferences.subproj/GeneralPreferences.m: (-[GeneralPreferences toggleAutoOpenDownloads:]): Cut out the proxies code.
  • Preferences.subproj/AutoFillPreferences.h: Added.
  • Preferences.subproj/AutoFillPreferences.m: Added. New empty husk of a class.
  • Preferences.subproj/TabsPreferences.h: Added.
  • Preferences.subproj/TabsPreferences.m: Added. New empty husk of a class.
  • Preferences.subproj/English.lproj/AutoFillPreferences.nib: Added. New empty husk of a preference pane.
  • Preferences.subproj/English.lproj/TabsPreferences.nib: Added. New empty husk of a preference pane.
  • Preferences.subproj/English.lproj/AdvancedPreferences.nib: Added. New preference pane, contains style sheet and proxies controls that formerly lived elsewhere. (Also a silly dividing line.)
  • Preferences.subproj/English.lproj/AppearancePreferences.nib: Removed style sheet control, shrunk window.
  • Preferences.subproj/English.lproj/GeneralPreferences.nib: Removed proxies control, shrunk window.
  • Preferences.subproj/WBPreferences.m: (-[WBPreferences init]): Create the three new panes.
  • WebBrowser.pbproj/project.pbxproj: updated for new files.
  • English.lproj/Localizable.strings: updated for names of new panes.
3:27 PM Changeset in webkit [3836] by hyatt
  • 3 edits in trunk/WebCore

Make :target match the root element if no #fragment is specified in
the URL.

Reviewed by john

  • khtml/css/cssstyleselector.cpp:
3:08 PM Changeset in webkit [3835] by mjs
  • 4 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • fixed 3190846 - REGRESSION: can't use Fidelity NetBenefits account
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Treat javascript: URLs as about:blank for now. (HTMLFrameElementImpl::attach): Likewise.
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Make sure to send completed() signal after signals are connectd in synchronous load case.
1:53 PM Changeset in webkit [3834] by mjs
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Don.

  • revert premature controller --> webView renaming, it's causing problems with window opening and such.
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m:

WebBrowser:

Reviewed by Don.

  • add controller: argument to a method that now needs it.

(informal protocols suck!)

  • BrowserWebController.m: (-[BrowserWebController controller:runOpenPanelForFileButtonWithResultListener:]):
12:13 PM Changeset in webkit [3833] by hyatt
  • 4 edits in trunk/WebCore

Fix for ew.com, hrweb and arstechnica forums. A <br> should
not create a nonempty line in the case where the previous line
didn't break cleanly. The fix is to have a new boolean that
tracks how the previous line broke and to have <br> check that
to figure out if it should set the line to be non-empty.

Reviewed by gramps

  • khtml/rendering/bidi.cpp:
11:28 AM Changeset in webkit [3832] by cblu
  • 7 edits in trunk/WebKit

Fixed: 3197872 - Standalone plug-in content isn't restarted when switching tabs
Fixed: 3189675 - assertion in plug-in code fails (nil window) with .swf page displaying standalone in a tab

We start plug-ins when they are added to the window and stop them when they are removed. To restart a plug-in, the data stream must be redelivered. This works in the embedded plug-in case, but in the standalone plug-in case, the stream is delivered by the machinery in WebKit. The stream is only delivered once. This fix addresses that.

Reviewed by trey.

  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): reset the offset ivar (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): If we create a file for the plug-in, handle the case where the file is already created.
  • Plugins.subproj/WebBaseNetscapePluginView.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView isStarted]): added so the stream knows the state of the view
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView initWithFrame:]): tweak (-[WebNetscapePluginDocumentView viewDidMoveToWindow]): call redeliverStream if we are added back to the window (-[WebNetscapePluginDocumentView setDataSource:]): only start the plug-in if we are in a window, don't assert
  • Plugins.subproj/WebNetscapePluginRepresentation.h:
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation dealloc]): release the retained data source and error (-[WebNetscapePluginRepresentation setDataSource:]): retain the data source (-[WebNetscapePluginRepresentation isPluginViewStarted]): new (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): only do work if isPluginViewStarted (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): retain the error, only do work if isPluginViewStarted (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]): only do work if isPluginViewStarted
(-[WebNetscapePluginRepresentation redeliverStream]): call receivedData
with all the received data up to this point. Call receivedError:: or finishedLoadingWithDataSource: if the load is already complete.
Note: See TracTimeline for information about the timeline view.