Timeline



Mar 22, 2003:

6:07 PM Changeset in webkit [3899] by hyatt
  • 3 edits in trunk/WebCore

Loosen up the DTD for <dl>, <dt>, and <dd> so that they can
occur anywhere in a document and be independent of one
another.

Reviewed by darin/gramps

  • khtml/html/dtd.cpp: (DOM::checkChild):
3:27 PM Changeset in webkit [3898] by hyatt
  • 7 edits in trunk/WebCore

Bottom border/padding was incorrectly being used in float
computations. The fix is trivial... positioning of floats
occurs before you add in the bottom border/padding rather
than after.

Also implementing support for transparent borders and adding
code that understands how to draw more complex polys when
individual sides are transparent. This code existed for left
and right borders, but not for top and bottom borders.

These two fixes make the tantek demo found at:

​http://www.tantek.com/map.html

work properly for the first time in Safari.

Reviewed by darin

  • ChangeLog:
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_object.cpp: (RenderObject::paintBorder):
  • khtml/rendering/render_style.h:

Mar 21, 2003:

5:37 PM Changeset in webkit [3897] by hyatt
  • 12 edits in trunk/WebCore

Fixes for all 4 macromedia rendering problems. They were all
related to buggy float handling.

The bugs are 3194998, 3195014, 3915155, 3204114.

This patch splits floats and positioned elements into two lists
instead of 1, and it also adds better logic for clearing out
floats when blocks move vertically.

Reviewed by darin

  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::detach):
  • khtml/rendering/render_flow.cpp: (RenderFlow::addChildWithContinuation):
  • khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::nodeAtPoint):
  • khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::removeFromObjectLists): (RenderObject::nodeAtPoint):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_root.cpp: (RenderRoot::layout):
  • khtml/rendering/render_table.cpp: (RenderTable::layout):
3:25 PM Changeset in webkit [3896] by cblu
  • 9 edits in trunk/WebKit

WebFoundation:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

  • Misc.subproj/WebNSDataExtras.m: (-[NSData _web_guessedMIMEType]): sniff for vcards and ical files
  • types.plist: added text/calendar and text/vcard

WebKit:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _representationClassForMIMEType:]): was _canShowMIMEType
  • WebView.subproj/WebFrameViewPrivate.h:
  • WebView.subproj/WebFrameViewPrivate.m: (+[WebFrameView _viewClassForMIMEType:]): was _canShowMIMEType
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (+[WebTextView unshowableMIMETypes]): new, returns text types that shouldn't be shown
  • WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): call unshowableMIMETypes

WebBrowser:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

  • Preferences.subproj/WBPreferences.m: (+[WBPreferences shouldOpenFileAtPath:]): auto-open vcf and ics
2:09 PM Changeset in webkit [3895] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3203212 -- nil-deref in khtml::CachedImage::isErrorImage at turbotax.com
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeImage): Remove all occurrences of the image from the list. We don't try to prevent multiple occurrences from getting in there. Also use removeRef instead of remove, for speed.
9:42 AM Changeset in webkit [3894]
  • 2 copies
    2 deletes in tags/JavaScriptCore-68-tarball

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-68-tarball'.

9:42 AM Changeset in webkit [3893] by darin
  • 1 edit in branches/JavaScriptCore-68-tarball-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Update project file for tarball.

9:39 AM Changeset in webkit [3892]
  • 4 copies
    2 deletes in tags/WebCore-68

This commit was manufactured by cvs2svn to create tag 'WebCore-68'.

9:39 AM Changeset in webkit [3891] by darin
  • 1 edit in branches/WebCore-68-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

Updated project file for tarball.

9:31 AM Changeset in webkit [3890] by darin
  • 4 edits in branches/Safari-68~1-branch/WebKit

Rolled in change from trunk.

2003-03-20 Vicki Murley <​vicki@apple.com>

don't include WebFoundation.h

Reviewed by cblu.

  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
9:26 AM Changeset in webkit [3889] by darin
  • 6 edits in trunk/WebCore

WebFoundation:

Reviewed by John.

  • fixed 3204660 -- EUC decoding not used for japanese yahoo page
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_characterSetFromContentTypeHeader]): Do the search for charset= in a case-insensitive way. It's possible that other browsers are case-insensitive, but also possible that it's just Japanese auto-detect that papers over this problem there.
  • other changes
  • Database.subproj/WebLRUFileList.m: (cStringHash): Get rid of unnecessary code to avoid hashes of 0. This is helpful in the place in JavaScriptCore where we copied this from, but it is not helpful here (slightly ugly and does slow things down a smidgen).

WebCore:

Reviewed by John.

  • fixed 3204660 -- EUC decoding not used for japanese yahoo page
  • khtml/misc/decoder.cpp: (Decoder::decode): Do the search for charset= in a case-insensitive way. It's possible that other browsers are case-insensitive, but also possible that it's just Japanese auto-detect that papers over this problem there.
  • other changes
  • kwq/KWQString.mm: (QString::hash): Get rid of unnecessary code to avoid hashes of 0. This is useful in the place in JavaScriptCore where we copied this from, but it is not helpful here (slightly ugly and does slow things down a smidgen).
  • kwq/WebCoreTextRendererFactory.m: Remove unused method.
12:46 AM Changeset in webkit [3888] by hyatt
  • 3 edits in trunk/WebCore

Fix the color handling of link= attributes on <body> elements
to pass in the quirks mode so that lax parsing can take place.

Reviewed by rjw and john

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):

Mar 20, 2003:

7:39 PM Changeset in webkit [3887] by rjw
  • 22 edits in trunk

WebKit:

Use "Item" consistently in the WebHistory and WebBackForwardList.
Change createSharedHistoryWithFile: to setSharedHistory:
Make the various page cache methods per WebBackForwardList instead of global.

Reviewed by gramps.

  • History.subproj/WebBackForwardList.h:
  • History.subproj/WebBackForwardList.m: (-[WebBackForwardListPrivate dealloc]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToItem:]): (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (-[WebBackForwardList containsItem:]): (-[WebBackForwardList maximumSize]): (-[WebBackForwardList setMaximumSize:]): (-[WebBackForwardList description]): (-[WebBackForwardList clearPageCache]): (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]): (-[WebBackForwardList setUsesPageCache:]): (-[WebBackForwardList usesPageCache]): (-[WebBackForwardList backListCount]): (-[WebBackForwardList forwardListCount]): (-[WebBackForwardList itemAtIndex:]):
  • History.subproj/WebHistory.h:
  • History.subproj/WebHistory.m: (-[_WebCoreHistoryProvider containsItemForURLString:]): (+[WebHistory setSharedHistory:]): (-[WebHistory addItemForURL:]): (-[WebHistory addItem:]): (-[WebHistory removeItem:]): (-[WebHistory removeItems:]): (-[WebHistory removeAllItems]): (-[WebHistory addItems:]): (-[WebHistory orderedItemsLastVisitedOnDay:]): (-[WebHistory containsItemForURLString:]): (-[WebHistory itemForURL:]):
  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryPrivate.h:
  • History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate insertItem:atDateIndex:]): (-[WebHistoryPrivate removeItemForURLString:]): (-[WebHistoryPrivate addItem:]): (-[WebHistoryPrivate removeItem:]): (-[WebHistoryPrivate removeItems:]): (-[WebHistoryPrivate removeAllItems]): (-[WebHistoryPrivate addItems:]): (-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]): (-[WebHistoryPrivate containsItemForURLString:]): (-[WebHistoryPrivate itemForURL:]): (-[WebHistoryPrivate _loadHistoryGuts:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge goBackOrForward:]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _canCachePage]): (-[WebFrame _purgePageCache]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _resetBackForwardListToCurrent]):
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView _commonInitialization:frameName:groupName:]): (-[WebView setMaintainsBackForwardList:]): (-[WebView goBack]): (-[WebView goForward]):

WebCore:

Use "Item" consistently in the WebHistory and WebBackForwardList.
Change createSharedHistoryWithFile: to setSharedHistory:
Make the various page cache methods per WebBackForwardList instead of global.

Reviewed by gramps.

  • kwq/KWQKHistoryProvider.mm:
  • kwq/WebCoreHistory.h:

WebBrowser:

Use "Item" consistently in the WebHistory and WebBackForwardList.
Change createSharedHistoryWithFile: to setSharedHistory:
Make the various page cache methods per WebBackForwardList instead of global.

Reviewed by gramps.

  • AppController.m: (-[AppController confirmResetSafari:]):
  • BrowserDocument.m: (-[BrowserDocument canGoBack]): (-[BrowserDocument canGoForward]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]): (-[BrowserDocument goToItem:]): (-[BrowserDocument backListMenuForButton:]):
  • BrowserWebController.m: (-[BrowserWebController snapBackTo:]): (-[BrowserWebController setPageForSnapBackToCurrentPage:]): (-[BrowserWebController canSnapBackToPage]): (-[BrowserWebController setSearchResultsForSnapBackToCurrentPage]): (-[BrowserWebController canSnapBackToSearchResults]):
  • ContextMenuHandler.m: (-[ContextMenuHandler addLinkToBookmarks:]):
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument validate_toggleBackForwardEnabled:]):
  • GlobalHistory.m: (-[GlobalHistory _registerForHistoryNotifications]): (-[GlobalHistory init]): (-[GlobalHistory _entriesFromMixedItems:]): (-[GlobalHistory _addItemsForDate:toMenu:skip:limit:]): (-[GlobalHistory _removeEntries:]): (-[GlobalHistory _undoRemoveEntries:]): (-[GlobalHistory deleteContentItems:withUndoManager:]): (-[GlobalHistory child:ofContentItem:]): (-[GlobalHistory numberOfChildrenOfContentItem:]):
  • URLCompletionController.m: (+[URLCompletionController _loadDB]): (+[URLCompletionController _registerForNotifications]):
7:04 PM Changeset in webkit [3886] by rjw
  • 1 edit in trunk/WebKit/API-Issues.rtf

Notes to self.

4:15 PM Changeset in webkit [3885] by cblu
  • 4 edits in trunk/WebKit

WebKit:

Properly handle file URL directory errors.

Reviewed by trey.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): when file URL has no path, return generic file icon
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]): set the URL, don't set it to nil!

WebBrowser:

Fixed: 3204064 - REGRESSION: PDF URL is left in location for after download
Properly handle file URL directory errors.

Reviewed by darin.

  • BrowserWebController.m: (-[BrowserWebController expectedOrCurrentURL]): don't use the URL of the provisional data source if it is not loading.
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): tweak, use [NSWorkspace isFilePackageAtPath:] instead of LaunchServices because it is easier.
2:21 PM Changeset in webkit [3884] by hyatt
  • 3 edits in trunk/WebCore

Always do residual style fixups in all three Safari rendering
modes.

Reviewed by darin

  • khtml/html/htmlparser.cpp: (KHTMLParser::popBlock):
2:18 PM Changeset in webkit [3883] by vicki
  • 4 edits in trunk/WebKit

don't include WebFoundation.h

Reviewed by cblu.

  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
11:44 AM Changeset in webkit [3882] by sheridan
  • 3 edits in trunk

Safari-69 begins

10:50 AM Changeset in webkit [3881]
  • 3 copies
    2 deletes in branches/WebCore-68-tarball-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-68-tarball-branch'.

10:50 AM Changeset in webkit [3880]
  • 3 copies
    2 deletes in tags/WebCore-68-tarball-anchor

This commit was manufactured by cvs2svn to create tag
'WebCore-68-tarball-anchor'.

10:50 AM Changeset in webkit [3879]
  • 3 copies in branches/Safari-68~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-68~1-branch'.

10:50 AM Changeset in webkit [3878]
  • 3 copies in tags/Safari-68~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-68~1-anchor'.

10:50 AM Changeset in webkit [3877]
  • 3 copies in tags/Safari-68

This commit was manufactured by cvs2svn to create tag 'Safari-68'.

10:50 AM Changeset in webkit [3876]
  • 1 copy
    2 deletes in branches/JavaScriptCore-68-tarball-branch

This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-68-tarball-branch'.

10:50 AM Changeset in webkit [3875]
  • 1 copy
    2 deletes in tags/JavaScriptCore-68-tarball-anchor

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-68-tarball-anchor'.

10:50 AM Changeset in webkit [3874] by sheridan
  • 8 edits in trunk

Safari-68

8:52 AM Changeset in webkit [3873] by darin
  • 2 edits in trunk/WebKit

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebKit:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

Mar 19, 2003:

7:20 PM Changeset in webkit [3872] by voas
  • 5 edits
    1 delete in trunk/WebKit

2003-03-19 Ed Voas ​voas@apple.com

Reviewed by Richard.

React to WebView API changes. Redo HIWebView API.

  • Carbon.subproj/HIWebView.h:
  • Carbon.subproj/HIWebView.m: (if): (switch):
  • Carbon.subproj/HIWebViewPriv.h: Removed.
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
7:02 PM Changeset in webkit [3871] by hyatt
  • 3 edits in trunk/WebCore

Adding a few more tags to the list of ones to check for
residual style.

Reviewed by gramps

  • khtml/html/htmlparser.cpp: (KHTMLParser::isResidualStyleTag): (KHTMLParser::isAffectedByResidualStyle):
6:55 PM Changeset in webkit [3870] by rjw
  • 4 edits in trunk/WebKit

WebKit:

Removed initWithView:* constructors from WebView.
New designated initializer for WebView is initWithFrame:frameName:groupName:

Reviewed by cblu & ed.

  • Carbon.subproj/HIWebView.m:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView init]): (-[WebView initWithFrame:]):

WebBrowser:

Updated Safari to use the new designated initializer for WebView. Simplified
many places that used to reference the WebFrameView.

Reviewed by cblu.

  • BrowserTabViewItem.m: (-[BrowserTabViewItem webController]):
  • BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]):
  • BrowserWindowController.m: (-[BrowserWindowController mainWebFrameView]): (-[BrowserWindowController updateLabelForTab:]): (-[BrowserWindowController setUpTabForController:]): (-[BrowserWindowController closeTab:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController findTabForWebController:]): (-[BrowserWindowController reloadTab:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController orderedTabs]): (-[BrowserWindowController canReloadTab:]):
6:13 PM Changeset in webkit [3869] by hyatt
  • 8 edits in trunk/WebCore

Fix continuations so that they are smarter about reusing
anonymous blocks. Avoids deep nesting when it isn't
necessary.

A complete implementation of the residual style fixes. It
seems to fix all current outstanding bugs.

One of the bugs in the residual style list was caused by
font-weight not being reset to tables and is actually its
own problem. I fixed that by moving the quirks resets for
table elements into the quirks stylesheet (which should be
a speed boost).

<b><p>Foo</b> Goo</p>

Also fixed the huge XML failure issue that made us fail hundreds
of test cases. Attachment of text nodes was being done way too
early, before the text of the node had been determined. By moving
the attachment from enterText to exitText, the problem is solved.

Reviewed by darin (res. style fix 1) and gramps (rest of res. style fix and XML fix)

  • ChangeLog:
  • khtml/css/quirks.css:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::attach):
  • khtml/html/htmlparser.cpp: (KHTMLParser::isResidualStyleTag): (KHTMLParser::isAffectedByResidualStyle): (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks): (KHTMLParser::reopenResidualStyleTags): (KHTMLParser::popBlock): (KHTMLParser::popOneBlock):
  • khtml/html/htmlparser.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::splitFlow):
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::enterText): (XMLHandler::exitText):
5:14 PM Changeset in webkit [3868] by rjw
  • 17 edits
    3 deletes in trunk/WebKit

WebKit:

Rename WebControllerPolicyDelegate*.[hm] to WebPolicyDelegate*.[hm]

Reviewed by trey.

  • API-Issues.rtf:
  • Misc.subproj/WebKit.h:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebControllerPolicyDelegate.h: Removed.
  • WebView.subproj/WebControllerPolicyDelegate.m: Removed.
  • WebView.subproj/WebControllerPolicyDelegatePrivate.h: Removed.
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.h:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebPolicyDelegate.m:
  • WebView.subproj/WebPolicyDelegatePrivate.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

Rename WebControllerPolicyDelegate*.[hm] to WebPolicyDelegate*.[hm]

Reviewed by trey.

  • BrowserWebController.m:
4:45 PM Changeset in webkit [3867] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed 3202780 -- REGRESSION: progress bar, stop button, both get stuck in "loading" state (bartsoft.com)
  • WebView.subproj/WebDataSource.m: (-[WebDataSource isLoading]): Add back the "is this page complete" check, so that subresource loads don't make us think we're loading again, once the page is complete. On the other hand, frames must still be checked independent of the "is this page complete" flag to avoid reintroducing bug 3200611.
3:11 PM Changeset in webkit [3866] by voas
  • 5 edits in trunk/WebKit

2003-03-19 Ed Voas ​voas@apple.com

Reviewed by Richard.

Got it working in non-compositing mode as well, so in theory it
can work inside a PowerPlant application as well. It's a bit of what
I'd consider a hack, but it's pretty straightforward.

  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter setViewsNeedDisplay:]):
  • Carbon.subproj/HIViewAdapter.h:
  • Carbon.subproj/HIViewAdapter.m: (+[HIViewAdapter bindHIViewToNSView:nsView:]): (-[HIViewAdapter setNeedsDisplay:]): (-[HIViewAdapter setNeedsDisplayInRect:]): (SetViewNeedsDisplay):
  • Carbon.subproj/HIWebView.m: (if):
9:04 AM Changeset in webkit [3865] by darin
  • 7 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3197684 -- <textarea wrap="hard"> behaves incorrectly (bugzilla)

By doing the line breaking inside the KWQ class for textarea we can both remove
the broken lineOfCharAtIndex: method and avoid the n-squared algorithm KHTML uses to
insert hard line breaks.

  • khtml/rendering/render_form.cpp: (RenderTextArea::text): Call textWithHardLineBreaks on widget instead of trying to break lines here.
  • kwq/KWQTextEdit.h: Added textWithHardLineBreaks member function. Made text member function const. Got rid of text(int), paragraphs, paragraphLength, and lineOfChar member functions.
  • kwq/KWQTextEdit.mm: (QTextEdit::text): Made this const, and move code that transforms CRLF and CR into LF inside KWQTextArea. (QTextEdit::textWithHardLineBreaks): Added. Calls new textWithHardLineBreaks method.
  • kwq/KWQTextArea.h: Added textWithHardLineBreaks method. Removed numLines, textForLine:, paragrahs, paragraphLength:, textForParagraph:, and lineOfCharAtIndex: methods.
  • kwq/KWQTextArea.mm: (-[KWQTextArea initWithQTextEdit:]): Call [self init] for clarity instead of [super init]. In both cases, we end up calling [self initWithFrame:]. (-[KWQTextArea text]): Added logic for transforming CRLF and CR into LF here instead of at the KWQTextEdit level. (-[KWQTextArea textWithHardLineBreaks]): Added. This method uses the layout manager to extract the characters for one line at a time, and put line breaks in between.
1:06 AM Changeset in webkit [3864] by mjs
  • 6 edits in trunk

WebCore:

Reviewed by Trey.

  • fixed 3146407 - bring the window with the targeted frame to the front
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): If we use an existing frame, focus it.
  • kwq/WebCoreBridge.h: Prototype focusWindow method.

WebKit:

Reviewed by Trey.

  • fixed 3127431 - bring the window with the named frame to the front
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge focusWindow]): Tell the window operations delegate to focus. (-[WebBridge loadURL:referrer:reload:target:triggeringEvent:form:formValues:]): If this navigation is meant for a different frame, focus its window. (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Likewise.

WebBrowser:

Reviewed by Trey.

  • fixed 3127431 - bring the window with the named frame to the front
  • set main frame name properly for targeted links opened in tabs
  • BrowserDocument.h:
  • BrowserDocument.m:

(-[BrowserDocument createWebControllerWithFrameName:]): New method.
(-[BrowserDocument createWebController]): Reimplement in terms of above.

  • BrowserDocumentController.m: (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]): Pass main frame name for tabs too.
  • BrowserWebController.m: (-[BrowserWebController windowController]): Move to higher in the file. (-[BrowserWebController webViewFocusWindow:]): Switch tabs too.
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController createTabWithFrameName:andShow:]): Added frameName parameter. (-[BrowserWindowController createTabWithFrameName:]): New method. (-[BrowserWindowController createInactiveTabWithFrameName:]): New method. (-[BrowserWindowController createTab]): Pass nil frame name. (-[BrowserWindowController createInactiveTab]): Likewise.

Mar 18, 2003:

11:23 PM Changeset in webkit [3863] by trey
  • 4 edits in trunk/WebKit

3077223 full keyboard UI navigation fails in authentication sheet

Hook up the views in this panel into a useful nextKeyView cycle.

Reviewed by Maciej.

  • Panels.subproj/English.lproj/WebAuthenticationPanel.nib:
11:05 PM Changeset in webkit [3862] by trey
  • 16 edits in trunk

WebCore:

Support for password saving in forms. Added elementIsPassword:,
nuked deadwood formIsLoginForm:.

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::submit): Pass forms data for login forms and password fields to bridge. This case was skipped for security in khtml's autocomplete, but we need this data to save passwords, and we enforce policy at a higher level.
  • khtml/html/html_formimpl.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: Nuked formIsLoginForm:. (-[WebCoreBridge elementIsPassword:]): New utility.

WebKit:

Support for saving passwords on forms-based logins. Biggest change is that
the willSubmitForm: message is async to allow a sheet to be presented.

Also fixed @interface.*{ so prepare-change-log can swallow WebFramePrivate.m.

Reviewed by Maciej.

  • WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyDecisionListener continue]): The decision listener also implements WebFormSubmissionListener, to share some other impl.
  • WebView.subproj/WebControllerPolicyDelegatePrivate.h:
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:willSubmitForm:withValues:submissionListener:]): Take listener param for async API.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Latent bug. Don't call willSubmitForm if no values are being submitted. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Latent bug. Don't call willSubmitForm if no values are being submitted. (-[WebFrame _continueAfterWillSubmitForm:]): Continuation code for after FormDelegate is done with willSubmitForm. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Pass new listener arg to willSubmitForm.
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: Nuke deadwood formIsLoginForm. (-[WebHTMLRepresentation elementIsPassword:]): Just pass through glue over the bridge.

WebBrowser:

Password saving is implemented, with data saved in the keychain.
Lots of FIXMEs were either fixed or moved to Radar.

Reviewed by Chris.

  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Observe BrowserDocumentLoadingFinishedNotification. (-[BrowserWindowController frameLoadStarted:]): Cancel timer that would try to autofill the last page with a password. (-[BrowserWindowController frameLoadFinished:]): Start a timer that will try to autofill this page with a password. We use a short timer to avoid affecting the PLT. (-[BrowserWindowController tryToAutofillPasswords:]): Force keychain check of password protecting the ad-hoc data. Try to autocomplete any login form on the page. (-[FormDelegate frame:willSubmitForm:withValues:submissionListener:]): Pass new async listener param along to FormCompletionController.
  • CompletionController.m: (-[CompletionController _showMatchesWindow:]): Don't try to set an initial match if there wasn't one. (-[CompletionController completeString:]): Handle the case of a subclass specifying no initial match after a query.
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Nuke items for which we now have real prefs.
  • English.lproj/ABAutoCompleteMappings.plist: A tweak for better matching. No longer need to have both USA and U.S.A.
  • English.lproj/Localizable.strings:
  • English.lproj/StringsNotToBeLocalized.txt:
  • FormCompletionController.h:
  • FormCompletionController.m: (urlFromFrame): New utility, just factored from other routines. (domainFromFrame): Call new utility. (authResourceFromFrame): New utility. (HTMLRepFromFrame): New utility, just factored from other routines. (dontSaveMarker): Return a magic username that indicates passwords are never saved for a particular AuthResource. (+[FormCompletionController setPasswordCompletionEnabled:]): Nuke NOP code. (viewContainsTextField): Utility to search view hierarchy for a text field. (+[FormCompletionController verifyKeychainAccessWithController:]): Read the AutoComplete encryption password, just to get the keychain nag out of the way. (+[FormCompletionController _cryptData:encode:]): Terminology - s/AutoComplete/AutoFill/ (+[FormCompletionController _reapABMarker:forFrame:fieldName:]): Deletes a stale AB marker that was detected. (+[FormCompletionController loginInfoForForm:inFrame:]): Return some info about the form if it is a login form. (+[FormCompletionController _frame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): Handle a login form being submitted. Runs a sheet for the user, or at least makes sure the one we are sending becomes the default item for the site. (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): After the sheet, possibly save the new item, or save a refusal marker so we never ask the user again for this site. Make sure to continue the submission. (+[FormCompletionController _frame:willSubmitRegularForm:withValues:]): Same code as what used to be in willSubmitForm, just factored here for the non-login case. (+[FormCompletionController frame:willSubmitForm:withValues:submissionListener:]): Branch to either the regular or login method. (+[FormCompletionController _addABMatchesToArray:forString:atABPointer:]): Subtle bug in how we inserted AB matches into the matches from completion data. We would sometimes errantly leave ABMarkers in this list, which became problematic now that we reap stale ones. Now we are willing to match an ABMatch against a literal string from the CompletionDB -AND- an ABMarker. (+[FormCompletionController _credentialMatchesForString:frame:]): Match the partialString against previous logins for this site. For these matches we insert WebCredentials into the matches array. (+[FormCompletionController _matchesForString:frame:fieldName:view:]): Call new utility routine. Reap any stale ABMarkers left over in the matches list. (stringFromMatch): Handle a Credential match. (matchComparator): Oops, should be case insensitive. (-[FormCompletionController queryResultsForString:startingMatch:]): Do a credential-based match if this is a login form. (+[FormCompletionController currentFrameAndForm:inController:]): Just factored code from autoFillInController. (+[FormCompletionController _autoFillPasswordInFrame:formInfo:]): Stick the default login and password into a form. (+[FormCompletionController autoFillInController:]): AutoFill a non-login form the same was as before (code was moved from elsewhere). AutoFill a login form too. (+[FormCompletionController autoFillPasswordInController:]): AutoFill, but only for login forms. (-[FormCompletionController initWithSourceField:frame:]): Use new utility to decide if this is a login form instead of WC routine. (-[FormCompletionController reflectSelectedRow]): If we are stuffing a username into a login form, stuff the password field too. (-[FormCompletionController finalMatchingStringForResult:]): FIXME -> Radar. (cookedPopupString): strip periods out of strings before we match popup values. (indexOfBestStringInArray): Use cookedPopupString for all matching. (-[AutoFillController _reflectAutoFillMatch:inView:fieldName:]): When stuffing a popup, be sure the action message is sent to get the right side-effects. (-[AutoFillController autoFill]): Use new utility routines. Return a more accurate result of whether we actually autofilled anything. (-[AutoFillController autoFillAddressStartingAtView:match:]): Use new utility routines. (+[FormToABBinder loadGlobalBinder]): FIXME -> Radar (-[FormToABBinder initWithPath:]): Cleanup SearchPass handling, so a non-specified SearchPass really behaves the same as a SearchPass==1.
10:18 PM Changeset in webkit [3861] by rjw
  • 38 edits
    4 deletes in trunk/WebKit

WebKit:

Another rename WebController*.[hm] to WebView*.[hm]

Reviewed by darin.

  • Carbon.subproj/HIWebView.h:
  • Misc.subproj/WebKit.h:
  • Misc.subproj/WebNSPasteboardExtras.m:
  • Panels.subproj/WebStandardPanelsPrivate.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginDocumentView.m:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
  • Plugins.subproj/WebNullPluginView.m:
  • Plugins.subproj/WebPluginController.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebController.h: Removed.
  • WebView.subproj/WebController.m: Removed.
  • WebView.subproj/WebControllerPrivate.h: Removed.
  • WebView.subproj/WebControllerPrivate.m: Removed.
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebDefaultResourceLoadDelegate.m:
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLView.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Another rename WebController*.[hm] to WebView*.[hm]

Reviewed by darin.

  • BrowserDocument.h:
  • BrowserDocument.m:
  • BrowserDocumentController.h:
  • BrowserWebController.h:
  • BrowserWebFrameExtras.m:
  • BrowserWebViewExtras.m:
  • BrowserWindowController.m:
  • ContextMenuHandler.m:
  • Debug/DebugUtilities.m:
  • Debug/SnippetController.m:
  • LoadProgressMonitor.m:
  • LocationChangeHandler.m:

Tests:

Another rename WebController*.[hm] to WebView*.[hm]

Reviewed by darin.

  • DumpBackForward/main.m:
  • DumpRenderTree/main.m:
  • IBViewer/DocumentController.m:
9:13 PM Changeset in webkit [3860] by rjw
  • 33 edits in trunk/WebKit

WebKit:

Renamed WebView*.[hm] to WebFrameView*.[hm]

Reviewed by me (I'm bad, it's just a file rename).

  • Misc.subproj/WebKit.h:
  • Misc.subproj/WebNSViewExtras.m:
  • Panels.subproj/WebStandardPanels.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginDocumentView.m:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNullPluginView.m:
  • Plugins.subproj/WebPluginController.m:
  • Plugins.subproj/WebPluginDatabase.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.m:
  • WebView.subproj/WebControllerPrivate.m:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDebugDOMNode.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.h:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLView.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebRenderNode.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.h: Removed.
  • WebView.subproj/WebView.m: Removed.
  • WebView.subproj/WebViewPrivate.h: Removed.
  • WebView.subproj/WebViewPrivate.m: Removed.

WebBrowser:

Renamed WebView*.[hm] to WebFrameView*.[hm]

Reviewed by me (I'm bad, it's just a file rename).

  • BrowserDocument.m:
  • BrowserTabViewItem.m:
  • BrowserWebController.m:
  • BrowserWebViewExtras.h:
  • BrowserWindowController.m:
  • ContextMenuHandler.m:
  • Debug/ViewTree.m:
  • FormCompletionController.m:
  • LocationChangeHandler.m:

Tests:

Renamed WebView*.[hm] to WebFrameView*.[hm]

Reviewed by me (I'm bad, it's just a file rename).

  • DumpBackForward/main.m:
  • DumpRenderTree/main.m:
  • HeaderView/ApplicationController.m:
  • HeaderView/DocumentController.m:
  • IBViewer/ApplicationController.m:
  • PDFBundle/PDFView.m:
  • PDFViewer/ApplicationController.m:
  • PDFViewer/DocumentController.m:
  • PDFViewer/PDFRepresentation.m:
  • SimpleViewer/ApplicationController.m:
  • SimpleViewer/DocumentController.m:
  • SnippetEditor/ApplicationController.m:
  • SnippetEditor/SnippetController.m:
8:29 PM Changeset in webkit [3859] by rjw
  • 65 edits in trunk/WebKit

WebKit:

Stage 2 of WebController to WebView renaming.

Reviewed by hyatt.

  • API-Issues.rtf:
  • Carbon.subproj/HIWebView.h:
  • Carbon.subproj/HIWebView.m:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
  • Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels _didStartLoadingURL:inController:]): (-[WebStandardPanels _didStopLoadingURL:inController:]): (-[WebStandardPanels frontmostWindowLoadingURL:]):
  • Panels.subproj/WebStandardPanelsPrivate.h:
  • Plugins.subproj/WebBaseNetscapePluginView.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView controller]): (-[WebBaseNetscapePluginView loadPluginRequest:]):
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation isPluginViewStarted]): (-[WebNetscapePluginRepresentation receivedData:withDataSource:]):
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge mainFrame]): (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge showWindow]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge areScrollbarsVisible]): (-[WebBridge setScrollbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge runJavaScriptAlertPanelWithMessage:]): (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebBridge setStatusText:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge setWebFrame:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge userAgentForURL:]): (-[WebBridge nextKeyViewOutsideWebFrameViews]): (-[WebBridge previousKeyViewOutsideWebFrameViews]): (-[WebBridge defersLoading]): (-[WebBridge setDefersLoading:]): (-[WebBridge setNeedsReapplyStyles]): (-[WebBridge setNeedsLayout]): (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): (-[WebBridge handleMouseDragged:]): (-[WebBridge mayStartDragWithMouseDragged:]): (-[WebBridge historyLength]): (-[WebBridge goBackOrForward:]): (formDelegate):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
  • WebKit.exp:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
  • WebView.subproj/WebContextMenuDelegate.h:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebView _commonInitialization:frameName:groupName:]): (-[WebView initWithFrame:]): (-[WebView supportsTextEncoding]): (-[WebView userAgentForURL:]):
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebViewPrivate _clearControllerReferences:]): (+[WebView canShowFile:]): (+[WebView suggestedFileExtensionForMIMEType:]): (-[WebView _createFrameNamed:inParent:allowsScrolling:]): (-[WebView _findFrameNamed:]): (-[WebView _openNewWindowWithRequest:]): (-[WebView _menuForElement:]): (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView _frameForView:fromFrame:]):
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m: (+[WebControllerSets addController:toSetNamed:]): (+[WebControllerSets removeController:fromSetNamed:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _controller]): (-[WebDataSource _setController:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _layoutChildren]): (+[WebDataSource _repTypes]): (-[WebDataSource _receivedData:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]): (-[WebDefaultContextMenuDelegate downloadURL:]):
  • WebView.subproj/WebDefaultLocationChangeDelegate.m: (-[WebDefaultLocationChangeDelegate webView:locationChangeStartedForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:serverRedirectedForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:locationChangeCommittedForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:receivedPageTitle:forDataSource:]): (-[WebDefaultLocationChangeDelegate webView:receivedPageIcon:forDataSource:]): (-[WebDefaultLocationChangeDelegate webView:locationChangeDone:forDataSource:]): (-[WebDefaultLocationChangeDelegate webView:willCloseLocationForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:locationChangedWithinPageForDataSource:]): (-[WebDefaultLocationChangeDelegate webView:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[WebDefaultLocationChangeDelegate webView:clientRedirectCancelledForFrame:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:inFrame:]): (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:willSendRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:pluginFailedWithError:dataSource:]):
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate webView:runJavaScriptConfirmPanelWithMessage:]): (-[WebDefaultWindowOperationsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[WebDefaultWindowOperationsDelegate webView:runOpenPanelForFileButtonWithResultListener:]):
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame init]): (-[WebFrame initWithName:webFrameView:webView:]): (-[WebFrame frameView]): (-[WebFrame webView]): (-[WebFrame findFrameNamed:]): (+[WebFrame registerViewClass:representationClass:forMIMEType:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (if): (switch):
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _controller]):
  • WebView.subproj/WebImageView.m: (-[WebImageView controller]): (-[WebImageView menuForEvent:]):
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:]):
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebTextView.m: (-[WebTextView menuForEvent:]):
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebFrameView setAllowsScrolling:]): (-[WebFrameView allowsScrolling]): (-[WebFrameView scrollView]): (-[WebFrameView documentView]): (-[WebFrameView drawRect:]): (-[WebFrameView setFrameSize:]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebFrameView _controller]): (-[WebFrameView _setDocumentView:]): (-[WebFrameView _setController:]): (-[WebFrameView _contentView]): (-[WebFrameView _verticalKeyboardScrollAmount]): (-[WebFrameView _horizontalKeyboardScrollAmount]): (-[WebFrameView _scrollToBottomLeft]): (+[WebFrameView _viewTypes]):
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Stage 2 of WebController to WebView renaming.

Reviewed by hyatt.

  • BrowserDocument.m: (-[BrowserDocument fileType]): (-[BrowserDocument mainWebFrameView]): (-[BrowserDocument text]):
  • BrowserTabViewItem.m: (-[BrowserTabViewItem webController]):
  • BrowserWebController.h:
  • BrowserWebController.m: (-[BrowserWebController webView:setStatusText:]): (-[BrowserWebController webViewStatusText:]): (-[BrowserWebController mouseoverTextForElement:modifierFlags:]): (-[BrowserWebController webView:mouseDidMoveOverElement:modifierFlags:]): (-[BrowserWebController webView:createWindowWithRequest:]): (-[BrowserWebController webViewCloseWindow:]): (-[BrowserWebController webViewShowWindow:]): (-[BrowserWebController webViewShowWindowBehindFrontmost:]): (-[BrowserWebController webViewFocusWindow:]): (-[BrowserWebController webViewUnfocusWindow:]): (-[BrowserWebController webViewFirstResponderInWindow:]): (-[BrowserWebController webView:makeFirstResponderInWindow:]): (-[BrowserWebController webViewIsResizable:]): (-[BrowserWebController webView:setResizable:]): (-[BrowserWebController webViewAreToolbarsVisible:]): (-[BrowserWebController webView:setToolbarsVisible:]): (-[BrowserWebController webViewIsStatusBarVisible:]): (-[BrowserWebController webView:setStatusBarVisible:]): (-[BrowserWebController mainWebFrameView]): (-[BrowserWebController webView:setFrame:]): (-[BrowserWebController webViewFrame:]): (-[BrowserWebController webView:runJavaScriptAlertPanelWithMessage:]): (-[BrowserWebController webView:runJavaScriptConfirmPanelWithMessage:]): (-[BrowserWebController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:]): (-[BrowserWebController webView:runOpenPanelForFileButtonWithResultListener:]): (-[BrowserWebController webView:unableToImplementPolicyWithError:inFrame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): (-[BrowserWebController webView:decideContentPolicyForMIMEType:andRequest:inFrame:decisionListener:]): (-[BrowserWebController webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]): (-[BrowserWebController goToURL:withFallbackURLs:]):
  • BrowserWebFrameExtras.m: (-[WebFrame isMainFrame]):
  • BrowserWebViewExtras.m: (-[WebFrameView isScrollable]): (-[WebFrameView largestScrollableWebView]):
  • BrowserWindowController.m: (-[BrowserWindowController updateLabelForTab:]): (-[BrowserWindowController setUpTabForController:]): (-[BrowserWindowController bestWindowSizeForCurrentPageWithDefaultSize:]): (-[BrowserWindowController frameLoadStarted:]): (-[BrowserWindowController frameLoadCommitted:]): (-[BrowserWindowController closeTab:]): (-[BrowserWindowController closeOtherTabs:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController tabBarView:menuForClippedTabViewItems:]): (-[BrowserWindowController replaceTabSwitcher:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController orderedTabs]): (-[BrowserWindowController canReloadTab:]): (-[BrowserWindowController canReloadAllTabs]): (-[BrowserWindowController validateMenuItem:]):
  • ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler search:]): (-[ContextMenuHandler goToAddress:]):
  • Debug/DebugUtilities.m: (-[BrowserDocument setUserAgent:]): (-[BrowserDocument validate_setUserAgent:]):
  • Debug/Snippet.nib:
  • Debug/SnippetController.h:
  • Debug/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController load]): (-[SnippetController loadComplete]): (-[SnippetController mainDataSource]): (-[SnippetController webView:locationChangeDone:forDataSource:]):
  • FormCompletionController.h:
  • FormCompletionController.m: (+[FormCompletionController autoFillInController:]): (+[AutoFillController autoFillInController:]):
  • LoadProgressMonitor.m: (-[LoadProgressMonitor _monitorProvisionalDataSourceForFrame:]): (-[LoadProgressMonitor monitorFrame:]): (-[LoadProgressMonitor webView:identifierForInitialRequest:fromDataSource:]): (-[LoadProgressMonitor webView:resource:willSendRequest:fromDataSource:]): (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]): (-[LoadProgressMonitor webView:resource:didReceiveContentLength:fromDataSource:]): (-[LoadProgressMonitor webView:resource:didFinishLoadingFromDataSource:]): (-[LoadProgressMonitor webView:pluginFailedWithError:dataSource:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeStartedForDataSource:]): (-[LocationChangeHandler webView:locationChangeCommittedForDataSource:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): (-[LocationChangeHandler webView:willCloseLocationForDataSource:]): (-[LocationChangeHandler webView:receivedPageTitle:forDataSource:]): (-[LocationChangeHandler webView:receivedPageIcon:forDataSource:]): (-[LocationChangeHandler webView:serverRedirectedForDataSource:]): (-[LocationChangeHandler webView:locationChangedWithinPageForDataSource:]): (-[LocationChangeHandler webView:clientWillRedirectTo:delay:fireDate:forFrame:]): (-[LocationChangeHandler webView:clientRedirectCancelledForFrame:]):

Tests:

Stage 2 of WebController to WebView renaming.

Reviewed by hyatt.

  • Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:identifierForInitialRequest:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didReceiveResponse:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didReceiveContentLength:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didFinishLoadingFromDataSource:]): (-[MyWebResourceLoadAdapter webView:resource:didFailLoadingWithError:fromDataSource:]): (-[MyWebResourceLoadAdapter webView:pluginFailedWithError:dataSource:]):
  • DumpBackForward/main.m: (main): (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): (-[CheapWindowOpsDelegate webView:createWindowWithRequest:]):
  • DumpRenderTree/main.m: (main): (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]):
  • HeaderView/ApplicationController.m:
  • HeaderView/DocumentController.h:
  • HeaderView/DocumentController.m: (-[DocumentController dealloc]): (-[DocumentController awakeFromNib]): (-[DocumentController loadURL:]): (-[DocumentController updateLayout]): (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
  • IBViewer/DocumentController.m: (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
  • PDFBundle/PDFView.m: (-[PDFView layout]):
  • PDFViewer/DocumentController.h:
  • PDFViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
  • PDFViewer/PDFRepresentation.m: (-[PDFView layout]):
  • SimpleViewer/DocumentController.h:
  • SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:locationChangeStartedForDataSource:]): (-[DocumentController webView:receivedPageTitle:forDataSource:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]): (-[DocumentController webView:resource:didFinishLoadingFromDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
  • SnippetEditor/SnippetController.h:
  • SnippetEditor/SnippetController.m: (-[SnippetController dealloc]): (-[SnippetController windowWillClose:]): (-[SnippetController awakeFromNib]): (-[SnippetController _resetViews]): (-[SnippetController _updateTitleWithURL]): (-[SnippetController updateFromURL:]): (-[SnippetController updateFromText:]): (-[SnippetController loadComplete]): (-[SnippetController mainDataSource]): (-[SnippetController webView:locationChangeDone:forDataSource:]):
5:29 PM Changeset in webkit [3858] by mjs
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3119663 - document.lastModified returns the wrong date format
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): Instead of using NSDate's default date format, use the format that IE and Gecko use.
4:35 PM Changeset in webkit [3857] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Fix build, use size instead of length.
4:25 PM Changeset in webkit [3856] by darin
  • 2 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3187143 -- when a font-family has many variants, Safari chooses the wrong one
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]): Changed the algorithm here in two ways. 1) Pick the family member with matching traits that has a weight closest to 5, the standard weight; the old code picked the first family member with matching traits. 2) Match traits based on a mask of which traits are the important ones. The old code matched traits based on a rule of "if the trait bit is 1 it matters, otherwise don't care".
3:31 PM Changeset in webkit [3855] by mjs
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3080337 - default values seem to be "no" when third param of window.open is an empty string
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Treat empty string the same as missing for third argument - leave all chrome on. Also remove support for scrollbars= property
2:23 PM Changeset in webkit [3854] by darin
  • 2 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3194756 -- REGRESSION: Geneva bold yields Geneva plain, used to yield Helvetica bold (apple.com)
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]): Remove the first call to NSFontManager before we do our searching algorithm. We always need to do the searching, because NSFontManager uses a different set of rules.
2:13 PM Changeset in webkit [3853] by darin
  • 12 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3164522 -- text encoding conversion is done a chunk at a time with no state; won't work in some cases
  • fixed 3164557 -- pages served with encoding UTF-16LE but no BOM character won't be decoded correctly
  • fixed 3164569 -- pages without BOM that have a server-specified encoding of utf-16 will fail to decode
  • fixed 3165002 -- can't open link with tilde (~) in page with Japanese encoding
  • fixed 3181297 -- can't open link with backslash (\) in page with Japanese encoding (download at netscape.com)
  • fixed 3182977 -- "unicode" encoding handled as UTF-16 rather than UTF-8 at www.delcom-eng.com
  • khtml/misc/decoder.h: Add an optional "8-bit-only" parameter to the setEncoding method.
  • khtml/misc/decoder.cpp: (Decoder::setEncoding): Add an "8-bit-only" parameter. Use the new codeForNameEightBitOnly method when that parameter is true. Use the new usesVisualOrdering constant rather than all the hardcoded logic here to tell logical from visual Hebrew encodings. (Decoder::decode): Pass true for "8-bit-only" when the encoding came out of an HTML header, since we are already parsing the file by this point so it makes no sense to use a non-8-bit encoding. (Decoder::flush): Pass true for the "flush" parameter when calling the decoder.
  • kwq/KWQCharsets.h: Add a new KWQEncodingFlags enum, and return a parameter of that type (optionally) from KWQCFStringEncodingFromIANACharsetName.
  • kwq/KWQCharsets.mm: (buildDictionaries): Make the dictionaries lead to table entries so we can get both the flags and the encoding. (KWQCFStringEncodingFromIANACharsetName): Get the flags as well as the encoding. (KWQCFStringEncodingToIANACharsetName): Use the new dictionary format. (encodingNameHash): Removed special case for hash for 0. This was useful in JavaScriptCore where this hash function came from, but it's not relevant for a CF hash function.
  • kwq/KWQTextCodec.h: Added codecForNameEightBitOnly function to QTextCodec. Added optional KWQEncodingFlags parameter to QTextCodec constructor. Replaced isISOLatin1Hebrew with usesVisualOrdering. Added == and hash functions to QTextCodec. Added virtual destructor to QTextDecoder. Added optional "flush" boolean parameter to QTextDecoder's toUnicode function.
  • kwq/KWQTextCodec.mm: (codecForCFStringEncoding): Use both the encoding and the flags as a key for the dictionary that holds QTextCodec objects. (QTextCodec::codecForName): Pass flags through. (QTextCodec::codecForNameEightBitOnly): Added. Maps kCFStringEncodingUnicode to kCFStringEncodingUTF8. (QTextCodec::codecForLocale): Pass noEncodingFlags. (QTextCodec::makeDecoder): Pass flags to KWQTextDecoder constructor. (QTextCodec::toUnicode): Pass true for the "flush" boolean parameter to KWQTextDecoder. (operator==): Added. Compares both encoding and flags. (QTextCodec::hash): Added. Computes a hash of encoding and flags. (QTextCodecsEqual): Added. Calls operator==. (QTextCodecHash): Added. Calls hash member function. (QTextDecoder::~QTextDecoder): Added. Empty. (KWQTextDecoder::KWQTextDecoder): Made this no longer inline. (KWQTextDecoder::~KWQTextDecoder): Added. Cache the TEC object for use next time. (KWQTextDecoder::convertUTF16): Use the flags to decide on big vs. little endian when the page does not have a BOM marker that makes it unambiguous. (KWQTextDecoder::convertUsingTEC): Added flush parameter. Changed code to reuse the same converter for successive convert calls, and only flush when the flush parameter is passed. Added code to set the kUnicodeForceASCIIRangeMask. Do it directly since we can't use TECSetBasicOptions due to bug 3201405. (KWQTextDecoder::toUnicode): Pass flush parameter through.
  • kwq/mac-encodings.txt: Added new sections for "Unicode, bigEndian", "Unicode, littleEndian", and "ISOLatinHebrew, visualOrdering". Also moved UTF-16 to "Unicode" from "UTF8" since we now handle this with the "8-bit-only" mechanism.
  • kwq/make-charset-table.pl: Updated script to support flags (after a comma), and made it a bit more strict about what to do with ill-formed lines.
  • kwq/KWQCharsetData.c: Regenerated.
  • other changes
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsBeforeElement): Take advantage of "using" and remove unneeded namespace prefixes. (KWQKHTMLPart::matchLabelsAgainstElement): Ditto. (KWQKHTMLPart::pauseActions): Ditto. (KWQKHTMLPart::resumeActions): Add check for nil to match pauseActions. Also take advantage of "using" and remove unneeded namespace prefixes. (KWQKHTMLPart::saveWindowProperties): Use ERROR instead of ASSERT for the nil case. (KWQKHTMLPart::saveLocationProperties): Use ERROR instead of ASSERT for the nil case. (KWQKHTMLPart::restoreWindowProperties): Use ERROR instead of ASSERT for the nil case. (KWQKHTMLPart::restoreLocationProperties): Use ERROR instead of printf for the nil case. (KWQKHTMLPart::openURLFromPageCache): Take advantage of "using" and remove unneeded namespace prefixes. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Ditto. (KWQKHTMLPart::passSubframeEventToSubframe): Ditto.
Note: See TracTimeline for information about the timeline view.