Timeline



Mar 23, 2003:

12:02 AM Changeset in webkit [3900] by hyatt
  • 3 edits in trunk/WebCore

Fix the top of the gamespot.com page on the PLT. The
clear status for <br> should be ignored if/when we decide
to ignore the <br> because the previous line didn't break
cleanly.

Reviewed by gramps

  • khtml/rendering/bidi.cpp:

Mar 22, 2003:

6:07 PM Changeset in webkit [3899] by hyatt
  • 3 edits in trunk/WebCore

Loosen up the DTD for <dl>, <dt>, and <dd> so that they can
occur anywhere in a document and be independent of one
another.

Reviewed by darin/gramps

  • khtml/html/dtd.cpp: (DOM::checkChild):
3:27 PM Changeset in webkit [3898] by hyatt
  • 7 edits in trunk/WebCore

Bottom border/padding was incorrectly being used in float
computations. The fix is trivial... positioning of floats
occurs before you add in the bottom border/padding rather
than after.

Also implementing support for transparent borders and adding
code that understands how to draw more complex polys when
individual sides are transparent. This code existed for left
and right borders, but not for top and bottom borders.

These two fixes make the tantek demo found at:

​http://www.tantek.com/map.html

work properly for the first time in Safari.

Reviewed by darin

  • ChangeLog:
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_object.cpp: (RenderObject::paintBorder):
  • khtml/rendering/render_style.h:

Mar 21, 2003:

5:37 PM Changeset in webkit [3897] by hyatt
  • 12 edits in trunk/WebCore

Fixes for all 4 macromedia rendering problems. They were all
related to buggy float handling.

The bugs are 3194998, 3195014, 3915155, 3204114.

This patch splits floats and positioned elements into two lists
instead of 1, and it also adds better logic for clearing out
floats when blocks move vertically.

Reviewed by darin

  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::detach):
  • khtml/rendering/render_flow.cpp: (RenderFlow::addChildWithContinuation):
  • khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::nodeAtPoint):
  • khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::removeFromObjectLists): (RenderObject::nodeAtPoint):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_root.cpp: (RenderRoot::layout):
  • khtml/rendering/render_table.cpp: (RenderTable::layout):
3:25 PM Changeset in webkit [3896] by cblu
  • 9 edits in trunk/WebKit

WebFoundation:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

  • Misc.subproj/WebNSDataExtras.m: (-[NSData _web_guessedMIMEType]): sniff for vcards and ical files
  • types.plist: added text/calendar and text/vcard

WebKit:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _representationClassForMIMEType:]): was _canShowMIMEType
  • WebView.subproj/WebFrameViewPrivate.h:
  • WebView.subproj/WebFrameViewPrivate.m: (+[WebFrameView _viewClassForMIMEType:]): was _canShowMIMEType
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (+[WebTextView unshowableMIMETypes]): new, returns text types that shouldn't be shown
  • WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): call unshowableMIMETypes

WebBrowser:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

  • Preferences.subproj/WBPreferences.m: (+[WBPreferences shouldOpenFileAtPath:]): auto-open vcf and ics
2:09 PM Changeset in webkit [3895] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3203212 -- nil-deref in khtml::CachedImage::isErrorImage at turbotax.com
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeImage): Remove all occurrences of the image from the list. We don't try to prevent multiple occurrences from getting in there. Also use removeRef instead of remove, for speed.
9:42 AM Changeset in webkit [3894]
  • 2 copies
    2 deletes in tags/JavaScriptCore-68-tarball

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-68-tarball'.

9:42 AM Changeset in webkit [3893] by darin
  • 1 edit in branches/JavaScriptCore-68-tarball-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Update project file for tarball.

9:39 AM Changeset in webkit [3892]
  • 4 copies
    2 deletes in tags/WebCore-68

This commit was manufactured by cvs2svn to create tag 'WebCore-68'.

9:39 AM Changeset in webkit [3891] by darin
  • 1 edit in branches/WebCore-68-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

Updated project file for tarball.

9:31 AM Changeset in webkit [3890] by darin
  • 4 edits in branches/Safari-68~1-branch/WebKit

Rolled in change from trunk.

2003-03-20 Vicki Murley <​vicki@apple.com>

don't include WebFoundation.h

Reviewed by cblu.

  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
9:26 AM Changeset in webkit [3889] by darin
  • 6 edits in trunk/WebCore

WebFoundation:

Reviewed by John.

  • fixed 3204660 -- EUC decoding not used for japanese yahoo page
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_characterSetFromContentTypeHeader]): Do the search for charset= in a case-insensitive way. It's possible that other browsers are case-insensitive, but also possible that it's just Japanese auto-detect that papers over this problem there.
  • other changes
  • Database.subproj/WebLRUFileList.m: (cStringHash): Get rid of unnecessary code to avoid hashes of 0. This is helpful in the place in JavaScriptCore where we copied this from, but it is not helpful here (slightly ugly and does slow things down a smidgen).

WebCore:

Reviewed by John.

  • fixed 3204660 -- EUC decoding not used for japanese yahoo page
  • khtml/misc/decoder.cpp: (Decoder::decode): Do the search for charset= in a case-insensitive way. It's possible that other browsers are case-insensitive, but also possible that it's just Japanese auto-detect that papers over this problem there.
  • other changes
  • kwq/KWQString.mm: (QString::hash): Get rid of unnecessary code to avoid hashes of 0. This is useful in the place in JavaScriptCore where we copied this from, but it is not helpful here (slightly ugly and does slow things down a smidgen).
  • kwq/WebCoreTextRendererFactory.m: Remove unused method.
12:46 AM Changeset in webkit [3888] by hyatt
  • 3 edits in trunk/WebCore

Fix the color handling of link= attributes on <body> elements
to pass in the quirks mode so that lax parsing can take place.

Reviewed by rjw and john

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):

Mar 20, 2003:

7:39 PM Changeset in webkit [3887] by rjw
  • 22 edits in trunk

WebKit:

Use "Item" consistently in the WebHistory and WebBackForwardList.
Change createSharedHistoryWithFile: to setSharedHistory:
Make the various page cache methods per WebBackForwardList instead of global.

Reviewed by gramps.

  • History.subproj/WebBackForwardList.h:
  • History.subproj/WebBackForwardList.m: (-[WebBackForwardListPrivate dealloc]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToItem:]): (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (-[WebBackForwardList containsItem:]): (-[WebBackForwardList maximumSize]): (-[WebBackForwardList setMaximumSize:]): (-[WebBackForwardList description]): (-[WebBackForwardList clearPageCache]): (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]): (-[WebBackForwardList setUsesPageCache:]): (-[WebBackForwardList usesPageCache]): (-[WebBackForwardList backListCount]): (-[WebBackForwardList forwardListCount]): (-[WebBackForwardList itemAtIndex:]):
  • History.subproj/WebHistory.h:
  • History.subproj/WebHistory.m: (-[_WebCoreHistoryProvider containsItemForURLString:]): (+[WebHistory setSharedHistory:]): (-[WebHistory addItemForURL:]): (-[WebHistory addItem:]): (-[WebHistory removeItem:]): (-[WebHistory removeItems:]): (-[WebHistory removeAllItems]): (-[WebHistory addItems:]): (-[WebHistory orderedItemsLastVisitedOnDay:]): (-[WebHistory containsItemForURLString:]): (-[WebHistory itemForURL:]):
  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryPrivate.h:
  • History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate insertItem:atDateIndex:]): (-[WebHistoryPrivate removeItemForURLString:]): (-[WebHistoryPrivate addItem:]): (-[WebHistoryPrivate removeItem:]): (-[WebHistoryPrivate removeItems:]): (-[WebHistoryPrivate removeAllItems]): (-[WebHistoryPrivate addItems:]): (-[WebHistoryPrivate orderedItemsLastVisitedOnDay:]): (-[WebHistoryPrivate containsItemForURLString:]): (-[WebHistoryPrivate itemForURL:]): (-[WebHistoryPrivate _loadHistoryGuts:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge goBackOrForward:]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _canCachePage]): (-[WebFrame _purgePageCache]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _resetBackForwardListToCurrent]):
  • WebView.subproj/WebLocationChangeDelegate.h:
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView _commonInitialization:frameName:groupName:]): (-[WebView setMaintainsBackForwardList:]): (-[WebView goBack]): (-[WebView goForward]):

WebCore:

Use "Item" consistently in the WebHistory and WebBackForwardList.
Change createSharedHistoryWithFile: to setSharedHistory:
Make the various page cache methods per WebBackForwardList instead of global.

Reviewed by gramps.

  • kwq/KWQKHistoryProvider.mm:
  • kwq/WebCoreHistory.h:

WebBrowser:

Use "Item" consistently in the WebHistory and WebBackForwardList.
Change createSharedHistoryWithFile: to setSharedHistory:
Make the various page cache methods per WebBackForwardList instead of global.

Reviewed by gramps.

  • AppController.m: (-[AppController confirmResetSafari:]):
  • BrowserDocument.m: (-[BrowserDocument canGoBack]): (-[BrowserDocument canGoForward]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]): (-[BrowserDocument goToItem:]): (-[BrowserDocument backListMenuForButton:]):
  • BrowserWebController.m: (-[BrowserWebController snapBackTo:]): (-[BrowserWebController setPageForSnapBackToCurrentPage:]): (-[BrowserWebController canSnapBackToPage]): (-[BrowserWebController setSearchResultsForSnapBackToCurrentPage]): (-[BrowserWebController canSnapBackToSearchResults]):
  • ContextMenuHandler.m: (-[ContextMenuHandler addLinkToBookmarks:]):
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument validate_toggleBackForwardEnabled:]):
  • GlobalHistory.m: (-[GlobalHistory _registerForHistoryNotifications]): (-[GlobalHistory init]): (-[GlobalHistory _entriesFromMixedItems:]): (-[GlobalHistory _addItemsForDate:toMenu:skip:limit:]): (-[GlobalHistory _removeEntries:]): (-[GlobalHistory _undoRemoveEntries:]): (-[GlobalHistory deleteContentItems:withUndoManager:]): (-[GlobalHistory child:ofContentItem:]): (-[GlobalHistory numberOfChildrenOfContentItem:]):
  • URLCompletionController.m: (+[URLCompletionController _loadDB]): (+[URLCompletionController _registerForNotifications]):
7:04 PM Changeset in webkit [3886] by rjw
  • 1 edit in trunk/WebKit/API-Issues.rtf

Notes to self.

4:15 PM Changeset in webkit [3885] by cblu
  • 4 edits in trunk/WebKit

WebKit:

Properly handle file URL directory errors.

Reviewed by trey.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): when file URL has no path, return generic file icon
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]): set the URL, don't set it to nil!

WebBrowser:

Fixed: 3204064 - REGRESSION: PDF URL is left in location for after download
Properly handle file URL directory errors.

Reviewed by darin.

  • BrowserWebController.m: (-[BrowserWebController expectedOrCurrentURL]): don't use the URL of the provisional data source if it is not loading.
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): tweak, use [NSWorkspace isFilePackageAtPath:] instead of LaunchServices because it is easier.
2:21 PM Changeset in webkit [3884] by hyatt
  • 3 edits in trunk/WebCore

Always do residual style fixups in all three Safari rendering
modes.

Reviewed by darin

  • khtml/html/htmlparser.cpp: (KHTMLParser::popBlock):
2:18 PM Changeset in webkit [3883] by vicki
  • 4 edits in trunk/WebKit

don't include WebFoundation.h

Reviewed by cblu.

  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
11:44 AM Changeset in webkit [3882] by sheridan
  • 3 edits in trunk

Safari-69 begins

10:50 AM Changeset in webkit [3881]
  • 3 copies
    2 deletes in branches/WebCore-68-tarball-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-68-tarball-branch'.

10:50 AM Changeset in webkit [3880]
  • 3 copies
    2 deletes in tags/WebCore-68-tarball-anchor

This commit was manufactured by cvs2svn to create tag
'WebCore-68-tarball-anchor'.

10:50 AM Changeset in webkit [3879]
  • 3 copies in branches/Safari-68~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-68~1-branch'.

10:50 AM Changeset in webkit [3878]
  • 3 copies in tags/Safari-68~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-68~1-anchor'.

10:50 AM Changeset in webkit [3877]
  • 3 copies in tags/Safari-68

This commit was manufactured by cvs2svn to create tag 'Safari-68'.

10:50 AM Changeset in webkit [3876]
  • 1 copy
    2 deletes in branches/JavaScriptCore-68-tarball-branch

This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-68-tarball-branch'.

10:50 AM Changeset in webkit [3875]
  • 1 copy
    2 deletes in tags/JavaScriptCore-68-tarball-anchor

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-68-tarball-anchor'.

10:50 AM Changeset in webkit [3874] by sheridan
  • 8 edits in trunk

Safari-68

8:52 AM Changeset in webkit [3873] by darin
  • 2 edits in trunk/WebKit

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebKit:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

Mar 19, 2003:

7:20 PM Changeset in webkit [3872] by voas
  • 5 edits
    1 delete in trunk/WebKit

2003-03-19 Ed Voas ​voas@apple.com

Reviewed by Richard.

React to WebView API changes. Redo HIWebView API.

  • Carbon.subproj/HIWebView.h:
  • Carbon.subproj/HIWebView.m: (if): (switch):
  • Carbon.subproj/HIWebViewPriv.h: Removed.
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
7:02 PM Changeset in webkit [3871] by hyatt
  • 3 edits in trunk/WebCore

Adding a few more tags to the list of ones to check for
residual style.

Reviewed by gramps

  • khtml/html/htmlparser.cpp: (KHTMLParser::isResidualStyleTag): (KHTMLParser::isAffectedByResidualStyle):
6:55 PM Changeset in webkit [3870] by rjw
  • 4 edits in trunk/WebKit

WebKit:

Removed initWithView:* constructors from WebView.
New designated initializer for WebView is initWithFrame:frameName:groupName:

Reviewed by cblu & ed.

  • Carbon.subproj/HIWebView.m:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView init]): (-[WebView initWithFrame:]):

WebBrowser:

Updated Safari to use the new designated initializer for WebView. Simplified
many places that used to reference the WebFrameView.

Reviewed by cblu.

  • BrowserTabViewItem.m: (-[BrowserTabViewItem webController]):
  • BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]):
  • BrowserWindowController.m: (-[BrowserWindowController mainWebFrameView]): (-[BrowserWindowController updateLabelForTab:]): (-[BrowserWindowController setUpTabForController:]): (-[BrowserWindowController closeTab:]): (-[BrowserWindowController didSelectTabViewItem]): (-[BrowserWindowController findTabForWebController:]): (-[BrowserWindowController reloadTab:]): (-[BrowserWindowController releaseTabSwitcher:]): (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]): (-[BrowserWindowController orderedTabs]): (-[BrowserWindowController canReloadTab:]):
6:13 PM Changeset in webkit [3869] by hyatt
  • 8 edits in trunk/WebCore

Fix continuations so that they are smarter about reusing
anonymous blocks. Avoids deep nesting when it isn't
necessary.

A complete implementation of the residual style fixes. It
seems to fix all current outstanding bugs.

One of the bugs in the residual style list was caused by
font-weight not being reset to tables and is actually its
own problem. I fixed that by moving the quirks resets for
table elements into the quirks stylesheet (which should be
a speed boost).

<b><p>Foo</b> Goo</p>

Also fixed the huge XML failure issue that made us fail hundreds
of test cases. Attachment of text nodes was being done way too
early, before the text of the node had been determined. By moving
the attachment from enterText to exitText, the problem is solved.

Reviewed by darin (res. style fix 1) and gramps (rest of res. style fix and XML fix)

  • ChangeLog:
  • khtml/css/quirks.css:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::attach):
  • khtml/html/htmlparser.cpp: (KHTMLParser::isResidualStyleTag): (KHTMLParser::isAffectedByResidualStyle): (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks): (KHTMLParser::reopenResidualStyleTags): (KHTMLParser::popBlock): (KHTMLParser::popOneBlock):
  • khtml/html/htmlparser.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::splitFlow):
  • khtml/xml/xml_tokenizer.cpp: (XMLHandler::enterText): (XMLHandler::exitText):
5:14 PM Changeset in webkit [3868] by rjw
  • 17 edits
    3 deletes in trunk/WebKit

WebKit:

Rename WebControllerPolicyDelegate*.[hm] to WebPolicyDelegate*.[hm]

Reviewed by trey.

  • API-Issues.rtf:
  • Misc.subproj/WebKit.h:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebControllerPolicyDelegate.h: Removed.
  • WebView.subproj/WebControllerPolicyDelegate.m: Removed.
  • WebView.subproj/WebControllerPolicyDelegatePrivate.h: Removed.
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.h:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebPolicyDelegate.m:
  • WebView.subproj/WebPolicyDelegatePrivate.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

Rename WebControllerPolicyDelegate*.[hm] to WebPolicyDelegate*.[hm]

Reviewed by trey.

  • BrowserWebController.m:
4:45 PM Changeset in webkit [3867] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed 3202780 -- REGRESSION: progress bar, stop button, both get stuck in "loading" state (bartsoft.com)
  • WebView.subproj/WebDataSource.m: (-[WebDataSource isLoading]): Add back the "is this page complete" check, so that subresource loads don't make us think we're loading again, once the page is complete. On the other hand, frames must still be checked independent of the "is this page complete" flag to avoid reintroducing bug 3200611.
3:11 PM Changeset in webkit [3866] by voas
  • 5 edits in trunk/WebKit

2003-03-19 Ed Voas ​voas@apple.com

Reviewed by Richard.

Got it working in non-compositing mode as well, so in theory it
can work inside a PowerPlant application as well. It's a bit of what
I'd consider a hack, but it's pretty straightforward.

  • Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter setViewsNeedDisplay:]):
  • Carbon.subproj/HIViewAdapter.h:
  • Carbon.subproj/HIViewAdapter.m: (+[HIViewAdapter bindHIViewToNSView:nsView:]): (-[HIViewAdapter setNeedsDisplay:]): (-[HIViewAdapter setNeedsDisplayInRect:]): (SetViewNeedsDisplay):
  • Carbon.subproj/HIWebView.m: (if):
9:04 AM Changeset in webkit [3865] by darin
  • 7 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3197684 -- <textarea wrap="hard"> behaves incorrectly (bugzilla)

By doing the line breaking inside the KWQ class for textarea we can both remove
the broken lineOfCharAtIndex: method and avoid the n-squared algorithm KHTML uses to
insert hard line breaks.

  • khtml/rendering/render_form.cpp: (RenderTextArea::text): Call textWithHardLineBreaks on widget instead of trying to break lines here.
  • kwq/KWQTextEdit.h: Added textWithHardLineBreaks member function. Made text member function const. Got rid of text(int), paragraphs, paragraphLength, and lineOfChar member functions.
  • kwq/KWQTextEdit.mm: (QTextEdit::text): Made this const, and move code that transforms CRLF and CR into LF inside KWQTextArea. (QTextEdit::textWithHardLineBreaks): Added. Calls new textWithHardLineBreaks method.
  • kwq/KWQTextArea.h: Added textWithHardLineBreaks method. Removed numLines, textForLine:, paragrahs, paragraphLength:, textForParagraph:, and lineOfCharAtIndex: methods.
  • kwq/KWQTextArea.mm: (-[KWQTextArea initWithQTextEdit:]): Call [self init] for clarity instead of [super init]. In both cases, we end up calling [self initWithFrame:]. (-[KWQTextArea text]): Added logic for transforming CRLF and CR into LF here instead of at the KWQTextEdit level. (-[KWQTextArea textWithHardLineBreaks]): Added. This method uses the layout manager to extract the characters for one line at a time, and put line breaks in between.
1:06 AM Changeset in webkit [3864] by mjs
  • 6 edits in trunk

WebCore:

Reviewed by Trey.

  • fixed 3146407 - bring the window with the targeted frame to the front
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): If we use an existing frame, focus it.
  • kwq/WebCoreBridge.h: Prototype focusWindow method.

WebKit:

Reviewed by Trey.

  • fixed 3127431 - bring the window with the named frame to the front
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge focusWindow]): Tell the window operations delegate to focus. (-[WebBridge loadURL:referrer:reload:target:triggeringEvent:form:formValues:]): If this navigation is meant for a different frame, focus its window. (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Likewise.

WebBrowser:

Reviewed by Trey.

  • fixed 3127431 - bring the window with the named frame to the front
  • set main frame name properly for targeted links opened in tabs
  • BrowserDocument.h:
  • BrowserDocument.m:

(-[BrowserDocument createWebControllerWithFrameName:]): New method.
(-[BrowserDocument createWebController]): Reimplement in terms of above.

  • BrowserDocumentController.m: (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]): Pass main frame name for tabs too.
  • BrowserWebController.m: (-[BrowserWebController windowController]): Move to higher in the file. (-[BrowserWebController webViewFocusWindow:]): Switch tabs too.
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController createTabWithFrameName:andShow:]): Added frameName parameter. (-[BrowserWindowController createTabWithFrameName:]): New method. (-[BrowserWindowController createInactiveTabWithFrameName:]): New method. (-[BrowserWindowController createTab]): Pass nil frame name. (-[BrowserWindowController createInactiveTab]): Likewise.
Note: See TracTimeline for information about the timeline view.