⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 25, 2003:

7:37 PM Changeset in webkit [3921] by rjw
  • 14 edits in trunk/WebKit

WebKit:

Changed use of plugin to plugIn in our public API
as instructed by those that must be obeyed.

Reviewed by Trey.

Changed userStyleSheetLocation to take/pass an NSURL.

Reviewed by Chris

  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • Plugins.subproj/WebNullPluginView.h:
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins.subproj/WebPluginError.h:
  • Plugins.subproj/WebPluginError.m: (-[WebPlugInError plugInPageURL]): (-[WebPlugInError plugInName]):
  • Plugins.subproj/WebPluginErrorPrivate.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetLocation]): (-[WebPreferences setUserStyleSheetLocation:]):
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):
  • API-Issues.rtf: notes to self

WebBrowser:

Changed use of plugin to plugIn in our public API
as instructed by those that must be obeyed.

Reviewed by Trey.

  • LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
  • Preferences.subproj/AdvancedPreferences.m: (-[AdvancedPreferences setStyleSheetPathPreference:]): (-[AdvancedPreferences styleSheetPathPreference]):
6:40 PM Changeset in webkit [3920] by cblu
  • 8 edits in trunk/WebKit

Fixed: 3135385 - many file types don't work with the QuickTime plugin in Safari

Reviewed by trey.

  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage pluginWithPath:]): tweak (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): moved up from WebNetscapePluginPackage (-[WebBasePluginPackage initWithPath:]): retain path, create bundle so subclasses don't have to do this work (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]): was getMIMEInformation from WebPluginPackage (-[WebBasePluginPackage dealloc]): release the bundle (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]): tweak
  • Plugins.subproj/WebNetscapePluginPackage.h:
  • Plugins.subproj/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage preferredLocalizationName]): new (-[WebNetscapePluginPackage openResourceFile]): tweak (-[WebNetscapePluginPackage closeResourceFile:]): tweak (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): tweak (-[WebNetscapePluginPackage getPluginInfoFromResources]): was getMIMEInformation (-[WebNetscapePluginPackage pListForPath:createFile:]): new, calls BP_CreatePluginMIMETypesPreferences if createFile==YES (-[WebNetscapePluginPackage getPluginInfoFromPLists]): calls getPluginInfoFromBundleAndMIMEDictionary with the MIME dictionary from the user's home dir. (-[WebNetscapePluginPackage initWithPath:]): have the superclass do some initialization, call getPluginInfoFromPLists and/or getPluginInfoFromResources (-[WebNetscapePluginPackage executableType]): tweak (-[WebNetscapePluginPackage load]): get the BP_CreatePluginMIMETypesPreferences symbol (-[WebNetscapePluginPackage unload]): tweak (-[WebNetscapePluginPackage dealloc]): tweak
  • Plugins.subproj/WebPluginPackage.h:
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): have the superclass do some initialization, call getPluginInfoFromBundleAndMIMEDictionary (-[WebPluginPackage viewFactory]): tweak (-[WebPluginPackage load]): call principalClass (-[WebPluginPackage isLoaded]): tweak
  • Plugins.subproj/npapi.h: added declaration for the BP_CreatePluginMIMETypesPreferences function pointer.
5:11 PM Changeset in webkit [3919] by hyatt
  • 5 edits in trunk/WebCore

Fix font-family parsing to match the spec (and other browsers).

This fixes bugs 3197584 and 3207760.

Also fix pseudos to be lower-cased. Fixes 3208303.

Reviewed by darin

  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp: (CSSParser::parseFontFamily):
2:43 PM Changeset in webkit [3918] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

  • WebKit part of fix for 3141794 -- No scroll bar for the "collections" column of the bookmarks window

Reviewed by Darin.

  • WebView.subproj/WebDynamicScrollBarsView.h: replaced disallowsScrolling boolean ivar with separate booleans for disallowHorizontalScrolling and disallowVerticalScrolling
  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): take the two disallow booleans into account separately (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]), (-[WebDynamicScrollBarsView allowsHorizontalScrolling]), (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]), (-[WebDynamicScrollBarsView allowsVerticalScrolling]): new methods, do the obvious (-[WebDynamicScrollBarsView setAllowsScrolling:]): changed to set both ivars (-[WebDynamicScrollBarsView allowsScrolling]): changed to return YES if scrolling is allowed in either direction
  • WebKit.exp: exported symbol for WebDynamicScrollBarsView class name

WebBrowser:

  • WebBrowser part of fix for 3141794 -- No scroll bar for the "collections" column of the bookmarks window

Reviewed by Darin.

  • English.lproj/Browser.nib: changed class of scroll view around collections column to be WebDynamicScrollBarsView
  • BookmarksViewController.m: (-[BookmarksViewController setUpBookmarkSourcesScrollView:]): new method, finds the dynamic scroll view enclosing the collections column, and turns off horizontal scrolling for it. (-[BookmarksViewController awakeFromNib:]): call setUpBookmarkSourcesScrollView
2:08 PM Changeset in webkit [3917] by kocienda
  • 3 edits in trunk/WebKit

Reviewed by Richard

Fixed a bug that could occur in the new immutable/mutable
request scheme. When opening a javascript window, it was
possible for a request passed as a method argument to be
released during the course of a method, particularly
after that request was passed to willSendRequest:.
The solution is to ask the data source for its current
request rather than using the one stored in the method
argument.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient startLoading:]):
10:42 AM Changeset in webkit [3916] by trey
  • 8 edits in trunk

JavaScriptCore:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be

additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

WebFoundation:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

  • WebFoundation.pbproj/project.pbxproj:

WebCore:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

  • WebCore.pbproj/project.pbxproj:

WebKit:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

  • WebKit.pbproj/project.pbxproj:
10:36 AM Changeset in webkit [3915] by kocienda
  • 10 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Spilt NSURLRequest into the immutable and mutable variants
as specified by the approved API.

Updated other code to use NSMutableURLRequest where appropriate.

Also updated some comments in NSURLRequest.h and removed
obsolete WebRequestCachePolicyRevalidate NSURLRequestCachePolicy
constant.

  • CacheLoader.subproj/NSURLRequest.h:
  • CacheLoader.subproj/NSURLRequest.m: (+[NSURLRequest requestWithURL:cachePolicy:timeoutInterval:]): (+[NSURLRequest requestWithURL:]): (-[NSURLRequest copyWithZone:]): (-[NSURLRequest mutableCopyWithZone:]): (-[NSURLRequest setURL:]): (-[NSMutableURLRequest setURL:]): (-[NSMutableURLRequest setCachePolicy:]): (-[NSMutableURLRequest setTimeoutInterval:]): (-[NSMutableURLRequest copyWithZone:]): (-[NSMutableURLRequest mutableCopyWithZone:]):
  • CacheLoader.subproj/WebResource.m: (-[WebResource loadWithDelegate:]): (-[WebResource _redirectedToRequest:permanent:]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol stateForCacheObject:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _addRequestMessageBody]):
  • WebFoundation.exp:

WebKit:

Reviewed by Darin

Updated to use NSMutableURLRequest where appropriate.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): (-[WebDataSource request]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setURL:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame reload]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):

WebBrowser:

Reviewed by Darin

Updated to use NSMutableURLRequest where appropriate.

  • BrowserDocumentController.m: (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]):
  • BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):
9:23 AM Changeset in webkit [3914] by darin
  • 4 edits in trunk/WebKit

Reviewed by John.

  • fixed 3205745 -- WebKit.framework's Localizable.strings file contains high ASCII in the Key definition.
  • English.lproj/Localizable.strings: Regenerated with the new version of the extract-localizable-strings tool that uses \U syntax instead of "high ASCII".
  • changed cursive font back to "Apple Chancery" for now
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Change to "Apple Chancery".
  • English.lproj/StringsNotToBeLocalized.txt: Update for above change.

Mar 24, 2003:

6:36 PM Changeset in webkit [3913] by hyatt
  • 7 edits in trunk/WebCore

Clean up isInlineFlow. Add a couple of new methods that I'll
be converting code over to use (carefully) piece by piece in
future patches.

Reviewed by gramps

  • khtml/rendering/render_block.h:
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):
  • khtml/rendering/render_object.h:
5:40 PM Changeset in webkit [3912] by darin
  • 4 edits in trunk/WebKit

Reviewed by Dave.

  • fixed 3206803 -- REGRESSION: Lucida Handwriting font doesn't work
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (acceptableChoice): Added. Returns NO if the weight/traits are no good. (betterChoice): Added. Returns YES if the new weight/traits are better than the old. (-[WebTextRendererFactory fontWithFamily:traits:size:]): Use the new functions to judge which font is good enough. Now it will accept an italic font if that's all we have.
  • fixed 3206904 -- use "Lucida Handwriting" for "cursive" so it works on systems without Classic
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Change default from "Apple Chancery" to "Lucida Handwriting".
  • English.lproj/StringsNotToBeLocalized.txt: Updated for this change.
5:23 PM Changeset in webkit [3911] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Richard.

  • made API (actually doc-only) changes needed for 3087535 - bugzilla queries come back as downloaded files
  • Downloads.subproj/WebDownload.h: Documented that download:didReceiveResponse: may be sent more than once.
  • WebView.subproj/WebLocationChangeDelegate.h: Documented that locationChangeCommittedForDataSource: may be sent more than once.
  • WebView.subproj/WebPolicyDelegate.h: Documented that decideContentPolicyForMIMEType:andRequest:inFrame: may be sent more than once.
  • WebView.subproj/WebResourceLoadDelegate.h: Documented that resource:didReceiveResponse:fromDataSource: may be sent more than once.
5:13 PM Changeset in webkit [3910] by mjs
  • 11 edits in trunk

WebCore:

Reviewed by Richard.

  • fixed 3083339 - significant top and side margin appended to new windows
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Account for distinction between frame and content rect.
  • kwq/KWQStyle.h: Return 0 for the appropriate style to avoid adding extra padding when making a new window from JavaScript.
  • kwq/WebCoreBridge.h: Prototype new methods.

WebKit:

Reviewed by Richard.

  • fixed 3083339 - significant top and side margin appended to new windows

Part of the fix involves adding new window operation delegate methods.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setWindowFrame:]): Tweaked code a bit. (-[WebBridge windowFrame]): Added. (-[WebBridge setWindowContentRect:]): Added. (-[WebBridge windowContentRect]): Added.
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate webView:setContentRect:]): Implemented. (-[WebDefaultWindowOperationsDelegate webViewContentRect:]): Likewise.
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Reviewed by Richard.

  • fixed 3083339 - significant top and side margin appended to new windows
  • BrowserWebController.m: (-[BrowserWebController webView:setFrame:]): Tweaked a bit. (-[BrowserWebController webViewFrame:]): Likewise. (-[BrowserWebController webView:setContentRect:]): Implemented. (-[BrowserWebController webViewContentRect:]): Likewise.
3:39 PM Changeset in webkit [3909] by hyatt
  • 4 edits in trunk/WebCore

Fix for crash on www.lnt.com. 3199929 is the bug number.

Blocks must have all their kids as inlines or all theirs kids
as blocks. Floats and positioned elements are special and
disregarded when this check occurs.

If a float or positioned element suddenly becomes a normal flow
element again, then the parent block might have to make its kids
all be non-inline or it might have to wrap a normal flow inline
with an anonymous block.

This patch fixed RenderObject's setStyle method to check for
this situation and to make the parent block fix itself up
appropriately.

Reviewed by darin

  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):
2:56 PM Changeset in webkit [3908] by cblu
  • 10 edits in trunk/WebKit

WebFoundation:

Reviewed by trey.

  • types.plist: added text/qif (Quicken)

WebKit:

Fixed: 3155489 - Seed: PostScript files display instead of downloading, often as a blank page
Fixed: 3106251 - quicken file not downloaded, can't save manually

Reviewed by trey.

  • WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): call [WebImageView supportedImageMIMETypes]
  • WebView.subproj/WebFrameViewPrivate.m: (+[WebFrameView _viewTypes]): call [WebImageView supportedImageMIMETypes]
  • WebView.subproj/WebImageView.h:
  • WebView.subproj/WebImageView.m: (+[WebImageView initialize]): was -initialize (oops) (+[WebImageView unsupportedImageMIMETypes]): new, AppKit images that we shouldn't display inline, includes ps and pdf (+[WebImageView supportedImageMIMETypes]): new, was in WebViewPrivate
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): renamed, added text/qif (quicken)
  • WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): call [WebTextView unsupportedTextMIMETypes]
  • WebView.subproj/WebViewPrivate.h: removed _supportedImageMIMETypes
  • WebView.subproj/WebViewPrivate.m: removed _supportedImageMIMETypes
2:37 PM Changeset in webkit [3907] by kocienda
  • 14 edits in trunk/WebKit

WebFoundation:

Reviewed by NOBODY (OOPS!).

Moved closer to target API for NSURLRequest. Merged in
final names for immutable and mutable versions of this
class and its HTTP category. The next step will be to
actually make the split between immutable/mutable
variants of NSURLRequest.

This involved some non-complicated changes in the
internals of NSURLRequest.

Note that NSURLRequestPrivate.h has taken on some methods
that used to be API, but were removed from the public
proposal. These methods are now available as SPI.

  • CacheLoader.subproj/NSURLRequest.h:
  • CacheLoader.subproj/NSURLRequest.m: (+[NSURLRequest requestWithURL:cachePolicy:timeoutInterval:]): (+[NSURLRequest requestWithURL:]): (-[NSURLRequest initWithURL:cachePolicy:timeoutInterval:]): (-[NSURLRequest initWithURL:]): (-[NSURLRequest init]): (-[NSURLRequest URL]): (-[NSURLRequest timeoutInterval]): (-[NSURLRequest setURL:]): (-[NSURLRequest setCachePolicy:]): (-[NSURLRequest setTimeoutInterval:]): (NSHTTPURLRequestInit): (-[NSURLRequest _parametersForReading]): (-[NSURLRequest _parametersForWriting]): (-[NSURLRequest HTTPMethod]): (-[NSURLRequest HTTPAllHeaderFields]): (-[NSURLRequest HTTPValueForHeaderField:]): (-[NSURLRequest HTTPBody]): (-[NSURLRequest HTTPAllowSSLCertificatesWithUnknownRoots]): (-[NSURLRequest HTTPContentType]): (-[NSURLRequest HTTPCookiePolicyBaseURL]): (-[NSURLRequest HTTPExtraCookies]): (-[NSURLRequest HTTPPageNotFoundCacheLifetime]): (-[NSURLRequest HTTPReferrer]): (-[NSURLRequest HTTPUserAgent]): (-[NSURLRequest HTTPSetMethod:]): (-[NSURLRequest HTTPSetAllHeaderFields:]): (-[NSURLRequest HTTPSetValue:forHeaderField:]): (-[NSURLRequest HTTPAddValue:forHeaderField:]): (-[NSURLRequest HTTPSetBody:]): (-[NSURLRequest HTTPSetAllowSSLCertificatesWithUnknownRoots:]): (-[NSURLRequest HTTPSetContentType:]): (-[NSURLRequest HTTPSetCookiePolicyBaseURL:]): (-[NSURLRequest HTTPSetExtraCookies:]): (-[NSURLRequest HTTPSetPageNotFoundCacheLifetime:]): (-[NSURLRequest HTTPSetReferrer:]): (-[NSURLRequest HTTPSetUserAgent:]): (-[NSHTTPURLRequestRequestParameters copyWithZone:]): (-[NSHTTPURLRequestRequestParameters dealloc]): (-[NSHTTPURLRequestRequestParameters hash]): (-[NSHTTPURLRequestRequestParameters isEqual:]): (-[NSHTTPURLRequestRequestParameters description]):
  • CacheLoader.subproj/NSURLRequestPrivate.h:
  • CacheLoader.subproj/WebCacheManager.m:
  • CacheLoader.subproj/WebResource.m: (-[WebResource _cacheKey]):
  • CacheLoader.subproj/WebResponse.h:
  • CacheLoader.subproj/WebResponse.m: (-[WebResponse contentType]): (-[WebResponse setContentType:]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebFoundation.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol setCertificatePolicyOnStream]): (-[WebCFNetworkHTTPProtocol addAcceptFieldsToHeader]): (-[WebCFNetworkHTTPProtocol addCookieFieldToHeader]): (-[WebCFNetworkHTTPProtocol addReferrerFieldToHeader]): (-[WebCFNetworkHTTPProtocol addUserAgentFieldToHeader]): (-[WebCFNetworkHTTPProtocol addExtraFieldsToHeader]): (-[WebCFNetworkHTTPProtocol addMessageBodyToRequest]): (-[WebCFNetworkHTTPProtocol buildHTTPRequest]): (-[WebCFNetworkHTTPProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol shouldAttemptOriginLoad]): (-[WebHTTPProtocol canStoreCacheObject:]): (-[WebHTTPProtocol stateForCacheObject:]):
  • ProtocolHandlers.subproj/WebHTTPRequest.h: Removed.
  • ProtocolHandlers.subproj/WebHTTPRequest.m: Removed.
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.h:
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _canUsePersistentConnectionForRequest]): (-[WebSimpleHTTPProtocol _addRequestMessageBody]): (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _parseHeaderFromData:]):
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by NOBODY (OOPS!).

Moved closer to target API for NSURLRequest. Merged in
final names for immutable and mutable versions of this
class and its HTTP category. The next step will be to
actually make the split between immutable/mutable
variants of NSURLRequest.

In WebKit, this amounts to name changes only.

  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]):
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge incomingReferrer]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]):
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame reload]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem]): (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient resource:willSendRequest:]):

WebBrowser:

Reviewed by NOBODY (OOPS!).

Moved closer to target API for NSURLRequest. Merged in
final names for immutable and mutable versions of this
class and its HTTP category. The next step will be to
actually make the split between immutable/mutable
variants of NSURLRequest.

In WebBrowser, this amounts to name changes only.

  • BrowserDocument.m:
  • BrowserDocumentController.m:
  • BrowserWebController.m: (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]):
  • BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):
  • English.lproj/Localizable.strings:
  • LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]):
11:47 AM Changeset in webkit [3906] by hyatt
  • 4 edits in trunk/WebCore

ignore the float property on first-letter styles.
The bug # is 3186044.

Reviewed by darin

  • khtml/css/parser.cpp:
  • khtml/rendering/render_block.cpp:
10:58 AM Changeset in webkit [3905] by hyatt
  • 4 edits in trunk/WebCore

Add error-handling case to deal with a common CSS malformation:

clip: rect( )

The bug is 3206171.

Reviewed by darin

  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
10:50 AM Changeset in webkit [3904] by darin
  • 18 edits
    1 add in trunk

WebCore:

Reviewed by John.

  • fixed 3203869 -- Monaco 9 looks different in Safari than in TextEdit (uses outline instead of bitmap)
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::getRenderer): Get a new renderer if the one we have is wrong printer-vs-screen-wise. For speed, use a global variable rather than methods.
  • kwq/KWQPainter.mm: (QPainter::_updateRenderer): Get a new renderer if the one we have is wrong printer-vs-screen-wise. For speed, use a global variable rather than methods.
  • kwq/KWQTextRendererFactory.h: Added. Exposes a global variable that tells whether we are in global "using printer font" mode.
  • kwq/WebCoreTextRendererFactory.h: Added setUsingPrinterFonts: and usingPrinterFonts methods.
  • kwq/WebCoreTextRendererFactory.m: (-[WebCoreTextRendererFactory setUsingPrinterFonts:]): Added. Sets global. (-[WebCoreTextRendererFactory usingPrinterFonts]): Added. Returns value of global.
  • WebCore.pbproj/project.pbxproj: Added KWQTextRendererFactory.h.

WebKit:

Reviewed by John.

  • fixed 3203869 -- Monaco 9 looks different in Safari than in TextEdit (uses outline instead of bitmap)
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]): Pass usingPrinterFont:NO, since this is used exclusively for on-screen text, not printing.
  • Misc.subproj/WebStringTruncator.m: (truncateString): Ditto.
  • WebCoreSupport.subproj/WebTextRenderer.h: Add usingPrinterFont boolean field and parameter to init.
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:forScreen:]): Add usingPrinterFont parameter, and get the screen font if it's NO, also store the boolean for later use. (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding: attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:fontFamilies:]): Pass the usingPrinterFont parameter through when getting a substitute font.
  • WebCoreSupport.subproj/WebTextRendererFactory.h: Add separate caches for screen and printing text renderers. Add usingPrinterFont parameter to our rendererWithFont: method (the one inherited from WebCore still has no parameter).
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory init]): Create both caches. (-[WebTextRendererFactory dealloc]): Release both caches. (-[WebTextRendererFactory rendererWithFont:]): Call the new rendererWithFont:usingPrinterFont: method, passing usingPrinterFonts from the WebCore side. Thus any fonts fetched by WebCore during printing are printing fonts, and otherwise they are screen fonts. (-[WebTextRendererFactory rendererWithFont:usingPrinterFont:]): Added. Has the code from the old rendererWithFont: method, but passes the usingPrinterFont parameter through to the WebTextRenderer init method.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]): Don't set unused canDragTo and canDragFrom fields. (-[WebHTMLView drawRect:]): Call -[WebTextRendererFactory setUsingPrinterFonts:] here if we are printing, as indicated by the usingPrinterFonts field. The reason we do this only inside drawRect is so we don't affect redraws of other HTML views that are not being printed that might be in "needs display" state when printing began. (-[WebHTMLView _setUsingPrinterFonts:]): Added. Calls _setUsingPrinterFonts on all WebHTMLViews inside this one, then does the work for this one. Uses the frame hierarchy rather than the view hierarchy, but either would work. If printer font state is changing, then sets the WebTextRendererFactory mode, then forces a layout and application of styles, but without triggering display. (-[WebHTMLView beginDocument]): Do an explicit display so this view does not have to be displayed while it is in "use printer fonts" mode. Then call _setUsingPrinterFonts:YES so that drawRect will use printer fonts, and also that the WebCore data structures and layout will be updated to reflect printer fonts as opposed to screen fonts. (-[WebHTMLView endDocument]): Call _setUsingPrinterFonts:NO to restore things to normal after printing.
  • WebView.subproj/WebHTMLViewPrivate.h: Removed unused canDragTo, canDragFrom, and liveAllowsScrolling fields. Added usingPrinterFonts field.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
10:40 AM Changeset in webkit [3903] by kocienda
  • 3 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Removed now-obsolete WebResponseCachePolicy enum.
Once the new cache API is ready, there will be new features
to replace what this enum provided. Seeing as how this
enum was largely unused, there is no impact associated with
removing it now.

  • CacheLoader.subproj/NSURLRequest.h:
  • CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest initWithURL:]): (-[NSURLRequest cachePolicy]): (-[NSURLRequest setCachePolicy:]): (-[NSURLRequest copyWithZone:]): (-[NSURLRequest hash]): (-[NSURLRequest isEqual:]):
  • CacheLoader.subproj/WebResource.m: (-[WebResource _finishedLoading]):

WebKit:

Reviewed by Darin

Removed now-obsolete WebResponseCachePolicy enum.
Once the new cache API is ready, there will be new features
to replace what this enum provided. Seeing as how this
enum was largely unused, there is no impact associated with
removing it now.

  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
10:12 AM Changeset in webkit [3902] by kocienda
  • 2 edits in trunk/WebKit

Tests:

Reviewed by John

Cleaned up some missed WebRequest -> NSURLRequest
name conversions.

  • Carbon/CarbonWeb/MyWebEventTypes.h:
  • Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:identifierForInitialRequest:fromDataSource:]):
  • Carbon/CarbonWeb/MyWebWindowOperationsAdapter.m: (-[MyWebWindowOperationsAdapter controller:createWindowWithRequest:]):
  • Carbon/CarbonWeb/TWebWindow.cp:

WebKit:

Reviewed by John

Cleaned up some missed WebRequest -> NSURLRequest
name conversions.

  • WebView.subproj/WebFramePrivate.m
9:29 AM Changeset in webkit [3901] by kocienda
  • 42 edits in trunk/WebKit

Tests:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

  • Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:identifierForInitialRequest:fromDataSource:]):
  • Carbon/CarbonWeb/MyWebWindowOperationsAdapter.m: (-[MyWebWindowOperationsAdapter controller:createWindowWithRequest:]):
  • Carbon/CarbonWeb/TWebWindow.h:
  • Downloader/MyDocument.m: (-[MyDocument downloadCancel:]): (-[MyDocument download:didStartFromRequest:]): (-[MyDocument download:willSendRequest:]):
  • DumpBackForward/main.m: (dumpBackForward): (-[CheapWindowOpsDelegate webView:createWindowWithRequest:]):
  • DumpRenderTree/main.m: (dumpRenderTree):
  • HeaderView/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
  • IBViewer/DocumentController.m: (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
  • PDFBundle/PDFView.h:
  • PDFBundle/PDFView.m: (-[PDFResourceDelegate resource:willSendRequest:]): (-[PDFView initWithFrame:pageURL:resourceURL:]):
  • PDFViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
  • SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]): (-[DocumentController webView:identifierForInitialRequest:fromDataSource:]): (-[DocumentController webView:resource:willSendRequest:fromDataSource:]):
  • SnippetEditor/DataResourceRequest.h:
  • SnippetEditor/SnippetController.m: (-[SnippetController updateFromURL:]):

WebFoundation:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

In the repository:
Moved WebRequest.h to NSURLRequest.h
Moved WebRequest.m to NSURLRequest.m
Moved WebRequestPrivate.h to NSURLRequestPrivate.h

  • CacheLoader.subproj/WebCacheManager.m:
  • CacheLoader.subproj/WebProtocol.h:
  • CacheLoader.subproj/WebProtocol.m: (+[WebProtocol partOfRequest:withClass:createIfDoesNotExist:]): (-[WebProtocol initWithProtocolClient:request:]): (-[WebProtocol request]):
  • CacheLoader.subproj/WebProtocolClient.h:
  • CacheLoader.subproj/WebResource.h:
  • CacheLoader.subproj/WebResource.m: (-[WebResource initWithRequest:]): (+[WebResource sendSynchronousRequest:]): (+[WebResource canInitWithRequest:]): (-[WebResource _sendWillSendRequestCallback]): (-[WebResource _beginLoad]): (-[WebResource _redirectedToRequest:permanent:]): (-[WebResource request]): (-[WebResourceInternal request]): (-[WebResourceInternal redirectedToRequest:permanent:]):
  • CacheLoader.subproj/WebResourceDelegate.h:
  • CacheLoader.subproj/WebResourceQueue.m:
  • CacheLoader.subproj/WebResponse.h:
  • CacheLoader.subproj/WebSynchronousDelegate.h:
  • CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate initWithRequest:monitor:]): (-[WebSynchronousDelegate resource:willSendRequest:]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebFoundation.h:
  • ProtocolHandlers.subproj/WebAboutProtocol.m:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol initWithProtocolClient:request:]): (-[WebCFNetworkHTTPProtocol addAcceptFieldsToHeader]): (-[WebCFNetworkHTTPProtocol buildHTTPRequest]):
  • ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol initWithProtocolClient:request:]): (-[WebFTPProtocol determineErrorAndFail]): (-[WebFTPProtocol _checkDirectoryListing]):
  • ProtocolHandlers.subproj/WebFileProtocol.m:
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol initWithProtocolClient:request:]): (-[WebHTTPProtocol determineErrorAndFail]): (-[WebHTTPProtocol canStoreCacheObject:]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]): (-[WebHTTPProtocol stateForCacheObject:]):
  • ProtocolHandlers.subproj/WebHTTPRequest.h:
  • ProtocolHandlers.subproj/WebHTTPRequest.m:
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol initWithProtocolClient:request:]): (-[WebSimpleHTTPProtocol _addRequestMessageBody]): (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _forwardToCFNetwork]):
  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

  • Downloads.subproj/WebDownload.h:
  • Downloads.subproj/WebDownload.m: (-[WebDownload initWithRequest:]): (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload _setRequest:]): (-[WebDownload resource:willSendRequest:]):
  • Downloads.subproj/WebDownloadPrivate.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): (-[WebIconLoader resource:willSendRequest:]):
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): (-[WebBaseNetscapePluginView getURL:target:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): (-[WebPluginRequest initWithRequest:frameName:notifyData:]): (-[WebPluginRequest request]):
  • Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]):
  • Plugins.subproj/WebNetscapePluginStream.h:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge isReloading]): (-[WebBridge loadEmptyDocumentSynchronously]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient resource:willSendRequest:]):
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate startLoading:]): (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate resource:willSendRequest:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): (-[WebDataSource initialRequest]): (-[WebDataSource request]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setURL:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _originalRequest]): (-[WebDataSource _lastCheckedRequest]): (-[WebDataSource _setLastCheckedRequest:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[WebDefaultPolicyDelegate webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]):
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:willSendRequest:fromDataSource:]):
  • WebView.subproj/WebDefaultWindowOperationsDelegate.m:
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame reload]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem]): (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrame _checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrame _continueAfterNewWindowPolicy:]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueAfterNavigationPolicy:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _loadRequest:inFrameNamed:]):
  • WebView.subproj/WebFrameView.m: (-[WebFrameView concludeDragOperation:]):
  • WebView.subproj/WebImageRepresentation.m:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterNavigationPolicy:formState:]): (-[WebMainResourceClient resource:willSendRequest:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient startLoading:]): (-[WebResourceDelegateProxy resource:willSendRequest:]):
  • WebView.subproj/WebPolicyDelegate.h:
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebView.m: (-[WebView takeStringURLFrom:]):
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]): (-[WebView _openNewWindowWithRequest:]):
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Reviewed by John

Changed WebRequest to NSURLRequest. Several other names,
like some constants whose names were based on WebRequest,
changed as well.

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument initWithContentsOfRequest:frameName:]): (-[BrowserDocument initWithContentsOfURL:ofType:]): (-[BrowserDocument goToRequest:]):
  • BrowserDocumentController.h:
  • BrowserDocumentController.m: (-[BrowserDocumentController _openDocumentWithContentsOfRequest:behind:display:frameName:]): (-[BrowserDocumentController openDocumentWithContentsOfRequest:behind:display:]): (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]): (-[BrowserDocumentController reuseWebController:forRequest:]): (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]): (-[BrowserDocumentController openDocument:]): (-[BrowserDocumentController goToURL:windowPolicy:]): (-[BrowserDocumentController goToRequest:windowPolicy:frameName:]): (-[BrowserDocumentController goToRequest:windowPolicy:]):
  • BrowserWebController.h:
  • BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController webView:createWindowWithRequest:]): (-[BrowserWebController openFileExternallyWithRequest:inFrame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): (-[BrowserWebController revealInFinderWithRequest:inFrame:]): (-[BrowserWebController webView:decideContentPolicyForMIMEType:andRequest:inFrame:decisionListener:]): (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]): (-[BrowserWebController webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]): (-[BrowserWebController webView:decideNewWindowPolicyForAction:andRequest:newFrameName:decisionListener:]): (-[BrowserWebController expectedOrCurrentURL]): (-[BrowserWebController queueRequest:]): (-[BrowserWebController removeRequestFromQueue]): (-[BrowserWebController goNowIfInQueue]): (-[BrowserWebController goToRequest:allowJavaScript:waitInQueue:]): (-[BrowserWebController goToURL:withFallbackURLs:]):
  • BrowserWindowController.m: (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]):
  • BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]): (-[BugReportController resource:willSendRequest:]):
  • ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]):
  • Debug/SnippetController.m: (-[SnippetController load]):
  • DownloadMonitor.h:
  • DownloadMonitor.m: (-[DownloadMonitor download:didStartFromRequest:]): (-[DownloadMonitor downloadMayBeOpenedForRequest:]):
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry _setRequest:]):
  • FrameProgressEntry.m:
  • LoadProgressMonitor.h:
  • LoadProgressMonitor.m: (-[LoadProgressMonitor _createProgressEntryWithRequest:dataSource:]): (-[LoadProgressMonitor webView:identifierForInitialRequest:fromDataSource:]): (-[LoadProgressMonitor webView:resource:willSendRequest:fromDataSource:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):

Mar 23, 2003:

12:02 AM Changeset in webkit [3900] by hyatt
  • 3 edits in trunk/WebCore

Fix the top of the gamespot.com page on the PLT. The
clear status for <br> should be ignored if/when we decide
to ignore the <br> because the previous line didn't break
cleanly.

Reviewed by gramps

  • khtml/rendering/bidi.cpp:

Mar 22, 2003:

6:07 PM Changeset in webkit [3899] by hyatt
  • 3 edits in trunk/WebCore

Loosen up the DTD for <dl>, <dt>, and <dd> so that they can
occur anywhere in a document and be independent of one
another.

Reviewed by darin/gramps

  • khtml/html/dtd.cpp: (DOM::checkChild):
3:27 PM Changeset in webkit [3898] by hyatt
  • 7 edits in trunk/WebCore

Bottom border/padding was incorrectly being used in float
computations. The fix is trivial... positioning of floats
occurs before you add in the bottom border/padding rather
than after.

Also implementing support for transparent borders and adding
code that understands how to draw more complex polys when
individual sides are transparent. This code existed for left
and right borders, but not for top and bottom borders.

These two fixes make the tantek demo found at:

​http://www.tantek.com/map.html

work properly for the first time in Safari.

Reviewed by darin

  • ChangeLog:
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_object.cpp: (RenderObject::paintBorder):
  • khtml/rendering/render_style.h:

Mar 21, 2003:

5:37 PM Changeset in webkit [3897] by hyatt
  • 12 edits in trunk/WebCore

Fixes for all 4 macromedia rendering problems. They were all
related to buggy float handling.

The bugs are 3194998, 3195014, 3915155, 3204114.

This patch splits floats and positioned elements into two lists
instead of 1, and it also adds better logic for clearing out
floats when blocks move vertically.

Reviewed by darin

  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::detach):
  • khtml/rendering/render_flow.cpp: (RenderFlow::addChildWithContinuation):
  • khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::nodeAtPoint):
  • khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::removeFromObjectLists): (RenderObject::nodeAtPoint):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_root.cpp: (RenderRoot::layout):
  • khtml/rendering/render_table.cpp: (RenderTable::layout):
3:25 PM Changeset in webkit [3896] by cblu
  • 9 edits in trunk/WebKit

WebFoundation:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

  • Misc.subproj/WebNSDataExtras.m: (-[NSData _web_guessedMIMEType]): sniff for vcards and ical files
  • types.plist: added text/calendar and text/vcard

WebKit:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _representationClassForMIMEType:]): was _canShowMIMEType
  • WebView.subproj/WebFrameViewPrivate.h:
  • WebView.subproj/WebFrameViewPrivate.m: (+[WebFrameView _viewClassForMIMEType:]): was _canShowMIMEType
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (+[WebTextView unshowableMIMETypes]): new, returns text types that shouldn't be shown
  • WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): call unshowableMIMETypes

WebBrowser:

Fixed: 3081681 - text/calendar should be downloaded instead of displayed
Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

  • Preferences.subproj/WBPreferences.m: (+[WBPreferences shouldOpenFileAtPath:]): auto-open vcf and ics
2:09 PM Changeset in webkit [3895] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3203212 -- nil-deref in khtml::CachedImage::isErrorImage at turbotax.com
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeImage): Remove all occurrences of the image from the list. We don't try to prevent multiple occurrences from getting in there. Also use removeRef instead of remove, for speed.
9:42 AM Changeset in webkit [3894]
  • 2 copies
    2 deletes in tags/JavaScriptCore-68-tarball

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-68-tarball'.

9:42 AM Changeset in webkit [3893] by darin
  • 1 edit in branches/JavaScriptCore-68-tarball-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Update project file for tarball.

9:39 AM Changeset in webkit [3892]
  • 4 copies
    2 deletes in tags/WebCore-68

This commit was manufactured by cvs2svn to create tag 'WebCore-68'.

9:39 AM Changeset in webkit [3891] by darin
  • 1 edit in branches/WebCore-68-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

Updated project file for tarball.

9:31 AM Changeset in webkit [3890] by darin
  • 4 edits in branches/Safari-68~1-branch/WebKit

Rolled in change from trunk.

2003-03-20 Vicki Murley <​vicki@apple.com>

don't include WebFoundation.h

Reviewed by cblu.

  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
9:26 AM Changeset in webkit [3889] by darin
  • 6 edits in trunk/WebCore

WebFoundation:

Reviewed by John.

  • fixed 3204660 -- EUC decoding not used for japanese yahoo page
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_characterSetFromContentTypeHeader]): Do the search for charset= in a case-insensitive way. It's possible that other browsers are case-insensitive, but also possible that it's just Japanese auto-detect that papers over this problem there.
  • other changes
  • Database.subproj/WebLRUFileList.m: (cStringHash): Get rid of unnecessary code to avoid hashes of 0. This is helpful in the place in JavaScriptCore where we copied this from, but it is not helpful here (slightly ugly and does slow things down a smidgen).

WebCore:

Reviewed by John.

  • fixed 3204660 -- EUC decoding not used for japanese yahoo page
  • khtml/misc/decoder.cpp: (Decoder::decode): Do the search for charset= in a case-insensitive way. It's possible that other browsers are case-insensitive, but also possible that it's just Japanese auto-detect that papers over this problem there.
  • other changes
  • kwq/KWQString.mm: (QString::hash): Get rid of unnecessary code to avoid hashes of 0. This is useful in the place in JavaScriptCore where we copied this from, but it is not helpful here (slightly ugly and does slow things down a smidgen).
  • kwq/WebCoreTextRendererFactory.m: Remove unused method.
12:46 AM Changeset in webkit [3888] by hyatt
  • 3 edits in trunk/WebCore

Fix the color handling of link= attributes on <body> elements
to pass in the quirks mode so that lax parsing can take place.

Reviewed by rjw and john

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):
Note: See TracTimeline for information about the timeline view.