⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 29, 2003:

11:22 PM Changeset in webkit [3963] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3138427 - new window opened by javascript is too small for popcap.com game
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Be a bit more tolerant of misformatted attribute strings.
11:20 PM Changeset in webkit [3962] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3180786 - Can't log in to the LL Bean Web site

The problem on this site was misnested tags, leading to two FORM
elements that were nested. Both their onSubmit handlers fired, and
the outer one returned false. The fix was to avoid bubbling submit
events, since this can never be useful in a valid document and
because that is what other browsers seem to do, and what Win IE
documents.

  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::prepareSubmit): Don't allow the submit event to bubble.
4:46 PM Changeset in webkit [3961] by mjs
  • 2 edits in trunk/WebCore

Corrected reviewer in ChangeLog.

4:46 PM Changeset in webkit [3960] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • improved on Darin's fix for 3211289 - REGRESSION: nil-deref in bridgeForWidget
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::bridgeForWidget): Special-case KHTMLView - this is the only kind of widget in the program that's not a form control (so nodeForWidget would return nil for it).

Mar 28, 2003:

3:14 PM Changeset in webkit [3959] by rjw
  • 3 edits in trunk/WebKit

WebKit:

Fix typo in comments that broke headerdoc.

Reviewed by me.

  • WebView.subproj/WebWindowOperationsDelegate.h:

Tests:

Fixed Carbon compile problems in example app.

Reviewed by me.

  • Carbon/CarbonWeb/CarbonWeb.h:
  • Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:pluginFailedWithError:dataSource:]):
  • Carbon/CarbonWeb/THistoryMenu.cp:
  • Carbon/CarbonWeb/TWebWindow.cp:
  • Carbon/CarbonWeb/main.c: (main):
2:05 PM Changeset in webkit [3958] by hyatt
  • 3 edits in trunk/WebCore

Fix a regression caused by my addition of nearestFloatBottom
to the code. I needed to make that a loop rather than just call
it once, since the nearestFloatBottom could be a bad position
for the next line.

This fixes the overlapping text problem at CNN: 3186593.

Reviewed by john

  • khtml/rendering/bidi.cpp:
12:09 PM Changeset in webkit [3957] by darin
  • 6 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3191163 -- hang in QPtrListIterator at www.phiffer.com
  • fixed 3183520 -- XML page has no vertical scrollbar

The hang was due to an exponential algorithm in lowest/rightmostPosition.
Fixed by making some simplifications to these functions, used only to determine the size
of the entire web page. While doing that I cleared some things up that made the XML
scroll bar problem go away too.

Note that www.phiffer.com still does not render right.

  • khtml/rendering/render_block.cpp: (RenderBlock::lowestPosition): Since this is always called on the whole tree, don't worry about which parent deals with which child. Just make sure that every object is visited exactly once. (RenderBlock::rightmostPosition): Ditto.
  • khtml/rendering/render_html.cpp: (RenderHtml::layout): Use the result from calling lowestPosition on the root, since some floating/positioned objects hang off there, rather than here. This seems consistent with the long term approach of doing more work in the root and less in RenderHtml, since XML documents don't have a RenderHtml.
  • khtml/rendering/render_root.cpp: (RenderRoot::docHeight): Call lowestPosition() on self rather than on children. Now that I understand the method, it's clear this is the correct way to do things. (RenderRoot::docWidth): Ditto, but rightmostPosition().
  • fixed 3211289 -- REGRESSION: nil-deref in bridgeForWidget

Maciej may have some ideas about how to fix this even better, but this
is better than just rolling his change out.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewForWidget): Added an assertion. (KWQKHTMLPart::bridgeForWidget): Handle case where node is 0 by returning 0. (KWQKHTMLPart::partForNode): Added an assertion. (KWQKHTMLPart::nodeForWidget): Handle case where eventFilterObject is 0 by returning 0. (KWQKHTMLPart::setDocumentFocus): Quietly do nothing if the node is 0. (KWQKHTMLPart::clearDocumentFocus): Quietly do nothing if the node is 0.
11:47 AM Changeset in webkit [3956] by kocienda
  • 5 edits in trunk/WebKit

WebFoundation:

Reviewed by John

Made SPI out of NSURLConnection code that did not make the API cut.

Removed timeout interval code from NSURLConnection. This is now
a per-request value.

SPI added to NSURLRequest to modify the default per-request
timeout interval.

  • CacheLoader.subproj/NSURLConnection.h:
  • CacheLoader.subproj/NSURLConnection.m: (+[NSURLConnection resourceLoaderRunLoop]): (-[NSURLConnection setDefersCallbacks:]): (-[NSURLConnection defersCallbacks]): (-[NSURLConnection _checkIfTimedOut]):
  • CacheLoader.subproj/NSURLConnectionPrivate.h:
  • CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest initWithURL:]): (-[NSURLRequest timeoutInterval]): (+[NSURLRequest setDefaultTimeoutInterval:]): (+[NSURLRequest defaultTimeoutInterval]):
  • CacheLoader.subproj/NSURLRequestPrivate.h:
  • CookieManager.subproj/WebCookieManager.m:
  • ProtocolHandlers.subproj/WebFTPProtocol.m:
  • ProtocolHandlers.subproj/WebSSLProxyWrapperStream.m:
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m:

WebKit:

Reviewed by John

Imports NSURLConnection private header to access NSURLConnection code
that did not make the API cut.

  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebMainResourceClient.m:

WebBrowser:

Reviewed by John

There is now a per-request timeout for NSURLRequest instead
of one default on the NSURLConnection class. Error string
code updated to account for this.

PageLoadTestRunner now uses SPI added to NSURLRequest to
modify the default timeout interval.

  • LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]):
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner startTest]): (-[PageLoadTestRunner stop]):
10:42 AM Changeset in webkit [3955] by kocienda
  • 5 edits in trunk/WebKit

WebFoundation:

Reviewed by Trey

NSURLConnection class method changed name:

canInitWithRequest: -> canHandleRequest:

Moved to API-approved model for synchronous loads.
Removed some files made obsolete by this change.

  • CacheLoader.subproj/NSURLConnection.h:
  • CacheLoader.subproj/NSURLConnection.m: (+[NSURLConnection canHandleRequest:]):
  • CacheLoader.subproj/WebSynchronousDelegate.h:
  • CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]): (-[WebSynchronousDelegate resourceData]):
  • CacheLoader.subproj/WebSynchronousResult.h: Removed.
  • CacheLoader.subproj/WebSynchronousResult.m: Removed.
  • CacheLoader.subproj/WebSynchronousResultPrivate.h: Removed.
  • ChangeLog:
  • Misc.subproj/WebFoundation.h:
  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Trey

NSURLConnection class method changed name:

canInitWithRequest: -> canHandleRequest:

Moved to API-approved model for synchronous loads.
Removed fixme I put in yesterday having to do with
reposting form data. The feature is fully functional
again.

  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _continueAfterNavigationPolicy:]):

WebBrowser:

Reviewed by Trey

NSURLConnection class method changed name:

canInitWithRequest: -> canHandleRequest:

  • BrowserWebController.m: (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]):
  • ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]):
9:28 AM Changeset in webkit [3954] by kocienda
  • 12 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Cosmetic change. Instances of 'resource' as a local variable
name have been changed to 'connection'. Some other changes
related to this cosmetic cleanup were done as well.

Also updated some comments.

  • CacheLoader.subproj/NSURLConnection.h:
  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection initWithRequest:]): (+[NSURLConnection sendSynchronousRequest:]): (+[NSURLConnection _forceSingleLoad]): (-[NSURLConnection _postCallback:]): (-[NSURLConnectionInternal redirectedToRequest:permanent:]): (-[NSURLConnectionInternal responseAvailable:]): (-[NSURLConnectionInternal didLoadBytes:length:]): (-[NSURLConnectionInternal invalidateCacheObject]): (-[NSURLConnectionInternal finishedLoading]): (-[NSURLConnectionInternal failedWithError:]):
  • CacheLoader.subproj/NSURLConnectionQueue.h:
  • CacheLoader.subproj/NSURLConnectionQueue.m: (-[NSURLConnectionQueue put:URL:]):
  • CacheLoader.subproj/WebSynchronousDelegate.h:
  • CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate dealloc]): (-[WebSynchronousDelegate run:]): (-[WebSynchronousDelegate connection]):

WebKit:

Reviewed by Darin

Cosmetic change. Instances of 'resource' as a local variable
name have been changed to 'connection'. Some other changes
related to this cosmetic cleanup were done as well.

As part of this change, I needed to change some 'connection'
method arguments to 'con' to avoid the name conflict now
that instance variables are named .connection'.

  • Downloads.subproj/WebDownload.m: (-[WebDownloadPrivate dealloc]): (-[WebDownload initWithRequest:]): (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload loadWithDelegate:]): (-[WebDownload _downloadEnded]): (-[WebDownload _cancelWithError:]):
  • Downloads.subproj/WebDownloadPrivate.h:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream connection:didReceiveResponse:]): (-[WebNetscapePluginStream connection:didReceiveData:]): (-[WebNetscapePluginStream connectionDidFinishLoading:]): (-[WebNetscapePluginStream connection:didFailLoadingWithError:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:willSendRequest:redirectResponse:]): (-[WebSubresourceClient connection:didReceiveResponse:]): (-[WebSubresourceClient connection:didReceiveData:]): (-[WebSubresourceClient connectionDidFinishLoading:]): (-[WebSubresourceClient connection:didFailLoadingWithError:]):
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate startLoading:]): (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate setDefersCallbacks:]): (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): (-[WebBaseResourceHandleDelegate connection:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient cancelWithError:]): (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient connection:didReceiveResponse:]): (-[WebMainResourceClient connection:didReceiveData:]): (-[WebMainResourceClient connectionDidFinishLoading:]): (-[WebMainResourceClient connection:didFailLoadingWithError:]): (-[WebMainResourceClient startLoading:]):
8:28 AM Changeset in webkit [3953] by kocienda
  • 14 edits in trunk/WebKit

Tests:

Reviewed by Darin

Changed names for URL connection callback methods to
use the API-approved names. No functional changes.

  • PDFBundle/PDFView.m: (-[PDFResourceDelegate connection:willSendRequest:redirectResponse:]): (-[PDFResourceDelegate connection:didReceiveResponse:]): (-[PDFResourceDelegate connection:didReceiveData:]): (-[PDFResourceDelegate connectionDidFinishLoading:]): (-[PDFResourceDelegate connection:didFailLoadingWithError:]):

WebFoundation:

Reviewed by Darin

Changed names for URL connection callback methods to
use the API-approved names. No functional changes.

  • CacheLoader.subproj/NSURLConnection.h:
  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _sendWillSendRequestCallback]): (-[NSURLConnection _sendDidReceiveResponseCallback]): (-[NSURLConnection _sendDidReceiveDataCallback]): (-[NSURLConnection _sendDidFailLoadingCallback]): (-[NSURLConnection _sendDidFinishLoadingCallback]):
  • CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate connection:willSendRequest:redirectResponse:]): (-[WebSynchronousDelegate connectionDidFinishLoading:]): (-[WebSynchronousDelegate connection:didReceiveResponse:]): (-[WebSynchronousDelegate connection:didReceiveData:]):

WebKit:

Reviewed by Darin

Changed names for URL connection callback methods to
use the API-approved names. No functional changes.

  • Downloads.subproj/WebDownload.h:
  • Downloads.subproj/WebDownload.m: (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload connection:willSendRequest:redirectResponse:]): (-[WebDownload connection:didReceiveResponse:]): (-[WebDownload connection:didReceiveData:]): (-[WebDownload connectionDidFinishLoading:]): (-[WebDownload connection:didFailLoadingWithError:]):
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): (-[WebIconLoader connection:willSendRequest:redirectResponse:]): (-[WebIconLoader connection:didReceiveResponse:]): (-[WebIconLoader connection:didReceiveData:]): (-[WebIconLoader connection:didFailLoadingWithError:]):
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream connection:didReceiveResponse:]): (-[WebNetscapePluginStream connection:didReceiveData:]): (-[WebNetscapePluginStream connectionDidFinishLoading:]): (-[WebNetscapePluginStream connection:didFailLoadingWithError:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:size:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:willSendRequest:redirectResponse:]): (-[WebSubresourceClient connection:didReceiveResponse:]): (-[WebSubresourceClient connection:didReceiveData:]): (-[WebSubresourceClient connectionDidFinishLoading:]): (-[WebSubresourceClient connection:didFailLoadingWithError:]):
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): (-[WebBaseResourceHandleDelegate connection:didFailLoadingWithError:]):
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient connection:didReceiveResponse:]): (-[WebMainResourceClient connection:didReceiveData:]): (-[WebMainResourceClient connectionDidFinishLoading:]): (-[WebMainResourceClient connection:didFailLoadingWithError:]): (-[WebMainResourceClient startLoading:]): (-[WebResourceDelegateProxy connection:willSendRequest:redirectResponse:]): (-[WebResourceDelegateProxy connection:didReceiveResponse:]): (-[WebResourceDelegateProxy connection:didReceiveData:]): (-[WebResourceDelegateProxy connectionDidFinishLoading:]): (-[WebResourceDelegateProxy connection:didFailLoadingWithError:]):
  • WebView.subproj/WebResourceLoadDelegate.h:

WebBrowser:

Reviewed by Darin

Changed names for URL connection callback methods to
use the API-approved names. No functional changes.

  • BugReportController.m: (-[BugReportController connection:willSendRequest:redirectResponse:]): (-[BugReportController connection:didReceiveResponse:]): (-[BugReportController connection:didReceiveData:]): (-[BugReportController connectionDidFinishLoading:]): (-[BugReportController connection:didFailLoadingWithError:]):

Mar 27, 2003:

6:17 PM Changeset in webkit [3952] by hyatt
  • 5 edits in trunk/WebCore

A collection of fixes for tables.

(1) Fixed table layout should only be used if an explicit width
is specified on a table.
(2) width="0" and height="0" should be ignored on table cells!
(3) Fixed table layout wasn't spreading extra space over
columns.

Reviewed by mjs

  • khtml/html/html_tableimpl.cpp: (HTMLTableCellElementImpl::parseAttribute):
  • khtml/rendering/render_table.cpp: (RenderTable::setStyle):
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::layout):
3:43 PM Changeset in webkit [3951] by hyatt
  • 3 edits in trunk/WebCore

Fix for the top of directory.apple.com. Only use the fixed
width on the cell (with nowrap set) if it is *larger* than
our current minwidth.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTableCell::calcMinMaxWidth):
3:38 PM Changeset in webkit [3950] by cblu
  • 2 edits in trunk/WebKit

Left out a "!" in my last check-in.

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
3:05 PM Changeset in webkit [3949] by hyatt
  • 6 edits in trunk/WebCore

Fix for 3166374. When a float is removed, crawl up and down the
tree looking for blocks that contain the float and dirty them all.

Reviewed by darin

  • ChangeLog:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_object.cpp: (RenderObject::markAllDescendantsWithFloatsForLayout): (RenderObject::removeFromObjectLists):
  • khtml/rendering/render_object.h:
2:57 PM Changeset in webkit [3948] by cblu
  • 2 edits in trunk/WebKit
  • Allow Netscape plug-ins that don't have resource files to load in Safari.
  • Added more error handling when loading plug-ins.

Reviewed by darin.

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
2:49 PM Changeset in webkit [3947] by mjs
  • 11 edits in trunk

WebCore:

Reviewed by Darin.

  • fixed 3192344 - nil-deref in KWin::info scrolling amazon while other shopping tabs load
  • fixed 3098365 - Default window size changes as a result of popup windows
  • fixed 3189291 - javascript window.close() closes window, not just originating tab
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scheduleClose): Close via the bridge, not the window directly. (KWQKHTMLPart::bridgeForWidget): Take const QWidget * instead of QWidget *. (KWQKHTMLPart::nodeForWidget): Likewise. (KWQKHTMLPart::khtmlMousePressEvent): Deal with responder issues via bridge, not window directly. (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Likewise. (KWQKHTMLPart::mouseDown): Likewise.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Set resizability via bridge, not window directly.
  • kwq/KWQTextArea.mm: (-[KWQTextArea becomeFirstResponder]): Deal with bridge for first responder issues, not window directly. (-[KWQTextArea drawRect:]): Likewise. (-[KWQTextAreaTextView insertTab:]): Likewise. (-[KWQTextAreaTextView insertBacktab:]): Likewise. (-[KWQTextAreaTextView shouldDrawInsertionPoint]): Likewise. (-[KWQTextAreaTextView selectedTextAttributes]): Likewise.
  • kwq/KWQWidget.mm: (QWidget::setActiveWindow): Focus window via bridge. (QWidget::hasFocus): Handle first responder issues via bridge. (QWidget::setFocus): Likewise. (QWidget::isVisible): Get window from bridge. (QWidget::mapFromGlobal): Get window from bridge. (QWidget::disableFlushDrawing): Add comment noting why it's OK to get the window from the view instead of from the bridge here. (QWidget::enableFlushDrawing): Likewise.
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry): Work through bridge, not window directly. (KWQWindowWidget::mapToGlobal): Likewise. (KWQWindowWidget::setFrameGeometry): Likewise.
  • kwq/WebCoreBridge.h:

WebKit:

Reviewed by Darin.

  • fixed 3192344 - nil-deref in KWin::info scrolling amazon while other shopping tabs load
  • fixed 3098365 - Default window size changes as a result of popup windows
  • fixed 3189291 - javascript window.close() closes window, not just originating tab
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setWindowIsResizable:]): New bridge method, implemented by calling window operations delegate. (-[WebBridge windowIsResizable]): Likewise. (-[WebBridge firstResponder]): Likewise. (-[WebBridge makeFirstResponder:]): Likewise. (-[WebBridge closeWindow]): Likewise.

WebBrowser:

Reviewed by Darin.

  • fixed 3189291 - javascript window.close() closes window, not just originating tab
  • BrowserWebController.m: (-[BrowserWebController windowController]): Moved this method higher. (-[BrowserWebController webViewCloseWindow:]): Close the tab, not the window.
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController closeTabForWebController:]): New method, closes tab or window if there is only one tab.
2:24 PM Changeset in webkit [3946] by kocienda
  • 29 edits in trunk/WebKit

Tests:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

  • HeaderView/DocumentController.m:
  • IBViewer/DocumentController.m:
  • PDFBundle/PDFView.h:
  • PDFBundle/PDFView.m: (-[PDFResourceDelegate resource:willSendRequest:]): (-[PDFResourceDelegate resource:didReceiveResponse:]): (-[PDFResourceDelegate resource:didReceiveData:]): (-[PDFResourceDelegate resourceDidFinishLoading:]): (-[PDFResourceDelegate resource:didFailLoadingWithError:]): (-[PDFView initWithFrame:pageURL:resourceURL:]):
  • SimpleViewer/DocumentController.m:

WebFoundation:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

  • CacheLoader.subproj/NSURLResponse.h:
  • CacheLoader.subproj/WebCacheManager.m:
  • CacheLoader.subproj/WebProtocol.m: (-[WebProtocol initWithProtocolClient:request:]):
  • CacheLoader.subproj/WebResourceDelegate.h:
  • CacheLoader.subproj/WebSynchronousDelegate.h:
  • CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]): (-[WebSynchronousDelegate resource]): (-[WebSynchronousDelegate resource:willSendRequest:]): (-[WebSynchronousDelegate resourceDidFinishLoading:]): (-[WebSynchronousDelegate resource:didReceiveResponse:]): (-[WebSynchronousDelegate resource:didReceiveData:]):
  • CacheLoader.subproj/WebSynchronousResult.h:
  • CookieManager.subproj/WebCookieManager.m: (runningOnLoadThread): (-[WebCookieManager _scheduleSetupOnLoadThread]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebFoundation.h:
  • Misc.subproj/WebFoundationLogging.h:
  • Misc.subproj/WebFoundationLogging.m:
  • Misc.subproj/WebFoundationPrivate.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol deallocateCFNetworkResources]): (-[WebCFNetworkHTTPProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]): (-[WebCFNetworkHTTPProtocol addConditionalFieldsToHeader]): (-[WebCFNetworkHTTPProtocol handleReadStreamEvent:event:]):
  • ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol startLoadingWithCacheObject:]): (-[WebFTPProtocol stopLoading]):
  • ProtocolHandlers.subproj/WebFileProtocol.m:
  • ProtocolHandlers.subproj/WebSSLProxyWrapperStream.m: (-[WebSSLProxyWrapperStream cancel]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (WebSimpleHTTPProtocolInit):
  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

  • Downloads.subproj/WebDownload.m: (-[WebDownload initWithRequest:]): (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload loadWithDelegate:]): (-[WebDownload resource:willSendRequest:]): (-[WebDownload resource:didReceiveResponse:]): (-[WebDownload resource:didReceiveData:]): (-[WebDownload resourceDidFinishLoading:]): (-[WebDownload resource:didFailLoadingWithError:]):
  • Downloads.subproj/WebDownloadPrivate.h:
  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): (-[WebIconLoader resourceDidFinishLoading:]): (-[WebIconLoader resource:willSendRequest:]): (-[WebIconLoader resource:didReceiveResponse:]): (-[WebIconLoader resource:didReceiveData:]): (-[WebIconLoader resource:didFailLoadingWithError:]):
  • Plugins.subproj/WebNetscapePluginStream.h:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream resource:didReceiveResponse:]): (-[WebNetscapePluginStream resource:didReceiveData:]): (-[WebNetscapePluginStream resourceDidFinishLoading:]): (-[WebNetscapePluginStream resource:didFailLoadingWithError:]):
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient resource:willSendRequest:]): (-[WebSubresourceClient resource:didReceiveResponse:]): (-[WebSubresourceClient resource:didReceiveData:]): (-[WebSubresourceClient resourceDidFinishLoading:]): (-[WebSubresourceClient resource:didFailLoadingWithError:]):
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): (-[WebBaseResourceHandleDelegate resource:willSendRequest:]): (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate resource:didReceiveData:]): (-[WebBaseResourceHandleDelegate resourceDidFinishLoading:]): (-[WebBaseResourceHandleDelegate resource:didFailLoadingWithError:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
  • WebView.subproj/WebDefaultResourceLoadDelegate.m:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient resource:willSendRequest:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient resource:didReceiveData:]): (-[WebMainResourceClient resourceDidFinishLoading:]): (-[WebMainResourceClient resource:didFailLoadingWithError:]): (-[WebResourceDelegateProxy setDelegate:]): (-[WebResourceDelegateProxy resource:willSendRequest:]): (-[WebResourceDelegateProxy resource:didReceiveResponse:]): (-[WebResourceDelegateProxy resource:didReceiveData:]): (-[WebResourceDelegateProxy resourceDidFinishLoading:]): (-[WebResourceDelegateProxy resource:didFailLoadingWithError:]):
  • WebView.subproj/WebPolicyDelegate.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by Darin

Changed WebResource to NSURLConnection. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

  • BrowserWebController.m: (-[BrowserWebController decidePolicyForAction:andRequest:inFrame:newFrameName:decisionListener:]):
  • BugReportController.h:
  • BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]): (-[BugReportController resource:willSendRequest:]): (-[BugReportController resource:didReceiveResponse:]): (-[BugReportController resource:didReceiveData:]): (-[BugReportController resourceDidFinishLoading:]): (-[BugReportController resource:didFailLoadingWithError:]):
  • ContextMenuHandler.m: (-[ContextMenuHandler webView:contextMenuItemsForElement:defaultMenuItems:]):
  • DownloadMonitor.m:
  • LoadProgressMonitor.h:
  • LoadProgressMonitor.m:
  • LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]):
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner startTest]): (-[PageLoadTestRunner stop]):
1:45 PM Changeset in webkit [3945] by rjw
  • 5 edits in trunk/WebKit

WebKit:

API change: WebHistory initWithFile: -> initWithContentsOfURL:

Reviewed by Ken.

  • History.subproj/WebHistory.h:
  • History.subproj/WebHistory.m: (-[WebHistory initWithContentsOfURL:]): (-[WebHistory URL]):
  • History.subproj/WebHistoryPrivate.h:
  • History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate initWithContentsOfURL:]): (-[WebHistoryPrivate dealloc]): (-[WebHistoryPrivate _loadHistoryGuts:]): (-[WebHistoryPrivate loadHistory]): (-[WebHistoryPrivate _saveHistoryGuts:]): (-[WebHistoryPrivate URL]): (-[WebHistoryPrivate saveHistory]):

WebBrowser:

API change: WebHistory initWithFile: -> initWithContentsOfURL:

Reviewed by Ken.

  • Debug/DebugUtilities.m: (-[WebHistory populateHistoryWithTestData:]):
  • GlobalHistory.m: (-[GlobalHistory init]):
12:24 PM Changeset in webkit [3944] by darin
  • 3 edits in trunk/WebKit

Reviewed by Shelley.

  • fixed 3157067 -- Pier1.com doesn't load; Microsoft VBScript runtime error in user-agent checking code

Besides this fix, I also filed an evangelism bug, bug 3210612.

  • WebView.subproj/WebUserAgentSpoofTable.gperf: Added pier1.com.
  • WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.
11:59 AM Changeset in webkit [3943] by kocienda
  • 12 edits in trunk/WebKit

Tools:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

  • WebDiskCacheInspector/Controller.m: (-[Controller tableView:objectValueForTableColumn:row:]): (-[Controller setCacheObject:]):

Tests:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

  • SnippetEditor/DataResourceRequest.m: (-[DataProtocolHandler startLoadingWithCacheObject:]):

WebFoundation:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.
Includes these method name changes:

replacemethod "resultCode" with "statusCode"
replacemethod "setResultCode:" with "setStatusCode:"
replacemethod "localizedStringForResultCode:" with "localizedStringForStatusCode:"
replacemethod "isErrorResultCode:" with "isErrorStatusCode:"
replacemethod "contentType" with "MIMEType" /* for NSURLResponse */
replacemethod "contentLength" with "expectedContentLength"
replacemethod "setContentType:" with "setMIMEType:"
replacemethod "setContentLength:" with "setExpectedContentLength:"

Other changes:

Bumped NSURLResponseVersion.
Removed WebError from NSURLResponse. Error object now tracked in WebResource.
Moved NSHTTPURLResponse into NSURLResponse header.
Bumped WebCacheObjectVersion.

  • CacheLoader.subproj/NSURLResponse.h:
  • CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponseInternal init]): (-[NSURLResponseInternal dealloc]): (-[NSURLResponse initWithCoder:]): (-[NSURLResponse encodeWithCoder:]): (-[NSURLResponse MIMEType]): (-[NSURLResponse expectedContentLength]): (-[NSURLResponse setExpectedContentLength:]): (-[NSURLResponse setMIMEType:]): (-[NSURLResponse createdDate]): (-[NSURLResponse lastModifiedDate]): (-[NSHTTPURLResponseInternal initWithCoder:]): (-[NSHTTPURLResponseInternal encodeWithCoder:]): (-[NSHTTPURLResponseInternal dealloc]): (-[NSHTTPURLResponse init]): (-[NSHTTPURLResponse initWithCoder:]): (-[NSHTTPURLResponse encodeWithCoder:]): (-[NSHTTPURLResponse allHeaderFields]): (-[NSHTTPURLResponse statusCode]): (-[NSHTTPURLResponse setStatusCode:]): (-[NSHTTPURLResponse setHeader:]): (-[NSHTTPURLResponse dealloc]): (+[NSHTTPURLResponse localizedStringForStatusCode:]): (+[NSHTTPURLResponse isErrorStatusCode:]):
  • CacheLoader.subproj/NSURLResponsePrivate.h:
  • CacheLoader.subproj/WebCacheObject.m:
  • CacheLoader.subproj/WebMutableResponse.h:
  • CacheLoader.subproj/WebResource.m: (-[WebResource _sendWillSendRequestCallback]): (-[WebResource _sendDidFailLoadingCallback]): (-[WebResource _redirectedToRequest:permanent:]): (-[WebResource _responseAvailable:]): (-[WebResource _didLoadBytes:length:]): (-[WebResource _finishedLoading]): (-[WebResource _failedWithError:]): (-[WebResource _setError:]): (-[WebResourceInternal dealloc]): (-[WebResourceInternal failedWithError:]):
  • CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate result]):
  • Misc.subproj/WebFoundation.h:
  • ProtocolHandlers.subproj/NSHTTPURLResponse.h:
  • ProtocolHandlers.subproj/NSHTTPURLResponse.m: (-[NSHTTPURLResponse statusCode]): (-[NSHTTPURLResponse setStatusCode:]): (+[NSHTTPURLResponse localizedStringForStatusCode:]): (+[NSHTTPURLResponse isErrorStatusCode:]):
  • ProtocolHandlers.subproj/NSHTTPURLResponsePrivate.h:
  • ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoadingWithCacheObject:]):
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]):
  • ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]):
  • ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.h:
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol sendResponseAvailableCallback]): (-[WebHTTPProtocol canStoreCacheObject:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _processHTTPResultCode]):
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

  • Downloads.subproj/WebDownload.m:
  • Misc.subproj/WebNSURLResponseExtras.m: (-[NSURLResponse suggestedFilenameForSaving]): (-[NSHTTPURLResponse suggestedFilenameForSaving]):
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _representationClass]): (-[WebDataSource _commitIfReady:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]): (-[WebFrame _loadItem:fromItem:withLoadType:]):
  • WebView.subproj/WebFrameViewPrivate.m: (-[WebFrameView _makeDocumentViewForDataSource:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient checkContentPolicyForResponse:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient startLoading:]):
  • WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation setDataSource:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView dataSourceUpdated:]):

WebBrowser:

Reviewed by Trey

Moved to final NSURLResponse and NSHTTPURLResponse API.

  • BrowserDocument.m: (-[BrowserDocument fileType]):
  • DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]):
  • DownloadProgressEntry.m: (-[DownloadProgressEntry setResponse:]):
  • LoadProgressMonitor.m: (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]):
  • ResourceProgressEntry.h:
  • ResourceProgressEntry.m: (-[ResourceProgressEntry statusCode]): (-[ResourceProgressEntry setStatusCode:]): (-[ResourceProgressEntry statusString]):
11:26 AM Changeset in webkit [3942] by hyatt
  • 3 edits in trunk/WebCore

This is just a long-standing screwup where I didn't port an old
table fix I made to Lars' new table code properly. The original
fix had this check in it.

The bug is 3171963 (cvs.com).

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
10:52 AM Changeset in webkit [3941] by darin
  • 4 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3156509 -- Safari fills src="" frame with current contents of frameset instead of leaving it empty

The trick here is to always use "about:blank" when the frame URL is empty string.
If we pass the empty string elsewhere, it's going to get passed to completeURL and
turned into a reference to the current document, and we have to avoid doing that
ourselves explicitly too.

  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::HTMLFrameElementImpl): Let the URL default to null rather than "about:blank". We do want to treat the frame as "about:blank", but that's not something people should see when inspecting the frame via the DOM. (HTMLFrameElementImpl::isURLAllowed): Allow empty URLs explicitly, so we don't call completeURL on them. (HTMLFrameElementImpl::updateForNewURL): Map empty URLs to "about:blank" at this level. (HTMLFrameElementImpl::attach): Do the same thing here. At some point we can share more code between these two. (HTMLFrameElementImpl::setLocation): Change this to call updateForNewURL. Not only does this make us handle the empty URL case properly, it also gets the benefit of other things we do in updateForNewURL, like handling the "isURLAllowed" rule, and properly handling the case where we already have a suitable frame.
  • other changes
  • kwq/KWQKHTMLView.mm: Improved a comment.
10:39 AM Changeset in webkit [3940] by sheridan
  • 3 edits in trunk

Safari-70u ... tree's open again

10:24 AM Changeset in webkit [3939]
  • 3 copies in branches/Safari-70-branch

This commit was manufactured by cvs2svn to create branch
'Safari-70-branch'.

10:24 AM Changeset in webkit [3938]
  • 3 copies in tags/Safari-70-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-70-anchor'.

10:24 AM Changeset in webkit [3937]
  • 3 copies in branches/Safari-69~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-69~1-branch'.

10:24 AM Changeset in webkit [3936]
  • 3 copies in tags/Safari-69~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-69~1-anchor'.

10:24 AM Changeset in webkit [3935]
  • 3 copies in tags/Safari-69

This commit was manufactured by cvs2svn to create tag 'Safari-69'.

10:24 AM Changeset in webkit [3934] by sheridan
  • 8 edits in trunk

Safari-69 stamp

Mar 26, 2003:

8:05 PM Changeset in webkit [3933] by rjw
  • 6 edits in trunk/WebKit

File name change WebPluginError.[hm] -> WebPlugInError.[hm]

  • Misc.subproj/WebKit.h:
  • Plugins.subproj/WebNullPluginView.m:
  • Plugins.subproj/WebPlugInError.h:
  • Plugins.subproj/WebPluginError.h: Removed.
  • Plugins.subproj/WebPluginError.m: Removed.
  • Plugins.subproj/WebPluginErrorPrivate.h:
  • WebKit.pbproj/project.pbxproj:
7:05 PM Changeset in webkit [3932] by rjw
  • 10 edits in trunk/WebKit

WebKit:

WebPreferences API changes:

JavaScriptCanOpenWindowsAutomatically -> javaScriptCanOpenWindowsAutomatically
setJavaScriptCanOpenWindowsAutomatically -> setJavaScriptCanOpenWindowsAutomatically
willLoadImagesAutomatically -> loadsImagesAutomatically
setWillLoadImagesAutomatically -> setLoadsImagesAutomatically
JavaEnabled -> isJavaEnabled
setJavaEnabled -> setIsJavaEnabled
JavaScriptEnabled -> isJavaScriptEnabled
setJavaScriptEnabled -> setIsJavaScriptEnabled
pluginsEnabled -> arePlugInsEnabled
setPluginsEnabled -> setArePlugInsEnabled
allowAnimatedImageLooping -> allowsAnimatedImageLooping
setAllowAnimatedImageLooping -> setAllowsAnimatedImageLooping
allowAnimatedImages -> allowsAnimatedImages
setAllowAnimatedImages -> setAllowsAnimatedImages

Made WebHistoryItem's ivars private.

WebPluginError API changes:

pluginPageURL -> plugInPageURLString
contentURL -> contentURLString

Reviewed by cblu.

  • API-Issues.rtf:
  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItemPrivate dealloc]): (-[WebHistoryItem init]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem URLString]): (-[WebHistoryItem originalURLString]): (-[WebHistoryItem title]): (-[WebHistoryItem setDisplayTitle:]): (-[WebHistoryItem icon]): (-[WebHistoryItem lastVisitedDate]): (-[WebHistoryItem hash]): (-[WebHistoryItem anchor]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (-[WebHistoryItem _retainIconInDatabase:]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem URL]): (-[WebHistoryItem target]): (-[WebHistoryItem parent]): (-[WebHistoryItem setURL:]): (-[WebHistoryItem setOriginalURLString:]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem setTarget:]): (-[WebHistoryItem setParent:]): (-[WebHistoryItem setLastVisitedDate:]): (-[WebHistoryItem documentState]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem setScrollPoint:]): (-[WebHistoryItem setAnchor:]): (-[WebHistoryItem isTargetItem]): (-[WebHistoryItem setIsTargetItem:]): (-[WebHistoryItem _recurseToFindTargetItem]): (-[WebHistoryItem targetItem]): (-[WebHistoryItem formData]): (-[WebHistoryItem setFormData:]): (-[WebHistoryItem formContentType]): (-[WebHistoryItem setFormContentType:]): (-[WebHistoryItem formReferrer]): (-[WebHistoryItem setFormReferrer:]): (-[WebHistoryItem children]): (-[WebHistoryItem addChildItem:]): (-[WebHistoryItem childItemWithName:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (-[WebHistoryItem alwaysAttemptToUsePageCache]): (-[WebHistoryItem _scheduleRelease]): (-[WebHistoryItem setHasPageCache:]): (-[WebHistoryItem pageCache]):
  • Plugins.subproj/WebPluginError.h:
  • Plugins.subproj/WebPluginError.m: (-[WebPlugInError plugInPageURLString]):
  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferences isJavaEnabled]): (-[WebPreferences setIsJavaEnabled:]): (-[WebPreferences isJavaScriptEnabled]): (-[WebPreferences setIsJavaScriptEnabled:]): (-[WebPreferences javaScriptCanOpenWindowsAutomatically]): (-[WebPreferences arePlugInsEnabled]): (-[WebPreferences setArePlugInsEnabled:]): (-[WebPreferences allowsAnimatedImages]): (-[WebPreferences allowsAnimatedImageLooping]): (-[WebPreferences setAllowsAnimatedImageLooping:]): (-[WebPreferences setLoadsImagesAutomatically:]): (-[WebPreferences loadsImagesAutomatically]):
  • WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebBrowser:

WebPrefernces API changes:

JavaScriptCanOpenWindowsAutomatically -> javaScriptCanOpenWindowsAutomatically
setJavaScriptCanOpenWindowsAutomatically -> setJavaScriptCanOpenWindowsAutomatically
pluginPageURL -> plugInPageURLString
contentURL -> contentURLString
willLoadImagesAutomatically -> loadsImagesAutomatically
setWillLoadImagesAutomatically -> setLoadsImagesAutomatically
JavaEnabled -> isJavaEnabled
setJavaEnabled -> setIsJavaEnabled
JavaScriptEnabled -> isJavaScriptEnabled
setJavaScriptEnabled -> setIsJavaScriptEnabled
pluginsEnabled -> arePlugInsEnabled
setPluginsEnabled -> setArePlugInsEnabled

Reviewed by cblu.

  • AppController.m: (-[AppController validateUserInterfaceItem:]): (-[AppController toggleJavaScriptCanNotOpenWindows:]):
  • LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences toggleDisplayImages:]): (-[AppearancePreferences initializeFromDefaults]):
  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences toggleJavaEnabled:]): (-[SecurityPreferences toggleJavaScriptEnabled:]): (-[SecurityPreferences toggleJavaScriptCanOpenWindows:]): (-[SecurityPreferences updateJavaScriptViews]): (-[SecurityPreferences togglePluginsEnabled:]): (-[SecurityPreferences initializeFromDefaults]):
6:56 PM Changeset in webkit [3931] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Chris.

  • fix unitialized access.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart):
5:57 PM Changeset in webkit [3930] by mjs
  • 12 edits in trunk/WebCore

Reviewed by Trey.

Made progress towards better handling of window operations.

  • khtml/ecma/kjs_window.cpp: (Window::get): Replace a few part->widget() calls with part->view() -- just as good for the real khtml, but easier to adapt to with KWQ. (WindowFunc::tryCall): Likewise.
  • khtml/khtmlview.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): Delete the window widget. (KWQKHTMLPart::topLevelWidget): Return the window widget. (KWQKHTMLPart::setBridge): Make a new window widget passing it the bridge.
  • kwq/KWQKHTMLView.mm: (KHTMLView::topLevelWidget): Moved here from KHTMLView; get the top level widget from the part. (KHTMLView::mapToGlobal): Moved here from KHTMLView; add a needed cast.
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm: Remove all top level widget considerations.
  • kwq/KWQWindowWidget.h:
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::KWQWindowWidget): Changed to work based on bridge, not window. (KWQWindowWidget::~KWQWindowWidget): Ditto. (KWQWindowWidget::frameGeometry): Ditto. (KWQWindowWidget::mapToGlobal): Ditto. (KWQWindowWidget::mapFromGlobal): Ditto. (KWQWindowWidget::setFrameGeometry): Ditto.

Also:

  • kwq/KWQKHTMLPart.cpp: Removed stuff that did not belong here.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::selectionStartOffset): Moved here from KWQKHTMLPart.cpp (KWQKHTMLPart::selectionEndOffset): Likewise. (KWQKHTMLPart::selectionStart): Likewise. (KWQKHTMLPart::selectionEnd): Likewise. (KWQKHTMLPart::selectionRect): Likesie.
4:13 PM Changeset in webkit [3929] by darin
  • 4 edits in trunk/WebCore

Reviewed by Trey.

  • fixed a storage leak when running cvs-base
  • khtml/rendering/render_list.h: Added _markerInstalledInParent.
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle): Set _markerInstalledInParent to false when creating a new marker. (RenderListItem::detach): Detach the marker if it's not not installed in the parent yet. (RenderListItem::updateMarkerLocation): Set _markerInstalledInParent to true when installing the marker in a parent.
3:41 PM Changeset in webkit [3928] by hyatt
  • 3 edits in trunk/WebCore

Make <label> use tag list 1. Fixes 3206063. Residual style
changes called this out.

Reviewed by darin

  • khtml/html/dtd.cpp: (DOM::checkChild):
3:12 PM Changeset in webkit [3927] by kocienda
  • 39 edits
    2 deletes in trunk/WebKit

Tests:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

  • Carbon/CarbonWeb/MyWebEventTypes.h:
  • Carbon/CarbonWeb/MyWebResourceLoadAdapter.m: (-[MyWebResourceLoadAdapter webView:resource:didReceiveResponse:fromDataSource:]):
  • Carbon/CarbonWeb/TWebWindow.cp:
  • Downloader/MyDocument.h:
  • Downloader/MyDocument.m: (-[MyDocument download:didReceiveResponse:]):
  • PDFBundle/PDFView.m: (-[PDFResourceDelegate resource:didReceiveResponse:]):
  • SnippetEditor/DataResourceRequest.m: (-[DataProtocolHandler startLoadingWithCacheObject:]):

WebFoundation:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

  • CacheLoader.subproj/WebCacheObject.h:
  • CacheLoader.subproj/WebCacheObject.m: (+[WebCacheObject cacheObjectWithResponse:]): (-[WebCacheObject initWithCoder:]): (-[WebCacheObject response]): (-[WebCacheObject setResponse:]):
  • CacheLoader.subproj/WebProtocol.h:
  • CacheLoader.subproj/WebProtocol.m:
  • CacheLoader.subproj/WebProtocolClient.h:
  • CacheLoader.subproj/WebResource.h:
  • CacheLoader.subproj/WebResource.m: (-[WebResource _responseAvailable:]): (-[WebResource _finishedLoading]): (-[WebResource _failedWithError:]): (-[WebResource response]): (-[WebResourceInternal response]): (-[WebResourceInternal responseAvailable:]):
  • CacheLoader.subproj/WebResourceDelegate.h:
  • CacheLoader.subproj/WebResourceQueue.m:
  • CacheLoader.subproj/WebSynchronousDelegate.h:
  • CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate response]): (-[WebSynchronousDelegate resource:didReceiveResponse:]):
  • CacheLoader.subproj/WebSynchronousResult.h:
  • CacheLoader.subproj/WebSynchronousResult.m: (-[WebSynchronousResult response]): (-[WebSynchronousResult _setResponse:]):
  • CacheLoader.subproj/WebSynchronousResultPrivate.h:
  • Misc.subproj/WebFoundation.h:
  • ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoadingWithCacheObject:]):
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m:
  • ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]):
  • ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.h:
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol initWithProtocolClient:request:]): (-[WebHTTPProtocol canStoreCacheObject:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m:
  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

  • Downloads.subproj/WebDownload.h:
  • Downloads.subproj/WebDownload.m: (-[WebDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[WebDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[WebDownload _setResponse:]): (-[WebDownload resource:didReceiveResponse:]):
  • Downloads.subproj/WebDownloadPrivate.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader resource:didReceiveResponse:]):
  • Misc.subproj/WebKit.h:
  • Plugins.subproj/WebBaseNetscapePluginStream.h:
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
  • Plugins.subproj/WebNetscapePluginDocumentView.m:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream resource:didReceiveResponse:]):
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebSubresourceClient.h:
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient resource:didReceiveResponse:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:didReceiveResponse:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource response]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setResponse:]): (-[WebDataSource _commitIfReady:]): (-[WebDataSource _addResponse:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _opened]):
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLRepresentation.m:
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient continueAfterContentPolicy:]): (-[WebMainResourceClient checkContentPolicyForResponse:]): (-[WebMainResourceClient resource:didReceiveResponse:]): (-[WebMainResourceClient startLoading:]): (-[WebResourceDelegateProxy resource:didReceiveResponse:]):
  • WebView.subproj/WebPolicyDelegate.h:
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebTextRepresentation.m:
  • WebView.subproj/WebTextView.m:

WebBrowser:

Reviewed by Darin

Changed WebResponse to NSURLResponse. Some other "supporting" names
changed as well. Note that there are no functional modifications,
only name changes.

  • BrowserDocument.m:
  • BrowserWebController.m:
  • BugReportController.m: (-[BugReportController resource:didReceiveResponse:]):
  • DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]):
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry setResponse:]): (-[DownloadProgressEntry response]):
  • HTMLSourceDocument.m:
  • LoadProgressMonitor.m: (-[LoadProgressMonitor webView:resource:didReceiveResponse:fromDataSource:]):
  • ResourceProgressEntry.m: (-[ResourceProgressEntry statusString]):
11:38 AM Changeset in webkit [3926] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
11:29 AM Changeset in webkit [3925] by darin
  • 3 edits in trunk/WebKit

Reviewed by Trey.

  • fixed 3209091 -- REGRESSION: WebFrameView leak (world leak)
  • WebView.subproj/WebView.m: (-[WebView _commonInitialization:frameName:groupName:]): Use copy, not retain, on an incoming NSString parameter. (-[WebView initWithFrame:frameName:groupName:]): Release the WebFrameView after setting it up.
  • other changes
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Put the bug workaround here inside an ifdef so we don't compile it in on Panther.
11:04 AM Changeset in webkit [3924] by cblu
  • 6 edits in trunk/WebKit

Use the private _cfBundle method on NSBundle so we only create 1 bundle per plug-in package class.

Reviewed by trey.

  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]): (-[WebBasePluginPackage dealloc]):
  • Plugins.subproj/WebNetscapePluginPackage.h:
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage getPluginInfoFromPLists]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage unload]):
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]): (-[WebPluginPackage isLoaded]):
8:46 AM Changeset in webkit [3923] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3208468 -- REGRESSION: checkbox immediately unchecks the first time you check it

The stateChanged signal must be delivered before the mouse up event is handled.

  • kwq/KWQButton.mm: (-[KWQButton initWithQButton:]): Use [self init] instead of [super init]; no real difference, just makes more logical sense. (-[KWQButton action:]): Don't send the mouse up event here. (-[KWQButton sendConsumedMouseUpIfNeeded]): Added. New method that sends the consumed mouse up event. (-[KWQButton mouseDown:]): Use a simplified scheme that uses only a single boolean to control sending the consumed mouse up event. Call sendConsumedMouseUpIfNeeded to do the deed. (QButton::clicked): Added comment to explain why it's important to send the consumed mouse up event here. Added a call to the new sendConsumedMouseUpIfNeeded method, replacing the code that was formerly in -[KWQButton action:].
8:28 AM Changeset in webkit [3922] by kocienda
  • 10 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej

Finished conversion to NSMutableURLRequest. HTTP-specific
mutator methods are now properly placed on an HTTP
category of NSMutableURLRequest. All client code has
been updated to use NSMutableURLRequest where appropriate.

  • CacheLoader.subproj/NSURLRequest.m: (-[NSMutableURLRequest _parametersForWriting]):
  • CacheLoader.subproj/NSURLRequestPrivate.h:

WebKit:

Reviewed by Maciej

Finished conversion to NSMutableURLRequest. HTTP-specific
mutator methods are now properly placed on an HTTP
category of NSMutableURLRequest. All client code has
been updated to use NSMutableURLRequest where appropriate.

  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]):
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate resource:willSendRequest:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient resource:willSendRequest:]):

WebBrowser:

Reviewed by Maciej

Finished conversion to NSMutableURLRequest. HTTP-specific
mutator methods are now properly placed on an HTTP
category of NSMutableURLRequest. All client code has
been updated to use NSMutableURLRequest where appropriate.

  • LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]): (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):

Mar 25, 2003:

7:37 PM Changeset in webkit [3921] by rjw
  • 14 edits in trunk/WebKit

WebKit:

Changed use of plugin to plugIn in our public API
as instructed by those that must be obeyed.

Reviewed by Trey.

Changed userStyleSheetLocation to take/pass an NSURL.

Reviewed by Chris

  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
  • Plugins.subproj/WebNullPluginView.h:
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins.subproj/WebPluginError.h:
  • Plugins.subproj/WebPluginError.m: (-[WebPlugInError plugInPageURL]): (-[WebPlugInError plugInName]):
  • Plugins.subproj/WebPluginErrorPrivate.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetLocation]): (-[WebPreferences setUserStyleSheetLocation:]):
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):
  • API-Issues.rtf: notes to self

WebBrowser:

Changed use of plugin to plugIn in our public API
as instructed by those that must be obeyed.

Reviewed by Trey.

  • LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
  • Preferences.subproj/AdvancedPreferences.m: (-[AdvancedPreferences setStyleSheetPathPreference:]): (-[AdvancedPreferences styleSheetPathPreference]):
6:40 PM Changeset in webkit [3920] by cblu
  • 8 edits in trunk/WebKit

Fixed: 3135385 - many file types don't work with the QuickTime plugin in Safari

Reviewed by trey.

  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage pluginWithPath:]): tweak (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): moved up from WebNetscapePluginPackage (-[WebBasePluginPackage initWithPath:]): retain path, create bundle so subclasses don't have to do this work (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]): was getMIMEInformation from WebPluginPackage (-[WebBasePluginPackage dealloc]): release the bundle (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]): tweak
  • Plugins.subproj/WebNetscapePluginPackage.h:
  • Plugins.subproj/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage preferredLocalizationName]): new (-[WebNetscapePluginPackage openResourceFile]): tweak (-[WebNetscapePluginPackage closeResourceFile:]): tweak (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): tweak (-[WebNetscapePluginPackage getPluginInfoFromResources]): was getMIMEInformation (-[WebNetscapePluginPackage pListForPath:createFile:]): new, calls BP_CreatePluginMIMETypesPreferences if createFile==YES (-[WebNetscapePluginPackage getPluginInfoFromPLists]): calls getPluginInfoFromBundleAndMIMEDictionary with the MIME dictionary from the user's home dir. (-[WebNetscapePluginPackage initWithPath:]): have the superclass do some initialization, call getPluginInfoFromPLists and/or getPluginInfoFromResources (-[WebNetscapePluginPackage executableType]): tweak (-[WebNetscapePluginPackage load]): get the BP_CreatePluginMIMETypesPreferences symbol (-[WebNetscapePluginPackage unload]): tweak (-[WebNetscapePluginPackage dealloc]): tweak
  • Plugins.subproj/WebPluginPackage.h:
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): have the superclass do some initialization, call getPluginInfoFromBundleAndMIMEDictionary (-[WebPluginPackage viewFactory]): tweak (-[WebPluginPackage load]): call principalClass (-[WebPluginPackage isLoaded]): tweak
  • Plugins.subproj/npapi.h: added declaration for the BP_CreatePluginMIMETypesPreferences function pointer.
5:11 PM Changeset in webkit [3919] by hyatt
  • 5 edits in trunk/WebCore

Fix font-family parsing to match the spec (and other browsers).

This fixes bugs 3197584 and 3207760.

Also fix pseudos to be lower-cased. Fixes 3208303.

Reviewed by darin

  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp: (CSSParser::parseFontFamily):
2:43 PM Changeset in webkit [3918] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

  • WebKit part of fix for 3141794 -- No scroll bar for the "collections" column of the bookmarks window

Reviewed by Darin.

  • WebView.subproj/WebDynamicScrollBarsView.h: replaced disallowsScrolling boolean ivar with separate booleans for disallowHorizontalScrolling and disallowVerticalScrolling
  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): take the two disallow booleans into account separately (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]), (-[WebDynamicScrollBarsView allowsHorizontalScrolling]), (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]), (-[WebDynamicScrollBarsView allowsVerticalScrolling]): new methods, do the obvious (-[WebDynamicScrollBarsView setAllowsScrolling:]): changed to set both ivars (-[WebDynamicScrollBarsView allowsScrolling]): changed to return YES if scrolling is allowed in either direction
  • WebKit.exp: exported symbol for WebDynamicScrollBarsView class name

WebBrowser:

  • WebBrowser part of fix for 3141794 -- No scroll bar for the "collections" column of the bookmarks window

Reviewed by Darin.

  • English.lproj/Browser.nib: changed class of scroll view around collections column to be WebDynamicScrollBarsView
  • BookmarksViewController.m: (-[BookmarksViewController setUpBookmarkSourcesScrollView:]): new method, finds the dynamic scroll view enclosing the collections column, and turns off horizontal scrolling for it. (-[BookmarksViewController awakeFromNib:]): call setUpBookmarkSourcesScrollView
2:08 PM Changeset in webkit [3917] by kocienda
  • 3 edits in trunk/WebKit

Reviewed by Richard

Fixed a bug that could occur in the new immutable/mutable
request scheme. When opening a javascript window, it was
possible for a request passed as a method argument to be
released during the course of a method, particularly
after that request was passed to willSendRequest:.
The solution is to ask the data source for its current
request rather than using the one stored in the method
argument.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient startLoading:]):
10:42 AM Changeset in webkit [3916] by trey
  • 8 edits in trunk

JavaScriptCore:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be

additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

WebFoundation:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

  • WebFoundation.pbproj/project.pbxproj:

WebCore:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

  • WebCore.pbproj/project.pbxproj:

WebKit:

Pass -seg_addr_table_filename <FILENAME> to ld. This makes our frameworks in
SYMROOT actually work for symbol resolution because they will have the correct
prebinding address. It also fixes obscure B&I problems with prebinding
reported by Matt Reda.

Note the reason all this is tricky for our projects is that we have a different
install location for Jaguar and Panther. The purpose of this arg is to declare
at link time our eventual location, which allows the prebinding address to be
found in /AppleInternal/Developer/seg_addr_table. We use a funky back-tick
expression within OTHER_LDFLAGS to get a conditional value depending on the
build train we are in.

This can all go away once we only build on Panther and don't embed the
frameworks inside the Safari.app wrapper.

In addition I fixed the OTHER_LDFLAGS settings in our build styles to be
additive instead of overriding, so we have the args we used for B&I in force
when building outside of B&I.

Reviewed by Maciej.

  • WebKit.pbproj/project.pbxproj:
10:36 AM Changeset in webkit [3915] by kocienda
  • 10 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Spilt NSURLRequest into the immutable and mutable variants
as specified by the approved API.

Updated other code to use NSMutableURLRequest where appropriate.

Also updated some comments in NSURLRequest.h and removed
obsolete WebRequestCachePolicyRevalidate NSURLRequestCachePolicy
constant.

  • CacheLoader.subproj/NSURLRequest.h:
  • CacheLoader.subproj/NSURLRequest.m: (+[NSURLRequest requestWithURL:cachePolicy:timeoutInterval:]): (+[NSURLRequest requestWithURL:]): (-[NSURLRequest copyWithZone:]): (-[NSURLRequest mutableCopyWithZone:]): (-[NSURLRequest setURL:]): (-[NSMutableURLRequest setURL:]): (-[NSMutableURLRequest setCachePolicy:]): (-[NSMutableURLRequest setTimeoutInterval:]): (-[NSMutableURLRequest copyWithZone:]): (-[NSMutableURLRequest mutableCopyWithZone:]):
  • CacheLoader.subproj/WebResource.m: (-[WebResource loadWithDelegate:]): (-[WebResource _redirectedToRequest:permanent:]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol stateForCacheObject:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _addRequestMessageBody]):
  • WebFoundation.exp:

WebKit:

Reviewed by Darin

Updated to use NSMutableURLRequest where appropriate.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): (-[WebDataSource request]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setURL:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame reload]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:fromItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):

WebBrowser:

Reviewed by Darin

Updated to use NSMutableURLRequest where appropriate.

  • BrowserDocumentController.m: (-[BrowserDocumentController _goToEachRequest:windowPolicy:frameName:]):
  • BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):
9:23 AM Changeset in webkit [3914] by darin
  • 4 edits in trunk/WebKit

Reviewed by John.

  • fixed 3205745 -- WebKit.framework's Localizable.strings file contains high ASCII in the Key definition.
  • English.lproj/Localizable.strings: Regenerated with the new version of the extract-localizable-strings tool that uses \U syntax instead of "high ASCII".
  • changed cursive font back to "Apple Chancery" for now
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Change to "Apple Chancery".
  • English.lproj/StringsNotToBeLocalized.txt: Update for above change.
Note: See TracTimeline for information about the timeline view.