Context Navigation

khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::parseAttribute): Just ignore the style set by livepage.apple.com, so we get a too-big "Search by Google" rather than a cut off "Search by Goo".

10:26 AM Changeset in webkit [4026] by hyatt

3 edits in trunk/WebCore

Fix for the Search button cutoff on livepage.apple.com We
weren't honoring hspace/vspace on input elements.

Reviewed by darin

khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseAttribute):

9:39 AM Changeset in webkit [4025] by hyatt

3 edits in trunk/WebCore

Fix for 3218085. Remove the bogus 2cm print rule for body in the
html4.css sheet.

Reviewed by darin/trey

khtml/css/html4.css:

8:56 AM Changeset in webkit [4024] by darin

22 edits
1 delete in trunk

WebCore:

Reviewed by Ken.

fixed 3217687 -- REGRESSION: printing uses widths from screen fonts, messing up layout

To get the style machinery working for me instead of against me, I had to introduce both
FontDef and QFont to the screen/printer font dichotomy. Just following that through took
care of the bugs we were seeing.

khtml/rendering/font.h: Add a usePrinterFont field to FontDef (in APPLE_CHANGES).
khtml/rendering/font.cpp: (Font::update): Set the new "printer font" field on the QFont (in APPLE_CHANGES).

khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Set usePrinterFont field on the document's fontDef (in APPLE_CHANGES).

kwq/KWQFont.h: Add isPrinterFont, setter, getter.
kwq/KWQFont.mm: (QFont::QFont): Default isPrinterFont to false, copy when copying. (QFont::operator=): Copy isPrinterFont. (QFont::setPrinterFont): Added. (QFont::operator==): Compare isPrinterFont.

kwq/KWQFontMetrics.mm: Remove the _rendererUsesPrinterFont field and associated code. This was only needed when the same QFont could be both printer and screen font, but now the QFont itself is different.
kwq/KWQPainter.mm: (QPainter::_updateRenderer): Remove textRendererUsesPrinterFont field and associated code, for same reason as above.

kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStylesForDeviceType:]): Set the document's paint device.

kwq/WebCoreTextRendererFactory.h: Remove global setUsingPrinterFonts: and usingPrinterFonts methods. We now handle this at the document level. Add a usingPrinterFont: parameter to rendererWithFont:, which is now how KHTML tells the text rendering code which kind to use.
kwq/WebCoreTextRendererFactory.m: Removed KWQTextRendererFactoryUsingPrinterFonts. (-[WebCoreTextRendererFactory rendererWithFont:usingPrinterFont:]): Added parameter.

other changes

kwq/KWQPaintDevice.h: Store the device type instead of using a virtual function.
kwq/KWQPrinter.h: Set device type in constructor instead of overriding devType function.
kwq/KWQPixmap.h: Changed destructor back to non-virtual (and entire class back to non-polymorphic), now that QPaintDevice doesn't use virtual functions any more.

kwq/KWQPaintDeviceMetrics.h: Remove unused width() and height().
kwq/KWQPaintDeviceMetrics.mm: Ditto.

WebCore.pbproj/project.pbxproj: Removed KWQTextRendererFactory.h.
kwq/KWQTextRendererFactory.h: Removed.

WebKit:

Reviewed by Ken.

fixed 3217687 -- REGRESSION: printing uses widths from screen fonts, messing up layout

WebCoreSupport.subproj/WebTextRendererFactory.m: Removed now-unused rendererWithFont: which called, the now-removed usingPrinterFonts method. WebCore now calls the one with the usingPrinterFont parameter.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Remove setUsingPrinterFonts: calls. This is now handled by the document on the WebCore side. (-[WebHTMLView _setPrinting:]): Ditto.

1:44 AM Changeset in webkit [4023] by mjs

1 edit in trunk/WebKit/ChangeLog

Added the following missing bug number to an earlier checkin.

fixed 3218262 - REGRESSION: Page address becomes about:blank when command-clicking bookmark to load tab

1:32 AM Changeset in webkit [4022] by mjs

2 edits in trunk/WebKit

WebFoundation:

Reviewed by Trey.

Made a return value mutable so callers can conveniently change it w/o allocating.g

Misc.subproj/WebNSDataExtras.h:
Misc.subproj/WebNSDataExtras.m: (-[NSData _web_parseRFC822HeaderFields]): Declare return type as NSMutableDictionary instead of NSDictionary. We were returning a mutable one anyway.

WebKit:

Reviewed by Trey.

fixed 3188914 - loop checking for Flash at http://www.scottsmind.com/celebrity_defacer/index.php

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Take a mutable request, and make sure to set referrer to the frame URL (as other browsers do). (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): pass an NSMutableURLRequest. (-[WebBaseNetscapePluginView getURL:target:]): Likewise. (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): If the plug-in passes a Content-Length header, take it out of the headers and truncate the content appropriately to make WebFoundation happy.

Apr 3, 2003:

11:25 PM Changeset in webkit [4021] by rjw

3 edits in trunk/WebKit

Fix checks for about: to avoid using our 'fake' request when
using WebDataProtocol. This fixes the assertion in the Snippet
Editor.

Reviewed by mjs.

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):

10:20 PM Changeset in webkit [4020] by trey

2 edits in trunk/WebKit

3218212 REGRESSION: page on screen draws ugly while printing is happening

Turn autodisplay of the window off while we print.

Reviewed by Darin.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView beginDocument]): Turn it off. (-[WebHTMLView endDocument]): and back on.

9:52 PM Changeset in webkit [4019] by mjs

6 edits in trunk

WebCore:

Reviewed by Trey.

fixed 3031544 - can't login on secure paytrust page due to lack of onchange handler

kwq/KWQTextField.mm: (-[KWQTextField control:textShouldBeginEditing:]): Send FocusIn event to event filter here. (-[KWQTextField control:textShouldEndEditing:]): Send FocusOut event to event filter here. (-[KWQTextField fieldEditorDidBecomeFirstResponder]): Removed. (-[KWQTextField fieldEditorDidResignFirstResponder]): Removed.
kwq/WebCoreFirstResponderChanges.h: Removed first responder methods.

WebKit:

Reviewed by Trey.

removed no-longer forwarding of become/resignFirstResponder

WebView.subproj/WebHTMLViewPrivate.m: Removed become/resignFirstResponder poses for WebNSTextView.

9:43 PM Changeset in webkit [4018] by mjs

2 edits in trunk/WebKit

Reviewed by Richard and Don.

WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestParametersForWriting]): Renamed from _webDataRequestParameters. (-[NSURLRequest _webDataRequestParametersForReading]): Like the above, but make sure nto to create the part if it does not exist. (-[NSURLRequest _webDataRequestData]): Use _webDataRequestParametersForReading. (-[NSURLRequest _webDataRequestEncoding]): Likewise. (-[NSURLRequest _webDataRequestBaseURL]): Likewise. (-[NSURLRequest _webDataRequestSetData:]):Use _webDataRequestParametersForWriting. (-[NSURLRequest _webDataRequestSetEncoding:]): Likewise. (-[NSURLRequest _webDataRequestSetBaseURL:]): Likewise. (-[NSURLRequest _webDataRequestExternalRequest]): Use _webDataRequestParametersForReading.

7:24 PM Changeset in webkit [4017] by rjw

7 edits in trunk/WebKit

WebFoundation:

Changed NSURLRequest to use an ivar to hold the primary
part data, instead of a dictionary. This avoids a dictionary
lookup when accessing part data. The dictionary lookup turns
out to be very expensive.

Reviewed by ken.

CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequestInternal dealloc]): (-[NSURLRequest _partWithClass:createIfDoesNotExist:]): (-[NSURLRequest mutableCopyWithZone:]): (-[NSMutableURLRequest copyWithZone:]):

WebKit:

Tweaks to minimize access to the parts of a WebDataRequest
that turn out to be slow. Although we've changed NSURLRequest
to be faster, it's still good to keep these tweaks.

Reviewed by ken.

WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
WebView.subproj/WebDataProtocol.h:
WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestExternalRequest]): (+[WebDataProtocol canHandleURL:]):
WebView.subproj/WebDataSource.m: (-[WebDataSource request]):

Tests:

Removed dead code.

Reviewed by ken.

SnippetEditor/SnippetEditor.pbproj/project.pbxproj:
SnippetEditor/DataResourceRequest.h: Removed.
SnippetEditor/DataResourceRequest.m: Removed.

4:12 PM Changeset in webkit [4016] by trey

17 edits
1 add in trunk

WebCore:

3067928 - printing should not break lines in half
3217607 - when printing we should not draw the selection

We leverage the existing knowledge that a couple render object classes had
for adjusting pagination. Wrote 3217705 saying we should add similar
smarts to a few more places.

Reviewed by Darin.

ForwardingHeaders/qprinter.h: Added.
khtml/rendering/render_list.cpp: (RenderListMarker::paintObject): Call our special setBestTruncatedAt instead of khtml's setTruncatedAt.
khtml/rendering/render_root.cpp: (RenderRoot::setBestTruncatedAt): Accumulate the best pagination boundary.
khtml/rendering/render_root.h:
khtml/rendering/render_text.cpp: (RenderText::paintObject): Call our special setBestTruncatedAt instead of khtml's setTruncatedAt.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Don't draw the debugging red background when printing. (KWQKHTMLPart::adjustPageHeight): The meat of the change. Make another painting pass (with actual painting disabled) to get the pagination boundary set as a side effect. Return result up to AppKit.
kwq/KWQPaintDevice.h: devType() made virtual
kwq/KWQPainter.h:
kwq/KWQPainter.mm: (QPainter::QPainter): New constructor for making a printing painter. (QPainter::device): Return either the Screen or Printer device.
kwq/KWQPixmap.h: Destructor needed to become virtual.
kwq/KWQPrinter.h: Implement devType().
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:]): Setup printer device in our painter if we're not drawing to the screen. (-[WebCoreBridge adjustFrames:]): Ditto. (-[WebCoreBridge adjustPageHeightNew:top:bottom:limit:]): Forward to part.

WebKit:

3067928 - printing should not break lines in half

This is just glue to call the right piece in WebCore.

Reviewed by Darin.

(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
Defer to WebCore to set pagination boundary.

3:39 PM Changeset in webkit [4015] by rjw

3 edits in trunk/WebKit

WebKit:

As requested by Nancy, drop "Is" and "Are" from setters,
but leave them in place on the getters.

Reviewed by cblu.

WebView.subproj/WebPreferences.h:
WebView.subproj/WebPreferences.m: (-[WebPreferences setJavaEnabled:]): (-[WebPreferences setJavaScriptEnabled:]): (-[WebPreferences setPlugInsEnabled:]):

WebBrowser:

As requested by Nancy, drop "Is" and "Are" from setters,
but leave them in place on the getters.

Reviewed by cblu.

Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences toggleJavaEnabled:]): (-[SecurityPreferences toggleJavaScriptEnabled:]): (-[SecurityPreferences togglePluginsEnabled:]):

2:48 PM Changeset in webkit [4014] by darin

5 edits in trunk/WebKit

Reviewed by Ken.

remove spoof entries as decided in meeting with Don, Dave, Mark Malone

WebView.subproj/WebUserAgentSpoofTable.gperf: Remove battle.net because it's only there to make Darin happy, and the site works fine without it. Remove pier1.com and disney.go.com because we want to try evangelism first in both those cases, and having a released version where the site works weakens our evangelism efforts.

WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.

disable workaround for Panther bug in Panther builds

Misc.subproj/WebNSImageExtras.m: (-[NSImage _web_dissolveToFraction:]): Add ifdefs.

11:07 AM Changeset in webkit [4013] by darin

6 edits in trunk/WebCore

Reviewed by John.

fixed 3194468 -- ARCH: text zoom should scale line-height as well as font-size

khtml/css/css_valueimpl.h:
khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLength): Add a new version that does a multiply before rounding. Also simplify the rounding code.

khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule): For line height, multiply by the text zoom factor in cases where the height isn't already relative to the font size.

other changes

khtml/rendering/render_replaced.cpp: (RenderWidget::paintObject): Disable code to work around X11 widget size limit. It can only do harm for us.

8:29 AM Changeset in webkit [4012] by darin

4 edits in trunk/WebCore

Reviewed by Ken.

fixed bug 3216832 -- REGRESSION: scroll bar doesn't appear soon enough when shrinking excite.com horizontally

khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Fixed mistake where using the wrong variable led to the colspan distribution loop terminating early, and not giving any additional width to the second column.

fixed some navigator properties as discussed in the meeting yesterday (with Don, Dave, Mike Malone)

khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Use the date 20030107 instead of 20021225 because people think it's less arbitrary. Use "Apple Computer, Inc." as the vendor string.

Apr 2, 2003:

10:41 PM Changeset in webkit [4011] by mjs

2 edits in trunk/WebKit

Reviewed by Trey.

fixed 3213556 - VIP: parent.mainFrameWidth=undefined on page refresh results in missing content

WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]): When reload or going back/forward, make sure to load the original URL of the item, not it's most recent URL. (-[WebFrame _loadURL:intoChild:]): Likewise.

7:24 PM Changeset in webkit [4010] by hyatt

3 edits in trunk/WebCore

Fix for 3216650. Needed an additional check when the disabled
attribute is changed on <link> elements for stylesheets to keep
the pending sheet count in sync.

Reviewed by gramps

khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseAttribute):

5:31 PM Changeset in webkit [4009] by rjw

2 edits in trunk/WebKit

Raise exceptions when these methods are called inappropriately.

Reviewed by Trey.

History.subproj/WebBackForwardList.m: (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToItem:]):

5:22 PM Changeset in webkit [4008] by hyatt

3 edits in trunk/WebCore

Fix for 3212011. Avoid applying a fixup to the minwidth
of overflow:hidden table cells, since we don't really have
an accurate width to compare against.

I filed followup bug 3216709 to deal with the fact that this
fixup has been disabled.

Reviewed by john

khtml/rendering/render_block.cpp:

4:48 PM Changeset in webkit [4007] by hyatt

4 edits in trunk/WebCore

Do not assume all columns have a minwidth/maxwidth of 1px.
Instead give them a min/maxwidth of 0px, and only inflate to
1px if a cell originates in the column.

This fixes the error on travelocity.com, where a large colspan
leads to the implicit creation of a new column that contains no
originating cells. That new column should be 0px wide, not
1px.

The bug # is 3170592.

Reviewed by kocienda

khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn):
khtml/rendering/table_layout.h:

4:47 PM Changeset in webkit [4006] by rjw

16 edits
2 adds in trunk/WebKit

WebKit:

Added new API on WebFrame, loadData: and loadString:

Reviewed by Maciej.

Fixed loading of cocoa plugins.

Reviewed by Chris.

History.subproj/WebBackForwardList.m: (-[WebBackForwardList _entries]):
Plugins.subproj/WebBasePluginPackage.h:
Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage bundle]):
Plugins.subproj/WebPluginDatabase.h:
Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]): (-[WebPluginDatabase loadPluginIfNeededForMIMEType:]): (-[WebPluginDatabase dealloc]):
WebKit.pbproj/project.pbxproj:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
WebView.subproj/WebDataProtocol.h: Added.
WebView.subproj/WebDataProtocol.m: Added. (-[WebDataRequestParameters copyWithZone:]): (-[WebDataRequestParameters mutableCopyWithZone:]): (-[WebDataRequestParameters dealloc]): (+[NSURLRequest _webDataRequestURLForData:]): (-[NSURLRequest _webDataRequestParameters]): (-[NSURLRequest _webDataRequestData]): (-[NSURLRequest _webDataRequestSetData:]): (-[NSURLRequest _webDataRequestEncoding]): (-[NSURLRequest _webDataRequestSetEncoding:]): (-[NSURLRequest _webDataRequestBaseURL]): (-[NSURLRequest _webDataRequestSetBaseURL:]): (-[NSURLRequest _webDataRequestExternalRequest]): (+[WebDataProtocol load]): (+[WebDataProtocol doesURLHaveInternalDataScheme:]): (+[WebDataProtocol canHandleURL:]): (+[WebDataProtocol canonicalURLForURL:]): (-[WebDataProtocol startLoadingWithCacheObject:]): (-[WebDataProtocol stopLoading]):
WebView.subproj/WebDataSource.m: (-[WebDataSource initialRequest]): (-[WebDataSource request]):
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]):
WebView.subproj/WebFrame.h:
WebView.subproj/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame loadString:baseURL:]):
WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _transitionToCommitted:]):
WebView.subproj/WebFrameViewPrivate.m: (-[WebFrameView _makeDocumentViewForDataSource:]):
WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]):

WebBrowser:

Change SnippetEditor to use new loadString: API.

Reviewed by Maciej.

ChangeLog:
Debug/SnippetController.m: (-[SnippetController load]):

4:42 PM Changeset in webkit [4005] by mjs

3 edits in trunk/WebKit

Reviewed by Ken.

fixed 3177183 - disneyland.com says "500 Internal Server Error"

WebView.subproj/WebUserAgentSpoofTable.gperf: Spoof as Mac IE for disney.go.com
WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.

4:39 PM Changeset in webkit [4004] by rjw

2 edits in trunk/WebKit

Reviewed by john.

WebView.subproj/WebPreferences.h: (-[WebPreferences setUserStyleSheetLocation:]): Cleaned up arg and comment.

4:37 PM Changeset in webkit [4003] by rjw

2 edits in trunk/WebKit

Fix for 3200447. Use class_pose to pose so as to avoid
indirect invocation of appkit class initializers.

Reviewed by darin.

WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):

4:33 PM Changeset in webkit [4002] by rjw

2 edits in trunk/WebKit

Removed private headers.

Reviewed by john.

Misc.subproj/WebKit.h:

3:30 PM Changeset in webkit [4001] by hyatt

2 edits in trunk/WebCore

Fix for excite.com. There are many bugs being fixed that all
contributed to the wideness of the table.

The bug # is 3200534

Reviewed by darin

khtml/rendering/table_layout.cpp: (shouldScaleColumns):

3:19 PM Changeset in webkit [4000] by hyatt

3 edits in trunk/WebCore

Fix for excite.com. There are many bugs being fixed that all
contributed to the wideness of the table.

Reviewed by darin

khtml/rendering/table_layout.cpp: (shouldScaleColumns):

1:54 PM Changeset in webkit [3999] by darin

4 edits in trunk/WebCore

Reviewed by Dave.

fixed 3213854 -- REGRESSION: can't click on a text field to select it
fixed 3201477 -- friends links don't work on hyatt's blog

khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint): Skip floating objects when hit testing children.
khtml/rendering/render_inline.cpp: (RenderInline::nodeAtPoint): Ditto.

10:54 AM Changeset in webkit [3998] by trey

5 edits in trunk/WebKit

3174227 - aggressive caching of generated pages causes problems with WIKI

We decided to fix half the observed behavior, as all the bad behavior is
arguably due to a mis-configured server (that sets a max-age=60 on
all its pages).

The fix is that when a redirect comes in response to a POST we force a
load from origin, since this is a common technique sites do to prevent
a post from ending up in the b/f list, and it is very likely you are
on your way back to look at data that you believe you just edited.

Reviewed by Ken.

WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]): Nit cleanup. Remove unused arg. (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): Same nit cleanup.
WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): Force loadFromOrigin if we have a redirect in response to a POST.
WebView.subproj/WebResourceLoadDelegate.h: Add headerdoc comment for redirectResponse param.

10:44 AM Changeset in webkit [3997] by trey

3 edits in trunk/WebCore

WebCore:

3119711 - redirects to anchors leave window half-loaded (was SCClib.org is half loaded, half rendered)

The problem happened when an anchor nav was the last half of a client redirect.
We would never stop the redirect timer, and thus never post a clientRedirectCanceled
message up through the stack. This left the app thinking that it was in redirect
mode even when the whole navigation had finished, which makes it not clear the
progress bar.

Reviewed by Darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Stop the redirect timer.

WebBrowser:

3119711 - redirects to anchors leave window half-loaded (was SCClib.org is half loaded, half rendered)

The problem happened when an anchor nav was the last half of a client redirect.
This case implies that an anchor nav must do the end-of-load cleanup, and not assume
that only a scroll was done to accomplish the nav. Note additional fix was
also needed in WebCore.

Reviewed by Darin.

LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangedWithinPageForDataSource:]): Update our page loading status. Finish up the progress bar, if it was showing non-zero progress.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed