Timeline



Apr 7, 2003:

10:41 PM Changeset in webkit [4042] by cblu
  • 2 edits in trunk/WebKit

Fixed: 3206018 - REGRESSION: Clicks on the BBC news ticker applet don't open story in new window

MSIE and Netscape for Windows treat a nil target as _top. Since this is usually the target audience of applet developers, we will mimic this. This makes 3206018 behave as expected.

Reviewed by gramps.

  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): treat nil as _top.
8:49 PM Changeset in webkit [4041] by rjw
  • 3 edits in trunk/WebKit

API conveniences for IB.

Reviewed by Maciej.

  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView canGoBack]): (-[WebView canGoForward]): (-[WebView reload:]): (-[WebView canMakeTextSmaller]): (-[WebView canMakeTextLarger]): (-[WebView makeTextSmaller:]): (-[WebView makeTextLarger:]):
8:36 PM Changeset in webkit [4040] by rjw
  • 11 edits in trunk

WebCore:

Fix for 3220988. Cancel frame load if it's detached before
finished loading.

Reviewed by Maciej.

  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::detach):
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached):
  • kwq/WebCoreBridge.h:

WebKit:

Fix for 3220988. Cancel frame load if it's detached before
finished loading.

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameDetached]):
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _removeChild:]):
6:59 PM Changeset in webkit [4039] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3220395. nearestFloatBottom() mistakenly returned 0
when it ran out of floats to return.

Reviewed by gramps

  • khtml/rendering/render_block.cpp:
6:36 PM Changeset in webkit [4038] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3219584 - REGRESSION: launch times appear slower in v71
  • WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): Avoid loading plugin database if we can find a view without doing so.
5:36 PM Changeset in webkit [4037] by hyatt
  • 5 edits in trunk/WebCore

Fix for the scrollbar problem in 3220395. Does not yet fix
the overlap problem. lowest/rightmostPosition got broken by
the RenderFlow split. This patch makes sure that we still crawl
into inlines with overhangingContents.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition):
  • khtml/rendering/render_flow.h:
5:24 PM Changeset in webkit [4036] by sheridan
  • 3 edits in branches/Safari-69~1-branch

actually I meant something slightly different ...

5:13 PM Changeset in webkit [4035] by sheridan
  • 5 edits in branches/Safari-69~1-branch

fixing versions for panther vs alexander build train submission

3:31 PM Changeset in webkit [4034] by hyatt
  • 3 edits in trunk/WebCore
  • khtml/html/htmlparser.cpp: (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks):

This is a patch to the parser to prevent residual
style from creating illegal constructs according to the DTD.
For now, it will just bail on performing the fixup if an
illegal construct would be created.

This fixes the regression #3219944.

Reviewed by darin

2:43 PM Changeset in webkit [4033] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3220490 -- REGRESSION: MALLORY horiz scrollbar incorrectly appears with abs positioned content
  • khtml/rendering/render_block.cpp: (RenderBlock::rightmostPosition): Fix a place where I had xPos instead of yPos.
9:55 AM Changeset in webkit [4032] by darin
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebUserAgentSpoofTable.c: Regenerated. When I landed my last change to the .gperf file I forgot to land this.

Apr 4, 2003:

2:28 PM Changeset in webkit [4031]
  • 3 copies in tags/Safari-71

This commit was manufactured by cvs2svn to create tag 'Safari-71'.

2:28 PM Changeset in webkit [4030] by sheridan
  • 8 edits in trunk

Safari-71 versions

1:31 PM Changeset in webkit [4029] by darin
  • 3 edits in trunk/WebCore

Reviewed by John and Richard.

  • fixed 3218725 -- REGRESSION: reproducible crash in recalcStyle on reload
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_paintDevice to 0.
11:13 AM Changeset in webkit [4028] by darin
  • 1 edit in trunk/WebCore/khtml/xml/dom_docimpl.cpp

Roll out accidentally-committed change.

10:34 AM Changeset in webkit [4027] by darin
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3125850 -- VIP: "search by goo" instead of "search by google" at livepage.apple.com

We decided not to fix the general problem right now, but just hack the site.

  • khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::parseAttribute): Just ignore the style set by livepage.apple.com, so we get a too-big "Search by Google" rather than a cut off "Search by Goo".
10:26 AM Changeset in webkit [4026] by hyatt
  • 3 edits in trunk/WebCore

Fix for the Search button cutoff on livepage.apple.com We
weren't honoring hspace/vspace on input elements.

Reviewed by darin

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseAttribute):
9:39 AM Changeset in webkit [4025] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3218085. Remove the bogus 2cm print rule for body in the
html4.css sheet.

Reviewed by darin/trey

  • khtml/css/html4.css:
8:56 AM Changeset in webkit [4024] by darin
  • 22 edits
    1 delete in trunk

WebCore:

Reviewed by Ken.

  • fixed 3217687 -- REGRESSION: printing uses widths from screen fonts, messing up layout

To get the style machinery working for me instead of against me, I had to introduce both
FontDef and QFont to the screen/printer font dichotomy. Just following that through took
care of the bugs we were seeing.

  • khtml/rendering/font.h: Add a usePrinterFont field to FontDef (in APPLE_CHANGES).
  • khtml/rendering/font.cpp: (Font::update): Set the new "printer font" field on the QFont (in APPLE_CHANGES).
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Set usePrinterFont field on the document's fontDef (in APPLE_CHANGES).
  • kwq/KWQFont.h: Add isPrinterFont, setter, getter.
  • kwq/KWQFont.mm: (QFont::QFont): Default isPrinterFont to false, copy when copying. (QFont::operator=): Copy isPrinterFont. (QFont::setPrinterFont): Added. (QFont::operator==): Compare isPrinterFont.
  • kwq/KWQFontMetrics.mm: Remove the _rendererUsesPrinterFont field and associated code. This was only needed when the same QFont could be both printer and screen font, but now the QFont itself is different.
  • kwq/KWQPainter.mm: (QPainter::_updateRenderer): Remove textRendererUsesPrinterFont field and associated code, for same reason as above.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStylesForDeviceType:]): Set the document's paint device.
  • kwq/WebCoreTextRendererFactory.h: Remove global setUsingPrinterFonts: and usingPrinterFonts methods. We now handle this at the document level. Add a usingPrinterFont: parameter to rendererWithFont:, which is now how KHTML tells the text rendering code which kind to use.
  • kwq/WebCoreTextRendererFactory.m: Removed KWQTextRendererFactoryUsingPrinterFonts. (-[WebCoreTextRendererFactory rendererWithFont:usingPrinterFont:]): Added parameter.
  • other changes
  • kwq/KWQPaintDevice.h: Store the device type instead of using a virtual function.
  • kwq/KWQPrinter.h: Set device type in constructor instead of overriding devType function.
  • kwq/KWQPixmap.h: Changed destructor back to non-virtual (and entire class back to non-polymorphic), now that QPaintDevice doesn't use virtual functions any more.
  • kwq/KWQPaintDeviceMetrics.h: Remove unused width() and height().
  • kwq/KWQPaintDeviceMetrics.mm: Ditto.
  • WebCore.pbproj/project.pbxproj: Removed KWQTextRendererFactory.h.
  • kwq/KWQTextRendererFactory.h: Removed.

WebKit:

Reviewed by Ken.

  • fixed 3217687 -- REGRESSION: printing uses widths from screen fonts, messing up layout
  • WebCoreSupport.subproj/WebTextRendererFactory.m: Removed now-unused rendererWithFont: which called, the now-removed usingPrinterFonts method. WebCore now calls the one with the usingPrinterFont parameter.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Remove setUsingPrinterFonts: calls. This is now handled by the document on the WebCore side. (-[WebHTMLView _setPrinting:]): Ditto.
1:44 AM Changeset in webkit [4023] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Added the following missing bug number to an earlier checkin.

  • fixed 3218262 - REGRESSION: Page address becomes about:blank when command-clicking bookmark to load tab
1:32 AM Changeset in webkit [4022] by mjs
  • 2 edits in trunk/WebKit

WebFoundation:

Reviewed by Trey.

Made a return value mutable so callers can conveniently change it w/o allocating.g

  • Misc.subproj/WebNSDataExtras.h:
  • Misc.subproj/WebNSDataExtras.m: (-[NSData _web_parseRFC822HeaderFields]): Declare return type as NSMutableDictionary instead of NSDictionary. We were returning a mutable one anyway.

WebKit:

Reviewed by Trey.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Take a mutable request, and make sure to set referrer to the frame URL (as other browsers do). (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): pass an NSMutableURLRequest. (-[WebBaseNetscapePluginView getURL:target:]): Likewise. (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): If the plug-in passes a Content-Length header, take it out of the headers and truncate the content appropriately to make WebFoundation happy.

Apr 3, 2003:

11:25 PM Changeset in webkit [4021] by rjw
  • 3 edits in trunk/WebKit

Fix checks for about: to avoid using our 'fake' request when
using WebDataProtocol. This fixes the assertion in the Snippet
Editor.

Reviewed by mjs.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):
10:20 PM Changeset in webkit [4020] by trey
  • 2 edits in trunk/WebKit

3218212 REGRESSION: page on screen draws ugly while printing is happening

Turn autodisplay of the window off while we print.

Reviewed by Darin.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView beginDocument]): Turn it off. (-[WebHTMLView endDocument]): and back on.
9:52 PM Changeset in webkit [4019] by mjs
  • 6 edits in trunk

WebCore:

Reviewed by Trey.

  • fixed 3031544 - can't login on secure paytrust page due to lack of onchange handler
  • kwq/KWQTextField.mm: (-[KWQTextField control:textShouldBeginEditing:]): Send FocusIn event to event filter here. (-[KWQTextField control:textShouldEndEditing:]): Send FocusOut event to event filter here. (-[KWQTextField fieldEditorDidBecomeFirstResponder]): Removed. (-[KWQTextField fieldEditorDidResignFirstResponder]): Removed.
  • kwq/WebCoreFirstResponderChanges.h: Removed first responder methods.

WebKit:

Reviewed by Trey.

  • removed no-longer forwarding of become/resignFirstResponder
  • WebView.subproj/WebHTMLViewPrivate.m: Removed become/resignFirstResponder poses for WebNSTextView.
9:43 PM Changeset in webkit [4018] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Richard and Don.

  • WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestParametersForWriting]): Renamed from _webDataRequestParameters. (-[NSURLRequest _webDataRequestParametersForReading]): Like the above, but make sure nto to create the part if it does not exist. (-[NSURLRequest _webDataRequestData]): Use _webDataRequestParametersForReading. (-[NSURLRequest _webDataRequestEncoding]): Likewise. (-[NSURLRequest _webDataRequestBaseURL]): Likewise. (-[NSURLRequest _webDataRequestSetData:]):Use _webDataRequestParametersForWriting. (-[NSURLRequest _webDataRequestSetEncoding:]): Likewise. (-[NSURLRequest _webDataRequestSetBaseURL:]): Likewise. (-[NSURLRequest _webDataRequestExternalRequest]): Use _webDataRequestParametersForReading.
7:24 PM Changeset in webkit [4017] by rjw
  • 7 edits in trunk/WebKit

WebFoundation:

Changed NSURLRequest to use an ivar to hold the primary
part data, instead of a dictionary. This avoids a dictionary
lookup when accessing part data. The dictionary lookup turns
out to be very expensive.

Reviewed by ken.

  • CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequestInternal dealloc]): (-[NSURLRequest _partWithClass:createIfDoesNotExist:]): (-[NSURLRequest mutableCopyWithZone:]): (-[NSMutableURLRequest copyWithZone:]):

WebKit:

Tweaks to minimize access to the parts of a WebDataRequest
that turn out to be slow. Although we've changed NSURLRequest
to be faster, it's still good to keep these tweaks.

Reviewed by ken.

  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
  • WebView.subproj/WebDataProtocol.h:
  • WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestExternalRequest]): (+[WebDataProtocol canHandleURL:]):
  • WebView.subproj/WebDataSource.m: (-[WebDataSource request]):

Tests:

Removed dead code.

Reviewed by ken.

  • SnippetEditor/SnippetEditor.pbproj/project.pbxproj:
  • SnippetEditor/DataResourceRequest.h: Removed.
  • SnippetEditor/DataResourceRequest.m: Removed.
4:12 PM Changeset in webkit [4016] by trey
  • 17 edits
    1 add in trunk

WebCore:

3067928 - printing should not break lines in half
3217607 - when printing we should not draw the selection

We leverage the existing knowledge that a couple render object classes had
for adjusting pagination. Wrote 3217705 saying we should add similar
smarts to a few more places.

Reviewed by Darin.

  • ForwardingHeaders/qprinter.h: Added.
  • khtml/rendering/render_list.cpp: (RenderListMarker::paintObject): Call our special setBestTruncatedAt instead of khtml's setTruncatedAt.
  • khtml/rendering/render_root.cpp: (RenderRoot::setBestTruncatedAt): Accumulate the best pagination boundary.
  • khtml/rendering/render_root.h:
  • khtml/rendering/render_text.cpp: (RenderText::paintObject): Call our special setBestTruncatedAt instead of khtml's setTruncatedAt.
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Don't draw the debugging red background when printing. (KWQKHTMLPart::adjustPageHeight): The meat of the change. Make another painting pass (with actual painting disabled) to get the pagination boundary set as a side effect. Return result up to AppKit.
  • kwq/KWQPaintDevice.h: devType() made virtual
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::QPainter): New constructor for making a printing painter. (QPainter::device): Return either the Screen or Printer device.
  • kwq/KWQPixmap.h: Destructor needed to become virtual.
  • kwq/KWQPrinter.h: Implement devType().
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:]): Setup printer device in our painter if we're not drawing to the screen. (-[WebCoreBridge adjustFrames:]): Ditto. (-[WebCoreBridge adjustPageHeightNew:top:bottom:limit:]): Forward to part.

WebKit:

3067928 - printing should not break lines in half

This is just glue to call the right piece in WebCore.

Reviewed by Darin.

(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
Defer to WebCore to set pagination boundary.

3:39 PM Changeset in webkit [4015] by rjw
  • 3 edits in trunk/WebKit

WebKit:

As requested by Nancy, drop "Is" and "Are" from setters,
but leave them in place on the getters.

Reviewed by cblu.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferences setJavaEnabled:]): (-[WebPreferences setJavaScriptEnabled:]): (-[WebPreferences setPlugInsEnabled:]):

WebBrowser:

As requested by Nancy, drop "Is" and "Are" from setters,
but leave them in place on the getters.

Reviewed by cblu.

  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences toggleJavaEnabled:]): (-[SecurityPreferences toggleJavaScriptEnabled:]): (-[SecurityPreferences togglePluginsEnabled:]):
2:48 PM Changeset in webkit [4014] by darin
  • 5 edits in trunk/WebKit

Reviewed by Ken.

  • remove spoof entries as decided in meeting with Don, Dave, Mark Malone
  • WebView.subproj/WebUserAgentSpoofTable.gperf: Remove battle.net because it's only there to make Darin happy, and the site works fine without it. Remove pier1.com and disney.go.com because we want to try evangelism first in both those cases, and having a released version where the site works weakens our evangelism efforts.
  • WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.
  • disable workaround for Panther bug in Panther builds
  • Misc.subproj/WebNSImageExtras.m: (-[NSImage _web_dissolveToFraction:]): Add ifdefs.
11:07 AM Changeset in webkit [4013] by darin
  • 6 edits in trunk/WebCore

Reviewed by John.

  • fixed 3194468 -- ARCH: text zoom should scale line-height as well as font-size
  • khtml/css/css_valueimpl.h:
  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLength): Add a new version that does a multiply before rounding. Also simplify the rounding code.
  • khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule): For line height, multiply by the text zoom factor in cases where the height isn't already relative to the font size.
  • other changes
  • khtml/rendering/render_replaced.cpp: (RenderWidget::paintObject): Disable code to work around X11 widget size limit. It can only do harm for us.
8:29 AM Changeset in webkit [4012] by darin
  • 4 edits in trunk/WebCore

Reviewed by Ken.

  • fixed bug 3216832 -- REGRESSION: scroll bar doesn't appear soon enough when shrinking excite.com horizontally
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Fixed mistake where using the wrong variable led to the colspan distribution loop terminating early, and not giving any additional width to the second column.
  • fixed some navigator properties as discussed in the meeting yesterday (with Don, Dave, Mike Malone)
  • khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Use the date 20030107 instead of 20021225 because people think it's less arbitrary. Use "Apple Computer, Inc." as the vendor string.
Note: See TracTimeline for information about the timeline view.