⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 8, 2003:

4:39 PM Changeset in webkit [4050] by trey
  • 2 edits in trunk/WebKit

3221355 document is numb to clicks after going back

The layoutTimer now does a layout if the doc is in state Completed,
in addition to LayoutAcceptable.

Reviewed by Richard.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]):
4:29 PM Changeset in webkit [4049] by darin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3221400 -- REGRESSION: password field with onfocus handler that does select causes focus/typing trouble
  • kwq/KWQTextField.mm: (-[KWQTextField selectText:]): Rearrange slightly. (-[KWQTextField becomeFirstResponder]): Add code to make the secure field first responder when in password mode. The old code did this indirectly through the call to setDocumentFocus, which caused minor trouble. (-[KWQSecureTextField selectText:]): Correct the current editor check to use a technique that works even for the secure text field's editor (which does not get returned by currentEditor).
  • kwq/KWQWidget.mm: (QWidget::hasFocus): Update the logic here so it works for the secure text field and the secure text field's editor.
3:59 PM Changeset in webkit [4048] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3166374. Making the nudie blog work. My loop for
removing floating objects when they got deleted wasn't catching
all the cases.

Reviewed by darin

  • khtml/rendering/render_object.cpp: (RenderObject::removeFromObjectLists):
2:39 PM Changeset in webkit [4047] by cblu
  • 6 edits in trunk/WebKit

Fixed: 3221128 - Double grey lines on macromedia.com home page

Flash relies on the ordering of attributes in the EMBED tag (which is really stupid). salign must come after scale.
Changed our plug-in API's to preserve orderings using arrays rather than lose orderings when using dictionaries.

Reviewed by trey.

  • Plugins.subproj/WebBaseNetscapePluginView.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.h:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:]): take attributeKeys and attributeValues instead of a dictionary
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): create attributeKeys and attributeValues to pass to the above method (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): create attributeKeys and attributeValues to pass to the above method
2:10 PM Changeset in webkit [4046] by sheridan
  • 3 edits in trunk

72u versionstamp

12:15 PM Changeset in webkit [4045] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3220463 - REGRESSION: PDF viewer plug-in does not display (worked in 69 and previous)

Reviewed by darin.

  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView didStart]): always call redeliverStream. Have WebNetscapePluginRepresentation determine if it actually needs to do that.
  • Plugins.subproj/WebNetscapePluginRepresentation.h:
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): keep track of _dataLengthReceived which is independent of the data received by the data source (-[WebNetscapePluginRepresentation redeliverStream]): only redeliver the stream if _dataLengthReceived is greater than 0
12:04 PM Changeset in webkit [4044] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3220979. Regression caused by changes to the CSS
parser's error handling. Fix is to narrow my original patch
to handle a specific subtype of error for properties.

Reviewed by darin

  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
10:23 AM Changeset in webkit [4043] by rjw
  • 3 edits in trunk/WebCore

Fixed 3221353. Added check for nil part.

Reviewed by Darin.

  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::detach):

Apr 7, 2003:

10:41 PM Changeset in webkit [4042] by cblu
  • 2 edits in trunk/WebKit

Fixed: 3206018 - REGRESSION: Clicks on the BBC news ticker applet don't open story in new window

MSIE and Netscape for Windows treat a nil target as _top. Since this is usually the target audience of applet developers, we will mimic this. This makes 3206018 behave as expected.

Reviewed by gramps.

  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): treat nil as _top.
8:49 PM Changeset in webkit [4041] by rjw
  • 3 edits in trunk/WebKit

API conveniences for IB.

Reviewed by Maciej.

  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView canGoBack]): (-[WebView canGoForward]): (-[WebView reload:]): (-[WebView canMakeTextSmaller]): (-[WebView canMakeTextLarger]): (-[WebView makeTextSmaller:]): (-[WebView makeTextLarger:]):
8:36 PM Changeset in webkit [4040] by rjw
  • 11 edits in trunk

WebCore:

Fix for 3220988. Cancel frame load if it's detached before
finished loading.

Reviewed by Maciej.

  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::detach):
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached):
  • kwq/WebCoreBridge.h:

WebKit:

Fix for 3220988. Cancel frame load if it's detached before
finished loading.

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameDetached]):
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _removeChild:]):
6:59 PM Changeset in webkit [4039] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3220395. nearestFloatBottom() mistakenly returned 0
when it ran out of floats to return.

Reviewed by gramps

  • khtml/rendering/render_block.cpp:
6:36 PM Changeset in webkit [4038] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Richard.

  • fixed 3219584 - REGRESSION: launch times appear slower in v71
  • WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): Avoid loading plugin database if we can find a view without doing so.
5:36 PM Changeset in webkit [4037] by hyatt
  • 5 edits in trunk/WebCore

Fix for the scrollbar problem in 3220395. Does not yet fix
the overlap problem. lowest/rightmostPosition got broken by
the RenderFlow split. This patch makes sure that we still crawl
into inlines with overhangingContents.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition):
  • khtml/rendering/render_flow.h:
5:24 PM Changeset in webkit [4036] by sheridan
  • 3 edits in branches/Safari-69~1-branch

actually I meant something slightly different ...

5:13 PM Changeset in webkit [4035] by sheridan
  • 5 edits in branches/Safari-69~1-branch

fixing versions for panther vs alexander build train submission

3:31 PM Changeset in webkit [4034] by hyatt
  • 3 edits in trunk/WebCore
  • khtml/html/htmlparser.cpp: (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks):

This is a patch to the parser to prevent residual
style from creating illegal constructs according to the DTD.
For now, it will just bail on performing the fixup if an
illegal construct would be created.

This fixes the regression #3219944.

Reviewed by darin

2:43 PM Changeset in webkit [4033] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3220490 -- REGRESSION: MALLORY horiz scrollbar incorrectly appears with abs positioned content
  • khtml/rendering/render_block.cpp: (RenderBlock::rightmostPosition): Fix a place where I had xPos instead of yPos.
9:55 AM Changeset in webkit [4032] by darin
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebUserAgentSpoofTable.c: Regenerated. When I landed my last change to the .gperf file I forgot to land this.

Apr 4, 2003:

2:28 PM Changeset in webkit [4031]
  • 3 copies in tags/Safari-71

This commit was manufactured by cvs2svn to create tag 'Safari-71'.

2:28 PM Changeset in webkit [4030] by sheridan
  • 8 edits in trunk

Safari-71 versions

1:31 PM Changeset in webkit [4029] by darin
  • 3 edits in trunk/WebCore

Reviewed by John and Richard.

  • fixed 3218725 -- REGRESSION: reproducible crash in recalcStyle on reload
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Initialize m_paintDevice to 0.
11:13 AM Changeset in webkit [4028] by darin
  • 1 edit in trunk/WebCore/khtml/xml/dom_docimpl.cpp

Roll out accidentally-committed change.

10:34 AM Changeset in webkit [4027] by darin
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3125850 -- VIP: "search by goo" instead of "search by google" at livepage.apple.com

We decided not to fix the general problem right now, but just hack the site.

  • khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::parseAttribute): Just ignore the style set by livepage.apple.com, so we get a too-big "Search by Google" rather than a cut off "Search by Goo".
10:26 AM Changeset in webkit [4026] by hyatt
  • 3 edits in trunk/WebCore

Fix for the Search button cutoff on livepage.apple.com We
weren't honoring hspace/vspace on input elements.

Reviewed by darin

  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::parseAttribute):
9:39 AM Changeset in webkit [4025] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3218085. Remove the bogus 2cm print rule for body in the
html4.css sheet.

Reviewed by darin/trey

  • khtml/css/html4.css:
8:56 AM Changeset in webkit [4024] by darin
  • 22 edits
    1 delete in trunk

WebCore:

Reviewed by Ken.

  • fixed 3217687 -- REGRESSION: printing uses widths from screen fonts, messing up layout

To get the style machinery working for me instead of against me, I had to introduce both
FontDef and QFont to the screen/printer font dichotomy. Just following that through took
care of the bugs we were seeing.

  • khtml/rendering/font.h: Add a usePrinterFont field to FontDef (in APPLE_CHANGES).
  • khtml/rendering/font.cpp: (Font::update): Set the new "printer font" field on the QFont (in APPLE_CHANGES).
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Set usePrinterFont field on the document's fontDef (in APPLE_CHANGES).
  • kwq/KWQFont.h: Add isPrinterFont, setter, getter.
  • kwq/KWQFont.mm: (QFont::QFont): Default isPrinterFont to false, copy when copying. (QFont::operator=): Copy isPrinterFont. (QFont::setPrinterFont): Added. (QFont::operator==): Compare isPrinterFont.
  • kwq/KWQFontMetrics.mm: Remove the _rendererUsesPrinterFont field and associated code. This was only needed when the same QFont could be both printer and screen font, but now the QFont itself is different.
  • kwq/KWQPainter.mm: (QPainter::_updateRenderer): Remove textRendererUsesPrinterFont field and associated code, for same reason as above.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStylesForDeviceType:]): Set the document's paint device.
  • kwq/WebCoreTextRendererFactory.h: Remove global setUsingPrinterFonts: and usingPrinterFonts methods. We now handle this at the document level. Add a usingPrinterFont: parameter to rendererWithFont:, which is now how KHTML tells the text rendering code which kind to use.
  • kwq/WebCoreTextRendererFactory.m: Removed KWQTextRendererFactoryUsingPrinterFonts. (-[WebCoreTextRendererFactory rendererWithFont:usingPrinterFont:]): Added parameter.
  • other changes
  • kwq/KWQPaintDevice.h: Store the device type instead of using a virtual function.
  • kwq/KWQPrinter.h: Set device type in constructor instead of overriding devType function.
  • kwq/KWQPixmap.h: Changed destructor back to non-virtual (and entire class back to non-polymorphic), now that QPaintDevice doesn't use virtual functions any more.
  • kwq/KWQPaintDeviceMetrics.h: Remove unused width() and height().
  • kwq/KWQPaintDeviceMetrics.mm: Ditto.
  • WebCore.pbproj/project.pbxproj: Removed KWQTextRendererFactory.h.
  • kwq/KWQTextRendererFactory.h: Removed.

WebKit:

Reviewed by Ken.

  • fixed 3217687 -- REGRESSION: printing uses widths from screen fonts, messing up layout
  • WebCoreSupport.subproj/WebTextRendererFactory.m: Removed now-unused rendererWithFont: which called, the now-removed usingPrinterFonts method. WebCore now calls the one with the usingPrinterFont parameter.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Remove setUsingPrinterFonts: calls. This is now handled by the document on the WebCore side. (-[WebHTMLView _setPrinting:]): Ditto.
1:44 AM Changeset in webkit [4023] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Added the following missing bug number to an earlier checkin.

  • fixed 3218262 - REGRESSION: Page address becomes about:blank when command-clicking bookmark to load tab
1:32 AM Changeset in webkit [4022] by mjs
  • 2 edits in trunk/WebKit

WebFoundation:

Reviewed by Trey.

Made a return value mutable so callers can conveniently change it w/o allocating.g

  • Misc.subproj/WebNSDataExtras.h:
  • Misc.subproj/WebNSDataExtras.m: (-[NSData _web_parseRFC822HeaderFields]): Declare return type as NSMutableDictionary instead of NSDictionary. We were returning a mutable one anyway.

WebKit:

Reviewed by Trey.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Take a mutable request, and make sure to set referrer to the frame URL (as other browsers do). (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): pass an NSMutableURLRequest. (-[WebBaseNetscapePluginView getURL:target:]): Likewise. (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): If the plug-in passes a Content-Length header, take it out of the headers and truncate the content appropriately to make WebFoundation happy.
Note: See TracTimeline for information about the timeline view.