Timeline
Apr 9, 2003:
- 7:12 PM Changeset in webkit [4057] by
-
- 4 edits in trunk/WebKit
Fix for 3222904. This change fixes the immediate symptoms of the bug,
but we need to come back to this issue after beta 2. Bug 3223929 captures
the other problems.
Reviewed by gramps.
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource __setRequest:]): (-[WebDataSource _setRequest:]):
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldReloadForCurrent:andDestination:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
- 6:48 PM Changeset in webkit [4056] by
-
- 4 edits in trunk/WebCore
This first fix is a refinement of the patch I produced to fix <nobr>
on cnn.com recently. It wasn't quite good enough to plug the
regression on other sites. This fix just checks the object
we're currently breaking on (which is what I meant to do) and
not the last object examined (which will always just be the
previous object you looked at).
The code currently in the tree would work if you had two objects
like this:
[Normal Whitespace] [Nowrap Whitespace]
but not if you had three:
[Normal][Nowrap][Nowrap]
Since when you looked at the third object, |last| would be the
previous nowrap object and not the normal object. The line break
properly stays at the normal object as long as nowrap objects are
encountered, so this patch basically does what the original was
intended to do.
This fixes the line break problems on 1800flowers.com, a line break
problem on the bugzilla.mozilla.org layout test, a problem
on the zdnet layout test, and 3207196 a regression on livejournal.
The second fix in this patch is a simple reversal of
containsOnlyWhitespace. The method on RenderText was
backwards! No logical changes have been made... I just inverted
all the callers, and then I patched the method.
The third fix is to make images check for == normal instead of != nowrap
in a few places, thus preventing incorrect line break points from being
set up.
Reviewed by gramps
- khtml/rendering/bidi.cpp:
- khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace):
- 5:46 PM Changeset in webkit [4055] by
-
- 3 edits in trunk/WebKit
Reviewed by Chris, Trey, Darin and Don.
- fixed 3223568 - site icons lost when moving from older Safari to 71
- Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): Rename old database containing directory to new, so we carry over old databases. The format is forward but not backward compatible. (-[WebIconDatabase _loadIconDictionaries]): Treat no version at all as version 1, so we can load old-style databases.
Reviewed by Trey.
- English.lproj/StringsNotToBeLocalized.txt: Updated.
- 4:19 PM Changeset in webkit [4054] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3223414 -- update text encoding menu and encoding names table
Made changes as suggested by Deborah Goldsmith and Peter Edberg from the International group.
- kwq/mac-encodings.txt: Moved all Korean character sets that are not explicitly Macintosh from MacKorean to EUC_KR. Moved Shift JIS character sets that are not explicitly Microsoft from DOSJapanese to ShiftJIS_X0213_00. Moved cp949 from DOSKorean to EUC_KR (DOSKorean is not implemented in Jaguar). Moved big5 character sets that are not explicitly Microsoft from DOSChineseTrad to Big5_HKSCS_1999. Moved all gb2312-80 character sets from GB_2312_80 to GB_18030_2000. Moved all gbk character sets from GBK_95 to GB_18030_2000. Moved all euc-cn character sets from EUC_CN to GB_18030_2000.
- kwq/KWQCharsetData.c: Regenerated.
- 1:05 PM Changeset in webkit [4053] by
-
- 4 edits in trunk/WebCore
Reviewed by Richard.
- fixed 3223126 -- REGRESSION: exception BrowserWindow isDescendantOf:]: selector not recognized
- kwq/KWQWidget.mm: (QWidget::hasFocus): Add missing check of the class of the first responder before calling an NSView method on it.
- 12:02 PM Changeset in webkit [4052] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3222708 -- REGRESSION: repro crash trying to read news at nttdocomo
- khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Make window.open do its location change with scheduleRedirection like all the other JavaScript calls that change location.
- 11:01 AM Changeset in webkit [4051] by
-
- 2 edits in trunk/WebKit
Fixed: 3223022 - Plug-in content bleeds onto frontmost tab
Reviewed by darin.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewDidMoveToWindow]): Explicitly call setWindow when the plug-in view is moved out of the window so it is clipped out of sight.
Apr 8, 2003:
- 4:39 PM Changeset in webkit [4050] by
-
- 2 edits in trunk/WebKit
3221355 document is numb to clicks after going back
The layoutTimer now does a layout if the doc is in state Completed,
in addition to LayoutAcceptable.
Reviewed by Richard.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]):
- 4:29 PM Changeset in webkit [4049] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3221400 -- REGRESSION: password field with onfocus handler that does select causes focus/typing trouble
- kwq/KWQTextField.mm: (-[KWQTextField selectText:]): Rearrange slightly. (-[KWQTextField becomeFirstResponder]): Add code to make the secure field first responder when in password mode. The old code did this indirectly through the call to setDocumentFocus, which caused minor trouble. (-[KWQSecureTextField selectText:]): Correct the current editor check to use a technique that works even for the secure text field's editor (which does not get returned by currentEditor).
- kwq/KWQWidget.mm: (QWidget::hasFocus): Update the logic here so it works for the secure text field and the secure text field's editor.
- 3:59 PM Changeset in webkit [4048] by
-
- 3 edits in trunk/WebCore
Fix for 3166374. Making the nudie blog work. My loop for
removing floating objects when they got deleted wasn't catching
all the cases.
Reviewed by darin
- khtml/rendering/render_object.cpp: (RenderObject::removeFromObjectLists):
- 2:39 PM Changeset in webkit [4047] by
-
- 6 edits in trunk/WebKit
Fixed: 3221128 - Double grey lines on macromedia.com home page
Flash relies on the ordering of attributes in the EMBED tag (which is really stupid). salign must come after scale.
Changed our plug-in API's to preserve orderings using arrays rather than lose orderings when using dictionaries.
Reviewed by trey.
- Plugins.subproj/WebBaseNetscapePluginView.h:
- Plugins.subproj/WebBaseNetscapePluginView.m:
- Plugins.subproj/WebNetscapePluginEmbeddedView.h:
- Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:]): take attributeKeys and attributeValues instead of a dictionary
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): create attributeKeys and attributeValues to pass to the above method (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): create attributeKeys and attributeValues to pass to the above method
- 2:10 PM Changeset in webkit [4046] by
-
- 3 edits in trunk
72u versionstamp
- 12:15 PM Changeset in webkit [4045] by
-
- 4 edits in trunk/WebKit
Fixed: 3220463 - REGRESSION: PDF viewer plug-in does not display (worked in 69 and previous)
Reviewed by darin.
- Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView didStart]): always call redeliverStream. Have WebNetscapePluginRepresentation determine if it actually needs to do that.
- Plugins.subproj/WebNetscapePluginRepresentation.h:
- Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): keep track of _dataLengthReceived which is independent of the data received by the data source (-[WebNetscapePluginRepresentation redeliverStream]): only redeliver the stream if _dataLengthReceived is greater than 0
- 12:04 PM Changeset in webkit [4044] by
-
- 4 edits in trunk/WebCore
Fix for 3220979. Regression caused by changes to the CSS
parser's error handling. Fix is to narrow my original patch
to handle a specific subtype of error for properties.
Reviewed by darin
- khtml/css/parser.cpp:
- khtml/css/parser.y:
- 10:23 AM Changeset in webkit [4043] by
-
- 3 edits in trunk/WebCore
Fixed 3221353. Added check for nil part.
Reviewed by Darin.
- khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::detach):
Apr 7, 2003:
- 10:41 PM Changeset in webkit [4042] by
-
- 2 edits in trunk/WebKit
Fixed: 3206018 - REGRESSION: Clicks on the BBC news ticker applet don't open story in new window
MSIE and Netscape for Windows treat a nil target as _top. Since this is usually the target audience of applet developers, we will mimic this. This makes 3206018 behave as expected.
Reviewed by gramps.
- Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): treat nil as _top.
- 8:49 PM Changeset in webkit [4041] by
-
- 3 edits in trunk/WebKit
API conveniences for IB.
Reviewed by Maciej.
- WebView.subproj/WebView.h:
- WebView.subproj/WebView.m: (-[WebView canGoBack]): (-[WebView canGoForward]): (-[WebView reload:]): (-[WebView canMakeTextSmaller]): (-[WebView canMakeTextLarger]): (-[WebView makeTextSmaller:]): (-[WebView makeTextLarger:]):
- 8:36 PM Changeset in webkit [4040] by
-
- 11 edits in trunk
WebCore:
Fix for 3220988. Cancel frame load if it's detached before
finished loading.
Reviewed by Maciej.
- khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::detach):
- khtml/khtml_part.h:
- kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached):
- kwq/WebCoreBridge.h:
WebKit:
Fix for 3220988. Cancel frame load if it's detached before
finished loading.
Reviewed by Maciej.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameDetached]):
- WebView.subproj/WebFrame.h:
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _removeChild:]):
- 6:59 PM Changeset in webkit [4039] by
-
- 3 edits in trunk/WebCore
Fix for 3220395. nearestFloatBottom() mistakenly returned 0
when it ran out of floats to return.
Reviewed by gramps
- khtml/rendering/render_block.cpp:
- 6:36 PM Changeset in webkit [4038] by
-
- 2 edits in trunk/WebKit
Reviewed by Richard.
- fixed 3219584 - REGRESSION: launch times appear slower in v71
- WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): Avoid loading plugin database if we can find a view without doing so.
- 5:36 PM Changeset in webkit [4037] by
-
- 5 edits in trunk/WebCore
Fix for the scrollbar problem in 3220395. Does not yet fix
the overlap problem. lowest/rightmostPosition got broken by
the RenderFlow split. This patch makes sure that we still crawl
into inlines with overhangingContents.
Reviewed by darin
- khtml/rendering/render_block.cpp:
- khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition):
- khtml/rendering/render_flow.h:
- 5:24 PM Changeset in webkit [4036] by
-
- 3 edits in branches/Safari-69~1-branch
actually I meant something slightly different ...
- 5:13 PM Changeset in webkit [4035] by
-
- 5 edits in branches/Safari-69~1-branch
fixing versions for panther vs alexander build train submission
- 3:31 PM Changeset in webkit [4034] by
-
- 3 edits in trunk/WebCore
- khtml/html/htmlparser.cpp: (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks):
This is a patch to the parser to prevent residual
style from creating illegal constructs according to the DTD.
For now, it will just bail on performing the fixup if an
illegal construct would be created.
This fixes the regression #3219944.
Reviewed by darin
- 2:43 PM Changeset in webkit [4033] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave.
- fixed 3220490 -- REGRESSION: MALLORY horiz scrollbar incorrectly appears with abs positioned content
- khtml/rendering/render_block.cpp: (RenderBlock::rightmostPosition): Fix a place where I had xPos instead of yPos.
- 9:55 AM Changeset in webkit [4032] by
-
- 2 edits in trunk/WebKit
- WebView.subproj/WebUserAgentSpoofTable.c: Regenerated. When I landed my last change to the .gperf file I forgot to land this.
