Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Apr 11, 2003:

6:17 PM Changeset in webkit [4085] by cblu

• 3 edits in trunk/WebKit

WebKit:

Removed WebKitErrorResourceLoadInterruptedByPolicyChange error because it isn't used.

Reviewed by john.

• Misc.subproj/WebKitErrors.h:
• Misc.subproj/WebKitErrors.m: (registerErrors):
• WebKit.pbproj/project.pbxproj:

WebBrowser:

Fixed: 3109110 - clean up status bar after deciding to download
Fixed: 3090317 - Download progress feedback very bad after drag & drop .dmg URL to Alex

Reviewed by trey, john.

• BrowserWebErrorExtras.h:
• BrowserWebErrorExtras.m: (-[WebError isCancelledError]): new (-[WebError isPolicyChangeError]): new
• FrameProgressEntry.m: (-[FrameProgressEntry stage]): use new error categories
• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor reset]): new, set main entry to nil if we haven't previously committed (-[LoadProgressMonitor committedFrame:]): set committed bool
• LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): call [LoadProgressMonitor reset] for downloads

5:34 PM Changeset in webkit [4084] by trey

• 11 edits in trunk

WebCore:

3148002 - printing shouldn't depend on the size of the window

The basic strategy is copied from khtmlview's print method: We reset the width
of the document to the paper width minus margins, and relayout before paginating
and printing.

Reviewed by Richard.

• khtml/rendering/render_root.cpp: (RenderRoot::layout): Always resize our view, even when doing a layout when in printing mode. It's necessary to change the view size because we rely on the AppKit built-in pagination, which operates using the view geometry.
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutForPageWidth): New method to do a layout given a specific width.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge _setPrintingMode:]): Helper routine to take the RenderRoot in and out of printing mode. (-[WebCoreBridge forceLayout]): Turn printing mode on/off. (-[WebCoreBridge forceLayoutForPageWidth:]): Turn printing mode on/off. New glue routine to call part. (-[WebCoreBridge drawRect:withPainter:]): Turn printing mode on/off. (-[WebCoreBridge drawRect:]): Test paintDevice type instead of graphics context to determine printing mode. The latter is still on when we are wrapping up the job and want to be setting things back to normal. (-[WebCoreBridge adjustFrames:]): Ditto. (-[WebCoreBridge adjustPageHeightNew:top:bottom:limit:]): Turn printing mode on/off.

WebKit:

3148002 - printing shouldn't depend on the size of the window

The basic strategy is copied from khtmlview's print method: We reset the width
of the document to the paper width minus margins, and relayout before paginating
and printing.

Reviewed by Richard.

• WebKit.pbproj/project.pbxproj: Someone is using an old version...
• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Don't do the dynamic scrollbar update magic when printing.
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): New routine, basically the old layout method with a new parameter. If we're given an width, we call a different bridge method. (-[WebHTMLView layout]): Just call above method with width==0 (-[WebHTMLView drawRect:]): Protect setting/resetting of graphics context and additional clip with a DURING/HANDLER. I saw an assertion failure that could be explained by this, so this is mostly a beartrap for that problem. (-[WebHTMLView _setPrinting:pageWidth:]): Pass page width through to others. (-[WebHTMLView beginDocument]): If we are not in a frame set, do a layout using the page width. (-[WebHTMLView endDocument]): Pass 0 to new pageWidth: arg.

4:30 PM Changeset in webkit [4083] by darin

• 5 edits in trunk/WebCore

Reviewed by Richard.

• fixed 3225472 -- www.sina.com.cn uses A3A0 for full-width space; used to work in Simplified Chinese (Mac OS)

• kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUsingTEC): Work around the problem in the Text Encoding Converter by changing all U+E5E5 to U+3000.

• kwq/KWQString.h: Added replace(QChar, QChar), since Qt has it and I need it.
• kwq/KWQString.mm: (QString::find): Fixed a bug where we'd yield a FATAL and return -1 on deployment if you searched for a non-ASCII character in a string that had ASCII valid and not Unicode valid. (QString::replace): Added replace(QChar, QChar).

2:38 PM Changeset in webkit [4082] by trey

• 2 edits in trunk/WebKit

3220349 - assertion failure in [WebFrame _recursiveGoToItem:...] hitting Back while loading movie

The problem was that when we go back we call stopLoading on the top frame, but
that has a bogus optimization to not do any work if state=Completed. That is a
bogus test if a subframe is doing a load. The fix is to just always tell the
dataSources to stopLoading. They already bail quickly when they are not loading,
so there is no significant additional cost.

Reviewed by Richard.

• WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]):

1:23 PM Changeset in webkit [4081] by sheridan

• 6 edits in trunk

Safari-74u.
also "1.0" instead of 0.9 AND instead of "1.0 Beta[ 2]"
cheers

10:07 AM Changeset in webkit [4080]

• 3 copies
  2 deletes in branches/WebCore-73-tarball-branch

This commit was manufactured by cvs2svn to create branch
'WebCore-73-tarball-branch'.

10:07 AM Changeset in webkit [4079]

• 3 copies
  2 deletes in tags/WebCore-73-tarball-anchor

This commit was manufactured by cvs2svn to create tag
'WebCore-73-tarball-anchor'.

10:07 AM Changeset in webkit [4078]

• 3 copies in branches/Safari-74-branch

This commit was manufactured by cvs2svn to create branch
'Safari-74-branch'.

10:07 AM Changeset in webkit [4077]

• 3 copies in tags/Safari-74-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-74-anchor'.

10:07 AM Changeset in webkit [4076]

• 3 copies in tags/Safari-73

This commit was manufactured by cvs2svn to create tag 'Safari-73'.

10:07 AM Changeset in webkit [4075]

• 1 copy
  2 deletes in branches/JavaScriptCore-73-tarball-branch

This commit was manufactured by cvs2svn to create branch
'JavaScriptCore-73-tarball-branch'.

10:07 AM Changeset in webkit [4074]

• 1 copy
  2 deletes in tags/JavaScriptCore-73-tarball-anchor

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-73-tarball-anchor'.

10:07 AM Changeset in webkit [4073] by sheridan

• 8 edits in trunk

73 stamp

Apr 10, 2003:

7:49 PM Changeset in webkit [4072] by rjw

• 2 edits in trunk/WebKit

Fixed 3219525

Our work-around for the CG pattern cache bogosity was always bypassed,
consequently we'd unnecessarily burn lots of memory filling that cache.

Reviewed by mjs & gramps.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): (-[WebImageRenderer tileInRect:fromPoint:]):

7:22 PM Changeset in webkit [4071] by mjs

• 2 edits in trunk/WebKit

Reviewed by Maciej.

• fixed 3225042 - MallocDebug shows "access after deallocated" problem in WebFrameView

• WebView.subproj/WebFrameView.m: (-[WebFrameView dealloc]): Nil out _private. (-[WebFrameView nextKeyView]): Check _private for nil. (-[WebFrameView previousKeyView]): Check _private for nil.

7:16 PM Changeset in webkit [4070] by rjw

• 3 edits in trunk/WebKit

Fix performance regression with iBench (post 71). The iBench cheat was being defeated.

Ensure that the layout timer is always invalidated when a frame completes
or is cancelled.

Reviewed by mjs & gramps.

• WebView.subproj/WebFrame.m: (-[WebFrame stopLoading]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]):

7:01 PM Changeset in webkit [4069] by trey

• 7 edits in trunk

WebCore:

3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields

New WC support function.

Reviewed by Darin.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge elementWithName:inForm:]): Run through the form's elements looking for a matching name.

WebKit:

3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields

Just glue for calling a new WC function.

Reviewed by Darin.

• WebView.subproj/WebHTMLRepresentation.h:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation elementWithName:inForm:]):

WebBrowser:

3224973 - Safari sometimes stores data for AUTOCOMPLETE=OFF fields and password fields

User new WC SPI to lookup the element for each field at submit time,
and test them for AUTOCOMPLETE=OFF or if they are password fields.

This is in the "saving data for previous forms case". Saving creds in
the keychain is done elsewhere.

Reviewed by Darin.

• FormCompletionController.m: (+[FormCompletionController _frame:willSubmitRegularForm:withValues:]):

3:45 PM Changeset in webkit [4068]

• 3 copies in tags/Safari-72

This commit was manufactured by cvs2svn to create tag 'Safari-72'.

3:45 PM Changeset in webkit [4067] by sheridan

• 8 edits in trunk

Safari-72 versionstamp

2:41 PM Changeset in webkit [4066] by mjs

• 2 edits in trunk/WebKit

WebKit:

Reviewed by Chris.

• fixed 3224690 - REGRESSION: Download related errors aren't preserved across launches

• WebKit.pbproj/project.pbxproj: Install WebKitErrorsPrivate.h as SPI.

WebBrowser:

Reviewed by Chris.

• fixed 3224690 - REGRESSION: Download related errors aren't preserved across launches

• BrowserWebController.m: (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): Use _webKitErrorWithCode:forURL: SPI.
• DownloadProgressEntry.m: -([DownloadProgressEntry initWithDictionary:]): Use _webKitErrorWithCode:forURL: SPI when appropriate. Also, avoid treating error code of 0 as "no error" if we have a non-empty non-nil domain.

1:57 PM Changeset in webkit [4065] by darin

• 4 edits in trunk/WebKit

Reviewed by Trey.

• fixed 3224622 -- REGRESSION: in an empty window, repeated tabs don't cycle back to location field

Added logic to WebFrameView's next/previous that matches the logic in WebHTMLView.
Looking for a better solution some day to the whole nextKeyView thing.

• WebView.subproj/WebFrameView.m: (-[WebFrameView nextKeyView]): If being called from nextValidKeyView, return the nextKeyView of the WebView rather than of self. (-[WebFrameView previousKeyView]): Ditto. (-[WebFrameView nextValidKeyView]): Set the inNextValidKeyView flag. (-[WebFrameView previousValidKeyView]): Ditto.

• WebView.subproj/WebFrameViewPrivate.h: Add the inNextValidKeyView flag.

12:23 PM Changeset in webkit [4064] by mjs

• 8 edits in trunk/WebKit

Reviewed by Darin.

Another launch time speedup - don't load the WebKit WebError
strings until we actually make a WebKit error. This prevents the
WebKit localized strings file from being loaded during normal startup.

• Downloads.subproj/WebDownload.m: (+[WebDownloadPrivate initialize]): Don't register WebKit errors. (-[WebDownload _errorWithCode:]): Use _webKitErrorWithCode:failingURL:
• Misc.subproj/WebKitErrors.m: (+[WebError _webKitErrorWithCode:failingURL:]): Wrapper that registers the WebKit error codes first.
• Misc.subproj/WebKitErrorsPrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): Use _webKitErrorWithCode:failingURL: (-[WebFrame _loadItem:withLoadType:]): Use _webKitErrorWithCode:failingURL:
• WebView.subproj/WebFrameView.m:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]): Use _webKitErrorWithCode:failingURL:

11:48 AM Changeset in webkit [4063] by mjs

• 3 edits in trunk/WebCore

Reviewed by Darin and Ken.

• fixed 3223127 - REGRESSION: windows for PopCap games show scroll bars now, did not in Safari-60

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Re-add scrollbars property, but change it to default to on even when other properties are specified (unlike other window properties). This seems to match what Mac IE, Win IE and Windows Mozilla do.

11:06 AM Changeset in webkit [4062] by cblu

• 2 edits in trunk/WebKit

Fixed: 3222896 - REGRESSION: sound plays after closing a window with a RealPlayer plug-in in it

Reviewed by darin.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewDidMoveToHostWindow]): We were starting plug-in on window close because that's when the host window is set to nil. Just check if we now have a host window before we start.

9:56 AM Changeset in webkit [4061] by darin

• 4 edits in trunk/WebCore

Reviewed by Trey.

• speed up startup by not loading the hand cursor until it's used

• khtml/khtml_part.cpp: (KHTMLPart::urlCursor): Use the hand cursor.
• khtml/khtmlpart_p.h: Don't store the hand cursor in a per-part global.

9:54 AM Changeset in webkit [4060] by darin

• 4 edits in trunk/WebKit

Reviewed by Trey.

• speed up startup by not calling [NSImage imageFileTypes] until we need to

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameRequiredForMIMEType:]): Call _viewClassForMIMEType instead of _viewTypes, since _viewClassForMIMEType is now optimized by not loading the image types unless needed.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _representationClass]): Call _representationClassForMIMEType instead of _repTypes, since _representationClassForMIMEType is now optimized by not loading the image types unless needed. (+[WebDataSource _repTypesAllowImageTypeOmission:]): Added. Moved the guts of _repTypes in here. If you pass YES, doesn't bother adding the image types yet. (+[WebDataSource _repTypes]): Now calls _repTypesAllowImageTypeOmission:NO. (+[WebDataSource _representationClassForMIMEType:]): First try the dictionary without requiring the image types, then only in the case where we get nil, try with the image types.

• WebView.subproj/WebFrameViewPrivate.m: (-[WebFrameView _makeDocumentViewForDataSource:]): Call _viewClassForMIMEType instead of _viewTypes, since _viewClassForMIMEType is now optimized by not loading the image types unless needed. (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Added. Moved the guts of _viewTypes in here. If you pass YES, doesn't bother adding the image types yet. (+[WebFrameView _viewTypes]): Now calls _viewTypesAllowImageTypeOmission:NO. (+[WebFrameView _viewClassForMIMEType:]): First try the dictionary without requiring the image types, then only in the case where we get nil, try with the image types.

9:52 AM Changeset in webkit [4059] by darin

• 5 edits
  1 add in trunk/WebCore

Reviewed by Maciej.

• fixed 3224077 -- REGRESSION: tables on MacNN forums messed up because we reject %% due to style parser

• khtml/css/tokenizer.flex: Add a + sign after the % in the percentage rule so we allow any number of extra percent signs. This is a temporary hack.

• khtml/css/Makefile.am: Add make rules to build tokenizer.cpp so we don't have to do it by hand.
• khtml/css/maketokenizer: Added. Script used by the make rules.
• khtml/css/tokenizer.cpp: Regenerated. The only substantive change is in the state tables.

12:14 AM Changeset in webkit [4058] by trey

• 5 edits in trunk/WebKit

3223413 - crash in [CompletionController controlTextDidChange] at travelocity.com

This was a great one to get steps for repro - it has shown up at least twice before.

The problem is that when there is a focused TextField within a frame, the proper
FormDelegate messages were not being sent on refresh or b/f. The cause was that
the FirstResponder would be reset in the middle of detaching the frame, at which point
our object graph was already half taken apart. Fix is to detect that case before
doing the detach work, and endEditing explicitly.

Reviewed by Darin.

• ChangeLog:
• Misc.subproj/WebKitLogging.h:
• Misc.subproj/WebKitLogging.m: New FormDelegate logging category.
• WebCoreSupport.subproj/WebBridge.m: All changes in here are just calling LOG for the new category. (-[WebBridge controlTextDidBeginEditing:]): (-[WebBridge controlTextDidEndEditing:]): (-[WebBridge controlTextDidChange:]): (-[WebBridge control:textShouldBeginEditing:]): (-[WebBridge control:textShouldEndEditing:]): (-[WebBridge control:didFailToFormatString:errorDescription:]): (-[WebBridge control:didFailToValidatePartialString:errorDescription:]): (-[WebBridge control:isValidObject:]): (-[WebBridge control:textView:doCommandBySelector:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _setDataSource:]): The fix, as described above.

Apr 9, 2003:

7:12 PM Changeset in webkit [4057] by rjw

• 4 edits in trunk/WebKit

Fix for 3222904. This change fixes the immediate symptoms of the bug,
but we need to come back to this issue after beta 2. Bug 3223929 captures
the other problems.

Reviewed by gramps.

• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource __setRequest:]): (-[WebDataSource _setRequest:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldReloadForCurrent:andDestination:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):

6:48 PM Changeset in webkit [4056] by hyatt

• 4 edits in trunk/WebCore

This first fix is a refinement of the patch I produced to fix <nobr>
on cnn.com recently. It wasn't quite good enough to plug the
regression on other sites. This fix just checks the object
we're currently breaking on (which is what I meant to do) and
not the last object examined (which will always just be the
previous object you looked at).

The code currently in the tree would work if you had two objects
like this:

[Normal Whitespace] [Nowrap Whitespace]

but not if you had three:

[Normal][Nowrap][Nowrap]

Since when you looked at the third object, |last| would be the
previous nowrap object and not the normal object. The line break
properly stays at the normal object as long as nowrap objects are
encountered, so this patch basically does what the original was
intended to do.

This fixes the line break problems on 1800flowers.com, a line break
problem on the bugzilla.mozilla.org layout test, a problem
on the zdnet layout test, and 3207196 a regression on livejournal.

The second fix in this patch is a simple reversal of
containsOnlyWhitespace. The method on RenderText was
backwards! No logical changes have been made... I just inverted
all the callers, and then I patched the method.

The third fix is to make images check for == normal instead of != nowrap
in a few places, thus preventing incorrect line break points from being
set up.

Reviewed by gramps

• khtml/rendering/bidi.cpp:
• khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth): (RenderText::containsOnlyWhitespace):

5:46 PM Changeset in webkit [4055] by mjs

• 3 edits in trunk/WebKit

Reviewed by Chris, Trey, Darin and Don.

• fixed 3223568 - site icons lost when moving from older Safari to 71

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): Rename old database containing directory to new, so we carry over old databases. The format is forward but not backward compatible. (-[WebIconDatabase _loadIconDictionaries]): Treat no version at all as version 1, so we can load old-style databases.

Reviewed by Trey.

• English.lproj/StringsNotToBeLocalized.txt: Updated.

4:19 PM Changeset in webkit [4054] by darin

• 4 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3223414 -- update text encoding menu and encoding names table

Made changes as suggested by Deborah Goldsmith and Peter Edberg from the International group.

• kwq/mac-encodings.txt: Moved all Korean character sets that are not explicitly Macintosh from MacKorean to EUC_KR. Moved Shift JIS character sets that are not explicitly Microsoft from DOSJapanese to ShiftJIS_X0213_00. Moved cp949 from DOSKorean to EUC_KR (DOSKorean is not implemented in Jaguar). Moved big5 character sets that are not explicitly Microsoft from DOSChineseTrad to Big5_HKSCS_1999. Moved all gb2312-80 character sets from GB_2312_80 to GB_18030_2000. Moved all gbk character sets from GBK_95 to GB_18030_2000. Moved all euc-cn character sets from EUC_CN to GB_18030_2000.

• kwq/KWQCharsetData.c: Regenerated.

1:05 PM Changeset in webkit [4053] by darin

• 4 edits in trunk/WebCore

Reviewed by Richard.

• fixed 3223126 -- REGRESSION: exception BrowserWindow isDescendantOf:]: selector not recognized

• kwq/KWQWidget.mm: (QWidget::hasFocus): Add missing check of the class of the first responder before calling an NSView method on it.

12:02 PM Changeset in webkit [4052] by darin

• 3 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3222708 -- REGRESSION: repro crash trying to read news at nttdocomo

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Make window.open do its location change with scheduleRedirection like all the other JavaScript calls that change location.

11:01 AM Changeset in webkit [4051] by cblu

• 2 edits in trunk/WebKit

Fixed: 3223022 - Plug-in content bleeds onto frontmost tab

Reviewed by darin.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewDidMoveToWindow]): Explicitly call setWindow when the plug-in view is moved out of the window so it is clipped out of sight.

Apr 8, 2003:

4:39 PM Changeset in webkit [4050] by trey

• 2 edits in trunk/WebKit

3221355 document is numb to clicks after going back

The layoutTimer now does a layout if the doc is in state Completed,
in addition to LayoutAcceptable.

Reviewed by Richard.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _timedLayout:]):

4:29 PM Changeset in webkit [4049] by darin

• 4 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3221400 -- REGRESSION: password field with onfocus handler that does select causes focus/typing trouble

• kwq/KWQTextField.mm: (-[KWQTextField selectText:]): Rearrange slightly. (-[KWQTextField becomeFirstResponder]): Add code to make the secure field first responder when in password mode. The old code did this indirectly through the call to setDocumentFocus, which caused minor trouble. (-[KWQSecureTextField selectText:]): Correct the current editor check to use a technique that works even for the secure text field's editor (which does not get returned by currentEditor).

• kwq/KWQWidget.mm: (QWidget::hasFocus): Update the logic here so it works for the secure text field and the secure text field's editor.

3:59 PM Changeset in webkit [4048] by hyatt

• 3 edits in trunk/WebCore

Fix for 3166374. Making the nudie blog work. My loop for
removing floating objects when they got deleted wasn't catching
all the cases.

Reviewed by darin

• khtml/rendering/render_object.cpp: (RenderObject::removeFromObjectLists):

2:39 PM Changeset in webkit [4047] by cblu

• 6 edits in trunk/WebKit

Fixed: 3221128 - Double grey lines on macromedia.com home page

Flash relies on the ordering of attributes in the EMBED tag (which is really stupid). salign must come after scale.
Changed our plug-in API's to preserve orderings using arrays rather than lose orderings when using dictionaries.

Reviewed by trey.

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m:
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:]): take attributeKeys and attributeValues instead of a dictionary
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): create attributeKeys and attributeValues to pass to the above method (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): create attributeKeys and attributeValues to pass to the above method

2:10 PM Changeset in webkit [4046] by sheridan

• 3 edits in trunk

72u versionstamp

12:15 PM Changeset in webkit [4045] by cblu

• 4 edits in trunk/WebKit

Fixed: 3220463 - REGRESSION: PDF viewer plug-in does not display (worked in 69 and previous)

Reviewed by darin.

• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView didStart]): always call redeliverStream. Have WebNetscapePluginRepresentation determine if it actually needs to do that.
• Plugins.subproj/WebNetscapePluginRepresentation.h:
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): keep track of _dataLengthReceived which is independent of the data received by the data source (-[WebNetscapePluginRepresentation redeliverStream]): only redeliver the stream if _dataLengthReceived is greater than 0

12:04 PM Changeset in webkit [4044] by hyatt

• 4 edits in trunk/WebCore

Fix for 3220979. Regression caused by changes to the CSS
parser's error handling. Fix is to narrow my original patch
to handle a specific subtype of error for properties.

Reviewed by darin

• khtml/css/parser.cpp:
• khtml/css/parser.y:

10:23 AM Changeset in webkit [4043] by rjw

• 3 edits in trunk/WebCore

Fixed 3221353. Added check for nil part.

Reviewed by Darin.

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::detach):

Apr 7, 2003:

10:41 PM Changeset in webkit [4042] by cblu

• 2 edits in trunk/WebKit

Fixed: 3206018 - REGRESSION: Clicks on the BBC news ticker applet don't open story in new window

MSIE and Netscape for Windows treat a nil target as _top. Since this is usually the target audience of applet developers, we will mimic this. This makes 3206018 behave as expected.

Reviewed by gramps.

• Plugins.subproj/WebPluginController.m: (-[WebPluginController showURL:inFrame:]): treat nil as _top.

8:49 PM Changeset in webkit [4041] by rjw

• 3 edits in trunk/WebKit

API conveniences for IB.

Reviewed by Maciej.

• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m: (-[WebView canGoBack]): (-[WebView canGoForward]): (-[WebView reload:]): (-[WebView canMakeTextSmaller]): (-[WebView canMakeTextLarger]): (-[WebView makeTextSmaller:]): (-[WebView makeTextLarger:]):

8:36 PM Changeset in webkit [4040] by rjw

• 11 edits in trunk

WebCore:

Fix for 3220988. Cancel frame load if it's detached before
finished loading.

Reviewed by Maciej.

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::detach):
• khtml/khtml_part.h:
• kwq/KWQKHTMLPart.mm: (KHTMLPart::frameDetached):
• kwq/WebCoreBridge.h:

WebKit:

Fix for 3220988. Cancel frame load if it's detached before
finished loading.

Reviewed by Maciej.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge frameDetached]):
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _removeChild:]):

6:59 PM Changeset in webkit [4039] by hyatt

• 3 edits in trunk/WebCore

Fix for 3220395. nearestFloatBottom() mistakenly returned 0
when it ran out of floats to return.

Reviewed by gramps

• khtml/rendering/render_block.cpp:

6:36 PM Changeset in webkit [4038] by mjs

• 2 edits in trunk/WebKit

Reviewed by Richard.

• fixed 3219584 - REGRESSION: launch times appear slower in v71

• WebView.subproj/WebView.m: (+[WebView canShowMIMEType:]): Avoid loading plugin database if we can find a view without doing so.

5:36 PM Changeset in webkit [4037] by hyatt

• 5 edits in trunk/WebCore

Fix for the scrollbar problem in 3220395. Does not yet fix
the overlap problem. lowest/rightmostPosition got broken by
the RenderFlow split. This patch makes sure that we still crawl
into inlines with overhangingContents.

Reviewed by darin

• khtml/rendering/render_block.cpp:
• khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition):
• khtml/rendering/render_flow.h:

5:24 PM Changeset in webkit [4036] by sheridan

• 3 edits in branches/Safari-69~1-branch

actually I meant something slightly different ...

5:13 PM Changeset in webkit [4035] by sheridan

• 5 edits in branches/Safari-69~1-branch

fixing versions for panther vs alexander build train submission

3:31 PM Changeset in webkit [4034] by hyatt

• 3 edits in trunk/WebCore

• khtml/html/htmlparser.cpp: (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks):

This is a patch to the parser to prevent residual
style from creating illegal constructs according to the DTD.
For now, it will just bail on performing the fixup if an
illegal construct would be created.

This fixes the regression #3219944.

Reviewed by darin

2:43 PM Changeset in webkit [4033] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave.

• fixed 3220490 -- REGRESSION: MALLORY horiz scrollbar incorrectly appears with abs positioned content

• khtml/rendering/render_block.cpp: (RenderBlock::rightmostPosition): Fix a place where I had xPos instead of yPos.

9:55 AM Changeset in webkit [4032] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebUserAgentSpoofTable.c: Regenerated. When I landed my last change to the .gperf file I forgot to land this.