Timeline



Apr 16, 2003:

3:26 PM Changeset in webkit [4127]
  • 6 copies in tags/Safari-73~2

This commit was manufactured by cvs2svn to create tag 'Safari-73~2'.

3:26 PM Changeset in webkit [4126] by darin
  • 2 edits in branches/Safari-73~1-branch/WebKit

WebFoundation:

Rolled in change from trunk.

2003-04-16 Ken Kocienda <​kocienda@apple.com>

Reviewed by Darin

Fixed synchronous loading API. When deciding on the new API,
we made a bonehead play which removed the ability to access
the error object associated with the load. Fixed.

  • CacheLoader.subproj/NSURLConnection.h:
  • CacheLoader.subproj/NSURLConnection.m:
  • CacheLoader.subproj/WebSynchronousDelegate.h:
  • CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate error]):

WebKit:

Rolled in change from trunk.

2003-04-16 Ken Kocienda <​kocienda@apple.com>

Reviewed by Darin

Fixed call to load synchronous URL. Now conforms to new API
which allows callers to access error object associated with
the load.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]):
3:08 PM Changeset in webkit [4125] by kocienda
  • 2 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Fixed synchronous loading API. When deciding on the new API,
we made a bonehead play which removed the ability to access
the error object associated with the load. Fixed.

  • CacheLoader.subproj/NSURLConnection.h:
  • CacheLoader.subproj/NSURLConnection.m:
  • CacheLoader.subproj/WebSynchronousDelegate.h:
  • CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate error]):

WebKit:

Reviewed by Darin

Fixed call to load synchronous URL. Now conforms to new API
which allows callers to access error object associated with
the load.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]):
1:38 PM Changeset in webkit [4124] by cblu
  • 3 edits in trunk/WebKit
  • Progressively load plain text in our text view.
  • Fixed: 3177603 - vCards appear in browser, not downloaded

Reviewed by darin.

  • WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation setDataSource:]): added FIXME about document source of RTF not working (-[WebTextRepresentation receivedData:withDataSource:]): feed data to the text view, progressively for plain text
  • WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): include text/directory, another vcard MIME type (-[WebTextView setDataSource:]): do 1-time attribute settings (-[WebTextView dataSourceUpdated:]): do nothing
1:34 PM Changeset in webkit [4123] by kocienda
  • 2 edits in trunk/WebKit

WebFoundation:

Reviewed by David

Added API-approved NSURLCacheStoragePolicy enum.

Removed NSURLProtocolClient.h file. Rolled protocol
declaration in NSURLProtocol.h

Moved all NSURLProtocolClient implementors to API-approved
interface.

Did some code reorganization with regard to cached response
management in NSURLConnection implementation and its interaction
with NSURLProtocol. This is a partial step towards implementing
the final API.

Moved some more cacheObject usages in the program text to
use cachedResponse instead.

Added a number of API FIXME markers to indicate places where
more work needs to be done to complete the API transition.

  • CacheLoader.subproj/NSURLCache.h:
  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection cachedResponse]): (-[NSURLConnection setCacheObject:]): (-[NSURLConnection _chooseCachedResponse]): (-[NSURLConnection _beginLoad]): (-[NSURLConnection _scheduleOriginLoad]): (-[NSURLConnection _prepareOriginLoad]): (-[NSURLConnection _beginOriginLoad]): (-[NSURLConnection _performTimeOut]): (-[NSURLConnection _wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnection _didReceiveResponse:cacheStoragePolicy:]): (-[NSURLConnection _didLoadData:]): (-[NSURLConnection _invalidateCacheObject]): (-[NSURLConnection _didFinishLoading]): (-[NSURLConnection _didFailWithError:]): (-[NSURLConnectionInternal dealloc]): (-[NSURLConnectionInternal cachedResponse]): (-[NSURLConnectionInternal URLProtocol:wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnectionInternal URLProtocol:cachedResponseIsValid:]): (-[NSURLConnectionInternal URLProtocol:didReceiveResponse:cacheStoragePolicy:]): (-[NSURLConnectionInternal URLProtocol:didLoadData:]): (-[NSURLConnectionInternal URLProtocolDidFinishLoading:]): (-[NSURLConnectionInternal URLProtocol:didFailWithError:]): (-[NSURLConnectionInternal _invalidateCacheObject]): (-[NSURLConnectionInternal _setWaitingForCallback:]):
  • CacheLoader.subproj/NSURLProtocol.h:
  • CacheLoader.subproj/NSURLProtocol.m: (-[NSURLProtocol initWithRequest:cachedResponse:client:]): (-[NSURLProtocol client]): (-[NSURLProtocol startLoading]): (-[NSURLProtocol _invalidateCacheObject]):
  • CacheLoader.subproj/NSURLProtocolPrivate.h:
  • ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoading]):
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]): (-[WebCFNetworkHTTPProtocol startLoading]): (-[WebCFNetworkHTTPProtocol retryAfterAuthenticationFailure:]): (-[WebCFNetworkHTTPProtocol retryAfterConnectingToInternet]): (-[WebCFNetworkHTTPProtocol continueAfterEndEncountered]): (-[WebCFNetworkHTTPProtocol continueHeaderReadAfter3xxResponseAndCall:]): (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]): (-[WebCFNetworkHTTPProtocol performStreamRead:]): (-[WebCFNetworkHTTPProtocol didAddCredentials:toRequest:context:]):
  • ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]): (-[WebFTPProtocol startLoading]): (-[WebFTPProtocol determineErrorAndFail]): (-[WebFTPProtocol didLoadData:]): (-[WebFTPProtocol handleHasBytesAvailable]): (-[WebFTPProtocol _checkDirectoryListing]): (-[WebFTPProtocol handleEndEncountered]): (-[WebFTPProtocol handleReadStreamEvent:event:]):
  • ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]): (-[WebFileProtocol startLoading]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol startLoading]): (-[WebHTTPProtocol sendResponseAvailableCallback]): (-[WebHTTPProtocol failWithError:]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol startLoading]): (-[WebSimpleHTTPProtocol _extractResponseStatusLineFromBytes:length:]): (-[WebSimpleHTTPProtocol _processHTTPResultCode]): (-[WebSimpleHTTPProtocol _forwardToCFNetwork]): (-[WebSimpleHTTPProtocol _handleLoadCallback]):
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by David

Moved this NSURLProtocolClient implementor to API-approved
interface.

  • WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):
11:20 AM Changeset in webkit [4122] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

Fix deployment build breaker caused by uninitialized variable.

  • WebView.subproj/WebViewPrivate.m: (-[WebView _loadBackForwardListFromOtherView:]):
10:21 AM Changeset in webkit [4121] by darin
  • 6 edits in trunk/WebKit

Reviewed by John.

  • fixed 3226281 -- REGRESSION: crash in WebHTMLView removeMouseMovedObserver closing gist.com
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]): Use _webView instead of _controller.
  • WebCoreSupport.subproj/WebTextRendererFactory.m: Remove stray semicolon.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView removeMouseMovedObserver]): Use _webView instead of _controller. (-[WebHTMLView menuForEvent:]): Ditto. (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
  • WebView.subproj/WebHTMLViewPrivate.h: Rename _controller to _webView.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _webView]): Use _web_superviewOfClass to find the WebView. This dodges possible stale unretained pointer issues with getting the WebView through the WebFrame, which is what fixes the bug. (-[WebHTMLView _updateMouseoverWithEvent:]): Use _webView instead of _controller. (+[WebHTMLView _pasteboardTypes]): Put the types in order from most preferred to least. (-[WebHTMLView _writeSelectionToPasteboard:]): Ditto.

Apr 15, 2003:

7:18 PM Changeset in webkit [4120] by rjw
  • 2 edits in trunk/WebKit

Create the dictionary for volatile values. Without this fix
values were never volatile!

Reviewed by mjs.

  • WebView.subproj/WebPreferences.m: (-[WebPreferences _init]): (-[WebPreferences init]): (+[WebPreferences standardPreferences]): (-[WebPreferences dealloc]):
7:02 PM Changeset in webkit [4119] by rjw
  • 2 edits in trunk/WebKit

Fix for 3226746. Remove some ancient and apparantly invalid cruft.

Reviewed by trey.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setDataSource:]):
5:47 PM Changeset in webkit [4118] by hyatt
  • 3 edits in trunk/WebCore

Missed a piece of the renaming on lowestPosition/rightmostPosition.
This was already reviewed by darin. Just missed landing one file.

Reviewed by darin

  • khtml/rendering/render_box.cpp: (RenderBox::lowestPosition): (RenderBox::rightmostPosition):
5:38 PM Changeset in webkit [4117] by rjw
  • 2 edits in trunk/WebKit

Fixed clipping of progressive images to correctly clip.

Reviewed by darin.

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):
5:28 PM Changeset in webkit [4116] by trey
  • 3 edits in trunk/WebCore

3210061 - Forms auto-fill ignores maxlength attribute

Reviewed by Maciej.

  • kwq/KWQTextField.mm: (-[KWQTextField setStringValue:]): We now trim down incoming values to fit the maxlength criteria. Matches the way we enforce this constraint when maxlength is set.
5:09 PM Changeset in webkit [4115] by hyatt
  • 1 edit in trunk/WebCore/khtml/css/parser.y

* empty log message *

5:04 PM Changeset in webkit [4114] by hyatt
  • 3 edits in trunk/WebCore

Fix 3227983 and 3229592, both the same bug involving a movable type
template:

letter-spacing: .none;

Fix is to make error-handling of exprs more generic.

Reviewed by darin

  • khtml/css/parser.y:
4:45 PM Changeset in webkit [4113] by darin
  • 8 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3056913 -- please add Japanese auto-detect
  • khtml/misc/decoder.cpp: (Decoder::decode): Turn on the auto-detect code if the default encoding is one of the Japanese encodings. Also change things around so the auto-detection process doesn't clobber the old chosen encoding if it does not yield a result.
  • kwq/KWQCharsets.h: Add a new IsJapanese encoding flag.
  • kwq/KWQTextCodec.h: Add a new isJapanese() member function, used by the above.
  • kwq/mac-encodings.txt: Add the IsJapanese flag to all Japanese encodings, and add "jis7" as a synonym for ISO-2022-JP.
  • kwq/make-charset-table.pl: Changed to allow flags even for unused encodings.
  • kwq/KWQCharsetData.c: Regenerated.
4:29 PM Changeset in webkit [4112] by hyatt
  • 14 edits in trunk/WebCore

Fix for 3220809, overflow values other than visible should not
affect the document's height (or document scrollbars). This
fixes squidfingers.com and briefcase.yahoo.com

Also laying a bunch of groundwork for overflow:auto and scroll
by adding them as supported values now.

Fixed overflow so that overflow objects now dodge floats and
don't let them intrude into their space.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth): (RenderBox::repaint): (RenderBox::repaintRectangle): (RenderBox::calcWidth): (RenderBox::calcAbsoluteVertical): (RenderBox::lowestPosition): (RenderBox::rightmostPosition):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::repaint): (RenderFlow::lowestPosition): (RenderFlow::rightmostPosition):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition): (RenderLayer::convertToLayerCoords): (RenderLayer::scrollOffset):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.cpp: (RenderObject::setLayouted): (RenderObject::detach):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.h:
3:54 PM Changeset in webkit [4111] by trey
  • 3 edits in trunk/WebCore

3229318 - no back entry created when searching at lonelyplanet.com

Reviewed by Darin.

  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::wasRunByUserGesture): Treat blur/focus events as being user gestures, since they probably were caused by something the user did. This cues us to not lock history for navigations that are spawned by these events.
2:25 PM Changeset in webkit [4110] by kocienda
  • 2 edits in trunk/WebKit

Tools:

Reviewed by Darin

Name change from WebCacheObject to NSCachedURLResponse.
No functional changes.

  • DiskCachePeek/main.m:
  • WebDiskCacheInspector/Controller.h:
  • WebDiskCacheInspector/Controller.m: (-[Controller cacheObjectForPath:]): (-[Controller setFilesArrayUsingSearchString:]): (-[Controller tableView:objectValueForTableColumn:row:]): (-[Controller setCacheObject:]):

WebFoundation:

Reviewed by Darin

Name change from WebCacheObject to NSCachedURLResponse.
No functional changes.

  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection cacheObject]): (-[NSURLConnection setCacheObject:]): (-[NSURLConnection _beginLoad]): (-[NSURLConnection _finishedLoading]): (-[NSURLConnectionInternal cacheObject]):
  • CacheLoader.subproj/NSURLProtocol.h:
  • CacheLoader.subproj/NSURLProtocol.m: (-[NSURLProtocol cacheObject]): (-[NSURLProtocol setCacheObject:]): (-[NSURLProtocol startLoadingWithCacheObject:]): (-[NSURLProtocol stateForCacheObject:]): (-[NSURLProtocol canStoreCacheObject:]):
  • CacheLoader.subproj/WebCache.h:
  • CacheLoader.subproj/WebCache.m: (-[WebCache cacheObjectForKey:]): (-[WebCache storeCacheObject:forKey:]):
  • CacheLoader.subproj/WebCacheManager.h:
  • CacheLoader.subproj/WebCacheManager.m: (-[WebCacheManager cacheObjectForKey:]): (-[WebCacheManager storeCacheObject:forKey:]):
  • CacheLoader.subproj/WebCacheObjectPrivate.h:
  • CacheLoader.subproj/WebDiskCache.m: (-[WebDiskCache cacheObjectForKey:]): (-[WebDiskCache storeCacheObject:forKey:]): (-[WebDiskCache removeCacheObjectForKey:]):
  • CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCacheLRUListNode initWithCacheObject:forKey:]): (-[WebMemoryCache cacheObjectForKey:]): (-[WebMemoryCache storeCacheObject:forKey:]):
  • Misc.subproj/WebFoundation.h:
  • ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoadingWithCacheObject:]):
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addConditionalFieldsToHeader]): (-[WebCFNetworkHTTPProtocol startLoadingWithCacheObject:]): (-[WebCFNetworkHTTPProtocol continueHeaderReadAfter3xxResponseAndCall:]):
  • ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol startLoadingWithCacheObject:]):
  • ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol startLoadingWithCacheObject:]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol startLoadingWithCacheObject:]): (-[WebHTTPProtocol canStoreCacheObject:]): (-[WebHTTPProtocol stateForCacheObject:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol startLoadingWithCacheObject:]): (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _processHTTPResultCode]):
  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Name change from WebCacheObject to NSCachedURLResponse.
No functional changes.

  • WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoadingWithCacheObject:]):
1:44 PM Changeset in webkit [4109] by trey
  • 3 edits in trunk/WebKit

WebKit:

3227514 Open window in "Same Page" should copy entire back/forward list

New support to load a new view by copying the whole backforward
list and driving the new view to the current item.

Reviewed by John.

  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _loadItem:]): Old routine, which only loaded an item. (-[WebView _loadItemsFromOtherView:]): New routine that does the works.

WebBrowser:

3227514 Open window in "Same Page" should copy entire back/forward list

Just call new method in WebKit.

Reviewed by John.

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument loadCloneOfView:]): Renamed goToHistoryItem:inView:.
  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Call above method instead of old one.
11:25 AM Changeset in webkit [4108] by hyatt
  • 5 edits in trunk/WebCore

A collection of fixes.

(1) Don't lay out positioned elements so early in
layoutInlineChildren. They need to get a layout only after
all the normal flow kids have gotten a layout (and this happens
already in layoutPositionedObjects).

(2) Fix a mistake with overflow:hidden. I was applying the
overflow-clip for positioned elements only if you had defined
clip using the clip property. This makes iht.com look better
(although it still misrenders pretty badly due to some JS error
we hit in the source).

(3) Patch RenderText's height method to give more accurate
information. This affects all the layout tests. :)

Reviewed by darin

  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
  • khtml/rendering/render_text.cpp: (RenderText::height):
11:13 AM Changeset in webkit [4107] by kocienda
  • 2 edits in trunk/WebKit

WebFoundation:

Reviewed by John

Name change from WebProtocolClient to NSURLProtocolClient.
No functional changes.

  • CacheLoader.subproj/NSURLConnection.m:
  • CacheLoader.subproj/NSURLProtocol.h:
  • CacheLoader.subproj/NSURLProtocol.m: (-[NSURLProtocol initWithProtocolClient:request:]): (-[NSURLProtocol client]):
  • ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoadingWithCacheObject:]):
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol initWithProtocolClient:request:]): (-[WebCFNetworkHTTPProtocol continueHeaderReadAfter3xxResponseAndCall:]): (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]): (-[WebCFNetworkHTTPProtocol performStreamRead:]):
  • ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol initWithProtocolClient:request:]): (-[WebFTPProtocol startLoadingWithCacheObject:]): (-[WebFTPProtocol _checkDirectoryListing]): (-[WebFTPProtocol handleEndEncountered]): (-[WebFTPProtocol handleReadStreamEvent:event:]):
  • ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]): (-[WebFileProtocol startLoadingWithCacheObject:]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol initWithProtocolClient:request:]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol initWithProtocolClient:request:]): (-[WebSimpleHTTPProtocol _processHTTPResultCode]): (-[WebSimpleHTTPProtocol _forwardToCFNetwork]): (-[WebSimpleHTTPProtocol _handleLoadCallback]):
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by John

Name change from WebProtocolClient to NSURLProtocolClient.
No functional changes.

  • WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoadingWithCacheObject:]):
10:39 AM Changeset in webkit [4106] by kocienda
  • 4 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Name change from WebProtocol to NSURLProtocol.
No functional changes.

  • CacheLoader.subproj/NSURLConnection.m: (+[NSURLConnection canHandleRequest:]): (-[NSURLConnection _beginLoad]): (-[NSURLConnection protocol]):
  • CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest _parametersForReading]): (-[NSMutableURLRequest _parametersForWriting]):
  • CacheLoader.subproj/NSURLResponse.m:
  • CacheLoader.subproj/WebCacheManager.m:
  • CacheLoader.subproj/WebProtocolClient.h:
  • Misc.subproj/WebFoundation.h:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_canonicalize]):
  • ProtocolHandlers.subproj/WebAboutProtocol.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m:
  • ProtocolHandlers.subproj/WebFTPProtocol.h:
  • ProtocolHandlers.subproj/WebFTPProtocol.m:
  • ProtocolHandlers.subproj/WebFileProtocol.h:
  • ProtocolHandlers.subproj/WebHTTPProtocol.h:
  • ProtocolHandlers.subproj/WebHTTPProtocol.m:
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m:
  • WebFoundation.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Name change from WebProtocol to NSURLProtocol.
No functional changes.

  • WebView.subproj/WebDataProtocol.h:
  • WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestParametersForReading]): (-[NSURLRequest _webDataRequestParametersForWriting]): (+[WebDataProtocol load]):
  • WebView.subproj/WebFrame.m:

WebBrowser:

Reviewed by Darin

Name change from WebProtocol to NSURLProtocol.
No functional changes.

  • Debug/DebugUtilities.m: (initProtocolHandlers): (-[BrowserDocument unregisterAllProtocolHandlers]): (-[BrowserDocument reregisterAllProtocolHandlers]): (-[BrowserDocument toggleAboutProtocolHandler:]): (-[BrowserDocument toggleFileProtocolHandler:]): (-[BrowserDocument toggleCFNetworkHTTPProtocolHandler:]): (-[BrowserDocument toggleSimpleHTTPProtocolHandler:]):
10:25 AM Changeset in webkit [4105] by trey
  • 19 edits in trunk

WebCore:

3009051 - Find on Page stops (once) at end of page, should wrap automatically WebKit
3051546 - Find on Page doesn't work for frameset pages
3058437 - can have a selection in two frames at the same time (problem for finding in frames)
3097498 - Find Previous continues to "Find Next" until end of paragraph
3097507 - Find Next searches from previous find hit instead of current selection

And a commented out fix for:

3121828 - scrollToVisible on find cuts off the left part of the view due to needless horiz. scroll

Various missing pieces are implemented to support better finding. The fix for
3121828 is left out until 3228511 is dealt with.

Reviewed by Maciej.

  • WebCore.pbproj/project.pbxproj:
  • khtml/khtml_part.cpp: (KHTMLPart::findTextBegin): Added args to allow starting a find at an arbitrary places, such as the current selection. (KHTMLPart::findTextNext): Implement reverse search - only the param was there. Don't do lame scrolling selection to visible here, do better ourselves later.
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::jumpToSelection): Make whole selection rect visible, and only scroll anything if needed. *Commented out in lieu of 3228511. (KWQKHTMLPart::findString): Implement find starting at the right place relative to the selection, forwards and backwards, and wraparound. This is just setup around calling findTextNext. Also scroll the result to be visible.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge deselectAll]): Call part instead of doc so its state isn't out of sync. (-[WebCoreBridge searchFor:direction:caseSensitive:wrap:]): Pass extra wrap arg.
  • kwq/WebCoreDOMNode.mm: (+[WebCoreDOMNode nodeWithImpl:DOM::]): Return a nil for a null element instead of croaking. (-[WebCoreDOMNode initWithImpl:DOM::]): Ditto.

WebKit:

3009051 - Find on Page stops (once) at end of page, should wrap automatically WebKit
3051546 - Find on Page doesn't work for frameset pages
3058437 - can have a selection in two frames at the same time (problem for finding in frames)
3097498 - Find Previous continues to "Find Next" until end of paragraph
3097507 - Find Next searches from previous find hit instead of current selection
Primary changes here: I added a wrap flag to the searchFor method, which is needed to
control how we search as we traverse the frame tree. A new method is added to WebView
that knows about traversing the frame tree as we search. HTMLView and TextView both
clear their selections when they lose first responder (see 3228554 for possible
improvements to that change).

Reviewed by Maciej.

  • Misc.subproj/WebSearchableTextView.m: Added wrap flag, pass on to TextView. Ensure we do some searching when we would previous get a zero range to search in.
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: These are all basic methods to support forwards and backwards traversal of the frame tree. Modeled after same methods we have for traversing the DOM. (-[WebFrame _nextSibling]): (-[WebFrame _previousSibling]): (-[WebFrame _lastChild]): (-[WebFrame _nextFrameWithWrap:]): (-[WebFrame _previousFrameWithWrap:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): Added wrap flag, pass it to bridge. (-[WebHTMLView resignFirstResponder]): Clear selection when we lose firstResp.
  • WebView.subproj/WebTextView.m: (-[WebTextView resignFirstResponder]): Clear selection when we lose firstResp.
  • WebView.subproj/WebView.m: (-[WebView _currentFrame]): Return the frame holding the first responder. (-[WebView _searchFor:direction:caseSensitive:wrap:]): Main work: traverse the frame tree and drive the overall find.
  • WebView.subproj/WebViewPrivate.h:

WebBrowser:

3009051 - Find on Page stops (once) at end of page, should wrap automatically WebKit
3051546 - Find on Page doesn't work for frameset pages
3058437 - can have a selection in two frames at the same time (problem for finding in frames)
3097498 - Find Previous continues to "Find Next" until end of paragraph
3097507 - Find Next searches from previous find hit instead of current selection

Primary change here is that we use a new WK method that is hip to searching across
frames. There is an open issue in 3228520 for getting that into the API.

Reviewed by Maciej.

  • BrowserWindowController.h:
  • BookmarksViewController.m: Added wrap: argument to searchFor:direction:caseSensitive: method.
  • FindPanelController.m: (-[FindPanelController _searchTarget]): Hacked to return a WebView if possible instead of always a WebDocumentSearching. (-[FindPanelController _doSearchForString:direction:caseSensitive:inTarget:]): New method that knows to call new WK method for searching across frames in the special case of us about to search within a WebView. (-[FindPanelController _findWithDirection:caseSensitive:]): Call above new method instead of going straight to the search target using the WebDocumentSearching method.

Apr 14, 2003:

10:31 PM Changeset in webkit [4104] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3214900 - iBench JavaScript test times get progressively slower with each test run

The fix is to make sure to always cast NodeImpl * to DocumentImpl
*. Multiple inheritance means the pointer values need not be the
same.

  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::getDOMObjectForDocument): (ScriptInterpreter::putDOMObjectForDocument): (ScriptInterpreter::deleteDOMObjectsForDocument): (ScriptInterpreter::forgetDOMObjectsForDocument):
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::getDOMNode):
3:43 PM Changeset in webkit [4103] by hyatt
  • 5 edits in trunk/WebCore

Reviewed by darin

  • ChangeLog:
  • khtml/css/cssstyleselector.cpp:
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseComment):
2:43 PM Changeset in webkit [4102] by cblu
  • 6 edits in trunk/WebKit

Log time spent loading each plug-in.

Reviewed by mjs.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconsForIconURLString:]): fixed logging code (-[WebIconDatabase _scaleIcon:toSize:]): fixed logging code
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): log time spent loading a plug-in
  • Plugins.subproj/WebPluginController.m: (-[WebPluginController startAllPlugins]): only log if there are plug-ins to start (-[WebPluginController stopAllPlugins]): only log if there are plug-ins to stop (-[WebPluginController destroyAllPlugins]): only log if there are plug-ins to destroy
1:46 PM Changeset in webkit [4101] by trey
  • 7 edits in trunk/WebKit

WebKit:

3150693 - open new window on "same page" doesn't give me the same frame content

The core is a new support method that loads a WebView given a HistoryItem, which
thus restores all frames of that item, and optionally the form and scroll state.

Reviewed by NOBODY (OOPS!).

  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem copyWithZone:]): Copy the docState, scrollPosition, isTargetItem. No good reason to have left these out when I wrote this method.
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _saveDocumentAndScrollState]): New method to run the frame tree and save all form/scroll state to the current item.
  • WebView.subproj/WebView.m: _goToItem:withLoadType: moved to WebViewPrivate.m
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _goToItem:withLoadType:]): Moved from WebView.m, no change. (-[WebView _loadItem:showingInView:]): New method to load the view with the item.

WebBrowser:

3150693 - open new window on "same page" doesn't give me the same frame content

The basic idea is that we try to call the new _loadItem:showingInView:
method with a history item instead of just loading a URL.

Reviewed by NOBODY (OOPS!).

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument goToHistoryItem:inView:]): Just pass through args to our current controller.
  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): If we can get a history item use that to do the load. Else use a URL like before.
11:48 AM Changeset in webkit [4100] by cblu
  • 3 edits in trunk/WebCore

Fixed build failure.

Reviewed by darin.

  • khtml/rendering/render_table.cpp: (RenderTable::cellAbove):
11:03 AM Changeset in webkit [4099] by cblu
  • 3 edits in trunk/WebKit

Fixed: 3162338 - Embedding SVG with <object type="image/svg+xml"> doesn't work

Reviewed by dave.

  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]): code moved from +[WebImageView supportedImageMIMETypes]
  • WebView.subproj/WebImageView.m: (+[WebImageView supportedImageMIMETypes]): return -[WebImageRendererFactory supportedMIMETypes]
11:01 AM Changeset in webkit [4098] by cblu
  • 6 edits in trunk/WebCore

Fixed: 3162338 - Embedding SVG with <object type="image/svg+xml"> doesn't work

Whenever we encounter an OBJECT tag with a type that starts with "image/" we create a render image object instead of a render part object. The behavior is nice because this allows the render object to resize to the size of the image if no WIDTH and HEIGHT are supplied. For example, the image at the bottom of this page:

​http://tantek.com/CSS/Examples/boxmodelhack.html

The problem is that we do this for image types that we can't handle and when there are plug-ins that *can* handle the types.

Reviewed by dave.

  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::rendererIsNeeded): call canRenderImageType instead of serviceType.startsWith (HTMLObjectElementImpl::createRenderer): call canRenderImageType instead of serviceType.startsWith (HTMLObjectElementImpl::attach): call canRenderImageType instead of serviceType.startsWith
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (canRenderImageType): new, checks if the MIME type is supported by the image factory
  • kwq/WebCoreImageRendererFactory.h: added supportedMIMETypes to the WebCoreImageRendererFactory protocol
7:14 AM Changeset in webkit [4097]
  • 2 copies
    2 deletes in tags/JavaScriptCore-73

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-73'.

7:14 AM Changeset in webkit [4096] by darin
  • 1 edit in branches/JavaScriptCore-73-tarball-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Update project file for tarball.

7:11 AM Changeset in webkit [4095]
  • 4 copies
    2 deletes in tags/WebCore-73

This commit was manufactured by cvs2svn to create tag 'WebCore-73'.

7:11 AM Changeset in webkit [4094] by darin
  • 1 edit in branches/WebCore-73-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

Update project for tarball release.

12:10 AM Changeset in webkit [4093] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Trey.

  • fixed 3165326 - javascript getSelection not implemented
  • khtml/ecma/kjs_window.cpp: (Window::get): (WindowFunc::tryCall):
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.lut.h:

Apr 13, 2003:

11:24 PM Changeset in webkit [4092] by mjs
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Trey.

  • WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate webView:setContentRect:]): Implemented in terms of webView:setFrame: to save clients work.

WebBrowser:

Reviewed by Trey.

  • fixed 3210715 - Window cannot resize smaller than 392px wide - mac.com Bookmarks
  • WindowController.m: (-[WindowController setFrameWithoutAutosaving:]): When setting size smaller than the current minimum, make it the new minimum. (-[WindowController webView:setContentRect:]): Removed.
10:18 PM Changeset in webkit [4091] by trey
  • 6 edits in trunk/WebCore

3219720 - autofill mapping confused by tables, worse than MacIE (at store.apple.com)

If in scanning backwards we get to the end of a table row, we take a diversion
and scan the cell that is above the cell we started at.
Big improvement for store.apple.com.

Reviewed by Maciej

  • khtml/rendering/render_table.cpp: (RenderTable::cellAbove): New support routine to find the cell above another
  • khtml/rendering/render_table.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsAboveCell): Get the cell above, scan its tree for matching text. (KWQKHTMLPart::searchForLabelsBeforeElement): Call above routine if we are working within a table
12:31 AM Changeset in webkit [4090]
  • 4 copies in branches/Safari-73~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-73~1-branch'.

12:31 AM Changeset in webkit [4089]
  • 4 copies in tags/Safari-73~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-73~1-anchor'.

12:31 AM Changeset in webkit [4088]
  • 4 copies in tags/Safari-73~1

This commit was manufactured by cvs2svn to create tag 'Safari-73~1'.

12:31 AM Changeset in webkit [4087] by mjs
  • 6 edits in trunk/JavaScriptCore

Reviewed by Don.

  • JavaScriptCore part of fix for 3158769 - JavaScript triggers not as async as they used to be

Added a way to get the current interpreter lock count, so Sherlock
can unlock the interpreter inside JS method implementations that
spend a long time waiting for I/O, allowing more efficient
multi-threaded operation.

  • kjs/internal.cpp: (lockInterpreter): (unlockInterpreter): (InterpreterImp::lock): (InterpreterImp::lockCount):
  • kjs/internal.h:
  • kjs/interpreter.cpp: (Interpreter::lockCount):
  • kjs/interpreter.h:

Apr 12, 2003:

3:18 PM Changeset in webkit [4086] by cblu
  • 3 edits in trunk/WebCore

Fixed: 3188070 - 6I32 EMBED tag with no SRC attribute doesn't load the plugin

Reviewed by dave.

  • khtml/khtml_part.cpp: (KHTMLPart::requestObject): allow URL-less parts
Note: See TracTimeline for information about the timeline view.