Timeline



Apr 21, 2003:

9:54 PM Changeset in webkit [4150] by darin
  • 2 edits in trunk/WebKit
  • Plugins.subproj/WebNetscapePluginStream.m: Removed unnecessary #import of <WebFoundation/WebFoundation.h>.
7:12 PM Changeset in webkit [4149] by mjs
  • 4 edits in trunk/WebKit

WebFoundation:

Reviewed by Richard.

Renamed headers and implementation files for new auth API.

  • AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
  • AuthenticationManager.subproj/NSURLAuthenticationChallenge.m:
  • AuthenticationManager.subproj/NSURLCredential.h:
  • AuthenticationManager.subproj/NSURLCredential.m:
  • AuthenticationManager.subproj/NSURLCredentialStorage.h:
  • AuthenticationManager.subproj/NSURLCredentialStorage.m:
  • AuthenticationManager.subproj/NSURLProtectionSpace.h:
  • AuthenticationManager.subproj/NSURLProtectionSpace.m:
  • AuthenticationManager.subproj/WebAuthenticatingResource.h: Removed.
  • AuthenticationManager.subproj/WebAuthenticatingResource.m: Removed.
  • AuthenticationManager.subproj/WebAuthenticationHandler.h:
  • AuthenticationManager.subproj/WebAuthenticationManager.h: Removed.
  • AuthenticationManager.subproj/WebAuthenticationManager.m: Removed.
  • AuthenticationManager.subproj/WebAuthenticationManagerCallback.h:
  • AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
  • AuthenticationManager.subproj/WebAuthenticationRequest.h: Removed.
  • AuthenticationManager.subproj/WebAuthenticationRequest.m: Removed.
  • AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
  • AuthenticationManager.subproj/WebAuthenticationResult.h: Removed.
  • AuthenticationManager.subproj/WebCredential.h: Removed.
  • AuthenticationManager.subproj/WebCredential.m: Removed.
  • AuthenticationManager.subproj/WebCredentialStorage.h:
  • AuthenticationManager.subproj/WebCredentialStorage.m:
  • AuthenticationManager.subproj/WebKeychainCredential.h:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Richard.

Updated for file renames.

  • Panels.subproj/WebAuthenticationPanel.h:
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Panels.subproj/WebStandardPanels.m:

WebBrowser:

Reviewed by Richard.

Updated for file renames.

  • AppController.m:
  • FormCompletionController.m:
  • Preferences.subproj/PasswordsEditor.m:
4:45 PM Changeset in webkit [4148] by darin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed bug 3159076 -- turbotax.intuit.com forms have text fields instead of radio buttons
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::setType): Implement; loosen rule about what type changes are allowed. (HTMLInputElementImpl::parseAttribute): Call setType for ATTR_TYPE.
  • unrelated tweak
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Use a macro here to make it a little easier to add items.
1:45 PM Changeset in webkit [4147] by cblu
  • 3 edits in trunk

WebCore:

Fixed previous "Reviewed by".

  • ChangeLog:

WebKit:

Fixed previous "Reviewed by".

  • ChangeLog:
11:49 AM Changeset in webkit [4146] by cblu
  • 8 edits in trunk

WebCore:

Use renamed plug-in view methods.

Reviewed by darin.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
  • kwq/WebCoreBridge.h:

WebKit:

Fixed: 3140990 - Safari: Error attempting to load movie from Rhino records
Renamed plug-in view methods to mention that they take URL strings.

Reviewed by darin.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURLString:attributes:baseURLString:MIMEType:]): renamed, try to find the plug-in using the extension of the SRC URL if the plug-in isn't found using the MIME type. (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURLString:]): renamed

Apr 18, 2003:

2:20 PM Changeset in webkit [4145] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3191892 - Popup blocking prevents window.open with '_self' as target (superbitdvd.com)
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Don't apply popup blocking if the call would open something in an existing frame (inlcuding the special _self, _top and _parent frames.
2:20 PM Changeset in webkit [4144] by hyatt
  • 3 edits in trunk/WebCore

Make sure display:table is not accidentally mutated to
display:block.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp:
2:14 PM Changeset in webkit [4143] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3081926 - bookmarklet to count and display mailto links fails
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall): Implement custom toString JavaScript method which calls the existing toString C++ custom method.
  • khtml/ecma/kjs_html.h: Added AnchorToString.
  • khtml/ecma/kjs_html.lut.h: Regenerated.
1:15 PM Changeset in webkit [4142] by cblu
  • 3 edits in trunk/WebCore

Fixed: 3172389 - Safari doesn't parse attributes within the OBJECT tag

Reviewed by dave.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): add attributes from within the OBJECT tag to params, the list of attributes we pass to plug-ins. Don't override attributes that are already in params.
10:44 AM Changeset in webkit [4141] by hyatt
  • 3 edits in trunk/WebCore

Make sure display:none is ignored and not accidentally mutated
to display:block.

Reviewed by darin

  • khtml/css/cssstyleselector.cpp:
9:20 AM Changeset in webkit [4140] by cblu
  • 10 edits in trunk/WebKit

WebKit:

Fixed: 3139385 - don't accept drags from other frames in the same WebView

Reviewed by john.

  • WebView.subproj/WebFrameView.m: moved drag destination code from WebFrameView to WebView (-[WebFrameView initWithFrame:]): removed drag registration code
  • WebView.subproj/WebFrameViewPrivate.h:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): unregister drag types on the WebView (-[WebHTMLView draggedImage:endedAt:operation:]): reregister drag types on the WebView
  • WebView.subproj/WebImageView.m: (-[WebImageView mouseDragged:]): unregister drag types on the WebView (-[WebImageView draggedImage:endedAt:operation:]): reregister drag types on the WebView
  • WebView.subproj/WebView.m: moved drag destination code from WebFrameView to WebView (-[WebView draggingEntered:]): moved from WebFrameView (-[WebView prepareForDragOperation:]): ditto (-[WebView performDragOperation:]): ditto (-[WebView concludeDragOperation:]): ditto
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _registerDraggedTypes]): ditto

WebBrowser:

  • Fixed regression. Don't append "txt" to files that already end in "txt". Doh!

Reviewed by john.

  • BrowserDocument.m: (-[BrowserDocument panel:userEnteredFilename:confirmed:]):

Apr 17, 2003:

7:14 PM Changeset in webkit [4139] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:]): if we can't load the file as a dictionary, try loading it the old-fashioned array way. This makes the history file format change forward-compatible.
6:30 PM Changeset in webkit [4138] by cblu
  • 3 edits in trunk/WebKit

WebKit:

Fixed: 3160751 - Can't use non-'.txt' file extension for text files?

Reviewed by mjs.

  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebNSURLResponseExtras.m: (-[NSURL _web_suggestedFilenameForSavingWithMIMEType:]): don't correct the file extension for plain text files

WebBrowser:

Fixed: 3160751 - Can't use non-'.txt' file extension for text files?

Reviewed by mjs

  • BrowserDocument.m: (-[BrowserDocument dataSourceToSave]): new (-[BrowserDocument isSavingPlainText]): new (-[BrowserDocument prepareSavePanel:]): newly implemented, make the save panel lenient about plain text (-[BrowserDocument panel:userEnteredFilename:confirmed:]): mimic TextEdit when saving plain text. If the extension ends in something other that ".txt", suggest appending ".txt" (-[BrowserDocument dataRepresentationOfType:]): call dataSourceToSave (-[BrowserDocument displayName]): call dataSourceToSave (-[BrowserDocument fileType]): call dataSourceToSave
  • English.lproj/Localizable.strings:
5:43 PM Changeset in webkit [4137] by sullivan
  • 2 edits in trunk/WebKit
  • fixed 3232332 -- History file should be versioned since we might change it in the future
  • fixed 3220355 -- Console error message at launch when there's no history file

Note: a downside of this change is that the history formats
before and after this change are not compatible. You will
get no history each time you cross that boundary by running
different Safaris.

Reviewed by Maciej.

  • History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:]): check for file-doesn't-exist case before complaining about being unable to read existing file; expect to read dictionary rather than array, and check version in dictionary. (-[WebHistoryPrivate _saveHistoryGuts:]): save dictionary that includes version as well as array of items by date.
5:40 PM Changeset in webkit [4136] by rjw
  • 2 edits in trunk/WebKit

Fixed typos in headerdoc comments.

  • WebView.subproj/WebFrame.h:
4:44 PM Changeset in webkit [4135] by darin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed a bug caught by libgmalloc on Vicki's test machine
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): Make sure we don't have a dangling paint device after detaching from the KTHMLView. (DocumentImpl::setPaintDevice): Allow a 0 parameter.
  • kwq/WebCoreBridge.mm: (nowPrinting): Handle the case of a 0 paint device.
4:22 PM Changeset in webkit [4134] by mjs
  • 3 edits in branches/Safari-73~1-branch/WebKit/Misc.subproj
  • merged build fixes from HEAD

2003-04-17 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • fix build on latest Panther due to conflicts with the latest Foundation.
  • Database.subproj/WebDatabase.h:
  • Database.subproj/WebDatabase.m: (-[WebDatabase open]): Removed boolean return. (-[WebDatabase close]): Likewise.
  • Database.subproj/WebFileDatabase.m: (-[WebFileDatabase open]): Likewise. (-[WebFileDatabase close]): Likewise.
4:20 PM Changeset in webkit [4133] by mjs
  • 3 edits in trunk/WebKit/Misc.subproj

Reviewed by Darin.

  • fix build on latest Panther due to conflicts with the latest Foundation.
  • Database.subproj/WebDatabase.h:
  • Database.subproj/WebDatabase.m: (-[WebDatabase open]): Removed boolean return. (-[WebDatabase close]): Likewise.
  • Database.subproj/WebFileDatabase.m: (-[WebFileDatabase open]): Likewise. (-[WebFileDatabase close]): Likewise.
11:54 AM Changeset in webkit [4132]
  • 8 copies in tags/Safari-73~3

This commit was manufactured by cvs2svn to create tag 'Safari-73~3'.

11:54 AM Changeset in webkit [4131] by darin
  • 2 edits in branches/Safari-73~1-branch/WebKit

Rolled in change from trunk.

2003-04-17 Richard Williamson <​rjw@apple.com>

Drop down yet one more level to avoid intialization horkage.
Call objc_getClass() instead of NSClassFromString().

Reviewed by darin.

  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):
11:51 AM Changeset in webkit [4130] by rjw
  • 2 edits in trunk/WebKit

Drop down yet one more level to avoid intialization horkage.
Call objc_getClass() instead of NSClassFromString().

Reviewed by darin.

  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):
11:43 AM Changeset in webkit [4129] by darin
  • 2 edits in branches/Safari-73~1-branch/WebKit

Rolled in change from trunk.

2003-04-17 Darin Adler <Darin Adler>

Reviewed by John.

  • WebView.subproj/WebDataProtocol.m: (+[NSURLRequest _webDataRequestURLForData:]): Register the WebDataProtocol here instead of doing it with a load method, since this is the bottleneck that must be used before that protocol is needed. It's good to have one less load method, and this may fix a problem reported by a Panther WebKit client on intrigue-dev too.
9:10 AM Changeset in webkit [4128] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • WebView.subproj/WebDataProtocol.m: (+[NSURLRequest _webDataRequestURLForData:]): Register the WebDataProtocol here instead of doing it with a load method, since this is the bottleneck that must be used before that protocol is needed. It's good to have one less load method, and this may fix a problem reported by a Panther WebKit client on intrigue-dev too.
Note: See TracTimeline for information about the timeline view.