Timeline
Apr 23, 2003:
- 10:36 PM Changeset in webkit [4164] by
-
- 2 edits in trunk/WebKit
WebFoundation:
Reviewed by Darin.
Revised NSURLCredential to fully comply with proposal.
- AuthenticationManager.subproj/NSURLCredential.h:
- AuthenticationManager.subproj/NSURLCredential.m: (-[NSURLCredentialPrivate dealloc]): (-[NSURLCredential initWithUser:password:persistence:]): (+[NSURLCredential URLCredentialWithUser:password:persistence:]): (-[NSURLCredential dealloc]): (-[NSURLCredential user]): (-[NSURLCredential password]): (-[NSURLCredential hasPassword]): (-[NSURLCredential persistence]): (-[NSURLCredential copyWithZone:]): (-[NSURLCredential description]):
- AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage _usernameForRealm:URL:]): (-[NSURLCredentialStorage _removePasswordForRealm:URL:]): (-[NSURLCredentialStorage _proxyUsernameForURL:]): (-[NSURLCredentialStorage _removeProxyPasswordForURL:]): (-[NSURLCredentialStorage _setDefaultUserInfoFromURL:]): (-[NSURLCredentialStorage NSURLAuthenticationChallenge:useCredential:]): (-[NSURLCredentialStorage _applyHTTPProxyCredentials:]): (-[NSURLCredentialStorage _applyHTTPCredentials:]):
- AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _addCredential:forProtectionSpace:]): (-[WebCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): (-[WebCredentialStorage _updateDefaultState:forCredential:protectionSpace:]): (-[WebCredentialStorage _addKeychainItem:]): (-[WebCredentialStorage addCredential:forProtectionSpace:]): (-[WebCredentialStorage removeCredential:forProtectionSpace:]): (-[WebCredentialStorage setDefaultCredential:forProtectionSpace:]):
- AuthenticationManager.subproj/WebKeychainCredential.m: (-[WebKeychainCredential initWithKeychainItem:]): (+[WebKeychainCredential credentialWithKeychainItem:]): (-[WebKeychainCredential hasPassword]):
WebKit:
Reviewed by Darin.
Adjusted for NSURLCredential changes.
- Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
WebBrowser:
Reviewed by Darin.
Adjusted for NSURLCredential changes.
- FormCompletionController.m: (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): (+[FormCompletionController _credentialMatchesForString:frame:]): (stringFromMatch): (+[FormCompletionController _autoFillPasswordInFrame:formInfo:]): (+[FormCompletionController credentialIsNeverSaveMarker:]):
- Preferences.subproj/PasswordsEditor.m: (compareCredentials): (-[PasswordsEditor tableView:objectValueForTableColumn:row:]):
- 2:41 PM Changeset in webkit [4163] by
-
- 2 edits in trunk/WebKit
WebKit:
Reviewed by darin.
- English.lproj/StringsNotToBeLocalized.txt: updated
WebBrowser:
Fixed: 3190961 - Adobe's "Download Manager Instructions" file deemed unsafe by Safari, so not opened
Reviewed by darin.
- English.lproj/StringsNotToBeLocalized.txt:
- Preferences.subproj/WBPreferences.m: (+[WBPreferences shouldOpenFileAtPath:]): open the file if its application's id is "com.adobe.ESD.helperapp"
- 1:36 PM Changeset in webkit [4162] by
-
- 2 edits in trunk/WebKit
Fixed: 3161374 - safari windows don't allow text/URL dragging on the first click
Reviewed by john.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _isSelectionEvent:]): new, determines if the event occurred over the selection (-[WebHTMLView acceptsFirstMouse:]): newly implemented, return result of _isSelectionEvent: (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): newly implemented, return result of _isSelectionEvent:
- 11:03 AM Changeset in webkit [4161] by
-
- 6 edits in trunk/WebKit
WebKit:
Renamed the policy delegate methods.
Reviewed by john.
- WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:frame:]): (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): (-[WebDefaultPolicyDelegate webView:decidePolicyForNewWindowAction:request:newFrameName:decisionListener:]):
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]): (-[WebFrame _checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient checkContentPolicyForResponse:]):
- WebView.subproj/WebPolicyDelegate.h:
WebBrowser:
Updated WebBrowser to the renamed WebPolicyDelegate methods.
Reviewed by john.
- BrowserWebController.m: (-[BrowserWebController webView:unableToImplementPolicyWithError:frame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]): (-[BrowserWebController decidePolicyForAction:request:frame:newFrameName:decisionListener:]): (-[BrowserWebController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): (-[BrowserWebController webView:decidePolicyForNewWindowAction:request:newFrameName:decisionListener:]):
- 10:24 AM Changeset in webkit [4160] by
-
- 11 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3237301 -- REGRESSION: text fields with size greater than maxlength are sized according to maxlength
- kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Override the maximum length for this operation.
- fixed 3236961 -- setting innerHTML with input elements doesn't set up value properly
To fix this, I rolled in the changes from the trunk of KHTML development that get rid of
the init() function and do the work in either attach() or insertedIntoDocument() instead.
- khtml/html/html_baseimpl.h: Removed init overrides, added insertedIntoDocument override.
- khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): Moved HTMLBodyElementImpl::init code here. (HTMLFrameElementImpl::attach): Moved HTMLFrameElementImpl::init code here. (HTMLFrameSetElementImpl::attach): Moved HTMLFrameSetElementImpl::init code here.
- khtml/html/html_formimpl.h: Added m_inited flag, removed init overrides, removed unused m_encCharset field.
- khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Removed code that set m_encCharset. (HTMLFormElementImpl::setEnctype): Removed code that set m_encCharset. (HTMLInputElementImpl::HTMLInputElementImpl): Initialize m_inited to false. (HTMLInputElementImpl::attach): Moved HTMLInputElementImpl::init code here, guarded by m_inited. (HTMLSelectElementImpl::attach): Moved HTMLSelectElementImpl::init code here. (HTMLTextAreaElementImpl::attach): Moved HTMLTextAreaElementImpl::init code here.
- khtml/xml/dom_nodeimpl.h: Removed init.
- khtml/xml/dom_nodeimpl.cpp: Removed init.
- khtml/html/htmlparser.cpp: (KHTMLParser::insertNode): Removed calls to init.
- khtml/xml/xml_tokenizer.cpp: (XMLHandler::startElement): Removed call to init. (XMLHandler::startCDATA): Removed call to init. (XMLHandler::exitText): Removed call to init.
Apr 22, 2003:
- 6:10 PM Changeset in webkit [4159]
-
- 20 copies in tags/Safari-73~4
This commit was manufactured by cvs2svn to create tag 'Safari-73~4'.
- 6:10 PM Changeset in webkit [4158] by
-
- 5 edits in branches/Safari-73~1-branch
Bump versions to 1.0.
- 5:30 PM Changeset in webkit [4157] by
-
- 8 edits in branches/Safari-73~1-branch
Safari-73.4
- 5:09 PM Changeset in webkit [4156] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Ken.
Improved List pool for 3% speed improvement on cvs-js-ibench
- kjs/list.cpp: Replaced the roving cursor with a free list and raised the high water mark to 384.
- 5:03 PM Changeset in webkit [4155] by
-
- 6 edits in trunk/WebCore
Reviewed by Maciej.
- fixed 3158411 -- radio button groups are per-form in WebCore, per-page in other browsers (flyglobespan.com)
- khtml/html/html_formimpl.h: Removed radioClicked. Made setName virtual and make HTMLInputElementImpl override it. Added isCheckedRadioButtonForDocument, addCheckedRadioButtonToDocument, and removeCheckedRadioButtonFromDocument.
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::~HTMLInputElementImpl): Call removeCheckedRadioButtonFromDocument. (HTMLInputElementImpl::setType): Call removeCheckedRadioButtonFromDocument before changing the type and addCheckedRadioButtonToDocument after. (HTMLInputElementImpl::parseAttribute): Call removeCheckedRadioButtonFromDocument before changing ATTR_NAME and addCheckedRadioButtonToDocument after. (HTMLInputElementImpl::setChecked): Call removeCheckedRadioButtonFromDocument before changing the checked state and addCheckedRadioButtonToDocument after. (HTMLInputElementImpl::setName): Call removeCheckedRadioButtonFromDocument before changing the name and addCheckedRadioButtonToDocument after. (HTMLInputElementImpl::isCheckedRadioButtonForDocument): Added. Checks if this element should be the one known to the document. (HTMLInputElementImpl::addCheckedRadioButtonToDocument): Call addCheckedRadioButton on the document if isCheckedRadioButtonForDocument returns true. (HTMLInputElementImpl::removeCheckedRadioButtonFromDocument): Call removeCheckedRadioButtonFromDocument on the document if isCheckedRadioButtonForDocument returns true.
- khtml/xml/dom_docimpl.h: Add addCheckedRadioButton, removeCheckedRadioButton, and m_checkedRadioButtons.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::addCheckedRadioButton): Uncheck the old radio button with this name, if any. Store the new radio button in the "checked radio buttons" map. (DocumentImpl::removeCheckedRadioButton): Remove the radio button from the map.
- 4:48 PM Changeset in webkit [4154] by
-
- 2 edits in trunk/WebKit
WebFoundation:
Reviewed by Darin
Updated to use API-approved methods for accessing
protocol-specific URL request data.
Changed use of NSURLProtocol registeredClasses method to
_registeredClasses to reflect that that this method
is no longer API, but is available as SPI.
- CacheLoader.subproj/NSURLProtocol.h:
- CacheLoader.subproj/NSURLProtocol.m: (+[NSURLProtocol propertyForKey:inRequest:]): (+[NSURLProtocol setProperty:forKey:inRequest:]): (+[NSURLProtocol _registeredClasses]):
- CacheLoader.subproj/NSURLProtocolPrivate.h:
- CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequestInternal dealloc]): (-[NSURLRequest hash]): (-[NSURLRequest isEqual:]): (-[NSURLRequest mutableCopyWithZone:]): (-[NSURLRequest _copyReplacingURLWithURL:]): (-[NSURLRequest _propertyForKey:]): (-[NSURLRequest _setProperty:forKey:]): (-[NSMutableURLRequest copyWithZone:]): (-[NSMutableURLRequest _copyReplacingURLWithURL:]): (-[NSURLRequest _parametersForReading]): (-[NSURLRequest HTTPMethod]): (-[NSURLRequest HTTPAllHeaderFields]): (-[NSURLRequest HTTPValueForHeaderField:]): (-[NSURLRequest HTTPBody]): (-[NSURLRequest HTTPAllowSSLCertificatesWithUnknownRoots]): (-[NSURLRequest HTTPCookiePolicyBaseURL]): (-[NSURLRequest HTTPExtraCookies]): (-[NSURLRequest HTTPPageNotFoundCacheLifetime]): (-[NSMutableURLRequest _parametersForWriting]): (-[NSMutableURLRequest HTTPSetMethod:]): (-[NSMutableURLRequest HTTPSetAllHeaderFields:]): (-[NSMutableURLRequest HTTPSetValue:forHeaderField:]): (-[NSMutableURLRequest HTTPAddValue:forHeaderField:]): (-[NSMutableURLRequest HTTPSetBody:]): (-[NSMutableURLRequest HTTPSetAllowSSLCertificatesWithUnknownRoots:]): (-[NSMutableURLRequest HTTPSetCookiePolicyBaseURL:]): (-[NSMutableURLRequest HTTPSetExtraCookies:]): (-[NSMutableURLRequest HTTPSetPageNotFoundCacheLifetime:]): (-[NSHTTPURLRequestRequestParameters copyWithZone:]): (-[NSHTTPURLRequestRequestParameters mutableCopyWithZone:]):
- CacheLoader.subproj/NSURLRequestPrivate.h:
- WebFoundation.pbproj/project.pbxproj:
WebKit:
Reviewed by Darin
Updated to use API-approved methods for accessing
protocol-specific URL request data.
- WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestParametersForReading]): (-[NSURLRequest _webDataRequestParametersForWriting]):
WebBrowser:
Reviewed by Darin
Changed use of NSURLProtocol registeredClasses method to
_registeredClasses to reflect that that this method
is no longer API, but is available as SPI.
- Debug/DebugUtilities.m: (initProtocolHandlers):
- 11:54 AM Changeset in webkit [4153] by
-
- 6 edits in trunk/WebKit
WebFoundation:
Reviewed by Darin.
Adjusted for class renames.
- AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
- AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallengePrivate initWithProtectionSpace:defaultUsername:previousFailureCount:delegate:]): (-[NSURLAuthenticationChallengePrivate dealloc]): (-[NSURLAuthenticationChallenge _initWithProtectionSpace:defaultUsername:previousFailureCount:delegate:]): (-[NSURLAuthenticationChallenge _authenticationHandlerBusy]): (-[NSURLAuthenticationChallenge init]): (-[NSURLAuthenticationChallenge dealloc]): (-[NSURLAuthenticationChallenge protectionSpace]): (-[NSURLAuthenticationChallenge defaultUsername]): (-[NSURLAuthenticationChallenge previousFailureCount]): (-[NSURLAuthenticationChallenge useCredential:]): (-[NSURLAuthenticationChallenge cancel]):
- AuthenticationManager.subproj/NSURLCredential.h:
- AuthenticationManager.subproj/NSURLCredential.m: (-[NSURLCredential initWithUsername:password:remembered:]): (+[NSURLCredential credentialWithUsername:password:remembered:]): (-[NSURLCredential copyWithZone:]):
- AuthenticationManager.subproj/NSURLCredentialStorage.h:
- AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLAuthenticationChallengeState initWithHandlersCopy:index:httpRequest:challenge:callback:context:]): (-[NSURLAuthenticationChallengeState dealloc]): (-[NSURLCredentialStoragePrivate init]): (-[NSURLCredentialStoragePrivate dealloc]): (-[NSURLCredentialStorage dealloc]): (-[NSURLCredentialStorage init]): (initSharedCredentialStorage): (initCredentialStorage): (_credentialStorage): (+[NSURLCredentialStorage sharedCredentialStorage]): (-[NSURLCredentialStorage addAuthenticationHandler:]): (-[NSURLCredentialStorage removeAuthenticationHandler:]): (-[NSURLCredentialStorage credentialsForProtectionSpace:]): (-[NSURLCredentialStorage addCredential:forProtectionSpace:]): (-[NSURLCredentialStorage removeCredential:forProtectionSpace:]): (-[NSURLCredentialStorage defaultCredentialForProtectionSpace:]): (-[NSURLCredentialStorage setDefaultCredential:forProtectionSpace:]): (-[NSURLCredentialStorage _internalInit]): (-[NSURLCredentialStorage _usernameForRealm:URL:]): (-[NSURLCredentialStorage _removePasswordForRealm:URL:]): (-[NSURLCredentialStorage _proxyUsernameForURL:]): (-[NSURLCredentialStorage _removeProxyPasswordForURL:]): (-[NSURLCredentialStorage _realmForURL:]): (-[NSURLCredentialStorage _setRealm:forURL:]): (-[NSURLCredentialStorage _proxyProtectionSpaceForURL:]): (-[NSURLCredentialStorage _setDefaultUserInfoFromURL:]): (-[NSURLCredentialStorage _invokeHandlersWithURL:realm:forRequest:failureCount:withCallback:context:]): (-[NSURLCredentialStorage _invokeHandlersWithURL:proxy:forRequest:failureCount:withCallback:context:]): (-[NSURLCredentialStorage _tryChallenge:]): (-[NSURLCredentialStorage _retryWaitingChallenges]): (-[NSURLCredentialStorage NSURLAuthenticationChallenge:useCredential:]): (-[NSURLCredentialStorage NSURLAuthenticationChallengeCancel:]): (-[NSURLCredentialStorage NSURLAuthenticationChallengeAuthenticationHandlerBusy:]): (-[NSURLCredentialStorage _applyHTTPProxyCredentials:]): (-[NSURLCredentialStorage _applyHTTPCredentials:]): (-[NSURLCredentialStorage _addCredentialsToInitialHTTPRequest:]): (-[NSURLCredentialStorage _checkForAuthenticationFailureInHTTPResponse:withURL:]): (-[NSURLCredentialStorage _addCredentialsToRetryHTTPRequest:afterFailureResponse:failureCount:withCallback:context:]): (-[NSURLCredentialStorage _cancelAddCredentialsToRetryHTTPRequest:]): (-[NSURLCredentialStorage _haveCredentialForURL:]):
- AuthenticationManager.subproj/NSURLProtectionSpace.h:
- AuthenticationManager.subproj/NSURLProtectionSpace.m: (-[NSURLProtectionSpace _internalInit]): (-[NSURLProtectionSpace copyWithZone:]): (-[NSURLProtectionSpace isEqual:]):
- AuthenticationManager.subproj/WebAuthenticationHandler.h:
- AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.h:
- AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationDispatchState dealloc]): (-[WebAuthenticationHandlerDispatcher _dispatchStartAuthentication:]): (-[WebAuthenticationHandlerDispatcher NSURLAuthenticationChallenge:useCredential:]): (-[WebAuthenticationHandlerDispatcher NSURLAuthenticationChallengeAuthenticationHandlerBusy:]): (-[WebAuthenticationHandlerDispatcher _dispatchCancelAuthentication:]): (-[WebAuthenticationHandlerDispatcher _dispatchAuthenticationDone:]): (-[WebAuthenticationHandlerDispatcher _dispatchAuthenticationHandlerBusy:]): (-[WebAuthenticationHandlerDispatcher initWithAuthenticationHandler:]): (-[WebAuthenticationHandlerDispatcher dealloc]): (-[WebAuthenticationHandlerDispatcher startAuthentication:]): (-[WebAuthenticationHandlerDispatcher cancelAuthentication:]):
- AuthenticationManager.subproj/WebAuthenticationManagerCallback.h:
- AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
- AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
- AuthenticationManager.subproj/WebCredentialStorage.h:
- AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _addCredential:forProtectionSpace:]): (-[WebCredentialStorage _rootSpaceForProtectionSpace:]): (-[WebCredentialStorage _protectionSpaceWithKeychainItem:isDefault:]): (-[WebCredentialStorage _secProtocolForProtectionSpace:]): (-[WebCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): (-[WebCredentialStorage _updateDefaultState:forCredential:protectionSpace:]): (-[WebCredentialStorage _addKeychainItem:]): (-[WebCredentialStorage credentialsForProtectionSpace:]): (-[WebCredentialStorage addCredential:forProtectionSpace:]): (-[WebCredentialStorage removeCredential:forProtectionSpace:]): (-[WebCredentialStorage defaultCredentialForProtectionSpace:]): (-[WebCredentialStorage setDefaultCredential:forProtectionSpace:]):
- AuthenticationManager.subproj/WebKeychainCredential.h:
- ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]): (-[WebCFNetworkHTTPProtocol stopLoading]): (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]):
- ProtocolHandlers.subproj/WebHTTPProtocol.h:
- ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (+[WebSimpleHTTPProtocol canInitWithRequest:]):
- WebFoundation.exp:
WebKit:
Reviewed by Darin.
Renamed classes to match API document.
- Panels.subproj/WebAuthenticationPanel.h:
- Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
- Panels.subproj/WebPanelAuthenticationHandler.h:
- Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler init]): (-[WebPanelAuthenticationHandler dealloc]): (-[WebPanelAuthenticationHandler isReadyToStartAuthentication:]): (-[WebPanelAuthenticationHandler startAuthentication:]): (-[WebPanelAuthenticationHandler cancelAuthentication:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]):
- Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels setUsesStandardAuthenticationPanel:]):
WebBrowser:
Reviewed by Darin.
Adjusted for class renames.
- AppController.m: (-[AppController removeAllCredentials]):
- BookmarksViewController.m: (+[BookmarksViewController autoTabColumnTitle]):
- FormCompletionController.h:
- FormCompletionController.m: (protectionSpaceFromFrame): (+[FormCompletionController _frame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): (+[FormCompletionController _credentialMatchesForString:frame:]): (stringFromMatch): (+[FormCompletionController _autoFillPasswordInFrame:formInfo:]): (+[FormCompletionController credentialIsNeverSaveMarker:]): (-[FormCompletionController reflectSelectedRow]):
- Preferences.subproj/PasswordsEditor.h:
- Preferences.subproj/PasswordsEditor.m: (-[PasswordsEditor protectionSpaceForCredential:]): (-[PasswordsEditor addressStringForCredential:]): (compareCredentials): (-[PasswordsEditor resetCredentials]): (-[PasswordsEditor startMonitoringCredentials]): (-[PasswordsEditor stopMonitoringCredentials]): (-[PasswordsEditor removeSelectedItems:]): (-[PasswordsEditor tableView:objectValueForTableColumn:row:]):
- 11:30 AM Changeset in webkit [4152] by
-
- 9 edits in trunk/WebCore
Reviewed by John.
- fixed 3144966 -- problems typing in form at http://www.mobile.att.net/messagecenter
The bug was that doing a focus would always select the entire contents of the field.
While this behavior does match Mozilla's behavior for text fields, it doesn't match
WinIE; we're going to imitate WinIE and not do it. Also fix the same issue for text areas.
- kwq/KWQTextField.h: Add lastSelectedRange field.
- kwq/KWQTextField.mm: (-[KWQTextField initWithFrame:]): Initialize lastSelectedRange (to nothing). (-[KWQTextField initWithQLineEdit:]): Use [self init] instead of [super init]. The same thing, but you should never call [super xxx] where xxx is a non-designated initializer of the superclass. (-[KWQTextField currentEditorForEitherField]): Added. Returns the current editor of either the text field or the secure text field. (-[KWQTextField selectedRange]): Added. (-[KWQTextField setSelectedRange:]): Added. (-[KWQTextField controlTextDidEndEditing:]): Store the selected text range in the lastSelectedRange variable, so it can be used later. Also move the code that sends the FocusOut event here. (-[KWQTextField control:textShouldBeginEditing:]): Do the "scroll frame into view" here isntead of in becomeFirstResponder so it can be shared. (-[KWQTextField control:textShouldEndEditing:]): Moved FocusOut to controlTextDidEndEditing:. (-[KWQTextField didBecomeFirstResponder]): Added. Sets the selected range back to what it was in textShouldEndEditing, but only if we are not tabbing into the field. If we don't set the selected range, then we inherit the behavior from NSTextField, all text selected. We can't do the selected range work in textDidEndEditing because that's called too early. (-[KWQTextField becomeFirstResponder]): Call didBecomeFirstResponder. (-[KWQSecureTextField currentEditorForSecureField]): Added. Factored out of selectText:. (-[KWQSecureTextField selectText:]): Use currentEditorForSecureField for clarity. (-[KWQSecureTextField becomeFirstResponder]): Call didBecomeFirstResponder.
- kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Rearrange a bit. (-[KWQTextArea setWordWrap:]): Ditto. (-[KWQTextAreaTextView becomeFirstResponder]): Only do the selectAll: operation here if we are tabbing into the field. Otherwise keep the selection from last time.
- khtml/rendering/render_form.cpp: (RenderTextArea::updateFromElement): Don't do the whole "save cursor position, set text, restore cursor position" dance for the case where the field already has the correct contents. Without this change, selections can be collapsed to an insertion point at the start of the selection at seemingly random times.
- khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Don't deselect the currently focused node on mouse down. This created a symptom where a text field would lose focus when you clicked on a button.
- kwq/KWQLineEdit.h: Remove unused frame() method.
- kwq/KWQLineEdit.mm: Remove unused, unimplemented frame() method.
- 6:56 AM Changeset in webkit [4151] by
-
- 6 edits in trunk/WebKit
WebFoundation:
Reviewed by Darin
API changes in NSURLProtocol and its subclasses:
+canHandleURL: becomes +canInitWithRequest:
+canonicalURLForURL: becomes +canonicalRequestForRequest:
_protocolClassForURL: becomes _protocolClassForRequest:
Some other related changes include:
These two methods added to NSURLRequest SPI:
-(id)_copyReplacingURLWithURL:(NSURL *)URL;
-(BOOL)_URLHasScheme:(NSString *)scheme;
_web_canonicalize: method in NSURL extras has been updated
to work with new canonicalization scheme.
The process of canonicalizing URLs no longer unconditionally
makes a new URL. There is now additional smarts that checks
a URL before making a new one based on whether or not the
input URL is already in canonical form.
- CacheLoader.subproj/NSURLConnection.m: (+[NSURLConnection canHandleRequest:]): (-[NSURLConnection _beginLoad]):
- CacheLoader.subproj/NSURLProtocol.h:
- CacheLoader.subproj/NSURLProtocol.m: (+[NSURLProtocol canInitWithRequest:]): (+[NSURLProtocol canonicalRequestForRequest:]): (+[NSURLProtocol registerClass:]): (+[NSURLProtocol _protocolClassForRequest:]): (+[NSURLProtocol _makeRequestCanonicalByMakingRequestURLCanonical:]):
- CacheLoader.subproj/NSURLProtocolPrivate.h:
- CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest _copyReplacingURLWithURL:]): (-[NSURLRequest _URLHasScheme:]): (-[NSMutableURLRequest copyWithZone:]): (-[NSMutableURLRequest _copyReplacingURLWithURL:]):
- CacheLoader.subproj/NSURLRequestPrivate.h:
- Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_canonicalize]):
- ProtocolHandlers.subproj/WebAboutProtocol.m: (+[WebAboutProtocol canInitWithRequest:]): (+[WebAboutProtocol canonicalRequestForRequest:]): (+[WebAboutProtocol _canonicalURLForURL:]):
- ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (+[WebCFNetworkHTTPProtocol canInitWithRequest:]):
- ProtocolHandlers.subproj/WebFTPProtocol.m: (+[WebFTPProtocol canInitWithRequest:]): (+[WebFTPProtocol canonicalRequestForRequest:]): (+[WebFTPProtocol _canonicalURLForURL:]):
- ProtocolHandlers.subproj/WebFileProtocol.m: (+[WebFileProtocol canInitWithRequest:]): (+[WebFileProtocol canonicalRequestForRequest:]): (+[WebFileProtocol _canonicalURLForURL:]):
- ProtocolHandlers.subproj/WebHTTPProtocol.h:
- ProtocolHandlers.subproj/WebHTTPProtocol.m: (+[WebHTTPProtocol canonicalRequestForRequest:]): (+[WebHTTPProtocol _canonicalURLForURL:]): (-[WebHTTPProtocol URL]):
- ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (+[WebSimpleHTTPProtocol canInitWithRequest:]):
WebKit:
Reviewed by Darin
API changes in NSURLProtocol and its subclasses:
+canHandleURL: becomes +canInitWithRequest:
+canonicalURLForURL: becomes +canonicalRequestForRequest:
Added new _webIsDataProtocolURL: helper method.
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
- WebView.subproj/WebDataProtocol.h:
- WebView.subproj/WebDataProtocol.m: (+[WebDataProtocol _webIsDataProtocolURL:]): (+[WebDataProtocol canInitWithRequest:]): (+[WebDataProtocol canonicalRequestForRequest:]):
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _transitionToCommitted:]):
Apr 21, 2003:
- 9:54 PM Changeset in webkit [4150] by
-
- 2 edits in trunk/WebKit
- Plugins.subproj/WebNetscapePluginStream.m: Removed unnecessary #import of <WebFoundation/WebFoundation.h>.
- 7:12 PM Changeset in webkit [4149] by
-
- 4 edits in trunk/WebKit
WebFoundation:
Reviewed by Richard.
Renamed headers and implementation files for new auth API.
- AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
- AuthenticationManager.subproj/NSURLAuthenticationChallenge.m:
- AuthenticationManager.subproj/NSURLCredential.h:
- AuthenticationManager.subproj/NSURLCredential.m:
- AuthenticationManager.subproj/NSURLCredentialStorage.h:
- AuthenticationManager.subproj/NSURLCredentialStorage.m:
- AuthenticationManager.subproj/NSURLProtectionSpace.h:
- AuthenticationManager.subproj/NSURLProtectionSpace.m:
- AuthenticationManager.subproj/WebAuthenticatingResource.h: Removed.
- AuthenticationManager.subproj/WebAuthenticatingResource.m: Removed.
- AuthenticationManager.subproj/WebAuthenticationHandler.h:
- AuthenticationManager.subproj/WebAuthenticationManager.h: Removed.
- AuthenticationManager.subproj/WebAuthenticationManager.m: Removed.
- AuthenticationManager.subproj/WebAuthenticationManagerCallback.h:
- AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
- AuthenticationManager.subproj/WebAuthenticationRequest.h: Removed.
- AuthenticationManager.subproj/WebAuthenticationRequest.m: Removed.
- AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
- AuthenticationManager.subproj/WebAuthenticationResult.h: Removed.
- AuthenticationManager.subproj/WebCredential.h: Removed.
- AuthenticationManager.subproj/WebCredential.m: Removed.
- AuthenticationManager.subproj/WebCredentialStorage.h:
- AuthenticationManager.subproj/WebCredentialStorage.m:
- AuthenticationManager.subproj/WebKeychainCredential.h:
- WebFoundation.pbproj/project.pbxproj:
WebKit:
Reviewed by Richard.
Updated for file renames.
- Panels.subproj/WebAuthenticationPanel.h:
- Panels.subproj/WebPanelAuthenticationHandler.h:
- Panels.subproj/WebStandardPanels.m:
WebBrowser:
Reviewed by Richard.
Updated for file renames.
- AppController.m:
- FormCompletionController.m:
- Preferences.subproj/PasswordsEditor.m:
- 4:45 PM Changeset in webkit [4148] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
- fixed bug 3159076 -- turbotax.intuit.com forms have text fields instead of radio buttons
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::setType): Implement; loosen rule about what type changes are allowed. (HTMLInputElementImpl::parseAttribute): Call setType for ATTR_TYPE.
- unrelated tweak
- kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Use a macro here to make it a little easier to add items.
- 1:45 PM Changeset in webkit [4147] by
-
- 3 edits in trunk
WebCore:
Fixed previous "Reviewed by".
- ChangeLog:
WebKit:
Fixed previous "Reviewed by".
- ChangeLog:
- 11:49 AM Changeset in webkit [4146] by
-
- 8 edits in trunk
WebCore:
Use renamed plug-in view methods.
Reviewed by darin.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
- kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
- kwq/WebCoreBridge.h:
WebKit:
Fixed: 3140990 - Safari: Error attempting to load movie from Rhino records
Renamed plug-in view methods to mention that they take URL strings.
Reviewed by darin.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURLString:attributes:baseURLString:MIMEType:]): renamed, try to find the plug-in using the extension of the SRC URL if the plug-in isn't found using the MIME type. (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURLString:]): renamed
Note:
See TracTimeline
for information about the timeline view.
