Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Apr 28, 2003:

7:09 PM Changeset in webkit [4203] by gramps

• 6 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej.

• English.lproj/StringsNotToBeLocalized.txt:

Updated for recent changes.

WebKit:

Fixed 3225050 -- Default font size should be 16px
Fixed 3241813 -- No longer spoof as WinIE for abcnews.go.com when
default font size becomes 16px

Reviewed by Darin and Maciej.

• English.lproj/StringsNotToBeLocalized.txt:

Updated.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):

We need to adjust Times, Helvetica, and Courier to closely match the
vertical metrics of their Microsoft counterparts that are the de facto
web standard. The AppKit adjustment of 20% is too big and is
incorrectly added to line spacing, so we use a 15% adjustment instead
and add it to the ascent.

• WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):

Changed default font size from 14 to 16 pixels and default fixed font
size from 14 to 13 pixels. Changed standard font from Lucida Grande to
Times, serif font from Times New Roman to Times, and sans serif font
from Lucida Grande to Helvetica. Also replaced some stray tabs with
spaces and made a few other anal-retentive formatting changes.

• WebView.subproj/WebUserAgentSpoofTable.c: (hash): (_web_findSpoofTableEntry):
• WebView.subproj/WebUserAgentSpoofTable.gperf:

No longer spoof as Windows MSIE for abcnews.go.com since we've also
changed the default font size.

WebBrowser:

Reviewed by Maciej.

• English.lproj/StringsNotToBeLocalized.txt:

Updated for recent changes.

6:59 PM Changeset in webkit [4202] by rjw

• 22 edits in trunk

WebCore:

API changes from final review meeting.

goBackOrForwardToItem: -> goToBackForwardItem:
drop "Window" from WebUIDelegate method names.
WebElementIsSelectedTextKey -> WebElementIsSelectedKey
Cross-frame searchFor on WebView now public.

Reviewed by Chris.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm:

WebKit:

API changes from final review meeting.

goBackOrForwardToItem: -> goToBackForwardItem:
drop "Window" from WebUIDelegate method names.
WebElementIsSelectedTextKey -> WebElementIsSelectedKey
Cross-frame searchFor on WebView now public.

Reviewed by Chris.

• Plugins.subproj/WebBaseNetscapePluginView.m:
• WebCoreSupport.subproj/WebBridge.m:
• WebKit.exp:
• WebView.subproj/WebDefaultContextMenuDelegate.m:
• WebView.subproj/WebDefaultUIDelegate.m:
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebHTMLViewPrivate.m:
• WebView.subproj/WebImageView.m:
• WebView.subproj/WebPolicyDelegate.h:
• WebView.subproj/WebTextView.m:
• WebView.subproj/WebUIDelegate.h:
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m:
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m:

WebBrowser:

API changes from final review meeting.

goBackOrForwardToItem: -> goToBackForwardItem:
drop "Window" from WebUIDelegate method names.
WebElementIsSelectedTextKey -> WebElementIsSelectedKey
Cross-frame searchFor on WebView now public.

Reviewed by Chris.

• BrowserDocument.m:
• BrowserWebController.m:
• ContextMenuHandler.m:
• FindPanelController.m:

Tests:

Updated examples to match API changes
Added zooming as an example of stringByEvaluatingJavaScriptFromString:
and custom context menus. Currently problematic because of 3242716.

• IBViewer/English.lproj/Document.nib:
• IBViewer/IBViewer.pbproj/project.pbxproj:
• PictureBrowser/Document.m:
• PictureBrowser/English.lproj/Document.nib:
• PictureBrowser/image_template.html:
• PictureBrowser/thumbnail_template.html:

5:12 PM Changeset in webkit [4201] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• re-fixed 3159076 -- turbotax.intuit.com forms have text fields instead of radio buttons

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::attach): Only set the type if JavaScript hasn't set it explicitly already.

4:01 PM Changeset in webkit [4200] by kocienda

• 3 edits
  2 adds in trunk/WebKit

WebFoundation:

Reviewed by Chris

Large reworking of NSURLResponse internals and
NSCachedURLResponse internals to move this code to
the API-approved design. Quite a bit of SPI has
shifted around as well.

• CacheLoader.subproj/NSCachedURLResponse.h: Name change: WebCacheObjectInternal -> NSCachedURLResponseInternal.

Added new init methods that conform to approved API. Removed old
initWithResponse: init method.

Also removed a host of other cache-related accessors and methods:
createdDate, setCreatedDate:, expiresDate, setExpiresDate:,
lastModifiedDate, setLastModifiedDate:, maxAgeValue, setMaxAgeValue:,
mustRevalidate, setMustRevalidate:, isExpired, age, and
freshnessLifetime. The getters have moved to SPI on NSURLResponse. The
setters have been obsoleted as there are now default values in the
case of non-HTTP responses, and the information can be derived from
the HTTP header in all cases for HTTP responses.

Removed: objectSize and setObjectSize: methods. This figure can be
derived from the length of the NSCachedURLResponse's data field.

Removed: canStoreInMemory, setCanStoreInMemory:, canStoreOnDisk, and
setCanStoreOnDisk: methods. These are obsoleted by the new
NSURLCacheStoragePolicy API construct.

• CacheLoader.subproj/NSCachedURLResponse.m:

Name change: WebCacheObjectVersion -> NSCachedURLResponseVersion.
Bumped the version number as well.

Removed instance variables used for now-obsoleted getter and setter
methods.

Added NSData, user-info NSDictionary and NSURLCacheStoragePolicy
instance variables, and added the API-approved getters for them.

Added implementation for new init methods; removed old init method
implementation.

Modified copy and coding methods accordingly.

Removed all method implementations mentioned in the
NSCachedURLResponse.h comment.

• CacheLoader.subproj/NSURLCache.m: (-[NSURLCache storeCacheObject:forKey:]): Rewrote implementation to use new NSURLCacheStoragePolicy construct in place of older canCache accessors.

• CacheLoader.subproj/NSURLCachePrivate.h: Added _cacheStatistics SPI method that used to be API but did not make the cut.

• CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _didFinishReturnCachedResponse:]): Use new API to access cache object data. (-[NSURLConnection _didFinishLoading]): Use new API to create an NSCachedURLResponse.

• CacheLoader.subproj/NSURLResponse.h: Now implements NSCopying.

• CacheLoader.subproj/NSURLResponse.m:

Bumped NSURLResponseVersion.

Removed createdTime and lastModifiedTime instance variables from
NSURLResponseInternal. Added createdDate instance variable. This is
part of the new way to track this information in responses.

Removed resourceData instance variable from NSURLResponseInternal.
This is no longer stored in the response object; it has moved to
NSCachedURLResponse.

Fixed silly retain of a static string in NSURLResponseInternal.

Updated NSURLResponseInternal dealloc and coding methods for new
instance variable set.

Added copyWithZone: method.

Removed accessors for obsoleted instance variables.

Added SPI accessor methods to NSURLResponseInternal: _createdDate,
_expiresDate, _lastModifiedDate, _maxAge, _mustRevalidate, and
_freshnessLifetime. Most of these return default values that give
objects very permissive cache constraints.

Name change: WebHTTPResponseVersion -> NSHTTPURLResponseVersion.
Bumped the value.

Added a collection of transient instance variables to
NSHTTPURLResponseInternal to track the values the HTTP response
subclass returns for _createdDate, _expiresDate, _lastModifiedDate,
_maxAge, _mustRevalidate, and _freshnessLifetime methods.

Updated NSHTTPURLResponseInternal dealloc method for new instance
variable set.

Name change in NSHTTPURLResponseInternal: setHeader: ->
setAllHeaderFields:.

Added SPI accessor methods: _createdDate, _expiresDate,
_lastModifiedDate, _maxAge, _mustRevalidate, and _freshnessLifetime
that use HTTP header information to return protocol-correct values.
Added _parseCacheControl helper method.

• CacheLoader.subproj/NSURLResponsePrivate.h:

Removed a collection of accessors having to do with cache processing
and replaced with a modified set of SPI methods which work
together with API-approved NSURLResponse and NSCachedURLResponse
designs.

• CacheLoader.subproj/WebCacheObjectPrivate.h: Removed.

• CacheLoader.subproj/WebDiskCache.m: (-[WebDiskCache storeCacheObject:forKey:]): Access NSCachedURLResponse data instance variable to determine the size of a cache object. (-[WebDiskCache removeCacheObjectForKey:]): Ditto.

• CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCache _truncateToSizeLimit]): Ditto. (-[WebMemoryCache storeCacheObject:forKey:]): Ditto.

• Downloads.subproj/NSURLDownload.m: (-[NSURLDownload _createFileIfNecessary]): _createdDate is now NSURLResponse SPI, not API.

• Misc.subproj/WebNSCalendarDateExtras.h: Modified convenience method:

+(NSTimeInterval)_web_timeIntervalFromHTTPDateString:(NSString *)string

is now

+(NSDate *)_web_dateFromHTTPDateString:(NSString *)string

• Misc.subproj/WebNSCalendarDateExtras.m: (+[NSCalendarDate _web_dateFromHTTPDateString:]): Ditto.

• Misc.subproj/WebNSStringExtras.h: Added a new method: -(BOOL)_web_hasCaseInsensitiveSubstring:(NSString *)substring;

• Misc.subproj/WebNSStringExtras.m: Ditto. (-[NSString _web_hasCaseInsensitiveSubstring:]):

• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addConditionalFieldsToHeader]): Use new _web_dateFromHTTPDateString: method.

• ProtocolHandlers.subproj/WebHTTPProtocol.h: Remove unused timeIntervalFromHTTPResponseHeader: method.

• ProtocolHandlers.subproj/WebHTTPProtocol.m: Ditto.

Modify a wide range of cache-related methods to use new API and
SPI made available by NSURLResponse and NSCachedURLResponse. In
many cases, this involved deleting code that now lives in one
of these two classes, which allows the protocol to rely more
on helpers.
(-[WebHTTPProtocol cachedResponseMustBeRevalidated]):
(-[WebHTTPProtocol _cachedResponseHasExpired]):
(-[WebHTTPProtocol HTTPResponse]):
(-[WebHTTPProtocol _cachePolicyForResponse]):
(-[WebHTTPProtocol setResponseHeader:]):

• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]): Tweaks to call new-style NSURLResponse and NSCachedURLResponse accessors.

• WebFoundation.pbproj/project.pbxproj: PB knows best.

WebKit:

Reviewed by Chris

• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): _lastModifiedDate on NSURLResponse is now SPI.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]): Ditto.

Apr 27, 2003:

6:10 PM Changeset in webkit [4199] by cblu

• 3 edits in trunk/WebKit

Improved headerdoc comments.

• Misc.subproj/WebKitErrors.h:
• WebView.subproj/WebFrameLoadDelegate.h:

Apr 25, 2003:

11:05 PM Changeset in webkit [4198] by darin

• 3 edits in trunk/JavaScriptCore

• fixed 3241344 -- REGRESSION: top of page missing on wired.com and cnn.com

Caused by the ResolveNode speedup. Roll it out until I can figure out why.

• kjs/nodes.cpp: (ResolveNode::evaluate): Go back to using evaluateReference.

9:13 PM Changeset in webkit [4197] by gramps

• 2 edits in trunk/WebKit

Backed out Richard's (hopefully) accidental checkin of our experiments
from earlier today. Otherwise many layout tests are hosed. But this
change, or something like it, will arrive soon.

Reviewed by me.

• WebCoreSupport.subproj/WebTextRenderer.m:

(-[WebTextRenderer initWithFont:usingPrinterFont:]):

6:42 PM Changeset in webkit [4196] by rjw

• 16 edits in trunk/WebKit

WebBrowser:

API changes from final review meeting.

WebView:
Added canShowMIMETypeAsHTML:

WebFrameView:
Removed scrollView
Removed isDocumentHTML

WebDataSource:
Removed isDocumentHTML

Reviewed by Chris.

• BrowserDocument.m: (-[BrowserDocument _isDocumentHTML]):
• BrowserWebViewExtras.h:
• BrowserWebViewExtras.m: (-[WebFrameView scrollView]):
• FrameProgressEntry.m: (+[FrameProgressEntry _isDocumentHTMLForDataSource:]): (-[FrameProgressEntry useSingletonChildForDisplay]):

WebKit:

API changes from final review meeting.

WebView:
Added canShowMIMETypeAsHTML:

WebFrameView:
Removed scrollView
Removed isDocumentHTML

WebDataSource:
Removed isDocumentHTML

Reviewed by Chris.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _layoutChildren]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _isDocumentHTML]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _makeDocumentView]): (-[WebFrame _setState:]): (-[WebFrame _isLoadComplete]):
• WebView.subproj/WebFrameView.h:
• WebView.subproj/WebFrameView.m: (-[WebFrameView setAllowsScrolling:]): (-[WebFrameView allowsScrolling]): (-[WebFrameView documentView]): (-[WebFrameView drawRect:]): (-[WebFrameView setFrameSize:]):
• WebView.subproj/WebFrameViewPrivate.h:
• WebView.subproj/WebFrameViewPrivate.m: (-[WebFrameView _setDocumentView:]): (-[WebFrameView _scrollView]): (-[WebFrameView _contentView]): (-[WebFrameView _verticalKeyboardScrollAmount]): (-[WebFrameView _horizontalKeyboardScrollAmount]): (-[WebFrameView _scrollToBottomLeft]): (+[WebFrameView _viewTypesAllowImageTypeOmission:]): (+[WebFrameView _canShowMIMETypeAsHTML:]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:pageWidth:]):
• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _updateMouseoverWithEvent:]):
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m: (+[WebView canShowMIMETypeAsHTML:]):

Tests:

API changes from final review meeting.

WebView:
Added canShowMIMETypeAsHTML:

WebFrameView:
Removed scrollView
Removed isDocumentHTML

WebDataSource:
Removed isDocumentHTML

Reviewed by Chris.

• SimpleViewer/DocumentController.m: (-[DocumentController webView:didReceiveTitle:forFrame:]):

6:24 PM Changeset in webkit [4195] by cblu

• 16 edits
  3 deletes in trunk/WebKit

WebFoundation:

Renamed WebDownload to NSURLDownload and moved it to WebFoundation.

Reviewed by rjw.

• Downloads.subproj/NSBinHexDecoder.h: Added.
• Downloads.subproj/NSBinHexDecoder.m: Added. (-[NSBinHexDecoder decodeIntoBuffer:size:]): (-[NSBinHexDecoder pumpCRCTwice]): (-[NSBinHexDecoder decodeAllIntoBuffer:size:]): (-[NSBinHexDecoder decodeHeader]): (-[NSBinHexDecoder setUpSourceForData:]): (-[NSBinHexDecoder decodeForkWithData:count:CRCCheckFlag:]): (+[NSBinHexDecoder canDecodeHeaderData:]): (-[NSBinHexDecoder decodeData:dataForkData:resourceForkData:]): (-[NSBinHexDecoder finishDecoding]): (-[NSBinHexDecoder fileAttributes]): (-[NSBinHexDecoder filename]):
• Downloads.subproj/NSGZipDecoder.h: Added.
• Downloads.subproj/NSGZipDecoder.m: Added. (+[NSGZipDecoder decodeHeader:headerLength:modificationTime:filename:]): (+[NSGZipDecoder canDecodeHeaderData:]): (-[NSGZipDecoder init]): (-[NSGZipDecoder dealloc]): (-[NSGZipDecoder decodeData:dataForkData:resourceForkData:]): (-[NSGZipDecoder finishDecoding]): (-[NSGZipDecoder fileAttributes]): (-[NSGZipDecoder filename]):
• Downloads.subproj/NSMacBinaryDecoder.h: Added.
• Downloads.subproj/NSMacBinaryDecoder.m: Added. (+[NSMacBinaryDecoder canDecodeHeaderData:]): (-[NSMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[NSMacBinaryDecoder finishDecoding]): (-[NSMacBinaryDecoder fileAttributes]): (-[NSMacBinaryDecoder filename]): (CRC16):
• Downloads.subproj/NSURLDownload.h: Added.
• Downloads.subproj/NSURLDownload.m: Added. (+[NSURLDownloadPrivate initialize]): (-[NSURLDownloadPrivate dealloc]): (-[NSURLDownload initWithRequest:]): (-[NSURLDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[NSURLDownload _downloadWithLoadingResource:request:response:delegate:proxy:]): (-[NSURLDownload dealloc]): (-[NSURLDownload loadWithDelegate:]): (-[NSURLDownload cancel]): (-[NSURLDownload path]): (-[NSURLDownload setPath:]): (-[NSURLDownload _downloadStarted]): (-[NSURLDownload _downloadEnded]): (-[NSURLDownload _setRequest:]): (-[NSURLDownload _setResponse:]): (-[NSURLDownload connection:willSendRequest:redirectResponse:]): (-[NSURLDownload connection:didReceiveResponse:]): (-[NSURLDownload connection:didReceiveData:]): (-[NSURLDownload connectionDidFinishLoading:]): (-[NSURLDownload connection:didFailLoadingWithError:]): (-[NSURLDownload _pathWithUniqueFilenameForPath:]): (-[NSURLDownload _createFSRefForPath:]): (-[NSURLDownload _createFileIfNecessary]): (-[NSURLDownload _decodeHeaderData:dataForkData:resourceForkData:]): (-[NSURLDownload _decodeData:dataForkData:resourceForkData:]): (-[NSURLDownload _decodeData:]): (-[NSURLDownload _dataIfDoneBufferingData:]): (-[NSURLDownload _finishDecoding]): (-[NSURLDownload _writeForkData:isDataFork:]): (-[NSURLDownload _writeDataForkData:resourceForkData:]): (-[NSURLDownload _isFileClosed]): (-[NSURLDownload _didCloseFile:]): (-[NSURLDownload _closeForkAsync:]): (-[NSURLDownload _closeForkSync:]): (-[NSURLDownload _closeFileAsync]): (-[NSURLDownload _closeFileSync]): (-[NSURLDownload _didDeleteFile]): (-[NSURLDownload _deleteFileAsnyc]): (-[NSURLDownload _closeAndDeleteFileAsync]): (-[NSURLDownload _cancelWithError:]): (-[NSURLDownload _cancelWithErrorCode:]): (-[NSURLDownload _setPath:]): (-[NSURLDownload _setDirectoryPath:]): (-[NSURLDownload _currentPath]): (-[NSURLDownload _errorWithCode:]): (-[NSURLDownload _dataForkReferenceNumber]): (-[NSURLDownload _setDataForkReferenceNumber:]): (-[NSURLDownload _resourceForkReferenceNumber]): (-[NSURLDownload _setResourceForkReferenceNumber:]): (-[NSURLDownload _areWritesCancelled]): (-[NSURLDownload _setWritesCancelled:]): (-[NSURLDownload _encounteredCloseError]): (-[NSURLDownload _setEncounteredCloseError:]): (-[NSURLConnectionDelegateProxy setDelegate:]): (-[NSURLConnectionDelegateProxy connection:willSendRequest:redirectResponse:]): (-[NSURLConnectionDelegateProxy connection:didReceiveResponse:]): (-[NSURLConnectionDelegateProxy connection:didReceiveData:]): (-[NSURLConnectionDelegateProxy connectionDidFinishLoading:]): (-[NSURLConnectionDelegateProxy connection:didFailLoadingWithError:]): (WriteCompletionCallback): (CloseCompletionCallback): (DeleteCompletionCallback):
• Downloads.subproj/NSURLDownloadDecoder.h: Added.
• Downloads.subproj/NSURLDownloadPrivate.h: Added.
• English.lproj/Localizable.strings:
• English.lproj/StringsNotToBeLocalized.txt:
• Misc.subproj/WebFoundation.h:
• Misc.subproj/WebNSErrorConstants.h:
• Misc.subproj/WebNSErrorExtras.m: (WebNSErrorExtrasInit):
• Misc.subproj/WebNSFileManagerExtras.h:
• Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_noteFileChangedAtPath:]):
• WebFoundation-base.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Renamed WebDownload to NSURLDownload and moved it to WebFoundation.

Reviewed by rjw.

• Downloads.subproj/WebBinHexDecoder.h: Removed.
• Downloads.subproj/WebBinHexDecoder.m: Removed.
• Downloads.subproj/WebDownload.h: Removed.
• Downloads.subproj/WebDownload.m: Removed.
• Downloads.subproj/WebDownloadDecoder.h: Removed.
• Downloads.subproj/WebDownloadPrivate.h: Removed.
• Downloads.subproj/WebGZipDecoder.h: Removed.
• Downloads.subproj/WebGZipDecoder.m: Removed.
• Downloads.subproj/WebMacBinaryDecoder.h: Removed.
• Downloads.subproj/WebMacBinaryDecoder.m: Removed.
• Downloads.subproj/crc16.h: Removed.
• Downloads.subproj/crc16.m: Removed.
• English.lproj/Localizable.strings:
• English.lproj/StringsNotToBeLocalized.txt:
• Misc.subproj/WebKit.h:
• Misc.subproj/WebKitErrors.h:
• Misc.subproj/WebKitErrors.m: (-[NSError _initWithPluginErrorCode:contentURLString:pluginPageURLString:pluginName:MIMEType:]): (registerErrors):
• Misc.subproj/WebNSWorkspaceExtras.h: Removed.
• Misc.subproj/WebNSWorkspaceExtras.m: Removed.
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.m:
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient continueAfterContentPolicy:response:]):
• WebView.subproj/WebView.h:
• WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]):

WebBrowser:

Renamed WebDownload to NSURLDownload and moved it to WebFoundation.

Reviewed by rjw.

• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor download:didStartFromRequest:]): (-[DownloadMonitor download:didReceiveResponse:]): (-[DownloadMonitor download:decidePathWithListener:suggestedFilename:]): (-[DownloadMonitor download:didReceiveDataOfLength:]): (-[DownloadMonitor downloadShouldDecodeEncodedFile:]): (-[DownloadMonitor download:didCreateFileAtPath:]): (-[DownloadMonitor downloadDidFinishDownloading:]): (-[DownloadMonitor download:didFailDownloadingWithError:]): (-[DownloadMonitor cancelDownload:withError:]): (-[DownloadMonitor setEntry:forReloadingDownload:]):
• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (-[DownloadProgressEntry _setDownload:]): (-[DownloadProgressEntry reload]):
• WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]):

4:21 PM Changeset in webkit [4194] by rjw

• 2 edits in trunk/WebKit

Final API review changes.

parent -> parentFrame
children -> childFrames

Reviewed by Chris.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setPrinting:pageWidth:]):

4:17 PM Changeset in webkit [4193] by rjw

• 2 edits in trunk/WebKit

Final API review changes.

parent -> parentFrame
children -> childFrames

Reviewed by Chris.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): (-[WebBridge frameDetached]):

3:55 PM Changeset in webkit [4192] by rjw

• 9 edits in trunk/WebKit

WebKit:

Final API review changes.

WebFrame:
parent -> parentFrame
children -> childFrames
loadString:baseURL: -> loadHTMLString:baseURL:
laodData:encodingName:baseURL: -> loadData:MIMEType:textEncodingName:baseURL:

Reviewed by Chris.

• WebView.subproj/WebDataProtocol.h:
• WebView.subproj/WebDataProtocol.m: (-[WebDataRequestParameters dealloc]): (-[NSURLRequest _webDataRequestMIMEType]): (-[NSURLRequest _webDataRequestSetMIMEType:]): (-[WebDataProtocol startLoading]):
• WebView.subproj/WebDataSource.m: (-[WebDataSource isLoading]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _recursiveStopLoading]): (-[WebDataSource _layoutChildren]): (-[WebDataSource _defersCallbacksChanged]):
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m: (-[WebFrame loadHTMLString:baseURL:]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame childFrames]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem]): (-[WebFrame _descendantFrameNamed:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]): (+[WebFrame _recursiveCheckCompleteFromFrame:]): (-[WebFrame _textSizeMultiplierChanged]): (-[WebFrame _viewWillMoveToHostWindow:]): (-[WebFrame _viewDidMoveToHostWindow]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _loadDataSource:withLoadType:formState:]):
• WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate _clearControllerReferences:]): (-[WebView _frameForDataSource:fromFrame:]): (-[WebView _frameForView:fromFrame:]):

WebBrowser:

Final API review changes.

WebFrame:
parent -> parentFrame
children -> childFrames
loadString:baseURL: -> loadHTMLString:baseURL:
laodData:encodingName:baseURL: -> loadData:MIMEType:textEncodingName:baseURL:

Reviewed by Chris.

• BrowserWebController.m: (-[BrowserWebController _closeDataSources:]):
• BrowserWebFrameExtras.m: (-[WebFrame _topFrame]):
• BrowserWebViewExtras.m: (-[WebFrameView largestScrollableWebView]):
• Debug/SnippetController.m: (-[SnippetController load]):
• LoadProgressMonitor.m: (-[LoadProgressMonitor _monitorProvisionalDataSourceForFrame:]): (-[LoadProgressMonitor titleChangedForFrame:]):

Tests:

Final API review changes.

WebFrame:
parent -> parentFrame
children -> childFrames
loadString:baseURL: -> loadHTMLString:baseURL:
laodData:encodingName:baseURL: -> loadData:MIMEType:textEncodingName:baseURL:

Reviewed by Chris.

• PictureBrowser/Document.m: (-[Document readFromFile:ofType:]):
• SnippetEditor/SnippetController.m: (-[SnippetController updateFromText:]):

3:47 PM Changeset in webkit [4191] by darin

• 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• a couple improvements that give a 6.6% speedup on iBench JavaScript

• kjs/nodes.cpp: (ResolveNode::evaluate): Don't use evaluateReference.

• kjs/object.cpp: (ObjectImp::get): Do the prototype work with the ValueImp, not a wrapper. Contributes a tiny bit to the speedup, but cleaner anyway. (ObjectImp::hasProperty): Same thing here.

3:07 PM Changeset in webkit [4190] by cblu

• 2 edits in trunk/WebKit

WebKit:

Don't do "@class WebDataSource" as that class isn't mentioned in this file.

• WebView.subproj/WebFrameLoadDelegate.h:

WebBrowser:

Do "@class WebDataSource" as that class is mentioned in this file.

• LocationChangeError.h:

2:55 PM Changeset in webkit [4189] by cblu

• 20 edits
  3 deletes in trunk/WebKit

Tests:

Turned WebLocationChangeDelegate into WebFrameLoadDelegate. Renamed WebFrameLoadDelegate all methods to pass a frame instead of the data source.

Reviewed by rjw.

• DumpBackForward/main.m: (main): (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): (-[WaitUntilDoneDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]): (-[WaitUntilDoneDelegate webView:didFailLoadWithError:forFrame:]):
• DumpRenderTree/main.m: (main): (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): (-[WaitUntilDoneDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]): (-[WaitUntilDoneDelegate webView:didFailLoadWithError:forFrame:]):
• IBViewer/DocumentController.m: (-[DocumentController webView:didStartProvisionalLoadForFrame:]): (-[DocumentController webView:didReceiveTitle:forFrame:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:didFailProvisionalLoadWithError:forFrame:]): (-[DocumentController webView:didFinishLoadForFrame:]): (-[DocumentController webView:didFailLoadWithError:forFrame:]):
• PDFViewer/DocumentController.m: (-[DocumentController webView:didStartProvisionalLoadForFrame:]): (-[DocumentController webView:didReceiveTitle:forFrame:]): (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:didFailProvisionalLoadWithError:forFrame:]): (-[DocumentController webView:didFinishLoadForFrame:]): (-[DocumentController webView:didFailLoadWithError:forFrame:]):
• PictureBrowser/Document.m: (-[Document webView:didStartProvisionalLoadForFrame:]): (-[Document webView:locationChangeDone:forDataSource:]): (-[Document webView:didFailProvisionalLoadWithError:forFrame:]): (-[Document webView:didFinishLoadForFrame:]): (-[Document webView:didFailLoadWithError:forFrame:]):
• SimpleViewer/DocumentController.m: (-[DocumentController webView:didStartProvisionalLoadForFrame:]): (-[DocumentController webView:didReceiveTitle:forFrame:]): (-[DocumentController webView:didFailProvisionalLoadWithError:forFrame:]): (-[DocumentController webView:didFinishLoadForFrame:]): (-[DocumentController webView:didFailLoadWithError:forFrame:]):
• SnippetEditor/SnippetController.m: (-[SnippetController updateFromURL:]): (-[SnippetController webView:didReceiveTitle:forFrame:]): (-[SnippetController webView:didFailProvisionalLoadWithError:forFrame:]): (-[SnippetController webView:didFinishLoadForFrame:]): (-[SnippetController webView:didFailLoadWithError:forFrame:]):

WebKit:

Turned WebLocationChangeDelegate into WebFrameLoadDelegate. Renamed WebFrameLoadDelegate all methods to pass a frame instead of the data source.

Reviewed by rjw.

• English.lproj/Localizable.strings:
• Misc.subproj/WebKit.h:
• Misc.subproj/WebKitErrors.h:
• Misc.subproj/WebKitErrors.m: (registerErrors):
• WebCoreSupport.subproj/WebBridge.m:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _updateIconDatabaseWithURL:]):
• WebView.subproj/WebDefaultFrameLoadDelegate.h: Added.
• WebView.subproj/WebDefaultFrameLoadDelegate.m: Added. (+[WebDefaultFrameLoadDelegate sharedFrameLoadDelegate]): (-[WebDefaultFrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[WebDefaultFrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[WebDefaultFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[WebDefaultFrameLoadDelegate webView:didCommitLoadForFrame:]): (-[WebDefaultFrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[WebDefaultFrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[WebDefaultFrameLoadDelegate webView:didFinishLoadForFrame:]): (-[WebDefaultFrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[WebDefaultFrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[WebDefaultFrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[WebDefaultFrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[WebDefaultFrameLoadDelegate webView:willCloseFrame:]):
• WebView.subproj/WebDefaultLocationChangeDelegate.h: Removed.
• WebView.subproj/WebDefaultLocationChangeDelegate.m: Removed.
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFrameLoadDelegate.h: Added.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _closeOldDataSources]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _isLoadComplete]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:]): (-[WebFrame _clientRedirectCancelled]):
• WebView.subproj/WebLocationChangeDelegate.h: Removed.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient interruptForPolicyChangeError]):
• WebView.subproj/WebPolicyDelegate.h:
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m: (-[WebView setFrameLoadDelegate:]): (-[WebView frameLoadDelegate]):
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate dealloc]): (-[WebView _frameLoadDelegateForwarder]):

WebBrowser:

Turned WebLocationChangeDelegate into WebFrameLoadDelegate. Renamed WebFrameLoadDelegate all methods to pass a frame instead of the data source.

Reviewed by rjw.

• BrowserNSErrorExtras.m: (-[NSError isPolicyChangeError]):
• BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController close]):
• Debug/SnippetController.m: (-[SnippetController load]): (-[SnippetController webView:didFinishLoadForFrame:]): (-[SnippetController webView:didReceiveTitle:forFrame:]):
• LocationChangeHandler.h:
• LocationChangeHandler.m: (-[LocationChangeHandler webView:didStartProvisionalLoadForFrame:]): (-[LocationChangeHandler webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[LocationChangeHandler webView:didCommitLoadForFrame:]): (-[LocationChangeHandler webView:didReceiveTitle:forFrame:]): (-[LocationChangeHandler webView:didReceiveIcon:forFrame:]): (-[LocationChangeHandler webView:didFailProvisionalLoadWithError:forFrame:]): (-[LocationChangeHandler webView:didFinishLoadForFrame:]): (-[LocationChangeHandler webView:didFailLoadWithError:forFrame:]): (-[LocationChangeHandler webView:didChangeLocationWithinPageForFrame:]): (-[LocationChangeHandler webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[LocationChangeHandler webView:didCancelClientRedirectForFrame:]): (-[LocationChangeHandler webView:willCloseFrame:]):

2:51 PM Changeset in webkit [4188] by darin

• 5 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• move from linear probing to double hashing, gives an 0.7% speedup in iBench JavaScript

• kjs/property_map.h: Remove the hash function.
• kjs/property_map.cpp: Added statistics for rehashes and removes. Moved from linear probing to double hashing, using the hash modulo (table size minus one) plus one for the probing distance.

• kjs/ustring.h: Use unsigned instead of int for hash function result.

2:14 PM Changeset in webkit [4187] by hyatt

• 16 edits
  3 adds in trunk/WebCore

Part two of the overflow patch. This adds the scrollbars and
patches the layers code, but it doesn't yet turn on the
overflow:auto capability.

Reviewed by mjs/gramps

• ForwardingHeaders/qscrollbar.h: Added.
• WebCore.pbproj/project.pbxproj:
• khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): (DOMNode::putValue):
• khtml/ecma/kjs_dom.h:
• khtml/ecma/kjs_dom.lut.h:
• khtml/rendering/render_box.cpp: (RenderBox::contentWidth): (RenderBox::repaintRectangle): (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteVertical): (RenderBox::lowestPosition):
• khtml/rendering/render_layer.cpp: (RenderScrollMediator::slotValueChanged): (RenderLayer::RenderLayer): (RenderLayer::~RenderLayer): (RenderLayer::updateLayerPosition): (RenderLayer::scrollOffset): (RenderLayer::subtractScrollOffset): (RenderLayer::scrollToOffset): (RenderLayer::updateScrollPositionFromScrollbars): (RenderLayer::setHasHorizontalScrollbar): (RenderLayer::setHasVerticalScrollbar): (RenderLayer::verticalScrollbarWidth): (RenderLayer::horizontalScrollbarHeight): (RenderLayer::moveScrollbarsAside): (RenderLayer::positionScrollbars): (RenderLayer::checkScrollbarsAfterLayout): (RenderLayer::paintScrollbars): (RenderLayer::paint): (RenderLayer::nodeAtPoint):
• khtml/rendering/render_layer.h:
• khtml/rendering/render_object.cpp: (RenderObject::clientWidth): (RenderObject::clientHeight): (RenderObject::scrollWidth): (RenderObject::scrollHeight): (RenderObject::nodeAtPoint):
• khtml/rendering/render_object.h:
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget):
• kwq/KWQNamespace.h:
• kwq/KWQScrollBar.h: Added.
• kwq/KWQScrollBar.mm: Added. (-[KWQScrollBar initWithQScrollBar:]): (-[KWQScrollBar scroll:]): (:m_valueChanged): (QScrollBar::~QScrollBar): (QScrollBar::setValue): (QScrollBar::setSteps): (QScrollBar::setKnobProportion): (QScrollBar::scrollbarHit): (QScrollBar::valueChanged):
• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):

1:23 PM Changeset in webkit [4186] by sullivan

• 2 edits in trunk/WebKit

• fixed 3240676 -- REGRESSION: Using old Safari then new one erases history

Reviewed by Darin.

• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): The new code to use a synchronous NSURLConnection to read the property list file did not take into account the two possible formats of the file (NSArray or NSDictionary), so reading old-style history files was completely broken. While in here, I distributed the variable declarations to first use.

Apr 24, 2003:

10:10 PM Changeset in webkit [4185] by mjs

• 2 edits in trunk/WebKit

Fixed build.

• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels setUsesStandardAuthenticationPanel:]):

9:22 PM Changeset in webkit [4184] by mjs

• 1 edit in trunk/WebKit/ChangeLog

WebFoundation:

Reviewed by Ken.

Updated NSURLCredentialStorage to match proposed API (except
authentication handlers, that remains to be fixed).

• AuthenticationManager.subproj/NSURLCredentialStorage.h:
• AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage init]): (initSharedURLCredentialStorage): (initCredentialStorage): (+[NSURLCredentialStorage sharedURLCredentialStorage]): (-[NSURLCredentialStorage setCredential:forProtectionSpace:]):
• AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _sendChangeNotification]):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]): (-[WebCFNetworkHTTPProtocol stopLoading]): (-[WebCFNetworkHTTPProtocol performHTTPHeaderRead:andCall:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (+[WebSimpleHTTPProtocol canInitWithRequest:]):

WebKit:

Reviewed by Ken.

Updated for auth API changes.

• Panels.subproj/WebStandardPanels.m: (-[WebStandardPanels setUsesStandardAuthenticationPanel:]):

WebBrowser:

Reviewed by Ken.

Updated for auth API changes.

• AppController.m: (-[AppController removeAllCredentials]):
• FormCompletionController.m: (+[FormCompletionController _frame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): (+[FormCompletionController _credentialMatchesForString:frame:]):
• Preferences.subproj/PasswordsEditor.m: (-[PasswordsEditor resetCredentials]): (-[PasswordsEditor startMonitoringCredentials]): (-[PasswordsEditor stopMonitoringCredentials]): (-[PasswordsEditor removeSelectedItems:]):

8:26 PM Changeset in webkit [4183] by rjw

• 23 edits
  4 deletes in trunk/WebKit

WebKit:

Final API review changes.

Renamed WebWindowOperationsDelegate to WebUIDelegate.
Merged WebContextMenuDelegate into WebUIDelegate.
Fixed crasher if history file doesn't exist.

Reviewed by Ken.

• History.subproj/WebHistory.h:
• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
• Misc.subproj/WebKit.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView status:]):
• Plugins.subproj/WebPluginController.m: (-[WebPluginController showStatus:]):
• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge showWindow]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge windowFrame]): (-[WebBridge setWindowContentRect:]): (-[WebBridge windowContentRect]): (-[WebBridge setWindowIsResizable:]): (-[WebBridge windowIsResizable]): (-[WebBridge firstResponder]): (-[WebBridge makeFirstResponder:]): (-[WebBridge closeWindow]): (-[WebBridge runJavaScriptAlertPanelWithMessage:]): (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebBridge setStatusText:]): (-[WebBridge focusWindow]):
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebContextMenuDelegate.h: Removed.
• WebView.subproj/WebDefaultContextMenuDelegate.h:
• WebView.subproj/WebDefaultContextMenuDelegate.m:
• WebView.subproj/WebDefaultUIDelegate.h:
• WebView.subproj/WebDefaultUIDelegate.m: (+[WebDefaultUIDelegate sharedUIDelegate]): (-[WebDefaultUIDelegate dealloc]):
• WebView.subproj/WebDefaultWindowOperationsDelegate.h: Removed.
• WebView.subproj/WebDefaultWindowOperationsDelegate.m: Removed.
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
• WebView.subproj/WebFrameView.m:
• WebView.subproj/WebHTMLViewPrivate.m:
• WebView.subproj/WebUIDelegate.h:
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m: (-[WebView setUIDelegate:]): (-[WebView UIDelegate]): (-[WebView downloadDelegate]):
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebView _openNewWindowWithRequest:]): (-[WebView _menuForElement:]): (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView _UIDelegateForwarder]):
• WebView.subproj/WebWindowOperationsDelegate.h: Removed.

WebBrowser:

Final API review changes.

Renamed WebWindowOperationsDelegate to WebUIDelegate.
Merged WebContextMenuDelegate into WebUIDelegate.

Reviewed by Ken.

• BrowserDocument.h:
• BrowserDocument.m:
• BrowserWebController.h:
• BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController dealloc]): (-[BrowserWebController close]):
• ContextMenuHandler.h: Removed.
• ContextMenuHandler.m:
• WebBrowser.pbproj/project.pbxproj:

Tests:

Final API review changes.

Renamed WebWindowOperationsDelegate to WebUIDelegate.
Merged WebContextMenuDelegate into WebUIDelegate.

Reviewed by Ken.

• ChangeLog:
• DumpBackForward/main.m: (main):
• SimpleViewer/DocumentController.m: (-[DocumentController loadURL:]):

6:32 PM Changeset in webkit [4182] by hyatt

• 21 edits in trunk/WebCore

Rename inQuirksMode to inCompatMode. Drop uses of it in
the render tree code in favor of style()->htmlHacks().

Remove dead code in the parser dealing with discarded attributes.

Optimize bidi run justification by adding a guard.

Fix :target to not match :root when no fragment ID is specified.

Reviewed by mjs/gramps

• khtml/css/cssstyleselector.cpp:
• khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute):
• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::setStyleSheet): (HTMLStyleElementImpl::childrenChanged):
• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::createSharedCellDecls):
• khtml/html/htmlparser.cpp: (KHTMLParser::~KHTMLParser): (KHTMLParser::reset): (KHTMLParser::parseToken): (KHTMLParser::insertNode):
• khtml/html/htmlparser.h:
• khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):
• khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
• khtml/rendering/bidi.cpp:
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_flow.cpp: (RenderFlow::paintLineBoxDecorations): (RenderFlow::repaint):
• khtml/rendering/render_inline.cpp:
• khtml/rendering/render_inline.h:
• khtml/rendering/render_list.cpp: (getParentOfFirstLineBox):
• khtml/rendering/render_object.cpp: (RenderObject::createObject):
• khtml/rendering/render_text.cpp: (RenderText::paintObject):
• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle): (DocumentImpl::recalcStyleSelector):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_elementimpl.cpp: (ElementImpl::createDecl):

6:24 PM Changeset in webkit [4181] by rjw

• 3 edits in trunk/WebKit

WebKit:

Final API review changes.

Reviewed by Chris.

• BrowserWindowController.m: (-[BrowserWindowController updateSnapBackButtons]):
• GlobalHistory.m: (-[GlobalHistory updateDisplayTitleForHistoryItem:]): (-[GlobalHistory _addHistoryEntry:toMenu:]):

WebBrowser:

Final API review changes.

• History.subproj/WebHistoryItem.h:
• History.subproj/WebHistoryItem.m: (-[WebHistoryItem setAlternateTitle:]): (-[WebHistoryItem initFromDictionaryRepresentation:]):

6:03 PM Changeset in webkit [4180] by rjw

• 10 edits in trunk/WebKit

WebKit:

Final API review changes.

Reviewed by Chris.

• History.subproj/WebBackForwardList.h:
• History.subproj/WebBackForwardList.m: (-[WebBackForwardList containsItem:]): (-[WebBackForwardList capacity]): (-[WebBackForwardList setCapacity:]): (-[WebBackForwardList _clearPageCache]): (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList _setUsesPageCache:]): (-[WebBackForwardList _usesPageCache]):
• History.subproj/WebHistory.h:
• History.subproj/WebHistory.m: (+[WebHistory optionalSharedHistory]): (+[WebHistory setOptionalSharedHistory:]): (-[WebHistory init]): (-[WebHistory loadFromURL:error:]): (-[WebHistory saveToURL:error:]):
• History.subproj/WebHistoryItemPrivate.h:
• History.subproj/WebHistoryPrivate.h:
• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate init]): (-[WebHistoryPrivate dealloc]): (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): (-[WebHistoryPrivate loadFromURL:error:]): (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]): (-[WebHistoryPrivate saveToURL:error:]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _canCachePage]): (-[WebFrame _purgePageCache]):

WebBrowser:

Final API review changes.

Reviewed by Chris.

• BrowserDocument.m: (-[BrowserDocument backListMenuForButton:]): (-[BrowserDocument forwardListMenuForButton:]):
• BrowserWebController.m: (-[BrowserWebController initWithDocument:request:frameName:]): (-[BrowserWebController clearPageCache]):
• Debug/DebugUtilities.m: (-[BrowserDocument toggleBackForwardEnabled:]): (-[BrowserDocument validate_toggleBackForwardEnabled:]): (-[WebHistory populateHistoryWithTestData:]):
• GlobalHistory.h:
• GlobalHistory.m: (+[GlobalHistory historyURL]): (-[GlobalHistory init]): (-[GlobalHistory savePendingChanges]):

5:24 PM Changeset in webkit [4179] by mjs

• 2 edits in trunk/WebKit

WebFoundation:

Reviewed by Chris.

Update Challenge API to mostly match proposal, except for the
parts that can't be done until auth handling is moved from the
authentication handler to the connection delegate.

• AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
• AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallengePrivate initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:delegate:]): (-[NSURLAuthenticationChallengePrivate dealloc]): (-[NSURLAuthenticationChallenge _initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:delegate:]): (-[NSURLAuthenticationChallenge proposedCredential]): (-[NSURLAuthenticationChallenge cancel]): (-[NSURLAuthenticationChallenge error]): (-[NSURLAuthenticationChallenge failureResponse]):
• AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage _invokeHandlersWithURL:realm:forRequest:failureCount:failureResponse:withCallback:context:]): (-[NSURLCredentialStorage _invokeHandlersWithURL:proxy:forRequest:failureCount:failureResponse:withCallback:context:]): (-[NSURLCredentialStorage _addCredentialsToRetryHTTPRequest:afterFailureResponse:nsFailureResponse:failureCount:withCallback:context:]):
• AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationHandlerDispatcher startAuthentication:]):
• AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
• AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
• AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage setDefaultCredential:forProtectionSpace:]):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]):

WebKit:

Reviewed by Chris.

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): Update for new Challenge API.

5:03 PM Changeset in webkit [4178] by cblu

• 10 edits
  2 deletes in trunk/WebKit

WebFoundation:

Renamed - [NSURLResponse suggestedFilenameForSaving] to suggestedFilename and moved it to WebFoundation.

Reviewed by mjs.

• CacheLoader.subproj/NSURLResponse.h:
• CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponse suggestedFilename]): (-[NSHTTPURLResponse suggestedFilename]):
• English.lproj/StringsNotToBeLocalized.txt:
• Misc.subproj/WebNSURLExtras.h:
• Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_suggestedFilenameWithMIMEType:]):

WebKit:

Renamed - [NSURLResponse suggestedFilenameForSaving] to suggestedFilename and moved it to WebFoundation.

Reviewed by mjs.

• Downloads.subproj/WebDownload.m: (-[WebDownload _createFileIfNecessary]):
• English.lproj/Localizable.strings:
• English.lproj/StringsNotToBeLocalized.txt:
• Misc.subproj/WebNSURLResponseExtras.h: Removed.
• Misc.subproj/WebNSURLResponseExtras.m: Removed.
• Plugins.subproj/WebNullPluginView.m: include NSError to unbreak build.
• WebKit.pbproj/project.pbxproj:

WebBrowser:

Renamed - [NSURLResponse suggestedFilenameForSaving] to suggestedFilename and moved it to WebFoundation.

Reviewed by mjs.

• BrowserDocument.m: (-[BrowserDocument displayName]):
• BrowserWebController.m:
• DownloadProgressEntry.m: (-[DownloadProgressEntry filename]):
• English.lproj/StringsNotToBeLocalized.txt:
• HTMLSourceDocument.m: (-[HTMLSourceDocument displayName]):

4:18 PM Changeset in webkit [4177] by cblu

• 12 edits
  3 deletes in trunk/WebKit

WebKit:

Removed WebPluginError and instead added fields to the userInfo of NSError for plug-in specific errors.

Reviewed by rjw.

• Misc.subproj/WebKitErrors.h:
• Misc.subproj/WebKitErrors.m: (+[NSError _webKitErrorWithCode:failingURL:]): (-[NSError _initWithPluginErrorCode:contentURLString:pluginPageURLString:pluginName:MIMEType:]):
• Misc.subproj/WebKitErrorsPrivate.h:
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]):
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m:
• Plugins.subproj/WebPlugInError.h: Removed.
• Plugins.subproj/WebPlugInError.m: Removed.
• Plugins.subproj/WebPluginErrorPrivate.h: Removed.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURLString:attributes:baseURLString:MIMEType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURLString:]):
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
• WebView.subproj/WebResourceLoadDelegate.h:

WebBrowser:

Updated WebBrowser to not use WebPlugInError.

Reviewed by rjw.

• LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):

1:27 PM Changeset in webkit [4176] by darin

• 11 edits in trunk

WebCore:

Reviewed by Chris.

• fixed 3210096 -- server identifies page as UTF-8, page identifies itself as windows-1252, server must win
• fixed 3105796 -- www.thai.com does not display with correct encoding (<body> tag in comment before <meta>)

• khtml/khtml_part.cpp: (KHTMLPart::write): Pass in an EncodingType rather than just a boolean. This lets us tell the difference between EncodingFromHTTPHeader (which wins out over an encoding in a meta tag) and DefaultEncoding (which loses). (KHTMLPart::setEncoding): Put ifdef around the whole function. We use our own version in KWQKHTMLPart instead.

• khtml/misc/decoder.h: Defined an EncodingType and changed the parameter to setEncoding to take it instead of force and 8-bit-only parameters. Store it in m_type and get rid of haveEncoding.
• khtml/misc/decoder.cpp: (Decoder::Decoder): Set m_type to DefaultEncoding. (Decoder::setEncoding): Take a type parameter, instead of force and 8-bit-only parameters. Use "eight-bit-only" mode for EncodingFromMetaTag only. Fix code so we don't clobber an existing codec if we can't find a new one in a simpler way. Store the type in m_type, rather than using the confusing "haveEncoding" flag. (skipComment): Added. Used to skip comments found in the <head> section. (Decoder::decode): Moved the check for the UTF-16 BOM out and do that check even when we have an encoding (although not if we have one the user chose). Update check so that we look for a meta tag when we have nothing except a default encoding. This fixes the bug where we have an encoding from an HTTP header; in that case we do not want to look at the meta tag. Improve performance a bit by not constructing a string just so we can append the data. Merged the APPLE_CHANGES case a bit with the original case better. Added code to skip comments; this fixes the thai.com issue. Improved the code to handle data after the first buffer full. We now avoid putting data into a QString once we are past the header. Extended an APPLE_CHANGES ifdef to exclude more code we don't need.

• kwq/KWQKHTMLPart.h: Added setEncoding and addData to replace slotData.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setEncoding): Added. Needs to be called only once and does the first-time work as well as setting up the encoding for the page. In practice it is called before each time addData is. (KWQKHTMLPart::addData): Added. Needs to be called for each run of data. Now just calls write(), but does some assertions, which is why I have not removed it and changed the bridge to call write().

• kwq/WebCoreBridge.h: Replaced the old addData:withEncoding: and addData:withOverrideEncoding: with setEncoding:userChosen: and addData:.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge setEncoding:userChosen:]): Call setEncoding on the part. (-[WebCoreBridge addData:]): Call addData on the part.

WebKit:

Reviewed by Chris.

• fixed 3210096 -- server identifies page as UTF-8, page identifies itself as windows-1252, server must win

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Change for new WebCore API. Pass the encoding in a separate setEncoding call rather than as a parameter in addData. Also don't handle default encoding here any more. Default encoding is now handled the same way all the other preferences are, in a way that works better on the WebCore side anyway; nil or empty string means use the default encoding.

11:21 AM Changeset in webkit [4175] by kocienda

• 45 edits in trunk/WebKit

top level:

Reviewed by Darin

Added a configure test for checking OS version. Used
to figure out what exports to use for WebFoundation.

• configure.in

Tests:

Reviewed by Darin

Changed WebError to NSError.

Changed call to errorDescription to localizedDescription to match
new NSError API.

Unrelated change to fix build breakage in PDFRepresentation. It seems
that WebDocumentRepresentation changed but this test was not updated.

• DumpBackForward/main.m: (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]):
• DumpRenderTree/main.m: (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]):
• PDFViewer/DocumentController.m: (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
• PDFViewer/PDFRepresentation.m: (-[PDFRepresentation receivedError:withDataSource:]): (-[PDFView menuForEvent:]): (-[PDFView viewWillMoveToHostWindow:]): (-[PDFView viewDidMoveToHostWindow]):
• SimpleViewer/DocumentController.m: (-[DocumentController webView:locationChangeDone:forDataSource:]): (-[DocumentController webView:resource:didFailLoadingWithError:fromDataSource:]):
• SnippetEditor/SnippetController.h:
• SnippetEditor/SnippetController.m: (-[SnippetController receivedError:]): (-[SnippetController webView:locationChangeDone:forDataSource:]):

WebFoundation:

Reviewed by Darin

Changed WebError to NSError.

Removed WebFoundation.exp. File with this name is now generated and
is listed in .cvsignore.

Added build mojo to handle making the correct exports for the
framework based on whether we are running on Jaguar or Panther
(or later). If we are on Jaguar, we need to export the NSError
class we build and include in the framework. Also note that
there is build mojo that works both for our local builds and
for B&I builds.

• .cvsignore:
• AuthenticationManager.subproj/NSURLCredentialStorage.m:
• CacheLoader.subproj/NSURLConnection.h:
• CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _sendDidFailLoadingCallback]): (-[NSURLConnection _beginLoad]): (-[NSURLConnection _prepareOriginLoad]): (-[NSURLConnection _performTimeOut]): (-[NSURLConnection _wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnection _didFailWithError:]): (-[NSURLConnection _setError:]): (-[NSURLConnectionInternal URLProtocol:didFailWithError:]):
• CacheLoader.subproj/NSURLProtocol.h:
• CacheLoader.subproj/NSURLResponse.h:
• CacheLoader.subproj/NSURLResponse.m:
• CacheLoader.subproj/WebSynchronousDelegate.h:
• CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]): (-[WebSynchronousDelegate error]):
• ChangeLog:
• English.lproj/StringsNotToBeLocalized.txt:
• Makefile.am:
• Misc.subproj/NSError.h: Added.
• Misc.subproj/NSError.m: Added. (-[NSError initWithDomain:code:userInfo:]): (+[NSError errorWithDomain:code:userInfo:]): (-[NSError code]): (-[NSError domain]): (-[NSError userInfo]): (-[NSError localizedDescription]): (-[NSError description]): (-[NSError copyWithZone:]): (-[NSError encodeWithCoder:]): (-[NSError initWithCoder:]):
• Misc.subproj/WebError.h:
• Misc.subproj/WebError.m: (-[WebError errorDescription]):
• Misc.subproj/WebFoundation.h:
• Misc.subproj/WebNSErrorConstants.h: Added.
• Misc.subproj/WebNSErrorExtras.h: Added.
• Misc.subproj/WebNSErrorExtras.m: Added. (WebNSErrorExtrasInit): (+[NSError _web_addErrorsWithCodesAndDescriptions:inDomain:]): (+[NSError _web_errorWithDomain:code:failingURL:]): (-[NSError _web_initWithDomain:code:failingURL:]): (-[NSError _web_errorIsInDomain:]): (-[NSError _web_localizedDescription]): (-[NSError _web_failingURL]):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]):
• ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol startLoading]): (-[WebFTPProtocol determineErrorAndFail]): (-[WebFTPProtocol _checkDirectoryListing]):
• ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol startLoading]):
• ProtocolHandlers.subproj/WebHTTPProtocol.h:
• ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol startLoading]): (-[WebHTTPProtocol cachedResponseRevalidated]): (-[WebHTTPProtocol failWithError:]): (-[WebHTTPProtocol determineTransferEncoding]): (-[WebHTTPProtocol determineErrorAndFail]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _continueLoadingWithAddressInfo]): (-[WebSimpleHTTPProtocol hostNameResolved:]): (-[WebSimpleHTTPProtocol _processRawData]): (-[WebSimpleHTTPProtocol _handleLoadCallback]): (-[WebSimpleHTTPProtocol failWithError:]):
• WebFoundation-base.exp: Added.
• WebFoundation-jaguar.exp: Added.
• WebFoundation.exp: Removed.
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed WebError to NSError

• Downloads.subproj/WebDownload.h:
• Downloads.subproj/WebDownload.m: (-[WebDownload connection:didReceiveData:]): (-[WebDownload connectionDidFinishLoading:]): (-[WebDownload connection:didFailLoadingWithError:]): (-[WebDownload _decodeData:]): (-[WebDownload _writeDataForkData:resourceForkData:]): (-[WebDownload _didCloseFile:]): (-[WebDownload _cancelWithError:]): (-[WebDownload _errorWithCode:]): (CloseCompletionCallback):
• English.lproj/StringsNotToBeLocalized.txt:
• Misc.subproj/WebIconLoader.m: (-[WebIconLoader connection:didFailLoadingWithError:]):
• Misc.subproj/WebKitErrors.h:
• Misc.subproj/WebKitErrors.m: (+[NSError _webKitErrorWithCode:failingURL:]): (registerErrors):
• Misc.subproj/WebKitErrorsPrivate.h:
• Plugins.subproj/WebNetscapePluginRepresentation.h:
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]):
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream connection:didFailLoadingWithError:]):
• Plugins.subproj/WebPlugInError.h:
• Plugins.subproj/WebPlugInError.m:
• WebCoreSupport.subproj/WebBridge.m:
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient connection:didFailLoadingWithError:]):
• WebKit.exp:
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]): (-[WebBaseResourceHandleDelegate cancelledError]):
• WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoadingInternal]): (-[WebDataSource _setMainDocumentError:]): (-[WebDataSource _receivedError:complete:]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _mainDocumentError]):
• WebView.subproj/WebDefaultLocationChangeDelegate.m: (-[WebDefaultLocationChangeDelegate webView:locationChangeDone:forDataSource:]):
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
• WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
• WebView.subproj/WebDocument.h:
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _handleUnimplementablePolicyWithErrorCode:forURL:]):
• WebView.subproj/WebFrameView.m:
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation receivedError:withDataSource:]):
• WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation receivedError:withDataSource:]):
• WebView.subproj/WebLocationChangeDelegate.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient cancelWithError:]): (-[WebMainResourceClient interruptForPolicyChangeError]): (-[WebMainResourceClient connection:didFailLoadingWithError:]): (-[WebResourceDelegateProxy connection:didFailLoadingWithError:]):
• WebView.subproj/WebPolicyDelegate.h:
• WebView.subproj/WebResourceLoadDelegate.h:
• WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation receivedError:withDataSource:]):
• WebView.subproj/WebView.h:
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m: (-[WebView _receivedError:fromDataSource:]): (-[WebView _mainReceivedError:fromDataSource:complete:]):

WebBrowser:

Reviewed by Darin

Changed WebError to NSError.

• BrowserDocument.m:
• BrowserWebController.m: (-[BrowserWebController webView:unableToImplementPolicyWithError:frame:]): (-[BrowserWebController openURLExternallyWithRequest:inFrame:]):
• BugReportController.m: (-[BugReportController connection:didFailLoadingWithError:]):
• Debug/SnippetController.m: (-[SnippetController webView:locationChangeDone:forDataSource:]):
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]): (-[DownloadMonitor download:didFailDownloadingWithError:]): (-[DownloadMonitor cancelDownload:withError:]): (-[DownloadMonitor handleDiskCopyEvent:withReplyEvent:]):
• DownloadProgressEntry.m: (-[DownloadProgressEntry dictionaryRepresentation]): (-[DownloadProgressEntry stop]):
• DownloadRow.m:
• FrameProgressEntry.h:
• FrameProgressEntry.m: (-[FrameProgressEntry _setCommittedError:]): (-[FrameProgressEntry _setProvisionalError:]): (-[FrameProgressEntry setError:forDataSource:]): (-[FrameProgressEntry error]): (-[FrameProgressEntry URL]): (-[FrameProgressEntry _urlStringForTitle]):
• LoadProgressMonitor.h:
• LoadProgressMonitor.m: (-[LoadProgressMonitor setError:forDataSource:]): (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
• LocationChangeError.h:
• LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): (-[LocationChangeHandler specializedMessageForError:dataSource:]): (-[LocationChangeHandler genericTitleForError:]): (-[LocationChangeHandler genericMessageForError:]): (-[LocationChangeHandler displayLocationChangeError:forDataSource:]):
• LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
• ResourceProgressEntry.h:
• ResourceProgressEntry.m: (+[ResourceProgressEntry entryWithURLString:bytesLoaded:bytesExpected:error:parent:]): (-[ResourceProgressEntry initWithURLString:bytesLoaded:bytesExpected:error:parent:]): (-[ResourceProgressEntry error]): (-[ResourceProgressEntry setError:]): (-[ResourceProgressEntry stage]):
• WebBookmarkImporter.h:
• WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]): (-[WebBookmarkImporter error]):
• WebBrowser.pbproj/project.pbxproj:

11:13 AM Changeset in webkit [4174] by darin

• 19 edits
  1 delete in trunk

WebCore:

Reviewed by John.

• improved the text encoding database

• kwq/mac-encodings.txt: Changed to a new format. Now the first encoding name in every list is the "canonical" one and is in canonical case and punctuation (no longer requiring lowercase). Since the first is the one that will be used outgoing to send to servers, it's good to have that one in canonical form. All subsequent aliases in the list are now required to be all lowercase and not use any punctuation. Since the comparison is done ignoring non-alphanumeric characters, and ignoring case, this will have no effect on which encodings are recognized.

• kwq/make-charset-table.pl: Updated to enforce the new format rules.

• kwq/KWQCharsetData.c: Regenerated.

• khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Simplify the "change commas to spaces" code in a way that lets us get rid of APPLE_CHANGES. Use the official "ISO-8859-1" here instead of something almost, but not quite, like it.
• kwq/KWQKCharsets.mm: (KCharsets::codecForName): Use the official "ISO-8859-1" here instead of the unofficial "latin1". Unimportant, but cleaner this way.

• preparation for some text encoding changes to fix some bugs

• kwq/KWQKHTMLSettings.h: Added an encoding value rather than always returning a hardcoded value. Other minor cleanup.
• kwq/KWQKHTMLSettings.mm: Removed.
• WebCore.pbproj/project.pbxproj: Removed KWQKHTMLSettings.mm.

• other changes

• kwq/KWQKHTMLPart.h: Removed "using" statement. Headers must not pollute the namespace by doing "using".
• khtml/khtml_part.cpp: Added a "using" here.
• kwq/KWQPageState.mm: Added a "using" here.

• kwq/KWQString.h: Added an append that takes a const char * and length for use by the decoder.
• kwq/KWQString.mm: (QString::append): Implemented it.

• kwq/WebCoreSettings.h: Added default text encoding field and methods.
• kwq/WebCoreSettings.mm: (-[WebCoreSettings dealloc]): Release defaultTextEncoding. (-[WebCoreSettings setDefaultTextEncoding:]): Added. (-[WebCoreSettings defaultTextEncoding]): Added.

WebKit:

Reviewed by John.

• WebView.subproj/WebViewPrivate.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): Added a call to the new setDefaultTextEncoding: method in WebCore. A preparation step for some encoding bug fixes.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSuperviewObservers]): Improved a comment.

10:38 AM Changeset in webkit [4173]

• 3 copies in tags/Safari-75-1

This commit was manufactured by cvs2svn to create tag 'Safari-75-1'.

10:38 AM Changeset in webkit [4172]

• 3 copies in tags/Safari-75

This commit was manufactured by cvs2svn to create tag 'Safari-75'.

10:38 AM Changeset in webkit [4171] by sheridan

• 3 edits in trunk

Safari-76u; tree's open

10:37 AM Changeset in webkit [4170] by sheridan

• 8 edits in trunk

Safari-75 version stamp

10:19 AM Changeset in webkit [4169] by sheridan

• 3 edits in trunk

Safari-75u; tree's open

9:47 AM Changeset in webkit [4168]

• 3 copies in tags/Safari-74

This commit was manufactured by cvs2svn to create tag 'Safari-74'.

9:47 AM Changeset in webkit [4167] by sheridan

• 8 edits in trunk

Safari-74 version stamps

9:17 AM Changeset in webkit [4166] by sullivan

• 3 edits in trunk/WebCore

• fixed 3151501 -- Toggling "Check Spelling As You Type" in a textarea should affect future textareas

Reviewed by Darin

• kwq/KWQTextArea.mm: (+[KWQTextAreaTextView _setContinuousSpellCheckingEnabledForNewTextAreas:]): new method, sets a static variable and an NSUserDefault (+[KWQTextAreaTextView _isContinuousSpellCheckingEnabledForNewTextAreas]): new method, checks a static variable, reading it from an NSUserDefault the first time (-[KWQTextAreaTextView initWithFrame:textContainer:]): override designated initializer to set continuous spell checking if appropriate (-[KWQTextAreaTextView setContinuousSpellCheckingEnabled:]): call _setContinuousSpellCheckingEnabledForNewTextAreas in addition to setting the value for this object

8:00 AM Changeset in webkit [4165] by darin

• 2 edits in trunk/WebKit

Reviewed by Ken and Darin.

Fixed an authentication crashing bug that crept into the last few
changes, plus a typo.

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): Remove extra space. (-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): Store the challenge properly.