Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

May 1, 2003:

5:53 PM Changeset in webkit [4260] by hyatt

• 3 edits in trunk/WebCore

Add a cycle check when importing stylesheets to prevent
infinite loops.

Reviewed by john

• khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::init):

5:12 PM Changeset in webkit [4259] by hyatt

• 4 edits in trunk/WebCore

Table rows don't know their precise dimensions, so repainting
them fails. For now, just make an invalidation of a table
row due to CSS changes invalidate the whole table.

This is what the old Safari table code used to do prior to the
new table code landing.

Fixes bug #3205092.

Reviewed by darin/john

• khtml/rendering/render_table.cpp: (RenderTableRow::repaint):
• khtml/rendering/render_table.h:

4:30 PM Changeset in webkit [4258] by hyatt

• 3 edits in trunk/WebCore

Fix for 3232637, don't let generated parentless image content
try to do width/height/layout calculations. It will do this
all anyway, when it finally gets inserted into the rendering
tree.

Reviewed by john

• khtml/rendering/render_image.cpp: (RenderImage::setPixmap):

4:01 PM Changeset in webkit [4257] by hyatt

• 3 edits in trunk/WebCore

Fix for 3239404, a crash caused because a block-level :after
element was being inserted as generated content inside an
inline element.

The fix is to mutate the display of the generated content to
be inline when the parent of the generated content is also
inline.

Section 12.1 of the CSS2 spec (at the very end of the spec)
covers this special case. Once we do the mutation it becomes
impossible for generated content to cause a splitFlow, and so
the crash is plugged.

Reviewed by john

• khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):

3:31 PM Changeset in webkit [4256] by sullivan

• 3 edits in trunk/WebKit

• fixed 3246045 -- History items without a valid date in History.plist show up with unexpected dates in UI

Reviewed by Darin.

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]): don't set lastVisitedTimeInterval to [nil doubleValue], since this is random

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

3:13 PM Changeset in webkit [4255] by rjw

• 2 edits in branches/Safari-77~1-branch/WebKit

Merged from HEAD:

Added missing header and alphabetized.

Reviewed by Ken.

• Misc.subproj/WebKit.h:

3:11 PM Changeset in webkit [4254] by rjw

• 2 edits in trunk/WebKit

Added missing header and alphabetized.

Reviewed by Ken.

• Misc.subproj/WebKit.h:

3:10 PM Changeset in webkit [4253] by hyatt

• 9 edits in trunk/WebCore

Replace effectiveWidth and effectiveHeight with a
parameterized overflowWidth/Height, since this is much better
terminology.

Also fix event handling so that it no longer assumes (incorrectly)
that being inside the overflow rect of an object means you are
inside the object. Now there are two separate checks, with the
overflow check being used only to figure out if you should check
inside your kids.

Reviewed by darin

• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_box.cpp: (RenderBox::repaint):
• khtml/rendering/render_flow.cpp: (RenderFlow::repaint):
• khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
• khtml/rendering/render_object.h:
• khtml/rendering/render_table.h:

2:44 PM Changeset in webkit [4252] by cblu

• 6 edits in trunk/WebKit

WebKit:

Fixed: 3234888 - REGRESSION: "can't add a plug-in to a defunct WebPluginController" error, then crash
Fixed: 3226392 - REGRESSION: Safari crashed while loading Java applet at PopCap.com

Reviewed by darin.

• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame setController:]): fixed comment
• WebView.subproj/WebView.m: (-[WebView dealloc]): call [self _close]
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate dealloc]): let the WebView class clear the frames (-[WebView _close]): remove self from controller set and detach and release frame

WebBrowser:

Fixed: 3234888 - REGRESSION: "can't add a plug-in to a defunct WebPluginController" error, then crash
Fixed: 3226392 - REGRESSION: Safari crashed while loading Java applet at PopCap.com

Reviewed by darin.

• BrowserWebController.m: (-[BrowserWebController close]): call [self _close]

2:31 PM Changeset in webkit [4251] by sheridan

• 3 edits in trunk

Safari-78u versionstamp

1:39 PM Changeset in webkit [4250]

• 3 copies
  1 delete in branches/Safari-77~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-77~1-branch'.

1:39 PM Changeset in webkit [4249]

• 3 copies
  1 delete in tags/Safari-77~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-77~1-anchor'.

1:39 PM Changeset in webkit [4248]

• 3 copies
  1 delete in tags/Safari-77

This commit was manufactured by cvs2svn to create tag 'Safari-77'.

1:39 PM Changeset in webkit [4247] by sheridan

• 8 edits in trunk

Safari-77 stamp

12:19 PM Changeset in webkit [4246] by sullivan

• 2 edits in trunk/WebKit

• fixed 3245793 -- Launching Safari-75 after tip of tree erases all history

Reviewed by Chris, Don

• History.subproj/WebHistoryItem.m: keep using "lastVisitedDate" as the dictionary key, since old Safaris otherwise can't read the History file. (-[WebHistoryItem dictionaryRepresentation]): keep storing the time interval as a string, since old Safaris otherwise can't read the History file (-[WebHistoryItem initFromDictionaryRepresentation:]): read the stored date as a string and convert to a double, as we did before.

11:24 AM Changeset in webkit [4245] by hyatt

• 3 edits in trunk/WebCore

Fix for 3244157, giantrobot.com misrenders with a lot of
vertical space. Overflow heights were being miscomputed for
overflow:auto blocks.

Reviewed by gramps

• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:

9:44 AM Changeset in webkit [4244] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed 3169117 -- dragging while using a scroll wheel affects scroll movement

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSWindow nextEventMatchingMask:untilDate:inMode:dequeue:]): Just return nil when called with NSScrollWheelMask to work around the bug where any kind of event can be returned when this mask is passed. This will prevent scroll wheel events from being coalesced, but it's better than extracting events of all different types. Mouse moved events are particularly bad because they have deltaX/Y/Z and the scroll wheel code in NSScrollView treats them as if they were scroll wheel events.

9:35 AM Changeset in webkit [4243]

• 1 copy
  61 deletes in tags/WebFoundation-77~1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-77~1'.

9:35 AM Changeset in webkit [4242] by kocienda

• 4 edits in trunk/WebKit/Misc.subproj

Reviewed by Gramps

Updated copyright notices on every header and
implementation file in the framework.

9:33 AM Changeset in webkit [4241] by kocienda

• 2 edits in trunk/WebKit

Tests:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.
Note that there are some discrepancies in the
test results, but they seem to be the result
of changes in the way we handle cookie paths,
an aspect of cookies I did not change at all
with this patch. The difference must have
crept in some time ago.

• CookieManager/wkcookie-test.chk:
• CookieManager/wkcookiemanager-test.chk:
• CookieManager/wkcookiemanager-test.m: (main):

WebFoundation:

Reviewed by Darin

Updated to provide and use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-setAcceptPolicy: -> -setCookieAcceptPolicy:
-acceptPolicy -> -cookieAcceptPolicy
-cookieRequestHeaderFieldsForURL: -> -cookiesForURL:
-setCookiesFromResponseHeader:forURL:policyBaseURL: -> -setCookies:forURL:mainDocumentURL:

Added back compare: method in NSHTTPCookie. Our tests use it.

• CookieManager.subproj/NSHTTPCookie.m: (-[NSHTTPCookie compare:]):
• CookieManager.subproj/NSHTTPCookieStorage.h:
• CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _cookieRequestHeaderFieldsForURL:withExtraCookies:]): (-[NSHTTPCookieStorage _cookiesForURL:withExtraCookies:]): (-[NSHTTPCookieStorage init]): (+[NSHTTPCookieStorage sharedHTTPCookieStorage]): (-[NSHTTPCookieStorage cookiesForURL:]): (-[NSHTTPCookieStorage setCookies:forURL:mainDocumentURL:]): (-[NSHTTPCookieStorage cookieAcceptPolicy]): (-[NSHTTPCookieStorage setCookieAcceptPolicy:]):
• CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addCookieFieldToHeader]): (-[WebCFNetworkHTTPProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _parseHeaderFromData:]):

WebKit:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-acceptPolicy -> -cookieAcceptPolicy
-cookieRequestHeaderFieldsForURL: -> -cookiesForURL:
-setCookiesFromResponseHeader:forURL:policyBaseURL: -> -setCookies:forURL:mainDocumentURL:

• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): (-[WebCookieAdapter cookiesForURL:]): (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):

WebBrowser:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-setAcceptPolicy: -> -setCookieAcceptPolicy:
-acceptPolicy -> -cookieAcceptPolicy

• AppController.m: (-[AppController deleteAllCookies]):
• Preferences.subproj/AcceptedCookies.m: (-[AcceptedCookies updateCookieData]): (-[AcceptedCookies removeSelectedItems:]): (-[AcceptedCookies registerForCookieChangeNotifications]):
• Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

12:06 AM Changeset in webkit [4240] by darin

• 2 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

Apr 30, 2003:

8:52 PM Changeset in webkit [4239] by kocienda

• 8 edits in trunk/WebKit

Tests:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

• PictureBrowser/PictureBrowserProtocol.m: (-[PictureBrowserProtocol startLoading]):

WebFoundation:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

• CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _beginLoad]): (-[NSURLConnection _prepareOriginLoad]): (-[NSURLConnection _performTimeOut]): (-[NSURLConnection _wasRedirectedToRequest:redirectResponse:]):
• CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]):
• FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload setDestination:allowOverwrite:]): (-[NSURLDownload connectionDidFinishLoading:]): (-[NSURLDownload _decodeData:]): (-[NSURLDownload _writeDataForkData:resourceForkData:]): (-[NSURLDownload _errorWithCode:]): (WriteCompletionCallback): (CloseCompletionCallback):
• Misc.subproj/WebFoundation.h:
• Misc.subproj/WebNSErrorExtras.h:
• Misc.subproj/WebNSErrorExtras.m: (WebNSErrorExtrasInit):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]):
• ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol startLoading]): (-[WebFTPProtocol determineErrorAndFail]): (-[WebFTPProtocol _checkDirectoryListing]):
• ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol startLoading]):
• ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol startLoading]): (-[WebHTTPProtocol cachedResponseRevalidated]): (-[WebHTTPProtocol determineTransferEncoding]): (-[WebHTTPProtocol determineErrorAndFail]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _continueLoadingWithAddressInfo]): (-[WebSimpleHTTPProtocol hostNameResolved:]): (-[WebSimpleHTTPProtocol _processRawData]): (-[WebSimpleHTTPProtocol _handleLoadCallback]):
• WebFoundation-base.exp:
• WebFoundation.pbproj/project.pbxproj:
• Misc.subproj/WebNSErrorConstants.h: Removed

WebKit:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancelledError]):
• WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoadingInternal]):

WebBrowser:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

• BrowserNSErrorExtras.m: (-[NSError isCancelledError]):
• DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]):
• DownloadProgressEntry.m: (-[DownloadProgressEntry stop]):
• LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): (-[LocationChangeHandler specializedMessageForError:dataSource:]): (-[LocationChangeHandler displayLocationChangeError:forDataSource:]):
• LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
• ResourceProgressEntry.m: (-[ResourceProgressEntry stage]):
• WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]):

8:16 PM Changeset in webkit [4238] by kocienda

• 6 edits in trunk/WebKit

WebFoundation:

Reviewed by Richard

Add API to NSURLProtocol so that protocol implementors
can set the instance variables defined on the base NSURLRequest
class. Also modified the existing setters on NSURLRequest
by giving them leading underscores, thus marking them
more clearly as SPI.

• CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _didLoadData:]): (-[NSURLConnection _didFinishReturnCachedResponse:]): (-[NSURLConnection _didFinishLoading]): (-[NSURLConnection _didFailWithError:]):
• CacheLoader.subproj/NSURLProtocol.h:
• CacheLoader.subproj/NSURLProtocol.m: (-[NSURLProtocol setURL:inResponse:]): (-[NSURLProtocol setExpectedContentLength:inResponse:]): (-[NSURLProtocol setMIMEType:inResponse:]): (-[NSURLProtocol setTextEncodingName:inResponse:]):
• CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponse _setURL:]): (-[NSURLResponse _setExpectedContentLength:]): (-[NSURLResponse _setMIMEType:]): (-[NSURLResponse _setTextEncodingName:]):
• CacheLoader.subproj/NSURLResponsePrivate.h:
• ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoading]):
• ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]):
• ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]):
• ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol HTTPResponse]):

WebKit:

Reviewed by Richard

Use NSURLResponse new SPI methods to set instance variables.

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
• WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient loadWithRequest:]):

8:04 PM Changeset in webkit [4237] by mjs

• 2 edits in trunk/WebKit

WebFoundation:

Reviewed by Richard.

Moved NSURLProtectionSpace over to officially blessed API.

• AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator _protectionSpaceForURL:realm:]): (-[NSHTTPAuthenticator _usernameForRealm:URL:]): (-[NSHTTPAuthenticator _proxyProtectionSpaceForURL:]): (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator _setDefaultUserInfoFromURL:]): (-[NSHTTPAuthenticator _removePasswordForRealm:URL:]):
• AuthenticationManager.subproj/NSURLProtectionSpace.h:
• AuthenticationManager.subproj/NSURLProtectionSpace.m: (-[NSURLProtectionSpaceInternal dealloc]): (-[NSURLProtectionSpace _internalInit]): (-[NSURLProtectionSpace initWithHost:port:protocol:realm:authenticationMethod:]): (-[NSURLProtectionSpace initWithProxyHost:port:type:realm:authenticationMethod:]): (-[NSURLProtectionSpace dealloc]): (-[NSURLProtectionSpace realm]): (-[NSURLProtectionSpace receivesCredentialSecurely]): (-[NSURLProtectionSpace isProxy]): (-[NSURLProtectionSpace host]): (-[NSURLProtectionSpace port]): (-[NSURLProtectionSpace proxyType]): (-[NSURLProtectionSpace hash]): (-[NSURLProtectionSpace isEqual:]): (-[NSURLProtectionSpace authenticationMethod]): (-[NSURLProtectionSpace protocol]):
• AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _protectionSpaceWithKeychainItem:isDefault:]): (-[WebCredentialStorage _secProtocolForProtectionSpace:]): (-[WebCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): (-[WebCredentialStorage _addKeychainItem:]): (-[WebCredentialStorage credentialsForProtectionSpace:]): (-[WebCredentialStorage addCredential:forProtectionSpace:]): (-[WebCredentialStorage removeCredential:forProtectionSpace:]): (-[WebCredentialStorage defaultCredentialForProtectionSpace:]): (-[WebCredentialStorage setDefaultCredential:forProtectionSpace:]):

WebKit:

Reviewed by Richard.

Moved NSURLProtectionSpace over to officially blessed API.

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]):

WebBrowser:

Reviewed by Richard.

Moved NSURLProtectionSpace over to officially blessed API.

• FormCompletionController.m: (protectionSpaceFromFrame):
• Preferences.subproj/PasswordsEditor.m: (-[PasswordsEditor addressStringForCredential:]): (-[PasswordsEditor resetCredentials]):

6:56 PM Changeset in webkit [4236] by rjw

• 2 edits in trunk/WebKit

Copy MIME type when copying WebDataProtocol's parameters.

Reviewed by Ken.

• WebView.subproj/WebDataProtocol.m: (-[WebDataRequestParameters copyWithZone:]):

6:30 PM Changeset in webkit [4235] by rjw

• 3 edits in trunk/WebKit

Documentation fixes.
Added "ADVISORY NOTE" about possible API change after beta SDK.

• History.subproj/WebHistory.h:
• WebView.subproj/WebUIDelegate.h:

5:59 PM Changeset in webkit [4234] by kocienda

• 11 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej

Tweaked some HTTP-specific NSURLRequest method names as specified
in the API errata list.

• CacheLoader.subproj/NSURLRequest.h:
• CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest allHTTPHeaderFields]): (-[NSURLRequest valueForHTTPHeaderField:]): (-[NSURLRequest allowsHTTPSCertificatesWithUnknownRoots]): (-[NSURLRequest HTTPContentType]): (-[NSURLRequest HTTPReferrer]): (-[NSURLRequest HTTPUserAgent]): (-[NSMutableURLRequest setHTTPMethod:]): (-[NSMutableURLRequest setAllHTTPHeaderFields:]): (-[NSMutableURLRequest setValue:forHTTPHeaderField:]): (-[NSMutableURLRequest addValue:forHTTPHeaderField:]): (-[NSMutableURLRequest setHTTPBody:]): (-[NSMutableURLRequest setAllowsHTTPSCertificatesWithUnknownRoots:]): (-[NSMutableURLRequest setHTTPContentType:]): (-[NSMutableURLRequest setHTTPCookiePolicyBaseURL:]): (-[NSMutableURLRequest setHTTPExtraCookies:]): (-[NSMutableURLRequest setHTTPPageNotFoundCacheLifetime:]): (-[NSMutableURLRequest setHTTPReferrer:]): (-[NSMutableURLRequest setHTTPUserAgent:]):
• CacheLoader.subproj/NSURLRequestPrivate.h:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol setCertificatePolicyOnStream]): (-[WebCFNetworkHTTPProtocol addAcceptFieldsToHeader]): (-[WebCFNetworkHTTPProtocol addExtraFieldsToHeader]):
• ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol _cachedResponsePassesValidityChecks]): (-[WebHTTPProtocol _shouldAttemptOriginLoad]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]):

WebKit:

Reviewed by Maciej

Tweaked some HTTP-specific NSURLRequest method names as specified
in the API errata list.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]):
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]):

WebBrowser:

Reviewed by Maciej

Tweaked some HTTP-specific NSURLRequest method names as specified
in the API errata list.

• BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):
• LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]):

5:44 PM Changeset in webkit [4233] by hyatt

• 4 edits in trunk/WebCore

Fix for 3210725, invalid n/a selector treated as valid. This
fix also makes the CSS1 test on the test suite for forward-compatible
parsing completely pass (yay!), which was an issue on
diveintomark's list.

Reviewed by gramps

• khtml/css/parser.cpp:
• khtml/css/parser.y:

5:40 PM Changeset in webkit [4232] by mjs

• 5 edits in trunk/WebKit

Reviewed by Ken.

Minor header tweaks.

• Misc.subproj/WebDownload.h: Fix copyright notice.
• Panels.subproj/WebAuthenticationPanel.h: Added 2003 to copyright.
• WebView.subproj/WebAuthenticationChallenge.h: Fix copyright notice, add docs.
• WebView.subproj/WebAuthenticationChallengeInternal.h: Fix copyright notice.

5:27 PM Changeset in webkit [4231] by mjs

• 3 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Cut over to using the approved API mechanism for sending
challenges between the protocol and protocol
client. NSURLConnection now does the corss-thread dispatch and
NSURLAuthenticationDispatcher is obsoleted.

• AuthenticationManager.subproj/NSHTTPAuthenticator.h:
• AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSURLAuthenticationChallengeState initWithProtocol:httpRequest:challenge:callback:context:]): (-[NSURLAuthenticationChallengeState dealloc]): (-[NSHTTPAuthenticator _tryChallenge:]): (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator _askDelegateWithURL:proxy:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator addCredentialsToRetryHTTPRequest:afterFailureResponse:nsFailureResponse:failureCount:protocol:withCallback:context:]): (-[NSHTTPAuthenticator cancelAddCredentialsToRetryHTTPRequest:]): (-[NSHTTPAuthenticator addCredentialsToInitialHTTPRequest:protocol:]): (-[NSHTTPAuthenticator checkForAuthenticationFailureInHTTPResponse:withURL:]): (-[NSHTTPAuthenticator useCredential:forAuthenticationChallenge:]): (-[NSHTTPAuthenticator continueWithoutCredentialForAuthenticationChallenge:]):
• AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
• AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallengeInternal initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:]): (-[NSURLAuthenticationChallengeInternal dealloc]): (-[NSURLAuthenticationChallenge initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:]): (-[NSURLAuthenticationChallenge initWithAuthenticationChallenge:]): (-[NSURLAuthenticationChallenge dealloc]): (-[NSURLAuthenticationChallenge protectionSpace]): (-[NSURLAuthenticationChallenge proposedCredential]): (-[NSURLAuthenticationChallenge previousFailureCount]): (-[NSURLAuthenticationChallenge error]): (-[NSURLAuthenticationChallenge failureResponse]):
• AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.m: (-[NSURLConnectionAuthenticationChallenge _initWithProtocolChallenge:connection:]):
• AuthenticationManager.subproj/NSURLConnectionAuthenticationChallengeInternal.h:
• AuthenticationManager.subproj/NSURLCredentialStorage.h:
• AuthenticationManager.subproj/NSURLCredentialStorage.m:
• AuthenticationManager.subproj/WebAuthenticationHandler.h: Removed.
• AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.h: Removed.
• AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: Removed.
• AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h: Removed.
• CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection useCredential:forAuthenticationChallenge:]): (-[NSURLConnection continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLConnection _sendCallbacks]): (-[NSURLConnection _sendDidReceiveAuthenticationCallback]): (-[NSURLConnection _sendDidCancelAuthenticationCallback]): (-[NSURLConnection _performCancel]): (-[NSURLConnection _performUseCredential]): (-[NSURLConnection _performContinueWithoutCredential]): (-[NSURLConnection _didReceiveAuthenticationChallenge:]): (-[NSURLConnection _didCancelAuthenticationChallenge:]): (+[NSURLConnection _resourceLoadLoop:]): (NSURLConnectionInit): (_authenticationDone): (-[NSURLConnectionInternal prepareCallbacks]): (-[NSURLConnectionInternal URLProtocol:didReceiveAuthenticationChallenge:]): (-[NSURLConnectionInternal URLProtocol:didCancelAuthenticationChallenge:]):
• CacheLoader.subproj/NSURLProtocol.h:
• ChangeLog:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]): (-[WebCFNetworkHTTPProtocol didAddCredentials:toRequest:context:]): (-[WebCFNetworkHTTPProtocol useCredential:forAuthenticationChallenge:]): (-[WebCFNetworkHTTPProtocol continueWithoutCredentialForAuthenticationChallenge:]):
• WebFoundation-base.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin.

Fixed imports and @class directives for WebFoundation changes.

• Panels.subproj/WebAuthenticationPanel.h:
• Panels.subproj/WebAuthenticationPanel.m:

WebBrowser:

Reviewed by John.

• FileLocker.m: (-[FileLocker dealloc]): Add call to [super dealloc].

• AppController.m: (-[AppController applicationShouldOpenUntitledFile:]): Since page load test is now really part of the real application, don't FIXME it in some half-assed way. (-[AppController applicationDidFinishLaunching:]): Remove a FIXME here too.

• Test/PageLoadTestRunner.m: (+[PageLoadTestRunner shouldPerformAutomatedPageLoadTest]): Replace the load method with this method.

• TitleBarButton.m: (-[TitleBarButton startDragIfNecessaryForEvent:URL:): Removed.

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
• English.lproj/Localizable.strings: Rolled out Ken's accidental check-in. Regenerating the file just changed it back to how it was before.

5:12 PM Changeset in webkit [4230] by hyatt

• 4 edits in trunk/WebCore

Fixes for 3227983 and 3224521, both bugs involving bad letter-spacing
property values. This fixes all Movable Type blogs that had this
error in their stylesheets.

Reviewed by gramps

• khtml/css/parser.cpp:
• khtml/css/parser.y:

4:50 PM Changeset in webkit [4229] by darin

• 4 edits in trunk/WebCore

Reviewed by Maciej.

• fixed 3233819 -- MALLORY: onChange handler being called on SELECT even if selected item does not change

• kwq/KWQComboBox.h: Added _currentItem variable, updateCurrentItem function, and replaced activated function with itemSelected function.

• kwq/KWQComboBox.mm: (QComboBox::QComboBox): Call updateCurrentItem so _currentItem is up to date. (QComboBox::insertItem): Ditto. (QComboBox::clear): Ditto. (QComboBox::setCurrentItem): Ditto. (QComboBox::updateCurrentItem): Added. Returns true if current item has changed since the last time the function was called. (QComboBox::itemSelected): Only send the activate method if updateCurrentItem returns true. (-[KWQComboBoxAdapter action:]): Call itemSelected instead of calling activated directly.

4:47 PM Changeset in webkit [4228] by rjw

• 2 edits in trunk/WebKit

Fixed doc errors.

• History.subproj/WebHistory.h:

4:46 PM Changeset in webkit [4227] by mjs

• 2 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Some simple renames:

sharedURLCredentialStorage --> sharedCredentialStorage
URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:

• AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator _usernameForRealm:URL:]): (-[NSHTTPAuthenticator _applyHTTPProxyCredentials:]): (-[NSHTTPAuthenticator _applyHTTPCredentials:]): (-[NSHTTPAuthenticator _proxyUsernameForURL:]): (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:connection:withCallback:context:]): (-[NSHTTPAuthenticator _askDelegateWithURL:proxy:forRequest:failureCount:failureResponse:connection:withCallback:context:]): (-[NSHTTPAuthenticator NSURLAuthenticationChallenge:useCredential:]): (-[NSHTTPAuthenticator _setDefaultUserInfoFromURL:]): (-[NSHTTPAuthenticator _removePasswordForRealm:URL:]): (-[NSHTTPAuthenticator _removeProxyPasswordForURL:]): (-[NSHTTPAuthenticator init]):
• AuthenticationManager.subproj/NSURLCredential.h:
• AuthenticationManager.subproj/NSURLCredential.m: (+[NSURLCredential credentialWithUser:password:persistence:]):
• AuthenticationManager.subproj/NSURLCredentialStorage.h:
• AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage init]): (initSharedCredentialStorage): (initCredentialStorage): (+[NSURLCredentialStorage sharedCredentialStorage]):

WebKit:

Reviewed by Darin.

Some simple renames:

sharedURLCredentialStorage --> sharedCredentialStorage
URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):

WebBrowser:

Reviewed by Darin.

Some simple renames:

sharedURLCredentialStorage --> sharedCredentialStorage
URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:

• AppController.m: (-[AppController removeAllCredentials]):
• FormCompletionController.m: (+[FormCompletionController _frame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): (+[FormCompletionController _credentialMatchesForString:frame:]):
• Preferences.subproj/PasswordsEditor.m: (-[PasswordsEditor resetCredentials]): (-[PasswordsEditor startMonitoringCredentials]): (-[PasswordsEditor stopMonitoringCredentials]): (-[PasswordsEditor removeSelectedItems:]):

4:15 PM Changeset in webkit [4226] by mjs

• 10 edits
  3 adds in trunk/WebKit

Reviewed by Darin.

Changed things to use WebAuthenticationChallenge for
WebResoureceLoadDelegate auth callbacks.

• Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler startAuthentication:window:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]):
• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebAuthenticationChallenge.h: Added.
• WebView.subproj/WebAuthenticationChallenge.m: Added. (-[WebAuthenticationChallengeInternal initWithDelegate:]): (-[WebAuthenticationChallengeInternal dealloc]): (-[WebAuthenticationChallenge _initWithAuthenticationChallenge:delegate:]): (-[WebAuthenticationChallenge dealloc]): (-[WebAuthenticationChallenge useCredential:]): (-[WebAuthenticationChallenge cancel]): (-[WebAuthenticationChallenge continueWithoutCredential]):
• WebView.subproj/WebAuthenticationChallengeInternal.h: Added.
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate useCredential:forAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
• WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
• WebView.subproj/WebResourceLoadDelegate.h:

3:48 PM Changeset in webkit [4225] by mjs

• 4 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Converted download code to use an
NSURLDownloadAuthenticationChallenge rather than a vanilla
NSURLAuthenticationChallenge.

• AuthenticationManager.subproj/NSURLCredential.h:
• AuthenticationManager.subproj/NSURLCredential.m: (-[NSURLCredential initWithUser:password:persistence:]): (-[NSURLCredential dealloc]): (-[NSURLCredential user]): (-[NSURLCredential password]): (-[NSURLCredential hasPassword]): (-[NSURLCredential persistence]): (-[NSURLCredential description]):
• AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h:
• AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.m: Added. (-[NSURLDownloadAuthenticationChallengeInternal initWithDownload:]): (-[NSURLDownloadAuthenticationChallengeInternal dealloc]): (-[NSURLDownloadAuthenticationChallenge _initWithAuthenticationChallenge:download:]): (-[NSURLDownloadAuthenticationChallenge dealloc]): (-[NSURLDownloadAuthenticationChallenge download]):
• AuthenticationManager.subproj/NSURLDownloadAuthenticationChallengeInternal.h: Added.
• FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload connection:didReceiveAuthenticationChallenge:]): (-[NSURLDownload connection:didCancelAuthenticationChallenge:]): (-[NSURLDownload useCredential:forAuthenticationChallenge:]): (-[NSURLDownload continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLDownload _cancelWithError:]):
• WebFoundation-base.exp:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin.

Converted download code to use an
NSURLDownloadAuthenticationChallenge rather than a vanilla
NSURLAuthenticationChallenge.

• Misc.subproj/WebDownload.m: (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]):
• Panels.subproj/WebPanelAuthenticationHandler.h:
• Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler startAuthentication:window:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]):

3:41 PM Changeset in webkit [4224] by kocienda

• 2 edits in trunk/WebKit

Tests:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

• CookieManager/wkcookie-test.m: (main):
• CookieManager/wkcookiemanager-test.m: (main):

WebFoundation:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

• CookieManager.subproj/NSHTTPCookie.h:
• CookieManager.subproj/NSHTTPCookie.m: (-[NSHTTPCookie initWithDictionary:]): (-[NSHTTPCookie init]): (-[NSHTTPCookie dictionaryRepresentation]): (+[NSHTTPCookie cookieWithV0Spec:forURL:locationHeader:]): (-[NSHTTPCookie description]):
• CookieManager.subproj/NSHTTPCookiePrivate.h:
• CookieManager.subproj/NSHTTPCookieStorage.h:
• CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _readAcceptCookiesPreference]): (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): (-[NSHTTPCookieStorage init]): (-[NSHTTPCookieStorage acceptPolicy]): (-[NSHTTPCookieStorage setAcceptPolicy:]): (-[NSHTTPCookieStorage description]):
• English.lproj/StringsNotToBeLocalized.txt:
• WebFoundation-base.exp:

WebKit:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]):

WebBrowser:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

• English.lproj/Localizable.strings:
• Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

3:20 PM Changeset in webkit [4223] by cblu

• 5 edits in trunk/WebKit

WebKit:

FIXED: Clients of WebKit should have separate icon DB's

Reviewed by rjw.

• English.lproj/StringsNotToBeLocalized.txt:
• Misc.subproj/WebIconDatabase.h:
• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): If the icon db hasn't been set using the defaults, create o directory using the bundle id.
• WebKit.exp:

WebBrowser:

FIXED: Clients of WebKit should have separate icon DB's

Reviewed by rjw.

• AppController.m: (+[AppController initialize]): Moved the icon DB rename code here from WebKit. Set the icon DB path.
• Defaults.plist: Removed unused "safe MIME types" defaults
• English.lproj/StringsNotToBeLocalized.txt:

3:03 PM Changeset in webkit [4222] by rjw

• 14 edits in trunk/WebKit

WebFoundation:

Added utility _web_URLFragment.

Reviewed by Darin.

• Misc.subproj/WebNSStringExtras.h:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_URLFragment]):

WebKit:

API changes from final review meeting.

Moved view registry to WebView.
Changed WebHistoryItem to use NSTimeInterval (at least for public API).
Still creates a NSCalendarDate for compatibility. We should wean Safari
off it's use of NSCalendarDate.
Added public init method for WebHistoryItem.
Removed anchor from WebHistoryItem.
Added WebHistorySavedNotification.

Reviewed by Darin.

• History.subproj/WebHistory.m: (-[WebHistory addItemForURL:]):
• History.subproj/WebHistoryItem.h:
• History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem lastVisitedTimeInterval]): (-[WebHistoryItem anchor]): (-[WebHistoryItem _setLastVisitedTimeInterval:]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem initFromDictionaryRepresentation:]):
• History.subproj/WebHistoryItemPrivate.h:
• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate insertItem:atDateIndex:]): (-[WebHistoryPrivate removeItemForURLString:]): (-[WebHistoryPrivate addItem:]): (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]):
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m: (+[WebView registerViewClass:representationClass:forMIMEType:]):

WebBrowser:

API changes from final review meeting.

Changed WebHistoryItem to use NSTimeInterval (at least for public API).
Still creates a NSCalendarDate for compatibility. We should wean Safari
off it's use of NSCalendarDate.
Added public init method for WebHistoryItem.
Removed anchor from WebHistoryItem.

Reviewed by Darin.

• Debug/DebugUtilities.m: (-[WebHistory populateHistoryWithTestData:]):
• GlobalHistory.m: (-[GlobalHistory parentOfContentItem:]):
• WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): (-[WebBookmarkLeaf setLastVisitedDate:]): (-[WebBookmarkLeaf lastVisitedDate]):

Tests:

API changes from final review meeting.
Moved view registry to WebView.

Reviewed by Darin.

• PDFBundle/PDFView.m: (+[PDFPluginViewFactory load]):
• PDFViewer/ApplicationController.m: (-[ApplicationController awakeFromNib]):

2:49 PM Changeset in webkit [4221] by mjs

• 18 edits
  2 adds
  3 deletes in trunk/WebKit

WebFoundation:

Reviewed by Darin.

More authentication API changes. With this change, we actually
send the authentication request through the connection delegate,
which is the major structural change. Even so, some work remains
to be done.

• AuthenticationManager.subproj/NSHTTPAuthenticator.h:
• AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSURLAuthenticationChallengeState initWithConnection:httpRequest:challenge:callback:context:]): Use a connection and dispatcher, not the usual handler array. (-[NSURLAuthenticationChallengeState dealloc]): Likewise. (-[NSHTTPAuthenticator _tryChallenge:]): Likewise. (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:connection:withCallback:context:]): Renamed from _invokeHandlersWithURL... and updated. (-[NSHTTPAuthenticator _askDelegateWithURL:proxy:forRequest:failureCount:failureResponse:connection:withCallback:context:]): Likewise. (-[NSHTTPAuthenticator NSURLAuthenticationChallenge:useCredential:]): Fix cleanup - no more handlers. (-[NSHTTPAuthenticator _internalInit]): Got rid of handler stuff. (-[NSHTTPAuthenticator dealloc]): Likewise. (-[NSHTTPAuthenticator addCredentialsToRetryHTTPRequest:afterFailureResponse:nsFailureResponse:failureCount:connection:withCallback:context:]): Ask the delegate, not the handlers. (-[NSHTTPAuthenticator cancelAddCredentialsToRetryHTTPRequest:]): Likewise.

• AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
• AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
• AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallenge _useCredential:]): Semi-privatized this method, it will go for real soon but is used as a back channel by NSURLConnection for now. (-[NSURLAuthenticationChallenge _cancel]): Likewise.

• AuthenticationManager.subproj/NSURLConnectionAuthenticationChallengeInternal.h:
• AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.m: (-[NSURLConnectionAuthenticationChallenge _initWithProtocolChallenge:connection:delegate:]): Temporary private init since we still need the challenge delegate for now.

• AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h: Added.
• AuthenticationManager.subproj/NSURLProtocolAuthenticationChallenge.h: Updated.

• AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.h:
• AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: Renamed class to WebAuthenticationDispatcher. (-[WebAuthenticationDispatcher _dispatchStartAuthentication:]): Redone to use connection delegate based auth instead of using an authentication handler. (-[WebAuthenticationDispatcher _dispatchCancelAuthentication:]): Likewise. (-[WebAuthenticationDispatcher _dispatchAuthenticationDone:]): Likewise. (-[WebAuthenticationDispatcher dealloc]): Likewise. (-[WebAuthenticationDispatcher startAuthentication:]): Likewise. (-[WebAuthenticationDispatcher initWithConnection:]): New init.

• CacheLoader.subproj/NSURLConnectionPrivate.h:
• CacheLoader.subproj/NSURLConnection.h:
• CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection useCredential:forAuthenticationChallenge:]): Call challenge (for now). (-[NSURLConnection continueWithoutCredentialForAuthenticationChallenge:]): Call challenge (for now). (-[NSURLConnection _delegate]): Temporary private method so that NSHTTPAuthenticator can bypass the Protocol <--> ProtocolClient interface and call the delegate directly.

• FileTransfer.subproj/NSURLDownloadPrivate.h: Declared _init methods.
• FileTransfer.subproj/NSURLDownload.h:
• FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload _initWithLoadingResource:request:response:delegate:proxy:]): Added. (+[NSURLDownload _downloadWithLoadingConnection:request:response:delegate:proxy:]): Use corresponding _init. (-[NSURLDownload _initWithSource:delegate:directory:]): Added. (+[NSURLDownload _downloadWithSource:delegate:directory:]): Use correspoding _init. (-[NSURLDownload _sendDidBeginMessage]): Note that we sent it even if we tried but the delegate does not respond to the begin selector, to avoid failing asserts later otherwise. (-[NSURLDownload connection:didReceiveAuthenticationChallenge:]): Forward to delegate or do the default action. (-[NSURLDownload connection:didCancelAuthenticationChallenge:]): Likewise. (-[NSURLConnectionDelegateProxy respondsToSelector:]): Act like we respond only if the underlying delegate does. (-[NSURLConnectionDelegateProxy connection:didReceiveAuthenticationChallenge:]): Pass it along. (-[NSURLConnectionDelegateProxy connection:didCancelAuthenticationChallenge:]): Pass it along.
• AuthenticationManager.subproj/NSURLCredentialStorage.h: Removed authentication handler stuff.
• AuthenticationManager.subproj/NSURLCredentialStorage.m: Likewise.

WebKit:

Reviewed by Darin.

• Adjusted for authentication API change - now we expect authentication via the connection delegate, not a separate global authentication handler

• Misc.subproj/WebKit.h: Include WebDownload.h
• Misc.subproj/WebDownload.h: Added.
• Misc.subproj/WebDownload.m: Added - this new class is just like NSURLDownload but if the standard auth delegate methods are not implemented, it prompts using the standard AppKit sheet.
• Panels.subproj/WebPanelAuthenticationHandler.h:
• Panels.subproj/WebPanelAuthenticationHandler.m: (+[WebPanelAuthenticationHandler sharedHandler]): New method to get a shared handler, since we no logner register an instance with WebFoundation. (-[WebPanelAuthenticationHandler startAuthentication:window:]): Do things using the new API. (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]): Likewise.
• WebKit.exp: Export WebDownload.
• WebKit.pbproj/project.pbxproj: Add new files to build.

• Removed WebStandardPanels - this is removed from the API.

• Panels.subproj/WebStandardPanels.h: Removed.
• Panels.subproj/WebStandardPanels.m: Removed.
• Panels.subproj/WebStandardPanelsPrivate.h: Removed.
• Panels.subproj/WebAuthenticationPanel.m: Remove WebStandardPanels.h import.

• Added new resource load delegate auth methods:

• WebView.subproj/WebResourceLoadDelegate.h:

• Use WebDownload where appropriate, and remove use of WebStandardPanels:

• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Pass to resource load delegate. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Likewise. (-[WebBaseResourceHandleDelegate dealloc]): Don't track currentURL any more. (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Likewise. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Likewise. (-[WebBaseResourceHandleDelegate connection:didFailLoadingWithError:]): Likewise. (-[WebBaseResourceHandleDelegate cancelWithError:]): Likewise.
• WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): Prompt using the standard panel.

(-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
Cancel prompting using the standard panel.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Use WebDownload instead of NSURLDownload.
• WebView.subproj/WebView.h: Remove unneeded @class directives, and mention WebDownload instead of NSURLDownload.
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]): Use WebDownload instead of NSURLDownload. (-[WebView _cacheResourceLoadDelegateImplementations]): Track auth methods too.

WebBrowser:

Reviewed by Darin.

Updated for new WebKit auth API.

• AppController.m: (-[AppController awakeFromNib]): No need to register interest in standard panels.
• DownloadMonitor.m: (-[DownloadMonitor downloadWindowForAuthenticationSheet:]): Implemented this method so we can pop a sheet off the download window when reloading (yay, finally)!
• DownloadProgressEntry.m: (-[DownloadProgressEntry reload]): Use WebDownload not NSURLDownload.

2:44 PM Changeset in webkit [4220] by hyatt

• 3 edits in trunk/WebCore

Fix for the Adam Rice float/padding test on diveintomark's list
of bugs. We weren't adding in the parent's border/padding in
one case in the clearFloats function, which resulted in the
float being incorrectly positioned.

Reviewed by darin

• khtml/rendering/render_block.cpp:

11:20 AM Changeset in webkit [4219] by kocienda

• 2 edits in trunk/WebKit

Tests:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

• CookieManager/wkcookie-test.m: (DumpIFCookie): (main):
• CookieManager/wkcookiemanager-test.m: (main):

WebFoundation:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

• CookieManager.subproj/NSHTTPCookie.h:
• CookieManager.subproj/NSHTTPCookie.m: (+[NSHTTPCookie cookieWithDictionary:]): (setVersion): (setName): (setValue): (setDefaultsFromOriginURL): (setDomain): (setPath): (setSecure): (setExpires): (-[NSHTTPCookie initWithDictionary:]): (+[NSHTTPCookie cookieWithV0Spec:forURL:locationHeader:]): (+[NSHTTPCookie _cookieArrayFromResponseHeaders:forURL:]): (-[NSHTTPCookie compare:]): (-[NSHTTPCookie _compareForHeaderOrder:]):
• CookieManager.subproj/NSHTTPCookiePrivate.h:
• CookieManager.subproj/NSHTTPCookieStorage.h:
• CookieManager.subproj/NSHTTPCookieStorage.m: (acceptCookiesChanged): (setUpOnLoadThread): (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): (-[NSHTTPCookieStorage _internalInit]): (-[NSHTTPCookieStorage _cookieRequestHeaderFieldsForURL:withExtraCookies:]): (initSharedCookieManager): (+[NSHTTPCookieStorage sharedCookieManager]): (-[NSHTTPCookieStorage setCookie:]): (-[NSHTTPCookieStorage deleteCookie:]): (-[NSHTTPCookieStorage setCookiesFromResponseHeader:forURL:policyBaseURL:]):
• CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
• CookieManager.subproj/WebCookieStorage.m: (-[WebCookieStorage cookiesMatchingDomain:path:secure:]):
• CookieManager.subproj/WebCookieStorageServer.m: (-[WebCookieStorageServer _checkForCookieExpiration:]): (-[WebCookieStorageServer _saveCookies]): (-[WebCookieStorageServer _setCookiesWithoutSaving:]): (-[WebCookieStorageServer deleteCookies:]): (makeCookie):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addCookieFieldToHeader]): (-[WebCFNetworkHTTPProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _parseHeaderFromData:]):
• WebFoundation-base.exp:

WebKit:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

• WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): (-[WebCookieAdapter cookiesForURL:]): (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):

WebBrowser:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

• AppController.m: (-[AppController deleteAllCookies]):
• Preferences.subproj/AcceptedCookies.m: (compareByDomain): (compareByName): (compareByPath): (compareBySecure): (compareByExpires): (compareByContents): (-[AcceptedCookies updateCookieData]): (-[AcceptedCookies removeSelectedItems:]): (-[AcceptedCookies tableView:objectValueForTableColumn:row:]): (-[AcceptedCookies registerForCookieChangeNotifications]):
• Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):

9:17 AM Changeset in webkit [4218] by kocienda

• 4 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Changed file names for cookie-related classes.
With the exception of moving some constants
around, the contents of the files themselves
remain unchanged.

WebCookie -> NSHTTPCookie.
WebCookieManager -> NSHTTPCookieStorage.

• CookieManager.subproj/NSHTTPCookie.h:
• CookieManager.subproj/NSHTTPCookie.m:
• CookieManager.subproj/NSHTTPCookiePrivate.h:
• CookieManager.subproj/NSHTTPCookieStorage.h:
• CookieManager.subproj/NSHTTPCookieStorage.m:
• CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
• CookieManager.subproj/WebCookie.h: Removed.
• CookieManager.subproj/WebCookie.m: Removed.
• CookieManager.subproj/WebCookieManager.h: Removed.
• CookieManager.subproj/WebCookieManager.m: Removed.
• CookieManager.subproj/WebCookieManagerPrivate.h: Removed.
• CookieManager.subproj/WebCookiePrivate.h: Removed.
• CookieManager.subproj/WebCookieStorage.m:
• CookieManager.subproj/WebCookieStorageServer.m:
• Misc.subproj/WebFoundation.h:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h:
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m:
• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m:
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed file names for these classes. The contents
of the files themselves remain unchanged.

WebCookie -> NSHTTPCookie.
WebCookieManager -> NSHTTPCookieStorage.

• WebCoreSupport.subproj/WebCookieAdapter.m:
• WebView.subproj/WebMainResourceClient.m:

WebBrowser:

Reviewed by Darin

Changed file names for these classes. The contents
of the files themselves remain unchanged.

WebCookie -> NSHTTPCookie.
WebCookieManager -> NSHTTPCookieStorage.

• AppController.m:
• Preferences.subproj/AcceptedCookies.m:
• Preferences.subproj/SecurityPreferences.m:

8:22 AM Changeset in webkit [4217] by darin

• 3 edits in trunk/WebKit

Reviewed by Ken.

• make change to avoid misunderstanding that led to bug report 3179394 "Safari: Request that temp files use actual file extensions"

• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Don't put a dot between "SafariPlugInStream" and the the 6-digit unique number, so the number does not look like an extension. Also make it "WebKitPlugInStream" since this is used for other WebKit clients, and not just Safari.

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

Apr 29, 2003:

7:33 PM Changeset in webkit [4216] by hyatt

• 8 edits in trunk/WebCore

This patch fixes the following bugs:

(1) 3186174 - padding-left improperly applied to list items.
The fix is in render_list.cpp and involves adding in the
list item's border and padding so that outside markers end up
outside the border box instead of just inside the padding box.

(2) 3239571 - a stray !important after a ; causes the CSS parser
to choke. This patch adds a rule to parser.y to deal with
!importants found in between property values and to just ignore
them.

(3) 3170647 - positioned boxes with auto widths ended up adding
in their border/padding twice! Make sure that when
calcAbsoluteHorizontal in render_box.cpp examines m_maxWidth that
it subtracts out the border and padding and looks at content width.

(4) 3186165 - Negative padding values were being incorrectly
honored by Safari. A patch to css_styleselector.cpp checks to
see if the value specified by the rule is negative, and if so
the rule is not applied.

(5) 3132172 - The clip property could not be accessed via script
because the cssText routine for CSS_RECT primitive values had
not been implemented. In css_valueimpl.cpp this code has now been
filled in.

Reviewed by mjs

• khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::cssText):
• khtml/css/cssstyleselector.cpp:
• khtml/css/parser.cpp:
• khtml/css/parser.y:
• khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontal):
• khtml/rendering/render_list.cpp: (RenderListMarker::paintObject):

6:13 PM Changeset in webkit [4215] by rjw

• 3 edits in trunk/WebKit

API changes from final review meeting.
Added textEncodingName method to WebDataSource.

Reviewed by Chris.

• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m: (-[WebDataSource textEncodingName]):

5:12 PM Changeset in webkit [4214] by hyatt

• 4 edits in trunk/WebCore

Fix for 3226138, crash on canada.gc.ca. Make sure a failed
@media parse doesn't crash by adding a null check.

Reviewed by mjs

• khtml/css/parser.cpp:
• khtml/css/parser.y:

4:46 PM Changeset in webkit [4213] by hyatt

• 1 edit in trunk/WebCore/khtml/rendering/render_object.cpp

Tweaking a comment.

4:32 PM Changeset in webkit [4212] by hyatt

• 9 edits in trunk/WebCore

The remainder of the overflow:auto patch.

A minor table cell optimization has also been included.

Also fixing one of rjw's inline table bugs. Inline tables
didn't clear their minmaxwidth bool when contents inside them
changed size.

r=mjs/gramps on overflow:auto stuff
r=rjw on the table stuff

• khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute):
• khtml/rendering/render_block.cpp:
• khtml/rendering/render_block.h:
• khtml/rendering/render_layer.cpp: (RenderLayer::checkScrollbarsAfterLayout):
• khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
• khtml/rendering/render_table.cpp: (RenderTableCell::layout):
• khtml/rendering/render_table.h:

2:54 PM Changeset in webkit [4211] by cblu

• 6 edits in trunk/WebKit

Tests:

Updated to use the new NSURLDownload API.

• Downloader/MyDocument.h:
• Downloader/MyDocument.m: (-[MyDocument downloadCancel:]): (-[MyDocument savePanelDidEnd:returnCode:contextInfo:]): (-[MyDocument downloadDidBegin:]): (-[MyDocument download:didReceiveResponse:]): (-[MyDocument download:decideDestinationWithSuggestedFilename:]): (-[MyDocument download:didReceiveDataOfLength:]): (-[MyDocument download:didCreateDestination:]): (-[MyDocument downloadDidFinish:]): (-[MyDocument download:didFailWithError:]):

WebFoundation:

Updated to new NSURLDownload API.

Reviewed by rjw.

• FileTransfer.subproj/NSBinHexDecoder.m: (+[NSBinHexDecoder MIMEType]):
• FileTransfer.subproj/NSGZipDecoder.m: (+[NSGZipDecoder MIMEType]):
• FileTransfer.subproj/NSMacBinaryDecoder.m: (+[NSMacBinaryDecoder MIMEType]):
• FileTransfer.subproj/NSURLDownload.h:
• FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload initWithSource:delegate:]): (-[NSURLDownload _initWithLoadingResource:request:response:delegate:proxy:]): (+[NSURLDownload _downloadWithLoadingConnection:request:response:delegate:proxy:]): (+[NSURLDownload _downloadWithSource:delegate:directory:]): (-[NSURLDownload setDestination:allowOverwrite:]): (-[NSURLDownload source]): (-[NSURLDownload useCredential:forAuthenticationChallenge:]): (-[NSURLDownload continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLDownload _sendDidBeginMessage]): (-[NSURLDownload connection:willSendRequest:redirectResponse:]): (-[NSURLDownload connection:didReceiveResponse:]): (-[NSURLDownload connection:didReceiveData:]): (-[NSURLDownload connectionDidFinishLoading:]): (-[NSURLDownload connection:didFailLoadingWithError:]): (-[NSURLDownload _createFileIfNecessary]): (-[NSURLDownload _decodeHeaderData:dataForkData:resourceForkData:]): (-[NSURLDownload _decodeData:dataForkData:resourceForkData:]): (-[NSURLDownload _didCloseFile:]): (-[NSURLDownload _cancelWithError:]): (-[NSURLDownload _setPath:]): (-[NSURLConnectionDelegateProxy connection:didFailLoadingWithError:]):
• FileTransfer.subproj/NSURLDownloadDecoder.h:
• FileTransfer.subproj/NSURLDownloadPrivate.h:
• FileTransfer.subproj/NSURLUpload.h: Added.
• FileTransfer.subproj/NSURLUpload.m: Added. (-[NSURLUpload initWithSource:destination:delegate:]): (-[NSURLUpload useCredential:forAuthenticationChallenge:]): (-[NSURLUpload continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLUploadAuthenticationChallenge upload]):
• WebFoundation.pbproj/project.pbxproj:

WebKit:

Updated to use the new NSURLDownload API.

Reviewed by rjw.

• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):
• WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]):

WebBrowser:

Updated to use the new NSURLDownload API.

Reviewed by rjw.

• DownloadMonitor.m: (-[DownloadMonitor downloadDidBegin:]): (-[DownloadMonitor download:decideDestinationWithSuggestedFilename:]): (-[DownloadMonitor download:shouldDecodeSourceDataOfMIMEType:]): (-[DownloadMonitor download:didCreateDestination:]): (-[DownloadMonitor downloadDidFinish:]): (-[DownloadMonitor download:didFailWithError:]): (-[DownloadMonitor cancelDownload:withError:]):
• DownloadProgressEntry.m: (-[DownloadProgressEntry reload]):

2:38 PM Changeset in webkit [4210] by rjw

• 18 edits in trunk/WebKit

Added "Copyright (C) 2003 Apple Computer, Inc. All rights reserved."
to all public headers. Also made formatting consistent.

Reviewed by darin.

12:44 PM Changeset in webkit [4209] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• fixed 3234633 -- page with moderately deep tag nesting causes crash when closed (www.4strokenationals.com)

• khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::~NodeBaseImpl): Avoid recursion by using a global list of child nodes to destroy and only doing the actual destruction at the top level.

11:30 AM Changeset in webkit [4208] by darin

• 22 edits
  2 deletes in trunk/WebCore

Mostly reviewed by Ken, some bits reviewed by John.

• fixed 3188781 -- eliminate globally initialized objects from WebCore

• kwq/KWQString.h: Change QChar::null to be a char constant, and QString::null to be a const char *. In the cases where the code still compiles after these changes, everything works fine. A few cases that didn't compile are fixed below.
• kwq/KWQString.mm: Remove QString::null. (QString::mid): Return QString() instead of null.
• kwq/KWQChar.mm: Remove the definition of QChar::null.

• khtml/css/css_base.cpp: (CSSSelector::extractPseudoType): Use DOMString explicitly in one place where the code said QString::null. The trick where QString::null is really a const char * does not work in this case.
• khtml/khtml_part.cpp: (KHTMLPart::reparseConfiguration): Use QString() instead of QString::null in one place. The trick where QString::null is really a const char * does not work in this case.
• kwq/KWQKHTMLSettings.h: Use QString() for settingsToCSS, the trick where QString::null is really a const char * does not work in this case.
• khtml/rendering/render_list.cpp: (RenderListMarker::paintObject): Use an isEmpty check here instead of comparing with QString::null. Not sure this change was strictly required, but it is simpler and may also make the code slightly faster.

• kwq/KWQKFileDialog.h: Removed. This used QString::null in a way that is incompatible with the new "0" hack, but was not used any more.
• kwq/KWQKFileDialog.mm: Removed.
• ForwardingHeaders/kfiledialog.h: Empty this out, since there is no KWQKFileDialog.h any more.
• WebCore.pbproj/project.pbxproj: Removed KWQKFileDialog.h and .mm.

• khtml/html/htmltokenizer.cpp: Change the commentStart global array to be an array of char instead of QChar to avoid the static constructor; the code works fine with char anyway.
• khtml/html/html_formimpl.cpp: Change the global constants in this file to be char instead of QChar. It works this way (and faster for KWQ), and avoids the static constructor.

• khtml/rendering/bidi.h: Change BidiIterator from a class with constructors into a plain struct. The copy construct and assignment operator weren't needed anyway since they simply duplicated default assignment, and if we have a constructor then we can't use it as a global object, since we want to avoid static constructors. Do the same with BidiStatus, and also stop using bit fields. It's silly to use bit fields for something when we have only one global instance of it; just makes extra code size and saves a few bytes.
• khtml/rendering/bidi.cpp: (BidiIterator::current): Move the non-breaking space global inside this function. (appendRunsForObject): Initialize BidiIterator object using brace notation. (buildCompactRuns): Initialize BidiIterator objects using brace notation and assignment. (RenderBlock::layoutInlineChildren): Initialize BidiStatus fields separately. Initialize BidiIterator objects using brace notation and assignment. (RenderBlock::findNextLineBreak): Initialize BidiIterator objects using brace notation and assignment.

• khtml/rendering/render_frames.cpp: Removed an include of <iostream.h>. This pulled the entire C++ I/O library in, with lots of static constructors. Elsewhere, we are careful not to use the C++ I/O library in WebCore except in Development versions. And this file didn't actually use the library, just included the header.

• kwq/KWQNamespace.h: Remove all the color globals except for the ones used in KHTML: black, white, darkGray, gray, and lightGray. And for those, make the globals RGB constants instead of QColor objects. This gets rid of the global objects with constructors and works without any KHTML code changes.
• kwq/KWQColor.mm: Remove the definition of the QColor constants from the Qt class.

• kwq/KWQPainter.h: Add overloads for setPen and setBrush so they work with the "color" constants from Qt that are now RGB constants rather than QColor objects.
• kwq/KWQPainter.mm: (QPainter::setPen): Set style to solid line and width to 0 when the parameter is an RGB constant. This is just like what you'd get if you constructed a QPen. (QPainter::setBrush): Set style to solid pattern when the parameter is an RGB constant. This is just like what you'd get if you constructed a QBrush.

• khtml/misc/loader.h: Change m_LRULists to be a global pointer instead of a global array, so we don't have to statically construct LRUList objects.
• khtml/misc/loader.cpp: (Cache::getLRUListFor): Allocate the global array the first time we pass through here.

11:27 AM Changeset in webkit [4207] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by John.

• fixed 2959353 -- eliminate globally initialized objects from JavaScriptCore

• JavaScriptCore.pbproj/project.pbxproj: Added fpconst.cpp.
• kjs/fpconst.cpp: Added. Defines KJS::NaN and KJS::Inf in a way that does not require a framework init routine.

• kjs/identifier.h: Use a new KJS_IDENTIFIER_EACH_GLOBAL macro so we can do things to the entire set of identifiers easily. Also added an init function that sets up these globals in a way that does not require a framework init routine.
• kjs/identifier.cpp: (Identifier::init): Initialize the property ane globals in a way that does not require a framework init routine.

• kjs/internal.cpp: (InterpreterImp::initGlobalObject): Call Identifier::init.

• kjs/ustring.h: Remove UChar::null and UString::null, and add UString::null(). We can't have a global object of a class that has a constructor if we want to avoid framework init routines, and luckily very little code relies on these.
• kjs/ustring.cpp: (UCharReference::ref): Use our own global specific to this function rather than returning UChar::null when past the end of the string. This is dangerous because if the caller modifies it, that affects what all subsequent callers will see. (UString::Rep::create): Added assertions. (UString::UString): Got rid of code here that used to set up UString::null. (UString::null): Added. Returns a global null string, and can be used in some of the places where we used to use the UString::null global. (UString::operator[]): Fixed case where this used to return UChar::null to return '\0' instead.

• kjs/regexp.cpp: (RegExp::match): Change uses of UString::null to UString::null().

11:26 AM Changeset in webkit [4206] by darin

• 9 edits
  1 add in trunk/JavaScriptCore

Reviewed by John.

• fixed 2959353 -- eliminate globally initialized objects from JavaScriptCore

• JavaScriptCore.pbproj/project.pbxproj: Added fpconst.cpp.
• kjs/fpconst.cpp: Added. Defines KJS::NaN and KJS::Inf in a way that does not require a framework init routine.

• kjs/identifier.h: Use a new KJS_IDENTIFIER_EACH_GLOBAL macro so we can do things to the entire set of identifiers easily. Also added an init function that sets up these globals in a way that does not require a framework init routine.
• kjs/identifier.cpp: (Identifier::init): Initialize the property ane globals in a way that does not require a framework init routine.

• kjs/internal.cpp: (InterpreterImp::initGlobalObject): Call Identifier::init.

• kjs/ustring.h: Remove UChar::null and UString::null, and add UString::null(). We can't have a global object of a class that has a constructor if we want to avoid framework init routines, and luckily very little code relies on these.
• kjs/ustring.cpp: (UCharReference::ref): Use our own global specific to this function rather than returning UChar::null when past the end of the string. This is dangerous because if the caller modifies it, that affects what all subsequent callers will see. (UString::Rep::create): Added assertions. (UString::UString): Got rid of code here that used to set up UString::null. (UString::null): Added. Returns a global null string, and can be used in some of the places where we used to use the UString::null global. (UString::operator[]): Fixed case where this used to return UChar::null to return '\0' instead.

• kjs/regexp.cpp: (RegExp::match): Change uses of UString::null to UString::null().

10:02 AM Changeset in webkit [4205] by darin

• 6 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3242460 -- crash in NSPopUpButtonCell at acheter-moins-cher.com

• kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Defer QObject timers too as well as loading while tracking a pop-up.

• kwq/KWQObject.h: Add defersTimers and setDefersTimers functions.
• kwq/KWQObject.mm: (QObject::setDefersTimers): Added. When called with true starts deferring timers. When called with false schedules a "delay 0" task to deliver all the timers and stop deferring them. (-[KWQObjectTimerTarget sendTimerEvent]): Added. Contains guts of the old timerFired method. (-[KWQObjectTimerTarget timerFired]): Puts timer on the deferred timers list or calls sendTimerEvent. (+[KWQObjectTimerTarget stopDeferringTimers]): Remove timers items from the deferred timers list, and makes them fire, then stops deferring timers.

• WebCore.pbproj/project.pbxproj: Reorder things a bit.

8:19 AM Changeset in webkit [4204] by darin

• 3 edits in trunk/WebCore

Reviewed by Ken.

• fixed 3230885 -- crash loading hixie test page in -[WebSubresourceClient connection:didReceiveData:]

• khtml/rendering/render_style.cpp: (RenderStyle::setContent): Change code around so we don't deref the text object without checking the contentType. Also fix the leak of a DOMStringImpl in the case where we are asked to add a string, but the string pointer is 0.

Apr 28, 2003:

7:09 PM Changeset in webkit [4203] by gramps

• 6 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej.

• English.lproj/StringsNotToBeLocalized.txt:

Updated for recent changes.

WebKit:

Fixed 3225050 -- Default font size should be 16px
Fixed 3241813 -- No longer spoof as WinIE for abcnews.go.com when
default font size becomes 16px

Reviewed by Darin and Maciej.

• English.lproj/StringsNotToBeLocalized.txt:

Updated.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):

We need to adjust Times, Helvetica, and Courier to closely match the
vertical metrics of their Microsoft counterparts that are the de facto
web standard. The AppKit adjustment of 20% is too big and is
incorrectly added to line spacing, so we use a 15% adjustment instead
and add it to the ascent.

• WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):

Changed default font size from 14 to 16 pixels and default fixed font
size from 14 to 13 pixels. Changed standard font from Lucida Grande to
Times, serif font from Times New Roman to Times, and sans serif font
from Lucida Grande to Helvetica. Also replaced some stray tabs with
spaces and made a few other anal-retentive formatting changes.

• WebView.subproj/WebUserAgentSpoofTable.c: (hash): (_web_findSpoofTableEntry):
• WebView.subproj/WebUserAgentSpoofTable.gperf:

No longer spoof as Windows MSIE for abcnews.go.com since we've also
changed the default font size.

WebBrowser:

Reviewed by Maciej.

• English.lproj/StringsNotToBeLocalized.txt:

Updated for recent changes.

6:59 PM Changeset in webkit [4202] by rjw

• 22 edits in trunk

WebCore:

API changes from final review meeting.

goBackOrForwardToItem: -> goToBackForwardItem:
drop "Window" from WebUIDelegate method names.
WebElementIsSelectedTextKey -> WebElementIsSelectedKey
Cross-frame searchFor on WebView now public.

Reviewed by Chris.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm:

WebKit:

API changes from final review meeting.

goBackOrForwardToItem: -> goToBackForwardItem:
drop "Window" from WebUIDelegate method names.
WebElementIsSelectedTextKey -> WebElementIsSelectedKey
Cross-frame searchFor on WebView now public.

Reviewed by Chris.

• Plugins.subproj/WebBaseNetscapePluginView.m:
• WebCoreSupport.subproj/WebBridge.m:
• WebKit.exp:
• WebView.subproj/WebDefaultContextMenuDelegate.m:
• WebView.subproj/WebDefaultUIDelegate.m:
• WebView.subproj/WebFrame.h:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebHTMLView.m:
• WebView.subproj/WebHTMLViewPrivate.m:
• WebView.subproj/WebImageView.m:
• WebView.subproj/WebPolicyDelegate.h:
• WebView.subproj/WebTextView.m:
• WebView.subproj/WebUIDelegate.h:
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m:
• WebView.subproj/WebViewPrivate.h:
• WebView.subproj/WebViewPrivate.m:

WebBrowser:

API changes from final review meeting.

goBackOrForwardToItem: -> goToBackForwardItem:
drop "Window" from WebUIDelegate method names.
WebElementIsSelectedTextKey -> WebElementIsSelectedKey
Cross-frame searchFor on WebView now public.

Reviewed by Chris.

• BrowserDocument.m:
• BrowserWebController.m:
• ContextMenuHandler.m:
• FindPanelController.m:

Tests:

Updated examples to match API changes
Added zooming as an example of stringByEvaluatingJavaScriptFromString:
and custom context menus. Currently problematic because of 3242716.

• IBViewer/English.lproj/Document.nib:
• IBViewer/IBViewer.pbproj/project.pbxproj:
• PictureBrowser/Document.m:
• PictureBrowser/English.lproj/Document.nib:
• PictureBrowser/image_template.html:
• PictureBrowser/thumbnail_template.html:

5:12 PM Changeset in webkit [4201] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• re-fixed 3159076 -- turbotax.intuit.com forms have text fields instead of radio buttons

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::attach): Only set the type if JavaScript hasn't set it explicitly already.

4:01 PM Changeset in webkit [4200] by kocienda

• 3 edits
  2 adds in trunk/WebKit

WebFoundation:

Reviewed by Chris

Large reworking of NSURLResponse internals and
NSCachedURLResponse internals to move this code to
the API-approved design. Quite a bit of SPI has
shifted around as well.

• CacheLoader.subproj/NSCachedURLResponse.h: Name change: WebCacheObjectInternal -> NSCachedURLResponseInternal.

Added new init methods that conform to approved API. Removed old
initWithResponse: init method.

Also removed a host of other cache-related accessors and methods:
createdDate, setCreatedDate:, expiresDate, setExpiresDate:,
lastModifiedDate, setLastModifiedDate:, maxAgeValue, setMaxAgeValue:,
mustRevalidate, setMustRevalidate:, isExpired, age, and
freshnessLifetime. The getters have moved to SPI on NSURLResponse. The
setters have been obsoleted as there are now default values in the
case of non-HTTP responses, and the information can be derived from
the HTTP header in all cases for HTTP responses.

Removed: objectSize and setObjectSize: methods. This figure can be
derived from the length of the NSCachedURLResponse's data field.

Removed: canStoreInMemory, setCanStoreInMemory:, canStoreOnDisk, and
setCanStoreOnDisk: methods. These are obsoleted by the new
NSURLCacheStoragePolicy API construct.

• CacheLoader.subproj/NSCachedURLResponse.m:

Name change: WebCacheObjectVersion -> NSCachedURLResponseVersion.
Bumped the version number as well.

Removed instance variables used for now-obsoleted getter and setter
methods.

Added NSData, user-info NSDictionary and NSURLCacheStoragePolicy
instance variables, and added the API-approved getters for them.

Added implementation for new init methods; removed old init method
implementation.

Modified copy and coding methods accordingly.

Removed all method implementations mentioned in the
NSCachedURLResponse.h comment.

• CacheLoader.subproj/NSURLCache.m: (-[NSURLCache storeCacheObject:forKey:]): Rewrote implementation to use new NSURLCacheStoragePolicy construct in place of older canCache accessors.

• CacheLoader.subproj/NSURLCachePrivate.h: Added _cacheStatistics SPI method that used to be API but did not make the cut.

• CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _didFinishReturnCachedResponse:]): Use new API to access cache object data. (-[NSURLConnection _didFinishLoading]): Use new API to create an NSCachedURLResponse.

• CacheLoader.subproj/NSURLResponse.h: Now implements NSCopying.

• CacheLoader.subproj/NSURLResponse.m:

Bumped NSURLResponseVersion.

Removed createdTime and lastModifiedTime instance variables from
NSURLResponseInternal. Added createdDate instance variable. This is
part of the new way to track this information in responses.

Removed resourceData instance variable from NSURLResponseInternal.
This is no longer stored in the response object; it has moved to
NSCachedURLResponse.

Fixed silly retain of a static string in NSURLResponseInternal.

Updated NSURLResponseInternal dealloc and coding methods for new
instance variable set.

Added copyWithZone: method.

Removed accessors for obsoleted instance variables.

Added SPI accessor methods to NSURLResponseInternal: _createdDate,
_expiresDate, _lastModifiedDate, _maxAge, _mustRevalidate, and
_freshnessLifetime. Most of these return default values that give
objects very permissive cache constraints.

Name change: WebHTTPResponseVersion -> NSHTTPURLResponseVersion.
Bumped the value.

Added a collection of transient instance variables to
NSHTTPURLResponseInternal to track the values the HTTP response
subclass returns for _createdDate, _expiresDate, _lastModifiedDate,
_maxAge, _mustRevalidate, and _freshnessLifetime methods.

Updated NSHTTPURLResponseInternal dealloc method for new instance
variable set.

Name change in NSHTTPURLResponseInternal: setHeader: ->
setAllHeaderFields:.

Added SPI accessor methods: _createdDate, _expiresDate,
_lastModifiedDate, _maxAge, _mustRevalidate, and _freshnessLifetime
that use HTTP header information to return protocol-correct values.
Added _parseCacheControl helper method.

• CacheLoader.subproj/NSURLResponsePrivate.h:

Removed a collection of accessors having to do with cache processing
and replaced with a modified set of SPI methods which work
together with API-approved NSURLResponse and NSCachedURLResponse
designs.

• CacheLoader.subproj/WebCacheObjectPrivate.h: Removed.

• CacheLoader.subproj/WebDiskCache.m: (-[WebDiskCache storeCacheObject:forKey:]): Access NSCachedURLResponse data instance variable to determine the size of a cache object. (-[WebDiskCache removeCacheObjectForKey:]): Ditto.

• CacheLoader.subproj/WebMemoryCache.m: (-[WebMemoryCache _truncateToSizeLimit]): Ditto. (-[WebMemoryCache storeCacheObject:forKey:]): Ditto.

• Downloads.subproj/NSURLDownload.m: (-[NSURLDownload _createFileIfNecessary]): _createdDate is now NSURLResponse SPI, not API.

• Misc.subproj/WebNSCalendarDateExtras.h: Modified convenience method:

+(NSTimeInterval)_web_timeIntervalFromHTTPDateString:(NSString *)string

is now

+(NSDate *)_web_dateFromHTTPDateString:(NSString *)string

• Misc.subproj/WebNSCalendarDateExtras.m: (+[NSCalendarDate _web_dateFromHTTPDateString:]): Ditto.

• Misc.subproj/WebNSStringExtras.h: Added a new method: -(BOOL)_web_hasCaseInsensitiveSubstring:(NSString *)substring;

• Misc.subproj/WebNSStringExtras.m: Ditto. (-[NSString _web_hasCaseInsensitiveSubstring:]):

• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addConditionalFieldsToHeader]): Use new _web_dateFromHTTPDateString: method.

• ProtocolHandlers.subproj/WebHTTPProtocol.h: Remove unused timeIntervalFromHTTPResponseHeader: method.

• ProtocolHandlers.subproj/WebHTTPProtocol.m: Ditto.

Modify a wide range of cache-related methods to use new API and
SPI made available by NSURLResponse and NSCachedURLResponse. In
many cases, this involved deleting code that now lives in one
of these two classes, which allows the protocol to rely more
on helpers.
(-[WebHTTPProtocol cachedResponseMustBeRevalidated]):
(-[WebHTTPProtocol _cachedResponseHasExpired]):
(-[WebHTTPProtocol HTTPResponse]):
(-[WebHTTPProtocol _cachePolicyForResponse]):
(-[WebHTTPProtocol setResponseHeader:]):

• ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]): Tweaks to call new-style NSURLResponse and NSCachedURLResponse accessors.

• WebFoundation.pbproj/project.pbxproj: PB knows best.

WebKit:

Reviewed by Chris

• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): _lastModifiedDate on NSURLResponse is now SPI.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]): Ditto.

Apr 27, 2003:

6:10 PM Changeset in webkit [4199] by cblu

• 3 edits in trunk/WebKit

Improved headerdoc comments.

• Misc.subproj/WebKitErrors.h:
• WebView.subproj/WebFrameLoadDelegate.h: