Timeline



May 4, 2003:

9:28 PM Changeset in webkit [4275] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed a storage leak
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Release the timer before setting to nil.
7:57 PM Changeset in webkit [4274] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed 3131534 -- "javascript:window.open()" leads to page not found error
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): For open() calls, if the first parameter is not present, use "" instead of "undefined" as the URL.
  • fixed 3244766 -- window.open() doesn't position window correctly along the y axis
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Fixed the code that flips the y coordinate to take the window height into account.
3:21 PM Changeset in webkit [4273] by hyatt
  • 5 edits in trunk/WebKit

Add smallCaps boolean to the string measuring and drawing
methods. Not actually supported yet.

Reviewed by darin

  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]):
  • Misc.subproj/WebStringTruncator.m: (stringWidth):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:smallCaps:fontFamilies:]):
3:17 PM Changeset in webkit [4272] by hyatt
  • 8 edits in trunk/WebCore

Add smallCaps boolean to the string drawing and measuring
routines. WebCore should be done after this patch, with
the rest of the work being done entirely in WebKit.

Reviewed by darin

  • khtml/rendering/font.cpp: (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths): (Font::width):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText):
  • kwq/WebCoreTextRenderer.h:
3:08 PM Changeset in webkit [4271] by darin
  • 3 edits in trunk/WebKit

Reviewed by John.

  • added validation to "Interface Builder" methods on WebView
  • WebView.subproj/WebView.h: Add NSUserInterfaceValidations protocol so that subclassers know that they can call [super validateUserInterfaceItem:].
  • WebView.subproj/WebView.m: (-[WebView canMakeTextSmaller]): Simplify. (-[WebView canMakeTextLarger]): Simplify. (-[WebView _isLoading]): Added. (-[WebView validateUserInterfaceItem:]): Added. Checks for the six actions we implement, and returns NO if they are not valid.

May 3, 2003:

11:33 AM Changeset in webkit [4270] by hyatt
  • 30 edits in trunk/WebCore

Rename layouted to needsLayout. Add a layoutIfNeeded method
and start using it in places that do if (needsLayout()) layout();

Reviewed by kocienda

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty):
  • khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::recalcStyle):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): (HTMLImageElementImpl::height):
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute):
  • khtml/khtmlview.cpp: (KHTMLView::layout): (KHTMLView::print): (KHTMLView::timerEvent):
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_applet.cpp: (RenderApplet::layout): (RenderEmptyApplet::layout):
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp: (RenderBox::close):
  • khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode): (RenderContainer::removeChild): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode): (RenderContainer::layout):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_form.cpp: (RenderFormElement::layout): (RenderSubmitButton::updateFromElement): (RenderSelect::updateFromElement): (RenderSelect::calcMinMaxWidth): (RenderSelect::layout):
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout): (RenderFrameSet::positionFrames): (RenderFrameSet::userResize): (RenderFrameSet::canResize): (RenderPart::setWidget): (RenderPartObject::updateWidget): (RenderPartObject::layout):
  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::layout):
  • khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::splitInlines): (RenderInline::splitFlow):
  • khtml/rendering/render_layer.cpp: (RenderLayer::checkScrollbarsAfterLayout):
  • khtml/rendering/render_list.cpp: (RenderListItem::layout): (RenderListMarker::setStyle): (RenderListMarker::layout): (RenderListMarker::setPixmap):
  • khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::setNeedsLayout): (RenderObject::information): (RenderObject::dump): (RenderObject::setStyle): (RenderObject::invalidateLayout): (RenderObject::detach):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::paint): (RenderWidget::setQWidget): (RenderWidget::layout):
  • khtml/rendering/render_root.cpp:
  • khtml/rendering/render_table.cpp: (RenderTable::addChild): (RenderTable::layout): (RenderTable::paint): (RenderTable::close): (RenderTable::splitColumn): (RenderTable::appendColumn): (RenderTable::recalcSections): (RenderTableSection::addChild): (RenderTableSection::setCellWidths): (RenderTableSection::layoutRows): (RenderTableSection::recalcCells): (RenderTableRow::addChild): (RenderTableRow::layout): (RenderTableCell::paint):
  • khtml/rendering/render_text.cpp: (RenderText::setText):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): (DocumentImpl::updateStyleSelector):
  • khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::insertBefore): (NodeBaseImpl::replaceChild): (NodeBaseImpl::appendChild):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutForPageWidth):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge needsLayout]):

May 2, 2003:

5:42 PM Changeset in webkit [4269] by mjs
  • 56 edits in trunk

WebFoundation:

Reviewed by Richard.

  • reformatted method prototypes to match AppKit style
  • AuthenticationManager.subproj/NSHTTPAuthenticator.h:
  • AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.h:
  • AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h:
  • AuthenticationManager.subproj/NSURLProtectionSpace.h:
  • AuthenticationManager.subproj/WebCredentialStorage.h:
  • AuthenticationManager.subproj/WebKeychainCredential.h:
  • CacheLoader.subproj/NSURLCache.h:
  • CacheLoader.subproj/NSURLCachePrivate.h:
  • CacheLoader.subproj/NSURLConnection.h:
  • CacheLoader.subproj/NSURLConnectionPrivate.h:
  • CacheLoader.subproj/NSURLConnectionQueue.h:
  • CacheLoader.subproj/NSURLProtocol.h:
  • CacheLoader.subproj/NSURLProtocolClient.h:
  • CacheLoader.subproj/NSURLProtocolPrivate.h:
  • CacheLoader.subproj/NSURLRequest.h:
  • CacheLoader.subproj/NSURLRequestPrivate.h:
  • CacheLoader.subproj/NSURLResponse.h:
  • CacheLoader.subproj/NSURLResponsePrivate.h:
  • CacheLoader.subproj/WebCache.h:
  • CacheLoader.subproj/WebCachePrivate.h:
  • CacheLoader.subproj/WebDiskCache.h:
  • CacheLoader.subproj/WebNetworkSettings.h:
  • CacheLoader.subproj/WebSynchronousDelegate.h:
  • CookieManager.subproj/NSHTTPCookiePrivate.h:
  • CookieManager.subproj/NSHTTPCookieStorage.h:
  • CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
  • CookieManager.subproj/WebCookieStorage.h:
  • CookieManager.subproj/WebCookieStorageServer.h:
  • Database.subproj/WebDatabase.h:
  • Database.subproj/WebFileDatabase.h:
  • Misc.subproj/WebBinaryHeap.h:
  • Misc.subproj/WebFileTypeMappings.h:
  • Misc.subproj/WebHostNameAddressInfo.h:
  • Misc.subproj/WebKeyValuePair.h:
  • Misc.subproj/WebMonitor.h:
  • Misc.subproj/WebMultipartForm.h:
  • Misc.subproj/WebNSArrayExtras.h:
  • Misc.subproj/WebNSCalendarDateExtras.h:
  • Misc.subproj/WebNSDataExtras.h:
  • Misc.subproj/WebNSDictionaryExtras.h:
  • Misc.subproj/WebNSErrorExtras.h:
  • Misc.subproj/WebNSObjectExtras.h:
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSThreadExtras.h:
  • Misc.subproj/WebNSValueExtensions.h:
  • Misc.subproj/WebOrderable.h:
  • Misc.subproj/WebQueue.h:
  • Misc.subproj/WebReadWriteLock.h:
  • Misc.subproj/WebRecursiveReadWriteLock.h:
  • Misc.subproj/WebSpinLock.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h:
  • ProtocolHandlers.subproj/WebFTPProtocol.h:
  • ProtocolHandlers.subproj/WebHTTPProtocol.h:

WebCore:

Reviewed by Richard.

  • reformatted method prototypes to match AppKit style
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreDOMPrivate.h:
  • kwq/WebCoreHistory.h:
  • kwq/WebCoreResourceLoader.h:
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebDOMDocument.h:
  • kwq/WebDOMElement.h:
  • kwq/WebDOMNode.h:

WebKit:

Reviewed by Richard.

  • reformatted method prototypes to match AppKit style
  • remove "Public header file" from headers that are not public
  • fix header doc @method names to match actual method names
  • Carbon.subproj/CarbonWindowAdapter.h:
  • Carbon.subproj/HIViewAdapter.h:
  • DOM.subproj/WebDOMDocument.h:
  • DOM.subproj/WebDOMNode.h:
  • History.subproj/WebBackForwardList.h:
  • History.subproj/WebHistoryItemPrivate.h:
  • History.subproj/WebHistoryPrivate.h:
  • History.subproj/WebURLsWithTitles.h:
  • Misc.subproj/WebIconDatabase.h:
  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebUnicode.h:
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebNetscapePluginStream.h:
  • Plugins.subproj/WebNullPluginView.h:
  • Plugins.subproj/WebPluginViewFactory.h:
  • WebCoreSupport.subproj/WebGlyphBuffer.h:
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRendererFactory.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebDataProtocol.h:
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDebugDOMNode.h:
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.h:
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebPolicyDelegate.h:
  • WebView.subproj/WebPolicyDelegatePrivate.h:
  • WebView.subproj/WebPreferencesPrivate.h:
  • WebView.subproj/WebRenderNode.h:
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebUIDelegate.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebViewPrivate.h:
4:10 PM Changeset in webkit [4268]
  • 8 copies
    1 delete in tags/WebKit-SDK-Beta-1

This commit was manufactured by cvs2svn to create tag
'WebKit-SDK-Beta-1'.

4:10 PM Changeset in webkit [4267] by rjw
  • 3 edits in branches/Safari-77~1-branch

Build hackery for WebKit beta SDK. Installs framework in /System/Library/Frameworks.

1:09 PM Changeset in webkit [4266] by mjs
  • 11 edits in trunk

WebCore:

Reviewed by Darin.

  • fixed 2936175 - MALLORY: please implement onResize
  • khtml/khtmlview.cpp: (KHTMLView::resizeEvent): Put most of this in #if !APPLE_CHANGES, since we already do the relayout and such on resize elswhere.
  • kwq/KWQEvent.h: Add a minimal QResizeEvent.
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendResizeEvent): Send it to the view.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge sendResizeEvent]): Send it to the part.

WebKit:

Reviewed by Darin.

  • fixed 2936175 - MALLORY: please implement onResize
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): If we just resized and we're not printing, make sure to send a resize event after the layout.
12:21 PM Changeset in webkit [4265] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3184113, bottom margins didn't collapse with their children
like they were supposed to. The problem is fixed by separately
caching whether or not the top and bottom margins can collapse
with their kids instead of having one global canCollapse variable.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp:
11:13 AM Changeset in webkit [4264] by darin
  • 10 edits in trunk

WebCore:

Reviewed by John.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scheduleClose): Change to use closeWindowSoon, so that the delay is on the WebKit side so it can be tied to the WebView as a whole, not a particular bridge.
  • kwq/WebCoreBridge.h: Replaced closeWindow with closeWindowSoon.
  • rolled in a couple of harmless and eventually-possibly-useful changes inspired by changes OmniGroup made in their copy of WebCore
  • kwq/KWQListBox.mm: Make KWQTableView a KWQWidgetHolder. (-[KWQTableView widget]): Return the widget.
  • kwq/KWQScrollView.mm: (QScrollView::ensureVisible): First cut at implementing these.

WebKit:

Reviewed by John.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): Replaces closeWindow. Schedule a closeWindow operation in the WebView. Important to not have the call's execution depend on whether this WebBridge or WebFrame is still around after the delay.
  • WebView.subproj/WebViewPrivate.h: Added _closeWindow.
  • WebView.subproj/WebViewPrivate.m: (-[WebView _closeWindow]): Make a webViewClose: call on the UI delegate.
10:39 AM Changeset in webkit [4263] by darin
  • 38 edits in trunk/WebKit

WebKit:

Reviewed by John.

Changed WebFrame to explicitly detach from the bridge so we don't have a stale pointer;
also cleaned up WebBridge initialization.

  • WebCoreSupport.subproj/WebBridge.h: Added initWithWebFrame: and close methods, removed setWebFrame: method.
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webFrameView:webView:]): Use the new initWithWebFrame:.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Call close on the bridge.
  • fixed many places that call a WebView a "controller"
  • Misc.subproj/WebKitStatistics.h:
  • Misc.subproj/WebKitStatistics.m:
  • Misc.subproj/WebKitStatisticsPrivate.h:
  • Misc.subproj/WebNSViewExtras.m:
  • Plugins.subproj/WebBaseNetscapePluginView.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.h:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by John.

  • fixed many places that call a WebView a "controller", including changing the name BrowserWebController to BrowserWebView
  • BrowserDocument.h:
  • BrowserDocument.m:
  • BrowserDocumentController.h:
  • BrowserDocumentController.m:
  • BrowserTabViewItem.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.h:
  • BrowserWebController.m:
  • BrowserWebFrameExtras.h:
  • BrowserWindowController.h:
  • BrowserWindowController.m:
  • ContextMenuHandler.m:
  • Debug/DOMTree.h:
  • Debug/DOMTree.m:
  • Debug/DebugUtilities.m:
  • Debug/RenderTree.h:
  • Debug/RenderTree.m:
  • Debug/ViewTree.h:
  • Debug/ViewTree.m:
  • English.lproj/StringsNotToBeLocalized.txt:
  • FindPanelController.m:
  • FormCompletionController.h:
  • FormCompletionController.m:
  • LoadProgressMonitor.h:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • LocationChangeHandler.h:
  • LocationChangeHandler.m:
  • Test/PageLoadTestRunner.m:
10:22 AM Changeset in webkit [4262] by hyatt
  • 3 edits in trunk/WebCore

Make sure that recalcSections always clears out the needSectionRecalc
boolean, even in the case where it finds column elements.

Fixes the assert outlined in bug 3237651.

Reviewed by john

  • khtml/rendering/render_table.cpp: (RenderTable::recalcSections):
8:52 AM Changeset in webkit [4261] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3226030, percentage height tables inside table cells
don't grow to fill the space inside the cell. There was
a missing edge case here for the case where the table was
nested inside a table cell.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTable::layout):

May 1, 2003:

5:53 PM Changeset in webkit [4260] by hyatt
  • 3 edits in trunk/WebCore

Add a cycle check when importing stylesheets to prevent
infinite loops.

Reviewed by john

  • khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::init):
5:12 PM Changeset in webkit [4259] by hyatt
  • 4 edits in trunk/WebCore

Table rows don't know their precise dimensions, so repainting
them fails. For now, just make an invalidation of a table
row due to CSS changes invalidate the whole table.

This is what the old Safari table code used to do prior to the
new table code landing.

Fixes bug #3205092.

Reviewed by darin/john

  • khtml/rendering/render_table.cpp: (RenderTableRow::repaint):
  • khtml/rendering/render_table.h:
4:30 PM Changeset in webkit [4258] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3232637, don't let generated parentless image content
try to do width/height/layout calculations. It will do this
all anyway, when it finally gets inserted into the rendering
tree.

Reviewed by john

  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap):
4:01 PM Changeset in webkit [4257] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3239404, a crash caused because a block-level :after
element was being inserted as generated content inside an
inline element.

The fix is to mutate the display of the generated content to
be inline when the parent of the generated content is also
inline.

Section 12.1 of the CSS2 spec (at the very end of the spec)
covers this special case. Once we do the mutation it becomes
impossible for generated content to cause a splitFlow, and so
the crash is plugged.

Reviewed by john

  • khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
3:31 PM Changeset in webkit [4256] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3246045 -- History items without a valid date in History.plist show up with unexpected dates in UI

Reviewed by Darin.

  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]): don't set lastVisitedTimeInterval to [nil doubleValue], since this is random
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
3:13 PM Changeset in webkit [4255] by rjw
  • 2 edits in branches/Safari-77~1-branch/WebKit

Merged from HEAD:

Added missing header and alphabetized.

Reviewed by Ken.

  • Misc.subproj/WebKit.h:
3:11 PM Changeset in webkit [4254] by rjw
  • 2 edits in trunk/WebKit

Added missing header and alphabetized.

Reviewed by Ken.

  • Misc.subproj/WebKit.h:
3:10 PM Changeset in webkit [4253] by hyatt
  • 9 edits in trunk/WebCore

Replace effectiveWidth and effectiveHeight with a
parameterized overflowWidth/Height, since this is much better
terminology.

Also fix event handling so that it no longer assumes (incorrectly)
that being inside the overflow rect of an object means you are
inside the object. Now there are two separate checks, with the
overflow check being used only to figure out if you should check
inside your kids.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::repaint):
  • khtml/rendering/render_flow.cpp: (RenderFlow::repaint):
  • khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_table.h:
2:44 PM Changeset in webkit [4252] by cblu
  • 6 edits in trunk/WebKit

WebKit:

Fixed: 3234888 - REGRESSION: "can't add a plug-in to a defunct WebPluginController" error, then crash
Fixed: 3226392 - REGRESSION: Safari crashed while loading Java applet at PopCap.com

Reviewed by darin.

  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame setController:]): fixed comment
  • WebView.subproj/WebView.m: (-[WebView dealloc]): call [self _close]
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate dealloc]): let the WebView class clear the frames (-[WebView _close]): remove self from controller set and detach and release frame

WebBrowser:

Fixed: 3234888 - REGRESSION: "can't add a plug-in to a defunct WebPluginController" error, then crash
Fixed: 3226392 - REGRESSION: Safari crashed while loading Java applet at PopCap.com

Reviewed by darin.

  • BrowserWebController.m: (-[BrowserWebController close]): call [self _close]
2:31 PM Changeset in webkit [4251] by sheridan
  • 3 edits in trunk

Safari-78u versionstamp

1:39 PM Changeset in webkit [4250]
  • 3 copies
    1 delete in branches/Safari-77~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-77~1-branch'.

1:39 PM Changeset in webkit [4249]
  • 3 copies
    1 delete in tags/Safari-77~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-77~1-anchor'.

1:39 PM Changeset in webkit [4248]
  • 3 copies
    1 delete in tags/Safari-77

This commit was manufactured by cvs2svn to create tag 'Safari-77'.

1:39 PM Changeset in webkit [4247] by sheridan
  • 8 edits in trunk

Safari-77 stamp

12:19 PM Changeset in webkit [4246] by sullivan
  • 2 edits in trunk/WebKit
  • fixed 3245793 -- Launching Safari-75 after tip of tree erases all history

Reviewed by Chris, Don

  • History.subproj/WebHistoryItem.m: keep using "lastVisitedDate" as the dictionary key, since old Safaris otherwise can't read the History file. (-[WebHistoryItem dictionaryRepresentation]): keep storing the time interval as a string, since old Safaris otherwise can't read the History file (-[WebHistoryItem initFromDictionaryRepresentation:]): read the stored date as a string and convert to a double, as we did before.
11:24 AM Changeset in webkit [4245] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3244157, giantrobot.com misrenders with a lot of
vertical space. Overflow heights were being miscomputed for
overflow:auto blocks.

Reviewed by gramps

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
9:44 AM Changeset in webkit [4244] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed 3169117 -- dragging while using a scroll wheel affects scroll movement
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSWindow nextEventMatchingMask:untilDate:inMode:dequeue:]): Just return nil when called with NSScrollWheelMask to work around the bug where any kind of event can be returned when this mask is passed. This will prevent scroll wheel events from being coalesced, but it's better than extracting events of all different types. Mouse moved events are particularly bad because they have deltaX/Y/Z and the scroll wheel code in NSScrollView treats them as if they were scroll wheel events.
9:35 AM Changeset in webkit [4243]
  • 1 copy
    61 deletes in tags/WebFoundation-77~1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-77~1'.

9:35 AM Changeset in webkit [4242] by kocienda
  • 4 edits in trunk/WebKit/Misc.subproj

Reviewed by Gramps

Updated copyright notices on every header and
implementation file in the framework.

9:33 AM Changeset in webkit [4241] by kocienda
  • 2 edits in trunk/WebKit

Tests:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.
Note that there are some discrepancies in the
test results, but they seem to be the result
of changes in the way we handle cookie paths,
an aspect of cookies I did not change at all
with this patch. The difference must have
crept in some time ago.

  • CookieManager/wkcookie-test.chk:
  • CookieManager/wkcookiemanager-test.chk:
  • CookieManager/wkcookiemanager-test.m: (main):

WebFoundation:

Reviewed by Darin

Updated to provide and use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-setAcceptPolicy: -> -setCookieAcceptPolicy:
-acceptPolicy -> -cookieAcceptPolicy
-cookieRequestHeaderFieldsForURL: -> -cookiesForURL:
-setCookiesFromResponseHeader:forURL:policyBaseURL: -> -setCookies:forURL:mainDocumentURL:

Added back compare: method in NSHTTPCookie. Our tests use it.

  • CookieManager.subproj/NSHTTPCookie.m: (-[NSHTTPCookie compare:]):
  • CookieManager.subproj/NSHTTPCookieStorage.h:
  • CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _cookieRequestHeaderFieldsForURL:withExtraCookies:]): (-[NSHTTPCookieStorage _cookiesForURL:withExtraCookies:]): (-[NSHTTPCookieStorage init]): (+[NSHTTPCookieStorage sharedHTTPCookieStorage]): (-[NSHTTPCookieStorage cookiesForURL:]): (-[NSHTTPCookieStorage setCookies:forURL:mainDocumentURL:]): (-[NSHTTPCookieStorage cookieAcceptPolicy]): (-[NSHTTPCookieStorage setCookieAcceptPolicy:]):
  • CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addCookieFieldToHeader]): (-[WebCFNetworkHTTPProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _parseHeaderFromData:]):

WebKit:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-acceptPolicy -> -cookieAcceptPolicy
-cookieRequestHeaderFieldsForURL: -> -cookiesForURL:
-setCookiesFromResponseHeader:forURL:policyBaseURL: -> -setCookies:forURL:mainDocumentURL:

  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): (-[WebCookieAdapter cookiesForURL:]): (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):

WebBrowser:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-setAcceptPolicy: -> -setCookieAcceptPolicy:
-acceptPolicy -> -cookieAcceptPolicy

  • AppController.m: (-[AppController deleteAllCookies]):
  • Preferences.subproj/AcceptedCookies.m: (-[AcceptedCookies updateCookieData]): (-[AcceptedCookies removeSelectedItems:]): (-[AcceptedCookies registerForCookieChangeNotifications]):
  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):
12:06 AM Changeset in webkit [4240] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

Apr 30, 2003:

8:52 PM Changeset in webkit [4239] by kocienda
  • 8 edits in trunk/WebKit

Tests:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

  • PictureBrowser/PictureBrowserProtocol.m: (-[PictureBrowserProtocol startLoading]):

WebFoundation:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _beginLoad]): (-[NSURLConnection _prepareOriginLoad]): (-[NSURLConnection _performTimeOut]): (-[NSURLConnection _wasRedirectedToRequest:redirectResponse:]):
  • CacheLoader.subproj/WebSynchronousDelegate.m: (-[WebSynchronousDelegate run:]):
  • FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload setDestination:allowOverwrite:]): (-[NSURLDownload connectionDidFinishLoading:]): (-[NSURLDownload _decodeData:]): (-[NSURLDownload _writeDataForkData:resourceForkData:]): (-[NSURLDownload _errorWithCode:]): (WriteCompletionCallback): (CloseCompletionCallback):
  • Misc.subproj/WebFoundation.h:
  • Misc.subproj/WebNSErrorExtras.h:
  • Misc.subproj/WebNSErrorExtras.m: (WebNSErrorExtrasInit):
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]):
  • ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol startLoading]): (-[WebFTPProtocol determineErrorAndFail]): (-[WebFTPProtocol _checkDirectoryListing]):
  • ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol startLoading]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol startLoading]): (-[WebHTTPProtocol cachedResponseRevalidated]): (-[WebHTTPProtocol determineTransferEncoding]): (-[WebHTTPProtocol determineErrorAndFail]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol _continueLoadingWithAddressInfo]): (-[WebSimpleHTTPProtocol hostNameResolved:]): (-[WebSimpleHTTPProtocol _processRawData]): (-[WebSimpleHTTPProtocol _handleLoadCallback]):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:
  • Misc.subproj/WebNSErrorConstants.h: Removed

WebKit:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedError:withDataSource:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancelledError]):
  • WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoadingInternal]):

WebBrowser:

Reviewed by Richard

Modified WebFoundation error constant names. Names
now begin with NSURLError prefix.

  • BrowserNSErrorExtras.m: (-[NSError isCancelledError]):
  • DownloadMonitor.m: (-[DownloadMonitor download:didReceiveResponse:]):
  • DownloadProgressEntry.m: (-[DownloadProgressEntry stop]):
  • LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): (-[LocationChangeHandler specializedMessageForError:dataSource:]): (-[LocationChangeHandler displayLocationChangeError:forDataSource:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
  • ResourceProgressEntry.m: (-[ResourceProgressEntry stage]):
  • WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]):
8:16 PM Changeset in webkit [4238] by kocienda
  • 6 edits in trunk/WebKit

WebFoundation:

Reviewed by Richard

Add API to NSURLProtocol so that protocol implementors
can set the instance variables defined on the base NSURLRequest
class. Also modified the existing setters on NSURLRequest
by giving them leading underscores, thus marking them
more clearly as SPI.

  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _didLoadData:]): (-[NSURLConnection _didFinishReturnCachedResponse:]): (-[NSURLConnection _didFinishLoading]): (-[NSURLConnection _didFailWithError:]):
  • CacheLoader.subproj/NSURLProtocol.h:
  • CacheLoader.subproj/NSURLProtocol.m: (-[NSURLProtocol setURL:inResponse:]): (-[NSURLProtocol setExpectedContentLength:inResponse:]): (-[NSURLProtocol setMIMEType:inResponse:]): (-[NSURLProtocol setTextEncodingName:inResponse:]):
  • CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponse _setURL:]): (-[NSURLResponse _setExpectedContentLength:]): (-[NSURLResponse _setMIMEType:]): (-[NSURLResponse _setTextEncodingName:]):
  • CacheLoader.subproj/NSURLResponsePrivate.h:
  • ProtocolHandlers.subproj/WebAboutProtocol.m: (-[WebAboutProtocol startLoading]):
  • ProtocolHandlers.subproj/WebFTPProtocol.m: (-[WebFTPProtocol sendResponseAvailableCallback]):
  • ProtocolHandlers.subproj/WebFileProtocol.m: (-[WebFileProtocol didLoadData:]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol HTTPResponse]):

WebKit:

Reviewed by Richard

Use NSURLResponse new SPI methods to set instance variables.

  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]):
  • WebView.subproj/WebDataProtocol.m: (-[WebDataProtocol startLoading]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient loadWithRequest:]):
8:04 PM Changeset in webkit [4237] by mjs
  • 2 edits in trunk/WebKit

WebFoundation:

Reviewed by Richard.

Moved NSURLProtectionSpace over to officially blessed API.

  • AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator _protectionSpaceForURL:realm:]): (-[NSHTTPAuthenticator _usernameForRealm:URL:]): (-[NSHTTPAuthenticator _proxyProtectionSpaceForURL:]): (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator _setDefaultUserInfoFromURL:]): (-[NSHTTPAuthenticator _removePasswordForRealm:URL:]):
  • AuthenticationManager.subproj/NSURLProtectionSpace.h:
  • AuthenticationManager.subproj/NSURLProtectionSpace.m: (-[NSURLProtectionSpaceInternal dealloc]): (-[NSURLProtectionSpace _internalInit]): (-[NSURLProtectionSpace initWithHost:port:protocol:realm:authenticationMethod:]): (-[NSURLProtectionSpace initWithProxyHost:port:type:realm:authenticationMethod:]): (-[NSURLProtectionSpace dealloc]): (-[NSURLProtectionSpace realm]): (-[NSURLProtectionSpace receivesCredentialSecurely]): (-[NSURLProtectionSpace isProxy]): (-[NSURLProtectionSpace host]): (-[NSURLProtectionSpace port]): (-[NSURLProtectionSpace proxyType]): (-[NSURLProtectionSpace hash]): (-[NSURLProtectionSpace isEqual:]): (-[NSURLProtectionSpace authenticationMethod]): (-[NSURLProtectionSpace protocol]):
  • AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _protectionSpaceWithKeychainItem:isDefault:]): (-[WebCredentialStorage _secProtocolForProtectionSpace:]): (-[WebCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): (-[WebCredentialStorage _addKeychainItem:]): (-[WebCredentialStorage credentialsForProtectionSpace:]): (-[WebCredentialStorage addCredential:forProtectionSpace:]): (-[WebCredentialStorage removeCredential:forProtectionSpace:]): (-[WebCredentialStorage defaultCredentialForProtectionSpace:]): (-[WebCredentialStorage setDefaultCredential:forProtectionSpace:]):

WebKit:

Reviewed by Richard.

Moved NSURLProtectionSpace over to officially blessed API.

  • Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]):

WebBrowser:

Reviewed by Richard.

Moved NSURLProtectionSpace over to officially blessed API.

  • FormCompletionController.m: (protectionSpaceFromFrame):
  • Preferences.subproj/PasswordsEditor.m: (-[PasswordsEditor addressStringForCredential:]): (-[PasswordsEditor resetCredentials]):
6:56 PM Changeset in webkit [4236] by rjw
  • 2 edits in trunk/WebKit

Copy MIME type when copying WebDataProtocol's parameters.

Reviewed by Ken.

  • WebView.subproj/WebDataProtocol.m: (-[WebDataRequestParameters copyWithZone:]):
6:30 PM Changeset in webkit [4235] by rjw
  • 3 edits in trunk/WebKit

Documentation fixes.
Added "ADVISORY NOTE" about possible API change after beta SDK.

  • History.subproj/WebHistory.h:
  • WebView.subproj/WebUIDelegate.h:
5:59 PM Changeset in webkit [4234] by kocienda
  • 11 edits in trunk/WebKit

WebFoundation:

Reviewed by Maciej

Tweaked some HTTP-specific NSURLRequest method names as specified
in the API errata list.

  • CacheLoader.subproj/NSURLRequest.h:
  • CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest allHTTPHeaderFields]): (-[NSURLRequest valueForHTTPHeaderField:]): (-[NSURLRequest allowsHTTPSCertificatesWithUnknownRoots]): (-[NSURLRequest HTTPContentType]): (-[NSURLRequest HTTPReferrer]): (-[NSURLRequest HTTPUserAgent]): (-[NSMutableURLRequest setHTTPMethod:]): (-[NSMutableURLRequest setAllHTTPHeaderFields:]): (-[NSMutableURLRequest setValue:forHTTPHeaderField:]): (-[NSMutableURLRequest addValue:forHTTPHeaderField:]): (-[NSMutableURLRequest setHTTPBody:]): (-[NSMutableURLRequest setAllowsHTTPSCertificatesWithUnknownRoots:]): (-[NSMutableURLRequest setHTTPContentType:]): (-[NSMutableURLRequest setHTTPCookiePolicyBaseURL:]): (-[NSMutableURLRequest setHTTPExtraCookies:]): (-[NSMutableURLRequest setHTTPPageNotFoundCacheLifetime:]): (-[NSMutableURLRequest setHTTPReferrer:]): (-[NSMutableURLRequest setHTTPUserAgent:]):
  • CacheLoader.subproj/NSURLRequestPrivate.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol setCertificatePolicyOnStream]): (-[WebCFNetworkHTTPProtocol addAcceptFieldsToHeader]): (-[WebCFNetworkHTTPProtocol addExtraFieldsToHeader]):
  • ProtocolHandlers.subproj/WebHTTPProtocol.m: (-[WebHTTPProtocol _cachedResponsePassesValidityChecks]): (-[WebHTTPProtocol _shouldAttemptOriginLoad]): (-[WebHTTPProtocol retryWithRedirectedURLAndResultCode:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]):

WebKit:

Reviewed by Maciej

Tweaked some HTTP-specific NSURLRequest method names as specified
in the API errata list.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]):

WebBrowser:

Reviewed by Maciej

Tweaked some HTTP-specific NSURLRequest method names as specified
in the API errata list.

  • BugReportController.m: (-[BugReportController sendBugReportToAppleWithScreenShot:source:]):
  • LocationChangeHandler.m: (-[LocationChangeHandler unknownRootSheetDidEnd:returnCode:contextInfo:]):
5:44 PM Changeset in webkit [4233] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3210725, invalid n/a selector treated as valid. This
fix also makes the CSS1 test on the test suite for forward-compatible
parsing completely pass (yay!), which was an issue on
diveintomark's list.

Reviewed by gramps

  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
5:40 PM Changeset in webkit [4232] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Ken.

Minor header tweaks.

  • Misc.subproj/WebDownload.h: Fix copyright notice.
  • Panels.subproj/WebAuthenticationPanel.h: Added 2003 to copyright.
  • WebView.subproj/WebAuthenticationChallenge.h: Fix copyright notice, add docs.
  • WebView.subproj/WebAuthenticationChallengeInternal.h: Fix copyright notice.
5:27 PM Changeset in webkit [4231] by mjs
  • 3 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Cut over to using the approved API mechanism for sending
challenges between the protocol and protocol
client. NSURLConnection now does the corss-thread dispatch and
NSURLAuthenticationDispatcher is obsoleted.

  • AuthenticationManager.subproj/NSHTTPAuthenticator.h:
  • AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSURLAuthenticationChallengeState initWithProtocol:httpRequest:challenge:callback:context:]): (-[NSURLAuthenticationChallengeState dealloc]): (-[NSHTTPAuthenticator _tryChallenge:]): (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator _askDelegateWithURL:proxy:forRequest:failureCount:failureResponse:protocol:withCallback:context:]): (-[NSHTTPAuthenticator addCredentialsToRetryHTTPRequest:afterFailureResponse:nsFailureResponse:failureCount:protocol:withCallback:context:]): (-[NSHTTPAuthenticator cancelAddCredentialsToRetryHTTPRequest:]): (-[NSHTTPAuthenticator addCredentialsToInitialHTTPRequest:protocol:]): (-[NSHTTPAuthenticator checkForAuthenticationFailureInHTTPResponse:withURL:]): (-[NSHTTPAuthenticator useCredential:forAuthenticationChallenge:]): (-[NSHTTPAuthenticator continueWithoutCredentialForAuthenticationChallenge:]):
  • AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
  • AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallengeInternal initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:]): (-[NSURLAuthenticationChallengeInternal dealloc]): (-[NSURLAuthenticationChallenge initWithProtectionSpace:proposedCredential:previousFailureCount:failureResponse:error:]): (-[NSURLAuthenticationChallenge initWithAuthenticationChallenge:]): (-[NSURLAuthenticationChallenge dealloc]): (-[NSURLAuthenticationChallenge protectionSpace]): (-[NSURLAuthenticationChallenge proposedCredential]): (-[NSURLAuthenticationChallenge previousFailureCount]): (-[NSURLAuthenticationChallenge error]): (-[NSURLAuthenticationChallenge failureResponse]):
  • AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.m: (-[NSURLConnectionAuthenticationChallenge _initWithProtocolChallenge:connection:]):
  • AuthenticationManager.subproj/NSURLConnectionAuthenticationChallengeInternal.h:
  • AuthenticationManager.subproj/NSURLCredentialStorage.h:
  • AuthenticationManager.subproj/NSURLCredentialStorage.m:
  • AuthenticationManager.subproj/WebAuthenticationHandler.h: Removed.
  • AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.h: Removed.
  • AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: Removed.
  • AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h: Removed.
  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection useCredential:forAuthenticationChallenge:]): (-[NSURLConnection continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLConnection _sendCallbacks]): (-[NSURLConnection _sendDidReceiveAuthenticationCallback]): (-[NSURLConnection _sendDidCancelAuthenticationCallback]): (-[NSURLConnection _performCancel]): (-[NSURLConnection _performUseCredential]): (-[NSURLConnection _performContinueWithoutCredential]): (-[NSURLConnection _didReceiveAuthenticationChallenge:]): (-[NSURLConnection _didCancelAuthenticationChallenge:]): (+[NSURLConnection _resourceLoadLoop:]): (NSURLConnectionInit): (_authenticationDone): (-[NSURLConnectionInternal prepareCallbacks]): (-[NSURLConnectionInternal URLProtocol:didReceiveAuthenticationChallenge:]): (-[NSURLConnectionInternal URLProtocol:didCancelAuthenticationChallenge:]):
  • CacheLoader.subproj/NSURLProtocol.h:
  • ChangeLog:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addAuthenticationFieldsToHeader]): (-[WebCFNetworkHTTPProtocol didAddCredentials:toRequest:context:]): (-[WebCFNetworkHTTPProtocol useCredential:forAuthenticationChallenge:]): (-[WebCFNetworkHTTPProtocol continueWithoutCredentialForAuthenticationChallenge:]):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin.

Fixed imports and @class directives for WebFoundation changes.

  • Panels.subproj/WebAuthenticationPanel.h:
  • Panels.subproj/WebAuthenticationPanel.m:

WebBrowser:

Reviewed by John.

  • FileLocker.m: (-[FileLocker dealloc]): Add call to [super dealloc].
  • AppController.m: (-[AppController applicationShouldOpenUntitledFile:]): Since page load test is now really part of the real application, don't FIXME it in some half-assed way. (-[AppController applicationDidFinishLaunching:]): Remove a FIXME here too.
  • Test/PageLoadTestRunner.m: (+[PageLoadTestRunner shouldPerformAutomatedPageLoadTest]): Replace the load method with this method.
  • TitleBarButton.m: (-[TitleBarButton startDragIfNecessaryForEvent:URL:): Removed.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
  • English.lproj/Localizable.strings: Rolled out Ken's accidental check-in. Regenerating the file just changed it back to how it was before.
5:12 PM Changeset in webkit [4230] by hyatt
  • 4 edits in trunk/WebCore

Fixes for 3227983 and 3224521, both bugs involving bad letter-spacing
property values. This fixes all Movable Type blogs that had this
error in their stylesheets.

Reviewed by gramps

  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
4:50 PM Changeset in webkit [4229] by darin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed 3233819 -- MALLORY: onChange handler being called on SELECT even if selected item does not change
  • kwq/KWQComboBox.h: Added _currentItem variable, updateCurrentItem function, and replaced activated function with itemSelected function.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Call updateCurrentItem so _currentItem is up to date. (QComboBox::insertItem): Ditto. (QComboBox::clear): Ditto. (QComboBox::setCurrentItem): Ditto. (QComboBox::updateCurrentItem): Added. Returns true if current item has changed since the last time the function was called. (QComboBox::itemSelected): Only send the activate method if updateCurrentItem returns true. (-[KWQComboBoxAdapter action:]): Call itemSelected instead of calling activated directly.
4:47 PM Changeset in webkit [4228] by rjw
  • 2 edits in trunk/WebKit

Fixed doc errors.

  • History.subproj/WebHistory.h:
4:46 PM Changeset in webkit [4227] by mjs
  • 2 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Some simple renames:

sharedURLCredentialStorage --> sharedCredentialStorage
URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:

  • AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator _usernameForRealm:URL:]): (-[NSHTTPAuthenticator _applyHTTPProxyCredentials:]): (-[NSHTTPAuthenticator _applyHTTPCredentials:]): (-[NSHTTPAuthenticator _proxyUsernameForURL:]): (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:connection:withCallback:context:]): (-[NSHTTPAuthenticator _askDelegateWithURL:proxy:forRequest:failureCount:failureResponse:connection:withCallback:context:]): (-[NSHTTPAuthenticator NSURLAuthenticationChallenge:useCredential:]): (-[NSHTTPAuthenticator _setDefaultUserInfoFromURL:]): (-[NSHTTPAuthenticator _removePasswordForRealm:URL:]): (-[NSHTTPAuthenticator _removeProxyPasswordForURL:]): (-[NSHTTPAuthenticator init]):
  • AuthenticationManager.subproj/NSURLCredential.h:
  • AuthenticationManager.subproj/NSURLCredential.m: (+[NSURLCredential credentialWithUser:password:persistence:]):
  • AuthenticationManager.subproj/NSURLCredentialStorage.h:
  • AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage init]): (initSharedCredentialStorage): (initCredentialStorage): (+[NSURLCredentialStorage sharedCredentialStorage]):

WebKit:

Reviewed by Darin.

Some simple renames:

sharedURLCredentialStorage --> sharedCredentialStorage
URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:

  • Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):

WebBrowser:

Reviewed by Darin.

Some simple renames:

sharedURLCredentialStorage --> sharedCredentialStorage
URLCredentialWithUser:password:persistence: --> credentialWithUser:password:persistence:

  • AppController.m: (-[AppController removeAllCredentials]):
  • FormCompletionController.m: (+[FormCompletionController _frame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): (+[FormCompletionController _passwordSheetDismissed:returnCode:contextInfo:]): (+[FormCompletionController _credentialMatchesForString:frame:]):
  • Preferences.subproj/PasswordsEditor.m: (-[PasswordsEditor resetCredentials]): (-[PasswordsEditor startMonitoringCredentials]): (-[PasswordsEditor stopMonitoringCredentials]): (-[PasswordsEditor removeSelectedItems:]):
4:15 PM Changeset in webkit [4226] by mjs
  • 10 edits
    3 adds in trunk/WebKit

Reviewed by Darin.

Changed things to use WebAuthenticationChallenge for
WebResoureceLoadDelegate auth callbacks.

  • Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler startAuthentication:window:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]):
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebAuthenticationChallenge.h: Added.
  • WebView.subproj/WebAuthenticationChallenge.m: Added. (-[WebAuthenticationChallengeInternal initWithDelegate:]): (-[WebAuthenticationChallengeInternal dealloc]): (-[WebAuthenticationChallenge _initWithAuthenticationChallenge:delegate:]): (-[WebAuthenticationChallenge dealloc]): (-[WebAuthenticationChallenge useCredential:]): (-[WebAuthenticationChallenge cancel]): (-[WebAuthenticationChallenge continueWithoutCredential]):
  • WebView.subproj/WebAuthenticationChallengeInternal.h: Added.
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate useCredential:forAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
  • WebView.subproj/WebResourceLoadDelegate.h:
3:48 PM Changeset in webkit [4225] by mjs
  • 4 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin.

Converted download code to use an
NSURLDownloadAuthenticationChallenge rather than a vanilla
NSURLAuthenticationChallenge.

  • AuthenticationManager.subproj/NSURLCredential.h:
  • AuthenticationManager.subproj/NSURLCredential.m: (-[NSURLCredential initWithUser:password:persistence:]): (-[NSURLCredential dealloc]): (-[NSURLCredential user]): (-[NSURLCredential password]): (-[NSURLCredential hasPassword]): (-[NSURLCredential persistence]): (-[NSURLCredential description]):
  • AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h:
  • AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.m: Added. (-[NSURLDownloadAuthenticationChallengeInternal initWithDownload:]): (-[NSURLDownloadAuthenticationChallengeInternal dealloc]): (-[NSURLDownloadAuthenticationChallenge _initWithAuthenticationChallenge:download:]): (-[NSURLDownloadAuthenticationChallenge dealloc]): (-[NSURLDownloadAuthenticationChallenge download]):
  • AuthenticationManager.subproj/NSURLDownloadAuthenticationChallengeInternal.h: Added.
  • FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload connection:didReceiveAuthenticationChallenge:]): (-[NSURLDownload connection:didCancelAuthenticationChallenge:]): (-[NSURLDownload useCredential:forAuthenticationChallenge:]): (-[NSURLDownload continueWithoutCredentialForAuthenticationChallenge:]): (-[NSURLDownload _cancelWithError:]):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin.

Converted download code to use an
NSURLDownloadAuthenticationChallenge rather than a vanilla
NSURLAuthenticationChallenge.

  • Misc.subproj/WebDownload.m: (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): (-[WebDownloadInternal download:didCancelAuthenticationChallenge:]):
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler startAuthentication:window:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]):
3:41 PM Changeset in webkit [4224] by kocienda
  • 2 edits in trunk/WebKit

Tests:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

  • CookieManager/wkcookie-test.m: (main):
  • CookieManager/wkcookiemanager-test.m: (main):

WebFoundation:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

  • CookieManager.subproj/NSHTTPCookie.h:
  • CookieManager.subproj/NSHTTPCookie.m: (-[NSHTTPCookie initWithDictionary:]): (-[NSHTTPCookie init]): (-[NSHTTPCookie dictionaryRepresentation]): (+[NSHTTPCookie cookieWithV0Spec:forURL:locationHeader:]): (-[NSHTTPCookie description]):
  • CookieManager.subproj/NSHTTPCookiePrivate.h:
  • CookieManager.subproj/NSHTTPCookieStorage.h:
  • CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _readAcceptCookiesPreference]): (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): (-[NSHTTPCookieStorage init]): (-[NSHTTPCookieStorage acceptPolicy]): (-[NSHTTPCookieStorage setAcceptPolicy:]): (-[NSHTTPCookieStorage description]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • WebFoundation-base.exp:

WebKit:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]):

WebBrowser:

Reviewed by Richard

Changed cookie-related constants and enums to
the API-approved names. Also did some text
search and replace in comments to catch usages
of now-obsolete names.

  • English.lproj/Localizable.strings:
  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):
3:20 PM Changeset in webkit [4223] by cblu
  • 5 edits in trunk/WebKit

WebKit:

FIXED: Clients of WebKit should have separate icon DB's

Reviewed by rjw.

  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebIconDatabase.h:
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): If the icon db hasn't been set using the defaults, create o directory using the bundle id.
  • WebKit.exp:

WebBrowser:

FIXED: Clients of WebKit should have separate icon DB's

Reviewed by rjw.

  • AppController.m: (+[AppController initialize]): Moved the icon DB rename code here from WebKit. Set the icon DB path.
  • Defaults.plist: Removed unused "safe MIME types" defaults
  • English.lproj/StringsNotToBeLocalized.txt:
3:03 PM Changeset in webkit [4222] by rjw
  • 14 edits in trunk/WebKit

WebFoundation:

Added utility _web_URLFragment.

Reviewed by Darin.

  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_URLFragment]):

WebKit:

API changes from final review meeting.

Moved view registry to WebView.
Changed WebHistoryItem to use NSTimeInterval (at least for public API).
Still creates a NSCalendarDate for compatibility. We should wean Safari
off it's use of NSCalendarDate.
Added public init method for WebHistoryItem.
Removed anchor from WebHistoryItem.
Added WebHistorySavedNotification.

Reviewed by Darin.

  • History.subproj/WebHistory.m: (-[WebHistory addItemForURL:]):
  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem lastVisitedTimeInterval]): (-[WebHistoryItem anchor]): (-[WebHistoryItem _setLastVisitedTimeInterval:]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem initFromDictionaryRepresentation:]):
  • History.subproj/WebHistoryItemPrivate.h:
  • History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate insertItem:atDateIndex:]): (-[WebHistoryPrivate removeItemForURLString:]): (-[WebHistoryPrivate addItem:]): (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]):
  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]):
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (+[WebView registerViewClass:representationClass:forMIMEType:]):

WebBrowser:

API changes from final review meeting.

Changed WebHistoryItem to use NSTimeInterval (at least for public API).
Still creates a NSCalendarDate for compatibility. We should wean Safari
off it's use of NSCalendarDate.
Added public init method for WebHistoryItem.
Removed anchor from WebHistoryItem.

Reviewed by Darin.

  • Debug/DebugUtilities.m: (-[WebHistory populateHistoryWithTestData:]):
  • GlobalHistory.m: (-[GlobalHistory parentOfContentItem:]):
  • WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): (-[WebBookmarkLeaf setLastVisitedDate:]): (-[WebBookmarkLeaf lastVisitedDate]):

Tests:

API changes from final review meeting.
Moved view registry to WebView.

Reviewed by Darin.

  • PDFBundle/PDFView.m: (+[PDFPluginViewFactory load]):
  • PDFViewer/ApplicationController.m: (-[ApplicationController awakeFromNib]):
2:49 PM Changeset in webkit [4221] by mjs
  • 18 edits
    2 adds
    3 deletes in trunk/WebKit

WebFoundation:

Reviewed by Darin.

More authentication API changes. With this change, we actually
send the authentication request through the connection delegate,
which is the major structural change. Even so, some work remains
to be done.

  • AuthenticationManager.subproj/NSHTTPAuthenticator.h:
  • AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSURLAuthenticationChallengeState initWithConnection:httpRequest:challenge:callback:context:]): Use a connection and dispatcher, not the usual handler array. (-[NSURLAuthenticationChallengeState dealloc]): Likewise. (-[NSHTTPAuthenticator _tryChallenge:]): Likewise. (-[NSHTTPAuthenticator _askDelegateWithURL:realm:forRequest:failureCount:failureResponse:connection:withCallback:context:]): Renamed from _invokeHandlersWithURL... and updated. (-[NSHTTPAuthenticator _askDelegateWithURL:proxy:forRequest:failureCount:failureResponse:connection:withCallback:context:]): Likewise. (-[NSHTTPAuthenticator NSURLAuthenticationChallenge:useCredential:]): Fix cleanup - no more handlers. (-[NSHTTPAuthenticator _internalInit]): Got rid of handler stuff. (-[NSHTTPAuthenticator dealloc]): Likewise. (-[NSHTTPAuthenticator addCredentialsToRetryHTTPRequest:afterFailureResponse:nsFailureResponse:failureCount:connection:withCallback:context:]): Ask the delegate, not the handlers. (-[NSHTTPAuthenticator cancelAddCredentialsToRetryHTTPRequest:]): Likewise.
  • AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
  • AuthenticationManager.subproj/NSURLAuthenticationChallenge.h:
  • AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallenge _useCredential:]): Semi-privatized this method, it will go for real soon but is used as a back channel by NSURLConnection for now. (-[NSURLAuthenticationChallenge _cancel]): Likewise.
  • AuthenticationManager.subproj/NSURLConnectionAuthenticationChallengeInternal.h:
  • AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.m: (-[NSURLConnectionAuthenticationChallenge _initWithProtocolChallenge:connection:delegate:]): Temporary private init since we still need the challenge delegate for now.
  • AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h: Added.
  • AuthenticationManager.subproj/NSURLProtocolAuthenticationChallenge.h: Updated.
  • AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.h:
  • AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: Renamed class to WebAuthenticationDispatcher. (-[WebAuthenticationDispatcher _dispatchStartAuthentication:]): Redone to use connection delegate based auth instead of using an authentication handler. (-[WebAuthenticationDispatcher _dispatchCancelAuthentication:]): Likewise. (-[WebAuthenticationDispatcher _dispatchAuthenticationDone:]): Likewise. (-[WebAuthenticationDispatcher dealloc]): Likewise. (-[WebAuthenticationDispatcher startAuthentication:]): Likewise. (-[WebAuthenticationDispatcher initWithConnection:]): New init.
  • CacheLoader.subproj/NSURLConnectionPrivate.h:
  • CacheLoader.subproj/NSURLConnection.h:
  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection useCredential:forAuthenticationChallenge:]): Call challenge (for now). (-[NSURLConnection continueWithoutCredentialForAuthenticationChallenge:]): Call challenge (for now). (-[NSURLConnection _delegate]): Temporary private method so that NSHTTPAuthenticator can bypass the Protocol <--> ProtocolClient interface and call the delegate directly.
  • FileTransfer.subproj/NSURLDownloadPrivate.h: Declared _init methods.
  • FileTransfer.subproj/NSURLDownload.h:
  • FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownload _initWithLoadingResource:request:response:delegate:proxy:]): Added. (+[NSURLDownload _downloadWithLoadingConnection:request:response:delegate:proxy:]): Use corresponding _init. (-[NSURLDownload _initWithSource:delegate:directory:]): Added. (+[NSURLDownload _downloadWithSource:delegate:directory:]): Use correspoding _init. (-[NSURLDownload _sendDidBeginMessage]): Note that we sent it even if we tried but the delegate does not respond to the begin selector, to avoid failing asserts later otherwise. (-[NSURLDownload connection:didReceiveAuthenticationChallenge:]): Forward to delegate or do the default action. (-[NSURLDownload connection:didCancelAuthenticationChallenge:]): Likewise. (-[NSURLConnectionDelegateProxy respondsToSelector:]): Act like we respond only if the underlying delegate does. (-[NSURLConnectionDelegateProxy connection:didReceiveAuthenticationChallenge:]): Pass it along. (-[NSURLConnectionDelegateProxy connection:didCancelAuthenticationChallenge:]): Pass it along.
  • AuthenticationManager.subproj/NSURLCredentialStorage.h: Removed authentication handler stuff.
  • AuthenticationManager.subproj/NSURLCredentialStorage.m: Likewise.

WebKit:

Reviewed by Darin.

  • Adjusted for authentication API change - now we expect authentication via the connection delegate, not a separate global authentication handler
  • Misc.subproj/WebKit.h: Include WebDownload.h
  • Misc.subproj/WebDownload.h: Added.
  • Misc.subproj/WebDownload.m: Added - this new class is just like NSURLDownload but if the standard auth delegate methods are not implemented, it prompts using the standard AppKit sheet.
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Panels.subproj/WebPanelAuthenticationHandler.m: (+[WebPanelAuthenticationHandler sharedHandler]): New method to get a shared handler, since we no logner register an instance with WebFoundation. (-[WebPanelAuthenticationHandler startAuthentication:window:]): Do things using the new API. (-[WebPanelAuthenticationHandler _authenticationDoneWithChallenge:result:]): Likewise.
  • WebKit.exp: Export WebDownload.
  • WebKit.pbproj/project.pbxproj: Add new files to build.
  • Removed WebStandardPanels - this is removed from the API.
  • Panels.subproj/WebStandardPanels.h: Removed.
  • Panels.subproj/WebStandardPanels.m: Removed.
  • Panels.subproj/WebStandardPanelsPrivate.h: Removed.
  • Panels.subproj/WebAuthenticationPanel.m: Remove WebStandardPanels.h import.
  • Added new resource load delegate auth methods:
  • WebView.subproj/WebResourceLoadDelegate.h:
  • Use WebDownload where appropriate, and remove use of WebStandardPanels:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): Pass to resource load delegate. (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): Likewise. (-[WebBaseResourceHandleDelegate dealloc]): Don't track currentURL any more. (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): Likewise. (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): Likewise. (-[WebBaseResourceHandleDelegate connection:didFailLoadingWithError:]): Likewise. (-[WebBaseResourceHandleDelegate cancelWithError:]): Likewise.
  • WebView.subproj/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): Prompt using the standard panel.

(-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
Cancel prompting using the standard panel.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Use WebDownload instead of NSURLDownload.
  • WebView.subproj/WebView.h: Remove unneeded @class directives, and mention WebDownload instead of NSURLDownload.
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _downloadURL:toDirectory:]): Use WebDownload instead of NSURLDownload. (-[WebView _cacheResourceLoadDelegateImplementations]): Track auth methods too.

WebBrowser:

Reviewed by Darin.

Updated for new WebKit auth API.

  • AppController.m: (-[AppController awakeFromNib]): No need to register interest in standard panels.
  • DownloadMonitor.m: (-[DownloadMonitor downloadWindowForAuthenticationSheet:]): Implemented this method so we can pop a sheet off the download window when reloading (yay, finally)!
  • DownloadProgressEntry.m: (-[DownloadProgressEntry reload]): Use WebDownload not NSURLDownload.
2:44 PM Changeset in webkit [4220] by hyatt
  • 3 edits in trunk/WebCore

Fix for the Adam Rice float/padding test on diveintomark's list
of bugs. We weren't adding in the parent's border/padding in
one case in the clearFloats function, which resulted in the
float being incorrectly positioned.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
11:20 AM Changeset in webkit [4219] by kocienda
  • 2 edits in trunk/WebKit

Tests:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

  • CookieManager/wkcookie-test.m: (DumpIFCookie): (main):
  • CookieManager/wkcookiemanager-test.m: (main):

WebFoundation:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

  • CookieManager.subproj/NSHTTPCookie.h:
  • CookieManager.subproj/NSHTTPCookie.m: (+[NSHTTPCookie cookieWithDictionary:]): (setVersion): (setName): (setValue): (setDefaultsFromOriginURL): (setDomain): (setPath): (setSecure): (setExpires): (-[NSHTTPCookie initWithDictionary:]): (+[NSHTTPCookie cookieWithV0Spec:forURL:locationHeader:]): (+[NSHTTPCookie _cookieArrayFromResponseHeaders:forURL:]): (-[NSHTTPCookie compare:]): (-[NSHTTPCookie _compareForHeaderOrder:]):
  • CookieManager.subproj/NSHTTPCookiePrivate.h:
  • CookieManager.subproj/NSHTTPCookieStorage.h:
  • CookieManager.subproj/NSHTTPCookieStorage.m: (acceptCookiesChanged): (setUpOnLoadThread): (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): (-[NSHTTPCookieStorage _internalInit]): (-[NSHTTPCookieStorage _cookieRequestHeaderFieldsForURL:withExtraCookies:]): (initSharedCookieManager): (+[NSHTTPCookieStorage sharedCookieManager]): (-[NSHTTPCookieStorage setCookie:]): (-[NSHTTPCookieStorage deleteCookie:]): (-[NSHTTPCookieStorage setCookiesFromResponseHeader:forURL:policyBaseURL:]):
  • CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
  • CookieManager.subproj/WebCookieStorage.m: (-[WebCookieStorage cookiesMatchingDomain:path:secure:]):
  • CookieManager.subproj/WebCookieStorageServer.m: (-[WebCookieStorageServer _checkForCookieExpiration:]): (-[WebCookieStorageServer _saveCookies]): (-[WebCookieStorageServer _setCookiesWithoutSaving:]): (-[WebCookieStorageServer deleteCookies:]): (makeCookie):
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addCookieFieldToHeader]): (-[WebCFNetworkHTTPProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _parseHeaderFromData:]):
  • WebFoundation-base.exp:

WebKit:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): (-[WebCookieAdapter cookiesForURL:]): (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):

WebBrowser:

Reviewed by Darin

Changed cookie-related class names:

WebCookie -> NSHTTPCookie
WebCookiePrivate -> NSHTTPCookieInternal
WebCookieManager -> NSHTTPCookieStorage
WebCookieManagerPrivate -> NSHTTPCookieStorageInternal

  • AppController.m: (-[AppController deleteAllCookies]):
  • Preferences.subproj/AcceptedCookies.m: (compareByDomain): (compareByName): (compareByPath): (compareBySecure): (compareByExpires): (compareByContents): (-[AcceptedCookies updateCookieData]): (-[AcceptedCookies removeSelectedItems:]): (-[AcceptedCookies tableView:objectValueForTableColumn:row:]): (-[AcceptedCookies registerForCookieChangeNotifications]):
  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):
9:17 AM Changeset in webkit [4218] by kocienda
  • 4 edits in trunk/WebKit

WebFoundation:

Reviewed by Darin

Changed file names for cookie-related classes.
With the exception of moving some constants
around, the contents of the files themselves
remain unchanged.

WebCookie -> NSHTTPCookie.
WebCookieManager -> NSHTTPCookieStorage.

  • CookieManager.subproj/NSHTTPCookie.h:
  • CookieManager.subproj/NSHTTPCookie.m:
  • CookieManager.subproj/NSHTTPCookiePrivate.h:
  • CookieManager.subproj/NSHTTPCookieStorage.h:
  • CookieManager.subproj/NSHTTPCookieStorage.m:
  • CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
  • CookieManager.subproj/WebCookie.h: Removed.
  • CookieManager.subproj/WebCookie.m: Removed.
  • CookieManager.subproj/WebCookieManager.h: Removed.
  • CookieManager.subproj/WebCookieManager.m: Removed.
  • CookieManager.subproj/WebCookieManagerPrivate.h: Removed.
  • CookieManager.subproj/WebCookiePrivate.h: Removed.
  • CookieManager.subproj/WebCookieStorage.m:
  • CookieManager.subproj/WebCookieStorageServer.m:
  • Misc.subproj/WebFoundation.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m:
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Darin

Changed file names for these classes. The contents
of the files themselves remain unchanged.

WebCookie -> NSHTTPCookie.
WebCookieManager -> NSHTTPCookieStorage.

  • WebCoreSupport.subproj/WebCookieAdapter.m:
  • WebView.subproj/WebMainResourceClient.m:

WebBrowser:

Reviewed by Darin

Changed file names for these classes. The contents
of the files themselves remain unchanged.

WebCookie -> NSHTTPCookie.
WebCookieManager -> NSHTTPCookieStorage.

  • AppController.m:
  • Preferences.subproj/AcceptedCookies.m:
  • Preferences.subproj/SecurityPreferences.m:
8:22 AM Changeset in webkit [4217] by darin
  • 3 edits in trunk/WebKit

Reviewed by Ken.

  • make change to avoid misunderstanding that led to bug report 3179394 "Safari: Request that temp files use actual file extensions"
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Don't put a dot between "SafariPlugInStream" and the the 6-digit unique number, so the number does not look like an extension. Also make it "WebKitPlugInStream" since this is used for other WebKit clients, and not just Safari.
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
Note: See TracTimeline for information about the timeline view.