Timeline



May 5, 2003:

10:28 PM Changeset in webkit [4282] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Don.

  • fixed 3239961 - www.phiffer.com doesn't work; uses "var top; top = n;"
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Check if the property exists with getDirect() instead of hasProperty().
9:09 PM Changeset in webkit [4281] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3241065 - popcap.com doesn't work in Safari, window.scrollBy fails to work in onLoad

Make sure to do a layout before accessing any window properties or
calling any window functions that require a layout to work
properly.

  • khtml/ecma/kjs_window.cpp: (Window::get): (WindowFunc::tryCall): (Window::updateLayout):
  • khtml/ecma/kjs_window.h:
7:47 PM Changeset in webkit [4280] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Richard.

Fix build by separating mutating data protocol methods into
category on NSMutableURLRequest. Also, formatting fixes.

  • WebView.subproj/WebDataProtocol.h:
  • WebView.subproj/WebDataProtocol.m: (+[NSURLRequest _webDataRequestURLForData:]): (-[NSURLRequest _webDataRequestData]): (-[NSURLRequest _webDataRequestEncoding]): (-[NSURLRequest _webDataRequestMIMEType]): (-[NSURLRequest _webDataRequestBaseURL]): (-[NSURLRequest _webDataRequestExternalRequest]): (-[NSMutableURLRequest _webDataRequestSetData:]):
  • WebView.subproj/WebFrame.m:
4:26 PM Changeset in webkit [4279] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3247722. Make sure the grammar accepts properties with
no values as declarations (albeit bad ones).

Reviewed by darin

  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
10:51 AM Changeset in webkit [4278] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3248587. Refine the crash fix for generated image
content so that we still set the image's intrinsic width
and height properly.

Reviewed by john

  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap):
10:31 AM Changeset in webkit [4277] by hyatt
  • 8 edits in trunk/WebCore

When using the content property in CSS, you can string together
an intermixed list of strings and image URLs. The old code
only supported a single image URL, and if you tried to mix
text in with images, you ended up crashing.

The crash bug is 3248172. The fix is to maintain a list of
ContentData objects instead of just a single object and to
ensure that a whole list of generated content gets made (and
not just a single RenderObject).

Reviewed by john

  • khtml/css/cssstyleselector.cpp: (applyRule)
  • khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
  • khtml/rendering/render_image.cpp: (RenderImage::setStyle): (RenderImage::setContentObject): (RenderImage::updateFromElement):
  • khtml/rendering/render_image.h:
  • khtml/rendering/render_style.cpp: (RenderStyle::setContent): (ContentData::clearContent):
  • khtml/rendering/render_style.h:
10:22 AM Changeset in webkit [4276] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed replaceOccurrencesOfString crash reported in bug 3247249 (not what the bug is about)
  • kwq/KWQTextArea.mm: (-[KWQTextArea text]): Use the length of the replaced text.

May 4, 2003:

9:28 PM Changeset in webkit [4275] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed a storage leak
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Release the timer before setting to nil.
7:57 PM Changeset in webkit [4274] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed 3131534 -- "javascript:window.open()" leads to page not found error
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): For open() calls, if the first parameter is not present, use "" instead of "undefined" as the URL.
  • fixed 3244766 -- window.open() doesn't position window correctly along the y axis
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Fixed the code that flips the y coordinate to take the window height into account.
3:21 PM Changeset in webkit [4273] by hyatt
  • 5 edits in trunk/WebKit

Add smallCaps boolean to the string measuring and drawing
methods. Not actually supported yet.

Reviewed by darin

  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]):
  • Misc.subproj/WebStringTruncator.m: (stringWidth):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:smallCaps:fontFamilies:]):
3:17 PM Changeset in webkit [4272] by hyatt
  • 8 edits in trunk/WebCore

Add smallCaps boolean to the string drawing and measuring
routines. WebCore should be done after this patch, with
the rest of the work being done entirely in WebKit.

Reviewed by darin

  • khtml/rendering/font.cpp: (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths): (Font::width):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText):
  • kwq/WebCoreTextRenderer.h:
3:08 PM Changeset in webkit [4271] by darin
  • 3 edits in trunk/WebKit

Reviewed by John.

  • added validation to "Interface Builder" methods on WebView
  • WebView.subproj/WebView.h: Add NSUserInterfaceValidations protocol so that subclassers know that they can call [super validateUserInterfaceItem:].
  • WebView.subproj/WebView.m: (-[WebView canMakeTextSmaller]): Simplify. (-[WebView canMakeTextLarger]): Simplify. (-[WebView _isLoading]): Added. (-[WebView validateUserInterfaceItem:]): Added. Checks for the six actions we implement, and returns NO if they are not valid.

May 3, 2003:

11:33 AM Changeset in webkit [4270] by hyatt
  • 30 edits in trunk/WebCore

Rename layouted to needsLayout. Add a layoutIfNeeded method
and start using it in places that do if (needsLayout()) layout();

Reviewed by kocienda

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty):
  • khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::recalcStyle):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): (HTMLImageElementImpl::height):
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute):
  • khtml/khtmlview.cpp: (KHTMLView::layout): (KHTMLView::print): (KHTMLView::timerEvent):
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_applet.cpp: (RenderApplet::layout): (RenderEmptyApplet::layout):
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp: (RenderBox::close):
  • khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode): (RenderContainer::removeChild): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode): (RenderContainer::layout):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_form.cpp: (RenderFormElement::layout): (RenderSubmitButton::updateFromElement): (RenderSelect::updateFromElement): (RenderSelect::calcMinMaxWidth): (RenderSelect::layout):
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout): (RenderFrameSet::positionFrames): (RenderFrameSet::userResize): (RenderFrameSet::canResize): (RenderPart::setWidget): (RenderPartObject::updateWidget): (RenderPartObject::layout):
  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::layout):
  • khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::splitInlines): (RenderInline::splitFlow):
  • khtml/rendering/render_layer.cpp: (RenderLayer::checkScrollbarsAfterLayout):
  • khtml/rendering/render_list.cpp: (RenderListItem::layout): (RenderListMarker::setStyle): (RenderListMarker::layout): (RenderListMarker::setPixmap):
  • khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::setNeedsLayout): (RenderObject::information): (RenderObject::dump): (RenderObject::setStyle): (RenderObject::invalidateLayout): (RenderObject::detach):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::paint): (RenderWidget::setQWidget): (RenderWidget::layout):
  • khtml/rendering/render_root.cpp:
  • khtml/rendering/render_table.cpp: (RenderTable::addChild): (RenderTable::layout): (RenderTable::paint): (RenderTable::close): (RenderTable::splitColumn): (RenderTable::appendColumn): (RenderTable::recalcSections): (RenderTableSection::addChild): (RenderTableSection::setCellWidths): (RenderTableSection::layoutRows): (RenderTableSection::recalcCells): (RenderTableRow::addChild): (RenderTableRow::layout): (RenderTableCell::paint):
  • khtml/rendering/render_text.cpp: (RenderText::setText):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): (DocumentImpl::updateStyleSelector):
  • khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::insertBefore): (NodeBaseImpl::replaceChild): (NodeBaseImpl::appendChild):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutForPageWidth):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge needsLayout]):

May 2, 2003:

5:42 PM Changeset in webkit [4269] by mjs
  • 56 edits in trunk

WebFoundation:

Reviewed by Richard.

  • reformatted method prototypes to match AppKit style
  • AuthenticationManager.subproj/NSHTTPAuthenticator.h:
  • AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.h:
  • AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h:
  • AuthenticationManager.subproj/NSURLProtectionSpace.h:
  • AuthenticationManager.subproj/WebCredentialStorage.h:
  • AuthenticationManager.subproj/WebKeychainCredential.h:
  • CacheLoader.subproj/NSURLCache.h:
  • CacheLoader.subproj/NSURLCachePrivate.h:
  • CacheLoader.subproj/NSURLConnection.h:
  • CacheLoader.subproj/NSURLConnectionPrivate.h:
  • CacheLoader.subproj/NSURLConnectionQueue.h:
  • CacheLoader.subproj/NSURLProtocol.h:
  • CacheLoader.subproj/NSURLProtocolClient.h:
  • CacheLoader.subproj/NSURLProtocolPrivate.h:
  • CacheLoader.subproj/NSURLRequest.h:
  • CacheLoader.subproj/NSURLRequestPrivate.h:
  • CacheLoader.subproj/NSURLResponse.h:
  • CacheLoader.subproj/NSURLResponsePrivate.h:
  • CacheLoader.subproj/WebCache.h:
  • CacheLoader.subproj/WebCachePrivate.h:
  • CacheLoader.subproj/WebDiskCache.h:
  • CacheLoader.subproj/WebNetworkSettings.h:
  • CacheLoader.subproj/WebSynchronousDelegate.h:
  • CookieManager.subproj/NSHTTPCookiePrivate.h:
  • CookieManager.subproj/NSHTTPCookieStorage.h:
  • CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
  • CookieManager.subproj/WebCookieStorage.h:
  • CookieManager.subproj/WebCookieStorageServer.h:
  • Database.subproj/WebDatabase.h:
  • Database.subproj/WebFileDatabase.h:
  • Misc.subproj/WebBinaryHeap.h:
  • Misc.subproj/WebFileTypeMappings.h:
  • Misc.subproj/WebHostNameAddressInfo.h:
  • Misc.subproj/WebKeyValuePair.h:
  • Misc.subproj/WebMonitor.h:
  • Misc.subproj/WebMultipartForm.h:
  • Misc.subproj/WebNSArrayExtras.h:
  • Misc.subproj/WebNSCalendarDateExtras.h:
  • Misc.subproj/WebNSDataExtras.h:
  • Misc.subproj/WebNSDictionaryExtras.h:
  • Misc.subproj/WebNSErrorExtras.h:
  • Misc.subproj/WebNSObjectExtras.h:
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSThreadExtras.h:
  • Misc.subproj/WebNSValueExtensions.h:
  • Misc.subproj/WebOrderable.h:
  • Misc.subproj/WebQueue.h:
  • Misc.subproj/WebReadWriteLock.h:
  • Misc.subproj/WebRecursiveReadWriteLock.h:
  • Misc.subproj/WebSpinLock.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h:
  • ProtocolHandlers.subproj/WebFTPProtocol.h:
  • ProtocolHandlers.subproj/WebHTTPProtocol.h:

WebCore:

Reviewed by Richard.

  • reformatted method prototypes to match AppKit style
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreDOMPrivate.h:
  • kwq/WebCoreHistory.h:
  • kwq/WebCoreResourceLoader.h:
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebDOMDocument.h:
  • kwq/WebDOMElement.h:
  • kwq/WebDOMNode.h:

WebKit:

Reviewed by Richard.

  • reformatted method prototypes to match AppKit style
  • remove "Public header file" from headers that are not public
  • fix header doc @method names to match actual method names
  • Carbon.subproj/CarbonWindowAdapter.h:
  • Carbon.subproj/HIViewAdapter.h:
  • DOM.subproj/WebDOMDocument.h:
  • DOM.subproj/WebDOMNode.h:
  • History.subproj/WebBackForwardList.h:
  • History.subproj/WebHistoryItemPrivate.h:
  • History.subproj/WebHistoryPrivate.h:
  • History.subproj/WebURLsWithTitles.h:
  • Misc.subproj/WebIconDatabase.h:
  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebUnicode.h:
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebNetscapePluginStream.h:
  • Plugins.subproj/WebNullPluginView.h:
  • Plugins.subproj/WebPluginViewFactory.h:
  • WebCoreSupport.subproj/WebGlyphBuffer.h:
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRendererFactory.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebDataProtocol.h:
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDebugDOMNode.h:
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.h:
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebPolicyDelegate.h:
  • WebView.subproj/WebPolicyDelegatePrivate.h:
  • WebView.subproj/WebPreferencesPrivate.h:
  • WebView.subproj/WebRenderNode.h:
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebUIDelegate.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebViewPrivate.h:
4:10 PM Changeset in webkit [4268]
  • 8 copies
    1 delete in tags/WebKit-SDK-Beta-1

This commit was manufactured by cvs2svn to create tag
'WebKit-SDK-Beta-1'.

4:10 PM Changeset in webkit [4267] by rjw
  • 3 edits in branches/Safari-77~1-branch

Build hackery for WebKit beta SDK. Installs framework in /System/Library/Frameworks.

1:09 PM Changeset in webkit [4266] by mjs
  • 11 edits in trunk

WebCore:

Reviewed by Darin.

  • fixed 2936175 - MALLORY: please implement onResize
  • khtml/khtmlview.cpp: (KHTMLView::resizeEvent): Put most of this in #if !APPLE_CHANGES, since we already do the relayout and such on resize elswhere.
  • kwq/KWQEvent.h: Add a minimal QResizeEvent.
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendResizeEvent): Send it to the view.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge sendResizeEvent]): Send it to the part.

WebKit:

Reviewed by Darin.

  • fixed 2936175 - MALLORY: please implement onResize
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): If we just resized and we're not printing, make sure to send a resize event after the layout.
12:21 PM Changeset in webkit [4265] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3184113, bottom margins didn't collapse with their children
like they were supposed to. The problem is fixed by separately
caching whether or not the top and bottom margins can collapse
with their kids instead of having one global canCollapse variable.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp:
11:13 AM Changeset in webkit [4264] by darin
  • 10 edits in trunk

WebCore:

Reviewed by John.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scheduleClose): Change to use closeWindowSoon, so that the delay is on the WebKit side so it can be tied to the WebView as a whole, not a particular bridge.
  • kwq/WebCoreBridge.h: Replaced closeWindow with closeWindowSoon.
  • rolled in a couple of harmless and eventually-possibly-useful changes inspired by changes OmniGroup made in their copy of WebCore
  • kwq/KWQListBox.mm: Make KWQTableView a KWQWidgetHolder. (-[KWQTableView widget]): Return the widget.
  • kwq/KWQScrollView.mm: (QScrollView::ensureVisible): First cut at implementing these.

WebKit:

Reviewed by John.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): Replaces closeWindow. Schedule a closeWindow operation in the WebView. Important to not have the call's execution depend on whether this WebBridge or WebFrame is still around after the delay.
  • WebView.subproj/WebViewPrivate.h: Added _closeWindow.
  • WebView.subproj/WebViewPrivate.m: (-[WebView _closeWindow]): Make a webViewClose: call on the UI delegate.
10:39 AM Changeset in webkit [4263] by darin
  • 38 edits in trunk/WebKit

WebKit:

Reviewed by John.

Changed WebFrame to explicitly detach from the bridge so we don't have a stale pointer;
also cleaned up WebBridge initialization.

  • WebCoreSupport.subproj/WebBridge.h: Added initWithWebFrame: and close methods, removed setWebFrame: method.
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webFrameView:webView:]): Use the new initWithWebFrame:.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Call close on the bridge.
  • fixed many places that call a WebView a "controller"
  • Misc.subproj/WebKitStatistics.h:
  • Misc.subproj/WebKitStatistics.m:
  • Misc.subproj/WebKitStatisticsPrivate.h:
  • Misc.subproj/WebNSViewExtras.m:
  • Plugins.subproj/WebBaseNetscapePluginView.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.h:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by John.

  • fixed many places that call a WebView a "controller", including changing the name BrowserWebController to BrowserWebView
  • BrowserDocument.h:
  • BrowserDocument.m:
  • BrowserDocumentController.h:
  • BrowserDocumentController.m:
  • BrowserTabViewItem.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.h:
  • BrowserWebController.m:
  • BrowserWebFrameExtras.h:
  • BrowserWindowController.h:
  • BrowserWindowController.m:
  • ContextMenuHandler.m:
  • Debug/DOMTree.h:
  • Debug/DOMTree.m:
  • Debug/DebugUtilities.m:
  • Debug/RenderTree.h:
  • Debug/RenderTree.m:
  • Debug/ViewTree.h:
  • Debug/ViewTree.m:
  • English.lproj/StringsNotToBeLocalized.txt:
  • FindPanelController.m:
  • FormCompletionController.h:
  • FormCompletionController.m:
  • LoadProgressMonitor.h:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • LocationChangeHandler.h:
  • LocationChangeHandler.m:
  • Test/PageLoadTestRunner.m:
10:22 AM Changeset in webkit [4262] by hyatt
  • 3 edits in trunk/WebCore

Make sure that recalcSections always clears out the needSectionRecalc
boolean, even in the case where it finds column elements.

Fixes the assert outlined in bug 3237651.

Reviewed by john

  • khtml/rendering/render_table.cpp: (RenderTable::recalcSections):
8:52 AM Changeset in webkit [4261] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3226030, percentage height tables inside table cells
don't grow to fill the space inside the cell. There was
a missing edge case here for the case where the table was
nested inside a table cell.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTable::layout):

May 1, 2003:

5:53 PM Changeset in webkit [4260] by hyatt
  • 3 edits in trunk/WebCore

Add a cycle check when importing stylesheets to prevent
infinite loops.

Reviewed by john

  • khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::init):
5:12 PM Changeset in webkit [4259] by hyatt
  • 4 edits in trunk/WebCore

Table rows don't know their precise dimensions, so repainting
them fails. For now, just make an invalidation of a table
row due to CSS changes invalidate the whole table.

This is what the old Safari table code used to do prior to the
new table code landing.

Fixes bug #3205092.

Reviewed by darin/john

  • khtml/rendering/render_table.cpp: (RenderTableRow::repaint):
  • khtml/rendering/render_table.h:
4:30 PM Changeset in webkit [4258] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3232637, don't let generated parentless image content
try to do width/height/layout calculations. It will do this
all anyway, when it finally gets inserted into the rendering
tree.

Reviewed by john

  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap):
4:01 PM Changeset in webkit [4257] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3239404, a crash caused because a block-level :after
element was being inserted as generated content inside an
inline element.

The fix is to mutate the display of the generated content to
be inline when the parent of the generated content is also
inline.

Section 12.1 of the CSS2 spec (at the very end of the spec)
covers this special case. Once we do the mutation it becomes
impossible for generated content to cause a splitFlow, and so
the crash is plugged.

Reviewed by john

  • khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
3:31 PM Changeset in webkit [4256] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3246045 -- History items without a valid date in History.plist show up with unexpected dates in UI

Reviewed by Darin.

  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]): don't set lastVisitedTimeInterval to [nil doubleValue], since this is random
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
3:13 PM Changeset in webkit [4255] by rjw
  • 2 edits in branches/Safari-77~1-branch/WebKit

Merged from HEAD:

Added missing header and alphabetized.

Reviewed by Ken.

  • Misc.subproj/WebKit.h:
3:11 PM Changeset in webkit [4254] by rjw
  • 2 edits in trunk/WebKit

Added missing header and alphabetized.

Reviewed by Ken.

  • Misc.subproj/WebKit.h:
3:10 PM Changeset in webkit [4253] by hyatt
  • 9 edits in trunk/WebCore

Replace effectiveWidth and effectiveHeight with a
parameterized overflowWidth/Height, since this is much better
terminology.

Also fix event handling so that it no longer assumes (incorrectly)
that being inside the overflow rect of an object means you are
inside the object. Now there are two separate checks, with the
overflow check being used only to figure out if you should check
inside your kids.

Reviewed by darin

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::repaint):
  • khtml/rendering/render_flow.cpp: (RenderFlow::repaint):
  • khtml/rendering/render_object.cpp: (RenderObject::nodeAtPoint):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_table.h:
2:44 PM Changeset in webkit [4252] by cblu
  • 6 edits in trunk/WebKit

WebKit:

Fixed: 3234888 - REGRESSION: "can't add a plug-in to a defunct WebPluginController" error, then crash
Fixed: 3226392 - REGRESSION: Safari crashed while loading Java applet at PopCap.com

Reviewed by darin.

  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame setController:]): fixed comment
  • WebView.subproj/WebView.m: (-[WebView dealloc]): call [self _close]
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate dealloc]): let the WebView class clear the frames (-[WebView _close]): remove self from controller set and detach and release frame

WebBrowser:

Fixed: 3234888 - REGRESSION: "can't add a plug-in to a defunct WebPluginController" error, then crash
Fixed: 3226392 - REGRESSION: Safari crashed while loading Java applet at PopCap.com

Reviewed by darin.

  • BrowserWebController.m: (-[BrowserWebController close]): call [self _close]
2:31 PM Changeset in webkit [4251] by sheridan
  • 3 edits in trunk

Safari-78u versionstamp

1:39 PM Changeset in webkit [4250]
  • 3 copies
    1 delete in branches/Safari-77~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-77~1-branch'.

1:39 PM Changeset in webkit [4249]
  • 3 copies
    1 delete in tags/Safari-77~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-77~1-anchor'.

1:39 PM Changeset in webkit [4248]
  • 3 copies
    1 delete in tags/Safari-77

This commit was manufactured by cvs2svn to create tag 'Safari-77'.

1:39 PM Changeset in webkit [4247] by sheridan
  • 8 edits in trunk

Safari-77 stamp

12:19 PM Changeset in webkit [4246] by sullivan
  • 2 edits in trunk/WebKit
  • fixed 3245793 -- Launching Safari-75 after tip of tree erases all history

Reviewed by Chris, Don

  • History.subproj/WebHistoryItem.m: keep using "lastVisitedDate" as the dictionary key, since old Safaris otherwise can't read the History file. (-[WebHistoryItem dictionaryRepresentation]): keep storing the time interval as a string, since old Safaris otherwise can't read the History file (-[WebHistoryItem initFromDictionaryRepresentation:]): read the stored date as a string and convert to a double, as we did before.
11:24 AM Changeset in webkit [4245] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3244157, giantrobot.com misrenders with a lot of
vertical space. Overflow heights were being miscomputed for
overflow:auto blocks.

Reviewed by gramps

  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
9:44 AM Changeset in webkit [4244] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed 3169117 -- dragging while using a scroll wheel affects scroll movement
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebNSWindow nextEventMatchingMask:untilDate:inMode:dequeue:]): Just return nil when called with NSScrollWheelMask to work around the bug where any kind of event can be returned when this mask is passed. This will prevent scroll wheel events from being coalesced, but it's better than extracting events of all different types. Mouse moved events are particularly bad because they have deltaX/Y/Z and the scroll wheel code in NSScrollView treats them as if they were scroll wheel events.
9:35 AM Changeset in webkit [4243]
  • 1 copy
    61 deletes in tags/WebFoundation-77~1

This commit was manufactured by cvs2svn to create tag
'WebFoundation-77~1'.

9:35 AM Changeset in webkit [4242] by kocienda
  • 4 edits in trunk/WebKit/Misc.subproj

Reviewed by Gramps

Updated copyright notices on every header and
implementation file in the framework.

9:33 AM Changeset in webkit [4241] by kocienda
  • 2 edits in trunk/WebKit

Tests:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.
Note that there are some discrepancies in the
test results, but they seem to be the result
of changes in the way we handle cookie paths,
an aspect of cookies I did not change at all
with this patch. The difference must have
crept in some time ago.

  • CookieManager/wkcookie-test.chk:
  • CookieManager/wkcookiemanager-test.chk:
  • CookieManager/wkcookiemanager-test.m: (main):

WebFoundation:

Reviewed by Darin

Updated to provide and use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-setAcceptPolicy: -> -setCookieAcceptPolicy:
-acceptPolicy -> -cookieAcceptPolicy
-cookieRequestHeaderFieldsForURL: -> -cookiesForURL:
-setCookiesFromResponseHeader:forURL:policyBaseURL: -> -setCookies:forURL:mainDocumentURL:

Added back compare: method in NSHTTPCookie. Our tests use it.

  • CookieManager.subproj/NSHTTPCookie.m: (-[NSHTTPCookie compare:]):
  • CookieManager.subproj/NSHTTPCookieStorage.h:
  • CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _cookieRequestHeaderFieldsForURL:withExtraCookies:]): (-[NSHTTPCookieStorage _cookiesForURL:withExtraCookies:]): (-[NSHTTPCookieStorage init]): (+[NSHTTPCookieStorage sharedHTTPCookieStorage]): (-[NSHTTPCookieStorage cookiesForURL:]): (-[NSHTTPCookieStorage setCookies:forURL:mainDocumentURL:]): (-[NSHTTPCookieStorage cookieAcceptPolicy]): (-[NSHTTPCookieStorage setCookieAcceptPolicy:]):
  • CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.m: (-[WebCFNetworkHTTPProtocol addCookieFieldToHeader]): (-[WebCFNetworkHTTPProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocol.m: (-[WebSimpleHTTPProtocol buildHTTPRequest]): (-[WebSimpleHTTPProtocol _parseHeaderFromData:]):

WebKit:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-acceptPolicy -> -cookieAcceptPolicy
-cookieRequestHeaderFieldsForURL: -> -cookiesForURL:
-setCookiesFromResponseHeader:forURL:policyBaseURL: -> -setCookies:forURL:mainDocumentURL:

  • WebCoreSupport.subproj/WebCookieAdapter.m: (-[WebCookieAdapter cookiesEnabled]): (-[WebCookieAdapter cookiesForURL:]): (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):

WebBrowser:

Reviewed by Darin

Updated to use approved NSHTTPCookieStorage API.

+sharedCookieManager -> +sharedHTTPCookieStorage
-setAcceptPolicy: -> -setCookieAcceptPolicy:
-acceptPolicy -> -cookieAcceptPolicy

  • AppController.m: (-[AppController deleteAllCookies]):
  • Preferences.subproj/AcceptedCookies.m: (-[AcceptedCookies updateCookieData]): (-[AcceptedCookies removeSelectedItems:]): (-[AcceptedCookies registerForCookieChangeNotifications]):
  • Preferences.subproj/SecurityPreferences.m: (-[SecurityPreferences takeCookiePolicyFrom:]): (-[SecurityPreferences updateCookiesViews]):
12:06 AM Changeset in webkit [4240] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
Note: See TracTimeline for information about the timeline view.