Timeline



May 6, 2003:

6:56 PM Changeset in webkit [4301]
  • 21 copies
    1 delete in tags/Safari-77~1

This commit was manufactured by cvs2svn to create tag 'Safari-77~1'.

6:56 PM Changeset in webkit [4300] by rjw
  • 2 edits in branches/Safari-77~1-branch

Revert framework references in project.pbxproj.

6:11 PM Changeset in webkit [4299] by darin
  • 12 edits in trunk/WebCore

Reviewed by Chris.

  • fixed 3211756 -- form field contents on the left instead of right on page in RtL language
  • khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): Call setAlignment based on the style's direction. (RenderTextArea::updateFromElement): Ditto.
  • kwq/KWQLineEdit.h: Added setAlignment.
  • kwq/KWQLineEdit.mm: (QLineEdit::setAlignment): Added. Calls setAlignment on KWQTextField.
  • kwq/KWQTextArea.h: Added setAlignment.
  • kwq/KWQTextArea.mm: (-[KWQTextArea setAlignment:]): Added. Calls setAlignment on NSTextView.
  • kwq/KWQTextEdit.h: Added setAlignment.
  • kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Added. Calls setAlignment on KWQTextField.
  • kwq/KWQTextField.mm: (-[KWQTextField setAlignment:]): Added. Call setAlignment on secure text field too.
  • fixed 3250538 -- on pages labeled "US-ASCII", non-ASCII chars are not decoded as Latin-1 as in other browsers
  • kwq/KWQTextCodec.mm: (effectiveEncoding): Added. Maps ISO Latin-1 and US-ASCII to Windows Latin-1. (QTextCodec::fromUnicode): Use effectiveEncoding. (KWQTextDecoder::convertUsingTEC): Use effectiveEncoding.
  • other changes
  • kwq/KWQCharsets.mm: (buildDictionaries): Make the first encoding in the file win for purposes of deciding which name is used. I thought this was happening before, but actually the last one was winning. Do this by using CFDictionaryAddValue, which does nothing if there's already a dictionary entry, instead of CFDictionarySetValue, which replaces.
6:06 PM Changeset in webkit [4298] by rjw
  • 8 edits in branches/Safari-77~1-branch/WebKit

Fixed build problems caused by mistaken additional merge.

5:43 PM Changeset in webkit [4297] by rjw
  • 8 edits in branches/Safari-77~1-branch

Backed out install name and release directory change.
Frameworks will be private for one more release.

  • WebKit.pbproj/project.pbxproj:
5:31 PM Changeset in webkit [4296] by rjw
  • 7 edits in branches/Safari-77~1-branch/WebKit

Merged changes from HEAD:

Fixed problem for HelpViewer. HV calls stopLoading in
a webView:resource:didReceiveResponse. This causes
the premature release of the connection delegate.

Reviewed by Ken.

  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connectionDidFinishLoading:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate dealloc]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient stopLoadingForPolicyChange]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient continueAfterContentPolicy:]): (-[WebMainResourceClient connection:didReceiveResponse:]): (-[WebMainResourceClient connectionDidFinishLoading:]):
5:15 PM Changeset in webkit [4295] by rjw
  • 8 edits in trunk/WebKit

Fixed problem for HelpViewer. HV calls stopLoading in
a webView:resource:didReceiveResponse. This causes
the premature release of the connection delegate.

Reviewed by Ken.

  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connectionDidFinishLoading:]):
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate dealloc]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient stopLoadingForPolicyChange]): (-[WebMainResourceClient continueAfterContentPolicy:response:]): (-[WebMainResourceClient continueAfterContentPolicy:]): (-[WebMainResourceClient connection:didReceiveResponse:]): (-[WebMainResourceClient connectionDidFinishLoading:]):
3:26 PM Changeset in webkit [4294] by hyatt
  • 11 edits in trunk/WebCore

Make negative z-index content paint above the background of
the stacking context element that encloses it. This fixes
gettyimages.com and hotwired.com.

Reviewed by kocienda

  • khtml/css/html4.css:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_inline.cpp: (RenderInline::paintObject):
  • khtml/rendering/render_layer.cpp: (RenderLayer::paint): (RenderLayer::nodeAtPoint): (RenderLayer::RenderZTreeNode::constructLayerList):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_root.cpp:
  • khtml/rendering/render_table.cpp: (RenderTable::paint):
  • kwq/KWQRenderTreeDebug.cpp: (write):
2:31 PM Changeset in webkit [4293] by darin
  • 1 edit
    1 delete in trunk/WebKit
  • removed obsolete file that's still around for some reason
  • Downloads.subproj/WebDownload.m: Removed.
1:28 PM Changeset in webkit [4292] by darin
  • 2 edits in trunk/WebKit
  • fixed crash on startup
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): Allocate WebHistoryItemPrivate.
11:26 AM Changeset in webkit [4291] by rjw
  • 8 edits in branches/Safari-77~1-branch

Changed install names and release directory to
/System/Library/Frameworks.

11:11 AM Changeset in webkit [4290] by kocienda
  • 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Reviewed by Richard

Refactored memory and disk cache. All the implementation
for the memory and disk caches are now concentrated in one
file, NSURLCache.m. This spells the end for the WebCache,
WebMemoryCache and WebDiskCache files. It also enabled
me to implement the API-approved design which calls upon
NSURLProtocol to make a determination about the cache
equivalence of cached objects.

NSURLRequest and friends are now codable.

WebLRUFileList gets a new function: WebLRUFileListContainsItem.

In WebNSFileManagerExtras, I fixed a gibberish method name:

_web_deleteBackgroundRemoveLeftoverFiles:

is now

_web_backgroundRemoveLeftoverFiles:

  • CacheLoader.subproj/NSURLCache.m: (-[NSURLCacheInternal dealloc]): (-[NSURLCacheNode initWithCachedResponse:request:key:]): (-[NSURLCacheNode isEqual:]): (-[NSURLCacheNode description]): (-[NSURLCacheNode dealloc]): (MemoryCacheRemoveNodeFromLRUList): (MemoryCacheAppendNodeToLRUList): (MemoryCacheTouchNode): (MemoryCacheTruncate): (MemoryCacheGet): (MemoryCacheSet): (MemoryCacheRemove): (MemoryCacheClear): (DiskCacheDefaultPath): (DiskCacheUniqueFilePathForKey): (DiskCacheCreateDirectory): (DiskCacheGet): (DiskCacheClear): (DiskCacheTruncate): (DiskCacheScheduleWrite): (DiskCacheExecuteWrite): (DiskCacheScheduleRemoval): (DiskCacheExecuteRemoval): (+[NSURLCache _diskCacheSyncLoop:]): (-[NSURLCache _setDiskCacheSyncTimer]): (-[NSURLCache _diskCacheSync:]): (-[NSURLCache _createDiskCacheLRUList:]): (NSURLCacheInit): (NSURLCacheCreateSharedInstance): (+[NSURLCache sharedURLCache]): (-[NSURLCache initWithMemoryCapacity:diskCapacity:diskPath:]): (-[NSURLCache cachedResponseForRequest:]): (-[NSURLCache storeCachedResponse:forRequest:]): (-[NSURLCache removeCachedResponseForRequest:]): (-[NSURLCache removeAllCachedResponses]): (-[NSURLCache memoryCapacity]): (-[NSURLCache diskCapacity]): (-[NSURLCache setMemoryCapacity:]): (-[NSURLCache setDiskCapacity:]): (-[NSURLCache currentMemoryUsage]): (-[NSURLCache currentDiskUsage]): (-[NSURLCache _cacheStatistics]):
  • CacheLoader.subproj/NSURLRequest.h:
  • CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest initWithCoder:]): (-[NSURLRequest encodeWithCoder:]): (-[NSURLRequest HTTPMethod]): (-[NSURLRequest allHTTPHeaderFields]): (-[NSURLRequest valueForHTTPHeaderField:]): (-[NSURLRequest HTTPBody]): (-[NSURLRequest allowsHTTPSCertificatesWithUnknownRoots]): (-[NSURLRequest HTTPCookiePolicyBaseURL]): (-[NSURLRequest HTTPExtraCookies]): (-[NSURLRequest HTTPPageNotFoundCacheLifetime]): (-[NSURLRequest HTTPShouldHandleCookies]): (-[NSMutableURLRequest _parametersForWriting]): (-[NSMutableURLRequest setHTTPMethod:]): (-[NSMutableURLRequest setAllHTTPHeaderFields:]): (-[NSMutableURLRequest setValue:forHTTPHeaderField:]): (-[NSMutableURLRequest addValue:forHTTPHeaderField:]): (-[NSMutableURLRequest setHTTPBody:]): (-[NSMutableURLRequest setAllowsHTTPSCertificatesWithUnknownRoots:]): (-[NSMutableURLRequest setHTTPCookiePolicyBaseURL:]): (-[NSMutableURLRequest setHTTPExtraCookies:]): (-[NSMutableURLRequest setHTTPPageNotFoundCacheLifetime:]): (-[NSMutableURLRequest setHTTPShouldHandleCookies:]): (-[NSHTTPURLRequestParameters initWithCoder:]): (-[NSHTTPURLRequestParameters encodeWithCoder:]): (-[NSHTTPURLRequestParameters copyWithZone:]): (-[NSHTTPURLRequestParameters mutableCopyWithZone:]): (-[NSHTTPURLRequestParameters isEqual:]):
  • CacheLoader.subproj/WebCache.h: Removed.
  • CacheLoader.subproj/WebCache.m: Removed.
  • CacheLoader.subproj/WebCachePrivate.h: Removed.
  • CacheLoader.subproj/WebDiskCache.h: Removed.
  • CacheLoader.subproj/WebDiskCache.m: Removed.
  • CacheLoader.subproj/WebMemoryCache.h: Removed.
  • CacheLoader.subproj/WebMemoryCache.m: Removed.
  • Database.subproj/WebFileDatabase.m: (-[WebFileDatabase open]):
  • Database.subproj/WebLRUFileList.h:
  • Database.subproj/WebLRUFileList.m: (WebLRUFileListContainsItem):
  • Misc.subproj/WebNSFileManagerExtras.h:
  • Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_backgroundRemoveLeftoverFiles:]):
  • WebFoundation.pbproj/project.pbxproj:
10:50 AM Changeset in webkit [4289] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Darin.

  • fixed 3245048 - "Block Pop-Up Windows" can easily be bypassed using javascript: URLs

Closed the loophole by tracking what client redirects were
triggered by user actions, and making sure the script interpreter
knows.

  • khtml/ecma/kjs_window.cpp: (Window::put): (WindowFunc::tryCall): (Location::put): (LocationFunc::tryCall):
  • khtml/khtml_part.cpp: (KHTMLPart::executeScript): (KHTMLPart::clear): (KHTMLPart::scheduleRedirection): (KHTMLPart::slotRedirect): (KHTMLPart::urlSelected):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:]):
10:47 AM Changeset in webkit [4288]
  • 21 copies in tags/Safari-73~5

This commit was manufactured by cvs2svn to create tag 'Safari-73~5'.

10:47 AM Changeset in webkit [4287] by darin
  • 2 edits in branches/Safari-73~1-branch/WebKit

Rolled in change from trunk.

2003-05-06 Darin Adler <Darin Adler>

  • fixed 3249211 -- WebTextRenderer.h should not use "AttributeGroup" type for styleGroup
  • WebCoreSupport.subproj/WebTextRenderer.h: Update to use ATSStyleGroupPtr.
10:43 AM Changeset in webkit [4286] by darin
  • 2 edits in branches/Safari-77~1-branch/WebKit

Rolled in change from main trunk.

2003-05-06 Darin Adler <Darin Adler>

  • fixed 3249211 -- WebTextRenderer.h should not use "AttributeGroup" type for styleGroup
  • WebCoreSupport.subproj/WebTextRenderer.h: Update to use ATSStyleGroupPtr.
10:42 AM Changeset in webkit [4285] by darin
  • 2 edits in trunk/WebKit
  • fixed 3249211 -- WebTextRenderer.h should not use "AttributeGroup" type for styleGroup
  • WebCoreSupport.subproj/WebTextRenderer.h: Update to use ATSStyleGroupPtr.
9:20 AM Changeset in webkit [4284] by darin
  • 4 edits in trunk/WebKit

Reviewed by Ken.

  • used ObjectAlloc to find large numbers of allocations on startup and get rid of some
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem initFromDictionaryRepresentation:]): Use the init method that takes a URL string so we don't have to create and then destroy a URL for each item we decode.
  • History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addItem:]): Use URLString instead of making and destroying a URL each time this is called. (-[WebHistoryPrivate removeItem:]): Ditto. (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): Check URLString for nil; no reason to construct and then destroy a URL just to check validity.
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (FontCacheKeyCopy): Added. (FontCacheKeyFree): Added. (FontCacheKeyEqual): Added. (FontCacheKeyHash): Added. (FontCacheValueRetain): Added. (FontCacheValueRelease): Added. (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]): Use a C struct for the font cache key instead of using an Objective-C object. This saves us an object allocation and deallocation when doing a lookup. Also took advantage of the CFDictionary ability to store NULL and distinguish it from "not found" so we don't need a separate set for cache misses.
8:59 AM Changeset in webkit [4283] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • used ObjectAlloc to find large numbers of allocations on startup and get rid of some
  • kwq/KWQColor.mm: (QColor::getNSColor): Keep a cache of 32 colors instead of returning a new one each time. Also use special cases for black and white.

May 5, 2003:

10:28 PM Changeset in webkit [4282] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Don.

  • fixed 3239961 - www.phiffer.com doesn't work; uses "var top; top = n;"
  • kjs/nodes.cpp: (VarDeclNode::evaluate): Check if the property exists with getDirect() instead of hasProperty().
9:09 PM Changeset in webkit [4281] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • fixed 3241065 - popcap.com doesn't work in Safari, window.scrollBy fails to work in onLoad

Make sure to do a layout before accessing any window properties or
calling any window functions that require a layout to work
properly.

  • khtml/ecma/kjs_window.cpp: (Window::get): (WindowFunc::tryCall): (Window::updateLayout):
  • khtml/ecma/kjs_window.h:
7:47 PM Changeset in webkit [4280] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Richard.

Fix build by separating mutating data protocol methods into
category on NSMutableURLRequest. Also, formatting fixes.

  • WebView.subproj/WebDataProtocol.h:
  • WebView.subproj/WebDataProtocol.m: (+[NSURLRequest _webDataRequestURLForData:]): (-[NSURLRequest _webDataRequestData]): (-[NSURLRequest _webDataRequestEncoding]): (-[NSURLRequest _webDataRequestMIMEType]): (-[NSURLRequest _webDataRequestBaseURL]): (-[NSURLRequest _webDataRequestExternalRequest]): (-[NSMutableURLRequest _webDataRequestSetData:]):
  • WebView.subproj/WebFrame.m:
4:26 PM Changeset in webkit [4279] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3247722. Make sure the grammar accepts properties with
no values as declarations (albeit bad ones).

Reviewed by darin

  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
10:51 AM Changeset in webkit [4278] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3248587. Refine the crash fix for generated image
content so that we still set the image's intrinsic width
and height properly.

Reviewed by john

  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap):
10:31 AM Changeset in webkit [4277] by hyatt
  • 8 edits in trunk/WebCore

When using the content property in CSS, you can string together
an intermixed list of strings and image URLs. The old code
only supported a single image URL, and if you tried to mix
text in with images, you ended up crashing.

The crash bug is 3248172. The fix is to maintain a list of
ContentData objects instead of just a single object and to
ensure that a whole list of generated content gets made (and
not just a single RenderObject).

Reviewed by john

  • khtml/css/cssstyleselector.cpp: (applyRule)
  • khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
  • khtml/rendering/render_image.cpp: (RenderImage::setStyle): (RenderImage::setContentObject): (RenderImage::updateFromElement):
  • khtml/rendering/render_image.h:
  • khtml/rendering/render_style.cpp: (RenderStyle::setContent): (ContentData::clearContent):
  • khtml/rendering/render_style.h:
10:22 AM Changeset in webkit [4276] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed replaceOccurrencesOfString crash reported in bug 3247249 (not what the bug is about)
  • kwq/KWQTextArea.mm: (-[KWQTextArea text]): Use the length of the replaced text.

May 4, 2003:

9:28 PM Changeset in webkit [4275] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed a storage leak
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _setState:]): Release the timer before setting to nil.
7:57 PM Changeset in webkit [4274] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed 3131534 -- "javascript:window.open()" leads to page not found error
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): For open() calls, if the first parameter is not present, use "" instead of "undefined" as the URL.
  • fixed 3244766 -- window.open() doesn't position window correctly along the y axis
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Fixed the code that flips the y coordinate to take the window height into account.
3:21 PM Changeset in webkit [4273] by hyatt
  • 5 edits in trunk/WebKit

Add smallCaps boolean to the string measuring and drawing
methods. Not actually supported yet.

Reviewed by darin

  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthWithFont:]):
  • Misc.subproj/WebStringTruncator.m: (stringWidth):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:smallCaps:fontFamilies:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:smallCaps:fontFamilies:]):
3:17 PM Changeset in webkit [4272] by hyatt
  • 8 edits in trunk/WebCore

Add smallCaps boolean to the string drawing and measuring
routines. WebCore should be done after this patch, with
the rest of the work being done entirely in WebKit.

Reviewed by darin

  • khtml/rendering/font.cpp: (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths): (Font::width):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText):
  • kwq/WebCoreTextRenderer.h:
3:08 PM Changeset in webkit [4271] by darin
  • 3 edits in trunk/WebKit

Reviewed by John.

  • added validation to "Interface Builder" methods on WebView
  • WebView.subproj/WebView.h: Add NSUserInterfaceValidations protocol so that subclassers know that they can call [super validateUserInterfaceItem:].
  • WebView.subproj/WebView.m: (-[WebView canMakeTextSmaller]): Simplify. (-[WebView canMakeTextLarger]): Simplify. (-[WebView _isLoading]): Added. (-[WebView validateUserInterfaceItem:]): Added. Checks for the six actions we implement, and returns NO if they are not valid.

May 3, 2003:

11:33 AM Changeset in webkit [4270] by hyatt
  • 30 edits in trunk/WebCore

Rename layouted to needsLayout. Add a layoutIfNeeded method
and start using it in places that do if (needsLayout()) layout();

Reviewed by kocienda

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty):
  • khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::recalcStyle):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::width): (HTMLImageElementImpl::height):
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute):
  • khtml/khtmlview.cpp: (KHTMLView::layout): (KHTMLView::print): (KHTMLView::timerEvent):
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_applet.cpp: (RenderApplet::layout): (RenderEmptyApplet::layout):
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp: (RenderBox::close):
  • khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode): (RenderContainer::removeChild): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode): (RenderContainer::layout):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_form.cpp: (RenderFormElement::layout): (RenderSubmitButton::updateFromElement): (RenderSelect::updateFromElement): (RenderSelect::calcMinMaxWidth): (RenderSelect::layout):
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout): (RenderFrameSet::positionFrames): (RenderFrameSet::userResize): (RenderFrameSet::canResize): (RenderPart::setWidget): (RenderPartObject::updateWidget): (RenderPartObject::layout):
  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): (RenderImage::layout):
  • khtml/rendering/render_inline.cpp: (RenderInline::addChildToFlow): (RenderInline::splitInlines): (RenderInline::splitFlow):
  • khtml/rendering/render_layer.cpp: (RenderLayer::checkScrollbarsAfterLayout):
  • khtml/rendering/render_list.cpp: (RenderListItem::layout): (RenderListMarker::setStyle): (RenderListMarker::layout): (RenderListMarker::setPixmap):
  • khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::setNeedsLayout): (RenderObject::information): (RenderObject::dump): (RenderObject::setStyle): (RenderObject::invalidateLayout): (RenderObject::detach):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::paint): (RenderWidget::setQWidget): (RenderWidget::layout):
  • khtml/rendering/render_root.cpp:
  • khtml/rendering/render_table.cpp: (RenderTable::addChild): (RenderTable::layout): (RenderTable::paint): (RenderTable::close): (RenderTable::splitColumn): (RenderTable::appendColumn): (RenderTable::recalcSections): (RenderTableSection::addChild): (RenderTableSection::setCellWidths): (RenderTableSection::layoutRows): (RenderTableSection::recalcCells): (RenderTableRow::addChild): (RenderTableRow::layout): (RenderTableCell::paint):
  • khtml/rendering/render_text.cpp: (RenderText::setText):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): (DocumentImpl::updateStyleSelector):
  • khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::insertBefore): (NodeBaseImpl::replaceChild): (NodeBaseImpl::appendChild):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutForPageWidth):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge needsLayout]):

May 2, 2003:

5:42 PM Changeset in webkit [4269] by mjs
  • 56 edits in trunk

WebFoundation:

Reviewed by Richard.

  • reformatted method prototypes to match AppKit style
  • AuthenticationManager.subproj/NSHTTPAuthenticator.h:
  • AuthenticationManager.subproj/NSURLConnectionAuthenticationChallenge.h:
  • AuthenticationManager.subproj/NSURLDownloadAuthenticationChallenge.h:
  • AuthenticationManager.subproj/NSURLProtectionSpace.h:
  • AuthenticationManager.subproj/WebCredentialStorage.h:
  • AuthenticationManager.subproj/WebKeychainCredential.h:
  • CacheLoader.subproj/NSURLCache.h:
  • CacheLoader.subproj/NSURLCachePrivate.h:
  • CacheLoader.subproj/NSURLConnection.h:
  • CacheLoader.subproj/NSURLConnectionPrivate.h:
  • CacheLoader.subproj/NSURLConnectionQueue.h:
  • CacheLoader.subproj/NSURLProtocol.h:
  • CacheLoader.subproj/NSURLProtocolClient.h:
  • CacheLoader.subproj/NSURLProtocolPrivate.h:
  • CacheLoader.subproj/NSURLRequest.h:
  • CacheLoader.subproj/NSURLRequestPrivate.h:
  • CacheLoader.subproj/NSURLResponse.h:
  • CacheLoader.subproj/NSURLResponsePrivate.h:
  • CacheLoader.subproj/WebCache.h:
  • CacheLoader.subproj/WebCachePrivate.h:
  • CacheLoader.subproj/WebDiskCache.h:
  • CacheLoader.subproj/WebNetworkSettings.h:
  • CacheLoader.subproj/WebSynchronousDelegate.h:
  • CookieManager.subproj/NSHTTPCookiePrivate.h:
  • CookieManager.subproj/NSHTTPCookieStorage.h:
  • CookieManager.subproj/NSHTTPCookieStoragePrivate.h:
  • CookieManager.subproj/WebCookieStorage.h:
  • CookieManager.subproj/WebCookieStorageServer.h:
  • Database.subproj/WebDatabase.h:
  • Database.subproj/WebFileDatabase.h:
  • Misc.subproj/WebBinaryHeap.h:
  • Misc.subproj/WebFileTypeMappings.h:
  • Misc.subproj/WebHostNameAddressInfo.h:
  • Misc.subproj/WebKeyValuePair.h:
  • Misc.subproj/WebMonitor.h:
  • Misc.subproj/WebMultipartForm.h:
  • Misc.subproj/WebNSArrayExtras.h:
  • Misc.subproj/WebNSCalendarDateExtras.h:
  • Misc.subproj/WebNSDataExtras.h:
  • Misc.subproj/WebNSDictionaryExtras.h:
  • Misc.subproj/WebNSErrorExtras.h:
  • Misc.subproj/WebNSObjectExtras.h:
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSThreadExtras.h:
  • Misc.subproj/WebNSValueExtensions.h:
  • Misc.subproj/WebOrderable.h:
  • Misc.subproj/WebQueue.h:
  • Misc.subproj/WebReadWriteLock.h:
  • Misc.subproj/WebRecursiveReadWriteLock.h:
  • Misc.subproj/WebSpinLock.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocol.h:
  • ProtocolHandlers.subproj/WebFTPProtocol.h:
  • ProtocolHandlers.subproj/WebHTTPProtocol.h:

WebCore:

Reviewed by Richard.

  • reformatted method prototypes to match AppKit style
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreDOMPrivate.h:
  • kwq/WebCoreHistory.h:
  • kwq/WebCoreResourceLoader.h:
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebDOMDocument.h:
  • kwq/WebDOMElement.h:
  • kwq/WebDOMNode.h:

WebKit:

Reviewed by Richard.

  • reformatted method prototypes to match AppKit style
  • remove "Public header file" from headers that are not public
  • fix header doc @method names to match actual method names
  • Carbon.subproj/CarbonWindowAdapter.h:
  • Carbon.subproj/HIViewAdapter.h:
  • DOM.subproj/WebDOMDocument.h:
  • DOM.subproj/WebDOMNode.h:
  • History.subproj/WebBackForwardList.h:
  • History.subproj/WebHistoryItemPrivate.h:
  • History.subproj/WebHistoryPrivate.h:
  • History.subproj/WebURLsWithTitles.h:
  • Misc.subproj/WebIconDatabase.h:
  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebUnicode.h:
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebNetscapePluginStream.h:
  • Plugins.subproj/WebNullPluginView.h:
  • Plugins.subproj/WebPluginViewFactory.h:
  • WebCoreSupport.subproj/WebGlyphBuffer.h:
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRendererFactory.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebDataProtocol.h:
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDebugDOMNode.h:
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.h:
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebMainResourceClient.h:
  • WebView.subproj/WebPolicyDelegate.h:
  • WebView.subproj/WebPolicyDelegatePrivate.h:
  • WebView.subproj/WebPreferencesPrivate.h:
  • WebView.subproj/WebRenderNode.h:
  • WebView.subproj/WebResourceLoadDelegate.h:
  • WebView.subproj/WebUIDelegate.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebViewPrivate.h:
4:10 PM Changeset in webkit [4268]
  • 8 copies
    1 delete in tags/WebKit-SDK-Beta-1

This commit was manufactured by cvs2svn to create tag
'WebKit-SDK-Beta-1'.

4:10 PM Changeset in webkit [4267] by rjw
  • 3 edits in branches/Safari-77~1-branch

Build hackery for WebKit beta SDK. Installs framework in /System/Library/Frameworks.

1:09 PM Changeset in webkit [4266] by mjs
  • 11 edits in trunk

WebCore:

Reviewed by Darin.

  • fixed 2936175 - MALLORY: please implement onResize
  • khtml/khtmlview.cpp: (KHTMLView::resizeEvent): Put most of this in #if !APPLE_CHANGES, since we already do the relayout and such on resize elswhere.
  • kwq/KWQEvent.h: Add a minimal QResizeEvent.
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendResizeEvent): Send it to the view.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge sendResizeEvent]): Send it to the part.

WebKit:

Reviewed by Darin.

  • fixed 2936175 - MALLORY: please implement onResize
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): If we just resized and we're not printing, make sure to send a resize event after the layout.
12:21 PM Changeset in webkit [4265] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3184113, bottom margins didn't collapse with their children
like they were supposed to. The problem is fixed by separately
caching whether or not the top and bottom margins can collapse
with their kids instead of having one global canCollapse variable.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp:
11:13 AM Changeset in webkit [4264] by darin
  • 10 edits in trunk

WebCore:

Reviewed by John.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scheduleClose): Change to use closeWindowSoon, so that the delay is on the WebKit side so it can be tied to the WebView as a whole, not a particular bridge.
  • kwq/WebCoreBridge.h: Replaced closeWindow with closeWindowSoon.
  • rolled in a couple of harmless and eventually-possibly-useful changes inspired by changes OmniGroup made in their copy of WebCore
  • kwq/KWQListBox.mm: Make KWQTableView a KWQWidgetHolder. (-[KWQTableView widget]): Return the widget.
  • kwq/KWQScrollView.mm: (QScrollView::ensureVisible): First cut at implementing these.

WebKit:

Reviewed by John.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): Replaces closeWindow. Schedule a closeWindow operation in the WebView. Important to not have the call's execution depend on whether this WebBridge or WebFrame is still around after the delay.
  • WebView.subproj/WebViewPrivate.h: Added _closeWindow.
  • WebView.subproj/WebViewPrivate.m: (-[WebView _closeWindow]): Make a webViewClose: call on the UI delegate.
10:39 AM Changeset in webkit [4263] by darin
  • 38 edits in trunk/WebKit

WebKit:

Reviewed by John.

Changed WebFrame to explicitly detach from the bridge so we don't have a stale pointer;
also cleaned up WebBridge initialization.

  • WebCoreSupport.subproj/WebBridge.h: Added initWithWebFrame: and close methods, removed setWebFrame: method.
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webFrameView:webView:]): Use the new initWithWebFrame:.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Call close on the bridge.
  • fixed many places that call a WebView a "controller"
  • Misc.subproj/WebKitStatistics.h:
  • Misc.subproj/WebKitStatistics.m:
  • Misc.subproj/WebKitStatisticsPrivate.h:
  • Misc.subproj/WebNSViewExtras.m:
  • Plugins.subproj/WebBaseNetscapePluginView.h:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.h:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by John.

  • fixed many places that call a WebView a "controller", including changing the name BrowserWebController to BrowserWebView
  • BrowserDocument.h:
  • BrowserDocument.m:
  • BrowserDocumentController.h:
  • BrowserDocumentController.m:
  • BrowserTabViewItem.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.h:
  • BrowserWebController.m:
  • BrowserWebFrameExtras.h:
  • BrowserWindowController.h:
  • BrowserWindowController.m:
  • ContextMenuHandler.m:
  • Debug/DOMTree.h:
  • Debug/DOMTree.m:
  • Debug/DebugUtilities.m:
  • Debug/RenderTree.h:
  • Debug/RenderTree.m:
  • Debug/ViewTree.h:
  • Debug/ViewTree.m:
  • English.lproj/StringsNotToBeLocalized.txt:
  • FindPanelController.m:
  • FormCompletionController.h:
  • FormCompletionController.m:
  • LoadProgressMonitor.h:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • LocationChangeHandler.h:
  • LocationChangeHandler.m:
  • Test/PageLoadTestRunner.m:
10:22 AM Changeset in webkit [4262] by hyatt
  • 3 edits in trunk/WebCore

Make sure that recalcSections always clears out the needSectionRecalc
boolean, even in the case where it finds column elements.

Fixes the assert outlined in bug 3237651.

Reviewed by john

  • khtml/rendering/render_table.cpp: (RenderTable::recalcSections):
8:52 AM Changeset in webkit [4261] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3226030, percentage height tables inside table cells
don't grow to fill the space inside the cell. There was
a missing edge case here for the case where the table was
nested inside a table cell.

Reviewed by darin

  • khtml/rendering/render_table.cpp: (RenderTable::layout):
Note: See TracTimeline for information about the timeline view.