Timeline



May 16, 2003:

9:55 PM Changeset in webkit [4391] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

  • fixed 3254063 - REGRESSION: hang in KJS PropertyMap with many items in iDisk pictures folder
  • kjs/property_map.cpp: (PropertyMap::expand): Fixed to maintain key count properly - otherwise the hashtable could get completely full, resulting in disaster. (PropertyMap::checkConsistency): Fixed compilation. Fixed to know about deleted sentinel. Fixed to search with double-hashing instead of linear probing.
6:40 PM Changeset in webkit [4390] by mjs
  • 12 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3260940 - REGRESSION: reproducible crash freeing page cache item
  • fixed 3241041 - REGRESSION: repro world leak of 1 JavaScript interpreter

The fix for these problems and probably other page cache wackiness
was to use a refcounting scheme for KHTMLView instead of counting
on the previous tricky ownership rules.

  • khtml/khtmlview.cpp: (KHTMLView::KHTMLView): Initialize _refCount to 1. (KHTMLView::~KHTMLView): Assert that _refCount is 0, to make sure no one is deleting views explicitly.
  • khtml/khtmlview.h:
  • khtml/rendering/render_frames.cpp: (RenderPart::~RenderPart): If our view is a KHTMLView, deref it. (RenderPart::setWidget): If the view is a KHTMLView, tell the superclass not to delete it and ref it.
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::RenderWidget): Initizlize m_deleteWidget to false. (RenderWidget::~RenderWidget): Only delete widget if we're supposed to. (RenderWidget::setQWidget): Add extra delegeWidget argument that says whether to delete this widget when done - defaults to true.
  • khtml/rendering/render_replaced.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Removed _ownsView boolean -- we'll always hang on to a ref to it now. (KWQKHTMLPart::~KWQKHTMLPart): Deref the view always instead of deleting it sometimes. (KWQKHTMLPart::setView): deref the old view if not null. ref the new view if not null. Drop tricky ownership rules. (KWQKHTMLPart::openURLFromPageCache): Remove no longer applicable comment about the importance of when setView is called.
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:]): ref the document's view. (-[KWQPageState invalidate]): deref the document's view. (-[KWQPageState dealloc]): deref the document's view instead of deleting it.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]): No more need to pass weOwnIt argument to setView. Also, deref the view after passing it to the KWQKHTMLView -- we own the initial ref since we allocated it. (-[WebCoreBridge removeFromFrame]): No more need to pass weOwnIt argument to setView. (-[WebCoreBridge installInFrame:]): Ditto.
11:36 AM Changeset in webkit [4389] by mjs
  • 4 edits in trunk/WebKit

WebFoundation:

Reviewed by John.

  • fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m: (-[NSURLKeychainCredentialStorage _secProtocolForProtectionSpace:]): Don't assert if the protocol is unknown, just return 0 and let the higher levels fail gracefully. (-[NSURLKeychainCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): Don't save if the protocol is unknown. Tolerate nil host.
  • AuthenticationManager.subproj/NSURLProtectionSpace.m: (-[NSURLProtectionSpace initWithHost:port:protocol:realm:authenticationMethod:]):
  • unrelated cookie code cleanup
  • CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): Avoid warning about "0 previous cookies rejected"

WebKit:

Reviewed by John.

  • fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): Expect sourceFrame argument.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Include source frame in form state. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Include source frame in form state. Post directly to the target frame if it exists, since we want the form state to contain the right source frame. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Pass source frame to form delegate. (-[WebFormState initWithForm:values:sourceFrame:]): New sourceFrame argument. (-[WebFormState dealloc]): release sourceFrame. (-[WebFormState sourceFrame]): New method.

WebBrowser:

Reviewed by John.

  • fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
  • BrowserWebController.m: (-[FormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): Expect sourceFrame.
  • FormCompletionController.h:
  • FormCompletionController.m: (+[FormCompletionController _frame:sourceFrame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): Pop up sheet based on source frame's window, and raise the sheet-bearing window if different than the target window. (+[FormCompletionController _frame:sourceFrame:willSubmitRegularForm:withValues:]): Expect and use sourceFrame. (+[FormCompletionController frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): Expect sourceFrame.
10:28 AM Changeset in webkit [4388] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3256997 - reproducible world leak (of 1 JavaScript interpreter) using google images

This turned out to be a page cache bug, and nothing to do with
JavaScript. The part and view were also leaked.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Make sure to reset the view before resetting the document, so that when we check if the document is in the page cache to determine if we can delete the old view, we'll be checking the old document instead of the new one.
9:07 AM Changeset in webkit [4387] by kocienda
  • 10 edits
    2 adds in trunk/WebKit

WebFoundation:

Reviewed by Gramps

Moved WebDatabase and WebFileDatabase files to WebKit

Twiddled some logging constants now that the WebFileDatabase
has been removed from the framework.

Updated StringsNotToBeLocalized.txt.

  • Database.subproj/NSLRUFileList.m: (NSLRUFileListRemoveOldestFileFromList):
  • Database.subproj/WebDatabase.h: Removed.
  • Database.subproj/WebDatabase.m: Removed.
  • Database.subproj/WebFileDatabase.h: Removed.
  • Database.subproj/WebFileDatabase.m: Removed.
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/NSURLLogging.h:
  • Misc.subproj/NSURLLogging.m:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Gramps

Moved in WebDatabase and WebFileDatabase files from WebFoundation.

Copied NSLRUFileList from WebFoundation and renamed to WebLRUFileList.

Updated StringsNotToBeLocalized.txt.

  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebDatabase.h:
  • Misc.subproj/WebDatabase.m:
  • Misc.subproj/WebFileDatabase.h:
  • Misc.subproj/WebFileDatabase.m: (-[WebFileDatabaseOp initWithCode:key:object:]): (-[WebFileDatabaseOp perform:]): (SetThreadPriority): (-[WebFileDatabase _createLRUList:]): (-[WebFileDatabase _truncateToSizeLimit:]): (+[WebFileDatabase _syncLoop:]): (-[WebFileDatabase setObject:forKey:]): (-[WebFileDatabase removeObjectForKey:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase close]): (-[WebFileDatabase lazySync:]): (-[WebFileDatabase sync]): (-[WebFileDatabase count]): (-[WebFileDatabase usage]):
  • Misc.subproj/WebIconDatabase.m:
  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebKitLogging.m:
  • Misc.subproj/WebLRUFileList.h: Added.
  • Misc.subproj/WebLRUFileList.m: Added. (WebLRUFileListCreate): (WebLRUFileListRelease): (WebLRUFileListRebuildFileDataUsingRootDirectory): (WebLRUFileListRemoveFileWithPath): (WebLRUFileListTouchFileWithPath): (WebLRUFileListSetFileData): (WebLRUFileListGetPathOfOldestFile): (WebLRUFileListRemoveOldestFileFromList): (WebLRUFileListContainsItem): (WebLRUFileListGetFileSize): (WebLRUFileListCountItems): (WebLRUFileListGetTotalSize): (WebLRUFileListRemoveAllFilesFromList): (compareTimes): (cStringEqual): (cStringHash): (NSLRUFileDataEqual): (WebLRUFileListGetOldestFileData): (NSLRUFileDataReleaseApplierFunction): (NSLRUFileDataRelease): (NSLRUFileDataBinaryHeapDumpApplierFunction): (NSLRUFileDataDictDumpApplierFunction): (WebLRUFileListDescription):
  • WebKit.pbproj/project.pbxproj:

May 15, 2003:

6:09 PM Changeset in webkit [4386] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3168588 - Can't click on links at Nike site (Image onload handler problem)

The fix was to implement the onload property for Image objects
(which are entirely different from <img> HTML elements).

  • khtml/ecma/kjs_html.cpp: (Image::getValueProperty): Implement access to onload attribte. (Image::tryPut): Use putValue cause we're gonna use the hashtable now. (Image::putValue): Moved guts of tryPut here. Implement setting of onload attribute. (Image::notifyFinished): Fire onload event if there is a listener. (Image::Image): initialize onload listener to null.
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_html.lut.h: Regenerated.
2:59 PM Changeset in webkit [4385] by cblu
  • 4 edits in trunk/WebKit

WebFoundation:

Fixed: ASSERT if delegate doesn't implement didReceiveResponse

Reviewed by kocienda.

  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection _postDidReceiveResponseCallback]): set didReceiveResponseCallbackSent to YES here (-[NSURLConnection _sendDidReceiveResponseCallback]): don't set didReceiveResponseCallbackSent to YES here because this method may not be called

WebKit:

Fixed: 3199310 - No user agent included in favicon.ico requests

Reviewed by kocienda.

  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoaderPrivate dealloc]): use the request ivar (-[WebIconLoader URL]): ditto (-[WebIconLoader startLoading]): ditto (-[WebIconLoader connection:didReceiveData:]): ditto (-[WebIconLoader connectionDidFinishLoading:]): ditto
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): create a icon loader with a request with the extra fields set
2:46 PM Changeset in webkit [4384] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3155760 - Plug-in MIME and extension mapping should be case-insensitive

Reviewed by john.

  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage getPluginInfoFromBundleAndMIMEDictionary:]): store the extensions and MIMEs as lowercase strings (-[NSArray _web_lowercaseStrings]): new, returns array of lowercase strings
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage getPluginInfoFromResources]): store the extensions and MIMEs as lowercase strings
  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForMIMEType:]): lowercase the passed MIME type (-[WebPluginDatabase pluginForExtension:]): lowercase the passed extension
2:39 PM Changeset in webkit [4383] by sheridan
  • 3 edits in trunk

build number 80u

2:11 PM Changeset in webkit [4382]
  • 3 copies in tags/Safari-79

This commit was manufactured by cvs2svn to create tag 'Safari-79'.

2:11 PM Changeset in webkit [4381] by sheridan
  • 8 edits in trunk

Safari-79 stamp

1:47 PM Changeset in webkit [4380] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Chris.

  • fixed 3259673 - REGRESSION: marvel.com thinks I don't have the flash plugin any more
  • kjs/nodes.cpp: (ContinueNode::execute): Return a Continue completion, not a Break completion, in the normal non-exception case.
12:55 PM Changeset in webkit [4379] by kocienda
  • 2 edits in trunk/WebKit

Tools:

Reviewed by John

Tweaked script so that it works with the changed names
of some dependent files and macors in WebFoundation.

  • Scripts/extract-localizable-strings:

WebFoundation:

Reviewed by John

Updated StringsNotToBeLocalized.txt for recent changes.

Changed localization macros back to UI_STRING and UI_STRING_KEY so
that we keep working with the tools we have to keep
localization information up to date.

  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m: (-[NSURLKeychainCredentialStorage _saveCredential:forProtectionSpace:isDefault:]):
  • CacheLoader.subproj/NSURLResponse.m: (+[NSHTTPURLResponse localizedStringForStatusCode:]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/NSError_NSURLExtras.m: (WebNSErrorExtrasInit):
  • Misc.subproj/NSString_NSURLExtras.m:
  • Misc.subproj/NSURLAssertions.h:
  • Misc.subproj/NSURLAssertions.m: (NSURLReportFatalError):
  • Misc.subproj/NSURLLocalizableStrings.h:
  • Misc.subproj/NSURL_NSURLExtras.m: (-[NSURL _web_suggestedFilenameWithMIMEType:]):

WebKit:

Reviewed by John

Updated for recent changes.

  • English.lproj/StringsNotToBeLocalized.txt:

WebBrowser:

Reviewed by John

Updated for recent changes.

  • English.lproj/StringsNotToBeLocalized.txt:
11:19 AM Changeset in webkit [4378] by kocienda
  • 37 edits in trunk/WebKit

Tests:

Reviewed by John

Changed the names of some extras files in WebFoundation:
Updated imports and usages in the tests.

WebNSArrayExtras -> NSArray_NSURLExtras
WebNSCalendarDateExtras -> NSCalendarDate_NSURLExtras
WebNSObjectExtras -> NSObject_NSURLExtras
WebNSStringExtras -> NSString_NSURLExtras
WebNSURLExtras -> NSURL_NSURLExtras

  • WebFoundation-Misc/ifnsarrayextensions-test.m:
  • WebFoundation-Misc/ifnscalendardateextensions-test.m:
  • WebFoundation-Misc/ifnsobjectextensions-test.m:
  • WebFoundation-Misc/ifnsstringextensions-test.m:
  • WebFoundation-Misc/ifnsurlextensions-test.m:
  • WebFoundation-Misc/ifurlparsing-test.m:

WebFoundation:

Reviewed by John

Changed the names of some extras files:
Updated imports and usages in this project.

WebNSArrayExtras -> NSArray_NSURLExtras
WebNSCalendarDateExtras -> NSCalendarDate_NSURLExtras
WebNSDataExtras -> NSData_NSURLExtras
WebNSDictionaryExtras -> NSDictionary_NSURLExtras
WebNSErrorExtras -> NSError_NSURLExtras
WebNSFileManagerExtras -> NSFileManager_NSURLExtras
WebNSObjectExtras -> NSObject_NSURLExtras
WebNSStringExtras -> NSString_NSURLExtras
WebNSURLExtras -> NSURL_NSURLExtras
WebNSUserDefaultsExtras -> NSUserDefaults_NSURLExtras
WebNSValueExtensions -> NSValue_NSURLExtras

  • AuthenticationManager.subproj/NSHTTPAuthenticator.m:
  • AuthenticationManager.subproj/NSURLCredentialStorage.m:
  • AuthenticationManager.subproj/NSURLKeychainCredential.m:
  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m:
  • CacheLoader.subproj/NSNetworkSettings.m:
  • CacheLoader.subproj/NSSynchronousURLConnectionDelegate.m:
  • CacheLoader.subproj/NSURLCache.m:
  • CacheLoader.subproj/NSURLConnection.m:
  • CacheLoader.subproj/NSURLConnectionQueue.m:
  • CacheLoader.subproj/NSURLProtocol.m:
  • CacheLoader.subproj/NSURLRequest.m:
  • CacheLoader.subproj/NSURLResponse.m:
  • ChangeLog:
  • CookieManager.subproj/NSHTTPCookie.m:
  • CookieManager.subproj/NSHTTPCookieDOStorage.m:
  • CookieManager.subproj/NSHTTPCookieServer.m:
  • CookieManager.subproj/NSHTTPCookieStorage.m:
  • Database.subproj/WebFileDatabase.m:
  • English.lproj/StringsNotToBeLocalized.txt:
  • FileTransfer.subproj/NSBinHexDecoder.m:
  • FileTransfer.subproj/NSMacBinaryDecoder.m:
  • FileTransfer.subproj/NSURLDownload.m:
  • Misc.subproj/NSArray_NSURLExtras.m:
  • Misc.subproj/NSCalendarDate_NSURLExtras.h:
  • Misc.subproj/NSCalendarDate_NSURLExtras.m:
  • Misc.subproj/NSData_NSURLExtras.h:
  • Misc.subproj/NSData_NSURLExtras.m:
  • Misc.subproj/NSDictionary_NSURLExtras.h:
  • Misc.subproj/NSDictionary_NSURLExtras.m:
  • Misc.subproj/NSError_NSURLExtras.h:
  • Misc.subproj/NSError_NSURLExtras.m:
  • Misc.subproj/NSFileManager_NSURLExtras.h:
  • Misc.subproj/NSFileManager_NSURLExtras.m:
  • Misc.subproj/NSObject_NSURLExtras.h:
  • Misc.subproj/NSObject_NSURLExtras.m:
  • Misc.subproj/NSString_NSURLExtras.h:
  • Misc.subproj/NSString_NSURLExtras.m:
  • Misc.subproj/NSURL_NSURLExtras.h:
  • Misc.subproj/NSURL_NSURLExtras.m:
  • Misc.subproj/NSUserDefaults_NSURLExtras.h:
  • Misc.subproj/NSUserDefaults_NSURLExtras.m:
  • Misc.subproj/NSValue_NSURLExtras.h:
  • Misc.subproj/NSValue_NSURLExtras.m:
  • Misc.subproj/WebNSArrayExtras.h: Removed.
  • Misc.subproj/WebNSArrayExtras.m: Removed.
  • Misc.subproj/WebNSCalendarDateExtras.h: Removed.
  • Misc.subproj/WebNSCalendarDateExtras.m: Removed.
  • Misc.subproj/WebNSDataExtras.h: Removed.
  • Misc.subproj/WebNSDataExtras.m: Removed.
  • Misc.subproj/WebNSDictionaryExtras.h: Removed.
  • Misc.subproj/WebNSDictionaryExtras.m: Removed.
  • Misc.subproj/WebNSErrorExtras.h: Removed.
  • Misc.subproj/WebNSErrorExtras.m: Removed.
  • Misc.subproj/WebNSFileManagerExtras.h: Removed.
  • Misc.subproj/WebNSFileManagerExtras.m: Removed.
  • Misc.subproj/WebNSObjectExtras.h: Removed.
  • Misc.subproj/WebNSObjectExtras.m: Removed.
  • Misc.subproj/WebNSStringExtras.h: Removed.
  • Misc.subproj/WebNSStringExtras.m: Removed.
  • Misc.subproj/WebNSURLExtras.h: Removed.
  • Misc.subproj/WebNSURLExtras.m: Removed.
  • Misc.subproj/WebNSUserDefaultsExtras.h: Removed.
  • Misc.subproj/WebNSUserDefaultsExtras.m: Removed.
  • Misc.subproj/WebNSValueExtensions.h: Removed.
  • Misc.subproj/WebNSValueExtensions.m: Removed.
  • ProtocolHandlers.subproj/NSAboutURLProtocol.m:
  • ProtocolHandlers.subproj/NSCFNetworkHTTPURLProtocol.m:
  • ProtocolHandlers.subproj/NSFTPURLProtocol.m:
  • ProtocolHandlers.subproj/NSFileURLProtocol.m:
  • ProtocolHandlers.subproj/NSHTTPURLProtocol.m:
  • ProtocolHandlers.subproj/NSSimpleHTTPURLProtocol.m:
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by John

Changed the names of some extras files in WebFoundation:
Updated imports and usages in this project.

WebNSCalendarDateExtras -> NSCalendarDate_NSURLExtras
WebNSDataExtras -> NSData_NSURLExtras
WebNSDictionaryExtras -> NSDictionary_NSURLExtras
WebNSErrorExtras -> NSError_NSURLExtras
WebNSFileManagerExtras -> NSFileManager_NSURLExtras
WebNSObjectExtras -> NSObject_NSURLExtras
WebNSStringExtras -> NSString_NSURLExtras
WebNSURLExtras -> NSURL_NSURLExtras
WebNSUserDefaultsExtras -> NSUserDefaults_NSURLExtras

  • History.subproj/WebHistory.m:
  • History.subproj/WebHistoryItem.m:
  • History.subproj/WebHistoryPrivate.m:
  • History.subproj/WebURLsWithTitles.m:
  • Misc.subproj/WebIconDatabase.m:
  • Misc.subproj/WebIconLoader.m:
  • Misc.subproj/WebKitErrors.m:
  • Misc.subproj/WebNSPasteboardExtras.m:
  • Misc.subproj/WebNSViewExtras.m:
  • Panels.subproj/WebAuthenticationPanel.m:
  • Panels.subproj/WebPanelAuthenticationHandler.m:
  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNullPluginView.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebCookieAdapter.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebDataProtocol.m:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultResourceLoadDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebPreferences.m:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by John

Changed the names of some extras files in WebFoundation:
Updated imports and usages in this project.

WebNSCalendarDateExtras -> NSCalendarDate_NSURLExtras
WebNSDictionaryExtras -> NSDictionary_NSURLExtras
WebNSErrorExtras -> NSError_NSURLExtras
WebNSFileManagerExtras -> NSFileManager_NSURLExtras
WebNSStringExtras -> NSString_NSURLExtras
WebNSURLExtras -> NSURL_NSURLExtras
WebNSUserDefaultsExtras -> NSUserDefaults_NSURLExtras

  • AppController.m: (-[AppController settingsDirectoryPath]):
  • BookmarkSource.m:
  • BookmarksViewController.m:
  • BrowserDocument.m:
  • BrowserDocumentController.m:
  • BrowserNSBundleExtras.m:
  • BrowserNSErrorExtras.m:
  • BrowserNSNetServiceExtras.m:
  • BrowserNSStringExtras.m:
  • BrowserNSURLExtras.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.m:
  • BrowserWindowController.m:
  • BugReportController.m:
  • ChangeLog:
  • ContextMenuHandler.m:
  • Debug/DebugUtilities.m:
  • DownloadMonitor.m:
  • DownloadProgressEntry.m:
  • DownloadRow.m:
  • FormCompletionController.m:
  • FrameProgressEntry.m:
  • GlobalHistory.m:
  • GoogleSearchChannel.m:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • LocationChangeHandler.m:
  • LocationFieldEditor.m:
  • NewBookmarksController.m:
  • Preferences.subproj/AdvancedPreferences.m:
  • Preferences.subproj/DefaultBrowserController.m:
  • Preferences.subproj/WBPreferences.m:
  • RendezvousController.m:
  • ResourceProgressEntry.m:
  • SlidingAnimation.m:
  • SpinningProgressIndicator.m:
  • TabBarView.m:
  • Test/PageLoadTestController.m:
  • Test/PageLoadTestRunner.m:
  • TitleBarButton.m:
  • URLCompletionController.m: (visitCountForResult):
  • WebBookmarkImporter.m:
  • WebBookmarkLeaf.m:
  • main.m:

May 14, 2003:

4:48 PM Changeset in webkit [4377] by kocienda
  • 5 edits
    2 adds in trunk/WebKit

Tests:

Reviewed by Chris

Fixed one straggling test I missed earlier when
changing name from WebMonitor to NSURLMonitor

  • WebFoundation-CacheLoader/NeverExpiresTest.m:

WebFoundation:

Reviewed by Chris

Cut way down on WebSystemBits. Kept only two thread-priority
functions. The WebSystemBits header is no longer privately exported.

  • Misc.subproj/WebSystemBits.h:
  • Misc.subproj/WebSystemBits.m: (WebGetThreadPriority):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Chris

WebKitSystemBits files that contain a system memory size
getter. This function is used in a few of places in WebKit.

  • History.subproj/WebBackForwardList.m:
  • Misc.subproj/WebKitSystemBits.h: Added.
  • Misc.subproj/WebKitSystemBits.m: Added. (initCapabilities): (WebSystemMainMemory):
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebTextRendererFactory.m:
  • WebKit.pbproj/project.pbxproj:

WebBrowser:

Reviewed by Chris

Removed dependency on WebFoundation/WebSystemBits.h.
Moved one function that was used into this file. This
function, JaguarSUJagGreenOrLater(), has been tweaked
to be more specialized for the one question it needs
to answer.

  • FormCompletionController.m: (GetRandomBytes): (generatePassword):
  • LocationChangeError.m: (JaguarSUJagGreenOrLater): (-[LocationChangeHandler specializedMessageForError:dataSource:]):
3:00 PM Changeset in webkit [4376] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3248193. Floats with layers paint twice. The fix
is to make sure floats are not painted during the float phase
if they also have a layer.

Reviewed by john

  • khtml/rendering/render_block.cpp:
2:03 PM Changeset in webkit [4375] by kocienda
  • 7 edits in trunk/WebKit

Tests:

Reviewed by David

File and class renamings in WebFoundation:

WebKeyValuePair -> NSURLKeyValuePair
WebReadWriteLock -> NSURLReadWriteLock
WebRecursiveReadWriteLock -> NSURLRecursiveReadWriteLock

  • WebFoundation-Misc/ifnsstringextensions-test.m: (formatPair): (main):
  • WebFoundation-Misc/ifreadwritelock-test.m: (main):
  • WebFoundation-Misc/ifrecursivereadwritelock-test.m: (main):

WebFoundation:

Reviewed by David

File and class renamings:

WebFileTypeMappings -> NSURLFileTypeMappings
WebHostNameAddressInfo.h -> NSURLHostNameAddressInfo.h
WebKeyValuePair -> NSURLKeyValuePair
WebMonitor -> NSURLMonitor
WebQueue -> NSURLQueue
WebReadWriteLock -> NSURLReadWriteLock
WebRecursiveReadWriteLock -> NSURLRecursiveReadWriteLock
WebSpinLock -> NSURLSpinLock

  • AuthenticationManager.subproj/NSHTTPAuthenticator.h:
  • AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator _internalInit]):
  • AuthenticationManager.subproj/NSURLCredentialStorage.m:
  • CacheLoader.subproj/NSNetworkSettings.m: (-[NSNetworkSettingsInternal init]):
  • CacheLoader.subproj/NSSynchronousURLConnectionDelegate.h:
  • CacheLoader.subproj/NSSynchronousURLConnectionDelegate.m: (-[NSSynchronousURLConnectionDelegate initWithRequest:monitor:]):
  • CacheLoader.subproj/NSURLCache.m: (-[NSURLCache initWithMemoryCapacity:diskCapacity:diskPath:]):
  • CacheLoader.subproj/NSURLConnection.m: (NSURLConnectionInit):
  • CacheLoader.subproj/NSURLConnectionQueue.h:
  • CacheLoader.subproj/NSURLConnectionQueue.m: (-[NSURLConnectionQueue put:URL:]):
  • CacheLoader.subproj/NSURLResponse.m: (-[NSHTTPURLResponse _parseCacheControl]):
  • ChangeLog:
  • CookieManager.subproj/NSHTTPCookie.m: (+[NSHTTPCookie cookieWithV0Spec:forURL:locationHeader:]):
  • CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorageInternal init]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/NSURLFileTypeMappings.h:
  • Misc.subproj/NSURLFileTypeMappings.m: (-[NSURLFileTypeMappings _init]): (initFileTypeMappings): (+[NSURLFileTypeMappings sharedMappings]):
  • Misc.subproj/NSURLHostNameAddressInfo.h:
  • Misc.subproj/NSURLHostNameAddressInfo.m: (NSURLHostNameAddressInfoInit): (+[NSURLHostNameAddressInfo addressInfoForHost:]): (+[NSURLHostNameAddressInfo asyncResolveWithCallbackClient:]): (doResolveHostName): (resolveHostName):
  • Misc.subproj/NSURLKeyValuePair.h:
  • Misc.subproj/NSURLKeyValuePair.m: (+[NSURLKeyValuePair pair]): (+[NSURLKeyValuePair pairWithKey:value:]): (-[NSURLKeyValuePair description]):
  • Misc.subproj/NSURLMonitor.h:
  • Misc.subproj/NSURLMonitor.m:
  • Misc.subproj/NSURLQueue.h:
  • Misc.subproj/NSURLQueue.m: (+[NSURLQueue newNode]): (-[NSURLQueue init]): (-[NSURLQueue put:]): (-[NSURLQueue take]): (-[NSURLQueue peekAt:]): (-[NSURLQueue remove:]): (-[NSURLQueue clear]): (-[NSURLQueue indexOf:]):
  • Misc.subproj/NSURLReadWriteLock.h:
  • Misc.subproj/NSURLReadWriteLock.m: (-[NSURLReadWriteLock init]):
  • Misc.subproj/NSURLRecursiveReadWriteLock.h:
  • Misc.subproj/NSURLRecursiveReadWriteLock.m:
  • Misc.subproj/NSURLSpinLock.h:
  • Misc.subproj/NSURLSpinLock.m:
  • Misc.subproj/WebFileTypeMappings.h: Removed.
  • Misc.subproj/WebFileTypeMappings.m: Removed.
  • Misc.subproj/WebHostNameAddressInfo.h: Removed.
  • Misc.subproj/WebHostNameAddressInfo.m: Removed.
  • Misc.subproj/WebKeyValuePair.h: Removed.
  • Misc.subproj/WebKeyValuePair.m: Removed.
  • Misc.subproj/WebMonitor.h: Removed.
  • Misc.subproj/WebMonitor.m: Removed.
  • Misc.subproj/WebNSArrayExtras.m: (-[NSArray _web_encodeWWWFormURLData]):
  • Misc.subproj/WebNSDataExtras.m: (-[NSData _web_guessedMIMETypeForExtension:]):
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_parseAsKeyValuePair]): (-[NSString _web_parseAsKeyValuePairHandleQuotes:]): (-[NSString _web_fileNameFromContentDispositionHeader]): (-[NSString _web_timeoutFromKeepAliveHeader]):
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_suggestedFilenameWithMIMEType:]):
  • Misc.subproj/WebQueue.h: Removed.
  • Misc.subproj/WebQueue.m: Removed.
  • Misc.subproj/WebReadWriteLock.h: Removed.
  • Misc.subproj/WebReadWriteLock.m: Removed.
  • Misc.subproj/WebRecursiveReadWriteLock.h: Removed.
  • Misc.subproj/WebRecursiveReadWriteLock.m: Removed.
  • Misc.subproj/WebSpinLock.h: Removed.
  • Misc.subproj/WebSpinLock.m: Removed.
  • ProtocolHandlers.subproj/NSCFNetworkHTTPURLProtocol.m:
  • ProtocolHandlers.subproj/NSFTPURLProtocol.m: (-[NSFTPURLProtocol sendResponseAvailableCallback]):
  • ProtocolHandlers.subproj/NSFileURLProtocol.m: (-[NSFileURLProtocol didLoadData:]):
  • ProtocolHandlers.subproj/NSHTTPURLProtocol.m:
  • ProtocolHandlers.subproj/NSSimpleHTTPURLProtocol.h:
  • ProtocolHandlers.subproj/NSSimpleHTTPURLProtocol.m: (NSSimpleHTTPURLProtocolInit): (-[NSSimpleHTTPURLProtocol initWithRequest:cachedResponse:client:]): (-[NSSimpleHTTPURLProtocol startOriginLoad]): (-[NSSimpleHTTPURLProtocol hostNameResolved:]): (-[NSSimpleHTTPURLProtocol _handleLoadCallback]):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by David

File and class renaming in WebFoundation:

WebFileTypeMappings -> NSURLFileTypeMappings

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge MIMETypeForPath:]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]):
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebViewPrivate.m: (+[WebView suggestedFileExtensionForMIMEType:]): (+[WebView _MIMETypeForFile:]):

WebBrowser:

Reviewed by David

File and class renaming done in WebFoundation:

WebFileTypeMappings -> NSURLFileTypeMappings

  • BrowserWebController.m:
1:27 PM Changeset in webkit [4374] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3258389, min-width should take precedence over max-width.
I just had an "else" that shouldn't have been there, so that
min-width would get checked even if max-width was also checked.

Reviewed by kocienda

  • khtml/rendering/render_box.cpp: (RenderBox::calcWidth):
1:27 PM Changeset in webkit [4373] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3258389, min-width should take precedence over max-width.
I just had an "else" that shouldn't have been there, so that
min-width would get checked even if max-width was also checked.

Reviewed by NOBODY (OOPS!).

  • khtml/rendering/render_box.cpp: (RenderBox::calcWidth):
11:48 AM Changeset in webkit [4372] by kocienda
  • 9 edits
    2 adds in trunk/WebKit

WebFoundation:

Reviewed by Maciej

Copied WebLocalizableStrings.[hm] from WebFoundation to WebKit.
Renamed copy of WebLocalizableStrings.[hm] that stayed to NSURLLocalizableStrings.[hm]

Search and replace through all the code in this framework to
twiddle localizable string function names and macros
used and defined in the headers and implementation
files so that they use an "NSURL" prefix instead of no prefix,
a "Web" prefix, or a "WebFoundation" prefix.

Removed localizable strings exported symbols from exports file.

  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m: (-[NSURLKeychainCredentialStorage _saveCredential:forProtectionSpace:isDefault:]):
  • CacheLoader.subproj/NSURLResponse.m: (+[NSHTTPURLResponse localizedStringForStatusCode:]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebNSErrorExtras.m: (WebNSErrorExtrasInit):
  • Misc.subproj/WebNSStringExtras.m:
  • Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_suggestedFilenameWithMIMEType:]):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Maciej

Copied WebLocalizableStrings.[hm] from WebFoundation to WebKit

Updated all imports.

Added logging exported symbols to exports file.

  • Misc.subproj/WebKitErrors.m:
  • Misc.subproj/WebLocalizableStrings.h: Added.
  • Misc.subproj/WebLocalizableStrings.m: Added.
  • Panels.subproj/WebAuthenticationPanel.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebFileButton.m:
  • WebCoreSupport.subproj/WebViewFactory.m:
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:

WebBrowser:

Reviewed by Maciej

Copied WebLocalizableStrings.[hm] from WebFoundation to WebKit.
Updated all imports.

  • ABHomePagesController.m:
  • AppController.m:
  • BookmarksController.m:
  • BookmarksRepresentation.m:
  • BookmarksViewController.m:
  • BrowserAddressBookExtras.m:
  • BrowserDocument.m:
  • BrowserDocumentController.m:
  • BrowserNSErrorExtras.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.m:
  • BrowserWindowController.m:
  • BugReportController.m:
  • ContextMenuHandler.m:
  • DateCell.m:
  • DownloadMonitor.m:
  • DownloadRow.m:
  • DownloadViewController.m:
  • DownloadWindowController.m:
  • FavoriteButton.m:
  • FindPanelController.m:
  • FormCompletionController.m:
  • FrameProgressEntry.m:
  • GlobalHistory.m:
  • HTMLSourceDocument.m:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • LocationChangeHandler.m:
  • Preferences.subproj/AcceptedCookies.m:
  • Preferences.subproj/AdvancedPreferences.m:
  • Preferences.subproj/AppearancePreferences.m:
  • Preferences.subproj/AutoFillPreferences.m:
  • Preferences.subproj/BookmarkPreferences.m:
  • Preferences.subproj/DefaultBrowserController.m:
  • Preferences.subproj/GeneralPreferences.m:
  • Preferences.subproj/PasswordsEditor.m:
  • Preferences.subproj/SecurityPreferences.m:
  • Preferences.subproj/TabsPreferences.m:
  • Preferences.subproj/WBPreferences.m:
  • RendezvousController.m:
  • ResourceProgressEntry.m:
  • SearchTextField.m:
  • ServicesProvider.m:
  • WebSearchManager.m:
  • main.m:
11:13 AM Changeset in webkit [4371] by mjs
  • 8 edits in trunk

WebCore:

Reviewed by Don.

  • fixed 3257307 - REGRESSION: crash using onFocus="this.blur()"
  • kwq/KWQTextField.mm:

(-[KWQTextField setHasFocus:]): Don't call
KWQKHTMLPart::setDocumentFocus(widget) to start with, it might
invoke a handler which could call blur(), and we don't want to do
the selection handling after that; futhermore, it will get called
anyway when we deliver the FocusIn event to the event
filter. Also, sometimes unfocusing in the middle of a focus can
leave us and AppKit in an inconsistent state; correct this. A
comment explains the details.

WebKit:

Reviewed by Don.

  • fixed 3257307 - REGRESSION: crash using onFocus="this.blur()"
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge makeFirstResponder:]): Let the WebView know that this is a programmatic focus.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): Check if this is a programmatic focus from WebCore - if so, treat it like a direct focus, even if there is a selection direction set.
  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (-[WebView _pushPerformingProgrammaticFocus]): New method to indicate upcoming programmatic focus. (-[WebView _popPerformingProgrammaticFocus]): New method to indicate end of programmatic focus. Needs to nest with the previous. (-[WebView _isPerformingProgrammaticFocus]): Check if we are handling a programmatic focus from WebCore.
11:03 AM Changeset in webkit [4370] by mjs
  • 8 edits in trunk/WebCore

Reviewed by John.

  • fixed 3240129 - REGRESSION: www.ezprints.com navigation buttons don't show up (window.addEventListener)

The problem here was that event handlers set using
window.addEventListener were set as regular event handlers on the
document object instead of as window event handlers - and the load
event does not fire properly that way.

The fix was to add support for both HTML and non-HTML window event
handlers. The old window event methods supported only "HTML"
handlers, but were not named as such.

  • khtml/ecma/kjs_window.cpp: (Window::setListener): Use setHTMLWindowEventListener. (Window::getListener): Use getHTMLWindowEventListener. (WindowFunc::tryCall): use addWindowEventListener and removeWindowEventListener on the DocumentImpl instead of addEventListener and removeEventListener on the Document.
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): Use setHTMLWindowEventListener instead of the old setWindowEventListener.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler): Don't stop after the first window event handler - keep going, since there might now be more than one for the same event. (DocumentImpl::setHTMLWindowEventListener): Renamed from setWindowEventListener. (DocumentImpl::getHTMLWindowEventListener): Renamed from getWindowEventListener. (DocumentImpl::removeHTMLWindowEventListener): Renamed from removeWindowEventListener. (DocumentImpl::addWindowEventListener): Implemented - support adding non-HTML window event listeners, which, unlike html listeners, are nto exclusive - there may be more than one. (DocumentImpl::removeWindowEventListener): Implemented. (DocumentImpl::hasWindowEventListener): Check if a window has any handler at all for a prticular event.
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::addEventListener): Add ref/deref pair to protect against last ref of listener going away on remove. Correct comment about the removal.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage): Check for an UNLOAD event handler using hasWindowEventListener instead of getHTMLWindowEventListener, to check for even addListener-style unload handlers.
9:56 AM Changeset in webkit [4369] by kocienda
  • 38 edits
    2 adds in trunk/WebKit

Tests:

Reviewed by John

Moved WebAssertions header to WebKit

  • PDFViewer/PDFRepresentation.m:

WebFoundation:

Reviewed by John

Copied WebAssertions.[hm] to WebKit
Renamed copy of WebAssertions.[hm] that stayed to NSURLAssertions.[hm]
Renamed WebFoundationLogging.[hm] to NSURLLogging.[hm]

Search and replace through all the code in this framework to
twiddle names used and defined in the logging and assertions
files so that they use an "NSURL" prefix instead of no prefix, i
a "Web" prefix, or a "WebFoundation" prefix.

Removed logging exported symbols to exports file.

  • AuthenticationManager.subproj/NSHTTPAuthenticator.m: (-[NSHTTPAuthenticator init]):
  • AuthenticationManager.subproj/NSURLAuthenticationChallenge.m: (-[NSURLAuthenticationChallenge init]):
  • AuthenticationManager.subproj/NSURLCredentialStorage.m: (-[NSURLCredentialStorage init]):
  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m: (-[NSURLKeychainCredentialStorage _protectionSpaceWithKeychainItem:isDefault:]): (-[NSURLKeychainCredentialStorage _secProtocolForProtectionSpace:]): (-[NSURLKeychainCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): (-[NSURLKeychainCredentialStorage _updateDefaultState:forCredential:protectionSpace:]): (-[NSURLKeychainCredentialStorage _initializeFromKeychain]): (-[NSURLKeychainCredentialStorage removeCredential:forProtectionSpace:]):
  • CacheLoader.subproj/NSNetworkSettings.m: (-[NSNetworkSettings _listenForProxySettingChanges]): (-[NSNetworkSettings init]):
  • CacheLoader.subproj/NSURLCache.m: (-[NSURLCache cachedResponseForRequest:]): (-[NSURLCache storeCachedResponse:forRequest:]): (-[NSURLCache removeCachedResponseForRequest:]): (-[NSURLCache removeAllCachedResponses]): (-[NSURLCache _memoryCacheRemoveNodeFromLRUList:]): (-[NSURLCache _memoryCacheAppendNodeToLRUList:]): (-[NSURLCache _memoryCacheTouchNode:]): (-[NSURLCache _memoryCacheTruncate:]): (-[NSURLCache _memoryCacheGet:]): (-[NSURLCache _memoryCachePut:]): (-[NSURLCache _memoryCacheRemove:]): (-[NSURLCache _diskCacheSetSyncTimer]): (-[NSURLCache _diskCacheSync:]): (-[NSURLCache _diskCacheCreateLRUList:]): (-[NSURLCache _diskCacheCreateDirectory]): (-[NSURLCache _diskCacheGet:]): (-[NSURLCache _diskCacheTruncate:]): (-[NSURLCache _diskCacheScheduleWrite:]): (-[NSURLCache _diskCacheExecuteWrite:]): (-[NSURLCache _diskCacheScheduleRemoval:]): (-[NSURLCache _diskCacheExecuteRemoval:]):
  • CacheLoader.subproj/NSURLConnection.m: (-[NSURLConnection initWithRequest:delegate:]): (+[NSURLConnection _forceSingleLoad]): (-[NSURLConnection _postDidReceiveResponseCallback]): (-[NSURLConnection _sendWillSendRequestCallback]): (-[NSURLConnection _sendDidReceiveResponseCallback]): (-[NSURLConnection _sendDidReceiveDataCallback]): (-[NSURLConnection _sendDidFailCallback]): (-[NSURLConnection _sendDidFinishLoadingCallback]): (-[NSURLConnection _chooseCachedResponse]): (-[NSURLConnection _beginLoad]): (-[NSURLConnection _checkIfTimedOut]): (-[NSURLConnection _cleanup]): (-[NSURLConnection _wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnection _didReceiveAuthenticationChallenge:]): (-[NSURLConnection _didReceiveResponse:cacheStoragePolicy:]): (-[NSURLConnection _didFinishReturnCachedResponse:]): (-[NSURLConnection _didFinishLoading]): (+[NSURLConnection incrementOriginLoadCount]): (_loadThrottler): (_loadSweeper): (-[NSURLConnectionInternal dealloc]): (-[NSURLConnectionInternal URLProtocol:wasRedirectedToRequest:redirectResponse:]): (-[NSURLConnectionInternal URLProtocol:cachedResponseIsValid:]):
  • CacheLoader.subproj/NSURLConnectionQueue.m: (-[NSURLConnectionQueue put:URL:]):
  • CacheLoader.subproj/NSURLProtocol.m: (+[NSURLProtocol canonicalRequestForRequest:]): (+[NSURLProtocol requestIsCacheEquivalent:toRequest:]): (+[NSURLProtocol propertyForKey:inRequest:]): (+[NSURLProtocol setProperty:forKey:inRequest:]): (+[NSURLProtocol _makeRequestCanonicalByMakingRequestURLCanonical:]):
  • CacheLoader.subproj/NSURLRequest.m: (-[NSURLRequest _URLHasScheme:]): (+[NSURLRequest allowsAnyHTTPSCertificateForHost:]): (+[NSURLRequest setAllowsAnyHTTPSCertificate:forHost:]): (-[NSMutableURLRequest setHTTPMethod:]):
  • CacheLoader.subproj/NSURLResponse.m: (-[NSURLResponse suggestedFilename]):
  • CookieManager.subproj/NSHTTPCookie.m: (-[NSHTTPCookie initWithProperties:]): (-[NSHTTPCookie init]): (+[NSHTTPCookie cookieWithV0Spec:forURL:locationHeader:]):
  • CookieManager.subproj/NSHTTPCookieDOStorage.m: (-[NSHTTPCookieDOStorage _establishConnection]):
  • CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): (-[NSHTTPCookieStorage _cookieRequestHeaderFieldsForURL:withExtraCookies:]): (-[NSHTTPCookieStorage init]): (-[NSHTTPCookieStorage setCookiesFromResponseHeader:forURL:policyBaseURL:]):
  • Database.subproj/NSLRUFileList.m: (NSLRUFileListRelease): (NSLRUFileListRebuildFileDataUsingRootDirectory): (NSLRUFileListRemoveFileWithPath): (NSLRUFileListTouchFileWithPath): (NSLRUFileListSetFileData): (NSLRUFileListGetPathOfOldestFile): (NSLRUFileListRemoveOldestFileFromList): (NSLRUFileListContainsItem): (NSLRUFileListGetFileSize): (NSLRUFileListCountItems): (NSLRUFileListGetTotalSize): (NSLRUFileListRemoveAllFilesFromList): (compareTimes): (cStringEqual): (cStringHash): (NSLRUFileDataEqual): (NSLRUFileListGetOldestFileData): (NSLRUFileDataReleaseApplierFunction): (NSLRUFileDataRelease):
  • Database.subproj/WebFileDatabase.m: (-[WebFileDatabaseOp initWithCode:key:object:]): (-[WebFileDatabaseOp perform:]): (-[WebFileDatabase _createLRUList:]): (-[WebFileDatabase setObject:forKey:]): (-[WebFileDatabase removeObjectForKey:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase lazySync:]): (-[WebFileDatabase sync]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • FileTransfer.subproj/NSBinHexDecoder.m: (-[NSBinHexDecoder decodeIntoBuffer:size:]): (-[NSBinHexDecoder decodeHeader]): (-[NSBinHexDecoder decodeForkWithData:count:CRCCheckFlag:]): (-[NSBinHexDecoder decodeData:dataForkData:resourceForkData:]): (-[NSBinHexDecoder finishDecoding]):
  • FileTransfer.subproj/NSGZipDecoder.m: (-[NSGZipDecoder init]): (-[NSGZipDecoder decodeData:dataForkData:resourceForkData:]): (-[NSGZipDecoder finishDecoding]): (-[NSGZipDecoder fileAttributes]): (-[NSGZipDecoder filename]):
  • FileTransfer.subproj/NSMacBinaryDecoder.m: (-[NSMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[NSMacBinaryDecoder fileAttributes]):
  • FileTransfer.subproj/NSURLDownload.m: (-[NSURLDownloadInternal dealloc]): (-[NSURLDownload initWithSource:delegate:]): (-[NSURLDownload setDestination:allowOverwrite:]): (-[NSURLDownload connection:didReceiveAuthenticationChallenge:]): (-[NSURLDownload connection:didCancelAuthenticationChallenge:]): (-[NSURLDownload connection:didReceiveData:]): (-[NSURLDownload connectionDidFinishLoading:]): (-[NSURLDownload _createFSRefForPath:]): (-[NSURLDownload _createFileIfNecessary]): (-[NSURLDownload _decodeHeaderData:dataForkData:resourceForkData:]): (-[NSURLDownload _decodeData:dataForkData:resourceForkData:]): (-[NSURLDownload _decodeData:]): (-[NSURLDownload _dataIfDoneBufferingData:]): (-[NSURLDownload _writeForkData:isDataFork:]): (-[NSURLDownload _closeForkSync:]): (-[NSURLConnectionDelegateProxy connection:willSendRequest:redirectResponse:]): (-[NSURLConnectionDelegateProxy connection:didReceiveAuthenticationChallenge:]): (-[NSURLConnectionDelegateProxy connection:didCancelAuthenticationChallenge:]): (-[NSURLConnectionDelegateProxy connection:didReceiveResponse:]): (-[NSURLConnectionDelegateProxy connection:didReceiveData:]): (-[NSURLConnectionDelegateProxy connectionDidFinishLoading:]): (-[NSURLConnectionDelegateProxy connection:didFailWithError:]): (WriteCompletionCallback): (CloseCompletionCallback): (DeleteCompletionCallback):
  • Misc.subproj/NSURLAssertions.h:
  • Misc.subproj/NSURLAssertions.m: (NSURLReportAssertionFailure): (NSURLReportAssertionFailureWithMessage): (NSURLReportArgumentAssertionFailure): (NSURLReportFatalError): (NSURLReportError): (NSURLLog):
  • Misc.subproj/NSURLLogging.h:
  • Misc.subproj/NSURLLogging.m:
  • Misc.subproj/WebAssertions.h: Removed.
  • Misc.subproj/WebAssertions.m: Removed.
  • Misc.subproj/WebFoundationLogging.h: Removed.
  • Misc.subproj/WebFoundationLogging.m: Removed.
  • Misc.subproj/WebLocalizableStrings.m: (WebLocalizedString):
  • Misc.subproj/WebNSCalendarDateExtras.m: (+[NSCalendarDate _web_dateFromHTTPDateString:]):
  • Misc.subproj/WebNSDataExtras.m: (-[NSData _web_parseRFC822HeaderFields]):
  • Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_changeFinderAttributes:forFileAtPath:]): (-[NSFileManager _web_noteFileChangedAtPath:]):
  • Misc.subproj/WebNSStringExtras.m:
  • Misc.subproj/WebNSURLExtras.m: (URLStringByAddingPercentEscapes): (hexDigitValue):
  • Misc.subproj/WebQueue.m: (-[WebQueue put:]): (-[WebQueue peekAt:]): (-[WebQueue remove:]):
  • Misc.subproj/WebSystemBits.m: (WebGetRandomBytes): (WebSetThreadPriority): (initCapabilities):
  • ProtocolHandlers.subproj/NSAboutURLProtocol.m: (+[NSAboutURLProtocol canInitWithRequest:]): (+[NSAboutURLProtocol canonicalRequestForRequest:]):
  • ProtocolHandlers.subproj/NSCFNetworkHTTPURLProtocol.m: (+[NSCFNetworkHTTPURLProtocol canInitWithRequest:]): (-[NSCFNetworkHTTPURLProtocol dealloc]): (-[NSCFNetworkHTTPURLProtocol setCertificatePolicyOnStream]): (-[NSCFNetworkHTTPURLProtocol continueBeginLoadInBackgroundAfterCreatingHTTPRequest]): (-[NSCFNetworkHTTPURLProtocol addConditionalFieldsToHeader]): (-[NSCFNetworkHTTPURLProtocol addMessageBodyToRequest]): (-[NSCFNetworkHTTPURLProtocol retryAfterConnectingToInternet]): (-[NSCFNetworkHTTPURLProtocol handleReadStreamEvent:event:]): (-[NSCFNetworkHTTPURLProtocol performHTTPHeaderRead:andCall:]): (-[NSCFNetworkHTTPURLProtocol setResponseHeaderUsingHTTPResponse:andCall:context:]):
  • ProtocolHandlers.subproj/NSFTPURLProtocol.m: (+[NSFTPURLProtocol canInitWithRequest:]): (+[NSFTPURLProtocol _canonicalURLForURL:]): (-[NSFTPURLProtocol startLoading]): (-[NSFTPURLProtocol determineErrorAndFail]): (-[NSFTPURLProtocol handleReadStreamEvent:event:]):
  • ProtocolHandlers.subproj/NSFileURLProtocol.m: (+[NSFileURLProtocol canInitWithRequest:]): (+[NSFileURLProtocol _canonicalURLForURL:]):
  • ProtocolHandlers.subproj/NSHTTPURLProtocol.m: (+[NSHTTPURLProtocol _canonicalURLForURL:]): (+[NSHTTPURLProtocol requestIsCacheEquivalent:toRequest:]): (-[NSHTTPURLProtocol startLoading]): (-[NSHTTPURLProtocol cachedResponseRevalidated]): (-[NSHTTPURLProtocol _cachedResponsePassesValidityChecks]): (-[NSHTTPURLProtocol HTTPResponse]): (-[NSHTTPURLProtocol buildHTTPResponse]): (-[NSHTTPURLProtocol determineErrorAndFail]): (-[NSHTTPURLProtocol _cachePolicyForResponse]): (-[NSHTTPURLProtocol setResponseHeader:]): (-[NSHTTPURLProtocol _URLStringFromLocationHeader]):
  • ProtocolHandlers.subproj/NSSSLProxyWrapperStream.m: (createConnectBytes): (wSocketStreamCallBack):
  • ProtocolHandlers.subproj/NSSimpleHTTPURLProtocol.m: (ensureRequestStringCapacity): (appendBytesToRequestString): (appendIntegerToRequestString): (appendNSStringToRequestString): (_loadRunLoop): (_socketWriteCallback): (_socketReadCallback): (_addCookieHeader): (+[NSSimpleHTTPURLProtocol canInitWithRequest:]): (-[NSSimpleHTTPURLProtocol _canUsePersistentConnectionForRequest]): (-[NSSimpleHTTPURLProtocol _continueLoadingWithFileDescriptor:]): (-[NSSimpleHTTPURLProtocol _continueLoadingWithAddressInfo]): (-[NSSimpleHTTPURLProtocol _addRequestMessageBody]): (-[NSSimpleHTTPURLProtocol buildHTTPRequest]): (-[NSSimpleHTTPURLProtocol _parseHeaderFromData:]): (-[NSSimpleHTTPURLProtocol _finishedWithFileDescriptor]): (-[NSSimpleHTTPURLProtocol _processRawData]):
  • WebFoundation-base.exp:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by John

Copied WebAssertions.[hm] from WebFoundation to WebKit

Updated all imports.

Added logging exported symbols to exports file.

  • History.subproj/WebBackForwardList.m:
  • History.subproj/WebHistory.m:
  • History.subproj/WebHistoryItem.m:
  • Misc.subproj/WebAssertions.h: Added.
  • Misc.subproj/WebAssertions.m: Added. (vprintf_stderr_objc): (WebReportAssertionFailure): (WebReportAssertionFailureWithMessage): (WebReportArgumentAssertionFailure): (WebReportFatalError): (WebReportError): (WebLog):
  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebNSPasteboardExtras.m:
  • Misc.subproj/WebStringTruncator.m:
  • Panels.subproj/WebAuthenticationPanel.m:
  • Panels.subproj/WebPanelAuthenticationHandler.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginDocumentView.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebCookieAdapter.m:
  • WebCoreSupport.subproj/WebFileButton.m:
  • WebCoreSupport.subproj/WebImageRenderer.m:
  • WebCoreSupport.subproj/WebImageRendererFactory.m:
  • WebCoreSupport.subproj/WebJavaScriptTextInputPanel.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebCoreSupport.subproj/WebTextRendererFactory.m:
  • WebCoreSupport.subproj/WebViewFactory.m:
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebClipView.m:
  • WebView.subproj/WebDataProtocol.m:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebImageView.m:
  • WebView.subproj/WebTextRepresentation.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by John

Copied WebAssertions.[hm] from WebFoundation.[hm] to WebKit.
Updated all imports.

  • ABHomePagesController.m:
  • ActivityViewer.m:
  • AppController.m:
  • BookmarkSource.m:
  • BookmarksViewController.m:
  • BrowserApplication.m:
  • BrowserDocument.m:
  • BrowserDocumentController.m:
  • BrowserNSAppleEventDescriptorExtras.m:
  • BrowserNSMenuExtras.m:
  • BrowserNSNetServiceExtras.m:
  • BrowserNSOutlineViewExtras.m:
  • BrowserNSSplitViewExtras.m:
  • BrowserNSStringExtras.m:
  • BrowserNSTableViewExtras.m:
  • BrowserNSWindowExtras.m:
  • BrowserNSWorkspaceExtras.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.m:
  • BrowserWebFrameExtras.m:
  • BrowserWebViewExtras.m:
  • BrowserWindow.m:
  • BrowserWindowController.m:
  • BugReportController.m:
  • ClippedItemsIndicator.m:
  • ColoredRect.m:
  • CompletionController.m:
  • ContextMenuHandler.m:
  • Debug/DebugUtilities.m:
  • Debug/Logging.h:
  • DownloadMonitor.m:
  • DownloadProgressEntry.m:
  • DownloadRow.m:
  • DownloadViewController.m:
  • DownloadWindowController.m:
  • FavoriteButton.m:
  • FavoritesBar.m:
  • FavoritesBarView.m:
  • FindPanelController.m:
  • FormCompletionController.m:
  • FrameProgressEntry.m:
  • GoogleSearchChannel.m:
  • HTMLSourceDocument.m:
  • ImageAndTextCell.m:
  • InternetConfigUtilities.m:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • NewBookmarksController.m:
  • OutlineViewPlus.m:
  • Preferences.subproj/AdvancedPreferences.m:
  • Preferences.subproj/BookmarkPreferences.m:
  • Preferences.subproj/DefaultBrowserController.m:
  • Preferences.subproj/GeneralPreferences.m:
  • Preferences.subproj/ISyncController.m:
  • Preferences.subproj/PasswordsEditor.m:
  • Preferences.subproj/WBPreferences.m:
  • RendezvousController.m:
  • ResourceProgressEntry.m:
  • SearchChannel.m:
  • SlidingAnimation.m:
  • SpinningProgressIndicator.m:
  • TabBarView.m:
  • TabButton.m:
  • TableViewPlus.m:
  • Test/PageLoadTestRunner.m:
  • TextEncodingMenu.m:
  • TextFieldWithControls.m:
  • TitleBarButton.m:
  • URLCompletionController.m:
  • WebBookmark.m:
  • WebBookmarkImporter.m:
  • WebBookmarkLeaf.m:
  • WebBookmarkList.m:
  • WebBookmarkProxy.m:
  • WebSearchManager.m:

May 13, 2003:

7:06 PM Changeset in webkit [4368] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3222607. divs that specify a fixed width should have
their minwidths increased to that width. This is an issue
on diveintomark's list as well as a blocker for Benoit.

Reviewed by gramps

  • khtml/rendering/render_block.cpp:
6:39 PM Changeset in webkit [4367] by hyatt
  • 18 edits in trunk/WebCore

Fix for 3256376, absolute positioned content that had to be
scrolled into view would not respond to events. This is a
regression caused by fixing the size of the HTML element.

I stopped all of the updating of layer widths/heights in
setLayouted and in setWidth/Height of RenderBox and special-cased
the sizing of the RenderCanvas layer so that it always encloses
all content.

This patch also contains a fix for 3211915, left/top positions
not computed properly when auto or static. The patch adds
staticX/Y member variables to RenderBox that holds the cached
values that can then be used by positioned elements to determine
their correct positions in the flow. RenderStyles also now
remember both the original display of an element as well as
the mutated display (e.g., when an inline becomes a block
because of absolute positioning).

Reviewed by darin (canvas fix) and kocienda (left/top fix)

  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::position): (RenderBox::setStaticX): (RenderBox::setStaticY): (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteVertical):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_flow.cpp: (RenderFlow::createInlineBox):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
  • khtml/rendering/render_line.cpp: (InlineFlowBox::placeBoxesHorizontally): (InlineFlowBox::adjustMaxAscentAndDescent): (InlineFlowBox::computeLogicalBoxHeights): (InlineFlowBox::placeBoxesVertically): (InlineFlowBox::shrinkBoxesWithNoTextChildren):
  • khtml/rendering/render_object.cpp: (RenderObject::hasStaticX): (RenderObject::hasStaticY): (RenderObject::setNeedsLayout): (RenderObject::createInlineBox):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.cpp: (RenderStyle::diff):
  • khtml/rendering/render_style.h:
  • khtml/rendering/render_text.cpp: (RenderText::createInlineBox):
  • khtml/rendering/render_text.h:
6:30 PM Changeset in webkit [4366] by rjw
  • 13 edits
    1 add in trunk

WebKit:

Fixed 3014661. We now display (a lame Lemay) image
when an image fails to load. We also display the
alt text if it fits within the image container
above the missing image icon. Alt text is also
now shown if image loading is disabled.

Reviewed by John.

  • Resources/missing_image.tiff: Added.
  • WebCoreSupport.subproj/WebImageRenderer.h:
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]): (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer isNull]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithName:]):
  • WebKit.pbproj/project.pbxproj:

WebCore:

Fixed 3014661. We now display (a lame Lemay) image
when an image fails to load. We also display the
alt text if it fits within the image container
above the missing image icon. Alt text is also
now shown if image loading is disabled.

Reviewed by John.

  • khtml/misc/loader.cpp: (CachedImage::data): (Cache::init):
  • khtml/rendering/render_image.cpp: (RenderImage::paintObject): (RenderImage::reload):
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (KWQLoadPixmap): (QPixmap::QPixmap): (QPixmap::isNull):
  • kwq/WebCoreImageRenderer.h:
  • kwq/WebCoreImageRendererFactory.h:
3:36 PM Changeset in webkit [4365] by cblu
  • 2 edits in trunk/WebKit

Reviewed by Chris and Richard.

  • fixed 3257296 -- REGRESSION: crash in WebImageRendererFactory (movietickets.com)
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): Check for nil. (-[WebImageRenderer initWithData:MIMEType:]): Check for nil, also don't check for GIF signature until after the object is allocated.
2:19 PM Changeset in webkit [4364]
  • 1 copy
    318 deletes in branches/unlabeled-1.6.20

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.6.20'.

2:19 PM Changeset in webkit [4363] by mjs
  • 18 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu
  • improved JavaScript error message format
  • kjs/error_object.cpp: (ErrorProtoFuncImp::call): Include line number in toString output.
  • kjs/internal.cpp: (Parser::parse): Remove redundant fprintf.
  • kjs/interpreter.cpp: (Interpreter::evaluate): Log if the flag is on. Include filename in log output. (Interpreter::shouldPrintExceptions): Check the global flag. (Interpreter::setShouldPrintExceptions): Set the global flag.
  • kjs/interpreter.h:
  • kjs/nodes.cpp: (Node::throwError): Add variants that include value and expression or label in format. (NewExprNode::evaluate): Improve error message. (FunctionCallNode::evaluate): Improve error message. (RelationalNode::evaluate): Improve error message. (ContinueNode::execute): Improve error message. (BreakNode::execute): Improve error message. (LabelNode::execute): Improve error message.
  • kjs/nodes.h:

WebCore:

Reviewed by Darin.

  • fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Pass the filename.
  • kwq/WebCoreJavaScript.h:
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript shouldPrintExceptions]): Call through to JavaScriptCore. (+[WebCoreJavaScript setShouldPrintExceptions:]): Call through to JavaScriptCore.
  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Print exception if there is one.
  • khtml/ecma/kjs_window.cpp: (ScheduledAction::execute): Print exception in the function case.

WebKit:

Reviewed by Darin.

  • fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu
  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics shouldPrintExceptions]): Call through to WebCore. (+[WebCoreStatistics setShouldPrintExceptions:]): Call through to WebCore.

WebBrowser:

Reviewed by Darin.

  • fixed 3254484 - Add a way to print JavaScript exceptions to the console via the debug menu
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): Include "Log JavaScript Exceptions" item. (-[BrowserDocument toggleLogJavaScriptExceptions:]): Call WebKit to do the toggle. (-[BrowserDocument validate_toggleLogJavaScriptExceptions:]): Set state properly.
1:40 PM Changeset in webkit [4362] by darin
  • 3 edits in trunk/WebCore

Tests:

Reviewed by Ken.

  • kde/kurl-test.chk: Update test results affected by the query changes.
  • kde/kurl-relative-test.chk: Update test results for recent changes (this test has been off for some time, so some changes were not that recent).
  • test.list: Turned kurl-relative-test back on.

WebCore:

Reviewed by Ken.

  • fixed 3140822 -- relative URLs starting with query strings clobber path as the RFC says, but web says no
  • kwq/KWQKURL.mm: (KURL::KURL): Add a case for queries (as with anchors) to match the behavior of the web (albeit not the RFC).
1:15 PM Changeset in webkit [4361] by darin
  • 7 edits in trunk

WebCore:

Reviewed by Ken.

  • fixed 3120355 -- importing IE favorites garbles non-ASCII characters (esp. bad for non-Roman languages)
  • kwq/WebCoreEncodings.h: Added decodeData:, removed all other (unused) methods.
  • kwq/WebCoreEncodings.mm: (+[WebCoreEncodings decodeData:]): Added. Calls the same decoder used to decode web pages.

WebKit:

Reviewed by Ken.

  • fixed 3120355 -- importing IE favorites garbles non-ASCII characters (esp. bad for non-Roman languages)
  • WebView.subproj/WebViewPrivate.h: Added _decodeData:.
  • WebView.subproj/WebViewPrivate.m: (+[WebView _decodeData:]): Added. Calls through to WebCore.

WebBrowser:

Reviewed by Ken.

  • fixed 3120355 -- importing IE favorites garbles non-ASCII characters (esp. bad for non-Roman languages)
  • WebBookmarkImporter.m: (-[WebBookmarkImporter initWithPath:]): Use new SPI call that decodes taking encoding into account, since the bookmarks file uses the same kinds of encoding techniques as web pages.
1:04 PM Changeset in webkit [4360] by mjs
  • 2 edits in trunk/WebKit

WebFoundation:

API CHANGE

Reviewed by Darin.

  • renamed NSErrorFailingURLKey to NSErrorFailingURLStringKey
  • removed NSURLCFStreamErrorDomain
  • Misc.subproj/NSURLError.h:
  • Misc.subproj/WebNSErrorExtras.m: (-[NSError _web_initWithDomain:code:failingURL:]): (-[NSError _web_failingURL]):
  • WebFoundation-base.exp:

WebKit:

Reviewed by Darin.

  • renamed NSErrorFailingURLKey to NSErrorFailingURLStringKey
  • Misc.subproj/WebKitErrors.m: (-[NSError _initWithPluginErrorCode:contentURLString:pluginPageURLString:pluginName:MIMEType:]):

WebBrowser:

Reviewed by Darin.

  • renamed NSErrorFailingURLKey to NSErrorFailingURLStringKey
  • LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]):
9:42 AM Changeset in webkit [4359] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed 3228186 -- REGRESSION: crash walking parent tree at housingscc.org in DOM::StyleBaseImpl::stylesheet()
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::~ElementImpl): Unref the stylesheet with the style declaration in it when destroying the element. (ElementImpl::createDecl): Ref the stylesheet with the style declaration in it when making a style element for this. If we don't we could end up with a style declaration without a stylesheet, which can't be manipulated by the CSS parser.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::removeCSSProperty): Since this function has a side effect of changing the stylesheet for the style declaration, ref the new stylesheet and unref the old one.
9:40 AM Changeset in webkit [4358] by sullivan
  • 2 edits in trunk/WebKit

fixed build break

Reviewed by Darin

  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): move #ifdefs; two required methods were being #ifdeffed out on Panther

May 12, 2003:

6:19 PM Changeset in webkit [4357] by rjw
  • 3 edits in trunk/WebKit

Fixed 3251316. * Public API Change *

Added -(void)setGroupName:(NSString *) and -(NSString *)groupName;

Reviewed by mjs.

  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m:
5:07 PM Changeset in webkit [4356] by rjw
  • 21 edits in trunk

WebCore:

Fixed 3194614 and 3194751. We avoid creating and render objects
and loading any images if the document is in 'renderless' mode.

Also, we now unique instances of the ObjC DOM wrappers.

Reviewed by hyatt/darin.

  • khtml/misc/loader.cpp:
  • khtml/xml/dom_docimpl.cpp:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm:
  • kwq/WebCoreDOMNode.mm:
  • kwq/WebDOMNode.h:

Pass the reported MIME type of an image up to WebKit when
creating an WebImageRenderer. This is useful to help speed up
the selection of an appropriate decoder.

Reviewed by darin.

  • kwq/WebCoreImageRendererFactory.h:
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm:

WebKit:

Fixed 3194614 and 3194751. Add SPI to set 'renderless' mode
for a frame.

Reviewed by darin.

  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m:

WebImageRenderers now get a MIME type that can be used to faciliate
selection of an appropriate decoder.

Reviewed by darin.

  • WebCoreSupport.subproj/WebImageRenderer.h:
  • WebCoreSupport.subproj/WebImageRenderer.m:
  • WebCoreSupport.subproj/WebImageRendererFactory.m:
  • WebKit.pbproj/project.pbxproj:
4:32 PM Changeset in webkit [4355] by sullivan
  • 7 edits in trunk/WebKit

WebKit:

  • addition to Darin's previous patch; when checking whether a request can be handled, take into account the schemes that were registered without an NSURLProtocol getting involved.

Reviewed by Darin

  • WebView.subproj/WebViewPrivate.h:
  • WebView.subproj/WebViewPrivate.m: (+[WebView _canHandleRequest:]): like NSURLConnection canHandleRequest, but also takes into account the schemes that were registered without an NSURLProtocol
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): use +[WebView _canHandleRequest] instead of +[NSURLConnection canHandleRequest]
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): ditto
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): ditto
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterNavigationPolicy:]): ditto

WebBrowser:

  • more code cleanup from bookmarks view change; eliminated BookmarksProtocol entirely.

Reviewed by Darin

  • BookmarksProtocol.h: Removed. Two #defines were moved to BookmarksView.h
  • BookmarksProtocol.m: Removed.
  • BookmarksView.h: Moved to #defines here from BookmarksProtocol.h
  • AppController.m: #import BookmarksView.h instead of BookmarksProtocol.h (+[AppController initialize]): remove call that registered BookmarkProtocol with NSURLProtocol
  • BrowserWebController.m: #import BookmarksView.h instead of BookmarksProtocol.h (-[BrowserWebView decidePolicyForAction:request:frame:newFrameName:decisionListener:]): use +[WebView _canHandleRequest] instead of +[NSURLConnection canHandleRequest] so it works for bookmarks (and any future registered schemes)
  • BrowserWindowController.m: #import BookmarksView.h instead of BookmarksProtocol.h
  • ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): use +[WebView _canHandleRequest] instead of +[NSURLConnection canHandleRequest] so it works for bookmarks (and any future registered schemes)
  • English.lproj/StringsNotToBeLocalized.txt: updated for moving the two #defines
  • WebBrowser.pbproj/project.pbxproj: updated for removed files
4:19 PM Changeset in webkit [4354] by darin
  • 4 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3240925 -- can't select or copy text from readonly INPUT elements

An AppKit peculiarity. Calling setEditable:NO will have a side effect of
doing setSelectable:NO unless you explicitly did setSelectable:YES.

  • kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): Call setSelectable:YES.
  • kwq/KWQTextField.mm: (-[KWQTextField setPasswordMode:]): When creating the password field, keep the setSelectable state synchronized. (-[KWQTextField setSelectable:]): If we already have a password field, be sure to keep its selectable state the same as the main field.
1:29 PM Changeset in webkit [4353] by darin
  • 6 edits in trunk/WebKit

WebKit:

Reviewed by John.

  • fixed 3254576 -- REGRESSION: visiting bookmarks view sometimes waits for other tabs to load first
  • WebView.subproj/WebViewPrivate.h: Added new SPI for registering view and represenation classes by scheme rather than MIME type.
  • WebView.subproj/WebViewPrivate.m: (+[WebView _registerViewClass:representationClass:forURLScheme:]]): Added. (+[WebView _generatedMIMETypeForURLScheme:]): Added. Makes a special MIME type for us only by the special "register scheme" mechanism. (+[WebView _representationExistsForURLScheme:]): Added.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Check for schemes that have their own representation, and handle them just like empty documents, loading no data, and doing it synchronously. (-[WebMainResourceClient loadWithRequest:]): Same thing here, only also arrange to get the appropriate MIME type. (-[WebMainResourceClient setDefersCallbacks:]): Same check here.
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

Reviewed by John.

  • fixed 3254576 -- REGRESSION: visiting bookmarks view sometimes waits for other tabs to load first
  • AppController.m: (+[AppController initialize]): Register the bookmarks view and representation class using the scheme, not the MIME type.
  • BrowserNSStringExtras.m: (-[NSString possibleURLsForUserTypedString]): Fix off by one error that would cause an NSException when you typed bookmarks:. Also fix so that bookmarks: is not treated as a host name.
9:11 AM Changeset in webkit [4352] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed 3255281 -- REGRESSION: objc_error in key loop code, closing tab containing aintitcool.com page
  • kwq/KWQTextField.mm: (-[KWQSecureTextField nextKeyView]): Change back to using our own nextKeyView implementation. By returning the nextKeyView from KWQTextField, we ended up making AppKit very upset about the key view loop. This undoes a change I made last Thursday, so the regression is very new and was never in a release. (-[KWQSecureTextField previousKeyView]): More of the same. (-[KWQSecureTextField nextValidKeyView]): Ditto. (-[KWQSecureTextField previousValidKeyView]): Ditto.
Note: See TracTimeline for information about the timeline view.