⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 20, 2003:

5:19 PM Changeset in webkit [4402] by rjw
  • 6 edits in trunk/WebKit

Fixed 3262825.
Fixed 3245625.
Fixed 3262547.

Recursively check items when going back/forward to ensure all
frame URLs are correct.

Added some logging to help diagnose back/forward problems.

Reviewed by John.

  • History.subproj/WebHistory.m: (-[WebHistory addItem:]):
  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebKitLogging.m:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem:]): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _URLsMatchItem:]): (-[WebFrame _loadItem:withLoadType:]):
3:43 PM Changeset in webkit [4401] by sheridan
  • 3 edits in trunk

Safari-81u

3:09 PM Changeset in webkit [4400]
  • 3 copies
    1 delete in branches/Safari-80~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-80~1-branch'.

3:09 PM Changeset in webkit [4399]
  • 3 copies
    1 delete in tags/Safari-80~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-80~1-anchor'.

3:09 PM Changeset in webkit [4398]
  • 3 copies in tags/Safari-80

This commit was manufactured by cvs2svn to create tag 'Safari-80'.

3:09 PM Changeset in webkit [4397] by sheridan
  • 8 edits in trunk

Safari-80 version stamp

10:48 AM Changeset in webkit [4396] by kocienda
  • 4 edits in trunk/WebKit

Reviewed by Darin

Due to some header file changes in Foundation on Panther,
Tweaked some includes so that WebKit builds on Jaguar
and Panther.

  • Carbon.subproj/CarbonWindowFrame.m:
  • Plugins.subproj/WebNetscapePluginPackage.m:
  • Plugins.subproj/WebPluginPackage.m:

May 19, 2003:

8:47 PM Changeset in webkit [4395] by mjs
  • 10 edits in trunk

JavaScriptCore:

  • fixed 3261096 - Make WebKit an umbrella framework
  • JavaScriptCore.pbproj/project.pbxproj: In a B&I build, compile as a sub-umbrella of WebKit.

WebCore:

  • fixed 3261096 - Make WebKit an umbrella framework
  • WebCore.pbproj/project.pbxproj: In a B&I build, compile as a sub-umbrella of WebKit.

WebKit:

  • fixed 3261096 - Make WebKit an umbrella framework
  • WebKit.pbproj/project.pbxproj: Build WebKit as a public umbrella framework when doing a B&I build.

WebBrowser:

  • fixed 3261096 - Make WebKit an umbrella framework
  • WebBrowser.pbproj/project.pbxproj: Build with umbrella public WebKit when doing a B&I build.
2:29 PM Changeset in webkit [4394] by kocienda
  • 3 edits in trunk/WebKit

Reviewed by Darin

  • Panels.subproj/WebAuthenticationPanel.m: Now imports Foundation/NSURLCredential.h
  • WebCoreSupport.subproj/WebCookieAdapter.m: Now imports Foundation/NSHTTPCookie.h
1:10 PM Changeset in webkit [4393] by kocienda
  • 58 edits in trunk/WebKit

top level:

Reviewed by Darin

Changes to move from WebFoundation to Foundation

  • Makefile.am: Add some targets to check out and build Foundation.
  • configure.in: Add some more command line options to support building Foundation.
  • make-Foundation.sh.in: Added. Helper script to build Foundation.

Tests:

Reviewed by Darin

Changed imports to include headers from Foundation
instead of WebFoundation.

Removed WebFoundation.framework as a dependency in
the project files.

Updated some test files to use Foundation-related names
instead of WebFoundation-related names.

No longer build WebFoundation-CacheLoader subdirectory.
This test has not worked in a very long time. No need
to keep up the ruse as long as the test does not work.

  • PDFViewer/DocumentController.m:
  • PDFViewer/PDFViewer.pbproj/project.pbxproj:
  • SimpleViewer/DocumentController.m:
  • SimpleViewer/SimpleViewer.pbproj/project.pbxproj:
  • SnippetEditor/SnippetController.m:
  • SnippetEditor/SnippetEditor.pbproj/project.pbxproj:
  • WebFoundation-CacheLoader/NeverExpiresTest.m: (-[NeverExpiresTest setUp]):
  • WebFoundation-Misc/Makefile.am:

WebKit:

Reviewed by Darin

Changed imports to include headers from Foundation
instead of WebFoundation.

Removed WebFoundation.framework as a dependency in
the project file.

  • History.subproj/WebHistory.m:
  • History.subproj/WebHistoryItem.m:
  • History.subproj/WebHistoryPrivate.m:
  • History.subproj/WebURLsWithTitles.m:
  • Misc.subproj/WebDownload.h:
  • Misc.subproj/WebDownload.m:
  • Misc.subproj/WebFileDatabase.m:
  • Misc.subproj/WebIconDatabase.m:
  • Misc.subproj/WebIconLoader.m:
  • Misc.subproj/WebKitErrors.m:
  • Misc.subproj/WebKitErrorsPrivate.h:
  • Misc.subproj/WebNSPasteboardExtras.m:
  • Misc.subproj/WebNSViewExtras.m:
  • Panels.subproj/WebAuthenticationPanel.h:
  • Panels.subproj/WebAuthenticationPanel.m:
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Panels.subproj/WebPanelAuthenticationHandler.m:
  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginDocumentView.m:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
  • Plugins.subproj/WebNullPluginView.m:
  • Plugins.subproj/WebPluginController.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebCookieAdapter.m:
  • WebCoreSupport.subproj/WebImageRendererFactory.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebDataProtocol.h:
  • WebView.subproj/WebDataProtocol.m:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebDefaultFrameLoadDelegate.m:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebDefaultResourceLoadDelegate.m:
  • WebView.subproj/WebDefaultUIDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLRepresentation.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebImageRepresentation.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebPreferences.m:
  • WebView.subproj/WebTextRepresentation.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebUIDelegate.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by Darin

Changed imports to include headers from Foundation
instead of WebFoundation.

Removed WebFoundation.framework as a dependency in
the project file.

  • AppController.m:
  • BookmarkSource.m:
  • BookmarksViewController.m:
  • BrowserDocument.h:
  • BrowserDocument.m:
  • BrowserDocumentController.m:
  • BrowserNSBundleExtras.m:
  • BrowserNSErrorExtras.h:
  • BrowserNSErrorExtras.m:
  • BrowserNSNetServiceExtras.m:
  • BrowserNSStringExtras.m:
  • BrowserNSURLExtras.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.m:
  • BrowserWindowController.m:
  • BugReportController.m:
  • ContextMenuHandler.m:
  • Debug/CacheController.m:
  • Debug/DebugUtilities.m:
  • Debug/SnippetController.m:
  • DownloadMonitor.m:
  • DownloadProgressEntry.m:
  • DownloadRow.m:
  • FormCompletionController.m:
  • FrameProgressEntry.m:
  • GlobalHistory.m:
  • GoogleSearchChannel.m:
  • HTMLSourceDocument.m:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • LocationChangeHandler.m:
  • LocationFieldEditor.m:
  • NewBookmarksController.m:
  • Preferences.subproj/AcceptedCookies.m:
  • Preferences.subproj/AdvancedPreferences.m:
  • Preferences.subproj/DefaultBrowserController.m:
  • Preferences.subproj/PasswordsEditor.m:
  • Preferences.subproj/SecurityPreferences.m:
  • Preferences.subproj/WBPreferences.m:
  • RendezvousController.m:
  • ResourceProgressEntry.m:
  • SlidingAnimation.m:
  • SpinningProgressIndicator.m:
  • TabBarView.m:
  • Test/PageLoadTestController.m:
  • Test/PageLoadTestRunner.m:
  • TitleBarButton.m:
  • URLCompletionController.m:
  • WebBookmarkImporter.m:
  • WebBookmarkLeaf.m:
  • main.m:
11:55 AM Changeset in webkit [4392] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Darin

Fixed build problem with declaring MIMEType as a category
on NSObject. This method needs to be typed to return NSString.

  • kwq/KWQLoader.mm

May 16, 2003:

9:55 PM Changeset in webkit [4391] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Ken.

  • fixed 3254063 - REGRESSION: hang in KJS PropertyMap with many items in iDisk pictures folder
  • kjs/property_map.cpp: (PropertyMap::expand): Fixed to maintain key count properly - otherwise the hashtable could get completely full, resulting in disaster. (PropertyMap::checkConsistency): Fixed compilation. Fixed to know about deleted sentinel. Fixed to search with double-hashing instead of linear probing.
6:40 PM Changeset in webkit [4390] by mjs
  • 12 edits in trunk/WebCore

Reviewed by Richard.

  • fixed 3260940 - REGRESSION: reproducible crash freeing page cache item
  • fixed 3241041 - REGRESSION: repro world leak of 1 JavaScript interpreter

The fix for these problems and probably other page cache wackiness
was to use a refcounting scheme for KHTMLView instead of counting
on the previous tricky ownership rules.

  • khtml/khtmlview.cpp: (KHTMLView::KHTMLView): Initialize _refCount to 1. (KHTMLView::~KHTMLView): Assert that _refCount is 0, to make sure no one is deleting views explicitly.
  • khtml/khtmlview.h:
  • khtml/rendering/render_frames.cpp: (RenderPart::~RenderPart): If our view is a KHTMLView, deref it. (RenderPart::setWidget): If the view is a KHTMLView, tell the superclass not to delete it and ref it.
  • khtml/rendering/render_frames.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::RenderWidget): Initizlize m_deleteWidget to false. (RenderWidget::~RenderWidget): Only delete widget if we're supposed to. (RenderWidget::setQWidget): Add extra delegeWidget argument that says whether to delete this widget when done - defaults to true.
  • khtml/rendering/render_replaced.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Removed _ownsView boolean -- we'll always hang on to a ref to it now. (KWQKHTMLPart::~KWQKHTMLPart): Deref the view always instead of deleting it sometimes. (KWQKHTMLPart::setView): deref the old view if not null. ref the new view if not null. Drop tricky ownership rules. (KWQKHTMLPart::openURLFromPageCache): Remove no longer applicable comment about the importance of when setView is called.
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:]): ref the document's view. (-[KWQPageState invalidate]): deref the document's view. (-[KWQPageState dealloc]): deref the document's view instead of deleting it.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]): No more need to pass weOwnIt argument to setView. Also, deref the view after passing it to the KWQKHTMLView -- we own the initial ref since we allocated it. (-[WebCoreBridge removeFromFrame]): No more need to pass weOwnIt argument to setView. (-[WebCoreBridge installInFrame:]): Ditto.
11:36 AM Changeset in webkit [4389] by mjs
  • 4 edits in trunk/WebKit

WebFoundation:

Reviewed by John.

  • fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
  • AuthenticationManager.subproj/NSURLKeychainCredentialStorage.m: (-[NSURLKeychainCredentialStorage _secProtocolForProtectionSpace:]): Don't assert if the protocol is unknown, just return 0 and let the higher levels fail gracefully. (-[NSURLKeychainCredentialStorage _saveCredential:forProtectionSpace:isDefault:]): Don't save if the protocol is unknown. Tolerate nil host.
  • AuthenticationManager.subproj/NSURLProtectionSpace.m: (-[NSURLProtectionSpace initWithHost:port:protocol:realm:authenticationMethod:]):
  • unrelated cookie code cleanup
  • CookieManager.subproj/NSHTTPCookieStorage.m: (-[NSHTTPCookieStorage _setCookies:forURL:policyBaseURL:]): Avoid warning about "0 previous cookies rejected"

WebKit:

Reviewed by John.

  • fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): Expect sourceFrame argument.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Include source frame in form state. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Include source frame in form state. Post directly to the target frame if it exists, since we want the form state to contain the right source frame. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Pass source frame to form delegate. (-[WebFormState initWithForm:values:sourceFrame:]): New sourceFrame argument. (-[WebFormState dealloc]): release sourceFrame. (-[WebFormState sourceFrame]): New method.

WebBrowser:

Reviewed by John.

  • fixed 3255088 - repro crash in WebCredentialStorage remembering password from onlinetrafficsafety.com
  • BrowserWebController.m: (-[FormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): Expect sourceFrame.
  • FormCompletionController.h:
  • FormCompletionController.m: (+[FormCompletionController _frame:sourceFrame:willSubmitLoginForm:withValues:formInfo:submissionListener:]): Pop up sheet based on source frame's window, and raise the sheet-bearing window if different than the target window. (+[FormCompletionController _frame:sourceFrame:willSubmitRegularForm:withValues:]): Expect and use sourceFrame. (+[FormCompletionController frame:sourceFrame:willSubmitForm:withValues:submissionListener:]): Expect sourceFrame.
10:28 AM Changeset in webkit [4388] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed 3256997 - reproducible world leak (of 1 JavaScript interpreter) using google images

This turned out to be a page cache bug, and nothing to do with
JavaScript. The part and view were also leaked.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Make sure to reset the view before resetting the document, so that when we check if the document is in the page cache to determine if we can delete the old view, we'll be checking the old document instead of the new one.
9:07 AM Changeset in webkit [4387] by kocienda
  • 10 edits
    2 adds in trunk/WebKit

WebFoundation:

Reviewed by Gramps

Moved WebDatabase and WebFileDatabase files to WebKit

Twiddled some logging constants now that the WebFileDatabase
has been removed from the framework.

Updated StringsNotToBeLocalized.txt.

  • Database.subproj/NSLRUFileList.m: (NSLRUFileListRemoveOldestFileFromList):
  • Database.subproj/WebDatabase.h: Removed.
  • Database.subproj/WebDatabase.m: Removed.
  • Database.subproj/WebFileDatabase.h: Removed.
  • Database.subproj/WebFileDatabase.m: Removed.
  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/NSURLLogging.h:
  • Misc.subproj/NSURLLogging.m:
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Reviewed by Gramps

Moved in WebDatabase and WebFileDatabase files from WebFoundation.

Copied NSLRUFileList from WebFoundation and renamed to WebLRUFileList.

Updated StringsNotToBeLocalized.txt.

  • English.lproj/StringsNotToBeLocalized.txt:
  • Misc.subproj/WebDatabase.h:
  • Misc.subproj/WebDatabase.m:
  • Misc.subproj/WebFileDatabase.h:
  • Misc.subproj/WebFileDatabase.m: (-[WebFileDatabaseOp initWithCode:key:object:]): (-[WebFileDatabaseOp perform:]): (SetThreadPriority): (-[WebFileDatabase _createLRUList:]): (-[WebFileDatabase _truncateToSizeLimit:]): (+[WebFileDatabase _syncLoop:]): (-[WebFileDatabase setObject:forKey:]): (-[WebFileDatabase removeObjectForKey:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase close]): (-[WebFileDatabase lazySync:]): (-[WebFileDatabase sync]): (-[WebFileDatabase count]): (-[WebFileDatabase usage]):
  • Misc.subproj/WebIconDatabase.m:
  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebKitLogging.m:
  • Misc.subproj/WebLRUFileList.h: Added.
  • Misc.subproj/WebLRUFileList.m: Added. (WebLRUFileListCreate): (WebLRUFileListRelease): (WebLRUFileListRebuildFileDataUsingRootDirectory): (WebLRUFileListRemoveFileWithPath): (WebLRUFileListTouchFileWithPath): (WebLRUFileListSetFileData): (WebLRUFileListGetPathOfOldestFile): (WebLRUFileListRemoveOldestFileFromList): (WebLRUFileListContainsItem): (WebLRUFileListGetFileSize): (WebLRUFileListCountItems): (WebLRUFileListGetTotalSize): (WebLRUFileListRemoveAllFilesFromList): (compareTimes): (cStringEqual): (cStringHash): (NSLRUFileDataEqual): (WebLRUFileListGetOldestFileData): (NSLRUFileDataReleaseApplierFunction): (NSLRUFileDataRelease): (NSLRUFileDataBinaryHeapDumpApplierFunction): (NSLRUFileDataDictDumpApplierFunction): (WebLRUFileListDescription):
  • WebKit.pbproj/project.pbxproj:
Note: See TracTimeline for information about the timeline view.