Timeline



May 22, 2003:

6:14 PM Changeset in webkit [4418] by rjw
  • 3 edits in trunk/WebKit

* Public API change *
100% compatible. Added notification when history items
change values.

Fixed 3265672
Reviewed by John.

  • History.subproj/WebHistoryItem.h:
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem setAlternateTitle:]): (-[WebHistoryItem setURL:]): (-[WebHistoryItem setOriginalURLString:]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem _setLastVisitedTimeInterval:]):
5:04 PM Changeset in webkit [4417] by hyatt
  • 9 edits in trunk/WebCore

Fix for 3259947. Can't add clippings on iht.com. The fix is
to make sure all DOM properties that relate to attributes return ""
and not "null" when the attribute isn't present or when the
DOMString is null.

Also patching the code for text-indent to make sure that floats
don't improperly consume text-indent. This fixes two of the issues
on diveintomark.

Reviewed by mjs

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::getValueProperty):
1:39 PM Changeset in webkit [4416] by rjw
  • 3 edits in trunk/WebKit

Fixed 3266464. Build problem on panther caused by overly
pedantic gcc.

Reviewed by John.

  • WebView.subproj/WebPreferences.m: (-[WebPreferences initWithCoder:]):
  • WebView.subproj/WebView.m: (-[WebView initWithCoder:]):
1:21 PM Changeset in webkit [4415] by rjw
  • 2 edits in trunk/WebKit

Add _web to method in category name.

Fixed 3266102. @selector missing ":".

Reviewed by Darin.

  • WebView.subproj/WebPreferences.m: (+[WebPreferences _removeReferenceForIdentifier:]): (-[NSMutableDictionary _web_checkLastReferenceForIdentifier:]):
11:21 AM Changeset in webkit [4414] by hyatt
  • 4 edits in trunk/WebCore

Make sure the overflow clip rect clips out the scrollbars
so that child layers aren't able to draw on top of the
scrollbars.

Also fix scrollbars so that they are painted before the
overflow clip rect is applied (just as backgrounds and borders
are).

These two fixes make the divtest example from Yahoo (sent by Mark
Malone) work.

Reviewed by john

  • khtml/rendering/render_box.cpp: (RenderBox::getOverflowClipRect):
  • khtml/rendering/render_layer.cpp: (RenderLayer::paint):
9:55 AM Changeset in webkit [4413] by darin
  • 3 edits in trunk/WebKit

Reviewed by John.

  • removed all entries except for jaguar.com because:

a) most of these sites now work fine without the spoofing or have gone away
b) nj.com and oregonlive.com do not work, but the spoofing committee (Mark,

Don, Dave, and me) decided we should stop spoofing and get them to fix
the sites instead

If we can resolve jaguar.com in a similar way, we can remove the spoofing
feature altogether.

  • WebView.subproj/WebUserAgentSpoofTable.gperf: Removed all but jaguar.com.
  • WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.
9:46 AM Changeset in webkit [4412] by darin
  • 5 edits in trunk/WebCore

Reviewed by John.

  • fixed 3216039 -- calls to m_redirectionTimer.stop() do not always clear m_scheduledRedirection
  • khtml/khtml_part.h: Added cancelRedirection().
  • khtml/khtml_part.cpp: (KHTMLPart::~KHTMLPart): Call cancelRedirection() instead of m_redirectionTimer.stop(). (KHTMLPart::restoreURL): Ditto. (KHTMLPart::openURL): Ditto. (KHTMLPart::closeURL): Ditto. (KHTMLPart::cancelRedirection): Added. Sets m_scheduledRedirection to noRedirectionScheduled and calls m_redirectionTimer.stop(), but is also safe to call after d is set to 0. (KHTMLPart::restoreState): Call cancelRedirection() instead of m_redirectionTimer.stop().
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Call cancelRedirection() instead of m_redirectionTimer.stop(). (KWQKHTMLPart::scrollToAnchor): Call cancelRedirection() instead of m_redirectionTimer.stop() (and setting m_scheduledRedirection).

May 21, 2003:

10:58 PM Changeset in webkit [4411] by hyatt
  • 7 edits in trunk/WebCore

This patch deals with the main cause of regressions from
the minimum font size removal. Because we stored font sizes
as integers, we ended up flooring font sizes, and when percentages
were nested, the magnitude of error increased dramatically.

This patch changes FontDef to store a float size instead of an
integer size. The style system thus always computes a precise
floating point value for a font, with no error introduced and
only once it has that final computed value does it round to the
nearest pixel for the QFont.

This fixes 3265628, www.anandtech.com.

Reviewed by rjw

  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLengthFloat):
  • khtml/css/cssstyleselector.cpp:
  • khtml/rendering/font.cpp: (Font::update):
  • khtml/rendering/font.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle):
8:52 PM Changeset in webkit [4410] by rjw
  • 6 edits in trunk/WebKit

* Public API Change *
The fix for 3265442 requires new API. This API is an addition
that is 100% compatible with the existing API.

Provide support for IB to palettize WebView.

Fixed 3265442.
Fixed 3263106.

Reviewed by Chris.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferencesPrivate dealloc]): (-[WebPreferences init]): (-[WebPreferences initWithIdentifier:]): (-[WebPreferences initWithCoder:]): (-[WebPreferences encodeWithCoder:]): (+[WebPreferences standardPreferences]): (-[WebPreferences dealloc]): (-[WebPreferences identifier]): (-[WebPreferences _stringValueForKey:]): (-[WebPreferences _setStringValue:forKey:]): (-[WebPreferences _integerValueForKey:]): (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _boolValueForKey:]): (-[WebPreferences _setBoolValue:forKey:]): (-[WebPreferences autosaves]): (+[WebPreferences _getInstanceForIdentifier:]): (+[WebPreferences _setInstance:forIdentifier:]): (+[WebPreferences _removeReferenceForIdentifier:]): (-[WebPreferences _postPreferencesChangesNotification]): (-[NSMutableDictionary _checkLastReferenceForIdentifier:]):
  • WebView.subproj/WebPreferencesPrivate.h:
  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView _commonInitializationFrameName:groupName:]): (-[WebView initWithCoder:]): (-[WebView encodeWithCoder:]): (-[WebView dealloc]): (-[WebView setPreferencesIdentifier:]): (-[WebView preferencesIdentifier]):
5:57 PM Changeset in webkit [4409] by cblu
  • 10 edits in trunk/WebKit

Fixed data source leak when viewing standalone plug-in content.

Reviewed by rjw.

  • Plugins.subproj/WebBaseNetscapePluginStream.h: don't inherit from WebBaseResourceHandleDelegate
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream transferMode]): new
  • Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation dealloc]): don't release the data source (-[WebNetscapePluginRepresentation setDataSource:]): don't retain the data source
  • Plugins.subproj/WebNetscapePluginStream.h:
  • Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): create a WebNetscapePluginConnectionDelegate (-[WebNetscapePluginStream dealloc]): release the WebNetscapePluginConnectionDelegate (-[WebNetscapePluginStream start]): start the load on the WebNetscapePluginConnectionDelegate (-[WebNetscapePluginStream stop]): start the load on the WebNetscapePluginConnectionDelegate (-[WebNetscapePluginConnectionDelegate initWithStream:view:]): new class, inherits from WebBaseResourceHandleDelegate (-[WebNetscapePluginConnectionDelegate _releaseResources]): (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:]): (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): (-[WebNetscapePluginConnectionDelegate cancel]):
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate response]): new
5:20 PM Changeset in webkit [4408] by mjs
  • 3 edits in trunk/WebKit

Reviewed by John.

  • fixed 3254473 - REGRESSION: nike help page reloads on mouseovers, triggered by onresize function

REGRESSION: reload loop due to onresize handler (fortune.com, flipdog.com, stanford.edu)

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): Go back to checking for at least one layout instead of last layout event time. Measure size in a way that ignores whether the scrollbares are there or not.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove last layout event time and add back laid out at least once boolean.
4:37 PM Changeset in webkit [4407] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3257990, attributes in HTML should always be case-insensitive
when matching CSS attribute selectors. Instead of relying on
the strict mode check, I patched the code to use an isXMLDoc
bool instead.

Also fixing a problem where <pre>s are mistakenly justifying their
text when text-align: justify is set.

Reviewed by kocienda

  • ChangeLog:
  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/rendering/bidi.cpp:
1:10 PM Changeset in webkit [4406] by cblu
  • 2 edits in trunk/WebKit

These problems:
3184359 - icon exception closing window while typing
3245476 - Safari-78 crashes or hangs after IMDB Find and using the history menu to go back ...
are not or are no longer reproducible. They were caused by an exception raised in WebKit.
Since we don't use exceptions in WebKit, I've replaced the exception with an assert.

Reviewed by john.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _releaseFutureIconForURL:]): assert instead of exception if failure
12:03 PM Changeset in webkit [4405] by voas
  • 6 edits in trunk/WebKit

2003-05-21 Ed Voas <​voas@apple.com>

  • fixed 3262868: Update Carbon WebKit API prefixes
  • fixed 3264980: Carbon support in WebKit needs to route mouse events properly

Reviewed by Richard.

  • Carbon.subproj/CarbonUtils.h:
  • Carbon.subproj/CarbonUtils.m: (WebInitForCarbon): (WebConvertNSImageToCGImageRef):
  • Carbon.subproj/HIWebView.h:
  • Carbon.subproj/HIWebView.m: (HIWebViewGetWebView): (OwningWindowChanged): (WindowHandler): (HIWebViewEventHandler):
  • WebKit.exp:
11:14 AM Changeset in webkit [4404] by vicki
  • 8 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by john

  • fixed 3234553: Safari and its frameworks should link using order files

WebCore:

Reviewed by john

  • fixed 3234553: Safari and its frameworks should link using order files
  • WebCore.order: Added.
  • WebCore.pbproj/project.pbxproj: set SECTORDER_FLAGS = -sectorder TEXT text WebCore.order

WebKit:

Reviewed by john

  • fixed 3234553: Safari and its frameworks should link using order files
  • WebKit.order: Added.
  • WebKit.pbproj/project.pbxproj: set SECTORDER_FLAGS = -sectorder TEXT text WebKit.order;

WebBrowser:

Reviewed by john

  • fixed 3234553: Safari and its frameworks should link using order files
  • Safari.order: Added.
  • WebBrowser.pbproj/project.pbxproj: set SECTORDER_FLAGS = -sectorder TEXT text Safari.order -e start;
12:00 AM Changeset in webkit [4403] by hyatt
  • 15 edits
    1 add in trunk/WebCore

An implementation of fieldset and legend. This is based off
some KHTML trunk code, but only loosely. I had to rewrite
most of it in order to make fieldsets work properly with
padding and in order to match the fieldset style of other
browsers more closely.

This code also fixes HTML4 buttons so that they don't fill the
width of containing blocks. This has been a long-standing
bug. Since legends behave the same way as buttons and floats,
I made a new helper function, sizesToMaxWidth(), to denote an
element that just uses its max intrinsic width when sizing
instead of filling a containing block.

This patch also fixes z-index so it properly only applies to the
root and to positioned/relpositioned elements.

Reviewed by darin

  • ChangeLog:
  • ForwardingHeaders/rendering/render_block.h: Added.
  • khtml/css/html4.css:
  • khtml/html/html_formimpl.cpp: (HTMLFieldSetElementImpl::HTMLFieldSetElementImpl): (HTMLFieldSetElementImpl::attach): (HTMLFieldSetElementImpl::createRenderer): (HTMLLegendElementImpl::HTMLLegendElementImpl): (HTMLLegendElementImpl::id): (HTMLLegendElementImpl::attach): (HTMLLegendElementImpl::createRenderer):
  • khtml/html/html_formimpl.h:
  • khtml/rendering/render_block.cpp:
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::calcWidthUsing):
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_form.cpp: (RenderFieldset::RenderFieldset): (RenderFieldset::layoutLegend): (RenderFieldset::findLegend): (RenderFieldset::paintBoxDecorations): (RenderFieldset::paintBorderMinusLegend): (RenderLegend::RenderLegend):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_object.cpp: (RenderObject::sizesToMaxWidth):
  • khtml/rendering/render_object.h:

May 20, 2003:

5:19 PM Changeset in webkit [4402] by rjw
  • 6 edits in trunk/WebKit

Fixed 3262825.
Fixed 3245625.
Fixed 3262547.

Recursively check items when going back/forward to ensure all
frame URLs are correct.

Added some logging to help diagnose back/forward problems.

Reviewed by John.

  • History.subproj/WebHistory.m: (-[WebHistory addItem:]):
  • Misc.subproj/WebKitLogging.h:
  • Misc.subproj/WebKitLogging.m:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _createItem:]): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _URLsMatchItem:]): (-[WebFrame _loadItem:withLoadType:]):
3:43 PM Changeset in webkit [4401] by sheridan
  • 3 edits in trunk

Safari-81u

3:09 PM Changeset in webkit [4400]
  • 3 copies
    1 delete in branches/Safari-80~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-80~1-branch'.

3:09 PM Changeset in webkit [4399]
  • 3 copies
    1 delete in tags/Safari-80~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-80~1-anchor'.

3:09 PM Changeset in webkit [4398]
  • 3 copies in tags/Safari-80

This commit was manufactured by cvs2svn to create tag 'Safari-80'.

3:09 PM Changeset in webkit [4397] by sheridan
  • 8 edits in trunk

Safari-80 version stamp

10:48 AM Changeset in webkit [4396] by kocienda
  • 4 edits in trunk/WebKit

Reviewed by Darin

Due to some header file changes in Foundation on Panther,
Tweaked some includes so that WebKit builds on Jaguar
and Panther.

  • Carbon.subproj/CarbonWindowFrame.m:
  • Plugins.subproj/WebNetscapePluginPackage.m:
  • Plugins.subproj/WebPluginPackage.m:

May 19, 2003:

8:47 PM Changeset in webkit [4395] by mjs
  • 10 edits in trunk

JavaScriptCore:

  • fixed 3261096 - Make WebKit an umbrella framework
  • JavaScriptCore.pbproj/project.pbxproj: In a B&I build, compile as a sub-umbrella of WebKit.

WebCore:

  • fixed 3261096 - Make WebKit an umbrella framework
  • WebCore.pbproj/project.pbxproj: In a B&I build, compile as a sub-umbrella of WebKit.

WebKit:

  • fixed 3261096 - Make WebKit an umbrella framework
  • WebKit.pbproj/project.pbxproj: Build WebKit as a public umbrella framework when doing a B&I build.

WebBrowser:

  • fixed 3261096 - Make WebKit an umbrella framework
  • WebBrowser.pbproj/project.pbxproj: Build with umbrella public WebKit when doing a B&I build.
2:29 PM Changeset in webkit [4394] by kocienda
  • 3 edits in trunk/WebKit

Reviewed by Darin

  • Panels.subproj/WebAuthenticationPanel.m: Now imports Foundation/NSURLCredential.h
  • WebCoreSupport.subproj/WebCookieAdapter.m: Now imports Foundation/NSHTTPCookie.h
1:10 PM Changeset in webkit [4393] by kocienda
  • 58 edits in trunk/WebKit

top level:

Reviewed by Darin

Changes to move from WebFoundation to Foundation

  • Makefile.am: Add some targets to check out and build Foundation.
  • configure.in: Add some more command line options to support building Foundation.
  • make-Foundation.sh.in: Added. Helper script to build Foundation.

Tests:

Reviewed by Darin

Changed imports to include headers from Foundation
instead of WebFoundation.

Removed WebFoundation.framework as a dependency in
the project files.

Updated some test files to use Foundation-related names
instead of WebFoundation-related names.

No longer build WebFoundation-CacheLoader subdirectory.
This test has not worked in a very long time. No need
to keep up the ruse as long as the test does not work.

  • PDFViewer/DocumentController.m:
  • PDFViewer/PDFViewer.pbproj/project.pbxproj:
  • SimpleViewer/DocumentController.m:
  • SimpleViewer/SimpleViewer.pbproj/project.pbxproj:
  • SnippetEditor/SnippetController.m:
  • SnippetEditor/SnippetEditor.pbproj/project.pbxproj:
  • WebFoundation-CacheLoader/NeverExpiresTest.m: (-[NeverExpiresTest setUp]):
  • WebFoundation-Misc/Makefile.am:

WebKit:

Reviewed by Darin

Changed imports to include headers from Foundation
instead of WebFoundation.

Removed WebFoundation.framework as a dependency in
the project file.

  • History.subproj/WebHistory.m:
  • History.subproj/WebHistoryItem.m:
  • History.subproj/WebHistoryPrivate.m:
  • History.subproj/WebURLsWithTitles.m:
  • Misc.subproj/WebDownload.h:
  • Misc.subproj/WebDownload.m:
  • Misc.subproj/WebFileDatabase.m:
  • Misc.subproj/WebIconDatabase.m:
  • Misc.subproj/WebIconLoader.m:
  • Misc.subproj/WebKitErrors.m:
  • Misc.subproj/WebKitErrorsPrivate.h:
  • Misc.subproj/WebNSPasteboardExtras.m:
  • Misc.subproj/WebNSViewExtras.m:
  • Panels.subproj/WebAuthenticationPanel.h:
  • Panels.subproj/WebAuthenticationPanel.m:
  • Panels.subproj/WebPanelAuthenticationHandler.h:
  • Panels.subproj/WebPanelAuthenticationHandler.m:
  • Plugins.subproj/WebBaseNetscapePluginStream.m:
  • Plugins.subproj/WebBaseNetscapePluginView.m:
  • Plugins.subproj/WebNetscapePluginDocumentView.m:
  • Plugins.subproj/WebNetscapePluginEmbeddedView.m:
  • Plugins.subproj/WebNetscapePluginRepresentation.m:
  • Plugins.subproj/WebNetscapePluginStream.m:
  • Plugins.subproj/WebNullPluginView.m:
  • Plugins.subproj/WebPluginController.m:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebCoreSupport.subproj/WebCookieAdapter.m:
  • WebCoreSupport.subproj/WebImageRendererFactory.m:
  • WebCoreSupport.subproj/WebSubresourceClient.m:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebBaseResourceHandleDelegate.m:
  • WebView.subproj/WebDataProtocol.h:
  • WebView.subproj/WebDataProtocol.m:
  • WebView.subproj/WebDataSource.m:
  • WebView.subproj/WebDataSourcePrivate.m:
  • WebView.subproj/WebDefaultContextMenuDelegate.m:
  • WebView.subproj/WebDefaultFrameLoadDelegate.m:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebDefaultResourceLoadDelegate.m:
  • WebView.subproj/WebDefaultUIDelegate.m:
  • WebView.subproj/WebFrame.m:
  • WebView.subproj/WebFramePrivate.m:
  • WebView.subproj/WebFrameView.m:
  • WebView.subproj/WebFrameViewPrivate.m:
  • WebView.subproj/WebHTMLRepresentation.m:
  • WebView.subproj/WebHTMLViewPrivate.m:
  • WebView.subproj/WebImageRepresentation.m:
  • WebView.subproj/WebMainResourceClient.m:
  • WebView.subproj/WebPreferences.m:
  • WebView.subproj/WebTextRepresentation.m:
  • WebView.subproj/WebTextView.m:
  • WebView.subproj/WebUIDelegate.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.m:

WebBrowser:

Reviewed by Darin

Changed imports to include headers from Foundation
instead of WebFoundation.

Removed WebFoundation.framework as a dependency in
the project file.

  • AppController.m:
  • BookmarkSource.m:
  • BookmarksViewController.m:
  • BrowserDocument.h:
  • BrowserDocument.m:
  • BrowserDocumentController.m:
  • BrowserNSBundleExtras.m:
  • BrowserNSErrorExtras.h:
  • BrowserNSErrorExtras.m:
  • BrowserNSNetServiceExtras.m:
  • BrowserNSStringExtras.m:
  • BrowserNSURLExtras.m:
  • BrowserWebBookmarkExtras.m:
  • BrowserWebController.m:
  • BrowserWindowController.m:
  • BugReportController.m:
  • ContextMenuHandler.m:
  • Debug/CacheController.m:
  • Debug/DebugUtilities.m:
  • Debug/SnippetController.m:
  • DownloadMonitor.m:
  • DownloadProgressEntry.m:
  • DownloadRow.m:
  • FormCompletionController.m:
  • FrameProgressEntry.m:
  • GlobalHistory.m:
  • GoogleSearchChannel.m:
  • HTMLSourceDocument.m:
  • LoadProgressMonitor.m:
  • LocationChangeError.m:
  • LocationChangeHandler.m:
  • LocationFieldEditor.m:
  • NewBookmarksController.m:
  • Preferences.subproj/AcceptedCookies.m:
  • Preferences.subproj/AdvancedPreferences.m:
  • Preferences.subproj/DefaultBrowserController.m:
  • Preferences.subproj/PasswordsEditor.m:
  • Preferences.subproj/SecurityPreferences.m:
  • Preferences.subproj/WBPreferences.m:
  • RendezvousController.m:
  • ResourceProgressEntry.m:
  • SlidingAnimation.m:
  • SpinningProgressIndicator.m:
  • TabBarView.m:
  • Test/PageLoadTestController.m:
  • Test/PageLoadTestRunner.m:
  • TitleBarButton.m:
  • URLCompletionController.m:
  • WebBookmarkImporter.m:
  • WebBookmarkLeaf.m:
  • main.m:
11:55 AM Changeset in webkit [4392] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Darin

Fixed build problem with declaring MIMEType as a category
on NSObject. This method needs to be typed to return NSString.

  • kwq/KWQLoader.mm
Note: See TracTimeline for information about the timeline view.