Timeline
May 30, 2003:
- 7:04 PM Changeset in webkit [4460] by
-
- 3 edits in trunk/WebCore
Reviewed by Chris.
- fixed 3169067 - PEOPLESOFT: left frame missing; frame RenderRoot height and width are both zero
- khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
- 6:54 PM Changeset in webkit [4459] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken.
- fixed 3273544 - REGRESSION: Page disappears at http://www.urban-advantage.com/
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::getElementById): Return null when the ID is the empty string. Otherwise we'll return the first element in the document, usually the top-level HTML element, which is wrong and does not match other browsers.
- 5:37 PM Changeset in webkit [4458] by
-
- 11 edits in trunk
WebKit:
Fixed 3272516. Items are now expired from the
b/f cache if they are older than 30 minutes. This
number was pulled out of our #!$es. Also did
some cleanup of the b/f cache code.
Reviewed by Ken.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge saveDocumentToPageCache:]):
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _createPageCacheForItem:]): (-[WebFrame _setState:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
- WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences _resourceTimedLayoutEnabled]): (-[WebPreferences _backForwardCacheExpirationInterval]):
- WebView.subproj/WebPreferencesPrivate.h:
- WebView.subproj/WebView.h:
- WebView.subproj/WebPreferences.h: Cleaned up some headerdoc comments.
WebCore:
As part of some cleanup when fixing 3272516 changed use of
@"" for cache keys to NSString declarations.
Reviewed by Ken.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
- 4:21 PM Changeset in webkit [4457] by
-
- 6 edits in trunk/WebCore
Fix for 3269129 and 3269220. setAttribute('value') didn't work
for inputs. Basically defaultValue and defaultChecked have never
worked. This patch fixes the problem by making sure that for both
value and checked you have a two-tier system where you look first
for the value as altered by the control (or by setting the DOM
property) and if that isn't set then you look at the default value.
This allows setAttribute (which changes the *default*) to work in
the cases where the control has not overridden the default
with a different value.
Reviewed by NOBODY (OOPS!).
- khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::HTMLInputElementImpl): (HTMLInputElementImpl::state): (HTMLInputElementImpl::parseAttribute): (HTMLInputElementImpl::attach): (HTMLInputElementImpl::reset): (HTMLInputElementImpl::setChecked): (HTMLInputElementImpl::value): (HTMLInputElementImpl::setValue): (HTMLInputElementImpl::isCheckedRadioButtonForDocument):
- khtml/html/html_formimpl.h:
- khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): (RenderLineEdit::calcMinMaxWidth): (RenderLineEdit::updateFromElement): (RenderLineEdit::slotTextChanged):
- khtml/rendering/render_form.h:
- 4:08 PM Changeset in webkit [4456] by
-
- 4 edits in trunk/WebCore
Reviewed by John.
- added "sjis" as a synonym for "Shift_JIS"; this might fix 3235161, HOMEPAGE: Publishing page with Japanese characters w/ Safari generates an error, but I am currently unable to test the fix.
- kwq/mac-encodings.txt: Added sjis to the Shift_JIS line.
- kwq/KWQCharsetData.c: Regenerated.
- 10:41 AM Changeset in webkit [4455] by
-
- 4 edits in trunk/WebCore
Fix for 3263156, stack overflow at www.liceo.edu.mx. This
site nests about 500 bold tags, only closes some of them,
and then opens 500 more, etc.
The fix for this problem is to stop honoring tags in the parser
after you see 20 identical tags. We do this only for fontstyle HTML
tags.
Reviewed by john/darin
- khtml/html/htmlparser.cpp: (KHTMLParser::getElement): (KHTMLParser::allowNestedRedundantTag):
- khtml/html/htmlparser.h:
- 10:23 AM Changeset in webkit [4454] by
-
- 3 edits in trunk/WebCore
WebCore:
Reviewed by Chris
- khtml/rendering/break_lines.cpp: Removed #ifdef/#else for which the two sides were identical that I noticed in passing.
WebBrowser:
- fixed 3273444 -- Window title leaks when window is closed
Reviewed by Chris
- BrowserWindow.m: (-[BrowserWindow dealloc]): release _title here, because there's a leftover retain from the last setTitle to enable our delay-title-change-for-performance hack.
May 29, 2003:
- 7:55 PM Changeset in webkit [4453] by
-
- 3 edits in trunk/WebCore
Reviewed by Richard.
- fixed 3270373 - MALLORY: repro crash in +[KWQObjectTimerTarget stopDeferringTimers] while changing folder
- kwq/KWQObject.mm: (QObject::killTimer): Remove the timer from the deferred list too - clients expect that a timer will never be delivered after the object was killed. (QObject::killTimers): Use killTimer on each timer for this object instead of trying to be tricky. (-[KWQObjectTimerTarget timerFired]): Don't add a timer to the deferred list more than once, because there's no benefit in ganging up multiple firings while deferred, and it makes other things simpler. (+[KWQObjectTimerTarget stopDeferringTimers]): Make sure to remove the timer before firing it, since it may also cancel itself, and we don't want to remove an extra timer in that case.
- 6:55 PM Changeset in webkit [4452] by
-
- 18 edits in trunk
WebKit:
* Public API change *
This API addition will be used (in some fashion) for Scott's WWDC
demo.
Implemented 'estimatedProgress' method on WebView. This should
eventually replace the broken algorithm on WebBrowser. Maybe
for panther.
Reviewed by Chris.
- WebKit.exp:
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading:]):
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): (-[WebFrame _numPendingOrLoadingRequests:]):
- WebView.subproj/WebView.h:
- WebView.subproj/WebView.m: (-[WebView estimatedProgress]):
- WebView.subproj/WebViewPrivate.h:
- WebView.subproj/WebViewPrivate.m: (-[WebViewPrivate dealloc]): (-[WebView _isPerformingProgrammaticFocus]): (-[WebView _progressStarted]): (-[WebView _progressCompleted]): (-[WebView _incrementProgressForConnection:data:]): (-[WebView _completeProgressForConnection:]):
Code cleanup. Moved variable initialization into block that
check for non-nil self.
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]):
WebCore:
Support for the 'estimatedProgress' method on
WebView. Added bridge access to the number of pending or still
loading requests (from KHTML's perspective). This is used to
more accurately guess at the total remaining bytes to load.
Reviewed by Chris.
- kwq/KWQLoader.h:
- kwq/KWQLoader.mm: (KWQServeRequest): (KWQNumberOfPendingOrLoadingRequests):
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge numPendingOrLoadingRequests]):
- 5:59 PM Changeset in webkit [4451] by
-
- 2 edits in trunk/WebKit
Fixed 3272226. The shared image factory was being released
when any renderer had 0 reps!
Reviewed by John.
- WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]):
- 3:54 PM Changeset in webkit [4450] by
-
- 3 edits in trunk/WebKit
WebKit:
Fixed: 3151216 - Safari crashes on Drag&Drop if plugin dialog is open
Reviewed by rjw.
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragOperationForDraggingInfo:]): return NSDragOperationNone is the app has a modal window so the current page can't be changed with a drag
- WebView.subproj/WebView.m: (-[WebView draggingEntered:]): return _web_dragOperationForDraggingInfo
WebBrowser:
Fixed: 3151216 - Safari crashes on Drag&Drop if plugin dialog is open
Reviewed by rjw.
- BrowserApplication.m: (-[BrowserApplication beginModalSessionForWindow:]): disable dragging app-wide (-[BrowserApplication endModalSession:]): renable dragging app-wide
- 3:44 PM Changeset in webkit [4449] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej
Fix for this bug:
<rdar://problem/3271697>: Search fails at travel site
- khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::parseAttribute): Allow form method to be set to GET from javascript.
- 3:42 PM Changeset in webkit [4448] by
-
- 2 edits in trunk/WebKit
Fixed: 3273109 - leak from functionPointerForTVector in -[WebNetscapePluginPackage load]
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): free the main function after using it
- 3:37 PM Changeset in webkit [4447] by
-
- 2 edits in trunk/WebKit
Fixed 3273115. Always use pixel dimensions,
not absolute dimensions.
Reviewed by Ken.
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]):
- 1:00 PM Changeset in webkit [4446] by
-
- 2 edits in trunk/WebKit
Fix 3272292. Ensure that loadStatus is always
initialized to NSImageRepLoadStatusUnknownType.
Reviewed by Chris.
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithMIMEType:]): (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]):
- 12:09 PM Changeset in webkit [4445] by
-
- 3 edits in trunk/WebCore
- fixed MIME type leaks that were most of 3272566 (several leaks after visiting amazon.com and emptying cache)
Reviewed by Darin
- kwq/KWQPixmap.mm: (QPixmap::QPixmap): (QPixmap::operator=): fixed two leaks of MIME string
- 8:59 AM Changeset in webkit [4444] by
-
- 5 edits in trunk/WebCore
Reviewed by John.
- fixed 3269564 -- dynamically-created forms look right, but don't post values when submitted
- khtml/html/html_formimpl.h: Remove useless virtual setParent function. Since the inherited setParent is not virtual, it does no good to make the subclass override it with a virtual function.
- khtml/html/html_formimpl.cpp: Remove useless virtual setParent. (HTMLGenericFormElementImpl::attach): Add code here, cribbed from setParent, to add a new form element to the form it's in. (HTMLButtonElementImpl::attach): A copy of the code is also needed here.
- WebCore.pbproj/project.pbxproj: Let Project Builder be Project Builder.
- 8:57 AM Changeset in webkit [4443] by
-
- 5 edits in trunk/WebKit
Reviewed by Richard
Fix for this bug:
Radar 3260323 (Some links at nike.com cause assertion failure
(connectionDidFinishLoading sent after cancel))
Added a flag which is set when a load is cancelled. This flag prevents
bad behvior when loads that finish cause the load itself to be
cancelled (which could happen with a javascript that changes the
window location). This is used to prevent both the body of
cancelWithError: and the body of connectionDidFinishLoading: running
for a single delegate. Cancelling wins.
- WebView.subproj/WebBaseResourceHandleDelegate.h:
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connectionDidFinishLoading:]): (-[WebBaseResourceHandleDelegate cancelWithError:]):
May 28, 2003:
- 4:53 PM Changeset in webkit [4442] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
- fixed 3263157 - REGRESSION: tabbing into a secure password field shows contents
- kwq/KWQTextField.mm: (-[KWQSecureTextField textDidEndEditing:]): Make sure to restore bullet mode if we accidentally lose it.
- 1:52 PM Changeset in webkit [4441] by
-
- 2 edits in trunk/WebKit
Fixed: 3270576 - RealPlayer plug-in fails to load
Reviewed by darin.
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage launchRealPlayer]): new (-[WebNetscapePluginPackage load]): call launchRealPlayer to regenerate its broken plist file
- 1:47 PM Changeset in webkit [4440] by
-
- 4 edits in trunk/WebKit
Fixed 3165631 (and other similar).
Fixed 3262592.
We now set NSImage's cache mode to NSImageCacheNever during
progressive loads. It gets reset to NSImageCacheDefault when
loads complete.
If an image is scaled, NSImage appears to create a NSCacheImageRep
with the wrong size during progessive image loading. Specifically
it appears to create a cached rep with the original size.
Reviewed by Chris.
- WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):
- WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]):
- WebView.subproj/WebPreferences.h: Updated headerdoc comments.
- 10:38 AM Changeset in webkit [4439] by
-
- 2 edits in trunk/WebKit
WebKit:
Fixed: 3233442 - Crash in -[WebNetscapePluginPackage load] at http://www.adultswim.com/
Reviewed by mjs.
- Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): don't call NPP_Shutdown if the plug-in fails to load
WebBrowser:
Fixed: 3271123 - "Plug-in not supported" error when Real fails to load
Reviewed by john.
- LoadProgressMonitor.m: (-[LoadProgressMonitor webView:plugInFailedWithError:dataSource:]): only show the "plug-in not supported" dialog for WMP
May 27, 2003:
- 5:20 PM Changeset in webkit [4438] by
-
- 5 edits in trunk/WebKit
WebKit:
Don't load and save icons if the icon DB directory default is not set.
Reviewed by darin.
- Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): don't create the DB if the default is not set (-[WebIconDatabase _loadIconDictionaries]): don't load the dictionaries if the DB doesn't exist (-[WebIconDatabase _updateFileDatabase]): don't update the DB if it doesn't exist
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): don't load icons if the icon DB directory default is not set
WebBrowser:
Moved the icon DB to ~/Library/Safari/Icons
Reviewed by darin.
- AppController.m: (+[AppController initialize]): move the icon DB (+[AppController _settingsDirectoryPath]): made this a class method (-[AppController settingsDirectoryPath]): call the class method
- 4:22 PM Changeset in webkit [4437] by
-
- 3 edits in trunk/WebCore
Rolled in fix from Safari-80~1-branch
2003-05-27 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- WebKit.pbproj/project.pbxproj: Removed no longer needed and harmful flag.
- 4:22 PM Changeset in webkit [4436] by
-
- 2 edits in trunk/WebKit
Rolled in fix from Safari-80~1-branch
2003-05-27 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin.
- WebKit.pbproj/project.pbxproj: Removed no longer needed and harmful flag.
- 4:12 PM Changeset in webkit [4435]
-
- 3 copies2 deletes in tags/WebKit-80~1
This commit was manufactured by cvs2svn to create tag 'WebKit-80~1'.
- 4:12 PM Changeset in webkit [4434] by
-
- 2 edits in branches/Safari-80~1-branch/WebKit
Reviewed by Darin.
- WebKit.pbproj/project.pbxproj: Updated version to 80.1.
- 4:12 PM Changeset in webkit [4433]
-
- 6 copies2 deletes in tags/WebCore-80~1
This commit was manufactured by cvs2svn to create tag 'WebCore-80~1'.
- 4:12 PM Changeset in webkit [4432] by
-
- 3 edits in branches/Safari-80~1-branch/WebCore
Reviewed by Darin.
- WebCore.pbproj/project.pbxproj: Updated version to 80.1.
- 4:11 PM Changeset in webkit [4431] by
-
- 3 edits in branches/Safari-80~1-branch/WebCore
Reviewed by Darin.
- WebCore.pbproj/project.pbxproj: Removed no longer needed and harmful flag.
- 4:09 PM Changeset in webkit [4430] by
-
- 2 edits in branches/Safari-80~1-branch/WebKit
Reviewed by Darin.
- WebKit.pbproj/project.pbxproj: Removed no longer needed and harmful flag.
- 3:03 PM Changeset in webkit [4429] by
-
- 2 edits in trunk/WebKit
Fix for IB.
Reviewed by Eric Seymour.
- WebView.subproj/WebPreferences.m: (-[WebPreferences initWithIdentifier:]): Added retain to uniqued instance. (As we did recently for initWithCoder:).
- 2:50 PM Changeset in webkit [4428] by
-
- 2 edits in trunk/WebKit
Fixed: 3270013 - Exception raised when visiting http://www.shutterfly.com/favicon.ico
Reviewed by john.
- WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithBytes:length:MIMEType:]): return nil if the image has no representations
- 1:50 PM Changeset in webkit [4427] by
-
- 2 edits in trunk/WebKit
Fixed: 3242864 - repro assertion failure in WebIconDatabase.m for www.shutterfly.com
Reviewed by john.
- Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): don't set the icon on the DB if it has no representations
- 1:04 PM Changeset in webkit [4426] by
-
- 4 edits in trunk/WebCore
Fix for 3268589, static position miscomputed when the positioned object is the last item in its enclosing block and when its previous sibling is a text run that ends in a space. In this case we need to clear our trailingSpaceObject so that we don't mistakenly ignore the positioned object when building up bidi runs.
Fix for 3260053, table-layout of inherit not supported. This
caused a crash. The fix is to just add in the support for the inherit
value to the style selector.
Reviewed by john
- khtml/rendering/bidi.cpp:
- khtml/css/cssstyleselector.cpp
- 11:34 AM Changeset in webkit [4425] by
-
- 3 edits in trunk/WebKit
Fixes for IB.
Reviewed by Eric Seymour.
- WebView.subproj/WebPreferences.m: (-[WebPreferences initWithCoder:]): Added retain to uniqued instance
- WebView.subproj/WebView.m: (-[WebView initWithCoder:]): (-[WebView setPreferences:]): Added release check to global uniquing dictionary.
